From nobody Wed Oct 8 21:36:50 2025 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11013006.outbound.protection.outlook.com [40.107.162.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D86A0280318; Tue, 24 Jun 2025 10:13:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.162.6 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750760011; cv=fail; b=b777ojNiPyLk+9/QDQF+6+t51CLyEUMY2e5F57u/tq8qonnfs0jyPQ9kagyOoaE+REs/hUnrdeP7u440H7TCmtjC+EkoP4AgwE/hYP+c/xlOEdZQnE+U6P0imSkY6MyMLVWKCbFW9HT98OUaj+GnGjZudup8OGIf/8qExhio3b0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750760011; c=relaxed/simple; bh=OLaWNEF8aHYU8Y/vsqsq0wZ8g5uImD65iR2axgNxypM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=rtnX2nFRcIGjSmyJDoXisL+GYybDf9oZ45KkLqjr3hyCiRjb/J4PNZxQxKVDGqnUYQ14rvYfEzpMLvVpJzty+PrcxbzmXiaaNxbLzxcYQIa86SR6bhklaI0IFOwpLTUDF5HY9EX4bbjOB+nLBGGc97+QIhkq6wM+V2vsZ1i8/QQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=QYy5qQa7; arc=fail smtp.client-ip=40.107.162.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="QYy5qQa7" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xo9YC0sqN7NlqyjfvdrKG9t/umGGFHxybW2Jvniy74WKf2nghM4pHU9ORITWjXVP5PYYLV6DXYTTJKpW9nWGRswhGsRH/lRrkIn/xuLUd/ZvEAivrC8fuy1KGvFgWOCVFv7KOBpssfqrxLMp3qdH+uQr+NRGdIBhqPy5vNubrqnLVCIzAvTHBXz+LdgU3dxCnav+ZrcszXjTJrpSl5GxulTnsGZlDWkx+u3hoe+/Mckp/AAYCfuG97rRXnHZsI6gEKqRCI3+zHv0nFiiU/MOeHiis9mrz7dMRki8ZAcmHpCM5Guj1G6ymplN6NpFeVDqmJ6o13DSuiiTcZ4w7diwkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YNpZh/TqCUvihnWB8zQ7g6ptHgFiCP21Z8Pv2hLiv2s=; b=gpFjAtWYb82hc7e3xG0fScTGRJOzo1KJFEiqK4s0KFmO5D8Gt3qpMwldyIzjBJIkoiedjZ5j8O/76SdBSwEZZM1VX6iRVhm2dJr5fiP13ppqNPt11HpePVAAiTLpeVGgfm78oyZJcYwjsCEgQNd8wQdaYsXY51CBKGX5fUEl5zmHTvtHxN750MgzhhkogRA+BjsZ9tHKjRxAKHQA6lafKYA+konzxyq16HC237C6KPScqpOpOnlHiRJ8UIJ2aOkHtmSwq40Xxiy4hfUcjPRwtzr17T1ghsmy327XZwOtWmFcUng9Y4t4q6tZGITdbYTNP+5yiTb6LS3pWSeS2YyYPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YNpZh/TqCUvihnWB8zQ7g6ptHgFiCP21Z8Pv2hLiv2s=; b=QYy5qQa7hD3xgMYUOn5QK7kuxZum1/60CnWXbhxO03KjAPWVdyYGJ6Ip7S6klMsZDrntBzHPv+uRzoYP/FPtZe41jMNaO0xUh0HGNwWz4zDuJf4iuGy+k5oJT+dcyEmJPCmk2EqUBd7dEVcY2pyJuwn/pfED9S4gPzvmwP4/o5iiAWDbZHu6bgoNJJ3CN/WHQ+NT+GEijqFzdvbwnnEB1m6Je20aW3iuOKyV4y7IRemSYtZ/YVVXmq8wlD5wgrLkZCWBOPEDqNAI4X4DIkQADweb8Tavj5z8+4qWPl3q8DJEPt0aHHstnaqZpZvehPPNE/9ENNarqJIOB/cdTVUDAQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8510.eurprd04.prod.outlook.com (2603:10a6:102:211::7) by AM9PR04MB8636.eurprd04.prod.outlook.com (2603:10a6:20b:43f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.28; Tue, 24 Jun 2025 10:13:28 +0000 Received: from PAXPR04MB8510.eurprd04.prod.outlook.com ([fe80::a7c2:e2fa:8e04:40db]) by PAXPR04MB8510.eurprd04.prod.outlook.com ([fe80::a7c2:e2fa:8e04:40db%5]) with mapi id 15.20.8857.026; Tue, 24 Jun 2025 10:13:28 +0000 From: Wei Fang To: claudiu.manoil@nxp.com, vladimir.oltean@nxp.com, xiaoning.wang@nxp.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev Subject: [PATCH v2 net-next 1/3] net: enetc: change the statistics of ring to unsigned long type Date: Tue, 24 Jun 2025 18:15:46 +0800 Message-Id: <20250624101548.2669522-2-wei.fang@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250624101548.2669522-1-wei.fang@nxp.com> References: <20250624101548.2669522-1-wei.fang@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SG2P153CA0028.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c7::15) To PAXPR04MB8510.eurprd04.prod.outlook.com (2603:10a6:102:211::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8510:EE_|AM9PR04MB8636:EE_ X-MS-Office365-Filtering-Correlation-Id: f3d18308-f1fd-46ac-cafe-08ddb307c337 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|376014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?CORW6KITZikh+PZQR7Ukx0VoLYZMccv/9FXhz3ouf2gMakynBPz0Ccl53rhQ?= =?us-ascii?Q?YMtiTUn9QcYkxg6QBD2scESwsmLRA51EuuJ/E2kOY3pwRpIt/XiIjnATkxxC?= =?us-ascii?Q?8gOAEVVRada+DPfFN+SKLxcPsDb+JmXLV+N5ZaDo11GCpCucYJ9VNVWXY03W?= =?us-ascii?Q?xhBLwx4J7OF7WNUyOj2uN2XEypj7s6aktw16LbOMYQZWCMn+QsJH61xujMWM?= =?us-ascii?Q?E8ahR7/5HWqA3mc2nOWhWbDEJRm+4YL9DZ3ZsDk9QHbqoCIimmEWlS21oxPJ?= =?us-ascii?Q?D0/wNEmb2p/IoXkt3X7VvWDpbfPHeKiQp2HeCa+vlF9jeA/3i6oNb0n5dpkd?= =?us-ascii?Q?VGBlMV6jE/Yq5lFe4Bc8gCUn5gOOieYWwK9Oys2D/Q742JUw/Hy4xeA8zFWS?= =?us-ascii?Q?bIvloYqqZTV6/JNadTvdZheYePX0tAITPLhaWsUSlAZxxcsDF0G36tylrWKC?= =?us-ascii?Q?rUQk2/8C+qiV7+lKGgrkUCEvlhqiUMvxvWmyoEuWIumf5AyPqYyhdDU2zg2j?= =?us-ascii?Q?I4yBzUStWGqn7CzOMptGljuhj4BYRDffLQW3TQ+vMLrfcWMle+jCpaPjSHDL?= =?us-ascii?Q?fXbtnbD6qcR/xoZbpdHc1q1vLAnlwQOoVsJR5wODkEuVGFxe4YUBwICo04dy?= =?us-ascii?Q?DEOIQTqsgE1lXz+IbMkKWU2QDa/ivwVBIF6rsx7TrSTIYZbNf1pZhmLdAjqc?= =?us-ascii?Q?/woko7LiivRwKzNxzw8Wp1C5hK3wX35DsdGbWgKDJsfrRdOsKC2zudZOHwSf?= =?us-ascii?Q?vAXEms96VPHB6Q8xJeqGvVslELiwUvq4pXrZi/Pkec4TKJTkg0M9eLUEpOwh?= =?us-ascii?Q?S7n5svDHgHxnLVCuR/j04Nqi87cJ8W/mMQdV/Z2yfyoz2xy8NcjvGNhhSCef?= =?us-ascii?Q?0T9WFRSd6jUYiIMHIdwi9Y6VNUa0cJh9/1PnKxMtg8lISSAEHyTAEiNnJzsy?= =?us-ascii?Q?w4RxO4OFM3nZGJswP9RbVoiLGnwxSDABCM7kEPJTwbSkray3WKQXyQQPOAzF?= =?us-ascii?Q?LaQnmOh1oGKC7hwJqPDBpnwxWGBxjV9xMXv4d+HI/8dX3mXPcOWNzi7IzfdG?= =?us-ascii?Q?pFKiAw1s/TnNS66U7o/t3eLmFSmPgyAA5Dq4isHFAzqqEM3VerkrKdzs82SO?= =?us-ascii?Q?ZoyyB06ShBLOdIQITWxJ5obh2GrhB1rUZBXKWy0mSdXsHXdvLjcDpD1Sor3A?= =?us-ascii?Q?RNOgJhvzkGsp3lFa3YrT6xFjlWrrQpyM96YBvgthQXVXtFNWRJhTlvl4WFOK?= =?us-ascii?Q?HzEE6YUu0hf424KAmSGEPRd2vLUt12A+6h41Efx3WIfDrQX2bMDMb1Ytsl4c?= =?us-ascii?Q?zON7FTK+oN1KnV/1xa/8iRsJ+vcEcNpCziytx0ytnRuu9fNz8c3ua/cXZ61U?= =?us-ascii?Q?uwGAmR8g6AKa0+XBZ5X+ANY0yt+DObMiYlBvo8bbv7ZElbPAyeZfRlYAsX5E?= =?us-ascii?Q?XT8pSPqFsAxUkFODV8gzVAOvCP5MDudoIJf0pnNPVXAkfMQ24G4qqw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8510.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(376014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bgHnwFHBai4mPtiLPYaJqQTHjN9f49TO7lNC9I7K7dEERa7bteyhvYR4T1S4?= =?us-ascii?Q?QainZxswbZdSAv9nirwXY3UQ09/dX3I73hbJ0bMTa7gYqsB4bEWNyK7YWcea?= =?us-ascii?Q?XRvOZGbbi8uQBeMO1rErJdldtQOj60Di57hYkpBgrredkSRZ8dkjtlQXDdyc?= =?us-ascii?Q?DGUKyrW3WXvL+yhdXmKgp8IWIt3GEFqO623p5B/pAk/UOvutaLTE17Yrvrh5?= =?us-ascii?Q?uXajEMqRrrrymQVURDBBGnVs+2vqReTWIQG80Re/yPkyL4K6I0tGUTty+vUK?= =?us-ascii?Q?kB6nFOcFT4NY7pBySKz+wWIyETD+emrJjtPTFzFfkw75x2v0XCocRjrTZrxW?= =?us-ascii?Q?b4O+3alTgRIod2y1EbKAK2H9qIlGLkUj8Th2Gx8xaxrtdwkkLM/V2oU6nKvY?= =?us-ascii?Q?Q4y7d1zdlPso5Uigfu+8HrGYt52Nwfz9rKjPhG7NnNw2LYgXMAS9hE1DcqHJ?= =?us-ascii?Q?/mpdJL5HyZYVZI15Y7IUZwzBsvJibP9CZ8CD971qZXK5jsVGy5Rq2ObQ04OM?= =?us-ascii?Q?NQxxK9Ts9DMksl7ja1ZV77j/e74X+de/s00jHyE9DHTHT3LNMattPOowwJFr?= =?us-ascii?Q?4eVpi6fu1VX7B4e4aFYMSFpumOGyYK69htsQxKGgz6PomLL11Ofz2Nc6z18y?= =?us-ascii?Q?28EzgEfmXI00xzZ7ZKosccaqkgSOkMqH88NDI3RU2fCqrKDTykMaLI0uLaSW?= =?us-ascii?Q?af4XDnXDDz5W3EQpE8/2ic5lXwEa9d2K2YfFpFnyz8SrT4E2sjSbqMMxrf4k?= =?us-ascii?Q?UseGk1VGjxF6bDZs+x1CzKvI9L5wMRG+UUv+Wky5A2UkNxAYmJAcMYztyjWB?= =?us-ascii?Q?oFt3mw7EFLdvs0STCN6qmVAf0gNV8wV8ynlE4Wwl4YwNyz06ITV1nZFNbFx/?= =?us-ascii?Q?i0VM+Ism8o85sU/a+pv3/JdY80k3+uvM8qEb3VJJeABwK5WS5hTZ6gAksDnH?= =?us-ascii?Q?mKq8i1t5wuleu+29xlqGTphe85OtzcNs3b22C7eJ/b2rVrKNoNpf/hQCq9O0?= =?us-ascii?Q?JISpPFa25vZVUkOPhPjMr18xEXvhOE8qi7j63h761CT7KjQsnVHb49sdVVMB?= =?us-ascii?Q?KkdArEJv9/OCeD21gXTX/GeVQ1Vd4MsLC6bKz5urbxhMMNUMUqYt2dHLrDEf?= =?us-ascii?Q?98Eh82nqeCOGO981cTYgB5N/XoFmFkpOaWLaQEOPphFxXgPbuYkou6/VwlZN?= =?us-ascii?Q?Zdwx0uA9FAXvI+SghtYezhqq8/wguS7uizD4KtHwU1a4B29V5PakT91FAv44?= =?us-ascii?Q?5PDFPY9C871wyjO/rzbrfMJjg/R9GRMK4m55BBJVt1AmfaNhQiTEI53g0IqS?= =?us-ascii?Q?3BDMthuFJBhTshOFgxsWMCm8qjnHY9SSAw0QYZklyu1S7sLWVfcXP2gx9NVj?= =?us-ascii?Q?wHkfD3DVUx7+PyxR2Sr6nkseyk6sfk2MEmc73A2LvCSrqnJBER3VC778zrXI?= =?us-ascii?Q?6rp9yata3Cjf5WTnZ5WHYFyV7y9CAoE53mKW46VtS/dyFaJqJHWjwZ7h96tc?= =?us-ascii?Q?Q1QGRgQqGyocPBFcMtFkAvDU4FUZGmuNDs6uTjjtvF4RdW2Qru4hZreGKRUO?= =?us-ascii?Q?6v8J8rmqOo0IXqyS9IVOcTJkUI3bKxXD3H3qCt+u?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f3d18308-f1fd-46ac-cafe-08ddb307c337 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8510.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2025 10:13:28.0699 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SAL3G4umseat/ylUKEP9AByIXusarQc8uA1vgQ313dvolmr51ufB6YX1aX6v0KEV3q8FDMtX7MNZ3dQLrZXuvQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8636 Content-Type: text/plain; charset="utf-8" The statistics of the ring are all unsigned int type, so the statistics will overflow quickly under heavy traffic. In addition, the statistics of struct net_device_stats are obtained from struct enetc_ring_stats, but the statistics of net_device_stats are unsigned long type. So it is better to keep the statistics types consistent in these two structures. Considering these two factors, and the fact that both LS1028A and i.MX95 are arm64 architecture, the statistics of enetc_ring_stats are changed to unsigned long type. Note that unsigned int and unsigned long are the same thing on some systems, and on such systems there is no overflow advantage of one over the other. Signed-off-by: Wei Fang Reviewed-by: Claudiu Manoil Reviewed-by: Frank Li Reviewed-by: Simon Horman --- drivers/net/ethernet/freescale/enetc/enetc.h | 22 ++++++++++---------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/net/ethernet/freescale/enetc/enetc.h b/drivers/net/eth= ernet/freescale/enetc/enetc.h index 872d2cbd088b..62e8ee4d2f04 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc.h +++ b/drivers/net/ethernet/freescale/enetc/enetc.h @@ -96,17 +96,17 @@ struct enetc_rx_swbd { #define ENETC_TXBDS_MAX_NEEDED(x) ENETC_TXBDS_NEEDED((x) + 1) =20 struct enetc_ring_stats { - unsigned int packets; - unsigned int bytes; - unsigned int rx_alloc_errs; - unsigned int xdp_drops; - unsigned int xdp_tx; - unsigned int xdp_tx_drops; - unsigned int xdp_redirect; - unsigned int xdp_redirect_failures; - unsigned int recycles; - unsigned int recycle_failures; - unsigned int win_drop; + unsigned long packets; + unsigned long bytes; + unsigned long rx_alloc_errs; + unsigned long xdp_drops; + unsigned long xdp_tx; + unsigned long xdp_tx_drops; + unsigned long xdp_redirect; + unsigned long xdp_redirect_failures; + unsigned long recycles; + unsigned long recycle_failures; + unsigned long win_drop; }; =20 struct enetc_xdp_data { --=20 2.34.1 From nobody Wed Oct 8 21:36:50 2025 Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11011042.outbound.protection.outlook.com [52.101.65.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30504281370; Tue, 24 Jun 2025 10:13:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.65.42 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750760020; cv=fail; b=WchvEmZx19XING1siP8LyHYVhfLypRMDFdstrnFjprBCj5C4W0KVDhgJGrlayXHMxNxj6x3DcZr+X28y+/AXBtxwF+kdgJc+E9wApnyuaG1iGVk6aZglWzEZ1eb5hdnvHs1FVpIO48zlRyLNm2bI4tMH4NTnVd0g0pGZ/YcW5A8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750760020; c=relaxed/simple; bh=6i9u3vtIHgRFo+YVNUlXNCIaZL4p4lK1GC/5gof3HyI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=b+8IUPhdZxft/mZfdEr0UUKgS9oVh0xElP/pfDhdXNW1ye5WiR8G0CRFzxvadhm07yaHgt8cdF5+VZCZvhjCXx9KvpcgPAzBn3t4cfPLaBjVo5B1ruLjIY1ri3rI9XWZGMfQ8PixvhOTfDht7CTitf/BK+KY78ZNqpGHyPIwcSY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=UOPoHRf4; arc=fail smtp.client-ip=52.101.65.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="UOPoHRf4" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Oi3IcliqZLgr/MMjpjG1Wu1JVuC/mNSyxUECaoT2BHETM6GsY8T0qG0UyBO5VkwPzno2tAVMM3ApXMmb3x+iGVGEJiGZjZcKrCnnxzIC5Xcyu9wBCSuDdN9CnU3Q21ZPuc4Qo+0jJE97F5EjUlIGSAGvn8xT+f/2XSqUAefqh7IZHlN/Yp3J1AKZFP7SZNKByfSHlv7rd5OhUYgZqj1P+/76q6zc7CM6mPis2gRPu0RcJrSTtmtVdlXwBmYRyQ2ZNSTsvnlCJbtpkYu7Y4pUCeDsXpEPfcJRQXTlk34VpigA10aAINYB8ae9J3dwFFEgJ1rPG7CuUklntdwAyXPnHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UY5K6LoxnPY/kjt+a0+v/t+dqv728OtL3VGVTbiAakA=; b=TOFkD6NVjcKXOx6gjVpqXgH8PgPs66SHLd8wQoL/igShaxm0Ny6ub9l1e6w6A4b2YJzel8QQITT7GhN1n3JYUjiA7KzpDp8wC9cK8QyquwfUPOEU4y2U28RVFk4t1uQ6dZ/Y9R7q1WdK6resbNkDNCWmr/EGt/VeFuV3cPhSO5yEZy6BsM35SD+4hgtJE2u/STn0e+WtoCQyoUqrCsfYpxs/l8Wq8D1l1bg/ppSLYrqf/y97Usdt20G1vX/JtiBc1DgzWCm/vgF9vi1Dlc4XswGuJ4MJB+Av4SIwGGJS9kwCRPAZSHZkMqWru020dhy6vycVkpQJx79cfi1GPquQMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UY5K6LoxnPY/kjt+a0+v/t+dqv728OtL3VGVTbiAakA=; b=UOPoHRf4Iu/w5F7WVj40hyXN+ILDaecKrLok/+2PqftTWRHYGDEOM2lnpqa6toNHT41wJbxHbXnkYI22itowntAqxHiSEpmmYrUHJXXonQfpdIk72xDXOFA08FQCA7vy4PCGLBx3v0udLqa6TaidnpM9Brrm6mgmRYvpGJrhGx4bHUkj167suihF8UDh4VIDdGjfzKipMCLdVnfbTmqypvXtVeZm6CIZh4c7IElpLbWMmxWjyDWxzoRwVVJG1TX2Q0/ewuXPdV1qTI/PxGuPRfO3+XzuBHo5XhfNDbsLm4EXYu29CCTaKAAR1DBfQO7HbjvODisGukkK5rR05epIQw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8510.eurprd04.prod.outlook.com (2603:10a6:102:211::7) by AM9PR04MB8636.eurprd04.prod.outlook.com (2603:10a6:20b:43f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.28; Tue, 24 Jun 2025 10:13:33 +0000 Received: from PAXPR04MB8510.eurprd04.prod.outlook.com ([fe80::a7c2:e2fa:8e04:40db]) by PAXPR04MB8510.eurprd04.prod.outlook.com ([fe80::a7c2:e2fa:8e04:40db%5]) with mapi id 15.20.8857.026; Tue, 24 Jun 2025 10:13:33 +0000 From: Wei Fang To: claudiu.manoil@nxp.com, vladimir.oltean@nxp.com, xiaoning.wang@nxp.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev Subject: [PATCH v2 net-next 2/3] net: enetc: separate 64-bit counters from enetc_port_counters Date: Tue, 24 Jun 2025 18:15:47 +0800 Message-Id: <20250624101548.2669522-3-wei.fang@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250624101548.2669522-1-wei.fang@nxp.com> References: <20250624101548.2669522-1-wei.fang@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SG2P153CA0028.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c7::15) To PAXPR04MB8510.eurprd04.prod.outlook.com (2603:10a6:102:211::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8510:EE_|AM9PR04MB8636:EE_ X-MS-Office365-Filtering-Correlation-Id: 45716466-747d-4163-2cef-08ddb307c61d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|376014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?3MmjewKY0BGTAV1oxHOkt6Y1SBaQd5yj1T+s6d7KW1BChcpPJDRBGH7n1+uU?= =?us-ascii?Q?1vlRWuSc+iUGkbOGaxpC5yqgt/vqySqT+im6U+fnCKuiehoNQRAI3tn5DzsV?= =?us-ascii?Q?4rgN+UkJ0uSwfQGcKIzLgYfw0EOJsokny0IKfUq3gHPEVEfvdtIoNP3hSQzf?= =?us-ascii?Q?9PiUTZjcXw9ZoVdRcifc72f7mJUQMNX79JQv+TKL5ocYbyYvXAXTHd6wapL2?= =?us-ascii?Q?UhNHl6QaVVpb/YBtQoyDNIYAmNiTdzJNsYu8LBe0Bpy1+dwQNGlwQWauEAb0?= =?us-ascii?Q?fGMa7FXEg0DYkD/P6RRs2Bbi3Lfa0rY2ZMB8hG548FtXGSFKQf2DZviKGf7D?= =?us-ascii?Q?4waxIMyAw0hX6yDeVJ9AIwl/aldj9weeNeUKK/0dhcNJ7kHvmrlK8g0WVx+G?= =?us-ascii?Q?6LF6vO5vyx0nG07fyyM7eNZ7yBUb+4Qw/T53lL1lhWTY3Sm05FIQyIT/VsjB?= =?us-ascii?Q?J31jpne08joOsnqr14f41FeI9hldfjitK5l0p1CVsHpImW3IoxgH218GK/yI?= =?us-ascii?Q?ZvMCKosZOxQ/1cL8c0nmhLcFQxspgDd3eoeg2friR4N1EoI59L1khnprSKA6?= =?us-ascii?Q?NujIBV5B0XJxa/K6YoBSCB8wxqXCJ/BuBCOftK9Go8665pNVKt1fxAA3SPTo?= =?us-ascii?Q?hS17+zq72aT1Y7uQFlzCTPL2KbQJyDv/+2ode4FntJiQKtrofa/o/eP7CKh3?= =?us-ascii?Q?8yVuKbTFg8SofTH+wi+llRQ90/bqIVBcMYvXfnRnS2YOldOqofJodk0tqA5M?= =?us-ascii?Q?wwp3ukQQKoaiRnBgQzUnNubgZgFVXGNEJ+kUxy2/rkn/fpYloc8pxKdsvplJ?= =?us-ascii?Q?NdfLLNv+WPnctWS4WPy+6xzfDkcy+enjVti/BRwOGlYubg8D8UwK7HrvlzOp?= =?us-ascii?Q?IIh8zeFf+v++Mybe8YbEnLW+uwnZJlck0qjYHGzIXnbIp4m1C5lzSFc6EHOd?= =?us-ascii?Q?WY4WWUJ4l1wKff9RMQwIBnEVQxkvTmkY0Evxzuj1Kav0nqypnm4w6K1qwcWP?= =?us-ascii?Q?b+s5mtZjCRhnC48fs2rmzOjYnW1PB+5wYRVZ4W95Sa/bCxz7BiLlKc94kq1K?= =?us-ascii?Q?TEd/rQIFpe68Orh+mH9kluSZ/mYJC/wH8zpa5UXThxRWjyrFCaCkxGmn/bJx?= =?us-ascii?Q?uNowUaDdrkrl+sfAzw30dMMQIjBO+zEYdfz9Siv8/MkGmg9hfou55xqxQn28?= =?us-ascii?Q?shhMWKNW2rkRfksETRXt+BX808LGTWimwZhpAH+qxzCe9wOC3U5VbiLpGZI3?= =?us-ascii?Q?W5e0JkzdmRx++/DB8r+ctNFuYf1nMBZiHfGbzEnWp+3SD8gX4/cBtu4fyokm?= =?us-ascii?Q?88Ew4eZl95BkscUq3esC254mYQoJaxK5JvvcdOeD6denEYcFw2qzANksd3f1?= =?us-ascii?Q?ETaGgszN/+r2hjC3SYHD///FeN8c7lKQ4HWwPSGA5MbWU0ygWzYn+PRv4dbw?= =?us-ascii?Q?poENvNPZo963XL0uWAObm946h0ivkWBX5o2z3EeEY5RLCi/euPof+g=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8510.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(376014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+7Q8xI6xxaOlq1lwq9fCevBdm7oXUkOGrDkfAwE0Vu5W9uZOo4fcC+382Lwu?= =?us-ascii?Q?9PyiCIVxDTDw6DgFPSWp2SeEQxexaao8OCqdOoAFQI9k5e1ApEpgMbX5njZO?= =?us-ascii?Q?UJPNOwTmadYdf82ub9SHDI+939xARSDxUZkdq1Guyj7mgkc1tNceTACx0RzL?= =?us-ascii?Q?SFuGt3Ey5y4Eq7c45m4CsN2SzbuE45ooY+zN8PLDnmfpEWH9/kAuSuF87HdW?= =?us-ascii?Q?zOpfz+AW4Aq4pGE7/nIzr8EmhsgUbe+yXA7Cys01YBz/CUnaBaNtW9qxVxJX?= =?us-ascii?Q?8Pn9D5z1JP1I1UmtJdSz1hHjVU/FR8tiUFwba9bSgX7GW6LqNKColqXhR1Py?= =?us-ascii?Q?0Uu7nMDDaLR9YQMwkVeBSSvrM/2Ey1Iz6bBck61OdZw+0ORdvAZM3nEOkPMY?= =?us-ascii?Q?OvldCVmDmiE2OMv9MmG+WgTIIDsSRgaF7DWf2WqbwT+2C9NWAvVqNFO6PO+D?= =?us-ascii?Q?ohgyp51VjDgDiv6YuyGxaH0aTBUdyMHfcQj/cB97GeVoqIc5aT0QDToWd6Wm?= =?us-ascii?Q?UbCWh9t8ZW5goOZGLKoJfjKfEYi9NScIL4lFiF+Z+xtXNkYha3W6PtaCSPoz?= =?us-ascii?Q?sp0Fj7IAM+UHbGIact025zdgo73K3JNlgcEMhtPLwvkm7bq4oWalAAIMxHQO?= =?us-ascii?Q?LAY+O7pX25nhH4E5JQehs3dLChnM9WgIQV/mkw+RbPaIvKixFmkzqB6qrUNY?= =?us-ascii?Q?qBxAnEXzicmXLjdtuYyQhDstzdzetoHZH4aTrkrxbaQGCpi+mQYMmMVY3U3X?= =?us-ascii?Q?wK9mfN8KcSFLjWHqD862ako8K5ggv4jt4KIzdiqjzGCxf9a0EE0DaJyffxaT?= =?us-ascii?Q?dfS4rCTlzvVn7lQNfvid2jCjFPpL5K01HIYnrKvFFjYA2Tb/k/kao0GoBnBs?= =?us-ascii?Q?VEn2gffPb80+7Ml84Px+o2MyIcKA6Q4R4Uk/pzJHs9k8lKFCR7bb0kyv0e2r?= =?us-ascii?Q?a9WhoKjLxqzT7It7UlWOZ0SzfelcwRlZ4fOVk455VqlJITG3gkhixabf38SB?= =?us-ascii?Q?dqUtB6p1z0Absa6JUPiVwPElKgH0vgDzuPuF1ZRnBzXuAOfz4/WE5F+ZYhXe?= =?us-ascii?Q?TFxCSSiWfMHLG/Ks+I5OZ927z1+N923Z2IJnTRYlK/81Orv2Z/pffVdAtTlA?= =?us-ascii?Q?8eB9mrC0votFx3p4dyBEzy4Rbuuvq4wNdvdzQXGU15n7Z4ETnCAQ+rQIRmYc?= =?us-ascii?Q?dWvwKFt6bTMFIUYIz6eiqas5K1CqRAJpY8I5Xs4ZQIjvZdZy4dT6QuZ8rnC9?= =?us-ascii?Q?4EQZwQMrz/nJ1hz8m1MCXKwbvd5M9j+On1grRuip9vVoT8z5q+kSggyoGqaO?= =?us-ascii?Q?dJLZLWGzHL7Ys8mWGXgAUY5mr5bKsULMpffjvcc/YXxF1GL7rGpKGGAOXRrV?= =?us-ascii?Q?LqAlU32a31+IrNg/YKblnWkrqjtBQ9Qq0uD1n9qcuclHkJ4Kz7B3Nqqx+l7d?= =?us-ascii?Q?ZsvDiKNmEVqZtfAfk1Nsz9ufLmxudYpvmPBCAsIvkfWcZB2I6TrecIIY7Jls?= =?us-ascii?Q?SCEiaIU/Sx2ie+T5gXmdFMIhZn06PvXn33yo+GXz3RSttk8k1N/kQkkX8b22?= =?us-ascii?Q?le+ukIK5f6Z1LQPAvRzVoY97t+hFaXhsWWs+YAXJ?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 45716466-747d-4163-2cef-08ddb307c61d X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8510.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2025 10:13:33.5632 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0/yXtlxpDF7Dc1rdkVNJ6vyGNkdzPSGlK+kGELwEtKcKaXKVHTlXCkD28u53ocAFcmBhudHqDLx+oX+j2UhCDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8636 Content-Type: text/plain; charset="utf-8" Some counters in enetc_port_counters are 32-bit registers, and some are 64-bit registers. But in the current driver, they are all read through enetc_port_rd(), which can only read a 32-bit value. Therefore, separate 64-bit counters (enetc_pm_counters) from enetc_port_counters and use enetc_port_rd64() to read the 64-bit statistics. Signed-off-by: Wei Fang Reviewed-by: Claudiu Manoil Reviewed-by: Frank Li Reviewed-by: Simon Horman --- .../net/ethernet/freescale/enetc/enetc_ethtool.c | 15 ++++++++++++++- drivers/net/ethernet/freescale/enetc/enetc_hw.h | 1 + 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c b/drivers= /net/ethernet/freescale/enetc/enetc_ethtool.c index 2e5cef646741..2c9aa94c8e3d 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c +++ b/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c @@ -142,7 +142,7 @@ static const struct { static const struct { int reg; char name[ETH_GSTRING_LEN] __nonstring; -} enetc_port_counters[] =3D { +} enetc_pm_counters[] =3D { { ENETC_PM_REOCT(0), "MAC rx ethernet octets" }, { ENETC_PM_RALN(0), "MAC rx alignment errors" }, { ENETC_PM_RXPF(0), "MAC rx valid pause frames" }, @@ -194,6 +194,12 @@ static const struct { { ENETC_PM_TSCOL(0), "MAC tx single collisions" }, { ENETC_PM_TLCOL(0), "MAC tx late collisions" }, { ENETC_PM_TECOL(0), "MAC tx excessive collisions" }, +}; + +static const struct { + int reg; + char name[ETH_GSTRING_LEN] __nonstring; +} enetc_port_counters[] =3D { { ENETC_UFDMF, "SI MAC nomatch u-cast discards" }, { ENETC_MFDMF, "SI MAC nomatch m-cast discards" }, { ENETC_PBFDSIR, "SI MAC nomatch b-cast discards" }, @@ -240,6 +246,7 @@ static int enetc_get_sset_count(struct net_device *ndev= , int sset) return len; =20 len +=3D ARRAY_SIZE(enetc_port_counters); + len +=3D ARRAY_SIZE(enetc_pm_counters); =20 return len; } @@ -266,6 +273,9 @@ static void enetc_get_strings(struct net_device *ndev, = u32 stringset, u8 *data) for (i =3D 0; i < ARRAY_SIZE(enetc_port_counters); i++) ethtool_cpy(&data, enetc_port_counters[i].name); =20 + for (i =3D 0; i < ARRAY_SIZE(enetc_pm_counters); i++) + ethtool_cpy(&data, enetc_pm_counters[i].name); + break; } } @@ -302,6 +312,9 @@ static void enetc_get_ethtool_stats(struct net_device *= ndev, =20 for (i =3D 0; i < ARRAY_SIZE(enetc_port_counters); i++) data[o++] =3D enetc_port_rd(hw, enetc_port_counters[i].reg); + + for (i =3D 0; i < ARRAY_SIZE(enetc_pm_counters); i++) + data[o++] =3D enetc_port_rd64(hw, enetc_pm_counters[i].reg); } =20 static void enetc_pause_stats(struct enetc_hw *hw, int mac, diff --git a/drivers/net/ethernet/freescale/enetc/enetc_hw.h b/drivers/net/= ethernet/freescale/enetc/enetc_hw.h index cb26f185f52f..d4bbb07199c5 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc_hw.h +++ b/drivers/net/ethernet/freescale/enetc/enetc_hw.h @@ -536,6 +536,7 @@ static inline u64 _enetc_rd_reg64_wa(void __iomem *reg) /* port register accessors - PF only */ #define enetc_port_rd(hw, off) enetc_rd_reg((hw)->port + (off)) #define enetc_port_wr(hw, off, val) enetc_wr_reg((hw)->port + (off), val) +#define enetc_port_rd64(hw, off) _enetc_rd_reg64_wa((hw)->port + (off)) #define enetc_port_rd_mdio(hw, off) _enetc_rd_mdio_reg_wa((hw)->port + (of= f)) #define enetc_port_wr_mdio(hw, off, val) _enetc_wr_mdio_reg_wa(\ (hw)->port + (off), val) --=20 2.34.1 From nobody Wed Oct 8 21:36:50 2025 Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11011042.outbound.protection.outlook.com [52.101.65.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A972D2857CD; Tue, 24 Jun 2025 10:13:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.65.42 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750760022; cv=fail; b=rttZJLYW1AVSybZTPRmRtCtAy2PHdIudkqAyXRG9tiY0N519EXXxsmCtBnKVIxKYpjntYvuZ7mzT+ayJIr/vPcTIL6Yt21v4Jt5t8vBG2WO4bdTqw5t2od9pq7lz/Kot58ryrV5oJ5qInHAvbqf7S7RNeXiPh63cbctDZNg2hDo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750760022; c=relaxed/simple; bh=lhG840XTLg3bH5glJXZT4Q6vDuwpdyybshaAF3T3/X8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=ERNQT+aLMj0XLoDLhCYfxXwVU0WMltVLrdPXXlH2HmtdaoUu9UluMDzkp+aIC7uaGffPuyhc+ub245V01jG/fSbkgdUrhZ34eC3NES2D8fDYzQ45ubSy1+2+sWLCdhTrrOgSnyLBlU5pQbnkcfb//dJbhx1i3b4UzHi5jioirZo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=NC97q17n; arc=fail smtp.client-ip=52.101.65.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="NC97q17n" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=E7tHb3gtXPjNIGVTqjvUg7fhTr/ZStsfLsykuEgqoserimreVXPMkFGRFp5CAoODmE2tLKth8eCGo0QaeMaHtiBHwSH9ggPZmcyKgPYbnkRC53AeL3Cf1zZb3jqlmEUvHT7Sc08WUeviYiIzLrVOoKU+mUsjljzz/uwuvMzO1YwQ56DdTcv3f8KoudZe5e7iDde1oa0AhQ+8Pd4DtaZsFJao9lPbil7dnLK4wLrDIi+nZhXUKxjqNxPUn8BYATjmubUEwiMcRhALrZH+9XXccjB4NZJZw1G78vul0NESwswTttzYXwIDDZVqJuRu5BER+Xz04c6nui32gjgn2RG9uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3DTYQh1ncCfnc017OA3Z0teH6kVaN9UTNfKj5ox55VQ=; b=HWAQfAN0KU60t5nrDiBqYzfdm7XgpA8VCW6fkLSQStf4HWSkwRstGqOhAx+ki1eKNL6Qspd9ee44v7Kr00zuwKXQHdmYRS7JC4gVQT0L4FCWswoeJnK/SoO5Dr2BLg2xy0jv0xy87hFjFBrUE6Svj5cxwnhHIXl73zUVSlocprrRrqrxvgg+M9UG+ksulwjrzM2+RKSOGlUsIF40M3gCliG+xyA1PAny+lWkkGEnUtcINljWhaLfLIPiNiOruMLDCd46t3ns4e6JOQwytbQjcA/Xhbwwgk3K1QhRxie93JZtRuIKgHUn/2z3B9ZyKZnQ9CeAOnlv3h6e/lChYwTfrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3DTYQh1ncCfnc017OA3Z0teH6kVaN9UTNfKj5ox55VQ=; b=NC97q17nWr0zBmxYs/rkbFiGzuQGYxFfT2l/QjhmKHOqdeO2VNzMMap8Uz5gpgs8j3o64QavJRH+hViAvwhZZgelc9uIR7tH8dBTBVkzMxwAoZNYBjCd6nO7CAUmlb1j9g+L2k2SRJo1oc6ad79/MC36w5TZbEfQhsexLO9iGy/he/muCS8/vh1kBbvd5MzTRXdKpLSRqc/rCGsFolxa16nzuMRtilulmZTje1JVCGyPm3XCbVPHM07/TXEoXeoVgKS6J9ic4E4e3nYbUHTIulYRNqf4SwtD8DztzRt3AjMT6yc9QQOSCti/qbmunWwkyN1LeLbMIjR5TELCnZCH3g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8510.eurprd04.prod.outlook.com (2603:10a6:102:211::7) by AM9PR04MB8636.eurprd04.prod.outlook.com (2603:10a6:20b:43f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.28; Tue, 24 Jun 2025 10:13:38 +0000 Received: from PAXPR04MB8510.eurprd04.prod.outlook.com ([fe80::a7c2:e2fa:8e04:40db]) by PAXPR04MB8510.eurprd04.prod.outlook.com ([fe80::a7c2:e2fa:8e04:40db%5]) with mapi id 15.20.8857.026; Tue, 24 Jun 2025 10:13:38 +0000 From: Wei Fang To: claudiu.manoil@nxp.com, vladimir.oltean@nxp.com, xiaoning.wang@nxp.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev Subject: [PATCH v2 net-next 3/3] net: enetc: read 64-bit statistics from port MAC counters Date: Tue, 24 Jun 2025 18:15:48 +0800 Message-Id: <20250624101548.2669522-4-wei.fang@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250624101548.2669522-1-wei.fang@nxp.com> References: <20250624101548.2669522-1-wei.fang@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SG2P153CA0028.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c7::15) To PAXPR04MB8510.eurprd04.prod.outlook.com (2603:10a6:102:211::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8510:EE_|AM9PR04MB8636:EE_ X-MS-Office365-Filtering-Correlation-Id: 806b6c76-003e-46cc-1b23-08ddb307c99a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|376014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Aq01U84XY94/MP/kA/YxZ3jaZRjl5u3Is7fu7euWdFQGC2G9FnKjSntJ70ZA?= =?us-ascii?Q?3Z9e/4wUPbfTMVN0JrT1iLUsqB3oy9FFy2VXQzB0gycTHV8VC62EOsJ39hHK?= =?us-ascii?Q?cT2DVyWfev/ERlrhrRZ4Mtij6BcxjK6HvLEBX072KODToere8A2O9OAR0Squ?= =?us-ascii?Q?VfWimXelJGWR40zb46Ms/8GmA83ynQUHC+o1IVUIf4zQX3bGf7x14oTHnLi9?= =?us-ascii?Q?8TGK76XeIckFXT7Gg+5zOkmLNyLGiXhhLdPQzfOs8+3+C7HRcFGkNAaUfwos?= =?us-ascii?Q?3CKG4J6DhF6TW3T6btlAn7BdiTVLkaL8eyVNZWbLDnPqcTLLDxWTLLHqdB0D?= =?us-ascii?Q?PhMtwGWbEihGfok2UMV6ludciWonb9sllQ8Wwf5BrC/LoIba2Yp8uQeLCAln?= =?us-ascii?Q?ni6GoIXnqRTnq6U2k8UrHfmXPc8j3AT8Jw8Eku8eZcizI0IrbALF0WcMZ3BT?= =?us-ascii?Q?IBxlW1UoYz9abwjicQIsVunYKxEZnC3y+z7ded77aN9ubbvlJM26t81/mEY1?= =?us-ascii?Q?ZJet2rcrDrw+sB0L24UzWAu4Ubt/OXmithN6dOSGgP5xsd8kkxoSk5BWTRHx?= =?us-ascii?Q?BQwPT/P2MFa1r/51TRZ/YaQTlFZ4WsKs7isICxCHo7KWypyp+juoKWjvsaEQ?= =?us-ascii?Q?nVRE+Zwv5jNudNbABIYRV8sJxkVG3TTPuK+R4f94yh/jduoysaxV97cmsP7C?= =?us-ascii?Q?0VHTU0/utf1n/OPJRI0BMuVyVR7SaaixVpOOHqy5sw3V8neWp7+C6HQ2dmyW?= =?us-ascii?Q?l7Qul0/a/k0IIf25qZoTFHNQz/Yhw8oSo7C1lJ11mghfYPHC2QIQfDk5jg/K?= =?us-ascii?Q?5iXPd/B634IkK+jc8rEOKTHqwt4EVjniG4t1MXuMJpXBQ4YtYCbH3cj4Arqt?= =?us-ascii?Q?cIUQ7OnbfCxa3SK/WB2K5xIEAvGj9Otp5epfnqQzkxep1GzOHMeXlobY4fAJ?= =?us-ascii?Q?OzehTfbtMZzJ3JPUz91Mb0slmzeMTFmtmt/0f5zFnqmzCL6rkBLTnYWdFZTD?= =?us-ascii?Q?S+SLRoq5Eq287jtBD0oDYxqVCkZ1NJL7G+VllG4DyDBSsX/7Apn8dotccuYy?= =?us-ascii?Q?r1bt7/BW9QP/FW2cUw2UQaUoW6KyrIIIs7yOwsXf6xoPFLjXWlGE5qYFrnIN?= =?us-ascii?Q?rMbvrGImPRPom/hBTkGzZMYXxD5Kn9+5r10GXR4DmseBFOZE6P6/+vgDefAL?= =?us-ascii?Q?6RHSc4mAJweHwJvSxe2UQGhBdnJBB7orTG/FdLWrBTEe9KooNab27fymkh9D?= =?us-ascii?Q?LrvJICqH0deDC7cQE+0EZrwZqoIPsutO1TdXq1UtmVNvMptXOGmPimFDb9uz?= =?us-ascii?Q?t/R8yyBDw7jexcJYO/mhWHpqFqXG1cjrjzdFjJ78fhT/+unQTxYHXgi9TUr7?= =?us-ascii?Q?S+DsaJji7wWTD2UH0Eyv9HBLXw/A3HdgDTKeuIBTerjLulYAWBfyU2AXfyOP?= =?us-ascii?Q?WimP1eMkEPjz+eitV/8c3lvm/c51xZRgE0d0P1pwg/XjUQhNiGwjbg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8510.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(376014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ygoenaNQGq4DiyO1K/bATPbA9gGnrSNSPGn66J3s9BwVbeByJBk2mJ7GD90h?= =?us-ascii?Q?3+gvSBoIu4W7zGzBMNskga5n5A+kvA4oDDTyFhgIQUfsQAM1f9G7Iol5lcmn?= =?us-ascii?Q?EO1V8WrpNPEzOYs5pqMncuqVcn/+Cv3ppGPNISjpi1J8O63/ijs5J+5NLGA8?= =?us-ascii?Q?5TMPaKz4CM5W82TNzvSOEf45LEVWPoD44tvAgXAsenXUnsNxowFICaaOI9a5?= =?us-ascii?Q?AWiP7yJ8SNH3vyPkh5EB6WDuiF9eVIzRSt+V04jhHWu18ypI4rAcnlTqA13J?= =?us-ascii?Q?YKKAQED6/a9D16sPBwDxRWL4QBg3UwNhLZ0C2YoSa03vS1z6ifzLhb0lO9o7?= =?us-ascii?Q?35Q9kx3CA0jM4mqUHvpXoEXqms8Y5op26QPSMIcXYs2ztVG4lcNzNb9DSfZg?= =?us-ascii?Q?fKKJGKZbP5vmeqhJp5ZRCHrjvfrbUc3JiHnXxerDKgAJF+Gj/sYVm0mUpEi3?= =?us-ascii?Q?OjBpkCT0aUmS4sJjXgf5vgld/xtiOV+pkptCbH26O4vgqUQSM5A0BE3S8x05?= =?us-ascii?Q?mrOHF2QHpxSEOCbHVpL+wy2BPZYozQYcqo6VkzGd08rpOGU9yko4/igW4zzB?= =?us-ascii?Q?naCjl9mkSQ2uD8PG7o111xuV5prd0QpROZtuclA4f5M60zGK14saICtGAMs1?= =?us-ascii?Q?RFuTHFaJPN+R9Tp5ofYggRT4B/e8jCaueOeWwruFZMkkXaDDYjBBW+ufJ0/r?= =?us-ascii?Q?nYq0dbRitogjZwUzYXLsNSw4EDp8FJL05bVfhntAW9xM0gioS0yE4gFhky7z?= =?us-ascii?Q?z3a87phy1EDg49QVG3Sry2CBtmPVmH+O5cPNDO6oTgOikG1Nt2BVN809eMhO?= =?us-ascii?Q?rlld+6i19/CA3rJthvEdHIiva3OYn88+wPswC4olCtSEitGzWXRlHqHnFnzY?= =?us-ascii?Q?46/95Cjar+N0byjGugdo6+ZMpA/PbMmhN1nuxgu+UTYqR1olmbMfdyr6qKGP?= =?us-ascii?Q?eJYB/k/kuGHlunUSA6kOW1I43feTm9Z2/6ak8wmWH5C5b9p37j7ca9xhDFBK?= =?us-ascii?Q?2hTSlj1K0itwsIGOrQrmnuAMrvejN2yDikpvkC/ThRvq2A7TXLov96dtDw6b?= =?us-ascii?Q?/TYoJT/vakGEXARGOC/a6RK+feQ4gFY1KEckm2u/PT6AQYe04mT4ySZXRfWr?= =?us-ascii?Q?IzitcVqAPtbE2TzM5I7fUB9SLyRMhi7qzbiwcAvwkHZeip06B708rBZquyo2?= =?us-ascii?Q?xa4M2pRmFzRNPQhO244sMX/yL7rmBwAjsM/wHehq98o+EdkB6/Q8KJY42OaI?= =?us-ascii?Q?HwHva9Yx4Mz8EPsIwr1HP+HZnbtdPpQTzvlDZuFDAUXgQjrvifWvNsEUJh9w?= =?us-ascii?Q?0JNlDMO7A93iHLpUZX8SJQYNkH08/h0z2gYPPqUtALM3k0No19pqmfoAHmoV?= =?us-ascii?Q?P/KLkTTunM0uTRMHu4TJLFFMygP9iY57z0f9RLkd8nbmYaK8uqVFN/rb/3eg?= =?us-ascii?Q?SxpiePx2kW/0hk64Lmmc612DPBGORjwLMejZe1r8vnVW7pLuKyWPypnvnuKd?= =?us-ascii?Q?8/7aEqfiauJSXyVOuS1ZtKc/MgYF2O2SqJup9V38u3IA5ac/qiusLIg8gtD0?= =?us-ascii?Q?DLXbK2Z4wcyvgCifHCtaHDY4qRvMirTmJAhAVAl0?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 806b6c76-003e-46cc-1b23-08ddb307c99a X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8510.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2025 10:13:38.7397 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gGb+BWugu7DQTMbJkISPLU+sBOi7qtcuMUl7Riy3NSWzFaSXDUNg7HAzNvh4pZyTWdP5U8WUJ/FB8TAxGngXYw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8636 Content-Type: text/plain; charset="utf-8" The counters of port MAC are all 64-bit registers, and the statistics of ethtool are u64 type, so replace enetc_port_rd() with enetc_port_rd64() to read 64-bit statistics. Signed-off-by: Wei Fang Reviewed-by: Claudiu Manoil Reviewed-by: Frank Li Reviewed-by: Simon Horman --- .../ethernet/freescale/enetc/enetc_ethtool.c | 84 +++++++++---------- 1 file changed, 42 insertions(+), 42 deletions(-) diff --git a/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c b/drivers= /net/ethernet/freescale/enetc/enetc_ethtool.c index 2c9aa94c8e3d..961e76cd8489 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c +++ b/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c @@ -320,8 +320,8 @@ static void enetc_get_ethtool_stats(struct net_device *= ndev, static void enetc_pause_stats(struct enetc_hw *hw, int mac, struct ethtool_pause_stats *pause_stats) { - pause_stats->tx_pause_frames =3D enetc_port_rd(hw, ENETC_PM_TXPF(mac)); - pause_stats->rx_pause_frames =3D enetc_port_rd(hw, ENETC_PM_RXPF(mac)); + pause_stats->tx_pause_frames =3D enetc_port_rd64(hw, ENETC_PM_TXPF(mac)); + pause_stats->rx_pause_frames =3D enetc_port_rd64(hw, ENETC_PM_RXPF(mac)); } =20 static void enetc_get_pause_stats(struct net_device *ndev, @@ -348,31 +348,31 @@ static void enetc_get_pause_stats(struct net_device *= ndev, static void enetc_mac_stats(struct enetc_hw *hw, int mac, struct ethtool_eth_mac_stats *s) { - s->FramesTransmittedOK =3D enetc_port_rd(hw, ENETC_PM_TFRM(mac)); - s->SingleCollisionFrames =3D enetc_port_rd(hw, ENETC_PM_TSCOL(mac)); - s->MultipleCollisionFrames =3D enetc_port_rd(hw, ENETC_PM_TMCOL(mac)); - s->FramesReceivedOK =3D enetc_port_rd(hw, ENETC_PM_RFRM(mac)); - s->FrameCheckSequenceErrors =3D enetc_port_rd(hw, ENETC_PM_RFCS(mac)); - s->AlignmentErrors =3D enetc_port_rd(hw, ENETC_PM_RALN(mac)); - s->OctetsTransmittedOK =3D enetc_port_rd(hw, ENETC_PM_TEOCT(mac)); - s->FramesWithDeferredXmissions =3D enetc_port_rd(hw, ENETC_PM_TDFR(mac)); - s->LateCollisions =3D enetc_port_rd(hw, ENETC_PM_TLCOL(mac)); - s->FramesAbortedDueToXSColls =3D enetc_port_rd(hw, ENETC_PM_TECOL(mac)); - s->FramesLostDueToIntMACXmitError =3D enetc_port_rd(hw, ENETC_PM_TERR(mac= )); - s->CarrierSenseErrors =3D enetc_port_rd(hw, ENETC_PM_TCRSE(mac)); - s->OctetsReceivedOK =3D enetc_port_rd(hw, ENETC_PM_REOCT(mac)); - s->FramesLostDueToIntMACRcvError =3D enetc_port_rd(hw, ENETC_PM_RDRNTP(ma= c)); - s->MulticastFramesXmittedOK =3D enetc_port_rd(hw, ENETC_PM_TMCA(mac)); - s->BroadcastFramesXmittedOK =3D enetc_port_rd(hw, ENETC_PM_TBCA(mac)); - s->MulticastFramesReceivedOK =3D enetc_port_rd(hw, ENETC_PM_RMCA(mac)); - s->BroadcastFramesReceivedOK =3D enetc_port_rd(hw, ENETC_PM_RBCA(mac)); + s->FramesTransmittedOK =3D enetc_port_rd64(hw, ENETC_PM_TFRM(mac)); + s->SingleCollisionFrames =3D enetc_port_rd64(hw, ENETC_PM_TSCOL(mac)); + s->MultipleCollisionFrames =3D enetc_port_rd64(hw, ENETC_PM_TMCOL(mac)); + s->FramesReceivedOK =3D enetc_port_rd64(hw, ENETC_PM_RFRM(mac)); + s->FrameCheckSequenceErrors =3D enetc_port_rd64(hw, ENETC_PM_RFCS(mac)); + s->AlignmentErrors =3D enetc_port_rd64(hw, ENETC_PM_RALN(mac)); + s->OctetsTransmittedOK =3D enetc_port_rd64(hw, ENETC_PM_TEOCT(mac)); + s->FramesWithDeferredXmissions =3D enetc_port_rd64(hw, ENETC_PM_TDFR(mac)= ); + s->LateCollisions =3D enetc_port_rd64(hw, ENETC_PM_TLCOL(mac)); + s->FramesAbortedDueToXSColls =3D enetc_port_rd64(hw, ENETC_PM_TECOL(mac)); + s->FramesLostDueToIntMACXmitError =3D enetc_port_rd64(hw, ENETC_PM_TERR(m= ac)); + s->CarrierSenseErrors =3D enetc_port_rd64(hw, ENETC_PM_TCRSE(mac)); + s->OctetsReceivedOK =3D enetc_port_rd64(hw, ENETC_PM_REOCT(mac)); + s->FramesLostDueToIntMACRcvError =3D enetc_port_rd64(hw, ENETC_PM_RDRNTP(= mac)); + s->MulticastFramesXmittedOK =3D enetc_port_rd64(hw, ENETC_PM_TMCA(mac)); + s->BroadcastFramesXmittedOK =3D enetc_port_rd64(hw, ENETC_PM_TBCA(mac)); + s->MulticastFramesReceivedOK =3D enetc_port_rd64(hw, ENETC_PM_RMCA(mac)); + s->BroadcastFramesReceivedOK =3D enetc_port_rd64(hw, ENETC_PM_RBCA(mac)); } =20 static void enetc_ctrl_stats(struct enetc_hw *hw, int mac, struct ethtool_eth_ctrl_stats *s) { - s->MACControlFramesTransmitted =3D enetc_port_rd(hw, ENETC_PM_TCNP(mac)); - s->MACControlFramesReceived =3D enetc_port_rd(hw, ENETC_PM_RCNP(mac)); + s->MACControlFramesTransmitted =3D enetc_port_rd64(hw, ENETC_PM_TCNP(mac)= ); + s->MACControlFramesReceived =3D enetc_port_rd64(hw, ENETC_PM_RCNP(mac)); } =20 static const struct ethtool_rmon_hist_range enetc_rmon_ranges[] =3D { @@ -389,26 +389,26 @@ static const struct ethtool_rmon_hist_range enetc_rmo= n_ranges[] =3D { static void enetc_rmon_stats(struct enetc_hw *hw, int mac, struct ethtool_rmon_stats *s) { - s->undersize_pkts =3D enetc_port_rd(hw, ENETC_PM_RUND(mac)); - s->oversize_pkts =3D enetc_port_rd(hw, ENETC_PM_ROVR(mac)); - s->fragments =3D enetc_port_rd(hw, ENETC_PM_RFRG(mac)); - s->jabbers =3D enetc_port_rd(hw, ENETC_PM_RJBR(mac)); - - s->hist[0] =3D enetc_port_rd(hw, ENETC_PM_R64(mac)); - s->hist[1] =3D enetc_port_rd(hw, ENETC_PM_R127(mac)); - s->hist[2] =3D enetc_port_rd(hw, ENETC_PM_R255(mac)); - s->hist[3] =3D enetc_port_rd(hw, ENETC_PM_R511(mac)); - s->hist[4] =3D enetc_port_rd(hw, ENETC_PM_R1023(mac)); - s->hist[5] =3D enetc_port_rd(hw, ENETC_PM_R1522(mac)); - s->hist[6] =3D enetc_port_rd(hw, ENETC_PM_R1523X(mac)); - - s->hist_tx[0] =3D enetc_port_rd(hw, ENETC_PM_T64(mac)); - s->hist_tx[1] =3D enetc_port_rd(hw, ENETC_PM_T127(mac)); - s->hist_tx[2] =3D enetc_port_rd(hw, ENETC_PM_T255(mac)); - s->hist_tx[3] =3D enetc_port_rd(hw, ENETC_PM_T511(mac)); - s->hist_tx[4] =3D enetc_port_rd(hw, ENETC_PM_T1023(mac)); - s->hist_tx[5] =3D enetc_port_rd(hw, ENETC_PM_T1522(mac)); - s->hist_tx[6] =3D enetc_port_rd(hw, ENETC_PM_T1523X(mac)); + s->undersize_pkts =3D enetc_port_rd64(hw, ENETC_PM_RUND(mac)); + s->oversize_pkts =3D enetc_port_rd64(hw, ENETC_PM_ROVR(mac)); + s->fragments =3D enetc_port_rd64(hw, ENETC_PM_RFRG(mac)); + s->jabbers =3D enetc_port_rd64(hw, ENETC_PM_RJBR(mac)); + + s->hist[0] =3D enetc_port_rd64(hw, ENETC_PM_R64(mac)); + s->hist[1] =3D enetc_port_rd64(hw, ENETC_PM_R127(mac)); + s->hist[2] =3D enetc_port_rd64(hw, ENETC_PM_R255(mac)); + s->hist[3] =3D enetc_port_rd64(hw, ENETC_PM_R511(mac)); + s->hist[4] =3D enetc_port_rd64(hw, ENETC_PM_R1023(mac)); + s->hist[5] =3D enetc_port_rd64(hw, ENETC_PM_R1522(mac)); + s->hist[6] =3D enetc_port_rd64(hw, ENETC_PM_R1523X(mac)); + + s->hist_tx[0] =3D enetc_port_rd64(hw, ENETC_PM_T64(mac)); + s->hist_tx[1] =3D enetc_port_rd64(hw, ENETC_PM_T127(mac)); + s->hist_tx[2] =3D enetc_port_rd64(hw, ENETC_PM_T255(mac)); + s->hist_tx[3] =3D enetc_port_rd64(hw, ENETC_PM_T511(mac)); + s->hist_tx[4] =3D enetc_port_rd64(hw, ENETC_PM_T1023(mac)); + s->hist_tx[5] =3D enetc_port_rd64(hw, ENETC_PM_T1522(mac)); + s->hist_tx[6] =3D enetc_port_rd64(hw, ENETC_PM_T1523X(mac)); } =20 static void enetc_get_eth_mac_stats(struct net_device *ndev, --=20 2.34.1