From nobody Thu Oct 9 00:10:36 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01BA92522B5 for ; Tue, 24 Jun 2025 06:05:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750745128; cv=none; b=V1Hdh3c14pmGrWgF9oQ1P7Qd4azJTyDlgvp8nH82t+j3ZkJzXCr1ilas8vwbp74MyCnVJvIMo/YuQqn0dC7QHsjRKp+MilxEXE1gjZUIPj/ZAsJghhFSCSVdj7CaAAPJZUMeAR4qFYhyD7c//TL5TrRhnHUiPTFCDCS1Y2BvVl8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750745128; c=relaxed/simple; bh=VBK9JtAr3FmFIut3GYFMz/furBThoh2UTUTxdAFQcD0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ghL+emf2tnNtXJExzXnHeHZr6kSkMbMO4GoVdBILZEpyaqdY3z8aQo6Lp8IZF12EnEvps8enp6DAe77u37hk+kLBmbSV3QiVj7PoVTiRpQ6/E+PdC/dyGbkBomVchYB8yAYwJWbRBwbPjH8RVbmf1ChQ4L7fRwC3JfphoSLjSm0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=i0c4z4eE; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="i0c4z4eE" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55NI2iEc020784 for ; Tue, 24 Jun 2025 06:05:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=lDdOYdwFc4W UgEUqvI2QS/sAK9B8E5IgVNSudMM9Bh8=; b=i0c4z4eEl78Km1aLtMy5ImC4Sr4 SBbO/iWZPsABX7YYWZxjQAGNjmoi5P6NSVRaIa4c+NhlLjfDkvdwnkXaN4CJ/FOd 41dM0cDx91dOE4QG95OtiikmB+0Tzi2AF26Eu2/G8NlwGqbN4LuPzbGuC8KBO+JQ QlMdybB+cr/FvFhFoqRX2NDXlS2U7rtWErF1xtb0TbicLGDctlsiDcczsUplOB9X CfCVtZ6kURwyE/Y5wBOTyCP6xT+Rn+SAIYwn7J/cpr01bWHPqCPFP0Ru3TGVQg77 92Me4yw+n9Wg7z9z2WnNuCZtm/PoR98v3obKCh6ezschd7jYP4whKOo3oNg== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47f4b3tv5y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 24 Jun 2025 06:05:26 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-315af08594fso2738116a91.2 for ; Mon, 23 Jun 2025 23:05:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750745125; x=1751349925; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lDdOYdwFc4WUgEUqvI2QS/sAK9B8E5IgVNSudMM9Bh8=; b=BkTobluJyB92b0AenRxN9zeAMpBsxdxLaGyatiPGnXt+TSMt2SVv7xK+ZbSA9XeFHR D66OTbl7EY28fwQratLVVNV16gDFm/kC9cdmEkFifARRJn0N+fV18DwWBeW+IfPiuaZH 8l2wI1fO2NuFj3QU7zY4U5SIMDRZ26CHouvjKpzwt29THFf3YFHiaEIwfaGzizNlO9sP udILUzQ9DT3s1azrVwGv9tDayenEkg2ueS2i4P4s+frafDUUT2fExnPaUBEg15YitMeB rxHy7HnzgGXxYkJmJ8UFNj235CQe0iL+Roe9kac6KWrZeVYUKoamCruTvBFfraXYnaYT ayFA== X-Forwarded-Encrypted: i=1; AJvYcCW1VD1g+WHPByA9WC766W9hXe93+qlAFxhxHwJTA710BtVkl+/kWvHWo/ouSdYvZdzxVZuc4zjRVt8BlC8=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/jG5swhiWYLqYMCJXm4PqrdPQiLCiiYudrsdFgd+5at+oOYbX ATPn0YoBV6iMvM9BOCNU6iIE+/qB53K+DjtBkdghGTirgd8zEGYiFuVTjj/wyC216aq0pi+EJrs DLweoMZhcT8pPCc/vFyJOxMraWK82Y8F0aVJ/+AY4QGcX2ZHG+Ere5TlSJimJnblYDUk= X-Gm-Gg: ASbGncvKLKQCIfeKEob/P6ITx1oXHCPH2urPVd7bO/d60uKEy32xsRYtD8Jxi+reDr7 M34iDcPbSkQDy4P/zJ05rsDGCyZDWx+v926Utd4LQpERSx62JiTB8JegZgs+zqjNrif+Yy5LFGF sj9fh4TbvaZtvAS3DhL/UEl9M4/QfxaEt4O4oysFZkZOs4t6Zir7+aZZfyKZAUbA1InLCNEwyLo eyIllydAP1iAHTfD1feSUctzi0J1XKYbhv64bkn99GC/1MmLeFIrucXMBqgDVsQ4TfqeWUMLfZ4 Xj5VrHZz+K3K9yZlcrqj2PMX1RJ/OZ/JACU6nNFmH7l4lHlCMEhYdadwyhqS0lBKloh1uGciYlH 9yA== X-Received: by 2002:a17:903:4b07:b0:234:8eeb:d834 with SMTP id d9443c01a7336-237d97fbc8fmr248546205ad.16.1750745125079; Mon, 23 Jun 2025 23:05:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFJSsLPuqK7+6S2VP4lZAltQqpakLws2gPXkMkL3c6Beh8EhGPZyr249GoBMsvm7A/2zAVDFQ== X-Received: by 2002:a17:903:4b07:b0:234:8eeb:d834 with SMTP id d9443c01a7336-237d97fbc8fmr248545765ad.16.1750745124642; Mon, 23 Jun 2025 23:05:24 -0700 (PDT) Received: from jiegan.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-237d83937b1sm101371455ad.52.2025.06.23.23.05.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jun 2025 23:05:23 -0700 (PDT) From: Jie Gan To: Suzuki K Poulose , Mike Leach , James Clark , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Alexander Shishkin Cc: Tingwei Zhang , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, jie.gan@oss.qualcomm.com Subject: [PATCH v3 09/10] coresight: tmc: add read function for byte-cntr Date: Tue, 24 Jun 2025 14:04:37 +0800 Message-Id: <20250624060438.7469-10-jie.gan@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250624060438.7469-1-jie.gan@oss.qualcomm.com> References: <20250624060438.7469-1-jie.gan@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjI0MDA1MSBTYWx0ZWRfX/D/SupWG8Bt6 j+TC8J0uvo2DtatUZdtbU0xbqSZksaECfrWIM4VXGpe6IXcCkfewoAdUpdMBmb99oagcZk9LNnP Dn9BvZww0k+zkYAoC9z8w66YtSU71aPIPwTRZKhZfOUyzk0Jxi6W5rxtVTOOmJaUEEZlc/u5wtu bNFJIosqpH5b2gqfYGuP++6FRFJYG9CzVa5ip/vTjNMPQ5MFV+9AkBsr2QVERAZUD9iNmSMZ5S4 CKjnIXI+LGurNifdsgbtRHgqd+zEo0O0fYHWonA3d1JwECjuCxr6o6r375c14zTyAELbhDOS+0+ 2RGiv9gzOamNnFQvKZcmfq5HFbK6Vm0VvkpkS+ZsymVutSsU3PDAMj7HoSXm45XOrWBxpPSF+fJ f68rrowAL5hyIsr4lxxnvMbfP97MRnlGvqVlX7gPXdAzHAhmJwxa/XBGEMMOm2t65MFYE0Mq X-Proofpoint-ORIG-GUID: JL3BL4dW_ZveV5fbc6Jqb9ARxO8rfbd_ X-Proofpoint-GUID: JL3BL4dW_ZveV5fbc6Jqb9ARxO8rfbd_ X-Authority-Analysis: v=2.4 cv=A8BsP7WG c=1 sm=1 tr=0 ts=685a4026 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=6IFa9wvqVegA:10 a=EUspDBNiAAAA:8 a=56IJ4eEW6NAC_NOVRZQA:9 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-06-24_02,2025-06-23_07,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 mlxlogscore=999 malwarescore=0 spamscore=0 bulkscore=0 phishscore=0 adultscore=0 impostorscore=0 suspectscore=0 mlxscore=0 clxscore=1015 priorityscore=1501 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506240051 Content-Type: text/plain; charset="utf-8" The byte-cntr read function always reads trace data from the deactivated and filled buffer which is already synced. The read function will fail when the ETR cannot find a available buffer to receive trace data. The read function terminates when the path is disabled or interrupted by a signal. Signed-off-by: Jie Gan --- .../hwtracing/coresight/coresight-tmc-core.c | 31 ++++++- .../hwtracing/coresight/coresight-tmc-etr.c | 90 +++++++++++++++++++ drivers/hwtracing/coresight/coresight-tmc.h | 4 +- 3 files changed, 120 insertions(+), 5 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-tmc-core.c b/drivers/hwt= racing/coresight/coresight-tmc-core.c index 40605310240d..7b09cf060666 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-core.c +++ b/drivers/hwtracing/coresight/coresight-tmc-core.c @@ -317,14 +317,18 @@ static int tmc_open(struct inode *inode, struct file = *file) return 0; } =20 -static ssize_t tmc_get_sysfs_trace(struct tmc_drvdata *drvdata, loff_t pos= , size_t len, - char **bufpp) +static ssize_t tmc_get_sysfs_trace(struct tmc_drvdata *drvdata, + struct ctcu_byte_cntr *byte_cntr_data, + loff_t pos, size_t len, char **bufpp) { switch (drvdata->config_type) { case TMC_CONFIG_TYPE_ETB: case TMC_CONFIG_TYPE_ETF: return tmc_etb_get_sysfs_trace(drvdata, pos, len, bufpp); case TMC_CONFIG_TYPE_ETR: + if (byte_cntr_data && byte_cntr_data->thresh_val) + return tmc_byte_cntr_get_data(drvdata, byte_cntr_data, len, bufpp); + return tmc_etr_get_sysfs_trace(drvdata, pos, len, bufpp); } =20 @@ -338,7 +342,21 @@ static ssize_t tmc_read(struct file *file, char __user= *data, size_t len, ssize_t actual; struct tmc_drvdata *drvdata =3D container_of(file->private_data, struct tmc_drvdata, miscdev); - actual =3D tmc_get_sysfs_trace(drvdata, *ppos, len, &bufp); + struct coresight_device *helper =3D coresight_get_helper(drvdata->csdev, + CORESIGHT_DEV_SUBTYPE_HELPER_CTCU); + struct ctcu_byte_cntr *byte_cntr_data =3D NULL; + struct ctcu_drvdata *ctcu_drvdata =3D NULL; + int port; + + if (helper) { + port =3D coresight_get_port_helper(drvdata->csdev, helper); + if (port >=3D 0) { + ctcu_drvdata =3D dev_get_drvdata(helper->dev.parent); + byte_cntr_data =3D &ctcu_drvdata->byte_cntr_data[port]; + } + } + + actual =3D tmc_get_sysfs_trace(drvdata, byte_cntr_data, *ppos, len, &bufp= ); if (actual <=3D 0) return 0; =20 @@ -348,7 +366,12 @@ static ssize_t tmc_read(struct file *file, char __user= *data, size_t len, return -EFAULT; } =20 - *ppos +=3D actual; + if (byte_cntr_data && byte_cntr_data->thresh_val) { + byte_cntr_data->total_size +=3D actual; + drvdata->reading_node->pos +=3D actual; + } else + *ppos +=3D actual; + dev_dbg(&drvdata->csdev->dev, "%zu bytes copied\n", actual); =20 return actual; diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtr= acing/coresight/coresight-tmc-etr.c index 3e3e1b5e78ca..8f53ecb12ad3 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c @@ -1163,6 +1163,10 @@ ssize_t tmc_etr_get_sysfs_trace(struct tmc_drvdata *= drvdata, ssize_t actual =3D len; struct etr_buf *etr_buf =3D drvdata->sysfs_buf; =20 + /* Reading the buf defind in buf_node if it exists*/ + if (drvdata->reading_node) + etr_buf =3D drvdata->reading_node->sysfs_buf; + if (pos + actual > etr_buf->len) actual =3D etr_buf->len - pos; if (actual <=3D 0) @@ -1339,6 +1343,92 @@ static bool tmc_byte_cntr_switch_buffer(struct tmc_d= rvdata *drvdata, return found_free_buf; } =20 +/* + * tmc_byte_cntr_get_data() - reads data from the deactived and filled buf= fer. + * The byte-cntr reading work reads data from the deactived and filled buf= fer. + * The read operation waits for a buffer to become available, either fille= d or + * upon timeout, and then reads trace data from the synced buffer. + */ +ssize_t tmc_byte_cntr_get_data(struct tmc_drvdata *drvdata, + struct ctcu_byte_cntr *byte_cntr_data, + size_t len, char **bufpp) +{ + size_t thresh_val =3D byte_cntr_data->thresh_val; + atomic_t *irq_cnt =3D &byte_cntr_data->irq_cnt; + struct etr_buf *sysfs_buf =3D drvdata->sysfs_buf; + struct device *dev =3D &drvdata->csdev->dev; + struct etr_buf_node *nd, *next; + ssize_t size =3D sysfs_buf->size; + ssize_t actual; + loff_t pos; + int ret; + +wait_buffer: + if (!byte_cntr_data->reading_buf) { + ret =3D wait_event_interruptible_timeout(byte_cntr_data->wq, + ((atomic_read(irq_cnt) + 1) * thresh_val >=3D size) || + !byte_cntr_data->enable, + BYTE_CNTR_TIMEOUT); + if (ret < 0) + return ret; + /* + * The current etr_buf is almost full or timeout is triggered, + * so switch the buffer and mark the switched buffer as reading. + */ + if (byte_cntr_data->enable) { + if (!tmc_byte_cntr_switch_buffer(drvdata, byte_cntr_data)) { + dev_err(dev, "Switch buffer failed for byte-cntr\n"); + return -EINVAL; + } + + byte_cntr_data->reading_buf =3D true; + } else { + if (!drvdata->reading_node) { + list_for_each_entry_safe(nd, next, &drvdata->etr_buf_list, node) { + if (nd->sysfs_buf =3D=3D sysfs_buf) { + nd->pos =3D 0; + drvdata->reading_node =3D nd; + break; + } + } + } + + pos =3D drvdata->reading_node->pos; + actual =3D tmc_etr_get_sysfs_trace(drvdata, pos, len, bufpp); + if (actual > 0) + return actual; + + drvdata->reading_node =3D NULL; + + /* Exit byte-cntr reading */ + return -EINVAL; + } + } + + /* Check the status of current etr_buf*/ + if ((atomic_read(irq_cnt) + 1) * thresh_val >=3D size) + /* + * Unlikely to find a free buffer to switch, so just disable + * the ETR for a while. + */ + if (!tmc_byte_cntr_switch_buffer(drvdata, byte_cntr_data)) + dev_info(dev, "No available buffer to store data, disable ETR\n"); + + pos =3D drvdata->reading_node->pos; + actual =3D tmc_etr_get_sysfs_trace(drvdata, pos, len, bufpp); + if (actual =3D=3D 0) { + /* Reading work for marked buffer has finished, reset flags */ + drvdata->reading_node->reading =3D false; + byte_cntr_data->reading_buf =3D false; + drvdata->reading_node =3D NULL; + + /* Nothing in the buffer, wait for next buffer to be filled */ + goto wait_buffer; + } + + return actual; +} + static int tmc_enable_etr_sink_sysfs(struct coresight_device *csdev) { int ret =3D 0; diff --git a/drivers/hwtracing/coresight/coresight-tmc.h b/drivers/hwtracin= g/coresight/coresight-tmc.h index f95df0a34ad6..4136ec5ecaf7 100644 --- a/drivers/hwtracing/coresight/coresight-tmc.h +++ b/drivers/hwtracing/coresight/coresight-tmc.h @@ -364,7 +364,9 @@ int tmc_read_prepare_byte_cntr(struct tmc_drvdata *drvd= ata, struct ctcu_byte_cntr *byte_cntr_data); int tmc_read_unprepare_byte_cntr(struct tmc_drvdata *drvdata, struct ctcu_byte_cntr *byte_cntr_data); - +ssize_t tmc_byte_cntr_get_data(struct tmc_drvdata *drvdata, + struct ctcu_byte_cntr *byte_cntr_data, + size_t len, char **bufpp); =20 #define TMC_REG_PAIR(name, lo_off, hi_off) \ static inline u64 \ --=20 2.34.1