From nobody Wed Oct 8 20:44:14 2025 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2084.outbound.protection.outlook.com [40.107.93.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEBFB2D321D; Tue, 24 Jun 2025 14:16:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.93.84 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774590; cv=fail; b=YrBA5mG26FQQrx4AgzTvGrYKf7NBgVId9hptRptq2VpI/tLe5Zr+u4W42u7R6Zvo4IEcRu6k11ilsr9AAT6OFIj3IIHEwaQfNTdRV4BG/46KJGTawL8fTssyYJ8V9oO+vy1Cr0eDdEabnB0YdC6VWgBZAn0EBNi15FWKmYctLEY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774590; c=relaxed/simple; bh=avb12mJUpmk+z2+fCJyY1MC9aPsyIXO2RAD+x3SfHI0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=me9tmOi5GFChk3k4qWQ3t4fFQ31NhfjhLzS9bzVibU4H+jIKnNNV8RFX3+2Vu7EwKWE1H+YPm9MgHwmL7RZw7gcicW4/fMPZ7IZDezO2dozOT9Mu/N1dlmJ6V4LF3ObK0L3nQdKg4gPnWcCBJZZCFtyLpLDi3h1T2RDhjqtczus= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=ERq4wfXB; arc=fail smtp.client-ip=40.107.93.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="ERq4wfXB" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=K4g5xnoAtJpPDeaZPOibHXOjGHMXI4ctb8PNCAn5OKjNtsJuyh6h9Ub8JH0mMqrR2zUNkdtgNyLI+fMMCeiTO6hzfDO4cbzAK5eDckneRBWNRmEARSC/Vf3Mi2rvAaJN6cCmoUyBd2PQlsovI6n8EG3vflec0UypWtOnEzUfSKav/rdmVjchkAp2BdT2qyn8qZXBgvuFKsFkxadfLJKFZcT9qYm91NfX/Jq7t17bINCuPkLQkR2AzC20vu5zwPMAQRaNH2lixd+oYws7CniYKezJSmcyFeqGFQhPLzogDVjXdKDkJM80QpVyo7L/1TmjfzHKJUJXvmmx34Nnf3XDCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NnLDuHh182yB8YN5atCJRAE1GZ6CuwAvZlepIQD8X5A=; b=ADF+wLy0LJfPK+5Puj09v/kM3bFDPzP0uoDvkTIcPMnODabfN3CFpi354XMXQS5WDZVqldesESh71vTBgCEsr10vFpGB8ZPAJgN0VQWwORzNbEDNeEON2n6KcsoZ8d0h3PMxj96LnZVJ3aiMWfOu+txpPPZ92mXe2H4b2HCL6DPUdvFVKyqxOciRxNuCj+WDWeeZbSeXvkl4Jq3dvDcpN2rgdGfk9RfrMthyjXCTza9V1BIMg/qy2W4jiZ1ztPCEjhXtRvWnvTtsoIpUUKnRvnx7t+vWvz+9G3Mg+o8kt5lRjoO7+lS+KjOd1J7AtLgkC646/cGc8SD0dnVCWrJO2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NnLDuHh182yB8YN5atCJRAE1GZ6CuwAvZlepIQD8X5A=; b=ERq4wfXBk9jvycW9x40ZEgHvOdC4NSbtb3uw9V2RyD8yRPgzg29iHw3P+LcTEp2SJE12LT7gwbzMza5jPjLGgKSzfkp/+JnDa8wt5asP4sGXaWkbxObiooSERjtrvMoyMzH7ZzEaah7bjCJFtBftV81gHsXhpIXOq+L2oZ03xus= Received: from MW4PR03CA0237.namprd03.prod.outlook.com (2603:10b6:303:b9::32) by CH2PR12MB4167.namprd12.prod.outlook.com (2603:10b6:610:7a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.25; Tue, 24 Jun 2025 14:16:26 +0000 Received: from SJ1PEPF00001CEA.namprd03.prod.outlook.com (2603:10b6:303:b9:cafe::b5) by MW4PR03CA0237.outlook.office365.com (2603:10b6:303:b9::32) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8857.29 via Frontend Transport; Tue, 24 Jun 2025 14:16:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CEA.mail.protection.outlook.com (10.167.242.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8880.14 via Frontend Transport; Tue, 24 Jun 2025 14:16:26 +0000 Received: from [127.0.1.1] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 24 Jun 2025 09:16:24 -0500 From: Yazen Ghannam Date: Tue, 24 Jun 2025 14:15:56 +0000 Subject: [PATCH v4 01/22] x86/mce: Don't remove sysfs if thresholding sysfs init fails Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250624-wip-mca-updates-v4-1-236dd74f645f@amd.com> References: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> In-Reply-To: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> To: , Tony Luck , "Rafael J. Wysocki" , Len Brown CC: , , , Qiuxu Zhuo , , Yazen Ghannam X-Mailer: b4 0.15-dev-9b767 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CEA:EE_|CH2PR12MB4167:EE_ X-MS-Office365-Filtering-Correlation-Id: c5b0b6cb-296f-4efa-97ae-08ddb329b4a0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|82310400026|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TUlPU3hhSTFaUzdQYjhqZk4yM01tVGgxdUsrSzVHcWl0dGVKK1hzeVBOS3dJ?= =?utf-8?B?b1llTUVBL3d4RVFHdE5pYWZmb1dKVk15UCtsb2c1YmNlVzVnMXVuYk9lZ0VY?= =?utf-8?B?WEZTbzVnbDhobFZpRXlJc24vZmZld25NeERGSW5yOERlQlhKZ1gzUHowWDAy?= =?utf-8?B?ODNIVVBKMTRKVzlLYVZ4Y3JudmdDaXZWeXN3YmhTVkt1aTBvaytXRGozclF1?= =?utf-8?B?V1NEK0hMTGlYR0l1Z04xZVhEQnIwMVVCb09nYXRNbmtWNDVjY3g1ZmpxZFp1?= =?utf-8?B?NFRzaXFZdFZRUUg1RmVxMEY4VTBtQXVyYWpaa29kaGNncTM1MVRrdDBQTTJD?= =?utf-8?B?bzcyOHBzV0t2NjV2NU1mTWhBTnZSU3hCRzBPRXhiWVJlYytoNEhLNDQrZjZy?= =?utf-8?B?UlhiRkx0aktqT1lERXBMcFpROG8wakhWY3RTaW9SM1VIU1E4dXJkZlZsZ3R6?= =?utf-8?B?QjBCaTF5ZnJnUTNBWkFMZ1VrQi9Ga3hYQkc2cEx4R3QxMHY1dHFhemV0OG1v?= =?utf-8?B?MVJESnlaV0NHdmdHUmhPU2JvVVZhditVQ01vSThmNWd2MURPUm1XV0gzUGpr?= =?utf-8?B?WjVGMnJFcnBlTVpsUFJVdVB6a3BqdndnV2hyQWJoTExBMGNMYVRRWk1yc2NI?= =?utf-8?B?dDJDUGtMZlMxT1g5Z1JUMGRYbmFmVDlja2ZTNENrUHJpYUFPTk1EcG41NVdW?= =?utf-8?B?VlJnOHYweFdhRDU3M1pJZVhlTlkya05nSUMxd1oxc2NRbmw1VGN1SkJja250?= =?utf-8?B?c0dMc2djaVJDb3FyK21qVitxend0SFIrMklhb2h0aTBpK3ZMb1R4R3FsaG1s?= =?utf-8?B?Q3hvVEh1TFZGbWRLcTlHc3I0STJvakc0b2ZJSkFZSFhJcU80TnFyUVIxcXhN?= =?utf-8?B?SGI3SmtySUY1NmVObmJpYkdXQWpzb0c2ZDRWRWVWVEJUSml1WjJXaGF3bGRS?= =?utf-8?B?VWZiOWdyQmpVYm1NZ3IveVdXTnlLUjNiMk5BWk96RVNHQS81Qk5maVVGZXBy?= =?utf-8?B?dEQ3RXlrOGE0ZHdleGR3MW5iNlFKVG05b1FtclMxTlpOZ3ZiMkpzMDROWkdm?= =?utf-8?B?VkV0ZUprRUtzS0c3dEliYXlReDZVTzNVNGxKT0U2cHNpOHdUMXR2aGcvcHZr?= =?utf-8?B?ZStKL0I0NnRtdEZ6aktNVFRLdXZCNVBMNGhmUWNJM2RoZHpTd0FWVUN2U0t2?= =?utf-8?B?MUFuQ2NvK2xOM2VhekhFSTAxcjVnTDJ6WGNteEJGQzhXNCtmZFpaKzZCaXVp?= =?utf-8?B?OGgxU3ExcHM5TitGMDZGMGVxMEJyWkhCTDQyV0hnVmh0eFFocW5iNHcybXRp?= =?utf-8?B?QVJpSFR5ZHpGZDM5OVVmTHluRWNCaU00dThXejFzekdnczVjb1hZWW56MVZM?= =?utf-8?B?RlRpQTRST1lPVUUzM3pmUHJHdXJWdEd0QUZ3TUlyUlZ1TzJ4N1QzZ1VFN0JD?= =?utf-8?B?MjRUOTlGZzBSR2xxU3l3RG43K3BRT2pGZWZZU1BWL2R4cG9Jck9QV29QbVdB?= =?utf-8?B?L2xCeXN2YkhkeTY4R2NtL05ZNFIrRE9YcVlpUlBqaHRoQlJndjMyMW5FUHEv?= =?utf-8?B?R2M3MHNxRmtqcFZtRWNSLzNOdlpIWmFOLzgyOVBBY3U0dExSMjdWMWg0VWFB?= =?utf-8?B?NnFQRi9wLzVxK1plKzdIYk5nMUFTSlZBa0J5cUcva1hQOGZvblFmRlIvdU1T?= =?utf-8?B?cWdPeTFSd0R2c0dqaEpnbzZmUTUzMnNHQXBFUVd2Qk5vWUpiTmZFTFduMUFj?= =?utf-8?B?UEdoRUlvVG0zL0NsOFYxZ1JQNkVsdTJYMEJEWkZSWnZrY2kzd3NNL0NtVHJE?= =?utf-8?B?MG1Na1pqNkRKU0VlQitibTg3elRmQ25zckV4NXJBNlExdmVqN1hGdDBvK3Bk?= =?utf-8?B?alFOWEpjWDRwVjRCTlV2SVVFa2Z4QU9BR0JPZVdUYng1RWFBY2I5K2UzV3RF?= =?utf-8?B?U0tSQlkvaVpFR2RyazJqUjgvOGxtRzFkRjg3SGtzcERIbk55V3pnZ0NBV2JG?= =?utf-8?B?Z01nTzhXUlhqVkZ1RnBqWHk4WGQ4bDhjZkpqaG54Wkx3T3l1aTJRRG1qZE9s?= =?utf-8?Q?HMcSbH?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(82310400026)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2025 14:16:26.0583 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c5b0b6cb-296f-4efa-97ae-08ddb329b4a0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CEA.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4167 Currently, the MCE subsystem sysfs interface will be removed if the thresholding sysfs interface fails to be created. A common failure is due to new MCA bank types that are not recognized and don't have a short name set. The MCA thresholding feature is optional and should not break the common MCE sysfs interface. Also, new MCA bank types are occasionally introduced, and updates will be needed to recognize them. But likewise, this should not break the common sysfs interface. Keep the MCE sysfs interface regardless of the status of the thresholding sysfs interface. Reviewed-by: Qiuxu Zhuo Tested-by: Tony Luck Reviewed-by: Tony Luck Signed-off-by: Yazen Ghannam Cc: stable@vger.kernel.org --- Notes: Link: https://lore.kernel.org/r/20250415-wip-mca-updates-v3-1-8ffd9eb4aa56@am= d.com =20 v3->v4: * No change. =20 v2->v3: * Added tags from Qiuxu and Tony. =20 v1->v2: * New in v2. * Included stable tag but there's no specific commit for Fixes. arch/x86/kernel/cpu/mce/core.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c index e9b3c5d4a52e..07d61937427f 100644 --- a/arch/x86/kernel/cpu/mce/core.c +++ b/arch/x86/kernel/cpu/mce/core.c @@ -2801,15 +2801,9 @@ static int mce_cpu_dead(unsigned int cpu) static int mce_cpu_online(unsigned int cpu) { struct timer_list *t =3D this_cpu_ptr(&mce_timer); - int ret; =20 mce_device_create(cpu); - - ret =3D mce_threshold_create_device(cpu); - if (ret) { - mce_device_remove(cpu); - return ret; - } + mce_threshold_create_device(cpu); mce_reenable_cpu(); mce_start_timer(t); return 0; --=20 2.49.0 From nobody Wed Oct 8 20:44:14 2025 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2074.outbound.protection.outlook.com [40.107.100.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB5032D5C6D; Tue, 24 Jun 2025 14:16:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.100.74 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774592; cv=fail; b=fq+VNK/bwRe4bpMN1xVNdf2DdfypgWiNXg5Ow30F0TF1lmCKrYTVzZRKMehMl+I8lhjqT073EeyiFJI+Z4wiXLgGlk6QznzZHupZ3OfoYKZsmY23A36B2s+SRCH0iY5sLEYyjtfEeGs79rJBk/ECzFcLQsRCTnS5Ft3BvKQ7Xk0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774592; c=relaxed/simple; bh=lpoQWd7Pp8XM5F+FETb7DdgvFwHNul+KJVE9njrXr8w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=Cd9sINruYup7VGakwWAnJ1N9UGk/QVjYjLhHvHsc+UftfQIGZzAACCS2SrdWd2IEZSLm6v5XMPCBAUkM7Qc5r7Dhb9A0hKGh+i+spLeq7zEKLShJS4PGGzW/qRn7WdGcumXeBrkvSaQ4vw08mwPUWFLwlAZFOfgW53tDC9q6kUc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=pl7u9KtF; arc=fail smtp.client-ip=40.107.100.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="pl7u9KtF" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=euB73dAKIPQ16DwNq0FhXxSRH3nvTFAGcnZVde5mzs9ssS/YsFlWxCrdotPpOzLkBeI3C7XQpwTx7e4PA0mnYSCUa5uTBt8PWqyko5wWNpk6aKyk0hFGs0Qrl3ggC4g5xKHTySCcsY5VwEWefBrlRendo0CJBKnOH1Zrv/jwWE+yq69Ti3mrADgk0+Dk+qWKdFuhWxUlsKB1b/awf5daWjopypMu5AyLhoGOneaHblXYhPd4thwxm5LGW+jGRRwBcrtiSh4oDfhkpxj0Bh2kOg0I7OSgAr1yRbBEfGSMfGy8IwYQl26+aKfeXX+CSrMq8m3Yz/Ut9Ew03tDSBNiRDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/AWv1ZX9mKVaN+qUrGWDsUXeo0f8F2QWrvGnhe7vl6I=; b=gT0THK2lYKDtpPyRI6RAPToGyUr6+S7K86TO6Au0ttRBBeKuwh8Nd1uwl12+rhhj+jsDy125mnKbC7W80TcRU8HHywmooxshDCnfKnGVjvHp0S/tJCZ2WgeyLFzCidpW43IYfcIT/6aUU/5IM1EHA/hw7nbryQMet2Qywf7/tSwxstayanzb0htMns91kZbonL1H+MZsdk9w/bSAk0HXJ4OtndQkucRFjYxzPsjYVgt7DwrlOrzm/VRsIKKjBwQxxDAkjjZ4OuuL+H9uqiynZICXCc0W4MeyUimdZISTISAFgfjLZh4L9QbGnqUwELN73mO7fQmzsCnHrYI0M01zrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/AWv1ZX9mKVaN+qUrGWDsUXeo0f8F2QWrvGnhe7vl6I=; b=pl7u9KtF7/kqHlQQYv5oJvU9PP0t6rJ6juJIMdmGs1nw7c+mBHvlbmM/ijCa08tRJEHBYFTp9pK6Np/nB/Y7hbNpknVANftgBUgbJQcAa3RwPzO8aRDE0snxKRlGAcycNUWb25ajncXzaPUvvTmqACZ36FAVhsaQo34X1FZHzjI= Received: from MW4PR03CA0223.namprd03.prod.outlook.com (2603:10b6:303:b9::18) by CH3PR12MB8880.namprd12.prod.outlook.com (2603:10b6:610:17b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.31; Tue, 24 Jun 2025 14:16:27 +0000 Received: from SJ1PEPF00001CEA.namprd03.prod.outlook.com (2603:10b6:303:b9:cafe::f2) by MW4PR03CA0223.outlook.office365.com (2603:10b6:303:b9::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8857.29 via Frontend Transport; Tue, 24 Jun 2025 14:16:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CEA.mail.protection.outlook.com (10.167.242.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8880.14 via Frontend Transport; Tue, 24 Jun 2025 14:16:26 +0000 Received: from [127.0.1.1] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 24 Jun 2025 09:16:25 -0500 From: Yazen Ghannam Date: Tue, 24 Jun 2025 14:15:57 +0000 Subject: [PATCH v4 02/22] x86/mce: Restore poll settings after storm subsides Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250624-wip-mca-updates-v4-2-236dd74f645f@amd.com> References: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> In-Reply-To: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> To: , Tony Luck , "Rafael J. Wysocki" , Len Brown CC: , , , Qiuxu Zhuo , , Yazen Ghannam X-Mailer: b4 0.15-dev-9b767 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CEA:EE_|CH3PR12MB8880:EE_ X-MS-Office365-Filtering-Correlation-Id: 9fa35c2f-c7d7-4afd-f66f-08ddb329b51e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?utf-8?B?U2tEZGE4REpTR08xSmIrbWlBeXZhNThFNVNrUmpFbnVjNkh5YWdUbCsvTGpC?= =?utf-8?B?dmxZRnNkL1NubE9SdEcrQTNOUkF2U3pGREpONlhadVk5UTN1SGpIU0haVGhW?= =?utf-8?B?dWJIMW1EZjFvdVNTQWM1eDRDc2xHcmlvb3NpcDF0TG1jeHVLZms1anFDTEly?= =?utf-8?B?U3NYanl6QUF3dmR6endVSk00c00rQzZHcG1ZSTFGNTZtalhaZXRuNzM2eGcz?= =?utf-8?B?eDYwQmtnblVnTFN6b28wK0d6U1U2THZqb2x2RSs5aW80eVRtZW93TEpJV3Ry?= =?utf-8?B?cHhpMUREeFpwQlR3TGdUNHpxdVJ5T0o5N1g3clNkcStmYjhtT3dqcFF5RXND?= =?utf-8?B?M1E3bXVUSHVvb0VCTm9OblpWYXkyU1lDUzRhODlwZkZMRkhtWnB6TjBrYmJ2?= =?utf-8?B?RmRNczNPNk54NFVVSFhuTUhoTE1qb1EyRm9wMmZBazVjYzBiK2UxNXhES3FT?= =?utf-8?B?MDl5U1pBL24xcFRSd0pPQkFXMmpjQTNUZXIrc3dVTWQ5TFkzVTNGQlF5K1cw?= =?utf-8?B?ajNzN2FWdXcrMHluaDF3KzBIRlNxdU1CVGxvYVVPU0FEUkg2SFBMWFJXZFZq?= =?utf-8?B?WXZOV2k3WEE1djY4c2dpMHJyM3JKaDFLSnU0OTdseEorNEFtK2Npdm5POUFP?= =?utf-8?B?WmlHaXlRRk5sY0NOLzRqR2JkYkdwWmlDbVY4QTN4RlpSMk5RNnR5bG5oamlz?= =?utf-8?B?MUEzMmlHSk0xZ3pOTWdpR1pvQm52MVl4V2p1emxDVjU3SHArbE0wcFI4UHRy?= =?utf-8?B?UjhtSGZkNlh6VThBeHNNOVhlRHM3SnEyVUhDeGtGUms3WktpVXJZN3FLSWZn?= =?utf-8?B?clBDNVBDQ3BYaVBDdjFTRWl3QThPTUk3Q2pqZmRMVHdSZ2pnbUxmcEptUTVa?= =?utf-8?B?UUFXSVg0Q0U1QUMxSEVqMGM5SGgvK3hVT2p0MXhwdXhYN3BGemY3cUpiTUl1?= =?utf-8?B?eTU5anBLVlVvVkp1ckNaUm0ramg5bm5YanZnNHhNeDRPSEdmZ2hDaUdXYXZO?= =?utf-8?B?NW1Bb2ZRVlpDS05PWEI1NHdhMVJDd1pUTWFNaU9rT3RobnN6U2d3Vnk1Yk1V?= =?utf-8?B?cTVNb1Z5K2RwYWZQMXNwYkhacTltVlZzcEdCV2podEdFUEpUK2xiV3orVTgv?= =?utf-8?B?WUFCVmNIRStCbVdBQThHNVRZSDFSczgrSnJyeERXSXVvOXZFZ1Vrc2VPYXJa?= =?utf-8?B?ME1KSTFyb3Q3R3BJRitnMDZBSDFEZUVjaTFRdk12UnZ6amk0d1VPb25uNFJq?= =?utf-8?B?dnQxWWFrUkZiQkkyeHZZRXlqeTF2bWoyM25zWlVmZXI0N01yUWQ1UTkwcERP?= =?utf-8?B?WGw1WUFVRkNrZHl1RE5mdGxSdk9jU2pOeVh0SFNKY2xobndMamlxamYxVTQy?= =?utf-8?B?RTIwaW5VRFVaVlZmY1QwMkdaTlBEVmRSRlBtdjZZUTVoMHFIUmZMZmhlSDR2?= =?utf-8?B?V0Q4VXkxRFJSeFV4SXZHblVnUFY4N2NDd285bkJ0aTRDMmJnNG5nc1NKRTRn?= =?utf-8?B?QTVhVFdCMlNmWjZoaFB3RFRCYmdXczdNQjZOeitkYTMzUFJXUEFZOWxzYmY1?= =?utf-8?B?ak5pTjlsN242aUtjTWFWamxhQ3U5cldQVjR5cmVYakRjTWZKdHNMRjBibkpY?= =?utf-8?B?UkdHYzAyVk1TbDZGWWFjYUEvRVR4anhJTytRbUNNYmtLREtiZkxwbm5DMUNu?= =?utf-8?B?SDJCNVZ3YTN1ZlFBSE5DZnk2RUZVTUtYWnl3bWdGUW5YWUxvUTltWEJFY2ZX?= =?utf-8?B?OTE2MDhKekRHdHFOVjh3Q0ExV3FBaGliT1M0YXlINjBZbTU3KzlUeXJxVHB2?= =?utf-8?B?T2d3SnBDeW1kdjZUeTNvcTVTZHpVczVhKzlqUldId0NIeG10T09yY203MTQ2?= =?utf-8?B?bk51SkRGdTZWQnZSTnVSYXBoSWZIRHpWenBRNHZPKzBsSWRiR2dxcGRNMW91?= =?utf-8?B?K2g4U25LUDhxMHdnbllOaGRLV3hnSnJvbXdoekwvYUU2WVV1T0k3eFZlQk5W?= =?utf-8?B?NDFleDJad09nelRRN1I0OEprb1d5WHNZazRjdFNIbnVxc3ZIQXMwZjcxajZ3?= =?utf-8?B?a3NpVjliSFhvWmNyVWdibTY5WW4ycWRRamR4Zz09?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(376014)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2025 14:16:26.8863 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9fa35c2f-c7d7-4afd-f66f-08ddb329b51e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CEA.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8880 Users can disable MCA polling by setting the "ignore_ce" parameter or by setting "check_interval=3D0". This tells the kernel to *not* start the MCE timer on a CPU. If the user did not disable CMCI, then storms can occur. When these happen, the MCE timer will be started with a fixed interval. After the storm subsides, the timer's next interval is set to check_interval. This disregards the user's input through "ignore_ce" and "check_interval". Furthermore, if "check_interval=3D0", then the new timer will run faster than expected. Create a new helper to check these conditions and use it when a CMCI storm ends. Fixes: 7eae17c4add5 ("x86/mce: Add per-bank CMCI storm mitigation") Signed-off-by: Yazen Ghannam Cc: stable@vger.kernel.org --- Notes: Link: https://lore.kernel.org/r/20250415-wip-mca-updates-v3-17-8ffd9eb4aa56@a= md.com =20 v3->v4: * Update commit message. * Move to beginning of set. * Note: Polling vs thresholding use case updates not yet addressed. =20 v2->v3: * New in v3. arch/x86/kernel/cpu/mce/core.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c index 07d61937427f..ae2e2d8ec99b 100644 --- a/arch/x86/kernel/cpu/mce/core.c +++ b/arch/x86/kernel/cpu/mce/core.c @@ -1740,6 +1740,11 @@ static void mc_poll_banks_default(void) =20 void (*mc_poll_banks)(void) =3D mc_poll_banks_default; =20 +static bool should_enable_timer(unsigned long iv) +{ + return !mca_cfg.ignore_ce && iv; +} + static void mce_timer_fn(struct timer_list *t) { struct timer_list *cpu_t =3D this_cpu_ptr(&mce_timer); @@ -1763,7 +1768,7 @@ static void mce_timer_fn(struct timer_list *t) =20 if (mce_get_storm_mode()) { __start_timer(t, HZ); - } else { + } else if (should_enable_timer(iv)) { __this_cpu_write(mce_next_interval, iv); __start_timer(t, iv); } @@ -2156,7 +2161,7 @@ static void mce_start_timer(struct timer_list *t) { unsigned long iv =3D check_interval * HZ; =20 - if (mca_cfg.ignore_ce || !iv) + if (!should_enable_timer(iv)) return; =20 this_cpu_write(mce_next_interval, iv); --=20 2.49.0 From nobody Wed Oct 8 20:44:14 2025 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2063.outbound.protection.outlook.com [40.107.236.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E99B2D5C81; Tue, 24 Jun 2025 14:16:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.63 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774593; cv=fail; b=APCeFxl6paOJ63ILEqOQizQrcQvFo+z9KQTEu8dJV7ByuzOqCUoENVZ2kLMNNauxt6jqT5wwJ3eURI8Uv0h1vkXZfQSevtvyVdCRYoPk2FQT4DTfHzRtp9hSaNNdfQl6Sau30Tf2J2lQHyXkmWuLf3bRE23AswwHtmB/BcJ8wm8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774593; c=relaxed/simple; bh=GIZ5GpG5nkVzk2J6ez7Rehd01uIa82RDZuLzTvrggJY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=B3O3d/V630pOuVhpCdfl3WLMeA3lVy7cAhIzwAoaGSsEb1/jlSfYwgMbDsO8qk2GIgfSMaF6G2TXNMV+VFASBGYwmDUXd/y00yTe/MADF/Q5rEfeuN5b111ulnK1ZNW026W6m4nYT701EbKi/GF/WEFd3A3r3qkWrCHqZRV1U94= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=eM8E7w1l; arc=fail smtp.client-ip=40.107.236.63 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="eM8E7w1l" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=peEUZvjheEZDOpAZiNNf8c9Yl7mmJmPqTeHUS0WU2tkLifhwxu8p9GOxJIO4fZp0q8ThsqVjYpa04UxQxCxfG5VN0oh/12U/aeqWESWp0PWjG6kLX08zu+vBY5Ky2/BvAfrn1/sl0tO7X/T7Nk3HUayRc4jmFKMNghc6xBsTzRiGJAQ+TkmWqgeEgVbuFEA5NJBaRkzqrnfa2ooAmMNPuzD3RalpggTUyttSYeFeg8q62W92aZTEPaxv+NRPZ+jcHTXe83x9OrSEQNOcr+Xag3pmsuZVgnsgp6P3uw6HUHv5XDcx/WKukQ3erMMYSiHwnCUiOSaNbfzSsgV3xelrTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=44cokBpdbsJW67lwiFhRqWRNBVt+hMmz4cDEACOmYMQ=; b=h1Y1S6nyobFpZdpKCpeyQ4loajFyEHgrjh/2UvWlkV0yZUt7rn8I1rX+npmLKwlKnnAjha5G8UNEBGGslRVWnZcarAAXDqcFfKpMBikHCv4q8oVq28VTDaMMJxUmzJYLEYLJsHk8TAAZY3ILS3DsB4wzvVlVkmeNHUqO395wd+m+5eBdmIJKlEx+pfm5ZxudTEj7VGj76bz4zlCoame6XiFxh4fg7mgQJai8PnkYf89VcWOvwdrrbwiBQtH2hT5Ecdg5C2K/I3Z5cQyQMf9y9ShQOidnMMjCutEeevz3oLYR3u1w+NKOQ6DyHVhewum5UdrSLpRC/FDEeyqIlxzJGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=44cokBpdbsJW67lwiFhRqWRNBVt+hMmz4cDEACOmYMQ=; b=eM8E7w1lHfErcD3thOCzMB2wuYJxDT3rSCQypNdleq60CLt3tVANSTAOsx8FQmBDMDx3AieJMQ6r9YdUTxleINir0V23zGGm49suEL3JryfxYFctdd1dt2gVtYPcWYpYKMAVtdCA2LrLdylQdbbasHsvEFSzQKmAxPXE6jMZz8Y= Received: from MW4PR03CA0214.namprd03.prod.outlook.com (2603:10b6:303:b9::9) by CY1PR12MB9602.namprd12.prod.outlook.com (2603:10b6:930:107::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.17; Tue, 24 Jun 2025 14:16:28 +0000 Received: from SJ1PEPF00001CEA.namprd03.prod.outlook.com (2603:10b6:303:b9:cafe::21) by MW4PR03CA0214.outlook.office365.com (2603:10b6:303:b9::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8857.29 via Frontend Transport; Tue, 24 Jun 2025 14:16:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CEA.mail.protection.outlook.com (10.167.242.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8880.14 via Frontend Transport; Tue, 24 Jun 2025 14:16:27 +0000 Received: from [127.0.1.1] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 24 Jun 2025 09:16:25 -0500 From: Yazen Ghannam Date: Tue, 24 Jun 2025 14:15:58 +0000 Subject: [PATCH v4 03/22] x86/mce/amd: Add default names for MCA banks and blocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250624-wip-mca-updates-v4-3-236dd74f645f@amd.com> References: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> In-Reply-To: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> To: , Tony Luck , "Rafael J. Wysocki" , Len Brown CC: , , , Qiuxu Zhuo , , Yazen Ghannam X-Mailer: b4 0.15-dev-9b767 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CEA:EE_|CY1PR12MB9602:EE_ X-MS-Office365-Filtering-Correlation-Id: 8e3e9329-3daa-47b3-d0b6-08ddb329b59b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|82310400026|36860700013; X-Microsoft-Antispam-Message-Info: =?utf-8?B?QXVRZzllWDRYNEh2amNValhWRW0zQkV5ZWk0R0U5NWZldTc2QmFzdGdXeDBv?= =?utf-8?B?amQzZ0N4Y3J6NlZqb0tSSG55ZUE5bk9RSnF1ZzFRMTRkVlc0MWRzdEZFUGVP?= =?utf-8?B?L1pqSXJuN2FSSmZaZHVBTitndy9GTkhnckdESnd4OFdPT2FQeVYvNFpsRzFG?= =?utf-8?B?bWNCOVV3a2ZwK2pNZ2FMOCtWa2gwVmhsT0tvS3FXdGZ6b3RpMitIRmdzUXha?= =?utf-8?B?b3RwMmRJTWpWYzZXcGI1ZXpLWG10TWVFejVZeUo4ZlduS0Y3dmRSampoVUJ2?= =?utf-8?B?Vnl1amVSN05lVThsZUswbFRRdFI5eG50SGxTYkpHTHdva2ltalpqVmJLd2Fr?= =?utf-8?B?cVl4bERxN3luVDVQcENRYUlpY2VsdDRHRjJOMkFoL2w2YzQrdUF0TWh2Zi82?= =?utf-8?B?NC9QOWF4UXR6b2dJNXZ5YnVOSitIeUNwTWZSL1JHMEZiMEZZd3JzUHdUS0Jz?= =?utf-8?B?S1hXeHh2NmZIcHpxaXZWSllyWThhV0d1ZmZMWXEweEYwbEhVbG1Eem5qMERl?= =?utf-8?B?NGRkLzZFWnNaOEpLd0Zvc2xkYWJyT0wyaW5ENUFic3VwUm5XVDlTUGNmck5N?= =?utf-8?B?bkx1WnBaNVJGTzV4N1BRK3lIcytzSFlLVUN0SmN6bEZTeEFVSDdQY3hDRThz?= =?utf-8?B?OGpQN29JV3VrcGRqdHZiRE1Eb1ZsZmhjcDJMQWgzU2xQTkpvR2xoNmR2Vk4x?= =?utf-8?B?RXprL2o1aC90TWdWVmxNbWR4cnc3REk5UXNFanRLNHJLSXFPN0phSlFITDhI?= =?utf-8?B?WnRlcDJwQkxzL2QvRkU0d2ZsWmZhemFQWHQvVGJreUVHZG9WVjJDeGpqWnc4?= =?utf-8?B?cllWb3d0ZDMyREVoa3BkNm9rNHFFZWFGOE5mNzVqTkdydE0rSXVSd2lhQlZF?= =?utf-8?B?ck4rU3dmcG5QOVllTHpGdkJ1TWNNdjRlYjNBL25nbkFGUEhaUkM4SUhvZ0hV?= =?utf-8?B?ZFdONS82RjRiSGNoNU16alZDelg3T2VWYzY3c2pJbEFiUlRZN3F6a2tQMGpP?= =?utf-8?B?bWl4bWJwSUdaRy9EYWY2bnBxT0lEVitOS2FmWFZ4ekM0dkRKTDNxbUZ0eXhP?= =?utf-8?B?dHJmeWhjVjA2Q1kvb2ZpeU8wMXVsS3kzUHRKUUJCQWgrYWMzSUF5RURRVDA1?= =?utf-8?B?QitSdFdMOE5ObWQzUnpxMXNaSlFoU3g5bWtkYzZZV2s5WHhHdjRPUTNWRG5i?= =?utf-8?B?d2l3S0llOHM0K3drazZraGFJMUN3MlBBLzg2TnZFakFsZld6WUZkMThIbUxj?= =?utf-8?B?bVZsWHJXMWJJYndpMy90NzRuM2VyZkxkdlRyMi8vcE9RMUlZRnpHMHpwV3hJ?= =?utf-8?B?ODlVc2tmdTRQeTd4OEZVb0RLYUhLSS8yL0FPOGdrTTZMNVVhUFFHdklyLzRP?= =?utf-8?B?czl2VUNBNEFLQTJDRmtqMTdUZnhJbmFDUmhYb3hFYkZyS0sxS1B3SkptVkpB?= =?utf-8?B?eDkxcUs2OUlsQkpGWFdiaHBVOTJoeGg4YmFBeEI0OUkwVjN2dVZBMzJwdkV5?= =?utf-8?B?cnhjQ3VFc3lDL0JnaUh6cjdkZWdPRTVCYzVhWm9iS0lBNDJkVXNsengxbnBC?= =?utf-8?B?Z0l3cEIya1hLTlkvV3N6YVc0OEs4dytnb0RISkJuWUtDRm5CTkE0WlBEbnNM?= =?utf-8?B?UFhXNkJCYzQ0ejVRWjFialZBMzlXclRoVjdWL043WkRXL3g0cXhweDdLOXpi?= =?utf-8?B?SzdpMkdnMTVXL3ZJUlJVZ0xXS1JwZ3BjOHQ1NVNYOEFOd21qSEc0eU9NTmJ4?= =?utf-8?B?NE9BaDJGL3hmdW9pRXUrVFZXSnVHcFVzcXQrMUQ4a2pZMXMwWDVEWTJjL0hV?= =?utf-8?B?WEsrWUNjd1BvdTBUdkhKdUVTYXN2RzFzZUdYTXZrUHN5RnpZRXM2MTRFR1ly?= =?utf-8?B?cVR1a2x6STRhR0U4SHpnTTFZU0xqZUVtU2U1cHhKd252K2NZWm5ldEFmcWt1?= =?utf-8?B?OGVyQXlNeTJBMWJCVVc0RHF6RkozSTBONmpIemV5QTBDUldVeURBZzhXSmg1?= =?utf-8?B?UWdhUHh2b0V2MGtlMk5ZM3R0NFNZWTNEN09FWWtiTlBVY1B2VmJvVFlIbW1V?= =?utf-8?Q?eGwq0d?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(1800799024)(82310400026)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2025 14:16:27.6926 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8e3e9329-3daa-47b3-d0b6-08ddb329b59b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CEA.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB9602 ...so sysfs init doesn't fail for new/unrecognized bank types or if a bank has additional blocks available. Most MCA banks have a single thresholding block, so the block takes the same name as the bank. Unified Memory Controllers (UMCs) are a special case where there are two blocks and each has a unique name. However, the microarchitecture allows for five blocks. Any new MCA bank types with more than one block will be missing names for the extra blocks. The MCE sysfs will fail to initialize in this case. Fixes: 87a6d4091bd7 ("x86/mce/AMD: Update sysfs bank names for SMCA systems= ") Signed-off-by: Yazen Ghannam Cc: stable@vger.kernel.org --- Notes: v3->v4: * New in v4. arch/x86/kernel/cpu/mce/amd.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c index 9d852c3b2cb5..6820ebce5d46 100644 --- a/arch/x86/kernel/cpu/mce/amd.c +++ b/arch/x86/kernel/cpu/mce/amd.c @@ -1113,13 +1113,20 @@ static const char *get_name(unsigned int cpu, unsig= ned int bank, struct threshol } =20 bank_type =3D smca_get_bank_type(cpu, bank); - if (bank_type >=3D N_SMCA_BANK_TYPES) - return NULL; =20 if (b && (bank_type =3D=3D SMCA_UMC || bank_type =3D=3D SMCA_UMC_V2)) { if (b->block < ARRAY_SIZE(smca_umc_block_names)) return smca_umc_block_names[b->block]; - return NULL; + } + + if (b && b->block) { + snprintf(buf_mcatype, MAX_MCATYPE_NAME_LEN, "th_block_%u", b->block); + return buf_mcatype; + } + + if (bank_type >=3D N_SMCA_BANK_TYPES) { + snprintf(buf_mcatype, MAX_MCATYPE_NAME_LEN, "th_bank_%u", bank); + return buf_mcatype; } =20 if (per_cpu(smca_bank_counts, cpu)[bank_type] =3D=3D 1) --=20 2.49.0 From nobody Wed Oct 8 20:44:14 2025 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2081.outbound.protection.outlook.com [40.107.243.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 208EE2D8787; Tue, 24 Jun 2025 14:16:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.243.81 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774596; cv=fail; b=P511Pvwz2s/ROx7BFvFr5UCPeBNgLVCKJ0DktZsA4q48l7ARmTxTmWdk8RN34w36eCYNjQDvhNQNl087zVT1g793uQsywaztlSb1WtgBwFoO2fUCqBhC2FYUa7RXjmCPgOy+KZFr8B8rCDLOe2uDEJ7U+YO71ezVJ/k95RY5OAQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774596; c=relaxed/simple; bh=NgvHgEEOHL7Ms24hWu+Nq8hgrfxwlcM9+jjHF/zn8SQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=lCrAIjJLiz/W5ry4VayWdcaKyzQnc7/YCkoxLk4xpdoAtUvraM43vXZHFz2l2X/piuwgbr5bsvOgHqPupPXz6gwdYmfIdytB7i7anT2j5V9MDWgL+D/6ZrkxM0a2+p7r36oImoqKB72ZwTRq7zGA6zQancfDfmm65HTCFsrOdSk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=p3W+r9zm; arc=fail smtp.client-ip=40.107.243.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="p3W+r9zm" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xSw6404mWvG0bMuR7h8b7qh0TyyeJZbdT4Yjdv0lqUAeSMS8JrdNe1asefkfTu/HQ1mHzwLitu06dprTW09PWggmQw3RXfATG6Djp3gE24s+MJRjOjbt1kop/LMYDyb/Sy59EqL3ZAgiuv7JqWGl/qE1W1UCM4WuAfR+wrTuttz+cHsD0AqUyLk+8IeGqQTKfNiyab78IZIjvE9zRmXNMdRS1Nv8idrecXDnkd8lO1KtyIklH0woZCEL5XV5BxzZbjkavOzo4NgQJNqT1cASBbnOZ0A5QdbzSG//VvlhXyA3hPzYI3QYEkHLa+APh4HCsmX7/wzDeFubVaQZxIngxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FfanEZymOX1nYK8d4M4pL27vO0XShk1kDIJ2f9BcQWg=; b=bPJQVm8eP6P5t+DnFmnYNhFmMJDQcVUsyjhTBMPH/ogXIEDl/GtJUCYIUoJtor9IGr6FAkNFmFZrWlGRKwC3VVl5tQ3FIquKSUILqwfYJCsocEhigpHJG8Mb9qeEq+tNvSqqSqE9FHcTqA97feVww9Pbbmmg3n9JnSi2oTHtb5vg1pqZ/XpHLwiC7ke28zG8WhK03EvZbiRLWP2PeVS7bnEVp011WlO/42XPkv2SJfDYy2aw3NbNaUHWWVzw7NjtKcPBVySNoSjeI/16bTwqpqQ1UDurM1RCbK6bsvVlwfNOERmxDM5hnwOAnaxu3xcXAlv+/R6265V9JptRX1WuMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FfanEZymOX1nYK8d4M4pL27vO0XShk1kDIJ2f9BcQWg=; b=p3W+r9zmfSqfIWgmu3gXYRuqpbGFEdlpFXZKYenDzXWiGWM52jmXdi776YsDJmQFDWRaYl5ZY9SsHKyPIU5pkbmKdWUAUO8sIMYVOwauiQGXPoMTh4+RS2Qj4GhGngcfei/mFV8l060OBKrm1xWtIKGInDaWVrbWRnai33t/39M= Received: from MW4PR03CA0232.namprd03.prod.outlook.com (2603:10b6:303:b9::27) by IA0PR12MB8862.namprd12.prod.outlook.com (2603:10b6:208:48e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.28; Tue, 24 Jun 2025 14:16:32 +0000 Received: from SJ1PEPF00001CEA.namprd03.prod.outlook.com (2603:10b6:303:b9:cafe::ea) by MW4PR03CA0232.outlook.office365.com (2603:10b6:303:b9::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.17 via Frontend Transport; Tue, 24 Jun 2025 14:16:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CEA.mail.protection.outlook.com (10.167.242.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8880.14 via Frontend Transport; Tue, 24 Jun 2025 14:16:31 +0000 Received: from [127.0.1.1] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 24 Jun 2025 09:16:26 -0500 From: Yazen Ghannam Date: Tue, 24 Jun 2025 14:15:59 +0000 Subject: [PATCH v4 04/22] x86/mce/amd: Fix threshold limit reset Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250624-wip-mca-updates-v4-4-236dd74f645f@amd.com> References: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> In-Reply-To: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> To: , Tony Luck , "Rafael J. Wysocki" , Len Brown CC: , , , Qiuxu Zhuo , , Yazen Ghannam X-Mailer: b4 0.15-dev-9b767 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CEA:EE_|IA0PR12MB8862:EE_ X-MS-Office365-Filtering-Correlation-Id: efbc86fd-51dd-4b44-69c7-08ddb329b7c8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Vm81Q1pta0w4eXhnb0s2KzhOTkFHWDRoc3dFc2lrUm1meUxYbHJRaGVxWmtP?= =?utf-8?B?Uko4emxOM1BIQ2xQcG5nV0FTWkQ0N3IzZnU2SjdjN1U0RVJ1Q1lyZ3pmRGo2?= =?utf-8?B?TmpBakFPWlNKQUJBZG8vM2JlRVhTZUYrYmpwTlZHajh6akk3dFdNWXdvZSsr?= =?utf-8?B?OStzNlk2U09UemFac3U3VmZlMC9jeHJzUWk5bURzaEt5S1Jod2UwOW9YTU1s?= =?utf-8?B?N2VrTVpVMlFLQjBIU0gwaE80eEZTdDRadTg3enlnK1pJZW5MbHRlZUhMajVx?= =?utf-8?B?cmE0UC9lK2Qxb2ZoSVlwNFpZalV3cXJiWkJrbWxXaVBEak5xV1hVWHJqMkRw?= =?utf-8?B?dnR2c2FKem13RVlrYWVOTmFQUnZtVDdXcmdMbUZzZDlNdHpRUUhOclBadFRj?= =?utf-8?B?VDc5bGlIdXFSRFVOVTlnbEJYbTgxeXhDa0pFbHZ1RmNGdXVXUFYxU2xKRHZU?= =?utf-8?B?dGRKLy9uaEdPdjBDaHBEaHhndnh1YTM4Q0ZNYkwzYTEweWVpd25FWTVldWdz?= =?utf-8?B?OGl3WUV2WGhJRGlwZENDOUVaTlhEVThaTGU3SDdocERzMUo5OFZ1WFFvQXps?= =?utf-8?B?TlZMZ2lwaVlwV3VidkFpUGxzeDNkazljOXFJdWl1WUJwTkxmT3hDNTFxY2F4?= =?utf-8?B?RndBLzVYK3VFMnk3bkh2bDVnYTRxNmE2by9OaWxGYzY2Vjc1OGxEYmNDcDVN?= =?utf-8?B?eXVxYUxCdm9rTW5JSG1uSFZxeTFHOTkxY1dMdXk4MkNSNlVZM0FtbGV6V1Bv?= =?utf-8?B?bmM2cEtlbDZhWWNaMEZRVStWWnpTeXhMY01ZTTd3Z09NUkxyZlZWQUFFVTlm?= =?utf-8?B?WUwvdVd6MUptbXkyNW11RFlFVVJ4cGZtc0tENWM5Vy9scnduTFBnekJrK3FV?= =?utf-8?B?cittZjBQWEhXYWkzTXdVcXc0a3d6MWNnejlzS0pBQllzMVJKZnFXUVFCejZ4?= =?utf-8?B?UEd0QVhoWEV6dWFlQStxOGNhNVFKQ2dKZDNyL2ZvbWlkUm55ZEZlMmp2ZjZj?= =?utf-8?B?QjhoZmNjanc2cG1yRjJtZUdDVXRWb0tmVWVxUno5V0JoMFFPNFhJWEt1b01J?= =?utf-8?B?eEZwb1h5alUzU1phWkx6M3hXV0NzTmZ6SzFobW4vM0h0aElXSDF4T3Y3OENS?= =?utf-8?B?c0lUdWl4NkdEN3hCSHNMQUNMOEcyYWk5ZmlQamlEeGIxbk8xeVQ1SFVLZkdE?= =?utf-8?B?RmhtVU5SMnlWcU0yQmhURzkvVk8zR05xV09vdjBvYUM1QzRjcFlzUm5xUlRw?= =?utf-8?B?aUNOM2dFOXBrOC9iU3hLMTVrSDd2NnkwcVpBanNZNlptOTNjdnJXaEhieXpo?= =?utf-8?B?MC95UCthOWd2QTVmZ2l0RmpQSVZFN0oyc3NMeDNvV1NzWStCQWxmUzc2eUVq?= =?utf-8?B?SFlGdHRCaysyZm9WOGY2aCtoeEJEa2p3Z1ppMVEzcGFWU1BEd3VXeFFhUE1V?= =?utf-8?B?ZHhiaFpHYWdWNmJSbWdDcGE5SHoxOEZJUjFHcWpuYWJNNnA5dkpSeS8yZzNj?= =?utf-8?B?VS91RzJITVlvUnJtcUYraFFEMGVkZllxcndnR2Rrd1RaNDNRQzZxWlNTQkEw?= =?utf-8?B?b3BZWk11d2VzS0h3clJRNHlyRWNjMnhNelFOc0h2TUFsK3UvNVV2QjNGVTh6?= =?utf-8?B?VDN3VUljeVBMZEJOUlVORVpmKzl5N3AyY1J0ZnprVG8rdVVOZldLNnhmS2x1?= =?utf-8?B?UDRxTVIxbkM3TlRRYU1nWDhvM0JvVWFEcnRCZ0p0a3lHWmRQdFJJNXRVSk5W?= =?utf-8?B?S3Zkb2lrSnJHSnVZeXEvOHQxSkxHVzQvTmw3U0tQYW93bzN0NkRTUlNlVTh1?= =?utf-8?B?a2FHK0FnNlFIeWFtaEVIY2tnN0RRYVdOY1NLMEovenRMUWI4WGZSRmZobFpG?= =?utf-8?B?dWpEUFVyWmRHK201Vkthend0UXhPRldLY3lGL2hlOGNBY0U4Vk1kVldwbC9N?= =?utf-8?B?T2hpOUJNRnE2MDNqRWJJTmhoV2FhcmJYaHEvRkp4YlF3OHNVdHJ1L0grMGtY?= =?utf-8?B?Mlo2L1N4dnpzZG81SjczNU0yZm1zdm9SS0NqUXdXckV3amZxVzhFUjdtSkJT?= =?utf-8?Q?4ZvnLX?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(376014)(36860700013)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2025 14:16:31.3530 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: efbc86fd-51dd-4b44-69c7-08ddb329b7c8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CEA.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8862 The MCA threshold limit must be reset after servicing the interrupt. Currently, the restart function doesn't have an explicit check for this. It makes some assumptions based on the current limit and what's in the registers. These assumptions don't always hold, so the limit won't be reset in some cases. Make the reset condition explicit. Either an interrupt/overflow has occurred. Or the bank is being initialized. Signed-off-by: Yazen Ghannam Cc: stable@vger.kernel.org --- Notes: v3->v4: * New in v4. arch/x86/kernel/cpu/mce/amd.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c index 6820ebce5d46..5c4eb28c3ac9 100644 --- a/arch/x86/kernel/cpu/mce/amd.c +++ b/arch/x86/kernel/cpu/mce/amd.c @@ -350,7 +350,6 @@ static void smca_configure(unsigned int bank, unsigned = int cpu) =20 struct thresh_restart { struct threshold_block *b; - int reset; int set_lvt_off; int lvt_off; u16 old_limit; @@ -432,13 +431,13 @@ static void threshold_restart_bank(void *_tr) =20 rdmsr(tr->b->address, lo, hi); =20 - if (tr->b->threshold_limit < (hi & THRESHOLD_MAX)) - tr->reset =3D 1; /* limit cannot be lower than err count */ - - if (tr->reset) { /* reset err count and overflow bit */ - hi =3D - (hi & ~(MASK_ERR_COUNT_HI | MASK_OVERFLOW_HI)) | - (THRESHOLD_MAX - tr->b->threshold_limit); + /* + * Reset error count and overflow bit. + * This is done during init or after handling an interrupt. + */ + if (hi & MASK_OVERFLOW_HI || tr->set_lvt_off) { + hi &=3D ~(MASK_ERR_COUNT_HI | MASK_OVERFLOW_HI); + hi |=3D THRESHOLD_MAX - tr->b->threshold_limit; } else if (tr->old_limit) { /* change limit w/o reset */ int new_count =3D (hi & THRESHOLD_MAX) + (tr->old_limit - tr->b->threshold_limit); --=20 2.49.0 From nobody Wed Oct 8 20:44:14 2025 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2056.outbound.protection.outlook.com [40.107.93.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2D0E2D8796; Tue, 24 Jun 2025 14:16:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.93.56 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774599; cv=fail; b=UaNintQgzmo5wPYmDUJAoWfY31BFZapFeuLawmK4tAPyFP4O53hyq8Fqgvsg2MT00lTIVhieI++HROq0gKhhqk2vKrqaBHVqOpZxVyOAsKxZZc/thLgBdmOgnzRIFmfPHL00tsyFuPZ/MuJh2gV53IBMBSZsBEKuGtJQGGelJ38= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774599; c=relaxed/simple; bh=U3CKZ8tT86xJfMuxj5j9CKO6AdnKEhOXl+GsViWSCNQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=f/BbJUynieoJ5wIsFtcZOZq0MFzfhoTqB15p5tOLb/BudbsV5/kDj429gUY2pKYxxh8lFn30cBj+k8ByWusvZDhz+gXvvPY4hueFuLxZn0tD/XFfyKDNsxUEw7UX/X6Z+8W2LGKAZDJjHp8YAiuwZzWg+oFE49aPzjGPrlRPn0I= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=5p4BKVxE; arc=fail smtp.client-ip=40.107.93.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="5p4BKVxE" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qygwTz31pQ5iXnVmAjC1AHZoPhHHBv2i2WpSZfCkp9YK5pwRuarziwRTim3bgbFe8S71IhPDumY7Np5CRi0mDZmWan/IPJYws+s7aMsRsG2lILqqx8nKeTAmNrsldfjTwMSWyga6uEHWn4EJJJwoRGjh6Vaiz44m5qls9JJkxeWQRiQwQx7NFCsTBZxugQmNNhAyeZ3Ik3OtXzWapmPkeBLKw7zKPzbLXIkDHkQItgmT+hHchrL+eCFI47gbSIoT9VerzpKVHmAPp7Tkw8ZiLCaaT8WuvNgL+3G0J550AjM/f7jLBLziMmoEGsfq2lf25rxV//0XuwrEHFPgICoL1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/t4Lc70LKiod2oQMEiR7zJ1v7IH0tyXTmniU3fFqoiw=; b=aVvMwixx91OcsJWbbNqAdAaQLJ06eq1yXVPR0omrKEkauWpDIkdTNtKURqQo6i5ZUfSnKsEOnr/8PHUItwf7x4FO/zf/iT+BWsa33rQX70japfibJrRNVFpQY1X6X7VNLac79GWvVKlw7Vg6JCbMMafCuoqeqe95gvlGgSwfZlTFnu1NdgGbIcwC/6pOnHjuNY0M2FkSDKn3LycA3x2WLCGHhjavrDL1u7Abgjvv6n9bfnSUUXmuKFLZqkjX9ZsnSTYEQKIwYApxHF6kUSyGhHsvGjzNvs4U3X542HNQ2aJn+lGUFkr0Ifnjzi5oBPpNmHYKDWkaC+WYwqiyZ2R6Xg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/t4Lc70LKiod2oQMEiR7zJ1v7IH0tyXTmniU3fFqoiw=; b=5p4BKVxE/931tZZC0QfIJOws8JAk3qMSO3e6dvidXithofqty+1/Y/jEExYnWnzaX3BsVzSwpbnWOwc5kzTz0lCu1a7Y7eY1/k+tBd4+Z868Z32Ho11CL1Awb5fzzYJ+tlD07JSLD5an2fhSd/o0ddssPBEys4fmMSZ9FaLumGg= Received: from MW4PR03CA0232.namprd03.prod.outlook.com (2603:10b6:303:b9::27) by SJ0PR12MB6685.namprd12.prod.outlook.com (2603:10b6:a03:478::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.28; Tue, 24 Jun 2025 14:16:33 +0000 Received: from SJ1PEPF00001CEA.namprd03.prod.outlook.com (2603:10b6:303:b9:cafe::ab) by MW4PR03CA0232.outlook.office365.com (2603:10b6:303:b9::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.17 via Frontend Transport; Tue, 24 Jun 2025 14:16:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CEA.mail.protection.outlook.com (10.167.242.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8880.14 via Frontend Transport; Tue, 24 Jun 2025 14:16:32 +0000 Received: from [127.0.1.1] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 24 Jun 2025 09:16:27 -0500 From: Yazen Ghannam Date: Tue, 24 Jun 2025 14:16:00 +0000 Subject: [PATCH v4 05/22] x86/mce/amd: Rename threshold restart function Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250624-wip-mca-updates-v4-5-236dd74f645f@amd.com> References: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> In-Reply-To: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> To: , Tony Luck , "Rafael J. Wysocki" , Len Brown CC: , , , Qiuxu Zhuo , , Yazen Ghannam X-Mailer: b4 0.15-dev-9b767 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CEA:EE_|SJ0PR12MB6685:EE_ X-MS-Office365-Filtering-Correlation-Id: 2614d55a-850d-4bac-7fb3-08ddb329b8b8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dGZTWlBpYmJ3eUUwYzJZRGQvYXBLb1N0a21YU2ROakhVK1F1cC9UZGo1RFFJ?= =?utf-8?B?TFRMY3RmLzlVbCtob2hCYjBtV2FwV25OWjJnTmdzQnRnZUhmSmZDYlN3TlNT?= =?utf-8?B?Z0V2MWlGalIyVlhrNzJnMGJvQjdadkpyTUNjVTBuTEtQcndVZDdWWUJvaHd2?= =?utf-8?B?R1RMT2ZBaERZanZHWDF3NWN4LzhkM2ltUU9qL0lCaU53SFJweS9ocFlVbzRO?= =?utf-8?B?eW85NXdCMnkvNkp3MFU2VFluQnd0YWR4Ny96QTRmNTA5cUh2TGs0U1JydDBM?= =?utf-8?B?MUZiQlpoWW43V3dMb3hqS1JDbnRjY3NjdTJnLzRPcHFKWFVWeEtsTWVnZWI5?= =?utf-8?B?VXVkY2lSL21reUtMcDB3MlFPZFM4T1FPQnhJSHRTU04xemZ3K2piaklVcThM?= =?utf-8?B?S2dLUm1mMFZTZUhRN1hYSDdjbit2cEpzc2tUOHZaUTlsS0tEcWpIeFhPbVNE?= =?utf-8?B?THRuMWJQWGFWMmNHUEs2M1R2dHVtd0Zua2EwTVdZb1kxUzZtdzViNVhiZkJw?= =?utf-8?B?WUNSWXhtUnJhK25NSGgyNUdTc1FzOXp3ZVpRYVFrdXUxKzZZVHdqVldWM2Jq?= =?utf-8?B?M0hVaGpuMHRhck9Kd21xeXlPT3I2aVdCYkFQOEpIQzU2MVllWlI1ZFR2YzhC?= =?utf-8?B?aXpXME02WWI0M0tYMWpWeEdXYmFyU1lKZzV6QW1ubS9TSWx1WUFNekorbU1k?= =?utf-8?B?WGR4UFFpREZ5enVPOFFlSTFXYjFtVDcxTkVOcThsdVl6QjZSdFJSdWxYMUIv?= =?utf-8?B?c3BpejlJNG1HU0JTYnNCOW5TYUoyRDNRcVdHWkQwQ3NkMWRmZWx4L1Y2eERl?= =?utf-8?B?S25FRDZVbTY4djhXYng1U0FXM29ZTXJSa1djdFUvQmFPOUQ4MDBxNTJtdkhh?= =?utf-8?B?cEVraklLV1JYUWxvVFBuSnVXd1UweVBjUWVWejBkR1ZiQVlpNDRpbHl3T28w?= =?utf-8?B?d1Jjb0ZXRlE3eXpSTThnTndGeVB4SE56a0JzTXpCTmZNL21RNW5rbDkrUHJs?= =?utf-8?B?ZEVUWW52aERUWWI5Y2Y5SVdFS1M0ek11SjZMZFVoSks5T2ZoaFgzTFNOUDJV?= =?utf-8?B?N0N1Vjc0MnNnUGdTa2hRbmplSFluUXNPL1czWGg5U1RZSXJ0TFFUTkFaTEZF?= =?utf-8?B?REh4RnpwZ2ZvaDYvc1paS09xR2Y3R0ZVV3hKVzh4MktvOWYxNXZTSTRmaDAx?= =?utf-8?B?QzJJR2syZU5LR0pmQmJnak05VEdFOEMyajQ1NmFEZlliVjUxeVJwYnBLUjJs?= =?utf-8?B?WG9ZREpSQ0RBTmxvMDVldEtacTlvcFBhaExsUUZLZ2ZyRFUvdzJTRGoyMFli?= =?utf-8?B?RHBqd3FINTQ4QmcyNmVvSGdXcDlKRXBMWmMzdG1tZzBPOWNpdUo1UEc3Vm5Q?= =?utf-8?B?aC9Mck9zNWtXbUgvdlhmcDRaZXI2eEZCTzdEZXNQVFdoTnQwaGF4S0xzYng5?= =?utf-8?B?MEhPMlNVRlhOcVBMaDNDQmJPSlBrTUFsUzVqQXIxZk53VTYwd1NaZDJiclB0?= =?utf-8?B?R2lpS2pnRGZZMDQ3dnVydng5VFRKMDVEMThvTXdpNktodG43UXh1YldZeDNv?= =?utf-8?B?NFgydW0wZkV0RTRZTWd6bFpaV2V1QVJwRnFZNzZIWlVLT0kxUEgwaElQTmVu?= =?utf-8?B?Qm1BcDlPbXhRMkgzbUVXajZBbVlDS1VXY1pDWmhyQkw0cnlLdGlKVHh0aTM1?= =?utf-8?B?eE1YbVBnM1JrTHFyWElyS1NXeWVReElmbkY1Y0RyVkhzc01wS3FFVWxCUWVw?= =?utf-8?B?dmE5MFRGV2I4RUZ4YXdKaFBiL2s0a0RKZWtnTnFkNW83RWE4YlNvazNxcmd6?= =?utf-8?B?WHliWGhacXFnNk5jN29hbnJ1K2J2am9qWGEvZmtjVnl5NWxQMVh3NFc3bkdS?= =?utf-8?B?Ynd6NjNkZFNJYnFrUkFEQjYxb21TVllwaXFnUlI3bXpKNktpQnJITGpYQlJa?= =?utf-8?B?WnZWMlpVbUlpSmxOM2E4R1lGRmxHT0JEcDd0QUVhWjZiTjJDU1ZDNFA0RXJn?= =?utf-8?B?b3A1TFlWZ09pN2MxdFBnMmZ2ZjcvRFBGVExVSkY2MWJlS1NQV2ozNTBPdUpQ?= =?utf-8?Q?hLoHXk?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(376014)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2025 14:16:32.7529 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2614d55a-850d-4bac-7fb3-08ddb329b8b8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CEA.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6685 It operates per block rather than per bank. So rename it for clarity. Signed-off-by: Yazen Ghannam --- Notes: v3->v4: * New in v4. arch/x86/kernel/cpu/mce/amd.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c index 5c4eb28c3ac9..9b980aecb6b3 100644 --- a/arch/x86/kernel/cpu/mce/amd.c +++ b/arch/x86/kernel/cpu/mce/amd.c @@ -419,8 +419,8 @@ static bool lvt_off_valid(struct threshold_block *b, in= t apic, u32 lo, u32 hi) return true; }; =20 -/* Reprogram MCx_MISC MSR behind this threshold bank. */ -static void threshold_restart_bank(void *_tr) +/* Reprogram MCx_MISC MSR behind this threshold block. */ +static void threshold_restart_block(void *_tr) { struct thresh_restart *tr =3D _tr; u32 hi, lo; @@ -478,7 +478,7 @@ static void mce_threshold_block_init(struct threshold_b= lock *b, int offset) }; =20 b->threshold_limit =3D THRESHOLD_MAX; - threshold_restart_bank(&tr); + threshold_restart_block(&tr); }; =20 static int setup_APIC_mce_threshold(int reserved, int new) @@ -921,7 +921,7 @@ static void log_and_reset_block(struct threshold_block = *block) /* Reset threshold block after logging error. */ memset(&tr, 0, sizeof(tr)); tr.b =3D block; - threshold_restart_bank(&tr); + threshold_restart_block(&tr); } =20 /* @@ -995,7 +995,7 @@ store_interrupt_enable(struct threshold_block *b, const= char *buf, size_t size) memset(&tr, 0, sizeof(tr)); tr.b =3D b; =20 - if (smp_call_function_single(b->cpu, threshold_restart_bank, &tr, 1)) + if (smp_call_function_single(b->cpu, threshold_restart_block, &tr, 1)) return -ENODEV; =20 return size; @@ -1020,7 +1020,7 @@ store_threshold_limit(struct threshold_block *b, cons= t char *buf, size_t size) b->threshold_limit =3D new; tr.b =3D b; =20 - if (smp_call_function_single(b->cpu, threshold_restart_bank, &tr, 1)) + if (smp_call_function_single(b->cpu, threshold_restart_block, &tr, 1)) return -ENODEV; =20 return size; --=20 2.49.0 From nobody Wed Oct 8 20:44:14 2025 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2074.outbound.protection.outlook.com [40.107.92.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 892032D8DCA; Tue, 24 Jun 2025 14:16:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.92.74 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774600; cv=fail; b=ALL9ip6i7duF3WPoNXlglgy5/+CcMMJrO2dmRtwhdRCnshnUCrPi9Jx1pAmVHaqrN3YneTSvQgHmM7EM3nssxsLb5lO8NdCv0xzBOypdtyHtPNKBtXzqhaKPtFeqhWU7RbpoCs6ZFFSpSbQhZK54yzlzcG0UhK1qMknYpGZRmVM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774600; c=relaxed/simple; bh=iM4IeoBSLfNLdDNV8Uh9yNb9yCgMFwGJp56rbz/SomU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=IPVeCKXGg9O3q+UnvLsr43NNXSFO4Bl8q0/l4cO/KgjKZetCQ7Pglbz/+WzHgidYCmllb9A9f7zaTOokAwlIq+K7IA4RCl5RVHWZIHrBbETz9QW+CoTTqgFvGB4LQPkbCvbgPMxywmn75PZQ88y+ooIS+2LR86dnrPdOJmS/m9c= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=yhWffdNR; arc=fail smtp.client-ip=40.107.92.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="yhWffdNR" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qJP0jZHwrAdQfZHnfq1iPmXyaa5o9Sx4pT3ejAj626HhRvFlg8ksAIikzkZjMFDjpQuYErhwL+0AZ3CFlKDlycL6t2FAAEAMWD/m6PILMD76BkiWLmkVuRlYqTyQJX8Jvb1W0WrOSGbNoDhnjfQIfP+1kibd9crjzFmi2Yb7ZKRwAnHqx86kp3nqCXXvTliJJCbMztz1KTlgRWYV64BYRTEM11+lrEqYouyNbcl4UeY1iQWLUVhYleyQvRLeHskmKoxcUIY7HcmTRwfRCRDlXnEauwnZqqTx0IrL7J+VNyNXU48F/giSeMsyIC7dyFASVkVp+K3wHyKlJMC8JAQM4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/o2npA2IvKqnzMTPRJK6I6MLyrofA+2YttuJAqDZ3xM=; b=oNzct5Duh7n4NWXykJnsdi1EIsE2GwQ9/gEKwpAARq/rx8O3g2QOwL7PZjOgSqUGwlLLpjLZ5PhKYUGgKfDqGhpM4M29aMqR559Y2SHDlIEF1SuRIDUxqqtmQvsM8ztTwvtXjGjroVOkgcxhXO6rnDwdldKR19NAz2g1jH7LigcuCEeAf02worFAqKHeQfyUWhb5DP6Ref4xT3/Fsvp5YK0dDyEg7UiihpdL78YCGlLDPv3A/t+ATKcK1tThhhSysizTA6+bx+74U9+1LO6FfNPhW0Q2iU3zq613nWUoaPRFUEyq79Q9BSwoI94lZRdYZc30tQq/KK6URd5AnZFaIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/o2npA2IvKqnzMTPRJK6I6MLyrofA+2YttuJAqDZ3xM=; b=yhWffdNRm2OMz1m4sTCCwXRxOIvRwZpHnYkplNKor9x1FxuZCZQpANabhASCUBhVFx1+scjHDaadjY1+kgHpEJAVmdKb8sB5pi2x4mQFw7DRBBEwOYXD2G+hadqC+TiIeuLN/ztL5ztmjfNk7zicNmwx8lXgH+V09Zj2xjngVgs= Received: from BYAPR05CA0052.namprd05.prod.outlook.com (2603:10b6:a03:74::29) by BL3PR12MB6379.namprd12.prod.outlook.com (2603:10b6:208:3b2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.35; Tue, 24 Jun 2025 14:16:35 +0000 Received: from SJ1PEPF00001CE6.namprd03.prod.outlook.com (2603:10b6:a03:74:cafe::b7) by BYAPR05CA0052.outlook.office365.com (2603:10b6:a03:74::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.16 via Frontend Transport; Tue, 24 Jun 2025 14:16:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CE6.mail.protection.outlook.com (10.167.242.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8880.14 via Frontend Transport; Tue, 24 Jun 2025 14:16:34 +0000 Received: from [127.0.1.1] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 24 Jun 2025 09:16:27 -0500 From: Yazen Ghannam Date: Tue, 24 Jun 2025 14:16:01 +0000 Subject: [PATCH v4 06/22] x86/mce/amd: Remove return value for mce_threshold_{create,remove}_device() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250624-wip-mca-updates-v4-6-236dd74f645f@amd.com> References: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> In-Reply-To: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> To: , Tony Luck , "Rafael J. Wysocki" , Len Brown CC: , , , Qiuxu Zhuo , , Yazen Ghannam X-Mailer: b4 0.15-dev-9b767 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE6:EE_|BL3PR12MB6379:EE_ X-MS-Office365-Filtering-Correlation-Id: 26995e2b-2e0c-4fcb-4d20-08ddb329b972 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|82310400026|36860700013; X-Microsoft-Antispam-Message-Info: =?utf-8?B?N0srOU9xbE53K3UzUnhTZHBPR2ZaUzNHd0VmYzJPbk5NYjlGbnBFckxvTHNn?= =?utf-8?B?QW1rN1R6alM2SHJvYjNMZ3VOWkl0Z3psNGtBRlRYV2tXTmkxZnRMREVDZjRN?= =?utf-8?B?ZVBmc1hNMkEvcTBiRTBsbk5nMlJ1L2VoZzRPYlN2N0hvZXZhcWRsQWZrY3Q0?= =?utf-8?B?cDFTU2FKZlZGc29Ma0xOZjh2MXkwMWhhYjNqaDQvYkF4S1g2NDRDV1N6VW8r?= =?utf-8?B?Tkd6R3NaNHg5MUc3bHVPa2NjNFdINHFXVEhhZjVvZU1GbFFBeWVKUkt5T0h3?= =?utf-8?B?N2JiQ1I1WWVXQ0VLQUVpSzFRNkRKaVF1MUV0aWcwSGYvbkVOTzM4dE16ZUhs?= =?utf-8?B?ZDQwN00zeVVPK3c4SXpPMGZueHZvaHRaSWJxU21nSDAzYzIvOXpHY2VTMmZG?= =?utf-8?B?ODY3REV6UXFoRGc4SVBIMmtVc0NxMEpjUnd5L3JlU2wyK1ZEQUlDZ1hwa1Nk?= =?utf-8?B?eENEdStwb3dFZlA5aUxoRjNOOVZiZ1F4dVVkNGNyRGVvbFpjTFVSWXZWSFJ3?= =?utf-8?B?MjAvV000cWNrRFRqT2FOeVdYMStyN090OXB4dyt4amdicXFHQVNVK1NYRm9l?= =?utf-8?B?VUtHTEV4emNSbTJ6M3o3elZtY2pmajcwZ0FVVFQ1QnlIbGkzSGlDbUJ0bWEy?= =?utf-8?B?ajcwQTVOUWR4T1kwTmhKcmMwZ05Zdjc2RFRJUGVYUWNMNXBiN3VHd2dvVjVu?= =?utf-8?B?cjhlclBacTJ6SU1XeDhQN1B3UnJkVmphZVJaZUwwTklwOTBWMUJGVzlqSEE1?= =?utf-8?B?UHNkaVdmS0FEZXViVUE3aFNKZkE2M2VIeit1bjBYekJna3FtZEh2VGR3aUI3?= =?utf-8?B?a0pvZnliNFBCZndySDdiYjFscDRYSjhKUjB4VFUyN2NJcVdYVk95NjlmWkdN?= =?utf-8?B?Ylc1MCszS2c5KzR2SXo4ZjdPb3BnMEM4ZE9NaitHTGFieTA4TkN6TjVab1lE?= =?utf-8?B?RzkwVDVyTVM5aU91L0MzOFM2MkpkZHB3U2lWbTlSOUpEY3lCeWhxSmpXOUE5?= =?utf-8?B?RXpyanJ0NkF4a3pGYVdZSWRLL3ZRQ1dvUzFYQzB4bzdKancxU1J5N1ZsOXht?= =?utf-8?B?ZW5td3JxQmdBd3RueVFvRzgyTXVDdFNkTitmVUpoUXBSUndCY0xkSTBsenBH?= =?utf-8?B?UDVaS1luYVk3L2Rrb1hYaTIxSUt4bmNsRzlQQ05sODRsVkpNMGd4cVZvaFpv?= =?utf-8?B?UVpRdC9nYUNTQnprOVgwd2JLb0RjZU9nUmpIK1ZJNDNPWFFNYWUwOHJST1Jl?= =?utf-8?B?M0pKS0p1L1YzRlpWNUhGSUplNmgwTTVHY21JUzZvT1RLam52UFNlYXRUOEdF?= =?utf-8?B?di9JUGc1elhlanpIbS9wSlBTeHU1Z2F0SUd1Vk1FUnFaQVlTMDBhUUZ6MlRC?= =?utf-8?B?amNCalFOVkorRkhwZC94TE1IbTlVUGFRMTg4ZzUvckQyMGNxdGFPVEJsQkk0?= =?utf-8?B?dDZFTWg3aDNFQzNqZ1RIYk03ZnBvMGk3cnJZNC9EK21samFXYWo5UHROaUM3?= =?utf-8?B?ckRORDFNa21GTU40QU9ud0pUVFhKaS9yUldUT0JZb0d4M3VNMEhJWHhoL3o3?= =?utf-8?B?MGprRXpDbmJ6QkJMNi9ZR2NPY1JaeTB4dXdnbU8rK0ZJdjc0T1RoTHVnZ0w5?= =?utf-8?B?anViaVF3YzhxMkdDWWxLaENzcUlmclBWY0xoWlUvWXE3M3llOHJtR0tiK1NP?= =?utf-8?B?cnVtOGk4Y3V2bjAzc0kvNTVwK3ZDdDYrL1k3cmdKZk9GQloyTUlCSVg5aUwx?= =?utf-8?B?KzBnT3d5cXBjRnl2QkRvWTJKcHhCQTJab00wUk1rNy9mV05hY1FtdUN2KzNv?= =?utf-8?B?UWlhR0RIem9sT2srRVoyVUVEZHRtTUNGTWZ3enpsbUtvY2EwYW5ESXNBdnR6?= =?utf-8?B?b3lLSkMrcGNIQnBBTGUzRTFBdGxsTWIwNDV3d3JTaDRwQWx5dGVOZWFoWTRl?= =?utf-8?B?NWRZK2orU1FETlNRaFNKUXJ2Q3d5UjFFdDR6aWNGT05QeVNScTdpcmhhUWM4?= =?utf-8?B?cTJBY09seTJBYWN0TUNwMlQyNWZKQXF1VVZ0akdDWG8rWHlmSnhxcXFGV0k5?= =?utf-8?B?a0tsMEFlcFh4dzV3dkNDS01LTTF0Q21DWk9tdz09?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(1800799024)(82310400026)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2025 14:16:34.1442 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 26995e2b-2e0c-4fcb-4d20-08ddb329b972 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE6.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6379 The return values are not checked, so set return type to 'void'. Also, move function declarations to internal.h, since these functions are only used within the MCE subsystem. Signed-off-by: Yazen Ghannam Reviewed-by: Nikolay Borisov --- Notes: Link: https://lore.kernel.org/r/20250415-wip-mca-updates-v3-2-8ffd9eb4aa56@am= d.com =20 v3->v4: * No change. =20 v2->v3: * Include mce_threshold_remove_device(). =20 v1->v2: * New in v2. arch/x86/include/asm/mce.h | 6 ------ arch/x86/kernel/cpu/mce/amd.c | 22 ++++++++++------------ arch/x86/kernel/cpu/mce/internal.h | 4 ++++ 3 files changed, 14 insertions(+), 18 deletions(-) diff --git a/arch/x86/include/asm/mce.h b/arch/x86/include/asm/mce.h index 6c77c03139f7..752802bf966b 100644 --- a/arch/x86/include/asm/mce.h +++ b/arch/x86/include/asm/mce.h @@ -371,15 +371,9 @@ enum smca_bank_types { =20 extern bool amd_mce_is_memory_error(struct mce *m); =20 -extern int mce_threshold_create_device(unsigned int cpu); -extern int mce_threshold_remove_device(unsigned int cpu); - void mce_amd_feature_init(struct cpuinfo_x86 *c); enum smca_bank_types smca_get_bank_type(unsigned int cpu, unsigned int ban= k); #else - -static inline int mce_threshold_create_device(unsigned int cpu) { return = 0; }; -static inline int mce_threshold_remove_device(unsigned int cpu) { return = 0; }; static inline bool amd_mce_is_memory_error(struct mce *m) { return false;= }; static inline void mce_amd_feature_init(struct cpuinfo_x86 *c) { } #endif diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c index 9b980aecb6b3..f429451cafc8 100644 --- a/arch/x86/kernel/cpu/mce/amd.c +++ b/arch/x86/kernel/cpu/mce/amd.c @@ -1296,12 +1296,12 @@ static void __threshold_remove_device(struct thresh= old_bank **bp) kfree(bp); } =20 -int mce_threshold_remove_device(unsigned int cpu) +void mce_threshold_remove_device(unsigned int cpu) { struct threshold_bank **bp =3D this_cpu_read(threshold_banks); =20 if (!bp) - return 0; + return; =20 /* * Clear the pointer before cleaning up, so that the interrupt won't @@ -1310,7 +1310,7 @@ int mce_threshold_remove_device(unsigned int cpu) this_cpu_write(threshold_banks, NULL); =20 __threshold_remove_device(bp); - return 0; + return; } =20 /** @@ -1324,36 +1324,34 @@ int mce_threshold_remove_device(unsigned int cpu) * thread running on @cpu. The callback is invoked on all CPUs which are * online when the callback is installed or during a real hotplug event. */ -int mce_threshold_create_device(unsigned int cpu) +void mce_threshold_create_device(unsigned int cpu) { unsigned int numbanks, bank; struct threshold_bank **bp; - int err; =20 if (!mce_flags.amd_threshold) - return 0; + return; =20 bp =3D this_cpu_read(threshold_banks); if (bp) - return 0; + return; =20 numbanks =3D this_cpu_read(mce_num_banks); bp =3D kcalloc(numbanks, sizeof(*bp), GFP_KERNEL); if (!bp) - return -ENOMEM; + return; =20 for (bank =3D 0; bank < numbanks; ++bank) { if (!(this_cpu_read(bank_map) & BIT_ULL(bank))) continue; - err =3D threshold_create_bank(bp, cpu, bank); - if (err) { + if (threshold_create_bank(bp, cpu, bank)) { __threshold_remove_device(bp); - return err; + return; } } this_cpu_write(threshold_banks, bp); =20 if (thresholding_irq_en) mce_threshold_vector =3D amd_threshold_interrupt; - return 0; + return; } diff --git a/arch/x86/kernel/cpu/mce/internal.h b/arch/x86/kernel/cpu/mce/i= nternal.h index b5ba598e54cb..64ac25b95360 100644 --- a/arch/x86/kernel/cpu/mce/internal.h +++ b/arch/x86/kernel/cpu/mce/internal.h @@ -265,6 +265,8 @@ void mce_prep_record_common(struct mce *m); void mce_prep_record_per_cpu(unsigned int cpu, struct mce *m); =20 #ifdef CONFIG_X86_MCE_AMD +void mce_threshold_create_device(unsigned int cpu); +void mce_threshold_remove_device(unsigned int cpu); extern bool amd_filter_mce(struct mce *m); bool amd_mce_usable_address(struct mce *m); =20 @@ -293,6 +295,8 @@ static __always_inline void smca_extract_err_addr(struc= t mce *m) } =20 #else +static inline void mce_threshold_create_device(unsigned int cpu) { } +static inline void mce_threshold_remove_device(unsigned int cpu) { } static inline bool amd_filter_mce(struct mce *m) { return false; } static inline bool amd_mce_usable_address(struct mce *m) { return false; } static inline void smca_extract_err_addr(struct mce *m) { } --=20 2.49.0 From nobody Wed Oct 8 20:44:15 2025 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2079.outbound.protection.outlook.com [40.107.223.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47C3F2D8DC3; Tue, 24 Jun 2025 14:16:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.223.79 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774598; cv=fail; b=mGnvDgVwXMvP4tUxVtcG/FRwyTlrBSmrvUYgQw8uo1xf/fLLSaIdkjsrTv57lfLcS3ZnvYgq2E+amwcMN70FCjH1H5r7qT0cpm1XsJKm1DMVIeFUxKpItW2QIh6Fbjk/9CoxC4zL7xq6yXzljFQKurYWOYHwq6HfqhyitptqYT8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774598; c=relaxed/simple; bh=liGglePT9VG9HvXwQP3CHIByHGBxBRi6dGu6ErWsDk8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=eNMJcDn+cvELTb01JrW3Dn5Tbc9KOprAQ7OyvbQePxCreiHmp7OJFQHaHbUNJm39TWKm4UKSY2ohvh6u5Aakt+15DXVOCAbrQfZPZ0BueztGVtcwOUf7Iyq2/ecj9hZ5DxatHim8bZaU/fKEegjZIv/bQ2mn8oMs3XpJmiRyDqo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=yLus5xQP; arc=fail smtp.client-ip=40.107.223.79 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="yLus5xQP" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nkrjHWsWllv7BkHY6aGr4nXyMKELVIxZh8ct+hpjamUGaRpvZDaowsCKSVpH3dp3MmETE2TxAPYrX4NNI3t4oiqJ8BJVmxxJvqstpLkC3Rld+8EmUfnicIaDxH8QwmymSCpywWqL4zhBjKtZGj5+OjFuEFtodFgBg4oDBvB3ETFGCXJaqBuexgM+/Agehs8c0ahe/GETmswLHGJ0FVEwE9vIJmMjvudukzeweTq2mOQ9srPvKmvJqX0DQUeFH9f+lZfFTL3HjPurcMWkepGodunNyVkix92Gyh1dwNTd+mnm3g6lE0uD/s7Ei7jf2R1KnsmQkN2DXnlR0J3wiBDURQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/yWES8a+ryd3REhb7jrntofsfPU3SgRsWUTmB5Aj/x0=; b=CYopl9IFTsDlCL9lS2hbjdxxAoAEBU+Qvh/eDAVrT4j1poKmao/bz2jXY5B87tplp3/wwxeIlZsYu/ews7PDYnqoQ5bFTcwkDAGI6re60lpMj7aC6RMMQOc4QkfDAQLDPbXhaLeydUZp9wYC7563bGqxdOcOCT+slXPU6CljDMqa0k98irbKzSgMm8ZvpsZVpGEfl4KcLGVQLNpLXYrLZZ/LTUOYoT2Hg/Hz/+Accoavy5/IruYQHzygwW28Kue9mHjyRVsO0YJ2Lqyld0KE3cC+idl7xy6ISkboywoi4xWck39Ac66ArsfHw6DryiVO4xlFdKn4TBZL38dYbO6vCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/yWES8a+ryd3REhb7jrntofsfPU3SgRsWUTmB5Aj/x0=; b=yLus5xQPDfwISKs4vefu6cky6Z2jfQCHswmSg1EbuSItQCgNiheA5wA39kmTJPjHZ40+0V0U21evu5CL+fggpoJDiFVThH+j/VzVWu3xJwDBaDCZFEmsXnfnuKKt4tHgjDm8neakG557QOJyTr3x5Xb4Sz94DJ+GFfQ0+KNc9hc= Received: from MW4PR03CA0235.namprd03.prod.outlook.com (2603:10b6:303:b9::30) by CY8PR12MB8267.namprd12.prod.outlook.com (2603:10b6:930:7c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.38; Tue, 24 Jun 2025 14:16:34 +0000 Received: from SJ1PEPF00001CEA.namprd03.prod.outlook.com (2603:10b6:303:b9:cafe::20) by MW4PR03CA0235.outlook.office365.com (2603:10b6:303:b9::30) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8857.29 via Frontend Transport; Tue, 24 Jun 2025 14:16:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CEA.mail.protection.outlook.com (10.167.242.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8880.14 via Frontend Transport; Tue, 24 Jun 2025 14:16:33 +0000 Received: from [127.0.1.1] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 24 Jun 2025 09:16:28 -0500 From: Yazen Ghannam Date: Tue, 24 Jun 2025 14:16:02 +0000 Subject: [PATCH v4 07/22] x86/mce/amd: Remove smca_banks_map Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250624-wip-mca-updates-v4-7-236dd74f645f@amd.com> References: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> In-Reply-To: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> To: , Tony Luck , "Rafael J. Wysocki" , Len Brown CC: , , , Qiuxu Zhuo , , Yazen Ghannam X-Mailer: b4 0.15-dev-9b767 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CEA:EE_|CY8PR12MB8267:EE_ X-MS-Office365-Filtering-Correlation-Id: ecdafb79-80dd-4514-5202-08ddb329b93c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?RGxZMlVmcHF3ajlOOWRjelEzL2x6c3Q4VGtwL3JBOVpjNll5QXFuSjJ1bVlw?= =?utf-8?B?MktFZWYySWlkMG9RbDc4UnQrZDhzVHhuQjBaTldYV2UzaUd0bm9tQ2lQZnRU?= =?utf-8?B?Y2pwMmdJUERjdUZseUdKYlpoc0tKZU9ZUXhLSk5yek4ySFg5OWQ3NXpIdlQz?= =?utf-8?B?WHFkYll3TzJKM2lNenVHeFpSd0ZOMkFiUGM0T29qMzhDOWdOSzBmZTdDSUVY?= =?utf-8?B?TldsK2JIaXJGeUJuTjMwMVNyTDlyVVhxQXRianhjaElYRFhTQVlwZTVPb0VR?= =?utf-8?B?VFU1MkR5Qk1mT2hRbVpiVHYrcmI3eXo3ZDJnMS9YbnQvT0tvSEE5NjlPRmZ2?= =?utf-8?B?TW1tM29Rb3FmLzQ3bEtYZ0ZuVGp4cTFPM0pvWjhhaXJhMTlCdDVjRGp1NjNy?= =?utf-8?B?TnNuSTVZRjZNakZwTWpMUE5IcDBja1ZWV2h6eFZYTnA3ZDlSRk1YckVhMW9l?= =?utf-8?B?cFdTbDhPQTFFYUdTb2FERWhaaFVYZGYyZ2FxVFpweEZ5NkFONm1wY3ZESkJp?= =?utf-8?B?RTFHbTgxdC9kZjI4RjNacnF1QW5mK21qQVM0TnZDTm9iWW16OUdSd01Pd0Vn?= =?utf-8?B?ak0vMzA5enJFNkprbHVMWkRHYld4emNvTkN4eS84WGxScFl1THUvM1F1MkZr?= =?utf-8?B?SzNEK1VaZ1I1dHVNMHNOeHlCRVNGMk1vNXRiZ2NMMlB0cVVMdGpmUGlkeVdq?= =?utf-8?B?U202cEhFZHBydU5pS3NLMFAzd2dtVi9CZU9SeDVsY1Q5Y0xhZnRUalJZS2pO?= =?utf-8?B?QzZDWWNaYVozRWpPcHVFRUFubmJzRmVyS0lnRUFxTmtyVFBnQkJyd1BCZlRz?= =?utf-8?B?QWdVZ1FpbHlJZWRkOEJwRmNaTmFzaVpsRUsrTUxvNUVxY1E4blR4dmdsbkUx?= =?utf-8?B?RGMwcEFSaDN3emdUWU5YV3FxeGhHMCt6dnk2dENVRFdnQkVDd3B6b2JjUVA0?= =?utf-8?B?V2ZxQlZ4aC9mRTN0SkRvUWFRNUtlRmR4aWRwNG5mY1p6MHA3S210Q2ROMmox?= =?utf-8?B?UkM1UzVyQmhqVUlyUHB0YWRnRVBId1BpTjhJdUxFZnAxclU4cUN1ekFSbHRU?= =?utf-8?B?amg3SHQxS1hSc20xT2JBdVhxZlZOTk5QMDdPUVdrSDUvQXlteEExdlhZWDlj?= =?utf-8?B?dlBsZXk2bVFkUHJneFdJclVJeEdEZ0d1cklKSFYwZXdQVW9STmpPZDZMY0F2?= =?utf-8?B?QnBSdjlaVHJtekxjYU1jRnVrYWExdjFYaTExZGlJMHRSTkliMmd3Mm1KU1dJ?= =?utf-8?B?T3R6aWtZckhaOG1laXlGQmE2eUhWa2VVcllQRElueWtyR2lQOHZ1ZW1pcFNB?= =?utf-8?B?WGZadnZRWmFEV29MaHpJMXBsR0ZjanJGQThlSnZJRmp0Nkl2ei9CeHhTQVVV?= =?utf-8?B?MmprSFltRFRrenVRVzdNRndabFg4R3J2NHBicy9SZnBqNFJZbURRZlYxYVBO?= =?utf-8?B?TXNZVWgwcXRWTDBPcGFDZFZaTFVmc2hOOTJuK0hyYTdXeUhXZzhYT3M4TXBq?= =?utf-8?B?cDJTUWZHRG5leVNTNFRlSDY0Ti9mcDBhMWpzQ0tHaVA2cVdLencwNVdrNjlU?= =?utf-8?B?VXp4Z0hzUFJhNVNmYTFSSmRFa0dOV1QyZm43SUhheDBHZXJiZm5lalY3WDJ1?= =?utf-8?B?OTdXd0RXa3dpYmVNclh4OWU4dXhRakJqM1daOURDVC9TTlFJZHlvTDZQYnNL?= =?utf-8?B?ZkhwRmhBT29CSU1JaG9ONlZwdWpGeW5MNXpGbklMcXhxS2VveTRaU1hrYURx?= =?utf-8?B?N2EyZ0piUU9rMUlNcEltMzdsc0NKNHR4NWIwclJFMnA4dVVCcHZ6ajBwV0xI?= =?utf-8?B?RHpyRGx2RkFGbjNSWEhvM1FXNEhlaHRvRHFOSWhVYU8rR3Q3L04vMG5OUVhy?= =?utf-8?B?ZmhTMXR6SXc5bE5UaFQvYm0vTWF6K1lRVnJwT2lndjdWUTBKSi9hZ0VUblVz?= =?utf-8?B?S0hhaGdVTW1OQ24rM0o3YXVQQXdydUNzdUhZT0pKSEhKV1J4RFcwNHJmTy8x?= =?utf-8?B?SDJuYVhuVTRZc1h0cDFYbXRHRWJPSXRNVHAvdTBSOHRSYVF2WWVhSzBrVEV2?= =?utf-8?B?RlVUVEkzV3F5bFBtMHUyakpiRHpIZll0Vzdjdz09?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(82310400026)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2025 14:16:33.7896 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ecdafb79-80dd-4514-5202-08ddb329b93c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CEA.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8267 The MCx_MISC0[BlkPtr] field was used on legacy systems to hold a register offset for the next MCx_MISC* register. In this way, an implementation-specific number of registers can be discovered at runtime. The MCAX/SMCA register space simplifies this by always including the MCx_MISC[1-4] registers. The MCx_MISC0[BlkPtr] field is used to indicate (true/false) whether any MCx_MISC[1-4] registers are present. But it indicates neither which ones nor how many. Therefore, all the registers are accessed and their bits are checked. AMD systems generally enforce a Read-as-Zero/Writes-Ignored policy for unused registers. Therefore, there is no harm to read an unused register. This is already done in practice for most of the MCx_MISC registers. Remove the smca_banks_map variable as it is effectively redundant. Reviewed-by: Qiuxu Zhuo Tested-by: Tony Luck Reviewed-by: Tony Luck Signed-off-by: Yazen Ghannam --- Notes: Link: https://lore.kernel.org/r/20250415-wip-mca-updates-v3-3-8ffd9eb4aa56@am= d.com =20 v3->v4: * No change. =20 v2->v3: * Minor edit in commit message. * Added tags from Qiuxu and Tony. =20 v1->v2: * New in v2. arch/x86/kernel/cpu/mce/amd.c | 30 ------------------------------ 1 file changed, 30 deletions(-) diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c index f429451cafc8..0ffbee329a8c 100644 --- a/arch/x86/kernel/cpu/mce/amd.c +++ b/arch/x86/kernel/cpu/mce/amd.c @@ -252,9 +252,6 @@ static DEFINE_PER_CPU(struct threshold_bank **, thresho= ld_banks); */ static DEFINE_PER_CPU(u64, bank_map); =20 -/* Map of banks that have more than MCA_MISC0 available. */ -static DEFINE_PER_CPU(u64, smca_misc_banks_map); - static void amd_threshold_interrupt(void); static void amd_deferred_error_interrupt(void); =20 @@ -264,28 +261,6 @@ static void default_deferred_error_interrupt(void) } void (*deferred_error_int_vector)(void) =3D default_deferred_error_interru= pt; =20 -static void smca_set_misc_banks_map(unsigned int bank, unsigned int cpu) -{ - u32 low, high; - - /* - * For SMCA enabled processors, BLKPTR field of the first MISC register - * (MCx_MISC0) indicates presence of additional MISC regs set (MISC1-4). - */ - if (rdmsr_safe(MSR_AMD64_SMCA_MCx_CONFIG(bank), &low, &high)) - return; - - if (!(low & MCI_CONFIG_MCAX)) - return; - - if (rdmsr_safe(MSR_AMD64_SMCA_MCx_MISC(bank), &low, &high)) - return; - - if (low & MASK_BLKPTR_LO) - per_cpu(smca_misc_banks_map, cpu) |=3D BIT_ULL(bank); - -} - static void smca_configure(unsigned int bank, unsigned int cpu) { u8 *bank_counts =3D this_cpu_ptr(smca_bank_counts); @@ -326,8 +301,6 @@ static void smca_configure(unsigned int bank, unsigned = int cpu) wrmsr(smca_config, low, high); } =20 - smca_set_misc_banks_map(bank, cpu); - if (rdmsr_safe(MSR_AMD64_SMCA_MCx_IPID(bank), &low, &high)) { pr_warn("Failed to read MCA_IPID for bank %d\n", bank); return; @@ -531,9 +504,6 @@ static u32 smca_get_block_address(unsigned int bank, un= signed int block, if (!block) return MSR_AMD64_SMCA_MCx_MISC(bank); =20 - if (!(per_cpu(smca_misc_banks_map, cpu) & BIT_ULL(bank))) - return 0; - return MSR_AMD64_SMCA_MCx_MISCy(bank, block - 1); } =20 --=20 2.49.0 From nobody Wed Oct 8 20:44:15 2025 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2060.outbound.protection.outlook.com [40.107.236.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 529392DECB1; Tue, 24 Jun 2025 14:16:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.60 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774601; cv=fail; b=ljUUY9Vgp0BMOTgYqnGbq64+453+tUZTxvnJW16Y5Blq5MiDILgfBbPaeUIcQ7EOLykQWDzN0cISIVAW4cDDXM0xP1P5LI0IAj+0xDt3vaa/npG3ixT1XjMWZw6ZQbQIi2EieTWMX+17ijujm20FaiyWK/ObTHJv7Dvq6LOo29E= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774601; c=relaxed/simple; bh=+OBqsGLfZ3+8WQrkO9asniDcZU2PuE2D/qB1LgVIcVk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=KVzMVc2ceY8I2oqgc17B35roPIst2v/+JCFc+op6cIYCYX7xSBVnpZ0AvMCACv/3Hwz+Tj2gNNY4/TDjcHQxb2pFiFpS5TzhHARjpIyx3o3C2ET2Qb8iKdYT3Z9O++L0PyAvMeOYW1rKKvuycXSvSK8rhBzi87Irur/KkbgyvjA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=48Lw3YCo; arc=fail smtp.client-ip=40.107.236.60 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="48Lw3YCo" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xq/PjH63QncewFd/Uku4qhHXPeEqO+gwKBZS/ZRgUaPUI2kY4dHjCTSb2bJpI4kz4mWKh0AvHr3H3kMd/QXbNP6LwJsDUKcZcp+6LOKnrh5nGXACCQqh4hmioIzoIhwBe3Pm2C9+Z9ihmYjmRwBZ8uUGaYdin8eOSU80fFo/CZKxXwa11v1CkKHct1AsDee5jp2jjez5xV/xRlN1zgszHlHBjvDOODtOWh/iW9gwEuSR26twUoBZQCIqYqY3pN2Nty5qVPtsY6674XLvc9T9BjZoF/zbSj7u6PPdE9WLzX+X3jCeP6MAU/NuT3p15S1emn/Ov3kZmCqAD8IpcOa8EQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8UFEnDw9WblrUWx0SuQx8EVQOwDtHAc7xpXHV6xWDV4=; b=iYX4UtQdqZ6zaWXmukKNM1ZYDU1h4tIWt6Xbaqnirnb0q0pMb+JqV2QxhCNY4X29JF2NeKgPW3/vegyhFDx1rHLfaQoOyzxYstdMTjxAR92JfG7RIjYsm49OuQUBpNsg88iufDrVDhPqXvYTJT9/4rhD8hmbWiVOYrFxw6EW9WJ+0KeFkA3dpxP9goL3g24J/jVXkmmPhhPlc+A3FiioNMP8Il0BCFDhHfrJZdTxKMifFSuIcvjgz2B2DgkIAvdQPjOk/J+zeAHkwdlS+BPCSOMejXjXtb82/XLMzz7pOXbJjrF5ceBZl2fP+MLJbd3FNC70NfEOATBOX9CzOwsfCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8UFEnDw9WblrUWx0SuQx8EVQOwDtHAc7xpXHV6xWDV4=; b=48Lw3YCo6XAWxmgjHeFjDP2GHOqVFI1+mC27Av5vP7GXxnTSVIbvUZuQ9TikS0csH6mXxv97O6COvEPCe99D7sib0BOQ+ccpAxFj8IlQSGqsCat9yYeWOLVrMy5EUXJQgApQ2zJOYJhy8Rc8CyTdHF+nDU/yTwcasCzGJU3K30Y= Received: from BYAPR05CA0040.namprd05.prod.outlook.com (2603:10b6:a03:74::17) by DS7PR12MB5814.namprd12.prod.outlook.com (2603:10b6:8:76::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.25; Tue, 24 Jun 2025 14:16:36 +0000 Received: from SJ1PEPF00001CE6.namprd03.prod.outlook.com (2603:10b6:a03:74:cafe::1b) by BYAPR05CA0040.outlook.office365.com (2603:10b6:a03:74::17) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.16 via Frontend Transport; Tue, 24 Jun 2025 14:16:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CE6.mail.protection.outlook.com (10.167.242.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8880.14 via Frontend Transport; Tue, 24 Jun 2025 14:16:36 +0000 Received: from [127.0.1.1] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 24 Jun 2025 09:16:29 -0500 From: Yazen Ghannam Date: Tue, 24 Jun 2025 14:16:03 +0000 Subject: [PATCH v4 08/22] x86/mce/amd: Put list_head in threshold_bank Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250624-wip-mca-updates-v4-8-236dd74f645f@amd.com> References: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> In-Reply-To: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> To: , Tony Luck , "Rafael J. Wysocki" , Len Brown CC: , , , Qiuxu Zhuo , , Yazen Ghannam X-Mailer: b4 0.15-dev-9b767 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE6:EE_|DS7PR12MB5814:EE_ X-MS-Office365-Filtering-Correlation-Id: 288627e9-fc96-49c7-dfe1-08ddb329ba8e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|376014|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dWJ5RysvSDJjSVVPM0V2K0wxZ2c4eWpTY2tUcTlFVUJGSGN1djVXemxoVmRE?= =?utf-8?B?VElxWGZ0VGpYOWF1RjdzanIxSWszRHNSSCtPL2pCcHExZE9MZTdXdzBwM3dT?= =?utf-8?B?SWhOdmVPUGtseFY5SWE1TXJjci9IY2ZlL0dlZDlEdDN2YjIwcU9LUU9qbUZG?= =?utf-8?B?RUk1N1NaRDRLUGhCSnNmbXF3SS9rd01zL0E0UmF1ZFRJVEN0RDNsbE9Bdmtj?= =?utf-8?B?cHJMaWdaOVRBZFR6ZGFIV3NFR3doN1U4NnNBSnczWTFBWkNLZ1FRYlhwd2hV?= =?utf-8?B?cjFISG1oc1ZuaHkvQThSdU52U1BwVTY1b0tqVFdIUWZrQ3Vhby9VbU9nQW5z?= =?utf-8?B?MnZtUFQ2TWc5d0pQakIyU0hDbFl1aFdkR0JBRllkcDJyU0tQUDY3S2pKSHpF?= =?utf-8?B?dHhmeDlEZjBTTlpmOGtZVXh3SEpRSXRjaG1URWRTdndneDdRR2V1OEl6UFV5?= =?utf-8?B?NXEwNCtZbEYzUkhuOHhNaDBmTjZTVUgwUkQzcHdUUEdvb3grMmpQUXA3b2Nj?= =?utf-8?B?M1RIeXpDMVVMT29rUk0xMjlRZTN6TXY3aEY2WkIrb0tYbFYySlFBNEU0d1gv?= =?utf-8?B?ZEpnVTBydkkyT2EvT0FvUzFla3NLUnIyeVVBeG5Ca2NsMHNSUSs3ODBXTlAr?= =?utf-8?B?Yk0yZ0JUbmp3YVhleXdWTVJ2SHhHeHB6M1Z0Q2lyamxRK1BCQ2JRMlBid3Fy?= =?utf-8?B?NVZqNnp0T3RScTZHSzBuUHJWSytRbjI2WHZpQUo2eEF0ZFA5K0NhcVFuWWVR?= =?utf-8?B?a3NGdnBVTWdTQ1NuZUgrS25TR08rUFlrMFRPNTJVeHpiSWxCQ0o1VnlMZWNN?= =?utf-8?B?bkEvMWgvU2QvM3hJRmVTV2tkdWNHZ2U2SnA0RHlEeVVwSkNEVjViMVc3YjRP?= =?utf-8?B?N3NRT1NrYjhMRGFSdTRFY2lNVjR5S1FXcWpkZEE3UE9CMTN4SHNnbmU3ZDZM?= =?utf-8?B?cFBOTFNDRlN1ODJKWXZrZ0c2N2gvVHMydGV0RWUxYm5YN0pwVHdTSE96cnZy?= =?utf-8?B?U3BmZm1XZm1od2lnNXZkeXJKMjkyWkNxS21LZ0tobEFkSUxMOUFXakJSSmJB?= =?utf-8?B?TGhjK0FFNHEvMmNUYnU0c0FwRkhNUGJ3N2x1QWhqWkZQOTNKVkQ3WjQyc04y?= =?utf-8?B?OEtSVGdYWENvc00xcnI3OHdtQkFOS1pXU0E1N3Zsb0t6ZGpmNEpGdElMVWov?= =?utf-8?B?bm5kdWpGL0xGUnZHMUx5bDdDOVdIZzVFRGhvNlY5RzRHYWZRS1hWOEVwSXd6?= =?utf-8?B?NHFlSUVKYzl4NkFiYmEvdVI1NkdvckFWckdRM2UxaXlrUnNPTXhLL0pJd2VC?= =?utf-8?B?a3VEOWhJQTBtZ2czdUEybnh1ZEhscmdXOXZGR0FqZkV5dktSOThaNGcwY3JG?= =?utf-8?B?MFFWS0FoSitjSGhsR0lTWGt1cGdtNlFTaFRWdTJuWDYrM1JRWURmRzVlbyt0?= =?utf-8?B?b3dCemlJSTZPOG9oZWw3ZHRLd0VmZ2VleHdJRWY1MlE2bEsvNCtqOVhJRldz?= =?utf-8?B?dWZUSHQ3d1JmbWpFVDM5SmZPK3QxUm9DUzVjcWV3TGI0MklXOUxKVVB5czdU?= =?utf-8?B?b3IzWmd4WXhvbG9CS0pITzFLRW0rM2pMK2N3WkkxZktTSGdvR0l2cUJJY3kw?= =?utf-8?B?TkdySUo5WVhLN1FCdUdyWWxsU0MwOWEzdDZCWmp2THZ2M1RtcmRVT05FcGw4?= =?utf-8?B?Rzlxa0NTTUFkeitxbHJ6NVRoZllzSisrVVJ6eTgrUEJVd1FTTGI2ZmtrNkZm?= =?utf-8?B?VWJRejF1aHZ0ZXpSTDk5SVYyblNxcFp1NjZNR2hqakt6azYzZ1NXbDhJUXZS?= =?utf-8?B?a0hlUDdQVmkzQVpOMGF0b3ZtWWxyNGZJYkpwMExhL3cwR2RVYnNRL2FqSEIw?= =?utf-8?B?aEdFbVhiOUFIcWIrNTRGd2FOSkpsdVZpQ1MzRTlrMzdCRVRONXRHUVFLSWZ6?= =?utf-8?B?RmNzTXlRcVVHbXlkU1N1UmExc1B5QUtZWDNVdTFvdXVzRW5HNzVGclM1b1JK?= =?utf-8?B?VHRTOTRvdDExZ3QvSWRkOERHWXg4UVNFVis2RnQwTHF3SlhnRmJ6MGlOQllD?= =?utf-8?B?Vm14WTVuK0tOYXBGZ0dTNGFUZk1pVnFhMi9KZz09?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2025 14:16:36.0037 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 288627e9-fc96-49c7-dfe1-08ddb329ba8e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE6.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5814 The threshold_bank structure is a container for one or more threshold_block structures. Currently, the container has a single pointer to the 'first' threshold_block structure which then has a linked list of the remaining threshold_block structures. This results in an extra level of indirection where the 'first' block is checked before iterating over the remaining blocks. Remove the indirection by including the head of the block list in the threshold_bank structure which already acts as a container for all the bank's thresholding blocks. Reviewed-by: Qiuxu Zhuo Tested-by: Tony Luck Reviewed-by: Tony Luck Signed-off-by: Yazen Ghannam --- Notes: Link: https://lore.kernel.org/r/20250415-wip-mca-updates-v3-4-8ffd9eb4aa56@am= d.com =20 v3->v4: * No change. =20 v2->v3: * Added tags from Qiuxu and Tony. =20 v1->v2: * New in v2. arch/x86/kernel/cpu/mce/amd.c | 43 ++++++++++++---------------------------= ---- 1 file changed, 12 insertions(+), 31 deletions(-) diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c index 0ffbee329a8c..5d351ec863cd 100644 --- a/arch/x86/kernel/cpu/mce/amd.c +++ b/arch/x86/kernel/cpu/mce/amd.c @@ -241,7 +241,8 @@ struct threshold_block { =20 struct threshold_bank { struct kobject *kobj; - struct threshold_block *blocks; + /* List of threshold blocks within this MCA bank. */ + struct list_head miscj; }; =20 static DEFINE_PER_CPU(struct threshold_bank **, threshold_banks); @@ -900,9 +901,9 @@ static void log_and_reset_block(struct threshold_block = *block) */ static void amd_threshold_interrupt(void) { - struct threshold_block *first_block =3D NULL, *block =3D NULL, *tmp =3D N= ULL; - struct threshold_bank **bp =3D this_cpu_read(threshold_banks); + struct threshold_bank **bp =3D this_cpu_read(threshold_banks), *thr_bank; unsigned int bank, cpu =3D smp_processor_id(); + struct threshold_block *block, *tmp; =20 /* * Validate that the threshold bank has been initialized already. The @@ -916,16 +917,11 @@ static void amd_threshold_interrupt(void) if (!(per_cpu(bank_map, cpu) & BIT_ULL(bank))) continue; =20 - first_block =3D bp[bank]->blocks; - if (!first_block) + thr_bank =3D bp[bank]; + if (!thr_bank) continue; =20 - /* - * The first block is also the head of the list. Check it first - * before iterating over the rest. - */ - log_and_reset_block(first_block); - list_for_each_entry_safe(block, tmp, &first_block->miscj, miscj) + list_for_each_entry_safe(block, tmp, &thr_bank->miscj, miscj) log_and_reset_block(block); } } @@ -1151,13 +1147,7 @@ static int allocate_threshold_blocks(unsigned int cp= u, struct threshold_bank *tb default_attrs[2] =3D NULL; } =20 - INIT_LIST_HEAD(&b->miscj); - - /* This is safe as @tb is not visible yet */ - if (tb->blocks) - list_add(&b->miscj, &tb->blocks->miscj); - else - tb->blocks =3D b; + list_add(&b->miscj, &tb->miscj); =20 err =3D kobject_init_and_add(&b->kobj, &threshold_ktype, tb->kobj, get_na= me(cpu, bank, b)); if (err) @@ -1208,6 +1198,8 @@ static int threshold_create_bank(struct threshold_ban= k **bp, unsigned int cpu, goto out_free; } =20 + INIT_LIST_HEAD(&b->miscj); + err =3D allocate_threshold_blocks(cpu, b, bank, 0, mca_msr_reg(bank, MCA_= MISC)); if (err) goto out_kobj; @@ -1228,26 +1220,15 @@ static void threshold_block_release(struct kobject = *kobj) kfree(to_block(kobj)); } =20 -static void deallocate_threshold_blocks(struct threshold_bank *bank) +static void threshold_remove_bank(struct threshold_bank *bank) { struct threshold_block *pos, *tmp; =20 - list_for_each_entry_safe(pos, tmp, &bank->blocks->miscj, miscj) { + list_for_each_entry_safe(pos, tmp, &bank->miscj, miscj) { list_del(&pos->miscj); kobject_put(&pos->kobj); } =20 - kobject_put(&bank->blocks->kobj); -} - -static void threshold_remove_bank(struct threshold_bank *bank) -{ - if (!bank->blocks) - goto out_free; - - deallocate_threshold_blocks(bank); - -out_free: kobject_put(bank->kobj); kfree(bank); } --=20 2.49.0 From nobody Wed Oct 8 20:44:15 2025 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2043.outbound.protection.outlook.com [40.107.95.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A8AC2DECB4; Tue, 24 Jun 2025 14:16:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.95.43 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774601; cv=fail; b=iWkdJADVKBlqrCans7EjZH288Yq5Qtwz4uLwkmkw4EGojzIaC4vTwNlNn7w1zPoTO1PoFMg4j+mvgZtHGu7587IQKz77aAWDSPcrsYWkBqRFXAxGKGhm0dMqFnZqJcNSTm7dk3pDEnS92adne0cwkwChq5dBdXn4CmOYZKI2SYM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774601; c=relaxed/simple; bh=RCSFoip5d9yz84EdTnlujnp/QvQSuxN4ThaFuihHNe8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=S/x5iXo6XI9KXlbtTZc4wqiLqUqZ0MeeK5Bv80s7AxpcrBbU3JVKgQpLK8arewJbO57U0lE/Lkx0K1Yi5KCt1JMFZ5bLJtgz2hYb1G0DnxlyDXLfYdxT/3IhDsQ+ebW9AB+8dhUkZEax1UgaTWM7pG0Lhk7DTyd892hZlffGYp8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=TpFIz6rM; arc=fail smtp.client-ip=40.107.95.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="TpFIz6rM" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NSZVMsflB/zZa5TrWPdnc6wq6A4Vu+3ZJA+DL6qWYQskc5u3ogHRFE+Uhouk9kAtDvaIRpI+j40m4foEF3Cms0o4BqwV2Dc2eke1BQE3qAG0TQBbK4wh771pb/YT9jDlmJYMJ6Er05KeJmrAq7ou3Ath8Fympqfzd7jByWV6k7iWNwP1rv0Jo5C2fSpf/rBgQgfqdPu39InGOu0OfaHsFKMqPSvrBjoF3eTxW/IXcdbqAHxdk/u/XQCncbp0vSaRhqYHDDpge3sd9NproGpfkeEm29tzUt4FeI79KJZ5iHHc7PnZADwQLsRTrFw1Zkk2LUApsfmgJqwcb4KzNkb6WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P13giJnnIZznlZLsPwq+qWANtKA2hjEc8r1VvvCfSRs=; b=mic+ukOJkkE+uFoKCiJQ/EiiyqWWbp7i67qg4sDXffsKKmh25/liLfsJGdHUzbA9404ygNEXt2lX04cSzFNUKasXN1HS7FQTuzF8wNTwsGMDBPPIlqLdeFS3NQ5T8vsvEUaPMNNFOKGzUWhWEmbnrj3eWPrn4fXhpSlqAC98lZ7oybWJTOi8dbJlL+6GOL9gEuerGeixktNKOvyIE7J9V3oxIQzWWzuzMcGpx0tPynaGihOIEMbgO3GO/pOYIjlp6Yo0d2hcCtBxVOmBB/dOyjcT4Lp/vhkHmPGKUzryjM+HXkjerc4oOJvo+IbWrWQY1VsiZhXVu/DfW5UKJANcEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P13giJnnIZznlZLsPwq+qWANtKA2hjEc8r1VvvCfSRs=; b=TpFIz6rMLZkpBRfP2lnE/U/hm6YXW3UntSnv4urpSGBwie5qmh2kNyjBfKydvzr+2ctw0tdetLx1LMsdSbWUIb5sbLrmFPYpBNhY6CsjJRjblU09m3Q2/Y4h9+PrWAMPz82sa8El95AUw6gISVt+VSse4V6ixIq9qifytsLQLgE= Received: from BYAPR05CA0052.namprd05.prod.outlook.com (2603:10b6:a03:74::29) by MN0PR12MB6197.namprd12.prod.outlook.com (2603:10b6:208:3c6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.23; Tue, 24 Jun 2025 14:16:37 +0000 Received: from SJ1PEPF00001CE6.namprd03.prod.outlook.com (2603:10b6:a03:74:cafe::77) by BYAPR05CA0052.outlook.office365.com (2603:10b6:a03:74::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.16 via Frontend Transport; Tue, 24 Jun 2025 14:16:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CE6.mail.protection.outlook.com (10.167.242.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8880.14 via Frontend Transport; Tue, 24 Jun 2025 14:16:36 +0000 Received: from [127.0.1.1] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 24 Jun 2025 09:16:30 -0500 From: Yazen Ghannam Date: Tue, 24 Jun 2025 14:16:04 +0000 Subject: [PATCH v4 09/22] x86/mce: Cleanup bank processing on init Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250624-wip-mca-updates-v4-9-236dd74f645f@amd.com> References: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> In-Reply-To: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> To: , Tony Luck , "Rafael J. Wysocki" , Len Brown CC: , , , Qiuxu Zhuo , , Yazen Ghannam X-Mailer: b4 0.15-dev-9b767 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE6:EE_|MN0PR12MB6197:EE_ X-MS-Office365-Filtering-Correlation-Id: f80c2c3a-81b8-4afb-ade5-08ddb329baf9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|376014|1800799024|82310400026; X-Microsoft-Antispam-Message-Info: =?utf-8?B?R2ZyTHlEckt0QkJBNXBpbGJobTEvVUZFSU1XalhoWlE0OXZtZk42YktnZnp2?= =?utf-8?B?L2FhRjFhQ1lHQXJnMCtVcVNoTU1GZFRVeDBDWUNQNWRpdi93cDFFUEFKTm90?= =?utf-8?B?YUppaGpybGJsYkV1MnBwZnZMS3FTbWdxcCtuL1JIeWg3dWhBRUdzclVuREFZ?= =?utf-8?B?NjZFQVh1cTd0V0lVeEJmR0ZaV0piUVU2N01vbkJsV2t4MXRMZUlKU1VTemtP?= =?utf-8?B?dTR5Q0FDR0RFY0NOWDJ5RjRpZCtzRmp6ZkFnTzNLUmZDZlhJNGJQVlhwTWRH?= =?utf-8?B?aDNPMDZ1d0kvWFpCWWZJV0xkMGtaUGhhaExhd1AwUFZKOGxxdnljVlpjQkNB?= =?utf-8?B?NzR2K1pJdk5OWWFMeURhcXBOdklEV3poUFRqUlJnazYyS1JTYlBVaTBOMHFX?= =?utf-8?B?YTJFK2pHS1AzT1ZsTmVRV3FVN2JuWW5iZGtJc2h2RWd4QWovY2ZOczBiNXl6?= =?utf-8?B?bWxpNktBZjZncDdiaU12MFpJUXcrRVJoaG1lYS81dWtGTldvRi81UU4zelk3?= =?utf-8?B?MDlKVFFmUkl2QU5OcVhVdGlrQ3RLRlg3c29yM3FpWm5FUWtVQi9aYjdjTjRC?= =?utf-8?B?RTIvZUljTmt5eU9lZU9qbHE3SGJLbmVrdlY3OXp3VXhHMkVQS001em5HQVh1?= =?utf-8?B?Q0Jnbnlqbmx4V2tMcTVFM2RJaTZuNHFqQ2IzREkyTlhNNktyTGZ4c0ZmNzBz?= =?utf-8?B?aHVKOU1xeGZrZHdKWGwxZkpkcUhOY3U2cDdmcVBJMndzRzBEVjBES0JtZWdK?= =?utf-8?B?ZjErN3FJdkNVOHBTQTNRbEc5TWhRQ2dQWjM5Q3lvcVg1SjZ5aUk2Z2pRY0hH?= =?utf-8?B?THR5OXc4bjNISmE2MVMrcXh6NWFZb0hGUkZPMmx6QWdhZjQwdSsxWFMrNXlk?= =?utf-8?B?M01NUjhqMjdwWGZMRHV6V05RQTVpcXdtZDNaQVR3bGduNC8vNTJIdE13V0Yv?= =?utf-8?B?UDV2UHZxckZCaUxFZUFRTmg3enJkTG5LdDBaYzEyL1AzcWJLY0pEVFJCRXp1?= =?utf-8?B?VkU1WEttOS9MelZ5c3YrYm9JaEkwRERQSnZ3L2pCZVZCV3g0YmtJaHo4SGhC?= =?utf-8?B?clJ5dExabWYyWjJ3MlhtQVZJclp2Y1BzVmU0MU82cXZEMTExTllnQUVodEFu?= =?utf-8?B?dytVQmNUOHY2YWw3WXBDS2I2RkNvV0lOLy9Ja2xsZDRWc0R1djRnVUo2UWRM?= =?utf-8?B?bFF0ZHlhMTNIMEVmczV6T1dieko5Nis4ZDlGa25tUldkTE0wV0UrYjFNbnRB?= =?utf-8?B?L2Nvam5MWTdoZnBBRVFjOFNFSW54NTBYTjFrKzFJaGFIZlFteDU5WE9KOUI5?= =?utf-8?B?SXdxcFBDUExqeEo2cHIybWJWbXhwTlRDMyszRi9iNkhZYURqdytEak5iekxa?= =?utf-8?B?N3M0QTkwVENnRUNsMm5YQTNnMWJkTXNoU1p5MnA1L3lZTEJFWEJvdEU5TVhE?= =?utf-8?B?YWhPeXB4RG02cDdCdm1hVVR5ZjROZ0VYZ0x0Z1NrSDFlMDYvR0RYT2hhYXg5?= =?utf-8?B?NXZzcFZyTWZLcGlrcXNqRXI3enRrcWZiZGxUNWxoSzBEYzVXelZkWWUxQ081?= =?utf-8?B?akdDVVpveU95VmMwVDNKbnB6RXlDeFV6eG9WL084Y2hJUWI3SG9XaEFrM1BT?= =?utf-8?B?ZjlIamhaNis3VlRJTHB2NEpRWFFkYk4yMEVrTGNiS2piV3ovd0d3S2EyQ3pX?= =?utf-8?B?dVlXMFJpUTllSXN5cXpDbXdIaE5hdW9kU1IrSWhIeVZRZkpkTk1nd2dNL25u?= =?utf-8?B?VFBXWW5Mck1BT081QkFjMXRzRkhiRkJ2V0V5SGZRVGpnZ2hFeHRsZHhlS0pQ?= =?utf-8?B?RkkwTU5GNzY3ZEhRV0pkcDZ3NGUxTktjb2xQdVVRM2wyTVlzRHh4akFsMDZR?= =?utf-8?B?WmdHZE84QjFKYXNPUEtucW9pVXRveERGb29WVHVTZ1YrNW1MZ1J3NktGNTVJ?= =?utf-8?B?UjlLMHRtUnBGZ1hFVWJ5bmFSNy8xRDl2L2VmTzRhcmw3RzM0WmY5bEY2OUFq?= =?utf-8?B?L3NHQ2pqdEROMEJrbjJPeWtnYXRzY2JZaWFTd2VrSHBNOW9PL2xVNXY2ZVl1?= =?utf-8?B?OERqZ1NpdFU1RVdqTGcxTTZScWFmbVZRV09hQT09?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(376014)(1800799024)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2025 14:16:36.7072 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f80c2c3a-81b8-4afb-ade5-08ddb329baf9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE6.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6197 From: Borislav Petkov Unify the bank preparation into __mcheck_cpu_init_clear_banks(), rename that function to what it does now - prepares banks. Do this so that generic and vendor banks init goes first so that settings done during that init can take effect before the first bank polling takes place. Move __mcheck_cpu_check_banks() into __mcheck_cpu_init_prepare_banks() as it already loops over the banks. The MCP_DONTLOG flag is no longer needed, since the MCA polling function is now called only if boot-time logging should be done. Signed-off-by: Borislav Petkov Reviewed-by: Yazen Ghannam Reviewed-by: Qiuxu Zhuo Tested-by: Tony Luck Reviewed-by: Tony Luck --- Notes: Link: https://lore.kernel.org/r/20250415-wip-mca-updates-v3-5-8ffd9eb4aa56@am= d.com =20 v3->v4: * No change. =20 v2->v3: * Update commit message. * Add tags from Qiuxu and Tony. =20 v1->v2: * New in v2, but based on old patch (see link). * Kept old tags for reference. arch/x86/include/asm/mce.h | 3 +- arch/x86/kernel/cpu/mce/core.c | 63 ++++++++++++--------------------------= ---- 2 files changed, 19 insertions(+), 47 deletions(-) diff --git a/arch/x86/include/asm/mce.h b/arch/x86/include/asm/mce.h index 752802bf966b..3224f3862dc8 100644 --- a/arch/x86/include/asm/mce.h +++ b/arch/x86/include/asm/mce.h @@ -290,8 +290,7 @@ DECLARE_PER_CPU(mce_banks_t, mce_poll_banks); enum mcp_flags { MCP_TIMESTAMP =3D BIT(0), /* log time stamp */ MCP_UC =3D BIT(1), /* log uncorrected errors */ - MCP_DONTLOG =3D BIT(2), /* only clear, don't log */ - MCP_QUEUE_LOG =3D BIT(3), /* only queue to genpool */ + MCP_QUEUE_LOG =3D BIT(2), /* only queue to genpool */ }; =20 void machine_check_poll(enum mcp_flags flags, mce_banks_t *b); diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c index ae2e2d8ec99b..486cddefaa7a 100644 --- a/arch/x86/kernel/cpu/mce/core.c +++ b/arch/x86/kernel/cpu/mce/core.c @@ -807,9 +807,6 @@ void machine_check_poll(enum mcp_flags flags, mce_banks= _t *b) continue; =20 log_it: - if (flags & MCP_DONTLOG) - goto clear_it; - mce_read_aux(&err, i); m->severity =3D mce_severity(m, NULL, NULL, false); /* @@ -1812,7 +1809,7 @@ static void __mcheck_cpu_mce_banks_init(void) /* * Init them all, __mcheck_cpu_apply_quirks() is going to apply * the required vendor quirks before - * __mcheck_cpu_init_clear_banks() does the final bank setup. + * __mcheck_cpu_init_prepare_banks() does the final bank setup. */ b->ctl =3D -1ULL; b->init =3D true; @@ -1851,21 +1848,8 @@ static void __mcheck_cpu_cap_init(void) =20 static void __mcheck_cpu_init_generic(void) { - enum mcp_flags m_fl =3D 0; - mce_banks_t all_banks; u64 cap; =20 - if (!mca_cfg.bootlog) - m_fl =3D MCP_DONTLOG; - - /* - * Log the machine checks left over from the previous reset. Log them - * only, do not start processing them. That will happen in mcheck_late_in= it() - * when all consumers have been registered on the notifier chain. - */ - bitmap_fill(all_banks, MAX_NR_BANKS); - machine_check_poll(MCP_UC | MCP_QUEUE_LOG | m_fl, &all_banks); - cr4_set_bits(X86_CR4_MCE); =20 rdmsrq(MSR_IA32_MCG_CAP, cap); @@ -1873,36 +1857,23 @@ static void __mcheck_cpu_init_generic(void) wrmsr(MSR_IA32_MCG_CTL, 0xffffffff, 0xffffffff); } =20 -static void __mcheck_cpu_init_clear_banks(void) +static void __mcheck_cpu_init_prepare_banks(void) { struct mce_bank *mce_banks =3D this_cpu_ptr(mce_banks_array); + u64 msrval; int i; =20 - for (i =3D 0; i < this_cpu_read(mce_num_banks); i++) { - struct mce_bank *b =3D &mce_banks[i]; + /* + * Log the machine checks left over from the previous reset. Log them + * only, do not start processing them. That will happen in mcheck_late_in= it() + * when all consumers have been registered on the notifier chain. + */ + if (mca_cfg.bootlog) { + mce_banks_t all_banks; =20 - if (!b->init) - continue; - wrmsrq(mca_msr_reg(i, MCA_CTL), b->ctl); - wrmsrq(mca_msr_reg(i, MCA_STATUS), 0); + bitmap_fill(all_banks, MAX_NR_BANKS); + machine_check_poll(MCP_UC | MCP_QUEUE_LOG, &all_banks); } -} - -/* - * Do a final check to see if there are any unused/RAZ banks. - * - * This must be done after the banks have been initialized and any quirks = have - * been applied. - * - * Do not call this from any user-initiated flows, e.g. CPU hotplug or sys= fs. - * Otherwise, a user who disables a bank will not be able to re-enable it - * without a system reboot. - */ -static void __mcheck_cpu_check_banks(void) -{ - struct mce_bank *mce_banks =3D this_cpu_ptr(mce_banks_array); - u64 msrval; - int i; =20 for (i =3D 0; i < this_cpu_read(mce_num_banks); i++) { struct mce_bank *b =3D &mce_banks[i]; @@ -1910,6 +1881,9 @@ static void __mcheck_cpu_check_banks(void) if (!b->init) continue; =20 + wrmsrq(mca_msr_reg(i, MCA_CTL), b->ctl); + wrmsrq(mca_msr_reg(i, MCA_STATUS), 0); + rdmsrq(mca_msr_reg(i, MCA_CTL), msrval); b->init =3D !!msrval; } @@ -2315,8 +2289,7 @@ void mcheck_cpu_init(struct cpuinfo_x86 *c) __mcheck_cpu_init_early(c); __mcheck_cpu_init_generic(); __mcheck_cpu_init_vendor(c); - __mcheck_cpu_init_clear_banks(); - __mcheck_cpu_check_banks(); + __mcheck_cpu_init_prepare_banks(); __mcheck_cpu_setup_timer(); } =20 @@ -2484,7 +2457,7 @@ static void mce_syscore_resume(void) { __mcheck_cpu_init_generic(); __mcheck_cpu_init_vendor(raw_cpu_ptr(&cpu_info)); - __mcheck_cpu_init_clear_banks(); + __mcheck_cpu_init_prepare_banks(); } =20 static struct syscore_ops mce_syscore_ops =3D { @@ -2502,7 +2475,7 @@ static void mce_cpu_restart(void *data) if (!mce_available(raw_cpu_ptr(&cpu_info))) return; __mcheck_cpu_init_generic(); - __mcheck_cpu_init_clear_banks(); + __mcheck_cpu_init_prepare_banks(); __mcheck_cpu_init_timer(); } =20 --=20 2.49.0 From nobody Wed Oct 8 20:44:15 2025 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2055.outbound.protection.outlook.com [40.107.236.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B3C92DECD5; Tue, 24 Jun 2025 14:16:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.55 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774602; cv=fail; b=Tdcp626hnaAHyYjOscai5bsLVjUy7cCjqmWe0DU/QRHpsVg2v5o44W4MFivJDGohf6aE2zap6mszFRKg3WbLODJB2IfE55rLmF9dyIhE78TIgF6TyhbvhAYBz0C1qQwtJR41g0p2DYzKdt3jpmvuS7qTQAexCI0AFYx77OBYLPw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774602; c=relaxed/simple; bh=m6cwxCaBCZlI0RLsMszhbT/DD/s2GFpiFrsBqX1heHI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=subLwTM6chpUuYdpbsQ6ADuBBTf7s9yrieJsEbZ+X3DEim41Yu3o36whrIKz6kRzdYAf5aECPg/pXF7jo5tpqs+g/SmmKgm4metFWGqdgLaHPIsYZtzbUw5GQf3mcD0uw4WaDpuedvCGCLlK8tC+lGFNTdqssetTqiDs1DpM6eU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=ciU/5dCX; arc=fail smtp.client-ip=40.107.236.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="ciU/5dCX" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jBeOVSDeDPD4SyL+0KH9LY8J0iu0j2meuHyRx4L+sdk+n5FeZaS3oAOVbSlxpHb4YGZpYePjMpzj+ufammyZjkCjlJ0XKkUpSMcaRc9vSmqg3wtUSUt/Gl+3vLfrVCd6J+2Z1zhPR4jYoh/ZeVaPGNZr+vyFISGNrdhs5sCZhvAShUd52RP8boz5Ccgva0HUDbsKocKV51EnIC03cfqEhA1jgQWugG6qAiX/8hyf0TrcbSF4U7CoFI/iX3P9Zk10KUVZiO1t4VGcMJqJlj5aDykZ4zjoAVGc7YPUQdJ03DI+jTnd/msejvg1VEpHQODOXmN36+ZSgxY0UaDavDnxHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RZhT7ZzdamwNR71vIDsJOUEaDUnfOV2gS73UPGLCBzA=; b=KLocGotE9j51XonFwK3REUD03qUeLUSg8csPvBAtG2nv47gRIMAmBQmLPg6o480uo0/EoztzYNUeT7LS418cqIIv61yUnmaENlmfqhUoafiAY1IdJpNukyYsp8OvCPpH0qxoVQt1qxTl9U86vwgMbysd2y4NewNemSpyafQVg5BRTOBczilnkJUwsaILdTysVpXXJ5hs9GOiWo6BFL+MVqnNH4Gsj7+FR+tENu/OTENfCIXr89/oSsot+obld8pCOzmJOc7/RAb4xVWNOQKtiH+pDZj9Fz49pmQpWzuOQMTmjZFozLpyM73EKL5s6EJAYVElXIzbD4NzjfmAK7gkAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RZhT7ZzdamwNR71vIDsJOUEaDUnfOV2gS73UPGLCBzA=; b=ciU/5dCXDnNoAeekFyc170JdrBXJz5C7DiJ+ATORWLnsRmr62JRJbS4nwP8Ec6Y4V4ZVPxgg0HtDSFmdlUbadTE4YvPPTTpBf4Cw3aH/rdmbPWbP7R7G2qVEdfsk22kKgK+trqVX+qIXT9z+gNqNWuPhT2MHa51aKQht67siNaQ= Received: from MW4PR03CA0211.namprd03.prod.outlook.com (2603:10b6:303:b9::6) by PH7PR12MB7307.namprd12.prod.outlook.com (2603:10b6:510:20b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.25; Tue, 24 Jun 2025 14:16:37 +0000 Received: from SJ1PEPF00001CEA.namprd03.prod.outlook.com (2603:10b6:303:b9:cafe::ec) by MW4PR03CA0211.outlook.office365.com (2603:10b6:303:b9::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8857.30 via Frontend Transport; Tue, 24 Jun 2025 14:16:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CEA.mail.protection.outlook.com (10.167.242.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8880.14 via Frontend Transport; Tue, 24 Jun 2025 14:16:37 +0000 Received: from [127.0.1.1] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 24 Jun 2025 09:16:31 -0500 From: Yazen Ghannam Date: Tue, 24 Jun 2025 14:16:05 +0000 Subject: [PATCH v4 10/22] x86/mce: Remove __mcheck_cpu_init_early() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250624-wip-mca-updates-v4-10-236dd74f645f@amd.com> References: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> In-Reply-To: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> To: , Tony Luck , "Rafael J. Wysocki" , Len Brown CC: , , , Qiuxu Zhuo , , Yazen Ghannam X-Mailer: b4 0.15-dev-9b767 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CEA:EE_|PH7PR12MB7307:EE_ X-MS-Office365-Filtering-Correlation-Id: 685d50b9-6c9a-4bde-ad3e-08ddb329bb49 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UGFyelRvK2ExdXE4dU9UNXFLcldRbnQ0a0JVWVRJTEZSaGQ3Z2xPSjBjQWVS?= =?utf-8?B?aXEvUG9iWHhBUkhFU09jUEFTcEQ0WmRZWjNGRjNkV2pTZUYyejdRSE9RVm02?= =?utf-8?B?dDhFVmlGdHlLSGZobXNsWjFQbVY5Ry9oYVZ1czRMejlKUXNjb0lBdDAwYkd5?= =?utf-8?B?Um0xYk9PS1FUVVlYWnFkOW55MkI5M1Q0eW1JVWh4bFVVTTk2MUFmSkREYmNC?= =?utf-8?B?OFZDVFRNd0t3WFdwazI5MGE3STNseTZOUzNmWWJWZUgwWVV3SUhsTk1wOXBn?= =?utf-8?B?NDUvc0U2WG5WWU1NTjU5YjltTzJMbDFHeEJDR3NMQkRHS1NqTFUxYjFXdGtJ?= =?utf-8?B?T2tuQTcvNTJJSVNpb2N3dm9vYUFKaWdWcU9YVkZwMStkcCt6TFdsc2NkVnZ5?= =?utf-8?B?UnNIcjR4UCtjdUpXc2ZuZ1FnODAxWTVkWG9NQnJ0T0U1M2wvcFdWdnZWSHgy?= =?utf-8?B?bHpCUVBqMFJuaDRRVVJvT0RyQmRRK2I2YkVwZTZZRGNtSG1ONzdtcTJGZVM1?= =?utf-8?B?TG41N281d00wWTVCOWpIR0grRHhLQUJ5RjExVEQzWm52N3hIanl3TGN3dkpE?= =?utf-8?B?M2lmMUhwTXU4dElGSU83ZVZvRTFuMGoxWXBJYWl4aCtrN0dwSHBlMGozRDJr?= =?utf-8?B?ampBcVd0THc2S0hrQWx1NmlRby9PTjA0RW8wZHZxU2hianpUQWc2dmM4YnI0?= =?utf-8?B?YkVsZTNKWXZmWGN0U3laQWJMbUY4YVJ2a2FWWStXU1lNcUk0ZGx4MXpBTENQ?= =?utf-8?B?dGZHTERvdnFTa2YwNkF3c3F2ZFZkOEozMTVXdWRwZDFuRTVpUlFGZFNPNGpj?= =?utf-8?B?VXhXRC9lUU5DMk9hTWlyVVZ6YjVITjRJK2JWZTN4dEpXMWt1eElVYVg2czVJ?= =?utf-8?B?MjFjWWdyVEZoamdWc0NRVkhOZFdNZE9LVmxWeVk3bVIyVXpjekJIdWhZZS9Q?= =?utf-8?B?dlpHSmJkb0tHSmdjbkZvMXJxS2FTenA1TEF2a3MrQVFkSHVzVnpwV0pQaEhW?= =?utf-8?B?TlFxZDNtN0w4SEI4SmxYeHZtOThtdFBUUHlNd0tYQ2twRWFpRDNNYnR0Wlp3?= =?utf-8?B?SUtPbGhLK25MUXhBV2ExVWkrWGF6cVVkS3BuVVlObzFEWHZ3MHBueDNTaXRi?= =?utf-8?B?MG9VT0pnQVdvc005cTZoNlpmL2dNRkpxU09YY05tdGZhMXRqWFZ6T1RxN1ll?= =?utf-8?B?T3M4ZHN4eVgyZndRb1ZDVHJvRTY3Z3VuWVE3eEdHRnVacmhVTHBRUHEyNEhQ?= =?utf-8?B?d3VNNmdIQzNVZmNTSUpHdUhORmRERzBaVlFDb3BJdy9OOFI0QldCZkx3aVpL?= =?utf-8?B?ZTVacVlZcjBpQVk2ckZUUlE2TWVGQ2NReENXalEwK1pLS3F2WlRiVEptYk1P?= =?utf-8?B?YUVEV0lXZlFWTC9GS2YwUE9qMFBKaHVDcm1WOG9OaHlSNGxjYkUrcmFYQWl1?= =?utf-8?B?TEZpMDIzT29KYlRwZGF4WlpXSHRuOVB2WWtmRlV3VnBUUG03YlZSYmRWeTlC?= =?utf-8?B?WXpsV2JlV1kwU2RleUMwMzRzOWt4VGxKOW1QQmp4cGVhSlM0L004NEphaEtT?= =?utf-8?B?a1Z5ZVkwN1dMektFd0FzcDRQVXRWKzZnVjNaUVIxbGxuMTUrYWJrcWZYN05L?= =?utf-8?B?WWorbENnMkp3ZHRHTFRmTGZtTFlLYnozQlhyT2k1MGx5N3RTQmZGZ2xMNzNI?= =?utf-8?B?cktBVHFZTXBIVFJNd3lSbUJpMFFOaUphYUFIanQrNXJtUk4zb2Q5QkN4UzZu?= =?utf-8?B?ajExWk0vdDRUMWRWTFFEODRmUjJtY3R5UmZlbzdhYlllZEFsTExnVDk0VnFa?= =?utf-8?B?NDlGYWd0WVZEUzF5YlozL2E3Y2U3d3NMTjEyRmlQYXNvTXJEZXNNUGI4a1o2?= =?utf-8?B?bGsxWWE2K1NXRHRBak4wVVlOOXFIbHc0TEZlbzZXTUNWM2J6VXArUWJ5V0Fl?= =?utf-8?B?QjFaVGpxd0hNc20zTzVOQkxZc3I0SUl3VTF2QkFmTVhrRGFQTUJKNWYvQ3Nw?= =?utf-8?B?ZmZCYnUzdTZ4RzJiY3A5VWRYOU9jbHh5MXEzbHNkaFFyRVhOR3NNZ1ZTbExI?= =?utf-8?B?NHh3eVNqYzRZOHJleXBucnRra0lHK01tREV4QT09?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(82310400026)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2025 14:16:37.2342 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 685d50b9-6c9a-4bde-ad3e-08ddb329bb49 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CEA.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7307 The __mcheck_cpu_init_early() function was introduced so that some vendor-specific features are detected before the first MCA polling event done in __mcheck_cpu_init_generic(). Currently, __mcheck_cpu_init_early() is only used on AMD-based systems and additional code will be needed to support various system configurations. However, the current and future vendor-specific code should be done during vendor init. This keeps all the vendor code in a common location and simplifies the generic init flow. Move all the __mcheck_cpu_init_early() code into mce_amd_feature_init(). Also, move __mcheck_cpu_init_generic() after __mcheck_cpu_init_prepare_banks() so that MCA is enabled after the first MCA polling event. Additionally, this brings the MCA init flow closer to what is described in the x86 docs. The AMD PPRs say "The operating system must initialize the MCA_CONFIG registers prior to initialization of the MCA_CTL registers. The MCA_CTL registers must be initialized prior to enabling the error reporting banks in MCG_CTL". However, the Intel SDM "Machine-Check Initialization Pseudocode" says MCG_CTL first then MCi_CTL. But both agree that CR4.MCE should be set last. Reviewed-by: Qiuxu Zhuo Tested-by: Tony Luck Reviewed-by: Tony Luck Signed-off-by: Yazen Ghannam Reviewed-by: Nikolay Borisov --- Notes: Link: https://lore.kernel.org/r/20250415-wip-mca-updates-v3-6-8ffd9eb4aa56@am= d.com =20 v3->v4: * No change. =20 v2->v3: * Update commit message. * Add tags from Qiuxu and Tony. =20 v1->v2: * New in v2, but based on old patch (see link). * Changed cpu_has() to cpu_feature_enabled(). arch/x86/kernel/cpu/mce/amd.c | 4 ++++ arch/x86/kernel/cpu/mce/core.c | 20 +++----------------- 2 files changed, 7 insertions(+), 17 deletions(-) diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c index 5d351ec863cd..292109e46a94 100644 --- a/arch/x86/kernel/cpu/mce/amd.c +++ b/arch/x86/kernel/cpu/mce/amd.c @@ -655,6 +655,10 @@ void mce_amd_feature_init(struct cpuinfo_x86 *c) u32 low =3D 0, high =3D 0, address =3D 0; int offset =3D -1; =20 + mce_flags.overflow_recov =3D cpu_feature_enabled(X86_FEATURE_OVERFLOW_REC= OV); + mce_flags.succor =3D cpu_feature_enabled(X86_FEATURE_SUCCOR); + mce_flags.smca =3D cpu_feature_enabled(X86_FEATURE_SMCA); + mce_flags.amd_threshold =3D 1; =20 for (bank =3D 0; bank < this_cpu_read(mce_num_banks); ++bank) { if (mce_flags.smca) diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c index 486cddefaa7a..ebe3e98f7606 100644 --- a/arch/x86/kernel/cpu/mce/core.c +++ b/arch/x86/kernel/cpu/mce/core.c @@ -2034,19 +2034,6 @@ static bool __mcheck_cpu_ancient_init(struct cpuinfo= _x86 *c) return false; } =20 -/* - * Init basic CPU features needed for early decoding of MCEs. - */ -static void __mcheck_cpu_init_early(struct cpuinfo_x86 *c) -{ - if (c->x86_vendor =3D=3D X86_VENDOR_AMD || c->x86_vendor =3D=3D X86_VENDO= R_HYGON) { - mce_flags.overflow_recov =3D !!cpu_has(c, X86_FEATURE_OVERFLOW_RECOV); - mce_flags.succor =3D !!cpu_has(c, X86_FEATURE_SUCCOR); - mce_flags.smca =3D !!cpu_has(c, X86_FEATURE_SMCA); - mce_flags.amd_threshold =3D 1; - } -} - static void mce_centaur_feature_init(struct cpuinfo_x86 *c) { struct mca_config *cfg =3D &mca_cfg; @@ -2286,10 +2273,9 @@ void mcheck_cpu_init(struct cpuinfo_x86 *c) =20 mca_cfg.initialized =3D 1; =20 - __mcheck_cpu_init_early(c); - __mcheck_cpu_init_generic(); __mcheck_cpu_init_vendor(c); __mcheck_cpu_init_prepare_banks(); + __mcheck_cpu_init_generic(); __mcheck_cpu_setup_timer(); } =20 @@ -2455,9 +2441,9 @@ static void mce_syscore_shutdown(void) */ static void mce_syscore_resume(void) { - __mcheck_cpu_init_generic(); __mcheck_cpu_init_vendor(raw_cpu_ptr(&cpu_info)); __mcheck_cpu_init_prepare_banks(); + __mcheck_cpu_init_generic(); } =20 static struct syscore_ops mce_syscore_ops =3D { @@ -2474,8 +2460,8 @@ static void mce_cpu_restart(void *data) { if (!mce_available(raw_cpu_ptr(&cpu_info))) return; - __mcheck_cpu_init_generic(); __mcheck_cpu_init_prepare_banks(); + __mcheck_cpu_init_generic(); __mcheck_cpu_init_timer(); } =20 --=20 2.49.0 From nobody Wed Oct 8 20:44:15 2025 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2078.outbound.protection.outlook.com [40.107.220.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B08EF2DFF25; Tue, 24 Jun 2025 14:16:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.220.78 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774605; cv=fail; b=KOC3kpJU6QwOd/p7DLUF2EHQppaWw5US48bK2ubymKs3SkuBuYcvr/fl51z/RK8RXHM8gmRkkPQu5hdl8JtkG1XhdF9As56QyuNfH1xbTeRVKn+CIJfGYC6FDVEhd8QPjgWPgmF2kWky3MAkPErrZpSivGdLVe6T86f/0e2GNfE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774605; c=relaxed/simple; bh=vPEQSSZrbPIEQ+3ZDYXQFGxEcbi0TwPXrNYJBi9QTBI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=rZJwBjoTPgt09DX0xwTAvq3HlLDJUN4BTPPZH7c8PHid2O9oEEvu4OmbbdpZdJNGsRBanETt1fhyCeq86oMvAq8VXYwwryFzscMnv9v7eZ5BT7H4l6iZBhnicAOtR7P+150J71dCtl9PC+D7s7xnGS38oZEcKlIcFEwJzEA7g1o= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=w/l/mBHS; arc=fail smtp.client-ip=40.107.220.78 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="w/l/mBHS" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=M0h0TTGh89EROFea9H+1sSn6V4dLXUvg21LlhryG4xUpglmUfOKEZm6OsvQBBoOT3x8R07ooORF4l5ME9RHE8Tk9K2Scn9G0fImsaOg7JdmLFc//DpRgDQwmjCAHXRmWGI65xYQGbrkYHUYrEXcTfAMiVDX8ToCp2jL6fRAHoS/xWwDlGvu7Wn9QZbHzVlXEha2fxVc3yvpbm1JkeEqZB7fBzKAmcDR4qe7nqygSz5SwgIZdBiNT/GIee4lnr8mOjlyRiAR3m9KMgG2u9D10tVmIegDsbHQRRLc3JXI3lMP3veSaztjhsa2g9HueOuZXJw5E84YREEIwScBM/8vFmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bP336B6mS4TQoArtsB77Dvuqac1/RA4b/+i+j1TYmhU=; b=mLz2gcoE/WW9MgC+cFPLlxqMsGqCiDRDkm2T2wkLehADosnWWJr7F04qKMKM4Ar5Vb7hi4ek9G3jdSTWiH+hU6UZXQfk7pGkk2zMjJUKyU90OheF9DXuefw27gbjeeOPtRRjEfE70BAofUmxlxIsrb3WhyEpD/6InEl2VhuzK59IBOjz9uvJyOe+CemBVykJENqo6sOrgaOq9hAPu5sxw8QcrXfJjMJ/+wdPGzyVR1kOd8Hy8Bd/b2A2dDBI4Uu6R/CQy2s67MRyyVkwC5QelcunKc5qbMkE7Q0RZhNiIo54hRaKN7K86dN/80/AvYmRvV1M0IcOsEm6YECxewMtjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bP336B6mS4TQoArtsB77Dvuqac1/RA4b/+i+j1TYmhU=; b=w/l/mBHSNuWAyqyTUwj8pm8/dva5sXuUjL/SCntldyf1E/079k5/+YYIY/LWYzfACRFhj+QOM/IURNV192AU56ktWSAVXj9RoSCUBrytosZ7Prh9ohtrWGSKD2eCWdhi6hTQu22FxZ+7cFMZ8wymW69pVYTVJ6wDRiXgsk9U1K4= Received: from BYAPR05CA0042.namprd05.prod.outlook.com (2603:10b6:a03:74::19) by CH3PR12MB8583.namprd12.prod.outlook.com (2603:10b6:610:15f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.17; Tue, 24 Jun 2025 14:16:38 +0000 Received: from SJ1PEPF00001CE6.namprd03.prod.outlook.com (2603:10b6:a03:74:cafe::2a) by BYAPR05CA0042.outlook.office365.com (2603:10b6:a03:74::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.16 via Frontend Transport; Tue, 24 Jun 2025 14:16:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CE6.mail.protection.outlook.com (10.167.242.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8880.14 via Frontend Transport; Tue, 24 Jun 2025 14:16:37 +0000 Received: from [127.0.1.1] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 24 Jun 2025 09:16:31 -0500 From: Yazen Ghannam Date: Tue, 24 Jun 2025 14:16:06 +0000 Subject: [PATCH v4 11/22] x86/mce: Define BSP-only init Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250624-wip-mca-updates-v4-11-236dd74f645f@amd.com> References: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> In-Reply-To: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> To: , Tony Luck , "Rafael J. Wysocki" , Len Brown CC: , , , Qiuxu Zhuo , , Yazen Ghannam X-Mailer: b4 0.15-dev-9b767 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE6:EE_|CH3PR12MB8583:EE_ X-MS-Office365-Filtering-Correlation-Id: db46ff50-5b1d-40bb-77ce-08ddb329bb75 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|36860700013|1800799024|13003099007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?R1Q3NWk4RDFNSUVtNGdJeU15LzJhSVdFK0lpeVVudjZCN1RlTG0weDIrdUJV?= =?utf-8?B?MkdBc3Q4cm9HeXo3L1R3b0E1T1FaV1BaRVpxd3dRVUhDaHZ3UkxLL2Rud01F?= =?utf-8?B?UjVFbVhGTmw4ZnVsRzJUZXFYeXNaZENPSWpFbkV6bVB6aGxBUHh5NGh6QTA3?= =?utf-8?B?aytzcXhhdFQxR1ljMkFGSGJTQ3g0TkFWV0RMR052eDVVbTB5OFFaMmVpblll?= =?utf-8?B?UHpqeUFFeERVL1Q5czdkTDk3RWZIOTY3bVpHTGJ1SEZxRGtIdVN1TmNOdDFD?= =?utf-8?B?dDh6ZGF2dG04N1ZWd21FWFdDY05ZeS9pS1RQWDVBYVFSS093UHNhNHJ4aHIy?= =?utf-8?B?citVQ3JnYUVndlp5emtpYkNNaS9SNS9Da1E4UGFJc2R1R2JqUnF3RHhzRFEy?= =?utf-8?B?dUptQTZuOUkyUEVKd0FXTFNwNjJDdmJab0lFdE9iUHRTdGRrb1lRcGM1WHRw?= =?utf-8?B?NC9WTFFzQjJUU2N0aW96VHNxTHRTaWZ3b2ZPL2ZMYUUxM1RJM0xHK3ZNYXp2?= =?utf-8?B?ZzZsNXJaSVFLOVF1ZXJ0Tmd0aWxYcFIvQ1pIOFNnREdSbFZMTjFEQUhhNlNo?= =?utf-8?B?WVg2RXpTWkFSbVlrcTd1eVhyR1RtUFV5VGc0ZTZ1M09xTFUyOXhKd3dMTmMv?= =?utf-8?B?S25leVRUTzRVbWUxWkZBNHRxZHUxVXB6VHZMYWRMYU1xMGlsUFFIbUcvYmNy?= =?utf-8?B?Z0d0bVh6ZlFZYzRPRkdveFZhZnBKcXZjOHpPa0JLNThNVXQwV3FPejMwRDI0?= =?utf-8?B?TnlIb3VOM08rWTJoZmlSczNVK3M3SjlkLzBjWmw2Njc0WiswdTBtQzVYWWpF?= =?utf-8?B?VXI2aUV6L2hXZlkrOUx5bHRTS3ltSGxSU3dsSEloSDlXOUxQYXB5WWJ1R2ti?= =?utf-8?B?UnNwS3dVa0xSTDdHa0tPZEZ5UDNEWUkzYVJqZGJibEFGT3U4MFJMaFNFVnpD?= =?utf-8?B?YkVEZzVGZFFVMHUyT3NvSHpsb2tlNXkwRVBYVGdnblR6ZlZwQk8ydi8zNEg2?= =?utf-8?B?c3dybE5VcWIwT0t3MXNSOFJ6S3NHT2l3R1VEVVdmbXNUbVcvbmZqUktUSEd3?= =?utf-8?B?T0VHcm1PQUdQaUI1TjlKSWhGWmtRWHFkRVFULytCUWN2aFFSOWFYLzgxUlhm?= =?utf-8?B?WDljWjdzbUFHUTdFME1zSnRtdFhwRTloMzJFK29zNEhKeFA0VzNGRXRncitv?= =?utf-8?B?K1JXMlh1OWFvY3lKQ2diR3hXSVJGNXdmQ0c0QmlBaWdtV0krTnAvVWorZHZj?= =?utf-8?B?dFVaQjB1TXhpQkg5MjV6ektzN0h1K1NidVdoK3BSdlVQbE4wTWJCMlJNUE5s?= =?utf-8?B?MVNZMHdMS3hvN2JnaXBxaGpLdURGbXhWcFJ6SWhGUFBuaHZrTTlwcU5aOWhJ?= =?utf-8?B?dDhDdjVwQjdtS0x0cEVKRTRLU1lkWC9LOHkwbGFiWEJ5ZTNqMTNGdUpNQUF3?= =?utf-8?B?M05oQ2xQOERaYmxWMkdYL0hCK1ZaZWEzaHQxdUxmRVlHV3Z3THhKNW8wRGpG?= =?utf-8?B?UGFVbzh4OWJ6UWNNNnUwbm8zaG9NdHZLbE14UGRMYW9BUFEzQ2tHMTUvWDFq?= =?utf-8?B?OFJRQmVQM1IrUjViZkQrYzQxNVBvOVBHc1k5RFgySWM2VjBMSVlBQ0wyNWI4?= =?utf-8?B?dFU5ZktSY29aM3I1cnBoWGlXallzQmFMK2dCOEt2UDQvQ0dLRUJaakk2L3NT?= =?utf-8?B?dXI2eElmVTZlKzlvdDB5eCsvLzlHU0Zrc1BGSjVidmpuNjBLeFY4b2FBYUph?= =?utf-8?B?b1hDTlFWaVludXBQSTR6dHNSYzJPaDIwVXBDeHpRTkZpVk9tc3FGT1kvbm9J?= =?utf-8?B?UXdGS1B6aEpKT3RmTDBoUjRrRGwyajBzb1NrZGFmWDZSQXduS1U1cTBpTDgv?= =?utf-8?B?dGpPZnUvU3UxZjlrT1ZUTHVHc1ByV0dIUWNtU0RiWnFVU3gxVU05RE9uMDMv?= =?utf-8?B?TW4xL3psTmhuVFRNaC9QZ0wvYW9EUE1XRVU5blVLUnFYaEpCUjh2LzFiT1k5?= =?utf-8?B?T0lhblhBdDFueGo5SnNwQWJxSEtoUXZTWVg1cWQ3bmRPTUkzN29wYnlRd1dL?= =?utf-8?Q?9A0FXZ?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(82310400026)(36860700013)(1800799024)(13003099007);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2025 14:16:37.5193 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: db46ff50-5b1d-40bb-77ce-08ddb329bb75 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE6.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8583 Currently, MCA initialization is executed identically on each CPU as they are brought online. However, a number of MCA initialization tasks only need to be done once. Define a function to collect all 'global' init tasks and call this from the BSP only. Start with CPU features. Reviewed-by: Qiuxu Zhuo Tested-by: Tony Luck Reviewed-by: Tony Luck Signed-off-by: Yazen Ghannam --- Notes: Link: https://lore.kernel.org/r/20250415-wip-mca-updates-v3-7-8ffd9eb4aa56@am= d.com =20 v3->v4: * Change cpu_mca_init() to mca_bsp_init(). * Drop code comment. =20 v2->v3: * Add tags from Qiuxu and Tony. =20 v1->v2: * New in v2. arch/x86/include/asm/mce.h | 2 ++ arch/x86/kernel/cpu/common.c | 1 + arch/x86/kernel/cpu/mce/amd.c | 3 --- arch/x86/kernel/cpu/mce/core.c | 28 +++++++++++++++++++++------- 4 files changed, 24 insertions(+), 10 deletions(-) diff --git a/arch/x86/include/asm/mce.h b/arch/x86/include/asm/mce.h index 3224f3862dc8..31e3cb550fb3 100644 --- a/arch/x86/include/asm/mce.h +++ b/arch/x86/include/asm/mce.h @@ -241,12 +241,14 @@ struct cper_ia_proc_ctx; =20 #ifdef CONFIG_X86_MCE int mcheck_init(void); +void mca_bsp_init(struct cpuinfo_x86 *c); void mcheck_cpu_init(struct cpuinfo_x86 *c); void mcheck_cpu_clear(struct cpuinfo_x86 *c); int apei_smca_report_x86_error(struct cper_ia_proc_ctx *ctx_info, u64 lapic_id); #else static inline int mcheck_init(void) { return 0; } +static inline void mca_bsp_init(struct cpuinfo_x86 *c) {} static inline void mcheck_cpu_init(struct cpuinfo_x86 *c) {} static inline void mcheck_cpu_clear(struct cpuinfo_x86 *c) {} static inline int apei_smca_report_x86_error(struct cper_ia_proc_ctx *ctx_= info, diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c index 8feb8fd2957a..8a00faa1042a 100644 --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -1771,6 +1771,7 @@ static void __init early_identify_cpu(struct cpuinfo_= x86 *c) setup_clear_cpu_cap(X86_FEATURE_LA57); =20 detect_nopl(); + mca_bsp_init(c); } =20 void __init init_cpu_devs(void) diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c index 292109e46a94..25a24d0b9cf9 100644 --- a/arch/x86/kernel/cpu/mce/amd.c +++ b/arch/x86/kernel/cpu/mce/amd.c @@ -655,9 +655,6 @@ void mce_amd_feature_init(struct cpuinfo_x86 *c) u32 low =3D 0, high =3D 0, address =3D 0; int offset =3D -1; =20 - mce_flags.overflow_recov =3D cpu_feature_enabled(X86_FEATURE_OVERFLOW_REC= OV); - mce_flags.succor =3D cpu_feature_enabled(X86_FEATURE_SUCCOR); - mce_flags.smca =3D cpu_feature_enabled(X86_FEATURE_SMCA); mce_flags.amd_threshold =3D 1; =20 for (bank =3D 0; bank < this_cpu_read(mce_num_banks); ++bank) { diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c index ebe3e98f7606..c55462e6af1c 100644 --- a/arch/x86/kernel/cpu/mce/core.c +++ b/arch/x86/kernel/cpu/mce/core.c @@ -1837,13 +1837,6 @@ static void __mcheck_cpu_cap_init(void) this_cpu_write(mce_num_banks, b); =20 __mcheck_cpu_mce_banks_init(); - - /* Use accurate RIP reporting if available. */ - if ((cap & MCG_EXT_P) && MCG_EXT_CNT(cap) >=3D 9) - mca_cfg.rip_msr =3D MSR_IA32_MCG_EIP; - - if (cap & MCG_SER_P) - mca_cfg.ser =3D 1; } =20 static void __mcheck_cpu_init_generic(void) @@ -2243,6 +2236,27 @@ DEFINE_IDTENTRY_RAW(exc_machine_check) } #endif =20 +void mca_bsp_init(struct cpuinfo_x86 *c) +{ + u64 cap; + + if (!mce_available(c)) + return; + + mce_flags.overflow_recov =3D cpu_feature_enabled(X86_FEATURE_OVERFLOW_REC= OV); + mce_flags.succor =3D cpu_feature_enabled(X86_FEATURE_SUCCOR); + mce_flags.smca =3D cpu_feature_enabled(X86_FEATURE_SMCA); + + rdmsrq(MSR_IA32_MCG_CAP, cap); + + /* Use accurate RIP reporting if available. */ + if ((cap & MCG_EXT_P) && MCG_EXT_CNT(cap) >=3D 9) + mca_cfg.rip_msr =3D MSR_IA32_MCG_EIP; + + if (cap & MCG_SER_P) + mca_cfg.ser =3D 1; +} + /* * Called for each booted CPU to set up machine checks. * Must be called with preempt off: --=20 2.49.0 From nobody Wed Oct 8 20:44:15 2025 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2046.outbound.protection.outlook.com [40.107.237.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E8742DF3CF; Tue, 24 Jun 2025 14:16:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.237.46 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774605; cv=fail; b=ceVOeAw96lTpkMnPMPPmJ2v7SBReH5oDaRFoKiBRfd60+BPXHXFuPqTTwp9uCfqcDDZEtDd5p4nj70Uba2upsALW7n1zm+J7pXORhh6c1sKtV439SMEFj1sAd/2dmFs0U5hfCn5T8D18ki6FKb69v4aUyfDkixYqE8sLALk/qBw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774605; c=relaxed/simple; bh=+JSZfAqUtjBAbCGYXXcdQkt7xR9QJYOKBOdIiLugiO0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=At8pat6dA8YJGqe8ulG+gEIRmg3840HuD2L3a5ERGlIotANCX9LeoVFYu/UVNrHM48QGXRRJpytLgRiwOe2Tn2l5UpUQDhAKIONHdk6ZtrjHiUS74Lv5SAMW7PAfBjLxDGwKn9jWsI4ePUHzC8bOttKhoKue8TCa01sTqpRHAWM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=f5J9XwCg; arc=fail smtp.client-ip=40.107.237.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="f5J9XwCg" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Bo6VbogPU2mdtWtQS/ryCeW6e0Gg5DyYi65weJl0WwEFtCkTnms3yECwMVfen/YWmgK1Rq7k/Ca6FY2l4ITZ74MEjV9gtC4xNgy2VVVAsBfY/MC9tEUCOZHgac6pbPqlL1UT3aqPpiTkitLa51BfRB/0nIg3n9ASPrPRUnXNhCYSafEQ/yizPxIS8C935nFnUWNxSKerBLUJMbkocYxL7TCm4pjLIxSVjJ8lJ7i4u8Wuf4Q6TNVKfgNwnBhYMVe+vpMs1d4nApT6kesOB3aT9VC49GpvMCVMgzOA698IAnJKXkOkTXCRbVKKLDwdfMhOR4Y4WmbtHXPvte7rhgaA8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZLnWDrZ3Uz/9NQm9vYqEbfkR0n+TxZl/17+7p9Q3Lvc=; b=aO0EUa6tGdMrvWttiTyFG+5oOdmWGr96dFQe1iRWq7dkpU/evK47Uhd9oAknQVd+qyP0WPfzCnwdHrW1bOcMyzrLFwZ1QIhnDb7I4OtpKOzZ1X/o2/WfFsUL2rTpedEJhlJTGIHKjk3hK0XrHJqKleZ4EHqpWB9oQ02tTuf5GZjN/piVpN6SL5daib+nlG8NBGxIZ40j+fKzsIem6Wh9K1iqXY3bUstY4CCpDdtnhTfD9EXZ3qLREPo3NyWHPEXUqCW+RnyE18sWB4prqsfFZLRMKjcLv2CEdE/u1qjwxOusRp8jOn3IeEYUtY8iOoLPllDpnpXB+Jp5V0OcdM1klA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZLnWDrZ3Uz/9NQm9vYqEbfkR0n+TxZl/17+7p9Q3Lvc=; b=f5J9XwCgZH8jp13FAFY0AQwR72VW9p9vviFPqgk+gu6eRuNcNd1UJoPd/mv0cBPgTeEtKO1b3NRdI/TURkA08vPNWaEsugCJ8gXxDtOpZzV9ToHJr1dMxjA96j9Lh7dUKJM/mUicyOcB2A2zGslwqXDPbX6g7Tbv1wfh6jLPtCE= Received: from BYAPR02CA0051.namprd02.prod.outlook.com (2603:10b6:a03:54::28) by BL3PR12MB6427.namprd12.prod.outlook.com (2603:10b6:208:3b6::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.28; Tue, 24 Jun 2025 14:16:38 +0000 Received: from SJ1PEPF00001CE7.namprd03.prod.outlook.com (2603:10b6:a03:54:cafe::ff) by BYAPR02CA0051.outlook.office365.com (2603:10b6:a03:54::28) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.17 via Frontend Transport; Tue, 24 Jun 2025 14:16:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CE7.mail.protection.outlook.com (10.167.242.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8880.14 via Frontend Transport; Tue, 24 Jun 2025 14:16:38 +0000 Received: from [127.0.1.1] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 24 Jun 2025 09:16:32 -0500 From: Yazen Ghannam Date: Tue, 24 Jun 2025 14:16:07 +0000 Subject: [PATCH v4 12/22] x86/mce: Define BSP-only SMCA init Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250624-wip-mca-updates-v4-12-236dd74f645f@amd.com> References: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> In-Reply-To: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> To: , Tony Luck , "Rafael J. Wysocki" , Len Brown CC: , , , Qiuxu Zhuo , , Yazen Ghannam X-Mailer: b4 0.15-dev-9b767 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE7:EE_|BL3PR12MB6427:EE_ X-MS-Office365-Filtering-Correlation-Id: 0b6a837c-810e-49a4-e6bb-08ddb329bbd4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|36860700013|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?RTVVd0ExSnRBVHNHRkE5ZTlLQWZjc3UxVWJoc005Z0JHbTh3UGMyU3dOeFFa?= =?utf-8?B?YWx4U0hURlgwTk1jeks4ME54NUt5WXJUT3FiMVVNMFhiQnVqcVhkYVpUWEkv?= =?utf-8?B?V0ZqMmFlanhCclN4cnpJamZPZkx3ei80bkZ0M205bGswRnZIZFBmN0s1RlE4?= =?utf-8?B?Mjl4Z05kRHR5cGx5c0FxVzFvdVE2L3Y2YzNxbUxwbXBtc3RUUDRCa0FRTjdn?= =?utf-8?B?MTdjbVViYVdqL0FHcUZ0TFlBdzZuZDFXMlNHU0d2NlpiQ3VYMDFWYTErZE4y?= =?utf-8?B?Vk1uTzNCMWNGWjdIRENBNkxJUzV2VlFKUWVZaFlURDhPamVDZEhNeGF0bVNL?= =?utf-8?B?aHgrRjlMRkNCWDl6amxUNE1XU2NRaUFmZzF2TU9DQjVqTE1jdEhtVy9PZHpE?= =?utf-8?B?aHVsNjdWL0NMRGxCVkJ5NmllU1FuSHFVZWc0TW8zNkZDUzFNdVZtdXBXTGNX?= =?utf-8?B?V3hzZExUYUtPMk9UL2duait3Z0hQZ01ML3hmbjRPOGxzdkd4M2RFM3BjVi93?= =?utf-8?B?a2tJNnhDZmlZc01TalZmMEhKeGhtcTc1NXZQTFpnVGNrOUp2L2oyQW9aeGw5?= =?utf-8?B?eFp3WCtwNExtZ1FzQjBVZkRaS3hGVjFWRnZTUldmYzVqUVlPSlVmSFJCQzNJ?= =?utf-8?B?SU9jSEZQNGcwcDVSSEV0VmxHVDRmNVp1VHN0N0VaS2lpM1FYVU1SN00vSlBR?= =?utf-8?B?MmlBOVpzT2RzL2R6WnJRWW80RGlEMmZUUW9nc3RhOXp3b2RzVm5pbTBYaTh1?= =?utf-8?B?bWMrZ1RNQitGL2JYMjRqRWxwdEszNitRVldWNktTcXZGUFBUd0loZnFEUDJx?= =?utf-8?B?cW1oZmp0MFRjWlVsRGdjK0hQcVdicEUwMS93TFB3RU9BWUVMcGk2Rk12NFJC?= =?utf-8?B?b1Z3QjBWOUJLR0hUanBZdmRJbVRlN1pTZ0tteS9JSXFORnFaQXZmcEllSE04?= =?utf-8?B?eXY3YzQ1Ykc4YnZIUlVXUTZleWlVZTE2VHNSL3pCcHhMM1U2eUduODQ1cjdl?= =?utf-8?B?NXJvai9JSTJVaUFnR2FCUVNqUGF1VndtMzZlaExjekl1b2JNR2NBcmxQekNv?= =?utf-8?B?aEYySjl2ZnBNUUYrT2dWZXdmMTljUmY1UzBqc3duaGRxK2lTNGJOY3p0YU1D?= =?utf-8?B?WHlLSy9yT29OYUlLb0RFSHFweW5Zam5IemgxMkYxQVFlOHZ6eTNJR0JTTmk0?= =?utf-8?B?Rjk1Z0tFU0xSS1NWR0RFZ240bGJOelFRa3pibWYxSlN6emUrNytobHFXRWtS?= =?utf-8?B?b1JyaHliWEJLV3VUbElzTy8raEJwdjNRRjhibDB1cDFQcENkK0FhOFBoelhi?= =?utf-8?B?emFmQTFEWGtSQk9NMzlHcVFLUGVnWmlWQ2JIWlRyWEwycDVUYWVUbHhtN1JV?= =?utf-8?B?V1V0NDA3bUQzZnhPb2xUVnNoc0I3YlFRNU1IZk9Ja0FwY2NmU0Q1SGFZYXFm?= =?utf-8?B?NEVDZVAxM2doSis4alRHRE5nVVBmL3pHRDZYWmZuRFlWdTl6SVpuWmVrOWc1?= =?utf-8?B?QTZpR21EVUlQVHY1eUVKWU8xcTVubk9VL0pmZ3NuOUpleSt6Yy9jYmdsblhP?= =?utf-8?B?T0NLV3hnMmJ3VHV1aU1PaXRrVHJqSFZKWTlDbFV3bDY4R1JpR3Jody96bnZK?= =?utf-8?B?cFhpdWpKbTBVeFRkUWhPdkRGTnYzYlRrREpWajkzWVFEcGY2TkVwWGgvVGV4?= =?utf-8?B?NE5iMGJuUFl2YXRiM0RpWkQ3NGpvMzdQM2dQVUFGa2tKaXlMdG9HNWdqMUVV?= =?utf-8?B?cHFuYVpBTWVTUWFUWTZCSE05YzIwdlBoM0tIRjlEcFJqTk5wWjFBUXFndlpy?= =?utf-8?B?N1l3NSt4Y3Jxb0pPbUh6KzlhVDlKNVJRR2sycmNaTE45V3BVdUJ2K0Y1bUxX?= =?utf-8?B?VkN5UitsNVBjYmNmNGJEM3RxVVdMd1U5ZlFya1h6U1Nkb1hOTzFNRUdQZ0Vn?= =?utf-8?B?aWpPNkprR01lclB6VFkzR2FueFJTWVNMZmVPVXBTRkNIU0llUWQxUTJYMkQ1?= =?utf-8?B?eTNkVWJNL2dZNXFsMVpsWWhqbXBMOXFGaC81b1dKWWNRaDB4TXk1TXdqdXFl?= =?utf-8?Q?Ah/d0R?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(36860700013)(82310400026)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2025 14:16:38.1443 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0b6a837c-810e-49a4-e6bb-08ddb329bbd4 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE7.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6427 Currently on AMD systems, MCA interrupt handler functions are set during CPU init. However, the functions only need to be set once for the whole system. Assign the handlers only during BSP init. Do so only for SMCA systems to maintain the old behavior for legacy systems. Signed-off-by: Yazen Ghannam --- Notes: Link: https://lore.kernel.org/r/20250415-wip-mca-updates-v3-8-8ffd9eb4aa56@am= d.com =20 v3->v4: * Change mce_smca_cpu_init() to smca_bsp_init(). =20 v2->v3: * No change. =20 v1->v2: * New in v2. arch/x86/kernel/cpu/mce/amd.c | 6 ++++++ arch/x86/kernel/cpu/mce/core.c | 3 +++ arch/x86/kernel/cpu/mce/internal.h | 2 ++ 3 files changed, 11 insertions(+) diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c index 25a24d0b9cf9..d55c4b5f5354 100644 --- a/arch/x86/kernel/cpu/mce/amd.c +++ b/arch/x86/kernel/cpu/mce/amd.c @@ -686,6 +686,12 @@ void mce_amd_feature_init(struct cpuinfo_x86 *c) deferred_error_interrupt_enable(c); } =20 +void smca_bsp_init(void) +{ + mce_threshold_vector =3D amd_threshold_interrupt; + deferred_error_int_vector =3D amd_deferred_error_interrupt; +} + /* * DRAM ECC errors are reported in the Northbridge (bank 4) with * Extended Error Code 8. diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c index c55462e6af1c..c852d06713ed 100644 --- a/arch/x86/kernel/cpu/mce/core.c +++ b/arch/x86/kernel/cpu/mce/core.c @@ -2247,6 +2247,9 @@ void mca_bsp_init(struct cpuinfo_x86 *c) mce_flags.succor =3D cpu_feature_enabled(X86_FEATURE_SUCCOR); mce_flags.smca =3D cpu_feature_enabled(X86_FEATURE_SMCA); =20 + if (mce_flags.smca) + smca_bsp_init(); + rdmsrq(MSR_IA32_MCG_CAP, cap); =20 /* Use accurate RIP reporting if available. */ diff --git a/arch/x86/kernel/cpu/mce/internal.h b/arch/x86/kernel/cpu/mce/i= nternal.h index 64ac25b95360..6cb2995f0ec1 100644 --- a/arch/x86/kernel/cpu/mce/internal.h +++ b/arch/x86/kernel/cpu/mce/internal.h @@ -294,12 +294,14 @@ static __always_inline void smca_extract_err_addr(str= uct mce *m) m->addr &=3D GENMASK_ULL(55, lsb); } =20 +void smca_bsp_init(void); #else static inline void mce_threshold_create_device(unsigned int cpu) { } static inline void mce_threshold_remove_device(unsigned int cpu) { } static inline bool amd_filter_mce(struct mce *m) { return false; } static inline bool amd_mce_usable_address(struct mce *m) { return false; } static inline void smca_extract_err_addr(struct mce *m) { } +static inline void smca_bsp_init(void) { } #endif =20 #ifdef CONFIG_X86_ANCIENT_MCE --=20 2.49.0 From nobody Wed Oct 8 20:44:15 2025 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2049.outbound.protection.outlook.com [40.107.244.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA1442D8787; Tue, 24 Jun 2025 14:16:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.244.49 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774602; cv=fail; b=S/7LXtAR0MaESDRNGtHJwsdT6YGOE1Acu8JeU2an5KRGIby07TPtaCztp3AigN06bgBf0gHbJqMTMYFs1n7afrS+2YdpOA6epecwDojsArhT4c44JcDtLojW47I4WbVviZ+LRxhWR4u/++95eMXV6d/MfJv6XJwx3kY6+9yS9XQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774602; c=relaxed/simple; bh=h7qJZlqYI6jdX+qt78rqDswnA/5YNQUm7BugACjCqWk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=THQCzOBnNexSj90/MHC/sFaQzNDnbbeJypJxylxfxzJ4ZTxiPZgxx3xM2IP3LCiexIalcPiINtGi0dNx4opm2EYI/8xbX4x15rrXu170BuNjE4Br6Pw/28uIVEDxT29R4vqY6gvH+Eah7LOCWJQfbARhAL65/O0jeiotBfMN0Qw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=ucV/5DXj; arc=fail smtp.client-ip=40.107.244.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="ucV/5DXj" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GS8FaZBzZele4NZnfMNCJjq/6yTWdZL7k5cafbNKhB0zDfUsz6gaDz/H/vDTX7uksIpuzGxuxE3vIDVrs776fQwY8j2MVlMJniar4o/+klZb3NwbE5F05AfGzlA6uiO9SW0GZFpy9VWMSDl3hsNz7T4IY8DeqErsYvvXXXZSpbheKhPVlancmECcBwH45HlgD9xQTE4XCwf4v4XJ5sW5BtaEM0GrZNONYsWs6JFLcQJ+6/a3RXznq8Xd2fOmtBcanu+y3uzGGJiN65AsRsQ04p3M0/ta6Pq5Z++IckEwB/qMFxh4Mtp4eHDxdAYkja13Mc/1DhjKJS9o5JJr9jwdCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8PmjHIUFybsIpygOH7b9ziSVBlfeuV01DExs1A1uOVs=; b=bafvpOX57SZdZd05khDKpiD54jUnHzVgdoSfPnNXlDoO6SDhFZTkufzRBT9sI1gYUejT6ntZ7JVZ7TY6lIHtvvlb/kNemf1AZYLZbICSxLn2ZcKhbXk3GdqTqLCUUytEMo6OcpUhc5qyZBC/sHMKwpJ2ZoZAQWlA2XDAzZQn4Ee5hw1OnTiN1v81mU5APXNbcEiJU2ph0Pq5sWXbAuN/xCUOvu0wl6yt8z66UlRDZAySqQclM3J5wePjXYUSJHE9Gu1J3z48RuUZpkhjTecfpuDq6VjiDl5H5ibEud+wO4LQWM0Z9VuEAAMPQbEXirE8xC9CCTDwpkznDTMTUocMmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8PmjHIUFybsIpygOH7b9ziSVBlfeuV01DExs1A1uOVs=; b=ucV/5DXjUEPKnbGYv45UNB6vyvppVV2CcMgnyRDsGeHX+o3yBbmv831AZDgi/xW2wnENc0B2ddcWEwoqX9hsnOOdryaU+CM5+tln2R4QsZPHY4EbIQshSRkNx/z1nCa7PMIud/glUnN1JNHMIPrCU6hQWNjWQlcuXE782iJwZdI= Received: from MW4PR03CA0230.namprd03.prod.outlook.com (2603:10b6:303:b9::25) by DM6PR12MB4139.namprd12.prod.outlook.com (2603:10b6:5:214::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.29; Tue, 24 Jun 2025 14:16:38 +0000 Received: from SJ1PEPF00001CEA.namprd03.prod.outlook.com (2603:10b6:303:b9:cafe::e) by MW4PR03CA0230.outlook.office365.com (2603:10b6:303:b9::25) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8857.29 via Frontend Transport; Tue, 24 Jun 2025 14:16:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CEA.mail.protection.outlook.com (10.167.242.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8880.14 via Frontend Transport; Tue, 24 Jun 2025 14:16:38 +0000 Received: from [127.0.1.1] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 24 Jun 2025 09:16:33 -0500 From: Yazen Ghannam Date: Tue, 24 Jun 2025 14:16:08 +0000 Subject: [PATCH v4 13/22] x86/mce: Do 'UNKNOWN' vendor check early Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250624-wip-mca-updates-v4-13-236dd74f645f@amd.com> References: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> In-Reply-To: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> To: , Tony Luck , "Rafael J. Wysocki" , Len Brown CC: , , , Qiuxu Zhuo , , Yazen Ghannam X-Mailer: b4 0.15-dev-9b767 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CEA:EE_|DM6PR12MB4139:EE_ X-MS-Office365-Filtering-Correlation-Id: fba33849-4a7f-405a-1c0c-08ddb329bbe6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|82310400026|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cUNCdXFneURRZkJiQTVtU2xWVEszd2pycjBvZGxmSDNvZjgwTXd0c084R2Ry?= =?utf-8?B?bWxXeFJ6T2JLZzhyRExmUElUV25jRzFJYnJ5Z0ZWL2hIbUtrVzZMYkNoWjY4?= =?utf-8?B?YW1pTHYwV3dESGFTcEZxK3B1RTcyYjhzMGtWb3VJMG13UDlmdXp5SE80Q3N0?= =?utf-8?B?Z1ZmSDBadHFVdXZyTG84dzFEeTB0RkRvWVM3eHJUSGI2UDg1YWdhSjlnSjdI?= =?utf-8?B?TTlGWW5wa0JpQnpoN2F4UFY2NnN0a2llaFk5cHdMVE5iWmpaMWpmdEZsT1dj?= =?utf-8?B?VVhicnYwV2ZsOE02aE5hazJDSnduTTlQOXpwODNVRVlWbHRwT0JIZ1lqbDly?= =?utf-8?B?UzlwUHo1YWU2WEptdkF0a0wwTDRaVHVOWm1qS1BpSVB0OUx3cFVXWXZ6OGhu?= =?utf-8?B?WlIyUjdqWXdzb25tdG9wbyt2Qkh2ZzFUYjdtbUpRTXBYMUVpdk9DWHdReEVF?= =?utf-8?B?bFh1THBRRmZvN0RNbm5iSWM4VlBUZlRoWEhLWll3RGVNb2ZTK0hqSzZQTWVH?= =?utf-8?B?QytqQXJ5QWxYTU05RkZKZTVUa0Q5akR4enBPa3NCS29YVGRtOFFYcm5wU1Fh?= =?utf-8?B?eUZBYzdvVkdKRXJ5ZSs5T0RmcTM0bzk2Y1JIUXcxdWwyUEtnbHJSaFVEMWpy?= =?utf-8?B?NVBzdEo0RVJjV3B0WFhRR0NBMlg1aGQ2b1FuVGp5cWc3bEY4dzRhRHp3UUpq?= =?utf-8?B?RnBZNDEzQzQ3WGZkVVpyQ01uc0d4T3VBWlVMR2dXTzRUQ0dxUlkrTTFCSWho?= =?utf-8?B?MGNnazJuQnkrY2dTSCs1ZlI4QWkzbThBZnNqZHVoTEZVYmh0WEN6ZWNNSFNN?= =?utf-8?B?NldBY0I2RmtnaDB2cWdrQWVSRmR1YXBUaE5TMjBBdmpSQnBzVm96RWJ1NlZS?= =?utf-8?B?VWxDd1hhb0RENmptSkJGZXhrMTRKM1lINXROTTV4akdpbjFMdHVpNktWeTRR?= =?utf-8?B?blU2anF4Zi9McnhyaFZ6NmZhVVBUQW1rVVdCU1BzdzIxNTNQM0NKTW1HaXlV?= =?utf-8?B?TjExci95T0xINnlBNVIwR2R6a2NzYlRBc2JsVUdvcDJxZ0hrNVlPQkM0b1pG?= =?utf-8?B?OGNCK3JTMWhPTlQ4ZHVBNFgxVzl1YzA5Y1U3K0dxUkw2WnRuQzBsRExjVVVw?= =?utf-8?B?bldsdVMwM3gwZ1VJMnIwMUYxb05qSEJISGhCdzltTEhJcU9hV3JlWnhRRXhO?= =?utf-8?B?bEowMC9zMG1xQ1M5Nit2TEdUYUJNWUdjSXpOSGVzSjY4R3BQbnczbnpUVFAx?= =?utf-8?B?VzdLa0hKaVphS2dZanhvU3BncWNTWC9IWlRrT1hqNmsySmhGTDlCcHpHbnpR?= =?utf-8?B?M3hiN1N3UkFoS24vUlV1U2JsSnpEMlM1RVVJR25RTmxPaEFBSmltWWV3Z2Uy?= =?utf-8?B?ZmxLZlg4a1JaaXdlUGZoc0UrSXg0N3BITXBLcVY3VkMzamdzYm0vWGtsNGk3?= =?utf-8?B?MCtzbHBEZjZIMjd3NnBpWnZzdlRrYlVIUlY4SnhGQm8xUlFIdG9MQTNmSzFh?= =?utf-8?B?KzRxa0NwbFRqUWViWDNHUDhpdGpWdk5PSGkveHRJemNSMmlqcnVjdFdoc2VO?= =?utf-8?B?Y25ZbjFjRnJFMVVTRlRnZ1FpOWJnaWJkRW15Tm96QmhScExmUC9oWWNaT083?= =?utf-8?B?MG9SZmJSaExuSFdaU09yc0VDRXRXbGY5MUgrZE1LaG44S1JOSUs3T21EMGZ6?= =?utf-8?B?YXZmM0Q4T253TXRUSUhrUjFtNVNlZjJ1NGV0dkRNSSs0U3dPOEtUbm9GMDJO?= =?utf-8?B?NHR5UWlDSXo3VVkvaFBjWUYySW45LzJIdUlwcy9YN0tHVHpUajlxcjhiM1Fw?= =?utf-8?B?MURZbHE0dllvYi9nQWdhQU05Y1U0MWtIZStKdU8xL2daVzRpU0xEZFVpbHM1?= =?utf-8?B?V0syTTdJWUoyY1djV1pTcXFxU3NybFZ6SHYwNjJmVWZxM24vZ0VQSkUrM1Vz?= =?utf-8?B?NFJRVlhkdkFMZDFVUFVzMFU4K3dZendLN3luMTlSOGtsQ0FZVFNWTnh1TVdR?= =?utf-8?B?c3JiWTlTdnZwbHNKeGtuM3dRbFJCMWJLZFlMSjBtaFdISmVKbW5WV01Cd2p5?= =?utf-8?B?dkFoY0VpNTdHeWI0Z3M4Q1pjdHk5dnBZbEpFUT09?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(82310400026)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2025 14:16:38.2509 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fba33849-4a7f-405a-1c0c-08ddb329bbe6 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CEA.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4139 The 'UNKNOWN' vendor check is handled as a quirk that is run on each online CPU. However, all CPUs are expected to have the same vendor. Move the 'UNKNOWN' vendor check to the BSP-only init so it is done early and once. Remove the unnecessary return value from the quirks check. Reviewed-by: Qiuxu Zhuo Tested-by: Tony Luck Reviewed-by: Tony Luck Signed-off-by: Yazen Ghannam --- Notes: Link: https://lore.kernel.org/r/20250415-wip-mca-updates-v3-9-8ffd9eb4aa56@am= d.com =20 v3->v4: * No change. =20 v2->v3: * Add tags from Qiuxu and Tony. =20 v1->v2: * New in v2. arch/x86/kernel/cpu/mce/core.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c index c852d06713ed..a723c7886eae 100644 --- a/arch/x86/kernel/cpu/mce/core.c +++ b/arch/x86/kernel/cpu/mce/core.c @@ -1979,14 +1979,11 @@ static void apply_quirks_zhaoxin(struct cpuinfo_x86= *c) } =20 /* Add per CPU specific workarounds here */ -static bool __mcheck_cpu_apply_quirks(struct cpuinfo_x86 *c) +static void __mcheck_cpu_apply_quirks(struct cpuinfo_x86 *c) { struct mca_config *cfg =3D &mca_cfg; =20 switch (c->x86_vendor) { - case X86_VENDOR_UNKNOWN: - pr_info("unknown CPU type - not enabling MCE support\n"); - return false; case X86_VENDOR_AMD: apply_quirks_amd(c); break; @@ -2002,8 +1999,6 @@ static bool __mcheck_cpu_apply_quirks(struct cpuinfo_= x86 *c) cfg->monarch_timeout =3D 0; if (cfg->bootlog !=3D 0) cfg->panic_timeout =3D 30; - - return true; } =20 static bool __mcheck_cpu_ancient_init(struct cpuinfo_x86 *c) @@ -2243,6 +2238,12 @@ void mca_bsp_init(struct cpuinfo_x86 *c) if (!mce_available(c)) return; =20 + if (c->x86_vendor =3D=3D X86_VENDOR_UNKNOWN) { + mca_cfg.disabled =3D 1; + pr_info("unknown CPU type - not enabling MCE support\n"); + return; + } + mce_flags.overflow_recov =3D cpu_feature_enabled(X86_FEATURE_OVERFLOW_REC= OV); mce_flags.succor =3D cpu_feature_enabled(X86_FEATURE_SUCCOR); mce_flags.smca =3D cpu_feature_enabled(X86_FEATURE_SMCA); @@ -2277,10 +2278,7 @@ void mcheck_cpu_init(struct cpuinfo_x86 *c) =20 __mcheck_cpu_cap_init(); =20 - if (!__mcheck_cpu_apply_quirks(c)) { - mca_cfg.disabled =3D 1; - return; - } + __mcheck_cpu_apply_quirks(c); =20 if (!mce_gen_pool_init()) { mca_cfg.disabled =3D 1; --=20 2.49.0 From nobody Wed Oct 8 20:44:15 2025 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2085.outbound.protection.outlook.com [40.107.236.85]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 916D42989AC; Tue, 24 Jun 2025 14:16:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.85 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774606; cv=fail; b=WKlmdMCd54E6KpfehBjFvZSIUzCpOqTPW/rNxQDLqmb7oBpEKk0gyuB9oH8F0HQQ56YASZX0AD/GI/HJAZIMDQiWkjDvxAqJGMmAOz/VjDdToHQwIhVCGhyKRrz9uDw3PlyBy+Hu1nh32xbuIv4taQ2FFokk+qv2Gx+PJXJJxGY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774606; c=relaxed/simple; bh=8ALPE6Ne8lOfto6UQvYd7q4YRXjlSCHU68EMK7OrLG4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=jMhzxb555lYiW03tmIErASDGiPVEgx/IQL/nZRetqtSQwvU7bwRGLtfP81UnCCu0kXIA6mj3R4cl9jaSfo7lnI7dWKBPqPf2mhJ8lWiazB0/5sXR/PFJKGDYN66C2kMQHmJgr6JNR7tBIppTcBkN+8SY5tN/KVGfPoGxcc+58jM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=2mBWg7b6; arc=fail smtp.client-ip=40.107.236.85 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="2mBWg7b6" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MO1KHUA3c4ehgiG9wCXXyN0kHPk9NYYLvjpmjzp/H0mmG3FjPkktxEPG8bURfFTUfKw3wXNsMEXMsOaSY8aG0SJmphql7sRCEaBQWUDXBkl4mwuBJpIwmJwFreGsEvpwOuxuLrBu/yDTfssUq9Gix4uS3vo7n1aPheKGH6h8DCNsSz/89LmYhVmrBv/GWj8VZBr20XwGh4SSf+bAvsGCNgxgmL5tBR945nrpL1khNDw9JCOsx9raQNnc2xvjiZP6haHFvn/PK676iGq4OVUhCvK7xpgatHekn01/aOVe8AptEVt5yp5igFMBL3f3KzX4Oa84Ecm2fiUbOONkbqufSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BMbFx41w4ZFMJEabi0w0o3IwTQ6GqieaGiCOEtE6Lro=; b=rRswEgMa2o7GmUlnjjMTEToyFkc2Z0SSBDHFpYo4O9QI341got3rVwvxjVDpjiBqwPtIkaT3IukaKChutRhBE+kl2vxlw/9SDL/B7qPASAnlQTwMwOP1ls7eeB6dG1KrjQkzwMyE9fA2mdU0/Hs26Oj1T/CZsulXfEqDprVtZbF95rXkUqyUQu5d7O1hoQSc5IkHlsnzINGDwq15btonHvet74nf3Oar3po2zu77SB2YhOx5x6FAnyNKMAJc4UoWTPctvG+Osnh5CIi8FNLb0rp0iZ7bA3RjeZbWYBTiaFX1DFUvvgcxw+tely+o+oUqMIYfGSnrQ20OU9MC5Qh4mQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BMbFx41w4ZFMJEabi0w0o3IwTQ6GqieaGiCOEtE6Lro=; b=2mBWg7b67PCWY3OUae6uMvY1bBN011EXMxAxojANqYHjv0i8VN98Oi9sL14uYTE8vgeX0f+93LVhKLoHboLuna1i39wAKcPck0QKiUxFnCKHGCrcJ2L00ElXi5gn8iM7cbvAYH+tefZngF7QNCVlzDfV5VRLK2hWGFsZJvxxYG0= Received: from BYAPR05CA0045.namprd05.prod.outlook.com (2603:10b6:a03:74::22) by PH0PR12MB5678.namprd12.prod.outlook.com (2603:10b6:510:14e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.25; Tue, 24 Jun 2025 14:16:39 +0000 Received: from SJ1PEPF00001CE6.namprd03.prod.outlook.com (2603:10b6:a03:74:cafe::8b) by BYAPR05CA0045.outlook.office365.com (2603:10b6:a03:74::22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.16 via Frontend Transport; Tue, 24 Jun 2025 14:16:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CE6.mail.protection.outlook.com (10.167.242.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8880.14 via Frontend Transport; Tue, 24 Jun 2025 14:16:39 +0000 Received: from [127.0.1.1] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 24 Jun 2025 09:16:33 -0500 From: Yazen Ghannam Date: Tue, 24 Jun 2025 14:16:09 +0000 Subject: [PATCH v4 14/22] x86/mce: Separate global and per-CPU quirks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250624-wip-mca-updates-v4-14-236dd74f645f@amd.com> References: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> In-Reply-To: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> To: , Tony Luck , "Rafael J. Wysocki" , Len Brown CC: , , , Qiuxu Zhuo , , Yazen Ghannam X-Mailer: b4 0.15-dev-9b767 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE6:EE_|PH0PR12MB5678:EE_ X-MS-Office365-Filtering-Correlation-Id: 8e9eed87-c377-4a09-4992-08ddb329bc67 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|376014|36860700013; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WnhjcjBUSGVWT2hzV0lwV1lHeUtVWG5TV3JoTzRDSmc4RXRWL3VxTHpiNUZp?= =?utf-8?B?R0NDZjB3L1A3WnFJRzJkRWFqYk1mL3lMcUp6ejZvT1pJV0RyemdWVENGR3JL?= =?utf-8?B?SzBydDdRVEpKcTBHdzMwa29wTENoc3Y0RkJEcUkvaFoyc094dTlwM3oxQzAx?= =?utf-8?B?VWFhV0txTlZjMVR1am55WEVBaHRMZzRYM1NNaGdBWDdzQURldzc2TENZYmJi?= =?utf-8?B?aUg2aklVTkxaOGZVb3ZoNkpNR2xEd3Rid29ONytXMm1nYnRUWWora1ZiaS9U?= =?utf-8?B?QkxvaUhSeDA2dFpLZENzL3BEY0I3a0dSd3d6UlJOUGkzeWJlZnFDSEFJYzNX?= =?utf-8?B?RFhaaWdtclRYZDRrdVJXWFF1MXdXa0VOSzFMUnFvUW5sS0ZtRXRHcUtvaHla?= =?utf-8?B?OCtidHhHd2JFUmtMWEd0QitPMkpiRzRERFpMZ1dUUkk3VWpzZnM3MUZQSUxh?= =?utf-8?B?RFpwaWU3S1M1ajZkdElPWnBycC85Y3VkdVlqL21VSXNCWFhIQUNkcXdKZ01B?= =?utf-8?B?ZW9GckxBZzdoZFVod0xPZEtpbTJiUm9xWmpldE5OdGZMcng1aWxUOFhQcnY4?= =?utf-8?B?MG9tbWxRYktZSVEwTEY0OGt2KzRxWUsremsrRUtHS1pLMzhmckc3Vk9uVGgw?= =?utf-8?B?TVI1b052cWV5NFdOMjBuTEhVTG53OUZRKzJEQ1dTWU1ZMFltL2JRWmVydDdX?= =?utf-8?B?Q0RMUmR6NUFTeDhNejhFNmNibWRNa0dvbEpQZ3RNSEZDZnlJM1luWnZ3a3Jl?= =?utf-8?B?TXdMR2hkRlhMM0FtUnZybkI2YkRYditDNUJzMG1QWkV4SDA3YXdGTFNwM1l4?= =?utf-8?B?bnBOUzNsVVIxbU5Ra3hNZEZYeU03ZE1FS0RBaTZtLzArK01RcmowTkFkQ3pJ?= =?utf-8?B?VFRWTXlxb1diT3phVG02cFVGaXFVMWlTbk1LTnJza1ZnQ29GYWNkZlArRDV2?= =?utf-8?B?aTJHdkpYZ28vWWlmYk9QanBYL21XRS9qSmJ3TGZxYXJHaFJCdktQSDZ2TlJy?= =?utf-8?B?Z2ZSZEJYZCt1dDR2UVB0eS9OWTRxeFl1K0F0UDRNd3dLbTRsV3Z5RlJmcytY?= =?utf-8?B?QVJRTHFXZnovbW1qRDRXYTBWUlU4VG14cmM3R09XcHVzQ1hPK3dnZHYwU3p2?= =?utf-8?B?a0VlRS9EWlVheEZtelIzR0thSXhLSCs4Mk1ld0hyVzA4VzRvOEVTeXM0ckhM?= =?utf-8?B?U0hQand4bUdLdFhHMU9xU1ZJSGRGU1dtdjBzTTZKRFNMYlRBaDNEVkVDV1ZD?= =?utf-8?B?K0pZZ0FPcWd1WGhOaGY5dW12OXg4czlBYlVTb3AwR3ZVWldTZnZzSktFY3hM?= =?utf-8?B?NmhWVHhIM3RITFJ1RzR5RXdpaFFFT0szRGE3UVJhNm9GVEhZQnB0QThzRC9p?= =?utf-8?B?TURwdnBiUkNqZWpsUTgyTml2WnZ4QTlaeGluK2g2czNYRGhuUzNoWXZzdWJU?= =?utf-8?B?cUwxOVJTMG12SFkwSCsvb0JucklId0g1RFNDL2tzTDJKbXI1d0hoM1Z6SzdO?= =?utf-8?B?MmovL1pCd1huNk5YOU1Zci9pR240WXB3aFV2bWJmZHVVN1BRajBTbUNURmVr?= =?utf-8?B?RmxiVUJwVnNMR0VmejNyZzVuM1lGZm80alBUUzFuQkROQVhBakhaMFQvTVI4?= =?utf-8?B?NWpTWldxMVNCQnN5K0l6cmtDU21KUzIwdGx4Z2dDNXkyZStjNUJYS2RadDVq?= =?utf-8?B?K3d6c1dHaHNlVHRqZ1pjbms0dzhjS2NtYlhiVFYwclRvOE5ZdE1oL243dHRl?= =?utf-8?B?M210aGVWY25LVG5wQ3ptekR3VFgwaVhNNnNXOUhyVW9YNHZsYk91ZTZjb0Nw?= =?utf-8?B?eGpESnIrZVdhbkI0b3RidC9UQWxhNElzenVqcUh1VnZTeXBDbGx6cEthaCtY?= =?utf-8?B?WGNBY3A4Ync4VmZVSEU4bDZ0NStMYWs5Q2pyaitkYWFhVitTVGlkOCtCMHB0?= =?utf-8?B?WUFZM2JzbW05Sko2QjlwVnlzaEVuMXRLTnRPYWUvdEhYSzlFRjBrSTd6QzY1?= =?utf-8?B?VWhockkrNW1xK0RjTGRFYU9xYzVwa1ZwNmxjdnVnQ1UwazZTTStWa2FCcWlx?= =?utf-8?B?TldqK2ZMbUNla3k1emVRQU5qRFd2YlVtakVWdz09?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(376014)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2025 14:16:39.1134 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8e9eed87-c377-4a09-4992-08ddb329bc67 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE6.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5678 Many quirks are global configuration settings and a handful apply to each CPU. Move the per-CPU quirks to vendor init to execute them on each online CPU. Set the global quirks during BSP-only init so they're only executed once and early. Reviewed-by: Qiuxu Zhuo Tested-by: Tony Luck Reviewed-by: Tony Luck Signed-off-by: Yazen Ghannam --- Notes: Link: https://lore.kernel.org/r/20250415-wip-mca-updates-v3-10-8ffd9eb4aa56@a= md.com =20 v3->v4: * Add newline in mce_amd_feature_init(). * Remove __mcheck_cpu_apply_quirks(). * Update code comment ref. __mcheck_cpu_apply_quirks(). =20 v2->v3: * Update code comment. * Add tags from Qiuxu and Tony. =20 v1->v2: * New in v2. arch/x86/kernel/cpu/mce/amd.c | 24 +++++++++++++ arch/x86/kernel/cpu/mce/core.c | 79 +++++++++++--------------------------= ---- arch/x86/kernel/cpu/mce/intel.c | 18 ++++++++++ 3 files changed, 62 insertions(+), 59 deletions(-) diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c index d55c4b5f5354..28dc36cdd137 100644 --- a/arch/x86/kernel/cpu/mce/amd.c +++ b/arch/x86/kernel/cpu/mce/amd.c @@ -648,6 +648,28 @@ static void disable_err_thresholding(struct cpuinfo_x8= 6 *c, unsigned int bank) wrmsrq(MSR_K7_HWCR, hwcr); } =20 +static void amd_apply_quirks(struct cpuinfo_x86 *c) +{ + struct mce_bank *mce_banks =3D this_cpu_ptr(mce_banks_array); + + /* This should be disabled by the BIOS, but isn't always */ + if (c->x86 =3D=3D 15 && this_cpu_read(mce_num_banks) > 4) { + /* + * disable GART TBL walk error reporting, which + * trips off incorrectly with the IOMMU & 3ware + * & Cerberus: + */ + clear_bit(10, (unsigned long *)&mce_banks[4].ctl); + } + + /* + * Various K7s with broken bank 0 around. Always disable + * by default. + */ + if (c->x86 =3D=3D 6 && this_cpu_read(mce_num_banks)) + mce_banks[0].ctl =3D 0; +} + /* cpu init entry point, called from mce.c with preempt off */ void mce_amd_feature_init(struct cpuinfo_x86 *c) { @@ -655,6 +677,8 @@ void mce_amd_feature_init(struct cpuinfo_x86 *c) u32 low =3D 0, high =3D 0, address =3D 0; int offset =3D -1; =20 + amd_apply_quirks(c); + mce_flags.amd_threshold =3D 1; =20 for (bank =3D 0; bank < this_cpu_read(mce_num_banks); ++bank) { diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c index a723c7886eae..4f6af060a395 100644 --- a/arch/x86/kernel/cpu/mce/core.c +++ b/arch/x86/kernel/cpu/mce/core.c @@ -1807,8 +1807,9 @@ static void __mcheck_cpu_mce_banks_init(void) struct mce_bank *b =3D &mce_banks[i]; =20 /* - * Init them all, __mcheck_cpu_apply_quirks() is going to apply - * the required vendor quirks before + * Init them all by default. + * + * The required vendor quirks will be applied before * __mcheck_cpu_init_prepare_banks() does the final bank setup. */ b->ctl =3D -1ULL; @@ -1884,18 +1885,6 @@ static void __mcheck_cpu_init_prepare_banks(void) =20 static void apply_quirks_amd(struct cpuinfo_x86 *c) { - struct mce_bank *mce_banks =3D this_cpu_ptr(mce_banks_array); - - /* This should be disabled by the BIOS, but isn't always */ - if (c->x86 =3D=3D 15 && this_cpu_read(mce_num_banks) > 4) { - /* - * disable GART TBL walk error reporting, which - * trips off incorrectly with the IOMMU & 3ware - * & Cerberus: - */ - clear_bit(10, (unsigned long *)&mce_banks[4].ctl); - } - if (c->x86 < 0x11 && mca_cfg.bootlog < 0) { /* * Lots of broken BIOS around that don't clear them @@ -1904,13 +1893,6 @@ static void apply_quirks_amd(struct cpuinfo_x86 *c) mca_cfg.bootlog =3D 0; } =20 - /* - * Various K7s with broken bank 0 around. Always disable - * by default. - */ - if (c->x86 =3D=3D 6 && this_cpu_read(mce_num_banks)) - mce_banks[0].ctl =3D 0; - /* * overflow_recov is supported for F15h Models 00h-0fh * even though we don't have a CPUID bit for it. @@ -1924,23 +1906,10 @@ static void apply_quirks_amd(struct cpuinfo_x86 *c) =20 static void apply_quirks_intel(struct cpuinfo_x86 *c) { - struct mce_bank *mce_banks =3D this_cpu_ptr(mce_banks_array); - /* Older CPUs (prior to family 6) don't need quirks. */ if (c->x86_vfm < INTEL_PENTIUM_PRO) return; =20 - /* - * SDM documents that on family 6 bank 0 should not be written - * because it aliases to another special BIOS controlled - * register. - * But it's not aliased anymore on model 0x1a+ - * Don't ignore bank 0 completely because there could be a - * valid event later, merely don't write CTL0. - */ - if (c->x86_vfm < INTEL_NEHALEM_EP && this_cpu_read(mce_num_banks)) - mce_banks[0].init =3D false; - /* * All newer Intel systems support MCE broadcasting. Enable * synchronization with a one second timeout. @@ -1978,29 +1947,6 @@ static void apply_quirks_zhaoxin(struct cpuinfo_x86 = *c) } } =20 -/* Add per CPU specific workarounds here */ -static void __mcheck_cpu_apply_quirks(struct cpuinfo_x86 *c) -{ - struct mca_config *cfg =3D &mca_cfg; - - switch (c->x86_vendor) { - case X86_VENDOR_AMD: - apply_quirks_amd(c); - break; - case X86_VENDOR_INTEL: - apply_quirks_intel(c); - break; - case X86_VENDOR_ZHAOXIN: - apply_quirks_zhaoxin(c); - break; - } - - if (cfg->monarch_timeout < 0) - cfg->monarch_timeout =3D 0; - if (cfg->bootlog !=3D 0) - cfg->panic_timeout =3D 30; -} - static bool __mcheck_cpu_ancient_init(struct cpuinfo_x86 *c) { if (c->x86 !=3D 5) @@ -2259,6 +2205,23 @@ void mca_bsp_init(struct cpuinfo_x86 *c) =20 if (cap & MCG_SER_P) mca_cfg.ser =3D 1; + + switch (c->x86_vendor) { + case X86_VENDOR_AMD: + apply_quirks_amd(c); + break; + case X86_VENDOR_INTEL: + apply_quirks_intel(c); + break; + case X86_VENDOR_ZHAOXIN: + apply_quirks_zhaoxin(c); + break; + } + + if (mca_cfg.monarch_timeout < 0) + mca_cfg.monarch_timeout =3D 0; + if (mca_cfg.bootlog !=3D 0) + mca_cfg.panic_timeout =3D 30; } =20 /* @@ -2278,8 +2241,6 @@ void mcheck_cpu_init(struct cpuinfo_x86 *c) =20 __mcheck_cpu_cap_init(); =20 - __mcheck_cpu_apply_quirks(c); - if (!mce_gen_pool_init()) { mca_cfg.disabled =3D 1; pr_emerg("Couldn't allocate MCE records pool!\n"); diff --git a/arch/x86/kernel/cpu/mce/intel.c b/arch/x86/kernel/cpu/mce/inte= l.c index efcf21e9552e..ae9417d634ac 100644 --- a/arch/x86/kernel/cpu/mce/intel.c +++ b/arch/x86/kernel/cpu/mce/intel.c @@ -468,8 +468,26 @@ static void intel_imc_init(struct cpuinfo_x86 *c) } } =20 +static void intel_apply_quirks(struct cpuinfo_x86 *c) +{ + /* + * SDM documents that on family 6 bank 0 should not be written + * because it aliases to another special BIOS controlled + * register. + * But it's not aliased anymore on model 0x1a+ + * Don't ignore bank 0 completely because there could be a + * valid event later, merely don't write CTL0. + * + * Older CPUs (prior to family 6) can't reach this point and already + * return early due to the check of __mcheck_cpu_ancient_init(). + */ + if (c->x86_vfm < INTEL_NEHALEM_EP && this_cpu_read(mce_num_banks)) + this_cpu_ptr(mce_banks_array)[0].init =3D false; +} + void mce_intel_feature_init(struct cpuinfo_x86 *c) { + intel_apply_quirks(c); intel_init_cmci(); intel_init_lmce(); intel_imc_init(c); --=20 2.49.0 From nobody Wed Oct 8 20:44:15 2025 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2043.outbound.protection.outlook.com [40.107.244.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EBCC2DFA3A; Tue, 24 Jun 2025 14:16:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.244.43 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774603; cv=fail; b=inAx5dq9LcmebaxitqMBXP6/lsB8Cq6QMGCF7PyGp7llIDEz7BIDTrE17m/WHM3BO6LFBBxogKso9CK30eZD+fXLN7CQpBZWDFQC7D7iGM3yl+hU4y++Op+ZXMhlirpZaLftLJeQM+07ygG6UpEfVw+9G0qTjifdcMQaWqRqF4M= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774603; c=relaxed/simple; bh=VfPze2bFvBbsr8FO65d6FE72elyK8dVOApORNfGzUwQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=PiWvSbawFk+pVsiuDOtCCEpcLpd9LJp+tjDmmlMlWQ1cVA9XuPv5S9phCmBsbMQb3leiq/gfrlscNRUgYM2mM3o30cwa3pshQ4ZXSPQeh8UfOrw7+bHXXMNz828UFqtLOvPYOBBc+4bYDkIgS63K3xFp2Jg1Z9tl5KH9ZSCrEOk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=ueppRq2O; arc=fail smtp.client-ip=40.107.244.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="ueppRq2O" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=w8yDRlwMY6iykblSY+Yg+BaSJnogEVoOddNt9pmfSub8rDjZokfVZaXc3EIyqD8E3N0LmU8KNMGblhZFFz+DLbQbVCrfNcfTAtQN+sZeWOJkMsecDP1LXvioirw5+/O69lVTI661nheiZA+3AFGB/hmML/IyAcD/3jXx2i9gOae4T7hsig2T+/40EmV4F+pGwmTrY+R6o6qkK1IcwE/l/VpAP6F8NcNFhHgjGzsYXo/Ozsq4/M6MkwoSDrTijO/ierRffmJzP6YHLMHJxCeCbn9uWKwZ84x7b+UB4jV46JwZnCgwNB9qI8C7M0OfsvePajAixgHPhwhMsBFpGA/CmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jZmSYLPbebC70FoWmyxn3ZrM8SL0yz3NJUV6QklgzVk=; b=MNT1EMABpUD5cdtQ0X9Fdgy5qfvCzoLv1/4PbDJqydV+Vmes6xzWITjocM6HgO89gzlMHPDzL135F0gwFWFeF793QPgjvI5QbfAS7P1qwQlOEAZKffjs7MspONZ/klXHiOiGt4u0xRMtVxwEvfcUYxNMj7BVxWXSLSzawXxBOCyXfDkgC+57Yow/dMaojJTHV3kV6GUPcvOdhxZ+2ZdyrOW6njN7NUyWnWRcLN8Aoux4fHhN0aG9HpbYXOJYdtliv6H++9LJDidLfItp5CdfhaKUxs9oXJW5IQZ3WFARB1LkXsniEDwN+VC4RZ3Gom/PCbwvQkgkdNM8/WqY9H6UAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jZmSYLPbebC70FoWmyxn3ZrM8SL0yz3NJUV6QklgzVk=; b=ueppRq2O6DtHzTwfY6CT3wXRcY7B0lZQM/iOGngIF74KrCJITB8TczRkOVOCwP7LugJkaEp3Gue3bsF/pdOXH+t0ocXTn/MOURClG0eXxyBM6UDcYIuEQApzZtP4v0TQMPyefDQs6z89g/ROgk+PY5oF7m36ptIKPC9IIf/5/hc= Received: from BYAPR05CA0048.namprd05.prod.outlook.com (2603:10b6:a03:74::25) by MW6PR12MB8913.namprd12.prod.outlook.com (2603:10b6:303:247::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.28; Tue, 24 Jun 2025 14:16:39 +0000 Received: from SJ1PEPF00001CE6.namprd03.prod.outlook.com (2603:10b6:a03:74:cafe::e4) by BYAPR05CA0048.outlook.office365.com (2603:10b6:a03:74::25) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.16 via Frontend Transport; Tue, 24 Jun 2025 14:16:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CE6.mail.protection.outlook.com (10.167.242.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8880.14 via Frontend Transport; Tue, 24 Jun 2025 14:16:39 +0000 Received: from [127.0.1.1] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 24 Jun 2025 09:16:34 -0500 From: Yazen Ghannam Date: Tue, 24 Jun 2025 14:16:10 +0000 Subject: [PATCH v4 15/22] x86/mce: Move machine_check_poll() status checks to helper functions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250624-wip-mca-updates-v4-15-236dd74f645f@amd.com> References: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> In-Reply-To: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> To: , Tony Luck , "Rafael J. Wysocki" , Len Brown CC: , , , Qiuxu Zhuo , , Yazen Ghannam X-Mailer: b4 0.15-dev-9b767 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE6:EE_|MW6PR12MB8913:EE_ X-MS-Office365-Filtering-Correlation-Id: b85b8bae-df60-4f0f-5951-08ddb329bc6e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MlRtZkVNbGN2SkwxNTFHZm5FRmU0RXk2Zi9FOHNJQVpSTWVadlY5cU9Eeklw?= =?utf-8?B?QnRadUd0UU5YTVhPTUM5TUgzZUlmS25WUjI4QlV2OXZwWEFNTHBESlJjM1Jm?= =?utf-8?B?SExCL3AydEVORm5GRmJ1RUxBTHpQY1paN1RnUm55ajJMNk5Dc3Zzc3pPVDVD?= =?utf-8?B?WElzUmVaWnVnUEJ6cnFHckJsdVhiSzByS252enhQREVxRld0L05ySlAvL2R0?= =?utf-8?B?UitremhDbzhyZWtMVUxVd2JwTGpLMU9zS0dKQkp4dmE2ODFDMjZiSjI1OXRO?= =?utf-8?B?amh2aCtMNWVYaWdkK2tMczZoL0MxMnJGZVU4K3B4YXRjYTlPb1l0RDk5amV1?= =?utf-8?B?V01EeTZpTlNOVUFYaGxsSFlKdDR2YnJwOTlSbit2MmhGU29TdDg4ZHRkeGxF?= =?utf-8?B?U1V4ZFE3Y2Q2eWpUYitZQ1YwWlVLKzRiS3FpaTdYSTlFUmtNZmlZZ0ZMd2lQ?= =?utf-8?B?MTNYME10cFBRb0NDd1VxMjMyNGJBalIrZEQ2dUJiK1pqVVZKNi9YN2JyOG04?= =?utf-8?B?UzJtWEJRVFNHVGxaZ21zd2dYdWtTeUNCWkxGZmxqN2tnZW9VNHVrWkRsVzc5?= =?utf-8?B?aHUxa1NILzN4d1ByZnJPaHRtc3VTQ2h4QzJhOGM2T2ZMZTdzdUNlQjhMbkJn?= =?utf-8?B?VjM1c2MvbmFEWDhOZm0zdVpQUjNkNXBNMzRObXF1TVFOOG92YklLNWR3V3Zo?= =?utf-8?B?RmxvVjJHSFZDODhjVHVxVTBlc1dzOS92TXBVTkVyQ1AvdGNZSFMrWUhsT3NE?= =?utf-8?B?ajZsSElpd21oTmcxTXBFcXFJZkZYQmUzWFFJTjJzK1BiTXRuVzhpL0NVZ0oy?= =?utf-8?B?TFpjZjNpbzhaREFkeEFVZklzd3loU0pMaXVSblRQbHF5YjhGUXd5VUgxelJZ?= =?utf-8?B?VE1Mdm1PQWFjZGZhU3lBYUE0UDR5dWxNdHRZekNjOHNaaHBYS2hXYWh4NjZE?= =?utf-8?B?U2J6eG9nNkJuRXRVL0loTXZjT2VmajhyU3hjYS9lampUa1VScTRodEVSOVRC?= =?utf-8?B?ak90YW9Oejlwa2NYelN6eUgzanZHZ1dEVVgrWWZ5QmpCMlE0d2N6MmFSTEtT?= =?utf-8?B?Yi9Ud0lLMWZzMFBPOExGcnFhUzVUUk5FbU9xejVrYmR0MFkrRFREU0o2YUg2?= =?utf-8?B?Qkg2QXhkSnBkRFZ2a3BraHpIUTRuaGlFbE1GNlNZR0FhZVhXRzJFVW1YZ09D?= =?utf-8?B?OHoxZFFqMWRRM2pCODVDSnlRTnFCWi8rZUtzc2Y5bnlzL2lMOTg3ckhVTm8x?= =?utf-8?B?NUx1LzBCaWt4Szk2MGFzUjlacGUrT2xWVzJUY2F6bVZIeXdPbTExRVdqTktq?= =?utf-8?B?Q3RLOUVEcXptU1lTZHpYQ2RHYVhBd2txTTZTMmxkdy9kVFE3WlRXVTBNc3lZ?= =?utf-8?B?RVc1dWxaMXdJYUYxcGFHUGF0eTZWckd4Q1ZLNjdSMTZZbWNIT3lCOEtjS3VT?= =?utf-8?B?ZlcvZGdkSWpFT3JKSE5aMWRXNFJ3Skp0dE9WbDhkZ0I4SXp1TEt3Vm1TMTUy?= =?utf-8?B?Ukx6dEZzWlcvMkg3R2RWWkhXdE9FeGhWbWFReTg2RXBOV3pucWJRMUE2dFlW?= =?utf-8?B?MURuQjh6dk1veGZHSjRoSDVhdG14NmdreFlTT0FNRmcxemJZNjJOZWx4d1NG?= =?utf-8?B?Q210UWRtbXNUTWFOS2ZQTXBsUlBJKy9iQXhhbkY5b0xKMzFWb1BrUTJZVXN2?= =?utf-8?B?VFBwV3RuNytlWWh6Q0lpVmxITnhqcGVBR1VyZ09YR2ZNbzJXV2xTS1RkaU1q?= =?utf-8?B?NVFScC9ST2FEMkFmNTdCbTFXdW5GUlFyZ1lwTmtlRkFPbzltWmRaU1RaSERJ?= =?utf-8?B?R3JFTWx0YmM4WFIxVkhxUnJoajhjSVByNnlacDNSdkNtZUIvTUo5SHM1Y2da?= =?utf-8?B?ODVXY1ZwZG9iOHNBQTdTRzk0eTIvandzeFBSWXRzK1R1cGNEbzh1UlVzQ29H?= =?utf-8?B?T0hLT291VC9MM1FJRUtZdDdtajlBOUpFWnNlSVJVUm9QWXVYVDdLMWdUamtq?= =?utf-8?B?T1ZLRHg0dTlScmRvelloVXpLL3FENGd3WkZWVStNWWdoQUwwY2JKR3BQS1c1?= =?utf-8?Q?7g+FXF?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(1800799024)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2025 14:16:39.1599 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b85b8bae-df60-4f0f-5951-08ddb329bc6e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE6.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8913 There are a number of generic and vendor-specific status checks in machine_check_poll(). These are used to determine if an error should be skipped. Move these into helper functions. Future vendor-specific checks will be added to the helpers. Reviewed-by: Qiuxu Zhuo Tested-by: Tony Luck Reviewed-by: Tony Luck Signed-off-by: Yazen Ghannam --- Notes: Link: https://lore.kernel.org/r/20250415-wip-mca-updates-v3-11-8ffd9eb4aa56@a= md.com =20 v3->v4: * No change. =20 v2->v3: * Add tags from Qiuxu and Tony. =20 v1->v2: * Change log_poll_error() to should_log_poll_error(). * Keep code comment. arch/x86/kernel/cpu/mce/core.c | 88 +++++++++++++++++++++++---------------= ---- 1 file changed, 48 insertions(+), 40 deletions(-) diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c index 4f6af060a395..bed059c6c808 100644 --- a/arch/x86/kernel/cpu/mce/core.c +++ b/arch/x86/kernel/cpu/mce/core.c @@ -714,6 +714,52 @@ static noinstr void mce_read_aux(struct mce_hw_err *er= r, int i) =20 DEFINE_PER_CPU(unsigned, mce_poll_count); =20 +/* + * Newer Intel systems that support software error + * recovery need to make additional checks. Other + * CPUs should skip over uncorrected errors, but log + * everything else. + */ +static bool ser_should_log_poll_error(struct mce *m) +{ + /* Log "not enabled" (speculative) errors */ + if (!(m->status & MCI_STATUS_EN)) + return true; + + /* + * Log UCNA (SDM: 15.6.3 "UCR Error Classification") + * UC =3D=3D 1 && PCC =3D=3D 0 && S =3D=3D 0 + */ + if (!(m->status & MCI_STATUS_PCC) && !(m->status & MCI_STATUS_S)) + return true; + + return false; +} + +static bool should_log_poll_error(enum mcp_flags flags, struct mce_hw_err = *err) +{ + struct mce *m =3D &err->m; + + /* If this entry is not valid, ignore it. */ + if (!(m->status & MCI_STATUS_VAL)) + return false; + + /* + * If we are logging everything (at CPU online) or this + * is a corrected error, then we must log it. + */ + if ((flags & MCP_UC) || !(m->status & MCI_STATUS_UC)) + return true; + + if (mca_cfg.ser) + return ser_should_log_poll_error(m); + + if (m->status & MCI_STATUS_UC) + return false; + + return true; +} + /* * Poll for corrected events or events that happened before reset. * Those are just logged through /dev/mcelog. @@ -765,48 +811,10 @@ void machine_check_poll(enum mcp_flags flags, mce_ban= ks_t *b) if (!mca_cfg.cmci_disabled) mce_track_storm(m); =20 - /* If this entry is not valid, ignore it */ - if (!(m->status & MCI_STATUS_VAL)) + /* Verify that the error should be logged based on hardware conditions. = */ + if (!should_log_poll_error(flags, &err)) continue; =20 - /* - * If we are logging everything (at CPU online) or this - * is a corrected error, then we must log it. - */ - if ((flags & MCP_UC) || !(m->status & MCI_STATUS_UC)) - goto log_it; - - /* - * Newer Intel systems that support software error - * recovery need to make additional checks. Other - * CPUs should skip over uncorrected errors, but log - * everything else. - */ - if (!mca_cfg.ser) { - if (m->status & MCI_STATUS_UC) - continue; - goto log_it; - } - - /* Log "not enabled" (speculative) errors */ - if (!(m->status & MCI_STATUS_EN)) - goto log_it; - - /* - * Log UCNA (SDM: 15.6.3 "UCR Error Classification") - * UC =3D=3D 1 && PCC =3D=3D 0 && S =3D=3D 0 - */ - if (!(m->status & MCI_STATUS_PCC) && !(m->status & MCI_STATUS_S)) - goto log_it; - - /* - * Skip anything else. Presumption is that our read of this - * bank is racing with a machine check. Leave the log alone - * for do_machine_check() to deal with it. - */ - continue; - -log_it: mce_read_aux(&err, i); m->severity =3D mce_severity(m, NULL, NULL, false); /* --=20 2.49.0 From nobody Wed Oct 8 20:44:15 2025 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2062.outbound.protection.outlook.com [40.107.92.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B080B2DFF19; Tue, 24 Jun 2025 14:16:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.92.62 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774607; cv=fail; b=K0A9/g5nmqx5D4Q6DoKLu5CDvKSM4sJ5pXTveWjWHZm75N7CczKzX9LBUrsj7oFrucVVtNPOGkGC6CGSublF/YTfei3K2+bIHdfyqGJbSkp0iy5M6HsQi6OYSq56azxY1v9QnMJgUOpbpKhouivSMC7eGGk+O1n6y77yzHJimGc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774607; c=relaxed/simple; bh=8eeso9hIb2jmdDMdjbEne7zVRy4omlRlLaUcb8dUlEE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=aaHlOZFrNQV+xWymN4dL9LM2vy5+fq1YsMmFkb/HBFtikKq7NIRJXL4BHBQ4/PORbEvI+ygD4ypVfa/kJnVYuA7SQ0gGnpojyv8aLkzjOvEdi4rnohVr97wpjMFWc7COeQu1VdZwaesdXOkL9ZcIHQ6gRRmx+RlzA6L+d9OzymQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=S1u6+AO2; arc=fail smtp.client-ip=40.107.92.62 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="S1u6+AO2" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=I1Hc6IX5JpCQ2iuJrmBTlvf/2k1pGupAYtmGa2P8L01D8nL5EyTM7q6CLzyZ9TF47VYVhu63NqlzJfar48K69+DxkoxrcAkPW8hM0FchpnkIHY1Y7pWbm8fDKaVdu2t+dOxo2xCTDpzo9+vw74GZt7Mymqv+OTLzJQHBhUkIVqgOiaiUrQuYNNJU5VVXXVUI8kmoZAMlMlrr4Hf3YX2n/nMjrMBhvF9YtyUbqJo35SQqF2nnBiwBBTnLTd1G8B+UzJKIUHPNOPRahpPg9xJ596+veQo8d7j9FWug0lC/eu7Fa2yQ37bTwcIKG+aaBD6YL9YGi8qxKSThfD2RCsOsyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZFiu4W7ftl5yFuB97zTetpeFeUZ4GK8Ps+x1K/va9h4=; b=MlyyOPcZnM4rvaqp62WtVItN4M5kNkh16wyhmHuzNK/MV4Qr6wPOnzEAWSxiAozC1dKHpHFE9n/TtAfXdf8Glnj6urWeT53kqy2DkFD4hhemAlUk21SbvRb8RSTB9gvBl7kkUw4zez0bHsW3qIRrC+aZVlZU+vX67kYW+xW4nQlR4uNIQd/r09gnQnAbS1CjHXfBy26S4Fzl40tg8Lf8UYqFt4TX027Xhw795yESaxgPIaaKoIgMpEmSQbH2WabosMo+qh9XoLi4tuUmfqhVvJZRT3XgLl9Nc0BV4+OfNecvFXx5A5hgMg466oD701DZHMS2EGmLKgiMI6ZjZ3B7uw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZFiu4W7ftl5yFuB97zTetpeFeUZ4GK8Ps+x1K/va9h4=; b=S1u6+AO2OmjN9iZS8BWqiXu/4A5fanJewF5f++MfqyWX0z3gMgqBwAS6tbuYApBStRQE4orujnAqbiCumvhPezPt/pFNoX6MjPDeCSNz7444B/vX59X8uDv3V9vOu07P+P77CdwjnoSIWqFcNWJbF1K+GsSgImYiVdTvm94hVJE= Received: from BYAPR05CA0064.namprd05.prod.outlook.com (2603:10b6:a03:74::41) by IA0PPF44635DB8D.namprd12.prod.outlook.com (2603:10b6:20f:fc04::bcc) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.25; Tue, 24 Jun 2025 14:16:39 +0000 Received: from SJ1PEPF00001CE6.namprd03.prod.outlook.com (2603:10b6:a03:74:cafe::88) by BYAPR05CA0064.outlook.office365.com (2603:10b6:a03:74::41) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.15 via Frontend Transport; Tue, 24 Jun 2025 14:16:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CE6.mail.protection.outlook.com (10.167.242.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8880.14 via Frontend Transport; Tue, 24 Jun 2025 14:16:39 +0000 Received: from [127.0.1.1] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 24 Jun 2025 09:16:35 -0500 From: Yazen Ghannam Date: Tue, 24 Jun 2025 14:16:11 +0000 Subject: [PATCH v4 16/22] x86/mce: Unify AMD THR handler with MCA Polling Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250624-wip-mca-updates-v4-16-236dd74f645f@amd.com> References: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> In-Reply-To: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> To: , Tony Luck , "Rafael J. Wysocki" , Len Brown CC: , , , Qiuxu Zhuo , , Yazen Ghannam X-Mailer: b4 0.15-dev-9b767 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE6:EE_|IA0PPF44635DB8D:EE_ X-MS-Office365-Filtering-Correlation-Id: b1bb30c3-58e3-4d1c-04c0-08ddb329bc73 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WDI1QjBaUzc5K1RaSjVHZVlQN3hzb0d0MWtLaHVvRHJCQllCNTdTTVBQYnZ3?= =?utf-8?B?ZC9lSGJoN2FQRXlmZWdRV1ZHUTlleXJjbHZmanQxVUFraTdsUnNXdXhndWdD?= =?utf-8?B?cUdUUmhBZ1FnNnNvamdlV0tsZHI5V3p0d281YXdmVllRVkZHdWpiNkgrM2dn?= =?utf-8?B?eWU1MTZ3OTlSK1RTRzJEVXp0SWcrNktSYllESXJYYjk0RWtrcWpxcDZBeXlS?= =?utf-8?B?V2pReEdlOXNnV2I2cmV1NXpGMndqZndaQlNrcklCblBFZk55eCtibTFraDJx?= =?utf-8?B?TnZsMXFVaEtzM2FtL0VSK0tjSXQ2bDJaR0lLL1BCRzZoV2FTVnBSakJMYWt1?= =?utf-8?B?WjIzcDV0N1ZMNmw3VVdFSklpRUg1NmhFdTIrMnN0d3RjSnFjbU1oTWFWaWxU?= =?utf-8?B?VVYzdXFqL29ZbzkvMWRteEROajh2MWhTUFp4TGc1cUxuM1RkSUhIaDlaSEpq?= =?utf-8?B?djlnb3hYU1ptdkVtb0FIUmpyU2grUE5zUDJFUENvODFaWXZpTSsrYU5jajcy?= =?utf-8?B?OENjeWpkTjNaSy9vSVQwZTU4ZksxdmFHUERIdnhHWnJrYlFRR0phZll3TkdJ?= =?utf-8?B?RUNZVlRmejRnakFSQ25VSmNoZktvTm44OE52YmtWL3VrYkEyMVl3NTZmcTNC?= =?utf-8?B?TnJxQjI3MTNscHR1cGd6UGk0c1Z5d1NoU2ZURnRkK3ZKdUcySWgxckluajVz?= =?utf-8?B?ai9iY1pyRXg2dHZxd1N3Qmdqa1pVME5aTlpXRGd0elQyZ0wwdE1VMWVucytF?= =?utf-8?B?MndlRE8zK21oWVF5SWxkZzJOOTR2ODFPT0xGSzlSSnR5dkcvTE1zcjM3UUFm?= =?utf-8?B?WDVEVjVEc2pRY1V4NXdBVVk4U0FyTDQ0QWJWMWo3dzV4WXFXVHlhMzBmZ0lU?= =?utf-8?B?YXRaaEtYVEl2dExhdkhmb2hpcXo0dEl6UDZ5ajBuQ2kxRDZ0UlptWGpXMXhY?= =?utf-8?B?REFPQzFuQnRSRVJ5bmdXMzhzUXlhRnZ4ajJIUFdiMm1UTXg3dHloNE9uYzdC?= =?utf-8?B?b2FteGYwd013U1k5V1lEN0d2ZElQWFZTMHlrYzM2ajFSZXYxNTJzQytIQjdy?= =?utf-8?B?c0xhYnZObXFqUkVod00zOTQwUkh3M0tBSUxnWUxsNjdYd0lWL0VRM0laakZJ?= =?utf-8?B?dUV4ajFnL1FFcndQY0U5Mk9lK3FnNWxDclN6L1BOOHFkdzRrME8rQ1B3dVhR?= =?utf-8?B?aE82Sk9tUXd1Zm01UVhFL1AzUG9LVHlPN0JwN3lIVS9UMWdEQ3U0TzdWaGlO?= =?utf-8?B?ajRMVFR1bk5lemRZNXE1RkpHM291UHlKUmhRNW5hWmxmQUsyYzF0MjljVHNT?= =?utf-8?B?Wi9OQUlPVlBHME9jV3UrRW5GSTlJZzd5Qy8xTDRxTDZZNlhBZlpQSlBGR0M0?= =?utf-8?B?eVNkRStDYTNWYVZOTHl2cHF1M204MnFkVkJsSW15a0s1ZFE0bXpIWXhOZ0d3?= =?utf-8?B?bnhmQkh3amZsQWQ2Q01HVHBqbG1uaVcwVWJNTGM1UWdCR2NaKzZoVVg3SFZE?= =?utf-8?B?SXZwL09sT2RQVGZJeENHcVlvTnJ2T2x5b3NxRGthTkp0R3l0SlZERXB6cnhE?= =?utf-8?B?R05lOTk3UkU4VlBUT3dDaVByOGhoWXppd3NCenFUdTBQWDZZY3BFQ2JSTjdR?= =?utf-8?B?Tlc5MEJzK20zTFNMQzV5SDFDdnJYN0g4Uk55WWxXNGN4MnJoWHNnVitjZm4z?= =?utf-8?B?TUNDTTBnMUt3ZlJ2ZlFvQWkvQlB4akIrc1d4UlBUNDNTQ0RUazVVKytPRlpm?= =?utf-8?B?c0Y3M3d2Y3phamdrQi9WUWtLZUFoTCtwNFNNblBIUU1OSVVlZ1ZxZ2x1MVZO?= =?utf-8?B?S3VXNHVBdjVJdFFzV1BDcnNESTgxVHpiQWhsK3FJbEdJd09EVXdtTkNITmhV?= =?utf-8?B?R1B3YlpJd21iU1NsNlpuV0RWdDVkcDFaSVFMNGZFazRPdHJacHN3OGpKNGp1?= =?utf-8?B?NE5HMysvaEZxbndCaURLd1FVbGk5ZmZ1ZnllUXhjblFrUFRQbGpQR013VTVU?= =?utf-8?B?QWtmTTU2Mzh6Y3Q2N3hCeEdKRzRuUWFWR2JvaU5JeGRFUlQrdnVmbjlpbzh4?= =?utf-8?B?anRVSE4reTBrU242Wm9rMUhFcUJUaE1OVGVDdz09?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(1800799024)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2025 14:16:39.1755 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b1bb30c3-58e3-4d1c-04c0-08ddb329bc73 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE6.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PPF44635DB8D AMD systems optionally support an MCA thresholding interrupt. The interrupt should be used as another signal to trigger MCA polling. This is similar to how the Intel Corrected Machine Check interrupt (CMCI) is handled. AMD MCA thresholding is managed using the MCA_MISC registers within an MCA bank. The OS will need to modify the hardware error count field in order to reset the threshold limit and rearm the interrupt. Management of the MCA_MISC register should be done as a follow up to the basic MCA polling flow. It should not be the main focus of the interrupt handler. Furthermore, future systems will have the ability to send an MCA thresholding interrupt to the OS even when the OS does not manage the feature, i.e. MCA_MISC registers are Read-as-Zero/Locked. Call the common MCA polling function when handling the MCA thresholding interrupt. This will allow the OS to find any valid errors whether or not the MCA thresholding feature is OS-managed. Also, this allows the common MCA polling options and kernel parameters to apply to AMD systems. Add a callback to the MCA polling function to check and reset any threshold blocks that have reached their threshold limit. Signed-off-by: Yazen Ghannam --- Notes: Link: https://lore.kernel.org/r/20250415-wip-mca-updates-v3-12-8ffd9eb4aa56@a= md.com =20 v3->v4: * No change. =20 v2->v3: * Add tags from Qiuxu and Tony. =20 v1->v2: * Start collecting per-CPU items in a struct. * Keep and use mce_flags.amd_threshold. arch/x86/kernel/cpu/mce/amd.c | 49 ++++++++++++++++------------------= ---- arch/x86/kernel/cpu/mce/core.c | 3 +++ arch/x86/kernel/cpu/mce/internal.h | 2 ++ 3 files changed, 26 insertions(+), 28 deletions(-) diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c index 28dc36cdd137..0c789fa1ae4c 100644 --- a/arch/x86/kernel/cpu/mce/amd.c +++ b/arch/x86/kernel/cpu/mce/amd.c @@ -54,6 +54,12 @@ =20 static bool thresholding_irq_en; =20 +struct mce_amd_cpu_data { + mce_banks_t thr_intr_banks; +}; + +static DEFINE_PER_CPU_READ_MOSTLY(struct mce_amd_cpu_data, mce_amd_data); + static const char * const th_names[] =3D { "load_store", "insn_fetch", @@ -558,6 +564,7 @@ prepare_threshold_block(unsigned int bank, unsigned int= block, u32 addr, if (!b.interrupt_capable) goto done; =20 + __set_bit(bank, this_cpu_ptr(&mce_amd_data)->thr_intr_banks); b.interrupt_enable =3D 1; =20 if (!mce_flags.smca) { @@ -898,12 +905,7 @@ static void amd_deferred_error_interrupt(void) log_error_deferred(bank); } =20 -static void log_error_thresholding(unsigned int bank, u64 misc) -{ - _log_error_deferred(bank, misc); -} - -static void log_and_reset_block(struct threshold_block *block) +static void reset_block(struct threshold_block *block) { struct thresh_restart tr; u32 low =3D 0, high =3D 0; @@ -917,23 +919,14 @@ static void log_and_reset_block(struct threshold_bloc= k *block) if (!(high & MASK_OVERFLOW_HI)) return; =20 - /* Log the MCE which caused the threshold event. */ - log_error_thresholding(block->bank, ((u64)high << 32) | low); - - /* Reset threshold block after logging error. */ memset(&tr, 0, sizeof(tr)); tr.b =3D block; threshold_restart_block(&tr); } =20 -/* - * Threshold interrupt handler will service THRESHOLD_APIC_VECTOR. The int= errupt - * goes off when error_count reaches threshold_limit. - */ -static void amd_threshold_interrupt(void) +void amd_reset_thr_limit(unsigned int bank) { - struct threshold_bank **bp =3D this_cpu_read(threshold_banks), *thr_bank; - unsigned int bank, cpu =3D smp_processor_id(); + struct threshold_bank **bp =3D this_cpu_read(threshold_banks); struct threshold_block *block, *tmp; =20 /* @@ -941,20 +934,20 @@ static void amd_threshold_interrupt(void) * handler is installed at boot time, but on a hotplug event the * interrupt might fire before the data has been initialized. */ - if (!bp) + if (!bp || !bp[bank]) return; =20 - for (bank =3D 0; bank < this_cpu_read(mce_num_banks); ++bank) { - if (!(per_cpu(bank_map, cpu) & BIT_ULL(bank))) - continue; - - thr_bank =3D bp[bank]; - if (!thr_bank) - continue; + list_for_each_entry_safe(block, tmp, &bp[bank]->miscj, miscj) + reset_block(block); +} =20 - list_for_each_entry_safe(block, tmp, &thr_bank->miscj, miscj) - log_and_reset_block(block); - } +/* + * Threshold interrupt handler will service THRESHOLD_APIC_VECTOR. The int= errupt + * goes off when error_count reaches threshold_limit. + */ +static void amd_threshold_interrupt(void) +{ + machine_check_poll(MCP_TIMESTAMP, &this_cpu_ptr(&mce_amd_data)->thr_intr_= banks); } =20 /* diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c index bed059c6c808..a0aaf0abd798 100644 --- a/arch/x86/kernel/cpu/mce/core.c +++ b/arch/x86/kernel/cpu/mce/core.c @@ -831,6 +831,9 @@ void machine_check_poll(enum mcp_flags flags, mce_banks= _t *b) mce_log(&err); =20 clear_it: + if (mce_flags.amd_threshold) + amd_reset_thr_limit(i); + /* * Clear state for this bank. */ diff --git a/arch/x86/kernel/cpu/mce/internal.h b/arch/x86/kernel/cpu/mce/i= nternal.h index 6cb2995f0ec1..e25ad0c005d5 100644 --- a/arch/x86/kernel/cpu/mce/internal.h +++ b/arch/x86/kernel/cpu/mce/internal.h @@ -269,6 +269,7 @@ void mce_threshold_create_device(unsigned int cpu); void mce_threshold_remove_device(unsigned int cpu); extern bool amd_filter_mce(struct mce *m); bool amd_mce_usable_address(struct mce *m); +void amd_reset_thr_limit(unsigned int bank); =20 /* * If MCA_CONFIG[McaLsbInStatusSupported] is set, extract ErrAddr in bits @@ -300,6 +301,7 @@ static inline void mce_threshold_create_device(unsigned= int cpu) { } static inline void mce_threshold_remove_device(unsigned int cpu) { } static inline bool amd_filter_mce(struct mce *m) { return false; } static inline bool amd_mce_usable_address(struct mce *m) { return false; } +static inline void amd_reset_thr_limit(unsigned int bank) { } static inline void smca_extract_err_addr(struct mce *m) { } static inline void smca_bsp_init(void) { } #endif --=20 2.49.0 From nobody Wed Oct 8 20:44:15 2025 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2085.outbound.protection.outlook.com [40.107.95.85]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C57202E0B72; Tue, 24 Jun 2025 14:16:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.95.85 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774606; cv=fail; b=VfaP70Ygagvvxz0z21dlaVRqpgBhxQgcTGtLZbweYINj80Bv8eSggvfQTkqi6kNgVneDDn9qiIP6bXM6jPZJNe1E2tWIdkEvjGU8dIjuRDYhYgQoxha3lsi1natXB3bWVBjnZ01bhTNmWEp/lxBAh05UU8yFQFWOfE6BD8fSAqQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774606; c=relaxed/simple; bh=yKLBPeSrnTP0I6c//Q571rSafa6MIhhkBOa6hnTx+OI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=rZtwBV75wcCySEpTx9je6RdBhKEiDoWd/TTWUv/se+TRKSsbrD69mdgkyuw7fWg8oCEYv4eK8fSyRMFCrON2MWf/oN64UVHKm0yAbq+w5yJA2vyQWW+HOIidLLPo9/mddklvf+O6XBCQNgN6tqQzDKzKvHI9gDWjiRzubpmxP6o= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=et1Smrlk; arc=fail smtp.client-ip=40.107.95.85 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="et1Smrlk" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=B9uIX/QdZIqvanmQ9LMIMk9R75lM2bP5PsfoVXCN/i0DqvY6Fw8xmx5DQVziBRQRD3RH3q+p0wFvPk5/gLVh9/X+gpZ+WdgXM6gWZadWgBSxjkwtoYQ84DzoP5aGb/4ar3gDrotIrXyVHhxyUKlNfrRfI+ADfu2Hk7KWB7NhjG8nFbPQxyTIWQG7g/52CfCynzzBxwjDEJr3ZaHo4eDEXf/9aV7HgT/nKGTTT7xJBOFG/4f7ppqhSjf/dICYvgL4YxtuxV4j/KzwL0YLG0kGCIrTKr0/xC9w6ZwESHT1XJbHuQaP7DSlqu2LzWhNhHtWUVSEmXvkdDTs2Yn6fXYtow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ybO7Lsblyw2k+njvFMV3qSECHZYxwPKRlogOcMUaWug=; b=NuyMtJi1xtGMjK6QJ8KsYHjqT4BQgZFn2naV7GF7gAPJez3ec/8XSoUEEk0fLSxvxXTbiIzL+211HNSStQoFLtd7fs1+EhnHlWXdoi0Q/EAwwkNzvhCiFT8XCxsi/ksqZUsqq8HRD9hoo9OZHYaLnSUXir+tRG9xMjcrVf7rc2RQQA4iGnviCG3VHuT9SgaWzaXxLxS5DVi9LIq24h9Sm5yoT20qb/DAUFjKfUnd8R85rt02lyvN1JyuVgfzALlKg60TDCM7V8Szz3KHAxF7eB8PgjYE2bIZFFpI2QVmIDkPvE1BM+pvLjdqouBG3zOs9pcj9sGWtIg+X8xlvGt41w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ybO7Lsblyw2k+njvFMV3qSECHZYxwPKRlogOcMUaWug=; b=et1Smrlkpa95n8YDi5vH89DVjasf6kqfZKeHKT+eiwbVidL7hat0D9OnxRgW9us4jUX2f2ySlpdNt0ujUjQMbLTR+dIskTC7qBYw6hW+2r/8tVUF58crb4ZIGRIyunwA3f5N5NR0ESmJUniLrgn523p3HiEvPf6Nrd8sva75v0A= Received: from MW4PR03CA0229.namprd03.prod.outlook.com (2603:10b6:303:b9::24) by CY8PR12MB7100.namprd12.prod.outlook.com (2603:10b6:930:60::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.18; Tue, 24 Jun 2025 14:16:40 +0000 Received: from SJ1PEPF00001CEA.namprd03.prod.outlook.com (2603:10b6:303:b9:cafe::dc) by MW4PR03CA0229.outlook.office365.com (2603:10b6:303:b9::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8857.29 via Frontend Transport; Tue, 24 Jun 2025 14:16:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CEA.mail.protection.outlook.com (10.167.242.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8880.14 via Frontend Transport; Tue, 24 Jun 2025 14:16:39 +0000 Received: from [127.0.1.1] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 24 Jun 2025 09:16:36 -0500 From: Yazen Ghannam Date: Tue, 24 Jun 2025 14:16:12 +0000 Subject: [PATCH v4 17/22] x86/mce: Unify AMD DFR handler with MCA Polling Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250624-wip-mca-updates-v4-17-236dd74f645f@amd.com> References: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> In-Reply-To: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> To: , Tony Luck , "Rafael J. Wysocki" , Len Brown CC: , , , Qiuxu Zhuo , , Yazen Ghannam X-Mailer: b4 0.15-dev-9b767 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CEA:EE_|CY8PR12MB7100:EE_ X-MS-Office365-Filtering-Correlation-Id: 5963fec1-79dd-4428-bb67-08ddb329bc7e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bmNzVllaM0VIUzFZckVGVkVLUWtQVXFWRjVtSHczOVZ1ekptbmU3VGsvMXd3?= =?utf-8?B?dGV3QVZWclRmeGVWQnhIS0tXdnRETGR4ZFJOcGI5K2ZjTWgzNUFkNkJBUGVz?= =?utf-8?B?dFo1eUxQK01CcTdaVVJNUDlDUU0wRE1IWEUrRWl1TVZYNXJDWWVZQXNOQ0F1?= =?utf-8?B?MkEwVU4xSUtVMEFrN2dxdmJPVXZvNmdKZ2hmY3p6U0NyczMzYVZRbjFFUXEy?= =?utf-8?B?WDlSZzlKNWIzRGVMYW1WaFMwMlFlVHFTSEdvdm1yOUJUcGZaSU5oa2ppSHFj?= =?utf-8?B?Wi84YzBsa1R1ZURwcm5kTHladHNpSVhmRi83TGRiNXF6L0c0M2RsSmFxTkJK?= =?utf-8?B?NlVBQThFVlVXMWtpMWlUWXdLNGtIK3dlRys0cERJYWFTL3gvQ3FQOUV1a2Q4?= =?utf-8?B?VUd4ZWZWc2czc3FaWnB5UGM3SFdHRzR3b2IrNjdQdlRJdnR5M0k3N0t0dTZv?= =?utf-8?B?V05nZ3JsSWhsajdMWGxaL1EzUVY0cHZQWmprc3o5SW13bjJaWGRvUTdndy9u?= =?utf-8?B?UmxKWDFMOEhRT3FQbUhxZTZkV3ZQUUZCa1NlVi9hYmFVU0V1bFkwZ3NyZlVs?= =?utf-8?B?Y0RpYkJmcWw0emtGbXZDeHBpR2pkSkF6UTh6eW45M1c0cWd4cjhtYllodDVs?= =?utf-8?B?ZkJnUHhiMHVKWmcxbnhkK1RLNGd0WHpGTWMvcTZQZ1JuY2s3YWVyMXZROCtK?= =?utf-8?B?Z2lkbFJaSCtvdnZqbUcwM1RqcjI2bE1iNkRCbTVIbThGdHRWeGJoeXFmeXQ3?= =?utf-8?B?em15VEdDOFB4M2FVUlZZajFUaFNLbUVNU1l2RWVvdDVLUTdTOWMweTdXR2RU?= =?utf-8?B?VUYrcmYvRHRHWnF1emI3UlEzRWRveHRlRHR1MWpxbWtqdXEzSVhwd0p4UGlu?= =?utf-8?B?WmdmVmFUR3RHZVdEOWowT3BlVjcxbGwwajhkVS94eHgyTEhwT1p6cHNmbGRw?= =?utf-8?B?STQ5RlU0eEJ2REhPTFZmendFdkl0d1A2MVhpUWJHdzdoREN5UnhiQi8rUFRS?= =?utf-8?B?ZWtWei9yQmxlUVh1aEFHVXlOdklxR1ZlLzhaNmpuMjNYMTZuU1RsNm9mSFRh?= =?utf-8?B?c08rMHBUUVFVREpHZzNZZzhEdTdtbUxwOHZVQnV4TXlYYjBDM0dCY3NqaXkx?= =?utf-8?B?bG0vd1c2Z0Z1L3ZqVElMb01LcTM0QUZrcG9LUDlwK2xQbElBTGVpNXRKY0ww?= =?utf-8?B?bDFmYjNpTXVPM1NYakFxMnBLTmVjaEYvZC9va2xpaHpTSUI5Zno3eXpsSC95?= =?utf-8?B?WnpZaDJkZ0hlKzhQMmRtK08zcUwxVFp6ZnhtN3kzeThEVmpkSHJpemJCeFNq?= =?utf-8?B?UUZiUDhqSndNRUpyNjA1U3dDMVRBaVdhMkZiTGU3WnY3SzBsMWJOWUZLdXRu?= =?utf-8?B?Zjg0b3BTVzQ1SmdBMlh5MGttTnVGUjViTjB1ZU9rRjVUN1kxV1ErZ2RVVDdO?= =?utf-8?B?cTY2aWVwT2swVko0UXhwK3QraUtmbllwYk03aEJBQmhxb1F4ZGxPWG8wcW1a?= =?utf-8?B?VXV4OVkzQXlXV1laTGNaTGVMNjV2R2ZRVGZ5WngrWEd0UkpiUmpZbjl5Y2Z3?= =?utf-8?B?VUt4YkJzbTBkTFZ5NTlpNlA5aHNrNm1abjVKNEVpMDZWNDZ1aXFQMlZ1RFZ3?= =?utf-8?B?THpYb1g2SlpNUy9UdnFmbkVBQlV4UkdVOXBIK0xtekgrWXNJbllKYnZDSm55?= =?utf-8?B?eXdPRGY1UHFoSmdhUFFmTGhzUVFQenNaMnMvQk4zNXZKWFcxclJ3bkJ3ZDYv?= =?utf-8?B?MXRHRmFUNDVlRzNwYXB5VVJUOXFOeTF5RGtpY044aW9JUDllNWdETUJVeHY5?= =?utf-8?B?alkzTWlpWVRrTU0wYm50b2RQazlOY2M5c01PZW80UkRnNW9JRDNMektLZFhF?= =?utf-8?B?d3F1WkdnQkxPcGlKVGJCZDc5SjdKeVBLNHIvY3Foc3ljYlJFL3dWMGhEcHFT?= =?utf-8?B?aFdYOUhVNlQ0TDFhSnFLSWc0U3BlNUFZRzRFMko2Um9wMHkwZFV5b1VtOVls?= =?utf-8?B?T05hWFlWMUJnMDhFUUFJOTVmRm9tSzlnTVMxcExvU0ZGQWptT3hGdmNReTJ1?= =?utf-8?B?VU1XNkZ6UDBPQkxUdXgyY1B4ME1HSkgzWkI2QT09?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(1800799024)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2025 14:16:39.2590 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5963fec1-79dd-4428-bb67-08ddb329bc7e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CEA.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7100 AMD systems optionally support a deferred error interrupt. The interrupt should be used as another signal to trigger MCA polling. This is similar to how other MCA interrupts are handled. Deferred errors do not require any special handling related to the interrupt, e.g. resetting or rearming the interrupt, etc. However, Scalable MCA systems include a pair of registers, MCA_DESTAT and MCA_DEADDR, that should be checked for valid errors. This check should be done whenever MCA registers are polled. Currently, the deferred error interrupt does this check, but the MCA polling function does not. Call the MCA polling function when handling the deferred error interrupt. This keeps all "polling" cases in a common function. Call the polling function only for banks that have the deferred error interrupt enabled. Add an SMCA status check helper. This will do the same status check and register clearing that the interrupt handler has done. And it extends the common polling flow to find AMD deferred errors. Remove old code whose functionality is already covered in the common MCA code. Reviewed-by: Qiuxu Zhuo Tested-by: Tony Luck Reviewed-by: Tony Luck Signed-off-by: Yazen Ghannam --- Notes: Link: https://lore.kernel.org/r/20250415-wip-mca-updates-v3-13-8ffd9eb4aa56@a= md.com =20 v3->v4: * Add kflag for checking DFR registers. =20 v2->v3: * Add tags from Qiuxu and Tony. =20 v1->v2: * Keep code comment. * Log directly from helper function rather than pass values. =20 Link: https://lore.kernel.org/r/20250213-wip-mca-updates-v2-13-3636547fe05f@a= md.com =20 v2->v3: * Add tags from Qiuxu and Tony. =20 v1->v2: * Keep code comment. * Log directly from helper function rather than pass values. arch/x86/include/asm/mce.h | 6 +++ arch/x86/kernel/cpu/mce/amd.c | 103 ++-----------------------------------= ---- arch/x86/kernel/cpu/mce/core.c | 50 +++++++++++++++++++- 3 files changed, 59 insertions(+), 100 deletions(-) diff --git a/arch/x86/include/asm/mce.h b/arch/x86/include/asm/mce.h index 31e3cb550fb3..7d6588195d56 100644 --- a/arch/x86/include/asm/mce.h +++ b/arch/x86/include/asm/mce.h @@ -165,6 +165,12 @@ */ #define MCE_IN_KERNEL_COPYIN BIT_ULL(7) =20 +/* + * Indicates that handler should check and clear Deferred error registers + * rather than common ones. + */ +#define MCE_CHECK_DFR_REGS BIT_ULL(8) + /* * This structure contains all data related to the MCE log. Also * carries a signature to make it easier to find from external diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c index 0c789fa1ae4c..9d4d0169713b 100644 --- a/arch/x86/kernel/cpu/mce/amd.c +++ b/arch/x86/kernel/cpu/mce/amd.c @@ -56,6 +56,7 @@ static bool thresholding_irq_en; =20 struct mce_amd_cpu_data { mce_banks_t thr_intr_banks; + mce_banks_t dfr_intr_banks; }; =20 static DEFINE_PER_CPU_READ_MOSTLY(struct mce_amd_cpu_data, mce_amd_data); @@ -300,8 +301,10 @@ static void smca_configure(unsigned int bank, unsigned= int cpu) * APIC based interrupt. First, check that no interrupt has been * set. */ - if ((low & BIT(5)) && !((high >> 5) & 0x3)) + if ((low & BIT(5)) && !((high >> 5) & 0x3)) { + __set_bit(bank, this_cpu_ptr(&mce_amd_data)->dfr_intr_banks); high |=3D BIT(5); + } =20 this_cpu_ptr(mce_banks_array)[bank].lsb_in_status =3D !!(low & BIT(8)); =20 @@ -794,37 +797,6 @@ bool amd_mce_usable_address(struct mce *m) return false; } =20 -static void __log_error(unsigned int bank, u64 status, u64 addr, u64 misc) -{ - struct mce_hw_err err; - struct mce *m =3D &err.m; - - mce_prep_record(&err); - - m->status =3D status; - m->misc =3D misc; - m->bank =3D bank; - m->tsc =3D rdtsc(); - - if (m->status & MCI_STATUS_ADDRV) { - m->addr =3D addr; - - smca_extract_err_addr(m); - } - - if (mce_flags.smca) { - rdmsrq(MSR_AMD64_SMCA_MCx_IPID(bank), m->ipid); - - if (m->status & MCI_STATUS_SYNDV) { - rdmsrq(MSR_AMD64_SMCA_MCx_SYND(bank), m->synd); - rdmsrq(MSR_AMD64_SMCA_MCx_SYND1(bank), err.vendor.amd.synd1); - rdmsrq(MSR_AMD64_SMCA_MCx_SYND2(bank), err.vendor.amd.synd2); - } - } - - mce_log(&err); -} - DEFINE_IDTENTRY_SYSVEC(sysvec_deferred_error) { trace_deferred_error_apic_entry(DEFERRED_ERROR_VECTOR); @@ -834,75 +806,10 @@ DEFINE_IDTENTRY_SYSVEC(sysvec_deferred_error) apic_eoi(); } =20 -/* - * Returns true if the logged error is deferred. False, otherwise. - */ -static inline bool -_log_error_bank(unsigned int bank, u32 msr_stat, u32 msr_addr, u64 misc) -{ - u64 status, addr =3D 0; - - rdmsrq(msr_stat, status); - if (!(status & MCI_STATUS_VAL)) - return false; - - if (status & MCI_STATUS_ADDRV) - rdmsrq(msr_addr, addr); - - __log_error(bank, status, addr, misc); - - wrmsrq(msr_stat, 0); - - return status & MCI_STATUS_DEFERRED; -} - -static bool _log_error_deferred(unsigned int bank, u32 misc) -{ - if (!_log_error_bank(bank, mca_msr_reg(bank, MCA_STATUS), - mca_msr_reg(bank, MCA_ADDR), misc)) - return false; - - /* - * Non-SMCA systems don't have MCA_DESTAT/MCA_DEADDR registers. - * Return true here to avoid accessing these registers. - */ - if (!mce_flags.smca) - return true; - - /* Clear MCA_DESTAT if the deferred error was logged from MCA_STATUS. */ - wrmsrq(MSR_AMD64_SMCA_MCx_DESTAT(bank), 0); - return true; -} - -/* - * We have three scenarios for checking for Deferred errors: - * - * 1) Non-SMCA systems check MCA_STATUS and log error if found. - * 2) SMCA systems check MCA_STATUS. If error is found then log it and also - * clear MCA_DESTAT. - * 3) SMCA systems check MCA_DESTAT, if error was not found in MCA_STATUS,= and - * log it. - */ -static void log_error_deferred(unsigned int bank) -{ - if (_log_error_deferred(bank, 0)) - return; - - /* - * Only deferred errors are logged in MCA_DE{STAT,ADDR} so just check - * for a valid error. - */ - _log_error_bank(bank, MSR_AMD64_SMCA_MCx_DESTAT(bank), - MSR_AMD64_SMCA_MCx_DEADDR(bank), 0); -} - /* APIC interrupt handler for deferred errors */ static void amd_deferred_error_interrupt(void) { - unsigned int bank; - - for (bank =3D 0; bank < this_cpu_read(mce_num_banks); ++bank) - log_error_deferred(bank); + machine_check_poll(MCP_TIMESTAMP, &this_cpu_ptr(&mce_amd_data)->dfr_intr_= banks); } =20 static void reset_block(struct threshold_block *block) diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c index a0aaf0abd798..dc5ddddceb22 100644 --- a/arch/x86/kernel/cpu/mce/core.c +++ b/arch/x86/kernel/cpu/mce/core.c @@ -687,7 +687,10 @@ static noinstr void mce_read_aux(struct mce_hw_err *er= r, int i) m->misc =3D mce_rdmsrq(mca_msr_reg(i, MCA_MISC)); =20 if (m->status & MCI_STATUS_ADDRV) { - m->addr =3D mce_rdmsrq(mca_msr_reg(i, MCA_ADDR)); + if (m->kflags & MCE_CHECK_DFR_REGS) + m->addr =3D mce_rdmsrq(MSR_AMD64_SMCA_MCx_DEADDR(i)); + else + m->addr =3D mce_rdmsrq(mca_msr_reg(i, MCA_ADDR)); =20 /* * Mask the reported address by the reported granularity. @@ -714,6 +717,43 @@ static noinstr void mce_read_aux(struct mce_hw_err *er= r, int i) =20 DEFINE_PER_CPU(unsigned, mce_poll_count); =20 +/* + * We have three scenarios for checking for Deferred errors: + * + * 1) Non-SMCA systems check MCA_STATUS and log error if found. + * 2) SMCA systems check MCA_STATUS. If error is found then log it and also + * clear MCA_DESTAT. + * 3) SMCA systems check MCA_DESTAT, if error was not found in MCA_STATUS,= and + * log it. + */ +static bool smca_should_log_poll_error(enum mcp_flags flags, struct mce_hw= _err *err) +{ + struct mce *m =3D &err->m; + + /* + * If this is a deferred error found in MCA_STATUS, then clear + * the redundant data from the MCA_DESTAT register. + */ + if (m->status & MCI_STATUS_VAL) { + if (m->status & MCI_STATUS_DEFERRED) + mce_wrmsrq(MSR_AMD64_SMCA_MCx_DESTAT(m->bank), 0); + + return true; + } + + /* + * If the MCA_DESTAT register has valid data, then use + * it as the status register. + */ + m->status =3D mce_rdmsrq(MSR_AMD64_SMCA_MCx_DESTAT(m->bank)); + + if (!(m->status & MCI_STATUS_VAL)) + return false; + + m->kflags |=3D MCE_CHECK_DFR_REGS; + return true; +} + /* * Newer Intel systems that support software error * recovery need to make additional checks. Other @@ -740,6 +780,9 @@ static bool should_log_poll_error(enum mcp_flags flags,= struct mce_hw_err *err) { struct mce *m =3D &err->m; =20 + if (mce_flags.smca) + return smca_should_log_poll_error(flags, err); + /* If this entry is not valid, ignore it. */ if (!(m->status & MCI_STATUS_VAL)) return false; @@ -837,7 +880,10 @@ void machine_check_poll(enum mcp_flags flags, mce_bank= s_t *b) /* * Clear state for this bank. */ - mce_wrmsrq(mca_msr_reg(i, MCA_STATUS), 0); + if (m->kflags & MCE_CHECK_DFR_REGS) + mce_wrmsrq(MSR_AMD64_SMCA_MCx_DESTAT(i), 0); + else + mce_wrmsrq(mca_msr_reg(i, MCA_STATUS), 0); } =20 /* --=20 2.49.0 From nobody Wed Oct 8 20:44:15 2025 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2061.outbound.protection.outlook.com [40.107.220.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 893122DFA57; Tue, 24 Jun 2025 14:16:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.220.61 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774604; cv=fail; b=phEDPfA0qefmdOxwGwWvMW0tZ93+/ABm1v1j20HClkjeqvNtksZQgmIh93TYEtArT24nsQoSPveDO5hymeg9jjA2GWerJJKmIvXdcFcCVA+mCvcoshHi3Zf3ZPKDAoqZ/wl8opOiTRk55JPV7ljqebaVqTWHFaFsudcywFwFQ/4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774604; c=relaxed/simple; bh=gUsS/87xpdCqyg4916ZTRzKT4n9GYVnMs/6TcRgM5Ko=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=R4mcpKvfRaiJ70a/VjMbjj+YplEPPIkf1jcMNUkScAEcSZ13hHTonUplvGFiL5XUmyxBMGQiP3+vcTLDjmqt2eUiKaHCH2PD3WLjlcBQ73RCFi6BXwvtjO0lPnb0upDdiJcnbyMi2LPxi5PvJhVdIuKYsliC9KYv/j9sYkWe2JU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=eHOdy4fZ; arc=fail smtp.client-ip=40.107.220.61 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="eHOdy4fZ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=stuCA+zD+xcJuM4jKYh8Jgo/d8jogg+LdM1KOSbtgEY+Iun+8Adeo3QGhcuddkst+UoUX6MM4QIgUbMD49XhQE7wxTBlRmDyWkIFMZBWpOuSWlWNWum7raO9rc1y8xyDvFbISy0F5GpoAwyoWknp5dNYUQ02IwVVlOdwQlIXuF8dtwhGb6D3tycmZPlwow5AYQWnTPEQFv7LHehqKkAaU8HEsZUCwX+UmtwRH5w6xGl1vgSPVElnmK46gkARIYOvm9VJVTxaFuuO3/Za1GnvhUwj6+Qmgbf2tn00JWAPIhOCCeuzVPYRyJ8CgnSra2P6/jcxtmmYfzGl7jbhVHuZPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HaxW2R1slKCdaaOBhaVyDPlhumxCqfqU2ZGwn1rbz+s=; b=Nqp6wfL1Lq464cjbSSrGBsRQx1sEPNonuStggw6tXpxqrVxE9GdxtQXNSL44an6UHIYZnsOO9dNK8aE4JvaNS0EDkAhq6UCzHQndhp7s4L/C2JkxINjsWmoBckhCIxvBCC6256uww/6ORfcXLFQ1x09++djJ9iR2u6ZJmJxhzFwkhhBbzB7q1JtGj4vY8iJv3ekMLFi2O8qzP/hPMh4r2QNEf5+fMeoiIZx/UqVc5w1rdOJ1YayzjD9onZ632/Uduiu5ccyLPEnBWLkrvvvBLmujrxe9BgXZQWw5Pje2cYrmoJJI0cYzWCJm6+V2z6yoQX7FxbyZ77KFC1SiQYptqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HaxW2R1slKCdaaOBhaVyDPlhumxCqfqU2ZGwn1rbz+s=; b=eHOdy4fZiH5CqJgnNJjvMsCkm3OTma4A2USgOBGdxnLSbeBB2CePPrTvSTiggnp7sSfA48oqr74rduInppcYow+dYzfBhRMrNSSf5z7Glb++/SEb6b/9gd9sknV3X0T8lkZ5Ut4OEEFfPZMDNBfj3ACvOPder7of7/zVuvDQBaI= Received: from BYAPR02CA0063.namprd02.prod.outlook.com (2603:10b6:a03:54::40) by DS0PR12MB7748.namprd12.prod.outlook.com (2603:10b6:8:130::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.28; Tue, 24 Jun 2025 14:16:39 +0000 Received: from SJ1PEPF00001CE7.namprd03.prod.outlook.com (2603:10b6:a03:54:cafe::ef) by BYAPR02CA0063.outlook.office365.com (2603:10b6:a03:54::40) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8857.30 via Frontend Transport; Tue, 24 Jun 2025 14:16:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CE7.mail.protection.outlook.com (10.167.242.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8880.14 via Frontend Transport; Tue, 24 Jun 2025 14:16:39 +0000 Received: from [127.0.1.1] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 24 Jun 2025 09:16:36 -0500 From: Yazen Ghannam Date: Tue, 24 Jun 2025 14:16:13 +0000 Subject: [PATCH v4 18/22] x86/mce/amd: Support SMCA Corrected Error Interrupt Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250624-wip-mca-updates-v4-18-236dd74f645f@amd.com> References: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> In-Reply-To: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> To: , Tony Luck , "Rafael J. Wysocki" , Len Brown CC: , , , Qiuxu Zhuo , , Yazen Ghannam X-Mailer: b4 0.15-dev-9b767 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE7:EE_|DS0PR12MB7748:EE_ X-MS-Office365-Filtering-Correlation-Id: edb915d3-76e3-42aa-f499-08ddb329bc90 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|82310400026|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?d245ZmdoRjU1eS9COVNaR1JyNGQzNk1VMEloazgzeUVtQVJIS1pEdm02YXdq?= =?utf-8?B?SG1WMlFZNk5UNFJVRDBjZGc0YjlsS2R6Y0t4Q0JVZmdlZS93SXJPdEFLaVIx?= =?utf-8?B?am5sQVNlRmRKV1ZzemJnL3RmMlFISVFkOU01NjdXbWNjcDZVRFloZTE5ZHJa?= =?utf-8?B?b2tTMXBOa0hadnNoVWhQVWkzZUw5MUZFWTIrM3Jrd2ZONzVIa0hiS3hpa1BM?= =?utf-8?B?T3VudGdsTW5RMHVFbmZGL0xBR0JQanJHNmkvUXJnc1RTMmdDRlI3MldjN3kw?= =?utf-8?B?WHpDODZvVmRXdHMrRE5Ga3hjS21CNkY0Qi84WFdUOGpJS0VvYXJqUHR4eExX?= =?utf-8?B?MlU1TG1xdmc4dmRETnppRUVWT3RIU2FlR1pkUGVwdDliQkliSEk1V3U5ZnFs?= =?utf-8?B?NStibTlMYTJCSUFwcHo2SVVUSTZKZ1Evc1dOZlRWSlI0OVIyRk80R3BOKzZW?= =?utf-8?B?dnFUbGM1UitKYURXN2Z3R1FKaHdRTUxhNkEvYUtXaUZ0Z3Q4NnpRbVNMTGVF?= =?utf-8?B?eS9QWTZhRk5uQlBwaTBhNWFIa0ZHb0UrZXp1QlJiSlR3aG5uYWF6VHVkU3FI?= =?utf-8?B?TS9WVlhtTlFnUGhCVkxVWUExYW9LQ3loSEszdWZYeWdNVHZ0dFMvTjd2K1kw?= =?utf-8?B?amExbGdjdnJ1YzNZNnJLeGZUZHBxalVneDhsY2FSNW5iZjYwYjI5YUJCN0Jv?= =?utf-8?B?SlluMUMxVEg1aUFyN1dDLzN6Q05ibG1VejhXS1JJY0N0a0h3UzJWV2RFL09P?= =?utf-8?B?ei9WTlhmYkx6L1BaMWVrR0VITkVzZUh5R3Y4a3JYck1tTmh5cEM4R1JFZTJl?= =?utf-8?B?bUN6Nzg2dkFWUHFmY3IyUjNocFpBNW1YYVp3cDExVFh2eklZcjhKWVhDR1pJ?= =?utf-8?B?eE9PL2dEdHJUNlJCRXpVT3h5ZHBSOGdaa3MvUE5oODVoS3NiclFWQ2JKSFFG?= =?utf-8?B?eC80YTFxd2ZHUDVHWDhmZUYyR2owazcrMHJMYnV6WFU0bExWRk1aRmg1Y0Iz?= =?utf-8?B?SGxaNTVkRnF5SlpTOUREWjdNSGdZOXNoNys3M1ZTcjBVMUszUWJVUktNYnYv?= =?utf-8?B?VGF0OVZsY1NsUGQrUFBsR25ML01IUDBOYmpVSXpLby9SUXJyK1lHSFRQaW9Z?= =?utf-8?B?Z1dWYUZhbmtIYWF6TnlVK2wxaC9RMFB5ZTYwZ1ZxWEZEQUs1UjNCcTB6dkRa?= =?utf-8?B?a0M5SG8zSi96OVBGdnozSTZ0YVNtK3pucWh3TDRzSTBQYXN6TjhianBkc0F6?= =?utf-8?B?bHNSMFBYL0tTaXV0c1c3S3NCQkVmdmVWelVRV1hiVGFoQWdNbTN3bVVLbWdX?= =?utf-8?B?K3h0cGdCbi8wbU1Mb1VYN3JVSHVnRHE4OThpSiswSEdyUUNIaTJxa1FBcDNQ?= =?utf-8?B?NUt6TzhHdldKMWpwRzFTWEpZZE1MQnd5L2t3bjkrL0liR09Ga3l5ZGtUaVlU?= =?utf-8?B?Z2gyOUhlN0puMUM3bmx5Q1lhc2Y1bFlmd2phODRsVUFWNmJrUGMwQ3Mza2Fw?= =?utf-8?B?UTNQN0Q1bVlLbEdwU3FKZVI0OFVONjZhWC93R0tSd3NSUVdkRDFQT1IyTXky?= =?utf-8?B?L2hOaTRwZjRBZTVmblN0NHBUKzJnUWVIOFhQZGIrY0pMNjZyMGxPWU92RHNt?= =?utf-8?B?N3ZrM2NBOVdnbVRRdnJnUnYzQU05dXBQNmNkMjRJTjdRanhKY0JYQ0RXbStY?= =?utf-8?B?aSt5ZnFBaXBHK2FSZ1hTeWhiRnU0WDNMeUxxNStxK3hDdWIzZTlJM1RpYU5q?= =?utf-8?B?VU9wR09TeWJ0c09nbmRoTGJKZmlBQnNoMVZtL2tlanlqOXVRdVNQd0duOXR5?= =?utf-8?B?REQrTmNSNUsyQ3hlczdQc2YvT2pFNS9ZTVo5L3h6OTBOdUV4bm5TOEdjdzlv?= =?utf-8?B?MTFkbE1scENEOGJqc1Y1bVRQNXpNYUpjc1NiMEx6eVFsVVlSQ3FBc2Z2UFIv?= =?utf-8?B?SW9EY1dKN25UZXVxUnlCbHJPRnFKVmFQUG9jWU4zOHVUUUI3bnNIa1owcEdW?= =?utf-8?B?L0R3ZGFaTTg4NUR5dUtnVTZpeExwMFpXSHpPaFFlcE5kYmRCbmtNV1FMR2RV?= =?utf-8?B?SWFtZ200V0NXcmtSNlZaRjdUaDdxazdIRTcvQT09?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(82310400026)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2025 14:16:39.3782 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: edb915d3-76e3-42aa-f499-08ddb329bc90 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE7.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7748 AMD systems optionally support MCA thresholding which provides the ability for hardware to send an interrupt when a set error threshold is reached. This feature counts errors of all severities, but it is commonly used to report correctable errors with an interrupt rather than polling. Scalable MCA systems allow the Platform to take control of this feature. In this case, the OS will not see the feature configuration and control bits in the MCA_MISC* registers. The OS will not receive the MCA thresholding interrupt, and it will need to poll for correctable errors. A "corrected error interrupt" will be available on Scalable MCA systems. This will be used in the same configuration where the Platform controls MCA thresholding. However, the Platform will now be able to send the MCA thresholding interrupt to the OS. Check for, and enable, this feature during per-CPU SMCA init. Tested-by: Tony Luck Reviewed-by: Tony Luck Signed-off-by: Yazen Ghannam --- Notes: Link: https://lore.kernel.org/r/20250415-wip-mca-updates-v3-15-8ffd9eb4aa56@a= md.com =20 v3->v4: * Add code comment describing bits. =20 v2->v3: * Add tags from Tony. =20 v1->v2: * Use new per-CPU struct. arch/x86/kernel/cpu/mce/amd.c | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c index 9d4d0169713b..3ddb28f90d70 100644 --- a/arch/x86/kernel/cpu/mce/amd.c +++ b/arch/x86/kernel/cpu/mce/amd.c @@ -271,6 +271,7 @@ void (*deferred_error_int_vector)(void) =3D default_def= erred_error_interrupt; =20 static void smca_configure(unsigned int bank, unsigned int cpu) { + struct mce_amd_cpu_data *data =3D this_cpu_ptr(&mce_amd_data); u8 *bank_counts =3D this_cpu_ptr(smca_bank_counts); const struct smca_hwid *s_hwid; unsigned int i, hwid_mcatype; @@ -302,10 +303,27 @@ static void smca_configure(unsigned int bank, unsigne= d int cpu) * set. */ if ((low & BIT(5)) && !((high >> 5) & 0x3)) { - __set_bit(bank, this_cpu_ptr(&mce_amd_data)->dfr_intr_banks); + __set_bit(bank, data->dfr_intr_banks); high |=3D BIT(5); } =20 + /* + * SMCA Corrected Error Interrupt + * + * MCA_CONFIG[IntPresent] is bit 10, and tells us if the bank can + * send an MCA Thresholding interrupt without the OS initializing + * this feature. This can be used if the threshold limit is managed + * by the platform. + * + * MCA_CONFIG[IntEn] is bit 40 (8 in the high portion of the MSR). + * The OS should set this to inform the platform that the OS is ready + * to handle the MCA Thresholding interrupt. + */ + if (low & BIT(10)) { + __set_bit(bank, data->thr_intr_banks); + high |=3D BIT(8); + } + this_cpu_ptr(mce_banks_array)[bank].lsb_in_status =3D !!(low & BIT(8)); =20 wrmsr(smca_config, low, high); --=20 2.49.0 From nobody Wed Oct 8 20:44:15 2025 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2084.outbound.protection.outlook.com [40.107.93.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D3FD2E0B66; Tue, 24 Jun 2025 14:16:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.93.84 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774605; cv=fail; b=J7JjET2Z5CreTa4XLWgAEPZjZPEyDwtkDa00TWgmJo1Qxy31U+Cikgro43/4TyUMBFsxHMUVQnxTZlk7o27mBZsBFZ4GGqiheV6+NCuNv1cpxxFzvkYmhOToCR+NF5szNP50ukgJATgGEgzgjEDXUEm2N/Xa7elaQOGuSG6KJZU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774605; c=relaxed/simple; bh=NgSMfrqL5u6na8jgFKIh5RkyjmfnD/PgY7J5aaM5Zyc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=dSUKeE7T3wBEfPM7hbPTeTpoFcjvBs5H5uu/bc/J5dNOG3CaKzcqXV2yZafaYhHNIsDDUib5FlAPMNbqf69TV9G2CMf1ih852qkF4m9DMuwkK62o9LOMjNHapmaG/V//6tkAAeCzumA/SQxBEJxiXUcoyFeb5vSUGaWvYjTMk5c= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=1FHs/HNl; arc=fail smtp.client-ip=40.107.93.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="1FHs/HNl" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ec3dZmZpro5cHo45+3oUoFtqBUVK1uL9DiEEYnf41XRwTd8TzZG8bSRm+oc2Tpi1uVq7EXrXFLXKaNLAccViQjPiYF2P2mtadAQ6mTXyZvPTSbYgHEhvR+8Kz6fdtekrAiD2u6/CyF055vcDsI/mhnZB5nNVviaBwBYXSnDX/kyr3Mg9fJvh71j54kP+QfQyghVhmlZBilHZzclDVTs/PRT9imxTX9Alq1jjXWtdXS1iQOlpyvbVwrnRkyxAVQaUmUXBb7zy/aVEoTo6UhD3B9R5rcS6y1D4Umf0aBq60sHPd0lsYjm6kCITeDsNlGYVoA5ueHz0v5CRnuCCe/OfRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C4Dq9t3i16skBd1YuUjYHECsGxwvBT4FowuJZ6e+m9Y=; b=G2SwYeUQmOEaslixGdjqTL/SRZwGIlyM6boFPY8tiUSCweEoou2/Va/2Ggor2/gpHy3AwkUgkYTe9YpDrEl1VLDbDi2pUcizmTmI6ZagQqksYb6uwWCWpYw4GhqIp7gj+YuQf6fkIy2QCWAh6pXTOdEySVh3YAWmSDRZYYZA6a7czg/X0F+PduKaSJ2s+bmTXoNJBjFWvrOEIzc17FYbWIxeQBxkh6jL8AsErS5gkEW5vRo/Ys3W9xag0k46gLEma26GH0O+9ISKyco7WKRc3cERZvgC5yKvl2JoTfYBWQ2m1XhNPipIlZqrHuRdIRfvt+4KWjxBpCmmpAMBb5q3FA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C4Dq9t3i16skBd1YuUjYHECsGxwvBT4FowuJZ6e+m9Y=; b=1FHs/HNlCQHr9l/4A89nGFf98tz1ITeXgeRKnl7aEREwGuB1c3PSAd+vB5tIuNMR2BGA5EIIvcoxn7+yn/opPUJanB8KVfch65NZQqSO3aHh8bCL7LzZHhLYGgOoFzD/aegpAIwTKgQW8aTh2tq3dCrf7A85UVGzHC9FTgDY7RY= Received: from BYAPR05CA0043.namprd05.prod.outlook.com (2603:10b6:a03:74::20) by DS0PR12MB8248.namprd12.prod.outlook.com (2603:10b6:8:f3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.21; Tue, 24 Jun 2025 14:16:39 +0000 Received: from SJ1PEPF00001CE6.namprd03.prod.outlook.com (2603:10b6:a03:74:cafe::e3) by BYAPR05CA0043.outlook.office365.com (2603:10b6:a03:74::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.15 via Frontend Transport; Tue, 24 Jun 2025 14:16:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CE6.mail.protection.outlook.com (10.167.242.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8880.14 via Frontend Transport; Tue, 24 Jun 2025 14:16:39 +0000 Received: from [127.0.1.1] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 24 Jun 2025 09:16:37 -0500 From: Yazen Ghannam Date: Tue, 24 Jun 2025 14:16:14 +0000 Subject: [PATCH v4 19/22] x86/mce/amd: Remove redundant reset_block() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250624-wip-mca-updates-v4-19-236dd74f645f@amd.com> References: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> In-Reply-To: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> To: , Tony Luck , "Rafael J. Wysocki" , Len Brown CC: , , , Qiuxu Zhuo , , Yazen Ghannam X-Mailer: b4 0.15-dev-9b767 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE6:EE_|DS0PR12MB8248:EE_ X-MS-Office365-Filtering-Correlation-Id: 5be7f1ac-e4d5-4ef0-7cf8-08ddb329bcbf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|376014|1800799024|82310400026; X-Microsoft-Antispam-Message-Info: =?utf-8?B?NnlxMmxWOGtxM3ZkVy9NY1lNUER3elZKVC93SWVhb1ZZSzVFektnZ0JZZHlk?= =?utf-8?B?Qk9QcWhXOUpMclQwQ0ZzdlJLV0Rjc0QvY25QRDhlQkR3SUVwMlY3bWR5Q0RR?= =?utf-8?B?R09MVVIyY0VDSStrN2huTmNxRnB6NnlNWm9KVTN5SjdpR1I4dzN5M3hyUldt?= =?utf-8?B?dFg0NGg4TDRpTXpoaEtGZHNXWCtFWCtzRW9jVzNncWFUdUxvSXhjOXVMVmlS?= =?utf-8?B?aEFtNDNiMlJuTlZPbWVPS1kwTnE0dER0T1IwVUdYdGZIVzM3cE81aFk4b3A3?= =?utf-8?B?N0tzcjkxZFM0VzlqZEw2NS9Ib1NzZ2RvV0dPT0RoMnJVNW5waUxIekJJcHBx?= =?utf-8?B?UmFwYVF2Mjg0N0I5cXNXZFAyaG9jNHZtbXFPT1FBWXBDOW45eDNpeGI1eXhj?= =?utf-8?B?YURMemVWbHhIN1N2R0k5aEJLblVYYzdta2xETzd1eHlUMUNEKzFVVFdMeVp4?= =?utf-8?B?SlgyRU1yN2RhbDF4K292WlpLbzI1S2I4QXFDUzF3bE4zQk1qbDkvVlhDTEFV?= =?utf-8?B?eFhESFhRdDBRYm9aZzN6YnRGNDA0cS9PL05VN3RDUlhWMDhnMG5ETW9yWUhJ?= =?utf-8?B?RmhuMmRiYkVER0t0UW9MdDB4akd6ZUVjeTEvcGtPaEhtbk1yWHQ1YzBKdXFm?= =?utf-8?B?Y1FXd1FBWEMzMnd3ckFQOHo1b1ZtR0dzSjRLL2RoRlAyZUhYcE0wVHhiVWhz?= =?utf-8?B?ZldPZmtNM0JGVHFOeUpaZ2FZeE1NakRGeDdkWUtEUUZCY1FTdXBzK0xHaVNO?= =?utf-8?B?OUJRYWNZUXcyVS9iNW5JZ2xFZ1R1TnB1TUR1enBFUm5DNW5YUFhxK2Y1aHZi?= =?utf-8?B?bklNeEtrY1d3NzhlVUJlOU9LdGgzV3pjY25jQ0FJTDlzUHBNSXp3aGVlRmsr?= =?utf-8?B?Q2xQYVNpdllDUVdJRDIxazZsYWo0bEdvd0xkd2J6TzZnTXA5Q3gvZEc0L1p4?= =?utf-8?B?MG9ZUEhBcCtDditlVTdEVDFweUQxSjJ0ZlU0NDJYbjM5d0IwQzk1NHhzNUFn?= =?utf-8?B?VWJhRlI2YlBRaUZOcmtFOVk0N3JadTJaalQzVnA5R0p0Rlp4b2VvUW1Cb3VX?= =?utf-8?B?b0M3UnI1TVQ3SDJpU2FRK1BlbkFIYiszRVZ3UlJPUStJTCtTbTFha3p5M1Vv?= =?utf-8?B?ZjBybzZIK0NNeXkrcnNKd1R4QURycC9uN1NsVWxIQlM1cVc3eWdNWmlGcXZS?= =?utf-8?B?VWNGWkpXZk8xMkZjT3J6QkQ2L3JDcExVZ1JaSi9IRXMwSHBteXpTN1ZSWi9Z?= =?utf-8?B?WDFNeVNFRG8zRW1xdDlQK0JEb3hzZ25rN1VJTVRyVVBOTTFCZXU3ZmpmSTEw?= =?utf-8?B?bDZJZjR4K1owbHZTd1F0TlhpQlRvYm1qYlBVODZTbzJXdmx0WDFNelRrQlUw?= =?utf-8?B?UG9tYkpqSGpuVmQ5WHFMVnh0Y2VtRCtSeXZMUSt5STNZOERiWVlqSDNGbjA0?= =?utf-8?B?d2lzRUpMV0tHSVZpVW1XWEtWTFB6RVc3amcrTFNybXltRno4bUhqVlZWcUN5?= =?utf-8?B?b3ZIejdiUUM4c1g2bTlkYlViSzZCbXdHMmR6NW1RTmc2VTJ0dlQvaWdjTUFm?= =?utf-8?B?U1VVc3hPdEsyQnI1ZWt3TkNMSTNvSVE3SHd4bG91MzJldFl2bVlzWlg0bmNC?= =?utf-8?B?Zk9jKzREajlnU0s2Z2NLVVdGN2dGZWZFcDdtdXh5RmxLWFpwOGp6aWR1eStO?= =?utf-8?B?ajBjTm9IanRwd1ZaaHJ3dyt4L1QybG1mSTRBMmNXU0pTcWdubjN4eTZMMVRp?= =?utf-8?B?NjRyNndYMVVoRitKQy8yT0FjZnhoWUptSC9vblpjbDd4eWlMWUpNSUIxSVJm?= =?utf-8?B?V2VmWC9UUVBzMzA3elNpc01WTm1tK0VNUktjQ293ZWpKMXovUWFkejZOZzF2?= =?utf-8?B?aTI4ZEZMbmtCZ05paWtXK0g1ZllPZk5oYjlKQjVJakUrd1BCVy9XRmkrcUtu?= =?utf-8?B?YmIrY3FtSk5QSGxVdG1JaU0yd2x2YXY4cWRiajN1aHJkeFdiNzY1QldEUG1i?= =?utf-8?B?Z2RBY1VNbGZCNGRXdzBGZ1RhbURDRnI2K1pYaVRZdjZmN2dNK25GTWRCRXNY?= =?utf-8?Q?+0MeDy?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(376014)(1800799024)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2025 14:16:39.6912 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5be7f1ac-e4d5-4ef0-7cf8-08ddb329bcbf X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE6.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8248 Many of the checks in reset_block() are done again in the block reset function. So drop the redundant checks. Signed-off-by: Yazen Ghannam --- Notes: v3->v4: * New in v4. arch/x86/kernel/cpu/mce/amd.c | 28 +++++++--------------------- 1 file changed, 7 insertions(+), 21 deletions(-) diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c index 3ddb28f90d70..3cb9f6a68316 100644 --- a/arch/x86/kernel/cpu/mce/amd.c +++ b/arch/x86/kernel/cpu/mce/amd.c @@ -830,29 +830,11 @@ static void amd_deferred_error_interrupt(void) machine_check_poll(MCP_TIMESTAMP, &this_cpu_ptr(&mce_amd_data)->dfr_intr_= banks); } =20 -static void reset_block(struct threshold_block *block) -{ - struct thresh_restart tr; - u32 low =3D 0, high =3D 0; - - if (!block) - return; - - if (rdmsr_safe(block->address, &low, &high)) - return; - - if (!(high & MASK_OVERFLOW_HI)) - return; - - memset(&tr, 0, sizeof(tr)); - tr.b =3D block; - threshold_restart_block(&tr); -} - void amd_reset_thr_limit(unsigned int bank) { struct threshold_bank **bp =3D this_cpu_read(threshold_banks); struct threshold_block *block, *tmp; + struct thresh_restart tr; =20 /* * Validate that the threshold bank has been initialized already. The @@ -862,8 +844,12 @@ void amd_reset_thr_limit(unsigned int bank) if (!bp || !bp[bank]) return; =20 - list_for_each_entry_safe(block, tmp, &bp[bank]->miscj, miscj) - reset_block(block); + memset(&tr, 0, sizeof(tr)); + + list_for_each_entry_safe(block, tmp, &bp[bank]->miscj, miscj) { + tr.b =3D block; + threshold_restart_block(&tr); + } } =20 /* --=20 2.49.0 From nobody Wed Oct 8 20:44:15 2025 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2057.outbound.protection.outlook.com [40.107.96.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C29F52DFA3D; Tue, 24 Jun 2025 14:16:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.96.57 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774606; cv=fail; b=eIGcNGn6ul7hxNL0N1qDQp4v/+X2odndUjhlWcZSda0O7dXhuT9XQtliSBGe6vnJ7ZPISID0rd3sj5bFQ2jGLAknWKuCOk4G9pXwTsbJWpX6i3vdJFx+esPwpMcDpfrSXaPfbw9B/vnXMXVOPeXXch+ZUTYuvEkM/zQkFjEnW4s= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774606; c=relaxed/simple; bh=sUT/SjsPtvGHgVfA01QDt7x5Xx41sstDvXmSa0P3Pfs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=YwXZmjqGhGaHoi9WWIWKn+/1Cp2sDSmnuN0MB7+H805n/k3eTmkEMzOC0jCTvhClMFM2uBI+pfbfMiWUP7+opzYY/hgThNBMMX6MKmPb+urfWFx7XRpC73WmYsI9PqTrg3K1Ya0x5nUAYC4xDY7jx7YOuK3blZuTYZqzEUIAUdk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=vJm+BUKT; arc=fail smtp.client-ip=40.107.96.57 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="vJm+BUKT" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pjWDnJZggbxkkgbWQQVf8aeeRoMSGUDh2YjAuHOmBmA/zXMczyt+8z4n0equ0+PNpxgT8aGnTYILN4JnmJlI4VSR3n6SSsjceZl78jH6uEKVxId2oqqAUyhaO1ZxHbxBbrFr44mRQ+NNYsbTMP30eHFSaNW14VebKv15O5F5d480oI+AIMX+QrrbI91MAPaswBvIBNPEpdeSgatvLBZTctNyeChhnnCh6S3lXkPDQeOFUteK14TYbSHcHle2OM9ZyLF0Y4O6pQVgOmkYmeYeVghyxasijeOYh47M2y/DgJIyNUMh6Ca9pfHveYvUBk+DNO+D2qb96GUfcxqnXARlvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2+aWmYAWpKWLiVvOUM9floD9d3qm75gHRQtlWdIIveM=; b=bt5qHdA3OtNTkiwvhrwZ7w1ueJcMMngDNvT/0NMY+Mp+z/IKLnICML9daPqbK4VEkql641kh8+R+2bcO2213RQF4gz+ZN6tWtA2OLgqvI3WcqMyj+Yg2/q449JPDNWEOqtRaYOcu31JhmQpEr71xlce0pwc3/jmyzNaTIKobRCuA5qU2rTRG+EAmlPed5kZOO8vyvJxhvZlo/NyreTTPow7820oCL6/CDbfOSI+6AIXybyNyKM1RPOZoICcdVC5jExpSg5ak+jjpz0nVuvG80z8ZBAI8qdmMzy7DNzznA+/TrXxjyIanhvX89nC+ubeNmMfUuGlYghS5IxxSXUYCHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2+aWmYAWpKWLiVvOUM9floD9d3qm75gHRQtlWdIIveM=; b=vJm+BUKT2SaNzo4MSpCUisPY3z1WhJU9UEpsexvX+prPWSjEnVPTQZGA3NptwOfQLeN4Th9xsNkusm0OM5GDAeGw2XN/hRfP4gSudngtS8igEocGa8FUcqh1g3PKQ0Uzgv2Huly43cAh98e6HaV4rU68MhgJjikng2S8s4DLR9M= Received: from BYAPR05CA0040.namprd05.prod.outlook.com (2603:10b6:a03:74::17) by DS7PR12MB5960.namprd12.prod.outlook.com (2603:10b6:8:7f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.20; Tue, 24 Jun 2025 14:16:40 +0000 Received: from SJ1PEPF00001CE6.namprd03.prod.outlook.com (2603:10b6:a03:74:cafe::1b) by BYAPR05CA0040.outlook.office365.com (2603:10b6:a03:74::17) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.16 via Frontend Transport; Tue, 24 Jun 2025 14:16:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CE6.mail.protection.outlook.com (10.167.242.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8880.14 via Frontend Transport; Tue, 24 Jun 2025 14:16:39 +0000 Received: from [127.0.1.1] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 24 Jun 2025 09:16:38 -0500 From: Yazen Ghannam Date: Tue, 24 Jun 2025 14:16:15 +0000 Subject: [PATCH v4 20/22] x86/mce/amd: Define threshold restart function for banks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250624-wip-mca-updates-v4-20-236dd74f645f@amd.com> References: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> In-Reply-To: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> To: , Tony Luck , "Rafael J. Wysocki" , Len Brown CC: , , , Qiuxu Zhuo , , Yazen Ghannam X-Mailer: b4 0.15-dev-9b767 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE6:EE_|DS7PR12MB5960:EE_ X-MS-Office365-Filtering-Correlation-Id: 35f1d0ce-d0b7-407d-ff25-08ddb329bccd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SWxpUHJhTFNiNnAzcUlWMjV3cndBTmVBM29ndndXQTVmaGJEMnZvbGdtMDky?= =?utf-8?B?NndZQlZiNGN2ek5jOWRuSmplcS8xVHBMS2xINmxVSjFnY2NRUTZRdFBNaFZN?= =?utf-8?B?YkhoWFk4bFdKY3RKU203QlFvUWxqR2ZkYm9FZW1TS1lKVlhyZ2pXNlE5YUhO?= =?utf-8?B?YUFIY3I5dkcxVW4zYk82TGE2eGlIYlhvY2UybFlqZ3NhOFE5QWZkdGV2WE9J?= =?utf-8?B?bzdNd1h6VlR6b0VmVGdxdEdBMlRNd3AxMjl3Q1VCZHNhSVBicFVUcEovVDNO?= =?utf-8?B?OFVvd1hkQjJlMnFNbXRwMjVXY2xiV1Zpc0RISklManBBZDY5Z1lobmRnekJi?= =?utf-8?B?VWNMbXJ3b0JNRXVJeEU2WXp5Qjk3YXBsU3U4SHd1ZEpZUzJ3emU4V1luNDJG?= =?utf-8?B?czdNa0VJazlCQ2kvbGdPZllGUzhmdHBnaFAzUE44ZTd2MTZHQ3U1NDUyd2xR?= =?utf-8?B?UEZRYm1wdGdFRVB3Mk1ScnYzZERCS25vK3ZhdzBubTF1L3ZDOTEydGkyakJm?= =?utf-8?B?bmlyQWtFU2Q4Y1Z2cnJWRGF5eEN1clUvbkJLcTFaS2N3cURqZXEvYnJTdGV3?= =?utf-8?B?ZWhUTVgzZ2tBMFluRU1Ga0syc0EyOHNxN21yOTk1UUMwUjhsdmlwb2JyV0x5?= =?utf-8?B?RzFIQUF1NFpQeEFWOXB6dmtKTEpPNUxVQmZJd0JVNFFLcFpNVVJKNGkwN3N5?= =?utf-8?B?UXJzMFFQQklGZUxVbWJOOHBzejZoYUhPbUhVWDV2NnZ5MndJdGV1ZHhpVG12?= =?utf-8?B?V1RHOFNxbDJiVUtoVFZ2ZzRkS0tMSnNyYmdORXVuK1B4OHdPZEhGWUc2MEhD?= =?utf-8?B?QXRmUVRhejQrYXhBdnVmSm5IcSt6bHZCaG81Tk5uNmVlTk5pM1JKNkFZRS9w?= =?utf-8?B?clBXaW5UNklHeVVyKzlLM0ZCVWFEa2UrYld0N05QVDg4U0dvUWJSdlNBc3BL?= =?utf-8?B?Y0wrdlR0TEVjMlJ2a0s4ampxb3JDcnpYQkNHVldQdXEva3dXeE9DOExwbWpz?= =?utf-8?B?Q0dzRXBuMTJjWitzZEJ3S283bStWaWplaS9GOGJvbjV0TENpakdZL2ZMK1JL?= =?utf-8?B?SlNmK1hQOUZZSFNwcmdCR0x6N1MwTGdzaElUdnJZVTJvQVZPSU9HMTlnSjlE?= =?utf-8?B?eHR0dTJoKzQ5V0VPaUxmeG9YZmY3RHBFMHNWTjJMb0pxamVyNVJOQ2dEdEw3?= =?utf-8?B?K2pmVDRUVVZOV1lmRkF3OHNiRVMwdHM5VFNtTWFVZE5wRm03bW41TUlkZ0Zj?= =?utf-8?B?djgwdHdlVG5DekIxMURrcEUxMEYzRG5uOWt1MGpKWUN2czM1SE1xRjBJbDAw?= =?utf-8?B?TFVlSFZCOWJYUzNCU1dUcGZ5b01XMVdwT3FlTHJQeks0RlFzYUJBNk53SkFr?= =?utf-8?B?RHljaklpbzVoRmpRRUVNL1VGTVk5cjJkanN6dWRhTTZCQVJlcUc5bGdyU3J4?= =?utf-8?B?d2o5K0lBTTluRFpxZC9hSUFIWTJ0RzYxd0N4eUV0VkVzRThkZWpPdXJpaVBK?= =?utf-8?B?Wk1NSlM4LyttYXJRVy9aTmpzQmpnMXRzTlR6MnMrY2l1VWh4MEdVcUtpUnNp?= =?utf-8?B?bHFqcXcyTXlLWGl1OGhndXhRQlBveFQvNyt3MDYrQlcyM2E2aVh0NXpqK25v?= =?utf-8?B?RG5VZ0hCTkhtUUE1SGdjcGZvWFBvNWZRaFJqZ1BmbVJuempvUlczMVZVdGs3?= =?utf-8?B?c0FSYmJ2MnNNT1VFUExyeFY4MDB6bjdhZE1idUk3QVU3LzRObnJjYVdNQ1VD?= =?utf-8?B?MGNKQkt4NUc0QnVaQTh2VXNnaHpqNXdHUDNxSXhaa0dzZmpUV1RodHNUc0dK?= =?utf-8?B?cEFpZ1RmRERlbkJVaVdQMjNhQmhKaTN2Q05ZNUhQWDFqcTVTNDJ3Tnpzbmo0?= =?utf-8?B?eFVFZXhoaFlXV0M3VUNGS3FWeDJDTXNROUVLbmhpL0hZTHpIZGRncnlWT1gx?= =?utf-8?B?dVBiSlBpL0Q3cEVkVDZVbStOcDI2M2R5RGtLbnVDQmJhaEdxVjIvZUZoQ0tM?= =?utf-8?B?UldLS3NlQWJodTFmclFGZVgxYnUrRVpNMVVrQjlNUjNFcS85ZWlmL2x0YmVk?= =?utf-8?Q?byhQNo?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(82310400026)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2025 14:16:39.7850 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 35f1d0ce-d0b7-407d-ff25-08ddb329bccd X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE6.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5960 Prepare for CMCI storm support by moving the common bank/block iterator code to a helper function. Include a parameter to switch the interrupt enable. This will be used by the CMCI storm handling function. Signed-off-by: Yazen Ghannam --- Notes: v3->v4: * New in v4. arch/x86/kernel/cpu/mce/amd.c | 37 +++++++++++++++++++------------------ 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c index 3cb9f6a68316..56e7d99cef86 100644 --- a/arch/x86/kernel/cpu/mce/amd.c +++ b/arch/x86/kernel/cpu/mce/amd.c @@ -470,6 +470,24 @@ static void threshold_restart_block(void *_tr) wrmsr(tr->b->address, lo, hi); } =20 +static void threshold_restart_bank(unsigned int bank, bool intr_en) +{ + struct threshold_bank **thr_banks =3D this_cpu_read(threshold_banks); + struct threshold_block *block, *tmp; + struct thresh_restart tr; + + if (!thr_banks || !thr_banks[bank]) + return; + + memset(&tr, 0, sizeof(tr)); + + list_for_each_entry_safe(block, tmp, &thr_banks[bank]->miscj, miscj) { + tr.b =3D block; + tr.b->interrupt_enable =3D intr_en; + threshold_restart_block(&tr); + } +} + static void mce_threshold_block_init(struct threshold_block *b, int offset) { struct thresh_restart tr =3D { @@ -832,24 +850,7 @@ static void amd_deferred_error_interrupt(void) =20 void amd_reset_thr_limit(unsigned int bank) { - struct threshold_bank **bp =3D this_cpu_read(threshold_banks); - struct threshold_block *block, *tmp; - struct thresh_restart tr; - - /* - * Validate that the threshold bank has been initialized already. The - * handler is installed at boot time, but on a hotplug event the - * interrupt might fire before the data has been initialized. - */ - if (!bp || !bp[bank]) - return; - - memset(&tr, 0, sizeof(tr)); - - list_for_each_entry_safe(block, tmp, &bp[bank]->miscj, miscj) { - tr.b =3D block; - threshold_restart_block(&tr); - } + threshold_restart_bank(bank, true); } =20 /* --=20 2.49.0 From nobody Wed Oct 8 20:44:15 2025 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2060.outbound.protection.outlook.com [40.107.95.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63C292E0B61; Tue, 24 Jun 2025 14:16:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.95.60 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774606; cv=fail; b=bIlL3lrgl8YXIBPtt/WBThbKOKxnW3FMuKp1NMOsUKWm84h3CxZ0YwHZW7UevcZR0r7ZeT0crrcGXQb1BoHNT/4jHbMk9dp2qDFruTSWcuZ5PdVS+showCv+/PMeQHoHp6xtTeHvtT1Jejfg1YF2izqsfrwOpo8cmX2ncGgs2dY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774606; c=relaxed/simple; bh=KHKc94XxBizT+ESKipj45EzFPfrUg77hNJrufuZ0yxo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=tWs6bMbXz2f9zIStaqCnbVbH1b5HlQX911zFYPv85LYB5PmBs0Rkp+eXx3XFkq2XnvBXyFpSsA0gLN0dsbX291Vg6Qkr6cptM4WTU8nf+AenHo7d6kpJMHCXV32+3GxGU2KNVCTv0v33rEtBIp+8pGDSiWDo9NcYx6lw5Z967OQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=S4xlHmGC; arc=fail smtp.client-ip=40.107.95.60 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="S4xlHmGC" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sh/WQHZQzV2t2t5eZD+Ie8KYnay2j3O6Tz1PSWroKzBm4VSNvDzu5otGQ6wJZWHEf1qk+zPVru2N/j8w/tywFDDj60bmwNitJshPsANzCKYtw+TASJSPBSVx6iyhpJAl+Xu3OHw++aC0vbScWgLwmVZuorrfjtNMwxa7lMyD2MYZumaoqlzHLDAnSaQGzFK/Rmt4Ld3hbqwfkaU+qCy9h26u/ms4wEgcwjsINbGWqdlPEDwig544xSSPiUzLr26acF3qyy2QQsvj3miLAsGXFc3M6xv3bjL7yX5l6ysRWotBKoCSrCizObypfcOZwY7aJRrAMHIE0vvBW3ZG9Y8sxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ADVTjgdDYzvuco1X9/2BkU/Ma5F5yiCHbXUACVMseYY=; b=uOk2zALbh25J2EErCn9+/FXn5EZfACeozXU4ShtvLZyQkQYOXmG9v8/t4uNiw/sQqnsUc11qrB+xr3FNrheGtXt0vPvfO8YUxaf/Uc9VGfeHbneTavZTrSc3dUrcDa11thT6NcGKEGDQm4T03intyrA8Gor/NDk64I5YitZDayfNK4LLT2E1yVBotAY6UqO+1fHlL7eb4VAVmcxDX4+a0dShPlRC+GKV+eTXelro4/o4bwddh5X8CUNMV/n9LAJGgfJF8iEtct3IGzhUvA3++x5ueC3V7wVqhrh4e2s21KGYewkpD+R6G2Q73bnyrpRvtdLi4q/31l5B/P+XA5KQww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ADVTjgdDYzvuco1X9/2BkU/Ma5F5yiCHbXUACVMseYY=; b=S4xlHmGCaA9VEblPNbX7vhXpjUukE8ghwdoWwWJ/7FK91klUEVZ5DElKK+voV1bTGl2usQD8Up6gQbbzMcoXJLCILXZ8I/pjvTi8xRWCWWDdRORBHnzHPE3XszS8nVBoMo6FqIh8GYCPMCNKsDn9pVH0r6BV4B1ds5BqTpUAl3U= Received: from BYAPR02CA0055.namprd02.prod.outlook.com (2603:10b6:a03:54::32) by PH7PR12MB6956.namprd12.prod.outlook.com (2603:10b6:510:1b9::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.28; Tue, 24 Jun 2025 14:16:40 +0000 Received: from SJ1PEPF00001CE7.namprd03.prod.outlook.com (2603:10b6:a03:54:cafe::ab) by BYAPR02CA0055.outlook.office365.com (2603:10b6:a03:54::32) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.16 via Frontend Transport; Tue, 24 Jun 2025 14:16:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CE7.mail.protection.outlook.com (10.167.242.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8880.14 via Frontend Transport; Tue, 24 Jun 2025 14:16:40 +0000 Received: from [127.0.1.1] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 24 Jun 2025 09:16:38 -0500 From: Yazen Ghannam Date: Tue, 24 Jun 2025 14:16:16 +0000 Subject: [PATCH v4 21/22] x86/mce: Handle AMD threshold interrupt storms Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250624-wip-mca-updates-v4-21-236dd74f645f@amd.com> References: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> In-Reply-To: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> To: , Tony Luck , "Rafael J. Wysocki" , Len Brown CC: , , , Qiuxu Zhuo , , Yazen Ghannam X-Mailer: b4 0.15-dev-9b767 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE7:EE_|PH7PR12MB6956:EE_ X-MS-Office365-Filtering-Correlation-Id: 18a4af6e-7d2e-4b28-734d-08ddb329bcfc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Vkx2dW45MGdacXJWRlNLS25WMXIvQ3oxU0xEK0dncFF1bzRXNkZHU2dUTjlT?= =?utf-8?B?dGdzbG80R3A3YW5UOTZJMUNUSXlad0VSQ0I1K1FHbHk5WmZyZzJOSVVyQTJD?= =?utf-8?B?cXY3QUdWSDI4RkJEayt4NlBTN0FkQjJvL2NyRUZFZkNRSXNta3RiY09pSWM2?= =?utf-8?B?Wk0vQ3gvWTlueUs1cjJhVGhTc2tqTnZYbW9NQkJ1emJQUFR6ZW1TRFpvV3ha?= =?utf-8?B?eEVNZnpRRDc4enJaMjFDd0Rub0hUWkErbk1oakk5Y0pBUGVkVDRhQ3JQb3Uw?= =?utf-8?B?dlRPVjF0NmxCQ3FjM2xiWGp5WmQ5SHVlUnRjSDRQOVl4cGVjV2VEaEloVVp0?= =?utf-8?B?YjdudUFpT2xTUFVzZ0tCRDRZQ2JaSVM2a0psVEwyV0dBVUV6aVFzWGVjNisz?= =?utf-8?B?eWJwS0ZoVDRzOVpjejUzWDNJNUMwNnlvcHpIYnE1Z3JIYWdRcDZmZmYvY1R5?= =?utf-8?B?VjBwRElNazhsOWl1bXhKeXBJSzEvUnVSelNVb1lodHNSYUVUN1U1TW9UY1hs?= =?utf-8?B?RkNmTUlZMjZkcnV4Ky9kcWZheE5jVUhmVkszcm1xNlNMQnRHWk55U3RzSmFQ?= =?utf-8?B?RmRVQlk4OWk3K0RHeDVlQ1RYSzFMUWVkM0ZjZzFJMVZLci8ySWpESCtRQjBR?= =?utf-8?B?T0VQN0p3ZTEyQ2FoWUZualc1aTZWMlBoZSsxWUlqWURFYmdNTVVaYW5JWm9k?= =?utf-8?B?YndEVnIyT01KeXN4YjdsWDlZQXhZb0h0QXhwbm5JUmxha1dkVnFTbWltTXhV?= =?utf-8?B?TDZuZE9LQXJ3S01sZDZlRjFoMFFVOStUZWNvcUVKVXJ1MzJieWR5RnFwWDlQ?= =?utf-8?B?SkVMWkJMTVdPVm50d1VteXZjbHZrY3B2cmJSaEZ5SWVoVm45NWJQNW5TNDFw?= =?utf-8?B?aUZQRURhdlZPenZxWEgyQVdGd3RYbENDTGZGU1MzVDlpclpRSnNNNVRVWUdO?= =?utf-8?B?cDRHRlBWUTdZUlc3b0FuOGRIM1hneTZZbUdKTWh5OHZNeE5kU0t4amxkcGk1?= =?utf-8?B?UUZ0WDN4L1pWVGJML3pvWDRJd2lDb0pRd0lQSitUbG1nQUJlWCsxam5VZWRS?= =?utf-8?B?elp2WE4zL29Wa0pvWE52dkNyaTRUSldaK3lONUNBOTZNS2NTZ1Zsb3FVWFM2?= =?utf-8?B?eEVySGpjZTRWTTV2aGY1ejJ1Y0J2ZkFjNkFmQ09KRG1iMHdUYkVvVmVoZUZy?= =?utf-8?B?dUpqOXVHNWFCeGVUdVVkdWdPZVBtVjBGa0toZ1Fza1dURzV4NXNNNDV3S21F?= =?utf-8?B?eDNqM1lSUXFyZjVlTkd0NC9VUXpNalVpQlpjNHF4QjhCaDMyWE1PTVdzL0do?= =?utf-8?B?VUVhLzRGUXN4dDRQWWFybFFmK2svVWV0dHJoTlM4WDJUV01rTjFnTUN2UnFm?= =?utf-8?B?cHlrT1pWc0FMaDNwNVA0eFNqWktjbWRHSHVINTFEM09ESUpXbFdNUmVLSnJq?= =?utf-8?B?c0Fac3JiU1A5TW5SalVleUtxa3hFUk43Y1F4anorQVhJK0dzaFBaa1dSSk1M?= =?utf-8?B?Zk9PbjhWYnNqZDJOSG5oQ1FFWkpUYWxvcmFTNy9YRnlkS3ozZlhnYTNMSlZD?= =?utf-8?B?U2lqTHkra3VNd2JrVklCcVdQN2NQVkZqcVVVZ0pWR3JvdHZuS1ZCUC9hekxT?= =?utf-8?B?L01QVFgzQ3hrNm9UcjUxS3NFR2NzRWUzK2ttckhySnRDRFNCcXdrS2hkYVJ6?= =?utf-8?B?WW1KOXdaQXpvRDlnTGxMUG1QUlN0R3FvQ0VIYmp6Rm8wZ0RnbUhrMEU5V3dS?= =?utf-8?B?UWExdXd0Y3kwSDEwZ1FyelNZOFdyb29uVEpXTlZpbDVUMzhmRFpZYlhSTURl?= =?utf-8?B?c1BabXpBVHlpMk1UMUJYVDRGd2NPVElNRzF4R3UrbVdrVVVFMStrbktQSnV2?= =?utf-8?B?OVoxL0VzdHZjOFZzTnRmNGdYUm1MWjNQa08zOENIYTZ0VEJqMWJoaUpkemRF?= =?utf-8?B?WVRKYzc3cXNUYUJzNm9NQk5HWVRES29kcWRyTTNzS1N0c1J5aW1yTWo5V25K?= =?utf-8?B?OXV0UXhDYUV5TVZWVitTUjdpdVZna3NobWl4RGFhVDVxU2xXS21oUTQ2YWRZ?= =?utf-8?B?WWVYTEZNU044VkF1YzQ5ZXNXUmxBMXZzaUN1dz09?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(376014)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2025 14:16:40.0823 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 18a4af6e-7d2e-4b28-734d-08ddb329bcfc X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE7.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6956 From: Smita Koralahalli Extend the logic of handling CMCI storms to AMD threshold interrupts. Rely on the similar approach as of Intel's CMCI to mitigate storms per CPU and per bank. But, unlike CMCI, do not set thresholds and reduce interrupt rate on a storm. Rather, disable the interrupt on the corresponding CPU and bank. Re-enable back the interrupts if enough consecutive polls of the bank show no corrected errors (30, as programmed by Intel). Turning off the threshold interrupts would be a better solution on AMD systems as other error severities will still be handled even if the threshold interrupts are disabled. [Tony: Small tweak because mce_handle_storm() isn't a pointer now] [Yazen: Rebase and simplify] Reviewed-by: Qiuxu Zhuo Signed-off-by: Smita Koralahalli Signed-off-by: Tony Luck Signed-off-by: Yazen Ghannam --- Notes: Link: https://lore.kernel.org/r/20250415-wip-mca-updates-v3-16-8ffd9eb4aa56@a= md.com =20 v3->v4: * Simplify based on new patches in this set. =20 v2->v3: * Add tag from Qiuxu. =20 v1->v2: * New in v2, but based on older patch. * Rebased on current set and simplified. * Kept old tags. arch/x86/kernel/cpu/mce/amd.c | 5 +++++ arch/x86/kernel/cpu/mce/internal.h | 2 ++ arch/x86/kernel/cpu/mce/threshold.c | 3 +++ 3 files changed, 10 insertions(+) diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c index 56e7d99cef86..85fd9273e90a 100644 --- a/arch/x86/kernel/cpu/mce/amd.c +++ b/arch/x86/kernel/cpu/mce/amd.c @@ -848,6 +848,11 @@ static void amd_deferred_error_interrupt(void) machine_check_poll(MCP_TIMESTAMP, &this_cpu_ptr(&mce_amd_data)->dfr_intr_= banks); } =20 +void mce_amd_handle_storm(unsigned int bank, bool on) +{ + threshold_restart_bank(bank, on); +} + void amd_reset_thr_limit(unsigned int bank) { threshold_restart_bank(bank, true); diff --git a/arch/x86/kernel/cpu/mce/internal.h b/arch/x86/kernel/cpu/mce/i= nternal.h index e25ad0c005d5..09ebcf82df93 100644 --- a/arch/x86/kernel/cpu/mce/internal.h +++ b/arch/x86/kernel/cpu/mce/internal.h @@ -267,6 +267,7 @@ void mce_prep_record_per_cpu(unsigned int cpu, struct m= ce *m); #ifdef CONFIG_X86_MCE_AMD void mce_threshold_create_device(unsigned int cpu); void mce_threshold_remove_device(unsigned int cpu); +void mce_amd_handle_storm(unsigned int bank, bool on); extern bool amd_filter_mce(struct mce *m); bool amd_mce_usable_address(struct mce *m); void amd_reset_thr_limit(unsigned int bank); @@ -299,6 +300,7 @@ void smca_bsp_init(void); #else static inline void mce_threshold_create_device(unsigned int cpu) { } static inline void mce_threshold_remove_device(unsigned int cpu) { } +static inline void mce_amd_handle_storm(unsigned int bank, bool on) { } static inline bool amd_filter_mce(struct mce *m) { return false; } static inline bool amd_mce_usable_address(struct mce *m) { return false; } static inline void amd_reset_thr_limit(unsigned int bank) { } diff --git a/arch/x86/kernel/cpu/mce/threshold.c b/arch/x86/kernel/cpu/mce/= threshold.c index f4a007616468..45144598ec74 100644 --- a/arch/x86/kernel/cpu/mce/threshold.c +++ b/arch/x86/kernel/cpu/mce/threshold.c @@ -63,6 +63,9 @@ static void mce_handle_storm(unsigned int bank, bool on) case X86_VENDOR_INTEL: mce_intel_handle_storm(bank, on); break; + case X86_VENDOR_AMD: + mce_amd_handle_storm(bank, on); + break; } } =20 --=20 2.49.0 From nobody Wed Oct 8 20:44:15 2025 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2054.outbound.protection.outlook.com [40.107.243.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2D722E0B67; Tue, 24 Jun 2025 14:16:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.243.54 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774606; cv=fail; b=U1cG6CnLUBSAcbPJq43bwDzXWZf5pkVLFR2pDmJffynNlu7teGcelTvFn4fg0lXtMgtyAuaxTsvDOvAsv2ufXnAV5lenp1yMWB7oOydiMCV/XGCF6aVAInwF4eaRqqj+eLXixUZXmv3jIjulxCQf7o0gHuwFQicYzXVpGZTbYsg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750774606; c=relaxed/simple; bh=PUxvdU/FGrtMkKmlTayh4Bas0x/axFzp32/5zqxbNvs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=CwWkpFbBkxduLk4nLVPA0e8ZstiebFIYPATGohLIWKclshufO20Pj9TgDzN93CHYlvV79JnSOo3+0DOSe3KTActRSSSkBJioH8A24mlDZH5He9nuXlLIFh+TwCrV0vfeUdGNORFMqfGES7jtDTZQSx0jPR6iTzs7tX2N+3Ch/18= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=B89mipnt; arc=fail smtp.client-ip=40.107.243.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="B89mipnt" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VWWhe/3GP0TQFrFnRfe1A0UqHmEkDztWVmzDeuDWJH2LLo+S8N8516ChYkdxgUlypL5RINE2gy/Fg+qcVlAu6El2qBCBFLMfLvG6c76V25UN3uY5tYgeAlVtMPKYU8uYxvdOnUuft7PuCQPobC5kPdugO3vLcmBCNEodVYf9LBdLUGO3L9igiIF69gGWCFWjgdUdHdmCj79dkIcO4BC6qHqYqww+alMP2JR/S8XGX9ii2fN8zhIzd64zGP5yAc7PwUeDzWpdYDJasxHrN54/0HpFis0vxipzqyC9mLcQJmA+Vmf3cngnFLX0Rydtp1+GZQPbKGeAPlLl4IvrWv7W1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xHoRZxtQL8M056Q0UaUCoTJKmPrv3TjuLdceI5SgjLk=; b=sMZYC6qLfDXniuD1Q/M1w7sOrq7xA0Ia22tevS+ZGSmG8teio0LBPbgbJKBl8e3Shnm6OtRPBgI7fajTKn/OMdQfxw9jumckgBc+yndt+VdqWMkOV6enFlxzeHlSA2vUaLFO9UcQ+Cw126JetQvOIbVzZxhYw8Evz46wPpSZU5RAo+kQ/4ukVwd/SOg/EvEkA8NYPgVqGenDn2Ix/853dQGPdE1vIvE7Y6LEerhFbcUxkRCc9LH0XygIsdVi7pzsZeo+/eggwL7oexyGczctCH9MWVY+gSpkw2053kPWt0lzfJIfEEp74FL0KYz1WLSUXsriIQ4fxK3XytNz8SVuhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xHoRZxtQL8M056Q0UaUCoTJKmPrv3TjuLdceI5SgjLk=; b=B89mipnt+nRV7/rXqAHsWSo4f56RqPyuyoIS3cmOSpvcK4hEUzl4bgslaCASyhGYItsIwbMNsE05omCukoQrS8m++VSXXlpaECiZFwieeBDUGKQORINV/m0evnPJVl9GIyPkWvFwb3Si5ptiGdi7o43+zgXNGZR0FaxWbj4Ov2g= Received: from BYAPR05CA0054.namprd05.prod.outlook.com (2603:10b6:a03:74::31) by CH2PR12MB4070.namprd12.prod.outlook.com (2603:10b6:610:ae::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.17; Tue, 24 Jun 2025 14:16:41 +0000 Received: from SJ1PEPF00001CE6.namprd03.prod.outlook.com (2603:10b6:a03:74:cafe::92) by BYAPR05CA0054.outlook.office365.com (2603:10b6:a03:74::31) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.16 via Frontend Transport; Tue, 24 Jun 2025 14:16:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CE6.mail.protection.outlook.com (10.167.242.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8880.14 via Frontend Transport; Tue, 24 Jun 2025 14:16:41 +0000 Received: from [127.0.1.1] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 24 Jun 2025 09:16:39 -0500 From: Yazen Ghannam Date: Tue, 24 Jun 2025 14:16:17 +0000 Subject: [PATCH v4 22/22] x86/mce: Save and use APEI corrected threshold limit Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250624-wip-mca-updates-v4-22-236dd74f645f@amd.com> References: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> In-Reply-To: <20250624-wip-mca-updates-v4-0-236dd74f645f@amd.com> To: , Tony Luck , "Rafael J. Wysocki" , Len Brown CC: , , , Qiuxu Zhuo , , Yazen Ghannam X-Mailer: b4 0.15-dev-9b767 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE6:EE_|CH2PR12MB4070:EE_ X-MS-Office365-Filtering-Correlation-Id: 55a5964c-e5b3-4ba7-7e43-08ddb329bdb6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|82310400026|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bGNiT205R3pUbnpxZi9tL0c5UlIzZ1ZrK1lDbGFaNFlLV0Uyem5kQkxJczNC?= =?utf-8?B?dmNkTm8wdE04UWRTRnRzWmZjNFVRK2lTS05OYldzMDJaUlh3V1RINzVYTGRk?= =?utf-8?B?ZENVUHZmd1lKc1pUSXM0ajdlc2pmOWhiOVBpZ0t6bkNicmk4ZjVnZ2NaU2wv?= =?utf-8?B?bVNIQmlEVUk3ckJMaGRMbU1pQ1NKUEp3NXpKWjBXOWI4dE1CMGZnZ3hESVo0?= =?utf-8?B?TEdWUjhxcmJGc3RSYmJRWDU4RG5jem1HMDZSMXJJQ2Z3bXBjbHBGR3UwSy9i?= =?utf-8?B?S3FlWDRyZ00vbHYyQmxWQXoxUXVibXFQRzh5OWNwMFB5ZnpQcWhTTXZsM29r?= =?utf-8?B?N1R4UTdmU2JTajdad3FOT1dTUENGalhab0Q1Y3N1eVlHbWlmYk50ZWNLSHBw?= =?utf-8?B?UVN2SWsyRnpuZVVEb0lQTUFRZjRtNWlRVTBVN0Q5VTMyS0FRQi91OW1WUmwy?= =?utf-8?B?amY0cTh3d29VSnViSHpwWDB5SnhTSE93NXZTM3crVG03U2ErYzB3WWRjN2ho?= =?utf-8?B?TS9JSnlhU2pKNmx0eTNYYlhxNCtHNngrRzlXdGtvRkw5L0FEZ0d4V2xpN21m?= =?utf-8?B?V25QUHA5MmRjVVZ5dXVzLy84ZkdFN3J0d1dnd2ZORGQwakRSM3lOeUxwRkZo?= =?utf-8?B?WjRuQXV1dUZoam1oSEhhbTRaMXM1a2pXUmh4VG5wNDAyVG5GNGVONTFKa2Yr?= =?utf-8?B?WDF1QnNsa2dpQ1F5dXZMclYxRW9oekpGMzRiekxCR3FaVkRXNzhmSitFS0lV?= =?utf-8?B?SENsYi94UFphcjJBd1lDQ0tEMmR4a1NFWHNabVlGcmtLNUtib3pIQkxVcHpq?= =?utf-8?B?UjVmUXFJaGtjUEZmUEIwY082RSt2M0NxcjFIV3puOG9HU2VqWDM4THdJR2hu?= =?utf-8?B?cFZxTmpha2t3RGgzVE9OQ0tJTU9TNTB3YzZsZW5RbzN5dDVvUURrNCs5WHRz?= =?utf-8?B?M1FHK2h3bmpWQzF3MG45c0QwQWtEOTMzdlplaGduTDB1Yis4Yk5hT0VjbSt1?= =?utf-8?B?dk9uZ20vQzNYYmtCV2luUXhrVGFtc2ZNZ2dsdENPcG14Q1pEU3ZkWXZnTVBE?= =?utf-8?B?aGcvTERTY2NvbXBXU25weGY5T29BN2xoMzhZb0JaY1dOSGdRdEtQSmdXMnRU?= =?utf-8?B?c3RyRnoyZ2g0YzF5MWhKaEhnUVVzRFJaYnNWZytKU3o4d2tsQlovZ3V5eERN?= =?utf-8?B?TFEyemkvZTQyR1JDV0cyaFBVRHV5WEZ6NmRRNUN3ODJaaXZXUTlSSlZGUFNN?= =?utf-8?B?MnZuc0hsV2xKYkk2Tmd0UjNkVXUyemxZeVBmek5CdTNIVEw5OCtac2dCZ2Zm?= =?utf-8?B?ZkJqUzUvVjRhdzM0RmdjMWovNWQxNDZicTBYSnNwa2xJZm9nZnordGdZaVIz?= =?utf-8?B?NWVzanhXdVFmbXhGYzJtTU9zeWhuVnJrWWtJL2lHY2dnOEJBQmRIYVk0OTdy?= =?utf-8?B?NmRaMjA5N2NUMVFTR3pYQjVwWEdoMVVOdUhVekE5T0w2dkRvNy90NzZ5YURJ?= =?utf-8?B?ZVp3UnhON044VmxRQ2d2ZWxjaXZ3TWJmM0IvNTRWanRVcXFiRDgzRzdEU0s1?= =?utf-8?B?K1FzT1dkK0UxMmRuUVczUkY1U2x4SjJzZ1h3eExlUjQ4Z2grZ2xqUkh2cmtj?= =?utf-8?B?ZHZQVzZ0TjRsLzRraEljd1FqenU5bkFMREZKeUpZQTBPR1Z3dHlNZTFKRlNn?= =?utf-8?B?MXpkSDc2ak80WjBQbnR4THpVTy9haWVOck1CSTVUY0d0MGhyL1NCcVRpaVhp?= =?utf-8?B?MEpreHBIYStxVU10MVExcXNVRUZ4MVhac2J0TlovZDV0em1Ra1dSRk5IeXJ5?= =?utf-8?B?Ry9qOTdHRnc5N2QrTy9PYWpudDV6d29lVVVVWndlMEVrVmZsWGFac2VoenZT?= =?utf-8?B?OXB2N0FTNDRyWkF3R1Z5eXNINTd3RGQ4K3EzNWhZSEY4UlBEeHpKTHRUU3pu?= =?utf-8?B?WmhwbDllYTA4Z2ZMVnU2QUpTaEM3dnZ2Mmk5anY4blJ4RVRWUTJLNFRUQWtN?= =?utf-8?B?eWNZQUZPRDlZWE1mZ245K0dMMXVZWFZ1d3pjM3pWVTZScVRvdWR5WEpIRHJl?= =?utf-8?Q?+YygeN?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(82310400026)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2025 14:16:41.3005 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 55a5964c-e5b3-4ba7-7e43-08ddb329bdb6 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE6.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4070 The MCA threshold limit generally is not something that needs to change during runtime. It is common for a system administrator to decide on a policy for their managed systems. If MCA thresholding is OS-managed, then the threshold limit must be set at every boot. However, many systems allow the user to set a value in their BIOS. And this is reported through an APEI HEST entry even if thresholding is not in FW-First mode. Use this value, if available, to set the OS-managed threshold limit. Users can still override it through sysfs if desired for testing or debug. APEI is parsed after MCE is initialized. So reset the thresholding blocks later to pick up the threshold limit. Signed-off-by: Yazen Ghannam --- Notes: v3->v4: * New in v4. arch/x86/include/asm/mce.h | 6 ++++++ arch/x86/kernel/acpi/apei.c | 2 ++ arch/x86/kernel/cpu/mce/amd.c | 18 ++++++++++++++++-- arch/x86/kernel/cpu/mce/internal.h | 2 ++ arch/x86/kernel/cpu/mce/threshold.c | 13 +++++++++++++ 5 files changed, 39 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/mce.h b/arch/x86/include/asm/mce.h index 7d6588195d56..1cfbfff0be3f 100644 --- a/arch/x86/include/asm/mce.h +++ b/arch/x86/include/asm/mce.h @@ -308,6 +308,12 @@ DECLARE_PER_CPU(struct mce, injectm); /* Disable CMCI/polling for MCA bank claimed by firmware */ extern void mce_disable_bank(int bank); =20 +#ifdef CONFIG_X86_MCE_THRESHOLD +void mce_save_apei_thr_limit(u32 thr_limit); +#else +static inline void mce_save_apei_thr_limit(u32 thr_limit) { } +#endif /* CONFIG_X86_MCE_THRESHOLD */ + /* * Exception handler */ diff --git a/arch/x86/kernel/acpi/apei.c b/arch/x86/kernel/acpi/apei.c index 0916f00a992e..e21419e686eb 100644 --- a/arch/x86/kernel/acpi/apei.c +++ b/arch/x86/kernel/acpi/apei.c @@ -19,6 +19,8 @@ int arch_apei_enable_cmcff(struct acpi_hest_header *hest_= hdr, void *data) if (!cmc->enabled) return 0; =20 + mce_save_apei_thr_limit(cmc->notify.error_threshold_value); + /* * We expect HEST to provide a list of MC banks that report errors * in firmware first mode. Otherwise, return non-zero value to diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c index 85fd9273e90a..9e26b0437dc6 100644 --- a/arch/x86/kernel/cpu/mce/amd.c +++ b/arch/x86/kernel/cpu/mce/amd.c @@ -488,6 +488,18 @@ static void threshold_restart_bank(unsigned int bank, = bool intr_en) } } =20 +/* Try to use the threshold limit reported through APEI. */ +static u16 get_thr_limit(void) +{ + u32 thr_limit =3D mce_get_apei_thr_limit(); + + /* Fallback to old default if APEI limit is not available. */ + if (!thr_limit) + return THRESHOLD_MAX; + + return min(thr_limit, THRESHOLD_MAX); +} + static void mce_threshold_block_init(struct threshold_block *b, int offset) { struct thresh_restart tr =3D { @@ -496,7 +508,7 @@ static void mce_threshold_block_init(struct threshold_b= lock *b, int offset) .lvt_off =3D offset, }; =20 - b->threshold_limit =3D THRESHOLD_MAX; + b->threshold_limit =3D get_thr_limit(); threshold_restart_block(&tr); }; =20 @@ -1079,7 +1091,7 @@ static int allocate_threshold_blocks(unsigned int cpu= , struct threshold_bank *tb b->address =3D address; b->interrupt_enable =3D 0; b->interrupt_capable =3D lvt_interrupt_supported(bank, high); - b->threshold_limit =3D THRESHOLD_MAX; + b->threshold_limit =3D get_thr_limit(); =20 if (b->interrupt_capable) { default_attrs[2] =3D &interrupt_enable.attr; @@ -1090,6 +1102,8 @@ static int allocate_threshold_blocks(unsigned int cpu= , struct threshold_bank *tb =20 list_add(&b->miscj, &tb->miscj); =20 + mce_threshold_block_init(b, (high & MASK_LVTOFF_HI) >> 20); + err =3D kobject_init_and_add(&b->kobj, &threshold_ktype, tb->kobj, get_na= me(cpu, bank, b)); if (err) goto out_free; diff --git a/arch/x86/kernel/cpu/mce/internal.h b/arch/x86/kernel/cpu/mce/i= nternal.h index 09ebcf82df93..df98930a32a5 100644 --- a/arch/x86/kernel/cpu/mce/internal.h +++ b/arch/x86/kernel/cpu/mce/internal.h @@ -67,6 +67,7 @@ void mce_track_storm(struct mce *mce); void mce_inherit_storm(unsigned int bank); bool mce_get_storm_mode(void); void mce_set_storm_mode(bool storm); +u32 mce_get_apei_thr_limit(void); #else static inline void cmci_storm_begin(unsigned int bank) {} static inline void cmci_storm_end(unsigned int bank) {} @@ -74,6 +75,7 @@ static inline void mce_track_storm(struct mce *mce) {} static inline void mce_inherit_storm(unsigned int bank) {} static inline bool mce_get_storm_mode(void) { return false; } static inline void mce_set_storm_mode(bool storm) {} +static inline u32 mce_get_apei_thr_limit(void) { return 0; } #endif =20 /* diff --git a/arch/x86/kernel/cpu/mce/threshold.c b/arch/x86/kernel/cpu/mce/= threshold.c index 45144598ec74..d00d5bf9959d 100644 --- a/arch/x86/kernel/cpu/mce/threshold.c +++ b/arch/x86/kernel/cpu/mce/threshold.c @@ -13,6 +13,19 @@ =20 #include "internal.h" =20 +static u32 mce_apei_thr_limit; + +void mce_save_apei_thr_limit(u32 thr_limit) +{ + mce_apei_thr_limit =3D thr_limit; + pr_info("HEST: Corrected error threshold limit =3D %u\n", thr_limit); +} + +u32 mce_get_apei_thr_limit(void) +{ + return mce_apei_thr_limit; +} + static void default_threshold_interrupt(void) { pr_err("Unexpected threshold interrupt at vector %x\n", --=20 2.49.0