From nobody Wed Oct 8 23:07:09 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B50D26C3AD; Mon, 23 Jun 2025 14:55:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750690527; cv=none; b=eaxZI2CmUZYep+GRh+iPRx4mhY2Kh/TCo4fvafBVfIsC5ul/GrxIOsi44m27ShV5PTi2rQJZ4bPymKP1jhHLHRCa6ggE+aLy6VmE19412Pn8wDtGgcJ7wphmlFeK0rFcM4XSgGQjzlcJ7k6eGkzXvLceQjZ8DJEgo9CI2syHnMk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750690527; c=relaxed/simple; bh=2Djwh9R6hBccpGx1AQ8wwl8i3I/wzz5QSLqhQ76JIXU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WSt+xwY42MYzZtXBDeHPylnMvWCUEbIZZBw35uCo2D7C86Q4EnLnQTdYPCedW9rdoSlAT34GUQxH4YgyUHEEIb6z5YXxi/2LRsOd87oHsE2ww6maD1DHwAnnIounL6iC5lCy1N+Uwq9xtY7qqnHz8z4dZvhUYoV22GKiN8Yq8uk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=OjMJxOfZ; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="OjMJxOfZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750690526; x=1782226526; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=2Djwh9R6hBccpGx1AQ8wwl8i3I/wzz5QSLqhQ76JIXU=; b=OjMJxOfZWG+oxPoypbs+YINAxQj724BJc6OhBFWVqVJxVt7kJepCtnlb kpAHgVw56ocHDTqJUSrTEuqEyf/nQHQ8NC4xgVyoz9J/JtuewtEyDF+MG hgBdCyzq9Jz7hQ/lvs0v5phc0UUx3IostFQihMclSh28+/dYV6j3ZqWGe reV84FQooA0VVujLRAZopnfNF9P72VYXebN5GcQh6WIMEVtFjAcrKhPV0 8/AfsVYx3/uZaitO68zmm/1mGQ3+98uURLUS7wM2Hyb93bOkUiZsfJdUg neZPp/OwQhwyRqBbJUaJcZ/Ozl5t3O9d8K58yX86ZYhPocinqSHqPfCC5 w==; X-CSE-ConnectionGUID: P27U970EQlOMu4NWQalK7A== X-CSE-MsgGUID: Cr5srPa7Sy+xUmOZHTxtfQ== X-IronPort-AV: E=McAfee;i="6800,10657,11473"; a="53042674" X-IronPort-AV: E=Sophos;i="6.16,258,1744095600"; d="scan'208";a="53042674" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2025 07:55:17 -0700 X-CSE-ConnectionGUID: JUZBZciTSkCmzXGLOVTvvA== X-CSE-MsgGUID: g2Qa8/oDRMuN0zRUtIDi7g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,258,1744095600"; d="scan'208";a="155997395" Received: from fdefranc-mobl3.ger.corp.intel.com (HELO fdefranc-mobl3.intel.com) ([10.245.246.11]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2025 07:55:09 -0700 From: "Fabio M. De Francesco" To: linux-cxl@vger.kernel.org Cc: "Rafael J . Wysocki" , Len Brown , Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams , Mahesh J Salgaonkar , Oliver O'Halloran , Bjorn Helgaas , Tony Luck , Borislav Petkov , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org, linux-edac@vger.kernel.org, "Fabio M. De Francesco" , Jonathan Cameron , Qiuxu Zhuo Subject: [PATCH 1/3 v4] ACPI: extlog: Trace CPER Non-standard Section Body Date: Mon, 23 Jun 2025 16:54:18 +0200 Message-ID: <20250623145453.1046660-2-fabio.m.de.francesco@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250623145453.1046660-1-fabio.m.de.francesco@linux.intel.com> References: <20250623145453.1046660-1-fabio.m.de.francesco@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ghes_do_proc() has a catch-all for unknown or unhandled CPER formats (UEFI v2.10 Appendix N 2.3), extlog_print() does not. This gap was noticed by a RAS test that injected CXL protocol errors which were notified to extlog_print() via the IOMCA (I/O Machine Check Architecture) mechanism. Bring parity to the extlog_print() path by including a similar log_non_standard_event(). Cc: Dan Williams Reviewed-by: Dan Williams Reviewed-by: Dave Jiang Reviewed-by: Jonathan Cameron Reviewed-by: Qiuxu Zhuo Signed-off-by: Fabio M. De Francesco --- drivers/acpi/acpi_extlog.c | 6 ++++++ drivers/ras/ras.c | 1 + 2 files changed, 7 insertions(+) diff --git a/drivers/acpi/acpi_extlog.c b/drivers/acpi/acpi_extlog.c index f6b9562779de0..47d11cb5c9120 100644 --- a/drivers/acpi/acpi_extlog.c +++ b/drivers/acpi/acpi_extlog.c @@ -183,6 +183,12 @@ static int extlog_print(struct notifier_block *nb, uns= igned long val, if (gdata->error_data_length >=3D sizeof(*mem)) trace_extlog_mem_event(mem, err_seq, fru_id, fru_text, (u8)gdata->error_severity); + } else { + void *err =3D acpi_hest_get_payload(gdata); + + log_non_standard_event(sec_type, fru_id, fru_text, + gdata->error_severity, err, + gdata->error_data_length); } } =20 diff --git a/drivers/ras/ras.c b/drivers/ras/ras.c index a6e4792a1b2e9..ac0e132ccc3eb 100644 --- a/drivers/ras/ras.c +++ b/drivers/ras/ras.c @@ -51,6 +51,7 @@ void log_non_standard_event(const guid_t *sec_type, const= guid_t *fru_id, { trace_non_standard_event(sec_type, fru_id, fru_text, sev, err, len); } +EXPORT_SYMBOL_GPL(log_non_standard_event); =20 void log_arm_hw_error(struct cper_sec_proc_arm *err) { --=20 2.49.0 From nobody Wed Oct 8 23:07:09 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0585326D4D8; Mon, 23 Jun 2025 14:55:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750690528; cv=none; b=Xr7hIqrHiCyPItIGwM23mdQlTKPtW1oI0kYJISb5I50gWZP41z1cxevPsowBf1tLEXh6qZXI49iz58P8/uuun7Hc8u7KjvI1+6klZ2bhkaykit6UzaP49xXLuQnaSI76JKykQuVqOmXbNs9e0NaJJ+lt9RkSDHCBmJvgUyKJo/I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750690528; c=relaxed/simple; bh=HHCfTsxfKlivffLWK/ZL85WvOOKEHt7JZb85XkOoK/s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JV3LDl4uwu+3yT1H9RdXiAKVjmDHZrsur5aO2XQM8r8IHu7rr5IfNeXBIEYf9Ujb/kTl9CbiL/zUhA/SoT2C1+DZWRHpDYDzgm+116KqmfpsfXkoHIb/j6Y14DC5duoU0AzVQztrOlkoo2fZc37UzCEEPkjMv/C79fZwRoTeEs0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Ag/BNT32; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Ag/BNT32" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750690527; x=1782226527; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=HHCfTsxfKlivffLWK/ZL85WvOOKEHt7JZb85XkOoK/s=; b=Ag/BNT32VzQ23vCVg5GazEaRgVlVH8qGpsSpZrVKaNm7e8NyaCUUdk4C dmONObC85mfp1TzT4zQ0BFAYDvE0A4qVwCZudAwI26ZzVmK/DWmtXMBNq rhfjEa0pZSSltUsGt4er7ntpc6pzbaTNclkAt5NXgaTojYOOHCS0pf7KV 3fKxruUbyZHp6ibRbOVdKvK1y3Un4gDNEtlswFPuVXb5wLgGeagWf3Iih vgKFUqh68MGUIcOgovs/nqY52cMiW4ux/1Wz1KUocU/2Vtza5DNHFFWer 7ccOxEDx7RiPJ7xOD1qBjmTtiprFCcQRoDFYbEG7l9Kk/030mLo/QFkv8 Q==; X-CSE-ConnectionGUID: qzIjRddwTUW67+htZgtoKQ== X-CSE-MsgGUID: nPBvAe7uRJmPKrlogJtgaA== X-IronPort-AV: E=McAfee;i="6800,10657,11473"; a="53042702" X-IronPort-AV: E=Sophos;i="6.16,258,1744095600"; d="scan'208";a="53042702" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2025 07:55:24 -0700 X-CSE-ConnectionGUID: /zZxaYq6S0S//MM1lJT2og== X-CSE-MsgGUID: TcZbs8/7RaOaS2tDCswdbw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,258,1744095600"; d="scan'208";a="155997402" Received: from fdefranc-mobl3.ger.corp.intel.com (HELO fdefranc-mobl3.intel.com) ([10.245.246.11]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2025 07:55:17 -0700 From: "Fabio M. De Francesco" To: linux-cxl@vger.kernel.org Cc: "Rafael J . Wysocki" , Len Brown , Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams , Mahesh J Salgaonkar , Oliver O'Halloran , Bjorn Helgaas , Tony Luck , Borislav Petkov , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org, linux-edac@vger.kernel.org, "Fabio M. De Francesco" Subject: [PATCH 2/3 v4] ACPI: extlog: Trace CPER PCI Express Error Section Date: Mon, 23 Jun 2025 16:54:19 +0200 Message-ID: <20250623145453.1046660-3-fabio.m.de.francesco@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250623145453.1046660-1-fabio.m.de.francesco@linux.intel.com> References: <20250623145453.1046660-1-fabio.m.de.francesco@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" I/O Machine Check Architecture events may signal failing PCIe components or links. The AER event contains details on what was happening on the wire when the error was signaled. Trace the CPER PCIe Error section (UEFI v2.10, Appendix N.2.7) reported by the I/O MCA. Cc: Dan Williams Reviewed-by: Dave Jiang Signed-off-by: Fabio M. De Francesco Reviewed-by: Jonathan Cameron --- drivers/acpi/Kconfig | 1 + drivers/acpi/acpi_extlog.c | 32 ++++++++++++++++++++++++++++++++ drivers/pci/pcie/aer.c | 2 +- 3 files changed, 34 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig index 7bc40c2735ac0..2bbd9e4868ad7 100644 --- a/drivers/acpi/Kconfig +++ b/drivers/acpi/Kconfig @@ -493,6 +493,7 @@ config ACPI_EXTLOG tristate "Extended Error Log support" depends on X86_MCE && X86_LOCAL_APIC && EDAC select UEFI_CPER + select ACPI_APEI_PCIEAER help Certain usages such as Predictive Failure Analysis (PFA) require more information about the error than what can be described in diff --git a/drivers/acpi/acpi_extlog.c b/drivers/acpi/acpi_extlog.c index 47d11cb5c9120..cefe8d2d8affc 100644 --- a/drivers/acpi/acpi_extlog.c +++ b/drivers/acpi/acpi_extlog.c @@ -132,6 +132,34 @@ static int print_extlog_rcd(const char *pfx, return 1; } =20 +static void extlog_print_pcie(struct cper_sec_pcie *pcie_err, + int severity) +{ + struct aer_capability_regs *aer; + struct pci_dev *pdev; + unsigned int devfn; + unsigned int bus; + int aer_severity; + int domain; + + if (!(pcie_err->validation_bits & CPER_PCIE_VALID_DEVICE_ID || + pcie_err->validation_bits & CPER_PCIE_VALID_AER_INFO)) + return; + + aer_severity =3D cper_severity_to_aer(severity); + aer =3D (struct aer_capability_regs *)pcie_err->aer_info; + domain =3D pcie_err->device_id.segment; + bus =3D pcie_err->device_id.bus; + devfn =3D PCI_DEVFN(pcie_err->device_id.device, + pcie_err->device_id.function); + pdev =3D pci_get_domain_bus_and_slot(domain, bus, devfn); + if (!pdev) + return; + + pci_print_aer(pdev, aer_severity, aer); + pci_dev_put(pdev); +} + static int extlog_print(struct notifier_block *nb, unsigned long val, void *data) { @@ -183,6 +211,10 @@ static int extlog_print(struct notifier_block *nb, uns= igned long val, if (gdata->error_data_length >=3D sizeof(*mem)) trace_extlog_mem_event(mem, err_seq, fru_id, fru_text, (u8)gdata->error_severity); + } else if (guid_equal(sec_type, &CPER_SEC_PCIE)) { + struct cper_sec_pcie *pcie_err =3D acpi_hest_get_payload(gdata); + + extlog_print_pcie(pcie_err, gdata->error_severity); } else { void *err =3D acpi_hest_get_payload(gdata); =20 diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index 70ac661883672..f019d12b89662 100644 --- a/drivers/pci/pcie/aer.c +++ b/drivers/pci/pcie/aer.c @@ -940,7 +940,7 @@ void pci_print_aer(struct pci_dev *dev, int aer_severit= y, pcie_print_tlp_log(dev, &aer->header_log, info.level, dev_fmt(" ")); } -EXPORT_SYMBOL_NS_GPL(pci_print_aer, "CXL"); +EXPORT_SYMBOL_GPL(pci_print_aer); =20 /** * add_error_device - list device to be handled --=20 2.49.0 From nobody Wed Oct 8 23:07:09 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C08A6267700; Mon, 23 Jun 2025 14:55:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750690534; cv=none; b=bVh1MyttiKooMOGEIcG3kLmk5/pW9lasEDD5az4nU9QLWsbuV+x0Raew92IAJXbesnhOmYEog8FNDUcfAeS6+gbEMkLxTjbAZEn7IAvDhp3Nta3u/hiAQs/9RmSPwvz67x12xfh36hm3Il6vG6nknl6aZpVXWWIAqmg1UYmamik= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750690534; c=relaxed/simple; bh=gszoEZ/bHkrFTTc3IzYuM4m4Ycm6E1VSniTVLUWbC0I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HSTUXZ4uhhUZwWwV6imj2Ng/PkS4t015f/tzaxJUq5U4jFSs9WXDEjXo3qTLhzDC3EUKZWDxc4RuQGZE1AIw+Y8WBjOIb4ava92C6ebZl/Uw6hecojAgz7T/ujx2eHdsnU7KWFNQPEKPJUPLHr/BSmYD6px6ZPuG07TmHmnelmM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=SozZaton; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="SozZaton" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750690533; x=1782226533; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=gszoEZ/bHkrFTTc3IzYuM4m4Ycm6E1VSniTVLUWbC0I=; b=SozZatonz5IC6KTnNz1eYoxlSq99K+gs5Ex36Iiv0a9HrYbaH4KGvult Dc12MhB862G49BES/63yPnjSWenrZWfvYGXzmAV1jIENRwX3u4GK+seAQ QuB+tMGt3tgKgE6oJJ/qLbLGbhMLN8/+BYDe/crAsjB1uqFIU4Tm3Wzko mvlQ59fszYmGDZBJJljBjBQPzZnPmWdt2kyeGJohhMgpI+hyaMghWsFjn heuUPvtsnPf273wfn4Uch4erPoe5KUBkBj45tuPsH7ciBldLdrEeAp6uE BeEIQj9a0GS1Tg9w//yWsI6GQIXmV4DqX9wQCe4Loy8YozylMYNp++8Hp g==; X-CSE-ConnectionGUID: nLhdkNukQN+y+kSFxR/KOg== X-CSE-MsgGUID: LYqF57++TFq5jGeNPXfMhw== X-IronPort-AV: E=McAfee;i="6800,10657,11473"; a="53042732" X-IronPort-AV: E=Sophos;i="6.16,258,1744095600"; d="scan'208";a="53042732" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2025 07:55:32 -0700 X-CSE-ConnectionGUID: IDXBrUhASwOrAxLiN9UO2g== X-CSE-MsgGUID: i9GOdjm+QLG4QDGi+dI36A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,258,1744095600"; d="scan'208";a="155997410" Received: from fdefranc-mobl3.ger.corp.intel.com (HELO fdefranc-mobl3.intel.com) ([10.245.246.11]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2025 07:55:24 -0700 From: "Fabio M. De Francesco" To: linux-cxl@vger.kernel.org Cc: "Rafael J . Wysocki" , Len Brown , Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams , Mahesh J Salgaonkar , Oliver O'Halloran , Bjorn Helgaas , Tony Luck , Borislav Petkov , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org, linux-edac@vger.kernel.org, "Fabio M. De Francesco" , Kuppuswamy Sathyanarayanan Subject: [PATCH 3/3 v4] ACPI: extlog: Trace CPER CXL Protocol Error Section Date: Mon, 23 Jun 2025 16:54:20 +0200 Message-ID: <20250623145453.1046660-4-fabio.m.de.francesco@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250623145453.1046660-1-fabio.m.de.francesco@linux.intel.com> References: <20250623145453.1046660-1-fabio.m.de.francesco@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When Firmware First is enabled, BIOS handles errors first and then it makes them available to the kernel via the Common Platform Error Record (CPER) sections (UEFI 2.10 Appendix N). Linux parses the CPER sections via one of two similar paths, either ELOG or GHES. The errors managed by ELOG are signaled to the BIOS by the I/O Machine Check Architecture (I/O MCA). Currently, ELOG and GHES show some inconsistencies in how they report to userspace via trace events. Therefore, make the two mentioned paths act similarly by tracing the CPER CXL Protocol Error Section (UEFI v2.10, Appendix N.2.13). Cc: Dan Williams Reviewed-by: Kuppuswamy Sathyanarayanan Signed-off-by: Fabio M. De Francesco --- drivers/acpi/acpi_extlog.c | 62 ++++++++++++++++++++++++++++++++++++++ drivers/cxl/core/ras.c | 6 ++++ include/cxl/event.h | 2 ++ 3 files changed, 70 insertions(+) diff --git a/drivers/acpi/acpi_extlog.c b/drivers/acpi/acpi_extlog.c index cefe8d2d8affc..9a37b08aacfea 100644 --- a/drivers/acpi/acpi_extlog.c +++ b/drivers/acpi/acpi_extlog.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -160,6 +161,60 @@ static void extlog_print_pcie(struct cper_sec_pcie *pc= ie_err, pci_dev_put(pdev); } =20 +static void +extlog_cxl_cper_handle_prot_err(struct cxl_cper_sec_prot_err *prot_err, + int severity) +{ + struct cxl_cper_prot_err_work_data wd; + u8 *dvsec_start, *cap_start; + + if (!(prot_err->valid_bits & PROT_ERR_VALID_AGENT_ADDRESS)) { + pr_warn_ratelimited("CXL CPER invalid agent type\n"); + return; + } + + if (!(prot_err->valid_bits & PROT_ERR_VALID_ERROR_LOG)) { + pr_warn_ratelimited("CXL CPER invalid protocol error log\n"); + return; + } + + if (prot_err->err_len !=3D sizeof(struct cxl_ras_capability_regs)) { + pr_warn_ratelimited("CXL CPER invalid RAS Cap size (%u)\n", + prot_err->err_len); + return; + } + + if ((prot_err->agent_type =3D=3D RCD || prot_err->agent_type =3D=3D DEVIC= E || + prot_err->agent_type =3D=3D LD || prot_err->agent_type =3D=3D FMLD) = && + !(prot_err->valid_bits & PROT_ERR_VALID_SERIAL_NUMBER)) + pr_warn_ratelimited(FW_WARN + "CXL CPER no device serial number\n"); + + switch (prot_err->agent_type) { + case RCD: + case DEVICE: + case LD: + case FMLD: + case RP: + case DSP: + case USP: + memcpy(&wd.prot_err, prot_err, sizeof(wd.prot_err)); + + dvsec_start =3D (u8 *)(prot_err + 1); + cap_start =3D dvsec_start + prot_err->dvsec_len; + + memcpy(&wd.ras_cap, cap_start, sizeof(wd.ras_cap)); + wd.severity =3D cper_severity_to_aer(severity); + break; + default: + pr_err_ratelimited("CXL CPER reserved agent type: %d\n", + prot_err->agent_type); + return; + } + + cxl_cper_ras_handle_prot_err(&wd); +} + static int extlog_print(struct notifier_block *nb, unsigned long val, void *data) { @@ -211,6 +266,12 @@ static int extlog_print(struct notifier_block *nb, uns= igned long val, if (gdata->error_data_length >=3D sizeof(*mem)) trace_extlog_mem_event(mem, err_seq, fru_id, fru_text, (u8)gdata->error_severity); + } else if (guid_equal(sec_type, &CPER_SEC_CXL_PROT_ERR)) { + struct cxl_cper_sec_prot_err *prot_err =3D + acpi_hest_get_payload(gdata); + + extlog_cxl_cper_handle_prot_err(prot_err, + gdata->error_severity); } else if (guid_equal(sec_type, &CPER_SEC_PCIE)) { struct cper_sec_pcie *pcie_err =3D acpi_hest_get_payload(gdata); =20 @@ -378,3 +439,4 @@ module_exit(extlog_exit); MODULE_AUTHOR("Chen, Gong "); MODULE_DESCRIPTION("Extended MCA Error Log Driver"); MODULE_LICENSE("GPL"); +MODULE_IMPORT_NS("CXL"); diff --git a/drivers/cxl/core/ras.c b/drivers/cxl/core/ras.c index 485a831695c70..56db290c88d35 100644 --- a/drivers/cxl/core/ras.c +++ b/drivers/cxl/core/ras.c @@ -98,6 +98,12 @@ static void cxl_cper_handle_prot_err(struct cxl_cper_pro= t_err_work_data *data) cxl_cper_trace_uncorr_prot_err(pdev, data->ras_cap); } =20 +void cxl_cper_ras_handle_prot_err(struct cxl_cper_prot_err_work_data *wd) +{ + cxl_cper_handle_prot_err(wd); +} +EXPORT_SYMBOL_NS_GPL(cxl_cper_ras_handle_prot_err, "CXL"); + static void cxl_cper_prot_err_work_fn(struct work_struct *work) { struct cxl_cper_prot_err_work_data wd; diff --git a/include/cxl/event.h b/include/cxl/event.h index f9ae1796da85f..aef906e260330 100644 --- a/include/cxl/event.h +++ b/include/cxl/event.h @@ -285,4 +285,6 @@ static inline int cxl_cper_prot_err_kfifo_get(struct cx= l_cper_prot_err_work_data } #endif =20 +void cxl_cper_ras_handle_prot_err(struct cxl_cper_prot_err_work_data *wd); + #endif /* _LINUX_CXL_EVENT_H */ --=20 2.49.0