From nobody Wed Oct 8 23:48:14 2025 Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EF4BA1E0DD8; Mon, 23 Jun 2025 08:14:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750666444; cv=none; b=hX89FkRjblIjUudIawdmWqgHhMoMFpskF2WFr6t0ToNPYuHd/cmOSdW++0mqrnMfrlx2C7HF0ZVPIQudrHWMGd+XMo9G+2TJTbUUuBgMjNPtbxYKgOZAGJERnhw8k40DJIKlsQEfH4JdfLT9Ikj1ApT6Pb91IHpmgbPu01ifHj4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750666444; c=relaxed/simple; bh=p2iip9FvAONLCF03jw7bbQYkAcS11a9IJIFKBJM0pMk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=tg225UuqUupi3MauRUEZrVquoK5wXAE7PJA49P6onX9eIa5TMWcj8cLR2l24ieuWqF+I5Iak88W1QP5jvqlV6dbHuVi+HoSpNJVTiPnOw7oc92hdnaDjnouoNDb6LHUsJYDlgobGW+9gtqGITb9gYSm85/uASZNT2sIrmek5TK0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=loongson.cn; spf=pass smtp.mailfrom=loongson.cn; arc=none smtp.client-ip=114.242.206.163 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=loongson.cn Received: from loongson.cn (unknown [223.64.68.149]) by gateway (Coremail) with SMTP id _____8AxfeHFDFlocX8bAQ--.21078S3; Mon, 23 Jun 2025 16:13:57 +0800 (CST) Received: from localhost.localdomain (unknown [223.64.68.149]) by front1 (Coremail) with SMTP id qMiowMBx2xrADFloFg0nAQ--.33680S2; Mon, 23 Jun 2025 16:13:55 +0800 (CST) From: Huacai Chen To: Greg Kroah-Hartman , Sasha Levin , Huacai Chen Cc: Xuerui Wang , stable@vger.kernel.org, ziyao@disroot.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, Huacai Chen Subject: [PATCH for 6.1/6.6] platform/loongarch: laptop: Add backlight power control support Date: Mon, 23 Jun 2025 16:13:37 +0800 Message-ID: <20250623081337.3767935-1-chenhuacai@loongson.cn> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qMiowMBx2xrADFloFg0nAQ--.33680S2 X-CM-SenderInfo: hfkh0x5xdftxo6or00hjvr0hdfq/ X-Coremail-Antispam: 1Uk129KBj93XoWxXFy5Ww4DAF4fGFW8CF4kAFc_yoWrArW5p3 9I9wsxtFW8trW0qF4qqF4rWr15Zw43Ary7Xay7A3Z2k34DtryF9ry8Jas0qF47ArW8CF1Y vrWkAF4rGF4UC3gCm3ZEXasCq-sJn29KB7ZKAUJUUUU7529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUBYb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVWxJr0_GcWl84ACjcxK6I8E87Iv6xkF7I0E14v2 6F4UJVW0owAaw2AFwI0_Jrv_JF1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0c Ia020Ex4CE44I27wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_JF0_ Jw1lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwI xGrwCY1x0262kKe7AKxVWUAVWUtwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWU JVW8JwCFI7km07C267AKxVWUXVWUAwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4 vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IY x2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26c xKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAF wI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU8HKZJUUUUU== Content-Type: text/plain; charset="utf-8" From: Yao Zi commit 53c762b47f726e4079a1f06f684bce2fc0d56fba upstream. loongson_laptop_turn_{on,off}_backlight() are designed for controlling the power of the backlight, but they aren't really used in the driver previously. Unify these two functions since they only differ in arguments passed to ACPI method, and wire up loongson_laptop_backlight_update() to update the power state of the backlight as well. Tested on the TongFang L860-T2 Loongson-3A5000 laptop. Cc: stable@vger.kernel.org Fixes: 6246ed09111f ("LoongArch: Add ACPI-based generic laptop driver") Signed-off-by: Yao Zi Signed-off-by: Huacai Chen --- drivers/platform/loongarch/loongson-laptop.c | 73 ++++++++++---------- 1 file changed, 37 insertions(+), 36 deletions(-) diff --git a/drivers/platform/loongarch/loongson-laptop.c b/drivers/platfor= m/loongarch/loongson-laptop.c index ba9a90818c92..9ba4c06252b6 100644 --- a/drivers/platform/loongarch/loongson-laptop.c +++ b/drivers/platform/loongarch/loongson-laptop.c @@ -56,8 +56,7 @@ static struct input_dev *generic_inputdev; static acpi_handle hotkey_handle; static struct key_entry hotkey_keycode_map[GENERIC_HOTKEY_MAP_MAX]; =20 -int loongson_laptop_turn_on_backlight(void); -int loongson_laptop_turn_off_backlight(void); +static bool bl_powered; static int loongson_laptop_backlight_update(struct backlight_device *bd); =20 /* 2. ACPI Helpers and device model */ @@ -354,16 +353,42 @@ static int ec_backlight_level(u8 level) return level; } =20 +static int ec_backlight_set_power(bool state) +{ + int status; + union acpi_object arg0 =3D { ACPI_TYPE_INTEGER }; + struct acpi_object_list args =3D { 1, &arg0 }; + + arg0.integer.value =3D state; + status =3D acpi_evaluate_object(NULL, "\\BLSW", &args, NULL); + if (ACPI_FAILURE(status)) { + pr_info("Loongson lvds error: 0x%x\n", status); + return -EIO; + } + + return 0; +} + static int loongson_laptop_backlight_update(struct backlight_device *bd) { - int lvl =3D ec_backlight_level(bd->props.brightness); + bool target_powered =3D !backlight_is_blank(bd); + int ret =3D 0, lvl =3D ec_backlight_level(bd->props.brightness); =20 if (lvl < 0) return -EIO; + if (ec_set_brightness(lvl)) return -EIO; =20 - return 0; + if (target_powered !=3D bl_powered) { + ret =3D ec_backlight_set_power(target_powered); + if (ret < 0) + return ret; + + bl_powered =3D target_powered; + } + + return ret; } =20 static int loongson_laptop_get_brightness(struct backlight_device *bd) @@ -384,7 +409,7 @@ static const struct backlight_ops backlight_laptop_ops = =3D { =20 static int laptop_backlight_register(void) { - int status =3D 0; + int status =3D 0, ret; struct backlight_properties props; =20 memset(&props, 0, sizeof(props)); @@ -392,44 +417,20 @@ static int laptop_backlight_register(void) if (!acpi_evalf(hotkey_handle, &status, "ECLL", "d")) return -EIO; =20 + ret =3D ec_backlight_set_power(true); + if (ret) + return ret; + + bl_powered =3D true; + props.max_brightness =3D status; props.brightness =3D ec_get_brightness(); + props.power =3D FB_BLANK_UNBLANK; props.type =3D BACKLIGHT_PLATFORM; =20 backlight_device_register("loongson_laptop", NULL, NULL, &backlight_laptop_ops, &props); =20 - return 0; -} - -int loongson_laptop_turn_on_backlight(void) -{ - int status; - union acpi_object arg0 =3D { ACPI_TYPE_INTEGER }; - struct acpi_object_list args =3D { 1, &arg0 }; - - arg0.integer.value =3D 1; - status =3D acpi_evaluate_object(NULL, "\\BLSW", &args, NULL); - if (ACPI_FAILURE(status)) { - pr_info("Loongson lvds error: 0x%x\n", status); - return -ENODEV; - } - - return 0; -} - -int loongson_laptop_turn_off_backlight(void) -{ - int status; - union acpi_object arg0 =3D { ACPI_TYPE_INTEGER }; - struct acpi_object_list args =3D { 1, &arg0 }; - - arg0.integer.value =3D 0; - status =3D acpi_evaluate_object(NULL, "\\BLSW", &args, NULL); - if (ACPI_FAILURE(status)) { - pr_info("Loongson lvds error: 0x%x\n", status); - return -ENODEV; - } =20 return 0; } --=20 2.47.1