From nobody Wed Oct 8 22:18:59 2025 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C4A42D3A6C; Mon, 23 Jun 2025 18:01:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750701717; cv=pass; b=gwV0WW0KlGJAHxrCFhyXD4TzoWV74KFWVH3lsN9xl2tigypQXOgnkPL0XPK50yM78/Gtr8gJwb4dLaZShy7qCDioFds3O+oR0zeeE6fDPYVroCntAaNvRuo8grICB7/miAypQhW+YouKN5luu8QhT/JrYFGyHpZ+LSSbUlO9qm8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750701717; c=relaxed/simple; bh=2qwMN6lN8/x/WoX6+eNWfhRLRYqxNp8PNR13U7u3pig=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oLlS/YxeIqS7bY+FbYXmD5nJ1DR8VI9jHY6KDJFqfXMcP/KZaUo739Cuorhbx8bteNA3rL1FLJvmnfNVeOX0fmrE1u47xV5OCHmAGafo5rrZt3t8CaXPX7aeDHfkgu+A6thRyu00k/6fGMKgSAYQG+JLwNDdSIlA4mx2eRPyBj0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b=MSidSuKt; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b="MSidSuKt" ARC-Seal: i=1; a=rsa-sha256; t=1750701687; cv=none; d=zohomail.com; s=zohoarc; b=MV65MM+NemfThrZ1zziW7nNgJkmDuDZCb7xdjOQ7VNx94EI3NtklO4ot/1LVp1gTF9LeF0n3wJ1GS/WRQJheUAJ0RUnHnYhwAx10CabFsc5x32gtI+WopqE7VRF9uuHSlwx1carunw9l6oMsShEhLkKQb7V/z76JXb4Ze/B4h58= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750701687; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=5FpfJ0CqUASp3pNcpfXNd9kKLY1o6Cwk8Nt966cf4OM=; b=Gf5V1zqiBrSni9hT3uaTKxKVRPBC2r51vATVJwxwtvqteLXMnuVDb2j1H01VMUEdRmTohZgsuoB4dClkiQhvAXdhZ8rH2ZGwI1a/LCbnRQeuTSpqJuNsKlyaw0dKbJPtQwWuF/sNMhLHBQgE6IkPa0bL4UYhP5E6+KUNU6H3hbk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=daniel.almeida@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1750701687; s=zohomail; d=collabora.com; i=daniel.almeida@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=5FpfJ0CqUASp3pNcpfXNd9kKLY1o6Cwk8Nt966cf4OM=; b=MSidSuKtm3QMOBrXZ2nOY/UBlclyqhE+0ItNCuf1QyujyLnSB1194dp/be+icCZy 3GzEWW6zFH0pfHhFjOpQ/9TRc3pW2vR6gb6B78113QiUtUoATJJiwEyRjzvXc1/d92T 9uAgmVAFZeiho+cL7Sw1uHHfTINy4baffrYZ7Hms= Received: by mx.zohomail.com with SMTPS id 1750701683906348.3665812969841; Mon, 23 Jun 2025 11:01:23 -0700 (PDT) From: Daniel Almeida Date: Mon, 23 Jun 2025 15:00:58 -0300 Subject: [PATCH v10 1/4] rust: io: add resource abstraction Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250623-topics-tyr-platform_iomem-v10-1-ed860a562940@collabora.com> References: <20250623-topics-tyr-platform_iomem-v10-0-ed860a562940@collabora.com> In-Reply-To: <20250623-topics-tyr-platform_iomem-v10-0-ed860a562940@collabora.com> To: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Greg Kroah-Hartman , "Rafael J. Wysocki" , Andrew Morton , Andy Shevchenko , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Bjorn Helgaas , Mika Westerberg , Ying Huang , Benno Lossin Cc: linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Fiona Behrens , Daniel Almeida X-Mailer: b4 0.14.2 X-ZohoMailClient: External In preparation for ioremap support, add a Rust abstraction for struct resource. A future commit will introduce the Rust API to ioremap a resource from a platform device. The current abstraction, therefore, adds only the minimum API needed to get that done. Co-developed-by: Fiona Behrens Signed-off-by: Fiona Behrens Signed-off-by: Daniel Almeida --- rust/bindings/bindings_helper.h | 1 + rust/helpers/io.c | 36 +++++++ rust/kernel/io.rs | 4 + rust/kernel/io/resource.rs | 222 ++++++++++++++++++++++++++++++++++++= ++++ 4 files changed, 263 insertions(+) diff --git a/rust/bindings/bindings_helper.h b/rust/bindings/bindings_helpe= r.h index 8cbb660e2ec218021d16e6e0144acf6f4d7cca13..38992cb4b2fc33c51c6894cf2a0= b8a1366c338a3 100644 --- a/rust/bindings/bindings_helper.h +++ b/rust/bindings/bindings_helper.h @@ -52,6 +52,7 @@ #include #include #include +#include #include #include #include diff --git a/rust/helpers/io.c b/rust/helpers/io.c index 15ea187c5466256effd07efe6f6995a1dd95a967..404776cf6717c8570c7600a2471= 2ce6e4623d3c6 100644 --- a/rust/helpers/io.c +++ b/rust/helpers/io.c @@ -1,6 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 =20 #include +#include =20 void __iomem *rust_helper_ioremap(phys_addr_t offset, size_t size) { @@ -99,3 +100,38 @@ void rust_helper_writeq_relaxed(u64 value, void __iomem= *addr) writeq_relaxed(value, addr); } #endif + +resource_size_t rust_helper_resource_size(struct resource *res) +{ + return resource_size(res); +} + +struct resource *rust_helper_request_mem_region(resource_size_t start, + resource_size_t n, + const char *name) +{ + return request_mem_region(start, n, name); +} + +void rust_helper_release_mem_region(resource_size_t start, resource_size_t= n) +{ + release_mem_region(start, n); +} + +struct resource *rust_helper_request_region(resource_size_t start, + resource_size_t n, const char *name) +{ + return request_region(start, n, name); +} + +struct resource *rust_helper_request_muxed_region(resource_size_t start, + resource_size_t n, + const char *name) +{ + return request_muxed_region(start, n, name); +} + +void rust_helper_release_region(resource_size_t start, resource_size_t n) +{ + release_region(start, n); +} diff --git a/rust/kernel/io.rs b/rust/kernel/io.rs index 72d80a6f131e3e826ecd9d2c3bcf54e89aa60cc3..7b70d5b5477e57d6d0f24bcd26b= d8b0071721bc0 100644 --- a/rust/kernel/io.rs +++ b/rust/kernel/io.rs @@ -7,6 +7,10 @@ use crate::error::{code::EINVAL, Result}; use crate::{bindings, build_assert}; =20 +pub mod resource; + +pub use resource::Resource; + /// Raw representation of an MMIO region. /// /// By itself, the existence of an instance of this structure does not pro= vide any guarantees that diff --git a/rust/kernel/io/resource.rs b/rust/kernel/io/resource.rs new file mode 100644 index 0000000000000000000000000000000000000000..611eca8cc693d83bccc2c384db2= ff22d11e7ac46 --- /dev/null +++ b/rust/kernel/io/resource.rs @@ -0,0 +1,222 @@ +// SPDX-License-Identifier: GPL-2.0 + +//! Abstractions for system resources. +//! +//! C header: [`include/linux/ioport.h`](srctree/include/linux/ioport.h) + +use core::ops::Deref; +use core::ptr::NonNull; + +use crate::str::CStr; +use crate::types::Opaque; + +#[cfg(CONFIG_HAS_IOPORT)] +/// Returns a reference to the global `ioport_resource` variable. +pub fn ioport_resource() -> &'static Resource { + // SAFETY: `bindings::ioport_resoure` has global lifetime and is of ty= pe Resource. + unsafe { Resource::as_ref(&raw mut bindings::ioport_resource) } +} + +#[cfg(CONFIG_HAS_IOMEM)] +/// Returns a reference to the global `iomem_resource` variable. +pub fn iomem_resource() -> &'static Resource { + // SAFETY: `bindings::iomem_resoure` has global lifetime and is of typ= e Resource. + unsafe { Resource::as_ref(&raw mut bindings::iomem_resource) } +} + +/// Resource Size type. +/// +/// This is a type alias to `u64` depending on the config option +/// `CONFIG_PHYS_ADDR_T_64BIT`. +#[cfg(CONFIG_PHYS_ADDR_T_64BIT)] +pub type ResourceSize =3D u64; + +/// Resource Size type. +/// +/// This is a type alias to `u32` depending on the config option +/// `CONFIG_PHYS_ADDR_T_64BIT`. +#[cfg(not(CONFIG_PHYS_ADDR_T_64BIT))] +pub type ResourceSize =3D u32; + +/// A region allocated from a parent [`Resource`]. +/// +/// # Invariants +/// +/// - `self.0` points to a valid `bindings::resource` that was obtained th= rough +/// `bindings::__request_region`. +pub struct Region(NonNull); + +impl Deref for Region { + type Target =3D Resource; + + fn deref(&self) -> &Self::Target { + // SAFETY: Safe as per the invariant of `Region` + unsafe { Resource::as_ref(self.0.as_ptr()) } + } +} + +impl Drop for Region { + fn drop(&mut self) { + // SAFETY: Safe as per the invariant of `Region` + let res =3D unsafe { Resource::as_ref(self.0.as_ptr()) }; + let flags =3D res.flags(); + + let release_fn =3D if flags.contains(flags::IORESOURCE_MEM) { + bindings::release_mem_region + } else { + bindings::release_region + }; + + // SAFETY: Safe as per the invariant of `Region` + unsafe { release_fn(res.start(), res.size()) }; + } +} + +// SAFETY: `Region` only holds a pointer to a C `struct resource`, which i= s safe to be used from +// any thread. +unsafe impl Send for Region {} + +// SAFETY: `Region` only holds a pointer to a C `struct resource`, referen= ces to which are +// safe to be used from any thread. +unsafe impl Sync for Region {} + +/// A resource abstraction. +/// +/// # Invariants +/// +/// [`Resource`] is a transparent wrapper around a valid `bindings::resour= ce`. +#[repr(transparent)] +pub struct Resource(Opaque); + +impl Resource { + /// Creates a reference to a [`Resource`] from a valid pointer. + /// + /// # Safety + /// + /// The caller must ensure that for the duration of 'a, the pointer wi= ll + /// point at a valid `bindings::resource`. + /// + /// The caller must also ensure that the [`Resource`] is only accessed= via the + /// returned reference for the duration of 'a. + pub(crate) const unsafe fn as_ref<'a>(ptr: *mut bindings::resource) ->= &'a Self { + // SAFETY: Self is a transparent wrapper around `Opaque`. + unsafe { &*ptr.cast() } + } + + /// Requests a resource region. + /// + /// Exclusive access will be given and the region will be marked as bu= sy. + /// Further calls to [`Self::request_region`] will return [`None`] if + /// the region, or a part of it, is already in use. + pub fn request_region( + &self, + start: ResourceSize, + size: ResourceSize, + name: &'static CStr, + flags: Flags, + ) -> Option { + // SAFETY: Safe as per the invariant of `Resource` + let region =3D unsafe { + bindings::__request_region( + self.0.get(), + start, + size, + name.as_char_ptr(), + flags.0 as i32, + ) + }; + + Some(Region(NonNull::new(region)?)) + } + + /// Returns the size of the resource. + pub fn size(&self) -> ResourceSize { + let inner =3D self.0.get(); + // SAFETY: safe as per the invariants of `Resource` + unsafe { bindings::resource_size(inner) } + } + + /// Returns the start address of the resource. + pub fn start(&self) -> u64 { + let inner =3D self.0.get(); + // SAFETY: safe as per the invariants of `Resource` + unsafe { *inner }.start + } + + /// Returns the name of the resource. + pub fn name(&self) -> &'static CStr { + let inner =3D self.0.get(); + // SAFETY: safe as per the invariants of `Resource` + unsafe { CStr::from_char_ptr((*inner).name) } + } + + /// Returns the flags associated with the resource. + pub fn flags(&self) -> Flags { + let inner =3D self.0.get(); + // SAFETY: safe as per the invariants of `Resource` + let flags =3D unsafe { *inner }.flags; + + Flags(flags) + } +} + +// SAFETY: `Resource` only holds a pointer to a C `struct resource`, which= is safe to be used from +// any thead. +unsafe impl Send for Resource {} + +// SAFETY: `Resource` only holds a pointer to a C `struct resource`, refer= ences to which are +// safe to be used from any thead. +unsafe impl Sync for Resource {} + +/// Resource flags as stored in the C `struct resource::flags` field. +/// +/// They can be combined with the operators `|`, `&`, and `!`. +/// +/// Values can be used from the [`flags`] module. +#[derive(Clone, Copy, PartialEq)] +pub struct Flags(usize); + +impl Flags { + /// Check whether `flags` is contained in `self`. + pub fn contains(self, flags: Flags) -> bool { + (self & flags) =3D=3D flags + } +} + +impl core::ops::BitOr for Flags { + type Output =3D Self; + fn bitor(self, rhs: Self) -> Self::Output { + Self(self.0 | rhs.0) + } +} + +impl core::ops::BitAnd for Flags { + type Output =3D Self; + fn bitand(self, rhs: Self) -> Self::Output { + Self(self.0 & rhs.0) + } +} + +impl core::ops::Not for Flags { + type Output =3D Self; + fn not(self) -> Self::Output { + Self(!self.0) + } +} + +/// Resource flags as stored in the `struct resource::flags` field. +pub mod flags { + use super::Flags; + + /// PCI/ISA I/O ports. + pub const IORESOURCE_IO: Flags =3D Flags(bindings::IORESOURCE_IO as us= ize); + + /// Resource is software muxed. + pub const IORESOURCE_MUXED: Flags =3D Flags(bindings::IORESOURCE_MUXED= as usize); + + /// Resource represents a memory region. + pub const IORESOURCE_MEM: Flags =3D Flags(bindings::IORESOURCE_MEM as = usize); + + /// Resource represents a memory region that must be ioremaped using `= ioremap_np`. + pub const IORESOURCE_MEM_NONPOSTED: Flags =3D Flags(bindings::IORESOUR= CE_MEM_NONPOSTED as usize); +} --=20 2.50.0 From nobody Wed Oct 8 22:18:59 2025 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5DC028ECDE; Mon, 23 Jun 2025 18:01:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750701710; cv=pass; b=pz5IrgOXSQwDaGquW7HbTuqrJhk+3wCKnFUXGluoKbb4aPgJdslbXXzoWQETotJIPPpDFvSPYjMgadkJJs2Z0/bRUEfm3QpKlU0NeQOCkH3uo16vPXnXdnIHIu+FY/jfOZtA54ZgcS7GhhiRslHs6dAqgXJMqnjkbJmaKXVXJME= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750701710; c=relaxed/simple; bh=sq3Q0uLG8bGNYrc02jS2SFjriPDRGj4eOUz8WbyIXKE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gdUaaJG/YQy88Bx+/xF+g8ibae2Kwqp0BJBeurz3os25XvS2iFzFWUQa3czCcsYr1MtT10bdmpQ9NAZk2Ck0J60jJZay4zmXKqx8TPRfA3M+HijbQiik7QOSLzI9ApaZybUUa2suX685t8ZKl3H/H02fIfnbszXPoLN9I25TPKg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b=AwI7HGih; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b="AwI7HGih" ARC-Seal: i=1; a=rsa-sha256; t=1750701691; cv=none; d=zohomail.com; s=zohoarc; b=ZJFAN8gqMz3WHD5WWJNUJC/zDsIXyf0yin7sxJ9zMOnXGu7dADPxKwwHeHno5WoBcfHLujbKndcRS7ImzhIfMCWD9m8OtBYX359Ld4DpJVQN+gNnUw/NqEvJi7l4phz7FZq+PGRp5UfLgc5S3CQGavSQ7lgX51oGQ1uAr6RIdBk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750701691; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=v/zklfuAzyTlu9HDCWeDf9Ydv1ELPS8SbfUtRAJHhSs=; b=LhgrdAz6K1xdnIrO4Q1270YnxdalGI51GZq7HqvQp0dL5XQfaooIpHLzyrBQlTWyNaNsX0+pFbIEq98OpzQ9bzLPsZIwJ2LdFSi4j8Rq22W8i5uapujgqDIjO5lPXd8AvzfKNr3eD6jYYKoZ80vaRlUL4wXU6JexgNapjnuWYxk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=daniel.almeida@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1750701691; s=zohomail; d=collabora.com; i=daniel.almeida@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=v/zklfuAzyTlu9HDCWeDf9Ydv1ELPS8SbfUtRAJHhSs=; b=AwI7HGihOcrtk1JagyeL9e+kigp1aTBBS5rF+HPHBzJ1xrxwDkq+xzN+tkD1lcpD 7Zhsych1Bih5dOdKAl7Q3cu5E+R8dRdo3VoTrTKv1DNQWskAnmk0de7wL8iUyY8RYvW S7hXDMuAPQYHMYtEJCCzrznsMF3x+iTUWX7zU8JA= Received: by mx.zohomail.com with SMTPS id 1750701688729856.990313539685; Mon, 23 Jun 2025 11:01:28 -0700 (PDT) From: Daniel Almeida Date: Mon, 23 Jun 2025 15:00:59 -0300 Subject: [PATCH v10 2/4] rust: io: mem: add a generic iomem abstraction Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250623-topics-tyr-platform_iomem-v10-2-ed860a562940@collabora.com> References: <20250623-topics-tyr-platform_iomem-v10-0-ed860a562940@collabora.com> In-Reply-To: <20250623-topics-tyr-platform_iomem-v10-0-ed860a562940@collabora.com> To: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Greg Kroah-Hartman , "Rafael J. Wysocki" , Andrew Morton , Andy Shevchenko , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Bjorn Helgaas , Mika Westerberg , Ying Huang , Benno Lossin Cc: linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Daniel Almeida X-Mailer: b4 0.14.2 X-ZohoMailClient: External Add a generic iomem abstraction to safely read and write ioremapped regions. The reads and writes are done through IoRaw, and are thus checked either at compile-time, if the size of the region is known at that point, or at runtime otherwise. Non-exclusive access to the underlying memory region is made possible to cater to cases where overlapped regions are unavoidable. Signed-off-by: Daniel Almeida --- rust/helpers/io.c | 5 ++ rust/kernel/io.rs | 1 + rust/kernel/io/mem.rs | 142 ++++++++++++++++++++++++++++++++++++++++++++++= ++++ 3 files changed, 148 insertions(+) diff --git a/rust/helpers/io.c b/rust/helpers/io.c index 404776cf6717c8570c7600a24712ce6e4623d3c6..c475913c69e647b1042e8e7d66b= 9148d892947a1 100644 --- a/rust/helpers/io.c +++ b/rust/helpers/io.c @@ -8,6 +8,11 @@ void __iomem *rust_helper_ioremap(phys_addr_t offset, size= _t size) return ioremap(offset, size); } =20 +void __iomem *rust_helper_ioremap_np(phys_addr_t offset, size_t size) +{ + return ioremap_np(offset, size); +} + void rust_helper_iounmap(void __iomem *addr) { iounmap(addr); diff --git a/rust/kernel/io.rs b/rust/kernel/io.rs index 7b70d5b5477e57d6d0f24bcd26bd8b0071721bc0..b7fc759f8b5d3c3ac6f33f5a66e= 9f619c58b7405 100644 --- a/rust/kernel/io.rs +++ b/rust/kernel/io.rs @@ -7,6 +7,7 @@ use crate::error::{code::EINVAL, Result}; use crate::{bindings, build_assert}; =20 +pub mod mem; pub mod resource; =20 pub use resource::Resource; diff --git a/rust/kernel/io/mem.rs b/rust/kernel/io/mem.rs new file mode 100644 index 0000000000000000000000000000000000000000..2bd9cf4c4f1a59f027999a6e9a2= 03dc99ad6c003 --- /dev/null +++ b/rust/kernel/io/mem.rs @@ -0,0 +1,142 @@ +// SPDX-License-Identifier: GPL-2.0 + +//! Generic memory-mapped IO. + +use core::ops::Deref; + +use crate::device::Bound; +use crate::device::Device; +use crate::devres::Devres; +use crate::io; +use crate::io::resource::Region; +use crate::io::resource::Resource; +use crate::io::Io; +use crate::io::IoRaw; +use crate::prelude::*; + +/// An exclusive memory-mapped IO region. +/// +/// # Invariants +/// +/// - [`ExclusiveIoMem`] has exclusive access to the underlying [`IoMem`]. +pub struct ExclusiveIoMem { + /// The region abstraction. This represents exclusive access to the + /// range represented by the underlying `iomem`. + /// + /// It's placed first to ensure that the region is released before it = is + /// unmapped as a result of the drop order. + /// + /// This field is needed for ownership of the region. + _region: Region, + /// The underlying `IoMem` instance. + iomem: IoMem, +} + +impl ExclusiveIoMem { + /// Creates a new `ExclusiveIoMem` instance. + pub(crate) fn ioremap(resource: &Resource) -> Result { + let iomem =3D IoMem::ioremap(resource)?; + + let start =3D resource.start(); + let size =3D resource.size(); + let name =3D resource.name(); + + let region =3D resource + .request_region(start, size, name, io::resource::flags::IORESO= URCE_MEM) + .ok_or(EBUSY)?; + + let iomem =3D ExclusiveIoMem { + iomem, + _region: region, + }; + + Ok(iomem) + } + + pub(crate) fn new(resource: &Resource, device: &Device) -> Resu= lt> { + let iomem =3D Self::ioremap(resource)?; + let devres =3D Devres::new(device, iomem, GFP_KERNEL)?; + + Ok(devres) + } +} + +impl Deref for ExclusiveIoMem { + type Target =3D Io; + + fn deref(&self) -> &Self::Target { + &self.iomem + } +} + +/// A generic memory-mapped IO region. +/// +/// Accesses to the underlying region is checked either at compile time, i= f the +/// region's size is known at that point, or at runtime otherwise. +/// +/// # Invariants +/// +/// [`IoMem`] always holds an [`IoRaw`] instance that holds a valid pointe= r to the +/// start of the I/O memory mapped region. +pub struct IoMem { + io: IoRaw, +} + +impl IoMem { + fn ioremap(resource: &Resource) -> Result { + let size =3D resource.size(); + if size =3D=3D 0 { + return Err(EINVAL); + } + + let res_start =3D resource.start(); + + let addr =3D if resource + .flags() + .contains(io::resource::flags::IORESOURCE_MEM_NONPOSTED) + { + // SAFETY: + // - `res_start` and `size` are read from a presumably valid `= struct resource`. + // - `size` is known not to be zero at this point. + unsafe { bindings::ioremap_np(res_start, size as usize) } + } else { + // SAFETY: + // - `res_start` and `size` are read from a presumably valid `= struct resource`. + // - `size` is known not to be zero at this point. + unsafe { bindings::ioremap(res_start, size as usize) } + }; + + if addr.is_null() { + return Err(ENOMEM); + } + + let io =3D IoRaw::new(addr as usize, size as usize)?; + let io =3D IoMem { io }; + + Ok(io) + } + + /// Creates a new `IoMem` instance. + pub(crate) fn new(resource: &Resource, device: &Device) -> Resu= lt> { + let io =3D Self::ioremap(resource)?; + let devres =3D Devres::new(device, io, GFP_KERNEL)?; + + Ok(devres) + } +} + +impl Drop for IoMem { + fn drop(&mut self) { + // SAFETY: Safe as by the invariant of `Io`. + unsafe { bindings::iounmap(self.io.addr() as *mut core::ffi::c_voi= d) } + } +} + +impl Deref for IoMem { + type Target =3D Io; + + fn deref(&self) -> &Self::Target { + // SAFETY: Safe as by the invariant of `IoMem`. + unsafe { Io::from_raw(&self.io) } + } +} --=20 2.50.0 From nobody Wed Oct 8 22:18:59 2025 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D87F82D3A66; Mon, 23 Jun 2025 18:01:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750701715; cv=pass; b=uQgrSKmNxj9mVgDdQVvHejRabNzBEJLD3MpI71ci7+Z8igo0oWjGBsqrFRWV4eUbozQhzu25WUlfUSwoMVgUkNZvB6SK8oAD0lc4A0uyPCIz3LCA4LLosCur/4s959Tvu5ay4cEUd4GtsDar8JZHWzQ1fngGSPPFWU3+hOvhjdI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750701715; c=relaxed/simple; bh=jD0Bs8pEGYPz7Co3uofmKUKddNMzKnpOUNwkMt5xm9U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PA9Dohf3aicmQsJvlleyDHfc2SUiL29YILW89BQ9hkICVjEVKBDC7zUPYGWsVH0vavryKfKmy+OgoqSGSW/g5SCOy5/cbp6pRt4ecTUbrTid/P2YmeVHlFo9Qz//RVfki7OercFrvUbNZB7cTvQEnfmI/9ch/hKfwjHxqOd+fdE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b=ARPuBqwK; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b="ARPuBqwK" ARC-Seal: i=1; a=rsa-sha256; t=1750701695; cv=none; d=zohomail.com; s=zohoarc; b=iCbDQEXnNosRGbP0xeH85y5jc+bx0dqN7yojPmAU8guMR1lCQVLk7W4KJQTtGKGRCbIlchq5m96sQ4Z+E7gWQPlN7qlbcrE2cshfuyYzed+jQNoEgP4OzQuWDp1ZnF38TNRvxEMpXO99NVLOcRIxiWfiNNQ2JjoE5Qaa/BqSn1I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750701695; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=jXtQ5usej9364YkX/FNJQWmiFrppYRFaFOduw0COy+E=; b=O75osqKpFlXyhx55p9bA92Lmx2PRQHYafUC4sTMRb26Bc2mCz64fnTuzCaK6k97tqc7Uv3laoMr5Xt+Hp5Jcr07bScx8GzreercMyHJmb9utiCPGPDgiNtrI9NIm9k0ezEpE5QnhtzJBhqf9Aj/qnefYAQLEDXhEruhnNymkCek= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=daniel.almeida@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1750701695; s=zohomail; d=collabora.com; i=daniel.almeida@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=jXtQ5usej9364YkX/FNJQWmiFrppYRFaFOduw0COy+E=; b=ARPuBqwKaL1kv2BvRx7u3jqemRHU0i3CqMBHAz9L84PeoZclRCUm1bSSRzF5WFl6 S5XnP3NfFhQIIOC+Y0I+l+idutSIwbggiLYye+HnJLgYaZTo9t6VuCkMe+/FQhogQEM aH+QexbBxGDIYitpCkTj/SBmwymcppWuwPBdxc7I= Received: by mx.zohomail.com with SMTPS id 1750701693614683.6155317146832; Mon, 23 Jun 2025 11:01:33 -0700 (PDT) From: Daniel Almeida Date: Mon, 23 Jun 2025 15:01:00 -0300 Subject: [PATCH v10 3/4] rust: platform: add resource accessors Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250623-topics-tyr-platform_iomem-v10-3-ed860a562940@collabora.com> References: <20250623-topics-tyr-platform_iomem-v10-0-ed860a562940@collabora.com> In-Reply-To: <20250623-topics-tyr-platform_iomem-v10-0-ed860a562940@collabora.com> To: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Greg Kroah-Hartman , "Rafael J. Wysocki" , Andrew Morton , Andy Shevchenko , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Bjorn Helgaas , Mika Westerberg , Ying Huang , Benno Lossin Cc: linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Daniel Almeida X-Mailer: b4 0.14.2 X-ZohoMailClient: External A previous patch has exposed the abstractions struct resource. Now make it possible to retrieve resources from platform devices in Rust using either a name or an index. Signed-off-by: Daniel Almeida --- rust/kernel/platform.rs | 38 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/rust/kernel/platform.rs b/rust/kernel/platform.rs index 5b21fa517e55348582622ec10471918919502959..0eedb8239fec31df7ab64dc68d2= 20c9d965f1f21 100644 --- a/rust/kernel/platform.rs +++ b/rust/kernel/platform.rs @@ -7,6 +7,7 @@ use crate::{ bindings, container_of, device, driver, error::{to_result, Result}, + io::Resource, of, prelude::*, str::CStr, @@ -188,6 +189,43 @@ impl Device { fn as_raw(&self) -> *mut bindings::platform_device { self.0.get() } + + /// Returns the resource at `index`, if any. + pub fn resource_by_index(&self, index: u32) -> Option<&Resource> { + // SAFETY: `self.as_raw()` returns a valid pointer to a `struct pl= atform_device`. + let resource =3D unsafe { + bindings::platform_get_resource(self.as_raw(), bindings::IORES= OURCE_MEM, index) + }; + + if resource.is_null() { + return None; + } + + // SAFETY: `resource` is a valid pointer to a `struct resource` as + // returned by `platform_get_resource`. + Some(unsafe { Resource::as_ref(resource) }) + } + + /// Returns the resource with a given `name`, if any. + pub fn resource_by_name(&self, name: &CStr) -> Option<&Resource> { + // SAFETY: `self.as_raw()` returns a valid pointer to a `struct + // platform_device` and `name` points to a valid C string. + let resource =3D unsafe { + bindings::platform_get_resource_byname( + self.as_raw(), + bindings::IORESOURCE_MEM, + name.as_char_ptr(), + ) + }; + + if resource.is_null() { + return None; + } + + // SAFETY: `resource` is a valid pointer to a `struct resource` as + // returned by `platform_get_resource`. + Some(unsafe { Resource::as_ref(resource) }) + } } =20 // SAFETY: `Device` is a transparent wrapper of a type that doesn't depend= on `Device`'s generic --=20 2.50.0 From nobody Wed Oct 8 22:18:59 2025 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD1912D3A88; Mon, 23 Jun 2025 18:01:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750701718; cv=pass; b=Y1w8ut4rGExk92LH7+kB8PlW+53zqcft22duVhoqBIGN9C0hE/RvavcJ4LDfiBaaAuQ5JFU3M4VjmPwUREQWEkIwaFkHqtIoEmr0DAhMQIA3qaIHroCu8/DlHJfSidDNW2vW5cL4H3eMrCIXoDTjEGEPB92n56HPv3xHyRwwkDY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750701718; c=relaxed/simple; bh=gqe57Gt1/AsaP6Lk5heZxUpWQuZW+wILnzh1U51++LM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=f3cNFzlVnqVbZdcpAM8074tUDx18hHoQ0Y8vIQslEzODN23IroKHGvcgDFkcdhndjFhTuwLSfN2K9Yvav3Uv8U+9lsqrnUj6lZB59OygyUcyTgxBbtmtoD2Qp8eOEoqW1KhU0+SzKpNvNk4azkqsfu/tG9sgcIlTUDCyWgFQVKI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b=RRjlCR/8; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b="RRjlCR/8" ARC-Seal: i=1; a=rsa-sha256; t=1750701701; cv=none; d=zohomail.com; s=zohoarc; b=MDBUR8mBLdfEVJLUYH8B5d7EBXYmhP7VisxJK/KGxbXGkkRZwLlzyCSFil3PZp83KzbQqDD1Xw00SauYwPco5RQK8jJEz/KkFnzD2yspK8ZHV3zb773au1PTjYeW2JRKCYP8G+OXDMvDEEy+cPNAFfzm1cmFnc0DaKeqeKUYGBo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750701701; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=U3Ka0jrgiaMi7VcajGGF4TMYKe+38iCUzYIMv0gB1Jg=; b=PjR483IaUJzQzlGXWo47yHyBZpX88sjQdtAY46Oha/b+9WLQeM5YWB87iHEXKs6rAdmjzSWXP7RFqEcH3zhfKmrCBJTPRNfF6AskGsOhRjFICjSm8C4EyI5oatEGqEEKN5Mzq5T4pBdX4wdEoSi+uFvYkEWjyCzCaFhhQxDBJ3c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=daniel.almeida@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1750701701; s=zohomail; d=collabora.com; i=daniel.almeida@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=U3Ka0jrgiaMi7VcajGGF4TMYKe+38iCUzYIMv0gB1Jg=; b=RRjlCR/8UBAHXkO4S5PG0/5PuvhkozwmF8Pe+I9DbBMtGbzYdDfbiI9JwI1as1jl TjtV1SbTUcqEzYE+ubUYZFzr2QLz6U3fsA4wjhR8DrKLAXLd+AGxYTkJ7aIunYoeiC+ kWOHlujIXDwcpos0nONSWeO5J3jqTczhcppI4RRo= Received: by mx.zohomail.com with SMTPS id 1750701698231550.6081453967741; Mon, 23 Jun 2025 11:01:38 -0700 (PDT) From: Daniel Almeida Date: Mon, 23 Jun 2025 15:01:01 -0300 Subject: [PATCH v10 4/4] rust: platform: allow ioremap of platform resources Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250623-topics-tyr-platform_iomem-v10-4-ed860a562940@collabora.com> References: <20250623-topics-tyr-platform_iomem-v10-0-ed860a562940@collabora.com> In-Reply-To: <20250623-topics-tyr-platform_iomem-v10-0-ed860a562940@collabora.com> To: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Greg Kroah-Hartman , "Rafael J. Wysocki" , Andrew Morton , Andy Shevchenko , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Bjorn Helgaas , Mika Westerberg , Ying Huang , Benno Lossin Cc: linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Daniel Almeida X-Mailer: b4 0.14.2 X-ZohoMailClient: External The preceding patches added support for resources, and for a general IoMem abstraction, but thus far there is no way to access said IoMem from drivers, as its creation is unsafe and depends on a resource that must be acquired from some device first. Now, allow the ioremap of platform resources themselves, thereby making the IoMem available to platform drivers. Signed-off-by: Daniel Almeida --- rust/kernel/platform.rs | 120 ++++++++++++++++++++++++++++++++++++++++++++= +++- 1 file changed, 118 insertions(+), 2 deletions(-) diff --git a/rust/kernel/platform.rs b/rust/kernel/platform.rs index 0eedb8239fec31df7ab64dc68d220c9d965f1f21..5e787cf85f41722837bb34a6620= c92d13d55625b 100644 --- a/rust/kernel/platform.rs +++ b/rust/kernel/platform.rs @@ -5,9 +5,14 @@ //! C header: [`include/linux/platform_device.h`](srctree/include/linux/pl= atform_device.h) =20 use crate::{ - bindings, container_of, device, driver, + bindings, container_of, device, + devres::Devres, + driver, error::{to_result, Result}, - io::Resource, + io::{ + mem::{ExclusiveIoMem, IoMem}, + Resource, + }, of, prelude::*, str::CStr, @@ -228,6 +233,117 @@ pub fn resource_by_name(&self, name: &CStr) -> Option= <&Resource> { } } =20 +impl Device { + /// Maps a platform resource where the size is known at compile time. + /// + /// This uses the + /// [`ioremap()`](https://docs.kernel.org/driver-api/device-io.html#ge= tting-access-to-the-device) + /// C API. + /// + /// # Examples + /// + /// ```no_run + /// # use kernel::{bindings, c_str, platform, of, device::Core}; + /// # struct SampleDriver; + /// + /// impl platform::Driver for SampleDriver { + /// # type IdInfo =3D (); + /// # const OF_ID_TABLE: Option> =3D None; + /// + /// fn probe( + /// pdev: &platform::Device, + /// info: Option<&Self::IdInfo>, + /// ) -> Result>> { + /// let offset =3D 0; // Some offset. + /// + /// // If the size is known at compile time, use [`Self::iomap_r= esource_sized`]. + /// // + /// // No runtime checks will apply when reading and writing. + /// let resource =3D pdev.resource_by_index(0).ok_or(ENODEV)?; + /// let iomem =3D pdev.iomap_resource_sized::<42>(&resource)?; + /// let io =3D iomem.access(pdev.as_ref())?; + /// + /// // Read and write a 32-bit value at `offset`. + /// let data =3D io.read32_relaxed(offset); + /// + /// io.write32_relaxed(data, offset); + /// + /// # Ok(KBox::new(SampleDriver, GFP_KERNEL)?.into()) + /// } + /// } + /// ``` + pub fn iomap_resource_sized( + &self, + resource: &Resource, + ) -> Result>> { + IoMem::new(resource, self.as_ref()) + } + + /// Same as [`Self::iomap_resource_sized`] but with exclusive access t= o the + /// underlying region. + /// + /// This uses the + /// [`ioremap()`](https://docs.kernel.org/driver-api/device-io.html#ge= tting-access-to-the-device) + /// C API. + pub fn iomap_resource_exclusive_sized( + &self, + resource: &Resource, + ) -> Result>> { + ExclusiveIoMem::new(resource, self.as_ref()) + } + + /// Maps a platform resource through `iomap()`. + /// + /// This uses the + /// [`ioremap()`](https://docs.kernel.org/driver-api/device-io.html#ge= tting-access-to-the-device) + /// C API. + /// + /// # Examples + /// + /// ```no_run + /// # use kernel::{bindings, c_str, platform, of, device::Core}; + /// # struct SampleDriver; + /// + /// impl platform::Driver for SampleDriver { + /// # type IdInfo =3D (); + /// # const OF_ID_TABLE: Option> =3D None; + /// + /// fn probe( + /// pdev: &platform::Device, + /// info: Option<&Self::IdInfo>, + /// ) -> Result>> { + /// let offset =3D 0; // Some offset. + /// + /// // Unlike [`Self::iomap_resource_sized`], here the size of t= he memory region + /// // is not known at compile time, so only the `try_read*` and= `try_write*` + /// // family of functions should be used, leading to runtime ch= ecks on every + /// // access. + /// let resource =3D pdev.resource_by_index(0).ok_or(ENODEV)?; + /// let iomem =3D pdev.iomap_resource(&resource)?; + /// let io =3D iomem.access(pdev.as_ref())?; + /// + /// let data =3D io.try_read32_relaxed(offset)?; + /// + /// io.try_write32_relaxed(data, offset)?; + /// + /// # Ok(KBox::new(SampleDriver, GFP_KERNEL)?.into()) + /// } + /// } + /// ``` + pub fn iomap_resource(&self, resource: &Resource) -> Result>> { + self.iomap_resource_sized::<0>(resource) + } + + /// Same as [`Self::iomap_resource`] but with exclusive access to the = underlying + /// region. + pub fn iomap_resource_exclusive( + &self, + resource: &Resource, + ) -> Result>> { + self.iomap_resource_exclusive_sized::<0>(resource) + } +} + // SAFETY: `Device` is a transparent wrapper of a type that doesn't depend= on `Device`'s generic // argument. kernel::impl_device_context_deref!(unsafe { Device }); --=20 2.50.0