From nobody Wed Oct 8 23:46:28 2025 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FD5721FF50; Mon, 23 Jun 2025 21:25:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.69.126.157 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750713946; cv=none; b=Bdpsl4wuygUHJqoLqA7jRDSSiyO1qiDr2IXXN93uTDX//FiLFckPqjPaP3b19h2nQzeCUhookFOMegExaz4LWNNWIpuAGSB9O514YA+JfOOCfTNUURj5duprkCqfiEcQmoolUcWptTivVadOkTpLlCDHGhjzYZEx+udQmQXrEKs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750713946; c=relaxed/simple; bh=K4401D/s9X8trfbLrKrkvgktSNGSmeMc0zrERdDGY3o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=myJQcSBmLdlWe9JpLFFnE5MMiYdOR90oNOPzrTyJwHpbZifxNm3VDZSlpVCVqRhlx4OZ6b+MrMiRulMsOI2B9uiwM6HZ7BxvRKKNsKUQ94N5PdXpBxtkQ8fXgAHJbxb8VCdqBixe9BvoyuDfcMPWQYRabmADwK+skAK1T++jDDw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net; spf=pass smtp.mailfrom=weissschuh.net; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b=Ii9HZmjt; arc=none smtp.client-ip=159.69.126.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b="Ii9HZmjt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1750713942; bh=K4401D/s9X8trfbLrKrkvgktSNGSmeMc0zrERdDGY3o=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Ii9HZmjtJ1vzUHdZiyIfbR4GqgwIynWJh4u6bWLGRCOar7vU6FaeF1iggMqHIxTxT l7hytbqGtMPIhZBLN1oBoQX5Tmrs4d7Ywm2bCEbeqcVK6ik3QkGz3t4dnEr9sguz5h fvdbrooGK5fG3wCFg6ukSbamNvrBkU3h754DPfJI= From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= Date: Mon, 23 Jun 2025 23:25:37 +0200 Subject: [PATCH v3 2/4] tools/nolibc: MIPS: drop manual stack pointer alignment Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250623-nolibc-mips-n32-v3-2-6ae2d89f4259@weissschuh.net> References: <20250623-nolibc-mips-n32-v3-0-6ae2d89f4259@weissschuh.net> In-Reply-To: <20250623-nolibc-mips-n32-v3-0-6ae2d89f4259@weissschuh.net> To: Willy Tarreau , Shuah Khan , Thomas Bogendoerfer , "Maciej W. Rozycki" Cc: Sebastian Andrzej Siewior , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1750713941; l=1367; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=K4401D/s9X8trfbLrKrkvgktSNGSmeMc0zrERdDGY3o=; b=e+vX5aMPOhXOax9UhDwDZCV86w/LuP0z/Zp8WYsdiiuEu6dGlDugQGpSBk3IcpEOZp3x1Nc4L nwEZF3ibA71A4VjAftT13g2pRyRTJRzq/UOmi178qv5CGX01acRv6S3 X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= The stack pointer is already aligned by the kernel to a multiple of 16. All modifications of the register have been removed from the entrypoint, so the manual realignment is unnecessary. Drop the manual alignment. Suggested-by: Maciej W. Rozycki Link: https://lore.kernel.org/lkml/alpine.DEB.2.21.2502161523290.65342@angi= e.orcam.me.uk/ Signed-off-by: Thomas Wei=C3=9Fschuh Tested-by: Sebastian Andrzej Siewior --- tools/include/nolibc/arch-mips.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/include/nolibc/arch-mips.h b/tools/include/nolibc/arch-m= ips.h index 6d023d9f120301b2d6837c923c142ab2cf87ae5a..0776de7574b451aeb34531bc469= 6c7bd9b694268 100644 --- a/tools/include/nolibc/arch-mips.h +++ b/tools/include/nolibc/arch-mips.h @@ -186,8 +186,6 @@ void __attribute__((weak, noreturn)) __nolibc_entrypoin= t __no_stack_protector __ ".set push\n" ".set noreorder\n" "move $a0, $sp\n" /* save stack pointer to $a0, as arg1 of _start= _c */ - "li $t0, -8\n" - "and $sp, $sp, $t0\n" /* $sp must be 8-byte aligned = */ "addiu $sp, $sp, -16\n" /* the callee expects to save a0..a3 there = */ "lui $t9, %hi(_start_c)\n" /* ABI requires current function address in $= t9 */ "ori $t9, %lo(_start_c)\n" --=20 2.50.0