From nobody Thu Oct 9 02:52:20 2025 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 84680288CBF; Fri, 20 Jun 2025 11:11:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750417920; cv=none; b=rwTRH6iHM4aNczs1JoWDaaRvs2Gr/ipjmx+pORtQvCoEtOIDMXIaq9WZJDX66x+1FqW6F/cn/FOWkKMt7S18flpOYXmnKaeW16QvziXMlZj4gJ4Isu4DMCUBLV8oprRbSPTRo+67O2QMv9/RvhTKSzmcfRY+4UST0HHT6fahiS4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750417920; c=relaxed/simple; bh=C3sH3mhSfvedE6q+7+YDcLAOXFJCWeiEUkujc6ssmgU=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=f2R8G9XQNkrqgG/SHHTVzgALAMaU+YZx5nTWWZ03gGvKQISzeQQMhmcM5bzgoW3gIDjcm5V83SuV98pOB++LwaoEmABRHeMKdWQG7LJ7gYfIBvZ8QPeMWaIsTDHHIfkoM9JVGJPkSib5v4rETXKZDc6qo/S0r3F9oWHnlDow8rQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 45776176A; Fri, 20 Jun 2025 04:11:38 -0700 (PDT) Received: from MacBook-Pro.blr.arm.com (MacBook-Pro.blr.arm.com [10.164.18.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 952DD3F673; Fri, 20 Jun 2025 04:11:54 -0700 (PDT) From: Dev Jain To: akpm@linux-foundation.org, shuah@kernel.org Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, anshuman.khandual@arm.com, ryan.roberts@arm.com, lorenzo.stoakes@oracle.com, david@redhat.com, donettom@linux.ibm.com, Dev Jain Subject: [PATCH] selftests/mm: Fix validate_addr helper Date: Fri, 20 Jun 2025 16:41:50 +0530 Message-Id: <20250620111150.50344-1-dev.jain@arm.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" validate_addr() function checks whether the address returned by mmap() lies in the low or high VA space, according to whether a high addr hint was passed or not. The fix commit mentioned below changed the code in such a way that this function will always return failure when passed high_addr =3D=3D 1; addr will be >=3D HIGH_ADDR_MARK always, we will fall down to "if (addr < HIGH_ADDR_MARK)" and return failure. Fix this. Fixes: d1d86ce28d0f ("selftests/mm: virtual_address_range: conform to TAP f= ormat output") Signed-off-by: Dev Jain Acked-by: David Hildenbrand Reviewed-by: Donet Tom --- tools/testing/selftests/mm/virtual_address_range.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/mm/virtual_address_range.c b/tools/tes= ting/selftests/mm/virtual_address_range.c index b380e102b22f..169dbd692bf5 100644 --- a/tools/testing/selftests/mm/virtual_address_range.c +++ b/tools/testing/selftests/mm/virtual_address_range.c @@ -77,8 +77,11 @@ static void validate_addr(char *ptr, int high_addr) { unsigned long addr =3D (unsigned long) ptr; =20 - if (high_addr && addr < HIGH_ADDR_MARK) - ksft_exit_fail_msg("Bad address %lx\n", addr); + if (high_addr) { + if (addr < HIGH_ADDR_MARK) + ksft_exit_fail_msg("Bad address %lx\n", addr); + return; + } =20 if (addr > HIGH_ADDR_MARK) ksft_exit_fail_msg("Bad address %lx\n", addr); --=20 2.30.2