From nobody Thu Oct 9 02:52:22 2025 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2068.outbound.protection.outlook.com [40.107.223.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A366928B50A; Fri, 20 Jun 2025 13:15:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.223.68 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750425313; cv=fail; b=lQkO4w86iDCiaYnqH3okOpldFWiLbP+KnX85lty0picj6QWIptutfohB1J+HUDiwuM1Ozc/wEs5MvAabXcsTNhApyeB+jBnwg89DP6MpijnrOhwqH+e7psa67OmL6WrAi4yYuwtdyGA+xPNKZ/C5axDjG47f4k/FxwwyUdZwM68= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750425313; c=relaxed/simple; bh=rVPkYx4ebNbdu+neFQgvDyUDqWQROh0MbOPfnnr7qX8=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=jGIC72XbkerDonHqfqWOQanqncNkurb9zdgAxUTCHznyu0IDWf1r/fvxsoRyGU8hj5SNrkLw4cQi9zdqy4NqYah2PYoIoR3kIVpUM4jrpTtxQ+G1e3sBNw5a6njHJLDg8PnCA2lKiNc6NH+TRbtMs6A8Xgn8BNOG3ZKDuC+fIFw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=p3HEpmoq; arc=fail smtp.client-ip=40.107.223.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="p3HEpmoq" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RU/0oLX3b8Jxr7j2DCzW+0d5jg+OLZiXbtGlDY5iipIdeMyCgTNrwQoKGyrSSAs8FQDZ8IVL2QT0mKHM1CjRP7wVe2g9p/nGqJViFJp59eM5KAkxEi48RskxvBwJuEpS4sG37xfhWbclNrlKYI0/Lc+ULR0USctFF+6nsopTy9RDGSlPJBH+GoVBoZD5zHzSDS//r1UROIAUA6+d46HRQ8rKgc0mkTRqI0cCJZlx9YcN/4xTj7UED9UOLQw+zYOKiAUXR4/LsBM2FzYb4AfXkS1NMyOuAycuCrQ+xdSK7jWq56CUETKVfzh49p9MDLF+cpJIQAId38W9vDVvAni/Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sxINqXmFm7uHIEYFDX2qSXVcV30MT4vfU6i7tn0CUG4=; b=a+9VtVQt3T5IAkm9yycg8NP1/fn/Q6m5nSPSkFnzlvL2MLxvvWlLKMelBeDmuwpXbparpkffbHTWRhbR2MijJ7Ssy0/KlhXxiisPUedgChm6reXLojMrZdHr5y5ma01MGEm6U4VZl/RpKsrsdACylzsvvNif1NaggidSnEzopZ+hWNA85DswkQTLdgRF+yLVWHAv51MR10LUVvpSQfYR8rxk0q4E4WfUw6TmJzygQLPCCNL2yf52YCHSOKgJ7lufxFaVS4Na9y3PG9RsBeoLn8zOEPT/k5it0RtjloOrTjNP0ZFe/kgAqJYP+ydGSLLwZTNJbIBlLb+I/SH2fIqhtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sxINqXmFm7uHIEYFDX2qSXVcV30MT4vfU6i7tn0CUG4=; b=p3HEpmoqzbHqMZ/WNVNFe1aTj9OV8USeP3u0ctnJmHQOg2zV6I/SavEfzP8Ds3ei663SP5KUXL+OHeFxg1hSJLEZTdl3QzqEWfz1870jf2/cefsZk89fPUAfRAbwFWmX5r44ifoNA+AT9Lq8Z+ESL/fuvESIHexZ4LucHCh/Mv4B8F5mXj3NLdqt0NfiMeG9CsxGZw2avQT2omtfziuS0NUGd203AibjwZkM0DtHrqWPbk5Yc23N2XpSYqT5e1w4FUtnkvH2KDkpmJJNy8rwaAma2BMNeB1slE417WGiAC/jx3BIUQV3PUbOC8hoBIGx50hhw+cjE59K99yIF44hCg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by PH7PR12MB8426.namprd12.prod.outlook.com (2603:10b6:510:241::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.29; Fri, 20 Jun 2025 13:15:09 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::6e37:569f:82ee:3f99]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::6e37:569f:82ee:3f99%4]) with mapi id 15.20.8857.019; Fri, 20 Jun 2025 13:15:09 +0000 From: Alexandre Courbot Date: Fri, 20 Jun 2025 22:14:51 +0900 Subject: [PATCH 1/3] rust: add `num` module with `PowerOfTwo` type Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250620-num-v1-1-7ec3d3fb06c9@nvidia.com> References: <20250620-num-v1-0-7ec3d3fb06c9@nvidia.com> In-Reply-To: <20250620-num-v1-0-7ec3d3fb06c9@nvidia.com> To: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich Cc: linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, nouveau@lists.freedesktop.org, Alexandre Courbot X-Mailer: b4 0.14.2 X-ClientProxiedBy: TYCP286CA0182.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:382::9) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|PH7PR12MB8426:EE_ X-MS-Office365-Filtering-Correlation-Id: 88decf0a-f560-425b-862a-08ddaffc7b9f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|10070799003|1800799024|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TGRGRmxQc050WlRjZmpiWnVGRDd4bEFCbVdQb0dXbXAxa0NBeVhSalhUMHpy?= =?utf-8?B?Ui9TZ0Zxa0pKTXJNZDczQ0FablNDbWFaZzJHdGZrd2xNNEdjY3ZYa0Z0WlJv?= =?utf-8?B?OXNYdm11ZmIzb2hGSmQxbkJjamVpTVMyTVFQd2xWUnZOdmJicEdCQ1pNUVVk?= =?utf-8?B?U1dPMVdqbmt5bDJhcDVoS2hqKzQvLzlsaTZXV1RyYzlnQTdScXdycTBDZ0xk?= =?utf-8?B?S0kzYm8vTE1iZnpxcFVzN2lqRzd5SWl4bFQvY29BeXpKTVFubkp2OXdwLzkr?= =?utf-8?B?eFJnTDFISndJeDhxT0tTamFZRE1GUTZnVFc5V1dIZHBlcTlmNHFIcFZRUmdV?= =?utf-8?B?V3ZSTUtiSzhCZVpleFBTVytYNEoycjVQZ1JUamJ4N1U2Wm1OZktuQVdkaDRa?= =?utf-8?B?WEozTGNEVWE5aEJQUHg2RmdFSWoraE1GUVVWcXlwS3o0emFueUYzQ0FQQUlI?= =?utf-8?B?YjZ3M2VldVdZSHVPbytqYXpLbVgwUy9oOTN0SzFmaVQzWUdpSFhFRVFnbUVT?= =?utf-8?B?VVpXMGNKcm0vZWlpbHZCdU5uOGk2ZXJIeXNJekdGODFlZXlkZjk1cE1SUmt5?= =?utf-8?B?TWVrM3lUNHVzb3BLdU1aQ0xCLzdYWGpLSVYvclBYZjJ2MkVUWjlaUm1sNDFR?= =?utf-8?B?Nm9VRmxRcXNic0NkRkNSdXY3amVDRmJWSlllZ1FNcWFoVktDUW9nN0xjVnBm?= =?utf-8?B?TU1nSi9XWGxtNU4zMTU1S0hMQU1EMVp6RkF3Qmh4ZjFxMUFyaEsxZUh1Y3Rn?= =?utf-8?B?d3YzWWxoL3FoZWI1Q2xma0FwbHcyTmkwR0pYYU93RTN1MkdXSG4yMEtSM05x?= =?utf-8?B?QWhqUm1qaHppWUZXT1JVeVNVZEVraXVJR1cvUnpwQ3NFQ1FIWEt4SG9nQ2JP?= =?utf-8?B?Z0FVYnl0aTFhekVWWDRIa3g4NHBGQzhQdXorcGxFMCtTaWlJYzZBbnNSekYz?= =?utf-8?B?TFA5YWZsMU8wbDdTd2F5RGZjWjFtSVc5cy9kUUxNeU55ZU9CVzc5SEtkTW5s?= =?utf-8?B?T0NPd2JxeWh6bTVvc3hMaXNsbXdybnR2Z1pVcnR4SHd5ODZNWFR2SzdjWVFu?= =?utf-8?B?Mkh6ajdqaVc2U3dhZjdSanUrY3lENDljSkRzd1gxWndMZnd5d2dwSlhoNWhz?= =?utf-8?B?b0VUd2c0bFBONU15VjY0YjU5NjhjdG5rNHF5a0JSQmJ4RWQ3bEdISFZLaWRu?= =?utf-8?B?R0pPU3pPaUtERDdaNU5FeXh2WkM0YTcySHU4bGc0SWJEcnp1S0dwVzRES3BP?= =?utf-8?B?S2YvL1Y5djlxM2JIZEl4YkNlQjc5SmNOSktkeG1BODlsOXZ5aG12NFoxWXpK?= =?utf-8?B?QW95bzZxTG05RmhFdDdVMUZRTFZxV1BXQWJ0b1A3MDdQaHRYSDdlSjRFczQx?= =?utf-8?B?RzJ1YW1pZTg0NnJ5TkY1MkJJVHlESHVINGw2SDB5MDRNL3c0WXpEek0vSCtQ?= =?utf-8?B?eGUxUmV3a2hTYnpiTU1GWFh5ZmVtVFlwSElzOFNlekNTaGM0SjhQVjZmZ0VJ?= =?utf-8?B?VFlIOHZUV0R3Y1hBYW9UczgyKzhjNHAyQ01wN3RlRlZtRU5CSFNFTUpvWmpv?= =?utf-8?B?VXp2YnRodlZoRmNIV21ETFlYVkJyVWpFUkYxYTJjNmNndmhtOWgxcTUxNVNt?= =?utf-8?B?L0RoNmJQVk1WbXJ3SWJTZWJ1cUtJMzV1YXdZSWxWR2d0cHcrTkRVZ2pXM1lN?= =?utf-8?B?bVZ0dXRmTTFvaGJwbEZTYmNjQ3p5RzVpSFkzRzBFNE9aTDArUmgycUxVMERU?= =?utf-8?B?bzJEV1dzL0szckVaRld0Y2gzZ1hKTjlUNkJSeXVzUllHNmc4bXJXejdhMXlm?= =?utf-8?B?cW9IS3dmVnQ1UGdkelE5ZXY1Y242QTdwdjhDNUFLamNPYnAxZi9YSGdYV1Zq?= =?utf-8?B?SzlkdkZmRmlZV3VjbS9mQW0yTkNEQWp6SGw2SmZLY1hFektUOVV0aGplY1d6?= =?utf-8?B?TFJlWjNUTDdkckdja0h3MjVBRnh5YW1WOHBOdHZEZGJMK2pZV2M1ZEhkcFBv?= =?utf-8?B?Rld6MkFobnV3PT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(10070799003)(1800799024)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bW5BUlJvQkhHVjlRaFBlMitmcnVvOFRDNkpOQUdNa1FKSjNGdzB3bm1MWnVx?= =?utf-8?B?WWNPMG0rekprK1VtQ0o3eDdlREkvcXdZMHhNSFNsMU1ZNDFMeXFoUmM2eGha?= =?utf-8?B?NjF4VHhhWFA5eTRndzI0SnFkY0J4MWdmUDB0Rms0WjFSbkJEcW9MNTNnTEkr?= =?utf-8?B?d0RRUk1QQ1E0QU1QZ2JLQWl2WkR6UFhPMkRPTEJ2ZGR3VHU2cGRHRkdwWHpy?= =?utf-8?B?U21DdnR0NUY5Z1IxclVTaitFWVBIellTQ2x2a0ZQbjZtclNVRVM5enl3Sk03?= =?utf-8?B?UEpnZ2xSYit3S3dOS1BDdHJXOWFyY29pdEtsTjBodkVZTkhGbkNyWXlIajVJ?= =?utf-8?B?MjM2WklKSWJXSWRXTFlFbDdlU2JnZzlLQUNCTEJrNzAxVW5qVnZTbmFMa295?= =?utf-8?B?V00ydVNoQzhHR3FVOEEyVUU5YTVtNVBmNEEvZkczTS9oVDNPZ1ZOeDlENTFK?= =?utf-8?B?VDJwZlJ3ekdVTFp0QzZWRDYxSkI3THhudHc0N1prbW5qL3lYYlhTTkRCdFZD?= =?utf-8?B?SUlZOEFlOG1pdXliZjRoK0JvUWFsNzQzbEtSY2ZkY2xUREQ5Y1orbGFjWVN2?= =?utf-8?B?bXc4V3h3Z1lUK1dPRVR3dGk0MnZqZjVoNFRFd0VNVld4SE85aXJ4MWRtN2Fo?= =?utf-8?B?Mk1Sb1FSdmwyckRQckFxaGFveTFPNlFnMUdqeitjeC9kbWt1eEhRK09QZjJm?= =?utf-8?B?VWlYYXZwZmZMbTlWWFVIUEJ0UWhsWWV1VXdZSWZEa3dYNmJhR1A5MUk2b05Z?= =?utf-8?B?RWs3Z0x5WTdxZkxNT2IwMHo1Qko3amVpbUk0dVU1WWVWTFZjUE1XaGxsa2ZD?= =?utf-8?B?NW5HS0RURGRqTk5yaDY0bEx0N3ZQU0dZaWd6K2JyUHd2NkpQTTRPbjdSam15?= =?utf-8?B?Sy9OellnelplS3h2c1ZHTFBYVjlUQlBPV1ZuSlVOWWtpSVM4Snk2WlVEMGJU?= =?utf-8?B?TzZiQjNFQ2I0YUd4WVhNaXBoUVEwMVVSVDFnelZUMTA4WTlCblRHV1pHNXNu?= =?utf-8?B?eU5EaldCTzhTeTA2cXBKSkh2L1BBdVVyQisxaitTSHdaSUxUcURuN3BsOXFN?= =?utf-8?B?emhYc2xrUEJRUzl2eGdNWXJsU3dXeWhTSmF6c0dJdC9GbklBZmQwdWlKWUlP?= =?utf-8?B?WGxPV0pqNGJNN29pTmJiblJBa0o0alJGNWZiMWMyTXNFVVY0cWtzQzdpdjhw?= =?utf-8?B?bXJnOHNCSXEvOVk1V0dkK0o0d3JpWE1ZdHVFWmZvalFBUkI4OGRISHczR3dE?= =?utf-8?B?NitDWDB0RlAyd1J4akNJRXdRS240ODMyTjVoYXF2OFdDdWFIdnFyeTJpd29D?= =?utf-8?B?bkhvZWdnWTdPcUo1RXVCalhGaDJQdmd1dFBZN3hFN0lneXE5WXJKUjJUY3B5?= =?utf-8?B?MmxCZ1pVcWRMS2lUV01pZ1UrZ0swcFRzUTlieXdxRE5teDVKKzZvL3JsMmh4?= =?utf-8?B?RmlYVjNLOGs3MWtZTmpsL3gvZFBmTEVQNDgva05aWFFISGV5RzVNeWJrSHU3?= =?utf-8?B?aGppTllxdmYwQnBzdnM2QzBGZWgya2Y1dmdCb0xEbHJXNnJkcVlpUXJ1MTlZ?= =?utf-8?B?NEFrTDBkOExTck9PdHlsK2Y4ajhKSytPWVFUNlpFV2JzVGkyTDJ0V3hFUHRt?= =?utf-8?B?dElKaEdzZnhJQ0t3aEEyVG9LSnZhVFkvVnk5Q1gycDRvQjF1aDRwTGw1ejZr?= =?utf-8?B?TnQ3bW5yd1hKNWFFWU1vTnN5MGt1Qno1YnlDU09ZUm55OHhod0VZejM0TVpr?= =?utf-8?B?MUl1bVhLRmZlRzg5QVhsdS9VK0xob1YyV1ZhUm5RMUk3bUVCbWxHdnpaRldU?= =?utf-8?B?dmVmNjluMGVkZXMvd2RUd3VZMDFob1prcWJ0YzdHNGZhaG9nYTBPVU5vU01s?= =?utf-8?B?U1huQjFqWjJCSk81QldsSWdFcXlJRmhDeGs1Ny92S3R6QTRDQ3hIVFRCRVQ0?= =?utf-8?B?cDJlSXpZUDJYdGxKN2todklHTXQzR2kwYmFrRWU5bTlaYWpvcWFKaXBIVjQ4?= =?utf-8?B?SUQyWGdvS1M1dTM3SHczUFJzdW9qeEVuREVzeUlaL285OW5QbFFwY0JaZkxG?= =?utf-8?B?Q3RQeEVUWVdDeEdSVldKclptdGl5TzdodWVmeCtMOWdkWVo1OEtDd09TcE96?= =?utf-8?B?MUpRWURjTDRKNWkvdkcrZnFNQkxjZ0tldElqMTVvcFdaaS9UNGlxRFdac2Rk?= =?utf-8?Q?Z2daYpSdN9HHrQHaYRJKFc8Nw8spwmDHZiPJlOwPhuUN?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88decf0a-f560-425b-862a-08ddaffc7b9f X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2025 13:15:09.8478 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: B1i3fupYTQ7pR3BblS9OVgmigGtVlGOTCGPFDAr8Zupii+P9ppoERRWGg8WxkrMnzB9PVlouOpdm+i4H9rZudA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8426 Introduce the `num` module, featuring the `PowerOfTwo` unsigned wrapper that guarantees (at build-time or runtime) that a value is a power of two. Such a property is often useful to maintain. In the context of the kernel, powers of two are often used to align addresses or sizes up and down, or to create masks. These operations are provided by this type. It is introduced to be first used by the nova-core driver. Signed-off-by: Alexandre Courbot --- rust/kernel/lib.rs | 1 + rust/kernel/num.rs | 163 +++++++++++++++++++++++++++++++++++++++++++++++++= ++++ 2 files changed, 164 insertions(+) diff --git a/rust/kernel/lib.rs b/rust/kernel/lib.rs index 6b4774b2b1c37f4da1866e993be6230bc6715841..2955f65da1278dd4cba1e4272ff= 178b8211a892c 100644 --- a/rust/kernel/lib.rs +++ b/rust/kernel/lib.rs @@ -89,6 +89,7 @@ pub mod mm; #[cfg(CONFIG_NET)] pub mod net; +pub mod num; pub mod of; #[cfg(CONFIG_PM_OPP)] pub mod opp; diff --git a/rust/kernel/num.rs b/rust/kernel/num.rs new file mode 100644 index 0000000000000000000000000000000000000000..6ecff037893dd25420a6369ea0c= d6adbe3460b29 --- /dev/null +++ b/rust/kernel/num.rs @@ -0,0 +1,163 @@ +// SPDX-License-Identifier: GPL-2.0 + +//! Numerical and binary utilities for primitive types. + +use crate::build_assert; +use core::fmt::Debug; +use core::hash::Hash; + +/// An unsigned integer which is guaranteed to be a power of 2. +/// +/// # Invariants +/// +/// The stored value is guaranteed to be a power of two. +#[derive(Debug, Clone, Copy, PartialEq, Eq, PartialOrd, Ord, Hash)] +#[repr(transparent)] +pub struct PowerOfTwo(T); + +macro_rules! power_of_two_impl { + ($($t:ty),+) =3D> { + $( + impl PowerOfTwo<$t> { + /// Validates that `v` is a power of two at build-time, an= d returns it wrapped into + /// [`PowerOfTwo`]. + /// + /// A build error is triggered if `v` cannot be asserted t= o be a power of two. + /// + /// # Examples + /// + /// ``` + /// use kernel::num::PowerOfTwo; + /// + #[doc =3D concat!("let v =3D PowerOfTwo::<", stringify!($t= ), ">::new(16);")] + /// assert_eq!(v.value(), 16); + /// ``` + #[inline(always)] + pub const fn new(v: $t) -> Self { + build_assert!(v.count_ones() =3D=3D 1); + Self(v) + } + + /// Validates that `v` is a power of two at runtime, and r= eturns it wrapped into + /// [`PowerOfTwo`]. + /// + /// [`None`] is returned if `v` was not a power of two. + /// + /// # Examples + /// + /// ``` + /// use kernel::num::PowerOfTwo; + /// + #[doc =3D concat!( + "assert_eq!(PowerOfTwo::<", + stringify!($t), + ">::try_new(16), Some(PowerOfTwo::<", + stringify!($t), + ">::new(16)));" + )] + #[doc =3D concat!( + "assert_eq!(PowerOfTwo::<", + stringify!($t), + ">::try_new(15), None);" + )] + /// ``` + #[inline(always)] + pub const fn try_new(v: $t) -> Option { + match v.count_ones() { + 1 =3D> Some(Self(v)), + _ =3D> None, + } + } + + /// Returns the value of this instance. + /// + /// It is guaranteed to be a power of two. + /// + /// # Examples + /// + /// ``` + /// use kernel::num::PowerOfTwo; + /// + #[doc =3D concat!("let v =3D PowerOfTwo::<", stringify!($t= ), ">::new(16);")] + /// assert_eq!(v.value(), 16); + /// ``` + #[inline(always)] + pub const fn value(self) -> $t { + self.0 + } + + /// Returns the mask corresponding to `self.value() - 1`. + /// + /// # Examples + /// + /// ``` + /// use kernel::num::PowerOfTwo; + /// + #[doc =3D concat!("let v =3D PowerOfTwo::<", stringify!($t= ), ">::new(0x10);")] + /// assert_eq!(v.mask(), 0xf); + /// ``` + #[inline(always)] + pub const fn mask(self) -> $t { + self.0.wrapping_sub(1) + } + + /// Aligns `self` down to `alignment`. + /// + /// # Examples + /// + /// ``` + /// use kernel::num::PowerOfTwo; + /// + #[doc =3D concat!( + "assert_eq!(PowerOfTwo::<", + stringify!($t), + ">::new(0x10).align_down(0x2f), 0x20);" + )] + /// ``` + #[inline(always)] + pub const fn align_down(self, value: $t) -> $t { + value & !self.mask() + } + + /// Aligns `value` up to `self`. + /// + /// Wraps around to `0` if the requested alignment pushes = the result above the + /// type's limits. + /// + /// # Examples + /// + /// ``` + /// use kernel::num::PowerOfTwo; + /// + #[doc =3D concat!( + "assert_eq!(PowerOfTwo::<", + stringify!($t), + ">::new(0x10).align_up(0x4f), 0x50);" + )] + #[doc =3D concat!( + "assert_eq!(PowerOfTwo::<", + stringify!($t), + ">::new(0x10).align_up(0x40), 0x40);" + )] + #[doc =3D concat!( + "assert_eq!(PowerOfTwo::<", + stringify!($t), + ">::new(0x10).align_up(0x0), 0x0);" + )] + #[doc =3D concat!( + "assert_eq!(PowerOfTwo::<", + stringify!($t), + ">::new(0x10).align_up(", + stringify!($t), "::MAX), 0x0);" + )] + /// ``` + #[inline(always)] + pub const fn align_up(self, value: $t) -> $t { + self.align_down(value.wrapping_add(self.mask())) + } + } + )+ + }; +} + +power_of_two_impl!(usize, u8, u16, u32, u64, u128); --=20 2.49.0 From nobody Thu Oct 9 02:52:22 2025 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2077.outbound.protection.outlook.com [40.107.93.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BED928CF76; Fri, 20 Jun 2025 13:15:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.93.77 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750425318; cv=fail; b=fEYNI5IWt46zWOZBb8a0gjhx91bsCdjoPSInzpKrZ7TAGZtjG08f9J6+4Q278Z/I+tCllYt2kqDO6aA7uqgCP9am9eNeR5bwBDLmQnaACbjF1L82caqNaHblwTOGyJ/AFP9lvkx1wm2tYofzrNuREeyu4H0B7prB50AjHRCM4SA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750425318; c=relaxed/simple; bh=PtSbr3tXvJsYyQAzsY26YPIFZX5zn4HPns9SNp3xcUo=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=r2NXGO4M/IJ/FM/YAFqPBiGhnQf6hBhjtM9hr3Wwaun8//Yi00YXFILgErqbEkBz8a9CuFxXqeexQABYyiuCRmbsIw9kfVUxBX3hpLo8EofSD1WOL4LQeX2nPeL9iD1Te3beGP/pTkW/NGSuogzl9294fsjKv8DNxBojJhVezdg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Y083ZR6o; arc=fail smtp.client-ip=40.107.93.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Y083ZR6o" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gAaeCS5ZpsNmr8BCf+pzu1ftxGBEKKIC4R6LVC9eoGuXaxxeDZnYfI1MLcKyG5YeArUfSgkpr9hZLJi99C5qyUo/GhpSQBf8nRV3uxuskLcVgZ+jEg+75+8vFIQJ0w30gd5dZrX1Bg2FnKwW9/lZv+lGNhfUDf8SWik4PB/MkrQExHF9GNyPfD4fgUcZ1Ab19Z7OvKm0Nh0JLOTBbS6R6HR1xbuCuCXVDZj6YW4UQTKDiSES19x6MjatwW4/1gPD7yaGQ6MIoZ4ztTITo22E1/JQ9+iwIse+x0xAqI+8C11PJps2EikK/I7Y8TCHfU1bbsnb4zU5MkXVkFYgmpFZjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ffdv7mK1aAMEuio0MWBoLIkToaJk28pZf56SqfK5ZKU=; b=xufDsPsFV4fK+gx+qFyVfBolXll7tejSXCgcufRoSfO/RUCiS0LGqUxxSPnyidIjoLGOVN/25y+4lHYx/9uXbc4Jl/V6wd/HWVq6pIqkrJ2kgPVvfRf35im28MwK0kXkwtMDnXDcdFR4xuoQKfQ6oGDlWUT2VK6Rf0U4gh5B3vgccYrfXaYFScvQLLXxjmmDtoEH/jgFPwETi+KSJ20uhfFaxuTUBaFXGuJu3j7DJ2H9N8r8dmF5kX1CLzHvNIQGldSaANYQCK1AbANNt9+w00N9Ia/c94cqBQ5lIqf8oyde5iLQt5cigQ31MCu7b8SD5gY5OJ+o/JvVf3zVTlABAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ffdv7mK1aAMEuio0MWBoLIkToaJk28pZf56SqfK5ZKU=; b=Y083ZR6oB0tZuMJjpMUUSICLWW2pXoEjkMjHCObqq9ZfIpuX4Tp7UnczEzvd/wnp2Ccg+NIh0YEhFOLvQSLcoe7iHj5xXcObzHx07hJ8+DH5y4Kf2Mx95VdxM04Is6zZas8AU8kf1in3JIPECAijrdpqRWSsdd2zGe3G7vpJdpcupAmSIe0y7FBBjP6ieAz3iQFXaF31Omu3BO8D1yKc4l74yx9INHr99BYClV3bx+18SOAZKYmpSDKJrBiDlHrChwJSycS0PLqGk123mVWkNIeRsbeSRlmVukWj/euF2NZce0FqllPlsRV5lI+3MuupqBjnq4NKppjvBuQb7Cf8aA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by PH7PR12MB8426.namprd12.prod.outlook.com (2603:10b6:510:241::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.29; Fri, 20 Jun 2025 13:15:13 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::6e37:569f:82ee:3f99]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::6e37:569f:82ee:3f99%4]) with mapi id 15.20.8857.019; Fri, 20 Jun 2025 13:15:13 +0000 From: Alexandre Courbot Date: Fri, 20 Jun 2025 22:14:52 +0900 Subject: [PATCH 2/3] rust: num: add the `last_set_bit` operation Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250620-num-v1-2-7ec3d3fb06c9@nvidia.com> References: <20250620-num-v1-0-7ec3d3fb06c9@nvidia.com> In-Reply-To: <20250620-num-v1-0-7ec3d3fb06c9@nvidia.com> To: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich Cc: linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, nouveau@lists.freedesktop.org, Alexandre Courbot X-Mailer: b4 0.14.2 X-ClientProxiedBy: TYCP286CA0115.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:29c::19) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|PH7PR12MB8426:EE_ X-MS-Office365-Filtering-Correlation-Id: 4a5af15e-39a4-4182-fa32-08ddaffc7d9d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|10070799003|1800799024|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SHI1Rnp5UFdIQXZaa0ZZY2JGakplZ1VRTXJzT1JsWHFJaFYrZ2pwdWJpUStC?= =?utf-8?B?QkZHdDhOeWtsbDVmejVYTjZPaWYxMURpUFo0Q3E3enVyRWV1dkJNUzc4L2dw?= =?utf-8?B?WXllTk5hOHkxdU1GQzhDNzhaZjVDaGtyend0YzBmcWhGbGd4cFVyMmhUQ0Z6?= =?utf-8?B?YW43ZjVEeW9JcENlTlpQUmtMNTdleUNlVThYaXpkaVBIS0JGWVlwejFLYlds?= =?utf-8?B?ZzhwRUZ1Y2dCQURWOHRWbmhWRkhwVHNac3NDTEc0Vlh5WWJjR3lVbHBXTUFJ?= =?utf-8?B?cGFDTGlzbFBQR0tTUmlWRzdsZU8wOWFXSVljN0VoVTFuM3VtR2VjRDJlbjRj?= =?utf-8?B?NlgvUGEwaDdpd1BVTU5CQ08ya2p5QjM0dWZOS0RFTGR1MXNFa3luMWorWnRC?= =?utf-8?B?enJJYzducUh0MGhZb3FlMU9SMmk2dUtRankxcHYyczRmaWIxT2N6Tk81ZzZL?= =?utf-8?B?RjVoeVdlSzUxV1VibXNtSEhkblNzRmJEeTdRK1VwbnFNYXhjLy9kelZvVWtR?= =?utf-8?B?RkxRd0FwSFdIVzk1ODllMzNENjJDV3Jyd29SUGxCNHNyZnlQWDhZUkFva3Rp?= =?utf-8?B?dEhIMkpmSk5RS1lYSng2Z3I5ZDFsTzlMZEs1TC9Pa3U1UGRSNjBpTjIyQWdF?= =?utf-8?B?ZkNXR3IyMG1jMkR3cllHRy9JWDNXZ3RJOWQxNnhzOWVsTFhDWVdSbmtCOHZ5?= =?utf-8?B?ZEFXc2JlaFdPcXc1Y3MwbzQ2NUJSVDFRMWFsbkVCSzNvTmVabThzcXFwWEp4?= =?utf-8?B?NUh1SWsvbXNyMjRzdWIvT3BqVWFHd0p1RGVGbHQ2R3lZOHNESWRhOWc0YnNS?= =?utf-8?B?bjVZRXNIcDhMNHNEL1pqcGZGbmtEdnh1Mi9GVVVCS2Q4b0lIaS95SU43SjNS?= =?utf-8?B?eWM4Y2NMN0FWU1VGRG5DZ1hNSmhLWnY5ZERrcXNKVnVnVmt3RjRNV2VYQUVK?= =?utf-8?B?Y3BkeHVhZGJQNFRQWC9aN0JUdFIvRGFNQVBBTFRWZzA3NWJ3RzEvTlY5VmlJ?= =?utf-8?B?RUdYRHBOWGVzMlh2TjRhbS9xbzFoRjVlSUdjbkYzbSsxNUIwRzFselRVc3Jw?= =?utf-8?B?THlSbURvdlR2bzlUUVBaa3hYQVd6ZnpwTXRWSGtiYzBXSWNYY01YQVd0aVpi?= =?utf-8?B?OC9yaXc1MjA3N2djZmRLazJNcWxIcEluSkZuNTE4NytxYWJMOHNrQndibkRa?= =?utf-8?B?blFtbU1PeVlXUjREem5tZEtJNkdURTBuT2htQUlSOVIzWmhDS1FnTHZwNVB1?= =?utf-8?B?L3VJaFlWTmhaWnZZZ0xoV1ZzRjRBWlVZOVg1b2w3MWF1YmxtS0NRQkYxY1Ir?= =?utf-8?B?NW5SUjVsVXVFZnRCNVYxZXdWN2dkUnNRa21iTnFnQ1hPRUtFejFhUGVpT29p?= =?utf-8?B?bTdLMXBKR1lOUGlTa3hPcFd6QStMYVBrWEZJVTdIaVhBZDNYSFF1eHpsY0l5?= =?utf-8?B?MmNWSjc1b2JUZ0k4M0NHeVBYT0grRDJLblB6ZHhoMkp0R25iVm5uVVN1QVhK?= =?utf-8?B?WDZVdlIrbWZvOWNuT3JnNkNvRWhxbEFmY3JlOUpId290U00zZ0d3UW9xbU1Q?= =?utf-8?B?YmlTaGF1dTN6SFlkOWx5d3l0NXllYksydjllSmRPM2lqY2RuSHVQaUtuaVlJ?= =?utf-8?B?ekU4SVFuS3BoUGVEU2g0cEhJY0JEOWZzQWtzMVdrMklGYjFMamdQa29Gc2JQ?= =?utf-8?B?Y0h2R2V0REo2aTdFQWh5aldxRFFIQXhzYXdzd2s5emphb1VaUmFjN3Fhajli?= =?utf-8?B?MXVsK3d6TWsxSTZrbk9nRklDakoxMllsYmlTZjVkL09iSlVLUXhRR21Tendu?= =?utf-8?B?ZnpyWDRmdGVqRm4yM09XbFlYckdTZE9RMTlmRjJaajZxeTN5NWhZS2hMKzF5?= =?utf-8?B?aHFLVU95d3lhZUgyV0czcWltRFNHMHRQNDc5TGtvOFEwWEtNU3RTcjdMOW54?= =?utf-8?B?VU9tMDI4RHRldE5KT0RjU2NnZzYvSCsveGtYMU82eXlVRGlKRWJIV0JqNWVQ?= =?utf-8?B?VGoyQUJRNW5BPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(10070799003)(1800799024)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c0JNdHIzTVJuQU0yVXE2ZUZLa2RIOWhrWTBRNjQvREhjdEU3S0VROUJPdjV1?= =?utf-8?B?WHQ4bFhmWFM2TEdPRGEwTTJNNVY3N24wc3ZFOFRTWmxiUVVsUVlCNlVsK2NS?= =?utf-8?B?OHd4RytnOVRtRU9XUDY0eWpNTCtpSU9HcHlQcEgxdGxER1NQbFVBOUpmdmJB?= =?utf-8?B?eWhFTUV4ZVMveWRBTmJvTitPS24wSVlRd0dlczNQWWtTUXZBU2kwdGtpQWhS?= =?utf-8?B?ZWIrNXFKTDI4OEZJZVE1YzRaQk0vcDhqR1N6KzRTN0pTajlXV1JtM0src25S?= =?utf-8?B?T3VUS01OSVVGVFNEd1VDVlNhQVlWSnFaU3dZdFF5cFpXT3hvTTNlbUE1ZXF6?= =?utf-8?B?VVlvME9mMDlZOXNrZHVyem9oMXlBRnRPaWhnVjVMTndXU3ZoK0NYMWhPOHJB?= =?utf-8?B?SHZOc0xQdERSN3VRTHpOMGpzYWZmc0dLWkJjVjBhT1p3L29IOVBzVVBQeGt2?= =?utf-8?B?ZzZBT0lxUndybjU2ZDYzNUE3WkNQYmJTd2RpazFLc09YclFUTnBaOG9BOU9m?= =?utf-8?B?VjFXT3RLUnZJMUVCOFBDNlNJRnFIMkY0V0ZvQ1I4ZVVJSXRqMmtYSEgrNGMx?= =?utf-8?B?WERIdjZzRXg4VnUvV2hSK3JqeXVxY1RBZ254TCs4aTcyRHV1Zm1YbFU2Tlh3?= =?utf-8?B?Vnh0YzFvbTVxTnY1Zm9TOGxFSlVRSVd3NjdJbk1kZldpYTRxZVZBamcyalFx?= =?utf-8?B?VmU3NXRja0F6QTZYNlBXK3Z5amY2SHNSc2Uxc2dDOTA1dlIxUDk4WjdjZ3pN?= =?utf-8?B?UjBjWE9tUit2Ymlvei9rTk90WmVWL3dzcFdyN1JzL0ljbUw1RUQrL0EyWVJJ?= =?utf-8?B?SUc5eGpMekdmRmVTdlJJTDFTM2JrRDE2VHJCaDZueXBZdVVTT1NvV1V3ZFlX?= =?utf-8?B?Ymk2QThOZG43dW9oaU15MldRRXAyWS9Ddmg0eEw3dEoyNnp1ejhtR1Z6QWd6?= =?utf-8?B?a0NpNGZQSERMRmNZS1h4NW5maExTaUlNZ1RUZnZBRWJGbDlCWmUrY1lKSzVZ?= =?utf-8?B?WXNDYkoyY3ZJLzhUTzlVV2xPYXRMa2dESVNpRnVKWWpTYzB0V0N1MnBFbHd1?= =?utf-8?B?TEpkR3J0a1prTkh6anhlVHFlMTlzWE1XNXB1alJ4MkNsd0pDdndOS1FDSXox?= =?utf-8?B?ZXAzV1lYcGtmZG44Zlc4bWdFQVFKeldCUTg2YXdUNE1mUUtDc2lzRlBUWHI4?= =?utf-8?B?d1FBc1VDS1poaGFmODhHRXdOZnVaMXVyZFcyK1pIaGFJSjBXZm5qckN3bUp4?= =?utf-8?B?MWZKMkx3TGU4Z3JtVllUaWhZbU5VZXlTcW1zT205YUhJMjRWRmlJeWZtbFBG?= =?utf-8?B?QWhXM0lNTFk1a0RhNkxqYkl5NEtZTkhibFphUWg0d0VyUFQ4UjFuOE1YdjZh?= =?utf-8?B?enp5Z3hpaDgrZG9TdHJubWU4WEIxc2x1V0lQQk9UbUc3QlEybVJhb2J5N2J4?= =?utf-8?B?UEZJVnpxOHM4T2FublNZWjVnblBYODlWbzlPMjdwOFJ2ZEJMTnoxNW1PUjU0?= =?utf-8?B?UGhFV1k3V3kwdmpDUDk1cnFabndNczlKcWNXME1wdGw4bU5kZEE0WlBKYUt3?= =?utf-8?B?MVQ0RDYvN3MwekEzakJ0SmZPS0ZSdDU4VDNHSFlLbG1uMysyZWZBbXZaT1NZ?= =?utf-8?B?dkJDc2pXUWZUcDFrWjVESVpjYlZ3dGRjVjRHaGlKMFdGK2hienNlYUR4dzBz?= =?utf-8?B?bmFob2ZnQkFmSzJBOWp3MEdIdnE2NW4yMTJDSzN3clBnM002d0tQQU55QVRO?= =?utf-8?B?QTNSY29XWUFhaFNkWEpFZWt0cCtNd3hwSkRMWGdzdmFzQ1VyZ1BHWStaRzFn?= =?utf-8?B?MktacHRQZzQ4UkJ4TVdvSzJBOFRPL0pHN2xVMEYxVXRkQVM2Yll3WXVKVnNx?= =?utf-8?B?eTFzSy9kVFdBNE01MFBUUVdzRGNOOXdkQnVveHk0eHBETkJINkpHNGhYUHA3?= =?utf-8?B?eHFpbDJhaG1WaXR6Y01wWEUveFJxN1RST0Z3NXBLT3d4TSt0aC9lLzlkUVpq?= =?utf-8?B?VjBBUXNhSHdIUDdFQ2gyM1AzZ2lUWnNNOVFoV0tHVVpsVDhPVjVPYkZVVFBS?= =?utf-8?B?OTFQYXhyVEdZeEpucmdjY1hCUUVqRzJNb1h0a2k1VE1FeXg2d3YxUURuS2g3?= =?utf-8?B?Q3BwK0l1NjcxL1hyZkRmekNDbitQWWVzSmlCMTBPL1d1TGVGVEkwQUpDKzBJ?= =?utf-8?Q?QW8948RIKPx2CshdOlYqnNsE8rcQOzP5MUD99Ni8xZgl?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a5af15e-39a4-4182-fa32-08ddaffc7d9d X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2025 13:15:13.3031 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k/WZdklxeEO3kICEUqc4oTh6pghfLDgFAcgt4gEM06BRrnZw2MgCCk06Eal29WD9EI6iuNoRvDh1vL6U+8Y9Nw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8426 Add an equivalent to the `fls` (Find Last Set bit) C function to Rust unsigned types. It is to be first used by the nova-core driver. Signed-off-by: Alexandre Courbot Reviewed-by: Alice Ryhl Reviewed-by: Benno Lossin --- rust/kernel/num.rs | 38 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/rust/kernel/num.rs b/rust/kernel/num.rs index 6ecff037893dd25420a6369ea0cd6adbe3460b29..95766201a7cf208989f37ecbc6d= 54d264385a754 100644 --- a/rust/kernel/num.rs +++ b/rust/kernel/num.rs @@ -161,3 +161,41 @@ pub const fn align_up(self, value: $t) -> $t { } =20 power_of_two_impl!(usize, u8, u16, u32, u64, u128); + +macro_rules! impl_last_set_bit { + ($($t:ty),+) =3D> { + $( + ::kernel::macros::paste! { + /// Last Set Bit: return the 1-based index of the last (i.e. m= ost significant) set bit + /// in `v`. + /// + /// Equivalent to the C `fls` function. + /// + /// # Examples + /// + /// ``` + #[doc =3D concat!("use kernel::num::last_set_bit_", stringify!= ($t), ";")] + /// + #[doc =3D concat!("assert_eq!(last_set_bit_", stringify!($t), = "(0x0), 0);")] + #[doc =3D concat!("assert_eq!(last_set_bit_", stringify!($t), = "(0x1), 1);")] + #[doc =3D concat!("assert_eq!(last_set_bit_", stringify!($t), = "(0x10), 5);")] + #[doc =3D concat!("assert_eq!(last_set_bit_", stringify!($t), = "(0x1f), 5);")] + #[doc =3D concat!( + "assert_eq!(last_set_bit_", + stringify!($t), + "(", + stringify!($t), + "::MAX), ", + stringify!($t), "::BITS);" + )] + /// ``` + #[inline(always)] + pub const fn [](v: $t) -> u32 { + $t::BITS - v.leading_zeros() + } + } + )+ + }; +} + +impl_last_set_bit!(usize, u8, u16, u32, u64, u128); --=20 2.49.0 From nobody Thu Oct 9 02:52:22 2025 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2077.outbound.protection.outlook.com [40.107.93.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 001A128F51C; Fri, 20 Jun 2025 13:15:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.93.77 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750425322; cv=fail; b=hrDLY5D3Meo3bhbpo9XM5G/yvoSjnVB/cPmiNVWJXqI1yj7T2NFcYg6lThhCvN4WL18FJhGETLYJNtYRr6p2ZBoFoH91w4wX9wMVW5l3qwpiJIBiuDCsYYWMoFyx+6zU8j9Lrj8amMZE3MCfaVj2Tt+7p9cR5HCYBTxfZZCq16c= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750425322; c=relaxed/simple; bh=OUyeUqugL/LcWF/pDFzPffvTlyQY9hRQB7v9QaZmk2E=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=Q8sqNo79Ssc6veGeJMtK004rsc2YmLmZfdhaNwVUAHtsTmaTLVfjOptnXtbJ5pCPQprYkuKbKe4TWgL5RISfzqmzg7DGAX0qTMw1xVjZootrmdFzUxORW00Q4BhleUHhFc0N9/DsmfHf7WF5k7C5QiFyn6v7yeCeQspTU954ofo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=jN098Q81; arc=fail smtp.client-ip=40.107.93.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="jN098Q81" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=p+6obA+Qp5mNNByMc7Uk/u9FYD0MYbvY7FbKKa6jM3QRINyyXAQOOCgcckUkVTc2zQDC3Cvf/Ee0V1fwayvpWreHY14/Ge+clOATL7nS4XjHN+JX+vfJxbwaGj6CdrWnAywuWgUJ4WnlmK7xPyUJ1LUyGEYqEyYJsaSN+kNSBuI5Zmh2CrwUxb5QkMU89Tv5w5g6iavRQMvJQQ3rdE1Uquzz0gG0762mh4JUBMQEQNQInGDmXjkJKzv4bXevGmVR3cYnuIFBAJOPC+G4u+riBUPnjEe9VZ74HK6hprb5NsWvt21+CgwgI2wvCG8OF/fU83T9bQJMLFV4HQbhYz1ypg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LSbBWzWr0X1gdzwS24yGhhRg5BUmP1OPT4+k93KITtg=; b=cseMS0IBqWtxEBD4ytNlUEtkq6QoPwmbg6ghzCyzgysoVzOJmB8VJsabv2Jf0ZJKS/gTqZyxv8JQVK+Hb//Yx42XSkgIoTXnSp7mk8T2NviRNEg13NrLu1KmQIwCJg9uvOY/q7qWE61zeFd9V5YS2VUcCvaWy0ef0fOSASpYjhtL6so66km/JvBTU6bAouoBI3UNT8m4M01npsNSUEx2OpkER0gHcLJHXt11M2yea33h5A0tTMCZwi1gW2mqZ3swiDqGTld0eynPYYqdXIbjoeiRJhbwx3406OmRNZhORcqJ7lu2Tc8K0RYUVqR0PRdJJSlJcj6U2o4VoMZQhzWmvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LSbBWzWr0X1gdzwS24yGhhRg5BUmP1OPT4+k93KITtg=; b=jN098Q814Nx/J38c5u6ydvPf2jk8UnaytKWHuZBbyPix73aNYaS19wRQkgpsP5kzVZ9TLIlVD7UimjJ5OC9F5JPw6PbkiiRaksWzeSWO9FEf2FJ4mSSlMM+7hofRzV1azfBOFTkIzvDX9gVceDgItS0FZ30DwrfA4s6s8H8IGYlo2ekETPKgYjPvuT4BnVg76oqapiwkHOB7vSgiROCaX7WFGG+T4CJQQzV9RCA/OYClt07EOXWLrZiotwCYWJRrUyNbB+J2xy6U9fWiiZFwMxQ6HpJlHMFxCI0HrYLaAgTkSrp6R2KwfuK1Vo7mgyUCvg3+Qmyr72cuMpCle5wfSg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by PH7PR12MB8426.namprd12.prod.outlook.com (2603:10b6:510:241::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.29; Fri, 20 Jun 2025 13:15:17 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::6e37:569f:82ee:3f99]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::6e37:569f:82ee:3f99%4]) with mapi id 15.20.8857.019; Fri, 20 Jun 2025 13:15:17 +0000 From: Alexandre Courbot Date: Fri, 20 Jun 2025 22:14:53 +0900 Subject: [PATCH 3/3] nova-core: use `num` module Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250620-num-v1-3-7ec3d3fb06c9@nvidia.com> References: <20250620-num-v1-0-7ec3d3fb06c9@nvidia.com> In-Reply-To: <20250620-num-v1-0-7ec3d3fb06c9@nvidia.com> To: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich Cc: linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, nouveau@lists.freedesktop.org, Alexandre Courbot X-Mailer: b4 0.14.2 X-ClientProxiedBy: TYAPR04CA0005.apcprd04.prod.outlook.com (2603:1096:404:15::17) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|PH7PR12MB8426:EE_ X-MS-Office365-Filtering-Correlation-Id: f5fed006-6349-4491-b9d4-08ddaffc7fd9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|10070799003|1800799024|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VFZtVjVvR2JZSURCbkJlTGt3dXpTcnRzQ2FQMW1OWmFSazRZRFUwc0ptWWpZ?= =?utf-8?B?UFU0SVBkZXFacDI3dzd3a1pTZk9NRWJjeXJKeFowMHV3ZFF1cktENkExdHNR?= =?utf-8?B?STZ4UU81M2MrMVR4TWo5Z0N5VkZsVDZSNFBRd0FEQlhNS1VETmpiWDlRVitN?= =?utf-8?B?OW1ZWmcwQzFCR2U4ang4RDVPNXFrOUZqN0J6d1JiUDhJdk9oOWJuakFqelNq?= =?utf-8?B?c3ZLNHowYXBqM0VvK1JtWFVscExyVCtGWmhib0ZiWWFJS1EydjNHeHlOM096?= =?utf-8?B?T052cWR1U3kyTkRuOTZSS0xOd2xBSzlQamJmbDdiRitIejB3SDF4VHVVbi9N?= =?utf-8?B?OGsrc0l5TTZKR24zSU5CUjNlS3RUQXRGQ3VCUHArRHJlWkxzVEhKTFhmOENl?= =?utf-8?B?Rm12c1BMQk1KRmZlUS9aUjZzTzNQVTVkTWRNSit4NHdONTdzV25JRlZTaS8x?= =?utf-8?B?NEhCYmwvNUwrbUZZU3hKZ29hNHNIVXBhN1UwdC9hVmY4U1hCVHpIdW1PYzA3?= =?utf-8?B?V1ZidHJaYWVjMWtxVHRLSmJldi9HRlJSZkdBcm5tY3lNSzloWno0R2o1TlRk?= =?utf-8?B?YmdZbHUwdG1nNHdWLzVFeGJHODlzYzVzcEQxK2FQaHEyeUVUQVdkNnRiWFhN?= =?utf-8?B?d1d6alJqUXhoWmxhRG5BMHhZUkVBSVp2cU1TSGN6RGFndCtsdk1RajM2RDAz?= =?utf-8?B?RDBwVTdSYWJ1aUJEaE4vNytkdjI0Vkk0YXZCa25hV05XbmtXUGEvKzV3YzM2?= =?utf-8?B?eHZMSFhxRzh5TmxZN29XZHZBQk9YRlJoeGtrR2Nlb0VZTHJyUzdweUtBL25J?= =?utf-8?B?QUYvcWZtYklIaXYxV3h5djIwckE2ampKTXJ5bzFhTkp6TXduRlpneG4vT0xj?= =?utf-8?B?MW0reEZZVkZHZUsxU0xFMHdUT2JabEhBZmVLSXg2bVJ3YnlncGROd25maWJV?= =?utf-8?B?MHVsZStKdjBuT3ZaWHFVdmRjb3JHRUIzb0p5eStoZ1ZENW1IcHBFWmNHdTh4?= =?utf-8?B?TWlCeEJTdFRFL3QxaWQvU3BVVERvc3pxNEpzUlBrRHlwanpmUGpHeVJYOUl4?= =?utf-8?B?bXpJUGk5TjF3dEo0cnFGcFZGVDFGTzZzUjdzejNYNkhLeUdhZmdXMUF5ckUw?= =?utf-8?B?OXF4cUYzTmdtS2VPai85ZWZjWHA0Mm5ZU05TeFdzRzRkVFo0ZnJDcVRQZEhZ?= =?utf-8?B?dlZPRk40SjU3dEtGdmgxdCtrRDFHZmpySktxakFRSnhxbzBiNUxtYlVmU01H?= =?utf-8?B?Tll1bGdmWHE2Wklqc1NCWVZBc2c3aWFPcWJvcGNORVpkcnB3SVlFUjNXL25y?= =?utf-8?B?a0RkbWxKelZDNGRDY1U4ZmlwSnNPRVZIZStXbUtWWlhQZktCVmhHQmdHZ2Rs?= =?utf-8?B?ZDMvZi9UTjNjTUNKTGlwZnFoRHRqWEFtUXFDYUZQYzBIaWRrOGErUzlwSHZZ?= =?utf-8?B?anNHdGhhRzhJNklUWlVSQldFcDYvaGpqSEJ1M25GK0V4TXhvZEhINDhuM013?= =?utf-8?B?dTh3bTFKS2hmRkRNZnVwN0p5OGZHcFNrN0owSjY2ZFhJWVE2TjBPTnJDd0pG?= =?utf-8?B?N0lxb2pUUmlHNGJ0aGZKS1pFQVlzWVNXTzMwRHlYQU9EOFlsZk8reXFST3l2?= =?utf-8?B?ZG9PVkZlc3U2YUtBZ3JDY1ErMlZGMHplMkZ0TDFkaktNZDdiQ2M5QWxtZ0xz?= =?utf-8?B?dW0wMkRhcXVZd2dRajZDWEsyY012K0xwZGFIajhRc2lOeU5wZUYyaG1wOWdV?= =?utf-8?B?RG5QVGhnUGxva2tCcFJieEM5RTgzWnZTT1V4RGI1R09ScWM1YjhkWC9PdTY3?= =?utf-8?B?KzhhZDhQeUM3d0RucmhjQmg4Q0ZSbCtBVkhVZ0xyRkRxU2dPSytFaUl1dVNa?= =?utf-8?B?dERtbjdDUmNOWDVaR3pqMUJURWxoN0Rmc1RCMmp4b0ZOc2tlUDVGUkRYdERw?= =?utf-8?B?RnJsZWM1ZWxtelNRNVhZSkJLMkhDL0JvYnV5TnlXWlo1V1Bwck16bnQvMmU0?= =?utf-8?B?WUZmeUZuaGVRPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(10070799003)(1800799024)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R29kOG1tbHZ3WUJ3TkluYUVzbHZZc2pGL0cyaDRUNFFtbDh4QmNjeFh2Tkgv?= =?utf-8?B?azl3a21kS1BBV1JCVmtNSGc5MjgyTHo4MUN6SkErVHNtYkVUYTlqL1ljQ2xQ?= =?utf-8?B?MEt5dFJCdmFyY09WZGdOQnNjaTlFaEpLbEpXa1FaOUZ4aUJnR0w4QmMyTy9t?= =?utf-8?B?SVpxdXRlblZwbldtUG56a2JxUjM3dU5xTHNDeWF0ZHVrVVRkSUVFZkU5M3Vt?= =?utf-8?B?ekxqMEJzQTdMcHNwa004L24yUlRxclFOUWJDOGZyNGFrdjNSaEloNHcvM2Z5?= =?utf-8?B?SXd4QjhCUFVkcm9hNHdBYldsanhSRnhZakJvRFFKeXQ5WGV2SkJCYzNhb016?= =?utf-8?B?WXNkdElqa3g3MVVxMDMxek1obVBjWWFSUmt4elpxUTNHWitZNW1mZ1Q4V1N6?= =?utf-8?B?QkdBclozUjUyUVR2bDRoSG5MQWVERW1vajdiSndMdEtPVWx5MGdSaGhIaHZO?= =?utf-8?B?Yk1SU3BCbGdNWHlSNlZ3cXpzcjdZM0lNNkZ0OGpxcWoxeXdsaGZBSW1Ydmsv?= =?utf-8?B?T2lrQVNUY2s1ZjY2VTI4UnUrQWNqYm1WWWMyVjhyWHc0cW9Ea0ZZVXhxVUVE?= =?utf-8?B?WFF3ZDJTcHpjWnFoZkwxS0lVYWJMSzlLdThOeUpLbmdpUVZhRjhhNmJHWEdM?= =?utf-8?B?eEN4M21QWExhTlVJYjhKSDkzb0padHdyMndoM0U1Mzl3VmJwSlRsalMwb1J1?= =?utf-8?B?cjhWeGdjOTJuVDVpSGVvWm1tcExBeEVYYmthWDI3REtSRlErQlR0QWNmZUxS?= =?utf-8?B?RzVRUzN6NEhocyt1U1Zka01CR0ZXUE00RE9nMzhLYldTbGJGOGtSVWtKTTRJ?= =?utf-8?B?eWdQY0F3cVl6d1R1MnpoNnlmRysxcFFJYktiK25EUGFyVmtUbGNYS29SNHY0?= =?utf-8?B?c0EzL3liQUU0aStYNEltWGFreXZ5bnJYK2k1NU9ydzZNNVdhTDA5bU1WNERW?= =?utf-8?B?MXBlSmRFRURYdkp0THZEZGR6UExZZTRHTDV4UEk2RUFJMXRLZG5OR0JJZ1dq?= =?utf-8?B?b0NQRWRMMjV2TlZ2YWVaeW9RUnE2aERaYUpscCtBYVErUVc3VFp2Y1RYVEdT?= =?utf-8?B?TlZ1alQ4anl6K1MrdTZldElRVjFERUh4eis3NGx2bHRJTXBkS1Z1bkJRdXA5?= =?utf-8?B?N2hYVWJSaC8xUHQxS29IOFFIcTdBejFvMkQwNW1vOFlvd0kybFZNV001bUhs?= =?utf-8?B?SzZTcm9XRDc2UjJLRkNtcXdWbVhNY2l1aU14UkljT3VWVDdrajU0ekgwSmJX?= =?utf-8?B?d2pvZXZxRDNIcVA1ZFFla0lVVTRrR0xXN1FONnRNeVJ2alhpWmJ0ZFJmYUhz?= =?utf-8?B?SzFGZmdPOHhnbUprM3k1bEhnTG1TOEl2cThmNG9rWGVYSU8zVC81dlBrb2wx?= =?utf-8?B?ZXBkekhxU2JzcGdCSzdmaVhrdlJmOXArbDI5QTAySlRLcldObFBHRFdQNGZp?= =?utf-8?B?UUd0S3JiV1ZBR1lNSXZXbmkwRldIdnZrSUw0QVgvSGZnaVg0Y3lPZ3BHV0ww?= =?utf-8?B?RVZ5YngwaXRreGl4ZjJzYzN2Tmo3TzcwZ2xsSk5GaHJERWYweEpjbmZleWtt?= =?utf-8?B?eGh2VDFxSWhMUjBRd0VkVkI5MUVlQXZveFYrQzRpVis3RVVKS0htUVNSaGpn?= =?utf-8?B?a29pZWw5LzhqbnlScVN1NXZJVlJLVXRlbm9MZUJ4UkNyNkoveVBxdVdWaXlu?= =?utf-8?B?d3FicmZvSnFyL0ExSW9aenljNXhMOEZUTjVSSTVOOFVGQkxvcHVuTDc5cjZU?= =?utf-8?B?MFFJb2tGbHljY2ZBTVJlZ2w0d3o3Y1RaOEZrbmhYK0xKekQ2MTBJNVRLVjJr?= =?utf-8?B?YUFpaGJNRE55SUVtTkYxcGw4L212WG5QN09kMkZpdU5jODFPUTNTODFqclI1?= =?utf-8?B?S3VpaVFoc3NhUXREY0xkQXVhbmFtSWlpRGYrdmt1LzB0OG5uM3BuUjNYdkc3?= =?utf-8?B?cmRTeHVES3ZVNXltYWttTVdpV2NGYlNSRFR6THlKV1Z2UFo2Z01HMW5yR2JN?= =?utf-8?B?bnU0eUVNMFBqak45UjBJdlZock1BdFdhTlJVZ2s0VnF6VWZGZS9nM2pRdlFR?= =?utf-8?B?aHZ2N1lPL1JwS1NJeFlkWU8yajI2ZU5tUWVnRkROMm5lVlhEZENySmwrTnF2?= =?utf-8?B?bEhwSVdyNjZLYnF4TEVvNEJhVmx6WU9uN3VaaHJaTFIyTmNXREVEY3dMNnN0?= =?utf-8?Q?3NNUZ1HD4+E6na7qngEEEIp2gRh9XlHwIye9C892FMej?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: f5fed006-6349-4491-b9d4-08ddaffc7fd9 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2025 13:15:16.9441 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: d9P3IgxOi8KeYCRgg84Qvg3HRITT6jg/ou0K1mD4GPgSRZG6IXaxfFZ8bozwn7rs19z/b8tpBccqlRcjvo7BSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8426 Make use of the functions available in the `num` module and remove the corresponding TODO items. Signed-off-by: Alexandre Courbot --- Documentation/gpu/nova/core/todo.rst | 15 --------------- drivers/gpu/nova-core/falcon/hal/ga102.rs | 4 ++-- drivers/gpu/nova-core/fb.rs | 6 +++--- drivers/gpu/nova-core/firmware/fwsec.rs | 7 ++----- drivers/gpu/nova-core/vbios.rs | 4 ++-- 5 files changed, 9 insertions(+), 27 deletions(-) diff --git a/Documentation/gpu/nova/core/todo.rst b/Documentation/gpu/nova/= core/todo.rst index 894a1e9c3741a43ad4eb76d24a9486862999874e..01dfa858d11fe377c345b463742= c13c37878e334 100644 --- a/Documentation/gpu/nova/core/todo.rst +++ b/Documentation/gpu/nova/core/todo.rst @@ -141,21 +141,6 @@ Features desired before this happens: | Complexity: Advanced | Contact: Alexandre Courbot =20 -Numerical operations [NUMM] ---------------------------- - -Nova uses integer operations that are not part of the standard library (or= not -implemented in an optimized way for the kernel). These include: - -- Aligning up and down to a power of two, -- The "Find Last Set Bit" (`fls` function of the C part of the kernel) - operation. - -A `num` core kernel module is being designed to provide these operations. - -| Complexity: Intermediate -| Contact: Alexandre Courbot - Delay / Sleep abstractions [DLAY] --------------------------------- =20 diff --git a/drivers/gpu/nova-core/falcon/hal/ga102.rs b/drivers/gpu/nova-c= ore/falcon/hal/ga102.rs index 664327f75cf4199cca37d22ca18b2b9abac781f8..9158991ec6e30f42fc0c7e49c87= e2c04b426189f 100644 --- a/drivers/gpu/nova-core/falcon/hal/ga102.rs +++ b/drivers/gpu/nova-core/falcon/hal/ga102.rs @@ -4,6 +4,7 @@ use core::time::Duration; =20 use kernel::device; +use kernel::num::last_set_bit_u32; use kernel::prelude::*; =20 use crate::driver::Bar0; @@ -69,8 +70,7 @@ fn signature_reg_fuse_version_ga102( let reg_fuse_version =3D bar.read32(reg_fuse_base + ((ucode_id - 1) as usize * core::mem::s= ize_of::())); =20 - // TODO[NUMM]: replace with `last_set_bit` once it lands. - Ok(u32::BITS - reg_fuse_version.leading_zeros()) + Ok(last_set_bit_u32(reg_fuse_version)) } =20 fn program_brom_ga102(bar: &Bar0, params: &FalconBromPara= ms) -> Result { diff --git a/drivers/gpu/nova-core/fb.rs b/drivers/gpu/nova-core/fb.rs index 48003527a2472a4a8b784af0d481a441c8d2426e..ca5e7ef997bc2b2855a1d60e813= 00fb99fe04cdb 100644 --- a/drivers/gpu/nova-core/fb.rs +++ b/drivers/gpu/nova-core/fb.rs @@ -2,6 +2,7 @@ =20 use core::ops::Range; =20 +use kernel::num::PowerOfTwo; use kernel::prelude::*; use kernel::sizes::*; use kernel::types::ARef; @@ -119,10 +120,9 @@ pub(crate) fn new(chipset: Chipset, bar: &Bar0) -> Res= ult { }; =20 let frts =3D { - const FRTS_DOWN_ALIGN: u64 =3D SZ_128K as u64; + const FRTS_DOWN_ALIGN: PowerOfTwo =3D PowerOfTwo::::= new(SZ_128K as u64); const FRTS_SIZE: u64 =3D SZ_1M as u64; - // TODO[NUMM]: replace with `align_down` once it lands. - let frts_base =3D (vga_workspace.start & !(FRTS_DOWN_ALIGN - 1= )) - FRTS_SIZE; + let frts_base =3D FRTS_DOWN_ALIGN.align_down(vga_workspace.sta= rt) - FRTS_SIZE; =20 frts_base..frts_base + FRTS_SIZE }; diff --git a/drivers/gpu/nova-core/firmware/fwsec.rs b/drivers/gpu/nova-cor= e/firmware/fwsec.rs index 047aab76470ecb0a0486f6917f6fda69b5381391..0edcade5e8b303ee249397736af= 55c5a6f6fb97f 100644 --- a/drivers/gpu/nova-core/firmware/fwsec.rs +++ b/drivers/gpu/nova-core/firmware/fwsec.rs @@ -15,6 +15,7 @@ use core::ops::Deref; =20 use kernel::device::{self, Device}; +use kernel::num::PowerOfTwo; use kernel::prelude::*; use kernel::transmute::FromBytes; =20 @@ -218,11 +219,7 @@ fn dmem_load_params(&self) -> FalconLoadTarget { FalconLoadTarget { src_start: self.desc.imem_load_size, dst_start: self.desc.dmem_phys_base, - // TODO[NUMM]: replace with `align_up` once it lands. - len: self - .desc - .dmem_load_size - .next_multiple_of(DMEM_LOAD_SIZE_ALIGN), + len: PowerOfTwo::::new(DMEM_LOAD_SIZE_ALIGN).align_up(sel= f.desc.dmem_load_size), } } =20 diff --git a/drivers/gpu/nova-core/vbios.rs b/drivers/gpu/nova-core/vbios.rs index a5889eb149a16beabc0ddbdc87666520114c8aec..cac55d1534831775c14f3fed1e9= 39ed89c7eba84 100644 --- a/drivers/gpu/nova-core/vbios.rs +++ b/drivers/gpu/nova-core/vbios.rs @@ -8,6 +8,7 @@ use core::convert::TryFrom; use kernel::device; use kernel::error::Result; +use kernel::num::PowerOfTwo; use kernel::pci; use kernel::prelude::*; =20 @@ -175,8 +176,7 @@ fn next(&mut self) -> Option { =20 // Advance to next image (aligned to 512 bytes) self.current_offset +=3D image_size; - // TODO[NUMM]: replace with `align_up` once it lands. - self.current_offset =3D self.current_offset.next_multiple_of(512); + self.current_offset =3D PowerOfTwo::::new(512).align_up(sel= f.current_offset); =20 Some(Ok(full_image)) } --=20 2.49.0