From nobody Thu Oct 9 04:14:02 2025 Received: from mail-oo1-f50.google.com (mail-oo1-f50.google.com [209.85.161.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B8FD248F4B for ; Fri, 20 Jun 2025 22:21:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750458092; cv=none; b=VFYDF1VbTyp+m6ct5x3OyKF0hRJMHbK5uX+qhZNug/IOsHj5n+aeozhhE1q+3ppGsGluSW8vqcd6r+U+EyX6TzJd9RECFvSJNlg9sduzp11qPqLntq5JhchnDDOx/Uz6q/yPf/7mGjOIHniRJHBkEu+z9xTn1pgFGMlFQseNrD8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750458092; c=relaxed/simple; bh=UX7Qk+7NOxJbsbC9UcQ9KMGOYrU47zh3dgyBfOfkmSc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=W1iSADabHKz66+FyMsREmSlTuirCclKla20fzb2fmiUxkrrLLtdkvoCqqGdMiB60WyVwJmWJFHYjPGNpP1/KWcWFLRHKlOAki/YB+j3e4n8VNbCuJKFm/3pf6epCjzaEpVZQpqh+sOBCHAXmrv3HzbgY8DMk5ZSaKWV/lOVF4hg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=NmpSGt9h; arc=none smtp.client-ip=209.85.161.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="NmpSGt9h" Received: by mail-oo1-f50.google.com with SMTP id 006d021491bc7-60be827f2b7so1302013eaf.0 for ; Fri, 20 Jun 2025 15:21:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1750458090; x=1751062890; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=JCcWLS8dPTQ4a25bImW7jFTx7RMnzyCqIg4blrEu6+I=; b=NmpSGt9h7smTo/xPE9h8pDWrX0W0m4OhCHajt3hY8M/O2K9OuEOjsXnAJM5G5zeWWJ CK2NMSqbGioc9yI+T7+ZLvfc7yB17Ow+JcvuLHjjCQVJwDgiiYIKVWq95LC5VUNdvAqO FS7VLuNxEkuQnWSWgkpVsEH4KIBIOfsaqKzxAhsbbq+dZPdUVNOuMAeSbJf+NZ5kPKZc 6I1ag5PiwabA+9JnwUK/eNfl4w4tm1QFrKWrZi9RWZ0Xe+275MsYHnnG1/RldsVcg4Wg XeSxLwsdkPxW943/4eV0dRznevFd8VvkIa3nLea+2jDLZQgvryPl3SX8Cx1SEzQIptQi fTRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750458090; x=1751062890; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JCcWLS8dPTQ4a25bImW7jFTx7RMnzyCqIg4blrEu6+I=; b=rKw0Y9EC/xF7mcf0SnK9KA3gztZDNkwW/uitgsRXMaU4kOiPzmKFg9Tq6hd7ZKFE1H E8l9JR1Y6Ho8FAx1zEotmYHGpcTaa1VQwkk++ZpHk8fWJly90li2Js03tcmIsY/j14+v 5p0Y6hlSCtoGjI7pjF4aN0gFuK0IE1of/MDfOd626eOXTE5YHTft5rQg9gzeSXkr4Idj cWV3uGw6UOobuLIcaK6HAf0sVJTIZQYxeT1DaKdW1uBAEAsGqy9quTAb6bwqJw5QkBYt WbhTxbNtwKmVHPMatDvmYjTPEZ2cuwEWGowrn03bcvugWXdiarEs2wWf2mLFs8zi4mzw nfKA== X-Forwarded-Encrypted: i=1; AJvYcCWh+/EMjaqIAd0WKZBIHJYfagvbj7vlCQHvnulvsRr20IoyVqS9ntTYxgEMPVz4V2G28hWy+tzgpVO1opo=@vger.kernel.org X-Gm-Message-State: AOJu0YxMc0xx7v1+7Py+37BrDT9oqfrEp10ZMnKvGS3yXxFWFR87pn5T pg6eRt5aTJ/52ga1iyumLXORiRntoCIsW9wG3SzEVq6l6wnhsPLOIcnzQpkZgnuYwfs= X-Gm-Gg: ASbGncsjR2Cx+0WRrnFHwoPOxHEAzv8NS7WmIuEOCzhq0fnxI9+OAmtaD5I0Teyd/cF 4YzH0hJGK4w3x4AX97FK5orYwIxmUkZlPZmoLiePtA55RgDgGb8aGG2UeWFg72PTt5EBM2j3O8U PPQFgFMoBHfaK5pIzuv7XTVlljaoUxZxMEW2uTCFQ0VoqX9dTa9alNl/qlkHfDoOF+2OMMzsY2g 9F+VBR3I5d4I2otHZAltKdziwyKx4r6Ij44odVZ9RGeOfDuQsJPABzt07CbNlEy4g9lLgPPU0Up 4Saf0Vv8m/oEhdxf8vW8bHUMyrjO6XXO+4Qvm0hLhxVI+5ci9XSuA6pDF539cWmCeJb9 X-Google-Smtp-Source: AGHT+IF2GLud5cD+DfB5URuM0aIY3NYHneGgtodyB2cz+tQIr1/WtBZ+tEE+jOQd4TTZZXS289sX4g== X-Received: by 2002:a05:687c:2053:b0:2eb:a2ec:dc02 with SMTP id 586e51a60fabf-2ef2a952c4cmr1558341fac.11.1750458089654; Fri, 20 Jun 2025 15:21:29 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:c4bf:cf27:203c:f8b0]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2ef481fe06esm7561fac.35.2025.06.20.15.21.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Jun 2025 15:21:29 -0700 (PDT) From: David Lechner Date: Fri, 20 Jun 2025 17:20:10 -0500 Subject: [PATCH 4/9] iio: adc: ad_sigma_delta: refactor setting read address Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250620-iio-adc-ad7173-add-spi-offload-support-v1-4-0766f6297430@baylibre.com> References: <20250620-iio-adc-ad7173-add-spi-offload-support-v1-0-0766f6297430@baylibre.com> In-Reply-To: <20250620-iio-adc-ad7173-add-spi-offload-support-v1-0-0766f6297430@baylibre.com> To: Michael Hennerich , Jonathan Cameron , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mark Brown Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-spi@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2048; i=dlechner@baylibre.com; h=from:subject:message-id; bh=UX7Qk+7NOxJbsbC9UcQ9KMGOYrU47zh3dgyBfOfkmSc=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBoVd63BLhmn+HB7QmyWk8EbmeurR9QlJsuMl3Uw JK5ZEn9KrCJATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaFXetwAKCRDCzCAB/wGP wNzyCACV9VMkV37f/qNR4IYrQCDTE4Gyr8RWjjT9Mt4L6/uR58OZzQeRn0xosTA5hf+6dMpIn4G quzIsNpX6yWjuiSQ6BOp8oNfohOWnp+phkS2M/ADbBQ8Njme63/AsYWaPJ3vWD7FNlCVavB857O ed+kaYrFagaItZiaShcMkKZC/DgYP4N/tI7ivJ5YAMw4XRgbb2Vo6hMGlprukpF1MsmQHzGZ4rL P9iHZYWfsgNN9cL0D9w0YRzwZRxNUg4fShiWkLFRMzkN9WHpJSNe66941B/TJQYxjIn4mYQJE33 STaX+GdnH/Orr4GEnmPjQ1Hl7VvFcQ0f9/gcHpmLS2zhrdm/ X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Refactor code to set the read address in a separate function. This code is already duplicated twice and we will need to use it a third time in a later commit. Signed-off-by: David Lechner --- drivers/iio/adc/ad_sigma_delta.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/iio/adc/ad_sigma_delta.c b/drivers/iio/adc/ad_sigma_de= lta.c index fa792c800c80f960aca75b28a60cb2588e69fe7d..883cc02d4099908644af523bcf6= 6c0178fbd0e55 100644 --- a/drivers/iio/adc/ad_sigma_delta.c +++ b/drivers/iio/adc/ad_sigma_delta.c @@ -100,6 +100,14 @@ int ad_sd_write_reg(struct ad_sigma_delta *sigma_delta= , unsigned int reg, } EXPORT_SYMBOL_NS_GPL(ad_sd_write_reg, "IIO_AD_SIGMA_DELTA"); =20 +static void ad_sd_set_read_reg_addr(struct ad_sigma_delta *sigma_delta, u8= reg, + u8 *data) +{ + data[0] =3D reg << sigma_delta->info->addr_shift; + data[0] |=3D sigma_delta->info->read_mask; + data[0] |=3D sigma_delta->comm; +} + static int ad_sd_read_reg_raw(struct ad_sigma_delta *sigma_delta, unsigned int reg, unsigned int size, u8 *val) { @@ -120,9 +128,7 @@ static int ad_sd_read_reg_raw(struct ad_sigma_delta *si= gma_delta, spi_message_init(&m); =20 if (sigma_delta->info->has_registers) { - data[0] =3D reg << sigma_delta->info->addr_shift; - data[0] |=3D sigma_delta->info->read_mask; - data[0] |=3D sigma_delta->comm; + ad_sd_set_read_reg_addr(sigma_delta, reg, data); spi_message_add_tail(&t[0], &m); } spi_message_add_tail(&t[1], &m); @@ -281,9 +287,7 @@ static int ad_sigma_delta_clear_pending_event(struct ad= _sigma_delta *sigma_delta if (sigma_delta->info->has_registers) { unsigned int data_reg =3D sigma_delta->info->data_reg ?: AD_SD_REG_DATA; =20 - data[0] =3D data_reg << sigma_delta->info->addr_shift; - data[0] |=3D sigma_delta->info->read_mask; - data[0] |=3D sigma_delta->comm; + ad_sd_set_read_reg_addr(sigma_delta, data_reg, data); t[0].tx_buf =3D data; spi_message_add_tail(&t[0], &m); } --=20 2.43.0