From nobody Thu Oct 9 04:14:02 2025 Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C970A2472AD for ; Fri, 20 Jun 2025 22:21:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750458090; cv=none; b=um6/kOJKG4oifhwdRpmPBbHM8TDk6nTqTBmEG6qXj8yElLBxjVA3d/UN37c2Aurcs7I92Fr36doQRAAce4shJ3wVH2SDDQqNBwYoTVZKHyoPP6DA9QpJQyNKIz/vzoD4ioe8uGfoMBEQgmEdNp9zQqS8qQf+83dkVQNhR1WZMS8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750458090; c=relaxed/simple; bh=ndollx0hHuXyYrWgV+w7a0yS9z8LaB+bJawqeWV7C1E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TwqXpHn7jO85nOEST6MxBgu0Vl8apZIWMZfpaxaJz0df1JhAaRR2lRMdTDgqo8By18zzfIUka5rvsfwbpeOX86xS7NnalWoVGLwQjICEICPxksNLn9RxA6G4BmqkSqpeXxD6gu3d7A2Eb+HSzv7LzzOhb+gabw8VS6p7UHrDLNQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=1OVCScBd; arc=none smtp.client-ip=209.85.160.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="1OVCScBd" Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-2ea0086338eso1372807fac.1 for ; Fri, 20 Jun 2025 15:21:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1750458088; x=1751062888; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=l3u6qop3BKgIw2zioaLcZOAXEzoElBarrBAd4z+BUYE=; b=1OVCScBd4yrIlZmue9sSiZMcFX6Wmxed5oX6wU8BgFDG8uTs0Q9+z2fZwP/tEEg3Cn +0dc4vTYDtW2aUryy+H9bYGPcXg1ZHonnLTKQ4Qc+QUkMJPgCuwSP4vhIQvDvReepcpN 9v1DR+tBHa0F2GCBH3MDY7V7zlZ/47fxLOpR8PJB3VvhZTQPchDU8Gz7zENTkb7Appbc 0qKUd8lHUfkck1juG2d4GgkLFstxPTTuns6IjboDVh6gwS6ILK5JGFo+tSDtVk2CGWRu 1w0tb+VPmXOnTohAyqToxaDnjxaMFTT4JrHWBYHL7PUCOzix7cW0GMAMZCqpykcHQDsu 5FGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750458088; x=1751062888; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l3u6qop3BKgIw2zioaLcZOAXEzoElBarrBAd4z+BUYE=; b=qwmE6ab/pAR02I8VY41UgWYWAwH0e9e9rj5mb6UOUyBUMCtQonil7C/C2BtrhC8nPd rbXcSQk5MNmy1u27eXX6OMb4OeJPGOx8w03rG+C1vN8icnEF1/tPwtlxL0i79qLcxClO LfIDXDUrjcS42h1sL76LFoQiJzT9bn50ASvjw12h8GFCRHqcfvVk5y1PVx1uCdLOaoWX bj4pS/KsYGsiBooj5j0M1U2oP7dOqHsvotATLfV5mWwFqmHlGT8qeQpL9s1KIBIeJx36 hP2U5410dX1pO7MI5sm4r5gdHdSuOTJgsLRdrDHJ6FySB6qXWUGVSFt7ImFMub6KyU7m r5ew== X-Forwarded-Encrypted: i=1; AJvYcCWHTB+xjHsTWlTsGaMAvNmOsq3QwsAXg3GkANpOyTOYOSKmI3eDpB7rirsb9SFtVm0cg+a1M8TWmkDEpZU=@vger.kernel.org X-Gm-Message-State: AOJu0YyMkP5yt9Dk2kuYw5gE03eR2qWiMtGbqFyibcztGnTXdrDx0WB6 6DiOqDJF5kYydzvnAHzIppdSUX3AbHn0GvFKfV/mX64SgZu32Qj8gC3ToO41kX5ZVTrMgljXqtf UJsrI X-Gm-Gg: ASbGncvWLxOKzQQMu/jtnAiWJxOU6Wo4AQnZRdnNtiipsLKiKstGX8GVKBGwJCecVjY 81GkUQG6KMIH/XeXOC8APYtSpFa1ql9W5bg2kpBOMyPiK36WCBa7qnFCmxJ4HCVlUPOGxsn9fYw nYu0p3dI66ovrbIEa6oMPcAa8zaeL0J6I0TnmAxtA48ntr7MkEIOjQ5Ch1tCcgmFrLzKfzulKN8 xWTMJGLsWqos13cQjZvoLrmwJUsh3pN1uCII0CvNMXjYlg6O4eME0GZC7GbYH2aR+97jwdvuvop +s6UcTc/TdnPKzg26wAFuLzp5Rh8xx58OJdY/1ewgR3HP159o6GFd4aMJvdu10Du4L36U8PElYn guk0= X-Google-Smtp-Source: AGHT+IEX1777Y06ItcBBP4l8QpCXPpcGQh9aDgmKoVRPlC3y0zOyjItWT/vafA/dCJ6lPmB+M/q+RQ== X-Received: by 2002:a05:6870:d68a:b0:296:a67c:d239 with SMTP id 586e51a60fabf-2eeee37f070mr3109724fac.12.1750458087845; Fri, 20 Jun 2025 15:21:27 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:c4bf:cf27:203c:f8b0]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2ef481fe06esm7561fac.35.2025.06.20.15.21.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Jun 2025 15:21:26 -0700 (PDT) From: David Lechner Date: Fri, 20 Jun 2025 17:20:09 -0500 Subject: [PATCH 3/9] iio: adc: ad_sigma_delta: use BITS_TO_BYTES() macro Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250620-iio-adc-ad7173-add-spi-offload-support-v1-3-0766f6297430@baylibre.com> References: <20250620-iio-adc-ad7173-add-spi-offload-support-v1-0-0766f6297430@baylibre.com> In-Reply-To: <20250620-iio-adc-ad7173-add-spi-offload-support-v1-0-0766f6297430@baylibre.com> To: Michael Hennerich , Jonathan Cameron , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mark Brown Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-spi@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2415; i=dlechner@baylibre.com; h=from:subject:message-id; bh=ndollx0hHuXyYrWgV+w7a0yS9z8LaB+bJawqeWV7C1E=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBoVd6wKUFl+BJbccGKOMPDZhFwWwlJmZlKp6484 HjZvLArD6SJATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaFXesAAKCRDCzCAB/wGP wKsgB/9q9AuTiwp7lOJRANwMucpfkpzJOrpHn8CkltOpI+aWNp+Kfyl6OBefNM8op2eNGutdhyG VapTsUmBy0YlNJe7zvGtVAyLLM77dKAWW+fHlZHAim6sSbO7dqepIrFVLEcPVaLOi94ij59dHeV XgJRxbNmWmeOBxCd4a3hj9ktQZw1X6YW89PXT9SJOxmtZJC2VdAq4p5iik434ZpESQ1vOFdBLc+ oUtDwBLov6N/UG3U+Ids7BV8Gt1HIgLGMT5wLP3kfqKjHRsUfb+nZ0QKU1O1YJtuirDAzJVRZ8z RUCX8asPQ3mICKuA90/dTn0yya84VK9/4anBMUm3qqpUXhuS X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Use the BITS_TO_BYTES() macro instead of dividing by 8 to convert bits to bytes. This makes it more obvious what unit conversion is taking place. In once instance, we also avoid the temporary assignment to a variable as it was confusing that reg_size was being used with two different units (bits and bytes). Signed-off-by: David Lechner --- drivers/iio/adc/ad_sigma_delta.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/iio/adc/ad_sigma_delta.c b/drivers/iio/adc/ad_sigma_de= lta.c index 1657f64f1c0465b249adcc8a70dda8faf4a90565..fa792c800c80f960aca75b28a60= cb2588e69fe7d 100644 --- a/drivers/iio/adc/ad_sigma_delta.c +++ b/drivers/iio/adc/ad_sigma_delta.c @@ -7,6 +7,7 @@ */ =20 #include +#include #include #include #include @@ -190,7 +191,7 @@ int ad_sd_reset(struct ad_sigma_delta *sigma_delta) unsigned int size; int ret; =20 - size =3D DIV_ROUND_UP(reset_length, 8); + size =3D BITS_TO_BYTES(reset_length); buf =3D kcalloc(size, sizeof(*buf), GFP_KERNEL); if (!buf) return -ENOMEM; @@ -419,7 +420,7 @@ int ad_sigma_delta_single_conversion(struct iio_dev *in= dio_dev, data_reg =3D AD_SD_REG_DATA; =20 ret =3D ad_sd_read_reg(sigma_delta, data_reg, - DIV_ROUND_UP(chan->scan_type.realbits + chan->scan_type.shift, 8), + BITS_TO_BYTES(chan->scan_type.realbits + chan->scan_type.shift), &raw_sample); =20 out: @@ -552,9 +553,8 @@ static irqreturn_t ad_sd_trigger_handler(int irq, void = *p) unsigned int reg_size; unsigned int data_reg; =20 - reg_size =3D indio_dev->channels[0].scan_type.realbits + - indio_dev->channels[0].scan_type.shift; - reg_size =3D DIV_ROUND_UP(reg_size, 8); + reg_size =3D BITS_TO_BYTES(indio_dev->channels[0].scan_type.realbits + + indio_dev->channels[0].scan_type.shift); =20 if (sigma_delta->info->data_reg !=3D 0) data_reg =3D sigma_delta->info->data_reg; @@ -616,7 +616,7 @@ static irqreturn_t ad_sd_trigger_handler(int irq, void = *p) } } =20 - sample_size =3D indio_dev->channels[0].scan_type.storagebits / 8; + sample_size =3D BITS_TO_BYTES(indio_dev->channels[0].scan_type.storagebit= s); sample_pos =3D sample_size * sigma_delta->current_slot; memcpy(&sigma_delta->samples_buf[sample_pos], data, sample_size); sigma_delta->current_slot++; --=20 2.43.0