From nobody Thu Oct 9 06:12:41 2025 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEC4E1E7C1C for ; Thu, 19 Jun 2025 17:52:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750355573; cv=none; b=FBcPdfVkFIPWeb08IojHHjpROP3qdMfelIUTKuNKHCDbklZDh+WGhWwJ+vYSfLgYOBpopxrSs2YUbXOWXKEmXwr2/hk3kXenZ4JC94jCEqJSCxYmzHNw+vjQiNhcIdot88nE9XfOkYug++mi5PScSh1VKutr+nB9b9tUBIi/qyA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750355573; c=relaxed/simple; bh=11ng1f6VPwCvI+8XO7NWn6w057suUPB/xBIrVu/g/yw=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=opewUbUNmJPL1nDwBo2DfbtGkmG3Onxld0PXP7Tq0NQZZ8HsremzHmlacMydwJsj/WoQcVfPXrytbLjiKSO9B6GD0wHhDmkJ3BKI2yvwQLpKLrIW5s5ZYZSe/EnsizswL5UAxIOkd+SDF5xmNTbHSBraqk37th3z6KMvtbdkxQY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--almasrymina.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=kDYUTkRz; arc=none smtp.client-ip=209.85.210.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--almasrymina.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="kDYUTkRz" Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-747cebffd4eso816017b3a.2 for ; Thu, 19 Jun 2025 10:52:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1750355571; x=1750960371; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=kKAQxo09G5cPv5qwWN16POW5i7zkedHBeHYLB/DKhXk=; b=kDYUTkRzBpifw3J8v43aS610ADumWc2i0IQOmYGe1O9mJwk9b+4KI4j0FhEgnAPh0B x/lL99xFO7d9jytmxKFB0bc9Jgul5aBU+QHV9Kozgxg4jKPm+Fo5C2kWZKyAdRhbsHXd YM0BZCz2hHglJHaSh8QLGE/EVckFcPgoalesAPyhrqgeNZMuiTrDhTObyC8S9SIVma87 Nf36L7Rc+HD9vXr8Y0Bc39OvMju4kJkU8EqIrtptIJ9sLPNwc7VXCfv9fhhfQQ/fKuku 4E25vtKEeYobt2rc/NaI4plmF1PyOqO1qyW5ZcLQkFw0T1j09E4OhDCILwMc1Zi5V3e8 x6EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750355571; x=1750960371; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=kKAQxo09G5cPv5qwWN16POW5i7zkedHBeHYLB/DKhXk=; b=If5r3jOkbgC4eQiaNeTPYU9FfsoN5ApY4A/yFPK8QaaSQ4IIZwv4q8mPAbijrCCGYq LHQ/y09RYEabRevgUDEB2Iq0nBF4LpeYeKuhf5fZFWHG+HrUNoLUOywhdO1mvQd+KUFp PacMhPdaB8Bg1aenbM6HsEn+nDKIAn7nP/8e7XQGK/rAkke5Hx6FAX7++oqGPi3/Fmdb V8SQlgYfrg8VWT6uyXtNDJQkHJHekBlCtwS57VuwMnu/mQQh1fRV/R9sIXhVkpkO+3ng 7ZunjXyLYPvIVtP36YchRAnJJxf+E9JoWZT5VOvOkTG+BV2OWn7gtYDn1KqlnMtD+vBT 9uQw== X-Forwarded-Encrypted: i=1; AJvYcCWko/jWplk30d08ez1bLd9yKpzwsV6F6tNiMQiGOLvCP9AslABX6mQ1UKHDWXmBSQTD8G8Zv0nyJU47Z5Y=@vger.kernel.org X-Gm-Message-State: AOJu0YxDCXis0xU0Mme0kPP6ToFnZDSTqElKtYPc8tP7iv12KsniAOZq xM1VfxSloJkBXGMsmp8I0iEaH5I5T4RKXRePAOJHHXygIjOy+S+Em+m4bcFlR5gGyMKliVGRkC2 QOIOjMHM1hy+KfLIXIGsfSp1pGw== X-Google-Smtp-Source: AGHT+IET5o2P4wUYb7dd58G56SGW2P48lKGW3j+rhDyrZHG0JDXaF5FQiMdicsGmxzV+16PzB+pmpmYbPzshlxEX1w== X-Received: from pfqf15.prod.google.com ([2002:aa7:9d8f:0:b0:747:9faf:ed39]) (user=almasrymina job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:4b13:b0:748:3a1a:ba72 with SMTP id d2e1a72fcca58-7489cffb748mr31583409b3a.20.1750355570964; Thu, 19 Jun 2025 10:52:50 -0700 (PDT) Date: Thu, 19 Jun 2025 17:52:38 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.50.0.rc2.701.gf1e915cc24-goog Message-ID: <20250619175239.3039329-1-almasrymina@google.com> Subject: [PATCH net-next v2] netmem: fix skb_frag_address_safe with unreadable skbs From: Mina Almasry To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mina Almasry , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , ap420073@gmail.com, Stanislav Fomichev Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" skb_frag_address_safe() needs a check that the skb_frag_page exists check similar to skb_frag_address(). Cc: ap420073@gmail.com Signed-off-by: Mina Almasry Acked-by: Stanislav Fomichev --- v2: https://lore.kernel.org/netdev/20250617210950.1338107-1-almasrymina@goo= gle.com/ - Move to net-next - save return value of skb_frag_page --- include/linux/skbuff.h | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 9508968cb300..4f6dcb37bae8 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -3665,7 +3665,13 @@ static inline void *skb_frag_address(const skb_frag_= t *frag) */ static inline void *skb_frag_address_safe(const skb_frag_t *frag) { - void *ptr =3D page_address(skb_frag_page(frag)); + struct page *page =3D skb_frag_page(frag); + void *ptr; + + if (!page) + return NULL; + + ptr =3D page_address(page); if (unlikely(!ptr)) return NULL; =20 base-commit: afc783fa0aab9cc093fbb04871bfda406480cf8d --=20 2.50.0.rc2.701.gf1e915cc24-goog