From nobody Thu Oct 9 07:05:20 2025 Received: from AS8PR03CU001.outbound.protection.outlook.com (mail-westeuropeazon11012027.outbound.protection.outlook.com [52.101.71.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67ADC265CAF; Thu, 19 Jun 2025 09:14:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.71.27 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750324465; cv=fail; b=hSyRVpObEe2+xlxJ4ub98hjcVQKavWCjdjs6RNXjAGhTd/c03oeCAmEAnju64RsO0w9lSSOrp/6XPNH9QkoauFiAddlAwSOwyXrlKZiXgaVIAA4ETDgR/l16KdR7eu7k6wnqsqIVPryuT5yuUz8Dsng7FAPUpl65OWOGHr3XkZU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750324465; c=relaxed/simple; bh=+kWgDC/aIY7HcrJSs29GJD9pSPwQmCsCxj43vZf+2DE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=ZkgtnNbUI+AKhoeVOhg00YepX3Vw53mNqdr0kKtuailpxv2d1Kn7RrsoMvKXsg8bq0bcJRHL0FeHdXYelFO0yv3wuEGtOgd4cmPfPHnjKumChjSuZBBtIgKZt7PQwdd/ft5RlAH8JS+o02Wf0L2sMe/Ek7YqJHiVSmAWshoZO1s= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=APnhX2pb; arc=fail smtp.client-ip=52.101.71.27 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="APnhX2pb" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Is0fkgOUSI5eHgAf9z1kuXAGIm79GxCy2zr8N5WKSABl04AQH0wZe/nR8e0M6docli2L8JjXvTrNkywclmD3+zY9cq4z9HQrbwX69fCjG4UHw8l0faWAxi3q/yjCrFgtIzshXt+C+lz91E3tpD299AVXOwa79T7TN5j79tav/FhoObyRr/1a+SuLgd1AVd2AbFWiqhgRu1e+TLJ5Sgc3lry0wcJ1HhbFFeOTXdi9flf1OOck27BpZko3vFoKnoAweWmWDt3b/JzKw3cajBTfXKDiPu9mpuKGe7lkveuVpyWLbYrrjf+vigZKhQPcfzG1U2NYejDatdvuE95HfgddKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MvVLufjuDVUtzX9TsNciLHzPlZJQnZSZVGgAP5m4mLY=; b=lcX8xG1UqtrecBUFUh/9oDKF15tgRR5GQl0ktmAmgzBcHw/SA3ka2gfXyjxu6oKjFq+ZhSUfLEajiKyCjRQlCbGaLYkXojuMFUfnnRNO7Tj9tv2jRT41IIrVPSDVRLhf5KlTcgb37bnsxdjMoujjpbktxsOh+cew1UJp6quzCIhy8jeVFw1JP9/358PfQpZ7+SM1aAtVkjTQfYCNU6QH0Va1YydNJ8ALHbH0SGl5vviRXMbn8Bk0gmW6H7PolxIvRvFLPf0bek3zdVTegcQoqbYa9FH3Y8+vBLGkg+FB67OYzVh2Ev+3MruAMObOgEsYZtG5tdE8LgvP6WzM0zBXsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MvVLufjuDVUtzX9TsNciLHzPlZJQnZSZVGgAP5m4mLY=; b=APnhX2pbK+LgbBfX2DGiDMk/jxbcl1wV7I6V7EtlgRS/NZb4hbsBDOaD0a8kjS7USpAcSGf+xlOGGf5MmNI269u3aHlpnVcqh7Earff9NgRWywHSTRNr5aqlQvDBDWEEHKmKqpqQtEs9ZqWBckJldP/s8VD5XlLKy9KL/Sxg3xiSwM6zpxKsaxlbAHPWRiVsElaQsWSo8p2+QRRJkFJRTGqIXeuniHrsby9z6E7PgyAoC776NWZXWcoNg1lHMfC+fzwtOfLQnaajF0hTMPbVysMXdx/UClUp+zOFzPpxAkTTC65vEKf03KSzmnt5A6yGsOwfcSUJ0olyYNE7J9xEDw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8676.eurprd04.prod.outlook.com (2603:10a6:20b:42b::10) by VI1PR04MB7021.eurprd04.prod.outlook.com (2603:10a6:800:127::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.21; Thu, 19 Jun 2025 09:14:20 +0000 Received: from AS8PR04MB8676.eurprd04.prod.outlook.com ([fe80::28b2:de72:ad25:5d93]) by AS8PR04MB8676.eurprd04.prod.outlook.com ([fe80::28b2:de72:ad25:5d93%4]) with mapi id 15.20.8857.020; Thu, 19 Jun 2025 09:14:20 +0000 From: Richard Zhu To: frank.li@nxp.com, jingoohan1@gmail.com, l.stach@pengutronix.de, lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, robh@kernel.org, bhelgaas@google.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, Richard Zhu , Frank Li Subject: [PATCH v3 1/5] PCI: dwc: Don't poll L2 if QUIRK_NOL2POLL_IN_PM is existing in suspend Date: Thu, 19 Jun 2025 17:12:10 +0800 Message-Id: <20250619091214.400222-2-hongxing.zhu@nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20250619091214.400222-1-hongxing.zhu@nxp.com> References: <20250619091214.400222-1-hongxing.zhu@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SGBP274CA0010.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b0::22) To AS8PR04MB8676.eurprd04.prod.outlook.com (2603:10a6:20b:42b::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8676:EE_|VI1PR04MB7021:EE_ X-MS-Office365-Filtering-Correlation-Id: 6917d9dd-7b16-4c27-a932-08ddaf11ac91 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|376014|1800799024|52116014|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?utUI8L7sN+CAS/jDjCGL9O8SmSZJS4j7vC1AmFaiazcGzVwFlnd9UhR1B6dB?= =?us-ascii?Q?4vCzJzEmhDb/MF41V0aeJylNWn9Yhlj9IctvcDzfoIf8RoWYkovsbZFiPZ+Q?= =?us-ascii?Q?qHlPfvA5lHRWwlsyQrJld4KA4orDDbxqFNr3N073IHgdDoSzQnVkKCyz4xkb?= =?us-ascii?Q?iaijfCrMyTxpbgDoGeiqTHlMgh47EKQSdod5yfmKZBKTfxCOvpNwte0DMv3h?= =?us-ascii?Q?Hut5kvi3lOq3gt9g5DmwKQfSAHuZL5kHGFwp9qzwwFCGVRIcKzNAs6UYOSwm?= =?us-ascii?Q?f+7vEoTidcIQqLALcYdgIPEEmjsdeOTZ7o2rXhtO+yZ8Kp5kyDdhegOzTb4Q?= =?us-ascii?Q?sL+SHJOdGzWz/CaC9cteqVKU0V3mO5GM+O5FsmdYCyhcNxbMo/s3RoG9SduP?= =?us-ascii?Q?/eRvNTs4htLBVCdfharK3OlnNQ2ptDEsEvlnPgjQmLZBWhHWXYieEEPyQMOe?= =?us-ascii?Q?/3B+OxmGjGGq9CcG9qSeyx5u6mB+wna0b758ImdP7aIymVHI78ZSSXyq3ZGL?= =?us-ascii?Q?wBs7FjFZT/VdM76FfeFqUo291ZPYn2E/rz1s6LJGtH+I/UMykk489exZNO93?= =?us-ascii?Q?Z2o6Gj8J3mz9I1eLvqs6V0hgBT4Mh9V4CH8nnXU48AuoRQwoqTBvyjKwUIVG?= =?us-ascii?Q?ywHeyf1GVY+AUjdJkiqxvsvzKvIexc/FzIR2eXxs0Jd2yHGU1JLPci1K2WSB?= =?us-ascii?Q?P4Ukba6kyKPSTTLTM3Riko2b4/8/6Y9FfG7XEd3A8PZflwMq3qxSeBixxrag?= =?us-ascii?Q?2Mj+4LgUbQV+ObGnBBxmRk4dAkTXYFpvT0CWQkDaZzc9f3a9VdAGR9r6SWyX?= =?us-ascii?Q?1Xn58mzvkx2JiobvHLkmCOiQhY2FQx6NPwZ1udzphGaDpe4NZJNPR2sYTV3F?= =?us-ascii?Q?dC6oH2PfWT8+7ASiid/kDtBgocB0cm+KG1FrO/5Thv4Gl9k0flcchIhKv+ce?= =?us-ascii?Q?2Jjhh+BEd8dCRfj78O5bvi1jKUQuhxNCnGT55NH7wlizBJ0rpRl1UwCp26cO?= =?us-ascii?Q?yMaVLdMNcBrlRBr/MB7BWP2fijXRBMbABXtYq4AaJQnDzt5trqynnVonBKlr?= =?us-ascii?Q?lYzyYPpAhqqqAhb4hySQGFMtUjDsGMpf8Y/5HJj0lXDTDZrH6ussd6BDwOb0?= =?us-ascii?Q?4NA1d5Cnh7j4CJkloL1jMJU/VCs6HNOqfrLvREel3NbOdpzbx630G0AGWJjB?= =?us-ascii?Q?gFyEzQ1fbxsO2Sx1cleJde+YMJ4RMmy6/d1XZZ7ltiJTtpa0HG3e6/A8sQm1?= =?us-ascii?Q?/q5BydsnWpsnPtiZ9n3GGDR4d7UVTK7qf59Ttq5dk+1rGogKg4uTT7esBSQx?= =?us-ascii?Q?v9dx4cEdg3aJOJz8OR8DqwRurTiVeqoc4nYg8OUWF99gU7MXq253QZuLDrAo?= =?us-ascii?Q?JJQYbvP+hXtkR9CSadKvXCRN5JQic1i3KW+SmTQJ17hhCPqUjmHm8HO2KXqN?= =?us-ascii?Q?XhCMUQiC8Bjn699DLJdCrf2gKjtm3MEujv/+Tbax+5JHcHACTOpscRmiHTLK?= =?us-ascii?Q?jvA6h45Qe2N/Cy8=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8676.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(1800799024)(52116014)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2Fjgsy/ivPLwUk9j+54WObIF8b3yGgYjF9Z2bR31kNf1DdxTHG5fI06JTQbU?= =?us-ascii?Q?MaPY1OCQcBnVjYXClZycX15ZgFAhMgO3h6TePKpPbUJ62zCZV3FqZDB3khfi?= =?us-ascii?Q?09qF1rOoWeQIOYcQlZH15K84XilJpbXIytqIw/9JgNH6Wm7DM7Zu7gJqXhpM?= =?us-ascii?Q?B2W3obwqjSA5wWRRkZIDMm12KDSrUGps17ZUbizrRec0g/faPEjbXjpm1fM5?= =?us-ascii?Q?cC9KVvnmHfGUCqrR//XLgXdzyfc0+ydjKBTN1VywbCE97Q+D9ng1fYMxOIy+?= =?us-ascii?Q?8o3UglloSOOx9TC0DsZa0VfQ/w1DBSzSBqlX4CcgrdSPP98wQoXamhui6aLQ?= =?us-ascii?Q?Rpo1/YLWBK21YtsD/SEwg1IRWDZbnGXzJOyqrBsb5Zv5Ov17w/HBFRs5BxTm?= =?us-ascii?Q?Itl+17snPI04ThR6CfcMCE5zSAArjKoO06SHBN2tMjVNLxFNsY+Z+yliLXMx?= =?us-ascii?Q?PPDdyalxeSAkiNszGy5GhjtYF3ZKzDL+Mlqq7qYMfJGHcqzMcUfZgcFIqzqA?= =?us-ascii?Q?yg9nMqXYF1L3Ucd50HjOKpMs+jmqRdGMT0ubE6Rqe6nvB1i/y2VNfYr7ymSa?= =?us-ascii?Q?rQmmXYkE3DHv6MgwhaVPC6OiPziedqwd+cwYrtBszjcsESXjeZCJtI5us+cS?= =?us-ascii?Q?bXc137x/YcJmVsyj/nlE3BViIhqUkLUaQeufOBu9hbDtN+u5BlMeflhWHjFD?= =?us-ascii?Q?BjOR/ucJ5tr3ghOqxuvgm7nnLH8mFo99a8vZ/BcXeN894Rx6xjU8XoXTX7et?= =?us-ascii?Q?rM5PjrLMNhTxnqabfZQGVWTQt3SOmSTyqFvpx+zRAOO0FsId/rrpk/KQtkoz?= =?us-ascii?Q?45zOVMx6lBgDSv0nGjTwWZoicmqbQjs+iai3dTEb8RZOWUsFTwid2yRMNRBL?= =?us-ascii?Q?Cvp3eH/BxMRfRgqzP5zy+txZ9f2sxONhsZeyyjdcOLx8C0t0iWRxtVO7jHyv?= =?us-ascii?Q?8ONAOMsgzbJ3t/U2WiCHEwPxjV9rbwBsu58XyITWhN95KOV6JtitbCRWGK6U?= =?us-ascii?Q?i9eNeJmb/xTd/86lpSMnTKTcbKDH8jyPOuzBTLOj9N5rmNFa0iyoM5JGKxT+?= =?us-ascii?Q?MnTTTWxMUBiT252O3GwCeUdnIc7AIA95Tpn0cx5suTdKbp2HPjT3UBah9G+z?= =?us-ascii?Q?D634nqIrH7GQ6WgV25pWmdH8w2Gz0uIRH/lUtsQys+Wjvi7ppSWyDIu8n1By?= =?us-ascii?Q?3Ws3jmztESP64qh+AVJuzshGRx2IbiACQl90XhNRiomlnFC+4/3Gih7NtfYS?= =?us-ascii?Q?y/KiPRSu8KVVbpNhsktxhF9sgydfHGy9g2nirjoRsLq7TSMQhJnYomB4QpN6?= =?us-ascii?Q?9VVLZtwN9/r2xuj0KYY3/iydJdpztuvUvqaUKmrMDPWrrCVj4Z0gAcJSdHZy?= =?us-ascii?Q?XoS7Y9rzbscK/rbvgtP7RhB4raVl7fSGTOKnogXp/LPQ8Uvh/oGEJh40RV9U?= =?us-ascii?Q?zo6pW5MgkKfUYTDk+3SsZueqcNMkseAmmFtaq2njIGI2TfPy1CC8k5M/S3z9?= =?us-ascii?Q?1/CVAPikvUPwLprwF4VP3h1s82zQj8pFZ/nHRaTaDWkZBPJd1dlh6qZycQsi?= =?us-ascii?Q?JWP9I6/e1LuuOfptV5a+UOMOswcXvcoPu811raL8?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6917d9dd-7b16-4c27-a932-08ddaf11ac91 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8676.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2025 09:14:20.3654 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8cz8h2g0YIj5nrAN8P5yPwhkD0m3garkEsY5dfWaj/8sYgowdgHuiy8u/GC4JYLHSukLUTAa+EbqjR9T8GIaMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7021 Content-Type: text/plain; charset="utf-8" Refer to PCIe r6.0, sec 5.2, fig 5-1 Link Power Management State Flow Diagram. Both L0 and L2/L3 Ready can be transferred to LDn directly. It's harmless to let dw_pcie_suspend_noirq() proceed suspend after the PME_Turn_Off is sent out, whatever the LTSSM state is in L2 or L3 after a recommended 10ms max wait refer to PCIe r6.0, sec 5.3.3.2.1 PME Synchronization. The LTSSM states are inaccessible on i.MX6QP and i.MX7D after the PME_Turn_Off is sent out. To support this case, don't poll L2 state and apply a simple delay of PCIE_PME_TO_L2_TIMEOUT_US(10ms) if the QUIRK_NOL2POLL_IN_PM flag is set in suspend. Signed-off-by: Richard Zhu Reviewed-by: Frank Li --- .../pci/controller/dwc/pcie-designware-host.c | 31 +++++++++++++------ drivers/pci/controller/dwc/pcie-designware.h | 4 +++ 2 files changed, 25 insertions(+), 10 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pc= i/controller/dwc/pcie-designware-host.c index 906277f9ffaf..2d58a3eb94a1 100644 --- a/drivers/pci/controller/dwc/pcie-designware-host.c +++ b/drivers/pci/controller/dwc/pcie-designware-host.c @@ -1026,7 +1026,7 @@ int dw_pcie_suspend_noirq(struct dw_pcie *pci) { u8 offset =3D dw_pcie_find_capability(pci, PCI_CAP_ID_EXP); u32 val; - int ret; + int ret =3D 0; =20 /* * If L1SS is supported, then do not put the link into L2 as some @@ -1043,15 +1043,26 @@ int dw_pcie_suspend_noirq(struct dw_pcie *pci) return ret; } =20 - ret =3D read_poll_timeout(dw_pcie_get_ltssm, val, - val =3D=3D DW_PCIE_LTSSM_L2_IDLE || - val <=3D DW_PCIE_LTSSM_DETECT_WAIT, - PCIE_PME_TO_L2_TIMEOUT_US/10, - PCIE_PME_TO_L2_TIMEOUT_US, false, pci); - if (ret) { - /* Only log message when LTSSM isn't in DETECT or POLL */ - dev_err(pci->dev, "Timeout waiting for L2 entry! LTSSM: 0x%x\n", val); - return ret; + if (dwc_quirk(pci, QUIRK_NOL2POLL_IN_PM)) { + /* + * Refer to PCIe r6.0, sec 5.2, fig 5-1 Link Power Management + * State Flow Diagram. Both L0 and L2/L3 Ready can be + * transferred to LDn directly. On the LTSSM states poll broken + * platforms, add a max 10ms delay refer to PCIe r6.0, + * sec 5.3.3.2.1 PME Synchronization. + */ + mdelay(PCIE_PME_TO_L2_TIMEOUT_US/1000); + } else { + ret =3D read_poll_timeout(dw_pcie_get_ltssm, val, + val =3D=3D DW_PCIE_LTSSM_L2_IDLE || + val <=3D DW_PCIE_LTSSM_DETECT_WAIT, + PCIE_PME_TO_L2_TIMEOUT_US/10, + PCIE_PME_TO_L2_TIMEOUT_US, false, pci); + if (ret) { + /* Only log message when LTSSM isn't in DETECT or POLL */ + dev_err(pci->dev, "Timeout waiting for L2 entry! LTSSM: 0x%x\n", val); + return ret; + } } =20 /* diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/con= troller/dwc/pcie-designware.h index ce9e18554e42..e35b19cbd8bf 100644 --- a/drivers/pci/controller/dwc/pcie-designware.h +++ b/drivers/pci/controller/dwc/pcie-designware.h @@ -299,6 +299,9 @@ /* Default eDMA LLP memory size */ #define DMA_LLP_MEM_SIZE PAGE_SIZE =20 +#define QUIRK_NOL2POLL_IN_PM BIT(0) +#define dwc_quirk(pci, val) (pci->quirk_flag & val) + struct dw_pcie; struct dw_pcie_rp; struct dw_pcie_ep; @@ -509,6 +512,7 @@ struct dw_pcie { const struct dw_pcie_ops *ops; u32 version; u32 type; + u32 quirk_flag; unsigned long caps; int num_lanes; int max_link_speed; --=20 2.37.1 From nobody Thu Oct 9 07:05:20 2025 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010026.outbound.protection.outlook.com [52.101.84.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24B842673BD; Thu, 19 Jun 2025 09:14:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.26 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750324471; cv=fail; b=qhIpfu8AFrhbexlKYsb3HfA1li/2AR4bWjBdlpM9bX9WKfj6GAKr4WagDVC7cEYpHHlcJZMvX5HJdJoXuTdTI0SCI5+uModSnzoj68EB/Ev4izh6cy2kj/OiZ6/2PusG2e7CX4EteRDZcG4zYprjgYh/1jOpcWjgbcC1Q5e5k08= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750324471; c=relaxed/simple; bh=zfu54HCXl/1OT21VFfC0fzTFwxkWioWa0xTe1UwVLrA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=BYj7Yuv+xLfQ8swp3YNrEVFLU+xvTchLtl717r9NRIJmY0aWlfK6xQXshWEi/kKkv+w/CrdyCbFs2zJAd3TJmux0Or4nVdGx07fZBz9oR3Le7Qe+AEbduAag3+rr7gGlG5euaNaVzGDnh0Rk3U3qrnVdpkAUo59qgYloClUP1xI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=I544dBfQ; arc=fail smtp.client-ip=52.101.84.26 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="I544dBfQ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ufjcihkSUCoEKzWufu0fqFrDovzLLulRx9Yezqmua3zo8A3ebcBi6n+7RdZdxcjkrYUFmh0eqdM+v+fDQadqboh88CS/TknQWSzBy83Gu4R41Q2zch1twraz2R+uT5l2l8RYz7F/w2gMQRrQ4HhB+tNEnQNgnwFUPLQNNoqApBjj5myZZlmtX5MVPcJMWgJ2p0W4Ff4OL7VbHwdTgl14CtET37E2rQFHZuRpEAHMq+CjY20lqHVb4wTMUSusfTK0gx1Mtz3YOc5AeLDZgBvIVqoleAet4l9wpA+GIwAQOh6nWoQqZx0NSNpga1dsM15NjAijJNyJDAs0hjPi4wLyzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jTMvzB/EsyVGyMym+l4MxGNuLFj8Q5x+lfAjXjfIsmo=; b=F2cNrAhYNHjPftcS27hRqayz/Hp2X2bT78M1PbhZu98sYjTrqsF0kX6fwwFK7UFMRPYIhJcoQ9QMnOakoBXLjzpODd6pptiEwirVpjEhxu4gc3f/TXZXzBgc7eNGMQ5Qu9TCVa65PDi3nkVafd6Tu//0WMhEh8NriDJ7/3V3BOQeoZNGKuMnOAYz1RQ0aGYBbZw8R/L+OE3JT2myP8I2AoPOBiBrTPhhYSRrAN/9k8S2Wbpm1h18wHUHBB+LUWJHk23uTBxUhUIOeoGwIlFszEHMtbf0aTPOzCiDCdT3pgweQl2gbW926hTF6jcQJM9Q5vYk/nBZfSi1waiWCpIbTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jTMvzB/EsyVGyMym+l4MxGNuLFj8Q5x+lfAjXjfIsmo=; b=I544dBfQdSitfhMJtynetwUrZoxLTbiBi7LclOqgdpWkjaGVkmbagC+q3vpHFL9foudVWvwhySqFSsBhAkSAminuNVzKKFaaYWA51g9Q4INHpJZloyaL4cJ1NyF/ZDAzMo4r3d7ca5SG+2x5YDHEgv4pXo4gyNHtKIOXSVPG3eFxNm4hmzp+TC1AaUCRptgv1D+EI2t0D+lKpmOqYaxFgshmKAGdpC32UhBF0ruCHbV+SEGqiEeGj5c8we1RHcjm8wtgevD3xtRui22Kcs4ibQzF8GMp/Qze5Kv8oPLfHUPTx6XDzP4Lq/zeE9OzAtqEB+J2ethf5FIb8Fg5VqSBkA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8676.eurprd04.prod.outlook.com (2603:10a6:20b:42b::10) by VI1PR04MB7021.eurprd04.prod.outlook.com (2603:10a6:800:127::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.21; Thu, 19 Jun 2025 09:14:25 +0000 Received: from AS8PR04MB8676.eurprd04.prod.outlook.com ([fe80::28b2:de72:ad25:5d93]) by AS8PR04MB8676.eurprd04.prod.outlook.com ([fe80::28b2:de72:ad25:5d93%4]) with mapi id 15.20.8857.020; Thu, 19 Jun 2025 09:14:25 +0000 From: Richard Zhu To: frank.li@nxp.com, jingoohan1@gmail.com, l.stach@pengutronix.de, lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, robh@kernel.org, bhelgaas@google.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, Richard Zhu Subject: [PATCH v3 2/5] PCI: imx6: Don't poll LTSSM state of i.MX6QP PCIe in PM operations Date: Thu, 19 Jun 2025 17:12:11 +0800 Message-Id: <20250619091214.400222-3-hongxing.zhu@nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20250619091214.400222-1-hongxing.zhu@nxp.com> References: <20250619091214.400222-1-hongxing.zhu@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SGBP274CA0010.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b0::22) To AS8PR04MB8676.eurprd04.prod.outlook.com (2603:10a6:20b:42b::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8676:EE_|VI1PR04MB7021:EE_ X-MS-Office365-Filtering-Correlation-Id: 326c85c6-0b9b-434a-ce9d-08ddaf11afae X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|376014|1800799024|52116014|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?GnlAw/B9nX1oGMVsdBDHSJ3l3JOqU7dBFbuweyG1RipNBjybTj6cgZssD8RF?= =?us-ascii?Q?UfCIEdnLnHyBYnxjkTof8rKw6lRD9EfXMyuvBGO9IKJRrTiP4b3PhlFP/KdO?= =?us-ascii?Q?DXO6vVFNSULkEB58I6WXxZOLpDuUH4Su5JuaVp87P4wm7PSre0O7tDf/7cKY?= =?us-ascii?Q?nyr3W5jo9BaimkT/L5Z83y69NSTxzVpDZMt/loHrlVbr+d/NHsuswGRKaR4h?= =?us-ascii?Q?cqxdhgHJlmOMUpfI+4Guv0hRUPIRvguXs0UuXAuV3VIKQDK83V9v9e73ffbE?= =?us-ascii?Q?tezE8KxfiSJqOrHTNYUzeGdKHEKXl/9P3FyGZCZDO3XgyapN/nLtyycmFqmG?= =?us-ascii?Q?AbqW+SSAyURoIKa5i/sdSlUfENc02+9S/5b9L4Ef2jp3Lzd49nIuXYEs8k0t?= =?us-ascii?Q?0ftBF07Ebwz01rziLuCe3sYa/dojuyrhRiiSCOuSH0XNzm2Y33hyXrzZ/JNF?= =?us-ascii?Q?towgEvFx/vUhaDckSiMyeKzwKznq3ESOeEvY9BlZL49urcpMZvwIkJ1i70TY?= =?us-ascii?Q?qBQUIfh+ldmSN4q/FGXnwqqLAW22TTioaoXfqtqR+4CEEJ+rS6Ylo1Yqkq2T?= =?us-ascii?Q?qhmw5EEvxZK6TSUdTXn4BxsWbW+Gs6uRPchyLvmeI58d91aH86pSTexR048R?= =?us-ascii?Q?IsF2MmSoa9VQ29m2e762Ehoc4GmFQZ53uWij7hENcMXgKaBeJvk3oQ6xMfK8?= =?us-ascii?Q?S9rMXbI/uOqnp2U6+Uq4A4+O+XOC+J66c4UVaCdGLPjm2X07qfwKTh1j86hY?= =?us-ascii?Q?Ar478rCq4OTnSovPCbT+BCGe88/LI2Yv4JNV5tuzxDYVY+xFaL9g/fchAwjY?= =?us-ascii?Q?RTX+w80YtTR1Pq6lUPc/Td1h4cVxDcLIw/W4sbTcgrCDXffkbImlWPMpMHMf?= =?us-ascii?Q?NKNYJIN1PonTOAF/xmsmlKss/1I0vhLEnFNloAqCE68AWdYODRdcTrZhXRt+?= =?us-ascii?Q?EwtYyArjyJWSUB1/ik/QgtpuvfFqpLe3IoXj3csNhtNesp9Fod3xE4dbrTd3?= =?us-ascii?Q?Hg5wTH8vgqonH+oQj1TiZfzufz1KUc9ZJCng3zzkNjk0K4cUoo/N4UC/8Joa?= =?us-ascii?Q?84nx85xkLURwu+WawX0aitTxZxFNbqLc6jEXow++sGuUF12dwer7AERPT4ZV?= =?us-ascii?Q?IWpK0nQWhAU3F1Ct+vkFft1Pvgbuuk9AAtpiE8oT7p91U/DFjZ5TIbHOTytZ?= =?us-ascii?Q?TD+EHt1fowiVY8QUshtK7P46sE0dsRxB/sO6gTjvIE875vnmTcTBfr95gxaM?= =?us-ascii?Q?V7KXIOLGMXVTRLxJHr0h249koFRGiKoFgVrjvkLMkEQQuw8VMD6kIr1TlIau?= =?us-ascii?Q?fW60JOi0AMTLjPhevS1kpqm48gx92CPLGPajkAt5qfYyzaHfjPA+6iJHcd16?= =?us-ascii?Q?R6NqvOJ6NL4k8Zo2PafTfizY6HIOwgKk8TYlOOLOh0sBNWZV2IVRrnV/tdVF?= =?us-ascii?Q?fxpzEMFK1jzA54btOe3KaO3c4JV2cXwrAjtFPSNHfOegoeDWl/FwNchDl/id?= =?us-ascii?Q?Q/3f1nT0CRRmxAM=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8676.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(1800799024)(52116014)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QjjnuRr8ZB2YbWOBcv+o3QU89oVPG8ku9pFr8NHttFTVYFTIqNT1GlDcKQeX?= =?us-ascii?Q?s7m5dqKIVurwNSWYWcXfJDlSCQZabljly9yixRpsXM0AKARPVTyFFIw3lJwn?= =?us-ascii?Q?7XUbl3vDdz6oXbMboXNKJ2TOt7ezHyqfAy5M8fz63kIzSZzTuRE2xy2VWELN?= =?us-ascii?Q?2jikyla/Ol/Lg6HbFfbpF4GVbavQEyrOdP+uaINWBY73UW+0i0ORTrNi0O8S?= =?us-ascii?Q?5I1V0mSOm7ywWYjZgYyqTRBkRz+Ld6H8Z0aaFgO+DIWvecTJpOzSdpUTqaId?= =?us-ascii?Q?Mz+F1TPuN3iWmkJSDQF7w3o4FU+HcDKFKFXrrZbBq1n+rwCXCTnK7YJDJF47?= =?us-ascii?Q?jIg6ROrN13dZXCk/E9phuUV0jj66dwoGCkheQKP7ZEOFVyRvxFhJsJtdwL3k?= =?us-ascii?Q?wFSKiCe6eipGwEzlxRHo/6QzzvzqpNtNcBr3qNJUFTjuYnS/vdeHw4DSKdJm?= =?us-ascii?Q?pGmtzFfEX8+lav+RpGmQOeOvugusGZcbAaMIkd8KJwFcNqCNh/Kc4HdNGeSk?= =?us-ascii?Q?O2o1TGuKPehcEDvTWqJTOGZ3G3n04xI3lOw7+2RqwahSsP5A+gFWKgtojnkM?= =?us-ascii?Q?qKqgjFi+izEhkHu5WD1kWOAHS6MX7Qvofd+xyp9V/5zJuudEVBMm9+rx9Gv0?= =?us-ascii?Q?G6axmX1ZmDzktwMqfmW3vDs89oZRh+tyEwvHD7VTSzPuogUhnnL9GvIc3wDX?= =?us-ascii?Q?rEONuE9nXXn9L1NDbKn+UbyGysaWaZgBlpHPbynCQs1MLut9h3UEnTN/32Hs?= =?us-ascii?Q?oYgj+WnppRiM3KmtacSg3uzHtO4IO+4Q1cgneQ7OubUCakdIdbjbtJ1jm3su?= =?us-ascii?Q?H6k5hQZhc5ciswHlKr3u0o3qOkjfogDYUwrA50ZDacKay9ekRxoztCqiI9cH?= =?us-ascii?Q?hS6ihLv+E7rNzWXFsO3IAVjxtpLu7nj1AUaPbOuZPnQ38MkiOPHrtsDz4QSF?= =?us-ascii?Q?oiZMUWqfqworQCQErFUNmr8Q2/Bxv85j0RmIupIsicC/UqICwqyn4ZZAEioy?= =?us-ascii?Q?RYZpUfit3IeyIYg3UQkenlVOS2qzaow11uTwB+zcuEpxHmi8J4Fur1b8Mpbs?= =?us-ascii?Q?nntI5PXpzhmvokWqae+47IWddMK1B76QTycCWdwUpltBmZTkn5lQEGOFw9T9?= =?us-ascii?Q?9bBWxYSi3YnQpfR0kG4X2UOKEAqRbzkmygFs/iZa9nzjQtIxbNKyYVa5r3v7?= =?us-ascii?Q?HX51umvdpq6nj2V249No5nfTd/5ZBy5GMnE9Oqk0h4Sqr6byxESyAjykTmzQ?= =?us-ascii?Q?54kKTKpBrf2qSi8alSANJWsZVYPy3aEpFXPwvTC2wjfweyHlzgdyRZj09qpw?= =?us-ascii?Q?NP8F/sVH/uDwH1/Mt9hymXq/4DPEqpLBoe3ieZ/D9GH39g5ZmmevU8pJImRN?= =?us-ascii?Q?P7NaHrJQQ9crkuz0pjZ/Xw9U15K8NVf2IBTciiGKMjN/Aw9nvQGnaRJcuOJZ?= =?us-ascii?Q?WZDznWRadrfMvcl0JKbKWboya65Dce+S8F7ayTUQspGMjum0/Qry2lZwrlLf?= =?us-ascii?Q?LYvLt6ZBP+Fthei6/W+hs35u95NOUSFdrACHEK/CllpafDdSJwvTi075KNLz?= =?us-ascii?Q?5JZmrJZ5Ur+W+6LyVO8G8MyuZbW6Upk+msf4CZ7r?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 326c85c6-0b9b-434a-ce9d-08ddaf11afae X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8676.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2025 09:14:25.5946 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: trM49lWIa13+xd1wzL8/0zTAJOcXaSLrLljVKIM89ApSWySXD72JKEi11DsI5ceXrLto/uD3sPcnMtFLCwITmA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7021 Content-Type: text/plain; charset="utf-8" Refer to PCIe r6.0, sec 5.2, fig 5-1 Link Power Management State Flow Diagram. Both L0 and L2/L3 Ready can be transferred to LDn directly. It's harmless to let dw_pcie_suspend_noirq() proceed suspend after the PME_Turn_Off is sent out, whatever the LTSSM state is in L2 or L3 after a recommended 10ms max wait refer to PCIe r6.0, sec 5.3.3.2.1 PME Synchronization. The LTSSM states of i.MX6QP PCIe is inaccessible after the PME_Turn_Off is kicked off. To handle this case, don't poll L2 state and add one max 10ms delay if QUIRK_NOL2POLL_IN_PM flag is existing in suspend. Signed-off-by: Richard Zhu Reviewed-by: Frank Li --- drivers/pci/controller/dwc/pci-imx6.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller= /dwc/pci-imx6.c index 5a38cfaf989b..8b7daaf36fef 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -125,6 +125,7 @@ struct imx_pcie_drvdata { enum imx_pcie_variants variant; enum dw_pcie_device_mode mode; u32 flags; + u32 quirk; int dbi_length; const char *gpr; const u32 ltssm_off; @@ -1759,6 +1760,7 @@ static int imx_pcie_probe(struct platform_device *pde= v) if (ret) return ret; =20 + pci->quirk_flag =3D imx_pcie->drvdata->quirk; pci->use_parent_dt_ranges =3D true; if (imx_pcie->drvdata->mode =3D=3D DW_PCIE_EP_TYPE) { ret =3D imx_add_pcie_ep(imx_pcie, pdev); @@ -1837,6 +1839,7 @@ static const struct imx_pcie_drvdata drvdata[] =3D { .enable_ref_clk =3D imx6q_pcie_enable_ref_clk, .core_reset =3D imx6qp_pcie_core_reset, .ops =3D &imx_pcie_host_ops, + .quirk =3D QUIRK_NOL2POLL_IN_PM, }, [IMX7D] =3D { .variant =3D IMX7D, --=20 2.37.1 From nobody Thu Oct 9 07:05:20 2025 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010065.outbound.protection.outlook.com [52.101.84.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 851452690D1; Thu, 19 Jun 2025 09:14:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.65 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750324475; cv=fail; b=fAo1wCe1hMikRh5v8SZIr07rL8Ljaw+7z0nn9LVrrdkIsgjRkdv7Ni7ajmJXmRPBRITRQaYccgUvX5JW9Tiks9KTytNkColRxUYuIUjwFSN5VDw1oZe89wNsvxV8YobnhSA3VBo74xNNBhkY5+8UlGdNgV3ijSjRvAXTcsd/7OE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750324475; c=relaxed/simple; bh=WpANRqaayzGeLOJ/NSdoQ4ZyBpPZyjKKVsiGYZ4nJBY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=oswwOXUsdXhj9ACBKmGDb17OWLzzW92dPwoz7yNgP5OmLPuaHkTevnX3I2DJ9D4Fo7OZ92E3ekw+QQPJQKBb8Rm88+B7IyOR3zutncCnTGd/O/Q4XlEtX0rOF+sKW1u9KwEWLk/nPbYyuYDmNYnTrInSbzi9QTyHBvNzTJ4+hAc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=b6dhF26/; arc=fail smtp.client-ip=52.101.84.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="b6dhF26/" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JTtgmU+YDLdWwgsbWaCA+uSLgDEGETGtfdzcV8fptJtcy0GkvyLIJR8zC7ec7oxpzJhJJhDhO3lF/U7fOS0eBAhyuxxelYuaJhWazsBZ+5e6BPd4Op2CWGziPPYxc7WYMJAOzLQNh64iJkN4q+ZOV0T3WX1W2MXQwpIactG/QkQwgA4H9N9ZX25vaxfpAPT2rcuJape7WhU3AyeeYcKFRnh918uYPWHAnu7PuqGcat5+Ndw+I0W8M4bUchApDAj2Tz5uZEzRKFhLLLArMs91YktCelzH5VTutM8ZW3zyXjAPuebRIaIApQ9ERkMygHZ1zNrnM37evrT61lVM1bY1Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p8fkwdc3PYtQjwhq6Po/T/8gTI2hUBfx8vMIEQvYQok=; b=E8oZg9MZsrcf6HjwAtrqYcSQe4l4fEUY53bnCVaZqkC/06KA/F8y1CWROUjCOWRJVEcNgzFjOnUfxmUyfDkDnkjuvlDQvWWsSmj4AwuKj+fV60Gu7GgmHxqKa8nJcoO7v8fRwKSuagGp4NIwCUIivbBg/zKEcR3mxNfERwhRk/k4wjwiTuR9HL2gEUAbAjlzUlaYkW1Kwefvp9cHIMHi6Ah3v4pNF6P3Gq1EPmU3VnEpJbAyuEQpAhWtVrY/lhG1iGnwBmcDSZgAXNVTku8U3lj7Bi5guNkqDuoYM7iSpOnJaePPqTuSkLtHN5/KMTKcySH0PXkUhZOziMLPbEh2Og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p8fkwdc3PYtQjwhq6Po/T/8gTI2hUBfx8vMIEQvYQok=; b=b6dhF26/txKUJY/vBv7vO3uVlkzJo23F+1dQjj1WXzmAN5wbKGoD4aXTiaIr21P58JCL6VpkeaU7dnhio8FS/E0OqMv1lYKqd+wrwfXPp1Z5oAE3XPPCA0BWpUZk8+hHqcm1/KU9gG7ezzTyZFSI9ozgyFPlbdrQ/Jago52kBOZ39pNVS27RVIjSWtvHmucNLntUsr+2sw/fjR2ZXruhwEx1doeUhPMJwf6mGcYjZ6ySK+G5jSJ9MTg1MJ3HVWJMJo7xzl5lEP9S7BUZwS58bdM8rmqktaElDJp4E2vrX7aToF19AVCO8kTPXaDuWwpZT2RE+tw7j8dV4yH0CRPe+g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8676.eurprd04.prod.outlook.com (2603:10a6:20b:42b::10) by VI1PR04MB7021.eurprd04.prod.outlook.com (2603:10a6:800:127::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.21; Thu, 19 Jun 2025 09:14:31 +0000 Received: from AS8PR04MB8676.eurprd04.prod.outlook.com ([fe80::28b2:de72:ad25:5d93]) by AS8PR04MB8676.eurprd04.prod.outlook.com ([fe80::28b2:de72:ad25:5d93%4]) with mapi id 15.20.8857.020; Thu, 19 Jun 2025 09:14:31 +0000 From: Richard Zhu To: frank.li@nxp.com, jingoohan1@gmail.com, l.stach@pengutronix.de, lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, robh@kernel.org, bhelgaas@google.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, Richard Zhu Subject: [PATCH v3 3/5] PCI: imx6: Don't poll LTSSM state of i.MX7D PCIe in PM operations Date: Thu, 19 Jun 2025 17:12:12 +0800 Message-Id: <20250619091214.400222-4-hongxing.zhu@nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20250619091214.400222-1-hongxing.zhu@nxp.com> References: <20250619091214.400222-1-hongxing.zhu@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SGBP274CA0010.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b0::22) To AS8PR04MB8676.eurprd04.prod.outlook.com (2603:10a6:20b:42b::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8676:EE_|VI1PR04MB7021:EE_ X-MS-Office365-Filtering-Correlation-Id: a76b4f70-58e6-46d0-393d-08ddaf11b2eb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|376014|1800799024|52116014|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?04Lds95jAjOyt+dOzm8dROpIazyqp24cSRf6aymi6aVlSNetluMhXfDQVrvL?= =?us-ascii?Q?dxZ74Feg83JtXhQLnSQECy0rurAIXCzXY7V2DEujiwHrPP3Dr5J/OfrlDsqg?= =?us-ascii?Q?zkOM/a5QwAM3LfQdmvBJmGWtETKU7BcvO03kvIQZkHk9zQtd1765BTP+iHdd?= =?us-ascii?Q?64Bgl0iocdsk3iDmH7w7nRj3qSfGzAg7sGFMncBo1JHNw43qvosU90AVzyzY?= =?us-ascii?Q?R3G8zr8db7CNzrnom7hIDHJAx0Obdse3xwQOZKasFppVnGYcFPrL2ab3rS1q?= =?us-ascii?Q?ONxw/nCCyO/saFzXnY/JOpli7geXwB/2SE1f6zlv8qOEcO2kRM1TtzGZJHhQ?= =?us-ascii?Q?bLvaMN9TRyY0bswrXIVO2GiW+zho1prHoiaCXOmurwm5dGHutxAS63j7PXiB?= =?us-ascii?Q?zPHmFuE7/YKio7V1u2Cs9FkVxKP7K8ygGjc6RerXKDE/04chph919ApxDrW8?= =?us-ascii?Q?H/ZW31A4ZAIvQOLvdxk9VR+/MCh/IZ6p36cUiMCWn8oWpuDRnJrsCITOUmqb?= =?us-ascii?Q?YSukQai6QO5EADGJ+E2J/RFBItWDBrzeRZQ6bvyYQVCDzJwkSbZCUGjvH7U1?= =?us-ascii?Q?/bvnx6RdMnka0I8SZwJMl1c9BDqBv2DeqP8qTpTi1g3eZ5o7ezwxqm8SM4v9?= =?us-ascii?Q?fyPAQ+wgnTdF/MSUlGQ8LSLM+mJzuHQxYJmR5x0D0Lj/I5SiYLMtxHp4ds9+?= =?us-ascii?Q?unty4pR8BNYhbG5UlyqxMG6olwoLlwBWR5s0hBpy/gDDW7lLPD80CJ8mXZyq?= =?us-ascii?Q?EO0sA3mqQHX0dz1+UWc9UJF+arIHvfnn4gL1arjxCdTvwPp+Fs5VacDMXNNm?= =?us-ascii?Q?XERie+1Fe64Z3OPzRO73C89cXx6BFKkypFIyOmrPrLHQR68Acp0UNhm9tXlk?= =?us-ascii?Q?+oYC+POuc5mwjL/ZRbgXUb9TEDalgQ8FpuFc82TIOgRpiD/YURTZSKMwUriY?= =?us-ascii?Q?WBPPwzBD1suhwJOaSjy+e86qHioKmSaORyTdoHfhSNlckqDtQljRGZbABW0K?= =?us-ascii?Q?nb7htSYWDpr6lBrzXi3yAlwxQYClMeH6FbXn1F34ePeB6/c1J2htbk/EVgjL?= =?us-ascii?Q?kzgsgLuYVN2HYp4r++jbgYrAOIr0tJcbDC0r3+OyYGurfp6y12zpHj49DtlJ?= =?us-ascii?Q?mjh88afqaAKoJt6wzkp4BZwKJMcJl5bhARP67MDJZ122WEBuvkH6J8yOzMbU?= =?us-ascii?Q?AUx4rbsNpk5gqtENj9R0M8ta9G7LmmD25x3F291u3sma1/MikW+UpLM/1Ctr?= =?us-ascii?Q?LidH/XxkmbIefXgLBdKwza2VxBkz6NSEdyvqPoFfHcUdd9HY5PLzmoK3EqZ5?= =?us-ascii?Q?kb6ii5ORlev2a+FtAx2d5Ee22BUSzGe+lQrhlr327R9dbxr4teJoLpYMPKgF?= =?us-ascii?Q?gewpYObXYOt10rkGlTwWEPIqQUQ8lwuwqm7qVoc4L+1honO+0KDfb4MbnzeO?= =?us-ascii?Q?INJhzHyKH686nw2Usbpvtu7OaajWye7tYM/1dpVACK4hFLp3bilFdqJNBIev?= =?us-ascii?Q?ibXDjyEYUtTMw1o=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8676.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(1800799024)(52116014)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ce8sOwR7vWl8xDe814Hk1GqeOFgjSHZ4UyLEVIydGyW/0M9TTyeEjci9n+tS?= =?us-ascii?Q?5ucTJwGp6erXZMZqgHNtrgVS/9nmKAzMNU4u2hPVq2+7rZSaaavCF0oJkcL0?= =?us-ascii?Q?Qa0KkTAqwVRe8uK3CI5U8YIunAej/J5geeNnH/S/vbc3lHh9RHqtjiCf/qYi?= =?us-ascii?Q?x4A9GcFP0h2lBr2Ma+CutcOUMCitSX+ObUkdqey5wYiMzrrVNPVNd+MJHhs2?= =?us-ascii?Q?qHvhcyyyK8fq5hBe3s/95k+Wtnueu5MvtLa/lScNwOemVLua/E4HTE1QKeqc?= =?us-ascii?Q?io41eKsoGgkrWzogtrjWRTyjFddUVsXX4ME9695tHwO8KeejsMmQqUxyzPWc?= =?us-ascii?Q?mLcKaDx6LqVsjLq3gV0We3HgCFEDWTZI2MdR34BERAGXBxdMMw5+CgA0tfYT?= =?us-ascii?Q?bsDq4DYgSBC5ww/a+OgkoJJv7IyrR9CKstGN2OOIE0U+l7HpG6VAHfc4C6HP?= =?us-ascii?Q?bCeDvRsIeHaiwynKAwgLAhQg4lfU+z2BNo2kSZHConkcZggmsPzSwA6OTJvN?= =?us-ascii?Q?PQI5X3q2RoxVOZ5jsdpDiz4ZNIgUbppC5CG+Bs7z5Wr/4duPoFAzpz2MF4ZO?= =?us-ascii?Q?KCAHz/scJP9cRk2/kcRjKvKzkPS4ssZkXGNR4zJghX9Y2TtmKVnvCzC4DI02?= =?us-ascii?Q?in4TdWHwsjTrexAlJhafnnme1PNNT4ZCoNdrXU5iwDBYHd2E8KG84XWr+bS6?= =?us-ascii?Q?ikdoIe8uaFp2yJYwDIb0328tXZiKYpR/KhTwqTS2lgyWFJAbhzpXnfdV4yhz?= =?us-ascii?Q?wP5fSJbzt6+vnwsKbKgEBBYJMmOGTfwX9dOSR1R3ltW2sadPJcuYJ+pxUYJj?= =?us-ascii?Q?v7aLtPJroyY21DFHv+zf8Flv7mTs6UfFoWBtU16ohNKyrXFviBnyOFViunb3?= =?us-ascii?Q?JKFninQFjajHnyWVNXbG0bf9INXfHg2KSqI6sWVd8aYCWK2iJ1dqHHq/zk4q?= =?us-ascii?Q?NhaiggsSrrKCgqxQN1QW1xXjHA2KhBzArY9c9KYs8s4z9/aDRJbrl5j96BBX?= =?us-ascii?Q?uiWMwqVSWOJls9erj+9gkR6vcjK9adjquomHZrgU4qI8RJRcLI2oNYIw27pZ?= =?us-ascii?Q?ApgVsxxi2uD7Mj5c5dTXe9SN/YYCkwsJQjBXAI/zLW72Q+5uAdkxoP6+OFke?= =?us-ascii?Q?qeCbT/kniFVeDK9VqsIMJa3InJZswMxncWk7QAXWpUgbh9DIAK7vAxoaAc6w?= =?us-ascii?Q?BR5QXxwcdfqG0EkjnX4Y2LaQMediqycPVSKvM/MCEpgrX8LjpZz9YSDFDYgC?= =?us-ascii?Q?LnnrlGbNbnvT3Cxz6WfLaPqU9K9BxkiN+Dig8oIflTIT9o13ljB21TGogEPG?= =?us-ascii?Q?ywi7VctfTUWKoJE0g0Aktu5KguNUjZ0nrF7CIzVu5mvmHx5rlJjW+pE+jHZ3?= =?us-ascii?Q?9L6FLCfqK6uvyojP8xwujphz8mmrr2OBCo0QJ8LU7eRLpu65M/vlo7ocr5lW?= =?us-ascii?Q?X+YvWS4Gi1t4Ab6aWWZrMQj87bn80fFkqzAizDckWXd/UW3jbq3YVBMoBhqV?= =?us-ascii?Q?fwbP9muOkwkumIjQJLwRrUKy9cde5IWRG1TvknjZw6IiW/945ZFRYpgG+8vj?= =?us-ascii?Q?XeSpm5rbhkfucnHUkPLcxiIKfsPgQEvkEiOy42KX?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a76b4f70-58e6-46d0-393d-08ddaf11b2eb X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8676.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2025 09:14:31.0947 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yi5v4Piyz3dru0Z022KrFE1esXAjkWKPEhL23xGU7IAI6ZXauVUhy8SpK9f50x3kN1F2q91x+ZEVq6lsSi1++A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7021 Content-Type: text/plain; charset="utf-8" Add a quirk flag(QUIRK_NOL2POLL_IN_PM) for i.MX7D PCIe. Don't poll the LTSSM states after issue the PME_Turn_Off message. Signed-off-by: Richard Zhu Reviewed-by: Frank Li --- drivers/pci/controller/dwc/pci-imx6.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller= /dwc/pci-imx6.c index 8b7daaf36fef..f084a9ad1001 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -1851,6 +1851,7 @@ static const struct imx_pcie_drvdata drvdata[] =3D { .mode_mask[0] =3D IMX6Q_GPR12_DEVICE_TYPE, .enable_ref_clk =3D imx7d_pcie_enable_ref_clk, .core_reset =3D imx7d_pcie_core_reset, + .quirk =3D QUIRK_NOL2POLL_IN_PM, }, [IMX8MQ] =3D { .variant =3D IMX8MQ, --=20 2.37.1 From nobody Thu Oct 9 07:05:20 2025 Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11011071.outbound.protection.outlook.com [52.101.65.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18BE7266561; Thu, 19 Jun 2025 09:14:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.65.71 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750324481; cv=fail; b=OxyyteqLcvsB09Jqrl0cBhGGMFBXEPf3f+YtW/yCPx9od/fICzyO3/pDjY9QfcB+L7rDvk0F8+Z+8De2V6idb3zKIonK8tJQDN0eme2IV7hz3H+UpaL94rlfE5348d2bBNg60cn7+k7yI8rCCyGnlTNyl1RMfk6DGyIQw9wSYcg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750324481; c=relaxed/simple; bh=349IMquuBDTUZ6JRzTwuWFvqwrah1mkQJmElSRHo/Co=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=mokIoRskZ6zsyaMHhvuF1lQX2d5mOuZZyd75GNY/ZVcErP78tlo+9jktAsv6rTd0IWlBdd8Rwd+jkBE3ZnFrB6xps4saUlXFdc4YScfHDefIPXrwZrD+1Q0VTEJ4GjvxYlRut+PgXaM4uiMtUwyRT2zvxNrIUYCXCeb6ZviNjws= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=gvoUfQGg; arc=fail smtp.client-ip=52.101.65.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="gvoUfQGg" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bIcQUd/IDfdbXq2QaRqe3GrLwJdbtKWK6FuS5vyk2Jx6Nuh1DkXyiJWDAT2rVy6qZ4W7WZzgteXnkDJCUd/3Lfp+WS2vF6tsJBIeVaoK+p8dAUR1hX9UscAkkjOuz6YOhklZi4t3VWKivQem2TtRNhb0HREFT3DD5YmH3csSjJ5ayIt0UAZcL4YvRbsyratZNYjipurMuSmdQt1HC/dxp+NPvCWPCbUKk0a0JkzVxBZKsDMcaZWv8A+M/0PMm/z26hEoILN7Qy7INhrcYmIAsBxleG+xyMDAsGsWvux29yVJe7KyV0kLFu5tbKhJbhJwkQ0PgftUVvxOXKSW0LCz+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IEivKNtFlk/z/CZDzEYkg3wFfThFQY800PDqGR+3CDc=; b=osca451eQcVaX+WR/l5G/kt+NfLkiF0VF2HEi2daPg+uoUe4fcp3ZMBF6WgmkWxGKkWyxTVlv04h9icj1W2HgQXd8JDs1UbvXUNZSDGb6OpDsMi3ZQH5M2hQ+hGf8TpZFarM9S3nbjzKDLI15pH05kQTTgFsuLYTTyOvhRVey+OlxeXNy+3SaIab6qSIxLqr6+E/2xBPTurji0uQ0pOf2Jkml7fxt7G5eSrVMuRz73FhSM/F0yec80JRf8byKRQGXASo8b1jSAl5rrh8r7P5npW5mj1tcOL7HMPwxuYJPvwCT+ibkVMmFwQ0TW7z/n9eHd3LUM0cnkxRGjcAtXPurA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IEivKNtFlk/z/CZDzEYkg3wFfThFQY800PDqGR+3CDc=; b=gvoUfQGgh/GqILHvdeKfKgSh3RpVCg4sI1EgHo7S1O5MTatEyKke5cLKDnTjWkLkLIs4EV8PjUtmvNMi4nPeDQkdgLBAQ+Tu+Qe7p1IeQULpFgJa8n14biedx7Al4utDgrhuIVIgIXaJ0JCEyM2dOD6m8epmKWbkT5tZgVU0j/d83JrQqyQoVYTqbT/zjURq1H5Tai1GWzDA3905NYji2YbCXcM+nbmBEnvOmlcr05kJSbQ3F2EhWCkoJhQMtqrWR2SII0LjqN92Nzlg+NXFrStm1rnCgOUWh1awziKgZKY8u+ph0mYhsO3xKo3Ac+Dqr7XML8V5X0xopAvpHfgKag== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8676.eurprd04.prod.outlook.com (2603:10a6:20b:42b::10) by VI1PR04MB7021.eurprd04.prod.outlook.com (2603:10a6:800:127::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.21; Thu, 19 Jun 2025 09:14:36 +0000 Received: from AS8PR04MB8676.eurprd04.prod.outlook.com ([fe80::28b2:de72:ad25:5d93]) by AS8PR04MB8676.eurprd04.prod.outlook.com ([fe80::28b2:de72:ad25:5d93%4]) with mapi id 15.20.8857.020; Thu, 19 Jun 2025 09:14:36 +0000 From: Richard Zhu To: frank.li@nxp.com, jingoohan1@gmail.com, l.stach@pengutronix.de, lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, robh@kernel.org, bhelgaas@google.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, Richard Zhu , Frank Li Subject: [PATCH v3 4/5] PCI: dwc: Skip PME_Turn_Off message if there is no endpoint connected Date: Thu, 19 Jun 2025 17:12:13 +0800 Message-Id: <20250619091214.400222-5-hongxing.zhu@nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20250619091214.400222-1-hongxing.zhu@nxp.com> References: <20250619091214.400222-1-hongxing.zhu@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SGBP274CA0010.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b0::22) To AS8PR04MB8676.eurprd04.prod.outlook.com (2603:10a6:20b:42b::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8676:EE_|VI1PR04MB7021:EE_ X-MS-Office365-Filtering-Correlation-Id: 8d437405-485f-4de3-7ec3-08ddaf11b62d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|376014|1800799024|52116014|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?F+B8inOdT5v8+qe4ShjnQ+Z6RvzYac/VXbpcBAcjEMSskN4HuLDYw7WGosi4?= =?us-ascii?Q?viruqmWl5iA9uO67YY+v9sXIGSvJcJ9waBZa2KHlC9vaEmhQMG5ktS101a0n?= =?us-ascii?Q?9Ztdy28YYStWivlRoyxebljH2i6gNjKbyGse/ZqqMlJl+QAXixCrLC0o3/XB?= =?us-ascii?Q?bmdePRbe4GzFU2oAiD8y3sd0XGsBu0r73kxgPSm9dicPP7PXoEBY2SpmC+rj?= =?us-ascii?Q?UFrHRyiEAWu1Dn7lkOoxEEf8JXg4SCRUL4+3Pd0kp6e7FVK0vSzsLgjwL/eg?= =?us-ascii?Q?VE5yo5qlTN1os5gDMvin98zChNA4Me5jj6FwjXwL/hD4OrUJaooZJOA/OakD?= =?us-ascii?Q?rRo3e2dtf7xP/rTuliio4FF3snngRYRjjON3P1e3ypYuP/z3wQ1rS+ZYbjR1?= =?us-ascii?Q?iLX4q7Y+AVMScFDvtsQ5A8lqSBf6n9uRFLFizvyu+5qbKuO2YZ9BLMOLqihd?= =?us-ascii?Q?iShIuv1Ik+iVDJAGu1KidApAX3U7V2m6QbCarPY6ocvXZVstzwj8A3blrcNh?= =?us-ascii?Q?kskMyYHV3Kyv6C0pYMKH5UX9+EoZ1wvKh/hGV0/vrw29UJV6dIzFbmRGndzB?= =?us-ascii?Q?k606qHjpOodR+JQbu7ZzvlG0NcUwj7v9uDpJ7KTE7NCn+K90arCjmn88Dlx0?= =?us-ascii?Q?X4gnV1mfiPOJqCzYqigX2jctB09EOf43jHWZLHCJq2BYirE06NO9rtPvRgv+?= =?us-ascii?Q?RNm8kP1c+VV71R9aDU1rpSlocShvDAAI6bm/n0KPqJ/H6Ps43dxlrWQj/fug?= =?us-ascii?Q?8Vbo1NaGHCzXyzTmapNkxiiMl6fWy2GlsECJHA+S9bEm+x5HY+BXAVUhHRgz?= =?us-ascii?Q?q9itgp5My6H45xOiHsjFKKt7FtgIDGrMJ74J4RXX7/rPURjc8zsMwHlTR8bd?= =?us-ascii?Q?pGk34PTana/WdkmCSq1ws+s+w2Fmdoha6x3EMOo72AGu4HML1PsDlQy4TNmZ?= =?us-ascii?Q?1eQp3Wqh8DoxWKG3tfdImxH3PkRQu2UYbwrFR3NJH1PZhRhne4qhngIlMEkG?= =?us-ascii?Q?RB78f609ZMNy1UHOGJYJlFTNg47nSzOC/KO5Fg0/5GzZXBKtrk9VzC6ZcVvL?= =?us-ascii?Q?is8PAUv2oYSnQc6QDFuR8HU2yR9UtIfoJuMLRL6xMCHVnP/mPFCumVN0GXYG?= =?us-ascii?Q?90kVqf3Ri0nEsMXBfreiek/locHneAWKsW2DJD9BGUjX6QgVP6pTizUg6zZ1?= =?us-ascii?Q?OzHch4pywEjgELuzAAFPYsWTs0ymNiBAGTBntV+VWujEL0be/RtjDlnK13Pp?= =?us-ascii?Q?l6ZU10PdLDzu+wufEKJ86GmZj31LKke5xAGXzLT18YKExrExY0aIuc/2x4y5?= =?us-ascii?Q?6WUSGNY/kCwpyOeal/JPFKasIqqQj5GQJPBcqhrY/lpufuxI2bRARl3F6280?= =?us-ascii?Q?NemJN0mKGSj2Dhlske7lqSGtMAE4t3T8Z+kwlbT2RX3ka8uQNCnaev+ZNhQ4?= =?us-ascii?Q?/rE55/Q3KvQcyn5yHGrxWwwvNnHzAJSJzhGbWGvql9JmmVUsnEY4eIbqDWbn?= =?us-ascii?Q?YCi6W+BENpH/Pso=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8676.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(1800799024)(52116014)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?goJayZzOC6FkShyO5WtH/UZWAuwPVukZIsLJ5t+OCeKhBrg9mu4oQzjVPA1K?= =?us-ascii?Q?5WHjHOj74dCiWzKffAIIQ4YkXEZH96vzjH3lEr18VxpfPwUHqP280CZEBMWV?= =?us-ascii?Q?IiYIR4JJcl1qNEi5e6Mq+pEehRVB39Oxhr53genfKIvF6zDV6On4oWJk04x3?= =?us-ascii?Q?BYH83YoDJSKwGC2r4W6+9ejOZSHIokdg/C/bVU2CID755My0dSfwXadSQRT3?= =?us-ascii?Q?xNmz/a0LzlCaS99OR2+J9aBp2k30+tdjHrXbu8cBq0IO40G50zJpb5orYmrF?= =?us-ascii?Q?e+JuInje327dHa2DXH5mTODp87EaYqS+6fb6JhYo1ieAdBraFHbzkyiR9Ci5?= =?us-ascii?Q?oXBcoID+LZZrw8jwsy5HbJArxLm54g/UGab/LTQkFLcDA5jliNmtjhncuqXP?= =?us-ascii?Q?c3zTH+leui/BFEZkizQfQTbs67p0HNiLuRaTR3/GZ/6kPmJoT2U/xdgsugUz?= =?us-ascii?Q?B4kPz7JncLTdj3WbXX//2//b3ETDzYaQkd0kTqos/6UVc0Se9zX3CxPL+DVs?= =?us-ascii?Q?+dN6CIRWPhL36ecL7XjwpxnvnEst8bL+qy6Wuk/zF1f9dl1mspSa/lXonw+e?= =?us-ascii?Q?gb91zF9YlVsnPYw7yEFGSls5jf8a7uxZDPjJdG3ZzSum5i/FzIqsOtemAHRw?= =?us-ascii?Q?0a74y0BGPXFLkUcZhh9JClhXjgFodELkT+J1qRQlfjDDeMot8MTCpFjILVla?= =?us-ascii?Q?rGI0VP1mNbWXtzVL3njM3yRVMTXFqxo/UFOey8Z1nLGXMhyATJXmHPrJrP2j?= =?us-ascii?Q?HOt1zXhvXms+PNl5QursD7APRfHku/XWIvXDu9JC/LDrMIcIEBoCM1SjxMWH?= =?us-ascii?Q?CSx+lZeP/KDxBgKd3IC9NM/NXRmiMdC1Tce19p1NzUNVwIqHiUb3vZaqZNjX?= =?us-ascii?Q?q5EpysZ24HwkNNbUptobyhMr9E7P4pnDcTa0oL/HfdU5RhiUvJbvnNEoBI0Y?= =?us-ascii?Q?U5T9bFU6nIWto89GMYnxOUf2KBiY/iK6kF3XZMk4V9JBp85d0hoYBM+eC5OH?= =?us-ascii?Q?7mi9IpdrUgI3gZ10dDeCn677TyxDoKBZ5/r9c7zDo+dTTuTFnO9Gghel6/sx?= =?us-ascii?Q?jWH82nemnxq1699UYVbhL+HxTy2w9GkBXFqPSU+WIj3k/Y8ZKZE2OqhM+AeT?= =?us-ascii?Q?pTAsc/XO65LH5AXmEna1gPGCyvKgQnzS7gikC5+39205enfHN+5J8YR4eyDt?= =?us-ascii?Q?+xFPyBTtB7YCMLG9CexNM4W5FQJqpr9riMcViabE4YX1CTp9D9mz2Dmn3Zzf?= =?us-ascii?Q?kecoiNEff/hSbbEdXmQYvxIBB5X7zoUU+Co3PoCvw4u2fk656r2pi5cr/VWA?= =?us-ascii?Q?p9lXspRnc6y5lbtZGs8avjYbqLlnLy65m8MXrq5q8gQFurk2dSBecRR1oEVq?= =?us-ascii?Q?IwF/TqEXTf6JtEcsU+9HDTBUdAAhDq6Fm4giEs4lihzuAH8LT6RflHg7UP+m?= =?us-ascii?Q?i7AMZrYrI9T2rOISHY5za1k9Mj0EHHctKhiursBE4/qAWVdGadnnEOa+Of1J?= =?us-ascii?Q?UMHuEntLCttMyj7SoSSwN7tNnKvSe0k/5XubhRA18OzJ5fGGLLl8KR1tXfyt?= =?us-ascii?Q?z3fXiVWyh2vI7Y1ppEPnxxP6HKXYaBB/1qBVER/t?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d437405-485f-4de3-7ec3-08ddaf11b62d X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8676.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2025 09:14:36.5282 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: I5wpD4nI9J2iT65++ceZC8nH8a9HGnMtWyYdmVJdyE1CdGc8J43MraRFCsNwOK7Cjtm1TaH8G6qmDi9YjmoihQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7021 Content-Type: text/plain; charset="utf-8" Skip PME_Turn_Off message if there is no endpoint connected. Signed-off-by: Richard Zhu Reviewed-by: Frank Li --- drivers/pci/controller/dwc/pcie-designware-host.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pc= i/controller/dwc/pcie-designware-host.c index 2d58a3eb94a1..228484e3ea4a 100644 --- a/drivers/pci/controller/dwc/pcie-designware-host.c +++ b/drivers/pci/controller/dwc/pcie-designware-host.c @@ -1035,12 +1035,15 @@ int dw_pcie_suspend_noirq(struct dw_pcie *pci) if (dw_pcie_readw_dbi(pci, offset + PCI_EXP_LNKCTL) & PCI_EXP_LNKCTL_ASPM= _L1) return 0; =20 - if (pci->pp.ops->pme_turn_off) { - pci->pp.ops->pme_turn_off(&pci->pp); - } else { - ret =3D dw_pcie_pme_turn_off(pci); - if (ret) - return ret; + /* Skip PME_Turn_Off message if there is no endpoint connected */ + if (dw_pcie_get_ltssm(pci) > DW_PCIE_LTSSM_DETECT_WAIT) { + if (pci->pp.ops->pme_turn_off) { + pci->pp.ops->pme_turn_off(&pci->pp); + } else { + ret =3D dw_pcie_pme_turn_off(pci); + if (ret) + return ret; + } } =20 if (dwc_quirk(pci, QUIRK_NOL2POLL_IN_PM)) { --=20 2.37.1 From nobody Thu Oct 9 07:05:20 2025 Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11013058.outbound.protection.outlook.com [40.107.159.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A1F427A13A; Thu, 19 Jun 2025 09:14:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.159.58 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750324487; cv=fail; b=GB0Jq3HXCZ3UDypjtJKFbKC6dspfrEdPL0OatnXX8iw7CYvoeNVIFYQrAk1k7sSkJdyOsiujXZ5qxALYp4aJUJBTh9p41+BDQDfLCHMB1A47l6W+tqnQZirARUMgvP7jTvgLLg5Z64Dq5vKkAMesCJQ+b8Wm64Q50SkJmyDsExs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750324487; c=relaxed/simple; bh=lMYquXVFAfygkQnCg3XPENftDUr36L20TvKmfw52GCE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=J21Se+KVuNbjYtp3YPxofafNeg+rV9KpDImPS42VvdbbsFK0xp9thHIw+skOjDYQrf1Xg0kLT1IQd2JFkB8w18WIGzgSlsJwnku2EFUXPCz+AuXz53as1xslrmXVyUomgixQ1eXPW3Rmb0stIa5c99HrAsdVmMJ/9EXPGCSJ4RU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=S5Hvj91J; arc=fail smtp.client-ip=40.107.159.58 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="S5Hvj91J" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sPV5x3bjO1aua9Q9iLwodMaGFA3pt4DI4zkotNP3dGij/TpGFWnTNzoJsxBcOJUx0kgcKxFpxaFqmgM33fd2COJbIhZ92XXFOoVWj9ewaOmks9JPACI0rT6AKR8gEh6+DcbQFxqtL37SFfwfKqAxGn44ZqmhyaKarFodbz19xtnpuOZ+aQW4r9WfW6VzTTl0p4jfMtVQQfY/cle+DxufVl2h/7P9cCi00/Q2xPlipK1XOrrC5w9zkzuaxe64piGpnBaN9MDVb+4+gFO2avPdAvc689Frr60ATDllVW+D3aLXc9tpLmzNStdNwSLbD4HQHN2QarOJKeJpQ7DDXIFZhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=flF1sNfjgukXPc6Zwx5msy6jj1vAw0R7GpR0xxfoi6A=; b=cL6/YiIwZpGIEAo291ZxC7htuckWgegFWwUKHMzKW1WnCUZvtluDIH1dnknWU9m74+E7bydG66rNHuldZdHIPV6JbdRsrLrR0/KSgRi1VwZUOwHAfReSofEobITZLZtCK9KSae2wBq7TGmPjTIfBo4WeqKr9zRbmb++8CZOvhuWQQnE/8sHIuMryb+1Ai3XRx83ZWaxw5kC4hvguC7yAgq+KBW7ZBC52JUi+7j18ozyYo1eDLztd50yNt9HFD9YDKAVbI+6HWcyFKfb7A98HXhNSHOvWDjSbrud03UwrdvoshNSqWwsuc4jJHYbID3AAWOiI8vRnOSdQlAmBobcUIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=flF1sNfjgukXPc6Zwx5msy6jj1vAw0R7GpR0xxfoi6A=; b=S5Hvj91JuzOSWtz0A6aX+pGhYKddysjvadpon5ewbywyOYvzMR78xtBeU54kmenxadsCuXXNXUX0Asica2kBi0UVStQmvVhT+1FRsnCk4UV1cClYnYDXUR8SH0WVv9S3aXibqXqqoR+6y4kogLqE4RLCJDXFLcfc1m/A3A8T6M4sVNRQaie/n2QQ63Zh8XOJHOy02vczSHQ7rnnNIR1OQlwJYR9o0m0KWiOE4AYMmA0GFYw/Bd8fkdzKUB1cVUM4pEpBWCeNjEFYvZ9D+J5iyKwOrE2WdxiFblE/JlzoIAvKXr7d21ng6k1WIePlGVMB9qRk89Kzo3eOPm+Dmf/WKw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8676.eurprd04.prod.outlook.com (2603:10a6:20b:42b::10) by DBAPR04MB7429.eurprd04.prod.outlook.com (2603:10a6:10:1a2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.30; Thu, 19 Jun 2025 09:14:42 +0000 Received: from AS8PR04MB8676.eurprd04.prod.outlook.com ([fe80::28b2:de72:ad25:5d93]) by AS8PR04MB8676.eurprd04.prod.outlook.com ([fe80::28b2:de72:ad25:5d93%4]) with mapi id 15.20.8857.020; Thu, 19 Jun 2025 09:14:41 +0000 From: Richard Zhu To: frank.li@nxp.com, jingoohan1@gmail.com, l.stach@pengutronix.de, lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, robh@kernel.org, bhelgaas@google.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, Richard Zhu , Frank Li Subject: [PATCH v3 5/5] PCI: dwc: Don't return error when wait for link up Date: Thu, 19 Jun 2025 17:12:14 +0800 Message-Id: <20250619091214.400222-6-hongxing.zhu@nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20250619091214.400222-1-hongxing.zhu@nxp.com> References: <20250619091214.400222-1-hongxing.zhu@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SGBP274CA0010.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b0::22) To AS8PR04MB8676.eurprd04.prod.outlook.com (2603:10a6:20b:42b::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8676:EE_|DBAPR04MB7429:EE_ X-MS-Office365-Filtering-Correlation-Id: 81981523-8aca-46a0-bbd8-08ddaf11b965 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|7416014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?LaWw56i4XaShSOb9JH7cVOnocFZ3S4Ctn8lCVpvyzDq86/m2rXcz5s8dR8vk?= =?us-ascii?Q?NkgoqmWCoWZfpqpKwiO+YGn9XcKI/V7vIr7nHOEuNy7fPkbx4zq53kJeZ9gC?= =?us-ascii?Q?twRR4bLqX30Ls145k6T2rEcRtvO9dexksZPXDBXxDerPlx7VRoVFhepL0WWW?= =?us-ascii?Q?hL5VEG57Vs+m7+Blj+uX1S17c+c12MGDQEkSK0JDY7K3VTJfJdf9SjclW74y?= =?us-ascii?Q?cRMhqxPGKH/qaSEgabbY1rJ7zhsVkjKik6T2QHKlVACXIe4xgXqmvncASSGX?= =?us-ascii?Q?zAoOVMO78pTmdFw3ZaS68tC2isWc4exAatfgcYwnUH3hfMbTRBDdcCIlfzmi?= =?us-ascii?Q?CKLSECzPs5fjmLesUiBnuBUp0lypBl6H9rQPcBEdoC3NXmGIsuZtw5ghu6/6?= =?us-ascii?Q?JnCJ/DnSjqzdvDfqN0BMUAFR1jJJf6CPjkBH+/YeA/AfTgsvKBhCUXeijEQ0?= =?us-ascii?Q?jos8aRDq+JfzkzFYesQ+/CV6GO5A15laZLl+Q26O100FbbH8QMSKCtq5CLB/?= =?us-ascii?Q?+/bW+lrAzjGKVoA7lkNA7eWRr8tQ+OPE3xKWztjS/f1u6iWxwFtXZ3OGKZQa?= =?us-ascii?Q?zV5L91P4/swQD4I5/qyRtL1AVPJBMjc1QTvHHcgoMf5pEcK7r9qq7/ilv8j+?= =?us-ascii?Q?W1Y10tpnz4+7Cpnk+DrWLUp+YxvfNazALo7I8NH0ov3mxejRfDV93JG9QTN9?= =?us-ascii?Q?FLRE8IXRuE9s0IPtMVncXsWPZlZ1d72DX+V8Sr2PhME4C5yP7gxnHDskw074?= =?us-ascii?Q?SasfwaA/JSdFcEkqeYw6YjXupw6YomN0P/1NgxBokSBBfb/iY8upF3VLhg/E?= =?us-ascii?Q?dmPNQYczcjwJkKhm6FOPnSTEMsaOka35iX5W6ijOPf8oqQN/0ZeY3U7C0JrS?= =?us-ascii?Q?QuwGBowr3p+DGzw2Z9zg5BU6SicMZZJOaCa6u2HHyCeKlVWoqiPlWhhzl0Yo?= =?us-ascii?Q?yGPZ3Zrfm6rI9iK41gCygTeX6AaHzkTUR3Da3FkgkfwIxgSrj31GtmTrtWu2?= =?us-ascii?Q?0pjrJwQcpt37K1cPAEIT3s8Mb7odiUYbQ6j7+NEMYZQic93uXZvcozIMuJ4+?= =?us-ascii?Q?/DHZHgEILoXdh8hQn/RoxadhQHVshycRqYyyPbAMv/v1LMsbZ0tHjVzKsP7B?= =?us-ascii?Q?Om4YavqV6rr5eygjwCYdeu+/ruMRA3dWF7QlqnXEOZU4HLDg+jTUt3i5KEXz?= =?us-ascii?Q?rdE793E+Ar/CHwhNAGwqccaFAjaIegb/JFbTvdaJSI6tVyv4vPU3Kud+MHZT?= =?us-ascii?Q?mzhSlSr7FVtYCLzNxHLlFiv4bq5LbiIANPuvO2CBGfURQrNBqpjSAwcNVa9E?= =?us-ascii?Q?5fDFt+j+S3rciWJkZO84vkwCFyrnepBk6JkAE78JZeNZNF8c0vyc4SYzlb8x?= =?us-ascii?Q?JpBg+/5NCSQkOYzpwHWny3NK/g0W9fwt3stNNdz6iGWGaDBru/S2BPXjBYPH?= =?us-ascii?Q?GBc1pbG6WwHxnP3MxDuz9sVnh7x2Nx8cGx84hYMPelIyIp26KvaWOkjMHJxA?= =?us-ascii?Q?1glqjqwF0pykoJs=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8676.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(7416014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UTwW8l4LLbSSQEy1YU3spriw95VKSPJt3YEns6EqPv7vYPmfb9I76CFdOTBl?= =?us-ascii?Q?I12pCbxNp82lt486+UoG0WQoCdONPUNgQTqQwqacPdVxRG4HXNtepkb1aZY7?= =?us-ascii?Q?0k+sW+ADNH8fW8x+m2c4+d6GIfTU3UO1lkO/L4oVpBVXSF0bWPVTG2BCP34F?= =?us-ascii?Q?3H4c+pNP4p2caNPEoPhA44KRj5K0A+XcbzGGY2a00BkTOBMWf26yKCnNY0rI?= =?us-ascii?Q?boIuiZVQOKyLR9arbYJQTtxu6Sn4ovD4hlV4+iuy75kbgEUWRtl/A2zlvLMv?= =?us-ascii?Q?Jt/huySa48fFgFR/CTMwSjoOoZrc0bdnUV+iqiQjZT/VdNoZhfMt27phvQ/5?= =?us-ascii?Q?PtSzzlhlMJ5MCIeeYLPwNFnc2VmT3XZbU0wVV+F/6bQOaShL+FEgVNg0it0Z?= =?us-ascii?Q?SwO+dzubTfZcHcN4hxAXEdxcNnhqiQgolI0M045oV2jz+sUe8UsR5inoxC+X?= =?us-ascii?Q?NlgqocW62ToWABfBXx3kLPwalHtG1htacCb02HuSsoForPmgQ9VJQCm7FNnn?= =?us-ascii?Q?IWzOqdi2Qt17b6OtEAzs9/T3jujFuGP60OdY/rzfgx/e0Q+bIJIMgJx7iuHh?= =?us-ascii?Q?4lFnhTTov03SiY/Zm8aXrBtCDwFhYT0wgGM4XhBPhGGZqKoYiQQSb/R4Hog+?= =?us-ascii?Q?fGEAn5Tp6kn48KhC40tjLN0x863lUzUD+ICiZmsweBt3ls9UJ0KaG3HOfRKk?= =?us-ascii?Q?CC3hDcEZ06Q7R9/rhloIqgHkIfhI3YljX6yxWVTZ67l6bkEFzWnvfrQ3bECl?= =?us-ascii?Q?8sC82jvHAAHCPRCd3Tz+IJ3EzjnPHx8AuXGMOHw5ETpi/HwabGrY7KYD7Tej?= =?us-ascii?Q?nEPmPUTZi84w4jXLf10k5ntvx9ydvHAUg+y81dXM/iRIMFj0LcW9cflZic43?= =?us-ascii?Q?w3c5DSi0gvrawSqLf5lEqYgWIhaFbAdov1fueVIfdvTy+nd1Zm+MYGxyeWCA?= =?us-ascii?Q?utbDkKPrmBgoDxnxvYtXORQ+m5ux53pqbPKqVJviJ21iC4kHLaqW/SSa5UU0?= =?us-ascii?Q?4Q8zy1MLcebC5lyAMNQrnpBOAqLyXVoGfEztYLOQBI5vmxjwUNewkKM/uaT8?= =?us-ascii?Q?8hVJuCS7znvdXNomdu7W/j7rD8fitfS/y+G81TBJnW3zBBPHXIsoQt+N4P5A?= =?us-ascii?Q?ZRluNarXh+Uclj6JGBHsk6Q0jicukq+J3pNmMobxMGKCDTd1PyJRAk24t+Fp?= =?us-ascii?Q?pGOkvOeuPxbSZndoEApIGnfkt7P1PKRZ063+pkDgY94BBUheHxS0DGd9GL2e?= =?us-ascii?Q?dEjx5i3OZbr2TVtjpSURaZBRk0hVPYFSrR/pJC+C87CCRpYTef605xRs5PE4?= =?us-ascii?Q?SvTI32QhxeJl0aYuPpZI9J267AeaJiCGVmW9YwXNrpwpSLahC9FhMQKwJq/i?= =?us-ascii?Q?WbubBtSwbPnytKZnhEvLRjwwl1a0ymHwEdIeF4CrhwdtwJ3YXDDkPgOcLc0q?= =?us-ascii?Q?o+GwIP4vCBMZt9H/WheGsPZg23cl4n62x3yUkq2EXJmNz/2sPkTLP+rLXdvD?= =?us-ascii?Q?fLZukm+erO4ymd0AuZsh0G8NKm96y2ZKPeyd4jfjgLnXqC8ZLpnQTuzUuOji?= =?us-ascii?Q?p4AemfSR7u9b+8b2G4+zHOHPssOfwFXRqP6fdfmY?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 81981523-8aca-46a0-bbd8-08ddaf11b965 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8676.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2025 09:14:41.9582 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MSm8vnkgV+3IMdMQ48IjvV9HP44nihVaXKg7WJ7o9JOe8S7/jgJhfE7Pyl3YpvKeG+YsLeBkyKQ0jJSZND4ILQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7429 Content-Type: text/plain; charset="utf-8" When waiting for the PCIe link to come up, both link up and link down are valid results depending on the device state. Do not return an error, as the outcome has already been reported in dw_pcie_wait_for_link(). Signed-off-by: Richard Zhu Reviewed-by: Frank Li --- drivers/pci/controller/dwc/pcie-designware-host.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pc= i/controller/dwc/pcie-designware-host.c index 228484e3ea4a..fe6997c9c1d5 100644 --- a/drivers/pci/controller/dwc/pcie-designware-host.c +++ b/drivers/pci/controller/dwc/pcie-designware-host.c @@ -1108,9 +1108,7 @@ int dw_pcie_resume_noirq(struct dw_pcie *pci) if (ret) return ret; =20 - ret =3D dw_pcie_wait_for_link(pci); - if (ret) - return ret; + dw_pcie_wait_for_link(pci); =20 return ret; } --=20 2.37.1