From nobody Tue Oct 7 21:33:36 2025 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A98D926560D for ; Thu, 19 Jun 2025 08:33:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750322013; cv=none; b=Ux+XsrOjHIIbCbBjkj3CWcZtKLu1RqxS6t5RIaeyLpn6ni85G/BMDjc1zskWISb5KiOEvZSE3VCfMSkK4WPdTyMngjffoW0NZJznZ/X1KP3twTe+fUPm0FoSl9xZdCopHJuB10UpFk8+IxHUCtGBMp0bl4jaHFq+7bG7LeQ2xoQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750322013; c=relaxed/simple; bh=bxD8Wln+1c1gwTOx2BtC9yxuB8rPQnYC6Cyew1Zz7wg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=itiGwDE5Zpjv8CNUWBl/fvDWOgqv1UCgmE6CqrI9yeNzZkDMNJIVSY3RQjKbx+nkv1wGCFE4CS3HBqoJh0zpbDvejbDhNyNx3atUXZ+SczFIZ4FP/wMZvv6bLOsO5/7HtuUiwIqZxU4MAhazjT9GsckWqigz+UqeB7ZMuqqOWLY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=kCk4oxlO; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="kCk4oxlO" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-451d7b50815so3532395e9.2 for ; Thu, 19 Jun 2025 01:33:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750322010; x=1750926810; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=QYBRyPsDGU996dnyWDGUWt7Y308dv2asqUkMv7/NV4k=; b=kCk4oxlOBP4BWr7VqPuUHZo8nB7bRtYi5NYivan8kre8soVW+hfKYAV8luG3rkWT5b AtGOlXhv4W66UaJoUIvDe5IYFsGI7wAhmID50SdsSQ8QhzOKaDGleOrtCkt8hThj+yJW 95CEahqgDHxl9qYe0MR26UG4b93jZQD4Xs+Grt4FhU1PlpWGEun0gBLR8PcLWdtDDDQS CTQ6FKCfJNhwb7d04BzWbwo6rBvjPGP3zdCjpxjUJzyi6nC0rVw35+eAde/j2FCfLcTF MURo4jQUpE4FGFVqybAuQ/CVKhu6gPrlNI5+KYothHjURCIp250ktRymFHspDdQTdOLP WWZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750322010; x=1750926810; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QYBRyPsDGU996dnyWDGUWt7Y308dv2asqUkMv7/NV4k=; b=cBjQ79K74+ZeGhNoSdcB/KFPJ+LtxrU68w5h2YQ06dkAjmGUgktGgV22rM/oro4+tL z3uSipfzd3FbfoIcGYPcX0fstSNKcI+7NVTf1Lo84J2yGm/+eIW37++Po3WoDsRQsAU3 xdF1TILlYLSj/kyfOjwrPnGHI0qMikA1Pkel0wJ11qFAovTYQwUU0uBJ8XVUeFll72m6 Hz4l11k0QWxBgKVCMR2wlYYLNUB8kzBvpR54zwdDRHiHhHKc3yd/P1ZRW3xXHQb1qxjO ICIWx2OJb6fx2hvLWEahPd3MZczosnfMFdfDtnHkzlkvle+JYNIwZzvn1TJOhYZeq5Qo g8QQ== X-Forwarded-Encrypted: i=1; AJvYcCX1TOYNoBe8/4G147ZTzpSTku25ku/MhUK/FJswY1YBgxb5MWSGWc47x0cWJUScKVz7nRc6722Oq9nlqTs=@vger.kernel.org X-Gm-Message-State: AOJu0YwkheElume9HUZrJwFHTUfho7Wx41PKrOfM8QgxXderf0rKAnKp nwn8+aJbXSV0AXH039zwbU5fxNjokOSD/DAEDENPpxBSX6GA7VKH9p5+PZAaWTHIrwU= X-Gm-Gg: ASbGncvcxAXNda4KAi+Uq/XuPJ3qyfpkNpjlvuybyldylbhOEd3euZsZT4onHPAvHHd YK+GnBpL+D1ls9wsH7IduXyN49cJ4IEkqwZDtkXlyNymi0W0vOnMOuUynku9lPw4jFQhS5SC6ng BYEnS7KEHBYylye4nplf+2pyHS35WOIKKLhe/ffPU/phzU527d/LAyc2aIILVbMxv06cqxNsk2c st1DELjf/8Y9BmFyrQQV9Z2q//cfzqGi8sl+m48+044JL+4xFt8gXkDPfSZ64Uct6mDZNLHztTy 79OLEdDo5aP/Z3EcjZ9BI2MxHGyu3c2i7DzL4hEdJkw5nofwnJkXchozTEEy58hc+Tg= X-Google-Smtp-Source: AGHT+IEr0cQ3t4TpkTGvuVjGq7cZO5AQ6BZfBJ0TBysup1ZbbPr4xJbOqOBjen/dHiRJRCL3wPVhbA== X-Received: by 2002:a05:6000:25f9:b0:3a4:f024:6717 with SMTP id ffacd0b85a97d-3a572e9a4a5mr15722608f8f.53.1750322009911; Thu, 19 Jun 2025 01:33:29 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:c485:fe15:c9ab:c72f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a63a42sm18828151f8f.28.2025.06.19.01.33.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jun 2025 01:33:29 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 19 Jun 2025 10:33:17 +0200 Subject: [PATCH v2 04/12] gpio: pl061: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250619-gpiochip-set-rv-gpio-v2-4-74abf689fbd8@linaro.org> References: <20250619-gpiochip-set-rv-gpio-v2-0-74abf689fbd8@linaro.org> In-Reply-To: <20250619-gpiochip-set-rv-gpio-v2-0-74abf689fbd8@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Orson Zhai , Baolin Wang , Chunyan Zhang , Robert Jarzmik , Heiko Stuebner Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1498; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=a1x5aRsn4kpz4DTuXQ3tdXS/YzbAV4e8kj3b/qk6D/4=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoU8tRgkTy/UGYoAUmJiupC/RZztmRVGafnrAkg DK/05i+a6CJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaFPLUQAKCRARpy6gFHHX cnO5EACetBLUgnxHHE9jFOzifG/ThcrCv2NXqdEgAKT3Y5Vy7gTAQa9+76iIHz6/1YKVhIqBc8v VC9froCuMPH3X3wFZZ0j7qu3QM3lsGd6ZHQjMxwaKEYMK2dj/tPdMULBW/2meqofEw6L8ruo9K1 KlTutcobE1KjZ576wI0Eb3no+rxcKiOw8lESyoxR6YqA2oQ9lPtNO7HZAboqGg9IORRpLBT2FzH mI39kRMp0Wkd2cMdsPbQRmVgNjtPrqCUpzCZReVR1JQuW5YZ8YAk0gB9foxpkPRPNz6HYqgEZT1 kr9fDu3aUqpt6y8vP4iKtzPpj+ilsyCVFqe/2STYbwkhtYE393F1GOa2BpW6xBvQg0bxEeXm6yp QIZ8qzI9+FpX/6EZYWBeHFRhddA6K92F0EgjXP1MkBdCGB6I9pxm/5sGSOsH4sVNDVVmq2dUvqi FnElD2iPkDLGaH7QxmbmcuLFBMgGmJdIEjDVZQSY4MDDhA99yiqiQKdtvqHP0vgAYtZ0syLQTIs NmPcMRd4jOXZ8OxShxyr/oXyYY7H0Mk60UBAQiUb2XQ1ASEY81pagI+54BCYqW8eMPdf+4PtUPf EEoLDdOq/+VJ3kDxQr3C5KU1pxKPudgdhDjEZiEbK/I8HN6IkDYHov6F0Hb0u6P4HKt701hZl3n K8gv+VNOpIv6MiQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/gpio/gpio-pl061.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-pl061.c b/drivers/gpio/gpio-pl061.c index 1c273727ffa3ac54d0f1e66bd6efb784d2a8604e..98cfac4eac85295915b801a62d6= 2c8d78f6cbc4a 100644 --- a/drivers/gpio/gpio-pl061.c +++ b/drivers/gpio/gpio-pl061.c @@ -115,11 +115,13 @@ static int pl061_get_value(struct gpio_chip *gc, unsi= gned offset) return !!readb(pl061->base + (BIT(offset + 2))); } =20 -static void pl061_set_value(struct gpio_chip *gc, unsigned offset, int val= ue) +static int pl061_set_value(struct gpio_chip *gc, unsigned int offset, int = value) { struct pl061 *pl061 =3D gpiochip_get_data(gc); =20 writeb(!!value << offset, pl061->base + (BIT(offset + 2))); + + return 0; } =20 static int pl061_irq_type(struct irq_data *d, unsigned trigger) @@ -328,7 +330,7 @@ static int pl061_probe(struct amba_device *adev, const = struct amba_id *id) pl061->gc.direction_input =3D pl061_direction_input; pl061->gc.direction_output =3D pl061_direction_output; pl061->gc.get =3D pl061_get_value; - pl061->gc.set =3D pl061_set_value; + pl061->gc.set_rv =3D pl061_set_value; pl061->gc.ngpio =3D PL061_GPIO_NR; pl061->gc.label =3D dev_name(dev); pl061->gc.parent =3D dev; --=20 2.48.1