From nobody Tue Oct 7 19:50:49 2025 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA166244694 for ; Thu, 19 Jun 2025 08:33:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750322009; cv=none; b=Xy1iuqqLlYCO4PPONYuTZMTYbnxFBOwguBEebX2yT3/uMH7y3+RRRCO9cxXRHkLNFz0GWVcPumsFcXFNPrgFHUKexB97jtprhlU8fYqXYZtbyPEOrbCl10H5S+iPBugpPrH7E+oQqL0vyyCDT5Z7MfrKkGNQsW9cCudcDtY9Yv0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750322009; c=relaxed/simple; bh=RPhkT3IzDcFi1m3smXl28iMPiZa62xWz+n4q9CIoNU8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JTNbagkB+j4LY3xUDGTWkYwq1GfYWbR/PI+VmIvWjArB8YDunyti7tv0gQhcw5UTsD9NV1KF2+YuoWsm6dC3koABmeTlWbXVlyz6hxWLcPyTb4ZlEa8GIw4MumaRfHs+OkTWllkCeB9o6W6/RlPyx4yJfUqRN4AbtzyxDzXijxU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=22qiFnFa; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="22qiFnFa" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-3a4f71831abso461615f8f.3 for ; Thu, 19 Jun 2025 01:33:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750322006; x=1750926806; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=UN053MZ+yEo6A92AhgjaJPUWZr1Vpzz6RE1Bqia1tO8=; b=22qiFnFaH+7yYTD1WPpTHi25yDE8TMFCzdlMQGwxA9/uqj+5xdwK+e/xqNfUMPjsSR xfFihPDRfOYrkWrUI986FYZPR9/3hoj65DjfOeEDYuLAU6OmuBgH2QneGL/Ti9cRPvDO 6B3NBKyZkcrXrnhGNPEvq+upQJXLsCHmv3btLAALo6oUlj0KO2A1CWl+3gyD8vGPpwyU P3N2uqD1rOTxdXZFj/t9WvbL4JX97CXG6Gr/cYm2eLoiBPHS6MYrjjB83gzEaOfM/HA0 E8zNCP+DJGQuo2/vbVB6q/UQIB7Fv+q0EmtW+aSu9pz9vMN1HCpKFjM56v6OXjIGAY4M TCMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750322006; x=1750926806; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UN053MZ+yEo6A92AhgjaJPUWZr1Vpzz6RE1Bqia1tO8=; b=D5NonV/aM0nDK81tXJvkRv4xJAwZCaBOatAXP5Q2ZLmaMEKimgd8Mm807+8NHloarz x/8n+B4blys9bGNKekkaS/2bdRrXCIXr/Pg/dn2qZTFZtfSeesnhBNPFUBKdWQgBBMqq RMA9TUda7Zx6CjDkc8jNF5cRMyE0ZMe7gHQOJGxdJIcumGYECv2cZ5YWaevdKU3LNFGt RZgXfhjeFWIgf2fNsSL/y4W81L+y/O5IsoOHK7g3dC737qSr6BXvf0ZfeoDQ1M+YWJju MrfEwaq1Q77hNb1oxul2CQ4hibbH3By1lh6Y6ct0wk2u57/dvOSs1iUrSvJTBsgMszjZ qLOw== X-Forwarded-Encrypted: i=1; AJvYcCWdXY/oQOKHR0yQ0T3mvGTjNrNHueIGx5sgqYR6aKz0MQAqTYsnW2hHoyNC3Dr8GBh0TGavebR5iWxsG3A=@vger.kernel.org X-Gm-Message-State: AOJu0YzRZhx/SBDNMV3JJfTJsRkoE4UxIbxE8vAWTx7iKzZTxem6gHqI GUgwGu7075COCDv6DRTjNNNrp1kmVrfpk8y+Vsq4TQsru0Jg+9zbgf7yZXkPQOeZ9eQ= X-Gm-Gg: ASbGncvqyriR7/Fotec2j9N4Rjgq7X5tHunpcPSl3A3tV8yYY4/tTfrUXQeyW7mgnVG qh00xT3DGg870zmB+X9tbcUs7U9G6y2645sLgjp5HTIffRmHCnbf7d+t0w1Is8iG6RXI3qaPQKn 1tqQBtLBXgML1W/TuvRsaVqfc2j6eCXQQpP8x21D+h69q1c2AbADQQcV9dh171gZnLpnLK+eBob aabYBOjgNWxtIoORUs/SFk0wKDEDaODar4U6bg6HeJUQxP16I5lzKQq9PjZHzT8yeuM7DlvJMz/ QvP1zT6vQSohHt59XiKK9tGRlPOGZPDOtN9X0NkOtEkcNQslWOi8x7MJ X-Google-Smtp-Source: AGHT+IEiED0mQ4+a32MGCQhlzyMcTjNqSc3s2m6eXgPGOeUaueHu67jN6I+lpA1Wnn2Ut5FCEP2y+w== X-Received: by 2002:a05:6000:25e9:b0:3a4:d994:be4b with SMTP id ffacd0b85a97d-3a572367d55mr15222705f8f.1.1750322006052; Thu, 19 Jun 2025 01:33:26 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:c485:fe15:c9ab:c72f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a63a42sm18828151f8f.28.2025.06.19.01.33.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jun 2025 01:33:25 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 19 Jun 2025 10:33:14 +0200 Subject: [PATCH v2 01/12] gpio: pca9570: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250619-gpiochip-set-rv-gpio-v2-1-74abf689fbd8@linaro.org> References: <20250619-gpiochip-set-rv-gpio-v2-0-74abf689fbd8@linaro.org> In-Reply-To: <20250619-gpiochip-set-rv-gpio-v2-0-74abf689fbd8@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Orson Zhai , Baolin Wang , Chunyan Zhang , Robert Jarzmik , Heiko Stuebner Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1532; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=t5r7nMPMOl/Fqhu7blFrjnyYOcc5SoneVJWT0UVvyG4=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoU8tRTHJhon1ZuCnCenmO49z6Bq3Wu3wOrzICX o4RpZQLMR+JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaFPLUQAKCRARpy6gFHHX cq8LD/sF6228YfnMmyZbE3tlZK1iFMNVyr5c67b6FoDsGs8zrAd40Lx5oCbTsP4Im25mpNB9Nly Ezf6/TpCHbwpLVGeCuUl8xunzUEtaXQU56bxevMxjgvc+/QmaDQbQ5ZOn8xBHc6cLHLZt5AfqLr Kc76zQB/jux76D480JbJMZM4S6zFEpAn2Ey3LfaBXrNnIRgIWFHce7Rb9DS/+MJDbjWF7tjUlg3 SxGymF06crmm6xMLbzkAYcozsGRun/1XntMRwG00CcswvE9JuR67I2SDFHFRchOJXDVYhjaaZhF PI3R0uPx6ZoQ4Nj6GyULy2Wg6l5am+JImsMhwb8P7hjA+eGiZJVi1kcyvSPXBaDy2n/bf/VlA8t j507rlA7XprBb2k+4iBSv9Uf46wUQ8FOudWqHDC8M4BcqiVEzgOLfQcdB7Brhz/6Q1EBGbXQW+/ N5GPOEY87jwj4jlXUe7NvKnmk2eC79EAeWoS63elxYg7bDZuoG7n+26/J4V2iNOY1jyfQRpPRri d81T4MjJp0IRjO5TzN492JN8CLSFWVt/6OkZvduQ8LYmqx6NDXoN/v1Tt4KUNFZERDEZ+UWlko8 OmZfykAWqmgKXLrp5PTD3mov5S6owsGQzcDGn9zirpSQ9Vxz4NrxjvMVwAhjmewsTMV/QCC+aXB E//DPkJ2ybu9CIA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-pca9570.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-pca9570.c b/drivers/gpio/gpio-pca9570.c index d37ba404936835bca160822ee361604827976e9b..a33246f20fd838a57abeedbbd7e= 58259bf073a86 100644 --- a/drivers/gpio/gpio-pca9570.c +++ b/drivers/gpio/gpio-pca9570.c @@ -88,7 +88,7 @@ static int pca9570_get(struct gpio_chip *chip, unsigned o= ffset) return !!(buffer & BIT(offset)); } =20 -static void pca9570_set(struct gpio_chip *chip, unsigned offset, int value) +static int pca9570_set(struct gpio_chip *chip, unsigned int offset, int va= lue) { struct pca9570 *gpio =3D gpiochip_get_data(chip); u8 buffer; @@ -110,6 +110,7 @@ static void pca9570_set(struct gpio_chip *chip, unsigne= d offset, int value) =20 out: mutex_unlock(&gpio->lock); + return ret; } =20 static int pca9570_probe(struct i2c_client *client) @@ -125,7 +126,7 @@ static int pca9570_probe(struct i2c_client *client) gpio->chip.owner =3D THIS_MODULE; gpio->chip.get_direction =3D pca9570_get_direction; gpio->chip.get =3D pca9570_get; - gpio->chip.set =3D pca9570_set; + gpio->chip.set_rv =3D pca9570_set; gpio->chip.base =3D -1; gpio->chip_data =3D device_get_match_data(&client->dev); gpio->chip.ngpio =3D gpio->chip_data->ngpio; --=20 2.48.1 From nobody Tue Oct 7 19:50:49 2025 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C347263F54 for ; Thu, 19 Jun 2025 08:33:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750322011; cv=none; b=Q4cRrIk6KUzp8afIvNs5RhcKMpyp0sH18r03hhaAIJg37LRV9wqNGkpz9o2Jo9Xxn1o05YhN9zK0OyCknqsDz04P6pHsnKxgAIw6Zanqsr7A8PIuijkM3Pu+5PkjtYKRBBHs37+WY1MarFT+sUtgKFbAFd9/MJPuvhze7JajjB0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750322011; c=relaxed/simple; bh=r8YR0XSxpNQwUjB1snBTCh+aO57h/fzpJl+JXwgznDU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FSFUWwOSaY+6Cw7konzi09kseYO0MpHmOEZd0v2ZEjK1nNlcdoyqczEI+A72SL7i6SvEsBn/Br0jzmDAcD2wMEI9m6Z27Xj7fPpKlLcCSnnHXOP718posxSGvtP1IW8C3+B3Q1UNuovxz5+74D4rFBkzbb/we+VoeGRgW/Zj188= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=iBvyDpcw; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="iBvyDpcw" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-3a52874d593so525599f8f.0 for ; Thu, 19 Jun 2025 01:33:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750322008; x=1750926808; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=aoNSIKbOdd485smFmBnHl/Mm0pNj2Y6zx1eXoO1wxPA=; b=iBvyDpcwy0z18HuPayN0oSEHq9x2OAmDWQktAfa8rMIkVP7hofvhDn82PGr8QoBRA6 5uM6USqS2Tg1fkWMckAC/LUxZfY8tfnGu9+sFNPvION1I0GSi0s89sZClBQ+qo9VyVAu e76m08zEIewwrl4MoDZqr+KUn9GEDsP3wwUrUYta6Hv64KvUmdb3qrGKpgUilBrHBqBR MT3zMz5bAff6r2JHXLnq1oBf07XNeInfNt/3UKBNWZyzn6YH37CMk8kbwZTQ8sTykXCg 9xXBFp3l8UJTkvQhcEQ81gNhmQXVxV4r5kUPNuUjyIaPfUtMyWD8110MvMYcstYharPc +/uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750322008; x=1750926808; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aoNSIKbOdd485smFmBnHl/Mm0pNj2Y6zx1eXoO1wxPA=; b=tMISREC84+17RcmpkpajAK0ne972JuFwvwSc/7fj4wzXTutM8MSx9x93tiSmI/AHiN E+BO7fu1USsrDWdrhpwaaRpLfSAo26QQXnsmzBJ0+oQk+nCF8dxGgaS1T2ZXTLy45Io6 iNm7bbrrZVH4Ga5hlpop9b6T/ACLwN+cnJda0r5rk6d460pfOPKtY3zZeFDXjgnzPgjA PaZJg6r41lC1PGCZFRhvBcANSXRyFneGHuQP6djRhAEnBG44ftSoCPd6SHFDX5gRhLes XQmJ1HPwWOHt+D3hM+5F7c9SPRRQy3CaeoeFyUWkflu4uKySjHURMW6CAG/9fhEGf5oq xh5A== X-Forwarded-Encrypted: i=1; AJvYcCVE7Ll9HODH5adv3tjoQVWRyjaXr3ZVRukX8JQRcHpDtlv2gJt2jUq7TiX/BAqxmK1ABJBD2YBZ7+SEp6M=@vger.kernel.org X-Gm-Message-State: AOJu0YwxDsXmq/oUGzf+c/wdt9K4Ahj5/iB0aCEI9Uw6+OS/15i0yLnu hLmVtxm1ziQNY6uJWIYfWpVzaelYVEc6uWTTcqflx9v0lbqPJAVXjA6ThbNTKS8P4p8= X-Gm-Gg: ASbGncvsFcfe5mKiNTPrRLyC1tQUpEPwTrwTKQIVm43ghjGkLMklDWVpZwomTFfyRda SDQvvR89CTUJlhapkdx6YaQME1NUJtmJh1iHDsDGbFYjYMcFtSWA9MCm2OfJGR9lYvgFAzes7V3 yPECcOgArwqIZKJvNImNfQuQSfmGylte6yVh3uvOGGjQeQQmropYKY3Gtg8KIL+xnapRUR01iRX YFDSC0vE7ew6L83JsQQuKq1nl3Rs/iL/hbRctiYGt1t7N5utp8wP8BZrZ/Yti1KJ6wQ8co5Reci ZaHh1GfumE3uBVe3c3QTQ4LD/A4v3MyiOi/WwaPLobxs/ZcHKE7ahtMd X-Google-Smtp-Source: AGHT+IHe4d+B/hxUOK2bnJFDnHeb97EwrHtnkLvTycjD/SAz+yoFSaaQYQmyOZJ3t+SenurZC+RZOA== X-Received: by 2002:a5d:64c2:0:b0:3a4:e6c6:b8bf with SMTP id ffacd0b85a97d-3a572e562abmr17981536f8f.52.1750322007770; Thu, 19 Jun 2025 01:33:27 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:c485:fe15:c9ab:c72f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a63a42sm18828151f8f.28.2025.06.19.01.33.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jun 2025 01:33:26 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 19 Jun 2025 10:33:15 +0200 Subject: [PATCH v2 02/12] gpio: pcf857x: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250619-gpiochip-set-rv-gpio-v2-2-74abf689fbd8@linaro.org> References: <20250619-gpiochip-set-rv-gpio-v2-0-74abf689fbd8@linaro.org> In-Reply-To: <20250619-gpiochip-set-rv-gpio-v2-0-74abf689fbd8@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Orson Zhai , Baolin Wang , Chunyan Zhang , Robert Jarzmik , Heiko Stuebner Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2108; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=UjdVhHBdj/MT105x/Q2pFxBb2AP6k98PFv96j+C3ycI=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoU8tRUaVjYB8TCH13E8mcMXqkCPZfRtBR4qqWH /WUoQsvQ8iJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaFPLUQAKCRARpy6gFHHX coGSEACHErXifEnqqKpybQk8gmcrD11FOI6ZnQC3xR1I1k7gBjHsTrsAjYbi1LE8fZKHMWwo0/k lnk2USAJIOjDaSZNWlaynNQIEUCVwXFmrWv59D2ceVNX+veJh+sri3z66LQYoKQu1Ay9Vno4ujR VqBQm3VrVuWWhfTqPgaHS0nk9tAd1ABJZBTnpfvvG8JQVLmkW6HRnuIdmSpjFZb9XdQyZS4rNhz I3C4BGnGt0/X5kBcVbQcYJCRZw4A4iHOXR+U/BWhAsULDAiSSNISKyziUj/v9zOUi1qEQYqGXer WtKHJgZbLTB/DTZF+KEPI7MU2cDMDO5qfMzLCHqmLwZmdbCM5m/LAAjJ1281UDkrQbuThv883ow 9AppTsR/koSlX8YaZX09dkZW3HE9U8YRRAZmV7xkMCG67CW7l2K/viC6O+umZlgTwFN0YWjpKxN EKEJeL4rZrJqT41/WsCmnPE3e7xoZIEDNf1viV2O2QgapMzLmKLhCbZL3tAgVGRGaGvJFPE75I6 nfyEebW2KfZU1XPbwL84kSd2+iAXvmOMmj23Z/rpcsmFPXZqHelBfIra2Ei4bs2JEXaMmxHxjbI W+rgA+Y+lzcjQyj45sI19sIvRzuPUr3OyAdpVYyiXD6DISVH0BUL86iT7yIkuoReDqqdohECXIL d7uhlxLNix+8Agw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-pcf857x.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/gpio/gpio-pcf857x.c b/drivers/gpio/gpio-pcf857x.c index 2e5f5d7f886598318b753304e7e0efca54ff8b69..a042036803336439d8e164fcfbd= 0263b0e84f3a4 100644 --- a/drivers/gpio/gpio-pcf857x.c +++ b/drivers/gpio/gpio-pcf857x.c @@ -171,21 +171,24 @@ static int pcf857x_output(struct gpio_chip *chip, uns= igned int offset, int value return status; } =20 -static void pcf857x_set(struct gpio_chip *chip, unsigned int offset, int v= alue) +static int pcf857x_set(struct gpio_chip *chip, unsigned int offset, int va= lue) { - pcf857x_output(chip, offset, value); + return pcf857x_output(chip, offset, value); } =20 -static void pcf857x_set_multiple(struct gpio_chip *chip, unsigned long *ma= sk, - unsigned long *bits) +static int pcf857x_set_multiple(struct gpio_chip *chip, unsigned long *mas= k, + unsigned long *bits) { struct pcf857x *gpio =3D gpiochip_get_data(chip); + int status; =20 mutex_lock(&gpio->lock); gpio->out &=3D ~*mask; gpio->out |=3D *bits & *mask; - gpio->write(gpio->client, gpio->out); + status =3D gpio->write(gpio->client, gpio->out); mutex_unlock(&gpio->lock); + + return status; } =20 /*------------------------------------------------------------------------= -*/ @@ -292,8 +295,8 @@ static int pcf857x_probe(struct i2c_client *client) gpio->chip.owner =3D THIS_MODULE; gpio->chip.get =3D pcf857x_get; gpio->chip.get_multiple =3D pcf857x_get_multiple; - gpio->chip.set =3D pcf857x_set; - gpio->chip.set_multiple =3D pcf857x_set_multiple; + gpio->chip.set_rv =3D pcf857x_set; + gpio->chip.set_multiple_rv =3D pcf857x_set_multiple; gpio->chip.direction_input =3D pcf857x_input; gpio->chip.direction_output =3D pcf857x_output; gpio->chip.ngpio =3D (uintptr_t)i2c_get_match_data(client); --=20 2.48.1 From nobody Tue Oct 7 19:50:49 2025 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC01D264A9E for ; Thu, 19 Jun 2025 08:33:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750322012; cv=none; b=jhXw6Hs17ar1tCImiV0uLxE2z8ZeL9Ja0m8jhZRZ7TmpjElrXCNRQD/tngjEcxZHb2NZ0A6oEIgvHOAn9kNyhXZygiO2d26DgFaN4bN10QrSNQiLS3Ze/vDRz5gwnytQeFIr1LKBeYcu/kGx1D7GcX7hinYGNW7SY6NB1KxRWv0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750322012; c=relaxed/simple; bh=kEfiCA9+OheiBriw2pdL33nAXF823N9SCYa1haJTgFQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HiNE7rHf6R4mIIxo83zP5oSjMUAiuE1JlPesuAa0HSMijQzgM3HyxWO/WyVNU2nun0REW75SN4IoZ3u852gpr3adTqnouwKNNsmVxCaRrKu08CB7uwI+FoVp0vGHsqZ1nnU+h8eO+bOtSytxe8h2fPvYzb7IMDrOFeFsF9CgNyY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=NA2h3asH; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="NA2h3asH" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-3a4f379662cso466959f8f.0 for ; Thu, 19 Jun 2025 01:33:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750322009; x=1750926809; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=BunBstoheAwjjbUHp5liz9ofrsXDKVHtZqsL4Aji7Bo=; b=NA2h3asHbxEWG0dXYV57Zwo7DzfDvtxtyH22ft091dMRYnrxFmGgMHTHh8ctJCjSU6 voo47AO8lBLHLojbyYxr1888wPeVKeQmtayI4KukIqwMA0yf4q5kVPAaimuRKCl3W1BP eW54mgTTN8O5jGKZmZztPhIk+I9n8oT/UM7oLxBj7QXxgd5n7cqBVNM1DjyGsviyZ4iO L2YMj09KLXx5brVphtdEX/I+MPTI9bGhjNu64gLQwcLrMRAYmZaeGz0wQSr4E8bf3Nqb sRm1PMocNaRQa7KYTyNSWbpsop30NCLfFwJJ7pzh5lsSiwyWzinN5nGbkLzuq6T6uKKZ H23A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750322009; x=1750926809; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BunBstoheAwjjbUHp5liz9ofrsXDKVHtZqsL4Aji7Bo=; b=AKwlPdR6r0otYRTQanpQQiBOlff6QtSWXUDOPo4mFv1G4ldfLakh6uhxu9O3KTOnLi azgaQGLHNGkinLboZknkc3F7ocIu0zibOW+qmYu605LZT9JV0qkQpuCqiXSziP+Z2qY+ T2G7xdglMD9RLjoU9ptw0oa5unxT2+y7J4bhOR7bmrByaivrD4uNmHI7YVflixc9QrEb MKKuzMrN7krwAaFajoad7TzwfMd9YwnxZzRQQbAAKfD5Bc9Crc+/mcj5WaOweQGF3Qbx 0fsJuFS/5tO7zla3KD+aJWOirWoxSGf8T7m2hGY96NWNZL1LpVdmHZCvnYTqoGNC8s67 +qFQ== X-Forwarded-Encrypted: i=1; AJvYcCXEuD0dP3slfYOWunh1hfO6tuAyR3Gr6ZnhUtHybYxZ7p2l9a9IzBOq6G/r2I0+hApbJRDCMkRpY9p7qcs=@vger.kernel.org X-Gm-Message-State: AOJu0YxHzEgn0vGj4V/6mV0TNXdN3gdDf6QsANIIqDyCalNsk9mRwZBk ATkjShvVua35EDFBuDx1aYqQhOmyltxY1hpIBg1emB/N5cpggXCLObsjaHEzdkd6294= X-Gm-Gg: ASbGnctvI/bORnLtz7RqzyPn/VnR8mYK2LdUy+wFSBbL605b8a4obq+oHr8zSB19xk0 u+JSYyLnRkMcW7yKieyheB3W6LAd+XvOJM+iq6kcYrE3jT5G8yEaGIj8piIgps7d29gAwx4yNJv SAymRzwHyod/EkHzYCjcP89jq9zStNcOCXs5dMNuiC7CZy4CWL2WpGQJEkCGpN4DsQwfufVg4V7 499mbWfFwqDg4gILL2xyXM6XFQXFuAhvQf7PP2003XHaLFMd5EFwpqLTxcP53UiY6ZbV4VIBJ7a mxjjV7DUMDtcyLXzCHdG+EtWvw007bEpNGwYZUO22O5ANUGQGKXywCSv X-Google-Smtp-Source: AGHT+IHPLcB8/29mYtkUt8iKok7FC37biZwWB/Q/SP56+aQt/F1bk12ty9NxJOh//CgnB0DvwIlwFg== X-Received: by 2002:a05:6000:2884:b0:3a4:cb4f:ac2a with SMTP id ffacd0b85a97d-3a572374884mr18221393f8f.21.1750322008719; Thu, 19 Jun 2025 01:33:28 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:c485:fe15:c9ab:c72f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a63a42sm18828151f8f.28.2025.06.19.01.33.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jun 2025 01:33:28 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 19 Jun 2025 10:33:16 +0200 Subject: [PATCH v2 03/12] gpio: pch: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250619-gpiochip-set-rv-gpio-v2-3-74abf689fbd8@linaro.org> References: <20250619-gpiochip-set-rv-gpio-v2-0-74abf689fbd8@linaro.org> In-Reply-To: <20250619-gpiochip-set-rv-gpio-v2-0-74abf689fbd8@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Orson Zhai , Baolin Wang , Chunyan Zhang , Robert Jarzmik , Heiko Stuebner Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1483; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=mZa8mgQmqtI4o68XMiXnsHjV4blkeihaJT265+ul6Aw=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoU8tRA5Lt5tCecOg14IUXcT8lEaMqPIFkzeDus xIhrJVliUeJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaFPLUQAKCRARpy6gFHHX csRrD/0X4kU8CvgNicRwRcPWkiYI5uyEKdHA44BuqB296GSDxiSMQlry3tpH3bDB615ncgTzJma OeW1E/h2/kWDyXb/rNf+JC8p6+Vp2CybgFfPoOITgwBlsGU94i2zsJVj59QgKSr+zQy/72qvBHn 30sFm5mbKzrutIuUP6hJcSCzDOlVbid1hEET+ln/VekIRRKHcacMTBTUZ0WWa/nfcUZRTZzAX2L tFfYnE55xhV5+Ol+XjM9Z9Mq/lCTwzhN2RBjrgLNtGizgzogE7BB3D1HB+DnRNGG9MY4m9dVllv 3OxtMEmV0j6XpjJIYQjMNDJFdRJgoMbELkgGEgBPprC6VEPHwtkQVpt8lk+IxBBa/qHDuyusXaf 7ov5BUaSMqQwsumEzkNW99h2bcqbJ/5v+eU/7YJeMAed+Ayi4yN2/UGvuQwxTH7gPEhgYLrlwzR 8UCVpkgDo5KYQ0WCsn+HvBworLov88KlUpjNIBrq/cV+Xmp95zE7w2JscdCfsFoclXHa1JsL4+i m1+oxV36y02XpfZ2aTxmzR4poQQrGV7KNVIehnHYTNdmNfXIhcHi6ksh5yv3TnZq6PtvyGM7wZb L1a0SsyjT037zulwfvX0arMDLrHDEDL4AFJENcGpmVSVfgEDcvQNQ3jHDR/tmWO3BUf6Lz+Se5A d+JfGKVb7WYgPOQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko --- drivers/gpio/gpio-pch.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c index 63f25c72eac2fb98156eb7682e780247a893d7e7..c6f313342ba06a1386d8ff8a882= c9344a9e809e7 100644 --- a/drivers/gpio/gpio-pch.c +++ b/drivers/gpio/gpio-pch.c @@ -99,7 +99,7 @@ struct pch_gpio { spinlock_t spinlock; }; =20 -static void pch_gpio_set(struct gpio_chip *gpio, unsigned int nr, int val) +static int pch_gpio_set(struct gpio_chip *gpio, unsigned int nr, int val) { u32 reg_val; struct pch_gpio *chip =3D gpiochip_get_data(gpio); @@ -114,6 +114,8 @@ static void pch_gpio_set(struct gpio_chip *gpio, unsign= ed int nr, int val) =20 iowrite32(reg_val, &chip->reg->po); spin_unlock_irqrestore(&chip->spinlock, flags); + + return 0; } =20 static int pch_gpio_get(struct gpio_chip *gpio, unsigned int nr) @@ -217,7 +219,7 @@ static void pch_gpio_setup(struct pch_gpio *chip) gpio->direction_input =3D pch_gpio_direction_input; gpio->get =3D pch_gpio_get; gpio->direction_output =3D pch_gpio_direction_output; - gpio->set =3D pch_gpio_set; + gpio->set_rv =3D pch_gpio_set; gpio->base =3D -1; gpio->ngpio =3D gpio_pins[chip->ioh]; gpio->can_sleep =3D false; --=20 2.48.1 From nobody Tue Oct 7 19:50:49 2025 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A98D926560D for ; Thu, 19 Jun 2025 08:33:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750322013; cv=none; b=Ux+XsrOjHIIbCbBjkj3CWcZtKLu1RqxS6t5RIaeyLpn6ni85G/BMDjc1zskWISb5KiOEvZSE3VCfMSkK4WPdTyMngjffoW0NZJznZ/X1KP3twTe+fUPm0FoSl9xZdCopHJuB10UpFk8+IxHUCtGBMp0bl4jaHFq+7bG7LeQ2xoQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750322013; c=relaxed/simple; bh=bxD8Wln+1c1gwTOx2BtC9yxuB8rPQnYC6Cyew1Zz7wg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=itiGwDE5Zpjv8CNUWBl/fvDWOgqv1UCgmE6CqrI9yeNzZkDMNJIVSY3RQjKbx+nkv1wGCFE4CS3HBqoJh0zpbDvejbDhNyNx3atUXZ+SczFIZ4FP/wMZvv6bLOsO5/7HtuUiwIqZxU4MAhazjT9GsckWqigz+UqeB7ZMuqqOWLY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=kCk4oxlO; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="kCk4oxlO" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-451d7b50815so3532395e9.2 for ; Thu, 19 Jun 2025 01:33:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750322010; x=1750926810; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=QYBRyPsDGU996dnyWDGUWt7Y308dv2asqUkMv7/NV4k=; b=kCk4oxlOBP4BWr7VqPuUHZo8nB7bRtYi5NYivan8kre8soVW+hfKYAV8luG3rkWT5b AtGOlXhv4W66UaJoUIvDe5IYFsGI7wAhmID50SdsSQ8QhzOKaDGleOrtCkt8hThj+yJW 95CEahqgDHxl9qYe0MR26UG4b93jZQD4Xs+Grt4FhU1PlpWGEun0gBLR8PcLWdtDDDQS CTQ6FKCfJNhwb7d04BzWbwo6rBvjPGP3zdCjpxjUJzyi6nC0rVw35+eAde/j2FCfLcTF MURo4jQUpE4FGFVqybAuQ/CVKhu6gPrlNI5+KYothHjURCIp250ktRymFHspDdQTdOLP WWZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750322010; x=1750926810; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QYBRyPsDGU996dnyWDGUWt7Y308dv2asqUkMv7/NV4k=; b=cBjQ79K74+ZeGhNoSdcB/KFPJ+LtxrU68w5h2YQ06dkAjmGUgktGgV22rM/oro4+tL z3uSipfzd3FbfoIcGYPcX0fstSNKcI+7NVTf1Lo84J2yGm/+eIW37++Po3WoDsRQsAU3 xdF1TILlYLSj/kyfOjwrPnGHI0qMikA1Pkel0wJ11qFAovTYQwUU0uBJ8XVUeFll72m6 Hz4l11k0QWxBgKVCMR2wlYYLNUB8kzBvpR54zwdDRHiHhHKc3yd/P1ZRW3xXHQb1qxjO ICIWx2OJb6fx2hvLWEahPd3MZczosnfMFdfDtnHkzlkvle+JYNIwZzvn1TJOhYZeq5Qo g8QQ== X-Forwarded-Encrypted: i=1; AJvYcCX1TOYNoBe8/4G147ZTzpSTku25ku/MhUK/FJswY1YBgxb5MWSGWc47x0cWJUScKVz7nRc6722Oq9nlqTs=@vger.kernel.org X-Gm-Message-State: AOJu0YwkheElume9HUZrJwFHTUfho7Wx41PKrOfM8QgxXderf0rKAnKp nwn8+aJbXSV0AXH039zwbU5fxNjokOSD/DAEDENPpxBSX6GA7VKH9p5+PZAaWTHIrwU= X-Gm-Gg: ASbGncvcxAXNda4KAi+Uq/XuPJ3qyfpkNpjlvuybyldylbhOEd3euZsZT4onHPAvHHd YK+GnBpL+D1ls9wsH7IduXyN49cJ4IEkqwZDtkXlyNymi0W0vOnMOuUynku9lPw4jFQhS5SC6ng BYEnS7KEHBYylye4nplf+2pyHS35WOIKKLhe/ffPU/phzU527d/LAyc2aIILVbMxv06cqxNsk2c st1DELjf/8Y9BmFyrQQV9Z2q//cfzqGi8sl+m48+044JL+4xFt8gXkDPfSZ64Uct6mDZNLHztTy 79OLEdDo5aP/Z3EcjZ9BI2MxHGyu3c2i7DzL4hEdJkw5nofwnJkXchozTEEy58hc+Tg= X-Google-Smtp-Source: AGHT+IEr0cQ3t4TpkTGvuVjGq7cZO5AQ6BZfBJ0TBysup1ZbbPr4xJbOqOBjen/dHiRJRCL3wPVhbA== X-Received: by 2002:a05:6000:25f9:b0:3a4:f024:6717 with SMTP id ffacd0b85a97d-3a572e9a4a5mr15722608f8f.53.1750322009911; Thu, 19 Jun 2025 01:33:29 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:c485:fe15:c9ab:c72f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a63a42sm18828151f8f.28.2025.06.19.01.33.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jun 2025 01:33:29 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 19 Jun 2025 10:33:17 +0200 Subject: [PATCH v2 04/12] gpio: pl061: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250619-gpiochip-set-rv-gpio-v2-4-74abf689fbd8@linaro.org> References: <20250619-gpiochip-set-rv-gpio-v2-0-74abf689fbd8@linaro.org> In-Reply-To: <20250619-gpiochip-set-rv-gpio-v2-0-74abf689fbd8@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Orson Zhai , Baolin Wang , Chunyan Zhang , Robert Jarzmik , Heiko Stuebner Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1498; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=a1x5aRsn4kpz4DTuXQ3tdXS/YzbAV4e8kj3b/qk6D/4=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoU8tRgkTy/UGYoAUmJiupC/RZztmRVGafnrAkg DK/05i+a6CJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaFPLUQAKCRARpy6gFHHX cnO5EACetBLUgnxHHE9jFOzifG/ThcrCv2NXqdEgAKT3Y5Vy7gTAQa9+76iIHz6/1YKVhIqBc8v VC9froCuMPH3X3wFZZ0j7qu3QM3lsGd6ZHQjMxwaKEYMK2dj/tPdMULBW/2meqofEw6L8ruo9K1 KlTutcobE1KjZ576wI0Eb3no+rxcKiOw8lESyoxR6YqA2oQ9lPtNO7HZAboqGg9IORRpLBT2FzH mI39kRMp0Wkd2cMdsPbQRmVgNjtPrqCUpzCZReVR1JQuW5YZ8YAk0gB9foxpkPRPNz6HYqgEZT1 kr9fDu3aUqpt6y8vP4iKtzPpj+ilsyCVFqe/2STYbwkhtYE393F1GOa2BpW6xBvQg0bxEeXm6yp QIZ8qzI9+FpX/6EZYWBeHFRhddA6K92F0EgjXP1MkBdCGB6I9pxm/5sGSOsH4sVNDVVmq2dUvqi FnElD2iPkDLGaH7QxmbmcuLFBMgGmJdIEjDVZQSY4MDDhA99yiqiQKdtvqHP0vgAYtZ0syLQTIs NmPcMRd4jOXZ8OxShxyr/oXyYY7H0Mk60UBAQiUb2XQ1ASEY81pagI+54BCYqW8eMPdf+4PtUPf EEoLDdOq/+VJ3kDxQr3C5KU1pxKPudgdhDjEZiEbK/I8HN6IkDYHov6F0Hb0u6P4HKt701hZl3n K8gv+VNOpIv6MiQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/gpio/gpio-pl061.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-pl061.c b/drivers/gpio/gpio-pl061.c index 1c273727ffa3ac54d0f1e66bd6efb784d2a8604e..98cfac4eac85295915b801a62d6= 2c8d78f6cbc4a 100644 --- a/drivers/gpio/gpio-pl061.c +++ b/drivers/gpio/gpio-pl061.c @@ -115,11 +115,13 @@ static int pl061_get_value(struct gpio_chip *gc, unsi= gned offset) return !!readb(pl061->base + (BIT(offset + 2))); } =20 -static void pl061_set_value(struct gpio_chip *gc, unsigned offset, int val= ue) +static int pl061_set_value(struct gpio_chip *gc, unsigned int offset, int = value) { struct pl061 *pl061 =3D gpiochip_get_data(gc); =20 writeb(!!value << offset, pl061->base + (BIT(offset + 2))); + + return 0; } =20 static int pl061_irq_type(struct irq_data *d, unsigned trigger) @@ -328,7 +330,7 @@ static int pl061_probe(struct amba_device *adev, const = struct amba_id *id) pl061->gc.direction_input =3D pl061_direction_input; pl061->gc.direction_output =3D pl061_direction_output; pl061->gc.get =3D pl061_get_value; - pl061->gc.set =3D pl061_set_value; + pl061->gc.set_rv =3D pl061_set_value; pl061->gc.ngpio =3D PL061_GPIO_NR; pl061->gc.label =3D dev_name(dev); pl061->gc.parent =3D dev; --=20 2.48.1 From nobody Tue Oct 7 19:50:49 2025 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1790265CAD for ; Thu, 19 Jun 2025 08:33:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750322014; cv=none; b=OibgaU39FZD9tpWi9RobOrYp3ZgK33j10QBuoIwZH4+e4sBpKDusAxRAO7LYY+y8uM0OouIdy7aLSxsLwprzzqS1T47eV+EmP/RJgcRDoP4WZi2eBoNl3LlgOs7R2kFQt10lZIbo4e8QdAR/SUoyk4Vz92MN3ztpAH1gmMtsODc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750322014; c=relaxed/simple; bh=J4/swX60dxFNnGyRxMTrvcRjJzp/EsyWsznOiUYARZc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=igjlxD/QYP0xZrnAsA+G7ulkzg+/I7V9z9EOKzNvEfsU37iYJXXBSph0mZXMtrT46hZvl+SyuVhRpJouG1ki4N+exBpsSAVjvkV9MDmxvsYLbMXJzWu4u5Rny2wMLn2XGf1RueWi+mqlk0XqjDu7pdTW67GRelhaTTQJB2JnvLE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=DRY0YGc1; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="DRY0YGc1" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-3a36748920cso510379f8f.2 for ; Thu, 19 Jun 2025 01:33:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750322011; x=1750926811; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=j3425DJ9smVNqtgfiewFDDuDZUIYNH7UVu89t2el+0A=; b=DRY0YGc1RcRmMF/IgUeFFp5B4NzPzcoN+oo+oTdcpQdNkX84NHePGFxti1rW0Wdf8e pMolJq58RVrHYJL7WzjMiES5VRtBWww8oN2RF7v3hyH2MPSc5r1bzDM2mD0wptTuxkuk KZFSTuy3dXnuJUIeBo2QbNxswuADAHXpVEzEQNON5i5qttxVZmZrpS+KttHw1AAhp4C9 zBk2Z+eEk4GWKsz62/XD7UtazxDDbs0xlPr3vPMEFAmv/5kRpcRgLhuqGh1ptbQ0aIAN pr3ErQ6f0PeBy2o/wOS2DnEzEE1RewU6f1zKGeKB6RSTV3QmrYMyNcYwImYxNeHFzFg9 8ZRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750322011; x=1750926811; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j3425DJ9smVNqtgfiewFDDuDZUIYNH7UVu89t2el+0A=; b=uXHiSqgPBaR3QphvOwoBtBGaNLPL0YfLKYXtm3IOMG/Rfzjq0odK6ogygUTHyy54pw GDL+L2R63ZGs3U3ppv4/kagPDXZ3Rm9sl2u5pplK/e6edFrcDq3NjNKdOAHZhAlkBUqc I7xIFq7bKqmVxR67T7lehYMl1Lvf8XxpbmpHkwuNDJZv1UlboAWTV+Hdifj0hdG0h5Ri 8L1ANPezg0BkIJbarA12HaWJ94Zmefzw3zOTbdGp+NlwRTfDm45fsmHmTIIFUFOA9c3A b0QYWM8n3/20HC0XhtmwNe1p/rvPsALRyojiiaoLQQgHn3aBz3bQ1L5vWC+ophJks80X X9uQ== X-Forwarded-Encrypted: i=1; AJvYcCXrPgouf5F/SC/JsFLS7iZEjdvObTTAfAUvK43OHFe05Rh52wDwYZjj1rpzjDsa4CLkBe6ly5Tlpr7ZWGI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7vnjJZBP2Y/LLl/he4p51rFnFvEOZewrWJFuO0Gi6AogltE0O TLWk6nZNcwGVgZQIhDc+cFkPDTislZmTYXWS97G/ReB9y2rK6AbW4pVurS+ybTO+L0A= X-Gm-Gg: ASbGncv9hzJe9GzrSla3EVrwmQua0mE8KiF0PXv8Rf3EYccONGUUGtQMaF0RosH4rmm Z3J7Q68d8MuMCfCwM1lCacWIK/2kZBqVXjOcRFZeruIVbaTiFkQfRMdj2zkYoelnZAvcNMJSHTQ s1fL2tHw1klbfMV5ljGBc2RMQB/yiRwAxne6IQoP3bxR+I1qAkQb6nHCdccdgUP6C5deZQMUVbe +ICQnaK+l20Pqj1FVYxdnvs6iY13DB+/60X2f7HxiJbtg4AOJ8IPH6yiG8i/GZIt1nA6s5vDsQt QZtAoyZI61QGWksMsAtPTH5DfpprASWN6tIacTQgaBC4T8BD1yAsqyZR8FdqM3Am9HQ= X-Google-Smtp-Source: AGHT+IFrsPvQBcfdGkjODy+e3yqc3AHlIahKNReGa+rvtx4ektz8kpZyRE1e3BB7ON0JDvQ8oJpUfA== X-Received: by 2002:a5d:64ee:0:b0:3a4:e75f:53f5 with SMTP id ffacd0b85a97d-3a5723a26f8mr17708250f8f.35.1750322011048; Thu, 19 Jun 2025 01:33:31 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:c485:fe15:c9ab:c72f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a63a42sm18828151f8f.28.2025.06.19.01.33.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jun 2025 01:33:30 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 19 Jun 2025 10:33:18 +0200 Subject: [PATCH v2 05/12] gpio: pmic-eic-sprd: drop unneeded .set() callback Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250619-gpiochip-set-rv-gpio-v2-5-74abf689fbd8@linaro.org> References: <20250619-gpiochip-set-rv-gpio-v2-0-74abf689fbd8@linaro.org> In-Reply-To: <20250619-gpiochip-set-rv-gpio-v2-0-74abf689fbd8@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Orson Zhai , Baolin Wang , Chunyan Zhang , Robert Jarzmik , Heiko Stuebner Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1348; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=U5ElyLmZBGysFJL9KcblCpbMCuSewiTUa3oGkohc5iA=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoU8tSNZDHMC4DZ4e94TG9I0QxUTJPp/knIHoLZ ngpzNeMrj+JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaFPLUgAKCRARpy6gFHHX cs7tEADbq0rtKcu0CtpTMbhplPaVXYghftiJVLjNx9ls/h6bpBkGrExc9GChQzG+Q7zhbcHnD9u C2jZn5ptHvOH7heEQ2vVjh6YD9YrwGECInonaAld8CaKlF9li75bIAu2EIPmnGHnkoeb9y9ejQq NUgqfirWA+Vn89x8JYkZ2yYQGn/kYHWSYvjad4y1//nWPlTQsQTXozhafHv/sEoqUlHxI1677x3 jIxA8nZMpg+TK+DfjalolY+tMbGti6RYt/AYwK7k+OCERsizg+3znNQDgpF16dG4P+duDRsFTPN MTuBU+/nvuDmAsfzReY7qlQEGTMvKOap5VGUx2LAXRomlj28hOomYjrSVdQjjJIBgWiArZj57lT pIQVrc7vIj2UEAEmDBU6x/vJ+Ap7UpYTduZukAh+BNo+3g8RxfeW9DOcKE7HWjHODvU0Q8SDkVc vRkO4k+tvkcc/5lMLF0IalPGBX6AQCDCHOo0b9GoXWVdtsix33EFG9yqiQgu4C9PDP7IcCZfH7A K6MSIE73cXim8CvXAXfIpI2/PwV3RCv8jF1+NfxrIApruyfrgJb5uM7HA3n8LgjwoS+ZkywcvDW qnUfQrtyAii6SWW9aBhPa+wAwsHcGbgR/x4Mt7aS9QPZh3OKG4KVP3pWFxTBV80w1DGiFHsor0s +I4VtQeCui/0NNA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski The lines on this chip are input-only. GPIO core can handle the missing .set() callback so there's no need to implement a dummy here. Drop it. Signed-off-by: Bartosz Golaszewski Reviewed-by: Baolin Wang --- drivers/gpio/gpio-pmic-eic-sprd.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/gpio/gpio-pmic-eic-sprd.c b/drivers/gpio/gpio-pmic-eic= -sprd.c index d9b228bea42eec53ba9d0d0945125f530a22946c..cb015fb5c946748402272391035= 4219e2c98d3c7 100644 --- a/drivers/gpio/gpio-pmic-eic-sprd.c +++ b/drivers/gpio/gpio-pmic-eic-sprd.c @@ -109,12 +109,6 @@ static int sprd_pmic_eic_direction_input(struct gpio_c= hip *chip, return 0; } =20 -static void sprd_pmic_eic_set(struct gpio_chip *chip, unsigned int offset, - int value) -{ - /* EICs are always input, nothing need to do here. */ -} - static int sprd_pmic_eic_set_debounce(struct gpio_chip *chip, unsigned int offset, unsigned int debounce) @@ -351,7 +345,6 @@ static int sprd_pmic_eic_probe(struct platform_device *= pdev) pmic_eic->chip.request =3D sprd_pmic_eic_request; pmic_eic->chip.free =3D sprd_pmic_eic_free; pmic_eic->chip.set_config =3D sprd_pmic_eic_set_config; - pmic_eic->chip.set =3D sprd_pmic_eic_set; pmic_eic->chip.get =3D sprd_pmic_eic_get; pmic_eic->chip.can_sleep =3D true; =20 --=20 2.48.1 From nobody Tue Oct 7 19:50:49 2025 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99331266568 for ; Thu, 19 Jun 2025 08:33:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750322015; cv=none; b=q6qqbM4Qd880Fo5U8VN5IrTnJdbFOy/YvWbHwqRmLc8zzspRgl8zXvPl200AOuo3Zi7B5sNHkXYraZtd5r8J2bjVMuXRc4Sww5FdX506shT+7BPxvJQ/oufXUC8HHwplu47AIja0CEtkAVQrxScdGSGi/KhcZSaYkBEEe2IyZxI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750322015; c=relaxed/simple; bh=TIbLTydFbIxMUGka9nMFS3KxZgZxnuWfV2GjJh3DcXg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=A0EGp5O0V6Kzf6I35on/pTBwyUmwtwToKK2+NCNYocAuDfGUYVqc5bH0c1SyVMP1GKp1po9IZMe1Y3xKs96FpQBDlMHWR/BbVqg5SZWlyVtD0OMiwdI11ppvF+9CesycIwIgpGSt5q9UvD2hW2RaI7S+OQ+0sOZ88TiIHe4LgG0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=w404o2Rd; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="w404o2Rd" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-3a4f379662cso467009f8f.0 for ; Thu, 19 Jun 2025 01:33:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750322012; x=1750926812; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=rBA3kzrSkCDXqL/qmFtpqMrbH8iiG3hu1F80uNaFdYQ=; b=w404o2Rdw9ogjqnCotYQj+d6y+yVH1spuMQmioGW6/jmlBqPzG40Z9PBtr5bq5xmOm xpXARWBwxohPuBuHr5iUoGORrkBnpYNdrsiHqeqHcvLillM/2cDqQZv0Tl/MkbN7Jq8s orD+j51Xdl/8PxrPytos+BSb6su8VO3SI9V+CIMjtBCkHlt8x0d0oFXUhlYoB/jkxR7A UKEEYnpc0oQxOOMwgBHx1f9t27mJJ/eF36v1oy7Q3omZgWoVc6actGUxaDr9B4e0sSYz NYOU6oMyKtClJTz2vKBChIay5ouY40KAA3Tfz2GEQgwGhu+NaAQ78Ag8YNMPwjR9PGS+ oxJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750322012; x=1750926812; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rBA3kzrSkCDXqL/qmFtpqMrbH8iiG3hu1F80uNaFdYQ=; b=wc7HelSLHz4ranE1R6qSrYObsfITS3Slo6AlvcAxEYHtkoz7T+JNihPYr5z0lKRlko DtVBAU/A5lGOo0y6iYcS8ZdoetnUcZIsfdrpDCUHIiSedzBXcTV/eX4wPefdAHC/ngSp 4OXFoIWT/4bAZhwmrEwuVIEyLWnHbTo63nBq9sGRnknt2MWWkiLMUy+IOipo3KNlX/NP rpVFRdC+OzkIGKRxom0CDJXKZ53VVMJ2eq06m7BivXG6x3LpoMJ5Mbk9MUsstUwhjHK/ bmYBKVlM2W8bP+f40SGlX2ecaC4dB/cjvGUV8SQA/Fiuw/GojxdrVr4cjh6iDpj+USxv BOHw== X-Forwarded-Encrypted: i=1; AJvYcCUz3bncOrxObxCejZhE+xbAfskZzgWm0ovsNmkUtvx735BaL5optlkO3Z54wJ6vK91DLc/g5VuYisYsCPE=@vger.kernel.org X-Gm-Message-State: AOJu0Ywh7pY//I47JEBNSuUPc6xirh0VAJOmtoszMhnM8hBL20TPRd0E V8ze4SkxpeMJ24qUo3z6kQR620syGBZP/CZn695KncOZwy6IgqFddCuS487h36q1wh4= X-Gm-Gg: ASbGncuCS6xHqdRsoiY2lJ4xViilejYB+dr///D6kVsDoJ0yFhJPCdTUxCufbjBV65q mOA+wstPjH5dUmT3yHEvOhR0JUa9Olz2AC7tzbCDYKCAOI/Cjywh+HuhPPiwFQ/Qbsp/UXJ7ao8 O+5Xnt3RhNbVj6Y6zinud1tYyYnY5Qy4RI+g9BusjCiqA3WhYD5trH36zmQ+3wBzoFWG0hnQinp ++JBtDhLASYJb6xeROKr98femoEBBHT89VVNJbHSPTCSDS0NuZNcg0L7CV/97KnxSgyxzACwkhs TA19+q09BNg28tDV4fWkPniz7rLJ0koH9jkzFFfWHvP4RpQpXdSKSC5Z X-Google-Smtp-Source: AGHT+IExSetU+H/G46+A+Kv2pCw5w5XlUszs48CCHuzCg/K6f+lzMaSm5DYdy7QwosUzPYCH8ueY9Q== X-Received: by 2002:a05:6000:1a88:b0:3a4:f41d:696e with SMTP id ffacd0b85a97d-3a5723a397bmr18021776f8f.27.1750322012064; Thu, 19 Jun 2025 01:33:32 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:c485:fe15:c9ab:c72f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a63a42sm18828151f8f.28.2025.06.19.01.33.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jun 2025 01:33:31 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 19 Jun 2025 10:33:19 +0200 Subject: [PATCH v2 06/12] gpio: pxa: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250619-gpiochip-set-rv-gpio-v2-6-74abf689fbd8@linaro.org> References: <20250619-gpiochip-set-rv-gpio-v2-0-74abf689fbd8@linaro.org> In-Reply-To: <20250619-gpiochip-set-rv-gpio-v2-0-74abf689fbd8@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Orson Zhai , Baolin Wang , Chunyan Zhang , Robert Jarzmik , Heiko Stuebner Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1502; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=B+Qz2OspKJ91xFNTEdAqgmxdOA/mnHzp8sm3HNk30eo=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoU8tSTMyIqQjS6A96KtIVo+22ennHEyY/653Ay ufgFq0L+7eJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaFPLUgAKCRARpy6gFHHX cllAEACcTO62jc9A4KHYc55XCch/hQhSLs8RmhzwqrMdUvC1ddw8nhH0A5xoRW7xEWXvE+sXZ4y UvEwwrLPzhzblUr1IHw8dpgT/Mj1pueQnCqvymJOCanv6KzE3uOVN0/wf7n4hxuxsnu980DcDNz zmKel/hACORSUcnaBH6uyxM8KoSSNFbSd20XvTomvekETxI1Fto5MQw5RnP3gFE64fIgREer+Ov W0DMQdlYgzmmzTc2r+8hc8qLmSuFbQGteSRIjwC2Ij8NvACWdhAXzDyePkew6+3h3m5MMl30mA7 oBtzhuNgW6iBNQlQAvYHEj+9B8w1sHe1dfD72vX7/Xc4GJsBAGKVAoIRQsspQup0+3NeorznGaW SDfYRh24udQ44UNa7JRqMsdcb6NXbX7AWgN0XKNj+U0X6GCgAuBQKnh5nt1hrqSPYwv44ZmceKC AZ+QsImPGESHhsHf0p62cKZmi/eyOJUewON8F8Gt7Sb3MrK5fRBn/jxJZ3zlhTEIJjPqVs4mUd9 GTOWmqFnR8FecCfio/EwJA/lOrk9VT1ZnC8dFGR12c7HkarYXRxHg7FOidsL5lsUlCuUiVQI1O3 r9RNAta3xi01R2CPUSH/VPytL8EZSavtDAfQSW3GcMxshABy92XhhIEPh0i5Iqf0ZvSX2tw4wH+ HkgTHlO2fFlRi8Q== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-pxa.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c index 131ab79ebce7555313fd93b3ebd80582d1b9327d..13f7da2a9486428bb8d1d44d2ca= f9f21f82cbca5 100644 --- a/drivers/gpio/gpio-pxa.c +++ b/drivers/gpio/gpio-pxa.c @@ -315,12 +315,14 @@ static int pxa_gpio_get(struct gpio_chip *chip, unsig= ned offset) return !!(gplr & GPIO_bit(offset)); } =20 -static void pxa_gpio_set(struct gpio_chip *chip, unsigned offset, int valu= e) +static int pxa_gpio_set(struct gpio_chip *chip, unsigned int offset, int v= alue) { void __iomem *base =3D gpio_bank_base(chip, offset); =20 writel_relaxed(GPIO_bit(offset), base + (value ? GPSR_OFFSET : GPCR_OFFSET)); + + return 0; } =20 #ifdef CONFIG_OF_GPIO @@ -353,7 +355,7 @@ static int pxa_init_gpio_chip(struct pxa_gpio_chip *pch= ip, int ngpio, void __iom pchip->chip.direction_input =3D pxa_gpio_direction_input; pchip->chip.direction_output =3D pxa_gpio_direction_output; pchip->chip.get =3D pxa_gpio_get; - pchip->chip.set =3D pxa_gpio_set; + pchip->chip.set_rv =3D pxa_gpio_set; pchip->chip.to_irq =3D pxa_gpio_to_irq; pchip->chip.ngpio =3D ngpio; pchip->chip.request =3D gpiochip_generic_request; --=20 2.48.1 From nobody Tue Oct 7 19:50:49 2025 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3870266EEA for ; Thu, 19 Jun 2025 08:33:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750322016; cv=none; b=asNVkMbTXBJxwMGng8w1yOz6URCbSsLl6wTssBwk70Csg75j7YjlrKgs5zxrbOw1jgauDR0mX1MZhPPEixlMYTr7vwwhJ3tPlxR0nSnR0krhR3WK+YAvh0q1jDyWBZ+JOTxqWbmYWX0iK4AGMg+P6vbhgs44m0rH6DOh1NnM0Cc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750322016; c=relaxed/simple; bh=KyzGRm5PzFaaCx6vaqmEFT/UHLNaTRS0BfqoZ2z4ZkM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KJeuQcKHa4DxIYCFN0+XXDz0GF3QaM0vURQrxQsjoxnilOJRlKH0C2z+r4sjSbf79XDNxmTVcO5DEXV90rxhwiljo7y6LOppPn00+HXjAt6kRPZWh0pcswOCYEfdLWcCd7cSOJ/5y9PqwG1Vs0XOnLrr674pDFX9+BBJ2WyS6To= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=iAdD94qF; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="iAdD94qF" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-3a54700a463so274713f8f.1 for ; Thu, 19 Jun 2025 01:33:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750322013; x=1750926813; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8+GlKxeWL5Yw829/r0IFKSs2jp0Xuv75Z5VhmG/MTnU=; b=iAdD94qFvWGppkwFRh/nDnZuzgMBWiwjVN8bqYdEksYXHYlDWwgG0M/rug2K5SbjnG 8aKuit9eP7531YEvIbpYUOfbJnallHS/bbSQwMC3mu+AYiuKlJlyepLRoLvxcJ+bbavD DunzRrK/8KsXMODgUCAr9No+xPtrVDN34qVoQ3dOytdkLNGmoBHYaMe6zPfH3h4PmgLO ZM9s0K5HpDfy9ijNsnu6ducf/156sT0etzMFx697bDOt/gYYvQylNmoSaZ4GbURZKWOA teKH5ww88yahRT4jFiV16ev0K6U1lzw3Tt9nyNqDcpbI8Vvq0MzttZzXq195mjNFoIDa A01g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750322013; x=1750926813; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8+GlKxeWL5Yw829/r0IFKSs2jp0Xuv75Z5VhmG/MTnU=; b=AALYv11sO5wEJpu5QzmuhBoBIi8O3cCBTatGGleRPVuQhhwpSQ7jyH7uPYa+XWr3x+ y3WUHSRAmsoSdPlRIriDFljuQVuAziM1GeagpZQaPqELnJuO6fpMrM8uKUAKIfBXeNNa D0u8d/aUxZdjJv/xfpu/JL/BnQtJyHswu00eQ0N3MhGdtYed2I4qnk76zokWZ+1is4gr IOsebJclGQDDUIn8TjZTZAhlxiwY680v6AwXoBOtkSVeZQVhYCNBL1o4g1ZBRztR9IJJ 9YcG9PDiF0M9P9rYGZ9i/JYsyC5CJHnQXa8cI+R8xbuNQn866/p/fC1ICxIZu5RY8dYY c/vg== X-Forwarded-Encrypted: i=1; AJvYcCU73QSVtCFC2zOZTkiWYxUyKIH4mgWne0g60Tjqt4ynwr8Tb/CPiFzQKajaUIptFIgtceCNHsPbne2bD/A=@vger.kernel.org X-Gm-Message-State: AOJu0YxzSsl+Kd26/prZZmwYtgQ46xbhO53L9U5GUiSpFoZVLmCQnucG FhSEurszRR6a1rPnbtVfeZrMnotzLxEMNLNVrbF3hSHmhkNlelsHTiEbI8GmwbPYn2Q= X-Gm-Gg: ASbGnctqCStBJLmliJ+qmundlysEIX/+6xdlfVq0GL5iQccJad/4E6MnUJ2UggVI0AH OTAvR75qGkeRxHonP30yIiMZd0Rj1IQxFmvm3M+29UgBPypyfFwVAQXURd/onxHyr+qNByKi8D+ zOuHfJUM8Khnapc8JdYYV+7z4jLOBqROlktu5c06NeABIZXvtpvSROQsaEH4LH2yUh/Fc7ZlFTF MVT49v7FWul/qlupXYwFbXwSquPBmCGDWi03XnxtYXWcr7r88vLwfe3YBD+Qfa5qN0tRhz/PGnL qO1EA8FdfzF3pET/AiKpwTn3c5x5tdOqhJ2W9fdQw+/pymn2AM39YAoG X-Google-Smtp-Source: AGHT+IEYd8zh0M+GIxvzO+cbczfDdVgwEB9/rBo3uvdJxipNvbLdwuD0peBA9caOs/ahFdM6KsbEFw== X-Received: by 2002:a05:6000:1448:b0:3a3:6478:e08 with SMTP id ffacd0b85a97d-3a6c96e5663mr1866539f8f.23.1750322013194; Thu, 19 Jun 2025 01:33:33 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:c485:fe15:c9ab:c72f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a63a42sm18828151f8f.28.2025.06.19.01.33.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jun 2025 01:33:32 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 19 Jun 2025 10:33:20 +0200 Subject: [PATCH v2 07/12] gpio: rc5t583: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250619-gpiochip-set-rv-gpio-v2-7-74abf689fbd8@linaro.org> References: <20250619-gpiochip-set-rv-gpio-v2-0-74abf689fbd8@linaro.org> In-Reply-To: <20250619-gpiochip-set-rv-gpio-v2-0-74abf689fbd8@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Orson Zhai , Baolin Wang , Chunyan Zhang , Robert Jarzmik , Heiko Stuebner Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2356; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=aSlqvGnhuSY1VlIGZB65GCCYVPKtjnadnIRxz6DCqho=; b=kA0DAAoBEacuoBRx13IByyZiAGhTy1KgqNjnmKmQLkXGxxWam8m1Wn84v8Mmm9k8q48PP1VEY 4kCMwQAAQoAHRYhBBad62wLw8RgE9LHnxGnLqAUcddyBQJoU8tSAAoJEBGnLqAUcddyFFkP/3zl 9RL/sxOpe2l7ZXx8muE1QdETZweVSf+QCakclyiBOlu9V+DX29m4PgdsLs7RKPBYR0bOoIDi37b cUxvgu1Db2DezcO6Hg/kISB1+kKTP1ra+mLibE2HkoRO0mGxEZUk5K7kWPfZxSjj0TkNOmIYb0u w0USK1lo+9vZbTXvUhMyxNzwP1oIzKV4EWICo7JXE3Yb25kPiera8eYaDQJmiGVzqsx2zlhOY4y 7JpKNjCYk38N9bAJpcMTpRe6X0HRqLob3wwRAWArAqfiyx4pM391d/laNhzmaB1EXW1G4p3X//z kXkuOi4cLqMXpbFt975vL5Aio5buuqcB83ajhxzy3o4j9rx2josJqR9yLf6HyV/FrTjJPQNRHw8 NFmhK39BfihcDsv2CStjI+rOhyR3whWppE+BvJi1H/Coa74Nsu1RblwOdUZzsvAY2NZMdgFXeE7 X+5yOnzSdyGBGTPyO1Nmy9T/cPj8C0zokeHVrUU7+nsQuYPa5xy2UNrO8KoZoZytP5mmMTmmupL JHLECUgyjbL/duwYUzSsQGm3c8sEogb2FjvnpzeA0Ryk2j+tI7D0R03WcI9DpCgUNZSVWpGgk41 TStG9T3DmCHn5cFwFUUV/EdG9woFsowNaioLk3P5F3nzAJk4sqhrc1Ge2ABs06g4AZ0JULQEtRY L7iFT X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-rc5t583.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/drivers/gpio/gpio-rc5t583.c b/drivers/gpio/gpio-rc5t583.c index c34dcadaee36d5fb775d4aaa8c8f8b275f4e2382..cf3e91d235df2eefc7d0fc93a58= 824edd55e9aba 100644 --- a/drivers/gpio/gpio-rc5t583.c +++ b/drivers/gpio/gpio-rc5t583.c @@ -35,14 +35,20 @@ static int rc5t583_gpio_get(struct gpio_chip *gc, unsig= ned int offset) return !!(val & BIT(offset)); } =20 -static void rc5t583_gpio_set(struct gpio_chip *gc, unsigned int offset, in= t val) +static int rc5t583_gpio_set(struct gpio_chip *gc, unsigned int offset, int= val) { struct rc5t583_gpio *rc5t583_gpio =3D gpiochip_get_data(gc); struct device *parent =3D rc5t583_gpio->rc5t583->dev; + int ret; + if (val) - rc5t583_set_bits(parent, RC5T583_GPIO_IOOUT, BIT(offset)); + ret =3D rc5t583_set_bits(parent, RC5T583_GPIO_IOOUT, + BIT(offset)); else - rc5t583_clear_bits(parent, RC5T583_GPIO_IOOUT, BIT(offset)); + ret =3D rc5t583_clear_bits(parent, RC5T583_GPIO_IOOUT, + BIT(offset)); + + return ret; } =20 static int rc5t583_gpio_dir_input(struct gpio_chip *gc, unsigned int offse= t) @@ -66,7 +72,10 @@ static int rc5t583_gpio_dir_output(struct gpio_chip *gc,= unsigned offset, struct device *parent =3D rc5t583_gpio->rc5t583->dev; int ret; =20 - rc5t583_gpio_set(gc, offset, value); + ret =3D rc5t583_gpio_set(gc, offset, value); + if (ret) + return ret; + ret =3D rc5t583_set_bits(parent, RC5T583_GPIO_IOSEL, BIT(offset)); if (ret < 0) return ret; @@ -109,7 +118,7 @@ static int rc5t583_gpio_probe(struct platform_device *p= dev) rc5t583_gpio->gpio_chip.free =3D rc5t583_gpio_free, rc5t583_gpio->gpio_chip.direction_input =3D rc5t583_gpio_dir_input, rc5t583_gpio->gpio_chip.direction_output =3D rc5t583_gpio_dir_output, - rc5t583_gpio->gpio_chip.set =3D rc5t583_gpio_set, + rc5t583_gpio->gpio_chip.set_rv =3D rc5t583_gpio_set, rc5t583_gpio->gpio_chip.get =3D rc5t583_gpio_get, rc5t583_gpio->gpio_chip.to_irq =3D rc5t583_gpio_to_irq, rc5t583_gpio->gpio_chip.ngpio =3D RC5T583_MAX_GPIO, --=20 2.48.1 From nobody Tue Oct 7 19:50:49 2025 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1683264606 for ; Thu, 19 Jun 2025 08:33:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750322019; cv=none; b=J/tQ2U0jFkPnKZdy6xDAwRRHDwFzMYGRAwEKFl6gNEA9V6TlwW1e3d4uQBtPhojC5k4Z8e9WVYSbVLdrq2hTB6VHto2k10kNe4YoAHN1wZhX8ZiohGk/X+1Kk5kkXM63P3W9Nmii3RxsKHKrdZPzQIUysbY8vCuS0rYQQHG9GjY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750322019; c=relaxed/simple; bh=9Zaxzyv360mf7Zwzu4QdvYgk1SpKcZsIH3LbMJy1S68=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WWH69eW37aaCzR3uUHSHhP0VrFoXCQI1+qlkLkKCCVdwst+DoC2PdrteLqGIg5EnkGF0fm470UDrh8Eb3PJpOcI5W48C6ZkReWboTV+/H2rTONeVqWXCx8TerKvSgnggHZ9HrwmZJc48uaC8OEjw8+pRHXnaJui5S45AB+AmTo0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=jEJz407X; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="jEJz407X" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-450ce3a2dd5so4272455e9.3 for ; Thu, 19 Jun 2025 01:33:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750322014; x=1750926814; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=AMHaAkSc/mi83kBCslhtD5+Hl3KktEIZpzS91Yh6h2M=; b=jEJz407XT+C4Cri6NiWAGlY/pHMuLy37X8bIUvd6z2u53rJrx6UjALcbm7qQG3dR+o bRV/1RFwC5wd7dUR27q5mPQLA0FOWpzOVLYH/nOU9C9KawZmNdjqwVanYzBcrLny0rrc f2c8eYpG7BeahtX+rFdlnJg/etIaDaEjN1gBC24IU0H2E6+DshxuXaf46C5rnECIYJeD uGy3Xm0t5PS+BO39upzHDLFY0/6d6J/HbUSG8MD7nG7laJ3W/MCTPOyWVyPGh78MM+pG VBQAlwh+TmV9EO98mEy2AsqOMXtpDYjwGbbt9si4mH+jExrdz+mIYz4IzUrDv4002reV Smhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750322014; x=1750926814; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AMHaAkSc/mi83kBCslhtD5+Hl3KktEIZpzS91Yh6h2M=; b=WXZSh1Hi0k52HWhUVHrxvCtc7+dMnwW/SvYpRkWNLVpzHeyXBsnZtZ0R06X9EVgdo7 tXXRiQXpnE7drcGhLZNYnLrielZZ8lnSX/6yPP4lWwTAvb8k3L/naTPE2s6L+HD4JeiN HFSwTo5lqIlOMUDT3xXSNPsRHgiDdyLS6Ol9dQN3XQzLIejQZ1ozwrv5l1ZX4bU69O6r dSvV/5ZxoaZo3AQ9KaIBtfmKWaJSYGM/o317e+GiM4THJ8Iusqb0PMlgPEJgUFgFlWBC YS4BC65sD6CF//b+mNDHUP8Mq58wrcvYmfju4SsngroYO4iIauySyOhL0LQKNFkXugBW UgRw== X-Forwarded-Encrypted: i=1; AJvYcCV0pj+h5sjfLzXObohOSCgYWE2+fivnLYnfbo4xDCcuHXGGDzbG7nch0POIxbZAIOnm97zdubLXxPBz2Dw=@vger.kernel.org X-Gm-Message-State: AOJu0YyWRr5oer3T8K0ZOXYDOLYLIxmakyTrITcVNcWCTa7m8OUiXR9V jXpbdNahdOEe2Gj60ep8YlIfvArZTAU6x/j8o1RdGkzQWr7KUtpgwabOWqXrvgJxJeU= X-Gm-Gg: ASbGncuiJ+3EYDYeQvzOkxpVPF5BauT+OfIfcecduyy4YkG78ecXJLSgWHKWFVsxldM BIck6TZs4WHT+1SlL8A6jwbUkYgTWl5JzSjH/jK5U5p98V0bkm7dP4UBz5aKtHCy/Rx+qS2YXtW yMBf3lf6uMx3xosU9m/VMDvgHtQgrX0ad1KgKLFSGUWUVInqKPmsyInmtHhoJ0oUl2h3HSOq9ui sivbyZm8nsN3qyn05conMFmdrIDP9VvwF81SNyhKwRqYDWBhAqULmzmY6g4OUM/diJRiDMZvYWJ 2tFvkSXmN5gCwr2sICmC1101px1KXlYTUtwyESHP/llUeo0Oo4kcTUl/ X-Google-Smtp-Source: AGHT+IEhu8xC4VxkK8D9y/IzWa7IE8mDdOLXw/zM9eziYcYO06FvESnlV4hQatzpue43BXOUc1GptA== X-Received: by 2002:a05:600c:674a:b0:453:dda:a52e with SMTP id 5b1f17b1804b1-4533cad28b6mr179151175e9.33.1750322014059; Thu, 19 Jun 2025 01:33:34 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:c485:fe15:c9ab:c72f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a63a42sm18828151f8f.28.2025.06.19.01.33.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jun 2025 01:33:33 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 19 Jun 2025 10:33:21 +0200 Subject: [PATCH v2 08/12] gpio: rdc321x: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250619-gpiochip-set-rv-gpio-v2-8-74abf689fbd8@linaro.org> References: <20250619-gpiochip-set-rv-gpio-v2-0-74abf689fbd8@linaro.org> In-Reply-To: <20250619-gpiochip-set-rv-gpio-v2-0-74abf689fbd8@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Orson Zhai , Baolin Wang , Chunyan Zhang , Robert Jarzmik , Heiko Stuebner Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1631; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=/FTgaK1cWGc0DF5sQuXKwdEauaSqv0NFqrELnWAzquo=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoU8tSnuKbzHD0kBPGGPIrGC9b8qHlgSZpDe/Nl /r9LV/9112JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaFPLUgAKCRARpy6gFHHX cpppEAC8RwVAaPlajD9OEFEZmq9MCIAXiIYRgG5/b2nHs3KNntWqL//mWx9dmU1WzpQn39fw3Xq 54qItaAMTtJVR7Ok6px0QA7xvOmK8exjF0AibgNZWkDnDu0jxXoOS0lUjn91yY51gL1LIqNpK+/ m2GfPgRLaDPRy8sDWUezXb+u2HBhpOLWWRX33x+QTPVB4F67ri66CvcmDCiVou6Kyy7RNCEwRO8 t8+lVxl5KyE6FNyAX3+nUWFq3dVOnLGcGK5AEbpKhF9Ho7M94LLbTthkWETb9dG+6BdpPEzJn3X Y6ZenbKzHOLjRkv9g/jb3ivNuMnqWedVOoQnC98hoz1DXHWtakIS60+xX7BJUvJc6aCoGiNhOe2 o5I9kBFYOF8iwdn94Hvvh5+poPJGpuRaIuX8Xuikqmvo+b8cU/UeC16gHp1wOLnOci9bz/6SwK5 IU7dotGSRGQAAXKT9q5y8Ue1723khYjt8QYHavZA+R3s/SvWCY4Qu3YL+TkasH5x2Mn+Bpe4MYN c4EKErHmU0mnLxxfIbL/lYKmkqYN7uOscb5iJDYkd3R0GLE3mBBDeAfeqGpqoZRXBsx5JX8HZe0 OByPtqosTCnUi1LkQheHJCv8kNnRTMl6iOlz+6Rw6e18MCMvRGFVWQm1UkdwUkcjLJAqQniLweV B7jLW9cNfptPhnQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-rdc321x.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-rdc321x.c b/drivers/gpio/gpio-rdc321x.c index ec7fb9220a4747fad5dfdb88e25e68d2a104e37a..a75ed8021de57db122938e4736c= 3ac994bcdd2d1 100644 --- a/drivers/gpio/gpio-rdc321x.c +++ b/drivers/gpio/gpio-rdc321x.c @@ -64,8 +64,8 @@ static void rdc_gpio_set_value_impl(struct gpio_chip *chi= p, } =20 /* set GPIO pin to value */ -static void rdc_gpio_set_value(struct gpio_chip *chip, - unsigned gpio, int value) +static int rdc_gpio_set_value(struct gpio_chip *chip, unsigned int gpio, + int value) { struct rdc321x_gpio *gpch; =20 @@ -73,6 +73,8 @@ static void rdc_gpio_set_value(struct gpio_chip *chip, spin_lock(&gpch->lock); rdc_gpio_set_value_impl(chip, gpio, value); spin_unlock(&gpch->lock); + + return 0; } =20 static int rdc_gpio_config(struct gpio_chip *chip, @@ -157,7 +159,7 @@ static int rdc321x_gpio_probe(struct platform_device *p= dev) rdc321x_gpio_dev->chip.direction_input =3D rdc_gpio_direction_input; rdc321x_gpio_dev->chip.direction_output =3D rdc_gpio_config; rdc321x_gpio_dev->chip.get =3D rdc_gpio_get_value; - rdc321x_gpio_dev->chip.set =3D rdc_gpio_set_value; + rdc321x_gpio_dev->chip.set_rv =3D rdc_gpio_set_value; rdc321x_gpio_dev->chip.base =3D 0; rdc321x_gpio_dev->chip.ngpio =3D pdata->max_gpios; =20 --=20 2.48.1 From nobody Tue Oct 7 19:50:49 2025 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40F52265CAD for ; Thu, 19 Jun 2025 08:33:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750322019; cv=none; b=fSy0GhmSyp6Rek3/99k3qzTKFRK+QxAy479b6bIoBrMSXS5BMaeyTepO6IfJTkq//c8S0XAGoyq7Z+nMHOc29Xn99WogASvtaXbUckdyZ/8ihOKjgbZkCRtBph2yzPj5zPEVirUydDkSbLm3VLQQhzSuoNQOouwpt66KwwKZmVQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750322019; c=relaxed/simple; bh=cKZpAhtifR8xk5RPiheRH/GzBlWm98s/1BZyILH5nuc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PAoRgHtvCiqpe9GOCC3QCGUD7uGTe/bh0M7wGlr2aYJA4f/r9fXZ0NCsJdSmBAjSz1gI2qsoYIYmZgTFh/gr9cMnkTV9TMKRxn4xpdTznWqDAFqPDabZ47lqIRyVp3NztK8YbjhX91e+HdwY0/Ee4ujZDZkF2D+Fle7O8PBZn3g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=W3AhiyfY; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="W3AhiyfY" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-450ce3a2dd5so4272635e9.3 for ; Thu, 19 Jun 2025 01:33:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750322015; x=1750926815; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=2SDdps11Q2eLdePG5stsUwakF44A60m55NMmpcUnFIc=; b=W3AhiyfYGjsT5PFZIldrXTCm9McBxYPYEShpu4ls241Z6hdb8sR3bcxUGqV0bMER2I 9XMoZgiGgFIU7lFFjLAFK3/1RqPB7xKg3HPCHyOfDF31qQ4o7icdVE2q/itjGqlZ0YCW xrQw09EUZE8Zksm2vRH79xYwkKt7bms6yA5HgWimdQbCGc84T1ncAsn2xa2kTZZ55r3G fdQ6sL0UqaUE+/02Az6wcXg5QvyAfIxXIDhRYcOhmBm6grD/pS8DyakZOgpy3gbEatfg jBWNHhznHsoftuVHlWBPyBCLBjGixwlZAVXDtZzLwQ5Rv4r2cCf7w2rcz+rwetu++JYT 9LEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750322015; x=1750926815; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2SDdps11Q2eLdePG5stsUwakF44A60m55NMmpcUnFIc=; b=gV6zlQ0nOrXRL9JnQrTCFkII+jFDvUYrVmZM1ngmEH8uuvL5iSi/5WJ1fIae5kdcIR zf9K5YoHjNyWXCC04+hNj2PjxjsmtUo4L48842pDn14/dkKE7t5lrW5S+JrCiEqrodce bp4b4Zc9Y8iVY6/WUoqUF0tH6mOwb2DBxv3XrdVgZSTIq1O29IjRhItYeee0Fh/aF41O hgaAU8u5pLCbxFdg+j1MX4/nFqUPr0tAb6RhVF2ffNsjroUih/V3RKQnZ8lealvd+IBi cRvwyVkIMvhW09sOJqN3tbxujifgpfuLNgmUVUY7ctt0asuUB/ehzdoDHIs9Zudvvxmq JUaQ== X-Forwarded-Encrypted: i=1; AJvYcCU8fxFf540qCvGFfnjslrYDaErkMKy5lBSpd0JpEaxDtRid0tdeeLrChKP7qAobNG1jtAuxc8Jhh5nmyqE=@vger.kernel.org X-Gm-Message-State: AOJu0YyfvQ3eAGRZXPMTuqWfWpY6jszArcfP2ablUve6/8uY3rsHm10k /X5GveP/jPoD3sivdCOpttraTKAlyBv/K9xeZ9IAwajrIwfhxdzYBJ2HvXJOEQcJaQo= X-Gm-Gg: ASbGnct8r0b+zUkOzLheE78499Uepb0sTh1YaaixVM3C6LP4Ae5T5RkrZZBnQNTN3lW ce3VuEinSC8fVPWCkc8NXAqksrXZGvChp4oRSxvfk4DsILTSa+HgVP8ImyFu44lod3A79xZDEKE PgmxtIatbDAH6orK6bSk7B+/cg4A11om+jYQvnmob+Ix8AjudrCzgfeKAn/uA8OU1gFqherCwB0 tUQGce/7ZOwXKrk4KKRhRnclGjZfd64FKMcU3kTY8pctYYR1hiQjdLmisG4Fmm5RA7PLeioUjIP rjUC+VF93nwjqnzO8WcCZGpen/30azY6rQlTUEQne8DBy1RD2Cb4/7MmrSAh/XpTycU= X-Google-Smtp-Source: AGHT+IEYlToyOJr+R8YXFkFhSULjEkR2OowLuJCLc5w/3XKdZxLCXJx6NMKNblG+ZhhHv+GOy+JYng== X-Received: by 2002:a05:600c:6207:b0:43c:fe15:41cb with SMTP id 5b1f17b1804b1-4533ca76ff8mr219841245e9.15.1750322015343; Thu, 19 Jun 2025 01:33:35 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:c485:fe15:c9ab:c72f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a63a42sm18828151f8f.28.2025.06.19.01.33.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jun 2025 01:33:34 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 19 Jun 2025 10:33:22 +0200 Subject: [PATCH v2 09/12] gpio: reg: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250619-gpiochip-set-rv-gpio-v2-9-74abf689fbd8@linaro.org> References: <20250619-gpiochip-set-rv-gpio-v2-0-74abf689fbd8@linaro.org> In-Reply-To: <20250619-gpiochip-set-rv-gpio-v2-0-74abf689fbd8@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Orson Zhai , Baolin Wang , Chunyan Zhang , Robert Jarzmik , Heiko Stuebner Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1851; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=mTukrDx/R865Eocr4BQInw+yzkmSNTUOuezPg7apBCo=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoU8tT9TjfCO988cJoPpaw0anioCZr5/SZzCR4/ DPRgt1RWO6JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaFPLUwAKCRARpy6gFHHX cqwAEACHem9z95tLu2mdatXQMsbEwEicFLRuj0CKjbLo6ddh0GNFaOmHiWL6TYjpWH5luCWeMji qr1REYJYG2+rMFPuZQPUyuhA1rjAiCsrWtl/bG1cZELYCCUs4vTIYgeEp2/NsoHpfOHN+1aAb+Z cxfAS9JLi0BgNAH5ji3H1LEoyTV5WC2TEAZjv90mZhXYbKXVgC47+jmunaleDfmjku8MT8/8Orx uU5pL9dxB99qCZeNNZsNm6K68r2sEJoEjTAVe7aRTyI/GTM680rIGfT1+rWSHaV762HhWV9xM/h XY943W99sLzAtIu/+fEObsJOpIgMARGHIv/73HK2929fx+Gni/Kuy8WaRWYnDUONLxu9Tr0bLQB KbfvyCCWvxqlNvkm/dWG7MOV73RahG9L9ihNjZPRYXra5NRXstQ/xRttFCsYv7zkLnb6tJOa0e5 z+1mU60ZwoOB+XoH6XvWBCGVaBfR8gh+GA1IfVSnndtvh7Q2H4ZYUniBVwnaRsS2pxLb32R+4iq zX5AV+tgLtdpL3yOnU2jfRaUkXt5MpQ+3r78F5PqiamJZzDRD5PbZP1uj3HOHYIHZLa4gtP6gWd yEYw21OVubU+lwFvfM3IHdUhbQFiuc+J41nWd0vt6pmrx3LdNUX70dveJQRLfE8MtZESyFB9BB6 4sqwsUIoOUevrKw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-reg.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-reg.c b/drivers/gpio/gpio-reg.c index 73c7260d89c083a702b1d914ddca7a573a37de4a..557dd77ce30bbca6174babbcabc= 965cdcec57896 100644 --- a/drivers/gpio/gpio-reg.c +++ b/drivers/gpio/gpio-reg.c @@ -46,7 +46,7 @@ static int gpio_reg_direction_output(struct gpio_chip *gc= , unsigned offset, if (r->direction & BIT(offset)) return -ENOTSUPP; =20 - gc->set(gc, offset, value); + gc->set_rv(gc, offset, value); return 0; } =20 @@ -57,7 +57,7 @@ static int gpio_reg_direction_input(struct gpio_chip *gc,= unsigned offset) return r->direction & BIT(offset) ? 0 : -ENOTSUPP; } =20 -static void gpio_reg_set(struct gpio_chip *gc, unsigned offset, int value) +static int gpio_reg_set(struct gpio_chip *gc, unsigned int offset, int val= ue) { struct gpio_reg *r =3D to_gpio_reg(gc); unsigned long flags; @@ -72,6 +72,8 @@ static void gpio_reg_set(struct gpio_chip *gc, unsigned o= ffset, int value) r->out =3D val; writel_relaxed(val, r->reg); spin_unlock_irqrestore(&r->lock, flags); + + return 0; } =20 static int gpio_reg_get(struct gpio_chip *gc, unsigned offset) @@ -157,7 +159,7 @@ struct gpio_chip *gpio_reg_init(struct device *dev, voi= d __iomem *reg, r->gc.get_direction =3D gpio_reg_get_direction; r->gc.direction_input =3D gpio_reg_direction_input; r->gc.direction_output =3D gpio_reg_direction_output; - r->gc.set =3D gpio_reg_set; + r->gc.set_rv =3D gpio_reg_set; r->gc.get =3D gpio_reg_get; r->gc.set_multiple =3D gpio_reg_set_multiple; if (irqs) --=20 2.48.1 From nobody Tue Oct 7 19:50:49 2025 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17A47278E7C for ; Thu, 19 Jun 2025 08:33:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750322019; cv=none; b=Gxw7VXJKPxwJcB4s/lD/AMqpgft4YBiTlRXhc2gjbohRsy877PGPgeNK1nbm5seoSqcNVZXPIssewp5mJScxkl3VVlOS0/ewXuzqwCf3VwILuee7s1tNFOhe+8uHP7WOBVZ4TFU9yqeGTJiKSe4eRjDyQTg0ToHbePLR5k/7kjo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750322019; c=relaxed/simple; bh=COE46zuDiGK6rLwTnt7+1d3gjUwt5RswqdYUD5pUbdE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=u4iB9LToems8k+UG36K+y+2JCP8ct1YI/YCdXfRQqGjLjsoNrPqHL5JnUX4ShHaVmA07uDbBlP0H5Qwk5KAP9yuJ+sTwqQ8rfyBO+YyEXBrz87rlhTQTqBcpWlZynkMgXLBmbBKMJkXte0gVX2NCjbTBEPPlDXDB8gmrWmoy34Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=M/UztOJ8; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="M/UztOJ8" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-441ab63a415so5995335e9.3 for ; Thu, 19 Jun 2025 01:33:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750322016; x=1750926816; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=fUxEFCxSV+En4LdALjtxQKt1K3KufAQa0J+EdQHN8Wk=; b=M/UztOJ8RfBge7iEfPQGJ1+ml8t12dHjQzlaINUJ1l248wTJTAiS4W+gxFaoVNo5MD Q/+NjapzaK0R9uZKL1djiGJHsIiH2yMsxd+iqla/gslt5GOsTrN1sMliraR4dBhjv36T REkdH0wWQverMicS7p+anjliA32jQqZwt84Y1xOpIxA4V5wLn1Qniu6gKzE7R7qxOPRE srRU+o72s/EBM5O4NC2JeG6V7KvkEUgtK50+zv0q+K8/x+0mNiebLfBL26yYuEj/k81+ 4RghNVE3pxGFN1pgOtelXTVlEvkeYq0G+yWmUC2dtD8aCm9WhCdaSEYuRgWxqI/HGSqr 4wJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750322016; x=1750926816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fUxEFCxSV+En4LdALjtxQKt1K3KufAQa0J+EdQHN8Wk=; b=AZIuhyday6UMIGPyYQ575SdmZGqlTJU3j5D9PB0iX4IpVT6zlvBtHAZc/NyK3qUZUG sBXHX0Omqx5PgOKg4ODczOOD03zJU9n63AP11U5cIGxNPiOEWy03oDcgPj8No9SuBlz/ MGUR4Hh8D5u9+91pOHgF29ngNu2UKX/+xdmvyF2+qfeCSYjlosUSvMNlAk8/eurqy/34 McGWBdnDXzoqb7ac3mfEeuT3tPWTnDl9UOKFFHhoVHUQFY3nyBRLKCqtJucppTvaS4iU 1gb17gncte45uS8y4G8gK3seTW8xtx2OANsq76a8G9ElkIMOqOhL0vGdkB+Zja46injL C0/Q== X-Forwarded-Encrypted: i=1; AJvYcCUFgPukaHbIyyyxi4SxkU8haUra2g4Xyri2BfF2cvra9HHPG48jTDh4EC9lXUyolJJxHE1/lZNc2mCh+OU=@vger.kernel.org X-Gm-Message-State: AOJu0YwZMasLxnTBEmdcPE8e9VmGYgXZR1BxpsRwo6HmW2hiGnay86Zv +48RGFRbLsZ0yZXrtT+2zeAcL7MNFQZ8JO5oMlnVv00A3LtJ2uPUIpdMyyzDCy3r2jo= X-Gm-Gg: ASbGncuYBowIhfu1QBoC7jSspP9OpJ/cDpa8NsUd8RUq5HeYiXjYsvIDCenzJFKUnl6 fB62d6bzJwyMFzja3qp29CitBN864Ff5YaeULg/DAA9rrKgt/xBNK8L+q012gTQcH0GHmjHw4mr ePR8HkFQuWlu2cGW1IUnLvgnC6IsAAoOfXErqTDR7Xg/FDE9kFwrSkp85oNrko9wZUEX+R1LuNh YzTpgMeDqNShns84yohCaCQ5QP1SrSOQ6G+zK4CGJRtPb1zr8Q5YOTy3lx1EgBt/QuuMM7NTkqS j9ulAM0qehF3yJGFFT8p9XF+h8y8ju6EYLk+5UPVqKYNqcIQUXuvt+Gi5Yc+82qd7zI= X-Google-Smtp-Source: AGHT+IFfsPhVrHgeuWzX3+6sQmR19Vl1yy5xDC5faeBVZQvTDHkV39fKCws88JWALuInD7mjUF9AVg== X-Received: by 2002:a05:6000:4803:b0:3a5:3062:793a with SMTP id ffacd0b85a97d-3a572e79d41mr16470567f8f.33.1750322016552; Thu, 19 Jun 2025 01:33:36 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:c485:fe15:c9ab:c72f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a63a42sm18828151f8f.28.2025.06.19.01.33.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jun 2025 01:33:35 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 19 Jun 2025 10:33:23 +0200 Subject: [PATCH v2 10/12] gpio: rockchip: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250619-gpiochip-set-rv-gpio-v2-10-74abf689fbd8@linaro.org> References: <20250619-gpiochip-set-rv-gpio-v2-0-74abf689fbd8@linaro.org> In-Reply-To: <20250619-gpiochip-set-rv-gpio-v2-0-74abf689fbd8@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Orson Zhai , Baolin Wang , Chunyan Zhang , Robert Jarzmik , Heiko Stuebner Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1750; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=bJZscimERewZNLI5pGqQIjH00bD6YcA1Kc9nHnuKKr4=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoU8tTDKdHYa2tugbl7ZgbX8M1+hP8adwm5KKEh MqhI//NcwuJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaFPLUwAKCRARpy6gFHHX cuAAEACjn7R+KR5/zt3QNdbTEUEkbL3xT1JlWMeyK1RMVSZHp3CYFxhOFf6/8w/Xq04lnJRQ2M/ lvWSlbFLft/9IseHT/Ism4eMG7xKvNSHWLB3vEONd12JYS9fWNcn47eL61YBQUF1R3LknWWtW/x UHnsEEr1iYZB36AYooj0M4Z7raU6Xt8srnztoZ3xhNkaY+Pa+p9KHAhj/8kN/ipuyAphKXdk0r2 knA1yAb59U2dR1V9Ru5eiUOenbf9shLNvwnW8Wkjl5uOpxFD2lt0mWpFGYVvfoyGaeMw4e/hERJ 2dNPhzDGhylpw/va5zlOzxFjqzttvo9MzKX/Tvp5HrAsCreSibdjUR28e1VD+CqzNjDsmCpyqTT Czq3I7mLvtqc5cDZVsVoYve7pbUWNqsQSxKxo+cztDof+wRRCRb5IbAzrN2BBXg6S74kWSSImTZ DOjr+HHnDnLcca18BTWMAYdEXtFdeuvOqMTujZd3kUXVq1qZEOAClLVXpmVgxxDTNkaJ/cFC5jl IE3Nhh/5s2pbySabu6Q76yGyMgclCRvVhOsgKIPaeieT2bt/NtlP/vHLqXkK+ouSR/aeYlsX8jq 5ohEONkE86sx7b0n6GxTh0XkaRULQDsItKSIkMa0QjnJLrB0EGYdtLnfz+ozQ/yxhndBWKEYMww QpzQm1rT3j0ULzw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Heiko Stuebner --- drivers/gpio/gpio-rockchip.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c index 64700a003f9a17947dd38baea23a066e8c057caf..ecd60ff9e1dd1a090bfad204c8b= 86c4d7fb68ce7 100644 --- a/drivers/gpio/gpio-rockchip.c +++ b/drivers/gpio/gpio-rockchip.c @@ -177,8 +177,8 @@ static int rockchip_gpio_set_direction(struct gpio_chip= *chip, return 0; } =20 -static void rockchip_gpio_set(struct gpio_chip *gc, unsigned int offset, - int value) +static int rockchip_gpio_set(struct gpio_chip *gc, unsigned int offset, + int value) { struct rockchip_pin_bank *bank =3D gpiochip_get_data(gc); unsigned long flags; @@ -186,6 +186,8 @@ static void rockchip_gpio_set(struct gpio_chip *gc, uns= igned int offset, raw_spin_lock_irqsave(&bank->slock, flags); rockchip_gpio_writel_bit(bank, offset, value, bank->gpio_regs->port_dr); raw_spin_unlock_irqrestore(&bank->slock, flags); + + return 0; } =20 static int rockchip_gpio_get(struct gpio_chip *gc, unsigned int offset) @@ -325,7 +327,7 @@ static int rockchip_gpio_to_irq(struct gpio_chip *gc, u= nsigned int offset) static const struct gpio_chip rockchip_gpiolib_chip =3D { .request =3D gpiochip_generic_request, .free =3D gpiochip_generic_free, - .set =3D rockchip_gpio_set, + .set_rv =3D rockchip_gpio_set, .get =3D rockchip_gpio_get, .get_direction =3D rockchip_gpio_get_direction, .direction_input =3D rockchip_gpio_direction_input, --=20 2.48.1 From nobody Tue Oct 7 19:50:49 2025 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C8AA27A47F for ; Thu, 19 Jun 2025 08:33:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750322021; cv=none; b=hV6Y1WFqHDq5SD1wKMNF43ZlfNDJInk7R/qDkRw9rhTzfleaSq1ZS68fm1LhOLDK4syaVZkyRCRQBtd+Q3kMKKT0QEjG1tvVEymPhOf5NIK6B7AZDzD8vFc6A6IoFdFgBG3HgGBC+LanX8HS7nidkUQcEMOzeILzmNvRsK4dt6c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750322021; c=relaxed/simple; bh=3QvoiOFdKV8vnY8Kgna8S7pQjfH/iy2iYWkuJQ55SWI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hq6gjTuXzWVuNkKUzwjXcX831sjHxJkZg2IXsKazBXGmeV8W1M8gdlUzqOfs+73R3/6A/Z7Dsjpv9scilIhfHH85yEVIvFHmEPeNTfJ7jhusOcZ+WdCIEIlxRbjYSajwcOLjSy2linIicGm2cXiFYaBU6zARRqFNqFtDKkg4TqA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=wdFpXUgp; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="wdFpXUgp" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-3a528243636so317752f8f.3 for ; Thu, 19 Jun 2025 01:33:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750322018; x=1750926818; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kXdEOuSE84y7KQ8YXqskQa8fEM4BBQcsKhAUrS+jouY=; b=wdFpXUgpmNk7rnGQ+a8x1fbWI0fc24PbUdmm4ygy9MQykqzIM9RKy9vpyHyRmBwJJ1 UMIbuPw3dIJM+DK1+CIX0F5np2yhnqohzC0qhihph8m26sMNxt135w3kgBC5LeWmnWgd KzTtIBTMPPSm/5jfbjwXrwQOny5XY4DiXJ081vPh0iuRdvbCRcG/dVnVMP3arL1Oei3h Ke4apxlS1sRlX/88qGNaKKGTwFPIrL9yZiA79NjiV6gen/g83IJsq7inDzO3zOFPCVir BemrcribVaODDc7/VEbDwN85oW7Bk6FmR/nCVZ2d2NsHhiArlPj+HjMqPnnaqmNEyoml m5Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750322018; x=1750926818; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kXdEOuSE84y7KQ8YXqskQa8fEM4BBQcsKhAUrS+jouY=; b=Rcq2HZ+9fBAnu7bohIBZOJF67zAJue4rqVQ9Pq2GgprkbN5kuppG6YBvSU972fgOGD YxonuGeZ1ai5B+/3IzMLlKUN3Dk3b/zZ3EXdKhw/5IYabJt8BV9Z0330sTPH10UTG3kH 2CUAUbOlR5NnApjnsF3+AVddtwxlbeMrl9hWHJlAzVhEKxJ+GR1aFO/fGm5VqCrPTO1v +D1GgWIWlZAf5pzyEHf4/m7dnYQ7PEQ3IiSrV+LNyHopEdjycKhV0Sj3Ui5eowi8XMA6 zeTxNHPXFnzJsXVDiaQNBKvUsG76ZNT2dVYcBEfwSCx83xtYwDc6rdf/0r5/sMHsDw81 jt2w== X-Forwarded-Encrypted: i=1; AJvYcCWvbKWmUkPz7HL1sIT/E/AFRbEL48/3appzBUKA8RQYt8VrtI2wsIcSUrnxiji3TyAFKZPIlMvx8HQHQp4=@vger.kernel.org X-Gm-Message-State: AOJu0YzruYkFPkzaR7rsedoJEcGfcWwTvwVOsqow+8ePRVINYentFlxL 288e/Oegr0LvAlQXWxGqCXg8zEmixsgQhOuNR2y5l2BhLbotkNh+zYTJdU/XiDO+y0U= X-Gm-Gg: ASbGnctbRiglypR4xfwsm5y7HLEN9+7gelWxwwbyOZAcsgQMYFcG1RHzG1jRSfrTw46 QF+i7wHSuglQgJtP+X8v58fRPApqBz0+8kt5MbNlaHczpiZKwKz7qlAlXubnFxugvTjx7dsYzwW /kNBA7ly0udo9fYxz4f663uFTCtYjzqX5DG4HvCccvtQzkSwTRbJ+Pn+ooXPZh7mWF41UzBMeIU Q4Ln7XadJHZfJsgjl5IKagPR8Vep6WUAmmUANRhQU9IYL2sGlltZUtjc7+kC0P0j1lRidzqcNYK xnoHZCnNESeLs25Sw2n5H0vTdKoVQJ1rHHH1PMPtXU5wrKVxhOmpz/Mu X-Google-Smtp-Source: AGHT+IGYf6Ur9Ugv00BgKRd4oArCMUnqUFrWbDyyGQdN0NxdK6b+fGQpGmKSwn4EbOC14dV/Zz+MRA== X-Received: by 2002:a05:6000:1a8e:b0:3a5:2208:41d9 with SMTP id ffacd0b85a97d-3a572e92134mr16408329f8f.40.1750322018388; Thu, 19 Jun 2025 01:33:38 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:c485:fe15:c9ab:c72f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a63a42sm18828151f8f.28.2025.06.19.01.33.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jun 2025 01:33:37 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 19 Jun 2025 10:33:24 +0200 Subject: [PATCH v2 11/12] gpio: rtd: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250619-gpiochip-set-rv-gpio-v2-11-74abf689fbd8@linaro.org> References: <20250619-gpiochip-set-rv-gpio-v2-0-74abf689fbd8@linaro.org> In-Reply-To: <20250619-gpiochip-set-rv-gpio-v2-0-74abf689fbd8@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Orson Zhai , Baolin Wang , Chunyan Zhang , Robert Jarzmik , Heiko Stuebner Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1662; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=v7M2Umlyn2cPSJSz3+M1vQ3MpPcGxR4ur24zUL3eZaA=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoU8tThgGdaruvFHruvGZ1lAgXO57/m24G9JZAH AZ0dHw+AMOJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaFPLUwAKCRARpy6gFHHX cpX2D/4iJISKxtRrP48ODihJoiJODatcQMlQc7qJrlQLGfyqLACXHtKsWH3vo4ZYvHikNgYvQRJ D1nzxPRafhpjXoUNaE0TMiVgAlNKv9WTqPh8/ca2vopFGeG+12V4TJ0RolHwfeWF6rZlSlfU+CA FvT4uglIG4oz3YIndaFMKuiPqMomFTuZ0sz6nNr9S9WlWUhgXsNm9AKG8xL4IzkXqjtKBFiNu2+ U3K7koUtZzrvTm8aKdtBVpr+Kh5fAyEqbjIUM8KOkoac5CfacDs5anNnBu9PKyrknB5dvjkw/Tj DfA5KyxsLMcEl5iT4UW5xS8NRuwrd2cXoVpY7NjLMeHOMKy8KE7LFp9uDxJUsiHuG2ANr+pNF+/ Sp+rl+r5szqRedXKpvRobS9q+e3EP0vNDU/VDu1pZo/JXnoMuNM2qpx/nQVRU8Tsq8QcjUYl9ce lwj3Snv0N3vLx6DIj714XhH6wwZEaVKQhBofRj9acJG5pOKa6jB2WPRGvW125y1ztYvTMDeRfEv j2H2jU4CXmygo6ctNjELJGSJVJumx4KCPWqkrZtPbkWlOwMeO2fo29J+FLWIGoFhTsm+O8rMI3D Cl8TjTeMgJ2IZopO+r8CVVGpRCUAOrCeGhm4n04NxnSzuAKKqpB8gVhYIq4eL8fynV+EFkj49TV WjjMy+HzldWpe2w== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-rtd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-rtd.c b/drivers/gpio/gpio-rtd.c index bf7f008f58d703347cba14f35c19f5798ee3a949..25bbd749b019bf8a272c173a3e7= 373a442f72350 100644 --- a/drivers/gpio/gpio-rtd.c +++ b/drivers/gpio/gpio-rtd.c @@ -275,7 +275,7 @@ static int rtd_gpio_set_config(struct gpio_chip *chip, = unsigned int offset, } } =20 -static void rtd_gpio_set(struct gpio_chip *chip, unsigned int offset, int = value) +static int rtd_gpio_set(struct gpio_chip *chip, unsigned int offset, int v= alue) { struct rtd_gpio *data =3D gpiochip_get_data(chip); u32 mask =3D BIT(offset % 32); @@ -292,6 +292,8 @@ static void rtd_gpio_set(struct gpio_chip *chip, unsign= ed int offset, int value) else val &=3D ~mask; writel_relaxed(val, data->base + dato_reg_offset); + + return 0; } =20 static int rtd_gpio_get(struct gpio_chip *chip, unsigned int offset) @@ -563,7 +565,7 @@ static int rtd_gpio_probe(struct platform_device *pdev) data->gpio_chip.get_direction =3D rtd_gpio_get_direction; data->gpio_chip.direction_input =3D rtd_gpio_direction_input; data->gpio_chip.direction_output =3D rtd_gpio_direction_output; - data->gpio_chip.set =3D rtd_gpio_set; + data->gpio_chip.set_rv =3D rtd_gpio_set; data->gpio_chip.get =3D rtd_gpio_get; data->gpio_chip.set_config =3D rtd_gpio_set_config; data->gpio_chip.parent =3D dev; --=20 2.48.1 From nobody Tue Oct 7 19:50:49 2025 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C4D427EC80 for ; Thu, 19 Jun 2025 08:33:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750322024; cv=none; b=lqP628oX1Z0DQTMvuvzN2wNdRQoeI8y69AllBs4tC9d81ThwyR6dH//gNxmG1QaeiuZKk7pgrCeDvKV3QCXPYjexm93MKkIIWd3r2+e2o62QmnWpoStpx2MtgA79geWzcdudXZhD6gwNzYvidk6ht4QxA2b4fcoCH1CMvEidI9Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750322024; c=relaxed/simple; bh=eEv9Rs9Ob2RKbLYMX17232517BahJV9MYVei3h7Ywh0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nCKOAcpBNw7NS+xl2UKm5qN8u1TtK0XXQFLpE3Ct0fIj3uI7ANU4Eo76fI2x7Ctu5NYoEy7TCHUO9LWqFjoihgvLJZfDDmu0sT22v/21dmYpM1GyD6NEHk9VqkpgEI7LefeIl/iObQU0t+4PqHpNOUflsVudNv+74F1alCFijKU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=1TgBD8O9; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="1TgBD8O9" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-453398e90e9so3422845e9.1 for ; Thu, 19 Jun 2025 01:33:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750322021; x=1750926821; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=QlDtpw6smBpfIslmsuGCGMOBJqH80dy6aXMZgZ8Sqro=; b=1TgBD8O9f+nmGuddO/r6hPYgMInFQ2VccdDhoPpCX//lDmLWefeju8wvqLEoHNoEqH Cou3R4ZB1zpOIh7b/CUq/aDPa/ZOt2jAd24Einc/Z03KYLd5jJC3AgxeC8mwiq/hNOX9 OzH2rGKS7w1siE5RjFLaef5YOqXqYT93dLAVT6QO+f2NrR4RE0NP5Z/XlgfJIGcEcwpm /eTJYQHab+v+MUMhiR08mV8QiWKHn/oo0r1LntqxYKPl3G+rLRNrTajVEmEgzQk8/3A1 xGLwdkaChAud+Lc/Y6Uo8kjwCIvWxP7kRztDjtwW+W83GE5TB11w2Nd36BAgtZ9p2ke1 eOyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750322021; x=1750926821; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QlDtpw6smBpfIslmsuGCGMOBJqH80dy6aXMZgZ8Sqro=; b=XR3ixPRHvxnHf7MQm+hfQxDHxq8n/QRL+1scuVtrvY1md2JU2D+pcMmQal4GG7LZo3 23nOj8oeVH9YGZgsRziVaCZ4/uoSQuMmnK5zePKwbnk7Jh8/gpvNBquDhbaU//kf7P9J mlIrPbB1H5m1PWIZJ/p5UG/rZCa53oE5sSXbkgs7CXath4TjJBFkMKm3Qp+MTjvwJSGe cmdo/gxocHAaRhpw34aG7HcrMKi8RlYC0W7QhRw8/EhT16E1Kat5q1OIVfl5NQASSFvT kSOH3Ldkd7eEVI8OH19C3A0tETqx0+NOY/GzBETZSdbWDhKNMVn1hxkRJ/WW0xLO1SfV IlNQ== X-Forwarded-Encrypted: i=1; AJvYcCWIIuKf/rKwY+BLj7VXYcKrbwcT/+iZ3nXlI1cyQ00XQkL9RrDpPP+XK3fqkxsaZ2PJZp/sREVJ4PNDkx8=@vger.kernel.org X-Gm-Message-State: AOJu0YwpHx4iEdxo6FsCIjCjRfS693TCrlNRhMsrbWRLAxD3nkHDoTRx UXxGXJ/ahYtMk1SyyRE8XIiHQog74sRdjM3cp2NLjceTabklTyB7SC6EehPFwMrjgtA= X-Gm-Gg: ASbGncuYIciNqYbm17Ccprsd2JqBQcgsiiEI0W7jgd2nAlnb0bxwJg7V72AzQZKhEd9 omBo3tBVrkCP7JXs+AKDQFq9Htc+vvVANL6I2lDFnBorkw51ifqZ0r9GB06L7jRVVBGjGqqUqiP xB63b7nYHdsbE/eYBpl7SKRJihl7uL5fXqvrplHQYpuGN4V9MkL8TKAN9wJVR0Fmgn+PMYQQUOz yqMXV68hz/UW/EH/VrxQOnY38DOU5GpXsyAovs/zND9r81obe34efj/pauHjOb2zEZCk77U9eBd zciaJqBeOL28Li3PyjhwZGA3YfgfDf3J1pYjCHblVoB25TUtRfslNrhempS0GFtfTK4= X-Google-Smtp-Source: AGHT+IHGQZUCpU4EKwN0pDb1PR+66z4H2pK14lR6dL/m7pgvVM5j9STX22YLKDyKpdUEu3zyNckJVA== X-Received: by 2002:a05:600c:a218:b0:44a:b9e4:4e6f with SMTP id 5b1f17b1804b1-4533cb3bd5dmr123193585e9.16.1750322020849; Thu, 19 Jun 2025 01:33:40 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:c485:fe15:c9ab:c72f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a63a42sm18828151f8f.28.2025.06.19.01.33.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jun 2025 01:33:38 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 19 Jun 2025 10:33:25 +0200 Subject: [PATCH v2 12/12] gpio: sa1100: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250619-gpiochip-set-rv-gpio-v2-12-74abf689fbd8@linaro.org> References: <20250619-gpiochip-set-rv-gpio-v2-0-74abf689fbd8@linaro.org> In-Reply-To: <20250619-gpiochip-set-rv-gpio-v2-0-74abf689fbd8@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Orson Zhai , Baolin Wang , Chunyan Zhang , Robert Jarzmik , Heiko Stuebner Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1424; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=c4Isjx61IsXwy1L10lydMFlqZBELu3z3ba+yBwH+QRc=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoU8tTJRS7HeQsESgIvXXZ0x6YdiYTKomdEfEZK n1HshL3jCCJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaFPLUwAKCRARpy6gFHHX cuxYD/wKuuPZarmVQqOx/roO55GiDf7bp8izUkbVjw6CzO6my9TiQR/eHWWX48I0yMgBKqPffnx zz1IrAto5nMAQ9A6KTBIzHaSpr4xG1/HW2hsgFHfyyLQNlPaBpCoN/Hkew24KLU0l0XtlRFPCv+ jLqU/XGI4V8cnRhpA6BT3W0PdIUNbubJn9Kui8m80DQH7IIHbqm7dOQQUrqdVLPXIfgdxk+oHKh bB/X5SGihn+BTWJANOm2/1GLHx3nR/5yj1RqN7W7JQt2QpLWy3Q1YBphABxr1vmYFrK9SiPq0c6 ONeePjzonJ+6ypaoelJfD2fitGseIAKwp5B6mgBAuOFtZcCbO7viJLjnYgvI46LZkMGuoBbaJJm TXeNli/gceQzcOM2wUGI9XcjSet8NGq1ix+8QCot5tPEXRmbecZ4iuoA4c/OY9JTvXhzpv1MLw0 kFo9CUCEY48J4FsizkRXgqW8IiOlaxqwD/duhHiOjeu7uMFnVkab2kppAP7UiF4K1tNBKxbsM5N y5kihu7nycPMXAWE64hLLk87yc1BirJvMOxwsWg/d6kHOIUgxUs+JIG2R7v+2Cvp1Ms+20pdKG2 MmRu61iKy9tJmqKBqX+5x2zmfjfNiqX8c4jV/THDywyPZ160KYDr1iHXefZdq3yYKRZftPLFamQ jqh0yd0/V0Gc56g== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-sa1100.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-sa1100.c b/drivers/gpio/gpio-sa1100.c index 3f3ee36bc3cb19a7baf530def0575d2ff09dd3c5..e9d054d78ccb8485b9f662fcec3= 85fe0d0edc0d7 100644 --- a/drivers/gpio/gpio-sa1100.c +++ b/drivers/gpio/gpio-sa1100.c @@ -43,11 +43,14 @@ static int sa1100_gpio_get(struct gpio_chip *chip, unsi= gned offset) BIT(offset); } =20 -static void sa1100_gpio_set(struct gpio_chip *chip, unsigned offset, int v= alue) +static int sa1100_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { int reg =3D value ? R_GPSR : R_GPCR; =20 writel_relaxed(BIT(offset), sa1100_gpio_chip(chip)->membase + reg); + + return 0; } =20 static int sa1100_get_direction(struct gpio_chip *chip, unsigned offset) @@ -96,7 +99,7 @@ static struct sa1100_gpio_chip sa1100_gpio_chip =3D { .get_direction =3D sa1100_get_direction, .direction_input =3D sa1100_direction_input, .direction_output =3D sa1100_direction_output, - .set =3D sa1100_gpio_set, + .set_rv =3D sa1100_gpio_set, .get =3D sa1100_gpio_get, .to_irq =3D sa1100_to_irq, .base =3D 0, --=20 2.48.1