From nobody Fri Oct 10 04:34:50 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2C6D2F3C3F for ; Wed, 18 Jun 2025 17:40:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750268425; cv=none; b=ZxijqajYaRSet9yJuhgmGiOYTBefViW7NuuFhgy7GrDeNuSiFF5S6c4xhT/+rv/BJS67bfIFoh6KOSSuveE9nHPQ62gg59Nza3umYge7gTnY7838vSXoKZctXRrxlfYDT7/dQQqRLzp4NjpLBjztYS7H13jlE6pMIJZD5kgO5yk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750268425; c=relaxed/simple; bh=LfUaIY7XKmkW22E2CA7zcjn2zCtCLb3wGZMadkbbvUs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rOFJ1+C2oSam01SpPdIzVHc2XrRuKAVom45X4Em9u6sW+xDyYELtTWHaOKds4oNNu7fGGyRu0vpxYpJDCXRmzQ1m71ay6WpZMXIy914yZcLDkJgwkFOB9LVgfdbwrN/Mup3vVlmlLDf3+AXaliX46jjty+t8+wRZ6Z+1NX792fc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=BBdzmE9s; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BBdzmE9s" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750268422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ztkVXhL49uhBZn35+Dz91j/1BkEFGTeWr88qG2zBn1I=; b=BBdzmE9skDUR9PXrrfZSGKNCO2KuWFlBjWWdfrIv0KrfhjDWFY41eCBTQND5+K/MRm2Wur z+o1ym/WmFbHHDlaqJl/cQwjCH/JowQ/Vt2ZiVjsqH6eiz+EjDJrIWZrdLREi8nvcs05hT 93a4fyWBBlQXy4mu0gci4x6WTkFXKw0= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-537-wKU506dBOOCGcMOYuPHjPQ-1; Wed, 18 Jun 2025 13:40:21 -0400 X-MC-Unique: wKU506dBOOCGcMOYuPHjPQ-1 X-Mimecast-MFC-AGG-ID: wKU506dBOOCGcMOYuPHjPQ_1750268420 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a56b3dee17so508821f8f.0 for ; Wed, 18 Jun 2025 10:40:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750268420; x=1750873220; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ztkVXhL49uhBZn35+Dz91j/1BkEFGTeWr88qG2zBn1I=; b=RsL18fxB7SmAsiqBldSVoO6GoNWBOt+O6RF+QSoeFus78gxNRftoj1fg35Pngg5asr Hyu4GpDp99kPjmoIX537+jpWEYxEd+tt7qv0CxR5mGB5dMXALaSBuPzimqFblN70qtIk VXOEg8hm25R8vUFFmEV7nqLdj9xc4G4LxqD3UsjR1qQTx/5Si+BHEcaxAOVwIoUnhU60 AjHHfZHPsFwry0Q2sSRMrRoVWjd/MukPdAiqJr6W4spJMghp+/mdI7uZDvpER0p/MC2a gXccbciemFtpAXTDJyrJb5KIiq7c82o0jnIxuUzfjvaJnDsaMBlvm+rk0Va8CyaC7/gR g7Mg== X-Gm-Message-State: AOJu0Yzx+A7Ls2Joc7PVEz68HQIrSgpdXZQ3f43/02VXtyLCZKLeb6wW YbwdiKfSYOhubjt0HHwYxtLT5Z4ljwOis4ezdiWCc6+jxFqPCEjsRvlFkDwGrqq1ey7bb3NySJy low5jD8iZkr8JMO4w7yuzeR5mNwVW+dSG9wQ9VfznmJTik1UtABHa0hh9ZTXpQIw02X9A/H9ZZ3 wy/APLRsuHk2hEEHYVal264iXznHV0m0FkVksqOEpbESGaIq/p X-Gm-Gg: ASbGnctdm+i5yGY3fbwHpO7xPYUsjiHn/+GxmbENwYN7HlK2/loXU6mvEB8ef5lIhrW rH854UpwRoXidr6ZXJgudNTBY/EjdxXXysPUa0LnhsG39HBU8lchs14scIONP8elKSQAnV6z6so SV2MMHfSSsnnDxvjMQFCYIZpGTZJpngJu9LE5m3ZBerstlEGxxAie+ETf9sybyLSiYw94FCzzOY vdhicxGITWdS9f5PF41YJkFjGIIeL+tz3Me1OT9JZgtntBYlqv+xKA3mlvdiBNx+E2ogjEJN0+Y duUjrg2UkUjssyZgvS5AHBDlJi1SuUYBrPGapz+TiFBtcM9p6/1BDMxKoMwQjdZrTWYOb3oe/FZ Qhpi7Hw== X-Received: by 2002:a05:6000:22c1:b0:3a4:f7dd:6fad with SMTP id ffacd0b85a97d-3a6c96bde70mr478051f8f.14.1750268420178; Wed, 18 Jun 2025 10:40:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGdKc/sogX7P8eUPuNrS35oj8SOpb+inlndXsECh3VUw/sMAlaRsKTNBWIAReSnT0M7eOt7jg== X-Received: by 2002:a05:6000:22c1:b0:3a4:f7dd:6fad with SMTP id ffacd0b85a97d-3a6c96bde70mr477976f8f.14.1750268419626; Wed, 18 Jun 2025 10:40:19 -0700 (PDT) Received: from localhost (p200300d82f2d2400405203b5fff94ed0.dip0.t-ipconnect.de. [2003:d8:2f2d:2400:4052:3b5:fff9:4ed0]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a568b0898fsm17901600f8f.54.2025.06.18.10.40.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jun 2025 10:40:19 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, David Hildenbrand , Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt Subject: [PATCH RFC 01/29] mm/balloon_compaction: we cannot have isolated pages in the balloon list Date: Wed, 18 Jun 2025 19:39:44 +0200 Message-ID: <20250618174014.1168640-2-david@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250618174014.1168640-1-david@redhat.com> References: <20250618174014.1168640-1-david@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The core will set PG_isolated only after mops->isolate_page() was called. In case of the balloon, that is where we will remove it from the balloon list. So we cannot have isolated pages in the balloon list. Let's drop this unnecessary check. Signed-off-by: David Hildenbrand Acked-by: Zi Yan --- mm/balloon_compaction.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c index d3e00731e2628..fcb60233aa35d 100644 --- a/mm/balloon_compaction.c +++ b/mm/balloon_compaction.c @@ -94,12 +94,6 @@ size_t balloon_page_list_dequeue(struct balloon_dev_info= *b_dev_info, if (!trylock_page(page)) continue; =20 - if (IS_ENABLED(CONFIG_BALLOON_COMPACTION) && - PageIsolated(page)) { - /* raced with isolation */ - unlock_page(page); - continue; - } balloon_page_delete(page); __count_vm_event(BALLOON_DEFLATE); list_add(&page->lru, pages); --=20 2.49.0