From nobody Thu Oct 9 10:50:43 2025 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EE6E2951A0 for ; Wed, 18 Jun 2025 12:26:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750249573; cv=none; b=ay34i+SKVYIkW1qvd39jpaPzzB/tqwetcOm5nhmBLdXfhSQ/6SYepUAFHdC0+AXPhk7aRM07/ca2xjkOqMQ0UQErWNqb7hOxfMOeYMvitBpR2Zc+7zR90Ki61xSo4blx1dexq5gS02U8Wrf0PSKkEdrNd6/ShVw4JUkr1DrN/jA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750249573; c=relaxed/simple; bh=pq0r+fx7fW+75RtNymzq+3FY8EA8Ax2oxTXhGJHBHYw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ioxxIjGD+ggjBGRjp0SsdlW65g9OTU59r6LRCVwPG2iPm9yhgMHUIXkxDXw3082o+gt65hGOtiFTscivQtNWTkzVvhWohZt5RA98sU+rIOClYpuFUz+rZCb6Ok6tbX3btnkKvfdMxse6pHPFkZFdwgcSA46iaNqXCsTeGEwZbhQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1uRrrg-00007j-UW; Wed, 18 Jun 2025 14:26:04 +0200 Received: from dude04.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::ac]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uRrrf-0048Us-1t; Wed, 18 Jun 2025 14:26:03 +0200 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1uRrrf-00DFD8-1X; Wed, 18 Jun 2025 14:26:03 +0200 From: Oleksij Rempel To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Woojung Huh , Andrew Lunn , Russell King , Thangaraj Samynathan , Rengarajan Sundararajan Cc: Oleksij Rempel , Maxime Chevallier , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, UNGLinuxDriver@microchip.com, Phil Elwell , Simon Horman Subject: [PATCH net-next v8 3/6] net: usb: lan78xx: Use ethtool_op_get_link to reflect current link status Date: Wed, 18 Jun 2025 14:25:59 +0200 Message-Id: <20250618122602.3156678-4-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250618122602.3156678-1-o.rempel@pengutronix.de> References: <20250618122602.3156678-1-o.rempel@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Replace the custom lan78xx_get_link implementation with the standard ethtool_op_get_link helper, which uses netif_carrier_ok to reflect the current link status accurately. Signed-off-by: Oleksij Rempel Reviewed-by: Maxime Chevallier Reviewed-by: Russell King (Oracle) --- drivers/net/usb/lan78xx.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 18402a3922a6..9bb1d2527d0c 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -1839,18 +1839,6 @@ static int lan78xx_set_eee(struct net_device *net, s= truct ethtool_keee *edata) return ret; } =20 -static u32 lan78xx_get_link(struct net_device *net) -{ - u32 link; - - mutex_lock(&net->phydev->lock); - phy_read_status(net->phydev); - link =3D net->phydev->link; - mutex_unlock(&net->phydev->lock); - - return link; -} - static void lan78xx_get_drvinfo(struct net_device *net, struct ethtool_drvinfo *info) { @@ -1970,7 +1958,7 @@ lan78xx_get_regs(struct net_device *netdev, struct et= htool_regs *regs, } =20 static const struct ethtool_ops lan78xx_ethtool_ops =3D { - .get_link =3D lan78xx_get_link, + .get_link =3D ethtool_op_get_link, .nway_reset =3D phy_ethtool_nway_reset, .get_drvinfo =3D lan78xx_get_drvinfo, .get_msglevel =3D lan78xx_get_msglevel, --=20 2.39.5