From nobody Thu Oct 9 13:21:35 2025 Received: from mx0b-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABDC921C179; Wed, 18 Jun 2025 07:17:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750231049; cv=none; b=GF3LZkE9Guh1vnlFlysv9S1N0q9e//CmXVFKYBV7u6J++ZCV8rQ/VGckayEwYsYkSOpLIB4Vj103+gIO2uIVPpyUJKBqf0kJRGfsIyFm2/VuP+bTaAT9AoCYNtuwea5v+nhyJK4eWzwlq1I2zQXSju0kB3f+TpFKAoX1tIBstI0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750231049; c=relaxed/simple; bh=tF1Ke6kYlgMODOQHEpPFqWaDfL7pi5uDwAOQtAoRsEU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=bf8X8Ros5FG0JCBlqEaqHTuE9bH95ajHdmQqMVYv24h7NC6DfMJLT+LQEx4Ah50fmuiXvmKQGlTySZgGpdc2OZ1SUgXLc6pn7EaY3ncrzUIWtIVi0c+Ab2WnmBGEhZa7I3V0v9kffzKJtplwJRBlaJM3scQRwOxOIRj4tiyYF/g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=sg9nGvWY; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="sg9nGvWY" Received: from pps.filterd (m0375855.ppops.net [127.0.0.1]) by mx0b-00128a01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55I61kxO001419; Wed, 18 Jun 2025 03:17:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=G9bWe W0i0cGPknY3euQ8X9EHffD8TZUOKwmYRZ9Oo3Y=; b=sg9nGvWYm4xXukCVJn+xb wTYHviGgXxWsC+pjJniP89FzI7P923N6SnLFv8i2ddRc1G3droI8PhvzWDHigKFu gToexgRb3iexGXli/SEEvpmt1S4qQzxml2M+sNUp9TSTeMEne5psxGXehG337aCa 3KoQtRPj4IrqQOCTdcbMmfGplpnvzyX7vg1XQQ4KsfXN95RrTjxCMk9cF2X7ddDf HtTjvctTOLy8PWK3pFgqo3yJVRNHqr6MefvMLQx35Q6DeasFGsNO/uZ/HXOFOGY6 5RrrcoqM0ISL9efqqSlYRq9etJ1O/P87XBC4YCrA6lTRBJWxvG7OsEzGsQhfZoRK g== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0b-00128a01.pphosted.com (PPS) with ESMTPS id 47bfsqjd1h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 18 Jun 2025 03:17:03 -0400 (EDT) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 55I7H2tI037091 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 18 Jun 2025 03:17:02 -0400 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.10; Wed, 18 Jun 2025 03:17:02 -0400 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.1748.10 via Frontend Transport; Wed, 18 Jun 2025 03:17:02 -0400 Received: from HYB-DlYm71t3hSl.ad.analog.com (HYB-DlYm71t3hSl.ad.analog.com [10.44.3.56] (may be forged)) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 55I7GkPg027550; Wed, 18 Jun 2025 03:16:57 -0400 From: Jorge Marques Date: Wed, 18 Jun 2025 09:16:44 +0200 Subject: [PATCH v3 2/2] i3c: master: Add driver for Analog Devices I3C Controller IP Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250618-adi-i3c-master-v3-2-e66170a6cb95@analog.com> References: <20250618-adi-i3c-master-v3-0-e66170a6cb95@analog.com> In-Reply-To: <20250618-adi-i3c-master-v3-0-e66170a6cb95@analog.com> To: Alexandre Belloni , Frank Li , Rob Herring , Krzysztof Kozlowski , Conor Dooley CC: , , , , Jorge Marques X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1750231006; l=30982; i=jorge.marques@analog.com; s=20250303; h=from:subject:message-id; bh=tF1Ke6kYlgMODOQHEpPFqWaDfL7pi5uDwAOQtAoRsEU=; b=ME2ANugMMi1BCFktKKdjEgE7Xr0qN70eXdk5Qna/FRxfBZjGjSVk0YKN1fKVvnvfcoBbTOGWO Goix7NiyeRzB9fBXvlHE6AUY6hORf2P6WomJ9vbGwJPa6dzXDJx2d8+ X-Developer-Key: i=jorge.marques@analog.com; a=ed25519; pk=NUR1IZZMH0Da3QbJ2tBSznSPVfRpuoWdhBzKGSpAdbg= X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-ORIG-GUID: uP0MqkS2kZl0jZT7esuXHoe_2vApsDiD X-Proofpoint-GUID: uP0MqkS2kZl0jZT7esuXHoe_2vApsDiD X-Authority-Analysis: v=2.4 cv=d9L1yQjE c=1 sm=1 tr=0 ts=685267f1 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=IkcTkHD0fZMA:10 a=6IFa9wvqVegA:10 a=gAnH3GRIAAAA:8 a=Br2UW1UjAAAA:8 a=jPpI4jNERvfxAMYflC4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=WmXOPjafLNExVIMTj843:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjE4MDA2MSBTYWx0ZWRfXw6nishQWYUTc VVD31D2v7vVDef3QzH6CWdb6iS57pV5wysC+GQOnN0l1KATgp1Eu+dXolRqG5qQ14b6LAJYBZ+m ixqid1gHKkmf18qhvTnHecdRs4glBU1BZencXzIYrRUJSQl5jkstSmeufDZnLuZA79asSNknQmL /WEvfi4cOtbihxrqTH+cx7C3WDGu0OEE66mMiX0P92ZuGMA91COArDk8XfSl/bvQ1K/HCB2UfJX XCHZBuCMyFtTa2J2TdugN3eCt8O872CqbrmspSzV6sIEypzVlVAB1ocucwlap8+2HyQek1ufBCr n5dpJdvjCd0EGHPoOZqGOMPY8bqXlbdKBe0HJtmnk1J6xU7B46mgc2q4PKDuTkLM3EuKY1QQ6Kf /ycunRGXyDYuMdHtZ/ygZy7jx0tH4r7AkgXGWWJYe8bybw4vaVO0f7qBvta/Tzn3+zXCTRnb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-18_02,2025-06-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 phishscore=0 spamscore=0 mlxlogscore=999 mlxscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506180061 Add support for Analog Devices I3C Controller IP, an AXI-interfaced IP core that supports I3C and I2C devices, multiple speed-grades and I3C IBIs. Signed-off-by: Jorge Marques --- MAINTAINERS | 1 + drivers/i3c/master/Kconfig | 11 + drivers/i3c/master/Makefile | 1 + drivers/i3c/master/adi-i3c-master.c | 1026 +++++++++++++++++++++++++++++++= ++++ 4 files changed, 1039 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6f56e17dcecf902c6812827c1ec3e067c65e9894..9eb5b6c327590725d1641fd4b73= e48fc1d1a3954 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11247,6 +11247,7 @@ I3C DRIVER FOR ANALOG DEVICES I3C CONTROLLER IP M: Jorge Marques S: Maintained F: Documentation/devicetree/bindings/i3c/adi,i3c-master.yaml +F: drivers/i3c/master/adi-i3c-master.c =20 I3C DRIVER FOR CADENCE I3C MASTER IP M: Przemys=C5=82aw Gaj diff --git a/drivers/i3c/master/Kconfig b/drivers/i3c/master/Kconfig index 7b30db3253af9d5c6aee6544c060e491bfbeb643..328b7145cdefa20e708ebfa3383= e849ce51c5a71 100644 --- a/drivers/i3c/master/Kconfig +++ b/drivers/i3c/master/Kconfig @@ -1,4 +1,15 @@ # SPDX-License-Identifier: GPL-2.0-only +config ADI_I3C_MASTER + tristate "Analog Devices I3C master driver" + depends on HAS_IOMEM + help + Support for Analog Devices I3C Controller IP, an AXI-interfaced IP + core that supports I3C and I2C devices, multiple speed-grades and + I3C IBIs. + + This driver can also be built as a module. If so, the module + will be called adi-i3c-master. + config CDNS_I3C_MASTER tristate "Cadence I3C master driver" depends on HAS_IOMEM diff --git a/drivers/i3c/master/Makefile b/drivers/i3c/master/Makefile index 3e97960160bc85e5eaf2966ec0c3fae458c2711e..6cc4f4b73e7bdc206b68c750390= f9c3cc2ccb199 100644 --- a/drivers/i3c/master/Makefile +++ b/drivers/i3c/master/Makefile @@ -1,4 +1,5 @@ # SPDX-License-Identifier: GPL-2.0-only +obj-$(CONFIG_ADI_I3C_MASTER) +=3D adi-i3c-master.o obj-$(CONFIG_CDNS_I3C_MASTER) +=3D i3c-master-cdns.o obj-$(CONFIG_DW_I3C_MASTER) +=3D dw-i3c-master.o obj-$(CONFIG_AST2600_I3C_MASTER) +=3D ast2600-i3c-master.o diff --git a/drivers/i3c/master/adi-i3c-master.c b/drivers/i3c/master/adi-i= 3c-master.c new file mode 100644 index 0000000000000000000000000000000000000000..d4e0756efec9588383ac55ca9ea= 9228368ce767d --- /dev/null +++ b/drivers/i3c/master/adi-i3c-master.c @@ -0,0 +1,1026 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * I3C Controller driver + * Copyright 2025 Analog Devices Inc. + * Author: Jorge Marques + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define VERSION_MAJOR(x) ((u32)FIELD_GET(GENMASK(23, 16), (x))) +#define VERSION_MINOR(x) ((u32)FIELD_GET(GENMASK(15, 8), (x))) +#define VERSION_PATCH(x) ((u32)FIELD_GET(GENMASK(7, 0), (x))) + +#define MAX_DEVS 16 + +#define REG_VERSION 0x000 +#define REG_ENABLE 0x040 +#define REG_IRQ_MASK 0x080 +#define REG_IRQ_PENDING 0x084 +#define REG_IRQ_PENDING_CMDR BIT(5) +#define REG_IRQ_PENDING_IBI ((u32)BIT(6)) +#define REG_IRQ_PENDING_DAA BIT(7) +#define REG_CMD_FIFO 0x0d4 +#define REG_CMD_FIFO_0_IS_CCC BIT(22) +#define REG_CMD_FIFO_0_BCAST BIT(21) +#define REG_CMD_FIFO_0_SR BIT(20) +#define REG_CMD_FIFO_0_LEN(l) FIELD_PREP(GENMASK(19, 8), (l)) +#define REG_CMD_FIFO_0_DEV_ADDR(a) FIELD_PREP(GENMASK(7, 1), a) +#define REG_CMD_FIFO_0_RNW BIT(0) +#define REG_CMD_FIFO_1_CCC(id) FIELD_PREP(GENMASK(7, 0), (id)) +#define REG_CMD_FIFO_ROOM 0x0c0 +#define REG_CMDR_FIFO 0x0d8 +#define REG_CMDR_FIFO_NO_ERROR 0 +#define REG_CMDR_FIFO_CE0_ERROR 1 +#define REG_CMDR_FIFO_CE2_ERROR 4 +#define REG_CMDR_FIFO_NACK_RESP 6 +#define REG_CMDR_FIFO_UDA_ERROR 8 +#define REG_CMDR_FIFO_ERROR(x) FIELD_GET(GENMASK(23, 20), (x)) +#define REG_CMDR_FIFO_XFER_BYTES(x) FIELD_GET(GENMASK(19, 8), (x)) +#define REG_SDO_FIFO 0x0dc +#define REG_SDO_FIFO_ROOM 0x0c8 +#define REG_SDI_FIFO 0x0e0 +#define REG_IBI_FIFO 0x0e4 +#define REG_FIFO_STATUS 0x0e8 +#define REG_FIFO_STATUS_CMDR_EMPTY BIT(0) +#define REG_FIFO_STATUS_IBI_EMPTY BIT(1) +#define REG_OPS 0x100 +#define REG_OPS_SET_SG(x) FIELD_PREP(GENMASK(6, 5), (x)) +#define REG_OPS_PP_SG_MASK GENMASK(6, 5) +#define REG_IBI_CONFIG 0x140 +#define REG_IBI_CONFIG_LISTEN BIT(1) +#define REG_IBI_CONFIG_ENABLE BIT(0) +#define REG_DEV_CHAR 0x180 +#define REG_DEV_CHAR_IS_I2C BIT(0) +#define REG_DEV_CHAR_IS_ATTACHED BIT(1) +#define REG_DEV_CHAR_BCR_IBI(x) (((x) & GENMASK(2, 1)) << 1) +#define REG_DEV_CHAR_WEN BIT(8) +#define REG_DEV_CHAR_ADDR(x) FIELD_PREP(GENMASK(15, 9), (x)) + +enum speed_grade {PP_SG_UNSET, PP_SG_1MHZ, PP_SG_3MHZ, PP_SG_6MHZ, PP_SG_1= 2MHZ}; +struct adi_i3c_cmd { + u32 cmd0; + u32 cmd1; + u32 tx_len; + const void *tx_buf; + u32 rx_len; + void *rx_buf; + u32 error; +}; + +struct adi_i3c_xfer { + struct list_head node; + struct completion comp; + int ret; + unsigned int ncmds; + unsigned int ncmds_comp; + struct adi_i3c_cmd cmds[]; +}; + +struct adi_i3c_master { + struct i3c_master_controller base; + u32 free_rr_slots; + unsigned int maxdevs; + struct { + unsigned int num_slots; + struct i3c_dev_desc **slots; + spinlock_t lock; /* Protect IBI slot access */ + } ibi; + struct { + struct list_head list; + struct adi_i3c_xfer *cur; + spinlock_t lock; /* Protect transfer */ + } xferqueue; + void __iomem *regs; + struct clk *clk; + unsigned long i3c_scl_lim; + struct { + u8 addrs[MAX_DEVS]; + u8 index; + } daa; +}; + +static inline struct adi_i3c_master *to_adi_i3c_master(struct i3c_master_c= ontroller *master) +{ + return container_of(master, struct adi_i3c_master, base); +} + +static void adi_i3c_master_wr_to_tx_fifo(struct adi_i3c_master *master, + const u8 *bytes, unsigned int nbytes) +{ + unsigned int n, m; + u32 tmp; + + n =3D readl(master->regs + REG_SDO_FIFO_ROOM); + m =3D min(n, nbytes); + writesl(master->regs + REG_SDO_FIFO, bytes, m / 4); + + if (m & 3) { + memcpy(&tmp, bytes + (m & ~3), m & 3); + writel(tmp, master->regs + REG_SDO_FIFO); + } +} + +static void adi_i3c_master_rd_from_rx_fifo(struct adi_i3c_master *master, + u8 *bytes, unsigned int nbytes) +{ + readsl(master->regs + REG_SDI_FIFO, bytes, nbytes / 4); + if (nbytes & 3) { + u32 tmp; + + tmp =3D readl(master->regs + REG_SDI_FIFO); + memcpy(bytes + (nbytes & ~3), &tmp, nbytes & 3); + } +} + +static bool adi_i3c_master_supports_ccc_cmd(struct i3c_master_controller *= m, + const struct i3c_ccc_cmd *cmd) +{ + if (cmd->ndests > 1) + return false; + + switch (cmd->id) { + case I3C_CCC_ENEC(true): + case I3C_CCC_ENEC(false): + case I3C_CCC_DISEC(true): + case I3C_CCC_DISEC(false): + case I3C_CCC_RSTDAA(true): + case I3C_CCC_RSTDAA(false): + case I3C_CCC_ENTDAA: + case I3C_CCC_SETDASA: + case I3C_CCC_SETNEWDA: + case I3C_CCC_GETMWL: + case I3C_CCC_GETMRL: + case I3C_CCC_GETPID: + case I3C_CCC_GETBCR: + case I3C_CCC_GETDCR: + case I3C_CCC_GETSTATUS: + case I3C_CCC_GETHDRCAP: + return true; + default: + break; + } + + return false; +} + +static int adi_i3c_master_disable(struct adi_i3c_master *master) +{ + writel(0, master->regs + REG_IBI_CONFIG); + + return 0; +} + +static struct adi_i3c_xfer *adi_i3c_master_alloc_xfer(struct adi_i3c_maste= r *master, + unsigned int ncmds) +{ + struct adi_i3c_xfer *xfer; + + xfer =3D kzalloc(struct_size(xfer, cmds, ncmds), GFP_KERNEL); + if (!xfer) + return NULL; + + INIT_LIST_HEAD(&xfer->node); + xfer->ncmds =3D ncmds; + xfer->ret =3D -ETIMEDOUT; + + return xfer; +} + +static void adi_i3c_master_start_xfer_locked(struct adi_i3c_master *master) +{ + struct adi_i3c_xfer *xfer =3D master->xferqueue.cur; + unsigned int i, n, m; + + if (!xfer) + return; + + for (i =3D 0; i < xfer->ncmds; i++) { + struct adi_i3c_cmd *cmd =3D &xfer->cmds[i]; + + if (!(cmd->cmd0 & REG_CMD_FIFO_0_RNW)) + adi_i3c_master_wr_to_tx_fifo(master, cmd->tx_buf, cmd->tx_len); + } + + n =3D readl(master->regs + REG_CMD_FIFO_ROOM); + for (i =3D 0; i < xfer->ncmds; i++) { + struct adi_i3c_cmd *cmd =3D &xfer->cmds[i]; + + m =3D cmd->cmd0 & REG_CMD_FIFO_0_IS_CCC ? 2 : 1; + if (m > n) + break; + writel(cmd->cmd0, master->regs + REG_CMD_FIFO); + if (cmd->cmd0 & REG_CMD_FIFO_0_IS_CCC) + writel(cmd->cmd1, master->regs + REG_CMD_FIFO); + n -=3D m; + } +} + +static void adi_i3c_master_end_xfer_locked(struct adi_i3c_master *master, + u32 pending) +{ + struct adi_i3c_xfer *xfer =3D master->xferqueue.cur; + int i, ret =3D 0; + u32 status0; + + if (!xfer) + return; + + for (status0 =3D readl(master->regs + REG_FIFO_STATUS); + !(status0 & REG_FIFO_STATUS_CMDR_EMPTY); + status0 =3D readl(master->regs + REG_FIFO_STATUS)) { + struct adi_i3c_cmd *cmd; + u32 cmdr, rx_len; + + cmdr =3D readl(master->regs + REG_CMDR_FIFO); + + cmd =3D &xfer->cmds[xfer->ncmds_comp++]; + if (cmd->cmd0 & REG_CMD_FIFO_0_RNW) { + rx_len =3D min_t(u32, REG_CMDR_FIFO_XFER_BYTES(cmdr), cmd->rx_len); + adi_i3c_master_rd_from_rx_fifo(master, cmd->rx_buf, rx_len); + } + cmd->error =3D REG_CMDR_FIFO_ERROR(cmdr); + } + + for (i =3D 0; i < xfer->ncmds; i++) { + switch (xfer->cmds[i].error) { + case REG_CMDR_FIFO_NO_ERROR: + break; + + case REG_CMDR_FIFO_CE0_ERROR: + case REG_CMDR_FIFO_CE2_ERROR: + case REG_CMDR_FIFO_NACK_RESP: + case REG_CMDR_FIFO_UDA_ERROR: + ret =3D -EIO; + break; + + default: + ret =3D -EINVAL; + break; + } + } + + xfer->ret =3D ret; + + if (xfer->ncmds_comp !=3D xfer->ncmds) + return; + + complete(&xfer->comp); + + xfer =3D list_first_entry_or_null(&master->xferqueue.list, + struct adi_i3c_xfer, node); + if (xfer) + list_del_init(&xfer->node); + + master->xferqueue.cur =3D xfer; + adi_i3c_master_start_xfer_locked(master); +} + +static void adi_i3c_master_queue_xfer(struct adi_i3c_master *master, + struct adi_i3c_xfer *xfer) +{ + init_completion(&xfer->comp); + guard(spinlock_irqsave)(&master->xferqueue.lock); + if (master->xferqueue.cur) { + list_add_tail(&xfer->node, &master->xferqueue.list); + } else { + master->xferqueue.cur =3D xfer; + adi_i3c_master_start_xfer_locked(master); + } +} + +static void adi_i3c_master_unqueue_xfer(struct adi_i3c_master *master, + struct adi_i3c_xfer *xfer) +{ + guard(spinlock_irqsave)(&master->xferqueue.lock); + if (master->xferqueue.cur =3D=3D xfer) + master->xferqueue.cur =3D NULL; + else + list_del_init(&xfer->node); + + writel(0x01, master->regs + REG_ENABLE); + writel(0x00, master->regs + REG_ENABLE); + writel(REG_IRQ_PENDING_CMDR, master->regs + REG_IRQ_MASK); +} + +static enum i3c_error_code adi_i3c_cmd_get_err(struct adi_i3c_cmd *cmd) +{ + switch (cmd->error) { + case REG_CMDR_FIFO_CE0_ERROR: + return I3C_ERROR_M0; + + case REG_CMDR_FIFO_CE2_ERROR: + case REG_CMDR_FIFO_NACK_RESP: + return I3C_ERROR_M2; + + default: + break; + } + + return I3C_ERROR_UNKNOWN; +} + +static int adi_i3c_master_send_ccc_cmd(struct i3c_master_controller *m, + struct i3c_ccc_cmd *cmd) +{ + struct adi_i3c_master *master =3D to_adi_i3c_master(m); + struct adi_i3c_xfer *xfer; + struct adi_i3c_cmd *ccmd; + + xfer =3D adi_i3c_master_alloc_xfer(master, 1); + if (!xfer) + return -ENOMEM; + + ccmd =3D xfer->cmds; + ccmd->cmd1 =3D REG_CMD_FIFO_1_CCC(cmd->id); + ccmd->cmd0 =3D REG_CMD_FIFO_0_IS_CCC | + REG_CMD_FIFO_0_LEN(cmd->dests[0].payload.len); + + if (cmd->id & I3C_CCC_DIRECT) + ccmd->cmd0 |=3D REG_CMD_FIFO_0_DEV_ADDR(cmd->dests[0].addr); + + if (cmd->rnw) { + ccmd->cmd0 |=3D REG_CMD_FIFO_0_RNW; + ccmd->rx_buf =3D cmd->dests[0].payload.data; + ccmd->rx_len =3D cmd->dests[0].payload.len; + } else { + ccmd->tx_buf =3D cmd->dests[0].payload.data; + ccmd->tx_len =3D cmd->dests[0].payload.len; + } + + adi_i3c_master_queue_xfer(master, xfer); + if (!wait_for_completion_timeout(&xfer->comp, msecs_to_jiffies(1000))) + adi_i3c_master_unqueue_xfer(master, xfer); + + cmd->err =3D adi_i3c_cmd_get_err(&xfer->cmds[0]); + kfree(xfer); + + return 0; +} + +static int adi_i3c_master_priv_xfers(struct i3c_dev_desc *dev, + struct i3c_priv_xfer *xfers, + int nxfers) +{ + struct i3c_master_controller *m =3D i3c_dev_get_master(dev); + struct adi_i3c_master *master =3D to_adi_i3c_master(m); + struct adi_i3c_xfer *xfer; + int i, ret; + + if (!nxfers) + return 0; + xfer =3D adi_i3c_master_alloc_xfer(master, nxfers); + if (!xfer) + return -ENOMEM; + + for (i =3D 0; i < nxfers; i++) { + struct adi_i3c_cmd *ccmd =3D &xfer->cmds[i]; + + ccmd->cmd0 =3D REG_CMD_FIFO_0_DEV_ADDR(dev->info.dyn_addr); + + if (xfers[i].rnw) { + ccmd->cmd0 |=3D REG_CMD_FIFO_0_RNW; + ccmd->rx_buf =3D xfers[i].data.in; + ccmd->rx_len =3D xfers[i].len; + } else { + ccmd->tx_buf =3D xfers[i].data.out; + ccmd->tx_len =3D xfers[i].len; + } + + ccmd->cmd0 |=3D REG_CMD_FIFO_0_LEN(xfers[i].len); + + if (i < nxfers - 1) + ccmd->cmd0 |=3D REG_CMD_FIFO_0_SR; + + if (!i) + ccmd->cmd0 |=3D REG_CMD_FIFO_0_BCAST; + } + + adi_i3c_master_queue_xfer(master, xfer); + if (!wait_for_completion_timeout(&xfer->comp, + msecs_to_jiffies(1000))) + adi_i3c_master_unqueue_xfer(master, xfer); + + ret =3D xfer->ret; + + for (i =3D 0; i < nxfers; i++) + xfers[i].err =3D adi_i3c_cmd_get_err(&xfer->cmds[i]); + + kfree(xfer); + + return ret; +} + +struct adi_i3c_i2c_dev_data { + u16 id; + s16 ibi; + struct i3c_generic_ibi_pool *ibi_pool; +}; + +static int adi_i3c_master_get_rr_slot(struct adi_i3c_master *master, + u8 dyn_addr) +{ + if (!master->free_rr_slots) + return -ENOSPC; + + return ffs(master->free_rr_slots) - 1; +} + +static int adi_i3c_master_reattach_i3c_dev(struct i3c_dev_desc *dev, u8 dy= n_addr) +{ + struct i3c_master_controller *m =3D i3c_dev_get_master(dev); + struct adi_i3c_master *master =3D to_adi_i3c_master(m); + u8 addr; + + addr =3D dev->info.dyn_addr ? dev->info.dyn_addr : dev->info.static_addr; + + writel(REG_DEV_CHAR_ADDR(dyn_addr), master->regs + REG_DEV_CHAR); + writel((readl(master->regs + REG_DEV_CHAR) & + ~REG_DEV_CHAR_IS_ATTACHED) | REG_DEV_CHAR_WEN, + master->regs + REG_DEV_CHAR); + + writel(REG_DEV_CHAR_ADDR(addr), master->regs + REG_DEV_CHAR); + writel(readl(master->regs + REG_DEV_CHAR) | + REG_DEV_CHAR_IS_ATTACHED | REG_DEV_CHAR_WEN, + master->regs + REG_DEV_CHAR); + + return 0; +} + +static int adi_i3c_master_attach_i3c_dev(struct i3c_dev_desc *dev) +{ + struct i3c_master_controller *m =3D i3c_dev_get_master(dev); + struct adi_i3c_master *master =3D to_adi_i3c_master(m); + struct adi_i3c_i2c_dev_data *data; + int slot; + u8 addr; + + data =3D kzalloc(sizeof(*data), GFP_KERNEL); + if (!data) + return -ENOMEM; + + slot =3D adi_i3c_master_get_rr_slot(master, dev->info.dyn_addr); + if (slot < 0) { + kfree(data); + return slot; + } + + data->ibi =3D -1; + data->id =3D slot; + i3c_dev_set_master_data(dev, data); + master->free_rr_slots &=3D ~BIT(slot); + + addr =3D dev->info.dyn_addr ? dev->info.dyn_addr : dev->info.static_addr; + + writel(REG_DEV_CHAR_ADDR(addr), master->regs + REG_DEV_CHAR); + writel(readl(master->regs + REG_DEV_CHAR) | + REG_DEV_CHAR_IS_ATTACHED | REG_DEV_CHAR_WEN, + master->regs + REG_DEV_CHAR); + + return 0; +} + +static void adi_i3c_master_sync_dev_char(struct i3c_master_controller *m) +{ + struct adi_i3c_master *master =3D to_adi_i3c_master(m); + struct i3c_dev_desc *i3cdev; + u8 addr; + + i3c_bus_for_each_i3cdev(&m->bus, i3cdev) { + addr =3D i3cdev->info.dyn_addr ? + i3cdev->info.dyn_addr : i3cdev->info.static_addr; + writel(REG_DEV_CHAR_ADDR(addr), master->regs + REG_DEV_CHAR); + writel(readl(master->regs + REG_DEV_CHAR) | + REG_DEV_CHAR_BCR_IBI(i3cdev->info.bcr) | REG_DEV_CHAR_WEN, + master->regs + REG_DEV_CHAR); + } +} + +static void adi_i3c_master_detach_i3c_dev(struct i3c_dev_desc *dev) +{ + struct i3c_master_controller *m =3D i3c_dev_get_master(dev); + struct adi_i3c_master *master =3D to_adi_i3c_master(m); + struct adi_i3c_i2c_dev_data *data =3D i3c_dev_get_master_data(dev); + u8 addr; + + addr =3D dev->info.dyn_addr ? dev->info.dyn_addr : dev->info.static_addr; + + writel(REG_DEV_CHAR_ADDR(addr), master->regs + REG_DEV_CHAR); + writel((readl(master->regs + REG_DEV_CHAR) & + ~REG_DEV_CHAR_IS_ATTACHED) | REG_DEV_CHAR_WEN, + master->regs + REG_DEV_CHAR); + + i3c_dev_set_master_data(dev, NULL); + master->free_rr_slots |=3D BIT(data->id); + kfree(data); +} + +static int adi_i3c_master_attach_i2c_dev(struct i2c_dev_desc *dev) +{ + struct i3c_master_controller *m =3D i2c_dev_get_master(dev); + struct adi_i3c_master *master =3D to_adi_i3c_master(m); + struct adi_i3c_i2c_dev_data *data; + int slot; + + slot =3D adi_i3c_master_get_rr_slot(master, 0); + if (slot < 0) + return slot; + + data =3D kzalloc(sizeof(*data), GFP_KERNEL); + if (!data) + return -ENOMEM; + + data->id =3D slot; + master->free_rr_slots &=3D ~BIT(slot); + i2c_dev_set_master_data(dev, data); + + writel(REG_DEV_CHAR_ADDR(dev->addr) | + REG_DEV_CHAR_IS_I2C | REG_DEV_CHAR_IS_ATTACHED | REG_DEV_CHAR_WEN, + master->regs + REG_DEV_CHAR); + + return 0; +} + +static void adi_i3c_master_detach_i2c_dev(struct i2c_dev_desc *dev) +{ + struct i3c_master_controller *m =3D i2c_dev_get_master(dev); + struct adi_i3c_master *master =3D to_adi_i3c_master(m); + struct adi_i3c_i2c_dev_data *data =3D i2c_dev_get_master_data(dev); + + writel(REG_DEV_CHAR_ADDR(dev->addr) | + REG_DEV_CHAR_IS_I2C | REG_DEV_CHAR_WEN, + master->regs + REG_DEV_CHAR); + + i2c_dev_set_master_data(dev, NULL); + master->free_rr_slots |=3D BIT(data->id); + kfree(data); +} + +static void adi_i3c_master_bus_cleanup(struct i3c_master_controller *m) +{ + struct adi_i3c_master *master =3D to_adi_i3c_master(m); + + adi_i3c_master_disable(master); +} + +static void adi_i3c_master_upd_i3c_scl_lim(struct adi_i3c_master *master) +{ + struct i3c_master_controller *m =3D &master->base; + struct i3c_bus *bus =3D i3c_master_get_bus(m); + u8 i3c_scl_lim =3D 0; + struct i3c_dev_desc *dev; + u8 pp_sg; + + i3c_bus_for_each_i3cdev(bus, dev) { + u8 max_fscl; + + max_fscl =3D max(I3C_CCC_MAX_SDR_FSCL(dev->info.max_read_ds), + I3C_CCC_MAX_SDR_FSCL(dev->info.max_write_ds)); + + switch (max_fscl) { + case I3C_SDR1_FSCL_8MHZ: + max_fscl =3D PP_SG_6MHZ; + break; + case I3C_SDR2_FSCL_6MHZ: + max_fscl =3D PP_SG_3MHZ; + break; + case I3C_SDR3_FSCL_4MHZ: + max_fscl =3D PP_SG_3MHZ; + break; + case I3C_SDR4_FSCL_2MHZ: + max_fscl =3D PP_SG_1MHZ; + break; + case I3C_SDR0_FSCL_MAX: + default: + max_fscl =3D PP_SG_12MHZ; + break; + } + + if (max_fscl && + (i3c_scl_lim > max_fscl || !i3c_scl_lim)) + i3c_scl_lim =3D max_fscl; + } + + if (!i3c_scl_lim) + return; + + master->i3c_scl_lim =3D i3c_scl_lim - 1; + + pp_sg =3D readl(master->regs + REG_OPS) & ~REG_OPS_PP_SG_MASK; + pp_sg |=3D REG_OPS_SET_SG(master->i3c_scl_lim); + + writel(pp_sg, master->regs + REG_OPS); +} + +static void adi_i3c_master_get_features(struct adi_i3c_master *master, + unsigned int slot, + struct i3c_device_info *info) +{ + memset(info, 0, sizeof(*info)); + + info->dyn_addr =3D 0x31; + info->dcr =3D 0x00; + info->bcr =3D 0x40; + info->pid =3D 0; +} + +static int adi_i3c_master_do_daa(struct i3c_master_controller *m) +{ + struct adi_i3c_master *master =3D to_adi_i3c_master(m); + u32 irq_mask; + int ret, addr; + + addr =3D 0x8; + for (u8 i =3D 0; i < MAX_DEVS; i++) { + addr =3D i3c_master_get_free_addr(m, addr); + if (addr < 0) + return addr; + master->daa.addrs[i] =3D addr; + } + + irq_mask =3D readl(master->regs + REG_IRQ_MASK); + writel(irq_mask | REG_IRQ_PENDING_DAA, + master->regs + REG_IRQ_MASK); + + master->daa.index =3D 0; + ret =3D i3c_master_entdaa_locked(&master->base); + + writel(irq_mask, master->regs + REG_IRQ_MASK); + + /* DAA always finishes with CE2_ERROR or NACK_RESP */ + if (ret && ret !=3D I3C_ERROR_M2) + return ret; + + /* Add I3C devices discovered */ + for (u8 i =3D 0; i < master->daa.index; i++) + i3c_master_add_i3c_dev_locked(m, master->daa.addrs[i]); + /* Sync retrieved devs info with the IP */ + adi_i3c_master_sync_dev_char(m); + + i3c_master_defslvs_locked(&master->base); + + adi_i3c_master_upd_i3c_scl_lim(master); + + return 0; +} + +static int adi_i3c_master_bus_init(struct i3c_master_controller *m) +{ + struct adi_i3c_master *master =3D to_adi_i3c_master(m); + struct i3c_device_info info =3D { }; + int ret; + + ret =3D i3c_master_get_free_addr(m, 0); + if (ret < 0) + return ret; + + adi_i3c_master_get_features(master, 0, &info); + ret =3D i3c_master_set_info(&master->base, &info); + if (ret) + return ret; + + writel(REG_IBI_CONFIG_LISTEN, + master->regs + REG_IBI_CONFIG); + + return 0; +} + +static void adi_i3c_master_handle_ibi(struct adi_i3c_master *master, + u32 ibi) +{ + struct adi_i3c_i2c_dev_data *data; + struct i3c_ibi_slot *slot; + struct i3c_dev_desc *dev; + u8 da, id; + u8 *mdb; + + da =3D (ibi >> 17) & GENMASK(6, 0); + for (id =3D 0; id < master->ibi.num_slots; id++) { + if (master->ibi.slots[id] && + master->ibi.slots[id]->info.dyn_addr =3D=3D da) + break; + } + + if (id =3D=3D master->ibi.num_slots) + return; + + dev =3D master->ibi.slots[id]; + guard(spinlock)(&master->ibi.lock); + + data =3D i3c_dev_get_master_data(dev); + slot =3D i3c_generic_ibi_get_free_slot(data->ibi_pool); + if (!slot) + return; + + mdb =3D slot->data; + mdb[0] =3D (ibi >> 8) & GENMASK(7, 0); + + slot->len =3D 1; + i3c_master_queue_ibi(dev, slot); +} + +static void adi_i3c_master_demux_ibis(struct adi_i3c_master *master) +{ + u32 status0; + + for (status0 =3D readl(master->regs + REG_FIFO_STATUS); + !(status0 & REG_FIFO_STATUS_IBI_EMPTY); + status0 =3D readl(master->regs + REG_FIFO_STATUS)) { + u32 ibi =3D readl(master->regs + REG_IBI_FIFO); + + adi_i3c_master_handle_ibi(master, ibi); + } +} + +static void adi_i3c_master_handle_da_req(struct adi_i3c_master *master) +{ + u8 payload0[8]; + u32 addr; + + /* Clear device characteristics */ + adi_i3c_master_rd_from_rx_fifo(master, payload0, 6); + addr =3D master->daa.addrs[master->daa.index++]; + addr =3D (addr << 1) | (parity8(addr) ? 0 : 1); + + writel(addr, master->regs + REG_SDO_FIFO); +} + +static irqreturn_t adi_i3c_master_irq(int irq, void *data) +{ + struct adi_i3c_master *master =3D data; + u32 pending; + + pending =3D readl(master->regs + REG_IRQ_PENDING); + writel(pending, master->regs + REG_IRQ_PENDING); + if (pending & REG_IRQ_PENDING_CMDR) { + spin_lock(&master->xferqueue.lock); + adi_i3c_master_end_xfer_locked(master, pending); + spin_unlock(&master->xferqueue.lock); + } + if (pending & REG_IRQ_PENDING_IBI) + adi_i3c_master_demux_ibis(master); + if (pending & REG_IRQ_PENDING_DAA) + adi_i3c_master_handle_da_req(master); + + return IRQ_HANDLED; +} + +static int adi_i3c_master_i2c_xfers(struct i2c_dev_desc *dev, + struct i2c_msg *xfers, + int nxfers) +{ + struct i3c_master_controller *m =3D i2c_dev_get_master(dev); + struct adi_i3c_master *master =3D to_adi_i3c_master(m); + struct adi_i3c_xfer *xfer; + int i, ret; + + if (!nxfers) + return 0; + for (i =3D 0; i < nxfers; i++) { + if (xfers[i].flags & I2C_M_TEN) + return -EOPNOTSUPP; + } + xfer =3D adi_i3c_master_alloc_xfer(master, nxfers); + if (!xfer) + return -ENOMEM; + + for (i =3D 0; i < nxfers; i++) { + struct adi_i3c_cmd *ccmd =3D &xfer->cmds[i]; + + ccmd->cmd0 =3D REG_CMD_FIFO_0_DEV_ADDR(xfers[i].addr); + + if (xfers[i].flags & I2C_M_RD) { + ccmd->cmd0 |=3D REG_CMD_FIFO_0_RNW; + ccmd->rx_buf =3D xfers[i].buf; + ccmd->rx_len =3D xfers[i].len; + } else { + ccmd->tx_buf =3D xfers[i].buf; + ccmd->tx_len =3D xfers[i].len; + } + + ccmd->cmd0 |=3D REG_CMD_FIFO_0_LEN(xfers[i].len); + } + + adi_i3c_master_queue_xfer(master, xfer); + if (!wait_for_completion_timeout(&xfer->comp, + m->i2c.timeout)) + adi_i3c_master_unqueue_xfer(master, xfer); + + ret =3D xfer->ret; + kfree(xfer); + return ret; +} + +static int adi_i3c_master_disable_ibi(struct i3c_dev_desc *dev) +{ + struct i3c_master_controller *m =3D i3c_dev_get_master(dev); + struct adi_i3c_master *master =3D to_adi_i3c_master(m); + struct i3c_dev_desc *i3cdev; + u32 enabled =3D 0; + int ret; + + ret =3D i3c_master_disec_locked(m, dev->info.dyn_addr, + I3C_CCC_EVENT_SIR); + + i3c_bus_for_each_i3cdev(&m->bus, i3cdev) { + if (dev !=3D i3cdev && i3cdev->ibi) + enabled |=3D i3cdev->ibi->enabled; + } + if (!enabled) { + writel(REG_IBI_CONFIG_LISTEN, + master->regs + REG_IBI_CONFIG); + writel(readl(master->regs + REG_IRQ_MASK) & ~REG_IRQ_PENDING_IBI, + master->regs + REG_IRQ_MASK); + } + + return ret; +} + +static int adi_i3c_master_enable_ibi(struct i3c_dev_desc *dev) +{ + struct i3c_master_controller *m =3D i3c_dev_get_master(dev); + struct adi_i3c_master *master =3D to_adi_i3c_master(m); + + writel(REG_IBI_CONFIG_LISTEN | REG_IBI_CONFIG_ENABLE, + master->regs + REG_IBI_CONFIG); + + writel(readl(master->regs + REG_IRQ_MASK) | REG_IRQ_PENDING_IBI, + master->regs + REG_IRQ_MASK); + + return i3c_master_enec_locked(m, dev->info.dyn_addr, + I3C_CCC_EVENT_SIR); +} + +static int adi_i3c_master_request_ibi(struct i3c_dev_desc *dev, + const struct i3c_ibi_setup *req) +{ + struct i3c_master_controller *m =3D i3c_dev_get_master(dev); + struct adi_i3c_master *master =3D to_adi_i3c_master(m); + struct adi_i3c_i2c_dev_data *data; + unsigned long flags; + unsigned int i; + + data =3D i3c_dev_get_master_data(dev); + data->ibi_pool =3D i3c_generic_ibi_alloc_pool(dev, req); + if (IS_ERR(data->ibi_pool)) + return PTR_ERR(data->ibi_pool); + + spin_lock_irqsave(&master->ibi.lock, flags); + for (i =3D 0; i < master->ibi.num_slots; i++) { + if (!master->ibi.slots[i]) { + data->ibi =3D i; + master->ibi.slots[i] =3D dev; + break; + } + } + spin_unlock_irqrestore(&master->ibi.lock, flags); + + if (i < master->ibi.num_slots) + return 0; + + i3c_generic_ibi_free_pool(data->ibi_pool); + data->ibi_pool =3D NULL; + + return -ENOSPC; +} + +static void adi_i3c_master_free_ibi(struct i3c_dev_desc *dev) +{ + struct i3c_master_controller *m =3D i3c_dev_get_master(dev); + struct adi_i3c_master *master =3D to_adi_i3c_master(m); + struct adi_i3c_i2c_dev_data *data =3D i3c_dev_get_master_data(dev); + unsigned long flags; + + spin_lock_irqsave(&master->ibi.lock, flags); + master->ibi.slots[data->ibi] =3D NULL; + data->ibi =3D -1; + spin_unlock_irqrestore(&master->ibi.lock, flags); + + i3c_generic_ibi_free_pool(data->ibi_pool); +} + +static void adi_i3c_master_recycle_ibi_slot(struct i3c_dev_desc *dev, + struct i3c_ibi_slot *slot) +{ + struct adi_i3c_i2c_dev_data *data =3D i3c_dev_get_master_data(dev); + + i3c_generic_ibi_recycle_slot(data->ibi_pool, slot); +} + +static const struct i3c_master_controller_ops adi_i3c_master_ops =3D { + .bus_init =3D adi_i3c_master_bus_init, + .bus_cleanup =3D adi_i3c_master_bus_cleanup, + .attach_i3c_dev =3D adi_i3c_master_attach_i3c_dev, + .reattach_i3c_dev =3D adi_i3c_master_reattach_i3c_dev, + .detach_i3c_dev =3D adi_i3c_master_detach_i3c_dev, + .attach_i2c_dev =3D adi_i3c_master_attach_i2c_dev, + .detach_i2c_dev =3D adi_i3c_master_detach_i2c_dev, + .do_daa =3D adi_i3c_master_do_daa, + .supports_ccc_cmd =3D adi_i3c_master_supports_ccc_cmd, + .send_ccc_cmd =3D adi_i3c_master_send_ccc_cmd, + .priv_xfers =3D adi_i3c_master_priv_xfers, + .i2c_xfers =3D adi_i3c_master_i2c_xfers, + .request_ibi =3D adi_i3c_master_request_ibi, + .enable_ibi =3D adi_i3c_master_enable_ibi, + .disable_ibi =3D adi_i3c_master_disable_ibi, + .free_ibi =3D adi_i3c_master_free_ibi, + .recycle_ibi_slot =3D adi_i3c_master_recycle_ibi_slot, +}; + +static const struct of_device_id adi_i3c_master_of_match[] =3D { + { .compatible =3D "adi,i3c-master" }, + {} +}; + +static int adi_i3c_master_probe(struct platform_device *pdev) +{ + struct adi_i3c_master *master; + unsigned int version; + int ret, irq; + + master =3D devm_kzalloc(&pdev->dev, sizeof(*master), GFP_KERNEL); + if (!master) + return -ENOMEM; + + master->regs =3D devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(master->regs)) + return PTR_ERR(master->regs); + + master->clk =3D devm_clk_get_enabled(&pdev->dev, "axi"); + if (IS_ERR(master->clk)) + return PTR_ERR(master->clk); + + irq =3D platform_get_irq(pdev, 0); + if (irq < 0) + return irq; + + version =3D readl(master->regs + REG_VERSION); + if (VERSION_MAJOR(version) !=3D 0) { + dev_err(&pdev->dev, "Unsupported IP version %u.%u.%c\n", + VERSION_MAJOR(version), + VERSION_MINOR(version), + VERSION_PATCH(version)); + return -EINVAL; + } + + writel(0x00, master->regs + REG_ENABLE); + writel(0x00, master->regs + REG_IRQ_MASK); + + ret =3D devm_request_irq(&pdev->dev, irq, adi_i3c_master_irq, 0, + dev_name(&pdev->dev), master); + if (ret) + return ret; + + platform_set_drvdata(pdev, master); + + master->maxdevs =3D MAX_DEVS; + master->free_rr_slots =3D GENMASK(master->maxdevs, 1); + + writel(REG_IRQ_PENDING_CMDR, master->regs + REG_IRQ_MASK); + + spin_lock_init(&master->ibi.lock); + master->ibi.num_slots =3D 15; + master->ibi.slots =3D devm_kcalloc(&pdev->dev, master->ibi.num_slots, + sizeof(*master->ibi.slots), + GFP_KERNEL); + if (!master->ibi.slots) + return -ENOMEM; + + return i3c_master_register(&master->base, &pdev->dev, + &adi_i3c_master_ops, false); +} + +static void adi_i3c_master_remove(struct platform_device *pdev) +{ + struct adi_i3c_master *master =3D platform_get_drvdata(pdev); + + writel(0xff, master->regs + REG_IRQ_PENDING); + writel(0x00, master->regs + REG_IRQ_MASK); + writel(0x01, master->regs + REG_ENABLE); + + i3c_master_unregister(&master->base); +} + +static struct platform_driver adi_i3c_master =3D { + .probe =3D adi_i3c_master_probe, + .remove =3D adi_i3c_master_remove, + .driver =3D { + .name =3D "adi-i3c-master", + .of_match_table =3D adi_i3c_master_of_match, + }, +}; +module_platform_driver(adi_i3c_master); + +MODULE_AUTHOR("Jorge Marques "); +MODULE_DESCRIPTION("Analog Devices I3C master driver"); +MODULE_LICENSE("GPL"); --=20 2.49.0