From nobody Thu Oct 9 10:42:22 2025 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0022B1F1315 for ; Tue, 17 Jun 2025 21:09:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750194597; cv=none; b=HYzsEPzMViAObLz2lI/yTPY8LfoYSh6iblWbbF+spTbuft5JAT0Pj8/wgxWBgfmq9jOkRC2FvZsyYqN0wMh6/k7ZYnwgGyqVHRPPJ3VqeoDld5s1qJOuYfMXdi3b09I0JSdsgVno5tvz+7kKKVWMhSmKc9TgYFHySzaA75TGic0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750194597; c=relaxed/simple; bh=l+gAYnVK3hmPAH+0q3x5oDcbd+to8+Y/w24p5fg7pLw=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=aoZEv1NhFU2xHi7LqILynycJPOL4jyRo7H1Do2ot4yay/DqITDfl5CWW1PRzFCRIfLgtvEL3yK9un5WR65Q+GrEK4LtW/AdX6ttb3Ce/mIkJ7+c16Fp0W1n5yUe8vSqpX0Mn+0cIwY8mVyKsXiyCwoJKsJtBH5m61zrcGNqjFo8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--almasrymina.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Vp8MluEo; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--almasrymina.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Vp8MluEo" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-313ff01d2a6so3075430a91.3 for ; Tue, 17 Jun 2025 14:09:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1750194595; x=1750799395; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=i/VGyywtV/bSSnR/m+LOohdoubGYGpC2/0l4w+x6gBw=; b=Vp8MluEo9lHM3F15rEtxRtKR9KQguhdDGUKu6B6KJmvY0equ7FZZbQjQ0bxmguunbx yghVwbEyTi+wJScsf0NfyUatieWEDUGamXU4KNFjEzsAIjB7RoFfyqake6QPWowXLc4o 4cpLVpFYuVoE5KHIqdZkl9f/ivek7KUzU7jh9dcxzpmkgv9gqaDWFPF7nAGD9ViJOud8 ZxJADZf5KvhbJjJ9pQC19yY6RSVcV/fvKHWSVhXweNtJA4Ofyc9SDPa5GS36KfdBRwcD QPNtawow41kFS2OB35n36S2DTPp2Cf8ONpeX1S3qspeJQj09r71JBEVs+avqz+cXZGgC dHZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750194595; x=1750799395; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=i/VGyywtV/bSSnR/m+LOohdoubGYGpC2/0l4w+x6gBw=; b=WSECKzG8dnpzvksobEewkQdV4tdE2o9goCSWoSZ9dpZSBpWjH6q4ZJrxhpEfEh9+Yx JJAAGL7nbIIYvBFJt6I91mKhdnC1ThzR2PHZ/YD7uU7c4I5TFmIWktNEiWvrUyN7mhWc KcJTcZv24H3yJ3Edrfke07FqBpF2JzcBCvzspM89ykheNx6dJQN9685BcbksxhjmEiEi 8JjIa5c+1TjDdMNu3mnG8g+jOVil0+1m5TQzSK5UL2QJwk3DFfHdDTWlYdYFaPtw4V7w yJjVbyGll1IR8LHF47cEwRglXzChh2ZuUWdkAerfURR2vMXxigiO1bXxdGRdZ2bj0sra UCTA== X-Forwarded-Encrypted: i=1; AJvYcCXmcTKqKl0rOCmVOD6ykl0Kgb+nZQEsKp/ykvIU460Vt3GL797VSdzGjeJb9Xh9QB935fOG1vrwTl3CkII=@vger.kernel.org X-Gm-Message-State: AOJu0YxZSHSKxw1tpN57Jp8xLHdPcZ8CvvVrt+tn6hFmIXTvpVL2f6Z9 nysdtb2CBPavmfYqUaLYnQnn4HJkiTi3UQA7HiQKwckTVpxnbNHYvEygnqyc/wY3YU9PA7er1fJ VVMWiuvmPQsQ9iD+S/AWBEetBlA== X-Google-Smtp-Source: AGHT+IGwwf3BFhjYUIQUdJ7POIRGQ7r131ZO7hQf1HmFGKvNY0E42xdvnx+IXbs+DORFLXEGhl15NyJiGXis2ooPow== X-Received: from pjbmw15.prod.google.com ([2002:a17:90b:4d0f:b0:314:2a3f:89c5]) (user=almasrymina job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90a:c107:b0:311:ad7f:3281 with SMTP id 98e67ed59e1d1-313f1ca70acmr27617519a91.12.1750194595273; Tue, 17 Jun 2025 14:09:55 -0700 (PDT) Date: Tue, 17 Jun 2025 21:09:50 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.50.0.rc2.696.g1fc2a0284f-goog Message-ID: <20250617210950.1338107-1-almasrymina@google.com> Subject: [PATCH net v1] netmem: fix skb_frag_address_safe with unreadable skbs From: Mina Almasry To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mina Almasry , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , ap420073@gmail.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" skb_frag_address_safe() needs a check that the skb_frag_page exists check similar to skb_frag_address(). Cc: ap420073@gmail.com Signed-off-by: Mina Almasry Acked-by: Stanislav Fomichev --- include/linux/skbuff.h | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 5520524c93bf..9d551845e517 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -3665,7 +3665,12 @@ static inline void *skb_frag_address(const skb_frag_= t *frag) */ static inline void *skb_frag_address_safe(const skb_frag_t *frag) { - void *ptr =3D page_address(skb_frag_page(frag)); + void *ptr; + + if (!skb_frag_page(frag)) + return NULL; + + ptr =3D page_address(skb_frag_page(frag)); if (unlikely(!ptr)) return NULL; =20 base-commit: 7b4ac12cc929e281cf7edc22203e0533790ebc2b --=20 2.50.0.rc2.696.g1fc2a0284f-goog