From nobody Fri Oct 10 09:48:04 2025 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73F12290BA5 for ; Tue, 17 Jun 2025 08:20:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750148414; cv=none; b=lA2ryn2hUt60uUHBwrrk1ig/FkP7sRWrS8P7AoiIOmtxpyL5kEcZ86fu3LVS0QochdXlVtbAjIZeA7bz2WsVAMJ9E5GjfzWgcFUkbvN9v1fQqnqgZM68hV0tuN7BDN/g3UhseDUXu3ZurW6ZlH3gjcICYT2qffe7U+/ohsI1iiw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750148414; c=relaxed/simple; bh=QcClUm1ZLCCbAPKXN4VamHSf/5X+mE7f+yW0QnLfibc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j9ObiPHqf42/AHsWTfxTRpi+25tltR4TYnTg6Z1xBHOnuCSSrit7YB6dMjQP9hJDbacSki7l+d9IRZGar3Pq45yAW2LuRNpRAcRgiHIAHCF+HtshDMt3ZNC7hR79YYkCTw/8oB0Tnod3Wlms0SbygA0jCWi+RpdGEAaMfF/S8Yo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Z5GrbODi; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Z5GrbODi" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-313910f392dso4895479a91.2 for ; Tue, 17 Jun 2025 01:20:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1750148412; x=1750753212; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=D8FRIhQ2Woh3xq2iizepqRwoAErGxOnhjCQDU9AZzIY=; b=Z5GrbODi1WmDHQ5CqiRF48yObpetmBImXfZromTQZwLuLyVaVCakAJt9VfyS9z7UF5 P9m+opDF38wUnOlX5HIEJUPmhDgs1OPJiCF88akzNbOl0J2RIJI0SVRiGyarOuRRhZ8P etvmclvNRFmJXE5apB+/ayQcnaNY6cF2a2PTg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750148412; x=1750753212; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D8FRIhQ2Woh3xq2iizepqRwoAErGxOnhjCQDU9AZzIY=; b=TwDOqqoS2Dy7CXI+J8r+i0xazZEES3eVEbdckeJ8ek2xifL/bHNrzXhzaf9I4OXusX e5N2npRiYApH+eMPWuhOfpTQg4ntDYDnwkjpXrtSum0WWpZNs1ICoMbhoNCK1DGmyses B2+bCtMwxPSkvSKuxygylUAMt+T+jOD6VfzigZJGGnSb9HRFRxDoHXcn+eLeiC81ZT+4 DdpxEiQRyIToiASpGPBY11l6jh44dpn6lUNHVYuS3zSrbi28McUEnLld+witjIluCIBQ WxpOmPI2tb25hshxxDMTgrLvzBc7WyF4aUWZdhYLEvvwMJ01G5u78+Em4GgA2+qRqfit KDNQ== X-Forwarded-Encrypted: i=1; AJvYcCUu4uvijp8YXD69Aa3HUU7j0B6NvgeJrSYzhDMGWNoh5QqhwAesGV1CbFnb3XhYCOkS5bcZsOU1Qy9e/fk=@vger.kernel.org X-Gm-Message-State: AOJu0Ywzi2T+puYfk29ZT3Rpbv7aWji1N9AAUiFZIA3jpl3WCvEmLit3 ylc1lje6HfdsN68VDP1R+3B1fdcoXXY/wWuocbTwhNJkiSdx8sIspDfhxuhu0m3ZHA== X-Gm-Gg: ASbGncuE+r1rR63uvQdovfzgpopgkOTmtgaFULjXpxccU61b9ST+z7ceTLM9p07ASMi sF1CE33wW4pMGpowEdVYRJqL/er2b3RUvp88XC5AzLH99CkU3Bsx1yMf+d5omBSbF/weRF97eD/ EqMPzq375nQDNl2CEZVVT0EXyxkv7mgJIQ4EeV5p/fJn0WqrWCju4FTsWOat9RFshC8gtpgfmAk kLbEkyW0PBsd/An5U0yzWTUDPjbP01P/xnWdejFGoLwa8o1I1hAMNbVv8H6npzPjInaiHJGgYgW HSF2HPxGnGrJpqHUQtBYv1PbZTXD8TR+M5l+dy9CEW4CCLIOOzdaSVeJHLdQjM9B2RDS3bjA3S5 Pbqs7 X-Google-Smtp-Source: AGHT+IG3KNV6ixPiJvUtBGaYxn8qmkk4lCQcaXYtEk6THCxE8V+YIcx+EzSCVTlQvmABQC9D1Nc91Q== X-Received: by 2002:a17:90b:4e84:b0:313:dcf4:37bc with SMTP id 98e67ed59e1d1-313f1dd74acmr15712251a91.34.1750148411484; Tue, 17 Jun 2025 01:20:11 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:24a1:2596:1651:13d8]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365de781f7sm74598885ad.110.2025.06.17.01.20.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 01:20:11 -0700 (PDT) From: Chen-Yu Tsai To: Matthias Brugger , AngeloGioacchino Del Regno , Dmitry Torokhov Cc: Chen-Yu Tsai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-input@vger.kernel.org, Douglas Anderson , "Rob Herring (Arm)" Subject: [PATCH v3 1/6] dt-bindings: HID: i2c-hid: elan: Introduce Elan eKTH8D18 Date: Tue, 17 Jun 2025 16:19:58 +0800 Message-ID: <20250617082004.1653492-2-wenst@chromium.org> X-Mailer: git-send-email 2.50.0.rc2.692.g299adb8693-goog In-Reply-To: <20250617082004.1653492-1-wenst@chromium.org> References: <20250617082004.1653492-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Elan eKTH8D18 touchscreen controller is an I2C HID device with a longer boot-up time. Power sequence timing wise it is compatible with the eKTH6A12NAY, with a power-on delay of at least 5ms, 20ms out-of-reset for I2C ack response, and 150ms out-of-reset for I2C HID enumeration, both shorter than what the eKTH6A12NAY requires. Enumeration and subsequent operation follows the I2C HID standard. Add a compatible string for it with the ekth6a12nay one as a fallback. No enum was used as it is rare to actually add new entries. These chips are commonly completely backward compatible, and unless the power sequencing delays change, there is no real effort being made to keep track of new parts, which come out constantly. Also drop the constraints on the I2C address since it's not really part of the binding. Reviewed-by: Douglas Anderson Reviewed-by: Rob Herring (Arm) Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Chen-Yu Tsai --- Changes since v1: - Reworded commit message - Dropped the enum for the new compatible string entry - Dropped constraint on I2C address completely --- .../devicetree/bindings/input/elan,ekth6915.yaml | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml b/D= ocumentation/devicetree/bindings/input/elan,ekth6915.yaml index cb3e1801b0d3..0840e4ab28b7 100644 --- a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml +++ b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml @@ -4,14 +4,14 @@ $id: http://devicetree.org/schemas/input/elan,ekth6915.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# =20 -title: Elan eKTH6915 touchscreen controller +title: Elan I2C-HID touchscreen controllers =20 maintainers: - Douglas Anderson =20 description: - Supports the Elan eKTH6915 touchscreen controller. - This touchscreen controller uses the i2c-hid protocol with a reset GPIO. + Supports the Elan eKTH6915 and other I2C-HID touchscreen controllers. + These touchscreen controller use the i2c-hid protocol with a reset GPIO. =20 allOf: - $ref: /schemas/input/touchscreen/touchscreen.yaml# @@ -23,12 +23,14 @@ properties: - enum: - elan,ekth5015m - const: elan,ekth6915 + - items: + - const: elan,ekth8d18 + - const: elan,ekth6a12nay - enum: - elan,ekth6915 - elan,ekth6a12nay =20 - reg: - const: 0x10 + reg: true =20 interrupts: maxItems: 1 --=20 2.50.0.rc2.692.g299adb8693-goog From nobody Fri Oct 10 09:48:04 2025 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4FB7291C15 for ; Tue, 17 Jun 2025 08:20:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750148416; cv=none; b=OHxjIJ3MOe5ErQFkZvUwapIn7NFeRK3oIhuvkOxyvUlGVYvpNWU+6q7tZTd9GPn+xR8W+ILr9eU0qqXW3oHK+LKC6HR17JPj6yMSx1nmTHSf7a1mzMpFvX4ldaggSubQAufY9mrCj9AEO/b50Y4Ji27kzY0NPMDIYl0VWQxHecU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750148416; c=relaxed/simple; bh=sZ4za1Id7G7nTtjakVPvrhklzZJfNGfC4w42qoWdWUg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XUgQWPT9tWmCXokVtqn824xDDIiITRZmVhePWep+yvHEWZGZAcc9qJ7QnGiyYrs0RC6sc9OBcZRZXOjrTfi9v9+cqVfp4+yY/kF1wx3zhDxnjeqP4+eU2m4yiZwQiTaTfIcPhujHhpO/WLKjmYrrg2iq4/ujtr4D1WY3BhCdTh0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=FszV23VG; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="FszV23VG" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2363e973db1so50572345ad.0 for ; Tue, 17 Jun 2025 01:20:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1750148414; x=1750753214; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hJpSSWKODubMWDu6LS8hKhfIs2zxRW9+kSXB6f03nq8=; b=FszV23VGo5soy7GqxhDa8qKGOPpx4ZJMjjJTg/0uTpRAaGcmgNhwDNF7oZyfeVxQTS T2NZs4rOdGbY4Ft9XdzsAVa4noz+gFOpJqzBKL26PJznvBmf5hbjUAvVHpwKoqiXIzaB PlsEXYnHvIoPcZrZ664znfwMIM+9Rkq7cV1T8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750148414; x=1750753214; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hJpSSWKODubMWDu6LS8hKhfIs2zxRW9+kSXB6f03nq8=; b=SWdfK39KEBNVHf7m+6+1fg408zGuPWxyVPMLruzgPNMD4TmpbIrXLcVbNx0pt9Qmy/ McXeVJKWPAqqv00z11Q5EfyTW58M6B9Z4Jpnqngtq+cqCi8kSbvbuZw+169iyX6PDT0T JIyXsHy+C7GHJ0yie7gNkAuoNHmwycxSOsNLwVrAk5vum8cj/xCqsklRDuTtgizXglRu G7whz4FgejlTX1OzGcCVsNCCKmjgKLWQdwkv9lBmm7JmWZj2UjTUgMg6ajFtMgdkfKYH FhDt6jtnM95tJiXsmkpnMjbs3jm4RbKCkioOY7jlFpjAOeVjMUoxmOjofxP9fZItgBXH I+eQ== X-Forwarded-Encrypted: i=1; AJvYcCV5rJNbwwatZ3k6PEg94FnykgkeByr25yu1OaDMS0gLpZ/KH8l/EqoNR1BoIhjvzVzId6LaKmuX3frsSww=@vger.kernel.org X-Gm-Message-State: AOJu0YxpCp0zwk6YNzBn5JV1FLDtIpL3i4MSV1CuEwveMmPKYbspEprK 7NqU5D6AG0LoYgN+7W4yr9OWK2R15UBp1I9dRStRImf6iwBN++KTo2lKW2uaLewhbA== X-Gm-Gg: ASbGncsqHwIHb2LpOXVq0rly1mlrXyTkmu+koAAQtZK6SJjPYSBaPyWsbwU1KFtwWEd +fM4BuUTWbikBCHJIynhIb978lmdbsO+SobjpdJQCl7UeQTNqQtCSn9koYhc5BVsHlvDiSbS3B4 JtWifc593IDqodQ10vr/VA32/i4i/Vn/H89Yewb4NY1+iUfUTtR77RSDWvONdqpDDnLvA9FYpSC I1wyBFRC/LNPjTJWlPx/VBk2hXYDOrKvaWqxnb28uObl2CwuGezLNJp390YXwOg6a4uRvNgc3rg pZL9zVStKc9JsOs7aNyHx5NzsmN+xcvbs8npkTL7ydK1ohxwdRlwaCCQ0AYktKiyBziw0qtd0wZ NisMSiOoj8uovlbE= X-Google-Smtp-Source: AGHT+IFfpg2r7E+A3hwnVaD8XvFL8a9eXnDD2HrKdh1NTx8ZQ0KD0SKLHARkzMHejSWGfoyIg/Kiig== X-Received: by 2002:a17:903:4b07:b0:234:b3fb:8ed with SMTP id d9443c01a7336-23691bedec5mr30450435ad.1.1750148414061; Tue, 17 Jun 2025 01:20:14 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:24a1:2596:1651:13d8]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365de781f7sm74598885ad.110.2025.06.17.01.20.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 01:20:13 -0700 (PDT) From: Chen-Yu Tsai To: Matthias Brugger , AngeloGioacchino Del Regno , Dmitry Torokhov Cc: Chen-Yu Tsai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-input@vger.kernel.org, "Rob Herring (Arm)" , Benson Leung Subject: [PATCH v3 2/6] dt-bindings: arm: mediatek: Merge MT8186 Voltorb entries Date: Tue, 17 Jun 2025 16:19:59 +0800 Message-ID: <20250617082004.1653492-3-wenst@chromium.org> X-Mailer: git-send-email 2.50.0.rc2.692.g299adb8693-goog In-Reply-To: <20250617082004.1653492-1-wenst@chromium.org> References: <20250617082004.1653492-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There are only two different SKUs of Voltorb, and the only difference between them is whether a touchscreen is present or not. This can be detected by a simple I2C transfer to the address, instead of having separate compatible strings and device trees. Drop the SKU-specific compatible strings and just keep the generic "google,voltorb" one. Acked-by: Rob Herring (Arm) Reviewed-by: Benson Leung Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Chen-Yu Tsai --- Changes since v1: - Added Rob's ack --- Documentation/devicetree/bindings/arm/mediatek.yaml | 3 --- 1 file changed, 3 deletions(-) diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Document= ation/devicetree/bindings/arm/mediatek.yaml index a7e0a72f6e4c..2032b0b64ba7 100644 --- a/Documentation/devicetree/bindings/arm/mediatek.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml @@ -350,9 +350,6 @@ properties: - const: mediatek,mt8186 - description: Google Voltorb (Acer Chromebook 311 C723/C732T) items: - - enum: - - google,voltorb-sku589824 - - google,voltorb-sku589825 - const: google,voltorb - const: mediatek,mt8186 - items: --=20 2.50.0.rc2.692.g299adb8693-goog From nobody Fri Oct 10 09:48:04 2025 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2864B2949E5 for ; Tue, 17 Jun 2025 08:20:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750148418; cv=none; b=WkV9i8HGgHAxXmOHL5qKVJ27m/6XGSfKGEXmLM0DH+gRcoECkOqXq6lVuB72OxQrwpH0NsBuiboK+gQKxNeRadmwXqfOwPXHBOjGb/YWsRMjjWmgSp8Hg/Xwzwb0zt3BocNdmkHnTXq3OEZ14UwglBagexfDDnt8yeoXFkHhGpc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750148418; c=relaxed/simple; bh=UxAuiy3peyOlwLJBGOPsPiR8T6DVdxWS7Est9l1Frw4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YBcrtnt1PYyjjfkNSqQN7WUwRGPjFyvOE/oPh1OswbQ9NTJsmcj6WlJ84hQxkb/FoQQtgnt3FnAWf1T/2+W7nwi3MiiaLwrXy8HwbMyOJjx1GJwfxU6gfWG8WY11sNL+wbc5McZnWxxwbltsJmhhHGO3mhV2sxPlWQJAs0fOkf4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=dycxxRg1; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="dycxxRg1" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-234fcadde3eso68739625ad.0 for ; Tue, 17 Jun 2025 01:20:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1750148416; x=1750753216; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/boR19WWVB+LDycLFRcC7qjbHGCqTpzpia0XTcyCZes=; b=dycxxRg1MQFA+QY5WXQUEmRBQCKew+3Qv1hNIdOhEyqmjsiabzW5aiSMJXy9CJ3HHr DwyltDia5ZJl6M0jbflsrENZUlilBPKvV2aP9vMoVcuT2FtD1kUSG/JgRevQGoPo9qxb 09Sd0g/xpTLPtRyz/H6C7Xw/ElgKmPnDkEzVA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750148416; x=1750753216; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/boR19WWVB+LDycLFRcC7qjbHGCqTpzpia0XTcyCZes=; b=vUEIr9S0BWtER3eS5GVO5wOCFA5SJ+zp4oZT2jZNc2f9eDdegHyJ+KvUxrtL2oovVN JbflcBtFJgBCl4O6hSlzItaglQWjBTr9RB2mh6nC7ImecXtcfSCqxbUX1nX1tdLlkfpW ImFhcCCTSYMhhm0duA0K/CAkuojqUvvrxTFg1DvBE/I2Hc6BfmWzBg1sPT4ZRzEMbrnc RAVfZ4bs19jzO5mhLUjov9UQX3zRKRA+wfKChPeDOGoVkOqmaAJBrs/4l3RlSEEpO4a4 C/2IBl/TaK96Qn7V+98e6p66M38n+MRXzXe5NkoSPbTWB6qpV3rKVh5T61BgXNCylylo IYBg== X-Forwarded-Encrypted: i=1; AJvYcCWabpwGejRGLZ1h34me5tc4ddqRh8Q1a1yYQGh/7Bzdb3mm5cKz3NEgsBcg7dJSe9FTCrCKbMBzdeU4OxA=@vger.kernel.org X-Gm-Message-State: AOJu0YzZ9Ol/yQvS3/uX6Pr/6Lh2QAw/UncQ1gZW8m/A2R1YVbgsd/+i D99Kn82FzXXp3r46UFXHMO3n4Mu5mkziov27+ZzrONwyUV1CPJMw/O2KRvpNbVHTgQ== X-Gm-Gg: ASbGncsNfQacG/z4bPxyv5JOgJFC9oiKDuhRLj0v7z7aqRgqacuT5d5HPkWXdIL8Jn0 YelXE+5HtiaCbtpGa9WH+Hzo5esQmGVV/eX1s+IXT0G977DX4B/ATgkKI4HYbbMhaox56K80ApT XvFsXdqkGbdgDtPLdd/RQhtr2fxcY2mJBbPqWh7MtpM5aepkn0cG/D/14OKcrI911U8SbHl8fXJ d+y0yWnRY3GHMGCG5CfqdAZq6SMJWe7sdVdhY2kNf7jkuT4i/t/Cp4QThTAN9tE68oXx+qPbBNt 0GgdAiAnKE13xLsrvgCFuRtzhn6ca7K1nHWbsRLPHtj9No5USgaZkY4PE0YGxcILmEH9r99wndN wDXFA X-Google-Smtp-Source: AGHT+IEDu/d0gvLMPkfg382ZhcCdbDKZbFxmgqE3AqPSqBv9agEnIVcL4Kq6GKfMPiLzVnBd6My2XA== X-Received: by 2002:a17:903:24f:b0:235:ea29:28e9 with SMTP id d9443c01a7336-2366b3c35b0mr200531685ad.38.1750148416513; Tue, 17 Jun 2025 01:20:16 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:24a1:2596:1651:13d8]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365de781f7sm74598885ad.110.2025.06.17.01.20.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 01:20:16 -0700 (PDT) From: Chen-Yu Tsai To: Matthias Brugger , AngeloGioacchino Del Regno , Dmitry Torokhov Cc: Chen-Yu Tsai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-input@vger.kernel.org, "Rob Herring (Arm)" , Benson Leung Subject: [PATCH v3 3/6] dt-bindings: arm: mediatek: Add MT8186 Squirtle Chromebooks Date: Tue, 17 Jun 2025 16:20:00 +0800 Message-ID: <20250617082004.1653492-4-wenst@chromium.org> X-Mailer: git-send-email 2.50.0.rc2.692.g299adb8693-goog In-Reply-To: <20250617082004.1653492-1-wenst@chromium.org> References: <20250617082004.1653492-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add an entry for the MT8186 based Squirtle Chromebooks, also known as the Acer Chromebook Spin 311 (R724T). The device is a 2-in-1 convertible. Acked-by: Rob Herring (Arm) Reviewed-by: Benson Leung Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Chen-Yu Tsai --- Changes since v1: - Added Rob's ack --- Documentation/devicetree/bindings/arm/mediatek.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Document= ation/devicetree/bindings/arm/mediatek.yaml index 2032b0b64ba7..a4d9c72d10c4 100644 --- a/Documentation/devicetree/bindings/arm/mediatek.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml @@ -302,6 +302,10 @@ properties: - const: google,steelix-sku196608 - const: google,steelix - const: mediatek,mt8186 + - description: Google Squirtle (Acer Chromebook Spin 311 (R724T) + items: + - const: google,squirtle + - const: mediatek,mt8186 - description: Google Starmie (ASUS Chromebook Enterprise CM30 (CM30= 01)) items: - const: google,starmie-sku0 --=20 2.50.0.rc2.692.g299adb8693-goog From nobody Fri Oct 10 09:48:04 2025 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F895295528 for ; Tue, 17 Jun 2025 08:20:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750148421; cv=none; b=D4uxSOhZlIZKkDrvo90ewkgRPZgd6uG/hGLg10y9Ca1UcsPqEK3lHpsHKm2keEAdkIrfiAKOnhW6NwLHI9KZ56j/KRGA8dAK0KcWGWN5mqFSFqama4pe0Mz0wJ/IQgCzptmyDByvR7uxYIYgrQZMmry5YBT9oGjXijO0U89rKY4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750148421; c=relaxed/simple; bh=oBHXVLfPUMNfuLYLhWWLUgYUX4yzCGGF3ElVjcq/IvQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tb68xLb0e/Vm5l8ZJN/Z0ob2UoK8Y3iN6iuCmyedTM6Q5yfALHpwUMUgLV9g2nJ9UkWixjHlrZ8yPbQtTGcf2sP20AqICbgRH+B8kx994+RwvuakhJImwXOODVw2SYEjiAZze1MamALTQvynzGjr7+/snNv4qkraFstXJ4yboSE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=iqH7AOxL; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="iqH7AOxL" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-236192f8770so37433885ad.0 for ; Tue, 17 Jun 2025 01:20:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1750148419; x=1750753219; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vLfwvnKqf7flG1w1FJwQLt+8yXkZ/9IUG75s/1+ddU0=; b=iqH7AOxL7rK9x2UR5zCInQMw8iDB9vPxWOHkjgqvZ5EQmEC5bsr5V87wRSaENmpvXA kN2sBl5wNb313noKZKTtFPTVmzdmLoY+xRUS3/3NIxBTbqa3qhB3Efte7Vv6hbLNW8O+ VZi12NS5YGlKwMXnW3j/koBJ0wEJIuIeARJ6U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750148419; x=1750753219; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vLfwvnKqf7flG1w1FJwQLt+8yXkZ/9IUG75s/1+ddU0=; b=YgF7WnQeHn20ul3TRXXop0r1kzV/+qeDGbZayYapE/nuY+JZFMArJyDAvfA+xj1KO4 Ao8o5TcQsp5DVluVtJCEjbxp/DUKrdP0mTIuu5U7WvyIMtCmdXNLZ96lr3Sf4XekxdFy 1fDTB3LoI+IwlYgZK10I4NGgjS+xwK5PjsAkMFL7NR0sUFTJB9KRFlvq/XrEJZId/2Ns tIkpKWEQt7YVVr7HUe3hAQegaKSck9LiOUtz72gDUSuoF3804teYmmaInJGuPFgeure5 iovA1X5L2sHxoY0OfzfisNPTIZRPAM/ztUdisgCDh+VHr0fxwxpb0czi308oEmfj7ony SVDQ== X-Forwarded-Encrypted: i=1; AJvYcCXcJpjZkl/DzVVa0Nfsm+oaovHHPPo++/Q08Hxv5PO4YApLsrqcqH9iiGG9jBbrbD5ep2Nzl1Xy0rpvLU4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/PHfdQk3m1kyYNRx4bovQwIVI5sz6bt3+gnW1YXuTQ1ifrSmb aCWVczS4fiT0eu+DsyiQz9q+iScMVMh66spoaFg52LH57IQ8tRM8WJ3QINGUlv4hLg== X-Gm-Gg: ASbGnctHL3nSSMUvED6g3Ko2cwBxIgJz7KaAmxc2d2j4V2XCv2fVyFizUwN4rXyiDPc vEne2Tmk/INyizGBqz21p6RgxeXUrTP3jhrCgjpjVs93H/fFT3UtzS1RI7xr3cs/ECMsBO/C5DO Y9+dfRQzKAPINHiYxloPEtSnOEOZ8UDKRF6po5LJxo2Vz77n12nNELTuUB3wOjP3rkEN4spoEBw Lro1j8aPHT8LAwRcoNCwa/0KMcpkeq/1mfzIApvExmkPPwsFkEzBGOuD/+q88/bPznSMC/O56AI 8FyY3TtWjGxV1ayDzT7sPFSQscGNKC7SsSIZst/jV3De3Dbs9MTgcK5OkDSylD7uwmRK2sWQ/f7 DlcZ/ X-Google-Smtp-Source: AGHT+IEdEae9jR3M9Ile50GhlK5a+mZddJwAjCXfQi04qoA/3oENN3QsRc5nWKd11gVEcOZh5+alGQ== X-Received: by 2002:a17:902:d4d0:b0:236:15b7:62e3 with SMTP id d9443c01a7336-2366ae00e3fmr181507135ad.9.1750148418807; Tue, 17 Jun 2025 01:20:18 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:24a1:2596:1651:13d8]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365de781f7sm74598885ad.110.2025.06.17.01.20.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 01:20:18 -0700 (PDT) From: Chen-Yu Tsai To: Matthias Brugger , AngeloGioacchino Del Regno , Dmitry Torokhov Cc: Chen-Yu Tsai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-input@vger.kernel.org, stable+noautosel@kernel.org Subject: [PATCH v3 4/6] arm64: dts: mediatek: mt8186-steelix: Mark second source components for probing Date: Tue, 17 Jun 2025 16:20:01 +0800 Message-ID: <20250617082004.1653492-5-wenst@chromium.org> X-Mailer: git-send-email 2.50.0.rc2.692.g299adb8693-goog In-Reply-To: <20250617082004.1653492-1-wenst@chromium.org> References: <20250617082004.1653492-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Steelix design has two possible trackpad component sources. Currently they are all marked as available, along with having workarounds for shared pinctrl muxing and GPIOs. Instead, mark them all as "fail-needs-probe" and have the implementation try to probe which one is present. Also remove the shared resource workaround by moving the pinctrl entry for the trackpad interrupt line back into the individual trackpad nodes. Cc: stable+noautosel@kernel.org # Needs accompanying new driver to work Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Chen-Yu Tsai --- .../boot/dts/mediatek/mt8186-corsola-steelix.dtsi | 7 +++++++ .../mediatek/mt8186-corsola-tentacool-sku327683.dts | 2 ++ .../mediatek/mt8186-corsola-tentacruel-sku262148.dts | 2 ++ arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi | 10 ++++------ 4 files changed, 15 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-steelix.dtsi b/arc= h/arm64/boot/dts/mediatek/mt8186-corsola-steelix.dtsi index e74e886a00cb..822a177e7c19 100644 --- a/arch/arm64/boot/dts/mediatek/mt8186-corsola-steelix.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-steelix.dtsi @@ -123,8 +123,11 @@ trackpad@2c { reg =3D <0x2c>; hid-descr-addr =3D <0x20>; interrupts-extended =3D <&pio 11 IRQ_TYPE_LEVEL_LOW>; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&trackpad_pin>; vdd-supply =3D <&pp3300_s3>; wakeup-source; + status =3D "fail-needs-probe"; }; }; =20 @@ -197,3 +200,7 @@ pins-vreg-en { }; }; }; + +&trackpad { + status =3D "fail-needs-probe"; +}; diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-tentacool-sku32768= 3.dts b/arch/arm64/boot/dts/mediatek/mt8186-corsola-tentacool-sku327683.dts index c3ae6f9616c8..4dbf2cb73a81 100644 --- a/arch/arm64/boot/dts/mediatek/mt8186-corsola-tentacool-sku327683.dts +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-tentacool-sku327683.dts @@ -17,6 +17,8 @@ trackpad@15 { compatible =3D "hid-over-i2c"; reg =3D <0x15>; interrupts-extended =3D <&pio 11 IRQ_TYPE_LEVEL_LOW>; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&trackpad_pin>; hid-descr-addr =3D <0x0001>; vdd-supply =3D <&pp3300_s3>; wakeup-source; diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-tentacruel-sku2621= 48.dts b/arch/arm64/boot/dts/mediatek/mt8186-corsola-tentacruel-sku262148.d= ts index 447b57b12b41..ee5bc2cd9e9f 100644 --- a/arch/arm64/boot/dts/mediatek/mt8186-corsola-tentacruel-sku262148.dts +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-tentacruel-sku262148.dts @@ -19,6 +19,8 @@ trackpad@15 { compatible =3D "hid-over-i2c"; reg =3D <0x15>; interrupts-extended =3D <&pio 11 IRQ_TYPE_LEVEL_LOW>; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&trackpad_pin>; hid-descr-addr =3D <0x0001>; vdd-supply =3D <&pp3300_s3>; wakeup-source; diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi b/arch/arm64/= boot/dts/mediatek/mt8186-corsola.dtsi index 18cfc99cfa3c..ff20376a44d7 100644 --- a/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi @@ -398,19 +398,17 @@ &i2c1 { =20 &i2c2 { pinctrl-names =3D "default"; - /* - * Trackpad pin put here to work around second source components - * sharing the pinmux in steelix designs. - */ - pinctrl-0 =3D <&i2c2_pins>, <&trackpad_pin>; + pinctrl-0 =3D <&i2c2_pins>; clock-frequency =3D <400000>; i2c-scl-internal-delay-ns =3D <10000>; status =3D "okay"; =20 - trackpad@15 { + trackpad: trackpad@15 { compatible =3D "elan,ekth3000"; reg =3D <0x15>; interrupts-extended =3D <&pio 11 IRQ_TYPE_LEVEL_LOW>; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&trackpad_pin>; vcc-supply =3D <&pp3300_s3>; wakeup-source; }; --=20 2.50.0.rc2.692.g299adb8693-goog From nobody Fri Oct 10 09:48:04 2025 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C978295DA6 for ; Tue, 17 Jun 2025 08:20:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750148423; cv=none; b=iLtK3OFIDUZwBpnmkTFu/OGEQsU9qYX7kCplnxxK/B9moFOseicIaNOU+ke/+XHdjBer6jLSAi7WWJytCY7zAPMU316NdDvsjRvbpyWyQNvK6uLSPXl0O5t/6YL1c9GG85A3AkTRBPJnRGVHK8czAwuruBPG8fToMk8eBF/F5sQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750148423; c=relaxed/simple; bh=qjRr++3nK/S0s+lP3ALUUbzeqRmkxOyEdtHPJW9G1pI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SLPdw6S/zZkqCVb/2VWp8F//ew8b3Aqwfq0xJOz8/aC7uR0eOr0xq5cKs3dTWO+2BLW7RUzO6kzTsdmasUtRJC1LbIO5I6i81I0sbo2n4gxI4kIugS+elD5ymJE0P9JHqm8D7TQ6kgqZM4HYFV+YuwJyqaQWlLeZVFWV5rtSc2c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=eixLJDLF; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="eixLJDLF" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-235d6de331fso65672435ad.3 for ; Tue, 17 Jun 2025 01:20:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1750148421; x=1750753221; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J2ul8xxfJRC/IslU3NO7LvIavTukETIYjBPpB2s1Bks=; b=eixLJDLFtLfEu6BgIlsNUFus2iT+UGTyHiyLmAiFhXvY9zT2Srpx8VZxW+QaIBD3nc LV9/0vyzNhsNgtaXYNFnbd4qpeqHN7+G6Y3bylL+OOvZR0ZYyFdvJHNtgveM8VwLy0xb YApCNS0WuCLew21G0jpeCqn5hlylKa5viI5bY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750148421; x=1750753221; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J2ul8xxfJRC/IslU3NO7LvIavTukETIYjBPpB2s1Bks=; b=nGJln1RatQo7yJqG7pckbAUdFtF0UuNwvSTbQVlHO8hLt7aSyQbRGO/8DJ9BvvjzJb cqpf05dZKGB3TaC9DD72sV1cvl902yFMkfRcRje3MRlgyvk5nw5UK9zoj5cDajb0F9u9 AVm25ZOAXMQ0SdVrAvzZpx4kQtLuR17g8+av43m5+TMmICdtbObb9SswdVYE8/hxmESP wVyz716KHbgh3qKpRqNgQy44MCr4QQW2vVYXnGpGgs80UmP+tS3MSV1X8IBLmIW+I9z2 KGZDZWRyqi0fou6P3KN83JTWU5c5ISzlms77MlBw7lGpdCUcxvhnrOSteippMTOqutkl n6ow== X-Forwarded-Encrypted: i=1; AJvYcCX4rUoBtiJB1Z6oVtOwHGPXvHfP6XYW9SKXCrQyx8geAGn4HH93u3dqO1gfFNYniLQ2fn8aLhrK2ddqVak=@vger.kernel.org X-Gm-Message-State: AOJu0Yxa+SVtBA2ohiOaeYFB+13+dvmht5UBDuKn512NWKLQ5higmZy3 IgMs0rWIVJuNQsJae4HVt3E0hp1W04W/cygwN38hmLCbmMRbykVrVH7uMhx9O9KxhQ== X-Gm-Gg: ASbGncsrac34PWRy0Z1PE+gk1+ntqRhYuyjnWlqJku2d8XeVE71ltEhfP6wUSfN2mbr A8gKjIFFVt8PeAM9LlnsAICZpAYkx5FjFlntd0v3dzJh/8nsKQ/3tXCLrTyVvk5rzr2NwwnmHgk XkBAVrV6h5w1QqTkWQjLclVkv42Bzvxf26jr5xaU6zhhVT/Wh0KLEdllOMgvQFG1nhAK625jhm3 /GylHj4frE9PK7rjHgtsLJSGGwc+s9GzITpCax3MRPebxiFnRDxvMxnTBQMmP2WMtg13I9LftrI UCBZ4zbpUa7VS0tEdNqh/DKRGKPrI7qEtBWy7UpGF0oFGxM1A5gUgCGKGiEk7Fq1dhcJ9X3L2/J gNj98 X-Google-Smtp-Source: AGHT+IEY70uZwkZ9fnRIDDmKpg9uBUC73hKP0ryT3ds2gfv9hOkjBFwKd6TZX/WRDjwEzvut9oH02w== X-Received: by 2002:a17:902:da85:b0:235:ec11:f0ee with SMTP id d9443c01a7336-2366affb250mr198366645ad.14.1750148421026; Tue, 17 Jun 2025 01:20:21 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:24a1:2596:1651:13d8]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365de781f7sm74598885ad.110.2025.06.17.01.20.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 01:20:20 -0700 (PDT) From: Chen-Yu Tsai To: Matthias Brugger , AngeloGioacchino Del Regno , Dmitry Torokhov Cc: Chen-Yu Tsai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v3 5/6] arm64: dts: mediatek: mt8186: Merge Voltorb device trees Date: Tue, 17 Jun 2025 16:20:02 +0800 Message-ID: <20250617082004.1653492-6-wenst@chromium.org> X-Mailer: git-send-email 2.50.0.rc2.692.g299adb8693-goog In-Reply-To: <20250617082004.1653492-1-wenst@chromium.org> References: <20250617082004.1653492-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There are only two different SKUs of Voltorb, and the only difference between them is whether a touchscreen is present or not. This can be detected by a simple I2C transfer to the address, instead of having separate device trees. Merge the two device trees together and simplify the compatible string list. The dtsi is still kept separate since there is an incoming device that shares the same design, but with slightly difference components. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Chen-Yu Tsai --- arch/arm64/boot/dts/mediatek/Makefile | 3 +-- .../mediatek/mt8186-corsola-voltorb-sku589824.dts | 13 ------------- ...orb-sku589825.dts =3D> mt8186-corsola-voltorb.dts} | 5 ++--- 3 files changed, 3 insertions(+), 18 deletions(-) delete mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb-sku= 589824.dts rename arch/arm64/boot/dts/mediatek/{mt8186-corsola-voltorb-sku589825.dts = =3D> mt8186-corsola-voltorb.dts} (76%) diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/me= diatek/Makefile index f68865d06edd..a8b8796276aa 100644 --- a/arch/arm64/boot/dts/mediatek/Makefile +++ b/arch/arm64/boot/dts/mediatek/Makefile @@ -76,8 +76,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8186-corsola-tentacool= -sku327681.dtb dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8186-corsola-tentacool-sku327683.dtb dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8186-corsola-tentacruel-sku262144.dtb dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8186-corsola-tentacruel-sku262148.dtb -dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8186-corsola-voltorb-sku589824.dtb -dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8186-corsola-voltorb-sku589825.dtb +dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8186-corsola-voltorb.dtb dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8186-evb.dtb dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8188-evb.dtb dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8188-geralt-ciri-sku0.dtb diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb-sku589824.= dts b/arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb-sku589824.dts deleted file mode 100644 index d16834eec87a..000000000000 --- a/arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb-sku589824.dts +++ /dev/null @@ -1,13 +0,0 @@ -// SPDX-License-Identifier: (GPL-2.0 OR MIT) -/* - * Copyright 2022 Google LLC - */ - -/dts-v1/; -#include "mt8186-corsola-voltorb.dtsi" - -/ { - model =3D "Google Voltorb sku589824 board"; - compatible =3D "google,voltorb-sku589824", "google,voltorb", - "mediatek,mt8186"; -}; diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb-sku589825.= dts b/arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb.dts similarity index 76% rename from arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb-sku589825.d= ts rename to arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb.dts index 45e57f7706cc..cc805408a8b7 100644 --- a/arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb-sku589825.dts +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-voltorb.dts @@ -7,9 +7,8 @@ #include "mt8186-corsola-voltorb.dtsi" =20 / { - model =3D "Google Voltorb sku589825 board"; - compatible =3D "google,voltorb-sku589825", "google,voltorb", - "mediatek,mt8186"; + model =3D "Google Voltorb board"; + compatible =3D "google,voltorb", "mediatek,mt8186"; }; =20 &i2c1 { --=20 2.50.0.rc2.692.g299adb8693-goog From nobody Fri Oct 10 09:48:04 2025 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D5B029615C for ; Tue, 17 Jun 2025 08:20:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750148425; cv=none; b=AcrI8TACi625BdIxcWGZWK/ZVe9I8Jnms2YsjPoZNWx3c1IZm6Xn5V/y0YrPg1gWkqvXMi/GemIhaKyXM5VklWbNZUTZLuRDKO0Y6R5WWCd1chETMPuC/U9F01m1tKUzJC9YIHSNIP0DHXpErQiLBsfRRRvCgZFyMESpQJF9ozE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750148425; c=relaxed/simple; bh=8yYHhsk6aMkF+7LDvlU62jXCOJIeWXFnbuZRr/rWNfI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oiTbkj1NhwYoU8qo4N0hpjLgbgQyD1a+DinurZBIxAqFN/pIF/64g9QO3r79DODAxJ9hQ/tOeqpCW6jq0OxmrLPNPL2SiGyoq0JFWAjCZePY11WyVZHfTqsC7e1iHTWJZTSGhbvJEKpQ2KQTXBaztrYnhVq/pRSLDO4Amk4gxh8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=W9+d0LI8; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="W9+d0LI8" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2351227b098so44284955ad.2 for ; Tue, 17 Jun 2025 01:20:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1750148423; x=1750753223; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=t0zl5UgUMJioINXEhfKw/OPFCjl4142IWY9RjIGoGFw=; b=W9+d0LI8+UdMHmzRSI819lrmhq8Z/1urzXKx/QhCCgI5Kr73XTflATW40xQRb7pR7r 8Wge0OBuNquzzBLYDm/fmJH75fwSDY3ijAZnTtaRr4b6MxSDqd1FyfXyGTSplLjDcp8/ HkVpmaTvORVcevstAv2mBshgvutS2d1jGzJ4g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750148423; x=1750753223; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t0zl5UgUMJioINXEhfKw/OPFCjl4142IWY9RjIGoGFw=; b=tUzJ7Dblg1brK+gNZptXKavdjnc7huGOEGQBezF0Musn9Fixr9cNaG6U8hgK+Rfc74 iTFJHegTlKOAMkrU8ninjpTUFAM+LtUSdLVdtIg0c81Is5RTlK630Esk6tw8DToxQdHA 1O2/9SfRnn2axRxu6H3f8o7odd9eGsF7SsCxM14nzaEmJfQsrV4hHOfRhcnTiv1HvlyL zaWFALh6L3qyR5n+PM6E1OehMypdheD0kwDaSfsHFiy9YdHCyhcFExscjzl5Bw77A/xg cSiNEIAHYdoJE+I1nfxsAkReIp40KKIw3VZtaYv99+VpePhKvdj11icBEPFVA4kzmMqC Mf7Q== X-Forwarded-Encrypted: i=1; AJvYcCWZVvscYTTbCuIfKJJs08MDLr2rEjbrrHP4RC2eA5MsezHMUqzFMugMkKCNdp+h0wB3DA4knxHkePRA2Q4=@vger.kernel.org X-Gm-Message-State: AOJu0YwHidw6hpZ8Z57iEIZldemzSak8walh9pKMtbfqu21q0Dtcmwhh VIRRDb2p/vX0mv+zJUgOaT+poBS8IbInVOe8cWiRpfpGVP1Ij+QeX2AQdal7WMGFvw== X-Gm-Gg: ASbGncvVGy3C+oWqZA1TMbTSJv8Kho07yFnaMvhSCaFf9rRyClkLIDcx4vtI3XOsnWr 7wJxxcEhvkYsg/It4ifp+w4adKeAsJYiHNpjj6ElFgk9X9IYF70viBLOUP6o2RN6BiPZCyLendv cpoXALSx8u2A6D6pds+ci/O9qwmHguSMu1e3WEzmvADSMeukHbzsVL/4tqmHHeMv+RFI7k4dlso sz8NWsxAWGWVV6a/aIK495reoqAFPFpSjNCRWJCSF0m2zHtTYsu/tS7TdhSjvHh1jA3cqcFgvcN WRJoPpapu79o7aWWOlKDqXJXei9Dl7diWspP9CW25iUX3h8WYMP5HOXw0Eh84xKbp9VZSCY8gpg AiiSF X-Google-Smtp-Source: AGHT+IF4kxUCNX955eBUeMtmUp09tZHq5eVY7way6VVQf06qYS7+0eKNuGC1EFb0EH+rMHbB8Kt5lw== X-Received: by 2002:a17:903:440f:b0:235:60e:3704 with SMTP id d9443c01a7336-2366b32ccafmr198804545ad.12.1750148423221; Tue, 17 Jun 2025 01:20:23 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:24a1:2596:1651:13d8]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365de781f7sm74598885ad.110.2025.06.17.01.20.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 01:20:22 -0700 (PDT) From: Chen-Yu Tsai To: Matthias Brugger , AngeloGioacchino Del Regno , Dmitry Torokhov Cc: Chen-Yu Tsai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH v3 6/6] arm64: dts: mediatek: mt8186: Add Squirtle Chromebooks Date: Tue, 17 Jun 2025 16:20:03 +0800 Message-ID: <20250617082004.1653492-7-wenst@chromium.org> X-Mailer: git-send-email 2.50.0.rc2.692.g299adb8693-goog In-Reply-To: <20250617082004.1653492-1-wenst@chromium.org> References: <20250617082004.1653492-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a device tree for the MT8186 based Squirtle Chromebooks, also known as the Acer Chromebook Spin 311 (R724T). The device is a 2-in-1 convertible. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Chen-Yu Tsai --- arch/arm64/boot/dts/mediatek/Makefile | 1 + .../dts/mediatek/mt8186-corsola-squirtle.dts | 107 ++++++++++++++++++ .../dts/mediatek/mt8186-corsola-steelix.dtsi | 2 +- 3 files changed, 109 insertions(+), 1 deletion(-) create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-squirtle.dts diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/me= diatek/Makefile index a8b8796276aa..a4df4c21399e 100644 --- a/arch/arm64/boot/dts/mediatek/Makefile +++ b/arch/arm64/boot/dts/mediatek/Makefile @@ -68,6 +68,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8186-corsola-magneton-= sku393218.dtb dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8186-corsola-ponyta-sku0.dtb dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8186-corsola-ponyta-sku1.dtb dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8186-corsola-rusty-sku196608.dtb +dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8186-corsola-squirtle.dtb dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8186-corsola-starmie-sku0.dtb dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8186-corsola-starmie-sku1.dtb dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt8186-corsola-steelix-sku131072.dtb diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-squirtle.dts b/arc= h/arm64/boot/dts/mediatek/mt8186-corsola-squirtle.dts new file mode 100644 index 000000000000..f721ad4e5c97 --- /dev/null +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-squirtle.dts @@ -0,0 +1,107 @@ +// SPDX-License-Identifier: (GPL-2.0 OR MIT) +/* + * Copyright 2024 Google LLC + */ + +/dts-v1/; +#include "mt8186-corsola-voltorb.dtsi" + +/ { + model =3D "Google squirtle board"; + compatible =3D "google,squirtle", "mediatek,mt8186"; + chassis-type =3D "convertible"; +}; + +&i2c1 { + touchscreen@10 { + compatible =3D "elan,ekth6915"; + reg =3D <0x10>; + interrupts-extended =3D <&pio 12 IRQ_TYPE_LEVEL_LOW>; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&touchscreen_pins>; + reset-gpios =3D <&pio 60 GPIO_ACTIVE_LOW>; + vcc33-supply =3D <&pp3300_s3>; + status =3D "fail-needs-probe"; + }; + + touchscreen@16 { + compatible =3D "elan,ekth8d18", "elan,ekth6a12nay"; + reg =3D <0x16>; + interrupts-extended =3D <&pio 12 IRQ_TYPE_LEVEL_LOW>; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&touchscreen_pins>; + reset-gpios =3D <&pio 60 GPIO_ACTIVE_LOW>; + vcc33-supply =3D <&pp3300_s3>; + status =3D "fail-needs-probe"; + }; +}; + +&i2c2 { + trackpad@68 { + compatible =3D "hid-over-i2c"; + reg =3D <0x68>; + hid-descr-addr =3D <0x20>; + interrupts-extended =3D <&pio 11 IRQ_TYPE_LEVEL_LOW>; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&trackpad_pin>; + vdd-supply =3D <&pp3300_s3>; + wakeup-source; + status =3D "fail-needs-probe"; + }; +}; + +&i2c5 { + clock-frequency =3D <400000>; + + /delete-node/ codec@1a; + + rt5650: codec@1a { + compatible =3D "realtek,rt5650"; + reg =3D <0x1a>; + interrupts-extended =3D <&pio 17 IRQ_TYPE_EDGE_BOTH>; + avdd-supply =3D <&mt6366_vio18_reg>; + cpvdd-supply =3D <&mt6366_vio18_reg>; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&speaker_codec_pins_default>; + cbj-sleeve-gpios =3D <&pio 150 GPIO_ACTIVE_HIGH>; + #sound-dai-cells =3D <0>; + realtek,dmic1-data-pin =3D <2>; + realtek,jd-mode =3D <2>; + }; +}; + +&sound { + compatible =3D "mediatek,mt8186-mt6366-rt5650-sound"; + model =3D "mt8186_rt5650"; + + audio-routing =3D + "Headphone", "HPOL", + "Headphone", "HPOR", + "HDMI1", "TX"; + + hs-playback-dai-link { + codec { + sound-dai =3D <&rt5650>; + }; + }; + + hs-capture-dai-link { + codec { + sound-dai =3D <&rt5650>; + }; + }; + + spk-hdmi-playback-dai-link { + codec { + sound-dai =3D <&it6505dptx>; + }; + }; +}; + +&speaker_codec { + status =3D "disabled"; +}; + +&trackpad_steelix { + status =3D "disabled"; +}; diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-steelix.dtsi b/arc= h/arm64/boot/dts/mediatek/mt8186-corsola-steelix.dtsi index 822a177e7c19..8a196dc9a96b 100644 --- a/arch/arm64/boot/dts/mediatek/mt8186-corsola-steelix.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-steelix.dtsi @@ -118,7 +118,7 @@ &i2c2 { i2c-scl-internal-delay-ns =3D <22000>; =20 /* second source component */ - trackpad@2c { + trackpad_steelix: trackpad@2c { compatible =3D "hid-over-i2c"; reg =3D <0x2c>; hid-descr-addr =3D <0x20>; --=20 2.50.0.rc2.692.g299adb8693-goog