From nobody Fri Oct 10 13:58:53 2025 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50C512DE1F2 for ; Tue, 17 Jun 2025 12:24:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750163091; cv=none; b=uXo6P4O8pPKknYBgALquvjHd/MMH8IQK5aYO6c2tsRmf1irEwsYtCvr6jcPtqzbY2748v55hon8auxgbOxU/ce+nIshhzaK0oFBFiX7/27pYWc94q+gycCg7Yd3HlKbO8/o9hmVzIQiuqL6USNsG1rCZGI7QfqngJ1UsjUdDnqM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750163091; c=relaxed/simple; bh=J4/swX60dxFNnGyRxMTrvcRjJzp/EsyWsznOiUYARZc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dyH4kQ7R8e8KQZ+mjMJHtEq5Y7HvfsGYHRu8urtLkfRrzsz9FUqqaWOtj0KyJZ8DvqtfEvGCpjINsN6ATqX2oRTOe7PL+2e9quGYiz6w+qNJ8exgxTXsC6JtB4BKCQysOZKDY1370wZsMNjAhp3jd9G7vW63/aMls1J+8b2Zf98= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=jUlnkfa1; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="jUlnkfa1" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-453398e90e9so30310705e9.1 for ; Tue, 17 Jun 2025 05:24:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750163087; x=1750767887; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=j3425DJ9smVNqtgfiewFDDuDZUIYNH7UVu89t2el+0A=; b=jUlnkfa1GMep9Gl/vtPRK1MlIvwrtzdFlHtzYS/xG7G7H+tef1OByINB8vV1dF/Xj0 mPzWF3NOuAHZqAS0d0OTAmfmkAWIlyH/jPieXHQKGxwiTeEMYOX4JAjghBZZvHnH1UoR AWl8CC/WKl4GqzmSP6Y+GcP/PLyoHzcORsKOH8TsaDovfH67hD5Ct3Nk8YXY9Wi/iS27 CZkfXFDG28j6BjkFT6eB+zpSJhaY+91/sOI5ilZ3QC26xEmTaKUQXdvCxA4AtaZAhYSn EC9oNXj3KpdZPf96UXhbjVHBfI0HA9FB5U4y5ppf4aKT5KijRHPK0Jidp0rEIzAhEd+S oSOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750163087; x=1750767887; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j3425DJ9smVNqtgfiewFDDuDZUIYNH7UVu89t2el+0A=; b=Rp4vLoNuYHLO1yQCFDe10KAmf3oFDrBqKw1cSKop0Tput93OnbMFQ4gfyACA1QugRi F2QUdYIqhJ73KWmmHmb7Nk3DZpBfpb9dTk4/a7g8xJJjTWY49oA8+Mn6Pz9TNGAI1UZF gbkX8JNrFx+2FUjGEB8l0UxAlLvF+apYdAoruI9lc5c+lN25T7oHirbaGp62ox7JOYbl P34EjVk1/QDIkIe+kUhWux82EmlIKWjqlhq88vbAlVzP2k0P3NRppcBb0uo0QjLO0OV3 W0Gb4aA4vr7Msf2IdE29z099lE3QGYg0wtBc6ppI4gMRSgKEU215jQWbO6kjwTrqANzG daAg== X-Forwarded-Encrypted: i=1; AJvYcCWqBmvRKtqENtgJESYKgjdxbcwbGDtG7Db99MV2SCLLNzy4I+PsoJv1liuxXGAa/C7toXw2w+rKpXxuSjU=@vger.kernel.org X-Gm-Message-State: AOJu0YwdQrYqMao2JNbHKH175rnGdmD8i+PdCsssx9TJHty+G0Bf9v9E psEn5QlnXPHEHhQkSxXH5XdAAzAdALwbnnIkCsIqnxB0nsDi5k627nVIGmpI1p1l+wWkv/eWJ1Z yPaUybbg= X-Gm-Gg: ASbGnctFrglG1u6Xzbgrn8MupNGe5Taf3YseGb7lHyDSOaTaVwQLSLRfOryT8BfWaU8 g+MMq3UB3ihmWJPNcFiYbDkj/KkSjZ95ytm9TDuBzuF9TAp8IZfcTbYIvkiktHC+3do/ENsF40y WiVsWxG+b+Cex6G763YThJiwe1JjbvlUjvF1vZOjmnwMgHX/ICaEa6MrysO5fiLI50O4WVZZlAX tcwMSfCYdzQRD5oP8wlPuu9eH+6c8yOQaTC8CTRMmlHvcGjrpFboHNoGrYZZrofaShFZK146GrS 1H1pVLYrbqQSHGBhL3rM6HADapntkhWvAUYDfbEqEc23Qw+hRs56VxrHKbn6cHKMlEU= X-Google-Smtp-Source: AGHT+IFSaiKVtjNdh8JpqeiVYaqMnisnI6PtZWZir+IMOwFShpzWggv/UUCBrlgK4mkCKC+HFcgJ9w== X-Received: by 2002:a05:600c:3513:b0:453:a95:f086 with SMTP id 5b1f17b1804b1-45343d2c0c4mr106531565e9.12.1750163087329; Tue, 17 Jun 2025 05:24:47 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:90df:ded7:9cbf:4074]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45320562afbsm173816135e9.1.2025.06.17.05.24.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 05:24:46 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 17 Jun 2025 14:24:27 +0200 Subject: [PATCH 05/12] gpio: pmic-eic-sprd: drop unneeded .set() callback Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250617-gpiochip-set-rv-gpio-v1-5-903703881fa2@linaro.org> References: <20250617-gpiochip-set-rv-gpio-v1-0-903703881fa2@linaro.org> In-Reply-To: <20250617-gpiochip-set-rv-gpio-v1-0-903703881fa2@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Orson Zhai , Baolin Wang , Chunyan Zhang , Robert Jarzmik , Heiko Stuebner Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1348; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=U5ElyLmZBGysFJL9KcblCpbMCuSewiTUa3oGkohc5iA=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoUV6HxHcn+27NvQvfcxrQSoAF+rm4EBXSaiw7O jAF5IOHFY6JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaFFehwAKCRARpy6gFHHX ctlqD/4/gbxk99tyQvyLzHrNJeGi24mjwUKkq1j+sQw6ALbBKzoDHmqfnKqIY8OLsCHbUTg8o7H WLpHhDv9MDocmKEc2xnBGqdhca8950X2Yw7bJ14AYGaBSNTk2gbnCqPtgwCxyzlGYRTH2e4qSDT d0Cqe9mnV0B6Rrrt5aNj8rKTVyt/J7X7uPyf5GAKS8TGO6IUfeQrCewVvHCaCo5NV9pJNG6ejEN iQPSSihfNWTzD6SXCjk70tmDN5zhvZDdNYThNj59HSNoqjfynIzS5ktlk6soYs039DHLCVH45NL QT5lHJ8hCpm3bAB3N5Lj6YOARL/YSGhm3r/8VevKOB2pp6aaKrKDSN5WMbqgW2WMo/MuiSEmIsT gLFIvF8uOCFS7LarA2OvuO11JjHzqQvEy19zMNxiiQYBsEQpsuufELBACem2g8XBOK+GKNUyvqT 6MF3nTtT8HvTgNzOJGNQ6y6KlOKhDxOqJmi7ry24bP5A2TOapEP02tSoPwvV3cPcsI2DMzYbPSs epODKf1eCc4YqOEdO88F2YeJssIJEhbYYpsdYD1zTNxub2CPsZ0qfXV4Hq7LgR1gJ+Dt4xWWa9B ZoQi9CaF4e8a6170SQtMrKrtUuDpeBEPSfBGUNIbYbrFnJM6jvj03wxdzhaNOuGLSSRpHY/MCJe g3QUwGjaBa2LvOA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski The lines on this chip are input-only. GPIO core can handle the missing .set() callback so there's no need to implement a dummy here. Drop it. Signed-off-by: Bartosz Golaszewski Reviewed-by: Baolin Wang --- drivers/gpio/gpio-pmic-eic-sprd.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/gpio/gpio-pmic-eic-sprd.c b/drivers/gpio/gpio-pmic-eic= -sprd.c index d9b228bea42eec53ba9d0d0945125f530a22946c..cb015fb5c946748402272391035= 4219e2c98d3c7 100644 --- a/drivers/gpio/gpio-pmic-eic-sprd.c +++ b/drivers/gpio/gpio-pmic-eic-sprd.c @@ -109,12 +109,6 @@ static int sprd_pmic_eic_direction_input(struct gpio_c= hip *chip, return 0; } =20 -static void sprd_pmic_eic_set(struct gpio_chip *chip, unsigned int offset, - int value) -{ - /* EICs are always input, nothing need to do here. */ -} - static int sprd_pmic_eic_set_debounce(struct gpio_chip *chip, unsigned int offset, unsigned int debounce) @@ -351,7 +345,6 @@ static int sprd_pmic_eic_probe(struct platform_device *= pdev) pmic_eic->chip.request =3D sprd_pmic_eic_request; pmic_eic->chip.free =3D sprd_pmic_eic_free; pmic_eic->chip.set_config =3D sprd_pmic_eic_set_config; - pmic_eic->chip.set =3D sprd_pmic_eic_set; pmic_eic->chip.get =3D sprd_pmic_eic_get; pmic_eic->chip.can_sleep =3D true; =20 --=20 2.48.1