From nobody Fri Oct 10 09:48:02 2025 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11B762DE1FD for ; Tue, 17 Jun 2025 12:24:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750163086; cv=none; b=bRGdZ/6BUWpEsCo30y/Zgi5xEYZ52wHF71e2amqQoqv4Ej+9TqQdAwrN+utXfKAKZQhx+i6JeAZxuPSTXdsDNg3HQRpiwKL1xIeNNU7NORGEnNmAYzxn/H3sKOt5xJI2V4fC+PcE4BXsuQVQzppsxCk2LAfHaFvhCfV2rvmuLAI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750163086; c=relaxed/simple; bh=RPhkT3IzDcFi1m3smXl28iMPiZa62xWz+n4q9CIoNU8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fnY4h4wLxnYjKwrnyC2a0ElLHjU3azHXDwOyfqteL/VNafQJnsaI5qWkoTIQvaLK/UZ6JS8vmneCpa3MqOVwY9fCkhXRyyqZjbJ2V0yj5kLn6ZGA01+D+RjlGYyAnbgOUaPPFAAaqruSoSKbRU6mIkM2+vbespImr6ENzPFtQF4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=bdP9rVmK; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="bdP9rVmK" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-43edecbfb46so41871925e9.0 for ; Tue, 17 Jun 2025 05:24:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750163083; x=1750767883; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=UN053MZ+yEo6A92AhgjaJPUWZr1Vpzz6RE1Bqia1tO8=; b=bdP9rVmKlF4I5S9A//E9NTrjwAv4FBeDhMEuO0wyeMpDDQDy9MRrbW1Wk4D2OXQvir eQb41LxRtJ2P9VE+pJ84l4CShwCXYD8Qn4Br7cTAnURuwzvNjQmWqIeq4lAtCj5jkvuJ W63p6OtpMQF8l0XArvOSr9ttIGDbFcm5ATZmycf+Vr5fmkznOLh0q+uHwkCflwPzG2u7 Dc4BzHsNFyjLbPYQY+cuNHjQ7hEpNloca2IqNMdHuNgnsVSeWO9Bg+x2l5bAUS8WKK4G rsTZ7LaOAI3Lcaavt8m9RA9zF2lPdXpD5risvvpe98nD50aXuCTz228kRVN/165+7Iha F0hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750163083; x=1750767883; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UN053MZ+yEo6A92AhgjaJPUWZr1Vpzz6RE1Bqia1tO8=; b=p9nzfrYkAUj4/7OXJzoMpGvko7i+vphKrsUm3f3l5qaGDmhXCNPlk5bEXir7a5TXIO hOAxhImOJ3PnqjaUV7AqjkihSI5LHa+pT+raVor63mxmxjkwWfqHKTLWW+S/ZOZot8eJ plTMVOGvz5MxGk6Uk23Xb/halULs84RWRSSrDQ7mt9HpF33wzSLODnoUjo7n1iiedb7u 5LMifeypcIyXNz/6+7bY100+3NLiwHcW8cHjpfIpPTgrlT5YmoOPkWimg4ebiE7lJ91e s5ihVRNfqa/S0JDPCA8SX45IhBcJKnZj0pffeXuJDPPNpN+iYQP7XcWxBrjyF8y0Zgzx 9tKg== X-Forwarded-Encrypted: i=1; AJvYcCUVsGagHWW9/fZZTdIv+rRwxNuGUMQ3Rk6SVJBE0+Kl26c92VsqnQlBB5UXU6WK2sdqTsuNsUpgFMbByYs=@vger.kernel.org X-Gm-Message-State: AOJu0YwcLUpjiSYBMkQRqXtvKxqARIF2zlWX+0uqbnP+u5malIVl0Mci 1hEUl89KacG6YdKysOehP6rhpFul1TJrfsoNW6j51RGJw74r2EvIpfgESZt3GCDRBs314lrw00j z9nxkq/0= X-Gm-Gg: ASbGncuhoiSw6c0jMBObWdNyfC1jhT5Re5HIDdMVI9gM+9PwcuojVHYYE9vWG5Um14f 7QAWqPjiFanq5t0TpJVc1M7fOReFvTxoAkJBu2W1rhKkHCVL3ZrPsCZhrqMwiIlbC0wKzkdLmmk w1saApzraDEKpUY2abKfVYBy8COw4nz23lBdP66DaD+8OFgKHCACT8DByJtF7VGmt54aN9KcHiD YwvyKZL1m/SHbMkjfUBz2Eg0SGKqdfmsQAWoEWGdvd4Clf3CHD/wzbLOk9koH0zLNa6MwzQ6tnV S0b1zE3sVIKATCZUbGfXvhJIn5yFHsy4XD5yiGaYZNzZWHqk/oH6+FD3rVBm1K7B+2c= X-Google-Smtp-Source: AGHT+IHdDJq3gvA4sfWiaOxd+XFP/XNqtrP+XE6lxG6A2/HHHT+4Da+4G92+pmD+3HshQ5Xg9wkLvg== X-Received: by 2002:a05:600c:37c4:b0:43c:f6c6:578c with SMTP id 5b1f17b1804b1-4533d5a03a9mr141189635e9.15.1750163082843; Tue, 17 Jun 2025 05:24:42 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:90df:ded7:9cbf:4074]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45320562afbsm173816135e9.1.2025.06.17.05.24.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 05:24:42 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 17 Jun 2025 14:24:23 +0200 Subject: [PATCH 01/12] gpio: pca9570: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250617-gpiochip-set-rv-gpio-v1-1-903703881fa2@linaro.org> References: <20250617-gpiochip-set-rv-gpio-v1-0-903703881fa2@linaro.org> In-Reply-To: <20250617-gpiochip-set-rv-gpio-v1-0-903703881fa2@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Orson Zhai , Baolin Wang , Chunyan Zhang , Robert Jarzmik , Heiko Stuebner Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1532; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=t5r7nMPMOl/Fqhu7blFrjnyYOcc5SoneVJWT0UVvyG4=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoUV6GexaPCP0OCCCwFHuQx75j/9CG0GCDLgAZ+ KSrqpESNoeJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaFFehgAKCRARpy6gFHHX crYWD/9ppC5aJkPOyjWUhC/39fpEYawzV1oo4LA3Ztz2IaHRnTre6rmnHt0RWCnXb3Ogft50bJz 3OfxYoBxk7sT23zhDEayJMLa7f+yRxlrGtMkvvbajg7FnK6dG0ZLDivOjPjg+3j6E3Csa63xB2j 8NHdCO9JCcXS993dXW2c3g1qsqyUR9jz8rDcpExWFZ/dpsvD1IhAW1s9pxCuuE6tkO4fK2zT0e/ di9CWR4RhrAK430nIY3rf009lMITmd/RqKVwZqF5Ao7QVyT1xkeE2tyi8+SLYebXQrHJCOGir6z HvkMvSkvjZx58Vh587NJQmVKxXh+hfbpfjoifEL1TAG/u4umxKzvGrtWB/6GM6Ea702rIGaK379 y0A3uyAYwtTOlKyB+AtIdxG2ydQWpo0NXYdH9Yh+RVNveDOALdEVGPqf7USkh/PIEJJRDPpXe0r s3bdRpJem+8LjEB3NEZWVlWEpdPiHVZB8YN+CImGcs2ZDCvS0plVUK0AOTDix+TymPsvXzmJGLR ha7VhjmPrxB8on4mkXhIm89HpjTC2Ifn15yc7tNP8ewrAgJ0CWo1V5xAgKX0hB/oUjIbBWWJDzo TEzXU+kxQqmGT1ktMvoWFMbHuwI2JIJHPv3eMDKPjty/8ZQqsn83VFR6GZ+oAtqFAQzfujICE4J zyK6vI1OeVADF8A== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-pca9570.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-pca9570.c b/drivers/gpio/gpio-pca9570.c index d37ba404936835bca160822ee361604827976e9b..a33246f20fd838a57abeedbbd7e= 58259bf073a86 100644 --- a/drivers/gpio/gpio-pca9570.c +++ b/drivers/gpio/gpio-pca9570.c @@ -88,7 +88,7 @@ static int pca9570_get(struct gpio_chip *chip, unsigned o= ffset) return !!(buffer & BIT(offset)); } =20 -static void pca9570_set(struct gpio_chip *chip, unsigned offset, int value) +static int pca9570_set(struct gpio_chip *chip, unsigned int offset, int va= lue) { struct pca9570 *gpio =3D gpiochip_get_data(chip); u8 buffer; @@ -110,6 +110,7 @@ static void pca9570_set(struct gpio_chip *chip, unsigne= d offset, int value) =20 out: mutex_unlock(&gpio->lock); + return ret; } =20 static int pca9570_probe(struct i2c_client *client) @@ -125,7 +126,7 @@ static int pca9570_probe(struct i2c_client *client) gpio->chip.owner =3D THIS_MODULE; gpio->chip.get_direction =3D pca9570_get_direction; gpio->chip.get =3D pca9570_get; - gpio->chip.set =3D pca9570_set; + gpio->chip.set_rv =3D pca9570_set; gpio->chip.base =3D -1; gpio->chip_data =3D device_get_match_data(&client->dev); gpio->chip.ngpio =3D gpio->chip_data->ngpio; --=20 2.48.1 From nobody Fri Oct 10 09:48:02 2025 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 035CC23B62C for ; Tue, 17 Jun 2025 12:24:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750163087; cv=none; b=lCbSv1zHSGaX1SHZNHCrpXlOIy3OprXLB2wh1wQULBxqF/UBp3lwiiFfagHb/PCTl7+WcZZB6utD4IebPsqnKXVgJLsgE8CTLPP+IhyfbBQHtFDNwo4He0YK/A5cTmizbpAsbWAakc22h7SzVbZN6XvS589eYVqX/8AZsFU5FK8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750163087; c=relaxed/simple; bh=r8YR0XSxpNQwUjB1snBTCh+aO57h/fzpJl+JXwgznDU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NLfX4Ju322oOYr4VBKlV/eu55VJoEZ6CfYwYuYR73B69d18D7N4VkfaO3fVVDz3GJBRD9x6cOBlgVQAbEMrhoJbS7HP+DAMOJNY5RCrPhfu1ZNzUnD6ObKOjl5UzWXKPYqU/tKnNzGsK7Da7ETsmqwLaGdG/RJLbEFSWHbchOhM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=gEXioIFq; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="gEXioIFq" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-451d41e1ad1so48459165e9.1 for ; Tue, 17 Jun 2025 05:24:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750163084; x=1750767884; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=aoNSIKbOdd485smFmBnHl/Mm0pNj2Y6zx1eXoO1wxPA=; b=gEXioIFq9DT2/5k2J6doqNSlMSseFgijgOteALk5SlzJMWxJ39uSzHEu2IYKCTmGHx UGVGWdHlMILM4gOPSQf8Uo5RVIr4BzivKibWtShBLpOemr2x4jLQD4aJU53Qb3TbKooM Zi+r35beYXPuHpyDgPOVTyRf53Y5eeaYYjg1xuZ20sPhwykH2dmsaYPkYpf5kZ+Kfl1W xI1GF+FnY371Yrtqwcjz9gGTKmkMeUZ85dc062Y7XBNxF3c0BQUJbQJfPLMFLO2xijio Ri+Ko6/FpvIBClbQJwDlPEZY6Nk25eH1HGUU8GfjAZspcx0Yp6np1+9qXii2HRQMS7TZ ZjYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750163084; x=1750767884; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aoNSIKbOdd485smFmBnHl/Mm0pNj2Y6zx1eXoO1wxPA=; b=I8mUaGlX/LJD+0gbV7XvquyAel/WODfKxlyn3YpSOj5zrhFQIs2ZgA4Ua/3Dm5R9ot 2dIOM1ILapuIWaCQRd4gErtO25rKueoNqsbqy4KXVZ0hWyXXcfJxjN8UKrM4LgbaBpoO FiRiC4i1bg/1W1vHFGPss0LHqrPvm0uMjta/NQI+T4yGZQM8x/ttG3Y3mbpxBe6yoq3+ lKjf6B566KAlHfaz1F/X5gqhOfv6peILqQj+I+UcFbpTBxgZujkpR1oNjWm4OCo2suv5 6S4U44WuYm2bu/9BSmtqA+pNJY8pyyzkmMHyWLoPQ6ECq85RPOwqPwm8VX2YD7ddWLIV RTeg== X-Forwarded-Encrypted: i=1; AJvYcCVxZGGMQLF0TawnZTZZ80doxHJjWyOE15RfGarHR9KuiODpZzeI9FrgLHNahYyhz6x/FhT25lliVNDQ8Lo=@vger.kernel.org X-Gm-Message-State: AOJu0YzenteeeVRMVU6kgYTZk0yX/5P0YG42U8DWWuP+A2uU1i9hjxEP OyfVGT2KjJk8YgR4ATMEbHxP/wBetdTtDKeBdT1iVzBWwrg4/xMx2f2LLCJXtCuBMjSPKrMcZVt eJw6G6CA= X-Gm-Gg: ASbGncufw6fzWlgNyG2QiKp+88ntmvS/iVd6HXnMWTooYzIYiOStyvKY659c+zCj4uk vvmnCwwMHYhQVE4SWWRytHivJnjcgFo6Or6U0fhGEzCwOxEw6X0S0YIxjUm+ztvyIlLSKn6yTGM 1olbRaHTsBCFDbWj6/MEW4QyaDhgAEByNO9g2y+b1Z02LJDPL/3ZbGVhgL4gII3NPV4bjDa9plN ykCzNolcMPhgh/kLRnFcUfAut5Ed0K6h3ZalOhO75p8omekNZUoc+9kBwFbpTgX4K10T00tx54E UPxFzwgq58tWilEXbCfpWbilUICra6/Fy1LYVANt12c5w+GRoeptgNpO X-Google-Smtp-Source: AGHT+IFjGWRgGD99OMAPMoLYwAIsTODZ+U2Af+jbgXlHRtQDLpU4RqEiIpXtgD7kFvIv8VVNBRGMcQ== X-Received: by 2002:a05:600c:4e87:b0:442:d5dd:5b4b with SMTP id 5b1f17b1804b1-4533cac57efmr142885005e9.31.1750163083958; Tue, 17 Jun 2025 05:24:43 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:90df:ded7:9cbf:4074]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45320562afbsm173816135e9.1.2025.06.17.05.24.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 05:24:43 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 17 Jun 2025 14:24:24 +0200 Subject: [PATCH 02/12] gpio: pcf857x: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250617-gpiochip-set-rv-gpio-v1-2-903703881fa2@linaro.org> References: <20250617-gpiochip-set-rv-gpio-v1-0-903703881fa2@linaro.org> In-Reply-To: <20250617-gpiochip-set-rv-gpio-v1-0-903703881fa2@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Orson Zhai , Baolin Wang , Chunyan Zhang , Robert Jarzmik , Heiko Stuebner Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2108; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=UjdVhHBdj/MT105x/Q2pFxBb2AP6k98PFv96j+C3ycI=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoUV6GFFklv2v6R87MrAXNHZyNzFP4WjIs26eeM jaLuHbEIROJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaFFehgAKCRARpy6gFHHX cp0pD/4jqSNOj2xQtdCVE8aUY/oYvVBdI0smTuI1wV5vjnOYk/XOkXPxvKf8cxCKJepJiLLS75O 9uEpobTggd4GQR20kr2zy6RaQ1C/oR5/3lZ1XIMmdei4517WPUhe04bBOwP66+tx9x2+QCUOfxb OiDQPg7BqqU9Ze4mcCV6OzO2wd20MX85sbGuxWFYNnKNLPiJECCNX0MUGR6ktbXHJbtHmeoT+1S WeKPV3ZTVNqqeEpizUAc0KyDaquEVYil9JFsAr9MbXMwKtT/v95oJEaMoQe38czxMsnTmnhclZR PpVpK2jejmCrdCpG8IS55/a1qyLTuE3SNcfHnxBZeyEeHhStByjQ6V7xLyJlZGeyM20g+oojNAy d5Q9OHc7sWW19ebIZdW1MJtHbpv4FEQ+h4M2lyLVqVMs6G9YagQgkFrJgQI1VhVXqYJu4H5fjoe nBbzp8EnwzOoqu/qNJW8eL4Vov1WkldJYd7Rr0dHWxsESRABq9OEeqRL0MdnMEUJUmtQcsrG/kW f5aKK2U+oh9dXNTgl2ZydapCMP/mB8LSMlIwR4cxuFbdTE+W393h3xmAAcARFBX42BeiJszBJg8 M4B52HDLRDWzhV7N9lrLgjf6FPQNmi4aM8vrs0vDtJLHo3t0dRpXziFICkKDKqTy+7NuyG8sBue U03dII3k8j0I+uA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-pcf857x.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/gpio/gpio-pcf857x.c b/drivers/gpio/gpio-pcf857x.c index 2e5f5d7f886598318b753304e7e0efca54ff8b69..a042036803336439d8e164fcfbd= 0263b0e84f3a4 100644 --- a/drivers/gpio/gpio-pcf857x.c +++ b/drivers/gpio/gpio-pcf857x.c @@ -171,21 +171,24 @@ static int pcf857x_output(struct gpio_chip *chip, uns= igned int offset, int value return status; } =20 -static void pcf857x_set(struct gpio_chip *chip, unsigned int offset, int v= alue) +static int pcf857x_set(struct gpio_chip *chip, unsigned int offset, int va= lue) { - pcf857x_output(chip, offset, value); + return pcf857x_output(chip, offset, value); } =20 -static void pcf857x_set_multiple(struct gpio_chip *chip, unsigned long *ma= sk, - unsigned long *bits) +static int pcf857x_set_multiple(struct gpio_chip *chip, unsigned long *mas= k, + unsigned long *bits) { struct pcf857x *gpio =3D gpiochip_get_data(chip); + int status; =20 mutex_lock(&gpio->lock); gpio->out &=3D ~*mask; gpio->out |=3D *bits & *mask; - gpio->write(gpio->client, gpio->out); + status =3D gpio->write(gpio->client, gpio->out); mutex_unlock(&gpio->lock); + + return status; } =20 /*------------------------------------------------------------------------= -*/ @@ -292,8 +295,8 @@ static int pcf857x_probe(struct i2c_client *client) gpio->chip.owner =3D THIS_MODULE; gpio->chip.get =3D pcf857x_get; gpio->chip.get_multiple =3D pcf857x_get_multiple; - gpio->chip.set =3D pcf857x_set; - gpio->chip.set_multiple =3D pcf857x_set_multiple; + gpio->chip.set_rv =3D pcf857x_set; + gpio->chip.set_multiple_rv =3D pcf857x_set_multiple; gpio->chip.direction_input =3D pcf857x_input; gpio->chip.direction_output =3D pcf857x_output; gpio->chip.ngpio =3D (uintptr_t)i2c_get_match_data(client); --=20 2.48.1 From nobody Fri Oct 10 09:48:02 2025 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC13E2C031D for ; Tue, 17 Jun 2025 12:24:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750163088; cv=none; b=C3mLjDLlSBKTpqv7DbuWMR7QzlKzuuFyBEpA+I65K4ENmtTaf2vbx7MdWGptey+0I+dh5DVyA7gbgDaIUdeNdwL679gU+kzQvh3tdOPIpSkLcKRAHPpN8h2r/xtB3k1Lm5KVsOXrUzb5v5ztXfUzsfTInIuGcPIA1w1rHRZNbTU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750163088; c=relaxed/simple; bh=kEfiCA9+OheiBriw2pdL33nAXF823N9SCYa1haJTgFQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XuDfGz+MvXeHZpLaCWK26qAeZX5Y1vLzBddPPXHejKItFTOklMpEG3Mivtw3mDxXba9XVbqtUvyd0ezlgXxYFdIqaqB5Sy7ceSQviGJTUMZrFCZrPz6jsSz3rqGqhKHmKlxhTLfKmkPXlzVP4sm+k468wvG/Wr2bN/4Z7as4Qi4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=wf+JYzOt; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="wf+JYzOt" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-43edecbfb46so41872215e9.0 for ; Tue, 17 Jun 2025 05:24:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750163085; x=1750767885; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=BunBstoheAwjjbUHp5liz9ofrsXDKVHtZqsL4Aji7Bo=; b=wf+JYzOtVxxK+GraGdBFJUY2egrf6hA8gNx9CwNYQ4bMMlZBibKD5Y9T2XJ/6XomWr ELizPUJb+8OPVyMX8mRfpLuh1iwwnG4iqhJqmkIwZKxNhuB0brJVi/NSWRgxQRrkdELY hn6gu+RQSv0U4wd0+AO4Ki01k1KpdCXYUPcVOS2tMAhlxbdrpqKD0mjMs0umhi+zR0Iv u81JG1z0yRiiGkQk5L6MNu+tfQG1vi1Vpp8gVKvIuSDgwQKh7n3upAGaCCsDXqukxYGr gurlNsLt+IpJwL4La/8GXGntu5vSy3kyHGf7h/QNZYVSmN2zwKrrKLBW5L5N6d6BAgzo QkPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750163085; x=1750767885; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BunBstoheAwjjbUHp5liz9ofrsXDKVHtZqsL4Aji7Bo=; b=rwo0s2XNLcEhB0SDrMY5vpKj6zQqmK/IGjN+/mQBLblhxEgubYddeQY7cmlIJA4H5R n7WN6QJwPx1ZxMHGBv9CINLMh8IYyxkRz0K+D2hCeipjbSMXioJxJ7wzAniqI9UzOIsZ 7AtzWj9WyeFppVnTkuZcRz1acDKTN0LMhG9vRXUDJoxF1Ye5kj0VfDgAXUcL7mQhE4t1 eQXRgV99mKvAW12wv5lUIOGaGgKG0pf1HXZr9d2U3Yw6YdDqvFEtCrZqHCwQpXsjrA7U NX5WQxjg7Y0p+f2y1+jPyKNFLh41TexA4BkDY/9QrA9w3ks3XWcZofTL1Bge81vvgKqF SuIA== X-Forwarded-Encrypted: i=1; AJvYcCU36yROmrqO2Uyg2zWt9b21aKIhvva++Z/ZtIkauE6TTn3Kcl7nCDTAeCdQtqHTpBqYvsaZBnDl48CIi48=@vger.kernel.org X-Gm-Message-State: AOJu0YwGY+2aDGn4nC1PCjpwdNx9uPBrT8A0OU0HE6YV+Bo68xmPObrq wRKGzc3hJQ+MQ8BcoJ1z6mt7YoAtAnB/iHclqoHDEonimCeqpHQxz6IsfpoVX9fGMCrpENn6f8Z WH16oXzQ= X-Gm-Gg: ASbGncv3lVOrAqG7T4joMl7eCLuccbHEr4nQ0tm3puN4ylPiyRkKgI+UwN8h7SMi25i 6qYwSmbhevdL1Yi4lSoOilPIkA36OQXjUpSQ9i6iKBg1wTu9EvHEZsHXWfMDfu4MrcMgTxC/uA9 pFPtlbHVzDtUVuq3FGA27G/XLpMhFuIXqezwwKzfzp8D2akGX3CF2OAjz0xs4fwVddh/CnyzT7d pzbM1r8uE2pKmI+xCC2FBNGmoWd7Dzum0d49ENB9ktp+vF7hewwiKth0bHMo28T5Tu/frR8OEKt Q++8gP0qHPGLMeQi1pVAUE+b3ocHUI1N5Qch9dl5tfVsVH2d0rYG4F5ktoY5VB9I0Bw= X-Google-Smtp-Source: AGHT+IG38n8yT+e1ncHPeSEVdH68o2T3Sec5cbPfOxOX3fgfc6HVuUUwfA/G8YafCEi55IS/XLmI7Q== X-Received: by 2002:a05:600c:b95:b0:450:d012:df85 with SMTP id 5b1f17b1804b1-4534b4d8ad2mr71541235e9.18.1750163084982; Tue, 17 Jun 2025 05:24:44 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:90df:ded7:9cbf:4074]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45320562afbsm173816135e9.1.2025.06.17.05.24.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 05:24:44 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 17 Jun 2025 14:24:25 +0200 Subject: [PATCH 03/12] gpio: pch: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250617-gpiochip-set-rv-gpio-v1-3-903703881fa2@linaro.org> References: <20250617-gpiochip-set-rv-gpio-v1-0-903703881fa2@linaro.org> In-Reply-To: <20250617-gpiochip-set-rv-gpio-v1-0-903703881fa2@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Orson Zhai , Baolin Wang , Chunyan Zhang , Robert Jarzmik , Heiko Stuebner Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1483; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=mZa8mgQmqtI4o68XMiXnsHjV4blkeihaJT265+ul6Aw=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoUV6GBgn584BsrCfQRzkIjI/k7X2K32+hBm8cd O+tckc9Rs+JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaFFehgAKCRARpy6gFHHX cjbdEACbzA8JpfrD7XUVbbPk6TErktnsgMRnasgtasnTq35ZQ7HTTM56J8h/KEe46L725xvuI88 VuGInJdMnPsCIINM2YsdxaBMunDAu3WvbcjoFDvQI0fYBmUpwfKouTrWsAL6gT4R/4PHH+DwaiB X3xZE2T9O1Coo94LvdLCNRg8C8V8QcfPttoO8tkKhDx8TSmOpBm8USV3IWbEwaQtxg61tGSuHrR xqYJGCe9WHkzvi/HN6Jk7z6E4ZXeqDKb19RnFaVjuz8rOMHfsjluKQENenMk2bvC4Cys5xKEuWh U1c+BPAPmK9AeO1byW1GlSYvqhxH2h6/uPs9P3e84RMlESHHR23QrJU388WSaJgIijeFcs4dFYm d7sWvPXNahCRoQZ4foUQbd2FsjPBWi78q8ZdG8rglnJYuetBj/5YGaESAn+Fc7sALIJrbLVgZHU k08mlvs0JGIuVvO+5mNHxROprqmNCR3CvQ/h0PrKzgg+B6j5SC7gDCjqGew481k0A96cYuU+50u 0+1F2SkqTVVjfOSV/czlhcWuv/5MdprAvks21HPS3vRN45BvMDvcr1DaAlkMvslrxVo+n1Kqy44 IAd9NmvSk1D/Yl9Npe3DgTVDHRuQGo4yD2n3P5wGzVXMpo12sFtubyoyJT5k9tn5rTZpd5Mb96j SaNb6luqvXivClQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko --- drivers/gpio/gpio-pch.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c index 63f25c72eac2fb98156eb7682e780247a893d7e7..c6f313342ba06a1386d8ff8a882= c9344a9e809e7 100644 --- a/drivers/gpio/gpio-pch.c +++ b/drivers/gpio/gpio-pch.c @@ -99,7 +99,7 @@ struct pch_gpio { spinlock_t spinlock; }; =20 -static void pch_gpio_set(struct gpio_chip *gpio, unsigned int nr, int val) +static int pch_gpio_set(struct gpio_chip *gpio, unsigned int nr, int val) { u32 reg_val; struct pch_gpio *chip =3D gpiochip_get_data(gpio); @@ -114,6 +114,8 @@ static void pch_gpio_set(struct gpio_chip *gpio, unsign= ed int nr, int val) =20 iowrite32(reg_val, &chip->reg->po); spin_unlock_irqrestore(&chip->spinlock, flags); + + return 0; } =20 static int pch_gpio_get(struct gpio_chip *gpio, unsigned int nr) @@ -217,7 +219,7 @@ static void pch_gpio_setup(struct pch_gpio *chip) gpio->direction_input =3D pch_gpio_direction_input; gpio->get =3D pch_gpio_get; gpio->direction_output =3D pch_gpio_direction_output; - gpio->set =3D pch_gpio_set; + gpio->set_rv =3D pch_gpio_set; gpio->base =3D -1; gpio->ngpio =3D gpio_pins[chip->ioh]; gpio->can_sleep =3D false; --=20 2.48.1 From nobody Fri Oct 10 09:48:02 2025 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 557182E0B65 for ; Tue, 17 Jun 2025 12:24:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750163090; cv=none; b=C3LEC/e1jGFhiF7qxn0Unbk2acRXL78+TS+LNAgoogfRHKf5OWQdenhBvAlpFgCA1lySnctybwuQyFIXiUpmttWCTu2D3zbzxX0h4cNeTiQft0AXe/xRmKzEDF1FwAdebVfgmLw21weinlq0hfeQkc2EBYXRzq69KXn3GZ5C7BA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750163090; c=relaxed/simple; bh=bxD8Wln+1c1gwTOx2BtC9yxuB8rPQnYC6Cyew1Zz7wg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TXnbkLttFUzlYd2qiAXFyu4zH3In5KntiZqjEjgloGLv1Ve709s3L+8QUm/jW9KG4j0KDHdgRRjVBBpk/8qb6J41pFHuYGZpfZltlcqkvq0Oh3gdJx8gDlNuv4l8RbivNMz5ksPcy/WfiTP1LMM4rKaxcpbzLslgNoNIf4bcpdg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=mxySF/Tj; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="mxySF/Tj" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-451d6ade159so46909975e9.1 for ; Tue, 17 Jun 2025 05:24:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750163086; x=1750767886; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=QYBRyPsDGU996dnyWDGUWt7Y308dv2asqUkMv7/NV4k=; b=mxySF/Tj82NdWyaYtRcuorlzqeisO5os3ZX7XakLbdXKbF39dWaeNFGV90x5ZcuUXd 3n+oCu1fOL+SlAQzkiJ+0euql7huwZrWBtNHsarIixiWl80ji7kmsg4y4Y1EKAzZPVrZ aXsALG+//gQC6CdplZO4B2Dec5mcDNCSQcMPgK8H0MAprxscgX7v3xKmEZd9AkCLq43t QKcEhnaWnNsNbYLFh+oK6aYhzluwnB3/d28C8cuHg71V61EqmqFZ5dRaLuCL8q5m+J87 FgsrOBVv9msRQz0oWohoABByvZF/v9Ba128Lk1go6nnJjnBaOvSvjUuxQaU6nSRYcVEx Hgaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750163086; x=1750767886; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QYBRyPsDGU996dnyWDGUWt7Y308dv2asqUkMv7/NV4k=; b=qGCtF81mMKqOlTGtGuR9yM5XEbWR+BKAaH/AQHRjfLiP3Qx80Z3x7NN3D9Whqy3dED Nb0wUB8Kr4gMbdqZUdjYozYsM+wOFbnKlve9ZjxzBVyAHIlp9OF7KiZxaLrtxzOv14hg Kkm1O0EltPHmT3yjoYJuCR4v3KXcErAB2CwIrdFJq+8WUeGwHKvP5wYD5F34ULtthyL/ N18z9aIsy58II3jtlZIwmC5JRDMfn3XUaudst0E9K7ulvOuwKsjBY83ZeRt+tGvgI15C b8DpJU9yCj5AUULzycG0rxkJXvDjg+lptwsCtAf7wAWru3BMmbcyb0luwxkeHySKpli1 aWPA== X-Forwarded-Encrypted: i=1; AJvYcCUwe4vAU0+PtJ/1uRDLFkUY6tLJiNmrwE4U+kJJLPNPvKmAIUXE3z0metcXEKJSljhG5DZg6RMBkLgx+Qc=@vger.kernel.org X-Gm-Message-State: AOJu0YxZLldchT6DwMZzFq9ykKXUpk+YBG71wODR77BXK1cC2mKW4zLI JL1xWLmW9iLUpiJs3Tdvx7ltcom+O8LN15KZJYxmgPJz4D8OvaYrPM3nV3j0LD87ar7AT7mYdwV ITo/3dUs= X-Gm-Gg: ASbGncukV+NHPSkdCbPub5U1D2viIUjr3pmOlK3Nls1mF1YNbnS5DSABpUBOxzK+Sw9 FksZtfd6LX3CFLUIB4qPRgB7ZCMRY3+YaVLwI+9GlUsEUp2fyftlh4W0bqmBo4WGPine0+rjdvf kL4I3dbnXNc3QeIQFqfNjnTI7QiCK1jrUWUPJNfUNTGeDXsf2PQ9wVVCX+hvUte6Ohe3SZwmVG9 LpTlD1Xp4tezYcrKjyD217p24Tg7JJWBzvI9s0vR564D5XMc1TnG8m9TH1pUiKcbAbV4mpMvc5u 5HkPOGGlzfCkn6sLOkSi5FO26c2fHLDQGEHhDKXXCWXpOSLOzvp1kZVx X-Google-Smtp-Source: AGHT+IFEY3qQ+Fglb9jg1ZhkUiIqMjijlbm8dxytbSflltEzbMtmudgpYXUBSqKCL5VsPPsVFxCG2Q== X-Received: by 2002:a05:600c:8509:b0:450:cf46:5510 with SMTP id 5b1f17b1804b1-4533cb53b27mr117448275e9.29.1750163085919; Tue, 17 Jun 2025 05:24:45 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:90df:ded7:9cbf:4074]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45320562afbsm173816135e9.1.2025.06.17.05.24.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 05:24:45 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 17 Jun 2025 14:24:26 +0200 Subject: [PATCH 04/12] gpio: pl061: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250617-gpiochip-set-rv-gpio-v1-4-903703881fa2@linaro.org> References: <20250617-gpiochip-set-rv-gpio-v1-0-903703881fa2@linaro.org> In-Reply-To: <20250617-gpiochip-set-rv-gpio-v1-0-903703881fa2@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Orson Zhai , Baolin Wang , Chunyan Zhang , Robert Jarzmik , Heiko Stuebner Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1498; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=a1x5aRsn4kpz4DTuXQ3tdXS/YzbAV4e8kj3b/qk6D/4=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoUV6GIgRCEm14nPNHr3CVnIwUGcS41bLz59WAs TXEwqwLAcCJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaFFehgAKCRARpy6gFHHX cs0dEADc+nUolHMR19/mMV5qvmdBmtTJhRhknvVpHeM0XbGqpCZ7wGj6z0n8OFOGOBrqIN3vXbi 0ZGL9wl2G1YDE42b2BWtFDJSjYhKoMMjx9KePbUSulFNhC7pb1fAxR+N3v31drUQ2jUO8Q/ZVI9 I2fdKO60nm0ExTLDeoJZfaQZoy7/3sTkNrVWW/9YtP/1hvw/QwqxGc3nq+BWozFQPcHoK7mOvew ldZBEzrS5qqC1a01nuQAgIEdB7DeeCvSo0EXDrrXutqcYNK2afxhfYZeUTriuhbXdp4qupp9err i0yEmM76PTVq5zfZD0xdQ4bKxH09NwMcaTZ4hwl0n3N8G1aFf76HGqY7INud5TBW/K2ana5kYb+ wEBuCD+sOThcDNDSc8TwqvLXb22tImhUfaKKr8ULqAbPvCE5YWzH7SkPBabm5T0VSJIEm3ugyC+ M37yUgz2E6jHwiJ04F9U4aZYLId1h/UfRoLZrOnSQNeCY2oyz2olOiCpwsH1Ctuxk6On6FQIXc/ SOK95xbuw0JifvRteSfWF9wqQjzNDJ6Lf9VoPE0AF8HaieKhzHW5BoTbsDo8nWpazpjGr03WvA/ DQjWBu7sHs0vgHmXxbyGw5kdDpzysV/vFPtzli1F3wl9G/irY+PTVBcR7sUbr1rmWTdNOmc7UzD sfNnPEFJzOHU+Aw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/gpio/gpio-pl061.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-pl061.c b/drivers/gpio/gpio-pl061.c index 1c273727ffa3ac54d0f1e66bd6efb784d2a8604e..98cfac4eac85295915b801a62d6= 2c8d78f6cbc4a 100644 --- a/drivers/gpio/gpio-pl061.c +++ b/drivers/gpio/gpio-pl061.c @@ -115,11 +115,13 @@ static int pl061_get_value(struct gpio_chip *gc, unsi= gned offset) return !!readb(pl061->base + (BIT(offset + 2))); } =20 -static void pl061_set_value(struct gpio_chip *gc, unsigned offset, int val= ue) +static int pl061_set_value(struct gpio_chip *gc, unsigned int offset, int = value) { struct pl061 *pl061 =3D gpiochip_get_data(gc); =20 writeb(!!value << offset, pl061->base + (BIT(offset + 2))); + + return 0; } =20 static int pl061_irq_type(struct irq_data *d, unsigned trigger) @@ -328,7 +330,7 @@ static int pl061_probe(struct amba_device *adev, const = struct amba_id *id) pl061->gc.direction_input =3D pl061_direction_input; pl061->gc.direction_output =3D pl061_direction_output; pl061->gc.get =3D pl061_get_value; - pl061->gc.set =3D pl061_set_value; + pl061->gc.set_rv =3D pl061_set_value; pl061->gc.ngpio =3D PL061_GPIO_NR; pl061->gc.label =3D dev_name(dev); pl061->gc.parent =3D dev; --=20 2.48.1 From nobody Fri Oct 10 09:48:02 2025 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50C512DE1F2 for ; Tue, 17 Jun 2025 12:24:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750163091; cv=none; b=uXo6P4O8pPKknYBgALquvjHd/MMH8IQK5aYO6c2tsRmf1irEwsYtCvr6jcPtqzbY2748v55hon8auxgbOxU/ce+nIshhzaK0oFBFiX7/27pYWc94q+gycCg7Yd3HlKbO8/o9hmVzIQiuqL6USNsG1rCZGI7QfqngJ1UsjUdDnqM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750163091; c=relaxed/simple; bh=J4/swX60dxFNnGyRxMTrvcRjJzp/EsyWsznOiUYARZc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dyH4kQ7R8e8KQZ+mjMJHtEq5Y7HvfsGYHRu8urtLkfRrzsz9FUqqaWOtj0KyJZ8DvqtfEvGCpjINsN6ATqX2oRTOe7PL+2e9quGYiz6w+qNJ8exgxTXsC6JtB4BKCQysOZKDY1370wZsMNjAhp3jd9G7vW63/aMls1J+8b2Zf98= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=jUlnkfa1; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="jUlnkfa1" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-453398e90e9so30310705e9.1 for ; Tue, 17 Jun 2025 05:24:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750163087; x=1750767887; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=j3425DJ9smVNqtgfiewFDDuDZUIYNH7UVu89t2el+0A=; b=jUlnkfa1GMep9Gl/vtPRK1MlIvwrtzdFlHtzYS/xG7G7H+tef1OByINB8vV1dF/Xj0 mPzWF3NOuAHZqAS0d0OTAmfmkAWIlyH/jPieXHQKGxwiTeEMYOX4JAjghBZZvHnH1UoR AWl8CC/WKl4GqzmSP6Y+GcP/PLyoHzcORsKOH8TsaDovfH67hD5Ct3Nk8YXY9Wi/iS27 CZkfXFDG28j6BjkFT6eB+zpSJhaY+91/sOI5ilZ3QC26xEmTaKUQXdvCxA4AtaZAhYSn EC9oNXj3KpdZPf96UXhbjVHBfI0HA9FB5U4y5ppf4aKT5KijRHPK0Jidp0rEIzAhEd+S oSOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750163087; x=1750767887; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j3425DJ9smVNqtgfiewFDDuDZUIYNH7UVu89t2el+0A=; b=Rp4vLoNuYHLO1yQCFDe10KAmf3oFDrBqKw1cSKop0Tput93OnbMFQ4gfyACA1QugRi F2QUdYIqhJ73KWmmHmb7Nk3DZpBfpb9dTk4/a7g8xJJjTWY49oA8+Mn6Pz9TNGAI1UZF gbkX8JNrFx+2FUjGEB8l0UxAlLvF+apYdAoruI9lc5c+lN25T7oHirbaGp62ox7JOYbl P34EjVk1/QDIkIe+kUhWux82EmlIKWjqlhq88vbAlVzP2k0P3NRppcBb0uo0QjLO0OV3 W0Gb4aA4vr7Msf2IdE29z099lE3QGYg0wtBc6ppI4gMRSgKEU215jQWbO6kjwTrqANzG daAg== X-Forwarded-Encrypted: i=1; AJvYcCWqBmvRKtqENtgJESYKgjdxbcwbGDtG7Db99MV2SCLLNzy4I+PsoJv1liuxXGAa/C7toXw2w+rKpXxuSjU=@vger.kernel.org X-Gm-Message-State: AOJu0YwdQrYqMao2JNbHKH175rnGdmD8i+PdCsssx9TJHty+G0Bf9v9E psEn5QlnXPHEHhQkSxXH5XdAAzAdALwbnnIkCsIqnxB0nsDi5k627nVIGmpI1p1l+wWkv/eWJ1Z yPaUybbg= X-Gm-Gg: ASbGnctFrglG1u6Xzbgrn8MupNGe5Taf3YseGb7lHyDSOaTaVwQLSLRfOryT8BfWaU8 g+MMq3UB3ihmWJPNcFiYbDkj/KkSjZ95ytm9TDuBzuF9TAp8IZfcTbYIvkiktHC+3do/ENsF40y WiVsWxG+b+Cex6G763YThJiwe1JjbvlUjvF1vZOjmnwMgHX/ICaEa6MrysO5fiLI50O4WVZZlAX tcwMSfCYdzQRD5oP8wlPuu9eH+6c8yOQaTC8CTRMmlHvcGjrpFboHNoGrYZZrofaShFZK146GrS 1H1pVLYrbqQSHGBhL3rM6HADapntkhWvAUYDfbEqEc23Qw+hRs56VxrHKbn6cHKMlEU= X-Google-Smtp-Source: AGHT+IFSaiKVtjNdh8JpqeiVYaqMnisnI6PtZWZir+IMOwFShpzWggv/UUCBrlgK4mkCKC+HFcgJ9w== X-Received: by 2002:a05:600c:3513:b0:453:a95:f086 with SMTP id 5b1f17b1804b1-45343d2c0c4mr106531565e9.12.1750163087329; Tue, 17 Jun 2025 05:24:47 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:90df:ded7:9cbf:4074]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45320562afbsm173816135e9.1.2025.06.17.05.24.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 05:24:46 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 17 Jun 2025 14:24:27 +0200 Subject: [PATCH 05/12] gpio: pmic-eic-sprd: drop unneeded .set() callback Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250617-gpiochip-set-rv-gpio-v1-5-903703881fa2@linaro.org> References: <20250617-gpiochip-set-rv-gpio-v1-0-903703881fa2@linaro.org> In-Reply-To: <20250617-gpiochip-set-rv-gpio-v1-0-903703881fa2@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Orson Zhai , Baolin Wang , Chunyan Zhang , Robert Jarzmik , Heiko Stuebner Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1348; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=U5ElyLmZBGysFJL9KcblCpbMCuSewiTUa3oGkohc5iA=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoUV6HxHcn+27NvQvfcxrQSoAF+rm4EBXSaiw7O jAF5IOHFY6JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaFFehwAKCRARpy6gFHHX ctlqD/4/gbxk99tyQvyLzHrNJeGi24mjwUKkq1j+sQw6ALbBKzoDHmqfnKqIY8OLsCHbUTg8o7H WLpHhDv9MDocmKEc2xnBGqdhca8950X2Yw7bJ14AYGaBSNTk2gbnCqPtgwCxyzlGYRTH2e4qSDT d0Cqe9mnV0B6Rrrt5aNj8rKTVyt/J7X7uPyf5GAKS8TGO6IUfeQrCewVvHCaCo5NV9pJNG6ejEN iQPSSihfNWTzD6SXCjk70tmDN5zhvZDdNYThNj59HSNoqjfynIzS5ktlk6soYs039DHLCVH45NL QT5lHJ8hCpm3bAB3N5Lj6YOARL/YSGhm3r/8VevKOB2pp6aaKrKDSN5WMbqgW2WMo/MuiSEmIsT gLFIvF8uOCFS7LarA2OvuO11JjHzqQvEy19zMNxiiQYBsEQpsuufELBACem2g8XBOK+GKNUyvqT 6MF3nTtT8HvTgNzOJGNQ6y6KlOKhDxOqJmi7ry24bP5A2TOapEP02tSoPwvV3cPcsI2DMzYbPSs epODKf1eCc4YqOEdO88F2YeJssIJEhbYYpsdYD1zTNxub2CPsZ0qfXV4Hq7LgR1gJ+Dt4xWWa9B ZoQi9CaF4e8a6170SQtMrKrtUuDpeBEPSfBGUNIbYbrFnJM6jvj03wxdzhaNOuGLSSRpHY/MCJe g3QUwGjaBa2LvOA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski The lines on this chip are input-only. GPIO core can handle the missing .set() callback so there's no need to implement a dummy here. Drop it. Signed-off-by: Bartosz Golaszewski Reviewed-by: Baolin Wang --- drivers/gpio/gpio-pmic-eic-sprd.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/gpio/gpio-pmic-eic-sprd.c b/drivers/gpio/gpio-pmic-eic= -sprd.c index d9b228bea42eec53ba9d0d0945125f530a22946c..cb015fb5c946748402272391035= 4219e2c98d3c7 100644 --- a/drivers/gpio/gpio-pmic-eic-sprd.c +++ b/drivers/gpio/gpio-pmic-eic-sprd.c @@ -109,12 +109,6 @@ static int sprd_pmic_eic_direction_input(struct gpio_c= hip *chip, return 0; } =20 -static void sprd_pmic_eic_set(struct gpio_chip *chip, unsigned int offset, - int value) -{ - /* EICs are always input, nothing need to do here. */ -} - static int sprd_pmic_eic_set_debounce(struct gpio_chip *chip, unsigned int offset, unsigned int debounce) @@ -351,7 +345,6 @@ static int sprd_pmic_eic_probe(struct platform_device *= pdev) pmic_eic->chip.request =3D sprd_pmic_eic_request; pmic_eic->chip.free =3D sprd_pmic_eic_free; pmic_eic->chip.set_config =3D sprd_pmic_eic_set_config; - pmic_eic->chip.set =3D sprd_pmic_eic_set; pmic_eic->chip.get =3D sprd_pmic_eic_get; pmic_eic->chip.can_sleep =3D true; =20 --=20 2.48.1 From nobody Fri Oct 10 09:48:02 2025 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 701C32E7642 for ; Tue, 17 Jun 2025 12:24:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750163092; cv=none; b=BQOOF3kaFpyaQoiMB5pFRrZZYeHo6qqSlbmlcq3U5fJcXefcl2aCb4i9dTPiKrMHru0JkAqJ9eZOOyhTwiIoOtivwAN/OvoexYMVxT1IKAjscegfSB5juWt1pRmcud2ZEUiKv2hqtA3WJADfFg+/C609AxlGsVLYt2jw2QEfl64= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750163092; c=relaxed/simple; bh=TIbLTydFbIxMUGka9nMFS3KxZgZxnuWfV2GjJh3DcXg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iRNFjPeObHEDlLISTxdSV0+8lV2mDfsNAl/cFFNni+eBKeWjsWD66lhf2zr8A7amoqZY2OS05qIc1g19zU1W5Uv6JldDplE35n5MMxdOyM02NvoCA675qWA3mQVioh5RsaLz0HPjYRk301EVIhVFZ0+rwihTkzfA46mMq3cLwy4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=HAf+3WaN; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="HAf+3WaN" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4533bf4d817so18280405e9.2 for ; Tue, 17 Jun 2025 05:24:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750163088; x=1750767888; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=rBA3kzrSkCDXqL/qmFtpqMrbH8iiG3hu1F80uNaFdYQ=; b=HAf+3WaNaIkeA3s5LTvHxIKpT4cJOjuIY79m8X8/UKuupPtj5giANzCX4umC3igcKq oOShmMpcIwZSXJEUXD/7VEE35CB/YPOGEu9soY1Z1Ihm5+pIIbzDQmMghLN4PZcubMUu U7/Mn8/QCXizn/yeFzqJCb3n+ls0TmyNU4BVVPNKExbst4zipJ00lXVe3vePT7qC2YuU eHo+lxt1Su3NXeNOdo2+JciDp28Z4jTxP26c+4af0ipd4nbSYWCrCtAkrXqefQ9qE2lF DQGCpp5lYnH9Kbq7l3RLBsv1Cr7dDZJ6ABenqRD1gVDw/5hXJaSXT4vegB9NtGUQL0bb dU8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750163088; x=1750767888; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rBA3kzrSkCDXqL/qmFtpqMrbH8iiG3hu1F80uNaFdYQ=; b=MlBESX2XZS0nW+Canh/KoyXIEmfvpA2OHG1qlwNTrCdtUGhXf67fiQa/s0W7wNhTba 0nJc7Q5VnNLtQ9wU6THlL1UkQWe+sIOalvLuKjU8Sf4oCj/3CWmrXKXl3d0Jc6d/bN40 jUNKLYUZLEAI7jWTDUB8MHYDO3MWTY8moMgGCLM3ERD8zyl4LQwKFI48lfVzJ1mriASK sasxijbYZo2WABdgF8dld7SjSJIAuK70eFN23Ug+0XZv7CdUNnocLrBiGb1R758tJ+Cl Ex4yX5WfE6DzAfMPseSEKI9QBt3j+fKi7Y319ScO9hqyKAVd1mlQRVXhz2Mx3fCQDOi1 F69g== X-Forwarded-Encrypted: i=1; AJvYcCUrgG907MnWHgZZOp8zCrzUPKMCFFPgSMHIMeYREVEShKwQcW5cTTr/VeOG1nXQFwPU8mfdoO3xQjRSgpE=@vger.kernel.org X-Gm-Message-State: AOJu0Yx01gYY1RB22/PhAnammgynbYYk2VO/xkxp7/Ql9y3h6UZg+TxC PlammHZQ+11Lu7oSxdooKHwLexiapE4iwz1H4aQdiM1f8Y4SjL4ltdap66tAv8L8rRoBHTDZOkf SogoASMQ= X-Gm-Gg: ASbGncuqZkzgG8TuIL1pJ3RMSS7LowWV2Mot/Pk+X6Q0kQnmTRcDVRmspS9JxGmS9E+ ZrS8HWKvFmZ91Mpo2IK6dmksPBQeYqirWPuxeLUh+zLaZwyTqVcEmJP45AGuXaQTWuqdjfofVbc xwPr6Oh65jIBKSBOqudpk2W0o9dU3ghOgm7G6LeTT1O0pe6HQqJLk7HHN6oTcirSHgJ1mPQRf/1 fSbqrRrjr8szF/Je4Hx3C4zEW39UokgdfHoQKt9Jgd2adld7GltQBCEsar/yUi5fC8niTkCmYSt PCV2KkX/It3diaAuHuqMdH76h7UcDbf4tRPolhbAAwfgui034YO81P4y X-Google-Smtp-Source: AGHT+IFM4CB6egWygK88t1cCzbwx8tBuCLfY0nKXhXb0rSxlnrlGoYbjnFIM6NMIfDKL54dPCw7nOA== X-Received: by 2002:a05:600c:6989:b0:442:e147:bea6 with SMTP id 5b1f17b1804b1-4533ca54d9bmr129406995e9.11.1750163088388; Tue, 17 Jun 2025 05:24:48 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:90df:ded7:9cbf:4074]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45320562afbsm173816135e9.1.2025.06.17.05.24.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 05:24:47 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 17 Jun 2025 14:24:28 +0200 Subject: [PATCH 06/12] gpio: pxa: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250617-gpiochip-set-rv-gpio-v1-6-903703881fa2@linaro.org> References: <20250617-gpiochip-set-rv-gpio-v1-0-903703881fa2@linaro.org> In-Reply-To: <20250617-gpiochip-set-rv-gpio-v1-0-903703881fa2@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Orson Zhai , Baolin Wang , Chunyan Zhang , Robert Jarzmik , Heiko Stuebner Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1502; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=B+Qz2OspKJ91xFNTEdAqgmxdOA/mnHzp8sm3HNk30eo=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoUV6H5nCXll2tmzt32qwVJ5b3oXA1BlRJjKdG9 qyMmbsQkzKJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaFFehwAKCRARpy6gFHHX crYrEACAJfGgkYJZ/u6TIzjXF0YEJwOtUfXB3u9+xQg83jnj0Sz1G2H/QIRldbaqCd8kUmXDI65 U0eFZ619I553u6CBkPVrChl3ZZpXtUKtGWeB6ManlL30/0d31D70RtVTKbKWHN4SkTFXOUwr61V us0hdDZcVXONIlywiB7f9yUPaJb+SEygs3L2h2URtZ9XF7mwRvxRQVJ9HKe1sSnkEGczZDCQ+82 Zi+gBEJnqqEK6cyMQmdBTYAPcSLi+GT5y6AHFGh50EKfqzjR9wEvwZ5E5GrfQM+SNxZVEXYL64v SbJH6gq+aHB9TwUiVoFRA6GI5ex4dq0Dx+R6b/k+ObpgcBKB0fCm5OCACmniQ4J0nHwpFNe69/Q 0/MXLF/xPeNfTqpMFjRSoYsHf5OJTFyidc9WUKOkPWLakCilxZVYLXovCTdgyaGpr2u5H01mNFO gaTuYuqpVkMmeGw2KEwr4qaQaQeb+yBpGBcKNt6ntqnpsRfMz1sIgF4/s9yJZddJ9NOA8xWR/VN OXZ2p/rlEhoTCRH1kmNm6TqTFs72FvtA7UXobCt3Ya+NAIr6F7X9iLX0CEaY0w78ZnJWqkUxlBJ EQQaPvVZWslahNf+l5I7HxiDZ3oB5l6gkBTIG66RkME6zNBACqjO0X8zT1wS4UiXp+ChfLA8HBF /Ooc4sXgrvhot6g== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-pxa.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c index 131ab79ebce7555313fd93b3ebd80582d1b9327d..13f7da2a9486428bb8d1d44d2ca= f9f21f82cbca5 100644 --- a/drivers/gpio/gpio-pxa.c +++ b/drivers/gpio/gpio-pxa.c @@ -315,12 +315,14 @@ static int pxa_gpio_get(struct gpio_chip *chip, unsig= ned offset) return !!(gplr & GPIO_bit(offset)); } =20 -static void pxa_gpio_set(struct gpio_chip *chip, unsigned offset, int valu= e) +static int pxa_gpio_set(struct gpio_chip *chip, unsigned int offset, int v= alue) { void __iomem *base =3D gpio_bank_base(chip, offset); =20 writel_relaxed(GPIO_bit(offset), base + (value ? GPSR_OFFSET : GPCR_OFFSET)); + + return 0; } =20 #ifdef CONFIG_OF_GPIO @@ -353,7 +355,7 @@ static int pxa_init_gpio_chip(struct pxa_gpio_chip *pch= ip, int ngpio, void __iom pchip->chip.direction_input =3D pxa_gpio_direction_input; pchip->chip.direction_output =3D pxa_gpio_direction_output; pchip->chip.get =3D pxa_gpio_get; - pchip->chip.set =3D pxa_gpio_set; + pchip->chip.set_rv =3D pxa_gpio_set; pchip->chip.to_irq =3D pxa_gpio_to_irq; pchip->chip.ngpio =3D ngpio; pchip->chip.request =3D gpiochip_generic_request; --=20 2.48.1 From nobody Fri Oct 10 09:48:02 2025 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 785B12E7F34 for ; Tue, 17 Jun 2025 12:24:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750163093; cv=none; b=ZQs3KbjbSGfW5vWLP+1fn12zeDsxxpRLbn683s09lX8g01pY7f1efsvzwHQR/E9Rat2sP3cTcbTWF2d0laFhCAANYR4ohpZA0+OMliTY9e/oAAKvgzCEfruZMEP0p+ZbmPAMteWvICEM3Gv79DgIfeTdiwsancgrDGZmLjILXDA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750163093; c=relaxed/simple; bh=KyzGRm5PzFaaCx6vaqmEFT/UHLNaTRS0BfqoZ2z4ZkM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aV7eclk3VJtZ2BHHEWyhvU6nKIA6Qn6YPQTg3mraFq0tL3/XO6q8kE239E1Ev5DZD7XxNZcxHr5UBerOrkdgfPgqvHnILKhwEYRjiupJCUNnTbAwUfUu8TqwWuWXYgyMByIHJOE0jdKW96whEC+13ppcfFZ9pN0nDdoojzkGyfE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=EvFofddP; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="EvFofddP" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-442fda876a6so49883445e9.0 for ; Tue, 17 Jun 2025 05:24:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750163089; x=1750767889; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8+GlKxeWL5Yw829/r0IFKSs2jp0Xuv75Z5VhmG/MTnU=; b=EvFofddP+TuyO7zOiDYJ0gcD0EHhGtiXlOJl4r0rd/mq9NMfn7Oj5SHqiX/H06LkBu 7u/FgByU3AR0q+sa5qMoN6FcWjF1ZDSzdZvljGaUlfgcRHfJsHg56vi2Hy9zzZ4oZ4NB YOuRDbMQuD542sdB3Bw4PRjCP+sURcNlWGJPa8XKwBxjGe6sdNtmx45eAEcFt7hr2FJa yPg7BFCUtwCiMaHw1YLauo5s/OnJOhYrMle7IcxoiUqcuM5GaRhuNxWJFy0pLrowpfqc UUSCNhY38o8ZDOzYS/pzVvvPHjxRQU8Tm7ny1vEfkxmdKqgYjrj0TbpBstPYpIuV8HEt DVqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750163089; x=1750767889; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8+GlKxeWL5Yw829/r0IFKSs2jp0Xuv75Z5VhmG/MTnU=; b=XqE6MB4+5rT6LsBp3fQlw2MXRMGyWt6kDIyUawgTPdIRGsAwub4iIJc9kbLuUU+UrE 78eA1w0LLQgD969SYK/JfgEXH8D+VJnO8uZuQen1gE5D8U2Wi1Qp8yTldkNAOHfk+xSs BszazahYnorivRZo86ukN7n7g4om0JTMaHJPSUNyFNIdz/vLQ0opT+0H8ya9+RHlCxvO 1SAh0Wi6LjJlm4jqZPBjtBzFH2KljLXh+wvqbVeuyIxEKPm2eZGufTOsfxDek0SSce4b qAy3m+OwQ0LmzHLS5VsrRdxlP3fnKbv4k/eIGbcyFDKuBfPeTcj6rpLXvJQUNOxti4SW vbIw== X-Forwarded-Encrypted: i=1; AJvYcCX7+IyOfKNu/MUt2+EQY87G21gWmHhU39BN6GA9foFosbsYXlKPC169///m62IPbj+MqH08Nt35KTHDroo=@vger.kernel.org X-Gm-Message-State: AOJu0YxgCziv4emza3chdiO82hNh6uUbsFZXwoUgrkrK2Y6JOOuwI+XQ EjtZSWXllpNXfB9F6PR6zMrpqMEaBgibN6yoTAseMGgHKcfvHgxWPRnGspUKfqoQ+U1ErwzLwSd 3Y+fPZ34= X-Gm-Gg: ASbGncsciD4YhFDjgu1zrXXjGrU3Xam5Nl/f22TB2ho6etXHuVGnWscy0bgyAO+FlnE c5bFH/s77VmGJZJ2LW/KIzYruLlB1uOT659yTnEwhFl2EAvTxp8KJe2VIlfiFRxiY2hJGDMk3Uc sTSFtn6zu4yJQWdjoQ9H9imsV1gAmKtEYQudIEJCOQLdsuV0igCQpeE2gLGd/dcRhlTCE5uF4/f /IRKlPaQsPO+uP55ZMaiGbDkCh7vFqbQ6YN6wtROjPnbJyS0/IUfHJ071VIRpz9//F1DDWT9Jys mp3D2ok9euwNqOGO+cpRWniJsEA1Rns1IfWbH+9EOGqphwSMDIRFXhSs X-Google-Smtp-Source: AGHT+IFwpjSz/VHM1KyhKvNfDih6/s2ZuW+4Piw/6pIGHipA31KSBXaVEaKGZPgbplZCT6m1zd4LdA== X-Received: by 2002:a05:600c:5287:b0:453:81a:2f3f with SMTP id 5b1f17b1804b1-4533cad0f12mr125521595e9.30.1750163089462; Tue, 17 Jun 2025 05:24:49 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:90df:ded7:9cbf:4074]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45320562afbsm173816135e9.1.2025.06.17.05.24.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 05:24:48 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 17 Jun 2025 14:24:29 +0200 Subject: [PATCH 07/12] gpio: rc5t583: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250617-gpiochip-set-rv-gpio-v1-7-903703881fa2@linaro.org> References: <20250617-gpiochip-set-rv-gpio-v1-0-903703881fa2@linaro.org> In-Reply-To: <20250617-gpiochip-set-rv-gpio-v1-0-903703881fa2@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Orson Zhai , Baolin Wang , Chunyan Zhang , Robert Jarzmik , Heiko Stuebner Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2356; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=aSlqvGnhuSY1VlIGZB65GCCYVPKtjnadnIRxz6DCqho=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoUV6HstBkB2gby7ddB5ZLVgfxa78tJTCxq4I8J JXEAxgt+RmJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaFFehwAKCRARpy6gFHHX cnWHEADXLgTBO1s9GscEdPh3i4ocjK3Fa/8SahQJlDGg7IYd/EOFZsQB9lPfRFp1AmdlmS7Hyfv wGE5ENDEW385rm628aDZa1kkpglOzfjnYMKvsWysH/pBILnzwVxnNE4SF12vwSHkFjg0FN9MGLq Iibrg3tGBwjti1unsrky3likoeNWePQQCY/bjxBqIi4iaLMzHJFHZxNSRAAsmDiAbQqnrFVtDjY WH5QxkOAK/XBl/gNy+G8iBDGPIDqg1SRVQ26Lubw2pr7hxNP5e0dKF5xK4U9RM2yITwhJEDDCsZ D26jI2LV1B3QH6PdxJole1tENQRwDtL7XBgKx8cge9PwP+chO0J8WORAj6Mq07foZAnpLhgum63 8fP39So4JYKqREjjgCgLJhdI/miZC+oTjHD+FRg+5puOVly96N3THIJ1Qg99d9Tdeb229ub7p7l xdFj2tti/aRhg5u6l/KFUttQMuS/QG/t5EPcIVfTYloM/GkfcitgFwLSxjLdT2e6qwYTyvMN/YW vegXsOBOMbpvEbX2FHamQUKwfV4eV8gcsThCxpamwhjZvd4WaYQLJinQgTectos4gxBgHa2i5TT 1FoQlOY6pdq8zj/npDGDSKcwWyDBywH0KXAx7UR+/D1+AIcFMM7uHzUMrvQM3C71524LbPY2HAd aQ6m6DlGZp2r1SA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-rc5t583.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/drivers/gpio/gpio-rc5t583.c b/drivers/gpio/gpio-rc5t583.c index c34dcadaee36d5fb775d4aaa8c8f8b275f4e2382..cf3e91d235df2eefc7d0fc93a58= 824edd55e9aba 100644 --- a/drivers/gpio/gpio-rc5t583.c +++ b/drivers/gpio/gpio-rc5t583.c @@ -35,14 +35,20 @@ static int rc5t583_gpio_get(struct gpio_chip *gc, unsig= ned int offset) return !!(val & BIT(offset)); } =20 -static void rc5t583_gpio_set(struct gpio_chip *gc, unsigned int offset, in= t val) +static int rc5t583_gpio_set(struct gpio_chip *gc, unsigned int offset, int= val) { struct rc5t583_gpio *rc5t583_gpio =3D gpiochip_get_data(gc); struct device *parent =3D rc5t583_gpio->rc5t583->dev; + int ret; + if (val) - rc5t583_set_bits(parent, RC5T583_GPIO_IOOUT, BIT(offset)); + ret =3D rc5t583_set_bits(parent, RC5T583_GPIO_IOOUT, + BIT(offset)); else - rc5t583_clear_bits(parent, RC5T583_GPIO_IOOUT, BIT(offset)); + ret =3D rc5t583_clear_bits(parent, RC5T583_GPIO_IOOUT, + BIT(offset)); + + return ret; } =20 static int rc5t583_gpio_dir_input(struct gpio_chip *gc, unsigned int offse= t) @@ -66,7 +72,10 @@ static int rc5t583_gpio_dir_output(struct gpio_chip *gc,= unsigned offset, struct device *parent =3D rc5t583_gpio->rc5t583->dev; int ret; =20 - rc5t583_gpio_set(gc, offset, value); + ret =3D rc5t583_gpio_set(gc, offset, value); + if (ret) + return ret; + ret =3D rc5t583_set_bits(parent, RC5T583_GPIO_IOSEL, BIT(offset)); if (ret < 0) return ret; @@ -109,7 +118,7 @@ static int rc5t583_gpio_probe(struct platform_device *p= dev) rc5t583_gpio->gpio_chip.free =3D rc5t583_gpio_free, rc5t583_gpio->gpio_chip.direction_input =3D rc5t583_gpio_dir_input, rc5t583_gpio->gpio_chip.direction_output =3D rc5t583_gpio_dir_output, - rc5t583_gpio->gpio_chip.set =3D rc5t583_gpio_set, + rc5t583_gpio->gpio_chip.set_rv =3D rc5t583_gpio_set, rc5t583_gpio->gpio_chip.get =3D rc5t583_gpio_get, rc5t583_gpio->gpio_chip.to_irq =3D rc5t583_gpio_to_irq, rc5t583_gpio->gpio_chip.ngpio =3D RC5T583_MAX_GPIO, --=20 2.48.1 From nobody Fri Oct 10 09:48:02 2025 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40BDA2E8897 for ; Tue, 17 Jun 2025 12:24:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750163093; cv=none; b=shtVuj7pLEoamWUN/44Oq9RXdDMEDYySrPWimRT/YOXxQPsoU2RhtdsSRvLRex161R+APv/UT8tY1Nj9MlKkCMBvuOaSS+wUO+s8xfTxnHgOvuKo/+ynNeX5XybwLSDm0RziRPlh4qmlrCsfoZ4gsdoC2m9VMi6aCZxGycV4Uoo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750163093; c=relaxed/simple; bh=9Zaxzyv360mf7Zwzu4QdvYgk1SpKcZsIH3LbMJy1S68=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=d3iQF5pjFzDggyWGbbLR3U2zXYwVdFroE+fkCzWn4MRG5O/if/+r3UBa84fVMXROWfD/5fBaAVmE8NtK7nvoTCNR3hAQtln/+9VGzl9JZ4lGw3LOW+Pn2pdM+VADD/zdwBnCYjCLmyeKJbA8W6W94tnQqsualw8+ra/CSOxu1m4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=Lgskz1BK; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="Lgskz1BK" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-450cf214200so48322165e9.1 for ; Tue, 17 Jun 2025 05:24:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750163090; x=1750767890; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=AMHaAkSc/mi83kBCslhtD5+Hl3KktEIZpzS91Yh6h2M=; b=Lgskz1BKoW73PYbh135ygjCj0GIwLc5EonuJ/JdlUBLeGVZRo+cFHTckDkkg0S59qD G5PX5nCyFu16eCL8iaagBU1w78x1k66ujmLeuJkJmOSnBoiqrC4zEzz29sjDONAElo4U NxGz2yyzfGGEDuVKrlkCE+Y4vS3DvkOdhqG3cUlsqohl9nxsPU160YDQ9V2ukU/m+HnN hpLnjgKgfo3CnRVlNrT/zlZcQJEhf5pn4Rsc9v9okmFsbOVvcdxjtId4ShGKCCcvx2kO SU+MCmC4nEeLA7Xs+dWHhY3u89Yyx14utxtzVcoNlinBxJDi2HJ9pS9D42iz1M/zXHEK wGrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750163090; x=1750767890; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AMHaAkSc/mi83kBCslhtD5+Hl3KktEIZpzS91Yh6h2M=; b=CatCFpF2CgiZ8+R81WR9VlIsX55Fr7FaGF0yrbhUGFnm5pkl8194CJTjMEUiQDh9qa N2xR/GBMfHtAWqR/MIAM6HuExi8dGebQgj/UYUYPuJHMAyJLdXzIZB/XjofQKAyea06g 2lvQWRPIWiAKPHD9d8/R0CGf7knnr/B1KXbmPHVgCuLslDE6zetyscComhnblVZqvP4s yjUWTdkUk6e2m/0GVUP+Fh9RpmiQjes2X1UsTzuhMGA3ahGYi2MwKmp/YDj3pjDU8ESI n66kbFbmWCF8Pu6/3hGfs8nwrsI+QEAUPY7B02mQ46sXsdSSL58sYFyKjAUGo7A4mJRM ITQA== X-Forwarded-Encrypted: i=1; AJvYcCX30etHLn5V7AgKUGzHZmXjbRBLyzyq5uIxjWH8fUbnDuChHqrOn8k6FPjwBZGStLPTH+uc03ZsZSLq/AE=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9rsuL4UzpiLDWE7qu6thtAKuKIRNSNvtsYMcXboFsbrTS0N/4 BZ9bo1+Ax6jQKz2AMfj3suJmlCcW7izwzVh1+kD9qiMtxWXK2NC/txw7FWR+HmGpQjp2b9llm4b Y2WYbWQ4= X-Gm-Gg: ASbGncvDONbitDk8MFVvmMmxv6caF2XvEjeKI6ojgpdGqgfjFcHYPPz6pwwrgfjRp04 E4+c4Yd6b2S0G3xbz2Wf+XRaPwXtCbwCFJfaXpEbkaWjvboEj1fWCslI7H58HRQ/3IegdbBzbxn xFJDb8D5N2HMMucTe2hh3qqvtAm72vN+2JzLrATgQHjUfG+6vw2Mcwz9AhBSXdiCjM0J8IbJD8M Zjta8meRvDJNkb1YxXz7PUxQ8/b2ROjv4l02WORvRZgk/gTG37vdo7yvRFIU07nFVrng5/tqNO/ 3/3UKlzpDmX5z/+IBhNc6gREGh21d6Lj4DsprM1HCJkvF7Kdd0aG3z6/ X-Google-Smtp-Source: AGHT+IFmKyHtiTnK3f0MnCL25OY403d6ySVCu8IrYmqOaI/BNa9QItLKGnF8DD4RrTrk/qX7jMZHBg== X-Received: by 2002:a05:600c:6211:b0:43c:f8fe:dd82 with SMTP id 5b1f17b1804b1-4533cab86f3mr122978975e9.18.1750163090447; Tue, 17 Jun 2025 05:24:50 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:90df:ded7:9cbf:4074]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45320562afbsm173816135e9.1.2025.06.17.05.24.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 05:24:50 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 17 Jun 2025 14:24:30 +0200 Subject: [PATCH 08/12] gpio: rdc321x: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250617-gpiochip-set-rv-gpio-v1-8-903703881fa2@linaro.org> References: <20250617-gpiochip-set-rv-gpio-v1-0-903703881fa2@linaro.org> In-Reply-To: <20250617-gpiochip-set-rv-gpio-v1-0-903703881fa2@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Orson Zhai , Baolin Wang , Chunyan Zhang , Robert Jarzmik , Heiko Stuebner Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1631; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=/FTgaK1cWGc0DF5sQuXKwdEauaSqv0NFqrELnWAzquo=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoUV6HxI/Kng34JgzZDWKYQKf8SOY7GXUJq2cX/ QrIk9Wh/OmJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaFFehwAKCRARpy6gFHHX ckXGD/4/iUM3v0T5QVM5vI2RC3Ut9NdycYDtiCIwbZFmIIZxah5HGVAYFj4hHNnnDmHgbOPKpbJ fvfFgQvz45DeYQkCt4pQiGZv0Qd/SqIgbJyYhc5qEtrMsyae4rhudlBYsW1omeeWw3WKZbpYJZa H+ZxUmGbPpRYWJ00ByGxGN7U0XwLEnGzdN9MFBTbMF1l2Skr6JR5xW7GSYEd8W0DUF+cKhHGlkG tTM+8sTClgTZKEhTwPU4xRm5iPN7WOjcMk5DmY0mG1UEXbySHcesZPEJNmM21B1+92IRk2JNe2H /VAEi7V/WkptmnNksEJ69Il01MaFBxMz4pxCQitD1TitfnJFmPkLjrzKbdrn3TyYmUv1CS7Pwb5 53BODlK5dE7lx4Aa7oalaaEuB9jUi95cbAT1NggaAMPcYGEtV4/osEVsgvFJgHmjqaNyMdGR2iM u/8qM+PA9O3kTmWneQ3nO2PYpET16aDMNTOLjSCwKd2tTxzIdjoyuANw12R51w7RQtzXyGNmcKm JK0IqnHKNBngn1OgNpXIZg/JEi/UpIzFhPzRsekoD4UsX/FCcFFWQCHncvwQ2OxaBBGY6qcMZll HdBrKU+g5SxgCmCazOJbDue5kkTg2eLpczzEwQyUiVYZqmBmf669E2jH+28FaLh6L+A5WIdC8L6 E+2w4xVaUPZMexQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-rdc321x.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-rdc321x.c b/drivers/gpio/gpio-rdc321x.c index ec7fb9220a4747fad5dfdb88e25e68d2a104e37a..a75ed8021de57db122938e4736c= 3ac994bcdd2d1 100644 --- a/drivers/gpio/gpio-rdc321x.c +++ b/drivers/gpio/gpio-rdc321x.c @@ -64,8 +64,8 @@ static void rdc_gpio_set_value_impl(struct gpio_chip *chi= p, } =20 /* set GPIO pin to value */ -static void rdc_gpio_set_value(struct gpio_chip *chip, - unsigned gpio, int value) +static int rdc_gpio_set_value(struct gpio_chip *chip, unsigned int gpio, + int value) { struct rdc321x_gpio *gpch; =20 @@ -73,6 +73,8 @@ static void rdc_gpio_set_value(struct gpio_chip *chip, spin_lock(&gpch->lock); rdc_gpio_set_value_impl(chip, gpio, value); spin_unlock(&gpch->lock); + + return 0; } =20 static int rdc_gpio_config(struct gpio_chip *chip, @@ -157,7 +159,7 @@ static int rdc321x_gpio_probe(struct platform_device *p= dev) rdc321x_gpio_dev->chip.direction_input =3D rdc_gpio_direction_input; rdc321x_gpio_dev->chip.direction_output =3D rdc_gpio_config; rdc321x_gpio_dev->chip.get =3D rdc_gpio_get_value; - rdc321x_gpio_dev->chip.set =3D rdc_gpio_set_value; + rdc321x_gpio_dev->chip.set_rv =3D rdc_gpio_set_value; rdc321x_gpio_dev->chip.base =3D 0; rdc321x_gpio_dev->chip.ngpio =3D pdata->max_gpios; =20 --=20 2.48.1 From nobody Fri Oct 10 09:48:02 2025 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 417BA2E88BA for ; Tue, 17 Jun 2025 12:24:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750163094; cv=none; b=B7G3ZEID8ITWJ50/Rshoqu6v5EiEWYF/7LZxyfNpQK1p3k2DVxV55WN5JpNEj+UbjdBGiUio7dZ9buFj2uEIFnYRVeTVee7nWMtB8quQmB8liok+IobJxyuFG8lkeUW+S13pXGhMD88vNbcIsKSurTJWIi0CHVMOXUWLRM0KCCg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750163094; c=relaxed/simple; bh=k4dHPZZ4gqkig6Focr6bfb2InwZS9T5SYeSgNocjwKk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VVCY4ebkXZEVvaS2hO2O5/jh2EUeHnwMMsQNNYQJhFnrOA1qZF/1CXSs6SwZr/Y4WPewbiUzoCyIBYOW9SBL8Wn/im8qtpEn3V0BydNF1it03xYocgsbO0MGpeQSSXb8aCtpDskjh7e/YGcB9GxzcbWbjnCMTWDqpOeTDAjWDiQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=CvaVIS4J; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="CvaVIS4J" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-450cfb6a794so33371235e9.1 for ; Tue, 17 Jun 2025 05:24:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750163091; x=1750767891; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=JKQWt4//oHPqdwtyW4DHzL6S4FclhuKp/qxVZV3GJA4=; b=CvaVIS4J6DyTJJuQ9ekrpzT/1gUNtHl6g/+rszZWJKaV5iwaDKtve+0Ow69TGo+Qv/ 0XrM5gt+qVp2trU7QDPPAzj9aaE73E94jY78TvN7Wrm/LB7eLJ4aW+6yPrqUtyb9FiIa bWtq7FyubYt7BRP43WjLH/V8YHM1t0eludAKYf4rkOb8OQX0GV9foFGx9jV8qVxOItZS 6O0kcHcr04j/4uLtHm4GH7+A5WasGsaemyGYfMA+iB18xzYZo3XZ9ces0K/V5wGQYmgM qQSC8olW+u0Yxp5gRUoMv5lexAasK6nQqk/Na0FCjhIx8YyK2Arj16akFMCgDPULuK14 llAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750163091; x=1750767891; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JKQWt4//oHPqdwtyW4DHzL6S4FclhuKp/qxVZV3GJA4=; b=CKBx3MwfL6jC9/dpMTvoWZHfqz+eVH6aAGEVsgbnVz/xWPnPZxwTArMp/nc7Py5dDt nCLqjkxrjqNggTDOP7wxK/UMIfzALf3sLWg2NgAbSfDjUcjqJiUH3vND/ypPnTQWs6de 5EAc9KPtXnQLtAEUBh9baJZgefDgml71ehwMA3lJo0QZ9RkH3TdEu78JUdRQ/iRDa3aL KEdZzo7Iz1Pmk/NeAfXCiJDTm7nu0d0zPp8j4qMuGfEag2XwUFy8xEOwKIo0OktOTwqZ ogxqW8lBOAil5L/OwksnUTIfO5BYCLYYHi0FS+txaX5rZWQL6bQyPkOXtFt9iMVYC4vI 3CUQ== X-Forwarded-Encrypted: i=1; AJvYcCXY/My4gORSBd7KraqagfXWZYm857Xepad8qY69+bcnXJkGHlvyggyO1kImhwiqzpHSTzgxplxAjC8Vp+U=@vger.kernel.org X-Gm-Message-State: AOJu0YwxmrJskdk2RMxdV+85TKQoaRgb6ocRyEC1bIjJCYRjerAsoIv8 SL83a9JDLRMSmyxnjnrEozxNqfoPNP5SiFgvpR8Oq9NZuoUO401zMFOlucNbwyCvJqtNi4n8Z+z YwW9o5zY= X-Gm-Gg: ASbGncul8fYe2gZmH8Lg36KX62e6xXOlTWFyk/j8suT3VGFY6lbu5YAhyEExEMwZMYA Iq2BNRUQMMdn+/rJBHKDFSwczOHPb7i+eUW5eUHainiK1jCSiYvNAlkzo5VFTrdaPabuHhwR9VM umxovdxaB2GddgKcL/av5hdYXH+ZbJ+6OMaZrxULWAgVRV7hXr4XNjznD7CPoN3zC6h/yOroizW fOi+UQEXXzWXIMx4gA3XA6hqHEoVE2KGCLS6tp5e11M9l16qFun3Zzpa9iEuU7n09h1Ye73atHF DMnykrM/18WTNiZhYKTsCtXkaQnau62n2S6A4D4x8fZxx0o/qvt0hxiQ X-Google-Smtp-Source: AGHT+IF6eYsaKpvLJvmiUt8QAE8cQozg8YKi52ZOS1NW0clbxh8hC/2bJbDvUtJBCX2vBadvgAd1AA== X-Received: by 2002:a05:600c:5490:b0:450:d386:1afb with SMTP id 5b1f17b1804b1-4533ca550e9mr126976755e9.9.1750163091328; Tue, 17 Jun 2025 05:24:51 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:90df:ded7:9cbf:4074]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45320562afbsm173816135e9.1.2025.06.17.05.24.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 05:24:50 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 17 Jun 2025 14:24:31 +0200 Subject: [PATCH 09/12] gpio: reg: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250617-gpiochip-set-rv-gpio-v1-9-903703881fa2@linaro.org> References: <20250617-gpiochip-set-rv-gpio-v1-0-903703881fa2@linaro.org> In-Reply-To: <20250617-gpiochip-set-rv-gpio-v1-0-903703881fa2@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Orson Zhai , Baolin Wang , Chunyan Zhang , Robert Jarzmik , Heiko Stuebner Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1609; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=2vGuNGgCgh0pc+4hsP4u+sm/9GXFZBWpDEWg7HI60YI=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoUV6IRA8tyBhHC37R2KBIo+pHJI7AEfyKcsRQq WM5zs1FSCiJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaFFeiAAKCRARpy6gFHHX ci99D/4hhJaBJIevMhmTwG4mOMgBexZpMsXQOU3lkV3o0lyW7sCFFoT4RAxJkgHQb3UY4BdCzYR hsuVsjmoiLXcB24EATcTHXDb+I4MldGSrUNljZkUqOcM2wOGt1cT658ZCdGGoH1vlNWLNHOVT6/ 2sL/BZgYNCi2AH3VGnf8a00O6kLdiRfcwLZC+PUzfsrpKn8gF1Ix3Mkbsa7OLF84038LJq6bI1c c2VRA2dqE9Gt+iutb+pLDOys7jK/e7YtrEvr6TVipW7t9rd+wfSGx6VjRRdQOzpRg1eu+J+Xi8T AYWthV9MGLhyJPDlQWECWxURTOjIym45RF7cVhwDCcsUKTj5xSOxGX09IUdOZYJR0VGfLcJPnbb 8BddmRCCqi8QUywmi0PQdgTEK7df0vHiAsu3qsbCUCWv/gGbWZLFJNBy/KO5u554GAGHkJBg682 j8YI40oL+nnf6nrN9JftBHs1Zd1kU2plsmAdp1w09XQCrJHaFQY3rUn6NEacZyxNZh1mzMfxSNZ G1fQZCb+TzEfZ+NGQJGbHU+7rf1b/xGILFLDqr+ip8XKYSSu5+No4Mauf3r9NKCxcIYvTtPMDBf uQx3IwCLQdPUqNBmuCpK8CrCHmX66eULZioJiClL3IJoMf8EKjEJF0epLFCIxutnFYCk+3O0QSk 07I77UmQH5zfvzQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-reg.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-reg.c b/drivers/gpio/gpio-reg.c index 73c7260d89c083a702b1d914ddca7a573a37de4a..d5f3d8f18b405d124b17c338d79= 846214f9e97de 100644 --- a/drivers/gpio/gpio-reg.c +++ b/drivers/gpio/gpio-reg.c @@ -57,7 +57,7 @@ static int gpio_reg_direction_input(struct gpio_chip *gc,= unsigned offset) return r->direction & BIT(offset) ? 0 : -ENOTSUPP; } =20 -static void gpio_reg_set(struct gpio_chip *gc, unsigned offset, int value) +static int gpio_reg_set(struct gpio_chip *gc, unsigned int offset, int val= ue) { struct gpio_reg *r =3D to_gpio_reg(gc); unsigned long flags; @@ -72,6 +72,8 @@ static void gpio_reg_set(struct gpio_chip *gc, unsigned o= ffset, int value) r->out =3D val; writel_relaxed(val, r->reg); spin_unlock_irqrestore(&r->lock, flags); + + return 0; } =20 static int gpio_reg_get(struct gpio_chip *gc, unsigned offset) @@ -157,7 +159,7 @@ struct gpio_chip *gpio_reg_init(struct device *dev, voi= d __iomem *reg, r->gc.get_direction =3D gpio_reg_get_direction; r->gc.direction_input =3D gpio_reg_direction_input; r->gc.direction_output =3D gpio_reg_direction_output; - r->gc.set =3D gpio_reg_set; + r->gc.set_rv =3D gpio_reg_set; r->gc.get =3D gpio_reg_get; r->gc.set_multiple =3D gpio_reg_set_multiple; if (irqs) --=20 2.48.1 From nobody Fri Oct 10 09:48:02 2025 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81BFB2E92D3 for ; Tue, 17 Jun 2025 12:24:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750163096; cv=none; b=l+U/c4utKbBWGGRzG+I/MEohrz06LEiQXaq6iZkk/e5YlWb7L8F7QNNfUQs8uQoIF3jt9KkIm77tf9nK9hivJVlWgwXrS8+/jwB2oeaLIqzUSHJQOWjXCy1MrVF1F8M980oFIqhiuLP0C81U4ETl3Ox1TxmV1WFbmuxZhx8e5WY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750163096; c=relaxed/simple; bh=COE46zuDiGK6rLwTnt7+1d3gjUwt5RswqdYUD5pUbdE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FE2SZBjQ5mxT0MVmJWGZMyltV2wDCjeAT4PCu//CkDT1PasEWeYOy+hiFPIE8VrswVb6UK7+kpnVSQ9v5/eOzV3oWulLdW5rMbbSNm5bYjoKPkxHR5pJpYT26AWJ7DpREJzDSP4jBTSrR2xJowox3NA15CeRatmNJmFaNt63J1w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=PvCGOxEE; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="PvCGOxEE" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-45347d6cba3so6532375e9.0 for ; Tue, 17 Jun 2025 05:24:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750163092; x=1750767892; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=fUxEFCxSV+En4LdALjtxQKt1K3KufAQa0J+EdQHN8Wk=; b=PvCGOxEEQr94a79NeUbIILmOsyGSMvHtZI6aYBFeaqFHxy3OctobRMF6ZA52CNaBrP xW1QCt3npM4azQ/k+1CEicTfhqb/ky3Af8M0RqW4lINOCOlVr1ZG7as+qXMjIhITE46i jpHdCClFNNmSOumybgaHdCjQsWTTmCS2VE3fmp2ZqQlfJ56xjPEDuCFayY8qGbNjRr26 8MH9L/uh7rvSAkwE+nmqzzRwBjowyW6hQ2oukxBoJVYTz16IdEtSz1znmUhnDaDciRbH vXMghfD1wbLlCF/9HXeSjSAnmEruvHn7d4uNntgAOrBYik7FCEMXB7+n0OwDFHJUR4+Z Wgag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750163092; x=1750767892; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fUxEFCxSV+En4LdALjtxQKt1K3KufAQa0J+EdQHN8Wk=; b=LN3Tabn29/9jzO1OSBE/Z9glYoyltUJyRuPm4PknwtwKYNmiUSvBynFtNYwmRZU+4H BQR5zjy/rp3SbITAFikgrqUD75j+zU0oVcn4wL2RXHz1o4I6HP0dsby78B5ZS1jY+BrY J3At/DWBOhJLZyq3Dyo/S2OolZkaI9omnHxm/nlLuXgnP26g1gGWeY8fUh+vNMLb2vU8 GRDMQ2nFdxhO+xZZBohsq6m8D7DkcTioUd2/VTmfcB1bIXWQzVG89czni0tuN2Lj7iAN pN0aUFGjnfCMalxaQj4ZNS3av3LNnl2HgN1T7H9Di8lfCAdA/PkvZ9s3TP94pL3sjKd+ CFVQ== X-Forwarded-Encrypted: i=1; AJvYcCXIFxjb49SBdI7rwYVI0yIVw7WtvEc3ytAhpFh2e1XGco9/6JDilmcDbzWO+qjuRE3y5u0ec9dICPSTt7E=@vger.kernel.org X-Gm-Message-State: AOJu0YwnPTBx/36jwdTegzc4ByhsHPALOm3r57L7FXnh5+Dy1ePdEWrZ pldHq0TmwlvlchZJOKXMs7kNhDYC5ww/fwcoyCy7AEqjKQyr0/ViBSnxF1ZdCW7wkEy+zXYwIAE dwaEnvhI= X-Gm-Gg: ASbGncsRmLfXBqDBzfWgQDhwkbGeDwBeKB0VrJYSW8Bh0aJfjv76MuveGJOT3x16inK 0jNuXVOSxnobUdexjVg8ryLYeKuWW33x4tRMw2keiilsW8Nn1t+kdKRXCiktr822YFWpM2IGkbM AQBC3c0WoIzfbPXKKqoPjxAL3nj4kU5VZ/2q5tV9q2RAf6aGwOHbPNe42Qd1sGMYmiHrCk2yahO zSqzQ4BA13L8ahyBd8Lnc9L8I+ATlUyYXs0RqkCzdTuaJtRgSxChecQ0wCI9gIsbEp3pxpqC2fA /Bc9uUxIwCEG9vTwJR6J5P2pSciDhS2qUONupXMeaDfiaG4AdIF/z4sw X-Google-Smtp-Source: AGHT+IGgYH+QDdfuvXiPaRleCGYB4hawdcNCoD+7SQT0TTGxbFuQ1U1ki3nSuWN7vTMRqEzg9ktwWg== X-Received: by 2002:a05:600c:4f14:b0:450:d30e:ff96 with SMTP id 5b1f17b1804b1-4533d05d802mr127973615e9.0.1750163092415; Tue, 17 Jun 2025 05:24:52 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:90df:ded7:9cbf:4074]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45320562afbsm173816135e9.1.2025.06.17.05.24.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 05:24:52 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 17 Jun 2025 14:24:32 +0200 Subject: [PATCH 10/12] gpio: rockchip: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250617-gpiochip-set-rv-gpio-v1-10-903703881fa2@linaro.org> References: <20250617-gpiochip-set-rv-gpio-v1-0-903703881fa2@linaro.org> In-Reply-To: <20250617-gpiochip-set-rv-gpio-v1-0-903703881fa2@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Orson Zhai , Baolin Wang , Chunyan Zhang , Robert Jarzmik , Heiko Stuebner Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1750; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=bJZscimERewZNLI5pGqQIjH00bD6YcA1Kc9nHnuKKr4=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoUV6INooTRzzb2rM2QZl1UnM7MKBZDkGH2R1+l +3ZOEcYOpqJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaFFeiAAKCRARpy6gFHHX cgACD/428t0VhbSsaD/sOpTRxYgjJixIbcbX+Imu1fnRwC0NDyjVSd1Ppu/1T/QJA8H96+5Hl4i IiSOqn30R4elqtKMEjyYjIKQO9nThTDDU82g94DWFqMA75uqXCEuzb27TrWkdI3y3BSpZ7InJln /f6EqcbSFl3ygCsX4e2zM8faIISbMgNsDH2E+imOPZSwXID0nYlh3+4Anct1sls0LJuJDb5CP5n feeX1GlDZttcB8DOTG4fh03a3XDE9mNvmjThVWd0uRIBWatKbT0NuMb/0V16FsSXSuUKFG22+58 0XIAhAJnT1oWWwblp9Hrz0nTqUc6LleqKCD7TW4cGeXFnKMO3xmdZliojYQLJpJG8pD4NhZhEdh g11wc9CTKxOapj+j93BDL4Z0JfN8YpTz7TBEM6MdCr5GncfqFWwc41/MhGpZT2z9WA+ILhc/mmP aumLjrTe0din4dpouMbsWDzxjCqoDPJFBass4ZvKADGq5vw45LXQdzGnzur1nWfuyuE1yDok5Sg bRZ/HgViajvE+2LHwm4Ch607XughI7JiAl9rVNlhUL2qQ5/cPjlfFa9MEI+/986p2yx/VljApYj LoFjiJ5p1flBGE5Bif0reNM2afmvMwg6xSA2kb7W9niSulMydT60OYDbBuSgXSkfBhs+IPI1lHR yUH3DYOL7hUuLPw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-rockchip.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c index 64700a003f9a17947dd38baea23a066e8c057caf..ecd60ff9e1dd1a090bfad204c8b= 86c4d7fb68ce7 100644 --- a/drivers/gpio/gpio-rockchip.c +++ b/drivers/gpio/gpio-rockchip.c @@ -177,8 +177,8 @@ static int rockchip_gpio_set_direction(struct gpio_chip= *chip, return 0; } =20 -static void rockchip_gpio_set(struct gpio_chip *gc, unsigned int offset, - int value) +static int rockchip_gpio_set(struct gpio_chip *gc, unsigned int offset, + int value) { struct rockchip_pin_bank *bank =3D gpiochip_get_data(gc); unsigned long flags; @@ -186,6 +186,8 @@ static void rockchip_gpio_set(struct gpio_chip *gc, uns= igned int offset, raw_spin_lock_irqsave(&bank->slock, flags); rockchip_gpio_writel_bit(bank, offset, value, bank->gpio_regs->port_dr); raw_spin_unlock_irqrestore(&bank->slock, flags); + + return 0; } =20 static int rockchip_gpio_get(struct gpio_chip *gc, unsigned int offset) @@ -325,7 +327,7 @@ static int rockchip_gpio_to_irq(struct gpio_chip *gc, u= nsigned int offset) static const struct gpio_chip rockchip_gpiolib_chip =3D { .request =3D gpiochip_generic_request, .free =3D gpiochip_generic_free, - .set =3D rockchip_gpio_set, + .set_rv =3D rockchip_gpio_set, .get =3D rockchip_gpio_get, .get_direction =3D rockchip_gpio_get_direction, .direction_input =3D rockchip_gpio_direction_input, --=20 2.48.1 From nobody Fri Oct 10 09:48:02 2025 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45A022EA47B for ; Tue, 17 Jun 2025 12:24:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750163096; cv=none; b=ieEHwKzRxj3307VJS44DZmYns0oOpH8ONG2BghFtnNVoKDHNqwBxw/ALn/MjTJ75O5mwyjJr+4gMY8vPdcWVJV8Vg0DIlP/b4vBfi3OWJiRB0vHvklS1K77Gu8VgIcoSv7P/qUBRQI3UKYSaSbPB2UE0p56uDuC+JNFkQPUd9+s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750163096; c=relaxed/simple; bh=3QvoiOFdKV8vnY8Kgna8S7pQjfH/iy2iYWkuJQ55SWI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bQIBp2TG7Yk86Uy6pMTjONwtMEd+8t3akLkDa0qqj98kVvWsTWwMQ/XHcKJCLqsru+qyCc7hV0UvUWLe7Pd2Qs+YoRvOK89S08gpnmZj57j0o2boo7XIA2DhkcxOcQVrcrkdQt/8fWCXTzyyspx603EnuZM6r0Ph6UCHYASrcTY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=2XKrKV12; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="2XKrKV12" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3a536ecbf6fso3814221f8f.2 for ; Tue, 17 Jun 2025 05:24:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750163093; x=1750767893; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kXdEOuSE84y7KQ8YXqskQa8fEM4BBQcsKhAUrS+jouY=; b=2XKrKV12QgkkKnozExFqvj91aJ89+ulCoVpmkf96jwsBpMAJH5UGgjCjND4mEWGabM Fnhy7Bub7X2cih6njlasAhvWvwuvHfsPDNZGVL/hgBdcogGW+rghb5JpWkM9dy9qtpnv nHvERnG1j+W+hplPHg4fZezNNOvYOsi8YACRcbGQBCo7NX7/CZ82t1OlP5wnVWf7SSkK eLuNCpHntEez3D8H9IxlefrVZpjKuQPLR4H6jbJDsWKui+XDnQpVPjY5CDYPgIy12sjF u2Hut3XMA1wY2lE/u9vn/2EyaCmWQh9FAOfEyrDzHKQRIp3f0cfuLnNdeWuL51aXBush ROEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750163093; x=1750767893; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kXdEOuSE84y7KQ8YXqskQa8fEM4BBQcsKhAUrS+jouY=; b=DVH2bGsyMkUfM6heDSqDgw8nfm9qD8vKe03OtTteH4fkHwXZ3iSlhYZJv3Iko03NI1 gt6NAWqXkb1bvQH5NFzD3dNtDp6JpJzcRItFGwLWQgyHasJ6jHhuY7t0Y8UP4fAqhNzx SNokDU9SGPSKnjqMMGBk2JLBwRG7bjjJo0r2EHipXEr5dUMWKU1+omcfVVBTXQNbdjTO K/1e5JGWbvT5fMC2/l6WaDVYpYSApT028Cu00ccUom6dujba43mkHkHxd6opIaE/OJN2 AmxK1v1ZMkdD29bVsQWaY2Oh9B0fSsbEmK5r8XmxKJieHnAhumz3UXiQSu1L3Bhlpg20 ng+Q== X-Forwarded-Encrypted: i=1; AJvYcCWnjahK1WARddDfHWrr/OLh1br2qZeD3qZNmmukiHcvYevvw4Ctar4njVhu8N4J7W8UZGM9wUnYop/Sl7M=@vger.kernel.org X-Gm-Message-State: AOJu0YyG3C6p93mx9B3mrcalxQp3L8xTDmGGD47tXbxLfx9nLNuUU9Wf WbInHm+17Xd/dSu5Br0b9yfAVey1aZun8HV9X1Z38pRYWt8K1gLjhX3TQndeOCuT3xgrJdUdgaW TSc/ctRI= X-Gm-Gg: ASbGncs8NFeUfZDcrEsF7yTTquA06xtqAbDIpYP+q3NtSkuPsBhzK51e4MWzw3/h9B+ /HzGi1zj8qnwRdTMo/q03X0SEkXbFTH4L6wBJ5HIx9Za6VSU4yt2KBEyYVjhDeO/MNg/svdmudA Uoxu2spJnYR0pv4LydkH0YKmTewrwShuJqovzqW+N9ivPvYU/gqzNGv26JfSVX9qnpIckcfTnHD Q2Tdo6ZNbV6cXDPGr8lxc649xMq3aFmuEWf9IpoRNmYkWPSn//Is3IxmYHOfowVdkW/Gj3FZ3X4 6Edt1j13WECwJyHFT8Uoy1t+B9fmAe/Mf+5ZGpPgYSiaYPCZQOaLINPF X-Google-Smtp-Source: AGHT+IH8xpEepUrAKy/suev+AiSpI+HMEadcjXJn3KnGCfb1V3r97zqr4NOUkjvPw/0XSg0h1ArV8A== X-Received: by 2002:a05:6000:1886:b0:3a4:d6ed:8df8 with SMTP id ffacd0b85a97d-3a5723af293mr10690095f8f.39.1750163093381; Tue, 17 Jun 2025 05:24:53 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:90df:ded7:9cbf:4074]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45320562afbsm173816135e9.1.2025.06.17.05.24.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 05:24:52 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 17 Jun 2025 14:24:33 +0200 Subject: [PATCH 11/12] gpio: rtd: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250617-gpiochip-set-rv-gpio-v1-11-903703881fa2@linaro.org> References: <20250617-gpiochip-set-rv-gpio-v1-0-903703881fa2@linaro.org> In-Reply-To: <20250617-gpiochip-set-rv-gpio-v1-0-903703881fa2@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Orson Zhai , Baolin Wang , Chunyan Zhang , Robert Jarzmik , Heiko Stuebner Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1662; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=v7M2Umlyn2cPSJSz3+M1vQ3MpPcGxR4ur24zUL3eZaA=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoUV6Ix+OY9qYUNs57XxRLpSefNPZMcuXRvrrwq in5+MyXCnGJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaFFeiAAKCRARpy6gFHHX cgUcD/9a/NMO23UBM1PKONinHkaDzFJv6rspeSt3zyUyirrJTSC+YG9L7KQAy6EP8I14UVcZKtA lNgBgl7hfpD+zkk1mp4AwrMXPBeVx8WSSjf0FmO+MrjsITnI4Z0fbz5o0jDFE+lDn7xD2cL2auU 947xCBF9+Ttxmotpuw9ArSMMBdVwMeIEhjD535k2QDvlUfURzxixpuWKVDuW/kJtMFSOIjhirXR NyY5cM5Y6hZc1PlNZvVmKEVRYX2iblKuwvO6aTogzr+j8DsAv9hWmlSFzuRR9P+0aO2XmvgGXg8 1n6R5ZC1zPol+Zn7IZ7P9bmtLwmCbhtwH52ceHQw7VwuxKj6XyyYS5Islx9pCInqsAyOKDDHc5w sBCDnSCr9KRnoYUgVU0FtZUccsCkeSs7u2WVJt4OXTN/vaW6+jyp25w9AcT5j70W4I/sXnJyA4C RqboO/HC6SFaenrazVmKfvN+w+LsKTyh2ubg6Q33Cvl8SUHSuJhXPmmYEVJtMBoh9sAgCbbhtZD VBokjCltqacYpkmvjoqoa4oGIWdwNjsmEjshSlpcJbQEjPOwSC8OT+L5DEF3DPTETFARiOApkFE DZl/rN6G8ha/5RdhURKiwc3HANM9XFITHEtdw4xybhabqYeL+fl5ZjADtbwN8Rh9jmgSrioWfJq BY0Nu9ZHfizUkJA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-rtd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-rtd.c b/drivers/gpio/gpio-rtd.c index bf7f008f58d703347cba14f35c19f5798ee3a949..25bbd749b019bf8a272c173a3e7= 373a442f72350 100644 --- a/drivers/gpio/gpio-rtd.c +++ b/drivers/gpio/gpio-rtd.c @@ -275,7 +275,7 @@ static int rtd_gpio_set_config(struct gpio_chip *chip, = unsigned int offset, } } =20 -static void rtd_gpio_set(struct gpio_chip *chip, unsigned int offset, int = value) +static int rtd_gpio_set(struct gpio_chip *chip, unsigned int offset, int v= alue) { struct rtd_gpio *data =3D gpiochip_get_data(chip); u32 mask =3D BIT(offset % 32); @@ -292,6 +292,8 @@ static void rtd_gpio_set(struct gpio_chip *chip, unsign= ed int offset, int value) else val &=3D ~mask; writel_relaxed(val, data->base + dato_reg_offset); + + return 0; } =20 static int rtd_gpio_get(struct gpio_chip *chip, unsigned int offset) @@ -563,7 +565,7 @@ static int rtd_gpio_probe(struct platform_device *pdev) data->gpio_chip.get_direction =3D rtd_gpio_get_direction; data->gpio_chip.direction_input =3D rtd_gpio_direction_input; data->gpio_chip.direction_output =3D rtd_gpio_direction_output; - data->gpio_chip.set =3D rtd_gpio_set; + data->gpio_chip.set_rv =3D rtd_gpio_set; data->gpio_chip.get =3D rtd_gpio_get; data->gpio_chip.set_config =3D rtd_gpio_set_config; data->gpio_chip.parent =3D dev; --=20 2.48.1 From nobody Fri Oct 10 09:48:02 2025 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C27E42E7F37 for ; Tue, 17 Jun 2025 12:24:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750163098; cv=none; b=mINEKcaNb43bVQF0vVWTOK3CQ2UxCroKy2PnCKSWMnh7/9+9loLZge/sFMM1QGuhbcmZAGvedin4wJBjFDHufUTjvczl+KP7wpVnRN3Cmiamcy5g8Zyd71JWrgeR68VOg3GqBSxV4AmGkXXgEAuWafn9RohGcY0CRXyAu6eJuBo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750163098; c=relaxed/simple; bh=eEv9Rs9Ob2RKbLYMX17232517BahJV9MYVei3h7Ywh0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jB03LJ5ff1UEkNYIgdZZImJzGx+BsqzL/P5FKGQ/fvZ4lzR/CQ/Nmyx8tjA3wi9ntmdGoEfilrbftgQuiMviyWEXtadNumk3VGR/u0gezV6228iMQbdPHmgVdbST6oFd4DF3H4ZSBGo73nrCT3EUFRh2AwjNSiuzTkKgyW193N0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=CDmMpoXb; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="CDmMpoXb" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-442fda876a6so49884445e9.0 for ; Tue, 17 Jun 2025 05:24:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750163095; x=1750767895; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=QlDtpw6smBpfIslmsuGCGMOBJqH80dy6aXMZgZ8Sqro=; b=CDmMpoXbxEegq7QPOKmmcINarHvc8jcxc8YT36fh+03SQl/OO2MqlQxwX0XtggyF3e D+1aucq85xUt/desvwkZWRXMQAeUzCSCS+Lu/TKJSNhdPncgAS1VzJICKbzh9/vWc3Jb 45GKfuuyjpJ4U0nzaC0kXGpYfMmEQFUXroSnZ13eJ7gbvPG7XkpQ7DWe8Wl338FQ2Vm3 GHpudH1ktgXvvOaKhYjFi0uPRnTnO2bkJmkCYmkfcjDlnbWmGjCbCiLXSxXLABW2LJlF xl82wTqB8w46R8oMJwG3ZT8icTnMy4IveJokuwyiu5i5PXxrJZUNITmtZM+ZaYlt0RP+ 558Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750163095; x=1750767895; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QlDtpw6smBpfIslmsuGCGMOBJqH80dy6aXMZgZ8Sqro=; b=MDajhPRrJXW6Nfvf5LwQ05RbbuZGMRlb/3a7ewByzQCN53QuEo0BaITVx0Vxn5lO/m 7swqUAiQJVw4h3KIvAp8/AIpJJcpfUM1aGGY6Ki3Qk1MacSP53wCcGXiIqqVBqFa8Jwb Dka8JJdXP46HClTc8vEKWuDo4/A1X9R+jKt4MI6ZTq6HakuOkTgzHPTataqDEUBOc/oH acKgxpdZO4Hq3OvM0bWUb6Dc1WrGKRYs4iIZgyv5j2Q/6T6v6Y57V8qbLYkcbLa1NK2k bxDCmzQJT9rn2R6am+pmR+DP4LeASIvg7IA0GM1NKQ1eGPVIBpoLX588L7MgiZJZb5An jYEA== X-Forwarded-Encrypted: i=1; AJvYcCWFu9MehS4eoaw72VIiL9lJFh/QyJXipMad6NYhJR4yBayE2HN38UIQGWG09r5aMRgm/ahHzg32i2DfA8w=@vger.kernel.org X-Gm-Message-State: AOJu0YwqVMd+bVjYoV/hFPC2Na9jV4ki7dh52NXa5Z3b2TPf8n1zE5H1 TTHaDeih18vzGpUoNa6ooRKowFflYdz9uO/LAmagBl15E2m5Wft7CywshMdTs2qyRThYyMeuINz oKT0MWIM= X-Gm-Gg: ASbGncuSFydqLfbl/erEyNy6g0vOX7G0EhJaHiBRrtWDY7Trd5/AD6RCFseL/9zPvVO lwBIyCdXUL4N4I40IVJX91YS2PKND0LSJ475rk8jYOCInLht/lEm0p0q8foQxuttgf9gyHkRxIo ENzzpgiXAr0X6dexfAB8FDF25smbwExQWM6H8rlSigJeRLcC0EJWYdbQZErQ7HgT0kwD7fyDONv I5bD2Qfu1XH3JlVmxIQ7pOJg6hgEUeFSBHK+ynap2mt9/d9uhcHBo80mllBD+c+w0jH+7P86WS1 KMsN3ZFKhODT+JdnTsIj5qfCPWyiIr1FPiqksqTjaDoCYm2J7eMcpZTr X-Google-Smtp-Source: AGHT+IFsTWQIKZSJGIY/CXmS6lZIJ3ZenpODtlq8yK7uNveBH+mmtvLiQ+k6AgHQE4CwrhnHTwO8nw== X-Received: by 2002:a05:6000:2382:b0:3a5:3bdd:6cfe with SMTP id ffacd0b85a97d-3a57237e161mr12452604f8f.26.1750163094424; Tue, 17 Jun 2025 05:24:54 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:90df:ded7:9cbf:4074]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45320562afbsm173816135e9.1.2025.06.17.05.24.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 05:24:53 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 17 Jun 2025 14:24:34 +0200 Subject: [PATCH 12/12] gpio: sa1100: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250617-gpiochip-set-rv-gpio-v1-12-903703881fa2@linaro.org> References: <20250617-gpiochip-set-rv-gpio-v1-0-903703881fa2@linaro.org> In-Reply-To: <20250617-gpiochip-set-rv-gpio-v1-0-903703881fa2@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Orson Zhai , Baolin Wang , Chunyan Zhang , Robert Jarzmik , Heiko Stuebner Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1424; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=c4Isjx61IsXwy1L10lydMFlqZBELu3z3ba+yBwH+QRc=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoUV6Ipp+OYSt+ikqj2UvGKKNMCmar+1zqMNgVE W9N6iQSuQGJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaFFeiAAKCRARpy6gFHHX chTeD/9I14P9RY3COUbCjQedgou7h73GVSmQAfpsU1+oR9NX67oKSF9DMr17US1TFf2xZifaFyB +A7PUaOjWr19fNg2617gbOaCxUfM1fd75XPrCYVHaR6PUWMzfvo96J35H4Aq1E4rp3nv6j8oYnp 39K7mMEvi66do04dqvXYuAp3nGAPJ6+P7RXanRnhC0jbJ5JbGuJdG2pSH4gX8+YW3cc91WVrb7d 4GxpxIYGWe0bGcDqZ17neqzVyzrpEluCO/VrPr/e81YyaUppzx9GoGtYMBXtNCd80QGyeAzfkOr FavT1ZDpRsyWPsF7c+aJ5Lk2ADy5FyToc5wtk1/IEhbCOc0ecPrrl28VY8mITwHwVpRtPIb48LK 40+TDflwhqQkl4wvcZUGrZQJYaGEALsIizpjR0LRHe/nQxSHyjrudyn6DrrgfwWkzY9UBJsQMA8 skB+VxmtuPO4gOKaUTkFlDa+LkasazYamiCrWNrJvXwY6PWop8tn0K8svtQ6P8S5HWlzSK0N6UZ Rxn9y/tS3F6w2S7c6XQTEEvtzi1V53Z+wxP2I/VELpg0AZVFcM1+55C+GTwbWshUf1qcMltwGSP vupnX/UiKGo9M3TMglMKZkB2CyR3GvqKjQ2rjUXGTgNK2IXSeKzrZbsyRGkQiOJDgGbpYuU5p4B SKaO1D2IiPKNZTw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-sa1100.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-sa1100.c b/drivers/gpio/gpio-sa1100.c index 3f3ee36bc3cb19a7baf530def0575d2ff09dd3c5..e9d054d78ccb8485b9f662fcec3= 85fe0d0edc0d7 100644 --- a/drivers/gpio/gpio-sa1100.c +++ b/drivers/gpio/gpio-sa1100.c @@ -43,11 +43,14 @@ static int sa1100_gpio_get(struct gpio_chip *chip, unsi= gned offset) BIT(offset); } =20 -static void sa1100_gpio_set(struct gpio_chip *chip, unsigned offset, int v= alue) +static int sa1100_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { int reg =3D value ? R_GPSR : R_GPCR; =20 writel_relaxed(BIT(offset), sa1100_gpio_chip(chip)->membase + reg); + + return 0; } =20 static int sa1100_get_direction(struct gpio_chip *chip, unsigned offset) @@ -96,7 +99,7 @@ static struct sa1100_gpio_chip sa1100_gpio_chip =3D { .get_direction =3D sa1100_get_direction, .direction_input =3D sa1100_direction_input, .direction_output =3D sa1100_direction_output, - .set =3D sa1100_gpio_set, + .set_rv =3D sa1100_gpio_set, .get =3D sa1100_gpio_get, .to_irq =3D sa1100_to_irq, .base =3D 0, --=20 2.48.1