From nobody Thu Oct 9 20:24:39 2025 Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A13AD28A1D5; Mon, 16 Jun 2025 17:53:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.11 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750096383; cv=none; b=nklz6qNQLdRBUnx5KyLz7+E2OjFvjDIVUwgdn2fxLxukUDw0qjeIlcetCXREnqF/uygKjPe7cgo1vobSkTaXOO6AWZWqIhgkzyG+YwBv1YeSo+WMgDX+bngLwVY+kKFvJmDXSTE7NniK935ctXzljgNG65oT0wEStqUx2N6jh9M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750096383; c=relaxed/simple; bh=a/MfSuVozGAacAKmarZnQF0n0dIVocJeRNqB4nOy+Qk=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=ehGykZfhF+whfRpFLPjDzUkXh/NSCwn3H2Y2qppDm2ZvVkUmaIv0zg5cu2tjG4iNtkaadAfrPqcKjwFQwQaokoSW6IIlufWw6GTOt6iSxhCb7nX+QhbK2UApV4YXZDZUm+AjtZO5CZxEUCy8tYyKCihawesgiyUUnBh8VC/BS9o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8D7C11D6E7C; Mon, 16 Jun 2025 17:52:54 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: nevets@goodmis.org) by omf16.hostedemail.com (Postfix) with ESMTPA id E3E6E20018; Mon, 16 Jun 2025 17:52:52 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1uRE0u-00000001KTG-3Qmh; Mon, 16 Jun 2025 13:52:56 -0400 Message-ID: <20250616175256.669462692@goodmis.org> User-Agent: quilt/0.68 Date: Mon, 16 Jun 2025 13:51:47 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Carlos Maiolino , Christoph Hellwig , "Darrick J. Wong" Subject: [PATCH v2 01/13] xfs: remove unused trace event xfs_attr_remove_iter_return References: <20250616175146.813055227@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Stat-Signature: nxabk184tb74pc6weow7eq64r5xaidso X-Rspamd-Server: rspamout02 X-Rspamd-Queue-Id: E3E6E20018 X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX1/EBVT/ypkTxI/+Sgk7S8G9jwsvgq2z58Y= X-HE-Tag: 1750096372-980939 X-HE-Meta: U2FsdGVkX1/WRZXHROWxbBSJP25HM2voSaVKtXS4/NIuXQOaf9kfU66N37DnmFa9KxpbhZnR3htCjIwIpZRXgAxnKL7AmQ1DtzozIbGsgsKHagnoyN3mkZ8tmbWplKNTS0XScc2TgoDV+M35g/cD2k76QTyy6w0yUXlIWqpjyNQho5SfWgx9u3hamKbaZ9+mhtZ4C9R0bLWYggDrJnvjxDzRFIYs3cVctb2cMHoanMz+3bCSyG5UbG9G8EcQ/S66HO1ITWG3ZSZ0TFF31SrpQpzLTHfnnmlDOU8lSVOvDHv7u6ZGc0XZ2YxeSUOh7I+hGYcDGp7rddX56GHMc+JaXU+8g/tjchTdTQ2RUWBXG+JlppnsGc+Usv3saAXxBlOl75WQnOO9529jrpl05caE4A== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt When the function xfs_attri_remove_iter was removed, it did not remove the trace event that it called. As a trace event can take up to 5K of memory for text and meta data regardless of if it is used or not, remove this unused t= race event. Fixes: 59782a236b62 ("xfs: remove xfs_attri_remove_iter") Reviewed-by: Christoph Hellwig Signed-off-by: Steven Rostedt (Google) --- fs/xfs/xfs_trace.h | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index 01d284a1c759..a8867f62ba18 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h @@ -5077,7 +5077,6 @@ DEFINE_DAS_STATE_EVENT(xfs_attr_sf_addname_return); DEFINE_DAS_STATE_EVENT(xfs_attr_set_iter_return); DEFINE_DAS_STATE_EVENT(xfs_attr_leaf_addname_return); DEFINE_DAS_STATE_EVENT(xfs_attr_node_addname_return); -DEFINE_DAS_STATE_EVENT(xfs_attr_remove_iter_return); DEFINE_DAS_STATE_EVENT(xfs_attr_rmtval_alloc); DEFINE_DAS_STATE_EVENT(xfs_attr_rmtval_remove_return); DEFINE_DAS_STATE_EVENT(xfs_attr_defer_add); --=20 2.47.2 From nobody Thu Oct 9 20:24:39 2025 Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD44E28A1DB; Mon, 16 Jun 2025 17:53:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750096383; cv=none; b=uMo9ZtGnx+gDdtZigR9UyoN6fSMfFQmy3WTS1bqE8sEbPUYywQCgIxXf7tPsD+zGvaGuNdAEPrijXAXPoodVNf7qCQFmnmbnLtgKk0htuQgHQ/eJZTw/jKO5XonglFYTnOeEtSyO5jPtpEG5jCTOT8kl7XzTneCeD5Dz0tbf9TQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750096383; c=relaxed/simple; bh=mLvPZZP61oay+IscZv9tkm2Gs3ZjQaoIJgaLGEYX/hU=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=ZRtht9+UK8uDs6l8yrXdp1FiLI3h6uE8dHmSQmjOsC61pgKRGeyvSboWMFFkLSgbuPLw51kTvfXP5DeOJti1NBwYMnU0Xk8X1sFW7LN1UfAak3fJjemBKIAJlmibxscbspLEL6NTFQosBIhhsZO9pOtK2PDF3SA9uljJF7lenwc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A88F7120AE1; Mon, 16 Jun 2025 17:52:54 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: nevets@goodmis.org) by omf01.hostedemail.com (Postfix) with ESMTPA id EAA8E60010; Mon, 16 Jun 2025 17:52:52 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1uRE0u-00000001KTj-49Xa; Mon, 16 Jun 2025 13:52:56 -0400 Message-ID: <20250616175256.839740146@goodmis.org> User-Agent: quilt/0.68 Date: Mon, 16 Jun 2025 13:51:48 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Carlos Maiolino , Christoph Hellwig , "Darrick J. Wong" Subject: [PATCH v2 02/13] xfs: remove unused event xlog_iclog_want_sync References: <20250616175146.813055227@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Rspamd-Queue-Id: EAA8E60010 X-Stat-Signature: ec3rbhqom87ts3188j6pqbpd9jg8h1ja X-Rspamd-Server: rspamout05 X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX19VVEMzjf2QpB/ZfvWAE/b4HOi2l7+cTcw= X-HE-Tag: 1750096372-822555 X-HE-Meta: U2FsdGVkX18UQPxgTBPAbOf8BTJ7oAdNJWvqdYSu74rPotqdc7B1MkJOZNV4iY1/VCl8bd7phyVLPf1otbYIMZK8BxEtssdxm3UZ7A+0hh7MfA2ri4DGWrGy60hyT7r+A2knqryHhOGTM4sP8xnDhde7NMWLNM0D/07TrszbLLpv205qJiPTHEuwHUNqpQBUiNLxcPz3agdJLQjNv4MaeBGePOp0wmFrWiM6F+aPAngDDmLdoJU1BRa8nvMxYjO3LpTWGlWl77M8sya5mnWwkMqdRrmAs3wlrU1rK8vj0R6kL9Ifk8d5Hdg1Qqm0TdxGpKX2ysDdu1Xm2i1aPZ9wqGgMKiH+QDIdvpIqrJLmsdq0kJIh7yUYU4ye8NfRVIbqXPmxpBV6zjoRS81jkZO6JA== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt The trace event xlog_iclog_want_sync was added but never used. As trace events can take up around 5K of memory in text and meta data regardless if they are used or not, remove this unused event. Fixes: 956f6daa84bf ("xfs: add iclog state trace events") Reviewed-by: Christoph Hellwig Signed-off-by: Steven Rostedt (Google) --- fs/xfs/xfs_trace.h | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index a8867f62ba18..b78676f44750 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h @@ -5028,7 +5028,6 @@ DEFINE_ICLOG_EVENT(xlog_iclog_switch); DEFINE_ICLOG_EVENT(xlog_iclog_sync); DEFINE_ICLOG_EVENT(xlog_iclog_syncing); DEFINE_ICLOG_EVENT(xlog_iclog_sync_done); -DEFINE_ICLOG_EVENT(xlog_iclog_want_sync); DEFINE_ICLOG_EVENT(xlog_iclog_wait_on); DEFINE_ICLOG_EVENT(xlog_iclog_write); =20 --=20 2.47.2 From nobody Thu Oct 9 20:24:39 2025 Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD02728A3ED; Mon, 16 Jun 2025 17:53:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750096384; cv=none; b=bsByR4pOdOCSu8pQ+trX7QHTAIEumVh5Q4kg1iOB43tpJOpnbgqzUebfa5M5dCz7gNnU7mIQEj62+y+vvQefQ3VmCcewb1GEhWfVU7S/k2txZEfxgwVIWf2pjzePGD66P13L2XmVPeVo5XiABhBSi/uL3kLt2H/6PNo7VBs3M3A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750096384; c=relaxed/simple; bh=zfx8UutfK6U5fkb1VSXEmOCFP9m3ucQdt45ECOKcJHs=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=uSPbGxbKFommGYXslDjJbFXQluNM+7qr07Q7Tkj+98eVLGiBy/Et8xYIYp4I4NmZsZ3jF3S5xbfq+RXiFa4VWsJMHF5urmYrKnOqLLXwQVJI0s3Brq/fmAQes2pg46pPTmsgy7AHLFQawjCNpUCfUTJY4ZUjEokEgLFAQH21GKg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CCFB81D6E88; Mon, 16 Jun 2025 17:52:54 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: nevets@goodmis.org) by omf09.hostedemail.com (Postfix) with ESMTPA id 1E9932002B; Mon, 16 Jun 2025 17:52:53 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1uRE0v-00000001KUF-0fs0; Mon, 16 Jun 2025 13:52:57 -0400 Message-ID: <20250616175257.010194747@goodmis.org> User-Agent: quilt/0.68 Date: Mon, 16 Jun 2025 13:51:49 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Carlos Maiolino , Christoph Hellwig , "Darrick J. Wong" Subject: [PATCH v2 03/13] xfs: remove unused event xfs_ioctl_clone References: <20250616175146.813055227@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Stat-Signature: dywih7b5713ahwnm1wgkurnj1w5jmtrp X-Rspamd-Server: rspamout04 X-Rspamd-Queue-Id: 1E9932002B X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX1+jQIRgyWIno3h7K+HKQc6PFNOc3LbvdqI= X-HE-Tag: 1750096373-164365 X-HE-Meta: U2FsdGVkX1/lmTovO10iDqOlt67EixerTXVHHBl1JpBj0hurA3NqB+ftQc8qxYGa3j2opuEWLgOI6VH/g+7eZpAMztqkqlXuDjVype3SPvRhv7CphsPPfTz5VMW30znKUV4H68bsFiMwmhddme8/A6ZGczMB+cshrCjphO42lGPEz7EL34rH8G4a/XDgCHZekazyyq23M0VKQhNR6Xnbw9RSHGuuFZSTGfbaPGplU1WRxlFB1xGjSlkqbMfv5vCxM4sdQwMwM9Q/NlEgXcJIeafAExw8pReMbIu0lt+J+a6mEwWAGJ1L9GA+DsC8Q/gxjoAvJlVS5sIVn39NkDSX2iF0jG2pjtxSbN6O+2CqaJn20pBMTnphawBB2cDTrWoX5+kGinOsgsML7o3bWDB9gQ== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt The trace event xfs_ioctl_clone was added but never used. As trace events can take up to 5K of memory in text and meta data regardless if they are used or not, remove the unused trace event. Fixes: 53aa1c34f4eb ("xfs: define tracepoints for reflink activities") Reviewed-by: Christoph Hellwig Signed-off-by: Steven Rostedt (Google) --- fs/xfs/xfs_trace.h | 26 -------------------------- 1 file changed, 26 deletions(-) diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index b78676f44750..993397f4767c 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h @@ -4210,32 +4210,6 @@ DEFINE_INODE_IREC_EVENT(xfs_reflink_remap_extent_des= t); DEFINE_DOUBLE_IO_EVENT(xfs_reflink_compare_extents); DEFINE_INODE_ERROR_EVENT(xfs_reflink_compare_extents_error); =20 -/* ioctl tracepoints */ -TRACE_EVENT(xfs_ioctl_clone, - TP_PROTO(struct inode *src, struct inode *dest), - TP_ARGS(src, dest), - TP_STRUCT__entry( - __field(dev_t, dev) - __field(unsigned long, src_ino) - __field(loff_t, src_isize) - __field(unsigned long, dest_ino) - __field(loff_t, dest_isize) - ), - TP_fast_assign( - __entry->dev =3D src->i_sb->s_dev; - __entry->src_ino =3D src->i_ino; - __entry->src_isize =3D i_size_read(src); - __entry->dest_ino =3D dest->i_ino; - __entry->dest_isize =3D i_size_read(dest); - ), - TP_printk("dev %d:%d ino 0x%lx isize 0x%llx -> ino 0x%lx isize 0x%llx", - MAJOR(__entry->dev), MINOR(__entry->dev), - __entry->src_ino, - __entry->src_isize, - __entry->dest_ino, - __entry->dest_isize) -); - /* unshare tracepoints */ DEFINE_SIMPLE_IO_EVENT(xfs_reflink_unshare); DEFINE_INODE_ERROR_EVENT(xfs_reflink_unshare_error); --=20 2.47.2 From nobody Thu Oct 9 20:24:39 2025 Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB9D2288C3F; Mon, 16 Jun 2025 17:52:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750096380; cv=none; b=b8BDD/aiDHRMgC2DipFfneaZ5SFJPtbuKLMgx7g8inx5AwLJBsd53aQ7SKs6lA4Br8URzfYH0cMNCGjeCgBc5dUesiQgi6X7Ha/91f9um99hu61l2f3HZbZaXITE6+Ay6/Cv0l2FIPchkJKch34HrzrnzHMHNILYuBQQRStN0Ms= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750096380; c=relaxed/simple; bh=AVp114dx6LIJj9Vd/bX8lpwcQYfC2mGHedvxI2YWSDc=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=P2BlYlq2BCl6QzDN+bRzrXkpPk36Xu6nEkkrKeoV+JsRHeq6zU2e/civXPkejt6R4uJrHkbGRGPsXtvO4f2OdiKTrhAPRMe1T7/qLLElsQ9zGB78Iy+6fNaiJWot1KP4jiQoyRqv2adEB3WePB6Lrt8bkzY/6pu+UFPhMLDX0YI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 24D92BD4CF; Mon, 16 Jun 2025 17:52:55 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: nevets@goodmis.org) by omf04.hostedemail.com (Postfix) with ESMTPA id 6169820031; Mon, 16 Jun 2025 17:52:53 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1uRE0v-00000001KUj-1NFk; Mon, 16 Jun 2025 13:52:57 -0400 Message-ID: <20250616175257.180775864@goodmis.org> User-Agent: quilt/0.68 Date: Mon, 16 Jun 2025 13:51:50 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Carlos Maiolino , Christoph Hellwig , "Darrick J. Wong" Subject: [PATCH v2 04/13] xfs: remove unused xfs_reflink_compare_extents events References: <20250616175146.813055227@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Rspamd-Queue-Id: 6169820031 X-Stat-Signature: 8ebu6r87hmzjy94ce4huz546yxirojhq X-Rspamd-Server: rspamout05 X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX1+09dk2fJxNMYcf0HeQDLz2wZnw6nwyG90= X-HE-Tag: 1750096373-741816 X-HE-Meta: U2FsdGVkX19Z3P0KrrHzWZRue+GgVdvYI4OP2XZ4COW9H6U4/8ML0uXAPbclnNmzyRIkgCcHPYMQ2yTFNhTnLwIAgukcPh0Nh154NcUTzXJyz9uMY7XxL87DocTTyd0hPgnQCeK3maB2aKYG5E6ui/o1oW+aUej96z9eHpaDB+j51UaE6C/VCLgJTNWAGJUY5GFiWvDo/8Bj6JkKBj+rTCLpegIgPdIiuHkSH4Q7wc51ilE4/x4vrtGtuU9W+RevL/c1bOM3K2Ialv+R6VVroc8KTC9GE9stOZNG6JA868ZB7csOWqAsxMRlZyuUZZnOyw9VWugCbwT8WCyGs8Ivoh2rzGgymsMmWwH+raJZSqcxojTrqnejGITYt+SpEJolgEekLMT/FBYlRyYMeU+wlQ== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt When the clone/dedupe_file_rang common functions were refactored, it removed the calls to the xfs_reflink_compare_extents and xfs_reflink_compare_extents_error events. As each event can take up to 5K in memory for text and meta data regardless if they are used or not, they should not be created if they are not used. Remove these unused events. Fixes: 876bec6f9bbf ("vfs: refactor clone/dedupe_file_range common function= s") Reviewed-by: Christoph Hellwig Signed-off-by: Steven Rostedt (Google) --- fs/xfs/xfs_trace.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index 993397f4767c..6ba8cf1a52c5 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h @@ -4206,10 +4206,6 @@ DEFINE_INODE_ERROR_EVENT(xfs_reflink_remap_extent_er= ror); DEFINE_INODE_IREC_EVENT(xfs_reflink_remap_extent_src); DEFINE_INODE_IREC_EVENT(xfs_reflink_remap_extent_dest); =20 -/* dedupe tracepoints */ -DEFINE_DOUBLE_IO_EVENT(xfs_reflink_compare_extents); -DEFINE_INODE_ERROR_EVENT(xfs_reflink_compare_extents_error); - /* unshare tracepoints */ DEFINE_SIMPLE_IO_EVENT(xfs_reflink_unshare); DEFINE_INODE_ERROR_EVENT(xfs_reflink_unshare_error); --=20 2.47.2 From nobody Thu Oct 9 20:24:39 2025 Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1295B286D69; Mon, 16 Jun 2025 17:52:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.13 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750096378; cv=none; b=COb4kKPYWEh94omr/b2mhzHFxVBZx7iwUuo22obwMCp9JPji/Lez3gl6Z+IvOyDdSaxSnw0AOY+PbqCy6tqoZlFmXZD8no/5FGuADlITj4LbYUMMgOA1QwPiYoCXyhj5RnSkJdS6ec5xDCBnZNXYbU79Y3xtWOxwMzzJB4Imfi8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750096378; c=relaxed/simple; bh=CYlQXKUC/k4zUgCaV2OcyF0QZlscFj2OAaCfrAxSlTE=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=GZbHdOJ+STdcpRvRo/O/OLwVKGhKJWXOMnJaEN3qtcxfy0xaJgLHH4T7a/5sb4IMVX3vOlrwaJPFMxwjEzFQbQZtvqfl7PjpgHTWm41WvA4YiGWwmUlBzLASrxmUnDY3Ey4uUR8laqhgXl+s8Kkkxfj/Lr+9rWI7wTlY5+lmoUM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 15FBC1A0B2E; Mon, 16 Jun 2025 17:52:55 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: nevets@goodmis.org) by omf04.hostedemail.com (Postfix) with ESMTPA id 5D47A20030; Mon, 16 Jun 2025 17:52:53 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1uRE0v-00000001KVD-24A3; Mon, 16 Jun 2025 13:52:57 -0400 Message-ID: <20250616175257.347133467@goodmis.org> User-Agent: quilt/0.68 Date: Mon, 16 Jun 2025 13:51:51 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Carlos Maiolino , Christoph Hellwig , "Darrick J. Wong" Subject: [PATCH v2 05/13] xfs: remove unused trace event xfs_attr_rmtval_set References: <20250616175146.813055227@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Rspamd-Queue-Id: 5D47A20030 X-Stat-Signature: fpx5h43nbm9ytpfeggtat4prb66fxuw1 X-Rspamd-Server: rspamout07 X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX1/cuPiYW/TAvrROxey7zFty0wbljByrxvs= X-HE-Tag: 1750096373-943156 X-HE-Meta: U2FsdGVkX1+EAisccI8NqaLL4Fb8JVQqxVRAVke+C9JezXVqVSzTUhNL/hE7w1av+UUEJ6v0Sy1mXDKOfmMswfqsZI4j5Xl05HRAHGjRNkFjPEbifVxdZ738zCebTSEZ4kCBXp8hyEI/nSpPc1DHoIfeNv7MChK0AaKl2wOpxbYimigSj6iJZE2OLMLnjWqe8XhgJw6gRyV2u2DaIDXBQL8ScgW618UlIHosuzkCJkTpQK7ka83ZcsecJglEVeCYiMw3TfsUHoZQGLwmeo/LHuEV4nVLdu/64JXsJTvFdhPPEKAhss7FQQaQi5NnLP4mO5IO5ywPkxgnH9wx2nVtwUYxgBDnSpCIUZAw+xNQzOIa2l+zbJOvnnYBhGRbkTCBi5bWnGyoxk6EqvflERNdeA== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt When the function xfs_attr_rmtval_set() was removed, the call to the corresponding trace event was also removed but the trace event itself was not. As trace events can take up to 5K of memory in text and meta data regardless if they are used or not they should not be created when not used. Remove the unused trace event. Fixes: 0e6acf29db6f ("xfs: Remove xfs_attr_rmtval_set") Reviewed-by: Christoph Hellwig Signed-off-by: Steven Rostedt (Google) --- fs/xfs/xfs_trace.h | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index 6ba8cf1a52c5..f62afb388189 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h @@ -2471,7 +2471,6 @@ DEFINE_ATTR_EVENT(xfs_attr_fillstate); DEFINE_ATTR_EVENT(xfs_attr_refillstate); =20 DEFINE_ATTR_EVENT(xfs_attr_rmtval_get); -DEFINE_ATTR_EVENT(xfs_attr_rmtval_set); =20 #define DEFINE_DA_EVENT(name) \ DEFINE_EVENT(xfs_da_class, name, \ --=20 2.47.2 From nobody Thu Oct 9 20:24:39 2025 Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B77DF288CB1; Mon, 16 Jun 2025 17:53:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750096384; cv=none; b=eLJvd+Y/CV8qpDSpphZjmdPn6GPM45W39bjYSRWtEE7S9DCfd/QDVZw5wP34bQV1ST2809zlJqEwAdIesse9nxI5bUJf22msaxoIYkewOcUUM+WfGYphXOiSu6LJj4y4nltUGwLeoQyHwfXWHM5ors0a+UXd1hlk8EtDyx3HC88= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750096384; c=relaxed/simple; bh=EybPv4tas+Ze5YJV/bsT0f6tTifbCg+q6oyv8QKWYmg=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=hqcu75t5bE//Dmft5nnxq4rJ5HiUthXqwt5qncHpqaJBo36rvWBrGs2ir3RgLmGnv5jKMJBAAmGscbvMY146rLIuw3y+uKb30wnS5Su1+3ZHnY3vZ+cHz1tlxJGdlO7E7U3mpBCrQhOMlvS456NZvscAgHEUbQg/iINMBrO/PEw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 756861A0B30; Mon, 16 Jun 2025 17:52:55 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: nevets@goodmis.org) by omf06.hostedemail.com (Postfix) with ESMTPA id A2C5B2000E; Mon, 16 Jun 2025 17:52:53 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1uRE0v-00000001KVh-2mn4; Mon, 16 Jun 2025 13:52:57 -0400 Message-ID: <20250616175257.512380287@goodmis.org> User-Agent: quilt/0.68 Date: Mon, 16 Jun 2025 13:51:52 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Carlos Maiolino , Christoph Hellwig , "Darrick J. Wong" Subject: [PATCH v2 06/13] xfs: remove unused xfs_attr events References: <20250616175146.813055227@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Rspamd-Server: rspamout03 X-Rspamd-Queue-Id: A2C5B2000E X-Stat-Signature: u3bn6zaeyx8gx7wmwsaqnio9gpsn5gr6 X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX1+Lo/MqJBkcEwSF4ph2FmKZmRoOgzNjPvg= X-HE-Tag: 1750096373-925209 X-HE-Meta: U2FsdGVkX1+rAs6/EWy2qXve9KgcaSliuvGGmwVPqKsSjoHhjdgtYy8zTv6xSTaVLYR2EDWLZLchpCvxlcdRoO2U+viSxY8/nQNsgL0bLw6SGTlviUBk2gb9jgrQ7CS/gaS6tWjLHZJ2cmYmRy1yGaPPVpHXP2VDVzlv8A8WaxKw5RTIJAx3t02dKFimuxNeFTv1EAqw0z08cm960XQ6YH5Gl3QfosRb5yjGMB33LOEzs1tcI2aJAszS81EuZVp+VwEYvtsPDluCS/4HHeYhLXB49/bKNlYyhFXT55xrBqZJQxXm0ZGsDxOuiK7zNNTF+OzIskxoxnsXcoKEWsw9lHfvmdPFPGLPzgYB02MVPQO2aiUZktI8hU2kDLDImOzBdfoqPXJtyNFkEmOZHZiCzbzgr3Ykg4OVJrtQBs9nAnQ= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt Trace events can take up to 5K in memory for text and meta data per event regardless if they are used or not, so they should not be defined when not used. The events xfs_attr_fillstate and xfs_attr_refillstate are only called in code that is #ifdef out and exists only for future reference. Remove these unused events. If the code is needed again, then git history can recover what the events were. Suggested-by: Christoph Hellwig Fixes: 59782a236b622 ("xfs: remove xfs_attri_remove_iter") Signed-off-by: Steven Rostedt (Google) --- Changes since v1: https://lore.kernel.org/20250612212635.748779142@goodmis.= org - Remove the trace events from the header file instead of #if 0 them out. fs/xfs/xfs_trace.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index f62afb388189..d41513c76652 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h @@ -2467,9 +2467,6 @@ DEFINE_ATTR_EVENT(xfs_attr_node_get); DEFINE_ATTR_EVENT(xfs_attr_node_replace); DEFINE_ATTR_EVENT(xfs_attr_node_removename); =20 -DEFINE_ATTR_EVENT(xfs_attr_fillstate); -DEFINE_ATTR_EVENT(xfs_attr_refillstate); - DEFINE_ATTR_EVENT(xfs_attr_rmtval_get); =20 #define DEFINE_DA_EVENT(name) \ --=20 2.47.2 From nobody Thu Oct 9 20:24:39 2025 Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BD05288C3F; Mon, 16 Jun 2025 17:53:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750096384; cv=none; b=ILCqVI9L1BVZqgWS8y9SejmM59/ZP20VUx+Tmjcf+vNaFcX1pOVeWLbqfbeGLDZ/wmZ0+qivanQbmBIa9M4g5CvQLnHLDng/jjQewHfsrvQUUcNkrMHg8g5c9CtdFhDyEqrBF7PanqIiM5ToclIItRmRyIVOefAs58X0PhhzmAw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750096384; c=relaxed/simple; bh=Vo5mo9vffi2431wb1UkgIWg4IctaULbsZ7jNpGoHmCE=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=TbhBLe8EBDnQYfhjQRwfh7Jrn/4npvF8cDN0KeK+WruA1ysFa++q4rviAGeZTwwJwIRiMTSZqeV2JOchdyQ9WjomJlFsRHu4quHdEV7AXZkotgGnF/jYCkmpjd8ROPV5dLACNrsN9ugn9vHZNaA+P8yUgITeMyV0wjqRbcNmrV8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 898D45C5F2; Mon, 16 Jun 2025 17:52:55 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: nevets@goodmis.org) by omf05.hostedemail.com (Postfix) with ESMTPA id C4B8A2000D; Mon, 16 Jun 2025 17:52:53 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1uRE0v-00000001KWB-3UXx; Mon, 16 Jun 2025 13:52:57 -0400 Message-ID: <20250616175257.685241532@goodmis.org> User-Agent: quilt/0.68 Date: Mon, 16 Jun 2025 13:51:53 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Carlos Maiolino , Christoph Hellwig , "Darrick J. Wong" Subject: [PATCH v2 07/13] xfs: remove unused event xfs_attr_node_removename References: <20250616175146.813055227@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Rspamd-Queue-Id: C4B8A2000D X-Rspamd-Server: rspamout08 X-Stat-Signature: 5etnophfocss3zrbamigozesq9fk4zym X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX1+R5SfIYIgziOAj6/kWMcHHQpJ4CFrBYiU= X-HE-Tag: 1750096373-289213 X-HE-Meta: U2FsdGVkX19n/hgMdBzOoOt1SFLDFSt9pnEXKyinc2yCdcqHDTBH9Dqm4PTZCnhOyt7bDpzZ0wO27gQcl2fXfpfDBppldFGdkPyEciZLfS9lKpL3IzhknrC4LpqSZibCpSmfT1u57U3+FgBIcuR+uJo63UUwjoNH9lolEadjbA5YoboXl3TFEYAzOZo0Br55MkOfzdkqZQg4ys4WLaE3bJ9RBFum22awQFmK9QPcmC3hEHUs68uRSlLDGgAY8YogCwLaZMv1jbD5wQ5TYbfxnBoCYuC6dKsX9E4epqY8C3wgXx/4gh2wdIHb+Hk1S5G6joCAQpbty8VuBseeNhRYhmz8Tm3e0JCxpD9D+w7ZQ8CZArDQ5gIDU4hqfehaY04JTMB6vajrRe6WK3zjx3rYdQ== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt When xfs_attri_remove_iter() was removed, so was the call to the trace event xfs_attr_node_removename. As trace events can take up to 5K in memory for text and meta data regardless if they are used or not, they should not be created when unused. Remove the unused event. Fixes: 59782a236b622 ("xfs: remove xfs_attri_remove_iter") Reviewed-by: Christoph Hellwig Signed-off-by: Steven Rostedt (Google) --- fs/xfs/xfs_trace.h | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index d41513c76652..41a46f7d3fd6 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h @@ -2465,7 +2465,6 @@ DEFINE_ATTR_EVENT(xfs_attr_leaf_toosmall); DEFINE_ATTR_EVENT(xfs_attr_node_addname); DEFINE_ATTR_EVENT(xfs_attr_node_get); DEFINE_ATTR_EVENT(xfs_attr_node_replace); -DEFINE_ATTR_EVENT(xfs_attr_node_removename); =20 DEFINE_ATTR_EVENT(xfs_attr_rmtval_get); =20 --=20 2.47.2 From nobody Thu Oct 9 20:24:39 2025 Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC86128851B; Mon, 16 Jun 2025 17:53:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.11 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750096384; cv=none; b=GyuxL91/uWk84laY6QAnP54Nf7YAD5Vlyh4YBegdQY0D3gODzFdvXvnEYyifVw4zR4i8s04EoZsIiyLe+ZfUBC92isJaocWkrlZrpOcWMyNxujJYURAAeDyFBGLE9Zq50ibws7GBRU5NaZGmEY5pYtVj+M8aEpLc7m5RjAudKWA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750096384; c=relaxed/simple; bh=Ft7TEOjSPV7cu5J28HR+aHJg0uFasyhK+kE65FHn+Ig=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=J7Ym0liZRpzlbQKQqv9k3AMcLxoB/YliCvDC0NBr5ji5F2ftrII7XYK2RwAtxH4bMrBtuDPhIUvnVPHLEBkVYcNEd0wbat1ZG6MV3tMWBOCFNKxuRZRVZbzXApo3khUYG0LrS+rEexO+B6NRBI/xi7HkwazPeJr4AxR4dOZWX1g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9BBAF120A41; Mon, 16 Jun 2025 17:52:55 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: nevets@goodmis.org) by omf05.hostedemail.com (Postfix) with ESMTPA id D65BD20015; Mon, 16 Jun 2025 17:52:53 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1uRE0w-00000001KWf-00a0; Mon, 16 Jun 2025 13:52:58 -0400 Message-ID: <20250616175257.853108895@goodmis.org> User-Agent: quilt/0.68 Date: Mon, 16 Jun 2025 13:51:54 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Carlos Maiolino , Christoph Hellwig , "Darrick J. Wong" Subject: [PATCH v2 08/13] xfs: remove unused event xfs_alloc_near_error References: <20250616175146.813055227@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Rspamd-Server: rspamout03 X-Rspamd-Queue-Id: D65BD20015 X-Stat-Signature: ij5anbu7ccs4okso3kid1ywa3nzqif9w X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX1/T7ax2EFuzHCt0wI5Y2fSq6akM66aq+fc= X-HE-Tag: 1750096373-849181 X-HE-Meta: U2FsdGVkX18i5CCehyCiL2XsJ/BA3vsQeKcflUX5hUhOe5rHnnSd5uev1svm4VOQw8PGPzU3xTq2/I/8Rio3glXWjTvY1tXubHnDNzaNUQBXclqKUVeLdJ3zFfaFcEwRvMrzIhxcYyfZUqiwo7TmdmTmZLAav1G4tVfOgBKzF8wfbiIhW+FD97YGolaybV8cL5jA1nebplXSAzdxH5/Vtfgm4e5CaZuC7n5RxtPzBjSFv/B9Z1yiQrvr66/Vi2KuEJfrwGC7V0sxzzgKWKw5v3tOTIJD1uYFmwomXVWDrIo+ic3EsoredO1m1MZbOIYg7J4+ywcL7rsMaghjnVK8ztJqeNh3EmD/rEshD9lq+PaYEp1GNTUKq91fTfo749vMBCRMAqPhMvhL/ItXKg0Z4A== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt Trace events take up to 5K of memory in text and meta data regardless if they are used or not. The call to the event xfs_alloc_near_error was removed when the cursor data structure allocation was introduced. Remove it as it is no longer used and is just wasting memory. Fixes: f5e7dbea1e3e ("xfs: introduce allocation cursor data structure") Reviewed-by: Christoph Hellwig Signed-off-by: Steven Rostedt (Google) --- fs/xfs/xfs_trace.h | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index 41a46f7d3fd6..d4004e21d0c5 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h @@ -2270,7 +2270,6 @@ DEFINE_ALLOC_EVENT(xfs_alloc_cur_right); DEFINE_ALLOC_EVENT(xfs_alloc_cur_left); DEFINE_ALLOC_EVENT(xfs_alloc_cur_lookup); DEFINE_ALLOC_EVENT(xfs_alloc_cur_lookup_done); -DEFINE_ALLOC_EVENT(xfs_alloc_near_error); DEFINE_ALLOC_EVENT(xfs_alloc_near_noentry); DEFINE_ALLOC_EVENT(xfs_alloc_near_busy); DEFINE_ALLOC_EVENT(xfs_alloc_size_neither); --=20 2.47.2 From nobody Thu Oct 9 20:24:39 2025 Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BD7328A1FB; Mon, 16 Jun 2025 17:53:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750096384; cv=none; b=iuvjd3uNTEKtuZeSR9e5nDcipFR1ZnbuQK0VuoosedFknlZBXj6/qtZxmMcwpvXh0DI/A0IHQBVCPeZhG8KKH5XEVSP5sfH9BNqv0SYrfB0vLR9r3cSpCAXkyLbtnp+XNjWyjfzMnV9CjG9gAakDRdVs01x57b1b/JrAkzE0f3E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750096384; c=relaxed/simple; bh=i+CoklhNPTZlyBGELwP5bgp/Wx8ljmmgLCWiZeodKzo=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=H2JtaJBTx+aXGlq6CMU9j5i4T453kloqDBhLZPoMY0siQ6YQx7umWmrfqLmC9oejQX379u14dO8wZJM7v/tdo9kfypyTWTfoB7qCJqDaxTUgh33M6nsZP7/pfp5f2w125/cEnpYnJnMjAdHRwJTetdO/GmlQYslD8QOoF1LOoyI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BE7A3160B21; Mon, 16 Jun 2025 17:52:55 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: nevets@goodmis.org) by omf19.hostedemail.com (Postfix) with ESMTPA id 1F0C420025; Mon, 16 Jun 2025 17:52:54 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1uRE0w-00000001KX9-0j0E; Mon, 16 Jun 2025 13:52:58 -0400 Message-ID: <20250616175258.024016837@goodmis.org> User-Agent: quilt/0.68 Date: Mon, 16 Jun 2025 13:51:55 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Carlos Maiolino , Christoph Hellwig , "Darrick J. Wong" Subject: [PATCH v2 09/13] xfs: remove unused event xfs_alloc_near_nominleft References: <20250616175146.813055227@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Rspamd-Queue-Id: 1F0C420025 X-Stat-Signature: n3a5bwfaoscfibin975f3cy44cikygbg X-Rspamd-Server: rspamout05 X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX1/IAnkaE8ud73P6we2ApRJ90HVFxyCEstw= X-HE-Tag: 1750096374-701067 X-HE-Meta: U2FsdGVkX1/DSoo6pXCozlPWTe7Ctr3VwfFOXe5KFNbjQK3QrR5caycVfAvX51SVkDc5yxxRdS0oXryM1ZRTaz82VtsHgW6qJMMgsxkjk2Y9RF5kK9XAKJfwJHnVcmLqeOJB3dCkkG72skTsrNbLCWqR61QPT1K5qTV52NCbxxtgkETTnNNVs3StrW/b7sF8kd1zFqpGhrJ6qPykwGjlEW0R4TPlkAv3DWAai5fCPPa8FYg835v+PZN1UqB0/cOAj7W8W2iMSycngDFC4uVaD87iURz9LrvUdb62u2x4ciJcmpQycvhu7sVzY/SD/M8saj7CZcpIcjVeEQbFeM4q7rayi6JYEWkaMweebPpl0hSjxZC+5njwkDsPji8AtPOaCVXLR2xIf7l3nbeC4hkutg== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt When the function xfs_alloc_space_available() was restructured, it removed the only calls to the trace event xfs_alloc_near_nominleft. As trace events take up to 5K of memory for text and meta data for each event, they should not be created when not used. Remove this unused event. Fixes: 54fee133ad59 ("xfs: adjust allocation length in xfs_alloc_space_avai= lable") Reviewed-by: Christoph Hellwig Signed-off-by: Steven Rostedt (Google) --- fs/xfs/xfs_trace.h | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index d4004e21d0c5..e629ee44a9a1 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h @@ -2263,7 +2263,6 @@ DEFINE_EVENT(xfs_alloc_class, name, \ DEFINE_ALLOC_EVENT(xfs_alloc_exact_done); DEFINE_ALLOC_EVENT(xfs_alloc_exact_notfound); DEFINE_ALLOC_EVENT(xfs_alloc_exact_error); -DEFINE_ALLOC_EVENT(xfs_alloc_near_nominleft); DEFINE_ALLOC_EVENT(xfs_alloc_near_first); DEFINE_ALLOC_EVENT(xfs_alloc_cur); DEFINE_ALLOC_EVENT(xfs_alloc_cur_right); --=20 2.47.2 From nobody Thu Oct 9 20:24:39 2025 Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDA2A288532; Mon, 16 Jun 2025 17:52:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.14 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750096379; cv=none; b=D9vNyU264oA2T3NNOP2qUcNvrxOMBee7xlLwHtRh7YJ0pYZVb/R0CfzB/akQIr0uiz40Kb/hMIjoHODXoBrbnKmCVUI4nakUrtU1Sp5TqH4Bm6E22WGdwHFf2inbt3/qrXZ3rdFkVIqXn0TVN4dAWgHxvQPcHT9IbTrgKtfvDms= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750096379; c=relaxed/simple; bh=nXjhwOy8tzQp6nc5tHLyk3cIZz5UAvrds1r3i5/ROJg=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=Mw+lNVY5IBlqTsPidHcoPryNMoEXDwNaQWO3vBwz80GOpCt+/aknaMvLGGMq/KSMsdDO1WTcfrHGvqbvJHLaoGnhBfJvm3v4sg1V+edZDOQ9cHxBC5dLCyVuibY8dsanYBQnjjfNQ4bW/AkIyi6gHR9l7ljNL6nQCrma/yGiMMo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DD0B8101393; Mon, 16 Jun 2025 17:52:55 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: nevets@goodmis.org) by omf01.hostedemail.com (Postfix) with ESMTPA id 33D346000F; Mon, 16 Jun 2025 17:52:54 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1uRE0w-00000001KXd-1Rrk; Mon, 16 Jun 2025 13:52:58 -0400 Message-ID: <20250616175258.192340775@goodmis.org> User-Agent: quilt/0.68 Date: Mon, 16 Jun 2025 13:51:56 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Carlos Maiolino , Christoph Hellwig , "Darrick J. Wong" Subject: [PATCH v2 10/13] xfs: remove unused event xfs_pagecache_inval References: <20250616175146.813055227@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Rspamd-Queue-Id: 33D346000F X-Stat-Signature: odzq8fcughxp5x6gyewd9xsj8otacz9y X-Rspamd-Server: rspamout05 X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX1+gCdUWe4wjocQ+NG57bKJaUPrzIofJ22o= X-HE-Tag: 1750096374-455171 X-HE-Meta: U2FsdGVkX1+HVuVCc+xnFo/FfJVkUtB09FX+HzAbr6wW9RL2lRvbDEq4HRPyDqzzvClHvdmm8W2qmNxuF1SYRQuYtTLOE9+pbJjzYIBdIOgkLnp8NOh0qWL9aI1E5p7SPz84MDdmxJoXBgdo8VLeYTrtNO8Ws+9ylHA/iLHP4jroNuuMBg47WFiu34sJN1qCnccbMQtv7b3ScE251L7pZn/3kpgj0UsFvlUwXwyBM7fxW1DeR6aaZPZGTeLEd4I8uUBm7/wLfrTSJrjwxtbhvAyQaJ9W46i7ChAy7FyI2782nCq1kWCh7W0uE9qY9nja8oZ110/SvtQq16vZDdpN0+8ZQqWRyOH/m5ygidHKBwQQlLMln3kiyse0SQErwKheFwK/5K63LcxXFPCXCrC1Qg== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt When the function xfs_flushinval_pages() was removed, it removed the only caller to the trace event xfs_pagecache_inval. As trace events can take up to 5K of memory in text and meta data each regardless if they are used or not, they should not be created when unused. Remove the unused event. Fixes: fb59581404ab ("xfs: remove xfs_flushinval_pages") Reviewed-by: Christoph Hellwig Signed-off-by: Steven Rostedt (Google) --- fs/xfs/xfs_trace.h | 25 ------------------------- 1 file changed, 25 deletions(-) diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index e629ee44a9a1..098ef23598fe 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h @@ -1893,31 +1893,6 @@ DEFINE_EVENT(xfs_itrunc_class, name, \ DEFINE_ITRUNC_EVENT(xfs_itruncate_extents_start); DEFINE_ITRUNC_EVENT(xfs_itruncate_extents_end); =20 -TRACE_EVENT(xfs_pagecache_inval, - TP_PROTO(struct xfs_inode *ip, xfs_off_t start, xfs_off_t finish), - TP_ARGS(ip, start, finish), - TP_STRUCT__entry( - __field(dev_t, dev) - __field(xfs_ino_t, ino) - __field(xfs_fsize_t, size) - __field(xfs_off_t, start) - __field(xfs_off_t, finish) - ), - TP_fast_assign( - __entry->dev =3D VFS_I(ip)->i_sb->s_dev; - __entry->ino =3D ip->i_ino; - __entry->size =3D ip->i_disk_size; - __entry->start =3D start; - __entry->finish =3D finish; - ), - TP_printk("dev %d:%d ino 0x%llx disize 0x%llx start 0x%llx finish 0x%llx", - MAJOR(__entry->dev), MINOR(__entry->dev), - __entry->ino, - __entry->size, - __entry->start, - __entry->finish) -); - TRACE_EVENT(xfs_bunmap, TP_PROTO(struct xfs_inode *ip, xfs_fileoff_t fileoff, xfs_filblks_t len, int flags, unsigned long caller_ip), --=20 2.47.2 From nobody Thu Oct 9 20:24:39 2025 Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D127728A700; Mon, 16 Jun 2025 17:53:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750096385; cv=none; b=DSxt+yf2E3spudvw56xfZSa9YA04j3NsIRhKjBbqO+wIWEFEN29rCLQqm1yjS8zrWloDdJtKNeVkBU8O02ifahn6UM2KygI/a2Wasp7bwWb3zLXCLbRHHk8naXQZsplBnC7ypwiXCTlIVthhnVfQGOUsjW5l775nxDS6YCvNing= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750096385; c=relaxed/simple; bh=xbKdr4UBDoWUn/whTov2So+kzSlACZlNew8aZc77WNM=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=KadXIv2N0uEJDHoOnhN4Q1YwN1uvcn8Gxyq4TvOAYqB827BT/+GF5wTkcWu6w2Onc+tH+kH2TEpS+nLJPPH/5inAx/WEm8bwONIWl7IqVJIpqMpSi2c18rEmF0ulihp4K5DAJn8aUTQAsRGNbC8fCJfEeoeTKVroLhWO1IxaLGY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2DD41120AF8; Mon, 16 Jun 2025 17:52:56 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: nevets@goodmis.org) by omf14.hostedemail.com (Postfix) with ESMTPA id 784192F; Mon, 16 Jun 2025 17:52:54 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1uRE0w-00000001KY7-28Nl; Mon, 16 Jun 2025 13:52:58 -0400 Message-ID: <20250616175258.365535825@goodmis.org> User-Agent: quilt/0.68 Date: Mon, 16 Jun 2025 13:51:57 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Carlos Maiolino , Christoph Hellwig , "Darrick J. Wong" Subject: [PATCH v2 11/13] xfs: remove usused xfs_end_io_direct events References: <20250616175146.813055227@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Stat-Signature: zgpj3qg3c6um4ikrwd8fpk4q8734mcy5 X-Rspamd-Server: rspamout04 X-Rspamd-Queue-Id: 784192F X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX1/4PB4uBbxO380EckpeIKqeGmX9eWdEUTE= X-HE-Tag: 1750096374-48307 X-HE-Meta: U2FsdGVkX18cnjKRSo6bVcu1N+4t8YY/rZxTl9e31jefmEE1KBHoFuJE++QxLo2jA3IzZNnxUg7MFw4ALBHHfCD3aJKKYgXxlVQdcQxNf2JTrVV6xdZ4xTQe5iv6c1okpgT5namd2ChcIaraPaQy2e1uR129MMC6Gs+cOm9dO2bv3AfEMck0rO5dwDCkQvMljxEpH7XPq67ikVBMAHZBcqJoeXla091TyA8UHaORsPV5jO7DFXQtqhQ7MmbW/uSgAPLDQeEYDdU5NddKT939YwUgYjv5YDA5r4s3CL5oIXYrzDigciLYaPQ8KxDFs2Ock1HSZ9J7N9sGTaXFkw7gHLFszAuR3bQoZc6YTE8BsbhzvAz5vpCurL+k96h05INShCCh5FkzcILup3OdJ+LRTg== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt When the use of iomap_dio_rw was added, the calls to the trace events xfs_end_io_direct_unwritten and xfs_end_io_direct_append were removed but those trace events were not. As trace events can take up to 5K in memory for text and meta data regardless if they are used or not, they should not be created when not used. Remove the unused events. Fixes: acdda3aae146 ("xfs: use iomap_dio_rw") Reviewed-by: Christoph Hellwig Signed-off-by: Steven Rostedt (Google) --- fs/xfs/xfs_trace.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index 098ef23598fe..7977af7c6873 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h @@ -1859,8 +1859,6 @@ DEFINE_SIMPLE_IO_EVENT(xfs_unwritten_convert); DEFINE_SIMPLE_IO_EVENT(xfs_setfilesize); DEFINE_SIMPLE_IO_EVENT(xfs_zero_eof); DEFINE_SIMPLE_IO_EVENT(xfs_end_io_direct_write); -DEFINE_SIMPLE_IO_EVENT(xfs_end_io_direct_write_unwritten); -DEFINE_SIMPLE_IO_EVENT(xfs_end_io_direct_write_append); DEFINE_SIMPLE_IO_EVENT(xfs_file_splice_read); DEFINE_SIMPLE_IO_EVENT(xfs_zoned_map_blocks); =20 --=20 2.47.2 From nobody Thu Oct 9 20:24:39 2025 Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABF4F288CB5; Mon, 16 Jun 2025 17:53:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750096386; cv=none; b=CVqajuLXT9+aRBSL84LI4k2gzk03A2gJZBlzSvki+Z9Ln82SmQgoPYfyL+V1+Fq1IVHlZg2UqskDFIfTOCyRL55jXzy00XRX5GgzvJs6W9781X2WwzsQUE3n+0YzS/l7rKu0vFTP2AfM1LNL4GZyPo5SLPhqMZlW4k4hFftpjy4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750096386; c=relaxed/simple; bh=NKxXMIXzsSM7kZFMLFM188WPZyVP6ERPHjmDt7Sjzjs=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=fpHQuu932OxxyUbPy77WaGW8PpIZ/uvoxOWmghbAGFmV3gWwclWc72QjDmoiLNMoAL4zWaq3Skg4UInXs3tJchCiUvDxYqJpdExT13KPNvusgXXKulgLIfMCDacUXk3/jCKL+jMfIyeihSZASGUmOaEhRUVYQFfiuj96fFORNaw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 415D6101344; Mon, 16 Jun 2025 17:52:56 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: nevets@goodmis.org) by omf14.hostedemail.com (Postfix) with ESMTPA id 8CF2C30; Mon, 16 Jun 2025 17:52:54 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1uRE0w-00000001KYc-2opA; Mon, 16 Jun 2025 13:52:58 -0400 Message-ID: <20250616175258.528614307@goodmis.org> User-Agent: quilt/0.68 Date: Mon, 16 Jun 2025 13:51:58 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Carlos Maiolino , Christoph Hellwig , "Darrick J. Wong" Subject: [PATCH v2 12/13] xfs: only create event xfs_file_compat_ioctl when CONFIG_COMPAT is configure References: <20250616175146.813055227@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Stat-Signature: bnkzq5i39athu4785ruc1wcg5jzjpyxf X-Rspamd-Server: rspamout02 X-Rspamd-Queue-Id: 8CF2C30 X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX1+QZfLrgkevSGG6U4TZA9OYfpnsSZdbJIs= X-HE-Tag: 1750096374-221371 X-HE-Meta: U2FsdGVkX19px8Fb8CkmNOiT1mEhlKTs0+8gaUgB8JXJqdaV4kFMqKW0pxevEZdglKLijc1+Xx4sDGHqlQ+8wkRiO5VyWNfrSLWT83FApzx/xlzL+Lo2dyK4fdgy/Fi6lK8ReI3xvUnIOK6Av6HNYgrOlTKtTk+9Jjt3gOTyQFO9yzoX4X0Y+Jy10Phl6AO+5O9PehVjceE4CorDoZfLEVULnXEFu8ADrSe+12MKRMT7SHXtP2gZA58ElcDPce543jIFtqNGzmFFjSQ40HOMofWl6Uqof7gquiJWvsBsSbKoGFpfxtIu0Hlf5iM1DkOgKb/L085+uV1sELqTr5Ayho2Cb5V7rWEHcBRXji2cDfXBOwLYz3qc9Tf1Dd/yzs+lFBwbiPFva8RW2V5p8J9HSw== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt The trace event xfs_file_compat_ioctl is only used when CONFIG_COMPAT is configured in the build. As trace events can take up to 5K in memory for text and meta data regardless if they are used, they should not be created when unused. Add #ifdef CONFIG_COMPAT around the event so that it is only created when that is configured. Fixes: cca28fb83d9e6 ("xfs: split xfs_itrace_entry") Reviewed-by: Christoph Hellwig Signed-off-by: Steven Rostedt (Google) --- fs/xfs/xfs_trace.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index 7977af7c6873..448dea97a052 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h @@ -1083,7 +1083,9 @@ DEFINE_INODE_EVENT(xfs_get_acl); #endif DEFINE_INODE_EVENT(xfs_vm_bmap); DEFINE_INODE_EVENT(xfs_file_ioctl); +#ifdef CONFIG_COMPAT DEFINE_INODE_EVENT(xfs_file_compat_ioctl); +#endif DEFINE_INODE_EVENT(xfs_ioctl_setattr); DEFINE_INODE_EVENT(xfs_dir_fsync); DEFINE_INODE_EVENT(xfs_file_fsync); --=20 2.47.2 From nobody Thu Oct 9 20:24:39 2025 Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4219E288C2D; Mon, 16 Jun 2025 17:52:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750096380; cv=none; b=RCU7tCw0fgzlG/YJcRltPrUj6HZpyAGoICeq7gJ+P9eAGja97R5xT4wcbCWc4NvcF0SIcKNawLueuH/Vw6mv5EPiimt8LnJh/aMI7j5obFbsSbihhCI1sFkIGhCzRApCmrbvC+INUHxw6N8UP2K5iyCvT/ApjsVk1TN2A8Wg6zE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750096380; c=relaxed/simple; bh=GkX6+5ssbSsWC2eRweu5p5dS6b/weFQGhxl3Vz1yWm4=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=scRzjFWl2njWgnCzZ04rY67l5OFJNlDrHObsiZsM0GoTGZmYnP/oir+EaSFiefQxExxaLe1wyc3MUJp3l+7YQ2fgvfuVryGrVu5Lq1Ojfkn9oizaG+e50YL+WVtWte633ILTUqhKPBArGDDp4XkBN84q4A3WOLLZ6yGO02GGmKI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 98518C0AF9; Mon, 16 Jun 2025 17:52:56 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: nevets@goodmis.org) by omf11.hostedemail.com (Postfix) with ESMTPA id CFDA12002C; Mon, 16 Jun 2025 17:52:54 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1uRE0w-00000001KZ6-3XJ8; Mon, 16 Jun 2025 13:52:58 -0400 Message-ID: <20250616175258.691664401@goodmis.org> User-Agent: quilt/0.68 Date: Mon, 16 Jun 2025 13:51:59 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Carlos Maiolino , Christoph Hellwig , "Darrick J. Wong" Subject: [PATCH v2 13/13] xfs: change xfs_xattr_class from a TRACE_EVENT() to DECLARE_EVENT_CLASS() References: <20250616175146.813055227@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Rspamd-Queue-Id: CFDA12002C X-Stat-Signature: 6151eycwd9aj61x8fugb3hnroagoiz49 X-Rspamd-Server: rspamout05 X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX19GNZDWZ6rXSZs0MgWJEFXBUVhlRJNZ5b4= X-HE-Tag: 1750096374-804361 X-HE-Meta: U2FsdGVkX1+g5hTChwKkEzGc6weI1MJjDnZc/XzwPe7Mykeii7LOaV5B+syfA7Zl0zJ6NUf6pv49P1IZ89eBtI94uTBoT/jLlWB26uu+EeNbBhvXSr2gngHPGIV+yAtoRtO+dwLs4z0L7GnlBKbp8cf7Xm0pGaoIIpSrJs45tQ/gjUacW8fxzL8b9jhWLHm/iUGRSwFQhBZcp7UBd9lQqtz8Mlt3JOkvZoS9iSzhbQqlbb8aCyZs/tMHyot7vmZqeVoU6nP1eAZcZFL2qc9DNpgBcbEf/mO4jEgBb97lizzVEFRKwCzvEt9ZGJxs9baTbxngz1//Kh48zSyuXEStKdTMtyHCGMMt2gn8aj7CgGcndRXmB1SiZK+Nwq2eIkE4tQ0FfbIredHRI+PhKSeAfw== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt xfs_xattr_class was accidentally created as a TRACE_EVENT() instead of a class with DECLARE_EVENT_CLASS(). Note, TRACE_EVENT() is just defined as: #define TRACE_EVENT(name, proto, args, tstruct, assign, print) \ DECLARE_EVENT_CLASS(name, \ PARAMS(proto), \ PARAMS(args), \ PARAMS(tstruct), \ PARAMS(assign), \ PARAMS(print)); \ DEFINE_EVENT(name, name, PARAMS(proto), PARAMS(args)); The difference between TRACE_EVENT() and DECLARE_EVENT_CLASS() is that TRACE_EVENT() also creates an event with the class name. Switch xfs_xattr_class over to being a class and not an event as it is not called directly, and that event with the class name takes up unnecessary memory. Fixes: e47dcf113ae3 ("xfs: repair extended attributes") Reviewed-by: Christoph Hellwig Signed-off-by: Steven Rostedt (Google) --- fs/xfs/scrub/trace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/xfs/scrub/trace.h b/fs/xfs/scrub/trace.h index d7c4ced47c15..1e6e9c10cea2 100644 --- a/fs/xfs/scrub/trace.h +++ b/fs/xfs/scrub/trace.h @@ -2996,7 +2996,7 @@ DEFINE_EVENT(xrep_pptr_salvage_class, name, \ DEFINE_XREP_PPTR_SALVAGE_EVENT(xrep_xattr_salvage_pptr); DEFINE_XREP_PPTR_SALVAGE_EVENT(xrep_xattr_insert_pptr); =20 -TRACE_EVENT(xrep_xattr_class, +DECLARE_EVENT_CLASS(xrep_xattr_class, TP_PROTO(struct xfs_inode *ip, struct xfs_inode *arg_ip), TP_ARGS(ip, arg_ip), TP_STRUCT__entry( --=20 2.47.2