From nobody Thu Oct 9 20:24:07 2025 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FF701CAA7B for ; Mon, 16 Jun 2025 13:45:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750081510; cv=none; b=TnBNJ9jsCt2WoKDzKLhh0aOQrgXqDKP6N6QqYuer8xYlKM3xxMBezcTL9T9PzLUgn5WVYlveeRG40mwcgfCNEOYAbwu6JrdK907ewyQ4+bBQanLVzxfKf9cUU1gqrPVV3HoV7KC3qHMhu8vU2c2SF6wT8EeQrBycnThd1ogVFjI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750081510; c=relaxed/simple; bh=AdS+arxO8XumTfc4Ek9XDyozfm6YJV3DV8vsb/NStv0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=ceQxxPz22z+UoHUA/B573LfvWcwPIvAl8Awd/nqolLPRIXxOPBi93KkXHOVW0J9X2MZHFnrvD+PARJEiAPFzszakjRHwTJ1yeGLt9MNxTJONmD+BB2w36jXNocEoleKFl9RO9esjBaTk/gQJQ/CMc8wyvLpVnF9kM8/rsPM0JXw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1uRA94-0004WZ-Bc; Mon, 16 Jun 2025 15:45:06 +0200 Received: from dude02.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::28]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uRA94-003odn-0Y; Mon, 16 Jun 2025 15:45:06 +0200 Received: from localhost ([::1] helo=dude02.red.stw.pengutronix.de) by dude02.red.stw.pengutronix.de with esmtp (Exim 4.96) (envelope-from ) id 1uRA94-0052aa-0A; Mon, 16 Jun 2025 15:45:06 +0200 From: Sascha Hauer To: linux-gpio@vger.kernel.org Cc: Linus Walleij , Bartosz Golaszewski , linux-kernel@vger.kernel.org, Sascha Hauer Subject: [PATCH] gpio: pca953x: fix wrong error probe return value Date: Mon, 16 Jun 2025 15:45:03 +0200 Message-Id: <20250616134503.1201138-1-s.hauer@pengutronix.de> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: s.hauer@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The second argument to dev_err_probe() is the error value. Pass the return value of devm_request_threaded_irq() there instead of the irq number. Signed-off-by: Sascha Hauer --- drivers/gpio/gpio-pca953x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c index b852e49976294..e80a96f397885 100644 --- a/drivers/gpio/gpio-pca953x.c +++ b/drivers/gpio/gpio-pca953x.c @@ -974,7 +974,7 @@ static int pca953x_irq_setup(struct pca953x_chip *chip,= int irq_base) IRQF_ONESHOT | IRQF_SHARED, dev_name(dev), chip); if (ret) - return dev_err_probe(dev, client->irq, "failed to request irq\n"); + return dev_err_probe(dev, ret, "failed to request irq\n"); =20 return 0; } --=20 2.39.5