From nobody Thu Oct 9 20:25:17 2025 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11010028.outbound.protection.outlook.com [52.101.69.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBE57272E45; Mon, 16 Jun 2025 08:59:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750064385; cv=fail; b=sDqqVXEWVDkgfrm30MvHrFBQUtGnnN5ncsjGmObQ8VOknqxWPb+4/vig2xVb4jWdcVeG5YiJnk+Q8qmtQK3RBktfNsdbIshkMoMatgj2E0JW4QwqHBU/dNGJRsWDYVP093ttMDilQvNfv6IGNZltKMZ9Z+0OKnnk+dWLRbnSySk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750064385; c=relaxed/simple; bh=aEhftXLroRRrIl+HubJSu0Lq8tymz+PFM6qlki4vaok=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=mP81DWhwG94yYnDaNdKpXFTE4XH6AWpl/4FKTzjmJwKoGOgzlTFIrZpHXkCvWyEL000iubDH3nPCDr22mrsZjLM8mPwGI7vIAQV50dClCNcFn3Q03b82XC+C9TJ8aN1l4LNYKokMDDohLHSJise6r6ivIizSiMrsn8vHUOv36fI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=i6vRMVDD; arc=fail smtp.client-ip=52.101.69.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="i6vRMVDD" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PWkQl/CT6EKKFwggtPmbrJv7DCbT0ntJfiViQiUHNhrGzUGUSnqep+/RPr62P8j8LV2FaanMhAg/TJh65Q0liQM6w0RQNT7GcWc7+NO5VvkU3krWIx14csVoWBjBKGI9Ql8HnRP9TW9VcqXR4T758Vls4/sNR4NL+trKfHXIja4epjKWvlMOPvCftCdObBpAsbdDbGkuxF9wXtWWkMd2vl1mcSVAUUg9i2paK/XVpqmJJQgEU3zTyBen0yLK4vL3uUuihWBv2eYEULFYqdLny20gFGGT90w2yit84va7RU7yU7PSwyZrUZt2k/2HPIxNnAsVeZmITdLLM7Lo49OVWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aF/po2uWP1zndEMFb9dodo89Y3APF+ETHMsaG3RT6SY=; b=wPRFVAdU1+ub1LYQZ4vLp306guilUB0H5frZ/t8h52/5J1A2dk/l5o/0AWPkNc0Ymiq05EtZKGMo1jLJtnMim9ANUmBMzjb254YpSGxau/7DdcihSh0LeyKNPpWeu+9iu7Eb8/IZrC0IXLpcuY+JnprzSHDJnB9r9vyr7tfOIg2IOWgXoRv0xmF2ODebyqew78+DCdS2BVL/fcO55hWfXnsgvSEGMVGhI0nxjzb3974DVazpyvsB7PgsSu2v+FwHCi8ftH/Bo+055MtuDES6GotxaXuHJ5Y+jdPzcGTR/vYlVJR7Jrr2Gt0Z79Qo9hzUSd6P5RjRrHGjLJ9aT37d9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aF/po2uWP1zndEMFb9dodo89Y3APF+ETHMsaG3RT6SY=; b=i6vRMVDDV7Ja0w152DHQbVN1CbxDKCfeQNYUeRXNLzhPpfL8whzwaI5TjScXVXvJMyLKRNy6Rx2mnQDAeThOS3buJRwq6rTa5hdUjmK3Cu25uMz3l0P6EKprKRp/qtNXDc8b0LP8mbyKXeJdfE2Dtic0L6SDLtgwfRmnkNW/lGb0p7ZB4SsYIF0mUXOWaXEEVdBjq/6fnR3m1jFq8HIQQaqiEZ6Y7ItLjPIeV5F2qfmt5HegpbMhGAdT7o3Kqxw1REzzMtkUCEJtqeIqCgCom1La7ZM7nnPQfal9QQlFV5ahIQ/uabNPA+brkYNSPJO0kUACI05IGv9HT2CjWI49uA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8676.eurprd04.prod.outlook.com (2603:10a6:20b:42b::10) by PA4PR04MB7712.eurprd04.prod.outlook.com (2603:10a6:102:ec::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.29; Mon, 16 Jun 2025 08:59:40 +0000 Received: from AS8PR04MB8676.eurprd04.prod.outlook.com ([fe80::28b2:de72:ad25:5d93]) by AS8PR04MB8676.eurprd04.prod.outlook.com ([fe80::28b2:de72:ad25:5d93%4]) with mapi id 15.20.8835.027; Mon, 16 Jun 2025 08:59:40 +0000 From: Richard Zhu To: frank.li@nxp.com, l.stach@pengutronix.de, lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, robh@kernel.org, bhelgaas@google.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, Richard Zhu , Tim Harvey , Frank Li Subject: [PATCH v3 1/2] PCI: imx6: Remove apps_reset toggle in _core_reset functions Date: Mon, 16 Jun 2025 16:57:41 +0800 Message-Id: <20250616085742.2684742-2-hongxing.zhu@nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20250616085742.2684742-1-hongxing.zhu@nxp.com> References: <20250616085742.2684742-1-hongxing.zhu@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI2PR02CA0025.apcprd02.prod.outlook.com (2603:1096:4:195::21) To AS8PR04MB8676.eurprd04.prod.outlook.com (2603:10a6:20b:42b::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8676:EE_|PA4PR04MB7712:EE_ X-MS-Office365-Filtering-Correlation-Id: 2ebe3bd5-a0b7-4f7c-e405-08ddacb42105 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|7416014|376014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?897Xg5sO0Lv7jWkX2j3rnUtpWCDfvLie1RCegRU5Xkm70AT7mMCIyTp0qyRo?= =?us-ascii?Q?JkYjGuTV2oV94olKLkkCKPMvl6fyohsH99/rutXMwYp1y1A0x/9B5haqziOa?= =?us-ascii?Q?sS8D1eNMJxlSUr42xXlm0yC4VMMSmYgqwMrJdUMSXNMUyk8ooZF0kah0kg9j?= =?us-ascii?Q?wqjgSzhDUxIakLYEXqA6vMIU5nUaE20HSTKjllm38NCFE9uUkNPsBkCmNDiA?= =?us-ascii?Q?+IDeaC3ZB4e2kVWQPT90Gcerg8VukiWTkwbBVYVMFf1pf/YTs60Qjl/UQgLQ?= =?us-ascii?Q?8pitQHavnReSwdR0MTbzV0HBI92fctxUhIDL346uN7qUtfCX9Bm/0K12/pcJ?= =?us-ascii?Q?GgSzXb19aBnztTLVr/ZRjnN5JW9UZZ9q3fJvIvgF1zm9pFkT9ciMy0j5RoaG?= =?us-ascii?Q?ESrMgTm04/1XsI51uBygWyGAzJeS3uwywxnrxzNrYx2+ZuoWPUEeA4ri77FO?= =?us-ascii?Q?hHwnAszBAPEVC4i7G2xoiulb/oousnVw42pa9wFZmHVM/s6oylBH1L48veux?= =?us-ascii?Q?VZejYwocCXMyQIs960drNU1evWXOPRhGSq+x6McOsaeSAGyujRlIFMLg5zyZ?= =?us-ascii?Q?gyHmVsa31PCsh6hbJOA7WN16SmG/7LqYVV1BWXWdzUMF/d0pfWEErvHUYYTD?= =?us-ascii?Q?1QfzAHkbN81j85XOk37dJZqRwrQS/NqweRNZ7fpKhSd5gma3rMxmcG0mjDwv?= =?us-ascii?Q?BX8p3OuJwYGDLO431R2kmrKQ33j+bNfuVrmA/6pMMpiC7IjCfhFOxRkbt5jW?= =?us-ascii?Q?94FceLeqGlz/b4ZoqU9uCbpIJlDg19rR+T+EzpyYqYF1JsPcut86v9IE4IdF?= =?us-ascii?Q?p5MdLtJt+sZpkAIX+QKvvThDhBsUdH/3e0ZAgVWuIGQXcZUavOnq0HnJ18YT?= =?us-ascii?Q?NQPMYPFShXZzqVWMe9VGCgSxzHRk6d3PY5+oWsRbc/j7AOaEKeie3Zffod6b?= =?us-ascii?Q?GrxfMlwJ8V4wwhDhIV8k2pFDMCisJqw9rqFqkYSm2Tuiu83jtonCwsJ4wOsg?= =?us-ascii?Q?cgvOlvAvkt8R1Z8YK0iigc8cWf98rYpP2K1I9DlPMSx8NKHaooM2XpbDx13a?= =?us-ascii?Q?mS3ADqlkN2OY1FT7bloiBvky6ZZeV+R0GwIkcRXsfYCNe3xQOIVNchy1y4Yo?= =?us-ascii?Q?Vqc0EqFpI7xX3HZJIkdJOcw/flrdj05rt3v9ESCaK/e9/WQFKzNpSzZEPyyn?= =?us-ascii?Q?IGYWGdcVHZzTGGSicfsBFS4pCe3LHVWWZVebJ3srPJBFj3NoFwryRqHWpyG9?= =?us-ascii?Q?4ikYhk+inzbP4/xSiSpQs24Gaan5Ef5f0oJQBJCzhVbE5XJcnHbcbmXt1ck5?= =?us-ascii?Q?MBzsqJSTT9gVeuPZz72Glh1gmIuGfjvM8iKyt7qDNo003EHEYujqEKTNNDm7?= =?us-ascii?Q?hL0PvciL0UYDCHxazdjHORwmMm/VeTomysgJ42/W32QAqDWF72K/e9/yniVe?= =?us-ascii?Q?iHKt3eL1JlvDPWaint9aRuvTzIrlkD8Y?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8676.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(7416014)(376014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?48sSjpKcoe3j6oYgaw9SNVcIOQoEMBAx267TkZBrEybrl4FFBtTOURHKYmWB?= =?us-ascii?Q?H1xrQliurytVjwQtQR9lTAPDYyEVzp4dRhGqpIFGHCJf9ZENtLjC1UoLphhy?= =?us-ascii?Q?RseiUJmbQBho0vfa0dT3lf+7G3EGPlgxu/RK18aS8Y3lrPnJdcj9p7DL3KIu?= =?us-ascii?Q?9abl5i7WOVsj9Pw5q+te6pJD0k77wwTCX8VP9xUOTsUp+diER31BgCXSTND4?= =?us-ascii?Q?/B7qrejEEYVMXEwdJ/kEGDcbwJdfQkbqiWSFGmDhe0ziKhzoMFcCFy1FnkAS?= =?us-ascii?Q?j4b0MJO7Z6CVGlyPfU+47hH7CD1f132bO6Im40SqbrwrUu8K4SjFeigycCCx?= =?us-ascii?Q?GHE6a3kgU6YAtQnojb1uHD5XBTttcql45s8Rba6tvzWQpy05lTcPTHvm7flt?= =?us-ascii?Q?7VuIsgvodaMvVf739jQ2DziQc4y6d2zsbtcNCJ3Iun4ov+9YHu0QPBMf93wW?= =?us-ascii?Q?sbmRsErLRzNLlkmXBGl78tYOZA2KnO5eFQZ0JGJ+jefGNy6SIGCj7bPNAIdr?= =?us-ascii?Q?ADMjSrQNvZ33npNiNykBS39BZyemwRv1lzl8VdFIfnAL66su0wgkay4T+1mr?= =?us-ascii?Q?KArhauoNuq5yyjglVHLzUerLu8meQLr13A3PylP/WsMC7bfdBTPZh37dafyp?= =?us-ascii?Q?htHMVtI4cdFlZx4/wLQ7HTiZ5N9DLI6Okvyic/ZlFiMCG0fTWcLxR+W3jmPn?= =?us-ascii?Q?Ab+MX/2VGvldEbbHvSQH9BaGeQs+7zaftO/okZQgKHSOgMv8VAKQKlTahF5s?= =?us-ascii?Q?OBWJy8MPG0/aalr9/taWwtKndXS5h/sg5X3NKT+YDNDubJA7iO3xR25RQS0p?= =?us-ascii?Q?umWyO0NdxEVwgViS/1Xoh8bSTEO7gvyyaZNoUTi+gYcDAnNUEjGBANUuxQin?= =?us-ascii?Q?T3QFNAGmVTA0iAY5qO+BKJq9V1K259hMDJG0JdiKeSye9g2kN5aK5aPDVoNG?= =?us-ascii?Q?AQ76s4Ee1MfykIoT20CODwNeqzGwzWLHmzP/vN7xt59FIEC1gAoPHHAj31rf?= =?us-ascii?Q?WEa6GwNeaEEej+teIZpkS1k6y7hIpLQWbKBU10UXvYhZLE+iO7EqnB+bgUOo?= =?us-ascii?Q?sF+me/KWDCIOL0+u5Qox+0Tor3Wh1iX/MdvHTUgQKpRYDVcMgF9iy3RIwJey?= =?us-ascii?Q?eWbfQtw+ADSpUJCGRY+/0suOm4x1Fn+oaPZmoXCtPje4F95X0ATJIdTV+txL?= =?us-ascii?Q?dleLVfTyI+5tzN6ngu8X2ltr3gYkaRi/juOLSnOUO51LzCYSqXRoCM0M8Tp8?= =?us-ascii?Q?fl2DOnlKXsbL5TeeMxZ2zICWdxF82TnIV1wW25Hw1hAPZuTanpnDoRVCzJfM?= =?us-ascii?Q?dhsNztKqnq6UbVlHWcMbDWGPZabR5EocKBkIKXwR6dnQa9vGVY0imL4VNtUu?= =?us-ascii?Q?Tk/hgyQjkLfcS1ORY8x6h6yjF/EvIXTEQwTVGK7c5JkTWyl9vPSvFsAouxcX?= =?us-ascii?Q?RMvwB2dA+5bh91Hcf87XUcaAS0tOw6df9Lh0WhcWPX0uuVh4o91vSyZcTP4z?= =?us-ascii?Q?hZ45vaBDkrcdGDr4HWP/mNOKPbJUZnK7NCzZyRkEq9le0ZIqbv1KEVv+PTEg?= =?us-ascii?Q?GWPVQkVgJyF42Wbge0+CZLN4/WIiX+gyco9wfjS2?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2ebe3bd5-a0b7-4f7c-e405-08ddacb42105 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8676.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2025 08:59:40.8255 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JjhSdWg5WnWceIbUcpgysmkCkRxfCfs15ixZqNmYeDKPq6l7Wozt6N2wx8NHz9Esg7iA1Jxl3aJiX/epYQGj3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7712 Content-Type: text/plain; charset="utf-8" apps_reset is LTSSM_EN on i.MX7, i.MX8MQ, i.MX8MM and i.MX8MP platforms. Since the assertion/de-assertion of apps_reset(LTSSM_EN bit) had been wrappered in imx_pcie_ltssm_enable() and imx_pcie_ltssm_disable(); Remove apps_reset toggle in imx_pcie_assert_core_reset() and imx_pcie_deassert_core_reset() functions. Use imx_pcie_ltssm_enable() and imx_pcie_ltssm_disable() to configure apps_reset directly. Fix fail to enumerate reliably PI7C9X2G608GP (hotplug) at i.MX8MM, which reported By Tim. Reported-by: Tim Harvey Closes: https://lore.kernel.org/all/CAJ+vNU3ohR2YKTwC4xoYrc1z-neDoH2TTZcMHD= y+poj9=3DjSy+w@mail.gmail.com/ Fixes: ef61c7d8d032 ("PCI: imx6: Deassert apps_reset in imx_pcie_deassert_c= ore_reset()") Signed-off-by: Richard Zhu Reviewed-by: Frank Li Tested-by: Tim Harvey # imx8mp-venice-gw74xx --- drivers/pci/controller/dwc/pci-imx6.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller= /dwc/pci-imx6.c index 9754cc6e09b9..f5f2ac638f4b 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -860,7 +860,6 @@ static int imx95_pcie_core_reset(struct imx_pcie *imx_p= cie, bool assert) static void imx_pcie_assert_core_reset(struct imx_pcie *imx_pcie) { reset_control_assert(imx_pcie->pciephy_reset); - reset_control_assert(imx_pcie->apps_reset); =20 if (imx_pcie->drvdata->core_reset) imx_pcie->drvdata->core_reset(imx_pcie, true); @@ -872,7 +871,6 @@ static void imx_pcie_assert_core_reset(struct imx_pcie = *imx_pcie) static int imx_pcie_deassert_core_reset(struct imx_pcie *imx_pcie) { reset_control_deassert(imx_pcie->pciephy_reset); - reset_control_deassert(imx_pcie->apps_reset); =20 if (imx_pcie->drvdata->core_reset) imx_pcie->drvdata->core_reset(imx_pcie, false); @@ -1247,6 +1245,9 @@ static int imx_pcie_host_init(struct dw_pcie_rp *pp) } } =20 + /* Make sure that PCIe LTSSM is cleared */ + imx_pcie_ltssm_disable(dev); + ret =3D imx_pcie_deassert_core_reset(imx_pcie); if (ret < 0) { dev_err(dev, "pcie deassert core reset failed: %d\n", ret); --=20 2.37.1 From nobody Thu Oct 9 20:25:17 2025 Received: from AS8PR03CU001.outbound.protection.outlook.com (mail-westeuropeazon11012021.outbound.protection.outlook.com [52.101.71.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FEA0273808; Mon, 16 Jun 2025 08:59:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.71.21 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750064390; cv=fail; b=lOKjDPhImnSHyGcOB/37G8KDNvYGwRd+NY8v7cATxkNbLBqwK8e2pc9SfIvj1WnTqonxwVYgqIlevoM6ucffWaUM4CrGjf+yzZS14Ax8pSSSg6Lqd+WLLOoXk72aesuIafiXOzqTVWckmKwVEpghJGCfc1Ueu+N4pvKN+1DdEIU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750064390; c=relaxed/simple; bh=zO8stQffc+HpUc4j1r8Fe9c8zTeYh4YqSOp1W/7Adng=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=VBxXUPnRacEZGfFqJiBaH5tFnzwLhlFiY6BPgq9CJOQE0lSRF0NoqSsovPb99Q6B1sMfoinbq1mIa+m4OCrJPey2TIwjT14s2QjAnGoHKgdDXhC2HRHzZPTpZVVWDQSi3krK9MGEJllOQMivDcNTkqhfjG/SGcuEYTl8swOJcuM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=IWKr86Op; arc=fail smtp.client-ip=52.101.71.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="IWKr86Op" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gB3JY+68QXUgAZB1rbEHRJFLs4LePVEIDYHVEWFT3hTWmafi61MCYYxEawyhNzaHNqAGp8FNvecY9gBKfKBnFE+nIFuo1phPJWJkVznGwwDF0r1aGp04nGxonG/GDmxPCwSlx0qoUioyo3fkWdQ8xCQ5EpY84tKzHl6weskCFQ625GOsbUdoZGED63AMDK4yFS9BQ8g5tt5mmcI1DDdetTKIldj5zQtdenVy0rhH7itC5DOpi6/HnLYDf2ohFf6oGDFnAvsBBLLM1hWjkV/XgmUnm75MUq3EZVFeiZ3T0QSBjTPSd3wJ30hTOOv8qN3jf9Q/1migrtQVg50sbmty1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1+ZRwaaUaSZTy0JUpYgOSAB2xJg99nCjpCfK0kRmCqw=; b=tKQZXIcSAJzqHk7pgYGggH/Uh48pluieiZhErTJ7adYpPCPHClkE3biUEIMhtwyYZPmW763mQ4nFmg9AzUMmvZg0phYwHoMye8Or54/RnH/Zfst9eyuYLOwAMpGSXKqHt1fy9gPCBwruajlgfdC2JaV/bAMpCZni381vPurvNxIJ2E+E571PRpk0fHIly/SRJ5/R2RxfZn0D+PezkE2jVFQTspq0C/SvGsMLFT/z6W8YIhnM4y1HzapMI3JOKmcFWHekkf8tAYtcSznuj0cagZ76n7BOaJMHLOAHBp3QQ/ymVHXAoyMenwB2j0izMN5KQRxZTsaV72A4sMUZHMaM9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1+ZRwaaUaSZTy0JUpYgOSAB2xJg99nCjpCfK0kRmCqw=; b=IWKr86Op4dgDzZtU9dGkFwgalP8IfT94hdcXuxDvAQl3/eqlof6MnDcr7GQj0Cu6fgfGXx1Y5O0MIcOkinozgxI6B8TAvCE47b3Oi5TOrZXJOUlFKSAQPcF9MC2PxTl2O7EugB2PreJFiXHhprjn7jXQQ3gmmLMZ9NdEeV/LwXcaGEVnSI8POr88iF9UuP3xPeJXDALEdqSe282nAKGruOZa9cetfgvpFM4wpnfcdo3v5hFaV3luHZybqAIU4cNKsHW9hcND8QkPduZwm4BXswqOfRWwG9AiQBaXdmPGJFo3w1pzEUxERkmMjcViL6MRM2MCTF69EsWk6rzOFZmaQA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8676.eurprd04.prod.outlook.com (2603:10a6:20b:42b::10) by PA4PR04MB7712.eurprd04.prod.outlook.com (2603:10a6:102:ec::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.29; Mon, 16 Jun 2025 08:59:46 +0000 Received: from AS8PR04MB8676.eurprd04.prod.outlook.com ([fe80::28b2:de72:ad25:5d93]) by AS8PR04MB8676.eurprd04.prod.outlook.com ([fe80::28b2:de72:ad25:5d93%4]) with mapi id 15.20.8835.027; Mon, 16 Jun 2025 08:59:46 +0000 From: Richard Zhu To: frank.li@nxp.com, l.stach@pengutronix.de, lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, robh@kernel.org, bhelgaas@google.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, Richard Zhu , Frank Li Subject: [PATCH v3 2/2] PCI: imx6: Align EP link start behavior with documentation Date: Mon, 16 Jun 2025 16:57:42 +0800 Message-Id: <20250616085742.2684742-3-hongxing.zhu@nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20250616085742.2684742-1-hongxing.zhu@nxp.com> References: <20250616085742.2684742-1-hongxing.zhu@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI2PR02CA0025.apcprd02.prod.outlook.com (2603:1096:4:195::21) To AS8PR04MB8676.eurprd04.prod.outlook.com (2603:10a6:20b:42b::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8676:EE_|PA4PR04MB7712:EE_ X-MS-Office365-Filtering-Correlation-Id: 28b55b26-e5d7-434f-70f0-08ddacb4242c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|7416014|376014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?PpxvCKIcrZHAoQD40Lr2CpOAqNURIu5Occs5I1nQL/M73JmxPKHg5S64MF5v?= =?us-ascii?Q?YTi9cQjJIYD7aDn3sA+ZLuFe8ad1ZJhMXH+sZ859Fmpjkmf7h4z9TFlTvTXz?= =?us-ascii?Q?RGQfWE5aBB5DegIeWsptrMeQdiiOFTQNix+Zn6ckCYPP9wty3a6cDUJe50RP?= =?us-ascii?Q?VYUcJvfJdhFpHqqVQ3CN4MOKB49OYqvk5yXM57acIfqK2V5iQU7nSBV4gCq+?= =?us-ascii?Q?y3b3P0FhDAuO+DCrgGB+go+D0966w4ChhZ2qxNlwUjGcHcqIjv8hJKG5Cc8Q?= =?us-ascii?Q?/1TvnDK+q8ayqd7SMRDMWKb/MEZkbMbVLFuPizDMuwPDwlPCcOsgvcQ/k/Aj?= =?us-ascii?Q?5ILlfb9ZutKDh6SDLlTtp2ezhkhKOmtTJmN0rs6GARrg13Xdc+8FtzmR5i9z?= =?us-ascii?Q?RUvJqFG0RWJ7BrvFRUPYQHSzcjHUWUpLRiVzD4afsO7ZJq6/fRkAXh8jFJus?= =?us-ascii?Q?TbgYKUf5TNfc87gJcQAFAGffpQXMMHcwus0qW2+soT6neb87OzB1hxAJoEGh?= =?us-ascii?Q?1LZoZXaiWNipmaXLLbavF5WmcdFGCLu6CfaMnMrZPw2Wkg9O3ZzYlYUS9Lvc?= =?us-ascii?Q?kF/GIZw/wivF4YiDS22fs4DQ2ZZJuBPlQH7THtf5sG9at/W0b54hJn14WqpF?= =?us-ascii?Q?fgQJHjaaRbwm8LwqPzZO/l59uUkvtVfwnEPjWHaoi4TRBxHFE7ZQA26//cx8?= =?us-ascii?Q?F0smvCHv/+gMV7byVyxLluj3lZiYvgCiC/JapeR2Vny1kGfD+8miTeK4dRDU?= =?us-ascii?Q?OR/hbetzbuiB/O1lt4OnIUcaWxLuXJjTD7uy53gIVKMgLuX6cPLnHJsBWC+9?= =?us-ascii?Q?rJhYIc9rnlc37tGWTMlKX4BRXcjTSN6ykDQ5kcc2nDxV9eHj8AcRPpxfs+MD?= =?us-ascii?Q?71uZ8TSO2rK1csZ2vda3Fhz38XwHF7dwuIH8xLpJfQl6cocm0S6nV9XXqhU8?= =?us-ascii?Q?y9EG99qzfoRHGpP0j+5Z+qvWNvrdAW0iEeDpPEd0cZNJcDDHOlulF41GRrRj?= =?us-ascii?Q?IpYC7oErPNKmm4ZNaAHuhKPBM5kDo4UIV7sZP6ls6ac392vc6Jp2iwUyvB3/?= =?us-ascii?Q?AHJXIAwjBKp/uFXxYHxONwG2TR4OBOZZZZ+CvXPAxxXpfaT1BbPZEp3q7GMg?= =?us-ascii?Q?bgrKc0xFdRNBT0J4XyY9MdiCpOpe5EEBvecYcBK7qcY3ADl2Hbtz1EW1Xh1c?= =?us-ascii?Q?mV+0qu7faakIgZah38VPsLOik68mfJowLZwYWwzem/cNczXkKFKADJUMpZeC?= =?us-ascii?Q?cd9d/gbXxPq0R+eQQFzz89ZdI6lS2w5TpQrSoj2O7nWWdpYBNlFWfRAYmrC+?= =?us-ascii?Q?E1FhuN24SZNYaXoYeoJ0OWK8MR73dVrL2zkAX8If8xGNoUDZhJ5H4w6502v3?= =?us-ascii?Q?Wasq/cE/q/ZWXzaNMGx7xCzgQtF/jIYMOlnMy0VpsQdYw4k+MSlh9xIKBRRc?= =?us-ascii?Q?AoKAOkx7FJ/Eg5ILZd07+Ds6/CldFat2yR/rKKIVhD96XTCT3sQbJG9VZB0l?= =?us-ascii?Q?UD9UpHphkS68Tx8=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8676.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(7416014)(376014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1vh0klUKQKDjdhMvdyqEMBQ8L0a8mHn0z8eOWsqFHv2x+Zzo/Wluc/d888Gh?= =?us-ascii?Q?e/uWyiTYyXrhjPMzrP7yJ0naxcsUJpxiET/BaWQdkVGSibf23WfsPWMQLy2Y?= =?us-ascii?Q?q+V6zXhl/X0TkpFmkO1dB+UiAvE5jJuTajt8VQZw903mx35ciYt4rdmJIUqc?= =?us-ascii?Q?n9lI7fk/IVjmI/Ii6IiEp2ntgdCz8uVyRkjV+5UTWvS+Xwylq//YIRWOJZje?= =?us-ascii?Q?vwXsCZ12uBix1k1rUlq/VV1KVRW41+2C0KxNb8wY1ZC+ToIK7SP+g+AXZOaN?= =?us-ascii?Q?N/XWR41LK+d2+SRw2epsPOJYfxpIySFFRSU24JaNhcPYp9Pc9LG5Z5Wye/Hs?= =?us-ascii?Q?tres9lxHJtvjRDOIa4oa4PBLw7cPyWeVMHO/2mRx/skADsZ4/d2ATSD+Z3ba?= =?us-ascii?Q?d0oWrJMQ3YxQTEkYP+warGzoeJ9PhyIZ/3F07BkX7Nnt04JCxMJ/LnJe/s5N?= =?us-ascii?Q?1TN2QM5IigM34LN/i9dYbY/0Y83uSpHQUqgF2tslcp15PQk78FmoZdgCv+Bb?= =?us-ascii?Q?TKG8Ru9qpakfqQHQT3BFjy6U+T472IqOB9F5d9yGVTPSY+qOcGppxTA5tYPV?= =?us-ascii?Q?Unmd7n+byOYUX83tVplze04nzogFvK4SeoZJnfqmNDoZoVrrYSjArGn0rb6N?= =?us-ascii?Q?sKP0FThxQyanaz0wKfp4FNwr3ycmII/jMzXk4dY8gBVjU5Xh8QtRJcDvVw2t?= =?us-ascii?Q?ZWonCD4FB9DYZtxeBhZB5Ttf14xM8UgLNhWM+c0hdlDq4bACXHqB1WMOa25D?= =?us-ascii?Q?pIBv5/ILecGKTgOwl/1N9qy/azGx/j9LMomxo8C724tDMmKHh5FxW/y0Sson?= =?us-ascii?Q?SrF8wwI+pEKoG6pXRVgrNT3kZyPBRXXGrvi4pAcKn0PDmDpM8LfgpTxObL/B?= =?us-ascii?Q?AHAoD8bugqYO0cQOC5u6S0OdcZnpddfrNjTQEppPCRIMEV/TZylFzKer5h2p?= =?us-ascii?Q?NrYLf2fV/nxC40Im5gEgNT64BaUBaw0Nu1tgazJ8DzWJ2drVDaB5bKcgmOC6?= =?us-ascii?Q?vTYfhW3aJB+0CAWgqP6c+tTqkSG/ra3N7cZAwItgK9UtaF8MBWbXReP+kJPy?= =?us-ascii?Q?rRzivpuHi9eJsQrBpyxdfVkVzn05t8yJ1/HAJF/hSRAdTCWjAV4UXW11XdWP?= =?us-ascii?Q?fOIhKRt0GpKPROeGUvItcU6wACcJPK9uSnh/DSiEmH5IuKOQG/vbQkw/9doE?= =?us-ascii?Q?J9mjbPpDe4LmkDatTdYyfYUXkXp9jwTkII7iEEXYKnK3gLD3SH+Ybd1XNAkM?= =?us-ascii?Q?gAoRk0TZMJLv+Or/5zFnrz4yOP4k0cZA6gMfn/LhKt7bk3/YFqH5FCA1Dvi6?= =?us-ascii?Q?s3IRE3NRVfW3YF99I/3LOnFJjn/DlV6jQsWCV40Vjde6SnChtP726RB17dfN?= =?us-ascii?Q?WRuWMtGNrab0CxwgNzyvUeL9Y9ZfsTKvHOPnUXa1OH7CbG3hcTH2++CXwXUA?= =?us-ascii?Q?OE2LwANlRC7v7JZozrS6C4h02Y/TAHattc1bLNH5F/yVporzGXDZmswOhI6W?= =?us-ascii?Q?5VwK9rxM4YfnKRmfO33MFd26dVj+ovnsbvt5BkEjP2HQzcv5zmieVm/CGcoF?= =?us-ascii?Q?scwvL8xwb2WY16nM8ECIhFhC84yPiulxRz4VbeuF?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28b55b26-e5d7-434f-70f0-08ddacb4242c X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8676.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2025 08:59:46.0715 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eTgoa1yyj9FrwzCCsCVsldzodR9QEfLnQNVCj/fKolaJI0yOYjliU6fKGL9PlBVneiC6oPyIuVfZLBzy8IL02A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7712 Content-Type: text/plain; charset="utf-8" According to PCI/endpoint/pci-endpoint-cfs.rst, the endpoint (EP) should only link up after `echo 1 > start` is executed. To match the documented behavior, do not start the link automatically when adding the EP controller. Signed-off-by: Richard Zhu Reviewed-by: Frank Li --- drivers/pci/controller/dwc/pci-imx6.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller= /dwc/pci-imx6.c index f5f2ac638f4b..fda03512944d 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -1468,9 +1468,6 @@ static int imx_add_pcie_ep(struct imx_pcie *imx_pcie, =20 pci_epc_init_notify(ep->epc); =20 - /* Start LTSSM. */ - imx_pcie_ltssm_enable(dev); - return 0; } =20 --=20 2.37.1