From nobody Fri Oct 10 02:41:53 2025 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44D3C241685 for ; Mon, 16 Jun 2025 15:24:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750087496; cv=none; b=nvlSEU6UtYEyUwU3jUAQT+fxPa6mKuFxm8dpbtjezxSrheXOf/abythNQlzDbQ/I+koNTzR/iSyOTq60cjqXlDcdi/YzZ/xnVazPTjE/WuaeBwNSyNNk78DDcowid8CvJyD+N3ItDoHRYi2aQC/x1Gc/Ns+8X4zB85BPTk3P2lY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750087496; c=relaxed/simple; bh=c1fcbRjJ58/n6v45d0hGUAr9YIahYT5F9yuooQ1PvsY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=E3VFXVh2+AVuKTvD8ZUkkpIAtUzlJUqF8JL7g1tDMTLFsk0H8xtGLSqEY2SMHqoJ0scXxO2e5NyWuLqcIJx5xji7tWD7XC2ylpTvSb6MB0Hsk/xJmIa7YCKe+4cNEOM+py32lNqvx1Z2vjt43p3IA4VSEoSx6IlNArO7ciBYJHY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=QrrFgB9+; arc=none smtp.client-ip=209.85.167.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="QrrFgB9+" Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-551ed563740so5034868e87.2 for ; Mon, 16 Jun 2025 08:24:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1750087492; x=1750692292; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=HLP+dzsQogEKVLSLXZuJGypFkFhYImTXNZozm06VbFk=; b=QrrFgB9+kDog4SRjcMILPaD4HjBq5Q9dZHK3GtCw60wU4Ox5V9zKi5h5jqIyXoKMEr 3dHVwKo3gIT17kbw4bQQllfbOUaYL9yfmw/717k/9yxoYuJxMAm33Hg1yTeQaXO9uUs0 7yyCWQMSoAgM4RZDXlPZkAXCkCSpqGzBHbueQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750087492; x=1750692292; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HLP+dzsQogEKVLSLXZuJGypFkFhYImTXNZozm06VbFk=; b=wDdUTNIFs4UcaTVQh/tC8ugov9w+viQbrVLIbiM+We2h7ghP+CTPOpMj82NFgxigQS UaiysLrsUQfIjoJw1mJrLN2Ncjm81aGlgshiiCjcJ2PdXpMhXkVQNQXO5oqqAe4EwzGj Dd9yhBGKTp4CRixab9HLe7utcp4ZnV+VjB585fhUR73kUPoUvtyq57VDaUbWSqKhpYz+ z/9reeF4A+zR0oDAsPJ3Gu/wDuWG94lO78y0td/OeJFfN23jKrbW+ce62y0NjauSsycI OK/4RCWitfuGhcDbHMfGyG/6bxYB5ixfc93GhIcCjBG1zEav85/CzkIEP56z206S6jNA bf1g== X-Forwarded-Encrypted: i=1; AJvYcCUAuZAtsGb/qyu2QViKjREZXNMDI+MmfWRBjneyz8PVflNZ5BsEtHVwLKcNk1sBNKuDtKAoKm3txsp71ok=@vger.kernel.org X-Gm-Message-State: AOJu0YxETEZjSz/pEjdr1yX99MHc3p+yhlqS4WPWh8Xwf7jU6Bhj4WVN lJ+I/8r1+Qb3gXPMVKH8Dhw6o8x1cyzSUVjV2w+yUnAQgdGZK+zt0gElynguwwBu5b2MXXuWZ6A dD7fGsA== X-Gm-Gg: ASbGncsGW65wFFEfEqRWNY8eNqE6L+8GhljUDvZnVn9vEamC+RUaQ5VRwmqpLYhLQbK og2Eu+5IyHA2XGM4QHd/0LJNB6eZlZq6SsXBVdTn44ULBPpM64YcoVhekgyLNtKrmwb21XcQh0A mNK6dUf2Xn64t9UjwExQt/bn3xf3MkrDGlns5sffNpim+N42r/aPQe3b74nU6HdVkaC77VqzH4e 9TTN0Pe9rCRI3tdnBk7WQAYMVAFRvjOaNl0LCCScVjvyFB6nxkiHoN535wlYMtMZENeokauj/C1 eZ6C6s66secMYaREFsUxqgYsVAc7azZ9cfYBxHBS/BnqSqolCL/iGS0KMFkDJPnxIEHQKdrbUFH B3sbDW4UWbAMNX0E0LCJaB75x5yaz7ykbHSfqPEw9jA== X-Google-Smtp-Source: AGHT+IHwrxVZaHqzzhsZCvCL26mk133FyEJL7YcfSwuEUUONI/k50br6D5fDapNxD/sPjvUNsvQtfw== X-Received: by 2002:a05:6512:1105:b0:553:2450:58a6 with SMTP id 2adb3069b0e04-553b6e75904mr2244348e87.1.1750087492221; Mon, 16 Jun 2025 08:24:52 -0700 (PDT) Received: from ribalda.c.googlers.com (166.141.88.34.bc.googleusercontent.com. [34.88.141.166]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-553ac1dbcf5sm1564271e87.190.2025.06.16.08.24.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 08:24:51 -0700 (PDT) From: Ricardo Ribalda Date: Mon, 16 Jun 2025 15:24:42 +0000 Subject: [PATCH v4 5/5] media: uvcvideo: Use prio state from v4l2_device Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250616-uvc-fop-v4-5-250286570ee7@chromium.org> References: <20250616-uvc-fop-v4-0-250286570ee7@chromium.org> In-Reply-To: <20250616-uvc-fop-v4-0-250286570ee7@chromium.org> To: Laurent Pinchart , Hans de Goede , Hans Verkuil , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.14.2 Currently, a UVC device can have multiple chains, and each chain maintains its own priority state. While this behavior is technically correct for UVC, uvcvideo is the *only* V4L2 driver that does not utilize the priority state defined within `v4l2_device`. This patch modifies uvcvideo to use the `v4l2_device` priority state. While this might not be strictly "correct" for uvcvideo's multi-chain design, it aligns uvcvideo with the rest of the V4L2 drivers, providing "correct enoug= h" behavior and enabling code cleanup in v4l2-core. Also, multi-chain devices are extremely rare, they are typically implemented as two independent usb devices. Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_driver.c | 2 -- drivers/media/usb/uvc/uvcvideo.h | 1 - 2 files changed, 3 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc= _driver.c index accfb4ca3c72cb899185ddc8ecf4e29143d58fc6..e3795e40f14dc325e5bd120f5f4= 5b60937841641 100644 --- a/drivers/media/usb/uvc/uvc_driver.c +++ b/drivers/media/usb/uvc/uvc_driver.c @@ -1728,7 +1728,6 @@ static struct uvc_video_chain *uvc_alloc_chain(struct= uvc_device *dev) INIT_LIST_HEAD(&chain->entities); mutex_init(&chain->ctrl_mutex); chain->dev =3D dev; - v4l2_prio_init(&chain->prio); =20 return chain; } @@ -2008,7 +2007,6 @@ int uvc_register_video_device(struct uvc_device *dev, vdev->fops =3D fops; vdev->ioctl_ops =3D ioctl_ops; vdev->release =3D uvc_release; - vdev->prio =3D &stream->chain->prio; vdev->queue =3D &queue->queue; vdev->lock =3D &queue->mutex; if (type =3D=3D V4L2_BUF_TYPE_VIDEO_OUTPUT) diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvi= deo.h index 3e6d2d912f3a1cfcf63b2bc8edd3f86f3da305db..5ed9785d59c698cc7e0ac69955b= 892f932961617 100644 --- a/drivers/media/usb/uvc/uvcvideo.h +++ b/drivers/media/usb/uvc/uvcvideo.h @@ -354,7 +354,6 @@ struct uvc_video_chain { * uvc_fh.pending_async_ctrls */ =20 - struct v4l2_prio_state prio; /* V4L2 priority state */ u32 caps; /* V4L2 chain-wide caps */ u8 ctrl_class_bitmap; /* Bitmap of valid classes */ }; --=20 2.50.0.rc1.591.g9c95f17f64-goog