From nobody Fri Oct 10 04:06:48 2025 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D7ED1E1A17 for ; Mon, 16 Jun 2025 07:24:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058655; cv=none; b=YLOTPQ9YvpR9gdMce+Uq6pQJ+D5EhxlQqn89xgQnTGxOadmMfZUNo3CLZLimVPKoQbK1t0FEfnz3gn+UOAgThbFr8XQjk4hK5xk3Uia14wHD8MXYg5eoCT14SIXI0xR4dBBWfcp9zWk8C2Vy7jofE9dIV6AGEq36vDrXAnLwfBI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058655; c=relaxed/simple; bh=DMxSE+KlKXo7E9j2J1aDyImW/V4iGavbbTY1DlV8QQA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Xfju4anCA4UHkpQcjKDzeV16TbQJ1R0Jc61wPbq/HjMX3UQaIwlkfe98QyygtlWVUzKZJpIK9DYRpUYac68/dBV1K67uzD1N2JOms1q6hGAAZ5hxBZ8xELDPId/3dzLU7oL07FRJAKvYtoOXq7UmnVD0iuSZPvqK7Ru5D0++wAo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=M4VZd82x; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="M4VZd82x" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-450ce671a08so25721515e9.3 for ; Mon, 16 Jun 2025 00:24:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750058652; x=1750663452; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=yE6IzPfXHMNhFc7FmQD93cM50XDdvhBiuKkLkDIaWfk=; b=M4VZd82x3dixXEQsRSXnF9xzzKKGjQyDdBrwnmF33kR9nDfd/P0r+ZeBxHoCVBqZ5z UkTDfahw9S06HeP8zID/l1nuCT8pM8W3L4FILkdOzHJyiFMKWPrnqRahp0dIMWMXGjL8 daO9LDXcy3WNrgITQOzbUcEUY2t+2t+RzCXjivA3mVUD/S0vsmt8FygwCwg2GAXt5qFU b91hPFeINE+WftuBMjtF9U7C3bs/nz97+YLql5Jtaj9QVLgvUabbeXW1v4BrSByg7/t9 NFMg1YOfXQl2fYtI46XaPZ+g2LqMIAca7H0ZLovZBZ7+uFOopot3++sJZXpTl8/hsjiy trng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750058652; x=1750663452; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yE6IzPfXHMNhFc7FmQD93cM50XDdvhBiuKkLkDIaWfk=; b=m/iqEenN5KIweqLWuyBYQtD0Pwu3P0swhazJHEHowTsFDkb98xgmqOvUlcBVSlpVf4 9P1Z+10M10STN7yTQdAjcSf+gP1Dcam7Nn/RpFRnZ1qS3GRmBL8lXoYLup2YhHSooBss pvAykeq0BE+CE3yFfKWqt2/2AqVO97CHFWokV4jvH46ro4+UBPuZe+JzzmAN3jyFqHBp 9sAnuQ9Q6ALU8zzYQl1vVLWcOpEyxnkg+2TcfAFGXKUQdU86Bq4ygCW6zAkBM6hxl+ui nwtC1vt5KVRJSFDOakl+ZGHIE9t13AfbET5do9flcrK8GTXGqbNRe+OySGv+gBcD+ldJ I0dQ== X-Forwarded-Encrypted: i=1; AJvYcCXMEIqZDHHostfUH8Gey1lSNjukYxJgC7nmwmpEQcDi8SlysqgOZ1x5HZZL4SRHOPpuheWEzsLXQz3FeMU=@vger.kernel.org X-Gm-Message-State: AOJu0YwEw3gtK1wWSjiGLvqSTyoa4eykHfRwcK69Nxu7lppVZpS4gI/H IIvELWLOxBL6wcKZ52Mnr0scSoFANweHPsXww9/JmRnUGvtxFdgCm5h8+kiEaUSYDyo= X-Gm-Gg: ASbGncu01r+MnOuQ+ULRIBbAhUqp/8Q+0KRLI9a97C35D70kP36FiZJh6NxPdJVZpxc 4HxS/bUn1N5LVQGglilVY9NbmMeoA9xRKFIsRmJBam9t2jHnfFvJMbtfnOa6tH219Rboo1jFHgL 879NE2hAHn5x4HvbN+ShiIkqdxT2D+3YgXFpeX3sZ69jIDOl52ryy+6FmD4lxiRW6LdIk98O64X KeY1IsyFv7dBojZCB4Jq6DyMVjMV13JVDv+i9oqny14ww+uyZ+k/PGsLNVC/exOFhbA1+3ZIK7C ErpkkrK3WgSwjP6Itbm/QREJFyIW1j4A0Rx+4Tg/z8f68GJ24uDZyTbk X-Google-Smtp-Source: AGHT+IHPFBPn3Zq/nUDkUy4oRevEKPyumefMdGv6HX3562iJJprMTS9/QcD9Dlx1hTdScj4u8SVCMA== X-Received: by 2002:a05:6000:4202:b0:3a4:dfaa:df8d with SMTP id ffacd0b85a97d-3a572367c45mr7317623f8f.9.1750058652323; Mon, 16 Jun 2025 00:24:12 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4238:f8a4:c034:8590]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568b08c99sm10312334f8f.63.2025.06.16.00.24.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 00:24:11 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 16 Jun 2025 09:24:04 +0200 Subject: [PATCH v2 1/5] net: dsa: vsc73xx: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250616-gpiochip-set-rv-net-v2-1-cae0b182a552@linaro.org> References: <20250616-gpiochip-set-rv-net-v2-0-cae0b182a552@linaro.org> In-Reply-To: <20250616-gpiochip-set-rv-net-v2-0-cae0b182a552@linaro.org> To: Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Linus Walleij , Bartosz Golaszewski , "Chester A. Unal" , Daniel Golle , DENG Qingfang , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Marc Kleine-Budde , Vincent Mailhol , Heiner Kallweit , Russell King Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-can@vger.kernel.org, linux-arm-msm@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1733; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=ooSfZcGlJ0aY63V/ZbHM5psbxtwwGfSHGbKlKX+V14k=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoT8aY68phhJHUiYmICb6qi2PtnsxOrk1Qj26di Sf0oPxAjkiJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaE/GmAAKCRARpy6gFHHX cmsID/90DiNKLTStA2nd+V5BqNvhGiL18/ZS+yk4NDv771RccIIvB08RD8O6h9mQk1BbBx2PGDf 8uUGoxxBYkl6SrCrU2WGXyT5gq7YAtwvpGuDWz0TgdkbCAT3B3FeIFwkAv0ykw1t7oPjNhRRO92 FzNqC7ddptm3fGUK0ZyPIj55GA9V5mNR9oNqWMYTNQJFzLbGDVfi5+hEZx36mWoyXue6bGO+ByG zjrOM+4AbcL2OsTpAZhuMEHFzWlQ490Tw09iu2MGvdzydWZreBvSFPJm2HdNS7qI181vxwc3Pr0 iEpTY3DJjRuIAXnAYAErCvz4amgZHJ2OSlcUWjpEKs7+57LZI1hfaIAyTfQpsylp3Fn8ucQZ8Bg FEL861RY6dMUJvPo7bz3gmb6bEplPlC7RHjimwXhGXTBqvG6WJCEn+l5JiWQpGzFgsf+QmtA6pr SFOwZQv/sBjz7nrwKkUExa74MUFw4w/5zidsXfSMokGQgAOGp3U90lHe15KSVz2BCIkXGTH0sDl KPagWn/xrxQH/6uqohnVTmdQmCMwgQ2o12ftsnf979MS5FTIOo+lqMFShb6yHBUdu0B4RluVfIT UAR8LI5viexSWvvxWDxg+sYDa7kv5sWzinYOHjoBh1tpudIlKw/Sj09VEzti0RhVxW57ynoPS9W tyHSiAbzSI0b3dw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/net/dsa/vitesse-vsc73xx-core.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/dsa/vitesse-vsc73xx-core.c b/drivers/net/dsa/vites= se-vsc73xx-core.c index f18aa321053d75f34544267528d68ade37264e89..4f9687ab3b2bc1cc61946eef33b= 7d08f779db8c6 100644 --- a/drivers/net/dsa/vitesse-vsc73xx-core.c +++ b/drivers/net/dsa/vitesse-vsc73xx-core.c @@ -2258,14 +2258,14 @@ static int vsc73xx_gpio_get(struct gpio_chip *chip,= unsigned int offset) return !!(val & BIT(offset)); } =20 -static void vsc73xx_gpio_set(struct gpio_chip *chip, unsigned int offset, - int val) +static int vsc73xx_gpio_set(struct gpio_chip *chip, unsigned int offset, + int val) { struct vsc73xx *vsc =3D gpiochip_get_data(chip); u32 tmp =3D val ? BIT(offset) : 0; =20 - vsc73xx_update_bits(vsc, VSC73XX_BLOCK_SYSTEM, 0, - VSC73XX_GPIO, BIT(offset), tmp); + return vsc73xx_update_bits(vsc, VSC73XX_BLOCK_SYSTEM, 0, + VSC73XX_GPIO, BIT(offset), tmp); } =20 static int vsc73xx_gpio_direction_output(struct gpio_chip *chip, @@ -2317,7 +2317,7 @@ static int vsc73xx_gpio_probe(struct vsc73xx *vsc) vsc->gc.parent =3D vsc->dev; vsc->gc.base =3D -1; vsc->gc.get =3D vsc73xx_gpio_get; - vsc->gc.set =3D vsc73xx_gpio_set; + vsc->gc.set_rv =3D vsc73xx_gpio_set; vsc->gc.direction_input =3D vsc73xx_gpio_direction_input; vsc->gc.direction_output =3D vsc73xx_gpio_direction_output; vsc->gc.get_direction =3D vsc73xx_gpio_get_direction; --=20 2.48.1 From nobody Fri Oct 10 04:06:48 2025 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E8AF1F4C8E for ; Mon, 16 Jun 2025 07:24:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058656; cv=none; b=ECtIzKnfC79pblmQhPrf94lwmQV5fUX2klllPG99oSavMWC5sKTgRfVvUwJoMhZbo+9To0QNt3VTJuFT7/A9vuBSGns4r/XCKMGVA6Rpeb8svXrpBoFD4DnghIIYTqHEQSFSAb8G1JKBy+Dz4iy/6sq0ElPb5ccr8j8059WRBjw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058656; c=relaxed/simple; bh=Or2j7o3D1slLZ5D8EJTGF6KLpMpv566+WGN2+SIZWMA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=etEb6N4TRECR2QfCNwnuId36Jilj/xCjOEwWxDGeajLOI2vS4HQwqbqhrg5S7djRQnsCWmU+u/GOW3paV7qGBkTra+tRlbAStVlsdb0weFEvH1/UK9K8Uy7lEad7cU9ZCcF5vJ0E9JAtcBn9gCh/SDbzWjyb6RagnL9iWc0TjoQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=x+JFU8NR; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="x+JFU8NR" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-3a375e72473so2332534f8f.0 for ; Mon, 16 Jun 2025 00:24:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750058653; x=1750663453; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=jIXq3f74XDnDymhzUWUlAdt1JYy6kAW2baobRVnYyes=; b=x+JFU8NRsb9/wyvkeWVy3WowcnPSq3w9mA6ydmO0+eoRF6W1Oz1gL22Gigcgl/Fs2T ZCaS949Xo8aJ1N9E7Pku/k5X9EO2rEB7YaP9peemcJ5WCPGWgIQW40WfxSRbZuQuh1SO izxRijpdlom+/6ZgSawjAh0epOvi/p1A79yJYLZDRlqDOTQmXceBbllVn5PPUI1X41hJ h8fJwaH3UWQ5RnuVOTIHq8PJnuX5pEzaJy6pgRdISe0c+HY7+XLLOAE7MhaGJggjtSao +3b2RuaZ+ggSY0CK0TgoBsuhO6MRfTEzub5xnxh2QV9bykXWCqjb2oKCm/c+c8WaZWhw /dsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750058653; x=1750663453; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jIXq3f74XDnDymhzUWUlAdt1JYy6kAW2baobRVnYyes=; b=wQR5k2OhhYlBlxIbo8uv9+IEl8/6mxR0DAubrcibtitLaicl75lmNB2Ap+Uoq+BuYF 99XqpsiCZr9zOHJfplDw8wlJbQsKOvysJvchBBxwLMm8znuca5y6h3J+1r1ZsKbh8Txb LlZ6w9kHNdUTPqvJV/8Q7ve8LkQqgBX0000P4p/Zss18pRGjhzmMsQqid5RMbJmRVyPU ppjUq/H03Dg5hPnguESNyvQT9aaEFsay9h0MZXR0mLC9HDa2dLYtJblT4nJBtqivV8SX SqNK1nWGP1kvE9jJ9LKz552nO6M7MDpHgBmobPrYUO+geFid5iYloKXzRht0bcKc/hIv 7yiA== X-Forwarded-Encrypted: i=1; AJvYcCV9ldOYxjJg8gej3rtBw2NMRb+66GBMMBlTO/jU9Fm8wR2PI5ROdT1PsNUKV6VAD+R71RgGb6njWxzLgxw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2C8sp/2IMIUbXlbupgpH7MR//F+TpFzOAuleSy3WxsghL/6wn qXACGreUY6bFItDEOB9pb7TPpOkNgUkn0uAvt2HiUmJgt6BdSLL1ce0kO/XC9+mhhAk= X-Gm-Gg: ASbGncvkOZEVymPFJsmBjGI9WC0iY+1mF7o/bfMl86wbLuvqqQ2EGHbVXgu0tFs4swa xD0V6clb/75U3bPUy6e4yJz/qMA5eK5UujM+yf+MGhEYTAOuBksZP7QuMbqRARt6ShqVQuBUtMB r4NMyRtttxTQ04+i24mtgb9Lj7OODwoGv6tfrCV9qMzcn2hplfz6dL2AY8ruQziOL1TygyVkLbW K09WZtgMh3FK72Vca/9pIWjPQ0vrxAfIg48QMp63nWHJwuGpIdbQi5Ti4+5EknsRRFEdGgVSlRI vKe6Ej5Dn7iPrwJbZAoMesEEG+bN3NIq4ze6jWQcaIufIm7eKFe4YqhX X-Google-Smtp-Source: AGHT+IE48oE5eDJIxJr49h4oPA9YTDo3yEljfvV96IR3ebuis1Y0vz3HpGqAPiP6g2TbjN9gjF1/TQ== X-Received: by 2002:a5d:5c84:0:b0:3a4:eecf:b8cb with SMTP id ffacd0b85a97d-3a5723a2912mr6781229f8f.28.1750058653481; Mon, 16 Jun 2025 00:24:13 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4238:f8a4:c034:8590]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568b08c99sm10312334f8f.63.2025.06.16.00.24.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 00:24:13 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 16 Jun 2025 09:24:05 +0200 Subject: [PATCH v2 2/5] net: dsa: mt7530: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250616-gpiochip-set-rv-net-v2-2-cae0b182a552@linaro.org> References: <20250616-gpiochip-set-rv-net-v2-0-cae0b182a552@linaro.org> In-Reply-To: <20250616-gpiochip-set-rv-net-v2-0-cae0b182a552@linaro.org> To: Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Linus Walleij , Bartosz Golaszewski , "Chester A. Unal" , Daniel Golle , DENG Qingfang , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Marc Kleine-Budde , Vincent Mailhol , Heiner Kallweit , Russell King Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-can@vger.kernel.org, linux-arm-msm@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1434; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=cOyYyWO13YQfp2ycss27bUpedNvkM8EVvpF8/6G0QtI=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoT8aZqs67TKrhqmdTVUjIoXv47OQEQk4qYQvii bxg3qrFa4uJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaE/GmQAKCRARpy6gFHHX clNmEACl+OMZ074SDpTO5quUC0oukmH6+JnHqbSET6X0mc+EKoxRFJtNYk1S7dEVI7pnlXXHqFJ EYqqyONv4VGeyya19QXIVGMTQ5YxveS8KU9oJqadT68LaqtzeN80I/jytXGjosU13hfPq7ik3Q3 VK0wciohlIegPmNaiWvGcrTEq9+N2kDt1z2tSvqOOa8YaSJRsjOaVdJ+33G69qAhVeo1QpR0sFy 27L9k2LOm1kLkB9h1D+eXYXdd1/zxNirXig639IS6937NDqd+qY1hREQVFfRxmukLIBEfqBPhoC hssFvyR9bfn6eUhrAIbdwRlaedEal8z8Kj+Q8c+5TFfxhwGAWYl7kHPvF3VpEglD2DRjfjSYRdF Ec2pHhXTAk5RLj0pI+h5d7zfLEM3VHxPbjWduO8UuYxRW9xxG/wz0djaFo1b5l7/+GiBVg68xuA nzpCHL4yltPGaSEHPgi6LM9spinJ0ltWp7jLvZNpjon/s7g9JNyd9l4IZ8tke3r4oZsQcteNgnq v0AC3pvn5aXiElHgDk3A2UtMmDi5LSNT7rwwmH3LPr7eZ1S54gUIXzS//yw6rBXShyicjaMI0Ys J5HE8b0C3wj5NlYstP84STJxDCgmHrH7Q9nhez6HSV5b0r/fHguIQzfuT89ndCGVn9QazsU2EQD exXyAvqd8zwLlYQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/net/dsa/mt7530.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index df213c37b4fe6ab85fc5b01c62297a35b7b6b2ed..e5bed4237ff4c46457b46598f07= b65d0daa84ae9 100644 --- a/drivers/net/dsa/mt7530.c +++ b/drivers/net/dsa/mt7530.c @@ -2112,7 +2112,7 @@ mt7530_gpio_get(struct gpio_chip *gc, unsigned int of= fset) return !!(mt7530_read(priv, MT7530_LED_GPIO_DATA) & bit); } =20 -static void +static int mt7530_gpio_set(struct gpio_chip *gc, unsigned int offset, int value) { struct mt7530_priv *priv =3D gpiochip_get_data(gc); @@ -2122,6 +2122,8 @@ mt7530_gpio_set(struct gpio_chip *gc, unsigned int of= fset, int value) mt7530_set(priv, MT7530_LED_GPIO_DATA, bit); else mt7530_clear(priv, MT7530_LED_GPIO_DATA, bit); + + return 0; } =20 static int @@ -2185,7 +2187,7 @@ mt7530_setup_gpio(struct mt7530_priv *priv) gc->direction_input =3D mt7530_gpio_direction_input; gc->direction_output =3D mt7530_gpio_direction_output; gc->get =3D mt7530_gpio_get; - gc->set =3D mt7530_gpio_set; + gc->set_rv =3D mt7530_gpio_set; gc->base =3D -1; gc->ngpio =3D 15; gc->can_sleep =3D true; --=20 2.48.1 From nobody Fri Oct 10 04:06:48 2025 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F4151FFC49 for ; Mon, 16 Jun 2025 07:24:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058658; cv=none; b=X5q8Qg8iB7CJYlxu4bg2uGm6q+QFLClD2yWG3zHA8rYS40B3Jf1hO10cSsXgM3ZgaZ4QqX2FvUlIzh2iYWmE1BpACSDAc/NfEnmY7TlnLBW0puEtshSIIGlOAtIew/V2bjLwU2DB4BhcwYxrz3OPKNLeX/p2wcRijOlxu2e/W+k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058658; c=relaxed/simple; bh=Yl+OrShKybgGktQ+kbAvNrti8ByItxmFOhxh8elUoMc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Wwg37c+nLCvzpSltvuzsWA8U5oKnBQuEu/UkFhIdZBk+7MuOOruRyAbXXyfaLArsRL1k5Nn0n9YOwzGJkRjs139EentJ2wlKDgn0moW8u892Ico57+zTwxYMUtQYxxfZK99VwHH/WS811rpRSyhiK87KcK8YzwS//Pa2tSjp0lc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=P3aSlgKJ; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="P3aSlgKJ" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-451d54214adso31977035e9.3 for ; Mon, 16 Jun 2025 00:24:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750058655; x=1750663455; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Prze7KarTtiEr9ULuOe3gPur17rt7b2Vlkz0iOaKSnE=; b=P3aSlgKJbdDaG6Yn6SNFubplfYERLj6RO4hIPmy+6xmkF2vQyxSvBpG19zNf0cXDuP xHInndB5Bur0UflhHoGz4ajfsx+ZCAn8J9dRHFMny8Sx88/6giYgbCUIDV/5w80RbNgb Q4hoCcB02eLj56S4qY/xja2JPqJ3huV9ZYEblSYfAWB3BPZ5pRrZjW9CnZ4AmYYaMBU8 yLrTYZYQToMK0qCX+c/iAEytu52nahXMUpuVUKv0tgCDugGjfgUNV+KUzBD3TtG0wQdM ukjhpeK+oVlqWbqUvASa6iSs99Lc03ReAllbGCKGu4XPZjS2EBiZ+4E5i2zLh6XBTUBv GxHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750058655; x=1750663455; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Prze7KarTtiEr9ULuOe3gPur17rt7b2Vlkz0iOaKSnE=; b=Qouyy8rRBYyga90ps9JlqAOKtQ+zhgbrTckXsEHcKDVOIGNThDN409aRyq2T54EJOo XnlcPhw7Q1CPbVXjKVA4zZkRfV7cGmt2+CQ3h/y7RcO8xeVEjAIWy7qX2+Ej0Tzo2mg9 3DqHVr5mNNJYxbYaDjp/pDO3eeVkAVwM8/2tPQu5LyeVnD1ir5E0P0Ervpr7/ggAIi9H dfqARd27OnkZFUaAn6jsHWY3qmo5XZ7rkmfiFWitUIsFmTPuY50qLzLVtkeEBu4hxluv IOjQUmJLQBOn3BRYZ2Zq4oEv6PyS48C5MWempnYtU+urKeMoANOwo56ZseJtH/cNW1mI 7+Bw== X-Forwarded-Encrypted: i=1; AJvYcCUFXlBKzX/FoGB0tkhNS2BhkiV229h8A05DnTvEUYi9Pae+W9H5rFluS4Qhtd6ajaZu1+BTfsRWRRD//Us=@vger.kernel.org X-Gm-Message-State: AOJu0YzKAnehk4yv8O/HBD5XF99lSHZ3DlvRnA272EDaLhjMHBE+jrrz 45J+474bCx3K1aesU6scjOw+W8jZHxi+mccxcPpmdb4+ZjRKqOwTQ5JcOx9sJ22P/1s= X-Gm-Gg: ASbGnct4xFU95i+D7utpXJ1RQFwyz77AsI0uJeTWTVQ/4cNMjDcxfdoGfvX8QHeGvkG n3ucvSSIEGNmGbxXQUM+/iB8633wvltVzeFnp2dAcHn2g1t2fzGrnJM+IslPAhCS/haBbOD29xD d1Tpph7buagVtl5WQ+PU8qT+H8yTaSDZeQ2o3erOJsVerFlUL9JpNIf/77lGP9UiOjY68VzYBYl T24B9TYILSh5OssvusthLKLdl97dE+UNDIY+fCtRHRe+eiBFUBFA30JA74AV7bhirJkk9FowDtm 2ecyQH5nCVDHaC9g7nyW8SFfhJXwvMQb94lGTOAD5EA/3mhpOs3gkDca X-Google-Smtp-Source: AGHT+IG/lAGJDXz/7A3CvJT8e5vgl3jiY1Lw3i6jYgkiFDTNWEgx2Zv5/09zy+DHigY6izksTnVhjw== X-Received: by 2002:a05:6000:310e:b0:3a5:1266:3e96 with SMTP id ffacd0b85a97d-3a5723710afmr6864057f8f.15.1750058654687; Mon, 16 Jun 2025 00:24:14 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4238:f8a4:c034:8590]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568b08c99sm10312334f8f.63.2025.06.16.00.24.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 00:24:14 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 16 Jun 2025 09:24:06 +0200 Subject: [PATCH v2 3/5] net: can: mcp251x: propagate the return value of mcp251x_spi_write() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250616-gpiochip-set-rv-net-v2-3-cae0b182a552@linaro.org> References: <20250616-gpiochip-set-rv-net-v2-0-cae0b182a552@linaro.org> In-Reply-To: <20250616-gpiochip-set-rv-net-v2-0-cae0b182a552@linaro.org> To: Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Linus Walleij , Bartosz Golaszewski , "Chester A. Unal" , Daniel Golle , DENG Qingfang , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Marc Kleine-Budde , Vincent Mailhol , Heiner Kallweit , Russell King Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-can@vger.kernel.org, linux-arm-msm@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1878; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=9MP33N5pSy3OGgT8wnmaqvxECSreBBEZS21KtQDntIg=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoT8aZLt+zmsPfXHGowMV7wiRrZdvT9d0pjybCs eRaNCJ9eEWJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaE/GmQAKCRARpy6gFHHX cr8SD/98aDqkM/VGj5uwtBE5gFWYPj5Z1zIx8qY+nCaRVn2DKwC2Kg4yMV70J9jSdq4ekrRinZV RnyJ7ds9/3L20t39TnghIi+GiIxnfHsIawEWyCLFFyEa+b4Fke0iOl/kx2jqaDSFM0C1C3u3ENG GbhKATNcf7F7G6DJ2xccIinHhEu+mBXrCrceO+kijsDh6wbut7AtETdESfZaIpQQXFCqwzKl/XS 6Etd4fE9UpLJ2bmyzW7Yn1/TFo+/OBPgyujTYD2t7FkbOI4ytp4QF/Wl22eeoB7lysoWLzZyI8n nA6GYs2OMox0U1nnMmlIEaY2L/73AbfJwzTOV9wnUgLFPgZSW9JGRtzYINWTz9/DrCHmlMwljUE VNcYSKhQL1LOduvDgcp3j2z8rI9/aOKxIVCFkXTr0FVHxM2Y7rh+JPFN5sV0TVIDNX/H5h3LMl6 OvVOPepI/+66wgHuOlV4dGNmeV/6yi2RcwONb7FHZq9wYxDJZtLX2fk6qLjQw8a1vXBfsiO/+Ci YULlo87CssHva7nhnuEC+iTL6EiiynLq4/MDVFCaCCFyAz9/cCdRcbyQx34tL8jxS2RAtH6OV48 dm/bkqz6CxfJxgmvOTb4RBiJdfLXyyoctwXbW/4h9irmuYzMUuV9rctiyHDtoR/H4R1bWJ/dhf1 u44dRSvvUN2+JGg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski Add an integer return value to mcp251x_write_bits() and use it to propagate the one returned by mcp251x_spi_write(). Return that value on error in the request() GPIO callback. Signed-off-by: Bartosz Golaszewski Reviewed-by: Marc Kleine-Budde Reviewed-by: Vincent Mailhol --- drivers/net/can/spi/mcp251x.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/can/spi/mcp251x.c b/drivers/net/can/spi/mcp251x.c index ec5c64006a16f703bc816983765584c5f3ac76e8..60b7fd3040d02f114693cf66d61= c8a075a32e278 100644 --- a/drivers/net/can/spi/mcp251x.c +++ b/drivers/net/can/spi/mcp251x.c @@ -388,8 +388,8 @@ static void mcp251x_write_2regs(struct spi_device *spi,= u8 reg, u8 v1, u8 v2) mcp251x_spi_write(spi, 4); } =20 -static void mcp251x_write_bits(struct spi_device *spi, u8 reg, - u8 mask, u8 val) +static int mcp251x_write_bits(struct spi_device *spi, u8 reg, + u8 mask, u8 val) { struct mcp251x_priv *priv =3D spi_get_drvdata(spi); =20 @@ -398,7 +398,7 @@ static void mcp251x_write_bits(struct spi_device *spi, = u8 reg, priv->spi_tx_buf[2] =3D mask; priv->spi_tx_buf[3] =3D val; =20 - mcp251x_spi_write(spi, 4); + return mcp251x_spi_write(spi, 4); } =20 static u8 mcp251x_read_stat(struct spi_device *spi) @@ -441,6 +441,7 @@ static int mcp251x_gpio_request(struct gpio_chip *chip, unsigned int offset) { struct mcp251x_priv *priv =3D gpiochip_get_data(chip); + int ret; u8 val; =20 /* nothing to be done for inputs */ @@ -450,8 +451,10 @@ static int mcp251x_gpio_request(struct gpio_chip *chip, val =3D BFPCTRL_BFE(offset - MCP251X_GPIO_RX0BF); =20 mutex_lock(&priv->mcp_lock); - mcp251x_write_bits(priv->spi, BFPCTRL, val, val); + ret =3D mcp251x_write_bits(priv->spi, BFPCTRL, val, val); mutex_unlock(&priv->mcp_lock); + if (ret) + return ret; =20 priv->reg_bfpctrl |=3D val; =20 --=20 2.48.1 From nobody Fri Oct 10 04:06:48 2025 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 240A220B7F9 for ; Mon, 16 Jun 2025 07:24:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058660; cv=none; b=uQVhCM+5NK6RM0xG+kNr3hxOZ70L72pY+rHSAs+U8/TPcl+Z1bVNBK3cuZ4Z0uYMAajCkrtg5ZdEuVJ81nAuoc3KRjm38RXu+xmX4oH3dyyKlV5/9b9CR5Q6UMHBZ7TFpwImIFkSqeWA8EcNehupLNyyvTmiRKuEF4oAY0piyTY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058660; c=relaxed/simple; bh=vJ8bAp6BM8Ym7lhFiXPJqMY9TEHYiyl/QFo5utRKFMQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=a1EMhjnTNE5moT+jRZ5wV3GDPVxa9sVSD2jQRTjTa1erTLKPa9LufKZWqX8PTUzabo1TpEPZRKGcEOlLcBrNjbjz2jnmBc8n4HLRhxSw/1uytG3YNQFqcWi2yn8FuquxWnBFP80bg6KRvExvW8DytwS6k8bjZGB5vekcuQHGBpU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=aEBOMGGg; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="aEBOMGGg" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-3a375e72473so2332570f8f.0 for ; Mon, 16 Jun 2025 00:24:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750058656; x=1750663456; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=MWpvlitNQyjX/3TaR360oAQrBTAeMtXI+WOaWtAQaSM=; b=aEBOMGGgX2iSIC/zvbWqiBxJqEWVnIkG8iHiJZ1HaXF+inISU93AFd0GyK8BA4S4AN DqlIF2QKHGDpAQbuurvd0+v8nri0GcKRtdGHpLVghz3fpOADVy7WRZpP35jeKi1ngIIm av/N8zNryDlNYSTlE+J99YZOVkzFDgnY29TXZzvhgLMn/5EGKESEYLbV76wVRt+yf4k5 c5LepnENVbCviPcP/g0oBJ6+/skash5OeIhtu1yBfMm/5caz06EHIdLRDjvJzddVvLpA yB61sk+IaNkmkk4cDj/6dCAI88TFUO66lS3rqkuFCy6oUgOBcFZ6I9hiiApE+a3uJWeP 49pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750058656; x=1750663456; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MWpvlitNQyjX/3TaR360oAQrBTAeMtXI+WOaWtAQaSM=; b=dF7HzS0vRvPsGUilfPAypfusDhghDWkhvtj1UjG3B1i3N6whVb7dh9C788Jt2ogvzH rJ+r8Qa+GnTi2/RJwIVpIrU2j/hpEos+hxl3mZ9gSZKnywjle28JrTua7UnuGTHAUh// BGFhjp1ZPzgw6EOwYeyyS7IT19YJGq/Lbob0YDfiy1eeyXpv8dxYM0Mj+rujId6MdG+9 maXz1hzmnjsRkzXKWYsSRvISpZ5qpF3A3dmpbItcj/o57h8iXnTkmfdyJuvvvDANxui+ N6vbusvrpGkKs9ioxwBzH3bu1ApZCHyco1lDY3qSDrSA6x84UkjIZvJVOkPFnDSxSqVx +wKg== X-Forwarded-Encrypted: i=1; AJvYcCXfVyn0usstyp1UBL8hXpMN+g5HiSmXFOXYKTTTEJ5V4P/2/o9hL71G0qDJ+yzVqjGHvka895HTGTayDyU=@vger.kernel.org X-Gm-Message-State: AOJu0YzaYXddzhp328km0c2EAn5LXCV7Rilup8ck4c1eCD/AIMxHo+FA DoYOv59lPov1Bfhg+SM/og8CIZX/+PCH2u2mENdRTEkqY/GvVaHcRkB61DAzi7y6V5M= X-Gm-Gg: ASbGncvUICyWkCpZL2Kabj6dTiRMcz4jPt3gvsq1O5WvY1JgCigk3MQVpyWRx6HRLlK wFC7Qh8+pDbeOwaxNOMbD2koNt8abHN00fnuoY+Dv7l0+s7njm5lH40MGY/ngNiYqG237gM2zeR hgxrfP3PCIlv3YQisNZJU1kuytUi5Gz1Wyso7NvmGfI8skITPIRhgjFZRngukU+h5CNz+2ZBXkp bPrRpm+rGGDCNJu+eZQUNYfM47t5kLeNofob/ZoF631wYQdYNGH8UlaG3n2HwYIsu7TaSzwmS8F e4zK7fcXYH6dkJSr07rrr7SS683eWky1XlsxgQyfDIgKm1d4YeCo9Yim X-Google-Smtp-Source: AGHT+IG60Qst8hEoeVHJrOe8WgEudvUhx+mpO473XIVAY3lrRn/4uizUbO770sqASh+Stcf20K9q/w== X-Received: by 2002:a05:6000:1887:b0:3a4:e393:11e2 with SMTP id ffacd0b85a97d-3a5723a22d6mr6934662f8f.34.1750058656267; Mon, 16 Jun 2025 00:24:16 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4238:f8a4:c034:8590]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568b08c99sm10312334f8f.63.2025.06.16.00.24.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 00:24:15 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 16 Jun 2025 09:24:07 +0200 Subject: [PATCH v2 4/5] net: can: mcp251x: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250616-gpiochip-set-rv-net-v2-4-cae0b182a552@linaro.org> References: <20250616-gpiochip-set-rv-net-v2-0-cae0b182a552@linaro.org> In-Reply-To: <20250616-gpiochip-set-rv-net-v2-0-cae0b182a552@linaro.org> To: Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Linus Walleij , Bartosz Golaszewski , "Chester A. Unal" , Daniel Golle , DENG Qingfang , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Marc Kleine-Budde , Vincent Mailhol , Heiner Kallweit , Russell King Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-can@vger.kernel.org, linux-arm-msm@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2706; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=lkJ86orkP2RFoVEY51zoeHCrs4bybXiW/Oh3wEXk8Lc=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoT8aZQKikr6KLr+7sJ83F72c4Qw2op7eIEQMdv SZWIKBUqIyJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaE/GmQAKCRARpy6gFHHX cmMMD/91tStvBSl3Yl2SLPgO2b3FWoqjotFtD9nwyncmCBZAaKQaMsQe9bWB7/9rqiuJTzGliVu rlXPWr9hparqPA5clW3XAkCo77zYB8ea47eoILRXc/zdlqkJ6x+zgY6LrugVt8Uviz/0d8/z47x KZBnL3k+VnNoAIOhiCp93MvuBcGJjh/ufkABKWOxleQqVxAlwaEjdeGpn6h/EzHECApiZy+w9C1 WEgI2Wx+xQ0FUrvhc2/GNSV7vQ7dtde0zYOK/T1R7CuGMsXQrMcBoY3/1MwKBbLstuPTmZ3nRa6 Aw/KQO/PInbLvdftJA0kNzp3PZlBiG6EaXCwxN4JDNy6NamYf1kD/bGN69y45Ug1A1V7+jQVAUm G6OnyqsTaVo+xHwv9zs23rhRM3tdiXIwLzEhCahGLa3POsNGle6cmp04dQEUOgNmE0oEpWrB3GJ fWpEh0l6ewJWmPUMB0YjfYyeBQkc1mmo+cJd5nrhyNxNrmnB+MyMlxxuOMhwXHymJTwlLk0qztO deyO3oZa7k42NQcrmz76wLzL3IRRhC3K6JqMRUj36MtULNvrKNNM6xS34kAKd+CIuNCuElPWpzX rzMsMO6As+RxHRr+IVZB1SM0jlr2VvYCXu/pXDUCayEgXwQgo4KEBWnN1OQqIg80E22J+g8ARGL WXvAcETCA/XZPWg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Marc Kleine-Budde Reviewed-by: Vincent Mailhol --- drivers/net/can/spi/mcp251x.c | 26 ++++++++++++++++++-------- 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/drivers/net/can/spi/mcp251x.c b/drivers/net/can/spi/mcp251x.c index 60b7fd3040d02f114693cf66d61c8a075a32e278..5a95877b7419b4644664b2115c6= b43f4b586cf4c 100644 --- a/drivers/net/can/spi/mcp251x.c +++ b/drivers/net/can/spi/mcp251x.c @@ -533,29 +533,35 @@ static int mcp251x_gpio_get_multiple(struct gpio_chip= *chip, return 0; } =20 -static void mcp251x_gpio_set(struct gpio_chip *chip, unsigned int offset, - int value) +static int mcp251x_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct mcp251x_priv *priv =3D gpiochip_get_data(chip); u8 mask, val; + int ret; =20 mask =3D BFPCTRL_BFS(offset - MCP251X_GPIO_RX0BF); val =3D value ? mask : 0; =20 mutex_lock(&priv->mcp_lock); - mcp251x_write_bits(priv->spi, BFPCTRL, mask, val); + ret =3D mcp251x_write_bits(priv->spi, BFPCTRL, mask, val); mutex_unlock(&priv->mcp_lock); + if (ret) + return ret; =20 priv->reg_bfpctrl &=3D ~mask; priv->reg_bfpctrl |=3D val; + + return 0; } =20 -static void +static int mcp251x_gpio_set_multiple(struct gpio_chip *chip, unsigned long *maskp, unsigned long *bitsp) { struct mcp251x_priv *priv =3D gpiochip_get_data(chip); u8 mask, val; + int ret; =20 mask =3D FIELD_GET(MCP251X_GPIO_OUTPUT_MASK, maskp[0]); mask =3D FIELD_PREP(BFPCTRL_BFS_MASK, mask); @@ -564,14 +570,18 @@ mcp251x_gpio_set_multiple(struct gpio_chip *chip, val =3D FIELD_PREP(BFPCTRL_BFS_MASK, val); =20 if (!mask) - return; + return 0; =20 mutex_lock(&priv->mcp_lock); - mcp251x_write_bits(priv->spi, BFPCTRL, mask, val); + ret =3D mcp251x_write_bits(priv->spi, BFPCTRL, mask, val); mutex_unlock(&priv->mcp_lock); + if (ret) + return ret; =20 priv->reg_bfpctrl &=3D ~mask; priv->reg_bfpctrl |=3D val; + + return 0; } =20 static void mcp251x_gpio_restore(struct spi_device *spi) @@ -597,8 +607,8 @@ static int mcp251x_gpio_setup(struct mcp251x_priv *priv) gpio->get_direction =3D mcp251x_gpio_get_direction; gpio->get =3D mcp251x_gpio_get; gpio->get_multiple =3D mcp251x_gpio_get_multiple; - gpio->set =3D mcp251x_gpio_set; - gpio->set_multiple =3D mcp251x_gpio_set_multiple; + gpio->set_rv =3D mcp251x_gpio_set; + gpio->set_multiple_rv =3D mcp251x_gpio_set_multiple; gpio->base =3D -1; gpio->ngpio =3D ARRAY_SIZE(mcp251x_gpio_names); gpio->names =3D mcp251x_gpio_names; --=20 2.48.1 From nobody Fri Oct 10 04:06:48 2025 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72E4020E710 for ; Mon, 16 Jun 2025 07:24:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058661; cv=none; b=InyM4jHAR/147znx2rdAtvh7F7OX+qxKXgrP4P4FJUzPMAi37y2kO/IrH+vJdS6Ro+Z9voTuMbaDyTEmXby7/hjg2eC2M2Y4w7tQoBzNtuu49XgJHRjZLd43sGimFaxmJh5gsmoGnxUcmrb0hcqT78cVZ0TXa1dBWXnd523me1E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058661; c=relaxed/simple; bh=bd8/aik3yGNPjXbB6KULRUrIDnWYBUIad25vDgDipU4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QsqV7XHmkkt91UVmSpWgGJsMYfmhwCvuxTJDX+WECQnAuU+OnalJDDbHwTOQxg0gJBxVf7yP05eNNxvzcc68GdagLZSARuTnr7qYhrIdE3mNGxFwWbl8pNtU1e33QZj/ZZKoJ/rf8wO1tRMrAUtS8qZDCoLPqUQxbN9iZpH+nh4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=xeYYH912; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="xeYYH912" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-3a507e88b0aso4087427f8f.1 for ; Mon, 16 Jun 2025 00:24:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750058657; x=1750663457; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dk2490V7toxDqdX6m2bpZwWhZapb2e47P6mgRch0L+A=; b=xeYYH912+eWOaHa65vB/dPXI/ZFTQL/TeF7b+xXWe3r70W1RDvduV6us+wWEIHZMRx v/H0vlwAbdGWaM0cUPa3953j9uA7buzk08j5sioxZAIFWy3IJDS6FD/jWzl/euTQczuy 7kgD7213wZpVc7kwPhSufz3U56wGspTBVnsw5IQHg6U+VaFEo+0N2ocImJZlPFTeNJmp uDfJtN0u4IPI6urBs2QUzTjcKCmDvkFrRa3mcFSWNyDa1FtnEX4PW4+SFBIZZYNLSmWe MGr3BszVeU6ylt6iIF8ZIRIoYXvFPI70Owjov3wwa88BMNCDQofbCtrvDu1aALJb75jM NOJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750058658; x=1750663458; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dk2490V7toxDqdX6m2bpZwWhZapb2e47P6mgRch0L+A=; b=orMKDmPBEKL1opX56c5ZeJYpQPhWDmSQtEGE85g4M8mdy0XHhCp70fbvCVqdpvZ8I/ 94TA8oolwW3sXebaSQJ9IEt+XtdAJcD2dNS0bH0DgVA0T5cmwAJ1T9JDmN1xDC96HZeC /IKnHS8HctuzPAuTNms3mgJ3Q7YymErUUib6urtXtsC29AE6zHErM4uRmFR1Vq2IulOz OAkYdwFhVlOYNazB0D8iEhTREjJSCpnUrjRH6aZb5L0XNxbh4akXYZM2IB13h+PZwSg9 eLXeyTUQVF3Qphx7f0gPKeGRptBH6cb4x+AgosOWoYI+SMz4YjFn2JP60yv3kfshmAA7 /Vhg== X-Forwarded-Encrypted: i=1; AJvYcCVh8zqLBh3C0Bp4hSn+M02YUOzsmeSmDHvSD6pY/uXoDVDxP4B/wsZfE6W2hlM2ZYPrDPnoJQqy4SjWX+4=@vger.kernel.org X-Gm-Message-State: AOJu0Yxytrozz3ZkOyvWZGlVaR7V2pnTmjn18afxinfFkUK4tZTco2nO mxW1n+qmC1UofOIZKFX0+JxXz2BXv/506rrodTYR5Y6S37T3hpEuKG+V3F1aAUU32n8= X-Gm-Gg: ASbGncu8kiw70WgBd9FLdZn6xH7SKrOu61uuxscxctBqsUWHnCG+VW4VF6Ce1VYoTXb XYT8QFlTn4l4n/kJ8e4WfSU2utdx3wZeH/jP+9mDuzx/nq5oX9BWIZecIN0locL4ZS7L8mhhEGr nxq6Bfzh7osal7/enbQrGL9HbDMoy+cZ9uerl00JS3Jyzi+LcBnxF+mKAZjQ2LjMNaqCyrvZlKh if3qEubj7t65tK+AbjL49YsQCmsS9ApKHGNWPduNTttCh8KDVWDHuwgHG0UsLZLEJ2cY2Jv7/LF RwF5nDZPR1yLvNO3xIXXzONqmYGQJWNcB4o2I3Zac8h1GwwN4xcH297F X-Google-Smtp-Source: AGHT+IHjTITSdrkkTH11GT/+EzTBq3NAlKsV/J8ox/RCJxKJGn5B+8SotQM6qAKPmFBSZqyU8wHWmA== X-Received: by 2002:a05:6000:2901:b0:3a5:2f23:3789 with SMTP id ffacd0b85a97d-3a5723721acmr6221770f8f.15.1750058657595; Mon, 16 Jun 2025 00:24:17 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4238:f8a4:c034:8590]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568b08c99sm10312334f8f.63.2025.06.16.00.24.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 00:24:17 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 16 Jun 2025 09:24:08 +0200 Subject: [PATCH v2 5/5] net: phy: qca807x: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250616-gpiochip-set-rv-net-v2-5-cae0b182a552@linaro.org> References: <20250616-gpiochip-set-rv-net-v2-0-cae0b182a552@linaro.org> In-Reply-To: <20250616-gpiochip-set-rv-net-v2-0-cae0b182a552@linaro.org> To: Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Linus Walleij , Bartosz Golaszewski , "Chester A. Unal" , Daniel Golle , DENG Qingfang , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Marc Kleine-Budde , Vincent Mailhol , Heiner Kallweit , Russell King Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-can@vger.kernel.org, linux-arm-msm@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2068; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=902geVroxqYNedJuDkhJncS6CjvxOYP3g9PjXCsT2tY=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoT8aZsS4bPVXRFW8hbhc2HST9zbVAikAosjSbI VX1fc56BVGJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaE/GmQAKCRARpy6gFHHX crs/EACb+XZ2NzlhRTyZfKfSIMQTWBEOV5YlX+0P+ziYYneyaZfSMCBPUdEJBK484XG1I1qHbJv Cmm6pNOUfA/aS3PvVVLRpFRew4lHAGNBxWMwkEDMdr4R3fLHomhTENRC/o5GlosvQbirXlm+YZ3 xl+ulmmLLqnxVo2rkU85w+4KaCvAZQWOWrGHjCmP6qbYdLh5UvNbq7Adfu7hvuaNn7tPTdVrvCP gpod/ON6nr2S48R5ssyepgil95lcxK+GL883CxVhFpYNBxXswOlUjmb6dhEAAQIs7lz0k5I4Vfz hkDI0NuwjjNWG5VCXCF1c6rDyDn0MZNaoQTxhuAlk/RzIoE9VW8n/mTzISVQO3uI4qq7LakfmQa QmACdUVNQJcVF/bhdLfkbTm3wYlVcgj5cVhg+D/6XuIyJ30s8VfVltAyuh8+0HDtqRGLJ396pNN gK3QIS5FwHsvtDIEWoswl/DsYodSNONEubXFnddYuM4SvhMHM1Oj4EVkC3F8Lx7AVMGpeCu4Rnk e987RhUzSpX7bPmzdtASZSflEpbRKe5vESs+ZXkMWWBo8qbfL4QEINVH4IpN2b82fUmSAUTKXns XPxhjw4a+Gggh9ujtD6GzkOXQbxq2Nd+85WregsI5+tVUQXeGUsF4WLG/lJKPiGKSIEVaGEXZVp SbeagtT3GHBmMPA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Andrew Lunn --- drivers/net/phy/qcom/qca807x.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/net/phy/qcom/qca807x.c b/drivers/net/phy/qcom/qca807x.c index 1af6b5ead74bf615ad155e396b0ecc6fe5636e8c..6d10ef7e9a8a4d906ea3a7e0d73= 087e8907be9c4 100644 --- a/drivers/net/phy/qcom/qca807x.c +++ b/drivers/net/phy/qcom/qca807x.c @@ -377,7 +377,7 @@ static int qca807x_gpio_get(struct gpio_chip *gc, unsig= ned int offset) return FIELD_GET(QCA807X_GPIO_FORCE_MODE_MASK, val); } =20 -static void qca807x_gpio_set(struct gpio_chip *gc, unsigned int offset, in= t value) +static int qca807x_gpio_set(struct gpio_chip *gc, unsigned int offset, int= value) { struct qca807x_gpio_priv *priv =3D gpiochip_get_data(gc); u16 reg; @@ -386,18 +386,19 @@ static void qca807x_gpio_set(struct gpio_chip *gc, un= signed int offset, int valu reg =3D QCA807X_MMD7_LED_FORCE_CTRL(offset); =20 val =3D phy_read_mmd(priv->phy, MDIO_MMD_AN, reg); + if (val < 0) + return val; + val &=3D ~QCA807X_GPIO_FORCE_MODE_MASK; val |=3D QCA807X_GPIO_FORCE_EN; val |=3D FIELD_PREP(QCA807X_GPIO_FORCE_MODE_MASK, value); =20 - phy_write_mmd(priv->phy, MDIO_MMD_AN, reg, val); + return phy_write_mmd(priv->phy, MDIO_MMD_AN, reg, val); } =20 static int qca807x_gpio_dir_out(struct gpio_chip *gc, unsigned int offset,= int value) { - qca807x_gpio_set(gc, offset, value); - - return 0; + return qca807x_gpio_set(gc, offset, value); } =20 static int qca807x_gpio(struct phy_device *phydev) @@ -425,7 +426,7 @@ static int qca807x_gpio(struct phy_device *phydev) gc->get_direction =3D qca807x_gpio_get_direction; gc->direction_output =3D qca807x_gpio_dir_out; gc->get =3D qca807x_gpio_get; - gc->set =3D qca807x_gpio_set; + gc->set_rv =3D qca807x_gpio_set; =20 return devm_gpiochip_add_data(dev, gc, priv); } --=20 2.48.1