From nobody Fri Oct 10 09:16:38 2025 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E8A7207A25 for ; Mon, 16 Jun 2025 07:19:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058348; cv=none; b=FZeuJJteqdslHl6uLlqp6KogCZ5WOTusWQ9AQjVe35m1y2jx/D6hJjKiKPIr94wiASqoAvIh7s8L4mpDctKwSzvMPiOVn4kjFsOIvkRfzoi5xNSdgKwxfflE3dfLXGx9zuV6qtWvMok2LM5ouyTvMmFaYztanRrVTr0RfkvBjjY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058348; c=relaxed/simple; bh=6dDruxI0CMaIvewahEW6x/eO1kPM4lNc6aCD8Neqv4U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IwkPof7Kwtn8gy+4+mlv61L6tqM75XXlav0ZAotMO+xCpSY6b4nPzk6pH87jJZZuDzvMDnuBDBeNq6C+2bGMHg68pyFDCIC5pA/1QwsTpEoLMoaO4gbm86UcnVnMPnJhogLsgwYyK93DO8KwNFqMufO5BqvMQqZaJfu8XwnDkC4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=cpqON9or; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="cpqON9or" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-3a54700a46eso2723508f8f.1 for ; Mon, 16 Jun 2025 00:19:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750058345; x=1750663145; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=vJ+dN5ujs/yPK5NxfTplkwW8W001YBt6mCY985Z4SkY=; b=cpqON9orsy1V7TXZWfB9VM+fC4/y9ErgakL835d4AJdapWtGCCs95RoAi2SWhKuOlH WL361/+4RfMTj97tNmXqXmjDB8LdzsNUOgFgYatW5HLQRIqYWDsc6KvEVxGHCDOxqwP9 mWEIroOK/Xl9tkLiwP0w6wURX4weAeq21hSYKraNHSfNNs6f/afyHOmcbH21SNjw6Dej 7irlR1nGilHV/0uuOgTzou9CQXSJPw2bMoeIZn/gOSLlbHiOmbMvuCZtp7JhKOqDPy6T Qov7hPFhganlti6AWG+OI4+gr+jGPIwANLTXOJIgQeCCno4g58ph7gpF8uKQXwhmCi64 gT0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750058345; x=1750663145; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vJ+dN5ujs/yPK5NxfTplkwW8W001YBt6mCY985Z4SkY=; b=Z5oYQmy6KDFbNM6lF+Axhz6TRykyveas03VGMviXGzOOMVeS6YLh2TzWpjtDNR3UQY Yjmndsoip90HoIKF3WN38DdNRUYn5BtM4ucKmYMN5QkrrF228jCniMgoIHQXPg1luNcN 4PIbHGxtrmnArZ90dj7pnNsd9kKPlaBSlxY45AQ6TGJ3TYgYo5lk2OV5HYX8STRb/XNq ypRUt3v1x6JokQi9XtLI0V6nqHvzAqtFsLUEiy89PWQ4e0+60cyKYFpPlfXB6GPO0Xoz 8SrV/dlOl3IZpcFnqhOuy1REVdlUwDzTmMUxSKuS3TRLvXzADoL5oO+V30haEfDPNX89 cXrg== X-Forwarded-Encrypted: i=1; AJvYcCWvp1THzWbsmIoD+SrzywJlyC40SheRYVsDbemzo9M+1V5vQ3+nDc4xKYuOrPHYItyTvvdL7BntLOwaMJE=@vger.kernel.org X-Gm-Message-State: AOJu0Yyqvf65o08YPK02EVbHiknyjgkRqFZMoQas9hWhdTicv9obw9Yr sbzovvqNQp2TuhZZ6JAWIeLiBfvyWxQKDFysiOVkDSdDpyIS6/v/2yJaAD9EQjI6BuE= X-Gm-Gg: ASbGnctk6tOgZwwxXt1rSuzCC0n2Uuc/Hp/6PPKjxm93fnLYEsYAsS+i57pBF6CBvWK dGfC8nWjjz5weZyKHUQQnwt+yhM5AQP1v61hnsRwesJU49mUdvy2oV7t3Xw1OVzy8hEe/CtHnd+ cCU8ZHRmfcXlI6G1wbxzxlgAiXYN3gh9HxPaXsBZAGlfdGaYo7o3mLiosGgyKb2SLmJmcYXfWpS TOsDGL0+95g8x0QlXU8ba7Y7dghMsU7WeY8XQC1EMixiTLVNh4ui4+i2I+DCtxIBVSo18AMaYQ5 LaCIJQjdIiyLRseUifl0CtDPguhuRQfFRPogG5juVZVlK+wHCqOzCs5b X-Google-Smtp-Source: AGHT+IGrvqPwXuwW7Wt8iGrYHJ6Hx17pNZJ3uy+D3GSxiqlpgwmfGGMQoCEKU/W3wO8g8xPiu4rprw== X-Received: by 2002:a05:6000:708:b0:3a5:5278:e635 with SMTP id ffacd0b85a97d-3a572367577mr6082606f8f.3.1750058345506; Mon, 16 Jun 2025 00:19:05 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4238:f8a4:c034:8590]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a800d9sm10104675f8f.45.2025.06.16.00.19.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 00:19:04 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 16 Jun 2025 09:18:55 +0200 Subject: [PATCH v2 6/7] media: i2c: max96717: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250616-gpiochip-set-rv-media-v2-6-6825114f18b0@linaro.org> References: <20250616-gpiochip-set-rv-media-v2-0-6825114f18b0@linaro.org> In-Reply-To: <20250616-gpiochip-set-rv-media-v2-0-6825114f18b0@linaro.org> To: Mauro Carvalho Chehab , Linus Walleij , Bartosz Golaszewski , Bluecherry Maintainers , Andrey Utkin , Ismael Luceno , Tomi Valkeinen , Julien Massot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Niklas_S=C3=B6derlund?= Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1689; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=zxXtt6XCScDkqWqDmMavuunKoHjUaJSqDc/9xdViskQ=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoT8VhTa121fKKIQpI3rhzYMXqmMCXKdk/BpqNU VpWOl21xzqJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaE/FYQAKCRARpy6gFHHX cpKFEACfu8pKMvDD3IZCkpB5j/m+8PK17IIyGDaDrRdKdrdD16nX5b39juWTiB+k5uWZqdl+KK0 3IPT3FKP277tEWQTDZW8UqoaF+PO3/ZW5wnyDz529kBGDNeRJ451ZCpf5nkbmwSpUBvsY50RLlB 1WEdOu7DTjOOKEnTZT//6uF1F3yM+nsbTOb1Q0Xvu7gqszAjX5+4OSaYDIDRBa5TVY3t+qxrqYs gk5tjhOhNIhtO6KPfrWzboj+5csmAw0YUTVGVgWPf4nzgS9IDOEc+0Czs0YUTBaF+gi01GSvRZq uB8uQKHt1W2RWCXUWtUCQwEvtoZ3GYEMwNVdDJurGSQQFhbhzFxtvx57uUxMlKVSDJpUpwSX7O5 0/NBl2X6jqqaJlMpSH/DXeyGVbpSx9/FQLy/rXZvcQAvCOWAhbPdtZuxEgP/6MCAg/Z5SOYg8Uv i3Uqhadm1KC8+ndzvXI2RtdDLx2uHxfKdQrDkNBdc6crJwo90a2neDVf+aiDpr7ohb3JuqxTMOs evXG1VhhI3/qYvW72lkLfX6ZioJdR5b1BOivMCDLoc24ObdLKUG2PKfkNYXGbbeQhdKlWzqiAh1 SYHtq1Z5rrHvuWm50cSdguYZV5kCBJ6h/vimvMx8aO0qvJiu6iYJC6cGOj76S9BqBGSY0TjbQWm WKBO+5OY+aBNV8Q== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/media/i2c/max96717.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/media/i2c/max96717.c b/drivers/media/i2c/max96717.c index 3746729366aca3af8aef3a807e2f91a8f142ce59..a503a55fe8afa9bdda8fc9b1c2b= 0e7ebd02afe1c 100644 --- a/drivers/media/i2c/max96717.c +++ b/drivers/media/i2c/max96717.c @@ -297,13 +297,13 @@ static int max96717_gpiochip_get(struct gpio_chip *gp= iochip, return !!(val & MAX96717_GPIO_OUT); } =20 -static void max96717_gpiochip_set(struct gpio_chip *gpiochip, - unsigned int offset, int value) +static int max96717_gpiochip_set(struct gpio_chip *gpiochip, + unsigned int offset, int value) { struct max96717_priv *priv =3D gpiochip_get_data(gpiochip); =20 - cci_update_bits(priv->regmap, MAX96717_GPIO_REG_A(offset), - MAX96717_GPIO_OUT, MAX96717_GPIO_OUT, NULL); + return cci_update_bits(priv->regmap, MAX96717_GPIO_REG_A(offset), + MAX96717_GPIO_OUT, MAX96717_GPIO_OUT, NULL); } =20 static int max96717_gpio_get_direction(struct gpio_chip *gpiochip, @@ -355,7 +355,7 @@ static int max96717_gpiochip_probe(struct max96717_priv= *priv) gc->get_direction =3D max96717_gpio_get_direction; gc->direction_input =3D max96717_gpio_direction_in; gc->direction_output =3D max96717_gpio_direction_out; - gc->set =3D max96717_gpiochip_set; + gc->set_rv =3D max96717_gpiochip_set; gc->get =3D max96717_gpiochip_get; gc->of_gpio_n_cells =3D 2; =20 --=20 2.48.1