From nobody Fri Oct 10 03:57:26 2025 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94A091DE3C7 for ; Mon, 16 Jun 2025 07:19:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058343; cv=none; b=qb9elpSIXEn+/7RZhUGHLi1TnJszA5a0C+jOui2fPRLYpw4lTX1PnYhITNAB6FWPfVprbUS3JRD8nXKUyD4zXw6iaO9+oa0UCFHpqcWfwvMbCkxpYXxGVe8BM/jrwajsxO+amDh9ntJO3GNM3MJ1UPVyhXOw+GG0KejUeoFU/hg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058343; c=relaxed/simple; bh=b/qgu6/medib2vu4jNB/RyGMXO6WslAvUTV0AIziuY8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fI9gNMJMo/UBIL/9sL/g7ZD24yvjvnHd5MmX6/FrH3b4LpfR0JWNrLR4ey6i5mFbCw+FRKY/XVUXKxE+B+5JjZpCxuWOIE9jAmUP61CRXll/noHp4c0wNKjYy/ZnES2b0tGv/jUJbUyyFohmNaHYqT4nU70484f/f1i5+/2DT2I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=E2jNH6+9; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="E2jNH6+9" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3a536ecbf6fso2747162f8f.2 for ; Mon, 16 Jun 2025 00:19:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750058340; x=1750663140; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=WTP8xNB64zIn9DIEvp87doAXF5a/sVMPLzzHk43KYWg=; b=E2jNH6+95ccs3apCDnOeCeCVIp3e28riGIqxDeP6CV0xsG8fjtvYgFHZg9TcSFl3RG fakQDhH7vxDEftiTC/WhMqMK0IUdJVqAt/rqF5fnYh5jpsMLe0gvAJdTbVtnJONmmvF+ gVkjEE5P+o7ZErW64Ynjc6cbapiC/BR9MXouOFr6GRNJq2FgUhcqBdrMGM5nxTtzO5qJ 2z/6onPmGxsbZNP8jf6IjiVoHN1U0i06r4NnUDLFPzlw1s5xQKYbuNzmmVDDJCnDSsa9 CYAOvGP+5K55m9D7qRXWHUo+NveFvwB4EIp3iEnLw4fNJgskOVLX1UtsEbM8tiGG7oTH azgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750058340; x=1750663140; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WTP8xNB64zIn9DIEvp87doAXF5a/sVMPLzzHk43KYWg=; b=kLrkphuNKTNWdFtnI1bVZEl37964Pw39BrHS8FiPxQRZELFqMg76Mo3+aGQvhds3gO Wenbwuptupkd0wA574uVkHFgE/mLXkxn6jth4EF+LrRR3DToc7wrWYCgyZGf8GTca9lz dukZqBmTWmJmZ6g6WijL+cCW/ImjB3Fl3OA1vHYxZBCji602UtDpoSwb/k2Z1iJdmjZC UXLhXN188TGBSrgQovI5CftiBrfe6Y+LCBE0ThLQor1mvPWIxr44A37fSIk8F9K10X9J fSKx3G2ooOlMx7VSGILFYVi2jE0HyexWudSI88h9TduRmu0bpIQd9gs0GuY4pGt9R8ys h8uw== X-Forwarded-Encrypted: i=1; AJvYcCWXNmeSN23Kz+aI1Kkg16EtciR7Gm08ar51MNDE9AJvru4DM+mptJxY2MyYcclv2qutfmo9RW6MDLRrNJk=@vger.kernel.org X-Gm-Message-State: AOJu0Yww7rKc6EFbH0r9rP0+LXIC32RVD0wd5NhmclpJaeJ4Ke0BA/OE 4FG6P78LbYh/1h3sqkhfr7ujLMb/e8qfPE52U4QyLfjmRWDZGWPj8GvvAr+EOFEf354= X-Gm-Gg: ASbGnctOf3BCotrzFT7NEi6J2TLtJdFKRpp96uwN4tKpG6aiwChtqeKUgWHGsGTHOWJ L44vVNhD5wy5XaN9tcqQBejEMhTC4X8P9WlwjThNsd6FtR9PER/64Scjvvq7wXZt8x7DrZ7ZYOl CcSaNbCCsXxeBfcZfDSj5cCdyOisVMB+hMcP+Hh4/PxSvo1XX+ey6gyaycfq6SFPOWoTSI3H+X7 frMchk/H0xyRpxI1orsNrdjdoSSL5O42BJ3910TjHogPudPvCKuH+gb+vDWrsmnLCR/XULgDwtV OK5ewQqogA48r7AOycFet7jyGsGIgK1Wnf3n2BGH+8glthBuvNYhpKTH X-Google-Smtp-Source: AGHT+IHJwXDSA4Z5xe9culUJGL+TV3WkdcCjz/o5pvo+YDSZ+lGiZKhbROr9J7tnrwvTTu9uyJoTTg== X-Received: by 2002:a05:6000:708:b0:3a5:2cb5:6402 with SMTP id ffacd0b85a97d-3a572366594mr5798288f8f.12.1750058339835; Mon, 16 Jun 2025 00:18:59 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4238:f8a4:c034:8590]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a800d9sm10104675f8f.45.2025.06.16.00.18.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 00:18:59 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 16 Jun 2025 09:18:50 +0200 Subject: [PATCH v2 1/7] media: dvb-frontends/cxd2820r: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250616-gpiochip-set-rv-media-v2-1-6825114f18b0@linaro.org> References: <20250616-gpiochip-set-rv-media-v2-0-6825114f18b0@linaro.org> In-Reply-To: <20250616-gpiochip-set-rv-media-v2-0-6825114f18b0@linaro.org> To: Mauro Carvalho Chehab , Linus Walleij , Bartosz Golaszewski , Bluecherry Maintainers , Andrey Utkin , Ismael Luceno , Tomi Valkeinen , Julien Massot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Niklas_S=C3=B6derlund?= Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1778; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=N9OvQ6idGerlmLwTIQS5N5xpWnMU9Eqb+M235W9W9/w=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoT8VfUCH8X17r5pnPQAArlMx0ie4BcV65lDtej K8ofAVFSluJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaE/FXwAKCRARpy6gFHHX cvILD/40T92AubfBQ0A8MrcZS9ZOtc0sRIrcm7vjV8QU5m0Lru+HCv3binRNDyv9ye9PnZguVzc pHNNVZfUmjnE700pWtmvPiUKImzBBxc3wo8X4nxNbFUBqbf3FkzOfAdRFj4Ptr+sECms7XQrBMi qb5soJkuQSqUoK3VV7i4y04lqUgK6Bs5BKr/LQ90PByxbqmu8hbm65oUYYfOua9Iz5FEVqdHJMO HKBSjKlxYAb58ym9Jzg0SXl2Zm8PQwo7/+e5NjRRcGkO3PsL0spUPHvtGUQBJrFYMt+CQroAcGm 4tM9cXn+TNRPy1uZDLhtec9BexB+WJArnAkUJOC01FYge8qEmzRDTnnhGdJTxPE0D5pNDLFz5U+ FDz+XYD68WTOxF3uNS3/uhg+hPIS02qMy1FdRR32NndRoG9xWM+uet2lJjRl9RshUoZSN1ThDnd j1NTqoz69lwsigEBYVsbsDAffI+7Y0B0bVnqNmeP/jzqD5R9XXS4gWRt5IHOW5mdYkO0dmTh/DS XqOT8uCr2K/TI65F1Sor+rOppLSeodjPpxOiaUqQOy8GMXrcJr8zccM0VZ0XBb6sHxFIog02RFm Is0dOfI6ESG3494of5kAFh1UuVtYqtMZcsEI6+F3vN4zJrZnE0XqA8oslJmZRJ7FQcIgli99oyW /Deo8F6L0mnbwFg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/media/dvb-frontends/cxd2820r_core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/dvb-frontends/cxd2820r_core.c b/drivers/media/dv= b-frontends/cxd2820r_core.c index c3d8ced6c3baa6608e17cc4797dbeddc5a5ed510..a31a8a6a494652e6aae874c399f= c70df3f9ee172 100644 --- a/drivers/media/dvb-frontends/cxd2820r_core.c +++ b/drivers/media/dvb-frontends/cxd2820r_core.c @@ -433,7 +433,7 @@ static int cxd2820r_gpio_direction_output(struct gpio_c= hip *chip, unsigned nr, return cxd2820r_gpio(&priv->fe, gpio); } =20 -static void cxd2820r_gpio_set(struct gpio_chip *chip, unsigned nr, int val) +static int cxd2820r_gpio_set(struct gpio_chip *chip, unsigned int nr, int = val) { struct cxd2820r_priv *priv =3D gpiochip_get_data(chip); struct i2c_client *client =3D priv->client[0]; @@ -446,7 +446,7 @@ static void cxd2820r_gpio_set(struct gpio_chip *chip, u= nsigned nr, int val) =20 (void) cxd2820r_gpio(&priv->fe, gpio); =20 - return; + return 0; } =20 static int cxd2820r_gpio_get(struct gpio_chip *chip, unsigned nr) @@ -651,7 +651,7 @@ static int cxd2820r_probe(struct i2c_client *client) priv->gpio_chip.parent =3D &client->dev; priv->gpio_chip.owner =3D THIS_MODULE; priv->gpio_chip.direction_output =3D cxd2820r_gpio_direction_output; - priv->gpio_chip.set =3D cxd2820r_gpio_set; + priv->gpio_chip.set_rv =3D cxd2820r_gpio_set; priv->gpio_chip.get =3D cxd2820r_gpio_get; priv->gpio_chip.base =3D -1; /* Dynamic allocation */ priv->gpio_chip.ngpio =3D GPIO_COUNT; --=20 2.48.1 From nobody Fri Oct 10 03:57:26 2025 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1CC21F429C for ; Mon, 16 Jun 2025 07:19:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058344; cv=none; b=JSBZdDvWOI0AHW2yrfyl/phOv60UFTjqE9ieQ5dna2xpcXBhyzKJ1pUOC5EVEEaXXQv1wFN7I58hK0dQ7LI8o8wv6fDDARHFrqL0OTN/rMSnebvA/+vRcr1nynYMoa0Ofdwy/XBmeozWHkawSPKxBdljjjLO3/2nAh7ZIuilGgU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058344; c=relaxed/simple; bh=vBIY6MDSAZqxd0wvprVpXG2GeCT/g5H/eGKWlDdO1xw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mAUGGujlGnI6gh6cE4NLRJEYupQt5BM1MW0MC6pkeq90TWG/rwvX4Ax0/NNbEfy5C/QCEyUHreEDSkiVQSFLS/J5ykTkgIExR2H3mXaXNOOTxhuvR8FTw2AeYB//Yt5j1CVQ+uZapVe6Zdbb7u/DLblVChypnkMxw38GUm3lyXw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=aJ61Zh1Z; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="aJ61Zh1Z" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-451dbe494d6so54184575e9.1 for ; Mon, 16 Jun 2025 00:19:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750058341; x=1750663141; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XFQEt0BhzwG4HODHfj1luH5UGQeZf6dSsvCSdYpA/bw=; b=aJ61Zh1Z33Lult0K0RRqJKsKmSkssE6uP+pE97VB4lfmk9HR0ApE9rx9uDOpXnn/sC bNX36Gyj6pjn6DJjWZUF+uEhm6+qvlzIZwGdSDZqY93ys988O3ls+n8sWnbecg75u8zL WO+FW/IazzGeUSO+zBhDMTCH8Mt4tSnMHwnDcG8qE+Z90A3X25UdpryDMvAjNXr3XMaD 7/B7Rvw86GOGZ+n1C9aXo3bWVbM3LW0oHQRSVpYHrqSW4XIfCDxC4ZiXPUjZzHJ9FBvO 4lf7mxpb9e2/mJL7yLI//g7PT3tPlCDXIyj/1cm0BtCicBa3fw79P1C6qGKYpHwEbMtZ 4xYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750058341; x=1750663141; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XFQEt0BhzwG4HODHfj1luH5UGQeZf6dSsvCSdYpA/bw=; b=gW7EXnMG0cZ8padi5JAjMe3IZxrYpjb/eA6IGnjkU/Ph0PGF7hgTy2i94B0e+1xcMY 1kC6BwILFKSq5FQ81pqxHzQ9cMFvZUVLkzHwFj5l+pXlVB8uNnSXr9jzmFY86C8CKQko viA/rBqVyNo2bq/C7jJ0QMSR5KCnGreLcmsj/LUeny9fVtxloVYsREUMTq5H+IF9Ytlo NaC12v4EgoLEMmEo8QI1yGFv3cCkRYEGJazHOra7/e7A+LQoot4Ua3PIaTEXczkWuVMI vt7oOOp5bit0PCvwDE6v92+S/Bd8Vw2PubihGPieWWsafBWivFYcnm+I6m+DihLc3+bS iCqg== X-Forwarded-Encrypted: i=1; AJvYcCWtwqSU3jNPAwvGcCRdrsFQ5oGe5N1b6ZXdymRz8kYsrAMXoLM7qrMaThyZGzkKWpTysaHf2zm84lmLwCU=@vger.kernel.org X-Gm-Message-State: AOJu0YwsSCdQXg5t4uuuMxbjP/GYdVTKrHeBWk94BkpK6GY1XCb94BON 7o29t3C3RlC8e17gBAGGA0u7AEJEV8p7EFwNppXNWoqx7EFi0450xVSDEtFmOgJfS3Q= X-Gm-Gg: ASbGncsnzDWvgyrJQsUmhvIWskGK5q6pnx6xqR9aFNFNmuSEqqpX1+Pnh6UUUg+gXb5 R81JPVpJ9FS2QyTVh9hl9/6S2Wk0nUz5SC5swXDEZRqawi9yi1g5XHAgzBYr1lV1oIinPahUc4j sAICo3QRxIvTiRfyH/6NdWwj4UneMKdyx9hELjDMEpgxbtnLaSiycf+7GzUMTjlta6BUxJNKe8Q n4hCMTp1XWL+6Ba0xaPrJqOW7DMtZoAhcl0H6hStUcJTt2j8kT7t/XRknwjCCZbb52sfmrJfcr9 BHx2+/QyIXmBsKRBkwLKu53SbDUrTxgWc3Vh0bb9TCdSirV9eaTL61BB X-Google-Smtp-Source: AGHT+IEpeKJ1CCUa4tMKa0oknF2j53B2Vzui9IgtIoBGlg6AY0Bg52q9oEE9EXSypL2qtmZhOC9Vpw== X-Received: by 2002:a05:600c:8286:b0:450:cfe1:a827 with SMTP id 5b1f17b1804b1-4533cb1a7c4mr85727495e9.31.1750058340932; Mon, 16 Jun 2025 00:19:00 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4238:f8a4:c034:8590]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a800d9sm10104675f8f.45.2025.06.16.00.18.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 00:19:00 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 16 Jun 2025 09:18:51 +0200 Subject: [PATCH v2 2/7] media: solo6x10: remove unneeded GPIO direction setters Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250616-gpiochip-set-rv-media-v2-2-6825114f18b0@linaro.org> References: <20250616-gpiochip-set-rv-media-v2-0-6825114f18b0@linaro.org> In-Reply-To: <20250616-gpiochip-set-rv-media-v2-0-6825114f18b0@linaro.org> To: Mauro Carvalho Chehab , Linus Walleij , Bartosz Golaszewski , Bluecherry Maintainers , Andrey Utkin , Ismael Luceno , Tomi Valkeinen , Julien Massot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Niklas_S=C3=B6derlund?= Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1660; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=3e0iLtDRWFqoc+uvXxn0R7qOqIkpeyOfEDZD1yz0l28=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoT8VgTH5VeBr4PPOdRetEYlYzMkClEKJWnpxYv 5hOmlma2lGJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaE/FYAAKCRARpy6gFHHX cpv9D/9HcVpm+i5p59mNFTDBR+fpBVwg5ruxCIdKLP39iyUc1w35zJAYAL/Z6hX+PrDYBO5Knbb wfGTHGQ+Oy6zpo3AFNZ0QHb2zfP/SfelYTmPZLqAPY4LXmlbso85NRQh873E6FNbMpggqlobjQ1 fS82HKlxG5AGpbaxCMG5Kiou3LBmwqU4jcT0kQh5G4P1XYnKJJxCch50+aw3AA9jJAiZF6LtTUH JlTPLpF9dea21/jtDRqqNu3fbIRt/QdblA5QY3uiF6ySja5U/m5VMydqq8Stf2IrmKPGyiB4Luo fJt+sDX3A3b3nAzZkMx64GkKpwdnXbiT85HtSllz2TCZIybHj4iQ79XGnj8kPrcDCD+t6TNCBY6 9lkdB3o2XhUCLCHNZDMl/f7W6ZYMctXpHy4maauw1Nzzwa3lKFQPD0lVFHHBKI8NtRxUoqZ2LwG +vWvXVtum9gB9/j3vSbI0qNd6ryq8I6jy0ugYi+Rc23JUI3xSMyRuFWY2Or5mY5psPKdFvFQBhi 0Zqyn1DOtPf2QRHJcpj8KQhiIIghiFN2+5K7ejEekVUnkzKs14Ke06isc7+jmlEzC32p20howmI Z1WhlD4IYBHkEg8Z5lnMxPQOjPBKNMHv8QpE18VGgDc/WFuez8ngATxPcfl/Red339NcjgV9kt6 tLfg0topyhg4Bhw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski GPIO core already handles missing direction_input/output() callbacks. The ones in this driver also effectively return magic numbers which is not optimal either (the number accidentally corresponds with -EPERM which is different from the number GPIOLIB returns and so inconsistent). Just remove them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/media/pci/solo6x10/solo6x10-gpio.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/media/pci/solo6x10/solo6x10-gpio.c b/drivers/media/pci= /solo6x10/solo6x10-gpio.c index 084c30760e459e37cd1800132a93dfb0fc70398e..f51f865c69bd7b04fac7a1f951c= 734965d8fc993 100644 --- a/drivers/media/pci/solo6x10/solo6x10-gpio.c +++ b/drivers/media/pci/solo6x10/solo6x10-gpio.c @@ -116,18 +116,6 @@ static int solo_gpiochip_get_direction(struct gpio_chi= p *chip, return -1; } =20 -static int solo_gpiochip_direction_input(struct gpio_chip *chip, - unsigned int offset) -{ - return -1; -} - -static int solo_gpiochip_direction_output(struct gpio_chip *chip, - unsigned int offset, int value) -{ - return -1; -} - static int solo_gpiochip_get(struct gpio_chip *chip, unsigned int offset) { @@ -167,8 +155,6 @@ int solo_gpio_init(struct solo_dev *solo_dev) solo_dev->gpio_dev.can_sleep =3D 0; =20 solo_dev->gpio_dev.get_direction =3D solo_gpiochip_get_direction; - solo_dev->gpio_dev.direction_input =3D solo_gpiochip_direction_input; - solo_dev->gpio_dev.direction_output =3D solo_gpiochip_direction_output; solo_dev->gpio_dev.get =3D solo_gpiochip_get; solo_dev->gpio_dev.set =3D solo_gpiochip_set; =20 --=20 2.48.1 From nobody Fri Oct 10 03:57:26 2025 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C844D1F4706 for ; Mon, 16 Jun 2025 07:19:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058345; cv=none; b=aTPPJytOGuVfXtL5YA1fG3+nBom6rHxVKH2rR4KuvTRFsltJaVpP5O5D9nepPYNvqAmDxGcnZVd6QFeLphTzWHlP4k1stbTTYaawKwoXFZ6E2+alUG9MRMXZ4m+h0mKwCiWBMo2hZPmYrVEpDQw2HuSz4+bJ97b/omK5l+36goE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058345; c=relaxed/simple; bh=i4HUX8ifaxrfpP6Wtp01EbUr03JCgVc5lw8n3/X/fHI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HW5ZeLLB83A06qKDada1ofhSUiok2wc7jS5l9H6SMgEqFsrKEvxI5XMqumzKvXomG/2fno7+wVWkDUQyZfNzTPZ3EyNHDjP73x2c/4W8rwiiCQ/lESttoeP70MbazrTLjt6x3AFZa7LTW1ulkbnIsLeXpIlpEqN3ugYmKGMLTxs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=lI6DAoFS; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="lI6DAoFS" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-3a5257748e1so2923539f8f.2 for ; Mon, 16 Jun 2025 00:19:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750058342; x=1750663142; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=xq7xfBYrivDdeg+8ZFQsb9LtSkPdVzHMYNYxsllkpTQ=; b=lI6DAoFSCwEkV3XVYgkKECKIGHWbqLkSptW4rW7WSgY5qRikCyrL32UYn7ZKafAaD8 ZsjntKOX8U6+I7cw3B0Vivav29Qsrv0yIOkv2/jK2vj/c5Y2u7K2IbxibWmUcJlDnExt 3vfn9XA96g0QxZ3iXqeetoXISzcsRl1ugwiq26d7CZd43Nz4jK8xP4hvyyOqh0R2qZEV HOa7r7VlEzdAcLmn2cELHU3DU/ztCEg5GNhhiifoqfKpYEqR4XsvFYr3pazcQq3O4uCZ hVAJ2/T9GP3/ElPptWUFKp4g7IUk+5jDkCRRFFJH46q+YRbdY9AJse7Eyk+YhjeWKMie zP+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750058342; x=1750663142; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xq7xfBYrivDdeg+8ZFQsb9LtSkPdVzHMYNYxsllkpTQ=; b=rGg6j86+7y6AiJ8tanWrei2VnK00dump89UQHpboRSvce0cHFdpAT8xwUS7npS3oEo 3Po/AHDogHBA21e6Ifw1WcCFOVP3uhMVKgjkOGGJbgdmt7P1R5gbo4GlYgmMZhR8+bJm NELzQ2NCgmRg/UncO8I40h4anqUfIBNOTKbW5HfvxmtLKH/mUtmXPrFvZy0ld5CwSYeM m/4xa5IjmOHVfyGfG6vgLeWE/GZRkGMAxEK/q3xezcOQzQxjmyp7tiHjTwyv63Zb1j50 9++NPxbR7HsXnQ39Fq/1J6Bh0yQ1jJwkk8PfgiC6MwT/8GtYMfzt0DV7jkB6Plp1kdbb ywpg== X-Forwarded-Encrypted: i=1; AJvYcCUcXXZ+deQB366NJmMb39NJkt3TNTuWNpUyxT814+kbQGuaW2N58gqBAFQPBvMEZ22K+o0x6afNZFlO8vc=@vger.kernel.org X-Gm-Message-State: AOJu0YyaJuiQJsSogbB/VSgveLmvksroGeuR5bmfbIx0mm8+UwGSbEKV Tk/tXqP0VHu1IYUmiWbKaMFBDq6haV5SocILexwbPzbaVzPAKaT83m8E1iAIWj8G+P4= X-Gm-Gg: ASbGncvceN7WXScDFDFYeYGDGm2A/uArcHDdcgXxdNqgdZzeFGZmHojhDxJD2GlasJs 8WruKUcW8M3e1OaL9oqPcFhdFzgkZZp+I4quKezCZg31B5pMhV9Goflfb0XPIgcx2BJkzRLaSO6 p2le25igJKrdkiXYksuqFDBah3VunbHaqv2Hr8fadcdS40+TDPGWLq6SKpcwSoNaiqbzoPZfVYz cPkdFvGVZm62dVy1ae90moPslPTh/J/HN8hj2KpvoC+5DzLw0Aqwl02fcVaGHt1CjkAImq0qqEt gjCjgjs6MhrTmbygVFRWRTVnvgOzbfMIWNENQBdnUUpfNTPUDnM0HtIA X-Google-Smtp-Source: AGHT+IGqRQFtwLQB2XoRi5EOneCYIsZXe+77XlPZZC7TAn7DBrw2xMQ1XvuYegfIi9R1ySJiXAmKpg== X-Received: by 2002:a05:6000:290c:b0:3a4:f35b:d016 with SMTP id ffacd0b85a97d-3a572367993mr5930123f8f.11.1750058341928; Mon, 16 Jun 2025 00:19:01 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4238:f8a4:c034:8590]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a800d9sm10104675f8f.45.2025.06.16.00.19.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 00:19:01 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 16 Jun 2025 09:18:52 +0200 Subject: [PATCH v2 3/7] media: solo6x10: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250616-gpiochip-set-rv-media-v2-3-6825114f18b0@linaro.org> References: <20250616-gpiochip-set-rv-media-v2-0-6825114f18b0@linaro.org> In-Reply-To: <20250616-gpiochip-set-rv-media-v2-0-6825114f18b0@linaro.org> To: Mauro Carvalho Chehab , Linus Walleij , Bartosz Golaszewski , Bluecherry Maintainers , Andrey Utkin , Ismael Luceno , Tomi Valkeinen , Julien Massot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Niklas_S=C3=B6derlund?= Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1584; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=x0xLHApMRQLh5h/Yrn6OODER6U8QbupzF1WTnrs22BE=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoT8VgnkyfY9zXwUwAbF3pDGBMJaaSofXadbbUu oURaRqaoYiJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaE/FYAAKCRARpy6gFHHX cgNZEACfPdzwFh2olDjXYlCjJ4Sr3vGyHbfYbeSG5KnAngNEJzuwjX/R3eFGn2wmsj3A9G7fpTc k098NBx1cBk+qV95tArmvsGnNTVbZYI06Ug6fsC0u5JdDzMTCV9qMhkRnEHQ6HF/Njn4Tbyf7oc lYBbQh1zRPHrp7zwafBO/eYQsiNymFErIsYGlbZYgqFBOVqkroc8SrWR4EP97q1XDLZ82+28iMQ YTcM+AGVcqTDwaAItFQP4Li+A/2o80vhh5xGX9P9lG/iK+cIL9VvtLbSNkZ9b8+5jp3jhw4T+18 MULYURcxjfSAwZDgcyLeJKzG1b9BL98+6YtxkKMZjPLfwQMX9phMRMPANX6LF3VDP7M5GSWAnMv Trk568ROBMSljKU7XjzFrivOYLtn+oM5HqSc9jf8uHfbe5KTLl8odnVgQ6qniJlttsoTxk0f3Tq uS9jRORJBa4YyVhT5sopoTsrAxPlZafLCHtv9zD/O6GjIHk5AK9uq6ZRHKR8/qiJf9eYXdzHyp2 949IQEE71+rInMxcYWjjiZjDl2PnQ/v+KWOSms6Be890tRXeyV5bL9MFgqPYN6VsDkllD5LUouX lEhaWJ8HIuEeaUzC4REk124DK/wNRtA9YPmkExi5ohmfvqKV3i5gAifkzF1dTOb1M1ChpDVrBC1 U1VIpWct/4X0IKA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/media/pci/solo6x10/solo6x10-gpio.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/media/pci/solo6x10/solo6x10-gpio.c b/drivers/media/pci= /solo6x10/solo6x10-gpio.c index f51f865c69bd7b04fac7a1f951c734965d8fc993..b16a8453a62afd5a420b03bfb19= 67d18e1cb1167 100644 --- a/drivers/media/pci/solo6x10/solo6x10-gpio.c +++ b/drivers/media/pci/solo6x10/solo6x10-gpio.c @@ -127,8 +127,8 @@ static int solo_gpiochip_get(struct gpio_chip *chip, return 1 & (ret >> (offset + 8)); } =20 -static void solo_gpiochip_set(struct gpio_chip *chip, - unsigned int offset, int value) +static int solo_gpiochip_set(struct gpio_chip *chip, + unsigned int offset, int value) { struct solo_dev *solo_dev =3D gpiochip_get_data(chip); =20 @@ -136,6 +136,8 @@ static void solo_gpiochip_set(struct gpio_chip *chip, solo_gpio_set(solo_dev, 1 << (offset + 8)); else solo_gpio_clear(solo_dev, 1 << (offset + 8)); + + return 0; } #endif =20 @@ -156,7 +158,7 @@ int solo_gpio_init(struct solo_dev *solo_dev) =20 solo_dev->gpio_dev.get_direction =3D solo_gpiochip_get_direction; solo_dev->gpio_dev.get =3D solo_gpiochip_get; - solo_dev->gpio_dev.set =3D solo_gpiochip_set; + solo_dev->gpio_dev.set_rv =3D solo_gpiochip_set; =20 ret =3D gpiochip_add_data(&solo_dev->gpio_dev, solo_dev); =20 --=20 2.48.1 From nobody Fri Oct 10 03:57:26 2025 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7FA71FBEB0 for ; Mon, 16 Jun 2025 07:19:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058347; cv=none; b=M8o6+ZBqhCbjMaPZaxdB67Mv3cXrzqvcNR4WT0u08qHdwd/jZ2O1lmxYedpaWZlzG1Z1FgviOBownp/Lu+iGvX22ETnVdNaMq1+E68wauN+1UJfN1boetBY8Bfajp9+e5G2RsDeKvSjQynga4VZlHdKPuRWmWYWw5crKGCh1sIk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058347; c=relaxed/simple; bh=DmSMep/ln8oFNFSCxh+5YdfNVCHUYDbu+lN2rz8R7HQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QclTZqGfh2It9OjbwXmQLyMBL61QwKCFTZvMSRWsJjSxpmfruOOU4G8pZpTXrv2uccoKbpW9haR2dJ06Duj53jr2+MiMCkV8pOyiH66cH2+/iF018JeGpKz2hIXOis/sD9wjRTRewwjKHoPSSkyXFgV1Y3fBB7v8WENpdYdTpT4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=i59Pn6zZ; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="i59Pn6zZ" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-3a375e72473so2329448f8f.0 for ; Mon, 16 Jun 2025 00:19:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750058343; x=1750663143; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=q5StFzbVLsxYvLdlkRPCazQb/CEyrkV6c3CXJXiOD9M=; b=i59Pn6zZ8K3T195PwEDixWL2xnYuJA8l0NmfppiN27y+RHOjDlbl2/aTxSD6zg9KIZ 3IdnsAhI2WU7ebeOd/c/33/5FBCs5v+abmA3ItrmQ3HdN4vwoEzG4kAXZJYjJC5rEEUo 1REcq5kB6rHjZr7lKfs4J3a+B2J+lo0b2WlG2BMJi9nhm9M1pz75PMuHckp0tV6l1u2N 9GNpFR3lvQ03sa3rH4f1UU9yiaIVsbUlfWGXvy+nVlOSv2t35AL19W0W+hW+X172C7HI 8/CmIomR1JIcg0UjKGKQKc+dTtRUq1iyXaZDT5q/fw9YR3E3BhxnWUnC03QXyRxdp46J k9Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750058343; x=1750663143; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q5StFzbVLsxYvLdlkRPCazQb/CEyrkV6c3CXJXiOD9M=; b=HAdmBYf+xUU8eCdFutgyQDWC/EMwmIBxATccZ/1wnOLy8SBaWSEpNwSfHxJiyX/uz9 BqfsV2EdqjnU0iY/BY0NVHTXlDZYYb2PFwScnEIOg3Z91KlEQp/vvcSxr962TKd/+PQ1 9p2Dn7DFazHK7q9bEMREPkH5Ar9M5Nbh/C+EEEfQjV9Gnv6Xp/gmT6lfol+L/kt5zw9e Ol95EpQYGUQMvvJ3IsVfoufA4XxDAZut37LfBUOr1hg1AoPYesPvSH3hBDZvQEfNOO1E Y5g4LGeKkvdL3Fo6XsP8Nkkh2lyHifE8z/udBeLa8oMuKbFL7P6TPi5NQ6VKzPqjVbg0 b/ZQ== X-Forwarded-Encrypted: i=1; AJvYcCUfijVntK2JmJvDlVPxVExeLg74P8AD58yyhYLnl/BIVPRRVk1P5b5Swybzf5VKVjFlzHieJ3SHKzyVEb0=@vger.kernel.org X-Gm-Message-State: AOJu0YznA+167TGybbyvrcj9+30N4ANx0YIKZntIsjmU0LRdaKJKMUUc scWYDRq5/eN1vrb4wThK7o27dHistua6NRgtwsKw/a4aZngWNINfZ36CCVHjw6AESsI= X-Gm-Gg: ASbGncvMCVGq5762M9M4/wYSsx8PHf/1qCFp3Dm4EzxYsUZ9j+p3AMt66EkmGfEz52R SZMZ7OZQbQy9Y3ux9dPsTcIqFxfz1yio+S0PcOFZu4vYyhCI0lw/B1yu/nxCB+k3+C2QgD1aQge Efw9gT0nam+eOggOD6UEWWkQS/Z5JOpbXAtZXQl4CNk5I9QsxVtEKGgOwptIkZRx0wllwjG617Z A5sQoicwhnL366BRak6XIjDJokYtq4NAY/CKQIMC4gmnN5cAEui2mpL4qo4JhaZLkfCVFoLT2Y3 wxW5MTgc2zCkv4vYJCGnLD1dswaTMkNyRvfAfgI+I4jWV0SbIEyJIUrps18n/9Hruos= X-Google-Smtp-Source: AGHT+IHsOWWrGw33KPO8FAEDWsN0OuiT7G9mdfWH0+bjyHnAr3r7fXuZ0wWs+hQ4SoAA8KJrWsqr+g== X-Received: by 2002:a05:6000:2dc3:b0:3a5:39a0:2309 with SMTP id ffacd0b85a97d-3a572e586dbmr6519037f8f.55.1750058343179; Mon, 16 Jun 2025 00:19:03 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4238:f8a4:c034:8590]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a800d9sm10104675f8f.45.2025.06.16.00.19.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 00:19:02 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 16 Jun 2025 09:18:53 +0200 Subject: [PATCH v2 4/7] media: i2c: ds90ub953: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250616-gpiochip-set-rv-media-v2-4-6825114f18b0@linaro.org> References: <20250616-gpiochip-set-rv-media-v2-0-6825114f18b0@linaro.org> In-Reply-To: <20250616-gpiochip-set-rv-media-v2-0-6825114f18b0@linaro.org> To: Mauro Carvalho Chehab , Linus Walleij , Bartosz Golaszewski , Bluecherry Maintainers , Andrey Utkin , Ismael Luceno , Tomi Valkeinen , Julien Massot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Niklas_S=C3=B6derlund?= Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1766; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=6W1fcEZimkIBP6TJfRKXLMogRIa4qaWvK8I7PtSZn7U=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoT8VgMhj5jvqoi7RHW1ogviS+lBSZMCBRL1IgU fhHi2YCzj+JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaE/FYAAKCRARpy6gFHHX chRYEAC0YVhoYaRGsUXyymS2Gdmskk5QlVFH58KLAmS7lZGmGYU0f1/4OvnKyE0dFGKwkeae7UR Fodidlvcn2SXrq+AinKj6dU6pOut2HbxEngfhU537ilkg/JrbZGThhylcUEyYQg9Z/539kpyvch vp7wnxb9+YJDzwNq9VGOojja7kSKVQpE7wydot6qDFH9NqA2y34exbGtqA425vsayOpfgX5edJz CR4FNSC4fmOXx05+wbEreP6ERYJLL78CQ7XETvBs+bpIORhqCqBoc4cF7+HfnGlFn+SRFYuPLsI jK2X/H7FyNmp0VV/EhSDS4osL1uNkhYllX80GZXY1eNRe7tuWiTy402c8PYSUqRvVlYEExv26zP rqKEiecx3rl+dAF6oQ+jFs4B6APD8X1bkffqQ3ni1lxHcaSkGL8HoST52fEo2mekJEaNJ9AICMg o9ZFllhFG0Lt2xUA/uhKqO9+LxJwu1RnfBJUF7aINp1qoZWV6jYY8GicRRFrWzI1N4qzXyrPEcZ UOcMHXQVj0zLxLk+ENkmPBYnPZd5RuJkN0T5OAAqbhhy335uiWkGPgaNG3Ag+Kcp8tblD+xybyX 8sL3BsgspUggCNsdYVwPZhwqiRCoAgUk2UkkAvA564N3jp22VOajWLxPVQXcutVDtogGGtTLla/ tfjylgBhGmODGCQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/media/i2c/ds90ub953.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c index 59bd92388845eedf64587289c7f7424ee570524a..242dbf6d48f3905c8908bbb06ed= e84e068e2f267 100644 --- a/drivers/media/i2c/ds90ub953.c +++ b/drivers/media/i2c/ds90ub953.c @@ -317,14 +317,13 @@ static int ub953_gpio_get(struct gpio_chip *gc, unsig= ned int offset) return !!(v & UB953_REG_GPIO_PIN_STS_GPIO_STS(offset)); } =20 -static void ub953_gpio_set(struct gpio_chip *gc, unsigned int offset, int = value) +static int ub953_gpio_set(struct gpio_chip *gc, unsigned int offset, int v= alue) { struct ub953_data *priv =3D gpiochip_get_data(gc); =20 - regmap_update_bits(priv->regmap, UB953_REG_LOCAL_GPIO_DATA, - UB953_REG_LOCAL_GPIO_DATA_GPIO_OUT_SRC(offset), - value ? UB953_REG_LOCAL_GPIO_DATA_GPIO_OUT_SRC(offset) : - 0); + return regmap_update_bits(priv->regmap, UB953_REG_LOCAL_GPIO_DATA, + UB953_REG_LOCAL_GPIO_DATA_GPIO_OUT_SRC(offset), + value ? UB953_REG_LOCAL_GPIO_DATA_GPIO_OUT_SRC(offset) : 0); } =20 static int ub953_gpio_of_xlate(struct gpio_chip *gc, @@ -362,7 +361,7 @@ static int ub953_gpiochip_probe(struct ub953_data *priv) gc->direction_input =3D ub953_gpio_direction_in; gc->direction_output =3D ub953_gpio_direction_out; gc->get =3D ub953_gpio_get; - gc->set =3D ub953_gpio_set; + gc->set_rv =3D ub953_gpio_set; gc->of_xlate =3D ub953_gpio_of_xlate; gc->of_gpio_n_cells =3D 2; =20 --=20 2.48.1 From nobody Fri Oct 10 03:57:26 2025 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E1C5203706 for ; Mon, 16 Jun 2025 07:19:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058348; cv=none; b=E9LZWdqRREhp6T0nxL5yiKW0BCbC7/edqXplfHzPxKHads7D7xqp1gXko7RiAyBy8hOnfY7JKmI6hCWxwpwUZOf+KFJsa0kAtSTLcN4kJxNZ2O8tDykpLSCUH9Ts/ckFHw2C9ZF1hSfEXne52cDgpvoMBIC3L94kwqje/MYcY84= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058348; c=relaxed/simple; bh=kgpyXSnZmCFwqfmomq7FGHn3gBVV4OHMPubpvkjXFrI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EyjZs9RhpnUBy+kdst+E0MElNjshjfnyBTygC5SVy8FV2M6xj6YKBM6dRiPlXkAZ4hGVZn2nI5XEk9qmAxC1i3qUceiTeI8fl/JBiA4ukBIR/WgD8E++ZabIKeKc+EQorZQ0pQeGxSHVL16nm5t7JD8h2qPacm3YK6qSliUuDSM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=Yk7SGk2c; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="Yk7SGk2c" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3a54690d369so4325714f8f.3 for ; Mon, 16 Jun 2025 00:19:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750058344; x=1750663144; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EmUjxGb9YXlrFmgTBSGtVdHlWeBBc2YrESubaUeQXrg=; b=Yk7SGk2cUaQrxHdo+Cmw3V7rIXT21M8xtRYzyFrUXsM3LttxxV6DkZCLwPZO9BIBd5 sVCpOe7EF/mr37LHz4NXISyWxZFNDqqkl4jerxFg7+tu/draaozz3cIL6v+EeA4AvXTa k4PpFOE6ice0zu3SaQjOonFN/ohGT3QJMH/JfFUJKWSunO+wQ6dAxsK8Vlg8mHVvg86C xIBW6WEgLmPmjWhqv4nkv+GNaDtM6xpR/nD5p9/IVfkkyz13SVYc9BxCaUBwsTKh4W32 it1buN3iyNUXO0JFXpBT+ekoJpvF9LSBZVYNz7mNOjfxaLfx31u8l4F0efblzhAq5AbY mttQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750058344; x=1750663144; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EmUjxGb9YXlrFmgTBSGtVdHlWeBBc2YrESubaUeQXrg=; b=p7iktiU4SQGbhFh0CAGRuVlX+gHKjQhbEuDZ9r+nGu6XCRD19ntGI5RsT5278Hob8m xgP85sAndUS+Dr72TNwrNCOLwyf28AszvqJVYi21wATUH06svTqYPOi6ntaUj82eXXUi a870w9DWxUhKQbJm/53vUpUKb7YfRAmt/c4Fh2tKCxLQYVh/JiwhbvZx02iF8QVCNR36 AwKRXWez4Z1g2A3+YOOD1IRfPaBhD9R6pLGMVpKXO9UXp7+kEEhTW/FM5k7o4MfoSMM2 EPhDHe6NDp6g6eJogaNOl/gT63LUzVQlUuBs4m+N+fiULhEZyv7qY+0uOB9f5zUBkjMy YLbg== X-Forwarded-Encrypted: i=1; AJvYcCXFirz+/ZdhGnrc7BSN4TVuclnX0G2WEFIbrBBNv7ODn29VIUMN/Rmqt4H6KU9/Bopmx5TB5JnOiaQsmQM=@vger.kernel.org X-Gm-Message-State: AOJu0YxxZEn1oELsq7S8AyXqA6ZhzQqOrBwwGZo4YyIDej28o8e8i0Bz BfTRh7DDf2+Rp/FZ2NJ/KZmoNELplXMMKKeE9rs9KO3on+tclUcNfHvsd6RzUFqs4zI= X-Gm-Gg: ASbGnctN6/Ba2NWw8VQEr0CVWwtFgrbTFfMK4XaZWPchBOfV0/cASbVxEML6aZP2+1i 7cmW2IYllhJ32qMSzumPRrO/ZsMAKim/rFPRB3Q14n+2VlJfONvVvCUVW7PmpHa/CvyEDMQZNMd W2Nne5z8uR25f8tQGY4hBPcJdFWevu7FFoGiNZvwWVbCB0x/G4OJFgbgupms833cRfkm+H1r9JD m2xH1ZfQkxUDbVlRxNbmHgj1PFfJKxV66v6/8cjUhz1oOxHWRKDCdkRbyWWgWKNPiiEPh5mmHm2 yDFma+vFbUu5k8w5BtiGQ097zuNtKrtH7QWF7VpaefI0QHfwPGYZYkao X-Google-Smtp-Source: AGHT+IGz82INEfm0MrBcQOnfOvjXW+7kZRw4hSg52Kw3fKhlwkINRRZt46P4IvIxeYULedfUDuAn2A== X-Received: by 2002:a05:6000:4308:b0:3a4:cfbf:519b with SMTP id ffacd0b85a97d-3a572c455d4mr7114649f8f.44.1750058344156; Mon, 16 Jun 2025 00:19:04 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4238:f8a4:c034:8590]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a800d9sm10104675f8f.45.2025.06.16.00.19.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 00:19:03 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 16 Jun 2025 09:18:54 +0200 Subject: [PATCH v2 5/7] media: i2c: ds90ub913: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250616-gpiochip-set-rv-media-v2-5-6825114f18b0@linaro.org> References: <20250616-gpiochip-set-rv-media-v2-0-6825114f18b0@linaro.org> In-Reply-To: <20250616-gpiochip-set-rv-media-v2-0-6825114f18b0@linaro.org> To: Mauro Carvalho Chehab , Linus Walleij , Bartosz Golaszewski , Bluecherry Maintainers , Andrey Utkin , Ismael Luceno , Tomi Valkeinen , Julien Massot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Niklas_S=C3=B6derlund?= Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1383; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=uirTvdGFKLj1HJ829gQF9CK8Tn6xJqSzhqLKMW/nEqE=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoT8Vg+JQxKi0/cLa/njC60fyp3VsUhtFUxANbk eGSVyRl2Y+JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaE/FYAAKCRARpy6gFHHX cu/PEACIrLPskE3Cw9Fq5/8R9425tpr+lSdYx/OQR1KNyOkXNpvTibWSiDJ4ipusnmH870tGlOt XXXBh3avCHvuPMfv8hQN3nANOImkOtLDt6333qnRFAvJsPbiYXvIhzxjBYCaLStZlAIAkjxFCmg Wlc/nS3aaqSUaQIvy55jpV2bL8kiHAISTJhdIEKnlXG3fs/Z/wpgpMeEnjLJyix8k2diDf/L9st Td/YJuetQOMZX6aJYPulZ2VW3OizRSr03tueMjZTWn8a9b80YypEo2QtQW1nVXx49cMi12DlSp9 EMRKglTjv+TSa5gvoIu2th1p7hbbg/XvTYCEryChn0sNuaXbbWLvZ1q82lrrZ/DTQyREyEg49gv hMwSW5kEHAAyZ6SgYDI2sBAbeSLt/ET8x2TFPCps5Ff8sMtArSTZa1k0REaidF9rienGiifo8PE +7HqS2ETNyqQbWX7KFIGJpCMskfQacSrXxzl/2Dst2Z6b2WXPAM29doi+isHi81esf8+fKZGCGh M7FC0jBfBOatPBt4l9HXhmb9U0MXJftJ4yi4GNzIqqsJlvEtxf6qjoG1o30WW7Gd95DSCtzIHae kR9KkQmHmiOA8nOI9y6KZ3iYSDif1AVvXBiW1yf+QAnUi3gfZgwqkpmYp6ls/MvZ1Gx4AJwUdFZ iwenE4uVn5nKqLA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/media/i2c/ds90ub913.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/ds90ub913.c b/drivers/media/i2c/ds90ub913.c index 6d3f8617ef136c6f47871f5886193fe934c6f3b7..c34ffeae5f5080875463b6b6d45= acbd9e107d461 100644 --- a/drivers/media/i2c/ds90ub913.c +++ b/drivers/media/i2c/ds90ub913.c @@ -203,9 +203,9 @@ static int ub913_gpio_direction_out(struct gpio_chip *g= c, unsigned int offset, 0)); } =20 -static void ub913_gpio_set(struct gpio_chip *gc, unsigned int offset, int = value) +static int ub913_gpio_set(struct gpio_chip *gc, unsigned int offset, int v= alue) { - ub913_gpio_direction_out(gc, offset, value); + return ub913_gpio_direction_out(gc, offset, value); } =20 static int ub913_gpio_of_xlate(struct gpio_chip *gc, @@ -235,7 +235,7 @@ static int ub913_gpiochip_probe(struct ub913_data *priv) gc->ngpio =3D UB913_NUM_GPIOS; gc->get_direction =3D ub913_gpio_get_direction; gc->direction_output =3D ub913_gpio_direction_out; - gc->set =3D ub913_gpio_set; + gc->set_rv =3D ub913_gpio_set; gc->of_xlate =3D ub913_gpio_of_xlate; gc->of_gpio_n_cells =3D 2; =20 --=20 2.48.1 From nobody Fri Oct 10 03:57:26 2025 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E8A7207A25 for ; Mon, 16 Jun 2025 07:19:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058348; cv=none; b=FZeuJJteqdslHl6uLlqp6KogCZ5WOTusWQ9AQjVe35m1y2jx/D6hJjKiKPIr94wiASqoAvIh7s8L4mpDctKwSzvMPiOVn4kjFsOIvkRfzoi5xNSdgKwxfflE3dfLXGx9zuV6qtWvMok2LM5ouyTvMmFaYztanRrVTr0RfkvBjjY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058348; c=relaxed/simple; bh=6dDruxI0CMaIvewahEW6x/eO1kPM4lNc6aCD8Neqv4U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IwkPof7Kwtn8gy+4+mlv61L6tqM75XXlav0ZAotMO+xCpSY6b4nPzk6pH87jJZZuDzvMDnuBDBeNq6C+2bGMHg68pyFDCIC5pA/1QwsTpEoLMoaO4gbm86UcnVnMPnJhogLsgwYyK93DO8KwNFqMufO5BqvMQqZaJfu8XwnDkC4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=cpqON9or; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="cpqON9or" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-3a54700a46eso2723508f8f.1 for ; Mon, 16 Jun 2025 00:19:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750058345; x=1750663145; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=vJ+dN5ujs/yPK5NxfTplkwW8W001YBt6mCY985Z4SkY=; b=cpqON9orsy1V7TXZWfB9VM+fC4/y9ErgakL835d4AJdapWtGCCs95RoAi2SWhKuOlH WL361/+4RfMTj97tNmXqXmjDB8LdzsNUOgFgYatW5HLQRIqYWDsc6KvEVxGHCDOxqwP9 mWEIroOK/Xl9tkLiwP0w6wURX4weAeq21hSYKraNHSfNNs6f/afyHOmcbH21SNjw6Dej 7irlR1nGilHV/0uuOgTzou9CQXSJPw2bMoeIZn/gOSLlbHiOmbMvuCZtp7JhKOqDPy6T Qov7hPFhganlti6AWG+OI4+gr+jGPIwANLTXOJIgQeCCno4g58ph7gpF8uKQXwhmCi64 gT0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750058345; x=1750663145; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vJ+dN5ujs/yPK5NxfTplkwW8W001YBt6mCY985Z4SkY=; b=Z5oYQmy6KDFbNM6lF+Axhz6TRykyveas03VGMviXGzOOMVeS6YLh2TzWpjtDNR3UQY Yjmndsoip90HoIKF3WN38DdNRUYn5BtM4ucKmYMN5QkrrF228jCniMgoIHQXPg1luNcN 4PIbHGxtrmnArZ90dj7pnNsd9kKPlaBSlxY45AQ6TGJ3TYgYo5lk2OV5HYX8STRb/XNq ypRUt3v1x6JokQi9XtLI0V6nqHvzAqtFsLUEiy89PWQ4e0+60cyKYFpPlfXB6GPO0Xoz 8SrV/dlOl3IZpcFnqhOuy1REVdlUwDzTmMUxSKuS3TRLvXzADoL5oO+V30haEfDPNX89 cXrg== X-Forwarded-Encrypted: i=1; AJvYcCWvp1THzWbsmIoD+SrzywJlyC40SheRYVsDbemzo9M+1V5vQ3+nDc4xKYuOrPHYItyTvvdL7BntLOwaMJE=@vger.kernel.org X-Gm-Message-State: AOJu0Yyqvf65o08YPK02EVbHiknyjgkRqFZMoQas9hWhdTicv9obw9Yr sbzovvqNQp2TuhZZ6JAWIeLiBfvyWxQKDFysiOVkDSdDpyIS6/v/2yJaAD9EQjI6BuE= X-Gm-Gg: ASbGnctk6tOgZwwxXt1rSuzCC0n2Uuc/Hp/6PPKjxm93fnLYEsYAsS+i57pBF6CBvWK dGfC8nWjjz5weZyKHUQQnwt+yhM5AQP1v61hnsRwesJU49mUdvy2oV7t3Xw1OVzy8hEe/CtHnd+ cCU8ZHRmfcXlI6G1wbxzxlgAiXYN3gh9HxPaXsBZAGlfdGaYo7o3mLiosGgyKb2SLmJmcYXfWpS TOsDGL0+95g8x0QlXU8ba7Y7dghMsU7WeY8XQC1EMixiTLVNh4ui4+i2I+DCtxIBVSo18AMaYQ5 LaCIJQjdIiyLRseUifl0CtDPguhuRQfFRPogG5juVZVlK+wHCqOzCs5b X-Google-Smtp-Source: AGHT+IGrvqPwXuwW7Wt8iGrYHJ6Hx17pNZJ3uy+D3GSxiqlpgwmfGGMQoCEKU/W3wO8g8xPiu4rprw== X-Received: by 2002:a05:6000:708:b0:3a5:5278:e635 with SMTP id ffacd0b85a97d-3a572367577mr6082606f8f.3.1750058345506; Mon, 16 Jun 2025 00:19:05 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4238:f8a4:c034:8590]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a800d9sm10104675f8f.45.2025.06.16.00.19.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 00:19:04 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 16 Jun 2025 09:18:55 +0200 Subject: [PATCH v2 6/7] media: i2c: max96717: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250616-gpiochip-set-rv-media-v2-6-6825114f18b0@linaro.org> References: <20250616-gpiochip-set-rv-media-v2-0-6825114f18b0@linaro.org> In-Reply-To: <20250616-gpiochip-set-rv-media-v2-0-6825114f18b0@linaro.org> To: Mauro Carvalho Chehab , Linus Walleij , Bartosz Golaszewski , Bluecherry Maintainers , Andrey Utkin , Ismael Luceno , Tomi Valkeinen , Julien Massot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Niklas_S=C3=B6derlund?= Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1689; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=zxXtt6XCScDkqWqDmMavuunKoHjUaJSqDc/9xdViskQ=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoT8VhTa121fKKIQpI3rhzYMXqmMCXKdk/BpqNU VpWOl21xzqJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaE/FYQAKCRARpy6gFHHX cpKFEACfu8pKMvDD3IZCkpB5j/m+8PK17IIyGDaDrRdKdrdD16nX5b39juWTiB+k5uWZqdl+KK0 3IPT3FKP277tEWQTDZW8UqoaF+PO3/ZW5wnyDz529kBGDNeRJ451ZCpf5nkbmwSpUBvsY50RLlB 1WEdOu7DTjOOKEnTZT//6uF1F3yM+nsbTOb1Q0Xvu7gqszAjX5+4OSaYDIDRBa5TVY3t+qxrqYs gk5tjhOhNIhtO6KPfrWzboj+5csmAw0YUTVGVgWPf4nzgS9IDOEc+0Czs0YUTBaF+gi01GSvRZq uB8uQKHt1W2RWCXUWtUCQwEvtoZ3GYEMwNVdDJurGSQQFhbhzFxtvx57uUxMlKVSDJpUpwSX7O5 0/NBl2X6jqqaJlMpSH/DXeyGVbpSx9/FQLy/rXZvcQAvCOWAhbPdtZuxEgP/6MCAg/Z5SOYg8Uv i3Uqhadm1KC8+ndzvXI2RtdDLx2uHxfKdQrDkNBdc6crJwo90a2neDVf+aiDpr7ohb3JuqxTMOs evXG1VhhI3/qYvW72lkLfX6ZioJdR5b1BOivMCDLoc24ObdLKUG2PKfkNYXGbbeQhdKlWzqiAh1 SYHtq1Z5rrHvuWm50cSdguYZV5kCBJ6h/vimvMx8aO0qvJiu6iYJC6cGOj76S9BqBGSY0TjbQWm WKBO+5OY+aBNV8Q== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/media/i2c/max96717.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/media/i2c/max96717.c b/drivers/media/i2c/max96717.c index 3746729366aca3af8aef3a807e2f91a8f142ce59..a503a55fe8afa9bdda8fc9b1c2b= 0e7ebd02afe1c 100644 --- a/drivers/media/i2c/max96717.c +++ b/drivers/media/i2c/max96717.c @@ -297,13 +297,13 @@ static int max96717_gpiochip_get(struct gpio_chip *gp= iochip, return !!(val & MAX96717_GPIO_OUT); } =20 -static void max96717_gpiochip_set(struct gpio_chip *gpiochip, - unsigned int offset, int value) +static int max96717_gpiochip_set(struct gpio_chip *gpiochip, + unsigned int offset, int value) { struct max96717_priv *priv =3D gpiochip_get_data(gpiochip); =20 - cci_update_bits(priv->regmap, MAX96717_GPIO_REG_A(offset), - MAX96717_GPIO_OUT, MAX96717_GPIO_OUT, NULL); + return cci_update_bits(priv->regmap, MAX96717_GPIO_REG_A(offset), + MAX96717_GPIO_OUT, MAX96717_GPIO_OUT, NULL); } =20 static int max96717_gpio_get_direction(struct gpio_chip *gpiochip, @@ -355,7 +355,7 @@ static int max96717_gpiochip_probe(struct max96717_priv= *priv) gc->get_direction =3D max96717_gpio_get_direction; gc->direction_input =3D max96717_gpio_direction_in; gc->direction_output =3D max96717_gpio_direction_out; - gc->set =3D max96717_gpiochip_set; + gc->set_rv =3D max96717_gpiochip_set; gc->get =3D max96717_gpiochip_get; gc->of_gpio_n_cells =3D 2; =20 --=20 2.48.1 From nobody Fri Oct 10 03:57:26 2025 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5330721146C for ; Mon, 16 Jun 2025 07:19:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058351; cv=none; b=gG9p93s/DEGiwCqQPktGns6AbfgFaoVFJIDuVGr58cygKqSDe5J0ZhgrCTekJ/LwY61zkBzbTsqtPCFM92UhKYCN5CXPEXCWOJ1G3X2xvAWr91GmkbxQ/KGHzIapFFBsji04tvoAYQWxpri2hdajmTs3pc1TcOmsk3jaWgLwMWs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058351; c=relaxed/simple; bh=j8Ee5zNRTgD6Im7szjj0YX+ao0qiLzGNAn/JhbhBZbo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=R4rA4APqvlfhp4PZsqEidgL+QZzibk2ncTX3Qsnq8naM56iEvmRgw4sztQVhz/wNh42fN6MeoTt1EQZNpqtKLk+rcvdXWOWB03TnDEqPPC7ALbcArJW3/X+ygJYBPzTiw8VqLuj2eZ5isqOzhhL6S6wNro4LRNofAErPC7a48B8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=qDCrGNw6; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="qDCrGNw6" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-3a36748920cso4888904f8f.2 for ; Mon, 16 Jun 2025 00:19:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750058348; x=1750663148; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=UnEiJ0DPVJeTNWgLtlb3XDcjvamvu9NbT3oHT6+NmYs=; b=qDCrGNw6vOVtCYsWW6pZuP63jtcaTzjRYotoYEfzsBcsOw77W8+OTE6sqlWN2IplRj /Lw4SofKdSF5agcg/Ab3aQvGFlMSFeACELVDKms3zaZU0xZXOttedeNdzTwI9chwpeQM bLJLEOpGSAjSaU37wZiuN0BwFEsRAkGMhvJ5rfDixq87wbIW4eNjy8kG1/o+18mPbrhs w72yENPZ92jOI1BVtK7pToaDHZSwASfVUrdML4MH2Kq7RUWFB6Ep6YoVlYtONRa1X1RH aXZ/3cKlPu4tvP0Zy6Nn2u+UXIEZr+lNCv2zyZKx1b0Jbg/DaIQUONF8U8K9iVv5V5Gs P6qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750058348; x=1750663148; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UnEiJ0DPVJeTNWgLtlb3XDcjvamvu9NbT3oHT6+NmYs=; b=MyyYujRXyoSDePetFnW+ZATPKzASb/K1hEGvxVRDUZh+pCSPWDFYMGwsrkrDA5ZI/O dxcKX44lsUo+IueFTq7+W5uqWHgmi6W4nWpNou6npZfcM4lmg+fbKQQ99IEU4y6JwZlv a69JuI7iYbrzrYSfxzr7Jnx1439Rnum19cpxXyUgoEbuaXlqhW74QOsw6uQPa3HBwSg6 B+SKeQvpHdrvXLEX1SzX6CZn9FI8wAe9FrlrgtANC+7ARRtxUn3MLAwiJ4+ZL2ZtY6wh gbJRGVYkolE8st2b03cJ47nX8KJ1H78rzA9FcTyHEIJmX7qCZ4NHfipMcMkuO1Pmb/UZ 5yLw== X-Forwarded-Encrypted: i=1; AJvYcCW5wzibrITymQxX8fAKjq0VPbXQQBDemKFk4WOOgSxG97iYq7wwZHB/+8sjZo7yZ/I6ZpoxDmgrD10d3HY=@vger.kernel.org X-Gm-Message-State: AOJu0Yxzz4cMV1gX1XlYo1HgMD+5PNdTYmfdL3VlUY0jwM8KTX2EV0rV KKb5Et9UlGyAtBCx0nf4iiXn2MUlm1bAKsLyDmqbskN9Pfi7uOrnzbe9kqAM1x2QNmc= X-Gm-Gg: ASbGncspz+lHCowjzGOjyGxlkEjlU+VaJv2objJLBzwZ3sh/Z0QMx/hF0TwzH4GufU2 HE2jz082GUVZGs6X7u2YRq2gheMfP+OmY3uzA1MN/cib9r0cgzxntlEMBAFB9G0JV6kDQQw5inN JBQ/EdVlyybAW0yhPUYgquBVeAe5w50yoEM6/XPIKR/Gdl6ZGgHgTSq6WP+pjNaOzbzzHArimQU rb9WsjZN/mYdIPRD0UqM2PdZ0qHyprBM3g+TBwdIVYKVu7r/oWgR66qLg0tGJLc37mojm8v4jy4 fSwQYbnm60OqfsUEJk423KMDMrmexfKtp4ZfgEQ/+6O3OtFtfdPbP/5b X-Google-Smtp-Source: AGHT+IF+qO7rWbAY/SNylys3RMK9GUs1aiqLgKMYCwlF9r3dPIWRev8VFgPCt2yqZehByEZR5PrtlA== X-Received: by 2002:a05:6000:430e:b0:3a5:1c3c:8d8d with SMTP id ffacd0b85a97d-3a572e56dc1mr6643153f8f.55.1750058346514; Mon, 16 Jun 2025 00:19:06 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4238:f8a4:c034:8590]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a800d9sm10104675f8f.45.2025.06.16.00.19.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 00:19:06 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 16 Jun 2025 09:18:56 +0200 Subject: [PATCH v2 7/7] media: i2c: max9286: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250616-gpiochip-set-rv-media-v2-7-6825114f18b0@linaro.org> References: <20250616-gpiochip-set-rv-media-v2-0-6825114f18b0@linaro.org> In-Reply-To: <20250616-gpiochip-set-rv-media-v2-0-6825114f18b0@linaro.org> To: Mauro Carvalho Chehab , Linus Walleij , Bartosz Golaszewski , Bluecherry Maintainers , Andrey Utkin , Ismael Luceno , Tomi Valkeinen , Julien Massot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Niklas_S=C3=B6derlund?= Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1468; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=HgIaQmZBN+2BMb6XtS/4r6T+Stu0X4lPC1c0+Nqlo58=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoT8VhkafOCJzunwHbvzisJ4lCYekKB0yX6Z1BU lA0/7SwGLeJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaE/FYQAKCRARpy6gFHHX ct50D/0R/5NlZeCsQ88EZ/XCDrW343VojK/G9nbfS4hJar5K6EYRhVcDHsK+tMtcwIOj+0f1ozw OjUPWbhs742QvGSlKtHOqOmq0AUJwSteNm3ejtzQa9EYOfB2dfGfxmuV40c36KwLbWsDvqQAiBe yy+ikCLRngH3/7nCo59Lo5rKfr+O8tb4jhbIY2p3R8UPlZEGn5mmyC6Nre6P4qcYRymZ1InB+YS 8pTjnbsKf4znlbuzFq3DCWdw3kkLja6z/U+BK8h5N1wtkoYA26csJVzcxeFCSGTvGX1JbbOa1/E IbzmubKPKPUAiwp5T8yUhuCweat4prnW3G6L53LZ6An5q9WhvnYR/EFOb5IEyxlMLT+mCT6Go+S 99sue8AZtPQ6RZc0UUKhuYM8EvHy0Sr9FylULPazl+k1DxGjqp6udkaAQcJ3fhdtHO5b4bmA1jB X/NVEzdIFrJh8ql+dxLTcROLtdTLpFBf+ErT2WrLXXRttzaGq7fx9ycItE1Ub8uh/kkEaOECwNA SvDORHEtVtlOjehTqC+sd29sNRNVxhLYEA15W0tcZYH5p+cOJt6NVH96vtEMgtZzbnDuLZ4w+oT N8HktFnOdHwD56w/WQ4v+yNbF/AYhECgLsA95l2vZ68K2cNVR8yaGTfzSUZ8b4GL4h+HysK/HlX QKE2oo1JlgG9XGA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Jacopo Mondi Reviewed-by: Linus Walleij --- drivers/media/i2c/max9286.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c index 9fc4e130a273f8547d7e7ec194cade5b5e9c8df2..1d0b5f56f989874e46f87db4a49= d935049e6e7ce 100644 --- a/drivers/media/i2c/max9286.c +++ b/drivers/media/i2c/max9286.c @@ -1193,12 +1193,12 @@ static int max9286_gpio_set(struct max9286_priv *pr= iv, unsigned int offset, MAX9286_0X0F_RESERVED | priv->gpio_state); } =20 -static void max9286_gpiochip_set(struct gpio_chip *chip, - unsigned int offset, int value) +static int max9286_gpiochip_set(struct gpio_chip *chip, + unsigned int offset, int value) { struct max9286_priv *priv =3D gpiochip_get_data(chip); =20 - max9286_gpio_set(priv, offset, value); + return max9286_gpio_set(priv, offset, value); } =20 static int max9286_gpiochip_get(struct gpio_chip *chip, unsigned int offse= t) @@ -1220,7 +1220,7 @@ static int max9286_register_gpio(struct max9286_priv = *priv) gpio->owner =3D THIS_MODULE; gpio->ngpio =3D 2; gpio->base =3D -1; - gpio->set =3D max9286_gpiochip_set; + gpio->set_rv =3D max9286_gpiochip_set; gpio->get =3D max9286_gpiochip_get; gpio->can_sleep =3D true; =20 --=20 2.48.1