From nobody Thu Oct 9 16:37:47 2025 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 265C7235067; Mon, 16 Jun 2025 23:53:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750118008; cv=none; b=ruHTlJ42yrqKb1p+tqdUupxLnTAJNp2V/L0oXHa1l2aajpnHOPJJHRuURZlbWdH9T2Rl0w5L+c2+LlKNUSl09I6UTEw0SOa3kpZwb0ipYjQwZt7s/C75K9Wf0BrUCWYnNzB/4tAi0MHVkk5FWNBa3MkeJxoKzTg1I4nMBFqFdvc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750118008; c=relaxed/simple; bh=4b4dI044v23C1OffMCTZwJ5/8fozf9R9xXvX7QmC3KQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rWUdr7zWev1DulQHL7YmQOoVvqwg19go0pFAcdkIdEbBufeck87dB2H77ZwW5gHEoRx8AMEX2aOCXn4M2t6mU1j/bxEL3PjuyIb6pL1xZNQ36OF/oYHkHeXCpAtnTCg9LGPgzO4haVojtGlSQIuu62ALAmKbdG593lBOSWctF+8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=crisDmmi; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="crisDmmi" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-b2fc93728b2so4167978a12.0; Mon, 16 Jun 2025 16:53:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750118006; x=1750722806; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=hIm0+OnMBm404I7VIGAcAGqFwKW5IFbBd4J9XuS6Kdo=; b=crisDmmiHs21nfWgi6TsW0lCStBtT2kpfD40bn1UQ4EjqYV44NJPQ26V1cXTMuYYl3 CuhuXwZ5MB+PxSZA3KHpS+mPv4O/6PkNJq6yHYZNn2IkgKqL3FQyHa0VT067/k47opfp sj0k3F1vMpMxwE9pMbxUSw6X2Jp3n11cBP0r3n55cPvgS/YkJeaZXAoyL09FoxusJHD3 gyMocDHUPQGun6CcXaDyNEwPXm3LKrw6Mx/wiirWiK0HM+7jclBkgC4iNOJ8C4Og/wNe 5mNWUZXbIhNYebHMKV2CvrK2bZS+/2RCpB1le4HyWbfFtfcL5rAoPVqCZfMNoZ/JUPCG UP3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750118006; x=1750722806; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hIm0+OnMBm404I7VIGAcAGqFwKW5IFbBd4J9XuS6Kdo=; b=Zz9N5AMUurqy+RktfcPpBrWy97zGMUQp/tkfJdJJ9Sis8KE4t6p4M+MoMWyAQM69Mm 1svBROCP7E48g0zJrEQQZyBOzNbfdyWd6A6EdNyefUVeZi0UiRuPta4CmofBffdu5eFJ wXOFh6wwXRkOCDJfYQXh36jMeMbqdG9rWgEn+OQqlFqh8mJkb2h9A/y9dkNViIw1pCNJ YlZux8qnVxBpkhCmJC3LpzqPkI4HrBuVhXGpQVjwgi9n3nysbV9sm7NZJhWLp4kA1pvD RcdGt9reSiRmy3EEmu2IYiH14jqn1RYTqGs8xDBQr7+EYU5Jg/KEePqLM5ScJcuZYrFH 2/Pw== X-Forwarded-Encrypted: i=1; AJvYcCX27ErSNSRLFijj0BXeRvX6GLQJEXH2vZ6YSU5smgNfYfYeFjU5KG/1n1RBwDciw8skxpoRCBVEdbTt+2w=@vger.kernel.org X-Gm-Message-State: AOJu0YwiSeEzPN+ZySoU5fibqWB6mckdhL7UNI8Ywsg/g7gINdKZKwwi kzcg/2TRovmCOCPALSXTOE5ELLqnxwXU2Ow1KypU5xeetbOe768v3VAgmGNM8Nvw X-Gm-Gg: ASbGncu0o9cNec52sckOeznNbHbgjiVQQ9epnmZU2xPmHo+4Mo0XObRup6C4fiE/dvJ WuwhQzBT+XMFpvWEfp2sUi46nXsf2C3+TkCqJppJ1vu7ym2fgf1NelyOA0nAg0RLEpvVDtjrKh9 QS4tWvoyB6uDHuZ/qX/ntTPVQxd+6GmyR0mGI6c7IvF/Sk8Yst4EF8CJsf3vLq3RQqtkbgZMqm1 BoLkd911sjHO4a3pSeRjFaSf6Hv9DOO5eVwBX7mq+M52Uhf31ThitoH2dcjc8WIXmBmWWyITX1q 4/05dLUx/D0G8W65TF9S5kpRgHTuFPLSeUOLaBFsnA5+PFgmJSv84TngNdDMS2e7R7BO7ZY= X-Google-Smtp-Source: AGHT+IHhdfcSX0lvqnTVVA2cCzrcocmRq5MtEyCFLVniRtkwdcNZdXVh+abXolMuulLhG201Crpyyw== X-Received: by 2002:a17:902:fb90:b0:234:9374:cfae with SMTP id d9443c01a7336-2366afe7d06mr120971255ad.19.1750118005772; Mon, 16 Jun 2025 16:53:25 -0700 (PDT) Received: from [192.168.0.9] ([2804:14d:90a8:477c:13e7:d349:8af8:5d32]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365de782d3sm67515395ad.115.2025.06.16.16.53.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 16:53:25 -0700 (PDT) From: Gustavo Silva Date: Mon, 16 Jun 2025 20:53:09 -0300 Subject: [PATCH v3 1/3] iio: imu: bmi270: add channel for step counter Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250616-bmi270-events-v3-1-16e37588604f@gmail.com> References: <20250616-bmi270-events-v3-0-16e37588604f@gmail.com> In-Reply-To: <20250616-bmi270-events-v3-0-16e37588604f@gmail.com> To: Alex Lanzano , Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Lothar Rubusch , Gustavo Silva X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1750117999; l=6343; i=gustavograzs@gmail.com; s=20250111; h=from:subject:message-id; bh=4b4dI044v23C1OffMCTZwJ5/8fozf9R9xXvX7QmC3KQ=; b=7tV/vHJcIxNIlacI4jg2453NTFsWOijMUFVABc26N61IpbJy7sV/AWaC5/jSg7cL4xIAXH13c NGJq+SkchELCUProDjLjrnIOoquDURb7JSpxYgoQF1ZZ31Jcx3aWbS8 X-Developer-Key: i=gustavograzs@gmail.com; a=ed25519; pk=g2TFXpo1jMCOCN+rzVoM9NDFNfSMOgVyY0rlyvk4RTM= Add a channel for enabling/disabling the step counter, reading the number of steps and resetting the counter. Reviewed-by: Andy Shevchenko Signed-off-by: Gustavo Silva --- drivers/iio/imu/bmi270/bmi270_core.c | 138 +++++++++++++++++++++++++++++++= ++++ 1 file changed, 138 insertions(+) diff --git a/drivers/iio/imu/bmi270/bmi270_core.c b/drivers/iio/imu/bmi270/= bmi270_core.c index a86be5af5ccb1f010f2282ee31c47f284c1bcc86..c3cf65bb05fc2f6699e107110ee= 98f703aca3da3 100644 --- a/drivers/iio/imu/bmi270/bmi270_core.c +++ b/drivers/iio/imu/bmi270/bmi270_core.c @@ -31,6 +31,8 @@ #define BMI270_INT_STATUS_1_REG 0x1d #define BMI270_INT_STATUS_1_ACC_GYR_DRDY_MSK GENMASK(7, 6) =20 +#define BMI270_SC_OUT_0_REG 0x1e + #define BMI270_INTERNAL_STATUS_REG 0x21 #define BMI270_INTERNAL_STATUS_MSG_MSK GENMASK(3, 0) #define BMI270_INTERNAL_STATUS_MSG_INIT_OK 0x01 @@ -39,6 +41,8 @@ =20 #define BMI270_TEMPERATURE_0_REG 0x22 =20 +#define BMI270_FEAT_PAGE_REG 0x2f + #define BMI270_ACC_CONF_REG 0x40 #define BMI270_ACC_CONF_ODR_MSK GENMASK(3, 0) #define BMI270_ACC_CONF_ODR_100HZ 0x08 @@ -90,6 +94,9 @@ #define BMI270_PWR_CTRL_ACCEL_EN_MSK BIT(2) #define BMI270_PWR_CTRL_TEMP_EN_MSK BIT(3) =20 +#define BMI270_STEP_SC26_RST_CNT_MSK BIT(10) +#define BMI270_STEP_SC26_EN_CNT_MSK BIT(12) + /* See datasheet section 4.6.14, Temperature Sensor */ #define BMI270_TEMP_OFFSET 11776 #define BMI270_TEMP_SCALE 1953125 @@ -111,6 +118,7 @@ struct bmi270_data { struct iio_trigger *trig; /* Protect device's private data from concurrent access */ struct mutex mutex; + bool steps_enabled; =20 /* * Where IIO_DMA_MINALIGN may be larger than 8 bytes, align to @@ -120,6 +128,11 @@ struct bmi270_data { __le16 channels[6]; aligned_s64 timestamp; } buffer __aligned(IIO_DMA_MINALIGN); + /* + * Variable to access feature registers. It can be accessed concurrently + * with the 'buffer' variable + */ + __le16 regval __aligned(IIO_DMA_MINALIGN); }; =20 enum bmi270_scan { @@ -282,6 +295,107 @@ static const struct bmi270_odr_item bmi270_odr_table= [] =3D { }, }; =20 +enum bmi270_feature_reg_id { + BMI270_SC_26_REG, +}; + +struct bmi270_feature_reg { + u8 page; + u8 addr; +}; + +static const struct bmi270_feature_reg bmi270_feature_regs[] =3D { + [BMI270_SC_26_REG] =3D { + .page =3D 6, + .addr =3D 0x32, + }, +}; + +static int bmi270_write_feature_reg(struct bmi270_data *data, + enum bmi270_feature_reg_id id, + u16 val) +{ + const struct bmi270_feature_reg *reg =3D &bmi270_feature_regs[id]; + int ret; + + ret =3D regmap_write(data->regmap, BMI270_FEAT_PAGE_REG, reg->page); + if (ret) + return ret; + + data->regval =3D cpu_to_le16(val); + return regmap_bulk_write(data->regmap, reg->addr, &data->regval, + sizeof(data->regval)); +} + +static int bmi270_read_feature_reg(struct bmi270_data *data, + enum bmi270_feature_reg_id id, + u16 *val) +{ + const struct bmi270_feature_reg *reg =3D &bmi270_feature_regs[id]; + int ret; + + ret =3D regmap_write(data->regmap, BMI270_FEAT_PAGE_REG, reg->page); + if (ret) + return ret; + + ret =3D regmap_bulk_read(data->regmap, reg->addr, &data->regval, + sizeof(data->regval)); + if (ret) + return ret; + + *val =3D le16_to_cpu(data->regval); + return 0; +} + +static int bmi270_update_feature_reg(struct bmi270_data *data, + enum bmi270_feature_reg_id id, + u16 mask, u16 val) +{ + u16 regval; + int ret; + + ret =3D bmi270_read_feature_reg(data, id, ®val); + if (ret) + return ret; + + regval =3D (regval & ~mask) | (val & mask); + + return bmi270_write_feature_reg(data, id, regval); +} + +static int bmi270_enable_steps(struct bmi270_data *data, int val) +{ + int ret; + + guard(mutex)(&data->mutex); + if (data->steps_enabled) + return 0; + + ret =3D bmi270_update_feature_reg(data, BMI270_SC_26_REG, + BMI270_STEP_SC26_EN_CNT_MSK, + FIELD_PREP(BMI270_STEP_SC26_EN_CNT_MSK, + val ? 1 : 0)); + if (ret) + return ret; + + data->steps_enabled =3D true; + return 0; +} + +static int bmi270_read_steps(struct bmi270_data *data, int *val) +{ + __le16 steps_count; + int ret; + + ret =3D regmap_bulk_read(data->regmap, BMI270_SC_OUT_0_REG, &steps_count, + sizeof(steps_count)); + if (ret) + return ret; + + *val =3D sign_extend32(le16_to_cpu(steps_count), 15); + return IIO_VAL_INT; +} + static int bmi270_set_scale(struct bmi270_data *data, int chan_type, int u= scale) { int i; @@ -551,6 +665,8 @@ static int bmi270_read_raw(struct iio_dev *indio_dev, struct bmi270_data *data =3D iio_priv(indio_dev); =20 switch (mask) { + case IIO_CHAN_INFO_PROCESSED: + return bmi270_read_steps(data, val); case IIO_CHAN_INFO_RAW: if (!iio_device_claim_direct(indio_dev)) return -EBUSY; @@ -571,6 +687,9 @@ static int bmi270_read_raw(struct iio_dev *indio_dev, case IIO_CHAN_INFO_SAMP_FREQ: ret =3D bmi270_get_odr(data, chan->type, val, val2); return ret ? ret : IIO_VAL_INT_PLUS_MICRO; + case IIO_CHAN_INFO_ENABLE: + *val =3D data->steps_enabled ? 1 : 0; + return IIO_VAL_INT; default: return -EINVAL; } @@ -596,6 +715,19 @@ static int bmi270_write_raw(struct iio_dev *indio_dev, ret =3D bmi270_set_odr(data, chan->type, val, val2); iio_device_release_direct(indio_dev); return ret; + case IIO_CHAN_INFO_ENABLE: + return bmi270_enable_steps(data, val); + case IIO_CHAN_INFO_PROCESSED: { + if (val || !data->steps_enabled) + return -EINVAL; + + guard(mutex)(&data->mutex); + /* Clear step counter value */ + return bmi270_update_feature_reg(data, BMI270_SC_26_REG, + BMI270_STEP_SC26_RST_CNT_MSK, + FIELD_PREP(BMI270_STEP_SC26_RST_CNT_MSK, + 1)); + } default: return -EINVAL; } @@ -698,6 +830,12 @@ static const struct iio_chan_spec bmi270_channels[] = =3D { BIT(IIO_CHAN_INFO_OFFSET), .scan_index =3D -1, /* No buffer support */ }, + { + .type =3D IIO_STEPS, + .info_mask_separate =3D BIT(IIO_CHAN_INFO_ENABLE) | + BIT(IIO_CHAN_INFO_PROCESSED), + .scan_index =3D -1, /* No buffer support */ + }, IIO_CHAN_SOFT_TIMESTAMP(BMI270_SCAN_TIMESTAMP), }; =20 --=20 2.49.0 From nobody Thu Oct 9 16:37:47 2025 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E4D5231A37; Mon, 16 Jun 2025 23:53:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750118011; cv=none; b=GwpG0Trn4PvRwUKbt2dhu6AzSFjiwrc8mlg5NvevWLyktXnkEMH7krSH+P78AOv81LT87cLx+Wf6C5fhDQTjn2ADYuFzI7v8ppelELuq53tlPlvZHGu3WgbuJB234GUmc+jq6VWb1onrv0U1Wn73wAPduzxhhyRTzEZW7wnNRtc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750118011; c=relaxed/simple; bh=KZGd+uO/a3REvMFjyoK0HG54FJDkLOzIZPL4YenHCgE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=d5snOIZBvWk3i9mxrRm7e0jJo47G162htrfviowo0Ql0qkqKS/L6vzfLGFSWHXj7X+NqwtGX8wSuMcD4a2UUXGB0/34w6w1dUmPC6bWNye/hePgZLUu3q794UncrCzzzH4uzWcWpvq0PE1XRSHfUoNrNwDgjWDDuhnTkXnoD1Yo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RODx3BqO; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RODx3BqO" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-236377f00easo66981325ad.1; Mon, 16 Jun 2025 16:53:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750118009; x=1750722809; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=YpDHu5+EGQCOtg+8rIcSFHGgC9IaYuMDhU1r7bF5Vf4=; b=RODx3BqOSZlo3GPvWR7aYTNRhrHeH7rH0nMunl+66yweTrqB2uOo2KUG12A8AlSZRJ TYuH05jwZU1W42RuOVwzwWeIT7tl36KEJno8SDAS3RTRItqrWBB8m84htxv3io/O1LZt wc9tYwHh4XkCaC5TzsxENwSIfnwrcStn8vy8bNET8sM8Nn+9u43wptmZWkbyale65gnb yIwuW/VZLA/CoqcxuFiV7iVBCAb/KqmMgi+vwLc3kqsPBrxh1biraEDzudhizudvh9sB i+WYPA01GCHFJ5rdbHl07i7eh7I9zFdoMdb0LbJBIzoQIHuOmbP71GU7pSQ4UwyBZZbB +fFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750118009; x=1750722809; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YpDHu5+EGQCOtg+8rIcSFHGgC9IaYuMDhU1r7bF5Vf4=; b=vy5BZqMyXWGLgDXgOgC9mOTs9XFajWaYv3j/VJqAWJfGRcLSJD3/Cbx1/eS1wWsxaw qubMF4OHYonLBNEZ6TvNMfVT8R9tT5GDFbrRTYTo7Szp+NY98djYEj47zBdrFUDTvNTN fFdPZ9sk1jIcOI6wkaAuPtItGPK/jpK0Fw8T3rnGOAy9Kv+QnmhB7Y3E3KlM8GW3ZXAf Y4SrPeybbZXMHlcZs5wlkcCfqkiXQsYc3d9laUOgpnEbJG0owYR8K8gUB/vdypnGC/Jo sRIbuDuU5znfW7NKcu0EVlpLTz2AGdwiLNg9Xjr0agjScIxGvNFoG73GfPW7LJZmUuAU JaJg== X-Forwarded-Encrypted: i=1; AJvYcCXl34TgL53J1YUDdZWwwx3xQUpqnxVJxQmGiAyQ9ccnEGbpu9o6D1VQLU9DAyzoWXfm/c0spn6Vcwf+Nvw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6Lh4NxP2O8sk7aQhvBe5zbR+ov5+pAdShwvURFVzxolGapO68 u64kGysp9wXqCrZDypta3Qd1jlAp45xbz9Gl2oQqmM6MJp3m6s9AQt3Y/08jOAH4 X-Gm-Gg: ASbGncvq/tXtvsPu8pJ946SR24D/VewWKxIv9WLQkBY0tBOuj3abmFmq2P/09JgCDzc zOADA6aU1CF4vT1075NhbfpIEg+FZ9cuXntwwHaNsiHJ2hEPR9+7olOObuvady0RVFwrE1oib/g rGcZNk6ZC9+Nb2FClOjpvmd5vApgGtOeezvEz2vI53uNoGKPKGgJPILVnv2DiGxiHpGCs9iDDW3 y02an4eYhEHMwCcqRslp6rHBCUQaCi06KEswIRj+tC05jmBDMWs+DQ5tTOxz63onNccLSU87C+e ZpTJeYuuFywDycw4cyLWHXLLqdIMdmZrge/0tjI9W4kvcoVhlASwTs5WTUCpG7+6xbnro4A= X-Google-Smtp-Source: AGHT+IHzG2UF03C3HkLvodKq5F/E3+AHjvrqSK5BXzI8seQWo84zAhJEvIzIqypm9nY288yuAZ97gw== X-Received: by 2002:a17:903:32c6:b0:235:ecf2:393 with SMTP id d9443c01a7336-2366b17744bmr177809035ad.53.1750118008949; Mon, 16 Jun 2025 16:53:28 -0700 (PDT) Received: from [192.168.0.9] ([2804:14d:90a8:477c:13e7:d349:8af8:5d32]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365de782d3sm67515395ad.115.2025.06.16.16.53.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 16:53:28 -0700 (PDT) From: Gustavo Silva Date: Mon, 16 Jun 2025 20:53:10 -0300 Subject: [PATCH v3 2/3] iio: imu: bmi270: add step counter watermark event Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250616-bmi270-events-v3-2-16e37588604f@gmail.com> References: <20250616-bmi270-events-v3-0-16e37588604f@gmail.com> In-Reply-To: <20250616-bmi270-events-v3-0-16e37588604f@gmail.com> To: Alex Lanzano , Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Lothar Rubusch , Gustavo Silva X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1750117999; l=7651; i=gustavograzs@gmail.com; s=20250111; h=from:subject:message-id; bh=KZGd+uO/a3REvMFjyoK0HG54FJDkLOzIZPL4YenHCgE=; b=DgH94BCIKaLMP5nL4DfYU9avlUjzD08V8/81jK8fSWYge1h1Mn0YVw65+bpc05tctoHgc1+yt tjknshtOHZkBeUN97TrDDwtYFQsvTzMmt0pOk71UCykdHiyAlUkhkiU X-Developer-Key: i=gustavograzs@gmail.com; a=ed25519; pk=g2TFXpo1jMCOCN+rzVoM9NDFNfSMOgVyY0rlyvk4RTM= Add support for generating events when the step counter reaches the configurable watermark. Reviewed-by: Andy Shevchenko Signed-off-by: Gustavo Silva --- drivers/iio/imu/bmi270/bmi270_core.c | 169 +++++++++++++++++++++++++++++++= +++- 1 file changed, 166 insertions(+), 3 deletions(-) diff --git a/drivers/iio/imu/bmi270/bmi270_core.c b/drivers/iio/imu/bmi270/= bmi270_core.c index c3cf65bb05fc2f6699e107110ee98f703aca3da3..7b632ec5b0108328c216a815535= 502f0078eb151 100644 --- a/drivers/iio/imu/bmi270/bmi270_core.c +++ b/drivers/iio/imu/bmi270/bmi270_core.c @@ -8,6 +8,7 @@ #include #include =20 +#include #include #include #include @@ -28,6 +29,9 @@ #define BMI270_ACCEL_X_REG 0x0c #define BMI270_ANG_VEL_X_REG 0x12 =20 +#define BMI270_INT_STATUS_0_REG 0x1c +#define BMI270_INT_STATUS_0_STEP_CNT_MSK BIT(1) + #define BMI270_INT_STATUS_1_REG 0x1d #define BMI270_INT_STATUS_1_ACC_GYR_DRDY_MSK GENMASK(7, 6) =20 @@ -74,6 +78,10 @@ #define BMI270_INT_LATCH_REG 0x55 #define BMI270_INT_LATCH_REG_MSK BIT(0) =20 +#define BMI270_INT1_MAP_FEAT_REG 0x56 +#define BMI270_INT2_MAP_FEAT_REG 0x57 +#define BMI270_INT_MAP_FEAT_STEP_CNT_WTRMRK_MSK BIT(1) + #define BMI270_INT_MAP_DATA_REG 0x58 #define BMI270_INT_MAP_DATA_DRDY_INT1_MSK BIT(2) #define BMI270_INT_MAP_DATA_DRDY_INT2_MSK BIT(6) @@ -94,6 +102,7 @@ #define BMI270_PWR_CTRL_ACCEL_EN_MSK BIT(2) #define BMI270_PWR_CTRL_TEMP_EN_MSK BIT(3) =20 +#define BMI270_STEP_SC26_WTRMRK_MSK GENMASK(9, 0) #define BMI270_STEP_SC26_RST_CNT_MSK BIT(10) #define BMI270_STEP_SC26_EN_CNT_MSK BIT(12) =20 @@ -101,6 +110,10 @@ #define BMI270_TEMP_OFFSET 11776 #define BMI270_TEMP_SCALE 1953125 =20 +/* See page 90 of datasheet. The step counter "holds implicitly a 20x fact= or" */ +#define BMI270_STEP_COUNTER_FACTOR 20 +#define BMI270_STEP_COUNTER_MAX 20460 + #define BMI260_INIT_DATA_FILE "bmi260-init-data.fw" #define BMI270_INIT_DATA_FILE "bmi270-init-data.fw" =20 @@ -396,6 +409,36 @@ static int bmi270_read_steps(struct bmi270_data *data,= int *val) return IIO_VAL_INT; } =20 +static int bmi270_int_map_reg(enum bmi270_irq_pin pin) +{ + switch (pin) { + case BMI270_IRQ_INT1: + return BMI270_INT1_MAP_FEAT_REG; + case BMI270_IRQ_INT2: + return BMI270_INT2_MAP_FEAT_REG; + default: + return -EINVAL; + } +} + +static int bmi270_step_wtrmrk_en(struct bmi270_data *data, bool state) +{ + int reg; + + guard(mutex)(&data->mutex); + if (!data->steps_enabled) + return -EINVAL; + + reg =3D bmi270_int_map_reg(data->irq_pin); + if (reg < 0) + return reg; + + return regmap_update_bits(data->regmap, reg, + BMI270_INT_MAP_FEAT_STEP_CNT_WTRMRK_MSK, + FIELD_PREP(BMI270_INT_MAP_FEAT_STEP_CNT_WTRMRK_MSK, + state)); +} + static int bmi270_set_scale(struct bmi270_data *data, int chan_type, int u= scale) { int i; @@ -552,19 +595,31 @@ static irqreturn_t bmi270_irq_thread_handler(int irq,= void *private) { struct iio_dev *indio_dev =3D private; struct bmi270_data *data =3D iio_priv(indio_dev); - unsigned int status; + unsigned int status0, status1; + s64 timestamp =3D iio_get_time_ns(indio_dev); int ret; =20 scoped_guard(mutex, &data->mutex) { + ret =3D regmap_read(data->regmap, BMI270_INT_STATUS_0_REG, + &status0); + if (ret) + return IRQ_NONE; + ret =3D regmap_read(data->regmap, BMI270_INT_STATUS_1_REG, - &status); + &status1); if (ret) return IRQ_NONE; } =20 - if (FIELD_GET(BMI270_INT_STATUS_1_ACC_GYR_DRDY_MSK, status)) + if (FIELD_GET(BMI270_INT_STATUS_1_ACC_GYR_DRDY_MSK, status1)) iio_trigger_poll_nested(data->trig); =20 + if (FIELD_GET(BMI270_INT_STATUS_0_STEP_CNT_MSK, status0)) + iio_push_event(indio_dev, IIO_UNMOD_EVENT_CODE(IIO_STEPS, 0, + IIO_EV_TYPE_CHANGE, + IIO_EV_DIR_NONE), + timestamp); + return IRQ_HANDLED; } =20 @@ -772,10 +827,116 @@ static int bmi270_read_avail(struct iio_dev *indio_d= ev, } } =20 +static int bmi270_write_event_config(struct iio_dev *indio_dev, + const struct iio_chan_spec *chan, + enum iio_event_type type, + enum iio_event_direction dir, bool state) +{ + struct bmi270_data *data =3D iio_priv(indio_dev); + + switch (type) { + case IIO_EV_TYPE_CHANGE: + return bmi270_step_wtrmrk_en(data, state); + default: + return -EINVAL; + } +} + +static int bmi270_read_event_config(struct iio_dev *indio_dev, + const struct iio_chan_spec *chan, + enum iio_event_type type, + enum iio_event_direction dir) +{ + struct bmi270_data *data =3D iio_priv(indio_dev); + int ret, reg, regval; + + guard(mutex)(&data->mutex); + + switch (chan->type) { + case IIO_STEPS: + reg =3D bmi270_int_map_reg(data->irq_pin); + if (reg) + return reg; + + ret =3D regmap_read(data->regmap, reg, ®val); + if (ret) + return ret; + return FIELD_GET(BMI270_INT_MAP_FEAT_STEP_CNT_WTRMRK_MSK, + regval) ? 1 : 0; + default: + return -EINVAL; + } +} + +static int bmi270_write_event_value(struct iio_dev *indio_dev, + const struct iio_chan_spec *chan, + enum iio_event_type type, + enum iio_event_direction dir, + enum iio_event_info info, + int val, int val2) +{ + struct bmi270_data *data =3D iio_priv(indio_dev); + unsigned int raw; + + guard(mutex)(&data->mutex); + + switch (type) { + case IIO_EV_TYPE_CHANGE: + if (!in_range(val, 0, BMI270_STEP_COUNTER_MAX + 1)) + return -EINVAL; + + raw =3D val / BMI270_STEP_COUNTER_FACTOR; + return bmi270_update_feature_reg(data, BMI270_SC_26_REG, + BMI270_STEP_SC26_WTRMRK_MSK, + FIELD_PREP(BMI270_STEP_SC26_WTRMRK_MSK, + raw)); + default: + return -EINVAL; + } +} + +static int bmi270_read_event_value(struct iio_dev *indio_dev, + const struct iio_chan_spec *chan, + enum iio_event_type type, + enum iio_event_direction dir, + enum iio_event_info info, + int *val, int *val2) +{ + struct bmi270_data *data =3D iio_priv(indio_dev); + unsigned int raw; + u16 regval; + int ret; + + guard(mutex)(&data->mutex); + + switch (type) { + case IIO_EV_TYPE_CHANGE: + ret =3D bmi270_read_feature_reg(data, BMI270_SC_26_REG, ®val); + if (ret) + return ret; + + raw =3D FIELD_GET(BMI270_STEP_SC26_WTRMRK_MSK, regval); + *val =3D raw * BMI270_STEP_COUNTER_FACTOR; + return IIO_VAL_INT; + default: + return -EINVAL; + } +} + +static const struct iio_event_spec bmi270_step_wtrmrk_event =3D { + .type =3D IIO_EV_TYPE_CHANGE, + .dir =3D IIO_EV_DIR_NONE, + .mask_shared_by_type =3D BIT(IIO_EV_INFO_ENABLE) | BIT(IIO_EV_INFO_VALUE), +}; + static const struct iio_info bmi270_info =3D { .read_raw =3D bmi270_read_raw, .write_raw =3D bmi270_write_raw, .read_avail =3D bmi270_read_avail, + .write_event_config =3D bmi270_write_event_config, + .read_event_config =3D bmi270_read_event_config, + .write_event_value =3D bmi270_write_event_value, + .read_event_value =3D bmi270_read_event_value, }; =20 #define BMI270_ACCEL_CHANNEL(_axis) { \ @@ -835,6 +996,8 @@ static const struct iio_chan_spec bmi270_channels[] =3D= { .info_mask_separate =3D BIT(IIO_CHAN_INFO_ENABLE) | BIT(IIO_CHAN_INFO_PROCESSED), .scan_index =3D -1, /* No buffer support */ + .event_spec =3D &bmi270_step_wtrmrk_event, + .num_event_specs =3D 1, }, IIO_CHAN_SOFT_TIMESTAMP(BMI270_SCAN_TIMESTAMP), }; --=20 2.49.0 From nobody Thu Oct 9 16:37:47 2025 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B6ED136349; Mon, 16 Jun 2025 23:53:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750118015; cv=none; b=rUpygiXJbAITj5ucg82LQoMzCSRtAfjwALkJcx6iZ+lh8qP69DGIetATX8cV6DThbNR8XBKp7P/yxcXYVNU8fbSebxQvNcHyTkGcv7Zf5TAmdBdq+1KgXQ8+IuTtKfBkgH1FcwmJpYBWnG3N9MK0UmICVXDV0hga+oJxGp5Ijw4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750118015; c=relaxed/simple; bh=XWLbUKngwqkA525prCGnTIBOUfc/ESDsAa1TANtVX/g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hub3RKJenf2EpM13POyU/ziNJCEwiXOIkAzM0rNGRMhHAMqK+GVNm3216if05dSkowO8nrkwVWt7rv9A/nnHYOfui+8yt+9iUnrPqAW4E7YFsBn80Z2mjg3qsl/iZh1IxkttzEczK54ycEFf6XW95SlU1sKy5mRy65MOE130CSk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PvoLCgA9; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PvoLCgA9" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2352400344aso46311765ad.2; Mon, 16 Jun 2025 16:53:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750118012; x=1750722812; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=1pSN9NUQ3la7t/FgqmWvBXqr5/Rl7A1XJVahioNEd/o=; b=PvoLCgA9k6aIVH6wcVrSH+wNCrOVy34silQd7xHyo+Zxu/6QsYqrvMysAN8N0YVL5t 8M3tCTxOAo1TZpW/XMBgYFVJ6iA4/qP3Ke+WEACCJRHequwpDMXu+8HhtIpQrrWj3dIW PsCpEk2pa/48+/dfCMO4mKr8xRRX+6p3ReYCLAFiIrIM29GyiCuKbTkozUwk4Gb8i4QK gXmZ2wUUEktZ4tLlshT1YwJ5jucXc2VYPqkTfpTmIeubjB1YOo4Z9UbZmzpaAApic3fD tWHSSZ3IEigRWJTunnQSx+eAjzpyH4E/52e34kpiBAr4PDjGKgLK0yyY2AmCVH+Uv3fC tsmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750118012; x=1750722812; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1pSN9NUQ3la7t/FgqmWvBXqr5/Rl7A1XJVahioNEd/o=; b=ZiH5Yr44cwLRdpq87NmzPufr5vhA1J+DkpXPM8342u5oum7jJdXcyB3LFCMkm9eCGt 03UUa4At75yJU7YsgnlYRGyEbXDZnvL/NYiNZlYdBzuz5leX8wFfyBAmt48XFwTndMS7 FiLwdygB7aDXXBsPqNe5NLhlZr8FTDEt5vILEDT6JxYc0fKAXvKrYWLM+2y9FabWHiMb MoubCql2NJRVhBvmj1iQO8ayC5q9WeUgnrj1MWwxp/A+jo1crVIwVy0zeQuV3bxXK1/n axzPIGBh00jciVAE9uY+I+hj7B9dyvLWxZhWiewPaoYNEJqFw7r5G6/0ZsTeQrLNIoqy HqHQ== X-Forwarded-Encrypted: i=1; AJvYcCWpvTM2uAGRQeBXL4wR//6U+tNEbQpmXojB0S1wl2tiB8U2EdPMy5kFLPWjUPJ/jJNngYfbNcuCrAkwqN8=@vger.kernel.org X-Gm-Message-State: AOJu0YxEKP5mdnS2gv0T3qhfw01yY9uoLE6SV3uWuVPIOV0oiDWm8KMu X/TXR2i4JsJ2CxDhiG8VhEhNRia4env5+Y1BzyMRFJ5X5QZ2ocDzuHdm0qv2x7LB X-Gm-Gg: ASbGnctEjOgHaRLUGv1LVUwc+RW5E0gLv6xvE/SYsklnb9g4bPTJKacN9jX4zwss1wr cQ2o/S3ADVrm/3G/jEJQbx5HYMs4TuNfnSXyqPj8TVUC9I5nWPviaMRG2fjb9Y3MIB4KE0poujf 3YpcGj6geh/WW8XJrfSAWFUA3XNE66JOCMHJF0QxWIPCHIewawAtF3VmTzdG/If4apBx38FcBkJ xU1YX55k2WeBHtO2s2igZUF90NSJovMcPVMSgKgJ+ZZODyn+F8TJvedLG8htfQvusfTes6iyBy6 FzyhwByMUDXLXUZ2Oxeako7zkaL8QpP9+uNPk1bkDcG8XJyXiHMSNYEHOewC7QWYyPaX3mQ= X-Google-Smtp-Source: AGHT+IHMX7aAnZ9J/gpjZSMr47K9GOlCQ04YWkOTeJVuE5h/j/XnS6BhAycd6M1SKavj4N/BBVaydg== X-Received: by 2002:a17:903:1246:b0:235:dd54:bce1 with SMTP id d9443c01a7336-2366afe7d67mr169712255ad.15.1750118012118; Mon, 16 Jun 2025 16:53:32 -0700 (PDT) Received: from [192.168.0.9] ([2804:14d:90a8:477c:13e7:d349:8af8:5d32]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365de782d3sm67515395ad.115.2025.06.16.16.53.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 16:53:31 -0700 (PDT) From: Gustavo Silva Date: Mon, 16 Jun 2025 20:53:11 -0300 Subject: [PATCH v3 3/3] iio: imu: bmi270: add support for motion events Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250616-bmi270-events-v3-3-16e37588604f@gmail.com> References: <20250616-bmi270-events-v3-0-16e37588604f@gmail.com> In-Reply-To: <20250616-bmi270-events-v3-0-16e37588604f@gmail.com> To: Alex Lanzano , Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Lothar Rubusch , Gustavo Silva X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1750117999; l=15360; i=gustavograzs@gmail.com; s=20250111; h=from:subject:message-id; bh=XWLbUKngwqkA525prCGnTIBOUfc/ESDsAa1TANtVX/g=; b=0+94yqN//yML0YoIjGGxYG8s0wcmZNv5vTNkd3QM/iK/FTwS04EIS6JZ/A4eNlQmE/j3CJfyb gC1NuhZKgZLCW7szImd8UiWD9J1GaDjWgFEBQJp1fsmMUAK9wkWOD5y X-Developer-Key: i=gustavograzs@gmail.com; a=ed25519; pk=g2TFXpo1jMCOCN+rzVoM9NDFNfSMOgVyY0rlyvk4RTM= Any-motion event can be enabled on a per-axis basis and triggers a combined event when motion is detected on any axis. No-motion event is triggered if the rate of change on all axes falls below a specified threshold for a configurable duration. A fake channel is used to report this event. Threshold and duration can be configured from userspace. Signed-off-by: Gustavo Silva --- drivers/iio/imu/bmi270/bmi270_core.c | 316 +++++++++++++++++++++++++++++++= ++-- 1 file changed, 306 insertions(+), 10 deletions(-) diff --git a/drivers/iio/imu/bmi270/bmi270_core.c b/drivers/iio/imu/bmi270/= bmi270_core.c index 7b632ec5b0108328c216a815535502f0078eb151..e54fb5f7a87f6f88e7eba8f81a1= 5f703e48031b5 100644 --- a/drivers/iio/imu/bmi270/bmi270_core.c +++ b/drivers/iio/imu/bmi270/bmi270_core.c @@ -31,6 +31,8 @@ =20 #define BMI270_INT_STATUS_0_REG 0x1c #define BMI270_INT_STATUS_0_STEP_CNT_MSK BIT(1) +#define BMI270_INT_STATUS_0_NOMOTION_MSK BIT(5) +#define BMI270_INT_STATUS_0_MOTION_MSK BIT(6) =20 #define BMI270_INT_STATUS_1_REG 0x1d #define BMI270_INT_STATUS_1_ACC_GYR_DRDY_MSK GENMASK(7, 6) @@ -81,6 +83,8 @@ #define BMI270_INT1_MAP_FEAT_REG 0x56 #define BMI270_INT2_MAP_FEAT_REG 0x57 #define BMI270_INT_MAP_FEAT_STEP_CNT_WTRMRK_MSK BIT(1) +#define BMI270_INT_MAP_FEAT_NOMOTION_MSK BIT(5) +#define BMI270_INT_MAP_FEAT_ANYMOTION_MSK BIT(6) =20 #define BMI270_INT_MAP_DATA_REG 0x58 #define BMI270_INT_MAP_DATA_DRDY_INT1_MSK BIT(2) @@ -106,6 +110,22 @@ #define BMI270_STEP_SC26_RST_CNT_MSK BIT(10) #define BMI270_STEP_SC26_EN_CNT_MSK BIT(12) =20 +#define BMI270_FEAT_MOTION_DURATION_MSK GENMASK(12, 0) +#define BMI270_FEAT_MOTION_X_EN_MSK BIT(13) +#define BMI270_FEAT_MOTION_Y_EN_MSK BIT(14) +#define BMI270_FEAT_MOTION_Z_EN_MSK BIT(15) +#define BMI270_FEAT_MOTION_XYZ_EN_MSK GENMASK(15, 13) +#define BMI270_FEAT_MOTION_THRESHOLD_MSK GENMASK(10, 0) +#define BMI270_FEAT_MOTION_OUT_CONF_MSK GENMASK(14, 11) +#define BMI270_FEAT_MOTION_ENABLE_MSK BIT(15) + +#define BMI270_MOTION_XYZ_MSK GENMASK(2, 0) + +/* See pages 92 and 93 of the datasheet */ +#define BMI270_MOTION_THRES_SCALE GENMASK(10, 0) +#define BMI270_MOTION_DURAT_SCALE 50 +#define BMI270_MOTION_DURAT_MAX 162 + /* See datasheet section 4.6.14, Temperature Sensor */ #define BMI270_TEMP_OFFSET 11776 #define BMI270_TEMP_SCALE 1953125 @@ -114,6 +134,10 @@ #define BMI270_STEP_COUNTER_FACTOR 20 #define BMI270_STEP_COUNTER_MAX 20460 =20 +#define BMI270_INT_MICRO_TO_RAW(val, val2, scale) ((val) * (scale) + \ + ((val2) * (scale)) / MEGA) +#define BMI270_RAW_TO_MICRO(raw, scale) ((((raw) % (scale)) * MEGA) / scal= e) + #define BMI260_INIT_DATA_FILE "bmi260-init-data.fw" #define BMI270_INIT_DATA_FILE "bmi270-init-data.fw" =20 @@ -309,6 +333,13 @@ static const struct bmi270_odr_item bmi270_odr_table[= ] =3D { }; =20 enum bmi270_feature_reg_id { + /* Page 1 registers */ + BMI270_ANYMO1_REG, + BMI270_ANYMO2_REG, + /* Page 2 registers */ + BMI270_NOMO1_REG, + BMI270_NOMO2_REG, + /* Page 6 registers */ BMI270_SC_26_REG, }; =20 @@ -318,6 +349,22 @@ struct bmi270_feature_reg { }; =20 static const struct bmi270_feature_reg bmi270_feature_regs[] =3D { + [BMI270_ANYMO1_REG] =3D { + .page =3D 1, + .addr =3D 0x3c, + }, + [BMI270_ANYMO2_REG] =3D { + .page =3D 1, + .addr =3D 0x3e, + }, + [BMI270_NOMO1_REG] =3D { + .page =3D 2, + .addr =3D 0x30, + }, + [BMI270_NOMO2_REG] =3D { + .page =3D 2, + .addr =3D 0x32, + }, [BMI270_SC_26_REG] =3D { .page =3D 6, .addr =3D 0x32, @@ -439,6 +486,95 @@ static int bmi270_step_wtrmrk_en(struct bmi270_data *d= ata, bool state) state)); } =20 +static int bmi270_anymotion_event_en(struct bmi270_data *data, + struct iio_chan_spec const *chan, + bool state) +{ + u16 axis_msk, axis_field_val, regval; + int ret, irq_reg; + bool axis_en; + + irq_reg =3D bmi270_int_map_reg(data->irq_pin); + if (irq_reg < 0) + return irq_reg; + + guard(mutex)(&data->mutex); + + ret =3D bmi270_read_feature_reg(data, BMI270_ANYMO1_REG, ®val); + if (ret) + return ret; + + switch (chan->channel2) { + case IIO_MOD_X: + axis_msk =3D BMI270_FEAT_MOTION_X_EN_MSK; + axis_field_val =3D FIELD_PREP(BMI270_FEAT_MOTION_X_EN_MSK, state); + axis_en =3D FIELD_GET(BMI270_FEAT_MOTION_Y_EN_MSK, regval) | + FIELD_GET(BMI270_FEAT_MOTION_Z_EN_MSK, regval); + break; + case IIO_MOD_Y: + axis_msk =3D BMI270_FEAT_MOTION_Y_EN_MSK; + axis_field_val =3D FIELD_PREP(BMI270_FEAT_MOTION_Y_EN_MSK, state); + axis_en =3D FIELD_GET(BMI270_FEAT_MOTION_X_EN_MSK, regval) | + FIELD_GET(BMI270_FEAT_MOTION_Z_EN_MSK, regval); + break; + case IIO_MOD_Z: + axis_msk =3D BMI270_FEAT_MOTION_Z_EN_MSK; + axis_field_val =3D FIELD_PREP(BMI270_FEAT_MOTION_Z_EN_MSK, state); + axis_en =3D FIELD_GET(BMI270_FEAT_MOTION_X_EN_MSK, regval) | + FIELD_GET(BMI270_FEAT_MOTION_Y_EN_MSK, regval); + break; + default: + return -EINVAL; + } + + ret =3D bmi270_update_feature_reg(data, BMI270_ANYMO1_REG, axis_msk, + axis_field_val); + if (ret) + return ret; + + ret =3D bmi270_update_feature_reg(data, BMI270_ANYMO2_REG, + BMI270_FEAT_MOTION_ENABLE_MSK, + FIELD_PREP(BMI270_FEAT_MOTION_ENABLE_MSK, + state || axis_en)); + if (ret) + return ret; + + return regmap_update_bits(data->regmap, irq_reg, + BMI270_INT_MAP_FEAT_ANYMOTION_MSK, + FIELD_PREP(BMI270_INT_MAP_FEAT_ANYMOTION_MSK, + state || axis_en)); +} + +static int bmi270_nomotion_event_en(struct bmi270_data *data, bool state) +{ + int ret, irq_reg; + + irq_reg =3D bmi270_int_map_reg(data->irq_pin); + if (irq_reg < 0) + return irq_reg; + + guard(mutex)(&data->mutex); + + ret =3D bmi270_update_feature_reg(data, BMI270_NOMO1_REG, + BMI270_FEAT_MOTION_XYZ_EN_MSK, + FIELD_PREP(BMI270_FEAT_MOTION_XYZ_EN_MSK, + state ? BMI270_MOTION_XYZ_MSK : 0)); + if (ret) + return ret; + + ret =3D bmi270_update_feature_reg(data, BMI270_NOMO2_REG, + BMI270_FEAT_MOTION_ENABLE_MSK, + FIELD_PREP(BMI270_FEAT_MOTION_ENABLE_MSK, + state)); + if (ret) + return ret; + + return regmap_update_bits(data->regmap, irq_reg, + BMI270_INT_MAP_FEAT_NOMOTION_MSK, + FIELD_PREP(BMI270_INT_MAP_FEAT_NOMOTION_MSK, + state)); +} + static int bmi270_set_scale(struct bmi270_data *data, int chan_type, int u= scale) { int i; @@ -614,6 +750,20 @@ static irqreturn_t bmi270_irq_thread_handler(int irq, = void *private) if (FIELD_GET(BMI270_INT_STATUS_1_ACC_GYR_DRDY_MSK, status1)) iio_trigger_poll_nested(data->trig); =20 + if (FIELD_GET(BMI270_INT_STATUS_0_MOTION_MSK, status0)) + iio_push_event(indio_dev, IIO_MOD_EVENT_CODE(IIO_ACCEL, 0, + IIO_MOD_X_OR_Y_OR_Z, + IIO_EV_TYPE_MAG_ADAPTIVE, + IIO_EV_DIR_RISING), + timestamp); + + if (FIELD_GET(BMI270_INT_STATUS_0_NOMOTION_MSK, status0)) + iio_push_event(indio_dev, IIO_MOD_EVENT_CODE(IIO_ACCEL, 0, + IIO_MOD_X_AND_Y_AND_Z, + IIO_EV_TYPE_ROC, + IIO_EV_DIR_RISING), + timestamp); + if (FIELD_GET(BMI270_INT_STATUS_0_STEP_CNT_MSK, status0)) iio_push_event(indio_dev, IIO_UNMOD_EVENT_CODE(IIO_STEPS, 0, IIO_EV_TYPE_CHANGE, @@ -827,6 +977,20 @@ static int bmi270_read_avail(struct iio_dev *indio_dev, } } =20 +static IIO_CONST_ATTR(in_accel_value_available, "[0.0 0.00049 1.0]"); + +static IIO_CONST_ATTR(in_accel_period_available, "[0.0 0.02 162.0]"); + +static struct attribute *bmi270_event_attributes[] =3D { + &iio_const_attr_in_accel_value_available.dev_attr.attr, + &iio_const_attr_in_accel_period_available.dev_attr.attr, + NULL +}; + +static const struct attribute_group bmi270_event_attribute_group =3D { + .attrs =3D bmi270_event_attributes, +}; + static int bmi270_write_event_config(struct iio_dev *indio_dev, const struct iio_chan_spec *chan, enum iio_event_type type, @@ -835,6 +999,10 @@ static int bmi270_write_event_config(struct iio_dev *i= ndio_dev, struct bmi270_data *data =3D iio_priv(indio_dev); =20 switch (type) { + case IIO_EV_TYPE_MAG_ADAPTIVE: + return bmi270_anymotion_event_en(data, chan, state); + case IIO_EV_TYPE_ROC: + return bmi270_nomotion_event_en(data, state); case IIO_EV_TYPE_CHANGE: return bmi270_step_wtrmrk_en(data, state); default: @@ -848,21 +1016,58 @@ static int bmi270_read_event_config(struct iio_dev *= indio_dev, enum iio_event_direction dir) { struct bmi270_data *data =3D iio_priv(indio_dev); - int ret, reg, regval; + bool feat_en, axis_en; + unsigned int regval; + u16 motion_reg; + int ret, reg; =20 guard(mutex)(&data->mutex); =20 + reg =3D bmi270_int_map_reg(data->irq_pin); + if (reg < 0) + return reg; + + ret =3D regmap_read(data->regmap, reg, ®val); + if (ret) + return ret; + switch (chan->type) { case IIO_STEPS: - reg =3D bmi270_int_map_reg(data->irq_pin); - if (reg) - return reg; - - ret =3D regmap_read(data->regmap, reg, ®val); - if (ret) - return ret; return FIELD_GET(BMI270_INT_MAP_FEAT_STEP_CNT_WTRMRK_MSK, regval) ? 1 : 0; + case IIO_ACCEL: + switch (type) { + case IIO_EV_TYPE_ROC: + return FIELD_GET(BMI270_INT_MAP_FEAT_NOMOTION_MSK, + regval) ? 1 : 0; + case IIO_EV_TYPE_MAG_ADAPTIVE: + ret =3D bmi270_read_feature_reg(data, BMI270_ANYMO1_REG, + &motion_reg); + if (ret) + return ret; + + feat_en =3D FIELD_GET(BMI270_INT_MAP_FEAT_ANYMOTION_MSK, + regval); + switch (chan->channel2) { + case IIO_MOD_X: + axis_en =3D FIELD_GET(BMI270_FEAT_MOTION_X_EN_MSK, + motion_reg); + break; + case IIO_MOD_Y: + axis_en =3D FIELD_GET(BMI270_FEAT_MOTION_Y_EN_MSK, + motion_reg); + break; + case IIO_MOD_Z: + axis_en =3D FIELD_GET(BMI270_FEAT_MOTION_Z_EN_MSK, + motion_reg); + break; + default: + return -EINVAL; + } + return (axis_en && feat_en) ? 1 : 0; + default: + return -EINVAL; + } default: return -EINVAL; } @@ -876,11 +1081,18 @@ static int bmi270_write_event_value(struct iio_dev *= indio_dev, int val, int val2) { struct bmi270_data *data =3D iio_priv(indio_dev); - unsigned int raw; + unsigned int raw, mask, regval; + int reg; =20 guard(mutex)(&data->mutex); =20 switch (type) { + case IIO_EV_TYPE_MAG_ADAPTIVE: + reg =3D BMI270_ANYMO1_REG; + break; + case IIO_EV_TYPE_ROC: + reg =3D BMI270_NOMO1_REG; + break; case IIO_EV_TYPE_CHANGE: if (!in_range(val, 0, BMI270_STEP_COUNTER_MAX + 1)) return -EINVAL; @@ -893,6 +1105,29 @@ static int bmi270_write_event_value(struct iio_dev *i= ndio_dev, default: return -EINVAL; } + + switch (info) { + case IIO_EV_INFO_VALUE: + if (!in_range(val, 0, 1)) + return -EINVAL; + + raw =3D BMI270_INT_MICRO_TO_RAW(val, val2, + BMI270_MOTION_THRES_SCALE); + mask =3D BMI270_FEAT_MOTION_THRESHOLD_MSK; + regval =3D FIELD_PREP(BMI270_FEAT_MOTION_THRESHOLD_MSK, raw); + return bmi270_update_feature_reg(data, reg, mask, regval); + case IIO_EV_INFO_PERIOD: + if (!in_range(val, 0, BMI270_MOTION_DURAT_MAX + 1)) + return -EINVAL; + + raw =3D BMI270_INT_MICRO_TO_RAW(val, val2, + BMI270_MOTION_DURAT_SCALE); + mask =3D BMI270_FEAT_MOTION_DURATION_MSK; + regval =3D FIELD_PREP(BMI270_FEAT_MOTION_DURATION_MSK, raw); + return bmi270_update_feature_reg(data, reg, mask, regval); + default: + return -EINVAL; + } } =20 static int bmi270_read_event_value(struct iio_dev *indio_dev, @@ -904,12 +1139,18 @@ static int bmi270_read_event_value(struct iio_dev *i= ndio_dev, { struct bmi270_data *data =3D iio_priv(indio_dev); unsigned int raw; + int ret, reg; u16 regval; - int ret; =20 guard(mutex)(&data->mutex); =20 switch (type) { + case IIO_EV_TYPE_MAG_ADAPTIVE: + reg =3D BMI270_ANYMO1_REG; + break; + case IIO_EV_TYPE_ROC: + reg =3D BMI270_NOMO1_REG; + break; case IIO_EV_TYPE_CHANGE: ret =3D bmi270_read_feature_reg(data, BMI270_SC_26_REG, ®val); if (ret) @@ -921,6 +1162,29 @@ static int bmi270_read_event_value(struct iio_dev *in= dio_dev, default: return -EINVAL; } + + switch (info) { + case IIO_EV_INFO_VALUE: + ret =3D bmi270_read_feature_reg(data, reg, ®val); + if (ret) + return ret; + + raw =3D FIELD_GET(BMI270_FEAT_MOTION_THRESHOLD_MSK, regval); + *val =3D raw / BMI270_MOTION_THRES_SCALE; + *val2 =3D BMI270_RAW_TO_MICRO(raw, BMI270_MOTION_THRES_SCALE); + return IIO_VAL_INT_PLUS_MICRO; + case IIO_EV_INFO_PERIOD: + ret =3D bmi270_read_feature_reg(data, reg, ®val); + if (ret) + return ret; + + raw =3D FIELD_GET(BMI270_FEAT_MOTION_DURATION_MSK, regval); + *val =3D raw / BMI270_MOTION_DURAT_SCALE; + *val2 =3D BMI270_RAW_TO_MICRO(raw, BMI270_MOTION_DURAT_SCALE); + return IIO_VAL_INT_PLUS_MICRO; + default: + return -EINVAL; + } } =20 static const struct iio_event_spec bmi270_step_wtrmrk_event =3D { @@ -929,6 +1193,20 @@ static const struct iio_event_spec bmi270_step_wtrmrk= _event =3D { .mask_shared_by_type =3D BIT(IIO_EV_INFO_ENABLE) | BIT(IIO_EV_INFO_VALUE), }; =20 +static const struct iio_event_spec bmi270_anymotion_event =3D { + .type =3D IIO_EV_TYPE_MAG_ADAPTIVE, + .dir =3D IIO_EV_DIR_RISING, + .mask_separate =3D BIT(IIO_EV_INFO_ENABLE), + .mask_shared_by_type =3D BIT(IIO_EV_INFO_VALUE) | BIT(IIO_EV_INFO_PERIOD), +}; + +static const struct iio_event_spec bmi270_nomotion_event =3D { + .type =3D IIO_EV_TYPE_ROC, + .dir =3D IIO_EV_DIR_RISING, + .mask_separate =3D BIT(IIO_EV_INFO_ENABLE), + .mask_shared_by_type =3D BIT(IIO_EV_INFO_VALUE) | BIT(IIO_EV_INFO_PERIOD), +}; + static const struct iio_info bmi270_info =3D { .read_raw =3D bmi270_read_raw, .write_raw =3D bmi270_write_raw, @@ -937,6 +1215,7 @@ static const struct iio_info bmi270_info =3D { .read_event_config =3D bmi270_read_event_config, .write_event_value =3D bmi270_write_event_value, .read_event_value =3D bmi270_read_event_value, + .event_attrs =3D &bmi270_event_attribute_group, }; =20 #define BMI270_ACCEL_CHANNEL(_axis) { \ @@ -956,6 +1235,8 @@ static const struct iio_info bmi270_info =3D { .storagebits =3D 16, \ .endianness =3D IIO_LE, \ }, \ + .event_spec =3D &bmi270_anymotion_event, \ + .num_event_specs =3D 1, \ } =20 #define BMI270_ANG_VEL_CHANNEL(_axis) { \ @@ -1000,6 +1281,14 @@ static const struct iio_chan_spec bmi270_channels[] = =3D { .num_event_specs =3D 1, }, IIO_CHAN_SOFT_TIMESTAMP(BMI270_SCAN_TIMESTAMP), + { + .type =3D IIO_ACCEL, + .modified =3D 1, + .channel2 =3D IIO_MOD_X_AND_Y_AND_Z, + .scan_index =3D -1, /* Fake channel */ + .event_spec =3D &bmi270_nomotion_event, + .num_event_specs =3D 1, + }, }; =20 static int bmi270_int_pin_config(struct bmi270_data *data, @@ -1107,6 +1396,13 @@ static int bmi270_trigger_probe(struct bmi270_data *= data, return dev_err_probe(data->dev, ret, "Trigger registration failed\n"); =20 + /* Disable axes for motion events */ + ret =3D bmi270_update_feature_reg(data, BMI270_ANYMO1_REG, + BMI270_FEAT_MOTION_XYZ_EN_MSK, + FIELD_PREP(BMI270_FEAT_MOTION_XYZ_EN_MSK, 0)); + if (ret) + return ret; + data->irq_pin =3D irq_pin; =20 return 0; --=20 2.49.0