From nobody Fri Oct 10 03:57:26 2025 Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8C1F2DF3F7 for ; Mon, 16 Jun 2025 13:14:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.29.241.158 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750079652; cv=none; b=ASXEcXwDMOvYvgyLiUDy3lSvJw7Q29CSwAUO9iM43QDsfBJoiWQhUKPYQgR0MrPqTmupFborDUJhD0+ut8LJxjt5IBVJjw6eZB6T5f6aWk4vEC4uoCQ2meuAYjAA6jDo+kV/4mlr2Y2jPVSB/aCfbzcPGzHpxtsJl8BUFqRXDLs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750079652; c=relaxed/simple; bh=KuN/6h42XoqFx0epqK/D83oGkccNJcqSb0beduloRwA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TkZTOeL8LXtJ7+Qx52XWYBTHqiC0DtS7SOJhExtC99pzUl9Ft6mHXB/rsMrrggLQYVtGGcR+XVv0dP2DqtVt21oCWCBa77aM81Y0YJn7TPDqXiRgQBS2Y5tUjnnrHixyLlgJ6zgbuHRZJrh0at5tBwe2dGHzTOXZOQe6uHiiF7E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au; spf=pass smtp.mailfrom=codeconstruct.com.au; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b=aU0U4ivu; arc=none smtp.client-ip=203.29.241.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b="aU0U4ivu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1750079643; bh=DyK7Zsciqq7Gdc/WmqGLpznYW74mVN+9mTkl64s/CPk=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=aU0U4ivusVdtrxuWPPlu7XAx0brJ7c/IBctTBCJaQGerqk2Gf0jOWXL0Du8swgdMi eJxyAWsihCFaZVdTzS59JSjvcvxNbsuuWhV7G4uJ1BbkTi0STlAe40YJIeN36sEz2r RIdtkdFBPR351m+I5hkTr9sHg5qg4h/5v+1i3Zb5+VfzrDwcJB2rVcM1i2voLrQRlO b21ScLnzRr+IYzlcPk3m49Bwuf5U5MwWwO0b6h0T53SwCTZ8Oyv0MSPH307JN/GI+l M4xr10bWNXKwA2I6kC+WXoBg+wHTYZSwZb8XyPvUHeprcaQlUDEhn0TnBLaE+g8ToW WYWDVe+n/yfLA== Received: from [127.0.1.1] (unknown [180.150.112.166]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 9E78B6884C; Mon, 16 Jun 2025 21:14:02 +0800 (AWST) From: Andrew Jeffery Date: Mon, 16 Jun 2025 22:43:44 +0930 Subject: [PATCH v2 07/10] soc: aspeed: lpc-snoop: Switch to devm_clk_get_enabled() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250616-aspeed-lpc-snoop-fixes-v2-7-3cdd59c934d3@codeconstruct.com.au> References: <20250616-aspeed-lpc-snoop-fixes-v2-0-3cdd59c934d3@codeconstruct.com.au> In-Reply-To: <20250616-aspeed-lpc-snoop-fixes-v2-0-3cdd59c934d3@codeconstruct.com.au> To: linux-aspeed@lists.ozlabs.org Cc: Joel Stanley , Henry Martin , Jean Delvare , Patrick Rudolph , Andrew Geissler , Ninad Palsule , Patrick Venture , Robert Lippert , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andrew Jeffery X-Mailer: b4 0.14.2 Simplify clock handling as done in other drivers. Signed-off-by: Andrew Jeffery Acked-by: Jean Delvare --- drivers/soc/aspeed/aspeed-lpc-snoop.c | 20 ++++---------------- 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/drivers/soc/aspeed/aspeed-lpc-snoop.c b/drivers/soc/aspeed/asp= eed-lpc-snoop.c index 9992212c789d4224edcc0ee1a3bb9c73f9fc661b..bd4afa7f258eb3c1e64fe87d2b4= be5f8422fbaf7 100644 --- a/drivers/soc/aspeed/aspeed-lpc-snoop.c +++ b/drivers/soc/aspeed/aspeed-lpc-snoop.c @@ -329,26 +329,21 @@ static int aspeed_lpc_snoop_probe(struct platform_dev= ice *pdev) return -ENODEV; } =20 - lpc_snoop->clk =3D devm_clk_get(dev, NULL); + lpc_snoop->clk =3D devm_clk_get_enabled(dev, NULL); if (IS_ERR(lpc_snoop->clk)) { rc =3D PTR_ERR(lpc_snoop->clk); if (rc !=3D -EPROBE_DEFER) dev_err(dev, "couldn't get clock\n"); return rc; } - rc =3D clk_prepare_enable(lpc_snoop->clk); - if (rc) { - dev_err(dev, "couldn't enable clock\n"); - return rc; - } =20 rc =3D aspeed_lpc_snoop_config_irq(lpc_snoop, pdev); if (rc) - goto err; + return rc; =20 rc =3D aspeed_lpc_enable_snoop(lpc_snoop, dev, ASPEED_LPC_SNOOP_INDEX_0, = port); if (rc) - goto err; + return rc; =20 /* Configuration of 2nd snoop channel port is optional */ if (of_property_read_u32_index(dev->of_node, "snoop-ports", @@ -356,16 +351,11 @@ static int aspeed_lpc_snoop_probe(struct platform_dev= ice *pdev) rc =3D aspeed_lpc_enable_snoop(lpc_snoop, dev, ASPEED_LPC_SNOOP_INDEX_1,= port); if (rc) { aspeed_lpc_disable_snoop(lpc_snoop, ASPEED_LPC_SNOOP_INDEX_0); - goto err; + return rc; } } =20 return 0; - -err: - clk_disable_unprepare(lpc_snoop->clk); - - return rc; } =20 static void aspeed_lpc_snoop_remove(struct platform_device *pdev) @@ -375,8 +365,6 @@ static void aspeed_lpc_snoop_remove(struct platform_dev= ice *pdev) /* Disable both snoop channels */ aspeed_lpc_disable_snoop(lpc_snoop, ASPEED_LPC_SNOOP_INDEX_0); aspeed_lpc_disable_snoop(lpc_snoop, ASPEED_LPC_SNOOP_INDEX_1); - - clk_disable_unprepare(lpc_snoop->clk); } =20 static const struct aspeed_lpc_snoop_model_data ast2400_model_data =3D { --=20 2.39.5