From nobody Fri Oct 10 14:02:03 2025 Received: from mail-vs1-f74.google.com (mail-vs1-f74.google.com [209.85.217.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C94A62566F5 for ; Fri, 13 Jun 2025 20:23:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749846204; cv=none; b=PKKM8mQPpYmDl4q4Sav/Bct9K9KrowfJW8q62ZqwNenu0g+/zrta9PW2ow/zyM0fSsN/fduh5G0OHT2JOdwhjckAWiVuImCAWAbQLY90qaEGiOQS4HC0YFkcr5RPLfrhhkUiYztGmsLlHycEpg1F6laFIbe5GvPkNEYWGg4SPBc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749846204; c=relaxed/simple; bh=59Iy6rW99a1WmCSYZewQQsUiKBtGxHTFVJJ6e22aVhg=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=eekPN6O0Ga8mMzNpvtOIpuccaEWT2sgKCplxCoUfm46ie9ndyVeciMs+RpCxg0kV02SJTkgtOyIdxmrJDX6/Bila4H1y4njXOlxT8+cC8ZzW9EZat5b3jtKgQw+OVWzMqoBjE3ZZ1bGyblcTiiKElzNkxVznAa5d06Vmtk07jxU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jthoughton.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=KUWAQV2I; arc=none smtp.client-ip=209.85.217.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jthoughton.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="KUWAQV2I" Received: by mail-vs1-f74.google.com with SMTP id ada2fe7eead31-4e7f36a3c97so145811137.0 for ; Fri, 13 Jun 2025 13:23:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1749846201; x=1750451001; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=XzW1XmGn2aMxciKqb55qIDnqTsupaBqldoKo6HBQgdg=; b=KUWAQV2IJ2Z+tJXzQt7b0Oddc58VtJraHNrqKPx64OrCIhI5h0+qn4xdsC0z0RbQaC xAdmLqiS8q6AOcCvZE6Ja1IfT0upGAuEzEdIqM2G9OAADo5FPVrZCyT+BeF7LlJcfvN6 dBBcaLUA9wCcg3RD1/1uIFhOdqnLONqJPQlFV27i2vyR6Vr3T4Mdko4S+QbRFHB8ll/U hoqWGsA7R6HrmlNWtnGyLkpdD/dbdCNpIAwphYee3DfneEeSAddeEkfqx0kMpW7zAfxS iPr+BXurPC1e2VO5A3fAb/1nmh69GmbXBtajgScgS/wAszI9mm38Q7Q+WQyAPyglCJ5I kVeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749846201; x=1750451001; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XzW1XmGn2aMxciKqb55qIDnqTsupaBqldoKo6HBQgdg=; b=OlDEQpBLtfL0fVQ4K6WMsnt2Ozkk7DpVJucK6+rC/Qe5ll2ejHCRq2bIE3Fb94mb9E QMWOCO1mH9rnc8s9gaxbjr6yDmmdH4vPSEAdGM6WIsEBQwaPltgR5vvWO3uqKoLBVfPU 4D/wCISvKFARKZxcUyzaciszg7me86cwLAz/rkAu+PDW4Ov1+qV9EB5xRota4xvmp5fw eqxKsNoiNvFGXC4vHzNeGgF6SNY+J04ghFjVXa1FSce4NklkWqn3IlnkbJjaVTeoVqlr 6ylk5Tq3hssNGTCLR1IpuAbVJWsndw88si79EVMlHq7D5jCwZWCrLYyWZHAGB6pVuL9E K+NQ== X-Forwarded-Encrypted: i=1; AJvYcCW1Ywdvj9NCfZ69XT5DYqurdNJ2Wd55hpynrLYQeNoVTxel9p0PxD+2pTTy5shbnc1nD5Nkz33MDsrxB9A=@vger.kernel.org X-Gm-Message-State: AOJu0YwJHgORVc/fjNwQcK75F7pqakfW7CVYbC1nXs1Pnxg0avf9hpvA yZxQ0MD42rmVeBGX19AMjKlRFT2+SKDda9PyCmNc9SDDkrSaKKCcHMGaQZabhgO/IyAk32A6l8n aS8EkvT3qqWTb4Lz8z4HABg== X-Google-Smtp-Source: AGHT+IE0NRHrDMwWtpGIEcKCTxD5Kf4jPxTrfVXerE3Nehmx+tOQQdnuX2HHZR/1hH8/WLBcgQXhf/bWdS+qG9E+ X-Received: from uae4.prod.google.com ([2002:a05:6130:8104:b0:87e:e774:76ee]) (user=jthoughton job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6102:418d:b0:4dd:b82d:e0de with SMTP id ada2fe7eead31-4e7f6223165mr1228261137.17.1749846201672; Fri, 13 Jun 2025 13:23:21 -0700 (PDT) Date: Fri, 13 Jun 2025 20:23:12 +0000 In-Reply-To: <20250613202315.2790592-1-jthoughton@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250613202315.2790592-1-jthoughton@google.com> X-Mailer: git-send-email 2.50.0.rc2.692.g299adb8693-goog Message-ID: <20250613202315.2790592-6-jthoughton@google.com> Subject: [PATCH v4 5/7] KVM: selftests: Introduce a selftest to measure execution performance From: James Houghton To: Paolo Bonzini , Sean Christopherson Cc: Vipin Sharma , David Matlack , James Houghton , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: David Matlack Introduce a new selftest, execute_perf_test, that uses the perf_test_util framework to measure the performance of executing code within a VM. This test is similar to the other perf_test_util-based tests in that it spins up a variable number of vCPUs and runs them concurrently, accessing memory. In order to support execution, extend perf_test_util to populate guest memory with return instructions rather than random garbage. This way memory can be execute simply by calling it. Currently only x86_64 supports execution, but other architectures can be easily added by providing their return code instruction. Signed-off-by: David Matlack Signed-off-by: James Houghton --- tools/testing/selftests/kvm/Makefile.kvm | 1 + .../testing/selftests/kvm/execute_perf_test.c | 199 ++++++++++++++++++ .../testing/selftests/kvm/include/memstress.h | 4 + tools/testing/selftests/kvm/lib/memstress.c | 25 ++- 4 files changed, 227 insertions(+), 2 deletions(-) create mode 100644 tools/testing/selftests/kvm/execute_perf_test.c diff --git a/tools/testing/selftests/kvm/Makefile.kvm b/tools/testing/selft= ests/kvm/Makefile.kvm index 38b95998e1e6b..0dc435e944632 100644 --- a/tools/testing/selftests/kvm/Makefile.kvm +++ b/tools/testing/selftests/kvm/Makefile.kvm @@ -137,6 +137,7 @@ TEST_GEN_PROGS_x86 +=3D x86/recalc_apic_map_test TEST_GEN_PROGS_x86 +=3D access_tracking_perf_test TEST_GEN_PROGS_x86 +=3D coalesced_io_test TEST_GEN_PROGS_x86 +=3D dirty_log_perf_test +TEST_GEN_PROGS_x86 +=3D execute_perf_test TEST_GEN_PROGS_x86 +=3D guest_memfd_test TEST_GEN_PROGS_x86 +=3D hardware_disable_test TEST_GEN_PROGS_x86 +=3D memslot_modification_stress_test diff --git a/tools/testing/selftests/kvm/execute_perf_test.c b/tools/testin= g/selftests/kvm/execute_perf_test.c new file mode 100644 index 0000000000000..f7cbfd8184497 --- /dev/null +++ b/tools/testing/selftests/kvm/execute_perf_test.c @@ -0,0 +1,199 @@ +// SPDX-License-Identifier: GPL-2.0 +#include +#include +#include +#include +#include +#include + +#include "kvm_util.h" +#include "test_util.h" +#include "memstress.h" +#include "guest_modes.h" +#include "ucall_common.h" + +/* Global variable used to synchronize all of the vCPU threads. */ +static int iteration; + +/* Set to true when vCPU threads should exit. */ +static bool done; + +/* The iteration that was last completed by each vCPU. */ +static int vcpu_last_completed_iteration[KVM_MAX_VCPUS]; + +/* Whether to overlap the regions of memory vCPUs access. */ +static bool overlap_memory_access; + +struct test_params { + /* The backing source for the region of memory. */ + enum vm_mem_backing_src_type backing_src; + + /* The amount of memory to allocate for each vCPU. */ + uint64_t vcpu_memory_bytes; + + /* The number of vCPUs to create in the VM. */ + int nr_vcpus; + + /* The number of execute iterations the test will run. */ + int iterations; +}; + +static void assert_ucall(struct kvm_vcpu *vcpu, uint64_t expected_ucall) +{ + struct ucall uc =3D {}; + + TEST_ASSERT(expected_ucall =3D=3D get_ucall(vcpu, &uc), + "Guest exited unexpectedly (expected ucall %" PRIu64 + ", got %" PRIu64 ")", + expected_ucall, uc.cmd); +} + +static bool spin_wait_for_next_iteration(int *current_iteration) +{ + int last_iteration =3D *current_iteration; + + do { + if (READ_ONCE(done)) + return false; + + *current_iteration =3D READ_ONCE(iteration); + } while (last_iteration =3D=3D *current_iteration); + + return true; +} + +static void vcpu_thread_main(struct memstress_vcpu_args *vcpu_args) +{ + struct kvm_vcpu *vcpu =3D vcpu_args->vcpu; + int current_iteration =3D 0; + + while (spin_wait_for_next_iteration(¤t_iteration)) { + vcpu_run(vcpu); + assert_ucall(vcpu, UCALL_SYNC); + vcpu_last_completed_iteration[vcpu->id] =3D current_iteration; + } +} + +static void spin_wait_for_vcpu(struct kvm_vcpu *vcpu, int target_iteration) +{ + while (READ_ONCE(vcpu_last_completed_iteration[vcpu->id]) !=3D + target_iteration) { + continue; + } +} + +static void run_iteration(struct kvm_vm *vm, const char *description) +{ + struct timespec ts_elapsed; + struct timespec ts_start; + struct kvm_vcpu *vcpu; + int next_iteration; + + /* Kick off the vCPUs by incrementing iteration. */ + next_iteration =3D ++iteration; + + clock_gettime(CLOCK_MONOTONIC, &ts_start); + + /* Wait for all vCPUs to finish the iteration. */ + list_for_each_entry(vcpu, &vm->vcpus, list) + spin_wait_for_vcpu(vcpu, next_iteration); + + ts_elapsed =3D timespec_elapsed(ts_start); + pr_info("%-30s: %ld.%09lds\n", + description, ts_elapsed.tv_sec, ts_elapsed.tv_nsec); +} + +static void run_test(enum vm_guest_mode mode, void *arg) +{ + struct test_params *params =3D arg; + struct kvm_vm *vm; + int i; + + vm =3D memstress_create_vm(mode, params->nr_vcpus, + params->vcpu_memory_bytes, 1, + params->backing_src, !overlap_memory_access); + + memstress_start_vcpu_threads(params->nr_vcpus, vcpu_thread_main); + + pr_info("\n"); + + memstress_set_write_percent(vm, 100); + run_iteration(vm, "Populating memory"); + + run_iteration(vm, "Writing to memory"); + + memstress_set_execute(vm, true); + for (i =3D 0; i < params->iterations; ++i) + run_iteration(vm, "Executing from memory"); + + /* Set done to signal the vCPU threads to exit */ + done =3D true; + + memstress_join_vcpu_threads(params->nr_vcpus); + memstress_destroy_vm(vm); +} + +static void help(char *name) +{ + puts(""); + printf("usage: %s [-h] [-m mode] [-b vcpu_bytes] [-v nr_vcpus] [-o] " + "[-s mem_type] [-i iterations]\n", + name); + puts(""); + printf(" -h: Display this help message."); + guest_modes_help(); + printf(" -b: specify the size of the memory region which should be\n" + " dirtied by each vCPU. e.g. 10M or 3G.\n" + " (default: 1G)\n"); + printf(" -i: specify the number iterations to execute from memory.\n"); + printf(" -v: specify the number of vCPUs to run.\n"); + printf(" -o: Overlap guest memory accesses instead of partitioning\n" + " them into a separate region of memory for each vCPU.\n"); + backing_src_help("-s"); + puts(""); + exit(0); +} + +int main(int argc, char *argv[]) +{ + struct test_params params =3D { + .backing_src =3D DEFAULT_VM_MEM_SRC, + .vcpu_memory_bytes =3D DEFAULT_PER_VCPU_MEM_SIZE, + .nr_vcpus =3D 1, + .iterations =3D 1, + }; + int opt; + + guest_modes_append_default(); + + while ((opt =3D getopt(argc, argv, "hm:b:i:v:os:")) !=3D -1) { + switch (opt) { + case 'm': + guest_modes_cmdline(optarg); + break; + case 'b': + params.vcpu_memory_bytes =3D parse_size(optarg); + break; + case 'i': + params.iterations =3D atoi(optarg); + break; + case 'v': + params.nr_vcpus =3D atoi(optarg); + break; + case 'o': + overlap_memory_access =3D true; + break; + case 's': + params.backing_src =3D parse_backing_src_type(optarg); + break; + case 'h': + default: + help(argv[0]); + break; + } + } + + for_each_guest_mode(run_test, ¶ms); + + return 0; +} diff --git a/tools/testing/selftests/kvm/include/memstress.h b/tools/testin= g/selftests/kvm/include/memstress.h index 9071eb6dea60a..ab2a0c05e3fd2 100644 --- a/tools/testing/selftests/kvm/include/memstress.h +++ b/tools/testing/selftests/kvm/include/memstress.h @@ -50,6 +50,9 @@ struct memstress_args { /* Test is done, stop running vCPUs. */ bool stop_vcpus; =20 + /* If vCPUs should execute from memory. */ + bool execute; + struct memstress_vcpu_args vcpu_args[KVM_MAX_VCPUS]; }; =20 @@ -63,6 +66,7 @@ void memstress_destroy_vm(struct kvm_vm *vm); =20 void memstress_set_write_percent(struct kvm_vm *vm, uint32_t write_percent= ); void memstress_set_random_access(struct kvm_vm *vm, bool random_access); +void memstress_set_execute(struct kvm_vm *vm, bool execute); =20 void memstress_start_vcpu_threads(int vcpus, void (*vcpu_fn)(struct memstr= ess_vcpu_args *)); void memstress_join_vcpu_threads(int vcpus); diff --git a/tools/testing/selftests/kvm/lib/memstress.c b/tools/testing/se= lftests/kvm/lib/memstress.c index 313277486a1de..49677742ec92d 100644 --- a/tools/testing/selftests/kvm/lib/memstress.c +++ b/tools/testing/selftests/kvm/lib/memstress.c @@ -40,6 +40,16 @@ static bool all_vcpu_threads_running; =20 static struct kvm_vcpu *vcpus[KVM_MAX_VCPUS]; =20 +/* + * When writing to guest memory, write the opcode for the `ret` instructio= n so + * that subsequent iteractions can exercise instruction fetch by calling t= he + * memory. + * + * NOTE: Non-x86 architectures would to use different values here to suppo= rt + * execute. + */ +#define RETURN_OPCODE 0xC3 + /* * Continuously write to the first 8 bytes of each page in the * specified region. @@ -75,8 +85,10 @@ void memstress_guest_code(uint32_t vcpu_idx) =20 addr =3D gva + (page * args->guest_page_size); =20 - if (__guest_random_bool(&rand_state, args->write_percent)) - *(uint64_t *)addr =3D 0x0123456789ABCDEF; + if (args->execute) + ((void (*)(void)) addr)(); + else if (__guest_random_bool(&rand_state, args->write_percent)) + *(uint64_t *)addr =3D RETURN_OPCODE; else READ_ONCE(*(uint64_t *)addr); } @@ -259,6 +271,15 @@ void __weak memstress_setup_nested(struct kvm_vm *vm, = int nr_vcpus, struct kvm_v exit(KSFT_SKIP); } =20 +void memstress_set_execute(struct kvm_vm *vm, bool execute) +{ +#ifndef __x86_64__ + TEST_FAIL("Execute not supported on thhis architecture; see RETURN_OPCODE= ."); +#endif + memstress_args.execute =3D execute; + sync_global_to_guest(vm, memstress_args); +} + static void *vcpu_thread_main(void *data) { struct vcpu_thread *vcpu =3D data; --=20 2.50.0.rc2.692.g299adb8693-goog