From nobody Fri Oct 10 13:31:31 2025 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E43F1111BF; Fri, 13 Jun 2025 13:40:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749822050; cv=none; b=Z1+7TtycwgbNtAC7hKdrbpOIv2HiJR2PKHGjy4ZyBTCHvh6aZaGfDAIYNBZ+b/L5LsHh7cBUpP0N0yqJD6EbiDSOFvGfPzMLs2PgsODD6BSi2xjeTXokWgrIjXAclSUw3xXxojFuuZjCK5LwkRh0KXgDUcym1rP0KVzb41jKaH0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749822050; c=relaxed/simple; bh=fLM1J7jVqqiZf/ld7d1JFGfRWVz+teNjK6y084/tbPs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BNSV5vms5Kwbtlbhq6bjk/VgU1NkfplM+jeg7FEJImv0lUpQmLatZyS3RynIE0hx/xHMs3qNFmJpvpokQRZt1VXVajgeDoA9i2xAFrpmxqg8fFqh0ZjlCh9Skx7HoR3sbRpTS4lO2uAd1Ou9KcCvqx/7wq3BiSjuC+cANMmGIEE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JqRVk66n; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JqRVk66n" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-450cf0120cdso17390995e9.2; Fri, 13 Jun 2025 06:40:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749822047; x=1750426847; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=oudxA8JPC06HRjXurKEPIdr/6i2EGFIADSPFZLQo5s0=; b=JqRVk66nenFwP3UFJSa2v0lIxzb6/hIo1iqOQqNzCbibJEMr/GQ7I2ZZ38jAw7Fe8s 6LhmobPA7CVC+WrrO9OB1gjz7tsXUCnq3J9ps515xDnl2kFCPVDufBS4T7kCCS6xSLwO IP8CkfzAbgm/vDgtiAsAUM0ewRwXkSN4m0cgmeJklKbHDs2Zw9b5jdoApSiPCYj+apwk v5Fhsi48PlEtIMENJxTcLGNXgW5Lx7qUOc81aKa83cmn88EuZljftGpE0EPITSFPxaYh rHK44fBmJ11GkuP0gBqN8JlQ1LAJREviY+rDCjM9n/i3c8D+UXG8Kfw5jAf+Rwp+0svE EKBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749822047; x=1750426847; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=oudxA8JPC06HRjXurKEPIdr/6i2EGFIADSPFZLQo5s0=; b=uH9MzXXREWtXXMYb12JNtv5x5RJJmjUXOI55KGpB2MW2h6Brje5YhzS+NkKXNAKy1j BZcB/N7Y3Yiwjo8cRSWIRdztI/SVpEbhKk+CVp/8mYmFlQnNEvs9vaW8/r4XAGEeRLnR dgycMXfGWzKE44ujr+m6AFBewDEvkTGAZXLcHKtZFw9QZHjUVFgxvkJ3vAWS8R6MSq7o zseuIxSmyu5ZOBokwCrRjQU7W52u8/6b89E85DQPNZKY2mdByc/OyRJ8KmVDDK/Rds0T kzHbVCPtMa5RB12Ua+e4n/pouGvLcznPTpPDRsaSMuhYyZEBFtx2gwHsoPLeSUaqVM8N MNQw== X-Forwarded-Encrypted: i=1; AJvYcCV8Th2+3U+a8mUPgRhSoViDu3bgqmJeuW04EQ6iok8ZSJAdim+3XEhfa0PLcs76GFxjGF8z44HVTKsrr8AEFKc=@vger.kernel.org, AJvYcCXCEbqv2XD4Qe0SLUPoO5zbz7zobkMSx5sWQ85oJuM68fsI6vCpvwdUwYS9aBmbk1hn9eAVER1KX8wE@vger.kernel.org, AJvYcCXfeBZ9Cxws57v8dfPEW94gUFOJIeiC6mFGK78ntU9E5ZxSBZIAJCob0A/iu8NsFkD8qf/m8DpqyEaU/Kc5@vger.kernel.org X-Gm-Message-State: AOJu0YwW1WvD6Cks/+uJgZwlTZ8Hb5P79ycPDQiT1v5yX6k/ly6rVEmD +JYsFORkenmFJHRxyiJkH5LIRItQ6MMyvJzSvg54X0kqNL4T3LOc8b44 X-Gm-Gg: ASbGncs1rVaRP0NNeLvEhH3cYIcPO4H+N9Ick/E0aPfPQSPrSbiKAyZE5/Fx99RrUdf pje+Sm0EbFORPt6ES+H/hvTG9a+MykO4r6Jx7dPm9wFYyESwOuTjywMMGAlzIvNEVCzhaNtfDTR U5xX1f/4q+D3wmbuwQLU6iUZkTC/irVEQZMIj/6bzgVXugspqglAMBnOkE3egtMGthuXdPxPlB3 8sprvqY7CLdxMdgL1waVlOosHpJqXqqd8VilOAgyEhFO3tYDMo4aWduf5LmjpuFBglwl8RjQeuI a+akTIYlvS9pbfsMxiPOIcAWYBfcoE7hz+w3x0I6EQFTRnLBWvXRROMcGney8kPdCh1W0bV+4xB iI+EefVSMyokKt8PWPl87yH1jBxsdk8Hn+XxyXppqKFsiuNc= X-Google-Smtp-Source: AGHT+IGSQQDsmwIh4IRTyDRinr32zbDXqbTyjcQINJTodAgQ41yIYuwm/iuMJcEHUctW6KpfLD9UWA== X-Received: by 2002:a05:600c:4f53:b0:43d:9f2:6274 with SMTP id 5b1f17b1804b1-45334ad2eb9mr35369995e9.14.1749822046739; Fri, 13 Jun 2025 06:40:46 -0700 (PDT) Received: from igor-korotin-Precision-Tower-3620.airspan.com ([188.39.32.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568b48564sm2361368f8f.82.2025.06.13.06.40.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jun 2025 06:40:46 -0700 (PDT) Sender: Igor Korotin From: Igor Korotin To: ojeda@kernel.org, alex.gaynor@gmail.com, rafael@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-acpi@vger.kernel.org Cc: boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu, dakr@kernel.org, lenb@kernel.org, wedsonaf@gmail.com, viresh.kumar@linaro.org, alex.hung@amd.com, dingxiangfei2009@gmail.com Subject: [PATCH v6 1/6] rust: acpi: add `acpi::DeviceId` abstraction Date: Fri, 13 Jun 2025 14:38:42 +0100 Message-ID: <20250613133842.1230254-1-igor.korotin.linux@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250613133517.1229722-1-igor.korotin.linux@gmail.com> References: <20250613133517.1229722-1-igor.korotin.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" `acpi::DeviceId` is an abstraction around `struct acpi_device_id`. This is used by subsequent patches, in particular the i2c driver abstractions, to create ACPI device ID tables. Signed-off-by: Igor Korotin --- MAINTAINERS | 1 + rust/kernel/acpi.rs | 61 +++++++++++++++++++++++++++++++++++++++++++++ rust/kernel/lib.rs | 1 + 3 files changed, 63 insertions(+) create mode 100644 rust/kernel/acpi.rs diff --git a/MAINTAINERS b/MAINTAINERS index a92290fffa16..6c809ea30e6a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -302,6 +302,7 @@ F: include/linux/acpi.h F: include/linux/fwnode.h F: include/linux/fw_table.h F: lib/fw_table.c +F: rust/kernel/acpi.rs F: tools/power/acpi/ =20 ACPI APEI diff --git a/rust/kernel/acpi.rs b/rust/kernel/acpi.rs new file mode 100644 index 000000000000..f9a98dc4eb8a --- /dev/null +++ b/rust/kernel/acpi.rs @@ -0,0 +1,61 @@ +// SPDX-License-Identifier: GPL-2.0 + +//! Advanced Configuration and Power Interface abstractions. + +use crate::{bindings, device_id::RawDeviceId, prelude::*}; + +/// IdTable type for ACPI drivers. +pub type IdTable =3D &'static dyn kernel::device_id::IdTable; + +/// An ACPI device id. +#[repr(transparent)] +#[derive(Clone, Copy)] +pub struct DeviceId(bindings::acpi_device_id); + +// SAFETY: +// * `DeviceId` is a `#[repr(transparent)` wrapper of `struct acpi_device_= id` and does not add +// additional invariants, so it's safe to transmute to `RawType`. +// * `DRIVER_DATA_OFFSET` is the offset to the `data` field. +unsafe impl RawDeviceId for DeviceId { + type RawType =3D bindings::acpi_device_id; + + const DRIVER_DATA_OFFSET: usize =3D core::mem::offset_of!(bindings::ac= pi_device_id, driver_data); + + fn index(&self) -> usize { + self.0.driver_data as _ + } +} + +impl DeviceId { + const ACPI_ID_LEN: usize =3D 16; + + /// Create a new device id from an ACPI 'id' string. + pub const fn new(id: &'static CStr) -> Self { + assert!(id.len() <=3D Self::ACPI_ID_LEN, "ID exceeds 16 bytes"); + let src =3D id.as_bytes_with_nul(); + // Replace with `bindings::acpi_device_id::default()` once stabili= zed for `const`. + // SAFETY: FFI type is valid to be zero-initialized. + let mut acpi: bindings::acpi_device_id =3D unsafe { core::mem::zer= oed() }; + let mut i =3D 0; + while i < src.len() { + acpi.id[i] =3D src[i]; + i +=3D 1; + } + + Self(acpi) + } +} + +/// Create an ACPI `IdTable` with an "alias" for modpost. +#[macro_export] +macro_rules! acpi_device_table { + ($table_name:ident, $module_table_name:ident, $id_info_type: ty, $tabl= e_data: expr) =3D> { + const $table_name: $crate::device_id::IdArray< + $crate::acpi::DeviceId, + $id_info_type, + { $table_data.len() }, + > =3D $crate::device_id::IdArray::new($table_data); + + $crate::module_device_table!("acpi", $module_table_name, $table_na= me); + }; +} diff --git a/rust/kernel/lib.rs b/rust/kernel/lib.rs index 6b4774b2b1c3..5bbf3627212f 100644 --- a/rust/kernel/lib.rs +++ b/rust/kernel/lib.rs @@ -51,6 +51,7 @@ =20 pub use ffi; =20 +pub mod acpi; pub mod alloc; #[cfg(CONFIG_AUXILIARY_BUS)] pub mod auxiliary; --=20 2.43.0 From nobody Fri Oct 10 13:31:31 2025 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0008519ABC3; Fri, 13 Jun 2025 13:42:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749822179; cv=none; b=PvYs3jBta4aStgU5lVD8IWKX1ugSGp68uVBfh0amtxNCw39jlqT/OeZeAaEZmA/ffCpJ4i3YGDL2lmfwgpqiRIU+2vqOIq4KR+puo+ek334ousTsBK0S1VEjumD4yxE1NOE6nJ/krt6gSQuxTlYciMw12G1eZgpQYhzk+docuUo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749822179; c=relaxed/simple; bh=kdiPdMh5+sRzNgtYRKj/S0sAtUte5v+zpvWVg0DO3wo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=agahtGzEi54B5F9LWYM2obbjelhTKsP4y6E4jM7+vclUwcRulwghAyYSd33cOTL+zbF9Ze2kCxVJQTxyD+eQkrtOryTwMWREnv989Cp1FVqHtfp0Jjss8tFA+DtiBqzszymrN1jqpr83SAzuJWesPoOKTy0Kd2bpgMTROXC2qRw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=R7v/a5nX; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R7v/a5nX" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3a4fb9c2436so1321383f8f.1; Fri, 13 Jun 2025 06:42:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749822176; x=1750426976; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=/5X6IDTVHTHpEsUSABa7MSKK8TKkDRNQdpFJlmd5FHY=; b=R7v/a5nXcZ1hPE6Teu5COQktZBWtmrg/3WLFDI76xAH+IXsPChYDLZn8tiuJRBYTz9 EKuCdOqmJ61pXl42KLC1KUai109P75Ilxhp54/U7+jOVVKsnfp4oUTLeaRD/N+xZAt5t rKi4yi1V0WyIm45f3gUCPw//XcteD2qyJid6JdwigcwwFeGjNsiIyfyN3skSEVSWrQWO o7Nn9UlUzTxosVxpSmcCtFAv39dpIblLW22vvw3Bh+f3pP3QdfmyLs/rimoR6FuoACMx VAupx4hNzyhcAfOaN1vflNlD35cN6RRsCpIsTh+vexXkb/XhlhnSO8KvQkrU5OzMfJ2F 864g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749822176; x=1750426976; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/5X6IDTVHTHpEsUSABa7MSKK8TKkDRNQdpFJlmd5FHY=; b=jgJg5xApEVd5GObHb0rcdjuNhkgut3i9e1Ej++JJuX/P0Ag8f48y0WAaoyMGWVqWkY C6VEz6fvzv2fQ+YrLn0JaVBFjnGICc2Xx/E8wKKVGea2wUmFnXD4zSLEEs5IfJtk3chV 9VGAm//GHQ+IMHo6owS7/+cC0IVTDISXTZi8oil9BvaWc+wU907mEi5ThIUtTxlKLdPH NH6MKomyzYMmUdMz3XszwC3bSFTnZQj1DVBIckn+QPQvdmbAXVzQiCNZKYYCcL9zsfsd OP9yh6CDIc0j3Wkj611MlrJfC8gghsQqk8zZG7iZ+3L7M1Qwi/1Phda0LJHJf4xjbYZW dCqQ== X-Forwarded-Encrypted: i=1; AJvYcCV0gFAbaeid7/3HggGnefgYoBGxR0eKF4+uZNJSfMTFEq6+zGoUBtsMmg2ZKBoGirbZ7JYIhvnNuK6B@vger.kernel.org, AJvYcCVpRdUF+JZa4zIAGjUH9wVugoQWQY4Bwi9GeIMHxmK82W6cT6c8Y1KmJ6HUFuMbMRr5AsKoB+YMvvcQqjp9@vger.kernel.org, AJvYcCXa5awEUU15FKTB+w9AFPT33AFQcsW3VH9EZ0HyaNKHvRkTZR+1Y0L+ugE+Zc0c3EyjmLSwWFcbmRG1NzoB6l8=@vger.kernel.org X-Gm-Message-State: AOJu0Yxlc7uWb4F+kIHEseMR4wm1uJ0lYGHOw7lnVsF3P8cCOZGnYKie 20aOHtbb2F0lheUYhv2nlw/XNQWYFnoQkTx8vTf3lmkxF00OEtwi+x6S X-Gm-Gg: ASbGnct+brE7dCcVj5rYzSqwu4mTmfjeB6bEtLyxy1VOj+9iL7GOXRD/Z6f4u9QHMGt LoxTYqdUxYqZ78/nN4sQa1YIK64PB+OYDCm55fEnuahwNQHEvLh7A9IhWnGEcvs0gvBrZtQzauG 5YdWbE8Pqs2JxZPixIn3Kg7LCL2xySfcgkHBpBdbg9eANJEBHg04K9slDsCY0rfi7DddcjqaE5a 3uBmlZMtnO7QYbX+C/NxgRFqP3mWP4Ehqy41gbwIJ8N/YCYdU+qu0kc1kZq86AdoDXbt/U6mwF8 tLtwtHThyXteKd+zInqBJPo9Me8/tllOLlSmxZ1J7///oN77kzOX6bJWtkPQjN6F0nk0/dVS88l y8nLPRDSueRcs/tQhm6JMp1ASpa+zBLeqO+B+Gg8= X-Google-Smtp-Source: AGHT+IErpZfMNcD4uCLvcP/jWyCe4iFHGIQImMSC9pURAYXJyAQlvgrclcjpnEZwyzObV9itosVjVQ== X-Received: by 2002:a5d:584c:0:b0:3a4:e5ea:1ac0 with SMTP id ffacd0b85a97d-3a5686e3f89mr3290245f8f.5.1749822175949; Fri, 13 Jun 2025 06:42:55 -0700 (PDT) Received: from igor-korotin-Precision-Tower-3620.airspan.com ([188.39.32.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4531febf905sm93542555e9.0.2025.06.13.06.42.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jun 2025 06:42:55 -0700 (PDT) Sender: Igor Korotin From: Igor Korotin To: ojeda@kernel.org, alex.gaynor@gmail.com, rafael@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-acpi@vger.kernel.org Cc: boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu, dakr@kernel.org, lenb@kernel.org, wedsonaf@gmail.com, viresh.kumar@linaro.org, alex.hung@amd.com, dingxiangfei2009@gmail.com Subject: [PATCH v6 2/6] rust: driver: Consolidate `Adapter::of_id_info` methods using `#[cfg]` Date: Fri, 13 Jun 2025 14:40:53 +0100 Message-ID: <20250613134053.1230903-1-igor.korotin.linux@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250613133517.1229722-1-igor.korotin.linux@gmail.com> References: <20250613133517.1229722-1-igor.korotin.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Refactor the `of_id_info` methods in the `Adapter` trait to reduce duplication. Previously, the method had two versions selected via `#[cfg(...)]` and `#[cfg(not(...))]`. This change merges them into a single method by using `#[cfg]` blocks within the method body. Suggested-by: Benno Lossin Signed-off-by: Igor Korotin --- rust/kernel/driver.rs | 40 +++++++++++++++++++++------------------- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/rust/kernel/driver.rs b/rust/kernel/driver.rs index ec9166cedfa7..cb62b75a0c0e 100644 --- a/rust/kernel/driver.rs +++ b/rust/kernel/driver.rs @@ -147,30 +147,32 @@ pub trait Adapter { /// Returns the driver's private data from the matching entry in the [= `of::IdTable`], if any. /// /// If this returns `None`, it means there is no match with an entry i= n the [`of::IdTable`]. - #[cfg(CONFIG_OF)] fn of_id_info(dev: &device::Device) -> Option<&'static Self::IdInfo> { - let table =3D Self::of_id_table()?; + #[cfg(not(CONFIG_OF))] + { + let _ =3D dev; + return None; + } =20 - // SAFETY: - // - `table` has static lifetime, hence it's valid for read, - // - `dev` is guaranteed to be valid while it's alive, and so is `= pdev.as_ref().as_raw()`. - let raw_id =3D unsafe { bindings::of_match_device(table.as_ptr(), = dev.as_raw()) }; + #[cfg(CONFIG_OF)] + { + let table =3D Self::of_id_table()?; =20 - if raw_id.is_null() { - None - } else { - // SAFETY: `DeviceId` is a `#[repr(transparent)` wrapper of `s= truct of_device_id` and - // does not add additional invariants, so it's safe to transmu= te. - let id =3D unsafe { &*raw_id.cast::() }; + // SAFETY: + // - `table` has static lifetime, hence it's valid for read, + // - `dev` is guaranteed to be valid while it's alive, and so = is `pdev.as_ref().as_raw()`. + let raw_id =3D unsafe { bindings::of_match_device(table.as_ptr= (), dev.as_raw()) }; =20 - Some(table.info(::index(id))) - } - } + if raw_id.is_null() { + None + } else { + // SAFETY: `DeviceId` is a `#[repr(transparent)` wrapper o= f `struct of_device_id` and + // does not add additional invariants, so it's safe to tra= nsmute. + let id =3D unsafe { &*raw_id.cast::() }; =20 - #[cfg(not(CONFIG_OF))] - #[allow(missing_docs)] - fn of_id_info(_dev: &device::Device) -> Option<&'static Self::IdInfo> { - None + Some(table.info(::index(id))) + } + } } =20 /// Returns the driver's private data from the matching entry of any o= f the ID tables, if any. --=20 2.43.0 From nobody Fri Oct 10 13:31:31 2025 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E71241A3155; Fri, 13 Jun 2025 13:45:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749822307; cv=none; b=Ilm/qHgQ83qWnA3SUWNuFMNABsjnPRoVp879U4gwVkiJY5z/3SXCvo/u9DTP+bXTPRHmWCpL6IISGfY4bRLerqtV0VEOOADyyxYB2y1Q+K1gSfpf/PuXSn7cK8SSHYouuktWf6+9tT5/ybKlwrS7K0pzrcrKgBCOEZgPLSkrPq4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749822307; c=relaxed/simple; bh=1Hy3ujJXBqxV9lfXBO++FN2/fZmpMCZpJfkWT5aJ4iQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Mq6MJV7h8jHvpCJITHYfiwMuGfxpxUyDfSAmFq6dpGl5x+aKDAsN4IKNT+rDTV+3wjagnCh24vZiBpiA6qdWlu9m4iNKQhgsm3kRYk8/ZiawVrAL0EMqRszQ6OzYaK6Is7h5fWHpmztUeJSLhBL2PycWb/E0zbk/ouLwW/XV8jg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TtLf8G8H; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TtLf8G8H" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-3a54700a463so1471816f8f.1; Fri, 13 Jun 2025 06:45:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749822304; x=1750427104; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=f7KlnwZB+CxVWmAEV673+n7G11D71TLYbf9q51R/jMw=; b=TtLf8G8H93S0R19lPo51vLv23ecS9k9HLiG5fRfu7hZ9ODrUqS7IfI17rH8oiuGXS9 pRMry3wXAhMwpWMF4WlFSGjFXh4rxhBptuf3BdZXZNhZQ8UtBppv2yQhB1kaR/2O+2Rp RjAN5r1aJBLMoc9k5E9o11W6KNJfw4J9uKYo09zjz+Cac9KPhMUy9a4T4vA8vDgoc4YD veTK8VLD26cSj3PUj2rgF4qjZDRg/Qw1XF/rRpgBqFTVW5ch3jfRbEuyFFwNxV3a0Vh9 YFp/TpU/l2zvGA56teePduwujP+LjoRyMELmdO1RrslygP9eXeO1TXGnWe4C667Sw9Du U35Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749822304; x=1750427104; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=f7KlnwZB+CxVWmAEV673+n7G11D71TLYbf9q51R/jMw=; b=S+3NsdqO1pxNmB0p52+T0RQvc+GY9PE7d15TQpvS1HjwB2DCfEt+I/NnOzLKPqQ32u Jl9IPHS164/dgINbgvdYCWzJUFis5jghNnAaIIbK/5UJVNISDWlY2L/7Axcbqi+6s2G9 XZoWC3Zxp5zXD8TqggT8l9RjrhmUCrWKrm1dvINOpa5Kt2DjDsp5dk2UPdLrjuRqlOBO ereUAOFh4id8yDhYaMDi9KJtbq0QTTmWJbsn9+Fk5/DXCQ46KJzQ6Hw5cEClLgc2afDT dGNZZqL3czZCrTgX4oxz5JYWrrFx4OnwCm2D+HVoi1j434omOi+FHoAoKMdvaqd/YpYm +HGA== X-Forwarded-Encrypted: i=1; AJvYcCUa7l8XtW+tOXjyKSipzyYrQmcEknHIYepHk3xQpXfIZpSJg9dQ+n86mnmBa0l86ImVWqVnWEmJjIVI73cNwGo=@vger.kernel.org, AJvYcCV2ZNiB1Dx/pQbVpdiFf/11dd5oxalCwiwMq5ZgrDYpDr07oJDC3b28JTLNMLBmUrqoqTPromjK4F9Q2Td8@vger.kernel.org, AJvYcCV58KiDiVQAqLmq11uqz3DBLbXzGz+VMKCUP9m2SqIaL91hhQ38el3dKzB31GrIn0xpSVa+1uwu52+c@vger.kernel.org X-Gm-Message-State: AOJu0Yxty8eWnOabCLD9m2f7n3dpiPHAtC9fob8JH0oLOjkDqO+pg0ns 8E36Efxc1GvvZw6omsi6HS/upKzc61+7ygylvht8j9OCjauEKzOt8CX3 X-Gm-Gg: ASbGncshRpMxe910ljlkQi2drDF9eaptxHNLiD5WWiSyTWIwVWHiZZL0CR/4edXaxo+ oMco4YgREuSa0lM+Hjf3KYM4kbkMgYSip0uSKzo32/ySOWK1Z0SrwgQxDmJRggihYVoDaPfygD1 tR2AaA0YhpgfK7FKjrp0yq3a5AAuIszcz8kWqjHaRE3s0guoG4FHV5maUTtvZ3m5JueQHXX9o4r 31G/8GE9Vqv+f4UTH+CgsYMUrjRryjakLYz/gAqHk1ztLZuJofRsOPUB/0kqvHdUQNR3l0Q5YiF otVBq2xu4vtQ63ozw5rSaM4zgPwjc+k0BKGW5q68PMljxMc1/no/gFoKhdheFeCRo0UdH7nyOJ7 e7JToA4uqNtU00r9m27YiEnWLZUA84Cdh/Xke X-Google-Smtp-Source: AGHT+IEWNniUs4P1E63VohfXQE6EU3JoQMNOoUU+QZyzKBx9d/Dwe+o27BZFGaemVFzQxWfkceM/fg== X-Received: by 2002:a05:6000:40c9:b0:3a5:1220:36d4 with SMTP id ffacd0b85a97d-3a56d83462bmr1058582f8f.22.1749822303897; Fri, 13 Jun 2025 06:45:03 -0700 (PDT) Received: from igor-korotin-Precision-Tower-3620.airspan.com ([188.39.32.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532e232e0asm51752975e9.14.2025.06.13.06.45.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jun 2025 06:45:03 -0700 (PDT) Sender: Igor Korotin From: Igor Korotin To: ojeda@kernel.org, alex.gaynor@gmail.com, rafael@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-acpi@vger.kernel.org Cc: boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu, dakr@kernel.org, lenb@kernel.org, wedsonaf@gmail.com, viresh.kumar@linaro.org, alex.hung@amd.com, dingxiangfei2009@gmail.com Subject: [PATCH v6 3/6] rust: driver: Add ACPI id table support to Adapter trait Date: Fri, 13 Jun 2025 14:43:01 +0100 Message-ID: <20250613134301.1231229-1-igor.korotin.linux@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250613133517.1229722-1-igor.korotin.linux@gmail.com> References: <20250613133517.1229722-1-igor.korotin.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Extend the `Adapter` trait to support ACPI device identification. This mirrors the existing Open Firmware (OF) support (`of_id_table`) and enables Rust drivers to match and retrieve ACPI-specific device data when `CONFIG_ACPI` is enabled. To avoid breaking compilation, a stub implementation of `acpi_id_table()` is added to the Platform adapter; the full implementation will be provided in a subsequent patch. Signed-off-by: Igor Korotin --- rust/bindings/bindings_helper.h | 1 + rust/kernel/driver.rs | 41 ++++++++++++++++++++++++++++++++- rust/kernel/platform.rs | 6 ++++- 3 files changed, 46 insertions(+), 2 deletions(-) diff --git a/rust/bindings/bindings_helper.h b/rust/bindings/bindings_helpe= r.h index bc494745f67b..dfb2dd500ef6 100644 --- a/rust/bindings/bindings_helper.h +++ b/rust/bindings/bindings_helper.h @@ -28,6 +28,7 @@ */ #include =20 +#include #include #include #include diff --git a/rust/kernel/driver.rs b/rust/kernel/driver.rs index cb62b75a0c0e..8389c122a047 100644 --- a/rust/kernel/driver.rs +++ b/rust/kernel/driver.rs @@ -6,7 +6,7 @@ //! register using the [`Registration`] class. =20 use crate::error::{Error, Result}; -use crate::{device, of, str::CStr, try_pin_init, types::Opaque, ThisModule= }; +use crate::{acpi, device, of, str::CStr, try_pin_init, types::Opaque, This= Module}; use core::pin::Pin; use pin_init::{pin_data, pinned_drop, PinInit}; =20 @@ -141,6 +141,40 @@ pub trait Adapter { /// The type holding driver private data about each device id supporte= d by the driver. type IdInfo: 'static; =20 + /// The [`acpi::IdTable`] of the corresponding driver + fn acpi_id_table() -> Option>; + + /// Returns the driver's private data from the matching entry in the [= `acpi::IdTable`], if any. + /// + /// If this returns `None`, it means there is no match with an entry i= n the [`acpi::IdTable`]. + fn acpi_id_info(dev: &device::Device) -> Option<&'static Self::IdInfo>= { + #[cfg(not(CONFIG_ACPI))] + { + let _ =3D dev; + return None; + } + + #[cfg(CONFIG_ACPI)] + { + let table =3D Self::acpi_id_table()?; + + // SAFETY: + // - `table` has static lifetime, hence it's valid for read, + // - `dev` is guaranteed to be valid while it's alive, and so = is `pdev.as_ref().as_raw()`. + let raw_id =3D unsafe { bindings::acpi_match_device(table.as_p= tr(), dev.as_raw()) }; + + if raw_id.is_null() { + None + } else { + // SAFETY: `DeviceId` is a `#[repr(transparent)` wrapper o= f `struct of_device_id` and + // does not add additional invariants, so it's safe to tra= nsmute. + let id =3D unsafe { &*raw_id.cast::() }; + + Some(table.info(::index(id))) + } + } + } + /// The [`of::IdTable`] of the corresponding driver. fn of_id_table() -> Option>; =20 @@ -180,6 +214,11 @@ fn of_id_info(dev: &device::Device) -> Option<&'static= Self::IdInfo> { /// If this returns `None`, it means that there is no match in any of = the ID tables directly /// associated with a [`device::Device`]. fn id_info(dev: &device::Device) -> Option<&'static Self::IdInfo> { + let id =3D Self::acpi_id_info(dev); + if id.is_some() { + return id; + } + let id =3D Self::of_id_info(dev); if id.is_some() { return id; diff --git a/rust/kernel/platform.rs b/rust/kernel/platform.rs index 5b21fa517e55..5923d29a0511 100644 --- a/rust/kernel/platform.rs +++ b/rust/kernel/platform.rs @@ -5,7 +5,7 @@ //! C header: [`include/linux/platform_device.h`](srctree/include/linux/pl= atform_device.h) =20 use crate::{ - bindings, container_of, device, driver, + acpi, bindings, container_of, device, driver, error::{to_result, Result}, of, prelude::*, @@ -94,6 +94,10 @@ impl driver::Adapter for Adapter= { fn of_id_table() -> Option> { T::OF_ID_TABLE } + + fn acpi_id_table() -> Option> { + None + } } =20 /// Declares a kernel module that exposes a single platform driver. --=20 2.43.0 From nobody Fri Oct 10 13:31:31 2025 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EB8C2ED85A; Fri, 13 Jun 2025 13:49:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749822580; cv=none; b=cb0V8rvJVVPnLS+MAe7y2LfHIVfHIRcr+66PAHC6kXhLZ8qB4uGVHgqjyqGmD6S0tLg+BB5IfXrHOgWpIofCy48j+pXpRbV8oXTh0Nbf/C2ktwqM28ngMOq6AfK+aiivuh/LddBnMYTFSI2qaFfFLsrvnPzi0cn6aViSn5Z7AV8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749822580; c=relaxed/simple; bh=X3GP0rFGQWYb7D9EofmWO4CkjJb3nRBnJ4sS25K5GGQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ihzV1Hz3jgC/gaq3cBp2HrFgN7kiHFfl6tuLwnwLyrUJeBxfiCHBJTPLQy+n+HVsvfOOJpnECzpD8qwO1UNJ81PmTb4U0mjROYsBM9auKWD6AOMrmEPBY3rvvv9xxwSPhOHMjiziPERGTKt/aZq96shuGC1QocwxfJUH8CWEZVk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jDmwatfu; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jDmwatfu" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3a525eee2e3so1738863f8f.2; Fri, 13 Jun 2025 06:49:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749822577; x=1750427377; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=X/r6nOkep5bcePWw/OmX8epaR10E2HZMsLJvTHOobc0=; b=jDmwatfuYDuuuzpxYppYdUR56GQzk0p5X3qFTdrDZ5FdZ0UCQGn4LaKjfl93RcwwUg Sjss4lSAe/Jh8tl7mBAZBdg+XqASL+jyqstRNZNhgnwclKpmLclePAQRHN5/u7W9qsNI hg0rcZsRm9fyZGlBxHTCyTV12utmpkjIpjTuNKhdimf2Bst7NoFIe8nWG4dFp6GnzI0t g8MpiORXevD/aNg1PGPwcV2e6kTVxKfN2LLZnjT8Z4NFWVkXpne1GUgwVFDCVDkn4IaY 0Up+QEuTQG6rGQfNwxm6Y1A25dWyzZIbbO/FY4X93Bv+aATID9hhZfRf+pon6ywqMMN7 EjAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749822577; x=1750427377; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=X/r6nOkep5bcePWw/OmX8epaR10E2HZMsLJvTHOobc0=; b=GkevFhoHdWL74jRF4Dt0SW9QSwr3/ra6gPbjgg+EFkt3tKOSTN8mOkXWEE6lf5n3sG nbRt9WqHFzfE/Gj43f5cDKq1ieZ8bkggCLspyeP110Hlf4eqtFJgFJ03EkD07HNmbk6/ Sz7cdKwHAniieBIJTqASohOjNeNAQqZkjv4u3z1DHwxl6U9NHSKo53NVRhOZUmn0pUov VKvPr5WyUpWOpVA/+tP5caR8GXFHg2c2N88/PKyxRsNgtGFo7+VvbZHIFM6ojOuWQcBJ +ICXM23c620muoLBJDKfdUk9WIwiwixYAtUzU9d2FugZr4yJ3V1FdVZAGFqnUUL+tgBt cXjA== X-Forwarded-Encrypted: i=1; AJvYcCUky7R9QWPeC9R5atmjQC2HRDgGI+F6dPkiCsZZ6UqeWOxRwa+AoLA7+dIaUG7TIpAc9BJGxo8hF7AI/GB6@vger.kernel.org, AJvYcCWkn1gh8IObpPz/BZ7eAX3U+kx1H7Y2Qgwexe3Aqps7UE8arjZQdNVZ47nVJUZdXdshRk5HdK1yRoEM@vger.kernel.org, AJvYcCX1PibPX/C/Vrf7Wen0QNLo4FDpngmKnjPbK8gwue4GufOyen8UUnwEz+l4W+uD7q/T8o4qcOxtnRDpXeFI8qY=@vger.kernel.org X-Gm-Message-State: AOJu0YwbItQ4ExO6RhlkLDgTsUke5NXnMHpF5YKg2L2To1vnB1nO7UDI hwKgt/H3/MgeIs6bw54dAOHeFfU/gpS1YXeDz0iqyOQyfYmF4pVHZQU5 X-Gm-Gg: ASbGncu5y7xL+oaDaNvs4d1tg869E7bmHL3eosLunOyLcnSsp0uKarlv8nGvPEXbS84 9WeXGCUvVTbO4tEWg7ehl+tUJqfEyI6U5vfWeRssYjVJejhJz3XshVfBUO98SYxagmzkmlvxnbd gzsTeA6+Zq2SGTUQ1zkLLWxWCOOTlTvqfqsz7AExPXRODl0tq+9Gxn9UVXe46B02cRZZf3h7beo GKWpaVt3Py9o6W5Xtqt+KzehpTYdl5EWJsorJJUEQOguqwzjEB6oIbVg3/k1K75FH4lXEMiW3dt JzVSLfo2pg0EugHYBjr3ryUo4wGXypHacud6c2UPqZWrarX7K3FjZbCu5jcJVI9VGO4+dUuRrkJ fGRfcsLhWC4iM/pjMANAikAQlSMRdFYTFHkVR X-Google-Smtp-Source: AGHT+IGGIalFTB6DUZM1gWX0syyRV3WpDt1rCMWnNCP9Kf/JDeJ16571MhlLO0tSnSeYWmbVL1oyKA== X-Received: by 2002:a05:6000:22ca:b0:3a4:d975:7d6f with SMTP id ffacd0b85a97d-3a56877eb6fmr3360807f8f.39.1749822576560; Fri, 13 Jun 2025 06:49:36 -0700 (PDT) Received: from igor-korotin-Precision-Tower-3620.airspan.com ([188.39.32.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a54d74sm2482634f8f.10.2025.06.13.06.49.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jun 2025 06:49:36 -0700 (PDT) Sender: Igor Korotin From: Igor Korotin To: ojeda@kernel.org, alex.gaynor@gmail.com, rafael@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-acpi@vger.kernel.org Cc: boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu, dakr@kernel.org, lenb@kernel.org, wedsonaf@gmail.com, viresh.kumar@linaro.org, alex.hung@amd.com, dingxiangfei2009@gmail.com Subject: [PATCH v6 4/6] rust: platform: Set `OF_ID_TABLE` default to `None` in `Driver` trait Date: Fri, 13 Jun 2025 14:45:10 +0100 Message-ID: <20250613134510.1231709-1-igor.korotin.linux@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250613133517.1229722-1-igor.korotin.linux@gmail.com> References: <20250613133517.1229722-1-igor.korotin.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Provide a default value of `None` for `Driver::OF_ID_TABLE` to simplify driver implementations. Drivers that do not require OpenFirmware matching no longer need to import the `of` module or define the constant explicitly. This reduces unnecessary boilerplate and avoids pulling in unused dependencies. Signed-off-by: Igor Korotin --- rust/kernel/platform.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rust/kernel/platform.rs b/rust/kernel/platform.rs index 5923d29a0511..2436f55b579b 100644 --- a/rust/kernel/platform.rs +++ b/rust/kernel/platform.rs @@ -162,7 +162,7 @@ pub trait Driver: Send { type IdInfo: 'static; =20 /// The table of OF device ids supported by the driver. - const OF_ID_TABLE: Option>; + const OF_ID_TABLE: Option> =3D None; =20 /// Platform driver probe. /// --=20 2.43.0 From nobody Fri Oct 10 13:31:31 2025 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FFFB2E11D8; Fri, 13 Jun 2025 13:51:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749822709; cv=none; b=iA/CeqMOjjozha1w/lsOB9Js4o0KTdZ96t5oAxHxjdBtBF4mImFXoZKdb2YRo9a4oVJZMZkO+8htsKyYeSHkUaCSAczZ20jvOR/YlKUkQf+HVgtxXQqi2v1V6eAErtUmJe31wvkyqMt8QQlkkHOz2TiRvjA662GrxOV2AKKoX84= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749822709; c=relaxed/simple; bh=qrwoSmZh1uvAMGuc0OD8LaGxAk4MN2XVSm5XQa5DvhY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nazL7Ov8WZT4CrG/0YaV0ZqkKzYG7ix5xG07D2TvK17VuxQewqnJ/UE1boDGudyeO6ahr97+TVMxII+L4CurTR8O5ovfStfEQ08LekdxxiHzHJjkvX+sOVm53I/ueCubv/v24GNsrMu6wikII7TNIQBYUBG/Z+1ZWOtDU4FmvSM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ACaFf16e; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ACaFf16e" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3a4fea34e07so1314037f8f.1; Fri, 13 Jun 2025 06:51:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749822706; x=1750427506; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=Xp6TNa4qUBX4uNwGZpN4h1HBng/ZXNtRsGZbvmQNhiQ=; b=ACaFf16e0MaWOwO/MBRkB4qrRKM9lLqr8j74FCQlSrXFE/bpdUBAan29e9UZMKs4i7 PdQXhw4Tq8ME1eXnJvafw5xPrqUbO6+SFHk7V5vfw4hVrcpIA/bL52wqTJFhKEj34kFz KVR/poYbJcx95j1nUVfpBxW4FBjsPDnxzVUjPVncfW+n+dy0bmi4ovhDGajFEt9vqOy3 57J5arwH/pOMBY1XduXwIlRJ6wJk+M6fLtbowBB5gD7Sc2TB8R4qhyaiRNkdiOvHltU3 Qg9Iu3K1vyq3nKDItkrlC8IejEOelVVqANuPFib01tO8GJdSPhgh2FGjwcEBLiJPHsDy TpMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749822706; x=1750427506; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Xp6TNa4qUBX4uNwGZpN4h1HBng/ZXNtRsGZbvmQNhiQ=; b=LKImXttKVE2rsPpJ6lUSLta47DnkrgaaPgXu7pLkqoEijK/Dh8TR1SOBO08LlhvfKP +RtA7bNf1K477jLC82j+sXkYCcxmfjUcfzsStp6Br8mtHbXKwem2v4F8jeeTthzNtF27 i5xnYLg/yKaNwxaEsUnGgXV1sRfEO0BrBDRBTb3/g+enUu/PYhSpnptgmvbwPlIxk/Ey EVFSGEzFWSE7tcteP/75PEspy0Fzyv2sUU/huYqB7YXe8Xrlemt+BvruX9WW3llOy+xS aNWOsNGQoZ+FupPFBNIChuLizHyhCR0mbfhatJkBca4OJ2KPqdZo91mvmROJlM3XcLGK 2eiw== X-Forwarded-Encrypted: i=1; AJvYcCUNk4p0go5+id+12BPhn1Kd2dq+xy8GUp6x2FLnVpGPgBgf9pD0ixgej9XPi8sz5/17Kni6OfKyvjF2@vger.kernel.org, AJvYcCUYFyUKmY2h8xSqaF7adJH/4JKKQS4FRMq5m1iQEZxDIUgqvmNoge7AUHJDwjnqFaS4mYXbfEBozDqG/SYe@vger.kernel.org, AJvYcCX/vBuTcpABgzcb8A36Qt30kHeilgPkQKc2Pb7pNCftj9US4/7uCS4b+iB5L3Cu3d1tcoFu2NshDcRt5ybSo2c=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9+pTN+TiIM5IdczZ65PD3/UWH0fk5DGgSudFxSN5iNlkrQj10 JXz0L/hZsCllIvyeEqi08tSKoQQAXrY5NEdJolHKO68RZ49iTqLpUIA2O8N08L/yVDY= X-Gm-Gg: ASbGncuWZ41mP9VuG1kXciy8mOOcLP2fwgon8JphgqC7AxBx8CBYcXV/WL/3TmoGmRj /kZuBrq2+8uHm7v//51ITDxa29bI9BMzuIrSXQY6hnkizEImrY5YEjNTjbInz/+A1Lcvjj5hRFm kNVimHntE9ZTcm6slqq0mH2j+XVOs9ULUVKUN7y0MyJCoQj1/YuaHqFJ8HL2tiq4IiY7N+VWMwh Ezcxp4DE1r/r6XiSH1v8+yYR3WYXt69xbo0Iw0L7XMbBqtNJYu+qP4PBHmNZKogubg1D8HAzV72 gv0qcHnSrhgGmtAjPuZB1qrtsLTUxvhh3cM4lMbF0LJVmusIivuMmhHQwJC0PpiX9Ifcku8Ls9d Gx0k52Ggfb0eMt1eGJPXUroJdL3H6eKrr+ak+ X-Google-Smtp-Source: AGHT+IGgi31tXooyEV3h/llbbLtPIOyeOEKKAWW17esYDZOUzx0JrD+WJRAVNUDlqd/B7dfjeISPGw== X-Received: by 2002:a5d:584b:0:b0:3a4:eeb6:3b6b with SMTP id ffacd0b85a97d-3a56876da63mr3590191f8f.43.1749822705452; Fri, 13 Jun 2025 06:51:45 -0700 (PDT) Received: from igor-korotin-Precision-Tower-3620.airspan.com ([188.39.32.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568b08c99sm2445560f8f.63.2025.06.13.06.51.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jun 2025 06:51:45 -0700 (PDT) Sender: Igor Korotin From: Igor Korotin To: ojeda@kernel.org, alex.gaynor@gmail.com, rafael@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-acpi@vger.kernel.org Cc: boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu, dakr@kernel.org, lenb@kernel.org, wedsonaf@gmail.com, viresh.kumar@linaro.org, alex.hung@amd.com, dingxiangfei2009@gmail.com Subject: [PATCH v6 5/6] rust: platform: Add ACPI match table support to `Driver` trait Date: Fri, 13 Jun 2025 14:49:43 +0100 Message-ID: <20250613134943.1232287-1-igor.korotin.linux@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250613133517.1229722-1-igor.korotin.linux@gmail.com> References: <20250613133517.1229722-1-igor.korotin.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Extend the `platform::Driver` trait to support ACPI device matching by adding the `ACPI_ID_TABLE` constant. This allows Rust platform drivers to define ACPI match tables alongside their existing OF match tables. These changes mirror the existing OF support and allow Rust platform drivers to match devices based on ACPI identifiers. Signed-off-by: Igor Korotin --- rust/kernel/platform.rs | 23 +++++++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/rust/kernel/platform.rs b/rust/kernel/platform.rs index 2436f55b579b..62a9e4ec5c19 100644 --- a/rust/kernel/platform.rs +++ b/rust/kernel/platform.rs @@ -37,12 +37,18 @@ unsafe fn register( None =3D> core::ptr::null(), }; =20 + let acpi_table =3D match T::ACPI_ID_TABLE { + Some(table) =3D> table.as_ptr(), + None =3D> core::ptr::null(), + }; + // SAFETY: It's safe to set the fields of `struct platform_driver`= on initialization. unsafe { (*pdrv.get()).driver.name =3D name.as_char_ptr(); (*pdrv.get()).probe =3D Some(Self::probe_callback); (*pdrv.get()).remove =3D Some(Self::remove_callback); (*pdrv.get()).driver.of_match_table =3D of_table; + (*pdrv.get()).driver.acpi_match_table =3D acpi_table; } =20 // SAFETY: `pdrv` is guaranteed to be a valid `RegType`. @@ -96,7 +102,7 @@ fn of_id_table() -> Option> { } =20 fn acpi_id_table() -> Option> { - None + T::ACPI_ID_TABLE } } =20 @@ -127,7 +133,7 @@ macro_rules! module_platform_driver { /// # Example /// ///``` -/// # use kernel::{bindings, c_str, device::Core, of, platform}; +/// # use kernel::{acpi, bindings, c_str, device::Core, of, platform}; /// /// struct MyDriver; /// @@ -140,9 +146,19 @@ macro_rules! module_platform_driver { /// ] /// ); /// +/// kernel::acpi_device_table!( +/// ACPI_TABLE, +/// MODULE_ACPI_TABLE, +/// ::IdInfo, +/// [ +/// (acpi::DeviceId::new(c_str!("TEST4321")), ()) +/// ] +/// ); +/// /// impl platform::Driver for MyDriver { /// type IdInfo =3D (); /// const OF_ID_TABLE: Option> =3D Some(&OF_= TABLE); +/// const ACPI_ID_TABLE: Option> =3D Some(= &ACPI_TABLE); /// /// fn probe( /// _pdev: &platform::Device, @@ -164,6 +180,9 @@ pub trait Driver: Send { /// The table of OF device ids supported by the driver. const OF_ID_TABLE: Option> =3D None; =20 + /// The table of ACPI device ids supported by the driver. + const ACPI_ID_TABLE: Option> =3D None; + /// Platform driver probe. /// /// Called when a new platform device is added or discovered. --=20 2.43.0 From nobody Fri Oct 10 13:31:31 2025 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46F7A19B5B1; Fri, 13 Jun 2025 13:56:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749822975; cv=none; b=Hxfg+3AlrkG1u5+c4CCid8TmgBQaQSt7tpRGBBSk993IHkTAEzSYxamm5DDdAuQhBohAk84VNczM5R4oMQSiTMTL6Dm7DD25KFLHSRxpKYwGIQouraU8nr0nzkmdbuzAHayhGBfCNZm4b5dFq+Q3xVyWgyP4+hLnAeitIKLWhtc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749822975; c=relaxed/simple; bh=5+kbWDXXq4IG8sDuXqes6a43G6RDWXt2POCGQmcpyOc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VQ7RrU1SMlgtKb2iiiUfZKID63qg6gnjEpXcQrwSr5b6J3RJKFne4CNTbGhZszHpw5z2BsAfpMvl0IRcvzyPHNl4AuMHLEpHW1pv792quk5DbRI7FYIM2VnhMl2QdZS6Tw4pXIeR5AxjNI1AdIpyWAri83W/xua7YDMJkL/MzjI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jRUMvw6W; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jRUMvw6W" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-442fda876a6so18932965e9.0; Fri, 13 Jun 2025 06:56:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749822971; x=1750427771; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=iuauSSTqx1TDFESDgGFVyFslKTU+wwALp8k7RA41ffM=; b=jRUMvw6WisV+ILtgTMas4DgTJTEiYQxV3Hzm/l6ykxsTgDHvOCUOPS8k3g+w0A4xdy BFyQBSBWqBDBV6oC8wAHQqZaNQkdCfxzno+K4BitIkbEefOJGICEHN+nA8cXz98uwtmb p6Gt1VQGdlBHoJyVBWw8gfnPhaCk79nYQ0Ar4XXNGIRSahDM25kV3HHUaJq3SLwX9vGw 77/07mrhdMuymd7F7J/jj6uIfkC23xUtqMsTqCWgXoML4G66pRiRH6xsDTYNqdT4X2MC VK2rpCkCJq0kAQJ7ND8TR8s7FZDvOIBX9swBFGE9pORDqetlnT3wJpbmwlA4BK9PX3lg YUug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749822971; x=1750427771; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=iuauSSTqx1TDFESDgGFVyFslKTU+wwALp8k7RA41ffM=; b=MoPAFXQhCzafSyAOmmoB1DxNuil7ZX104/ush2znxxIaupQLZBZLBotkQlvZZ2Jx7H eCr0IfM4TlJehTxdYYU6G7bSiPTAXLWowpN9iZlS8EQwTuIUGHdt45Va9Yu7aoops5YG 4rNrLXZAz2DK6KKzWJKIT3cSWpNj/qTcZNvSXPSUnrMuDPYiAO7fHxXvyNRxzTZYyYZ5 uGijrT6tzbjsj0iIH+9rTNSvRjQhsypXRgutBFbVFYbp5gKqdmo4gHvQ/OsK/oZxgf8v wgAwUV14/My6UYSGxbN+cRToR4R6zcEAZTTeSxwxin+d/E4bIoJw24rfyKRTPQblC6Ya FCYw== X-Forwarded-Encrypted: i=1; AJvYcCUtRKb+5/v1k4mo9JaiM2JOX9zp4iSCIbIartapHopbinSE8bxO+9mPDKpjGVea4C10wwpFE/0LDTMN1NWi3to=@vger.kernel.org, AJvYcCWk48ICRaf2wdB3pwYQDYtLwp++BlBdMI4VE4jvjIPLAO5f0UGH8qAIitX5IpcrzyYJZ9iwtMrzi35e@vger.kernel.org, AJvYcCXEFuLNC7rb+Rq8iOJkETTCtoNAwXuSJuVbhHQxoWBi0pPYVJpzU6uAA/fSnZwZVnr+ssEhv3McUDh5/cda@vger.kernel.org X-Gm-Message-State: AOJu0Yyz+27auW6SsGqhycFQ9jjm6RwYjx6ZI0dZ8UFK3ZnRbIsx3HHy VWmxOQbpzw/W9KXMqeXASFAW6bR/RuRHFvaV5DHCNcrGPSPGbTryVSrZ X-Gm-Gg: ASbGncvHr1zSEMMmzsI8Oyvnqk+jY8VcWQzcbMM5BXVO3zZ1k6xL68G7/gHWx8AO2m+ xB2pfhMjEqqL/IRchN2FNlX7cN8hESxljJV8jfl4whPD3mOps9tvXEs27Dw9jaK0X4lTDfzxbjN FW8LWmC5wR8EcCmfGpm5oIuDo6OazRk5oIqv98c5NQEMmgY83VavzyM7WhYIk0FqXQlWYsp7b7+ bzxQKagKfdutzaevgfT7bn+LPJxDS9bH6wPDwDBywpXRUMbMz1xVTiQB1d7pQbYbWDJFU5BSGeI E5KyfTVUUSNuL4a8AKaL2BK9QsIsdkFu4YU+sRzy4F/6J+GpNTr/VIkj3WjFCib4P50xxpP1tRn VhaiNznvGPj3OWG5vIWXdt7huCdjlaGGS8kSF X-Google-Smtp-Source: AGHT+IGTzyy552+tppB1feCaA+V2C1A6hMR43WFjhXbodmqD/BBCl9OoHG4w6shHYXb2kVogl4oGFQ== X-Received: by 2002:a05:600c:3f16:b0:450:d104:29eb with SMTP id 5b1f17b1804b1-45334ab20e4mr31162545e9.5.1749822971229; Fri, 13 Jun 2025 06:56:11 -0700 (PDT) Received: from igor-korotin-Precision-Tower-3620.airspan.com ([188.39.32.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532e195768sm53600045e9.0.2025.06.13.06.56.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jun 2025 06:56:10 -0700 (PDT) Sender: Igor Korotin From: Igor Korotin To: ojeda@kernel.org, alex.gaynor@gmail.com, rafael@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-acpi@vger.kernel.org Cc: boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu, dakr@kernel.org, lenb@kernel.org, wedsonaf@gmail.com, viresh.kumar@linaro.org, alex.hung@amd.com, dingxiangfei2009@gmail.com Subject: [PATCH v6 6/6] samples: rust: add ACPI match table example to platform driver Date: Fri, 13 Jun 2025 14:54:07 +0100 Message-ID: <20250613135407.1233005-1-igor.korotin.linux@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250613133517.1229722-1-igor.korotin.linux@gmail.com> References: <20250613133517.1229722-1-igor.korotin.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Extend the Rust sample platform driver to probe using device/driver name matching, OF ID table matching, or ACPI ID table matching. Signed-off-by: Igor Korotin --- samples/rust/rust_driver_platform.rs | 71 +++++++++++++++++++++++++++- 1 file changed, 70 insertions(+), 1 deletion(-) diff --git a/samples/rust/rust_driver_platform.rs b/samples/rust/rust_drive= r_platform.rs index 8b42b3cfb363..35d5067aa023 100644 --- a/samples/rust/rust_driver_platform.rs +++ b/samples/rust/rust_driver_platform.rs @@ -2,7 +2,7 @@ =20 //! Rust Platform driver sample. =20 -use kernel::{c_str, device::Core, of, platform, prelude::*, types::ARef}; +use kernel::{acpi, c_str, device::Core, of, platform, prelude::*, types::A= Ref}; =20 struct SampleDriver { pdev: ARef, @@ -17,9 +17,78 @@ struct SampleDriver { [(of::DeviceId::new(c_str!("test,rust-device")), Info(42))] ); =20 +// ACPI match table test +// +// This demonstrates how to test an ACPI-based Rust platform driver using = QEMU +// with a custom SSDT. +// +// Steps: +// +// 1. **Create an SSDT source file** (`ssdt.dsl`) with the following conte= nt: +// +// ```asl +// DefinitionBlock ("", "SSDT", 2, "TEST", "VIRTACPI", 0x00000001) +// { +// Scope (\_SB) +// { +// Device (T432) +// { +// Name (_HID, "TEST4321") // ACPI hardware ID to match +// Name (_UID, 1) +// Name (_STA, 0x0F) // Device present, enabled +// Name (_CRS, ResourceTemplate () +// { +// Memory32Fixed (ReadWrite, 0xFED00000, 0x1000) +// }) +// } +// } +// } +// ``` +// +// 2. **Compile the table**: +// +// ```sh +// iasl -tc ssdt.dsl +// ``` +// +// This generates `ssdt.aml` +// +// 3. **Run QEMU** with the compiled AML file: +// +// ```sh +// qemu-system-x86_64 -m 512M \ +// -enable-kvm \ +// -kernel path/to/bzImage \ +// -append "root=3D/dev/sda console=3DttyS0" \ +// -hda rootfs.img \ +// -serial stdio \ +// -acpitable file=3Dssdt.aml +// ``` +// +// Requirements: +// - The `rust_driver_platform` must be present either: +// - built directly into the kernel (`bzImage`), or +// - available as a `.ko` file and loadable from `rootfs.img` +// +// 4. **Verify it worked** by checking `dmesg`: +// +// ``` +// rust_driver_platform TEST4321:00: Probed with info: '0'. +// ``` +// +// This demonstrates ACPI table matching using a custom ID in QEMU with a = minimal SSDT + +kernel::acpi_device_table!( + ACPI_TABLE, + MODULE_ACPI_TABLE, + ::IdInfo, + [(acpi::DeviceId::new(c_str!("TEST4321")), Info(0))] +); + impl platform::Driver for SampleDriver { type IdInfo =3D Info; const OF_ID_TABLE: Option> =3D Some(&OF_TABL= E); + const ACPI_ID_TABLE: Option> =3D Some(&ACP= I_TABLE); =20 fn probe( pdev: &platform::Device, --=20 2.43.0