From nobody Fri Oct 10 17:33:00 2025 Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A9462D8DB1; Thu, 12 Jun 2025 21:25:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749763504; cv=none; b=dWqZejOU+Vvq47RjJlh6gAN80Wc5Lf22k4EPUaJXUhZcEkdPJjp/ULf3LjFvX/dC7MKAElZ0W0eXwE8HSpAEa4sBZWOabdwPPcF9w64Pa9qkKq7MMTpgI4kkSR0s5HnlFy5bgfFoJcW+2H1OTacyZX1lJyC8qXIXnUtHceHerg4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749763504; c=relaxed/simple; bh=Kv8GpNW1i9evYXPkzz691+faP6WezKd/Ck4ruwoW1ms=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=A3Nkk1DikS2vKyH2UhgBbOLG3bK3oTS5GmNxLXIdh798HwVIeGw6icz7WIj7X92QQERoEaMY3KcOzHs3Y0kbtwplBGpP3G1fjUcBly1NpR9vrGxHUhhGjKMGqRY+rC7jZIX6sklu3L4sAng36C+fAItSIENvvn8lyyKYS4atHXk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 745D512023C; Thu, 12 Jun 2025 21:25:00 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: nevets@goodmis.org) by omf16.hostedemail.com (Postfix) with ESMTPA id C898620013; Thu, 12 Jun 2025 21:24:58 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1uPpRS-00000001tO2-3kT3; Thu, 12 Jun 2025 17:26:34 -0400 Message-ID: <20250612212634.746367055@goodmis.org> User-Agent: quilt/0.68 Date: Thu, 12 Jun 2025 17:24:06 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org Cc: Masami Hiramatsu , Mathieu Desnoyers , Andrew Morton , Carlos Maiolino , Christoph Hellwig , "Darrick J. Wong" Subject: [PATCH 01/14] xfs: tracing; Remove unused event xfs_reflink_cow_found References: <20250612212405.877692069@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Stat-Signature: u99ng4s9ctec46pi5c15k1ztqpzopjn8 X-Rspamd-Server: rspamout02 X-Rspamd-Queue-Id: C898620013 X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX1/z/u/69sk8lvHox7glHELK/KNw9BH+XY0= X-HE-Tag: 1749763498-158627 X-HE-Meta: U2FsdGVkX1/bN/RPUtxO0G/+1qNdyHRCWg398M5FK8FYggPLoL/wHC/USzHaE8Qde0XdUt1Gwfzwj7sdZpFVFg+EHwM/mtLJo+GcVngyqDFrntuBG7F6Sj1gpuMU9DjKuMyY8gca1BNV1qtZPvKDjFVCvyBS27YslGQfUq6GaeUo+5lsJ2wIQKJbaZFI6b9gKVyjVSjHnzZifxA0QVcpH2eEcyTQiT0byEhg9XlZ6zFIgITbCuPatX/1KfzUoRCNJ+vEATjj5VnoMZP1aKrsKacc2x8XuXrxfufEvYtqVF288/6RAdjfeA9qV/T8vnPYLbeQonrzyKQu17N1Te70QBB5bNHMqNdL6duQjmndMfKeGEbKx/e/T95UhcIb8kgO0XtHF++zrwCaFSCLRQXGRg== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt Each trace event can take up to around 5K of text and meta data regardless if they are used or not. With the restructuring of the XFS COW handling, the tracepoint trace_xfs_reflink_cow_found() was removed but the trace event was still being created. Remove the creation of that trace event. Fixes: db46e604adf8 ("xfs: merge COW handling into xfs_file_iomap_begin_del= ay") Signed-off-by: Steven Rostedt (Google) --- fs/xfs/xfs_trace.h | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index 01d284a1c759..ae0ed0dd0a01 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h @@ -4242,7 +4242,6 @@ DEFINE_INODE_ERROR_EVENT(xfs_reflink_unshare_error); =20 /* copy on write */ DEFINE_INODE_IREC_EVENT(xfs_reflink_trim_around_shared); -DEFINE_INODE_IREC_EVENT(xfs_reflink_cow_found); DEFINE_INODE_IREC_EVENT(xfs_reflink_cow_enospc); DEFINE_INODE_IREC_EVENT(xfs_reflink_convert_cow); =20 --=20 2.47.2 From nobody Fri Oct 10 17:33:00 2025 Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02B282D8DAE; Thu, 12 Jun 2025 21:25:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749763505; cv=none; b=utBWWSxQmIWlxki63008ecy33mnX4HoU0hr8kl2NN0SYtsHdtyvpyZ8weYX2+Vd9WRniGngw4ZN5pUq6R+LuiK1W88tAAKzq60F3CT6HUcDa5v2fyKI8NpJos2W6Jzh7+ZSxoDlNcDRGPkfHM/NyldX+mdBgEPS15wh4Uzj+9NM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749763505; c=relaxed/simple; bh=xmWp2AqhrRKFMvXkEIvtGR29GmRkNQtA5ZxOZ4AiOv8=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=rETlY/Vz3SgNHT1HU29miQzCw22MrbYpoUNNXNwcjkK0Vmk3n9fOqfNBPbEa8RZgfABUwKNuCROM4NXxCafJHVYE99abSLsLVjHQw/wSncTOlWCIrmzav2/b67Tj+Hby2W/zLfcvoVQHc4iys04jIpFyQL9UHzj7n7WAuduUpYc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6403D576ED; Thu, 12 Jun 2025 21:25:00 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: nevets@goodmis.org) by omf11.hostedemail.com (Postfix) with ESMTPA id C828A20029; Thu, 12 Jun 2025 21:24:58 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1uPpRT-00000001tOV-0ELB; Thu, 12 Jun 2025 17:26:35 -0400 Message-ID: <20250612212634.914730119@goodmis.org> User-Agent: quilt/0.68 Date: Thu, 12 Jun 2025 17:24:07 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org Cc: Masami Hiramatsu , Mathieu Desnoyers , Andrew Morton , Carlos Maiolino , Christoph Hellwig , "Darrick J. Wong" Subject: [PATCH 02/14] xfs: Remove unused trace event xfs_attr_remove_iter_return References: <20250612212405.877692069@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Rspamd-Server: rspamout03 X-Rspamd-Queue-Id: C828A20029 X-Stat-Signature: 9dccdcetd4piai7pgf9ws9f1qjy8ab6o X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX1/m6umyMGBbUBeuaqntx0trCsmwmvufSI4= X-HE-Tag: 1749763498-405258 X-HE-Meta: U2FsdGVkX1+39QocuuAXLXwEmrmg67AdqbEj4bi4NTgYS4A+2jqapoR+BuBwwfMiW83/ERBLWc6CaPkGHUdKkrTixbQAip9brOR2WCp03GycTSd1h7ArI/qKBhqWm0DVyPPfb+Qq/aaZgIKu/XoBs1LQkaBJVZQ0s/8gCqb6/mRyH0LcFt40RnXpNwfogwryb0wCyj/LqwsZaRw9V4kyjxc/fSysfZQegLm00+kXZ1vBZsITEbluc13bR1uL2O68Sgy8PfmBXxx0Rnzy6sfgs1MnWErRb3znQgSMaggmiZtZ4EMehA0iFC9D3TfJp1wYjIxnckpgNXIpyzumpNAEYa7wyc33M9yQwXMmwzKWobGNEUrwLzaYV6SxlEvqL2oSm3W+F/lCj/VkOn/OK+sFZw== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt When the function xfs_attri_remove_iter was removed, it did not remove the trace event that it called. As a trace event can take up to 5K of memory for text and meta data regardless of if it is used or not, remove this unused t= race event. Fixes: 59782a236b62 ("xfs: remove xfs_attri_remove_iter") Signed-off-by: Steven Rostedt (Google) Reviewed-by: Christoph Hellwig --- fs/xfs/xfs_trace.h | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index ae0ed0dd0a01..67bdcab9ff47 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h @@ -5076,7 +5076,6 @@ DEFINE_DAS_STATE_EVENT(xfs_attr_sf_addname_return); DEFINE_DAS_STATE_EVENT(xfs_attr_set_iter_return); DEFINE_DAS_STATE_EVENT(xfs_attr_leaf_addname_return); DEFINE_DAS_STATE_EVENT(xfs_attr_node_addname_return); -DEFINE_DAS_STATE_EVENT(xfs_attr_remove_iter_return); DEFINE_DAS_STATE_EVENT(xfs_attr_rmtval_alloc); DEFINE_DAS_STATE_EVENT(xfs_attr_rmtval_remove_return); DEFINE_DAS_STATE_EVENT(xfs_attr_defer_add); --=20 2.47.2 From nobody Fri Oct 10 17:33:00 2025 Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C2FE2D8DC4; Thu, 12 Jun 2025 21:25:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749763504; cv=none; b=sLZwnSC8YeahP2/Xlw0xHZ0967l/VbGDepHELGATNeEHZEt4mcKLFoLffFt9PweGPpguJKsQxkiex1+XQ6/iRFbmTxS5GEiBoI1lfP6TaOgIZ4q2Yc9C2qzb3hfY9/8fBJPGcMDDZMR+b6Ui/pRC29AfFIOWcP/PbLgu6GvU8go= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749763504; c=relaxed/simple; bh=sTjUFbUTnZj6r5VIFanu14zWxsRNcBHcaFhuwK3QYNw=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=e7cGxYspm/j1/gLNYjfLh7Es+257jbwBzbDY0dg0sd5FUZigppGRlef2T9B/qfqysM3fYW5etnvHhGLfFNuFQ2/pK0K41uLWnB+MPwYSc0KMRiNp4SUL4oeriw5yQBP6D/cYkzU0+5lMLueUs3ACSI9hHxE04Z0bx7mV5BRKV1U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7F1E91CE2E6; Thu, 12 Jun 2025 21:25:00 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: nevets@goodmis.org) by omf01.hostedemail.com (Postfix) with ESMTPA id DC95060009; Thu, 12 Jun 2025 21:24:58 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1uPpRT-00000001tP1-0v6w; Thu, 12 Jun 2025 17:26:35 -0400 Message-ID: <20250612212635.074800207@goodmis.org> User-Agent: quilt/0.68 Date: Thu, 12 Jun 2025 17:24:08 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org Cc: Masami Hiramatsu , Mathieu Desnoyers , Andrew Morton , Carlos Maiolino , Christoph Hellwig , "Darrick J. Wong" Subject: [PATCH 03/14] xfs: Remove unused event xlog_iclog_want_sync References: <20250612212405.877692069@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Stat-Signature: bm94qr67shj5y3zw5niwwfrppign4zqa X-Rspamd-Server: rspamout02 X-Rspamd-Queue-Id: DC95060009 X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX19WQ5TFx4lPmkyvFW7xtcYWehn3QuQamq0= X-HE-Tag: 1749763498-114303 X-HE-Meta: U2FsdGVkX1+QP1pRCP+sX55XLIdGKEpH7e1qaO1aaJW7/HH8yDjX+IObwx8dnxKO8zdph+acOvsscmsaSxI779jK8RQRRRE95g9mz1BroyuEbat1XULajBIlWYf1fbyi91SIqZtB5jVVN/4+oqu83eiB2laRzdjuosDpuEfYB0sSybjW5FLwXiKJhxZs1/ZYggEBp05aILjEUhLMFxSXbSwq0NfPAYzOYgSK+0K4A4VkQ4sD+wyIGrKYzVAAtDZgtm7xBSMLe5memiUTYmnWtEA/pkTwbFlG+AkSbhe2Wbexbmcq9mFUp2eBzSG6PkW3f0wPLhJiF3sbj5uQq5Uy6qo5DZ3I+onwEwuA9q+vArMeV86fmXgsdfedeIJACqVjHfxnJxXNifXu7EYhrvHGtA== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt The trace event xlog_iclog_want_sync was added but never used. As trace events can take up around 5K of memory in text and meta data regardless if they are used or not, remove this unused event. Fixes: 956f6daa84bf ("xfs: add iclog state trace events") Signed-off-by: Steven Rostedt (Google) --- fs/xfs/xfs_trace.h | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index 67bdcab9ff47..049bf9e34063 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h @@ -5027,7 +5027,6 @@ DEFINE_ICLOG_EVENT(xlog_iclog_switch); DEFINE_ICLOG_EVENT(xlog_iclog_sync); DEFINE_ICLOG_EVENT(xlog_iclog_syncing); DEFINE_ICLOG_EVENT(xlog_iclog_sync_done); -DEFINE_ICLOG_EVENT(xlog_iclog_want_sync); DEFINE_ICLOG_EVENT(xlog_iclog_wait_on); DEFINE_ICLOG_EVENT(xlog_iclog_write); =20 --=20 2.47.2 From nobody Fri Oct 10 17:33:00 2025 Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02AB92D8DA1; Thu, 12 Jun 2025 21:25:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749763503; cv=none; b=OQ7978/BTtAwEE6tCLKkha/FeUjntc4UKxQUec7Xq5B1LBBLMKmsqf2IdD3pkKlf1CgNf+u3TD/2AretD583yUTflPFmXPSCsy+yZ0e6ffK8uR9q3uCowA1Fc/0Hfg7hztTNlt8i9Tx5lnmDILGl40/CQBH9KV6owD/0rgtDHtc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749763503; c=relaxed/simple; bh=+VnxRD5xgKbSbKAayVo76MzO4o48C8v5QVinLZE+2NM=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=YA77KjwoE1k4w6yUA8GzVA9IDGCD00LFMEfx7hhFeu8njU9hf2cpyNJc2oePiNZrHyMIoVhLuiIIAWKgDKmTW5wkoUJj9JtYpBhpKT3csVHaH5sGeLUHSr0DbLqjjdr7zt52Pky648SALa2YtWDh8NuMn1tBoqChuH42n7g95sE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B5DE5B6D1A; Thu, 12 Jun 2025 21:25:00 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: nevets@goodmis.org) by omf12.hostedemail.com (Postfix) with ESMTPA id 19D6817; Thu, 12 Jun 2025 21:24:59 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1uPpRT-00000001tPV-1dpx; Thu, 12 Jun 2025 17:26:35 -0400 Message-ID: <20250612212635.247519894@goodmis.org> User-Agent: quilt/0.68 Date: Thu, 12 Jun 2025 17:24:09 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org Cc: Masami Hiramatsu , Mathieu Desnoyers , Andrew Morton , Carlos Maiolino , Christoph Hellwig , "Darrick J. Wong" Subject: [PATCH 04/14] xfs: Remove unused event xfs_ioctl_clone References: <20250612212405.877692069@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Rspamd-Queue-Id: 19D6817 X-Stat-Signature: kx8igcgjwy9gpbhui7ifb7upcfhgmnig X-Rspamd-Server: rspamout06 X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX19ue6BR7hXq+rMopguYaK4WKcIAj67jf8w= X-HE-Tag: 1749763499-217513 X-HE-Meta: U2FsdGVkX1+NcEH23Na+DHN4SSRC7qXmptdij8TmrSYUjrlbz7/3CCnAUcTCcp1V1+3ru9u3IULozNrp43vLUv+CSxAzp7g/A4tzaQSBhmiQd1fKNI6Igr3L19WKH/W5Xph5n0MLYq8sT1tEA9KRAQafB0U6kqGCGb0OTXFq3KOJk2FCqky0xG6SW5TbS+7C/1dm5F2kFjLFnx12/0PvSofd6bwpgr8h5exBUPKNrPiAL6Obg1gwWwg203NosqjPMgWqojsq0VZkMSj+xMT45HLcsjus8GyBquBgyaC56CXk9BtyyvWytR6BvTdFAk7mo3h+M1uSU9yeUvRftbs8sFTXTwz4r+i5+V1y1R1i6ubqhqyH6XOc0tloldL5wdP6khlRsoM3N7x6fg+l07ZF9A== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt The trace event xfs_ioctl_clone was added but never used. As trace events can take up to 5K of memory in text and meta data regardless if they are used or not, remove the unused trace event. Fixes: 53aa1c34f4eb ("xfs: define tracepoints for reflink activities") Signed-off-by: Steven Rostedt (Google) --- fs/xfs/xfs_trace.h | 26 -------------------------- 1 file changed, 26 deletions(-) diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index 049bf9e34063..ad686fe0a577 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h @@ -4210,32 +4210,6 @@ DEFINE_INODE_IREC_EVENT(xfs_reflink_remap_extent_des= t); DEFINE_DOUBLE_IO_EVENT(xfs_reflink_compare_extents); DEFINE_INODE_ERROR_EVENT(xfs_reflink_compare_extents_error); =20 -/* ioctl tracepoints */ -TRACE_EVENT(xfs_ioctl_clone, - TP_PROTO(struct inode *src, struct inode *dest), - TP_ARGS(src, dest), - TP_STRUCT__entry( - __field(dev_t, dev) - __field(unsigned long, src_ino) - __field(loff_t, src_isize) - __field(unsigned long, dest_ino) - __field(loff_t, dest_isize) - ), - TP_fast_assign( - __entry->dev =3D src->i_sb->s_dev; - __entry->src_ino =3D src->i_ino; - __entry->src_isize =3D i_size_read(src); - __entry->dest_ino =3D dest->i_ino; - __entry->dest_isize =3D i_size_read(dest); - ), - TP_printk("dev %d:%d ino 0x%lx isize 0x%llx -> ino 0x%lx isize 0x%llx", - MAJOR(__entry->dev), MINOR(__entry->dev), - __entry->src_ino, - __entry->src_isize, - __entry->dest_ino, - __entry->dest_isize) -); - /* unshare tracepoints */ DEFINE_SIMPLE_IO_EVENT(xfs_reflink_unshare); DEFINE_INODE_ERROR_EVENT(xfs_reflink_unshare_error); --=20 2.47.2 From nobody Fri Oct 10 17:33:00 2025 Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90B372D8DC5; Thu, 12 Jun 2025 21:25:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.14 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749763504; cv=none; b=Vr21f+GDGrikcRaTY+M3BfrUMFhU8pIXUs/hIARDNyvR1sEpnMs9PiR4gS9E6SC7P+SPj+dOXntDDxni8Si4DWwvPQ0OTxputEONAULKM2rXXKTsOr313lc3Vk4JjdftOr40YpK67mRIEwVYrn4EpfrGFKBaSCDLP2w+IrehB5w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749763504; c=relaxed/simple; bh=IJ78fjClEcTPz7L5WLA2FwSnFv3v0R2KlHOf4dlR5TQ=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=gI70oI7AW0WChVr4GUPEJRqgha4rbbwAACbLo3X0dRLPx2Yk6+AnU1EiC5tz9+DEHiW/OqX7oh+srCqG6NMaMUb1gV+fgZjjix+tcAIbZDdmxrtLxNgYGHJOq1/jo45UQUuagSkttgLEa7ee6PsfarS35pL5Bx/bUK891M4/VC0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E1ACF1CF094; Thu, 12 Jun 2025 21:25:00 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: nevets@goodmis.org) by omf02.hostedemail.com (Postfix) with ESMTPA id 3D5D180012; Thu, 12 Jun 2025 21:24:59 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1uPpRT-00000001tPz-2LNx; Thu, 12 Jun 2025 17:26:35 -0400 Message-ID: <20250612212635.411754637@goodmis.org> User-Agent: quilt/0.68 Date: Thu, 12 Jun 2025 17:24:10 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org Cc: Masami Hiramatsu , Mathieu Desnoyers , Andrew Morton , Carlos Maiolino , Christoph Hellwig , "Darrick J. Wong" Subject: [PATCH 05/14] xfs: Remove unused xfs_reflink_compare_extents events References: <20250612212405.877692069@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Stat-Signature: sgkdc7hi81b6j3nge8xc1qory3xrmey3 X-Rspamd-Server: rspamout04 X-Rspamd-Queue-Id: 3D5D180012 X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX19nDpZI/ee7iSofY8en9RmKM+4l953O1ao= X-HE-Tag: 1749763499-917816 X-HE-Meta: U2FsdGVkX19txEltUpPBpqHkjHOwNFv96fbMoIJjwPA18ONC84nLxPPWIs1jFa97vusRGzT8bATvSALu9/ITSkPybCQ6YfAiZH/U0We1cldBq+9tDnDBlJ05OnWu82cngOFCv48PG50awE/KkefnFZlMB7hbyIpG5x6jmPjWZIyek7I0/X48j8uHiFLpQMxOyRJ+lMWfgYsc5uMtmDC7onE6C8Wm28GqQ0uFFV7LfC+HKjv21duyvgydy2QOBS7CyRDCBBXPj6WcK4T9oV9thOOT4+9wDaBBggvBnh2fDMhYIja321ErbQAG7fCn4xBSbAWabECVRZE38YC7akyTK2QKM95W8y+i+R2kWbNwswKh6ws6wPnG85Etm5182h0G8Dxv1s2pc5yDKbQMp3XDVg== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt When the clone/dedupe_file_rang common functions were refactored, it removed the calls to the xfs_reflink_compare_extents and xfs_reflink_compare_extents_error events. As each event can take up to 5K in memory for text and meta data regardless if they are used or not, they should not be created if they are not used. Remove these unused events. Fixes: 876bec6f9bbf ("vfs: refactor clone/dedupe_file_range common function= s") Signed-off-by: Steven Rostedt (Google) --- fs/xfs/xfs_trace.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index ad686fe0a577..fe22f791de6e 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h @@ -4206,10 +4206,6 @@ DEFINE_INODE_ERROR_EVENT(xfs_reflink_remap_extent_er= ror); DEFINE_INODE_IREC_EVENT(xfs_reflink_remap_extent_src); DEFINE_INODE_IREC_EVENT(xfs_reflink_remap_extent_dest); =20 -/* dedupe tracepoints */ -DEFINE_DOUBLE_IO_EVENT(xfs_reflink_compare_extents); -DEFINE_INODE_ERROR_EVENT(xfs_reflink_compare_extents_error); - /* unshare tracepoints */ DEFINE_SIMPLE_IO_EVENT(xfs_reflink_unshare); DEFINE_INODE_ERROR_EVENT(xfs_reflink_unshare_error); --=20 2.47.2 From nobody Fri Oct 10 17:33:00 2025 Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADF732D8DD6; Thu, 12 Jun 2025 21:25:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749763504; cv=none; b=LS0qIvupMgrqu1h3NvXqW6N9CmL0C/FeuwuKJ9qmijeoUV72wJHZa2WbXFnDjCzvNU8fvCS+/Z0uInE0SLMe91n5KXSe5I2xoqb+F1819Vv01OAs1TfXkX6U/XD6/0gHh5HJ1l4svjfxzHo3W8zdkDPNcz2WX1SVOPDS7NF5IUQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749763504; c=relaxed/simple; bh=o2WvZF8/Wj9oS5PyPHIu/2Zv1oPNwLjyXdrg1kidN8I=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=is5SrhlacvjNde1O3wXVujGG9VXgzNvv+drhsogAybINe4L3M9GvuPR1A1T/tgBnnjXZrK/3XQvwwo5HcXA+qVS1Z4sHLP7bCvLpEL7NiPwz5C/PDPiO2UNNATx0ya96TCTDV2tLUwSz/z7wfp4ou6G82H35FqM2xRPU65EV7zU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 10BEC8020F; Thu, 12 Jun 2025 21:25:01 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: nevets@goodmis.org) by omf14.hostedemail.com (Postfix) with ESMTPA id 662232D; Thu, 12 Jun 2025 21:24:59 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1uPpRT-00000001tQU-33Xw; Thu, 12 Jun 2025 17:26:35 -0400 Message-ID: <20250612212635.579394128@goodmis.org> User-Agent: quilt/0.68 Date: Thu, 12 Jun 2025 17:24:11 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org Cc: Masami Hiramatsu , Mathieu Desnoyers , Andrew Morton , Carlos Maiolino , Christoph Hellwig , "Darrick J. Wong" Subject: [PATCH 06/14] xfs: Remove unused trace event xfs_attr_rmtval_set References: <20250612212405.877692069@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Rspamd-Server: rspamout03 X-Rspamd-Queue-Id: 662232D X-Stat-Signature: b36rgichgih6d7pw7rib4uoe553zzq6u X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX1/lS2S6zOc8c8WQzcQZWnqJVZ+11fBpSv0= X-HE-Tag: 1749763499-110801 X-HE-Meta: U2FsdGVkX19//A+Oqj6S60RE4zMlAbdDufoaeXQA1+JPbo0oiGL0sZgtZsNjGbqPgVcCKV8WYUezV56dAf0+myQjlU6aNgGOfWruNQdd7CyOHamajzNCnz+yZsd7OpEzbOLL0knTfNhDICrfa41n56giBulTZY8FdfVBIfTkfhLacae5d0e0sIzgNe6K2dyVfo4yPjBcHj9S0tnY8r8la1nKGv0Zz3fT482C5lX5tg1QFdE+t2pnkT7caO2998vs1oNbPaCkKD0BpB4xUvn1Ya/Egw0Ds228cuYGYP3ChPJeChvt6I28BsuImSJ6fCiGEKkomlgazpFurKeZ4pm5zKSwJ4UphOWIScrSuwUV3k7wWIpcDonxr/LeuzdV6pEFvs6sWYYWoH8B1SZ8Lh4MgQ== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt When the function xfs_attr_rmtval_set() was removed, the call to the corresponding trace event was also removed but the trace event itself was not. As trace events can take up to 5K of memory in text and meta data regardless if they are used or not they should not be created when not used. Remove the unused trace event. Fixes: 0e6acf29db6f ("xfs: Remove xfs_attr_rmtval_set") Signed-off-by: Steven Rostedt (Google) --- fs/xfs/xfs_trace.h | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index fe22f791de6e..cdc639198bb9 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h @@ -2471,7 +2471,6 @@ DEFINE_ATTR_EVENT(xfs_attr_fillstate); DEFINE_ATTR_EVENT(xfs_attr_refillstate); =20 DEFINE_ATTR_EVENT(xfs_attr_rmtval_get); -DEFINE_ATTR_EVENT(xfs_attr_rmtval_set); =20 #define DEFINE_DA_EVENT(name) \ DEFINE_EVENT(xfs_da_class, name, \ --=20 2.47.2 From nobody Fri Oct 10 17:33:00 2025 Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C76F62D8DDF; Thu, 12 Jun 2025 21:25:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749763504; cv=none; b=kABnKZnM7/8wqgGk8SKN+be25sYP6DVPRfVXiNKfGX0/oWP+BWYxPpbih/gvCW0sEgqrOEa6Inb3yhWc5zqTlmPy3nMi2CElM724JBTwukaWQ+b072AMFwXDa2ydczw9A7O+xvwM95Y3TLygQPUsqbVRA3HeIkUAHeWjxm3EHUE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749763504; c=relaxed/simple; bh=4l3kvVo4cfZ3K+FLvtLpoePJnS6GtWwUUo0+jAAGrMQ=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=kLThxcoX/w+U8dkokpihqBMbKe1OWy++YsDdmR3ALybJfqPKFb1Pm0qP4wklUgfOgyYyIbcfJprLDIrCZt4HmsqRYooPATbb4jHqMKpHaNaPUIPf0A9JeGX4yjEUHbRZ+lq8v1SyswF039HWVb1P09r6gl36hqt76JYUPM6V0j8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 332875797F; Thu, 12 Jun 2025 21:25:01 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: nevets@goodmis.org) by omf01.hostedemail.com (Postfix) with ESMTPA id 78DC36000F; Thu, 12 Jun 2025 21:24:59 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1uPpRT-00000001tQz-3lDh; Thu, 12 Jun 2025 17:26:35 -0400 Message-ID: <20250612212635.748779142@goodmis.org> User-Agent: quilt/0.68 Date: Thu, 12 Jun 2025 17:24:12 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org Cc: Masami Hiramatsu , Mathieu Desnoyers , Andrew Morton , Carlos Maiolino , Christoph Hellwig , "Darrick J. Wong" Subject: [PATCH 07/14] xfs: ifdef out unused xfs_attr events References: <20250612212405.877692069@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Rspamd-Queue-Id: 78DC36000F X-Stat-Signature: 1utj44zzuw5br316xpcfjk5zcjm6ch3b X-Rspamd-Server: rspamout05 X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX1+70v1B4gCQRQSAQWGzzZ3vC3aBvg7avbk= X-HE-Tag: 1749763499-862500 X-HE-Meta: U2FsdGVkX1/1hnysNfa5zsbZin82bbtuFgMe7yngO5DHHkHezDEa50Hhcj1J4MXCc+mCvuWRtLriMc08/AwYX7eQMXw5lmOSsEdhrjmCxJnxldNR0EAQjnHhenGvsI91xOrtXAG/IbBQLnfUe7g6uR0U8+wi/oJJ7xBTmXWB8lFozZOQfUL/gmXFtI/e/9sHeoTpD+n1AcknKKjLK+VgaDg99Xx8lOxbNMal0Y3Gcg/lBlNIjDczXqDGjaY4gmAtUjDzmbey04PbW70IZk9amFRiwhZt+MC5M6puZmXaIGxvaFQFq34XqETB13Nk71NyhD0p1D0vCTvoIMiBIgsl9NeILxuHNkI3OLj9M6Tm7+6F5cv+PBa0Ihy4ICjBpZ4LCjzm/kKv3tdnrwIvVFUWGQ== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt Trace events can take up to 5K in memory for text and meta data per event regardless if they are used or not, so they should not be defined when not used. The events xfs_attr_fillstate and xfs_attr_refillstate are only called in code that is #ifdef out and exists only for future reference. Ifdef out the events that go with that code and add a comment mentioning the other code. Fixes: 59782a236b622 ("xfs: remove xfs_attri_remove_iter") Signed-off-by: Steven Rostedt (Google) --- fs/xfs/xfs_trace.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index cdc639198bb9..bd4e5a727b73 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h @@ -2467,8 +2467,14 @@ DEFINE_ATTR_EVENT(xfs_attr_node_get); DEFINE_ATTR_EVENT(xfs_attr_node_replace); DEFINE_ATTR_EVENT(xfs_attr_node_removename); =20 +/* + * When the corresponding code in xfs_attr.c is re-enabled + * then so can these trace events. + */ +#if 0 DEFINE_ATTR_EVENT(xfs_attr_fillstate); DEFINE_ATTR_EVENT(xfs_attr_refillstate); +#endif =20 DEFINE_ATTR_EVENT(xfs_attr_rmtval_get); =20 --=20 2.47.2 From nobody Fri Oct 10 17:33:00 2025 Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 603A02DCBE4; Thu, 12 Jun 2025 21:25:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749763505; cv=none; b=sdu1T2tXVHtoGisUkVaOIM/avEV/oFkMFAO3He4doq6Tmdwfu8Fr69FdTAQ5VXZFpfFshsqAujECI3IPbmNC04smPgIE8AA8uCvcuR7OQ/Wy2Sc9/dT5fUjTxc+GGOTM4Jw2e5Vd508k4rx6v5hZmPVbnDJZpIjtIQovv/NqfkQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749763505; c=relaxed/simple; bh=zRnYHNw1IkZxk/dBgC0osXHFs/qpnb5lqXbr0izsgqE=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=EJZ5mjlVtYG2yxO9Od/SYTbpYghruf/cZaeNPu+3dgKa/0KzuE61NPkrUcjmOlgltW7kazdtcjzVHLSd7ud1KcOA9qnsrQgnCm6N3/QGcgAobmksLr7pI7tb87kr7j/iAEpFo9NI3w5uLXpwCYr6oawiHVeQe9j/E/rNCtXDRAQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5DD1412023A; Thu, 12 Jun 2025 21:25:01 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: nevets@goodmis.org) by omf04.hostedemail.com (Postfix) with ESMTPA id B859920023; Thu, 12 Jun 2025 21:24:59 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1uPpRU-00000001tRT-0FV6; Thu, 12 Jun 2025 17:26:36 -0400 Message-ID: <20250612212635.916651164@goodmis.org> User-Agent: quilt/0.68 Date: Thu, 12 Jun 2025 17:24:13 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org Cc: Masami Hiramatsu , Mathieu Desnoyers , Andrew Morton , Carlos Maiolino , Christoph Hellwig , "Darrick J. Wong" Subject: [PATCH 08/14] xfs: Remove unused event xfs_attr_node_removename References: <20250612212405.877692069@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Stat-Signature: 5m1a4pwrf6tfcigetmrakcdqarri9u1w X-Rspamd-Server: rspamout04 X-Rspamd-Queue-Id: B859920023 X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX18OIw2FF8TdDdPXyr4KM5DiiLb9E2yrGwc= X-HE-Tag: 1749763499-341034 X-HE-Meta: U2FsdGVkX180+/Ybqn2q8J6nsyJy0JJb4oN6BzAf+TBUsnro2JryN/aMq4vdUrSUL4SCcoqCutZe2adrqA9pO6UOzuKI2EpiifHS1KKLd0Dk6rOeelXiqesMaPPbsSEMpj8UE8Ml6wKQJzsCI7bWVWPvD/87Y6GGb9uXGaXLonvKKUK4Ic61Yn4S4XyRWcfu21Sa66OQBcY/YdZrjPeBvDI99GyQjtpN65jDaVsXf/svE2rP9LEdCj218OpRak7zwW92fig0oBV9j8w7BiKrn1SsQqhGiBm9OiWCWfmhaYI3y2cFZ7KgudK2BFct+Xqlyyr87Wb+/XEyYUnF4d8wkEdBAnaWx1FQY+bdo8FTkFMS4d97PpVCw4krgnvh99QY49MTcEQTVs7oZAeYK47d6Q== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt When xfs_attri_remove_iter() was removed, so was the call to the trace event xfs_attr_node_removename. As trace events can take up to 5K in memory for text and meta data regardless if they are used or not, they should not be created when unused. Remove the unused event. Fixes: 59782a236b622 ("xfs: remove xfs_attri_remove_iter") Signed-off-by: Steven Rostedt (Google) --- fs/xfs/xfs_trace.h | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index bd4e5a727b73..3c15282b2a8a 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h @@ -2465,7 +2465,6 @@ DEFINE_ATTR_EVENT(xfs_attr_leaf_toosmall); DEFINE_ATTR_EVENT(xfs_attr_node_addname); DEFINE_ATTR_EVENT(xfs_attr_node_get); DEFINE_ATTR_EVENT(xfs_attr_node_replace); -DEFINE_ATTR_EVENT(xfs_attr_node_removename); =20 /* * When the corresponding code in xfs_attr.c is re-enabled --=20 2.47.2 From nobody Fri Oct 10 17:33:00 2025 Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E74629B227; Thu, 12 Jun 2025 21:25:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749763505; cv=none; b=P+HldpyijcwRLWSyi6Miby5KqKq0yOdWTExUpUHpzvQ4YG/iS/lKy/Au9gjU4cBNc90zUsg0X9aN3sUquWr19pg3Gu8mr1IZgW/gDTCe5rxLOo8nWv7FMzWj8CSTG1GLgAm8R/vGr9bHJAbTWKOM2DAcjC89x+SFKfmUYLW6PkY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749763505; c=relaxed/simple; bh=R6GDH+pi/TisbmmlM1tiP9Ycm3BzPweSXNUekosIhWY=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=poTWTGuiVyBVArkkRpvvveXlZqTT/h2Z6aFlaPzu4fxgYf0zLzmXVvGJnEM5cjrQ5wI8WMk5bKRHp3Uak6MccwT2HfErfq5htb1VLwR5ulG204wYN8IIsuBH7nO6y5+NCsGdft8gDlVbppg4opfZPLYyFlWpoC4kMVxe/5NePlI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7239AC018D; Thu, 12 Jun 2025 21:25:01 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: nevets@goodmis.org) by omf15.hostedemail.com (Postfix) with ESMTPA id BFCBC17; Thu, 12 Jun 2025 21:24:59 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1uPpRU-00000001tRx-0ySj; Thu, 12 Jun 2025 17:26:36 -0400 Message-ID: <20250612212636.080305835@goodmis.org> User-Agent: quilt/0.68 Date: Thu, 12 Jun 2025 17:24:14 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org Cc: Masami Hiramatsu , Mathieu Desnoyers , Andrew Morton , Carlos Maiolino , Christoph Hellwig , "Darrick J. Wong" Subject: [PATCH 09/14] xfs: Remove unused event xfs_alloc_near_error References: <20250612212405.877692069@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Rspamd-Server: rspamout03 X-Rspamd-Queue-Id: BFCBC17 X-Stat-Signature: ze8ij1s4gbrm18ajk6destqyspmp1s3y X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX1/76CYWaDEPaZq/fnOJc1E46idQL/K51hg= X-HE-Tag: 1749763499-949767 X-HE-Meta: U2FsdGVkX1/h0PsnFAhUIB6OuHqyBecE2q+w3FXEHtSeX8H57hw+FS1mDWMsATw7n+TCD5kZyntCSlF5kDkCMFDmao5e7Oxd8WUJ8h36s1QfGPgLFL9+U6deZwFJHVv6eRb4u1PteUj8Zzvgf3myDjmuS0J98ZwT9DscpxclULYZo4dFhQrzT1yDxIdCkBsszwYXg8ADl5tpNtOBFSMXnc8s8oOTlSfCVPAwaNuVoX9B94ZZC47q/kgYieClDFkoVF9AYNMo4rQkZ3GwqczUhBgcAIJlwjU4+UsYPHJsyLYR8oBv0PrMvT4H7GtDGeTu5oAi+U/p1zHMpDXETYBD4LoMIY/2N8I+DEBSzxWFHnvLGC7PB76YCLpGtYYqlhR9mplvq0hN/riNjVYtd1y1VA== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt Trace events take up to 5K of memory in text and meta data regardless if they are used or not. The call to the event xfs_alloc_near_error was removed when the cursor data structure allocation was introduced. Remove it as it is no longer used and is just wasting memory. Fixes: f5e7dbea1e3e ("xfs: introduce allocation cursor data structure") Signed-off-by: Steven Rostedt (Google) --- fs/xfs/xfs_trace.h | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index 3c15282b2a8a..6ec483341bc4 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h @@ -2270,7 +2270,6 @@ DEFINE_ALLOC_EVENT(xfs_alloc_cur_right); DEFINE_ALLOC_EVENT(xfs_alloc_cur_left); DEFINE_ALLOC_EVENT(xfs_alloc_cur_lookup); DEFINE_ALLOC_EVENT(xfs_alloc_cur_lookup_done); -DEFINE_ALLOC_EVENT(xfs_alloc_near_error); DEFINE_ALLOC_EVENT(xfs_alloc_near_noentry); DEFINE_ALLOC_EVENT(xfs_alloc_near_busy); DEFINE_ALLOC_EVENT(xfs_alloc_size_neither); --=20 2.47.2 From nobody Fri Oct 10 17:33:00 2025 Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E7A52DCBE2; Thu, 12 Jun 2025 21:25:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749763505; cv=none; b=Xo1pWKxB8GAuhtOm3wkUk1kAi0DrmxQPSDUYM8AnSf6cABun8cfTD2hwMmEYWfvqkAlBFq2o6pdgqBoeE4yu/1QxxQqyWQpSuXETaFMAcmmHOCMC5fL/SoRBIiRDWrPC+5LNckD2oaLhLRJ9kvCU0/fpePn+A7ofbCCJBGM3bg4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749763505; c=relaxed/simple; bh=Hj5p80U0BlS67DfChc9EawelY7e03EBTEBWaAhRRYE8=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=Iy0KEVsq3pA7eor9G+8yIqIfeBLPv0IZwKuMVEsQJxx7x1zT3RQGFvKPk3AxZXL2Xd91wKsl0lDzs+EY8P40OrpN2nVt5ryHg6rYo4LD9hRTS68w0PwFMC2wnwMrYopnh0YSCRXSPYaQNyTim2zh1hx4mzY55tVgCeh4V318mwE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A1FB7140119; Thu, 12 Jun 2025 21:25:01 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: nevets@goodmis.org) by omf15.hostedemail.com (Postfix) with ESMTPA id E682718; Thu, 12 Jun 2025 21:24:59 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1uPpRU-00000001tSS-1gQD; Thu, 12 Jun 2025 17:26:36 -0400 Message-ID: <20250612212636.252544787@goodmis.org> User-Agent: quilt/0.68 Date: Thu, 12 Jun 2025 17:24:15 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org Cc: Masami Hiramatsu , Mathieu Desnoyers , Andrew Morton , Carlos Maiolino , Christoph Hellwig , "Darrick J. Wong" Subject: [PATCH 10/14] xfs: Remove unused event xfs_alloc_near_nominleft References: <20250612212405.877692069@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Stat-Signature: boocakeqhbte66cnjdanun73458yd44i X-Rspamd-Server: rspamout04 X-Rspamd-Queue-Id: E682718 X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX18V/YH0dZYiTbPkq/nW6ZnltEr6uk4VF04= X-HE-Tag: 1749763499-323208 X-HE-Meta: U2FsdGVkX1/0YKQ1caPnnqHOizesHT+WHJsXxpGH92zaw/rZaxkNicSm7SEe1Xv97AIBai5lbTs7f6DhV4vUyySXfGOzjct7phR+NI3qLUm3tdPj70ag1HzIM/hYBV8v5uxsT8PuaJJI6EtA4OMAbqrbE8rijwrJlsDFiU0M/HVYm7XI553Z9y0OSv9uNAWADqRmvNZeDZlPVk0TAGWybJ957mz3sMnNRPlUsMOLcukGvcj0+lfyU9GIF/9NBcsfxFaLX0BaYt4eNVCwbDaejpOi9LmCr5RXc4bmSxdUHN31egs63U7RlwXwUToLKZ56rRYOVmB6KMm2pIUB/7EkfbjntdfVNPPLa2GEdqW2jwMJ91ImkVY3TZfKwL+YwY6FKaSBPx/rc+diSz7yei3+Bg== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt When the function xfs_alloc_space_available() was restructured, it removed the only calls to the trace event xfs_alloc_near_nominleft. As trace events take up to 5K of memory for text and meta data for each event, they should not be created when not used. Remove this unused event. Fixes: 54fee133ad59 ("xfs: adjust allocation length in xfs_alloc_space_avai= lable") Signed-off-by: Steven Rostedt (Google) --- fs/xfs/xfs_trace.h | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index 6ec483341bc4..277402801394 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h @@ -2263,7 +2263,6 @@ DEFINE_EVENT(xfs_alloc_class, name, \ DEFINE_ALLOC_EVENT(xfs_alloc_exact_done); DEFINE_ALLOC_EVENT(xfs_alloc_exact_notfound); DEFINE_ALLOC_EVENT(xfs_alloc_exact_error); -DEFINE_ALLOC_EVENT(xfs_alloc_near_nominleft); DEFINE_ALLOC_EVENT(xfs_alloc_near_first); DEFINE_ALLOC_EVENT(xfs_alloc_cur); DEFINE_ALLOC_EVENT(xfs_alloc_cur_right); --=20 2.47.2 From nobody Fri Oct 10 17:33:00 2025 Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 552FE2D4B7A; Thu, 12 Jun 2025 21:25:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749763506; cv=none; b=VCi+Fm4IBTDtyBb1AX+5cs2ugpRsfwnuifiSiLrgeFyCmeRPYYOtQeCJCMNnykvRWfKGnSRNHtiLsyFcPBSRQ/p9Qmyx4tArLty+9gQgnuV/LT22gtY6O9jr9y0lo96VQffMnDTpXXlwvZZRSUd1sXh5gD5ULHLJ+L3dO7ywbjo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749763506; c=relaxed/simple; bh=HuMjZINpKSUcmI84cW4j+vLlDWcteElTKOayabQOjQY=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=QClrcU0IEdV6PKgzZ6TwJXRhsNv9UclJvx1BEsWnAkmywPB3PcniMM5fyzAngCM8sGkuiLyyFCUfOxOJiUG1mQ1hgdpN+LyNx0NBh7xk1CiA8TUfqPigWHGOmufuoeXOH6odzzaaOj0pnqr3fVhlSlWQTpRoCT4aLZp1jLofsoI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 24740120242; Thu, 12 Jun 2025 21:25:02 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: nevets@goodmis.org) by omf06.hostedemail.com (Postfix) with ESMTPA id 43A8220010; Thu, 12 Jun 2025 21:25:00 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1uPpRU-00000001tSw-2Pc2; Thu, 12 Jun 2025 17:26:36 -0400 Message-ID: <20250612212636.430882263@goodmis.org> User-Agent: quilt/0.68 Date: Thu, 12 Jun 2025 17:24:16 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org Cc: Masami Hiramatsu , Mathieu Desnoyers , Andrew Morton , Carlos Maiolino , Christoph Hellwig , "Darrick J. Wong" Subject: [PATCH 11/14] xfs: Remove unused event xfs_pagecache_inval References: <20250612212405.877692069@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Stat-Signature: u9qzqba3sbjuss5rnceuh3fo6gok7das X-Rspamd-Server: rspamout04 X-Rspamd-Queue-Id: 43A8220010 X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX19FFybcoQc1IEhFothZu6rsSnE/QAd4I/U= X-HE-Tag: 1749763500-295858 X-HE-Meta: U2FsdGVkX1/j5UlrzR+HDEpRPi6KS7T4Ux1FzgznzSfyAYaaxe2IbU60ruu+rJ2SvfXxQ8XmQ3LE0Rc6+XRuoLFG2kAdiwchKTUmviC9MEdxcZrWfOu+7BBkTS9vVFiF9898NdTt6v9LFIgdsMg0LJK16ReU9Gk6S+FK7MhWMHRkhNY6cNB5F04jFqvf72TgJyTMRj7966xIgretl0rpgrM8i47XcnjcGm+XfRpky4Le2AsoIjdizg0DFCRSECrYNDm5PXBEDcArriviLzx72M9LNyLAsOahxUDoD6AHB9Snl4QPYepIXv1DPjOooaWQzfPmuDLZ0WAsVT8lMitKm15eqzduyKNmGlmyctPy90uu+b9NVAZ0k05XjgaHDFhlMgyoe1Nhsvb/zxGNTc6b/w== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt When the function xfs_flushinval_pages() was removed, it removed the only caller to the trace event xfs_pagecache_inval. As trace events can take up to 5K of memory in text and meta data each regardless if they are used or not, they should not be created when unused. Remove the unused event. Fixes: fb59581404ab ("xfs: remove xfs_flushinval_pages") Signed-off-by: Steven Rostedt (Google) --- fs/xfs/xfs_trace.h | 25 ------------------------- 1 file changed, 25 deletions(-) diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index 277402801394..ee21ce3651a5 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h @@ -1893,31 +1893,6 @@ DEFINE_EVENT(xfs_itrunc_class, name, \ DEFINE_ITRUNC_EVENT(xfs_itruncate_extents_start); DEFINE_ITRUNC_EVENT(xfs_itruncate_extents_end); =20 -TRACE_EVENT(xfs_pagecache_inval, - TP_PROTO(struct xfs_inode *ip, xfs_off_t start, xfs_off_t finish), - TP_ARGS(ip, start, finish), - TP_STRUCT__entry( - __field(dev_t, dev) - __field(xfs_ino_t, ino) - __field(xfs_fsize_t, size) - __field(xfs_off_t, start) - __field(xfs_off_t, finish) - ), - TP_fast_assign( - __entry->dev =3D VFS_I(ip)->i_sb->s_dev; - __entry->ino =3D ip->i_ino; - __entry->size =3D ip->i_disk_size; - __entry->start =3D start; - __entry->finish =3D finish; - ), - TP_printk("dev %d:%d ino 0x%llx disize 0x%llx start 0x%llx finish 0x%llx", - MAJOR(__entry->dev), MINOR(__entry->dev), - __entry->ino, - __entry->size, - __entry->start, - __entry->finish) -); - TRACE_EVENT(xfs_bunmap, TP_PROTO(struct xfs_inode *ip, xfs_fileoff_t fileoff, xfs_filblks_t len, int flags, unsigned long caller_ip), --=20 2.47.2 From nobody Fri Oct 10 17:33:00 2025 Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D126E2D4B58; Thu, 12 Jun 2025 21:25:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749763505; cv=none; b=nbrhmmxZEIf9xm3kbFue9E4Z4JXyO1FejhW0hxDkBwt0rRImpJQnVZlWzBL1Ozk5aawYMsilTyHp+AYvLEQgdgw+fG8pN9FXSPa0VFXAnes+pH4z0FcQC+NvxK4tAN4m03f8fjrmfWS1l7tNTEHRr7K9tpxhE/mmKCtqG0Xn4dM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749763505; c=relaxed/simple; bh=5npKsJuDpglGznd2LvzyObZv4jx5kLIPSqQk5d9O3YY=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=ByteI5Noby+5rhklNYlwKNsHZKonxV5OLxzOqRa8SMTylra85CLhm28kadLq/kPVD6NG6wGYP8a6roDI6PmSpw0Vw6ABXGnux6j1F0Naz6zAsoF3G0eqVdcciDY8bGIGIvlYEjJ064jcU0I3KuUlIVSEkRfL3hzBkuT8Y8srLxc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 096AA160239; Thu, 12 Jun 2025 21:25:01 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: nevets@goodmis.org) by omf20.hostedemail.com (Postfix) with ESMTPA id 7149820027; Thu, 12 Jun 2025 21:25:00 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1uPpRU-00000001tTQ-37hZ; Thu, 12 Jun 2025 17:26:36 -0400 Message-ID: <20250612212636.596101735@goodmis.org> User-Agent: quilt/0.68 Date: Thu, 12 Jun 2025 17:24:17 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org Cc: Masami Hiramatsu , Mathieu Desnoyers , Andrew Morton , Carlos Maiolino , Christoph Hellwig , "Darrick J. Wong" Subject: [PATCH 12/14] xfs: Remove usused xfs_end_io_direct events References: <20250612212405.877692069@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Rspamd-Queue-Id: 7149820027 X-Stat-Signature: 4dncrjmp9j41jtw1ejbhy85o477bn94z X-Rspamd-Server: rspamout05 X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX1/RLTYgODuJnPrO2+ZqLM0v9CLzieCE59k= X-HE-Tag: 1749763500-989544 X-HE-Meta: U2FsdGVkX18C+Qqh/OKuc8PhP+RerXeFA+TAPO168llKMLLnqTgmg7OdHZ1vgElrI1E/LUwQLB6SJoGi9vY29Zj72tMzlfzHdTSHUfPvNli5Lbt/Hgmh9p7xz65UNB2lrniY56ncw4bgFVCz5+RQy1+zSzgOdQ09zlXBrCXxnJBebx2ne2Hv7gt9MJkavq/6Ou2tIow41XTxkH758J8NhHvSAQBIiessNOi/KPO3yzF+0bCpEg19bmFW1Nf//PK20SaCLrbW+vl7fsz5tzghIDD5KA6TQc91c8iuAAs+bqE0kxy/oRSb8VQhxDORbFjPG0Q1GEaA9IsFuux9So79O6YDJyd9kqcFtuqLuK0R6gnVAypelTI6yoWVifl77TW/21xrEPTJAiCcLecStG8+/Q== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt When the use of iomap_dio_rw was added, the calls to the trace events xfs_end_io_direct_unwritten and xfs_end_io_direct_append were removed but those trace events were not. As trace events can take up to 5K in memory for text and meta data regardless if they are used or not, they should not be created when not used. Remove the unused events. Fixes: acdda3aae146 ("xfs: use iomap_dio_rw") Signed-off-by: Steven Rostedt (Google) --- fs/xfs/xfs_trace.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index ee21ce3651a5..83d4ef8386a1 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h @@ -1859,8 +1859,6 @@ DEFINE_SIMPLE_IO_EVENT(xfs_unwritten_convert); DEFINE_SIMPLE_IO_EVENT(xfs_setfilesize); DEFINE_SIMPLE_IO_EVENT(xfs_zero_eof); DEFINE_SIMPLE_IO_EVENT(xfs_end_io_direct_write); -DEFINE_SIMPLE_IO_EVENT(xfs_end_io_direct_write_unwritten); -DEFINE_SIMPLE_IO_EVENT(xfs_end_io_direct_write_append); DEFINE_SIMPLE_IO_EVENT(xfs_file_splice_read); DEFINE_SIMPLE_IO_EVENT(xfs_zoned_map_blocks); =20 --=20 2.47.2 From nobody Fri Oct 10 17:33:00 2025 Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91C6D2D0292; Thu, 12 Jun 2025 21:25:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.14 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749763505; cv=none; b=XKDHvayYWP4DceOca+s/bebvVe99i7AdhRTX9zpEoKziU/mdaanS6W66+c7A89uWxcyeIqUBcoY2eP2kpjOp8BK+OM2SaHL2g5gBioCBqvgwoaIyCgv1a9QV8dQngt/UitJ4GuT5QD/rd2rdbw/YBBbkvBb8pmLUFSmGj8zQniY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749763505; c=relaxed/simple; bh=v1sG8BmYEnPIfc5CTC+a/SlCTBrRKoIo4CT6uG6u9ws=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=Qjs/o0WBCYWmby4fhPCbtkTYV9D3RALjv9ZJz9v5WJKRpvyWu/gJs9cfS3OEgNZKCvdNZETTM8pDQ1t7mJkGKNllRvYl3W7Va7Zmdh3aZ9kpm2TFpXKXnCvjIuE4FCY8+O+wyLT+BmcU+BcMysAt2LErjZfwjFJ37ocLczapIPI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 16DFCB7528; Thu, 12 Jun 2025 21:25:02 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: nevets@goodmis.org) by omf11.hostedemail.com (Postfix) with ESMTPA id 784462002A; Thu, 12 Jun 2025 21:25:00 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1uPpRU-00000001tTu-3pN5; Thu, 12 Jun 2025 17:26:36 -0400 Message-ID: <20250612212636.765270044@goodmis.org> User-Agent: quilt/0.68 Date: Thu, 12 Jun 2025 17:24:18 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org Cc: Masami Hiramatsu , Mathieu Desnoyers , Andrew Morton , Carlos Maiolino , Christoph Hellwig , "Darrick J. Wong" Subject: [PATCH 13/14] xfs: Only create event xfs_file_compat_ioctl when CONFIG_COMPAT is configure References: <20250612212405.877692069@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Stat-Signature: gjwhakpb6ai165ws88afyxaa6w8ueg5g X-Rspamd-Server: rspamout02 X-Rspamd-Queue-Id: 784462002A X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX19u1AuwmCiKQZCNpszhinM9Y4P5VefYxXI= X-HE-Tag: 1749763500-923667 X-HE-Meta: U2FsdGVkX18BqC2LRgKV3GdOVtsHGlmwrTw9HOFrtXZgn1IbSXt/+DqtSGZ1VfQhfXJPn7IOtbgbPMjk2S3n4pzrL9FmZhZdoG6Q8a8Xse3zvbE78VTRRi/+VMxCM/Nf4lyTe78RgDcG7erVUd7QaikRdy66tMZACK6rbBhBo0mswkcwMr6n+JS8jm8FN05ku4VkdOTIdyQvyFpcyYTgIJGhZDcbdXF2if1hD0coh1Qnm75KuA+J5X/H+IRzyi8YY551ItOIr5dzngtRvR6szh69dKk1a2c2QBJZe9lMfH0HLmqrBi9Na4FE89ZSd1FJXz/q74jU8anrassN5R8vZqJSCRMQ/joeIHBwH+TJuL0IOfNUp1lWHZCjDS69YJJCC9AK94nZ/N2Au3oIASgr7Q== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt The trace event xfs_file_compat_ioctl is only used when CONFIG_COMPAT is configured in the build. As trace events can take up to 5K in memory for text and meta data regardless if they are used, they should not be created when unused. Add #ifdef CONFIG_COMPAT around the event so that it is only created when that is configured. Fixes: cca28fb83d9e6 ("xfs: split xfs_itrace_entry") Signed-off-by: Steven Rostedt (Google) --- fs/xfs/xfs_trace.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index 83d4ef8386a1..76928583549a 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h @@ -1083,7 +1083,9 @@ DEFINE_INODE_EVENT(xfs_get_acl); #endif DEFINE_INODE_EVENT(xfs_vm_bmap); DEFINE_INODE_EVENT(xfs_file_ioctl); +#ifdef CONFIG_COMPAT DEFINE_INODE_EVENT(xfs_file_compat_ioctl); +#endif DEFINE_INODE_EVENT(xfs_ioctl_setattr); DEFINE_INODE_EVENT(xfs_dir_fsync); DEFINE_INODE_EVENT(xfs_file_fsync); --=20 2.47.2 From nobody Fri Oct 10 17:33:00 2025 Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C5A32DCC12; Thu, 12 Jun 2025 21:25:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.11 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749763506; cv=none; b=cM3puxVNDIZ3xIvl8F8u1tjqk1AO6kz+JtqaFZxmdWz0uBcHJK7EaIPbWGc9UeVK7XTqG9IMX383LJde7JZIMamyjUWyJyd34l5nILZDYZYKcq5BpJoW5hxjj8J8CsmiMKuvEhfwo3FbMPS06nVesOVrvABr6vsCNs3/UQdy3Ok= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749763506; c=relaxed/simple; bh=w6Uo262VhjHbfeaV/nb5W81D7WAIexobDSw1kv1idQo=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=qo5dL6DR7bwYc0SOu1lYdarAt/M8x0RbUfgwmsxFM/i1V7cILPKY+/VLH/Txwj1ryMgwz7Cs4RTzXZs3yJBGenUt+X+LBvLA8xOvLiW1x3csY2AfcbsD/BMyZgl8692vrur5Op7Fo47PLsG9HEGfRreZlmug2eSsTATHpEIh6Wg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 50DFD57998; Thu, 12 Jun 2025 21:25:02 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: nevets@goodmis.org) by omf11.hostedemail.com (Postfix) with ESMTPA id A10E22002C; Thu, 12 Jun 2025 21:25:00 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1uPpRV-00000001tUO-0K7r; Thu, 12 Jun 2025 17:26:37 -0400 Message-ID: <20250612212636.933500763@goodmis.org> User-Agent: quilt/0.68 Date: Thu, 12 Jun 2025 17:24:19 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org Cc: Masami Hiramatsu , Mathieu Desnoyers , Andrew Morton , Carlos Maiolino , Christoph Hellwig , "Darrick J. Wong" Subject: [PATCH 14/14] xfs: Change xfs_xattr_class from a TRACE_EVENT() to DECLARE_EVENT_CLASS() References: <20250612212405.877692069@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Rspamd-Queue-Id: A10E22002C X-Stat-Signature: ncatgiqa6b4xu14ce5mf68kh7rqtg38c X-Rspamd-Server: rspamout07 X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX19GzQHBVNlOhxtGSB/EBRDqpj/Xw+XXV7I= X-HE-Tag: 1749763500-549411 X-HE-Meta: U2FsdGVkX18amOI4PfLEoWEmG8qlq+xcoA+Pt10mkf80y+f75woyTcea5EsdlyMXMEtyXe8Jmtyd3mW8wA/rp5JdknzG0kQ51KxUMp/jpbkU50ZAmvBbRKdxzibruDnJtHb8XhWj7+e7siXDoZ4cYZPP7alqLg0/BNZLbJ6BiaVWTbvu+gcvxe5qGXzm7f8usRmK0WLkld6XOPWTslKsbG5zxnNLnY9N7Qoyn2lQ6Njo4XuraCf+ZNIJg6otNPLJH7pmxcgZe6ks5e4wcFl+xnRwg9olzyqDE+osMwjjpiw06AuoIejnn05vw98Ygp0r5vHbv7YO/1FeqzEuNJSGb55WgDEn/qGV21K7K3RRQSqYDEMeajvWl6O2d/miZ4dSs7JZXdPvNDPioM+C6wsYig== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt xfs_xattr_class was accidentally created as a TRACE_EVENT() instead of a class with DECLARE_EVENT_CLASS(). Note, TRACE_EVENT() is just defined as: #define TRACE_EVENT(name, proto, args, tstruct, assign, print) \ DECLARE_EVENT_CLASS(name, \ PARAMS(proto), \ PARAMS(args), \ PARAMS(tstruct), \ PARAMS(assign), \ PARAMS(print)); \ DEFINE_EVENT(name, name, PARAMS(proto), PARAMS(args)); The difference between TRACE_EVENT() and DECLARE_EVENT_CLASS() is that TRACE_EVENT() also creates an event with the class name. Switch xfs_xattr_class over to being a class and not an event as it is not called directly, and that event with the class name takes up unnecessary memory. Fixes: e47dcf113ae3 ("xfs: repair extended attributes") Signed-off-by: Steven Rostedt (Google) --- fs/xfs/scrub/trace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/xfs/scrub/trace.h b/fs/xfs/scrub/trace.h index d7c4ced47c15..1e6e9c10cea2 100644 --- a/fs/xfs/scrub/trace.h +++ b/fs/xfs/scrub/trace.h @@ -2996,7 +2996,7 @@ DEFINE_EVENT(xrep_pptr_salvage_class, name, \ DEFINE_XREP_PPTR_SALVAGE_EVENT(xrep_xattr_salvage_pptr); DEFINE_XREP_PPTR_SALVAGE_EVENT(xrep_xattr_insert_pptr); =20 -TRACE_EVENT(xrep_xattr_class, +DECLARE_EVENT_CLASS(xrep_xattr_class, TP_PROTO(struct xfs_inode *ip, struct xfs_inode *arg_ip), TP_ARGS(ip, arg_ip), TP_STRUCT__entry( --=20 2.47.2