From nobody Fri Oct 10 23:16:18 2025 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1552C2D4B5A for ; Thu, 12 Jun 2025 19:49:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749757786; cv=none; b=sCO7z2L/W08G+fGtI7+y23QbzJ6jUnYpxhrug/SblYQmUckA9aVGM0j0vU9XOdyIIZ1YSVlvn35K0CEDxUv+chqnCsIz76Xt2VaXiZ8Nx6+kGSYEP+vSjXf3N1k9C5/lu9DEPdc/+PojfIe0Q5rKERyc75xsu6l/M4gMctruEdU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749757786; c=relaxed/simple; bh=jY3MGFXxhQhmObC8B0QQNU5r9zUDqG3Bm/y01WftukM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=fxSrKoMkTAGXHeunu/gq+ZV/uPrMJT+9KS1hC6fnjLYCJcTObWH91d2cL4g8eyQK9GjePQbwdEZ5yHNspRnTSRdCcFghWxlfONZlH567uzW1Dpa2ywxAkYUO5aOCr8D7jmTcd7eBj5mDNnSOYMEma6aEdwkrKYd82+RVM4muJwU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--blakejones.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=F20QgdiE; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--blakejones.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="F20QgdiE" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-311f4f2e6baso1271439a91.0 for ; Thu, 12 Jun 2025 12:49:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1749757784; x=1750362584; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=yYXjS/TK8jfGSnydeZ1dK5T+dpqe3MEJcXcTnDyoht0=; b=F20QgdiElgHCP7ZXBXR16EXGexXeku68NO0Y+jO22wNmvFAIzzuq1jGFH5UEbZZmvG D+rMmYCR39hzxU4Prb5auOce1l+vgsPAE552ns4ialv6lqzky9c9ex9y4ddB6HM15/+T aZptf/wWZW5Jpp1IqsZ33mYAxsk07NsOOUG1F9VldMqUW63tITswQbInTAE78sArlfI1 VuQrEF6iIjaw7LAuZ4maPN43W4ppSCBA9TugzFsQioK91CGEydke/PoIy8EWzOXaXJGi t7DgGWHSH9Dil6dMqvzXVEaVYUzmIhpJtebTsVcYTaTovcUJkSBQb0V5wixSq4a5c5sa MIGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749757784; x=1750362584; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yYXjS/TK8jfGSnydeZ1dK5T+dpqe3MEJcXcTnDyoht0=; b=JhGKBI0VvLAUbTsbwjzHgYwnEyqsWtznhi4cUntl/UgXlIfBiYEDE36/sQmXKNitLP Qx66X04PIDg+XwssxWijbdnv0mVlBy8JKICA7Rf/RTeqNsvAeJb/3m5HozC2yTor3MZT JWgyzTPv0FN4Yq5yTDRkoAKJfGNVYFQoP48qta2/jhMAnpn8uMSpOCjgRj1cTUqOnZtd pHF+GWK+JeGlyUtas8nEGS8Gkaeu/nvArwLKQFiqvTCGPxVEha1T90weSmjF21SDR9vY DcGlWGZ3q/TPK7ks81i/GpF5VyyaJya3HcTiHRfVsfnQdH/7y0P6K5M1piFWIznjxYLI vnIQ== X-Forwarded-Encrypted: i=1; AJvYcCW4Q/meG+KD4eOaUQ5XXTo36NwiIO7mMTZ5EFTaPfGqJayS4z/PnBPCKG1+b3QDppgg5S4DW5Dl3HuQIjU=@vger.kernel.org X-Gm-Message-State: AOJu0Ywa6t9KUoBuXC3j43HIAE0wFtVP0WE6xsZCf4KtRq5bKL5qDdVi w5RToXF+uyowo6FB/FYU8+C/t8xOZ0WEZHJbnH3kn7TKz+AgPJRRJAn1SKWUrsYP4bqkJ3VV1Yl V5jRHP9q6eyzEWjexjv0QXg== X-Google-Smtp-Source: AGHT+IEIyY1JuTOelnsD6QIJH09dPoFDqlUdg6uKiJwl+kRH0n4MU6s3D73fdkkzPSwsOxlG8YH8nMFbcjmO/aUx X-Received: from pjbdb8.prod.google.com ([2002:a17:90a:d648:b0:30c:4b1f:78ca]) (user=blakejones job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90a:e7c6:b0:311:e358:c4af with SMTP id 98e67ed59e1d1-313d9eac799mr726583a91.16.1749757784484; Thu, 12 Jun 2025 12:49:44 -0700 (PDT) Date: Thu, 12 Jun 2025 12:49:35 -0700 In-Reply-To: <20250612194939.162730-1-blakejones@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250612194939.162730-1-blakejones@google.com> X-Mailer: git-send-email 2.50.0.rc1.591.g9c95f17f64-goog Message-ID: <20250612194939.162730-2-blakejones@google.com> Subject: [PATCH v4 1/5] perf: detect support for libbpf's emit_strings option From: Blake Jones To: Arnaldo Carvalho de Melo , Namhyung Kim , Ian Rogers , Jiri Olsa , Peter Zijlstra , Ingo Molnar Cc: Mark Rutland , Alexander Shishkin , Adrian Hunter , Kan Liang , Steven Rostedt , Tomas Glozar , James Clark , Leo Yan , Guilherme Amadio , Yang Jihong , Charlie Jenkins , Chun-Tse Shao , Aditya Gupta , Athira Rajeev , Zhongqiu Han , Andi Kleen , Dmitry Vyukov , Yujie Liu , Graham Woodward , Yicong Yang , Ben Gainey , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, bpf@vger.kernel.org, Blake Jones Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This creates a config option that detects libbpf's ability to display character arrays as strings, which was just added to the BPF tree (https://git.kernel.org/bpf/bpf-next/c/87c9c79a02b4). To test this change, I built perf (from later in this patch set) with: - static libbpf (default, using source from kernel tree) - dynamic libbpf (LIBBPF_DYNAMIC=3D1 LIBBPF_INCLUDE=3D/usr/local/include) For both the static and dynamic versions, I used headers with and without the ".emit_strings" option. I verified that of the four resulting binaries, the two with ".emit_strings" would successfully record BPF_METADATA events, and the two without wouldn't. All four binaries would successfully display BPF_METADATA events, because the relevant bit of libbpf code is only used during "perf record". Signed-off-by: Blake Jones --- tools/build/Makefile.feature | 1 + tools/build/feature/Makefile | 4 ++++ tools/build/feature/test-libbpf-strings.c | 10 ++++++++++ tools/perf/Documentation/perf-check.txt | 1 + tools/perf/Makefile.config | 8 ++++++++ tools/perf/builtin-check.c | 1 + 6 files changed, 25 insertions(+) create mode 100644 tools/build/feature/test-libbpf-strings.c diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature index 3a1fddd38db0..2e5f4c8b6547 100644 --- a/tools/build/Makefile.feature +++ b/tools/build/Makefile.feature @@ -126,6 +126,7 @@ FEATURE_TESTS_EXTRA :=3D \ llvm \ clang \ libbpf \ + libbpf-strings \ libpfm4 \ libdebuginfod \ clang-bpf-co-re \ diff --git a/tools/build/feature/Makefile b/tools/build/feature/Makefile index 4aa166d3eab6..0c4e541ed56e 100644 --- a/tools/build/feature/Makefile +++ b/tools/build/feature/Makefile @@ -59,6 +59,7 @@ FILES=3D \ test-lzma.bin \ test-bpf.bin \ test-libbpf.bin \ + test-libbpf-strings.bin \ test-get_cpuid.bin \ test-sdt.bin \ test-cxx.bin \ @@ -339,6 +340,9 @@ $(OUTPUT)test-bpf.bin: $(OUTPUT)test-libbpf.bin: $(BUILD) -lbpf =20 +$(OUTPUT)test-libbpf-strings.bin: + $(BUILD) + $(OUTPUT)test-sdt.bin: $(BUILD) =20 diff --git a/tools/build/feature/test-libbpf-strings.c b/tools/build/featur= e/test-libbpf-strings.c new file mode 100644 index 000000000000..83e6c45f5c85 --- /dev/null +++ b/tools/build/feature/test-libbpf-strings.c @@ -0,0 +1,10 @@ +// SPDX-License-Identifier: GPL-2.0 +#include + +int main(void) +{ + struct btf_dump_type_data_opts opts; + + opts.emit_strings =3D 0; + return opts.emit_strings; +} diff --git a/tools/perf/Documentation/perf-check.txt b/tools/perf/Documenta= tion/perf-check.txt index a764a4629220..799982d8d868 100644 --- a/tools/perf/Documentation/perf-check.txt +++ b/tools/perf/Documentation/perf-check.txt @@ -52,6 +52,7 @@ feature:: dwarf-unwind / HAVE_DWARF_UNWIND_SUPPORT auxtrace / HAVE_AUXTRACE_SUPPORT libbfd / HAVE_LIBBFD_SUPPORT + libbpf-strings / HAVE_LIBBPF_STRINGS_SUPPORT libcapstone / HAVE_LIBCAPSTONE_SUPPORT libcrypto / HAVE_LIBCRYPTO_SUPPORT libdw-dwarf-unwind / HAVE_LIBDW_SUPPORT diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config index d1ea7bf44964..affe5e173920 100644 --- a/tools/perf/Makefile.config +++ b/tools/perf/Makefile.config @@ -595,8 +595,16 @@ ifndef NO_LIBELF LIBBPF_STATIC :=3D 1 $(call detected,CONFIG_LIBBPF) CFLAGS +=3D -DHAVE_LIBBPF_SUPPORT + LIBBPF_INCLUDE =3D $(LIBBPF_DIR)/.. endif endif + + FEATURE_CHECK_CFLAGS-libbpf-strings=3D"-I$(LIBBPF_INCLUDE)" + $(call feature_check,libbpf-strings) + ifeq ($(feature-libbpf-strings), 1) + $(call detected,CONFIG_LIBBPF_STRINGS) + CFLAGS +=3D -DHAVE_LIBBPF_STRINGS_SUPPORT + endif endif endif # NO_LIBBPF endif # NO_LIBELF diff --git a/tools/perf/builtin-check.c b/tools/perf/builtin-check.c index 9a509cb3bb9a..f4827f0ddb47 100644 --- a/tools/perf/builtin-check.c +++ b/tools/perf/builtin-check.c @@ -43,6 +43,7 @@ struct feature_status supported_features[] =3D { FEATURE_STATUS("dwarf-unwind", HAVE_DWARF_UNWIND_SUPPORT), FEATURE_STATUS("auxtrace", HAVE_AUXTRACE_SUPPORT), FEATURE_STATUS_TIP("libbfd", HAVE_LIBBFD_SUPPORT, "Deprecated, license in= compatibility, use BUILD_NONDISTRO=3D1 and install binutils-dev[el]"), + FEATURE_STATUS("libbpf-strings", HAVE_LIBBPF_STRINGS_SUPPORT), FEATURE_STATUS("libcapstone", HAVE_LIBCAPSTONE_SUPPORT), FEATURE_STATUS("libcrypto", HAVE_LIBCRYPTO_SUPPORT), FEATURE_STATUS("libdw-dwarf-unwind", HAVE_LIBDW_SUPPORT), --=20 2.50.0.rc1.591.g9c95f17f64-goog