From nobody Sat Oct 11 04:17:30 2025 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B615B221572 for ; Thu, 12 Jun 2025 07:49:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749714584; cv=none; b=Npd8BbUAQVsjyTSH7SJPQcLlRTIqHDZEMCTXLDbhhKOGjqhLbEReWYmg5oVWytQ/KI3AbU7mWbrog/vLpMI/UIXUYk6AeZ/M/gkpsmQh+hBuOK4j67MNrpSiQ+ANS+4zBBPUXB7cWprZZrxi8qEVHJoM7Hv6a1ezvGtMGC5b1xI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749714584; c=relaxed/simple; bh=mgKRPAxHp5lw/IYW6/80BbNLOKQ1CXL+sHNydAPoR2M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jZZ+ycWxwOQJ+ygKVKZeQiVcq1rIDYJ2lafumE1aHrt9VVbgmY2lvy1M1VXl24N7gBC3loXRkTHl31UfKpJ4Qi+RRF2zxLNVUoACGaJgYEFKk8y7NZnTAIKiXGbiq8doyTKhJhOoTA/GgIRnejSmuxzl8ks60ugB4vkKgJj4p1Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=QPt4ys4Q; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="QPt4ys4Q" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-23602481460so6730035ad.0 for ; Thu, 12 Jun 2025 00:49:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1749714582; x=1750319382; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ddcn6csaeeV+h8a6qan45mbc5QA320UytwqG7KT7p5k=; b=QPt4ys4QNYwt3/Sh66gUaxGP1JRYAyslYTdNE+iyZdAmRIMMLVBo3dCrDQ8A0Ax6MJ VNZ59azg0FB5MMBBaH6Kp0XtIgSPXw0cqsIcszhTtwBVNUJKDWBtvzeoX4tWWcc21Piw aF6fltV3kQuEZbFmnpfb1qFCvBN7Lgy3b6448= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749714582; x=1750319382; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ddcn6csaeeV+h8a6qan45mbc5QA320UytwqG7KT7p5k=; b=Ao7dhjm/NjUMzZ7rTfDG5lPLWIpyJHdVi0oRUwPblbudLjWErdqGKf/UDJNWHl04P9 nupsCNfA4v2VilW21R3pk2WJ590v9ITEnQM3XgpbApaAOZDXSC8+Cc8oGazVn6YyP8M3 e/MrMKc/9k90KCBqmqll+uXWk2O1wXIWzFp/bpPyvWdTgFpOl7hhsbZ+FijO0bUBOAZ4 8Z8tI5eSzOZCtypv9hJxVEjBhuL8/yfW4cJ+I/XSP//XRh5PKnHUAutawmofcVDvxloe CemKjs6EQXI9Y+mP/exr0iD1pLVbT9sjd42PICJmZKHazS0H36RhClqDJR3r4sW2kD9e EDfw== X-Forwarded-Encrypted: i=1; AJvYcCXlcSPxTLdVxG11RtvuNKyXFw46BDSrU9DCazEMp1OhkAD0DTjepoX/WBJdvew3LHgjQsIw3989T0d5KGw=@vger.kernel.org X-Gm-Message-State: AOJu0YxAIz5fW+R/1HJnZTtx29+yNd29RaGuTcUiUUFlG7QNN3ptQIVK wweIclqZ0QjBCQdFz+2m1f8OxeqWtDwejO1doWOAbRNhAzguPPHDYLO7bnW9glu4nQ== X-Gm-Gg: ASbGncvQ4xo0tAt+yZg8J+xe4qIcsAp/gRcY+XuQUSyaT0IjUwieAFgV69rnfUWl3Qb IwRhp460w+AaKfprmk7/uzssM1Y1xchRfVkjJUpwKs3VGxLFQFeGmgAmN68QMih/TbRwqqATNV7 6HKYrtu6fUapuRyqe+SqkEyXpgiluHB3kPogg7sCKxeJy1JhqajKDthV/2R6roF42Iu/UlldO6m Qu9tyS2Wck9O5Nu5XC5kRvrl1gh76HYOpjeIfm5EYcxB5Grm4p2XtxZ6yMWEHr7pidF7n1aTISh 9je0DBifNcvk/Lx2um+RX5FNi8Xpx31nYCs9VXubo0r2Fv57uO9zsS5CnTE5uF6Vd4ETtt69X64 hpTQ= X-Google-Smtp-Source: AGHT+IGBp6g9KafxxLhpwpCbKXrP6FojB0bp0d+xTc5kKarZApwn/2KeJhM/CNXIUtiGxu8HhD0Ecw== X-Received: by 2002:a17:902:f684:b0:234:b41e:37a2 with SMTP id d9443c01a7336-23641aa223amr95318655ad.11.1749714581947; Thu, 12 Jun 2025 00:49:41 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:5b9:e73a:2e58:5a47]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2364e63d42esm7893295ad.74.2025.06.12.00.49.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 00:49:41 -0700 (PDT) From: Chen-Yu Tsai To: Liam Girdwood , Mark Brown Cc: Chen-Yu Tsai , Jaroslav Kysela , Takashi Iwai , Matthias Brugger , AngeloGioacchino Del Regno , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jiaxin Yu , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 9/9] ASoC: mediatek: mt8183-afe-pcm: use local `dev` pointer in driver callbacks Date: Thu, 12 Jun 2025 15:49:00 +0800 Message-ID: <20250612074901.4023253-10-wenst@chromium.org> X-Mailer: git-send-email 2.50.0.rc1.591.g9c95f17f64-goog In-Reply-To: <20250612074901.4023253-1-wenst@chromium.org> References: <20250612074901.4023253-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The probe and remove functions in the mt8183-afe-pcm driver repeatedly uses `&pdev->dev` for |struct device *|, but then assigns this value to `afe->dev` and uses that in other places in the same function. Store `&pdev->dev` in a local pointer and use that exclusively to avoid the numerous dereferences and to make the code more consistent. Lines are reflowed where it makes sense. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Chen-Yu Tsai --- sound/soc/mediatek/mt8183/mt8183-afe-pcm.c | 37 ++++++++++------------ 1 file changed, 17 insertions(+), 20 deletions(-) diff --git a/sound/soc/mediatek/mt8183/mt8183-afe-pcm.c b/sound/soc/mediate= k/mt8183/mt8183-afe-pcm.c index 7383184097a4..a7fef772760a 100644 --- a/sound/soc/mediatek/mt8183/mt8183-afe-pcm.c +++ b/sound/soc/mediatek/mt8183/mt8183-afe-pcm.c @@ -770,27 +770,25 @@ static int mt8183_afe_pcm_dev_probe(struct platform_d= evice *pdev) { struct mtk_base_afe *afe; struct mt8183_afe_private *afe_priv; - struct device *dev; + struct device *dev =3D &pdev->dev; struct reset_control *rstc; int i, irq_id, ret; =20 - ret =3D dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(34)); + ret =3D dma_set_mask_and_coherent(dev, DMA_BIT_MASK(34)); if (ret) return ret; =20 - afe =3D devm_kzalloc(&pdev->dev, sizeof(*afe), GFP_KERNEL); + afe =3D devm_kzalloc(dev, sizeof(*afe), GFP_KERNEL); if (!afe) return -ENOMEM; platform_set_drvdata(pdev, afe); =20 - afe->platform_priv =3D devm_kzalloc(&pdev->dev, sizeof(*afe_priv), - GFP_KERNEL); + afe->platform_priv =3D devm_kzalloc(dev, sizeof(*afe_priv), GFP_KERNEL); if (!afe->platform_priv) return -ENOMEM; =20 afe_priv =3D afe->platform_priv; - afe->dev =3D &pdev->dev; - dev =3D afe->dev; + afe->dev =3D dev; =20 ret =3D of_reserved_mem_device_init(dev); if (ret) { @@ -835,7 +833,7 @@ static int mt8183_afe_pcm_dev_probe(struct platform_dev= ice *pdev) =20 /* enable clock for regcache get default value from hw */ afe_priv->pm_runtime_bypass_reg_ctl =3D true; - pm_runtime_get_sync(&pdev->dev); + pm_runtime_get_sync(dev); =20 ret =3D regmap_reinit_cache(afe->regmap, &mt8183_afe_regmap_config); if (ret) { @@ -843,7 +841,7 @@ static int mt8183_afe_pcm_dev_probe(struct platform_dev= ice *pdev) goto err_pm_disable; } =20 - pm_runtime_put_sync(&pdev->dev); + pm_runtime_put_sync(dev); afe_priv->pm_runtime_bypass_reg_ctl =3D false; =20 regcache_cache_only(afe->regmap, true); @@ -901,7 +899,7 @@ static int mt8183_afe_pcm_dev_probe(struct platform_dev= ice *pdev) for (i =3D 0; i < ARRAY_SIZE(dai_register_cbs); i++) { ret =3D dai_register_cbs[i](afe); if (ret) { - dev_warn(afe->dev, "dai register i %d fail, ret %d\n", + dev_warn(dev, "dai register i %d fail, ret %d\n", i, ret); goto err_pm_disable; } @@ -910,8 +908,7 @@ static int mt8183_afe_pcm_dev_probe(struct platform_dev= ice *pdev) /* init dai_driver and component_driver */ ret =3D mtk_afe_combine_sub_dai(afe); if (ret) { - dev_warn(afe->dev, "mtk_afe_combine_sub_dai fail, ret %d\n", - ret); + dev_warn(dev, "mtk_afe_combine_sub_dai fail, ret %d\n", ret); goto err_pm_disable; } =20 @@ -923,16 +920,14 @@ static int mt8183_afe_pcm_dev_probe(struct platform_d= evice *pdev) afe->runtime_suspend =3D mt8183_afe_runtime_suspend; =20 /* register component */ - ret =3D devm_snd_soc_register_component(&pdev->dev, - &mtk_afe_pcm_platform, + ret =3D devm_snd_soc_register_component(dev, &mtk_afe_pcm_platform, NULL, 0); if (ret) { dev_warn(dev, "err_platform\n"); goto err_pm_disable; } =20 - ret =3D devm_snd_soc_register_component(afe->dev, - &mt8183_afe_pcm_dai_component, + ret =3D devm_snd_soc_register_component(dev, &mt8183_afe_pcm_dai_componen= t, afe->dai_drivers, afe->num_dai_drivers); if (ret) { @@ -943,15 +938,17 @@ static int mt8183_afe_pcm_dev_probe(struct platform_d= evice *pdev) return ret; =20 err_pm_disable: - pm_runtime_disable(&pdev->dev); + pm_runtime_disable(dev); return ret; } =20 static void mt8183_afe_pcm_dev_remove(struct platform_device *pdev) { - pm_runtime_disable(&pdev->dev); - if (!pm_runtime_status_suspended(&pdev->dev)) - mt8183_afe_runtime_suspend(&pdev->dev); + struct device *dev =3D &pdev->dev; + + pm_runtime_disable(dev); + if (!pm_runtime_status_suspended(dev)) + mt8183_afe_runtime_suspend(dev); } =20 static const struct of_device_id mt8183_afe_pcm_dt_match[] =3D { --=20 2.50.0.rc1.591.g9c95f17f64-goog