From nobody Fri Oct 10 21:00:35 2025 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D52BB245023 for ; Thu, 12 Jun 2025 13:15:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734125; cv=none; b=We7LwqzwYAGNndhhlR5M07uw08xhraR7/99e+J4uywraLwh80wMd39nr5WLL2BXAl4LYB6v+RhyMSg4EYMrFv2DTUHeoQYWs/wxZVoR/76cVZ9xeTzWECcXOEi2uBNzIa2u1pJ4q94K1cY3kxh8EHnZrKym0KFzRcAWsUAYX3co= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734125; c=relaxed/simple; bh=r0qYcU16DOOXB/L65/ELIol1UcVjLdmj6pz7lcDecA4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oX65ZIjx+lX3nN2eq3nrE2Rlmr/m6dep+78sZuYDmcy1vaWYXAnQ2CwbqzUoZPYhTjFbwcxpELbh7HPgSIhLy6g2H0tFsOaUBxQQO4GR6OcWb28psaG4FYmrt2UaQmv86Ot8OSJIP6UuP0wQTT7sKtuy3jiBJD/MJj3DZSIjpMA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=MpQKAQd4; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="MpQKAQd4" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-442fda876a6so8198345e9.0 for ; Thu, 12 Jun 2025 06:15:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749734122; x=1750338922; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=zmZkKLxN2UmLakt+dPeotcVOQqoR98FTAzfeh6JlZVI=; b=MpQKAQd4deRkgarkX7d6Ian3Zk/MdVqgpTZlXlFZrzdPZYi0mffFFcpH5RyenSeEJE QrUHH2xNSlcjZ0AxocdjVVahNTT6sYgYPy0MbGZQmoowu5G6pwwNDo2PVIcm4cNBhsfL Is1ZogqbZxSbMIcWovDzUAN40q/+59XCuWwDlAaE9dwqpif8WN1lrLqxgi4h21LDxTUB VbrRdwZLSnj45kZJxKlObHQ9XK57FJpZzU2wtmpa5KicwdH820CM4tPOlSc/aIc5Dnn4 JCUUTCGam/CeSmK/gh9y0E5bnZk6WzVlFB/qVUZ3mWPW8ANGf3Sv+1Jw0dOfH4G00+Hc QtSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749734122; x=1750338922; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zmZkKLxN2UmLakt+dPeotcVOQqoR98FTAzfeh6JlZVI=; b=NW5zejWtNxJYocCx9k5J+/XXYnokvk7oWHFrCyZ51qqB2d8G3Tu6t9/1Hh8t+eRWRy ssKpvE1t9qsd4MOdhHckpldT++A2jzELo1hPdct9HVdo9d6qNlXt+AIkJwq0P85l+1ZQ r5RKcHEKWhneGC1zsxT5Huup09rnX7VwFnyFQ/kVq5vZrQTsTu0jqfE03LnUMbWlcsSf IMmK8Lhdgb46LIf+D6v2ck7t6PlcPRVZbm8tOcm7PjM85750mlXY/2fGOAfXwN1FxtVB PGrK1KdpZENz1kTU4DjMWddw1EbRwgMrmecHx6YbupO4CKbNovKu0URr8PU8NTZoW3Sr mw2Q== X-Forwarded-Encrypted: i=1; AJvYcCULQ2vV8EO/0TYr3HLAhIo9MmE2MZGzyd5wyKkqXAbjibyIuFDVVQwh/uQNp5eLaOFFMvaM028F+diuQ3Y=@vger.kernel.org X-Gm-Message-State: AOJu0Ywe/wbIjNsHHqlh39C51n4TCrI7ImQhtsKra5VC75MlNASMV8gv /Wqm1xRiEtTWGU6P2DVRNQK+2qWNI6HbkMBaPHz8fMR7YCOIIxyB+pRIs6qqqPYyWqM= X-Gm-Gg: ASbGncsawOajIRf1qgIW1utY43f0nRi1yG1LNjvSM27QdO9MrAVB9OnhEABFsTzfVQd ZWmVSo4zWNtCq0gNBN7/L1GekAlMMAkK3q54lkuA0Y2OgWUcEZTU6hi+4V8x5pyqPKq/MSzTbj3 FmakfRkDvyqgO0Hri170TT6HKgOJ5MYhOm5EKGfN2Vb/2qwRiDCrVGWRfQE+2+ZHd8FQw4WqLuz RPnMuIfuKMn49S7YyemvUCz3R3IIVXo7MYB36z8JtyuakszJLXir2NfrUH7VCzEMNzpuN2qZH5M Q423qZDwYlSGm6w551eHeZtWr/UWlt2nOBgn5blKyXcIYXyYMRfSx4g= X-Google-Smtp-Source: AGHT+IFdr6eiKmLNU1U7PCiAyyEcaNtod1q+PU6cBesinlO+7E1MRjBPyMho7YxEmPTyFNNlQJ5EIQ== X-Received: by 2002:a05:600c:c16a:b0:450:d61f:dd45 with SMTP id 5b1f17b1804b1-4532d37700emr31586985e9.4.1749734122088; Thu, 12 Jun 2025 06:15:22 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8b99:9926:3892:5310]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532dea17d7sm20619795e9.10.2025.06.12.06.15.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 06:15:21 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 12 Jun 2025 15:15:10 +0200 Subject: [PATCH 01/16] pinctrl: sppctl: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-1-556b0a530cd4@linaro.org> References: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> In-Reply-To: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> To: Dvorkin Dmitry , Wells Lu , Linus Walleij , Bartosz Golaszewski , Patrice Chotard , Support Opensource , Baruch Siach , Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Viresh Kumar , Lakshmi Sowjanya D , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, soc@lists.linux.dev, linux-sunxi@lists.linux.dev, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1728; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=LieHmje5ivI5luNfORERBIvPNT4Z77mh5n845VHvScA=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoStLk4RH7GPVp8SssQRxQJp6gzZ2YETuVm14Kq ofe5DUznf6JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaErS5AAKCRARpy6gFHHX cr/lEACI6ET2WlvZ9cyQDzGwOdmiCfZct2usLbI+rS53HlFtmhOQcNkSmaUGnwVPfPHX1OKG7u8 dbqcNZIdDG6lrAjwrodXYH7a1vrgYl4fLrudzgfzXyx/pyT+4NJZvRWfprR4w4TraR6/W9iQzdO wP3bL6aoNjJQjxz3P0ey6wN/zPuvQJaxjAh+lJDMEFh8mz5P0UDMZ4D66yIKi2Cm6Ea0xZgGJyR KJOGz4mct+SIxm358x4VzGpQckl5dZF0hqK3CfjD+MAe595dVdFJ2m9NghpyjJV+xYYUrA/tl6T yHMxNVVaczWBNyvrynetjzEFh0LHJ1lK3woV+mzoiFeXT5PaWXJBhxTJeXBSdXAs1EdF5DWjeb3 gf1xcSBfd9eqV2bTnSYtjsgobI3JYLTeFl7LT9h9GtJ4HfD39BuzyA0Ss0+ZAkP+0RbhARTf8Dd LNOqMPmFirJVka+ELdb1qNf56x2cFpRETLOdZ2OtNsAS151YAwJDiLLKBI8FLDvUqxbNK1sST+S 4M6hYV9k3URKnrim10RgFTxPcQrCuW5q62+1mTRUjg7XxpIUlrSdX6TtvPqWmtMoY1zM71OwHl7 f4ZCx+47It/Y0/pIQzZWm31bgsmNv2MW2oIhK/1QHFPK/JDVZtvJPYUtr8AXF+ZEHgJcPqFCZ8s MScuhzi/9MgLUwQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/sunplus/sppctl.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/sunplus/sppctl.c b/drivers/pinctrl/sunplus/spp= ctl.c index ae156f779a16b8c4bb91c4cb0d5d4363ebd15d25..3c3357f80889a95c46557b3f812= 9882d2ce96f6e 100644 --- a/drivers/pinctrl/sunplus/sppctl.c +++ b/drivers/pinctrl/sunplus/sppctl.c @@ -461,13 +461,15 @@ static int sppctl_gpio_get(struct gpio_chip *chip, un= signed int offset) return (reg & BIT(bit_off)) ? 1 : 0; } =20 -static void sppctl_gpio_set(struct gpio_chip *chip, unsigned int offset, i= nt val) +static int sppctl_gpio_set(struct gpio_chip *chip, unsigned int offset, in= t val) { struct sppctl_gpio_chip *spp_gchip =3D gpiochip_get_data(chip); u32 reg_off, reg; =20 reg =3D sppctl_prep_moon_reg_and_offset(offset, ®_off, val); sppctl_gpio_out_writel(spp_gchip, reg, reg_off); + + return 0; } =20 static int sppctl_gpio_set_config(struct gpio_chip *chip, unsigned int off= set, @@ -545,7 +547,7 @@ static int sppctl_gpio_new(struct platform_device *pdev= , struct sppctl_pdata *pc gchip->direction_input =3D sppctl_gpio_direction_input; gchip->direction_output =3D sppctl_gpio_direction_output; gchip->get =3D sppctl_gpio_get; - gchip->set =3D sppctl_gpio_set; + gchip->set_rv =3D sppctl_gpio_set; gchip->set_config =3D sppctl_gpio_set_config; gchip->dbg_show =3D IS_ENABLED(CONFIG_DEBUG_FS) ? sppctl_gpio_dbg_show : NULL; --=20 2.48.1 From nobody Fri Oct 10 21:00:35 2025 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 336BB246769 for ; Thu, 12 Jun 2025 13:15:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734127; cv=none; b=BsZivo9BW/3zIE/hb832f2MS8cSYD2Lz2Q8gN/yOqxttSQYzDpbu8RGdHdGLwKgXJ/xQebvR9OP4sj9Pg3IIgkfWnwGq0kryCMeO8G3HswexgmlLUe8CDEgsAIf+em/GqELOq0MS2JMsByuGa9aiqhryhql0rltigBnZlFjGINw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734127; c=relaxed/simple; bh=ouf2Msmzi8BBHjiroC26wEHH+x9bWRaKtDQmEzjftt4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TiThf5v8JccUtOZ947rO2Q7jL1JxwNa982+yQvDSe+a0Gr20WBaJIE8x/91yMawFQe0wUOzRn5k3Vok8AuJogvs6R6gMUkQqezSgI8ZyOZEP0kR1gCR8GB8RjyNXJXfNArhKWSBEFDS/feepCi5XGvpXtFxFC3UmiSFO+foji94= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=J1jxSmsB; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="J1jxSmsB" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-451d41e1ad1so7695865e9.1 for ; Thu, 12 Jun 2025 06:15:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749734123; x=1750338923; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=raLE52k1FOP5xc4vn5Fhz2KPLej0BIrS83cEFgVPEbo=; b=J1jxSmsBCcGJvCr3Sl2fLQVWwm8dbmivNaCdeZre1mFF3BFOgVvQY0o1VpDdR7OsP9 5OqqAEORycqP7hieb7+2Xk19S700uVvH1o+mRMPzh1RY4EQYZvXRj1WPpjKtgiGGf/Xb 1Fb1On05LM+OXH50P3Q3v8z58VyYJD7j6rXf0AlOtYqEIsQLIZTYBF9/Xb9JgwVPqYu9 A0zW2oDLE/XVfe3CEh3AaLelqmElfDH3yh2GcB9ZW5sHdgpijMB0+BeEfTXPE1KMcABm lIp5WQRjc7lSBhyEHE/bj+evINzy7E2bWHr0+83rMdvIo7P/YQBDrDz0nSJQKlxHRUlQ Gdmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749734123; x=1750338923; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=raLE52k1FOP5xc4vn5Fhz2KPLej0BIrS83cEFgVPEbo=; b=aqQxAO04gheEDNfPMU3/HfbalWqRxiLFgSbbQnEgTL1WPslYrFqkm//vtgzRGYuTiy oNx8Jc66RkrX09NjYZUwSZZAYyeK5ecPgu3lUU1hszsWYCUTXEOEXyfGw7niVVyypXiM TTsNG5cSF7SrvzVEaReg2c1zOWgH8kog9PaqoPRHDsSIK42ytD7l0c7LPEeRnhPV9gEg lTjcn2vSpyOJyjYQIli7pj6uLQ4JzIuZYpCshbhbqawGv0hn8HQiOv1yzmwEYIbcMtoQ qQnVnwax30pLnMCDNvstHJYZvg9LMGnhDFkqxnbc+k4i8ief0Gh4a6ye/1Fw8EXVRmzV agXQ== X-Forwarded-Encrypted: i=1; AJvYcCVuT9h58BpyhUtV7ll6V8j4v3QiS7w3oCEbnC0+egmrVw0uB2ExhGvKLqrv3nc5bRA97nXFeTasew8LDr4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7cuOwDdYcDU4vfiVwosNkXAuqDlG38Hqg9/ulMnqpXcB9hq4O KdXB4J3ejmmmbMHB3WnJQX+7hTDkze534Xv28ravlp9ulMU9gq/pGI2/hY4HytuFYZ4= X-Gm-Gg: ASbGncsIts9Pkic0AeXrEpLpGT0hczgGKtqoItXshYW8+Y5BLCPJqR41rTLppwdpqLR SIWQ0unVLH5yOqoz9IXf16gIhxNHagjWCNyRalfmVGHVZqK591F92Df+EM0A1Tc5Nu9GHyprboT DoM+UYVgBKqy/GuQZKr+zpByvKYKaR2buNCH4A2mour9QurnF9Zg/uQYTDDrAmd43Ym/bW6sEl+ /dTw6nFUCV66a0IaXMVZdA9uzyf4u+jK6VovXb0j/83bqoYjnM+FdyfaMuY4b4NPgyfuUeW1aaq QD1jjSuWlcJ8PXGofMygHgUTZm7yO9uxTP+EBbtkoKCRpOFbbum3LQXqgJFwJB55sQ== X-Google-Smtp-Source: AGHT+IFhdHOEFkYRXt2aGfqR8yUbaKu71Wss7a74LOAwDEENbVsdkagshqU0KdML5k1g7zcI8+VF/w== X-Received: by 2002:a05:600c:8719:b0:442:f482:c432 with SMTP id 5b1f17b1804b1-453248f9836mr73550665e9.18.1749734123425; Thu, 12 Jun 2025 06:15:23 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8b99:9926:3892:5310]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532dea17d7sm20619795e9.10.2025.06.12.06.15.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 06:15:22 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 12 Jun 2025 15:15:11 +0200 Subject: [PATCH 02/16] pinctrl: st: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-2-556b0a530cd4@linaro.org> References: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> In-Reply-To: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> To: Dvorkin Dmitry , Wells Lu , Linus Walleij , Bartosz Golaszewski , Patrice Chotard , Support Opensource , Baruch Siach , Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Viresh Kumar , Lakshmi Sowjanya D , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, soc@lists.linux.dev, linux-sunxi@lists.linux.dev, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1451; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=5oB62agveNry6MooKoxev/dYplc8gqfDNeN0pMdLmAw=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoStLk2dgnIHTbMZddeUKxRSqft05VFU92x1VSm HYQEZ9FQymJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaErS5AAKCRARpy6gFHHX ci90D/4nF341GcBLvs7mN4+c32OAiw+FWYJXPAOuwi/EUKU0s3AT0CdFTJYUDtLgh4tTL1kGiOc 0afStrGNH+AilQUqqVnZA54B4xB/xitGdZyKn1L2FMY95sTWY2DLazI9FaWGDJHzYr32Is4+/Od ApDWy89r3ZqJPsu/AqFA+u/WL1GS6eGHjsGaCqOJkJOxCd12CtopA1Sa9ykgrwOCvflKi35tefo c1EdnStWa+4dhBA2u4ImkGdepns6dNSsrR0sIlxPxCYbNjcxD3Cw12K4Kzh28PwDa+5M2rjPZLV HCn/H8EY5ZYroSn0pCawU/zDxL+JoWLupRE7O0mCGnMOV3L6bFSoydD3Y5hmzalmzvIDGwpG4Po daXmD8lwASgyWOmQdEnPotm7B+8+RK88tsKCp6fRHo6gvcWj8gFb/VqlGCxUU4ZGBWtI6ugA4ij 1NELeINA4u8yjj7X3/a1UBo2cKr5zrP4WIqCQVR9Q29kLfEpOdoiGJz80VL03tcvUFTye2QsEdv +xncjx3Gsp+H9v6sMKbar5HUNDMfufe29u4+gPeU9LFwHb+MMQBz8jHlI1Qu4+zMgbO0dRqaYXF XLFoAR2ELXErj81QGwg+WTGD19Aoxi051lXMTTQ/eYD3HUrw2H4T0XHfaLFlBSW+sOOPBmL3S2V +yvayW/ehrmLRwQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/pinctrl-st.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c index fe2d52e434db8cdc03d61ef3f4df95cbcc9c513e..fb5d72a6826ed730f5a10a817e9= a46f9fe319b5b 100644 --- a/drivers/pinctrl/pinctrl-st.c +++ b/drivers/pinctrl/pinctrl-st.c @@ -711,10 +711,12 @@ static int st_gpio_get(struct gpio_chip *chip, unsign= ed offset) return !!(readl(bank->base + REG_PIO_PIN) & BIT(offset)); } =20 -static void st_gpio_set(struct gpio_chip *chip, unsigned offset, int value) +static int st_gpio_set(struct gpio_chip *chip, unsigned int offset, int va= lue) { struct st_gpio_bank *bank =3D gpiochip_get_data(chip); __st_gpio_set(bank, offset, value); + + return 0; } =20 static int st_gpio_direction_output(struct gpio_chip *chip, @@ -1470,7 +1472,7 @@ static const struct gpio_chip st_gpio_template =3D { .request =3D gpiochip_generic_request, .free =3D gpiochip_generic_free, .get =3D st_gpio_get, - .set =3D st_gpio_set, + .set_rv =3D st_gpio_set, .direction_input =3D pinctrl_gpio_direction_input, .direction_output =3D st_gpio_direction_output, .get_direction =3D st_gpio_get_direction, --=20 2.48.1 From nobody Fri Oct 10 21:00:35 2025 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F62D246BBE for ; Thu, 12 Jun 2025 13:15:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734129; cv=none; b=Xxbg/sG8JNvPEJxAUwZYRRwVpqiNcrpYzskMF7focsEidNOWSxJIaWMuHj33njFTBAqSP92cdpd+JaPxCYlV8quzDqEzTw2/9vlbqqzjPfWcrqPXGJiPv4wSWOPPQ/TBu9E/Ze39xds0bwEBT0DHLL5lhQG1988AGH3ry2bKHy0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734129; c=relaxed/simple; bh=UfAyi0SnKB7UNnDRolL6nwsA4uSdSBP9PbHYK+OpTMQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=msFp85GfhrgE5stU6dbDZOxm9P5g/QnpUnF58zy7kybB2q8q/eU8D3D+ukoxm4Dx0cl0RLY+W8YdG0aRn/vW+IGzxFDbvJrf0JGNytfu+0uVFgR/KptiEwsW0ufdMUk5yfnpFQl61iiDVoufl8cCcXL5K3eCDqjDFs2eKZWWiR8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=K8AtIo+R; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="K8AtIo+R" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-451d3f72391so12368585e9.3 for ; Thu, 12 Jun 2025 06:15:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749734125; x=1750338925; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3Xh9vFlYN2cjb4AoCZuPQ/5e61RjLZcwUz2fDo2ivjU=; b=K8AtIo+RPYzSZrapz6Vl1RxLFLSGvwu9YrSOCumBpuQL5jNqvjZcBJzhyg+f6CZRRE +zteFqHbGxz9wNKCqPt+ht+jt+CEp5bijahnJUaq8ivXdgMggkhjoMXA3Qi2K5pDrgiS QEWfGMPpi1kXWOM4JOUa+NLimgVyavkapyoi2hOl0zvteq0QcSY4uGVnerriXg7GUZuu 6RZf+BZ558UY1aFZDvsSxeiY0ka+AUsl6PJ6fOzUsIsgAKkmcfdeT/UndLEwk/JL1iCY YUr9FwWOFP0y7Bz0U4bpVAzC7YJfufecrfi/0fDKcLNjGlUc4zkO4H1nC9ph+X+jYAVQ p4SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749734125; x=1750338925; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3Xh9vFlYN2cjb4AoCZuPQ/5e61RjLZcwUz2fDo2ivjU=; b=gij3SpyO+VW6bemA/wKngMJ2yaqxSbJPzFOkFq2cegFDNDab4WbbHCEZObIVf+rUIV TOHuv864WTc/eYutJ+dL6fK6L5YP5fFTL4iUxMlLSLomTU+sxj05iyNtU7ZSex2DVDDP jBF4Y93D6t1xdcNOsZ9rHCFe+QNcKEcSGnDmo7+AJY2BMyM5968lrLsf4B6LGj34ytNJ bfu7XS0W7i/l1PltpRitgzR4tZD8bbK2GMZO+m/otYJrMGroWpjd9pIjltgEbMs2kTz/ 3xbIcrhpn7Suzpsx9EUNDD+cGZXUEIOIL9R5QPsKsxLjLw8dyFDzwsQ/UBWt+iwqMCtD q4HQ== X-Forwarded-Encrypted: i=1; AJvYcCWmlUM/f2EFhpNIKbiHMX8jC5wRedAEBBRgc2vlNNfs2FAq4DZZI04b5sm5S/9O2nP51Yb8sg0kNsUnCaw=@vger.kernel.org X-Gm-Message-State: AOJu0YxMEa8p4yOH0U4Or0bsfJfJ0Op+qxz3nYlXsPzmNKv5EqmCT2wL BF45O/ZNpGPiKbholU42AkzgiC0lJ4PBnh39wSr3CwZk5DFY9yifwEM0OXw6Ik+trR4= X-Gm-Gg: ASbGncu5OstaCXDtohnVMRRUUyxhW0xks3o9O7KoTkiNoApg0P9bcjBirPBb18eRKRL 2tJvhaX6qUaUTCHPgO1ESfcxtrKtGpXmdmbjAdieKdI/KL6XBv08tI7IlbEdMEdO242xAqutv+2 aDjxzOTROPSdlSoKYHaKYToEW/9HopuX1wUjv/ENeTpDv++HzifkRBBBptnatQymNDmlyMi2/in nY95fhyGZtWnK99NS/sWrwd2qkLL6zWr84YbgJK6/B6DCqzkxB0w1JzUkaAXE5Zf7eX6Xzghwgt wfPfhLjZmvycS7XhE+KEeJT4UzmnHDh5x2L3qiIdCFlsW/RUGhb6mpgJ3uyI7ki8qQ== X-Google-Smtp-Source: AGHT+IHQX+Ej9HN4lelzlLvXYSgEkOOUk0QijevexRqGIQJCq4lgjLqOhwOf+he5IAKWkE6Gfii7JA== X-Received: by 2002:a05:6000:40cb:b0:399:6dd9:9f40 with SMTP id ffacd0b85a97d-3a56074913bmr2816635f8f.9.1749734124811; Thu, 12 Jun 2025 06:15:24 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8b99:9926:3892:5310]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532dea17d7sm20619795e9.10.2025.06.12.06.15.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 06:15:24 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 12 Jun 2025 15:15:12 +0200 Subject: [PATCH 03/16] pinctrl: da9062: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-3-556b0a530cd4@linaro.org> References: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> In-Reply-To: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> To: Dvorkin Dmitry , Wells Lu , Linus Walleij , Bartosz Golaszewski , Patrice Chotard , Support Opensource , Baruch Siach , Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Viresh Kumar , Lakshmi Sowjanya D , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, soc@lists.linux.dev, linux-sunxi@lists.linux.dev, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2018; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=gwxSylPIbPGKwi/smPHfzBU9AQqt6xWeX1IRJSlXXtw=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoStLklRnjxne2O9+BScgNIbdaQOQ8KBJv22AEy OvQ1Poa4/yJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaErS5AAKCRARpy6gFHHX ciqcEADP8OlzO6NOQIzIT/qqVAp3TDw0XWzO3xI33euUn/a7LW3bOC5krWIHRmgqL2O3X9ROPwy 8pz4JQq0eNG//IFcZicNDy4OI/1UXmVX7q6CTYBRrYTSHn9MSK7xj7ewNxtxNs7ICz64+F6S4z6 /Se7jc0CQ3+r1opnL11YOXKKagRki+iK+jyb9M1JOxbj0Tgo4adZrx19lS3VMhZOI+iDMiNO5DH p/BDCDHQz7LVzxYAaSRH4gKrjFW2Lu4YdlRvFpVQUh0MPPte0b3fJZWWM/2W2rWSJZXC7VQihcM sYjsZf8F9PccsfTurbyxNG4+uf2Jkp5qZLGr8jxajXwhCzCb+dIbiEkG8b+tQRkAsEddqLTWMXu pHbF0u9YUFROoTwzyjewSEVDLm0ef5KMRrMR919B5eD0+Gvv51hg2ISZQl/Ul/ifkNOkubjn1cj eOrF8/vsmxM/hUgNHcaXZLKXrg29O5KiZTlsW/oC9FKdRjVXCgRZCZCt1eDKD70aS1vurl57yZ8 qqz3aHv0xXNXD4dOXrILpcZnJM9wsqnWEHpOVEhlEJlMuCs+JjOQsuOJ5agwuTE5BzgxJGpDjVy f7SN3HIJfkiYibBq4+uvAchWPc9l3G4GtUTbeTyVX7EvbSLzHv069LGspheGTOvXTiJ7OvFJuj9 eNUbMRFae+k53Ug== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/pinctrl-da9062.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/pinctrl/pinctrl-da9062.c b/drivers/pinctrl/pinctrl-da9= 062.c index 6f44a13b90ce56dbb00fdbedc28b0377a42d3b0c..3295b09dfc3daf8feb6de0082d9= 5952e1cf25d26 100644 --- a/drivers/pinctrl/pinctrl-da9062.c +++ b/drivers/pinctrl/pinctrl-da9062.c @@ -102,14 +102,14 @@ static int da9062_gpio_get(struct gpio_chip *gc, unsi= gned int offset) return !!(val & BIT(offset)); } =20 -static void da9062_gpio_set(struct gpio_chip *gc, unsigned int offset, - int value) +static int da9062_gpio_set(struct gpio_chip *gc, unsigned int offset, + int value) { struct da9062_pctl *pctl =3D gpiochip_get_data(gc); struct regmap *regmap =3D pctl->da9062->regmap; =20 - regmap_update_bits(regmap, DA9062AA_GPIO_MODE0_4, BIT(offset), - value << offset); + return regmap_update_bits(regmap, DA9062AA_GPIO_MODE0_4, BIT(offset), + value << offset); } =20 static int da9062_gpio_get_direction(struct gpio_chip *gc, unsigned int of= fset) @@ -172,9 +172,7 @@ static int da9062_gpio_direction_output(struct gpio_chi= p *gc, if (ret) return ret; =20 - da9062_gpio_set(gc, offset, value); - - return 0; + return da9062_gpio_set(gc, offset, value); } =20 static int da9062_gpio_set_config(struct gpio_chip *gc, unsigned int offse= t, @@ -235,7 +233,7 @@ static int da9062_gpio_to_irq(struct gpio_chip *gc, uns= igned int offset) static const struct gpio_chip reference_gc =3D { .owner =3D THIS_MODULE, .get =3D da9062_gpio_get, - .set =3D da9062_gpio_set, + .set_rv =3D da9062_gpio_set, .get_direction =3D da9062_gpio_get_direction, .direction_input =3D da9062_gpio_direction_input, .direction_output =3D da9062_gpio_direction_output, --=20 2.48.1 From nobody Fri Oct 10 21:00:35 2025 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD8D724886A for ; Thu, 12 Jun 2025 13:15:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734129; cv=none; b=IJgIFsPo+oKXFc3xpLjvcF1Z08Kx4CfgrfB8Tz+FsvfsjsaeNtzA50e3atjT1Ef6pZ8f249iXPHP7oFMawHJC4iwNO9KA2sYU6XpLu8H5eg+Pljb0Y3dGtf/ySS1SUglOuzNgBevBzuZOyiOfQnUVkDLOYnPWL41lf/8qZ6kkig= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734129; c=relaxed/simple; bh=E5AKqRpmO9wPBzhaTRocu/BHU3xEEHDIC4VmpgIEqvk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BBtYOPNQ1jKC2XT3qpGPLCImCV07sXx5JYFN+Z/CQpedarpPrS0ghMS9S6xWZcJsXFda9MVqkn99nKE0yWj50NGnpiiyPHHjt7YTtLfRiVw2IZH/X26hWpaVRPw1MIQO+PzkThStzn3VybWvZ/f/jUiCKBoaguCm//MeRp4u+sE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=pAwpO+1w; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="pAwpO+1w" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-450ccda1a6eso8201735e9.2 for ; Thu, 12 Jun 2025 06:15:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749734126; x=1750338926; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=rV66TNaxM+tRVm0G56yg1ZS+Xb8QC9jIEshfuDQ8Ajw=; b=pAwpO+1w/VG7oXx15P9CMDEgW8OSZqJ/dgvcFhhcf5A0ZMNwgSga8/gSvqe9nirCX1 reK7nyWl4eHMYnbLvdMFPYJ7DDYoNSOJ6Nn4vXwekrtFTubz34xoK8tG8bDMmMNPNEzb tpAAv7SUmQz1aJc1vewguETQ0RWHOTko+Dc2aBp5gBzlY6e7QlE3y1LF0vryDlmgK7gJ SjV0HT3I8G0TaeywJj1khDPtI3fxiS9Y7FQpnjtbzaMN9ea+VbZgcyMdJAxn2m6Y0Kg8 o2kb/xyCLzoHcZ+KtO40ZCPNMFwkuHTfG0VJTJUhQq04o/IH8jBq6sRnhva1PLScHlE5 W47A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749734126; x=1750338926; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rV66TNaxM+tRVm0G56yg1ZS+Xb8QC9jIEshfuDQ8Ajw=; b=R/ExlELq/uEKJJeQew7xJrROZ1ZJPNtkPPFUrTzGTkH5N6vmycp0CJSBNEW1jEH75j TW5SKeQYHdc/A/mpAWfj3zqfS0sr0/q039DYB8p8fk+m2Xkr3VZ8bMSBc6/RefzvHWC1 F6NB/1BLHrj8q1bnNzpo4H4SklCTQ4hgDmG2+YF16jNDfJFL8t6x5KuZ9mns1WGHHb/K OKmd3iGQPQ/0R6XyJd35JhXEko2XGyNrcAu8SHm/KD1rdjT9+bPb4B49aFgwyoReEwj0 wwESNJ246PPqmzRfuGHWvYzzuJlDS7aW5BCFhB3c/lOib2qq1eN8oYpfG+jO67xh3DA7 zbog== X-Forwarded-Encrypted: i=1; AJvYcCWECvE+ZKsLYc/yHGrcpLXro3+kHcXMD+pJINrjfRNH+D1jT+T//fGBtvzDW2XTlozN+dbp2CsIuSxR25w=@vger.kernel.org X-Gm-Message-State: AOJu0Yz59pRv1HprrFbffXSJucVg1B2eZRYGEsMglhR2uFLCQ1qCTjUR mCygz2qHW9VDcCi4nz2HPl95IKoroV0d7CF0Mj9MjHeJlKFowcMkgDcFiCnytDCwKLs= X-Gm-Gg: ASbGncvd2Hw0LnJ52DgEBzqBbWT+DKHDHcqyAk3Mgt4wA6IiQjaxSYT3mS1wsA6cpkQ cHRtusWCODQJZEI3X4rB+zNqZnMHrs+9bvVEcXfEWWBcabL7LAYGKvqclnO8XeyqydYZPUpCHSe 2mc9l8gOqI2x8x8K1XS7qwQ9BP9KCN3UsEMI7tKU1waEiTdsSQ1fhwh4RqRxBlQe7EqMsyOI8jF qQbsJ3klMlvXjGfVNitU7W10nHAOlQqyaHl4VhtwVG4/+wndCRV0Da7m/io71aVEjYbBgBQu8sD iHKmulvkxXmxDEHD3eWXKS8ZQpkqT9beULmQNkqNeQfthmyeFY0WL3U= X-Google-Smtp-Source: AGHT+IE5mT66pzqKyfIajfIGyDumyvkC12XEvq6ZyTsCS1EDLoE+BveAXbQvq+KfiZgQjZVcNrQ5EA== X-Received: by 2002:a05:6000:2890:b0:3a4:f744:e00e with SMTP id ffacd0b85a97d-3a560749228mr2745803f8f.4.1749734126031; Thu, 12 Jun 2025 06:15:26 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8b99:9926:3892:5310]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532dea17d7sm20619795e9.10.2025.06.12.06.15.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 06:15:25 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 12 Jun 2025 15:15:13 +0200 Subject: [PATCH 04/16] pinctrl: mcp23s08: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-4-556b0a530cd4@linaro.org> References: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> In-Reply-To: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> To: Dvorkin Dmitry , Wells Lu , Linus Walleij , Bartosz Golaszewski , Patrice Chotard , Support Opensource , Baruch Siach , Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Viresh Kumar , Lakshmi Sowjanya D , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, soc@lists.linux.dev, linux-sunxi@lists.linux.dev, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2173; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=tEFYQzYr4zlLCNgvVSEeoX4S4CSsudf7dYRdU15AU4k=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoStLk00prsnH+1kwtr0kzg9zSLDkGxpKTnd0jQ 2950YwwAduJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaErS5AAKCRARpy6gFHHX chD4EACJYOau8Xi4fN3Ov3TIfQN7He28eIvwgT5/E20lExaBUJ2RaS+UWGxHsqkMw1AmYmlWwWe t7Y93zOUENY77UyolkyLKRIUoxa/rU5H3OHrxR2lzxEZHJGH1YIWDeKInlkQCAumxB/LbXOunlZ 0Y/7w5Jm6gYhBq0c1lN8zx+kW4v6xH/BPTgfbz69NBHIg3q1m4abQQAxZdZBBJmludNlRPCel6C UJPsLmXvRaKumW5SFMgO3g+EZmXP2+/9JPy6FjxR9s3ZudFN/Q/24bByS4PGOuwEQbQZ/bQDV3e kY5l+jCwcAmU1EVEx4qQGBtNC5fa/OK85yj1wOzyr/uthH7vQFFPbLUWpiccyQsuRRTVamFc12M QWX6OnGRjMKwUyfEtqgwONiGC7b8/73K1ihlB1FWR+V4d8DntIjO2Hm31hZNk2K9HHs3Tnoye/Q V2Akk29iY+g1pd6DQ7ZCeFDiZ3/mYjrgr4SVc8LRVbOn2YBqrTBHkVgXNnw/Vf2SePZy/XjLuLL JvbAmYmTxkDQvqDfg3xmLI6aVfLuOLlvIbEY2hY8lkxE6oPurqUc1v4mNapXqijdfpMojdcUefE KgPCcATeWN6UEPqxC1itvEf6yH+135QoxRLH+32f39jZeN54TE1MjPkkwy1eeo94ZR4lkUBs+CL R0R7Nzt1LEuaeUA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/pinctrl-mcp23s08.c | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/pinctrl/pinctrl-mcp23s08.c b/drivers/pinctrl/pinctrl-m= cp23s08.c index c2f4b16f42d20b0dfb0e1e6c79f8336392307c70..c8027ef03eccdf54809dfcd76ed= 8c07c424b41c3 100644 --- a/drivers/pinctrl/pinctrl-mcp23s08.c +++ b/drivers/pinctrl/pinctrl-mcp23s08.c @@ -341,24 +341,30 @@ static int __mcp23s08_set(struct mcp23s08 *mcp, unsig= ned mask, bool value) return mcp_update_bits(mcp, MCP_OLAT, mask, value ? mask : 0); } =20 -static void mcp23s08_set(struct gpio_chip *chip, unsigned offset, int valu= e) +static int mcp23s08_set(struct gpio_chip *chip, unsigned int offset, int v= alue) { struct mcp23s08 *mcp =3D gpiochip_get_data(chip); unsigned mask =3D BIT(offset); + int ret; =20 mutex_lock(&mcp->lock); - __mcp23s08_set(mcp, mask, !!value); + ret =3D __mcp23s08_set(mcp, mask, !!value); mutex_unlock(&mcp->lock); + + return ret; } =20 -static void mcp23s08_set_multiple(struct gpio_chip *chip, - unsigned long *mask, unsigned long *bits) +static int mcp23s08_set_multiple(struct gpio_chip *chip, + unsigned long *mask, unsigned long *bits) { struct mcp23s08 *mcp =3D gpiochip_get_data(chip); + int ret; =20 mutex_lock(&mcp->lock); - mcp_update_bits(mcp, MCP_OLAT, *mask, *bits); + ret =3D mcp_update_bits(mcp, MCP_OLAT, *mask, *bits); mutex_unlock(&mcp->lock); + + return ret; } =20 static int @@ -626,8 +632,8 @@ int mcp23s08_probe_one(struct mcp23s08 *mcp, struct dev= ice *dev, mcp->chip.get =3D mcp23s08_get; mcp->chip.get_multiple =3D mcp23s08_get_multiple; mcp->chip.direction_output =3D mcp23s08_direction_output; - mcp->chip.set =3D mcp23s08_set; - mcp->chip.set_multiple =3D mcp23s08_set_multiple; + mcp->chip.set_rv =3D mcp23s08_set; + mcp->chip.set_multiple_rv =3D mcp23s08_set_multiple; =20 mcp->chip.base =3D base; mcp->chip.can_sleep =3D true; --=20 2.48.1 From nobody Fri Oct 10 21:00:35 2025 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D67F624A049 for ; Thu, 12 Jun 2025 13:15:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734131; cv=none; b=tgwQHWoB/DShhAHw1jFz3MTyvXa4oG62wsUQ12Mav03z4NYuoweGrO4UVbJTjNZactkNWzWS4mB5MwkJyEMtAJ7N3dXV+hdCjjfIXkdvqHMzR87H8WHwz/10mtgRf4+5yBT/bT67CBlbWqglVggYL9hqTLblIA/8hozm1pcIoz0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734131; c=relaxed/simple; bh=kcI0bfI5H/Hmf5yZdyf0QMbThFtI4nWGLfbZ3WK0FlY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oRNn/UOUXUmTgt23LDs29VTcrZlHG1B7qFazDoc9wMjyzA4LfmvvFxMe8+T3UsL5S5jRHKE/ArmW0xpkqllPKAqbJGVj3zCoG+Fh9cAKj6a4MG3k5VIDAT48yWP+Wx9VqlhZoORuP6SCwHSyegkhyVRvB6S2u5chv7CTDXXRBZw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=kf0hl+oF; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="kf0hl+oF" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3a361b8a664so849777f8f.3 for ; Thu, 12 Jun 2025 06:15:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749734127; x=1750338927; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=tPh64evwrzs2XEZo26akT0hL+LXbpDIaNfa8zeCvhbI=; b=kf0hl+oF1YH8z2XK9SBxt88+4+55wGdV4bnjPQkPBgQb3QXeZIUvm0m9pP2PhD7dLg RhIDNpLUOSXaTMOmjXx35qqKA1fiWSkFTUC0AVlgDYYtiUlyspoy4sDVf6eIBqXBjFNA F6Xlt8beduzdKIf6CLjtdJRFHCq6G+xvgZAkUl/TCayN+pJafPyVPxyC+QHoXm2WnR9K slSRtzHCS/Q5kKY+ZUYI9yRtMVIDa8vYDf4YC23QZeSvdv/Dyshtg9FYsym42t26dI0D c1fTbZlVrQ7ayLcX89D8RwmQmyDZW+w/jKCwnFYKIgubbBhp45dQR2NyqSjErjeqRjJx w1bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749734127; x=1750338927; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tPh64evwrzs2XEZo26akT0hL+LXbpDIaNfa8zeCvhbI=; b=l7Rt+jBJfwOrv2PDFUCth4PIomwxCn689+8uc4tlnE0l2d5OXz4VtddbnLvJvc8jc1 BOCMQUcIB2PFX2NT5btSYoz5uP7GTaDrSpAKnt1/u1Lom484xIpsMDx4jNvLPrt5AdrA yGimuJp4HpOFijK8rIgYkDuzvGpV9vgHkR2frKmlhpw271Iz7dLjVaogR9UnE3GY6CKh sJh2czXrv/9htF37oKFiwQiJigbSJMyML/eGnzlh3jY0wm0cehijb1o1irEkkG+OLfPc QQ6WYpTJoZQsFJ5WvZlfoKhwm0GAroRK8fcSo1OGUd9a25RPPIjcUvHZHptC04RIPrpz 3bfw== X-Forwarded-Encrypted: i=1; AJvYcCVrrJBgaB378BOWgaKQJfhnmqlSP8wZehxHjdwzSEO2mf5bJxDE9vaULuXPT61cTr9Yp5F6G6ByqS7gc4c=@vger.kernel.org X-Gm-Message-State: AOJu0YzCLX5PBvPScO6dUA3WutaXVvpktryVf/cM1qAV1qyIBi22r8CE 9JrfomtTdUZaKklwY7HNpW5mkbrs8a68A/b/znoyDsKe25pIYzOH7+3VD41hzfinrdg= X-Gm-Gg: ASbGncvv1YUPwkAaUImivAjdVOp71A5xgzWpf5hjFNwhVSFnBnZZAPH8DtdDTTkvGzQ ORhjtKanjvEPlvT5W6tJiUM0SZohqM/p6xSgEv4nBsP5hhF1Daf6ztYwz17zeWlkkrA9FouYz1E yzHPF/7KKgXqYth9vD4TH/3gbXcw0zCT0VgAMyS6NhdkeO9oM0nRZzibxAvUyL4vEOpiPiTRodu gxNajhsAMFZ7GBrhSL6qkuUzRWT3ScBUG19Sxg5fUp0TV3VGyDtxPKSMYTUyP9f9/ZwYpqZM8H1 DBpU+cok9xpSJbF4K33IfQ/iM6zFrpZx4OLUkYx4Qo3qI03pu8x50fkNqHQVubc++A== X-Google-Smtp-Source: AGHT+IF8dQFZu3267rnqS9T+MlnDpsGMNr4UhOIVEWZlRhW8ilrSLXmT3/L/LQod0dJlLDDEHru6ig== X-Received: by 2002:a05:6000:2505:b0:3a4:f7e6:2b29 with SMTP id ffacd0b85a97d-3a5586dcc29mr6204277f8f.5.1749734127149; Thu, 12 Jun 2025 06:15:27 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8b99:9926:3892:5310]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532dea17d7sm20619795e9.10.2025.06.12.06.15.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 06:15:26 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 12 Jun 2025 15:15:14 +0200 Subject: [PATCH 05/16] pinctrl: wmt: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-5-556b0a530cd4@linaro.org> References: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> In-Reply-To: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> To: Dvorkin Dmitry , Wells Lu , Linus Walleij , Bartosz Golaszewski , Patrice Chotard , Support Opensource , Baruch Siach , Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Viresh Kumar , Lakshmi Sowjanya D , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, soc@lists.linux.dev, linux-sunxi@lists.linux.dev, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2065; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=zZBlMtHKzzXioPhlG1XBi+lA5WvGdR2KtCyPxbjRVIk=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoStLll7sZrjDKxB+yIfzZvsGDAzsgGsNSphici P1S3FHTYBuJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaErS5QAKCRARpy6gFHHX clh4D/0eejaFFeaR28Vf6ymty4cRxtkyHHnZyl0oNIAQK4k2LKxfyvv1Uvm5rcDeJyn5YwvFLUM 63wQ/V8f3n0FvrZ0akyzb4OoY/gTGr9TqBrRvfmdw3r88RstUyCq+LAePz4qg737URegvsmvcqD d0sTmTdeWFE8SJUqM1Rthnrc32nwNGmdogrzN3Y3ZySLnrLIrGYKfwRv1uaBnPxjdZ92ZZp7S3u EkfpWxLbbosC+cqD7juqS5+lazxS8yOH2tC8dPPUxwYFwlA/yuIElg3a5eB1sSMrR4EGmkb2RuG omLdr7y0eoOfBmNyoHulUJeZERWMiUDyTpZuVWgKEfCYdzgb/Ti1935juLv1SrhpTfvkpL369DG saMpzPev+8uD4fKF3iWymk7Rpdk2zZ+93Ey4bGlSG2YDdgz5qd31nsBMFhvQPWVdVKNty0XtRyX mt0+a9PFIVXl1mjGeDhyldfzWKuR1cd3kDzod6bLGisrs3zMUq+/Ru0yBalUAzuB40k9boYhvhv jfa8sc/Rp5eAZ3YSb7LDTNEf9m5zWmWu2wMBGWlQIS0JyYZqtY+6j37fbI16nOHQgPZcd9zGGG/ cvIur8XbL1wPUk8bK7ZObQF8wT/Nu0GAH+UK2fj/hAJAIHmRY6Vy2gaw9fAM0vxRT/AEE2HSZfC 45zRTemNQslYrtA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/vt8500/pinctrl-wmt.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/pinctrl/vt8500/pinctrl-wmt.c b/drivers/pinctrl/vt8500/= pinctrl-wmt.c index fce92111a32e4976bd31c7e9845e4fd08a7affa3..767c6808a463ede61aee61b63f2= 8ee38185b7633 100644 --- a/drivers/pinctrl/vt8500/pinctrl-wmt.c +++ b/drivers/pinctrl/vt8500/pinctrl-wmt.c @@ -507,8 +507,8 @@ static int wmt_gpio_get_value(struct gpio_chip *chip, u= nsigned offset) return !!(readl_relaxed(data->base + reg_data_in) & BIT(bit)); } =20 -static void wmt_gpio_set_value(struct gpio_chip *chip, unsigned offset, - int val) +static int wmt_gpio_set_value(struct gpio_chip *chip, unsigned int offset, + int val) { struct wmt_pinctrl_data *data =3D gpiochip_get_data(chip); u32 bank =3D WMT_BANK_FROM_PIN(offset); @@ -517,19 +517,26 @@ static void wmt_gpio_set_value(struct gpio_chip *chip= , unsigned offset, =20 if (reg_data_out =3D=3D NO_REG) { dev_err(data->dev, "no data out register defined\n"); - return; + return -EINVAL; } =20 if (val) wmt_setbits(data, reg_data_out, BIT(bit)); else wmt_clearbits(data, reg_data_out, BIT(bit)); + + return 0; } =20 static int wmt_gpio_direction_output(struct gpio_chip *chip, unsigned offs= et, int value) { - wmt_gpio_set_value(chip, offset, value); + int ret; + + ret =3D wmt_gpio_set_value(chip, offset, value); + if (ret) + return ret; + return pinctrl_gpio_direction_output(chip, offset); } =20 @@ -542,7 +549,7 @@ static const struct gpio_chip wmt_gpio_chip =3D { .direction_input =3D pinctrl_gpio_direction_input, .direction_output =3D wmt_gpio_direction_output, .get =3D wmt_gpio_get_value, - .set =3D wmt_gpio_set_value, + .set_rv =3D wmt_gpio_set_value, .can_sleep =3D false, }; =20 --=20 2.48.1 From nobody Fri Oct 10 21:00:35 2025 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B67224BD00 for ; Thu, 12 Jun 2025 13:15:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734132; cv=none; b=h+TGvsefB0RG7mQScDAP5fx0xXqRNmZ0EQAwotgmiWecrDZCGT4GsHtViVwh5zhxPrI18Fj7z/wia0Pqk+3qLnR6I+7SntCNaiptFQvhbaAiwR54KBBOPywwPyL5rUeSB4+mUQLDS1KWS39owSs4+O9rqfUba1GT+Vq6NGvEWhY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734132; c=relaxed/simple; bh=+NK8m5qrc1KmJw+Fk/qnUNfnygvAI3Ur756wHpi5Soc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bN2qn1+JhefEfjj0ACGHegU4hTHInMHqkYw4HbQvhRLD92bjYp6+y7GsXUOX9P+78bM/WCcpMEsh+uOQOrQifMdfC4S+2QZ0ZXzEnOLB+0EkzhITo+rZeac0bAsew4YgdJWsHt00DxYB+lhE9EFcBYICfXAmsC/mLNg1LV/g0Lw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=oS3PdEV1; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="oS3PdEV1" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-451d3f72391so12369855e9.3 for ; Thu, 12 Jun 2025 06:15:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749734128; x=1750338928; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dpryYjr6dJZUJcBNCU3DY41Q8g7jIiX7s0MfCXnX/8U=; b=oS3PdEV1glOiO+dhgwzDHvtjJ0ljcJ9MqtjcyAvpxdB6+nD2xhaVy1jd5aQebdqKv4 OSF22ls02ZBjuoG4PFiYt91VhNy/1gr94GMZY3gCMxKtoZF+Zhv8pOx0kaHqYp9aKHv8 bOUoy55PxDf8IuAFkoiIqwU1TTsM++WEOlr7ETR5jE4z9rIg8aWBgkIWCLEvhQrTYibq VTVpr3lBZKVAUJnOUrW7iJeDl7NIZYE+e5NP9brJJIP0d46VJdd0o68sq0tI+EYpsXVF 9kRF8tb4zbb4+F3HF3LGwO/eVTFRccjkCPcyGijGAskP+y7mE58sS+TZdRRGNz8zR6IL Y3sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749734128; x=1750338928; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dpryYjr6dJZUJcBNCU3DY41Q8g7jIiX7s0MfCXnX/8U=; b=B4uEVyw7T7qcRArK3gk8Nf9lGuwowApSRX/z+am7TYbbQLBp+l59Q2wtH8bYQAaUCY 4zUMdqVtJflKx5yUPjxqzdsN1hDrcFUJspE42ttZ5njUbHIXVq05kK/8F38aGPez543h gAXf/I/HF6ka+HP53zu5HgrcwfupbVOiFtOx3L6zzaZodP4hE1cxV6DwhRHELxkOi1Tu npi0Ad8l1v9Um2gouX9oMoSzxyqX2sVbRNzIi/kRDnhKxMZXznc3kaPzqKsLv4Jpxwf/ ek58rU/bnla2RNTaPgrbj6g5WjKYlvaLd9PKDIB0zlR7wtI9MaOUULFbdu8akeawWS9G 1Ybg== X-Forwarded-Encrypted: i=1; AJvYcCXlIybGaDtHI5RnY68jTiOdMe9qtmlutNnp2v7JIfor5QrOS2ZhEHYNaAhS3oaV5lUkV380aCaAYiTyZrY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx21pmenYX0n/6N1OQm+x0fLz4hdv1ZHWevKjKdelYl9QwqQB7M 3Ni79Wh7eOBBuu/jr/ehlbngRJjXCcIzPVQXqY5WfLVRDP4twNx8UbXSpxloVu12H6o= X-Gm-Gg: ASbGncsHWe7UxXWZmn3Hs6mRUFt9D8U4qJW3oFKtIZVlxcbsnAR5CRfXNArnpAdBfei 722d8giSX0Hj6ZryUYzes5PxDuIX5H2qcJHBoplZg2SQ7w7hXwiGm/DCabbjr+PgtuHyPh1oJHY jz3VlrlvN1Os9FrbdE2E4v5umX/oIexTMOMOxJ4rIZvWqv8vA4DLqeE9v/OzlNwn2SWYV2yZ3gB 2bsCqPqaj551YrxCKxzjriJx2izsiA8kaMFGZPz0oZyC5V46xVx4Y2vmDsvIaCOqRY1vQfaUz3+ e4rWNT50AQDVgxj2UtOslcDpe+1xTSzcLHF6lAO7Ifi2+1Flst+s1zeI6s8SH8Tc9Q== X-Google-Smtp-Source: AGHT+IHYhHp/jvxkulDT8caAK3JFprrXp6WBLQybVLzjI96KoA3fZGyckOWajuSkl9W+4oQhpYhEmw== X-Received: by 2002:a05:600c:5291:b0:44a:b7a3:b95f with SMTP id 5b1f17b1804b1-4532b966af9mr29139925e9.25.1749734128225; Thu, 12 Jun 2025 06:15:28 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8b99:9926:3892:5310]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532dea17d7sm20619795e9.10.2025.06.12.06.15.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 06:15:27 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 12 Jun 2025 15:15:15 +0200 Subject: [PATCH 06/16] pinctrl: aw9523: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-6-556b0a530cd4@linaro.org> References: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> In-Reply-To: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> To: Dvorkin Dmitry , Wells Lu , Linus Walleij , Bartosz Golaszewski , Patrice Chotard , Support Opensource , Baruch Siach , Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Viresh Kumar , Lakshmi Sowjanya D , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, soc@lists.linux.dev, linux-sunxi@lists.linux.dev, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2777; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=/k8zafhiaZ5lNZ/R4/TDowhHogmpS6F04NS8uK5axS4=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoStLlAWn+gixCdfC0imr4N4CjdzgtOVQSb/c3U huOoAJ6Hj2JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaErS5QAKCRARpy6gFHHX crzhD/0T0e3xmRZAZFh9L727loONGDCc4JHCYoraLqm9oW7X2GMp5bsZjgzR9lIpJTcS2lz2/50 7K1JpLe+3IV/JM3Jsuje0k5O9ZSzUrg7tWjzcR5APoxHEJVxL+esq136rwbVMiMUqJdB68n9Ohb 2as5Wk1vASZi13ROmULzSgpb3+uiQaAGkDcpL1ieFstxBzDZS34ojSuMUj2pzkeZpu4qSMsmpV+ j6o1OXBEOa7XzItsZ+wdhDVDjo74LIH6w+7ZetDer8IKdulsgwMsiIpL90cW0p0COp7+nXuI6kh 32Yb8Zw49Z6wxkQQpps9iwDAsqLk3Q/V0EOnKLPvJPtJAG5pc7lojKUwGfj1X9EFl+Q8VlEiCTE 7Llv1zB9G9hNDtLE9U2hT7toep6c0798QQ3teRYgyLVERdkGjpLfL5kdV1GnnUYUmavpJaXikA7 wfngkE49CVSCKrsvtodJj3jyvNergEk5cGDqKSa/m3yHljlRrQoDndSM/+WnK8r3LToblbH8Jep xs0ev/kWXAJHtnIhiwALmT2dtnHVAVV2m1aqDyabjB+ozDZ8lYW1USpwg/rezqcCY/d3pLF33qp Ely+uT5GKTkEsTBk4pIujiVaFHqyLFnGLWFBMvPVxOEDVK0Grf+UJ3FowqoNFYx6FUGLwXpfdlX 6Hw3h2VYdTU5O1Q== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/pinctrl-aw9523.c | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/drivers/pinctrl/pinctrl-aw9523.c b/drivers/pinctrl/pinctrl-aw9= 523.c index 9bf53de20be874661168ba28f64517b4325ce0c3..c844540384198f40f1142528d81= 5fb6e4d5194b7 100644 --- a/drivers/pinctrl/pinctrl-aw9523.c +++ b/drivers/pinctrl/pinctrl-aw9523.c @@ -625,14 +625,14 @@ static int aw9523_gpio_get_multiple(struct gpio_chip = *chip, return ret; } =20 -static void aw9523_gpio_set_multiple(struct gpio_chip *chip, +static int aw9523_gpio_set_multiple(struct gpio_chip *chip, unsigned long *mask, unsigned long *bits) { struct aw9523 *awi =3D gpiochip_get_data(chip); u8 mask_lo, mask_hi, bits_lo, bits_hi; unsigned int reg; - int ret; + int ret =3D 0; =20 mask_lo =3D *mask; mask_hi =3D *mask >> 8; @@ -644,27 +644,33 @@ static void aw9523_gpio_set_multiple(struct gpio_chip= *chip, reg =3D AW9523_REG_OUT_STATE(AW9523_PINS_PER_PORT); ret =3D regmap_write_bits(awi->regmap, reg, mask_hi, bits_hi); if (ret) - dev_warn(awi->dev, "Cannot write port1 out level\n"); + goto out; } if (mask_lo) { reg =3D AW9523_REG_OUT_STATE(0); ret =3D regmap_write_bits(awi->regmap, reg, mask_lo, bits_lo); if (ret) - dev_warn(awi->dev, "Cannot write port0 out level\n"); + goto out; } mutex_unlock(&awi->i2c_lock); + +out: + return ret; } =20 -static void aw9523_gpio_set(struct gpio_chip *chip, - unsigned int offset, int value) +static int aw9523_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct aw9523 *awi =3D gpiochip_get_data(chip); u8 regbit =3D offset % AW9523_PINS_PER_PORT; + int ret; =20 mutex_lock(&awi->i2c_lock); - regmap_update_bits(awi->regmap, AW9523_REG_OUT_STATE(offset), - BIT(regbit), value ? BIT(regbit) : 0); + ret =3D regmap_update_bits(awi->regmap, AW9523_REG_OUT_STATE(offset), + BIT(regbit), value ? BIT(regbit) : 0); mutex_unlock(&awi->i2c_lock); + + return ret; } =20 =20 @@ -779,8 +785,8 @@ static int aw9523_init_gpiochip(struct aw9523 *awi, uns= igned int npins) gc->direction_output =3D aw9523_direction_output; gc->get =3D aw9523_gpio_get; gc->get_multiple =3D aw9523_gpio_get_multiple; - gc->set =3D aw9523_gpio_set; - gc->set_multiple =3D aw9523_gpio_set_multiple; + gc->set_rv =3D aw9523_gpio_set; + gc->set_multiple_rv =3D aw9523_gpio_set_multiple; gc->set_config =3D gpiochip_generic_config; gc->parent =3D dev; gc->owner =3D THIS_MODULE; --=20 2.48.1 From nobody Fri Oct 10 21:00:35 2025 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FCB124C676 for ; Thu, 12 Jun 2025 13:15:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734133; cv=none; b=N5+1DFWSEkHONyVONyBFxnEYUjwc2tOXpl6hxHX2qmQ8bUvTs2OzsYcMrFhv8Rq9sWJIy36IEmE+yHK2gPOWw3b6Rc65Hc5x/dsitqPjA/BljzuCW6v5aNOZNTqd6Z4zkz+gJAaLcSZM/1X+kBzeuON0/VzXTWPO9C7AUUc7An4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734133; c=relaxed/simple; bh=w0yxq9GrB5wxpDo1vCkzUf7jDpYrthjvxTQ7Cy2YDBQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=r5xUTBCRd2SiQbl4pJAaEEQHzLNtvBdC5qSiQlDxwTzYl9ePGkAlAvrzUckh79IPo+CViGEeooM1V2zXoJSLLGx1gV0NjyAf22kHSFPl4LYVLpcPivPFbOvUn3XOkIoh2skP5/viD8qzxtZHPc/kXXACxreE5QbfetonsEIBnHo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=q7Gq04ym; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="q7Gq04ym" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-450cfb79177so5342705e9.0 for ; Thu, 12 Jun 2025 06:15:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749734129; x=1750338929; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=JGXLWLYyw9ZyCRb8Qq3Tm3IRZiXBZ5znvzTh5cF4+vI=; b=q7Gq04ym2orqMBi7Ku/7AwQgKHfZNQsXkbJ1YjDeFmzesRAWZSeN2MRaprBe/x7syc UQ0SjHFWykfr9AP59NZGVp79zD1tD4BXhTOsLAKelQadkjSxp9LLJ4NJ0zWpw7sUtObh 370c0gAX7BxV8/wMRuaYbYaQMOkhgpKI3vZSypmKg6Tu+I7p0+5ZrfuLUrJ6NEyzPKQl xL3FMSCkihfBiNS4EnKkldqDEcqll/PRiDhhIP+157xtmFWy4xIZamCK2onwgm6O+edB okfmk7R4quaA8FZp4ydlFFTUQkpwNkYRle4A5D6EO8lAqfHNmaw+dQ6qefphzMqjhGCn IICA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749734129; x=1750338929; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JGXLWLYyw9ZyCRb8Qq3Tm3IRZiXBZ5znvzTh5cF4+vI=; b=J65Mh6Lhl8vHCID5KXYI6y6HNPuujA9AAGW5iO9QQqghRgK30+8i07/MppufUSN/ux h3ov/I1+CIVeM/y/Nla9+TB3k+aUdJh9lOhpGCyRYS9lYOIbT4ujN04bJxx9n3YZhgsz 5KUXkqhJMpqhQ25AdqLD0VToZcL/KmI0adYHTnZvDGxYF8fLs8eDsn8F3h52bBe5BFrR H02JtEwGRNv9ToVREbKJxazEatkVqtt0wMl7ERwwKBn57V7D9kvgmiVRpCNwrrIsdeYG onzu+zzItG/Gd4EePOWPb2Sm4uIoHau0hca+A66XM0O2d3r2h2u8krkUEXVjeg1HTb9E LCrQ== X-Forwarded-Encrypted: i=1; AJvYcCVhYQJ7SPKm7dslJeIHPKNLBx4R9Rz3d7ctmBYMP/fsgWk0JjpaZAPFyZ7vJuIqBvs429HAMLYb/ZkSpNs=@vger.kernel.org X-Gm-Message-State: AOJu0Yynd+mTY98hbnX3yPMMCdXrYvnn7INs4oENIz5RxfNC8bUAAP1F H0ZL8kYkYvFTNwylEsL6ev+Q8jDECDAyy2hHaUyG960/JR+ndFsdDh+y5pTPCb+SiRk= X-Gm-Gg: ASbGncu+X7ioYoHxyW0QNN/fZz3fx5vEtsaCELEv77mh2GiFQE9k42zrQiwWrlwlAae 5qHmLCTLDJqp0bgOfg3KDniFqQ8rqXHmrexemNJTujUCPX7siKF5EPyMoYNyz5KUUL475i2nSv2 T2UbYxVE9rLBheu+rDoBcrYN7uEY/UyvNByU1zPYb56sX37MZpVvaadF8KZjPEnMvv8gMjXRxu6 wwU8MMbdoyGVhnPNvj6OJDhOnWzC4xL3t4z3uV4HX9hmLtHCtCETz3WpsOfK+xAogxXUZ4IOirV +D3G83J8M6tzqxCWEVcwP3K5pFU/qOjgG7oDiFNZyMMbIIzzluGMZFo= X-Google-Smtp-Source: AGHT+IF9IZN2MS+sYW2ouGCv5DMbUlGfHcNRSDur1nJMOJwR6mhtfhHbo2K0m63hGJZ7Lzm9t37Sjw== X-Received: by 2002:a05:600c:3586:b0:440:6a37:be0d with SMTP id 5b1f17b1804b1-4532b8c2c9amr37528825e9.15.1749734129300; Thu, 12 Jun 2025 06:15:29 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8b99:9926:3892:5310]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532dea17d7sm20619795e9.10.2025.06.12.06.15.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 06:15:28 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 12 Jun 2025 15:15:16 +0200 Subject: [PATCH 07/16] pinctrl: xway: statify xway_pinconf_group_set() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-7-556b0a530cd4@linaro.org> References: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> In-Reply-To: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> To: Dvorkin Dmitry , Wells Lu , Linus Walleij , Bartosz Golaszewski , Patrice Chotard , Support Opensource , Baruch Siach , Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Viresh Kumar , Lakshmi Sowjanya D , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, soc@lists.linux.dev, linux-sunxi@lists.linux.dev, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1006; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=9Q3bm/CeNxC+8oeWa7fm99HCVraMx1u7Zl7EzaVQzgw=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoStLlNqDuphL86C99UAAzPjSE0SJSMbsWkwcvS zysyjdjnZKJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaErS5QAKCRARpy6gFHHX cim+D/9Yvh9pdH0HyHsSxQ03GvnN1C9sg0macmAjL6e0GEFn8NRgOxEnXwKbStGp95OJYoTJ66D jGvdoiWzR8UqF6TssAx9xGFIRvMWV6PZ5DknaE1I8c6T74vJmoJhu93H/sDuwVLrTn+/DU2mCFA jnPNftQI2C9KH4WKcwsW6p88+VkRHVVojR71vHqEly1CvfsUDt1YHdfD0b/i7sD4U6wKsdF5Je8 dfcENemlDbwdAwAgiGY5Fh8LbLSRWPLeMG7zzrMuVwW4epppnpeSJLV6UKgrCgz/czoIVYNPyDs Rf87bKBsOdzu2II2sLqjC0FpkgsgGpfEK4Y0cgLsAHYSnu+AzsTWVPKtM7UVYZ05GRHLuxcKgXU PjLnEUr3bR07xBoubOEXOjQKtoV2wcZ5/dLlfo+MaNMT3ub0nw+qNhQMbGGSdNBqsTZcCLcG81u qxqW/N41epJAzbgUyQziedQdsAi6pZtSYrCG/HNuuBhbMSTwQTKr9mA5lODj6UwJC1c6owybPjp cPVB2E90EJN97TqqmSlpCm5As6SPt63bD+uj0RihsW/Y63BWIS9e33rzwyS8251w5U21iErEzoU pk8qWDKqMb8tuCs1JuJf5+bZ69qI1UzCzDmGyaad1Ncn318qefMNQozIPqs0Jk07IWgHAFzqn7Z KLFaSAY7+IyRMHQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski This function is not exported and is only used locally. Make it static. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/pinctrl-xway.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/pinctrl-xway.c b/drivers/pinctrl/pinctrl-xway.c index 48f8aabf3bfa3ae18f3eca8ea00c6e796faf4500..02e65d25e72911b812446ad4b90= bfd611c9c1714 100644 --- a/drivers/pinctrl/pinctrl-xway.c +++ b/drivers/pinctrl/pinctrl-xway.c @@ -1228,10 +1228,10 @@ static int xway_pinconf_set(struct pinctrl_dev *pct= ldev, return 0; } =20 -int xway_pinconf_group_set(struct pinctrl_dev *pctldev, - unsigned selector, - unsigned long *configs, - unsigned num_configs) +static int xway_pinconf_group_set(struct pinctrl_dev *pctldev, + unsigned int selector, + unsigned long *configs, + unsigned int num_configs) { struct ltq_pinmux_info *info =3D pinctrl_dev_get_drvdata(pctldev); int i, ret =3D 0; --=20 2.48.1 From nobody Fri Oct 10 21:00:35 2025 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2237124E01F for ; Thu, 12 Jun 2025 13:15:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734134; cv=none; b=sjmrRohuH2jTp/DQupiK833GlXlVFyUb6+QBUMu2FADMZzSsDjIrdt2PCpxC0/RK1cQFz+5pGsMc+rl+UXu9iwk0MWlzh/dd/C3OcGQXSzyI0dhss3VpD3Uf115nHFinr4829Fomaz58ChXE8ylrI4VPKiVGkMSF9qYat8l4+jo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734134; c=relaxed/simple; bh=DCdQEcUDLTTl1/hH+Diq9E/bx+GpQ/RAE5sx+LPA2K4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cS3u8+A6vslBkgzdyde77vd4QYnEJGTrzVSqy2XefORXIgyzNHpHDNSXeHe145GIVpGzEqz39YWQeJx8kmofExNWWLFLKySF5rOmqO6i8ZlVA6ZTxtmVAPmr3K0FMjLw2ezTVeVRhF/b0zT82x/fs4FWNTZJTDDU5MYjhtuigX0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=amNVPMv5; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="amNVPMv5" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-3a531fcaa05so545674f8f.3 for ; Thu, 12 Jun 2025 06:15:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749734130; x=1750338930; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ddos4D+qX7/1EnT+iqN5KagM9V0p0W2P3w/4kWY208s=; b=amNVPMv597kPo5AbSI2ALOoyyMalcc97LG/14gUbwQ5jPogXtEwzUcNPmLogapk30+ Nc8REkfJzWVcu1mWAzOhvjfHdvKE/5RdC44vbt3LeAQzI+TLtDU0GezCzW9Nt3IWpB9S /0smo0c9YpDRsn4JhgJD8T8VKx2Qy5nKioc0D+VDHGEeCkbbmta/T303xuDr5mxrErAP MRETg2wF+ewOqmlg6TGs5c+1xOP2OR5ce2s3Ktd8rjPBDeihPbBuKw0z1J/FCDke1YRO ooOOdzCPJmlbS64iF+C0IKBr969kWOH+ALpt9Kl79q/YV91FuD57P4/wM33YjK/VO8AU HGYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749734130; x=1750338930; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ddos4D+qX7/1EnT+iqN5KagM9V0p0W2P3w/4kWY208s=; b=S0H3WUuHQnkx06d8lFX/zX63ZQgCqKkquUvJipyGZbizmKaiV+qoMtMbcblMvSHAje 54oddIiVDNbrvgjPM8iQGse0cBMecQcIDViwhq+V3fBp8KLFD8I+HESzOIXLziEeWLoR 6iZ7UzGBahBDsEqAfcaGBlLGjq2j/VltGy310YZqxe9luFd5+iEn/3x8gIMVx8cOoU0V kiSqcouzGhF+hg5LLCngIsorn0CS9kDQC4n73Uj4JsjcLYsawweaErmsPnlezdoikU+t rhqnprsGI1qP+qrcp4uoAYv/LKV4Zzhrp7RNixhBFngG+8ikMFRlZEunbZU2Sc04OZN8 BnaA== X-Forwarded-Encrypted: i=1; AJvYcCXgRm+HfsuUBxDpBP/DoapM9jbbacFU0KS4yv3IUYKMW4y9CZrWohFm4tdXQEASVR/yKWhkITwHs4jg0jY=@vger.kernel.org X-Gm-Message-State: AOJu0YynbJOR9PIe5ZiwfPfrqYptS+LT2e5J6iAUJAcyGwl8G0QpHUJD uiwgg+uStlKyjomXH+GPLXg7aC/D9lDAUZoUmGXTcC/2WKCSuH1kwPE5ChH38hDbiyk= X-Gm-Gg: ASbGncsCpPUvAR+919cWtu/2SjzlGpGv6meuBJfyflZtzIUEWJqp9YnB7m/ylh3q3Z7 0IvoCFqgsCUDumSHKhEXC5VAQ6rqozvcavRueDagH+ipLGWDbxK2RjjTB1HF1KjUWX6SZsl61NN VdiO5XesUtDNNNHdWTFQztR4RjJkh7Sc1Zhbx3Y4e4ssFbsFOJ1iHmN9KaydmSU6jKI3/pDq3Zr kYXH8iCa+pBa2XfX6XNQzQkaA8EEo7eO8ZlqpiotSgb9xO1X12+qurfnnsSOoncGe5b4GcX0Xhl nEuf+UrYmzFdOUTVUP+8Tu5OMMRMhkagaDYaNWw7g2jL2hbGTtRsrbs= X-Google-Smtp-Source: AGHT+IEjm92mzG6iTvPU0aaqMJR5tJjcC1kKUVwpXp7/ZRJdx/YJfK1/AxyJNMPRaZiUgO8dI0ZM0g== X-Received: by 2002:a05:6000:18a2:b0:3a5:3b56:974e with SMTP id ffacd0b85a97d-3a560694b22mr2626108f8f.6.1749734130365; Thu, 12 Jun 2025 06:15:30 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8b99:9926:3892:5310]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532dea17d7sm20619795e9.10.2025.06.12.06.15.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 06:15:30 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 12 Jun 2025 15:15:17 +0200 Subject: [PATCH 08/16] pinctrl: xway: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-8-556b0a530cd4@linaro.org> References: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> In-Reply-To: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> To: Dvorkin Dmitry , Wells Lu , Linus Walleij , Bartosz Golaszewski , Patrice Chotard , Support Opensource , Baruch Siach , Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Viresh Kumar , Lakshmi Sowjanya D , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, soc@lists.linux.dev, linux-sunxi@lists.linux.dev, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1950; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=83dVwDjCWymw8bEavhDOHIM+hxScalMSI8x7KJC7tWY=; b=kA0DAAoBEacuoBRx13IByyZiAGhK0uWivjkySga8kTnFeUwUE68bmLo7YM/dAt6M6sI+TJxUj 4kCMwQAAQoAHRYhBBad62wLw8RgE9LHnxGnLqAUcddyBQJoStLlAAoJEBGnLqAUcddyEcsP/0U/ lQ+/N8a7qZ3Y1MwY7dHUJKTAx5Dfzvi0QNp3MMjqS8cvsbF+baaAXMW8ngmt+x64NWoYANmZ6bH 1lRgsQ8pUweyVIBotIf0V1huvpTG5o6r6v6jVRpqLWw6OTMlDXHFcbpZDl9MFXQm1LgD/gNqkaR pOAY8yWvG5YXJGzz5PaZOxE8Dn81QWKgYwJh0kY4qgqOrIy5eefHE0LjmtWWWvlpkU3unM5uTWa k8Rw37a2U49NeIX1dz7lM8O7RicIdC/a8YqDuRkU99HRBPnMawH93t9cSlWVVqi3rEzt9nMMlZn 8YZVHGwgC2TaJWyVzd+3zMJy2wqx94f4WFgCMk7oK98TbH6VaT57g3qyYorVUBPJ9DuYeiHN3Kz 0VXawdCFHV4VwHWhX13VnGIo5tHIFn1PCQxKz6LysoKHrvPDXKdvVduU3lAOX9d4IUiND4hUSPx 6kD6UrXqaS9XCdctmTZROU1jqUSo+jSET9EqeIsb/TfqSdc7CBrSiyFIKaTXDZNVF0WAhJA8rN1 yANcZDYks4P2EiL/bRon27uP/947tNFjIXoY4QHGBfTBfi9DSQfyCoIoLs0SbXbofzs4A74Bxgm PE5Q269V5ir7Xb+83MPmRPLy4bK/9pOzT3CdEFZfGMhdoZZ9bpHDY0j6tS3nlEPrf6rllqjrk3V U+5o7 X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/pinctrl-xway.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/pinctrl/pinctrl-xway.c b/drivers/pinctrl/pinctrl-xway.c index 02e65d25e72911b812446ad4b90bfd611c9c1714..53c6c22ff24d752ba66bdd8d46c= 860bfd9a93731 100644 --- a/drivers/pinctrl/pinctrl-xway.c +++ b/drivers/pinctrl/pinctrl-xway.c @@ -1293,7 +1293,7 @@ static struct ltq_pinmux_info xway_info =3D { }; =20 /* --------- gpio_chip related code --------- */ -static void xway_gpio_set(struct gpio_chip *chip, unsigned int pin, int va= l) +static int xway_gpio_set(struct gpio_chip *chip, unsigned int pin, int val) { struct ltq_pinmux_info *info =3D dev_get_drvdata(chip->parent); =20 @@ -1301,6 +1301,8 @@ static void xway_gpio_set(struct gpio_chip *chip, uns= igned int pin, int val) gpio_setbit(info->membase[0], GPIO_OUT(pin), PORT_PIN(pin)); else gpio_clearbit(info->membase[0], GPIO_OUT(pin), PORT_PIN(pin)); + + return 0; } =20 static int xway_gpio_get(struct gpio_chip *chip, unsigned int pin) @@ -1328,9 +1330,7 @@ static int xway_gpio_dir_out(struct gpio_chip *chip, = unsigned int pin, int val) else gpio_setbit(info->membase[0], GPIO_OD(pin), PORT_PIN(pin)); gpio_setbit(info->membase[0], GPIO_DIR(pin), PORT_PIN(pin)); - xway_gpio_set(chip, pin, val); - - return 0; + return xway_gpio_set(chip, pin, val); } =20 /* @@ -1354,7 +1354,7 @@ static struct gpio_chip xway_chip =3D { .direction_input =3D xway_gpio_dir_in, .direction_output =3D xway_gpio_dir_out, .get =3D xway_gpio_get, - .set =3D xway_gpio_set, + .set_rv =3D xway_gpio_set, .request =3D gpiochip_generic_request, .free =3D gpiochip_generic_free, .to_irq =3D xway_gpio_to_irq, --=20 2.48.1 From nobody Fri Oct 10 21:00:35 2025 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67F1E25A2D2 for ; Thu, 12 Jun 2025 13:15:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734141; cv=none; b=KwJnY2CDaBldYWJ+FPltJWQH2bwLssK0vGoONeMSRWTCjWwFkJ2wwmUc6vAFs4kIZm6n5M9MQypiA7K0Cnhfe7NbNpKmJqvk60JB7pwRm9O9o/3N8zF0129JkuuOxd1KnJhY/ySpk43GpWnwyg/o6MlA1giySQWFBc2ZJ31Qr80= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734141; c=relaxed/simple; bh=pcmGu317gTZwAy3/dan+A6JGqZDrA3MuzLVFRN4QaD0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OZH052BJQJ8OxwWmKAVjNdPdSNqsRkFC5uCYuP+bxz12egfLSlW8yKFQrzdBI7Lk/KA+8hXEPT9PrO3t4u7MIdE/2zJE9mmmBaur2sMlUwhAd1LJcV/hPLHiGGdQz8YQc03fBGeqx5bSMikhEsDF2dnuXRZhj+7KbHMpck/sGx4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=HuvYGx08; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="HuvYGx08" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-3a4e742dc97so1396894f8f.0 for ; Thu, 12 Jun 2025 06:15:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749734137; x=1750338937; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=i5mo28r4bSLhtRxKleEgwjFwDjbfBKbh8TaaOWlq67M=; b=HuvYGx08zVK3c/f/3WX9pDPKxBy+gcKUS4GKmUJR/UhgFjowWRUMc0fRK4TRaFK0gM hgou7LvzQuZsCORkTZbzz4hQMwQxigBS2pYWek0GinPut/9Hl/q6exznVriEN9vG0/Bb YuedNpQeCqNE5Eq4GV4eHeuFqCI/G5BO93WunVMj5U6fb/J5FQy+jn6Z/LmLuBgGrGMd 5Mtx/O756HKyLSZc1P0Mn9tf9WclNC11cP/IQ9Z4KUTn6pypwGG6M8vai4YHUtNI1SXA QO8C9Yfw9E9+EslzTrKhIikxwiF0jlbhs+MIEKRQAdJ3CyQuHUzDi4Cp7uCYD61zdgJU ufdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749734137; x=1750338937; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i5mo28r4bSLhtRxKleEgwjFwDjbfBKbh8TaaOWlq67M=; b=eWI9OJJuvtZtU5iBrn6K3TNrYToGCDfs9GoSRc82PdEmq1I4XRe8Qe+IWvPxnQqNs+ 0WN/ATNDftR4DL4rfN2PK9Rid+l1fn6AfyGjCNcEM6O9+aZEw3GPf5TJjWDXMjxrChNr /CaZzdSagsVYiYPv+upUQ6H229iVLNoagXmdQ3GTxsgmKjMBDvHdnvPBj5UQ9/Eungrv dutY9M6vg8Ig2caQBHfHaHT0u0173ik3ouinUeRR+9pehat9TglS5B+IYKv0Wq959SJR sj0sQeOcu60/WRV6mgLsknIo2URDPUVZIh84Ez7EQoeuL2kWFleEdsTTbEFc2yaDq/4t PU+A== X-Forwarded-Encrypted: i=1; AJvYcCURwBU5BFe1+TdPqJMgocuIWunlXt4CL4PeKcbeq3xFabdKueinvIMcFQvpFaK/XkO+WpqC8kf4j387NAs=@vger.kernel.org X-Gm-Message-State: AOJu0Yyk+no5VB/OTQRxC8KRrbVbJCgx0W7J9/4w0IWPE7pbKU8z6xf0 LcPhgwwvAEBtfpbzznR/lV5eZ8ItHFWIMOSqxLcbh1/prIJQlMWu9/ILddqxHNCwe1o= X-Gm-Gg: ASbGncucNP7eZy44EctRhJJk1VDbwmgfqnuk2PufdR7hIJPIPNtvuhEA/QearsRTaq7 I/F9zoSfcv4/hR0ee4SNyC6KgXlhN2TyFmQoq29oqVxb9/S0gQP1hGoyZfcElzgHEmO/yh0Tuw+ qxHDjjtNqU2MeyCow4gxl+8DqayYphkG39ICVGjrEtNDsenAr/We+HuCcVYEveExoJ2npglFB9+ D97S29WfXcsbzRPuOUXYo9pnzDg5jXjIF01bEQMzV/vg9l5zJXYaLgSwaDu8jvYJBzQM/NNVRMT QvTEOJBt5NALrGETK4fGwxB8BDMUB7w6no3uIuUVHV+GH+iT0Hcf6ic= X-Google-Smtp-Source: AGHT+IGBzR2mvuzoTZVHlKLwIjCRQmPWg1494+jjoGTBRb95NjkbBovSMnn1G3/kvKyntrJFTjslYw== X-Received: by 2002:a05:6000:1acc:b0:3a4:eb7a:2ccb with SMTP id ffacd0b85a97d-3a5607fa6a9mr2706309f8f.16.1749734131666; Thu, 12 Jun 2025 06:15:31 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8b99:9926:3892:5310]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532dea17d7sm20619795e9.10.2025.06.12.06.15.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 06:15:31 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 12 Jun 2025 15:15:18 +0200 Subject: [PATCH 09/16] pinctrl: digicolor: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-9-556b0a530cd4@linaro.org> References: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> In-Reply-To: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> To: Dvorkin Dmitry , Wells Lu , Linus Walleij , Bartosz Golaszewski , Patrice Chotard , Support Opensource , Baruch Siach , Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Viresh Kumar , Lakshmi Sowjanya D , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, soc@lists.linux.dev, linux-sunxi@lists.linux.dev, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2000; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=OQugchdrkWqDPvdem4KQYa6SyzhpAo4iCK+GSkQ42zM=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoStLm65xc3XhSAXLjOYJrRx8iTF6Z3NPsxp5s+ otU7k+QhaWJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaErS5gAKCRARpy6gFHHX cpxgD/4qN100OY/e/Uz3KaPovCgsqpm2wpUtbSiYEFHBmHRBGLuf3ySBpaIk66jUCp2HK6IC/Cu 2rqLmWG+B1iFpS4BnVMqobo6XmQjO/ARjPAV5Mt5CaDoOoTOhpLoNchztmEN9Q2JKULHtTgCqhX lQHrPhbY/9i/5W0RbV5etGdJItUlMoySsE119JLcLNM/on+dOLWMt+O3R6OFQVbA2Ax1wh27sWY 400r6LQeOyu7NOnJX3zbqfwN/N+J2L065B6bTivK6wSYzswkHHRl1mWBdJI08KlqfsH6XPgQFQw JX9YVFecSDqkoVn+ypM6aD02FboP/q3cvaaUBgxUNeZX30SJzwt52lsSpg1n+Tx4J77UuEZyss+ GFY852aRZcZxAim54v/DC23tAfXW37EDYmRMBWXAr+q34Gz7l0YcsBZVHY59CfR/16FxKPEggg/ 3iQYJRkgoOkddEdzxoZ8j7F7myunohSmcOCpD5Tu7Ycpzt2nb9gQzdsAwZZixXN2jBJxs11uOSl KaDj1iHD+UyHxRyF4uxpTztdkNsHGKodkqbgajWh9wCY7oxvodduH64VwV96QA8h2NgxXxorrg6 X3fbAgBNYIXJF2fF+V2DAOgvtIyTF7nNrlcaKu7z3fq0cycKeH7OGmyuh2ikwHlpBgY8Zj4s2kM q0e5Q8QmLCBxxSg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/pinctrl-digicolor.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/pinctrl-digicolor.c b/drivers/pinctrl/pinctrl-= digicolor.c index a0423172bdd6d8600fcb56a542ef498e14308968..1676cb3cc4c98755d287d3d87ba= 682ffc61192a1 100644 --- a/drivers/pinctrl/pinctrl-digicolor.c +++ b/drivers/pinctrl/pinctrl-digicolor.c @@ -182,7 +182,7 @@ static int dc_gpio_direction_input(struct gpio_chip *ch= ip, unsigned gpio) return 0; } =20 -static void dc_gpio_set(struct gpio_chip *chip, unsigned gpio, int value); +static int dc_gpio_set(struct gpio_chip *chip, unsigned int gpio, int valu= e); =20 static int dc_gpio_direction_output(struct gpio_chip *chip, unsigned gpio, int value) @@ -216,7 +216,7 @@ static int dc_gpio_get(struct gpio_chip *chip, unsigned= gpio) return !!(input & BIT(bit_off)); } =20 -static void dc_gpio_set(struct gpio_chip *chip, unsigned gpio, int value) +static int dc_gpio_set(struct gpio_chip *chip, unsigned int gpio, int valu= e) { struct dc_pinmap *pmap =3D gpiochip_get_data(chip); int reg_off =3D GP_OUTPUT0(gpio/PINS_PER_COLLECTION); @@ -232,6 +232,8 @@ static void dc_gpio_set(struct gpio_chip *chip, unsigne= d gpio, int value) output &=3D ~BIT(bit_off); writeb_relaxed(output, pmap->regs + reg_off); spin_unlock_irqrestore(&pmap->lock, flags); + + return 0; } =20 static int dc_gpiochip_add(struct dc_pinmap *pmap) @@ -246,7 +248,7 @@ static int dc_gpiochip_add(struct dc_pinmap *pmap) chip->direction_input =3D dc_gpio_direction_input; chip->direction_output =3D dc_gpio_direction_output; chip->get =3D dc_gpio_get; - chip->set =3D dc_gpio_set; + chip->set_rv =3D dc_gpio_set; chip->base =3D -1; chip->ngpio =3D PINS_COUNT; =20 --=20 2.48.1 From nobody Fri Oct 10 21:00:35 2025 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CB8225A2A4 for ; Thu, 12 Jun 2025 13:15:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734140; cv=none; b=LuFMOacZGJ7BttGa3D6dPLGWEV5GwmTSx2CZX+7NPavrTRt/i28fmvXwgLCuivJymOahqsFoOitQjLzVayH7YIgiv2K0i7WWEQy77hNtvo3DZ66o0tKrsqp6OzspxFIZM2I1wHDVh4wyWnhVs/WIrA6YWe1s6fqD/c05z93O4rM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734140; c=relaxed/simple; bh=Ek5gzG7d4ZwNZMLDtQPVgdgJ3Mwq+w30jIM+xzq/1NM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Qgf0w14AehMo6FXU2i8vWQz/QBbsoxjmsrXCOI74b9ogSrKNHpWgYsuvtkjK5TMRQ57piSLtC8XsAlMI1QpmeYMAPUSd7VcWglOfWNQ8P7U7CRfpLdIuggldESz6xUPH+HcudYanbkL7VI6Q0TiJJ1asnOZwnJ7OZor37fTwTuY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=IGb7onSb; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="IGb7onSb" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-451d6ade159so7953495e9.1 for ; Thu, 12 Jun 2025 06:15:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749734137; x=1750338937; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ip6lbynAFYtNjOClsW2vFt7aCkU5Ra6KlZGM45oXiHg=; b=IGb7onSb1drfDqPn0qVxMizoxrlhjNGgjDMyG8YQeojPpw5n6Y5T2lI/XbSBF/2fn8 o6oabitw/t/H6H+ZpCIcFWSZtiCxs/up16tS+ztbV2tkBJ6wZnUg/R5SNz/TvykeLUFK IB8xR9sNmq+xrFd904gJRMnV4YGtX6FtFcDJNSSRBLWdLmAVamxIiuH6hA1CKUQT8eM4 HVNPCqpaRIkfgvaVMAMIMuEc5Z6MeT0CJUG7np/bwcKmh0+Fsumyq/ptUvRwTJF/vDHp +CU+ItxxWPimc9y4ZQ7RoeErtna73qNZvSICQDe0dmqqLCqVqb0Idv9O81TUx2nqW7lp 3fMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749734137; x=1750338937; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ip6lbynAFYtNjOClsW2vFt7aCkU5Ra6KlZGM45oXiHg=; b=ui+6/BVIkO4cplDfcyO7AQ7vq6ROUkSU11QAAhsSnkKN4Rl7lgJTNLMogcXYVUDcgt ItLm1w4LpkpwjXL1FFSf746MJyp/Kyh/xLxe6ILPKFQ2aeny2XCm4V3ASYu8P0vT5D10 zwb9EloyvN0JKzn880+mh9iQwWDub4YopGE8lv/OoDbnwEvidJ+IMCrfmisYtjJpNTzG 7BfzafgtV1Ked60rEaUtUbExeQxdmNO76LamaKiJVW8oYAJ/NfESjs0Em8dXVCoPjwE+ QZsilkl51Ab8edl8q52sbmYZFS1DHmlP7nJmfUjOO4DAfBkzGnUChJP2wUde1ZShUj4O NkZg== X-Forwarded-Encrypted: i=1; AJvYcCUM5kONVTBv8cRY+RpKZePaNL04J0FKamvTGmZwKnDw7C3Ao/hAfJlUFzzYDFE8X7nuZ0vp/c7ebA0h+Gk=@vger.kernel.org X-Gm-Message-State: AOJu0YyRqASE+MwvQ/IzoaH1X0l+R/tOcmrNeHVmUjIEOU9qchkb2ib3 Yh/XYeO06/DGLbhLwlSpopgZ8GFJIKfZz5kE7saJD2mi7hHfzZF022cpnrk1G5fXomM= X-Gm-Gg: ASbGncsYjk8mbTdXxbxE1cuKVIVOq1IUTHFk6ZmSLMvM9mD4k1O3+jcZrmN7Q54XYUf JDWAkMhNvetk5NXxCJ0zbfzUZ2cu3smjdZDqNimZf9KGcGxS63IvilNaeorT7/f7/XxsdI7+Y9i pNWV/8pOO5VblhCc9EhMgyzAw9chIMsRUcwC9USss4gTICQzwSnhpdQHATjv5/Tgp2Pzc+TedEt sldnKquUJmF/w4ofanBIz5FNA1tAmEDtY4WieY09RNHa4rSAyTF697U+xuCex3F7vg9FvfwZ4Fy 5en5CnNmxnvrdAycsEwgVsAlAg7fnKwCS9+OC22zXpndMVgnsYIMeSA= X-Google-Smtp-Source: AGHT+IHar0PqDY1QE4EHUJ2UDPwjmIuAL/4fwnWhb7FmMh0PHKvPQEkqatf4UNuUJGPMW4GVTDu7YQ== X-Received: by 2002:a05:600c:8b56:b0:43d:17f1:2640 with SMTP id 5b1f17b1804b1-4532d30e471mr25451165e9.26.1749734136591; Thu, 12 Jun 2025 06:15:36 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8b99:9926:3892:5310]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532dea17d7sm20619795e9.10.2025.06.12.06.15.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 06:15:36 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 12 Jun 2025 15:15:19 +0200 Subject: [PATCH 10/16] pinctrl: apple: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-10-556b0a530cd4@linaro.org> References: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> In-Reply-To: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> To: Dvorkin Dmitry , Wells Lu , Linus Walleij , Bartosz Golaszewski , Patrice Chotard , Support Opensource , Baruch Siach , Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Viresh Kumar , Lakshmi Sowjanya D , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, soc@lists.linux.dev, linux-sunxi@lists.linux.dev, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1644; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=1IApo4igNtXTEv/Q7vu31GP6B3n4wjJlImJTj9XqA2s=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoStLmWXbtvzzN20cI8pq1ql0lzItgzIAO4vu7/ Vh13Q8eW6qJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaErS5gAKCRARpy6gFHHX cu4rD/0bUGcQAKydYhwzI9Rk/4kHLYT1KvTVAL/i42Z3N0kU9QrjzFMdnxe7jVZscx8cUH4C0RJ X9vX1NV14ApTq4Go5LEVS87FcIdp+/PFp1v6HEJ2Z5Ei+lFdiGuViKFiVnbt0k7KUdLG/biuyyM s6fFrmrS+TfsQ5BFkvtpCwMfMANjwALeIeCP4WrYERolA9GZatzEePL/ARH6y1DSXROrVeMGDzE o4QV5ertmVruQ7cQaDBYdUSKcXziz3nUk3vVU0aq3RLWz4z0jPqnCsurFZ7XWH6++JSdwl9eGDD N+p/3J/wpZDelRBqVD/AP40yjN19ZnEKYJuseqMWttjNyzv+Tavo50Rtr1Zp4gVD2ynUU57Z0vL sEMEA8+n3RvnOXutl/uFVp4NdK5eaJruYdT2+ghGilFAdEn/UcdQGWE1gTPGqvD4k2NUSGJ96X4 8T8eFub+XjCYsI4wnnCONAnuu1XYOe52wBFeUjCq93IFXlbOw+TUdspUkW9ih/YTUA985jdJKOJ tbfCEf6yADWiWCiHgKPcWgrnCh/TXoaxvooD/K+kkXUBQ/N8brH2KbqXnt1d8kVquhyNqVIBFoL w8p+GSbvQJQ3DGwzFuWGVO3aAa0fSjQI7BpFePHwFJbW+e7i/vVKozf6dqVUuhpNiqnF7WD5j5U Pfx5x5E6gbynZDw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Janne Grunau --- drivers/pinctrl/pinctrl-apple-gpio.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-apple-gpio.c b/drivers/pinctrl/pinctrl= -apple-gpio.c index 0f551d67d482d96c7a1e4c28a6db580f0db6452e..dcf3a921b4df54250194403f06a= 3c1fb40110eaa 100644 --- a/drivers/pinctrl/pinctrl-apple-gpio.c +++ b/drivers/pinctrl/pinctrl-apple-gpio.c @@ -217,11 +217,13 @@ static int apple_gpio_get(struct gpio_chip *chip, uns= igned offset) return !!(reg & REG_GPIOx_DATA); } =20 -static void apple_gpio_set(struct gpio_chip *chip, unsigned int offset, in= t value) +static int apple_gpio_set(struct gpio_chip *chip, unsigned int offset, int= value) { struct apple_gpio_pinctrl *pctl =3D gpiochip_get_data(chip); =20 apple_gpio_set_reg(pctl, offset, REG_GPIOx_DATA, value ? REG_GPIOx_DATA := 0); + + return 0; } =20 static int apple_gpio_direction_input(struct gpio_chip *chip, unsigned int= offset) @@ -376,7 +378,7 @@ static int apple_gpio_register(struct apple_gpio_pinctr= l *pctl) pctl->gpio_chip.direction_input =3D apple_gpio_direction_input; pctl->gpio_chip.direction_output =3D apple_gpio_direction_output; pctl->gpio_chip.get =3D apple_gpio_get; - pctl->gpio_chip.set =3D apple_gpio_set; + pctl->gpio_chip.set_rv =3D apple_gpio_set; pctl->gpio_chip.base =3D -1; pctl->gpio_chip.ngpio =3D pctl->pinctrl_desc.npins; pctl->gpio_chip.parent =3D pctl->dev; --=20 2.48.1 From nobody Fri Oct 10 21:00:35 2025 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 905DD2459D2 for ; Thu, 12 Jun 2025 13:15:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734142; cv=none; b=M93zVPPRnHquTLwgEee5nWpwtck1tUHBU0ITYrHUvp+aXmvkTsVZ13iIEy2pjGufp4KcmUNWJx70u3Bq5q7UMOqUs2H51okzx8biCIuIQDhprZMvl7hF25HoBE8uWaibQgmM6HdjHM2Pq+IHr59KcgeqwREzfnVqd41o55c3Wuo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734142; c=relaxed/simple; bh=smpoRJPqTgqboXPBnMexqjWTEKSSiuerFWJdx+xG4jk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MF7LpJCib1POG1ap/3rtVC5DCBPkNG864nMwndj5hnrppT33xK3e1yIV4T16hcz6DLXQHvZlrhGZ7jBOaI86o7+2XhyJ6g6EnyErgQrTkWeJdZnwajSTMzHJC3ARefyib+oFfIdhguBHTWMjw/qCFVlo040ZkqLgYoFU/oYFF+U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=K0l+CeF8; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="K0l+CeF8" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-441ab63a415so9887155e9.3 for ; Thu, 12 Jun 2025 06:15:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749734138; x=1750338938; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=MsO/RfPfPYEcGu7pzHlaE+05FqNn0lPn9H16RQ8VcEk=; b=K0l+CeF8FLmO/WW+t3AzaDZO1u2KuZ4CWJQvwsm18daE5kHBcJlg+zIt/1LLaq0QK8 WU6QX3pyI95FrHCd9oCQpnHQjYA2tyvfDthpQXkEjR9hIc9zrPyJYSJcf2e9IE3/emAb NnV/fair17Jy14R2w44xisqI+oEcC5dlZ83glFHrxkqcpp5qOMhU0z9+dUPgm2FfbKrV OsU9qOVW1oTAk9WQybJyahCWGHRXgz1sn96RcvIc3s0MllcLY6ku562BLrEMIbiJDWul KaWsf9lfDa/2BC+BeZxHLRpyJeHMVykA4mkMMJT4/yGrGCmRqixSRRztiqQGggVZ4nJk +Fpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749734138; x=1750338938; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MsO/RfPfPYEcGu7pzHlaE+05FqNn0lPn9H16RQ8VcEk=; b=biMVWlVThidWeo1J2145GTAbxt4QySgAIYaGYQuWG5r06RIFKstOn0awzjIb+mMC6R GOgdQVbi5t4uOxbMzFd8USNP7BqFb+8y7lypkzWNJeLVB5tgCEnolbmnUHOtf9f3MXsK 0ofw6N3gk6sx1E0VZDk3B5MSD7g9gMXKTO6TfnTZR8S1nQd31UWM3C5Zb6D9Lm1pdV0S nvNR1yjfpLiUdKWavBOCXLvi/81hUjORLbKIY63spY1C9gFhhKqFTIw5vALkUzP7sQRw FTFNCyJ4CKkqYH3FC2NSDR06P63mKCt41OkOAiEy420of//BaHKSdQ8Cw35xX3X8YGSl brXg== X-Forwarded-Encrypted: i=1; AJvYcCXIExvdWW034HsXg6OlMoLZvbD4NiJbn1H4CBAWX6coBlSVxQPKVU55ewrDxDC2/W8sKjKuFnn9aMsmgQk=@vger.kernel.org X-Gm-Message-State: AOJu0YyZNAVk5vcpuyIorhud6cWz0Gry5BYzGuasHftC1pvIa0GZX2+y XOR2gGBbCb7FJyXrFBcGoupap0KXezTruLDfNSHpRuNKhTZy5PPzmxhVxBbSfqDTid4= X-Gm-Gg: ASbGncvQq5KXNuViZEQ/BJm1++QZn4v+N+Hpwr6evGmqKqeb63m757S21b4ns8a00Se RBozP+QyDqQqNBYJyA2bOqnUDerklsuUdGq7/e4D5cqe8JzYbBFfaLMLeYLO34Gdxkp9tkvbfJF YNf/UZH3ubZGrtZN//3FDzHd7NGj3+cMkRMOZLpr7PhlSH3MzujwDE+jVRzRVWG8r3DNjK5zPNo m5uP9mwhbxsm6Sb7YB7ocLQeCRUzKKzVJ+4q+1jmkJ+jrRLnZyAGf9UBDUPRM8UUReYbvTlcPwK 6hFKYtjkD7Ck7v4ronKe/0qNE1BbX6WQnm+eIMoYCuPI+5vFB+N2pHs= X-Google-Smtp-Source: AGHT+IF/kkUZmqJMzJYib645Bdu8k5BoQYvJm3jm3K7Cxkyey72KYBawXxzfCbRcLK0/hrXvvJy0SA== X-Received: by 2002:a05:600c:3b94:b0:442:f4d4:546 with SMTP id 5b1f17b1804b1-4532486c513mr66058075e9.1.1749734137693; Thu, 12 Jun 2025 06:15:37 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8b99:9926:3892:5310]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532dea17d7sm20619795e9.10.2025.06.12.06.15.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 06:15:37 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 12 Jun 2025 15:15:20 +0200 Subject: [PATCH 11/16] pinctrl: pic32: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-11-556b0a530cd4@linaro.org> References: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> In-Reply-To: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> To: Dvorkin Dmitry , Wells Lu , Linus Walleij , Bartosz Golaszewski , Patrice Chotard , Support Opensource , Baruch Siach , Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Viresh Kumar , Lakshmi Sowjanya D , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, soc@lists.linux.dev, linux-sunxi@lists.linux.dev, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1720; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=36c+wupdpQstMiyirn6O+A3D3CWfgG4Pu3KgyyFz9nA=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoStLmawJ7WD6umM/5yinajp8MTMUCxK3T/5pvO NJPhif2mbeJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaErS5gAKCRARpy6gFHHX ctMdEACUmqcuKhVLteNNFsKXjhb0zQLkw4a2Fw9Tyn53Jq2evetPN4alNRZOafrKnN4EQaA2bjC rCflz4VMDSQ8DB+ExJ1dZMPiE47azhpnGrP2Ntday7+7iuRXGMWpM8ADbtGgUe/87ZPFa0KidXZ DVBXl4M3NXYsc5IWpsJnmoLdg5UyE+mW9JoofY+Mz04Oxd6n9fQ5bZeifkdllln4Q3y5qnNSjb0 cdW1s1afOJlDtHkPTAbuP2RB+eGem60QlsIWtBpMPpWxv4eitSa3ucXGPDal0PCK9fSTCstU62g lrFrlnFbOaL7ZWcHtDDFy2m24jc1lIqxy0Azvs7DQWHF0D7SQDExoX8kLuVPW/sqEt2t8AoFs3v jXf+K1tgpr5K9xn8S10zcd7MNFEPWRxFLTb1T+GPZpPJ9kW51o0pp6qBvuDUrgf6N9wwDjtloqU knRNbrM431Biml5vy6a26Ze8NeXj9D9txpKR9izG2oM0yUdAS90qQqn8d8Gl4J5gwP28GB5WU7E 7FYMcPwKodRzc69PaB4Ab4ULl+m160z7TQtvhZhM/bIK067QAAX5rXY8ZTyU/ZMnRRLh9VaBrr/ V2zPICzcxe2Duc+ES9nlLO+6hTvzZ4Wrzz2cnxnr+exUfjvlrPHT1knIw87EtPiAZVpvG3qC7BA oo6HMlDJeALdzbQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/pinctrl-pic32.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/pinctrl-pic32.c b/drivers/pinctrl/pinctrl-pic3= 2.c index bf827ab081a1d672c440a8b4eccab539fdc215e7..6d64cab97e8116625c2efce29a3= e5db8248bcba4 100644 --- a/drivers/pinctrl/pinctrl-pic32.c +++ b/drivers/pinctrl/pinctrl-pic32.c @@ -1828,8 +1828,8 @@ static int pic32_gpio_get(struct gpio_chip *chip, uns= igned offset) return !!(readl(bank->reg_base + PORT_REG) & BIT(offset)); } =20 -static void pic32_gpio_set(struct gpio_chip *chip, unsigned offset, - int value) +static int pic32_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct pic32_gpio_bank *bank =3D gpiochip_get_data(chip); u32 mask =3D BIT(offset); @@ -1838,6 +1838,8 @@ static void pic32_gpio_set(struct gpio_chip *chip, un= signed offset, writel(mask, bank->reg_base + PIC32_SET(PORT_REG)); else writel(mask, bank->reg_base + PIC32_CLR(PORT_REG)); + + return 0; } =20 static int pic32_gpio_direction_output(struct gpio_chip *chip, @@ -2118,7 +2120,7 @@ static void pic32_gpio_irq_handler(struct irq_desc *d= esc) .direction_input =3D pic32_gpio_direction_input, \ .direction_output =3D pic32_gpio_direction_output, \ .get =3D pic32_gpio_get, \ - .set =3D pic32_gpio_set, \ + .set_rv =3D pic32_gpio_set, \ .ngpio =3D _npins, \ .base =3D GPIO_BANK_START(_bank), \ .owner =3D THIS_MODULE, \ --=20 2.48.1 From nobody Fri Oct 10 21:00:35 2025 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB2A7259CA5 for ; Thu, 12 Jun 2025 13:15:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734144; cv=none; b=FYU6ScIdv+tBba2h4ffaLwVF/LWk356h21tC5sS5Ibs76OYaJyA974Icmm+Wg20POYIcQh62MjysBdxAjGAhMXxsXlKe5BvGHIv8ByV8kvC+4b2kzW2wTJKAD9zjXcTr4+p/v/Qq4bwrOpq2S4V1oFZZlGheXhfQ5QFwAcx1/DI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734144; c=relaxed/simple; bh=FlsshZr2pWaa66OdHrYeRpFA8c2RWzue9ZDkcpQOBWc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Kaca692AiURNDF+IT1dsc+vntqNKrtch5+PgNpA+2zgFE/mJ94PJMX0pxi5Rbyi3IWt65t24OQp3SwQ88Gzdzy+JHrdZAAkkS0ZEwzCfRQLaa4xy2eVWKkZApZk3QfYFmSIWsvpfA0sh5oVWoyyQXnWss4FI5QZsmrMN41IkKfI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=w7BSmqN+; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="w7BSmqN+" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-43cfe63c592so10860485e9.2 for ; Thu, 12 Jun 2025 06:15:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749734139; x=1750338939; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3kdCtMGqd8snTnoQ+DvH1UQEd/O3oxtCQF39dSuJ39Y=; b=w7BSmqN+JGvYmLro6g0UGCAusPV5vZ32lCxMOv8GtIxVX02LDyXFh1TTQ0f9SBXo2x y5b+p8VA41h3NnziWOW8SmYOf0wGCffp+iCPOFJi6kvkAKcwFzc9M5oCt4ilp7dOsLRt S+nO/WcQtLaENpK1StOTdKpJH1hL31q4/BRGbMk666fpIez2GuHis1K+GNUuusnz7zzc DYn1QUOfWiyD5mHlzEkQXZ+gC0rqvozHNkdgL/ZrN4Yy/ydPxBRW8uGnWHlaeGVxNVSi UwjJLgF6/6VNbS6H91LY0mENgC1crmnua4tla4dq/I/YxLojD7zFXNF9IWnVU9AKOkPc 4g6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749734139; x=1750338939; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3kdCtMGqd8snTnoQ+DvH1UQEd/O3oxtCQF39dSuJ39Y=; b=ty+sULEPrw9vbh1U/0jn0H19cPWvpga3OfBDdXPE9bRakiei85hsYHudxW6UXVqIaE uThMkCNyk1bfbx+a58rtkkdpjpUashAs2pO12jt62XjnTxf8HHyBz7T8dUBG2vusQrMN Ef30UaPiHaSZhtzRMW6LIIxiSqjaAoo1ozC3rHE18rOtZ7/SyFWjXYIJx9c/YsoaTWgt vNYz/evKYW1v8y9VZ+/mMsbqziUmjoO1Mtlx3/oBi94hLVoHK3GuvAl+DlkUSTcs2gbV h6ok9Kgx/1KcgE1ts+EF/2OAPQtmL6EUpDNYpvjk8S+gEc7y5x3F50O0ZrtCDnpfXLX6 URBQ== X-Forwarded-Encrypted: i=1; AJvYcCWAIc7sAEMKYqT/a2BpG5i6ATFCm+YyqxciXEWtJYOC+9V7W/BVJ2mtjmXdc0cU5nGsnculQJPQsDX3HF4=@vger.kernel.org X-Gm-Message-State: AOJu0YxDJNBoAaMUuwaOBfwiGLz0EGuWpvgD+Ze8mOqoFgKRUR4Nc46R TuCxcDeIe202VYt0j4JNlrLN3CpDbd2scfeyv+GL2Gu547b8yPgXOpUsNyY0kDMfn90= X-Gm-Gg: ASbGncuHVbPXwtiQ2383akoqcRwYxinnGQyGnXb/EB75vTU2FQ6s1zNkFLL7ICu8TX8 RKbCLQpA5r5EX6No4o2wCrmBohhqrUAOre1Qq8TqcappAHHSLJyRVphiZgFcT2NXEwenwSwKtJE Z7Yx3ajE2OJAx1SiwJuo3BfrXan5pSCy7TvCevYnR4GhdUdDfV9QuMltUSxSG23GRqvPUF/88Do J9LA4jPZ28KQvvQZOmivZomPDF4n6/pu+Z/aUkL64NhKNMV7x8D5n6YJ/85+VLwnRef4zFjc1WP tV3VCyvRKVStxKz/LCr59DZLaxDivtFP5ioWMCDMZFSdQiGocwt8VljS4xem62jfTQ== X-Google-Smtp-Source: AGHT+IGl8eW8WnL+cIAddPc5eM66HwVHrNHEeYaEVb5oP5iPREXvfn5SVQ58c3fSGe7nsIDDe/S61w== X-Received: by 2002:a05:600c:1386:b0:450:cfe1:a827 with SMTP id 5b1f17b1804b1-4532d3299f5mr29713045e9.31.1749734138978; Thu, 12 Jun 2025 06:15:38 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8b99:9926:3892:5310]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532dea17d7sm20619795e9.10.2025.06.12.06.15.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 06:15:38 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 12 Jun 2025 15:15:21 +0200 Subject: [PATCH 12/16] pinctrl: spear: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-12-556b0a530cd4@linaro.org> References: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> In-Reply-To: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> To: Dvorkin Dmitry , Wells Lu , Linus Walleij , Bartosz Golaszewski , Patrice Chotard , Support Opensource , Baruch Siach , Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Viresh Kumar , Lakshmi Sowjanya D , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, soc@lists.linux.dev, linux-sunxi@lists.linux.dev, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1988; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=Quh2BKoDNlMEGO9ydmQRx8uUPC9cI403NRhtbznDNiA=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoStLmiiG0NS7y222qXdi+UK1gYs11zyVNle3ll 7695Du5fQuJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaErS5gAKCRARpy6gFHHX cjHTD/0QOLxxD5opxxXzFfIt89ty+lC0lghLR0yZYrf36EMOnwkkHtmGCsjxHfOnT0/73ea88cP BravFuaTrO9sftxm8SdI2BAQv37NtThvkmJF3q0Qbfp5EFXSC5ULs9W/tIdqsYQl69+EvGegQhe CDjFPkxd5m2z+aag5lFhpTsTXq3C12nMbgyUA1ycXYTndObv0TbV0zFIYxHnJSMGdkLwLJPQFAv PG9wjwBT4L1FzNMTYG98IdDTisCAYEpKsTMq8P3CCHB865IaWhxMRR9b3jKlwY5Da6ChTYY95F6 VQOHgQrVo6tGqs4P3E+5QmY9RWj20w8wfoGxN187W2WGFS1maDLwfTNRfq1MhixKopBADFwMZfS +9d1ElgztrQhn4tIxBfl17thgN/j5PWlirVM7vscR2L6GvE+PXplIUVYURjbz2X2ZJFuSY8x0hy GHFLJqI2/2oid1h7jUJJQAPVsJzI9h6fagO8QlxKFWnwQlFieKd8fp7J+o3FimezPmJ1iDZ+Q7j AeVH1PN8imcKdY2m+hCwoK4XXTn9Fd4fPAFYRSO8abRFNbd0PcvXzmvsVENjXQlaUTyblsm6txX gxDyv8i63/C/D2iK2iAr6J77BMI3gKO9NsdJLWsU3y1BSLFNzNpe5REp2gyzX1i7MgaAL1bA2fS 1tzGhBqfBBHQqOw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/spear/pinctrl-plgpio.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/spear/pinctrl-plgpio.c b/drivers/pinctrl/spear= /pinctrl-plgpio.c index a05570c7d833d9b8268989f2a6e54e1873d20de9..e8234d2156daa5ada8adff5848e= e4cf136257c3f 100644 --- a/drivers/pinctrl/spear/pinctrl-plgpio.c +++ b/drivers/pinctrl/spear/pinctrl-plgpio.c @@ -181,24 +181,27 @@ static int plgpio_get_value(struct gpio_chip *chip, u= nsigned offset) return is_plgpio_set(plgpio->regmap, offset, plgpio->regs.rdata); } =20 -static void plgpio_set_value(struct gpio_chip *chip, unsigned offset, int = value) +static int plgpio_set_value(struct gpio_chip *chip, unsigned int offset, + int value) { struct plgpio *plgpio =3D gpiochip_get_data(chip); =20 if (offset >=3D chip->ngpio) - return; + return -EINVAL; =20 /* get correct offset for "offset" pin */ if (plgpio->p2o && (plgpio->p2o_regs & PTO_WDATA_REG)) { offset =3D plgpio->p2o(offset); if (offset =3D=3D -1) - return; + return -EINVAL; } =20 if (value) plgpio_reg_set(plgpio->regmap, offset, plgpio->regs.wdata); else plgpio_reg_reset(plgpio->regmap, offset, plgpio->regs.wdata); + + return 0; } =20 static int plgpio_request(struct gpio_chip *chip, unsigned offset) @@ -579,7 +582,7 @@ static int plgpio_probe(struct platform_device *pdev) plgpio->chip.direction_input =3D plgpio_direction_input; plgpio->chip.direction_output =3D plgpio_direction_output; plgpio->chip.get =3D plgpio_get_value; - plgpio->chip.set =3D plgpio_set_value; + plgpio->chip.set_rv =3D plgpio_set_value; plgpio->chip.label =3D dev_name(&pdev->dev); plgpio->chip.parent =3D &pdev->dev; plgpio->chip.owner =3D THIS_MODULE; --=20 2.48.1 From nobody Fri Oct 10 21:00:35 2025 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02D1525A642 for ; Thu, 12 Jun 2025 13:15:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734144; cv=none; b=rghwTu/JLvnYTYvSz2hoq4hazU2VGMJcl6clDVzlyKIEQeaAVLqwBLaBhy5lBYp6zyv3X5cFecLstP3lSgWMYYH9D4XVj87JAmUz4DLMb01YlhP6oL9P+4nYLaMNEkpfRqUUGxSZPN+9BtCk9+125ZY2FB+CQHJItcUJuCc4Ylo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734144; c=relaxed/simple; bh=zp6d5z1sYxwWEw/wzKNXZwt1zjGFDbts1CmdEZq0nus=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bXT8zjuXXOAqPJlBu0VxQIbklNZ0jimDjuko8eT59NDoHfCYvuUoD4A7Jrrcv3OOVXVgWzVbXwoK0mLSi1vYHpdEHlcdlfXS5a5mJHCRsyQuPhMBTIRfDgVn8TGDhQ8t8XLaDlQXv/vG8qM80uy2ghckBik6SWStlENfzKmwU64= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=bXrkb48K; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="bXrkb48K" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-43ea40a6e98so11655835e9.1 for ; Thu, 12 Jun 2025 06:15:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749734140; x=1750338940; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=xRVP/g9ETBrQ7ivNn5p21D3d98uF7eL3W+bgcNUMLx4=; b=bXrkb48KkkSVvRL1fIduwlV9Iul7exkzSy2jUZ2IG2BpKquYn8FgeUhUoQn97ZlxR2 qiaG+TQIboy+JPrDjNDVnSMjoSvZTzlex1Ij82+GTQvJIBURJWhBhVDj++GSQNzwd1eb ZwVDxBL3BDKafJ63eNjrvz/qjH0gkHA/+UI98rNARVQhY9bK8yhJG0Xb7o4dPpq4EDwl GQrNMfjCypLMjZIdLIPc6Eb6NM11wHMRx5N/0KJcBPeJHRrM7psgW3od2QdSMvhdQZxU Fddj1wg8ZZPEZIK13MYzZxmxE7rcbcp8l4Nv4JlUVrWAW/VEbpgchDcGQDX7nOOFL1VX iTGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749734140; x=1750338940; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xRVP/g9ETBrQ7ivNn5p21D3d98uF7eL3W+bgcNUMLx4=; b=jiAib2sgcgIQcHB45RTMPodQvF+9wCBNtxPzpM6sjXuXJ8QvdG3V6GLDhwnqWyx1F+ 0N4FPzcRbFfiNYTT2wcd1t/KAkNrjufxdqg7Brl8pa03AjAx55NUlQcVAIQpiLSkIIHv feDsK9pzzSEn54exv90pNiBQ9JdbWRJQ2k5z97xUsER3jUzx0gFfWQuolTWVI4OsGS4L 5qmAmod0G5sGgIglGki7hlp7rs10xxbJ0eppbhU1844n4+OKNga0m3GQzQ1eREVXxTQu ExDjvucHKCgglVYn51kZrev80cFS+bbQQef12AaLqc+MmpAzErSmcGsa4huQKW6DIHFZ unjg== X-Forwarded-Encrypted: i=1; AJvYcCW3ZUDn8SSI/aTfq2f7Ehj6W2FyyUvTjE2FlNqIu2Bpks/emmZEuHjlS6PIZONg2DQsJTGlwkKn2CFFubE=@vger.kernel.org X-Gm-Message-State: AOJu0YygDAN04vxlZsJ4IYFMkKJTsBdDgfHp+qz5CMsglfm7o3RHUFUC f9wZ4Xzl/AyFFRX7tiXrC9yp7LjrDjx16ty2TlOCkS8zlGmp7cJSuLFSgdxK98Fy9OI= X-Gm-Gg: ASbGncvtSmM9f4dnjqEV48YKuYTEsMDShKVyc9wxxLdZ48viRuxH0acJABQvz4HmvuR yubaWkrpaw12SXq9hO1z/RMW+Z0eVymfDvvoHCP0T1osfaB1q+Xmt/gRJToX2wKsYGEeadULRm2 DUBbVeSwHEm88+wWhEgKbNfpuIHn+Y5N5pPsguWF84tLPnHbb9LeW3Yxz1QcC+50Rj8FR03YGIY FXnFqS44YhsRHjUu2N4fQIF/ZpTNTtYjrrjvX2lL/7S0ttrEBUYAakq/CX3GgdDISYm4v3EOkUY 2PIm6MpadIiGVjxa0u57fFm84efLpO8sBs8dBXotcF4j4cm+C/lS5+Q= X-Google-Smtp-Source: AGHT+IHSRKRz+S4AqZCA7nk2lBD5FvLjirlW/aLzXrlkeH/hiH8EEnGTppCPiobvVp5rFO/8nRH0ZA== X-Received: by 2002:a05:600c:6304:b0:442:d9f2:c74e with SMTP id 5b1f17b1804b1-453248cadc7mr61464915e9.23.1749734140174; Thu, 12 Jun 2025 06:15:40 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8b99:9926:3892:5310]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532dea17d7sm20619795e9.10.2025.06.12.06.15.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 06:15:39 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 12 Jun 2025 15:15:22 +0200 Subject: [PATCH 13/16] pinctrl: keembay: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-13-556b0a530cd4@linaro.org> References: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> In-Reply-To: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> To: Dvorkin Dmitry , Wells Lu , Linus Walleij , Bartosz Golaszewski , Patrice Chotard , Support Opensource , Baruch Siach , Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Viresh Kumar , Lakshmi Sowjanya D , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, soc@lists.linux.dev, linux-sunxi@lists.linux.dev, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2154; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=uiWkBcfY0fL2/5gsJ5RtTL76wdCKi/XJJns8EXZp1Uc=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoStLmMUTq/R3HYvt1qPLJCXHDLlLJ2q7Mprw3y q+tW19o7dqJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaErS5gAKCRARpy6gFHHX ct8fEACqt7lUq3+S1tzRy8OrX4O3CMfw4nPrYnVysPwnIX5aR7rCUP9il86P5OxnBe1clhRmwf9 HoPniYHRVUQF6YnI9EAGIDwhSUum1jbEzozs8EuWZ7akwxiY2lALTFQUB7pAw2aWqDQurWwASrh BAPCmHKNGQdiW4jPkj3dLIslFjsYCDyb4a7d0h7Rv4tHvOUJjwZTpmSlxh6jQhmj8/OnfF4FmSD A8SD5CTEpda8DN7KqBB1fsTu8o8/TRNLf1sa/DJf4UITLByVIfbtYMhfr/RbkMTCOa1I/Dca2/P Y8qdU4ZwwfmOTHnc/lA2TI6ioK5BvuhNtqvz4Cb1IEgG2Zlg+c5asL8lkSQySfaQCuWVBZ6+2Hp 6pgnwuG0nSOllmDlZu6Tkzrd1ImxXcHfrsa02KtJ491H2I3Reth1gL1neP6RR6Nl3UDYNrcfUn3 VqyShql609Nvgybzi+iTFSjRiwiPqG2yqgild3NQGG4yXE8kfSUys5UhBTzPaS5B8+VvpC/ZsAX xJfJ0KUdYCJumelmLmj2UUWKfC2pS9l4NPnQ9EqQOSiTnderpXlz7vJKNljTZW5Xz7ra3xmDff3 VwRuV7ZIQrTn1lzp1FlY9U4bZ1Finj92YfG99YcWHQ0kTqN/Y0O3a7ioGWw4qxRszN5QakMKHOF J+HEqcwBsnDzYvA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/pinctrl-keembay.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/pinctrl-keembay.c b/drivers/pinctrl/pinctrl-ke= embay.c index 0d7cc8280ea2168e69cf3d0ea415f6d2389efd03..622000139317e9dfb95e9a76f24= 78366daebdcaf 100644 --- a/drivers/pinctrl/pinctrl-keembay.c +++ b/drivers/pinctrl/pinctrl-keembay.c @@ -1188,7 +1188,7 @@ static int keembay_gpio_get(struct gpio_chip *gc, uns= igned int pin) return keembay_read_pin(kpc->base0 + offset, pin); } =20 -static void keembay_gpio_set(struct gpio_chip *gc, unsigned int pin, int v= al) +static int keembay_gpio_set(struct gpio_chip *gc, unsigned int pin, int va= l) { struct keembay_pinctrl *kpc =3D gpiochip_get_data(gc); unsigned int reg_val; @@ -1200,6 +1200,8 @@ static void keembay_gpio_set(struct gpio_chip *gc, un= signed int pin, int val) else keembay_write_gpio_reg(~reg_val | BIT(pin % KEEMBAY_GPIO_MAX_PER_REG), kpc->base0 + KEEMBAY_GPIO_DATA_LOW, pin); + + return 0; } =20 static int keembay_gpio_get_direction(struct gpio_chip *gc, unsigned int p= in) @@ -1231,9 +1233,8 @@ static int keembay_gpio_set_direction_out(struct gpio= _chip *gc, val =3D keembay_read_reg(kpc->base1 + KEEMBAY_GPIO_MODE, pin); val &=3D ~KEEMBAY_GPIO_MODE_DIR; keembay_write_reg(val, kpc->base1 + KEEMBAY_GPIO_MODE, pin); - keembay_gpio_set(gc, pin, value); =20 - return 0; + return keembay_gpio_set(gc, pin, value); } =20 static void keembay_gpio_irq_handler(struct irq_desc *desc) @@ -1480,7 +1481,7 @@ static int keembay_gpiochip_probe(struct keembay_pinc= trl *kpc, gc->direction_input =3D keembay_gpio_set_direction_in; gc->direction_output =3D keembay_gpio_set_direction_out; gc->get =3D keembay_gpio_get; - gc->set =3D keembay_gpio_set; + gc->set_rv =3D keembay_gpio_set; gc->set_config =3D gpiochip_generic_config; gc->base =3D -1; gc->ngpio =3D kpc->npins; --=20 2.48.1 From nobody Fri Oct 10 21:00:35 2025 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD76524502E for ; Thu, 12 Jun 2025 13:15:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734145; cv=none; b=YlQ5GKv7h5Xhucpe2ezr00Izemux1D/5sj10VV1pOXOzvdvTlE4J1Hx8mdQuwDtDozV4v5u4bLV/stC+YWTJBx1wnhO3GXuPlvOtaPCLIh3rQplEph/iAEEJjcMOKxf67RLADAZjII1HUVHPVcWDYYa27+XbsNi9FhDKHBMOSbk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734145; c=relaxed/simple; bh=85haVVGK9Bcs+IGMqbyClCBY80jPljKCDJVYKsTGn2c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Gcosaum5Yy6IxNe5227N8PKzi3hS1+DNJ8uQ9+POc97wx75DKkeIPhYqmK4dj1H1901zlnhkejt4/IYuUsi4sNDdpNgqpw7nm1KeIdegM+Y93tVQ8EI38Z7OjZNS7qzrNWWAlJMuhtcdHVbU2A/KC65GfLoFFuYbePnnzeDv8NU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=MRoO7XI+; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="MRoO7XI+" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-450cfb79177so5343865e9.0 for ; Thu, 12 Jun 2025 06:15:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749734142; x=1750338942; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=SYW0+B04sInxcyPw7RL4odLCTvi8nL12cX8+rIobfUQ=; b=MRoO7XI+jh91AHkx/TICYRdn7kp+jtwHjcM/Rbsrgt77VOu007rWWcDFw9q/3Ybr6R ItURHVZGOwzxEc8fjICWudMIYjBqSOe5ZnTArJVQ4OJS7Pb4lFv2NvboPje5nv33O4oq //2z2If1hOwR95Lj1TnEjN0eBcpzP0D6tEBAdEBQBVu1s3pwbxtDlQjZwYZ5OWIaqkeO s1o/5mJ+esXaOS6T8J6gIV8lSJ+mp7xTGhzp1OofX8l6rOzOafwimz3k9QSRRdT8zCsv du5CW52dfFRiyS7Mi5xOHxjN9ye8GK4cI20XmxtYdTJXV9iISlN5Gqy76ONgt0wV1V/A NBSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749734142; x=1750338942; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SYW0+B04sInxcyPw7RL4odLCTvi8nL12cX8+rIobfUQ=; b=jnBWPKelkcAgqleQprQklovBpOjjtAm8vy+fUJlJbE5eDs5R3K+1GAaQmHVR/+VZdU LQ4gbC8lhRN+O6bRTZP05OXw3e+jA7NqXwaC1WyZKQaQxNSEEG0Cee/Ed5b06bffKwPl ofM8AkOUeeYknQwlDxj+z8iv7oQjTt9Pte+frmbE6N3JK6CK1t0/mErSDOCarWvcCyxt ZAyB8HQJGR2GHQW4f4IvMpC3yjCfGgeZ2K5fFjonZcT56sw0NU4h8r/XrQKLp+cDOOSm +EF/QWa6ig4NW8iQBaeQesrCF/5LdR/xkeKyWV3cybkTxVG02ByRtbEyj3Ev9iPGfFnm GVhw== X-Forwarded-Encrypted: i=1; AJvYcCVVVbvEBc+N/QHpd2gM9ArhqeAG2E8XvoHQI95ZqxtGzQ7sO6g3FPjUYyzjdIhMcnQd0Karo6Wjbns004c=@vger.kernel.org X-Gm-Message-State: AOJu0YzzkUSQuCnozwDQCoYYPNnIUl/xc7E7XgfYG0tezyXr433tlFQV ptlEH4ehAsRLGTFhQeUooQmFyYxIFcwoxk3Emvyuwh1T+BlW8V0reSY7hWa3coKrNAI= X-Gm-Gg: ASbGncv3EjxsPWhQ0VMPPn/vcJ8tqJW+nCaCSvO/KUO2wZJtiATMLKFDf6zkSXVsHlx IBFCTBRMx2FJRQeoxyRnMd/hJDjOEHOL7bLFNJ09OLyaOg70SM3AActe8R5UByjLWoYdbAUah23 ZMAMwhq+l1jLoG7qbql69+lqQCa/WoEOqmW+rZtcjL8BHMjUYVu8RQhFAC/u1rkvGNB+D/u/qQf Zcujxx2yrk1mrHeGIwPuP/4RLo7MA6oB88Pv21eMMP4xFv3JnUDA3eMDoElRqiPmqZ0ev4LmPaw j0cHK44mJx3lZwRapU4PnVM0LOudJLK5mc2dBbDVnWrYErbPK2/u0jc= X-Google-Smtp-Source: AGHT+IFpZ9SXfAbcx9UYgsykf4kQVZZ7hDQIXoDecEBolRJ+pnmV+MNhvJktOJmHqFQTsif+GRyCYg== X-Received: by 2002:a05:600c:3586:b0:43d:ea:51d2 with SMTP id 5b1f17b1804b1-4532b8c2f2bmr38451605e9.14.1749734141385; Thu, 12 Jun 2025 06:15:41 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8b99:9926:3892:5310]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532dea17d7sm20619795e9.10.2025.06.12.06.15.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 06:15:40 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 12 Jun 2025 15:15:23 +0200 Subject: [PATCH 14/16] pinctrl: sunxi: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-14-556b0a530cd4@linaro.org> References: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> In-Reply-To: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> To: Dvorkin Dmitry , Wells Lu , Linus Walleij , Bartosz Golaszewski , Patrice Chotard , Support Opensource , Baruch Siach , Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Viresh Kumar , Lakshmi Sowjanya D , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, soc@lists.linux.dev, linux-sunxi@lists.linux.dev, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1804; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=nIb1ERVNbKJsSviHJxgUP0dw0VlXNMpXQSUn3radzBU=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoStLnDirgrB5LayZ6bmpzTb9vnrrWDTKxpwuY6 6GuRs6+7+OJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaErS5wAKCRARpy6gFHHX cjGPD/wNvb4j//YoAIysQkS1R/JAVIQzuJnhYsUG1hvGNE0K/Tj2zywZqHvUHGhwy0MMfY4/IPv ipPG/UE5TMpaAfnUreWMO+6gxvRyBKLPdnaXZFXBx84htL1YUquIbzHMfT+cuIwtCnRANTxi9So I+0/W4Ejq/+fTnRec5gzwllQdA+qwsjIuNLHh2hmROmHFzBhnrngKJdRyiYjB4n08hMg33DyloF R+WMLG5USaOhzS/cXh74PjDCSNab71daGuxVVLjx6sNQm+imFmYb4aAZaHP34eGfUMMInd9XzFM SSClmvWkl4TCO/CRIH9s2dok8DZbUhgNwR2461FteN5+z4/wJh7owtQ3RtsRJeriFnI6cdJNxiH O/cD4XHBvqloqHTCEeD0KHICq0c4Ka6xKLZZaxo1/eJAtBPvQDdS6VXDNjKjxr4hpedktowfEPL 8dzAoSnwDri+1MvHu82L2GIfD+vUzkRxP8AhYFQlINlgKg+FSNbV8utKdF7Dp/RvA0AyTR5AygF CpNuMQSY+P7pgwk41Y9dwdiFlxRy30of81JlYjV6kdmBpB17p+eWnhfObkprJ5ndF6wY7DM75ri VViJexUTAn0tAMuSEcLxSC3FqL/JUCBI8vRA1fvCu2BIbzgjhzOLrsorSrBLj10sqL1w8ZimBia 8eHbwXrot5DU3sQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/sunxi/pinctrl-sunxi.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/= pinctrl-sunxi.c index bf8612d72daacdde6209b0b5c84e010ef3b846c9..9a94c5276828aca51212f536400= 897e447c62ecd 100644 --- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c @@ -955,8 +955,8 @@ static int sunxi_pinctrl_gpio_get(struct gpio_chip *chi= p, unsigned offset) return val; } =20 -static void sunxi_pinctrl_gpio_set(struct gpio_chip *chip, - unsigned offset, int value) +static int sunxi_pinctrl_gpio_set(struct gpio_chip *chip, unsigned int off= set, + int value) { struct sunxi_pinctrl *pctl =3D gpiochip_get_data(chip); u32 reg, shift, mask, val; @@ -976,6 +976,8 @@ static void sunxi_pinctrl_gpio_set(struct gpio_chip *ch= ip, writel(val, pctl->membase + reg); =20 raw_spin_unlock_irqrestore(&pctl->lock, flags); + + return 0; } =20 static int sunxi_pinctrl_gpio_direction_output(struct gpio_chip *chip, @@ -1597,7 +1599,7 @@ int sunxi_pinctrl_init_with_flags(struct platform_dev= ice *pdev, pctl->chip->direction_input =3D sunxi_pinctrl_gpio_direction_input; pctl->chip->direction_output =3D sunxi_pinctrl_gpio_direction_output; pctl->chip->get =3D sunxi_pinctrl_gpio_get; - pctl->chip->set =3D sunxi_pinctrl_gpio_set; + pctl->chip->set_rv =3D sunxi_pinctrl_gpio_set; pctl->chip->of_xlate =3D sunxi_pinctrl_gpio_of_xlate; pctl->chip->to_irq =3D sunxi_pinctrl_gpio_to_irq; pctl->chip->of_gpio_n_cells =3D 3; --=20 2.48.1 From nobody Fri Oct 10 21:00:35 2025 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAA8C25B683 for ; Thu, 12 Jun 2025 13:15:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734147; cv=none; b=PQYgLLTI3rCNuM1ks10bW8wxpA4Xsvd6UjVFpTWcLr6t65+kGhyoLA3bpdvWA+tcFzm7jmgS11zwJl657kiyI4masRSEk+u7lbDMKQtqcZA5KWxInQP7yNsbMfBTVuU5++ffeYVIR+dDB0tIWL6vPH5aO0MV+/3yHOl4/RwJOgg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734147; c=relaxed/simple; bh=IWzffuaXPTlvob8B44ZyI57c1fGd+CDDEQUCn3zwQG0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZqHnxj2Dgg4chZEDi7ju3nCHMclDgs7A2O0XXVrjx9MIOJmlh0GHrsj+rK5sNdEkaEoWCEANffdYIw19D39mQXoyD9Jkp2N9Al5DgukltUjd1tS7o3yX0tHnAzVZ19+MSlcc1qJo911kh+zlq4cYuEEi3V936hXqvPKQPOqUYYE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=jwZBGck3; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="jwZBGck3" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-450cfb790f7so7044975e9.0 for ; Thu, 12 Jun 2025 06:15:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749734143; x=1750338943; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=OeMSlNL5v7plT+CdY2CAH8xRYdEmWgOgE7l1ThlWmy8=; b=jwZBGck3QiGQeRKkTtBppjgmqbB6O8uaZV39PuQZsoRJuEQEYYLsgd4xDpRdsC+WZA Jem2I9PYzsbpfdk1v50S48zsq0Ga0BH1Gop4vfUDuAX3ld1a83ZBqHE+mV4BR0pKPuNc MSWGlQg6pSvcSrAicZ3VXoVfaxr6IrMaxU9h4l/ddEyFMhoyww0+jnaywhSGZObRZTNT AZHCBHyROU+nUZ0ikiFCmAggOVweq79cdcm0xEArK4k/nGikiMne7JFokwWLfUJs0kL4 Q2PQzweeu+zGpeMbpCiSA9mlBLgSMQkbxxBdvNkgrY2vr4gDA7KZPMiFicCnjRWv4g+m T0vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749734143; x=1750338943; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OeMSlNL5v7plT+CdY2CAH8xRYdEmWgOgE7l1ThlWmy8=; b=gWIyIXnBObiDlu7sBRAN2m6OqI9GauxUHdc0gHKO3AEk2zKgEDOnHoR/SZD6ya04++ b4/FIbPadnS1YMJytIrZEVgUg+1AY27nJo8scpLhGhrxwoGZaRbT776gOdMlax988Q+Q R9atWBEJ3+dr7uFFmv+iZkMB9l8WEtckRUpgf8GeVydnnsePA2/8qi6lCjS6hCE1Ssir UM+aUvwCrUvHByp0bumADHpO81ZBMva42PnjG2IYf3zbMnCx9xcAathwiPVFRX2AFXoY /qpRYLwUFxoL6fm68FYIy9lpDZCx4iFdfN7pjRogA/Fp+nBf/IqRVytS/kw6XElxCc5v HLzg== X-Forwarded-Encrypted: i=1; AJvYcCV94ZblkfFwgReAJDTBYWAvH+qsMB/JrKaUz4KBaB03Co3EVajzQGszT0DcKSfzic5vLJzPRz5s4Anjg4Y=@vger.kernel.org X-Gm-Message-State: AOJu0YxgqDKK28Z9HQ3MoD3rYysMU4B1Hp0NJlythy8FiP0lSsBiyQ8U wBhbBDAf67Hov+MqmSsiMDmJM2GQeuQC/BlLh/wvXbp6nuE3O/OfA7++8rZx9HFKlII= X-Gm-Gg: ASbGncuG/pWd/TPT+VfBue3udiguzk3Ge1NJVwcPZwZ2fyqQ3dr5rVx5SKJFwjC15FD GrKyICvSnWS40eXLehwfByzTDOKGbLlbS+AT1m5OLBLWPzmR8e7q+HFDwhRjFIj8KD4kjMQyZII yY9Xfh0EJAmsjqA58zu32ezpC2yf0OXztJ0Z5S2ZFZ5OFVKcU84yeOtHvWIXfvCVzqogFZ4zHBK EQG21arOLGb8wO+jVLg8YEda6uZvuDxRlmzJrLD6DX4Uycp/8GaL4sGQagwtEeZLQQKouFJo76j VOOtm+th9HQ7L9Bt5Rv12wisVu3eKkKA0BzhA0I3y/0wwPvef6hSGds= X-Google-Smtp-Source: AGHT+IFfk2JNW5+JEjAS4QGCHFxkYolSwpuwPG6mz1wRQQcTjF+58a/OlpyQ8Y8a8U04LXW/Ou6tzQ== X-Received: by 2002:a05:600c:c04e:b0:44b:eb56:1d45 with SMTP id 5b1f17b1804b1-453249a1500mr45370855e9.15.1749734142562; Thu, 12 Jun 2025 06:15:42 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8b99:9926:3892:5310]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532dea17d7sm20619795e9.10.2025.06.12.06.15.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 06:15:42 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 12 Jun 2025 15:15:24 +0200 Subject: [PATCH 15/16] pinctrl: as3722: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-15-556b0a530cd4@linaro.org> References: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> In-Reply-To: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> To: Dvorkin Dmitry , Wells Lu , Linus Walleij , Bartosz Golaszewski , Patrice Chotard , Support Opensource , Baruch Siach , Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Viresh Kumar , Lakshmi Sowjanya D , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, soc@lists.linux.dev, linux-sunxi@lists.linux.dev, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2237; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=fTmHKsEYrKTNyxoNVzmb5kuSXiJl4noseL2AUv0JQqs=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoStLnJzYKUbqVxOzi9/0Npp9vPvP9vlYV0ANF5 rwLBnERYbWJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaErS5wAKCRARpy6gFHHX coSBEADHmODbD8gx++i43lj29SdaYhpz3ZGxHPtzCbpJM8Weriq+nhM6eLcP4+WvjNqshPbwg/Z n20SACuNZZz+S0+l9KGgSHzYrmCVuUEiF3DNl2mICCeEspJAxClBAGUA2y0Q2TpEV2SLxz2I4dv EtAY+a2ESleqNVnppDCes+DFZ5n5aP6K5VD8Hg7J2DLFYtNp6qHprkyCqcTsOnSb/nuo86E8kZF zDRkzeByIrj4z71f8Y4fLKzDGxq8krDXvhm9SD73b2UCvw6QXQosqznLheEz4+Z9CPrd1jKbE7r cDjRGZ920JYxOSVQHMaipi7GJZsBW/MOU8qI7Ox3HnQbMfHtmliB1rwYB4AhffpcWWuFNw/64se CQfZuf3MI8WBKHUHreGVFrkLIfa/dDyNdag0niMoHvtUfXOc5gdwfyduPuuRAwPEoy/gflanzKJ W/ZDOKFh3IPWI9cbeaKRzvYbJ4CV2OjtB5/gz+V9t7+aIOwlEnHvNhmcYT47t9LDEBkuOasfyVx HOartloAzNYSN3ytVG9SxzobpHzoH5MHqHi1q6l1kLVt8GWdw//Pyxa4Mi/53e/YSBADF7E5j/d icL7N29K4WriyHwptsCLWDZn/Wh/0d2q55xgK3Mjnea9jsemXZ7KgCgdZb4MJD9JsUi+EPUMeDp qq668JcQgjxm84g== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/pinctrl-as3722.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/pinctrl-as3722.c b/drivers/pinctrl/pinctrl-as3= 722.c index 0d8c75ce20eda97627aef773342a0b63ff6114a1..0c7777a7669fe60d7ffd1526326= 1a9f4d5d7b659 100644 --- a/drivers/pinctrl/pinctrl-as3722.c +++ b/drivers/pinctrl/pinctrl-as3722.c @@ -471,8 +471,8 @@ static int as3722_gpio_get(struct gpio_chip *chip, unsi= gned offset) return (invert_enable) ? !val : val; } =20 -static void as3722_gpio_set(struct gpio_chip *chip, unsigned offset, - int value) +static int as3722_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct as3722_pctrl_info *as_pci =3D gpiochip_get_data(chip); struct as3722 *as3722 =3D as_pci->as3722; @@ -484,7 +484,7 @@ static void as3722_gpio_set(struct gpio_chip *chip, uns= igned offset, if (ret < 0) { dev_err(as_pci->dev, "GPIO_CONTROL%d_REG read failed: %d\n", offset, ret); - return; + return ret; } en_invert =3D !!(val & AS3722_GPIO_INV); =20 @@ -498,12 +498,19 @@ static void as3722_gpio_set(struct gpio_chip *chip, u= nsigned offset, if (ret < 0) dev_err(as_pci->dev, "GPIO_SIGNAL_OUT_REG update failed: %d\n", ret); + + return ret; } =20 static int as3722_gpio_direction_output(struct gpio_chip *chip, - unsigned offset, int value) + unsigned int offset, int value) { - as3722_gpio_set(chip, offset, value); + int ret; + + ret =3D as3722_gpio_set(chip, offset, value); + if (ret) + return ret; + return pinctrl_gpio_direction_output(chip, offset); } =20 @@ -520,7 +527,7 @@ static const struct gpio_chip as3722_gpio_chip =3D { .request =3D gpiochip_generic_request, .free =3D gpiochip_generic_free, .get =3D as3722_gpio_get, - .set =3D as3722_gpio_set, + .set_rv =3D as3722_gpio_set, .direction_input =3D pinctrl_gpio_direction_input, .direction_output =3D as3722_gpio_direction_output, .to_irq =3D as3722_gpio_to_irq, --=20 2.48.1 From nobody Fri Oct 10 21:00:35 2025 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A869E25BF03 for ; Thu, 12 Jun 2025 13:15:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734148; cv=none; b=TTJBwAtl0O8Gz47ThQlFy10LjucAK7n2QUXgIfXFG/d8sKA+piQ5UDglJl7/ejvPmk7h96frLkbzf4uTF2pSOlKhTi+KemNguLmnuCdPQ/3a1RlY+R4MdVrA2vVwvhCqHb3aM2wGnM+U7FD3iYTeSrV9aXfZJCzrXN509sQYe+I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734148; c=relaxed/simple; bh=5pAhRcgO1+EuPNUIzj/fNOn0kIQ0uu1BHYpfqb2hKXU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qRkS3/5eL3U8gp2zqVZlkrimErX9wPCZ/Gk66Nowj1UBoHJ2kqz4E8Ph/NjNXsxpd+D3ZkE+J7GIPwj84RrzASHOXn6n6UKBMF1WH4bXh2Rs8+mUK9+OcilzrqCivIUB3LGTIBHkPZe2lQtZFHs0rMlHYgtlReylqdxqRYYW9Mg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=A7ibo2MN; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="A7ibo2MN" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3a4f72cba73so1510045f8f.1 for ; Thu, 12 Jun 2025 06:15:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749734144; x=1750338944; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=qXOeSoBKwd4+haJ3JvgSLXQF+sIOgqi9Fow9Bw5pk0w=; b=A7ibo2MNMC4mdQzPUxLJ38BUt6sOocs1SmvIrjFQX02eFgUqL96WGSikFuneY5HoFY IeEOkK69k+TEL1lNhP7FCu0u/93B06QREGxdgVf718tvD6e3FfHJr/REZ+ug0y3fddMk Q6Ss5NwNQKDouQHGKk51AZNSYJrey5+1yMu2hkqAZtN9Yh/PpNkhsFat8n0at+qzqfK5 WFFJFh19oVo26HFXiaz2qrZF71r8mW/L8jgDQ8wTfZjuZp9AfSq/hFsQAsKQ7dvaGntL l2h478T1XP+/2R6bdnX1JS5EAs5Zm48oOQm/AlldJSqDWW9YnvcZNo0z89UZgGa80H00 MoQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749734144; x=1750338944; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qXOeSoBKwd4+haJ3JvgSLXQF+sIOgqi9Fow9Bw5pk0w=; b=DVc+ykBP68vfcJXxN3vhfpY5TSvpl3CnaNNJUv8d111pDUuqw+V492VXJ/FDvtP0mI TJPVacSHOtYwrN3tcOp9XiqU4bg4LgdbXurSNnVCGyz9xP0KAsj3VEh+OuSLshg+GfXI X+GZQ3uNpim0yAmR3sTT1exuQ3FvAIH5c/yf81i8oQ7kR4uSabyBqdeSDp4sU5VtMJqF hn4VnhRbQY1CAT+Z5+dXr+s6+D30b4+2TYbDVoM/4gGd6ontd20HDfDhwkK7ATuS5WA7 rl+ZXT0d/r5iwieuJ2MiR8MjpevynPFewLv4KcxLXFolhhGbevMEc4Un8vbBF6Yujc79 tLlg== X-Forwarded-Encrypted: i=1; AJvYcCUO1Vd2WJdEA7uhYECOK0BY3Z+GV1x4RYuO+SHPkcHos5RtAxM9P0d8tU58T6VAI9kQ5c2/KfjK9xMYltY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5CVwsu7/iWF2/XROvqaTdX69AL3ivXXR1rzRki5PvEGTjI+Te Iuixyjc0XafHaROHXiJkeAEwY2IMANEXhBZ9E3cGwJ03XPimMKjnvfD78gLUJ4oRKbjod2QBHaY icWVzbtI= X-Gm-Gg: ASbGncsKJshUwUvOqhsQA+Csavhv14OoR17iLiGsPs8LDqkP9yYW2e6TxK221yK9HS3 mFHbdU7fguu0Mdt8Jyp/xTsWNdshY2+APbqzYoE5J2VpgoJEeUfyo8bR1dH/561FHHGzX7HlQV/ 8hAM9UiTASwe6agva6sByiMVojW2pAfuOzFS+g5HapB5esqjJPd+cw/vsnaFghXZqanX7iNXHCB DUmGOmcwsDr5SIU71OrksGS8Z70PRO9Um3Z4Sz+bGrKYULX+pTGLbBhlklQ1yqFGTQGdeJo8+cL QafDwOMtpT7CxA8eyYewsV0wX5ow4Yb2b+qP/U6PaeRk7acNU3IKJP4= X-Google-Smtp-Source: AGHT+IEnpJ6Q4AZ8oPyYmaUzcDZGuReMq7lbniJezZBAPId2TYPV/p2NnMGPvdWDp/pysd3sY6Avhg== X-Received: by 2002:a05:6000:1acc:b0:3a4:eb7a:2ccb with SMTP id ffacd0b85a97d-3a5607fa6a9mr2707038f8f.16.1749734143769; Thu, 12 Jun 2025 06:15:43 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8b99:9926:3892:5310]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532dea17d7sm20619795e9.10.2025.06.12.06.15.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 06:15:43 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 12 Jun 2025 15:15:25 +0200 Subject: [PATCH 16/16] pinctrl: amdisp: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-16-556b0a530cd4@linaro.org> References: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> In-Reply-To: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> To: Dvorkin Dmitry , Wells Lu , Linus Walleij , Bartosz Golaszewski , Patrice Chotard , Support Opensource , Baruch Siach , Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Viresh Kumar , Lakshmi Sowjanya D , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, soc@lists.linux.dev, linux-sunxi@lists.linux.dev, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1643; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=ME7t3PhskqpuTEodGS0joNb0JvX701e6DVecRBqhzik=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoStLn8MZgPfXtIzTahad3jneTgIaic/QOkZGyI SGVy3H/f3GJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaErS5wAKCRARpy6gFHHX cmoRD/0a+ixlOlllZnxdQ3IwiZjofhYGTNWzylVmVuilwkjx74Ac0WhwgNOgk5uCmmF2NGn47Lz E435pD4buRkFabuolt2o9TL8wMz/0RDBg32C9bjwz9fezuo6zTgzSwOjEh5cRd647C84rRl0KWc YHu+TOoz2o4uLlV75o3nQTqLM3l1jFVZ3+VSt31kn1Zavk6/31+PgUYiSjgTIsxlT/Gdps4VRtH wa/aiQgsQsiFHtCM7iv1U583mqmt1fyy3DcZukPCRuIyWOIBMDvi/gqk9leFU29A9h0srxVog+b 2atd0fQ4ad1OubxK41SjP79dMWtYCixfFespdF2IrwaZrVN03CtyobPyUeIkzlYqy+j+XcVocDO NjjWKIYMEYJkruZsAOCp6RnA720dgwIaPMSHCb9EL/t1FuLODewQSnenP5FeWSZaiw/y0s0HNWE u5xsj/scBHbfLBGmsXxgSr7mOO9hzjyNxYki8z8+PdJQHiEWRq0F1D+FoXcIHUqQ4YrQK5Dawhw aQuOGjzWqV36vIoUCA26atb3hiQS/pIePKqxAtnWOg9w2ghzZB8deMzBPTGDg632LEnQYGzr5eV 2jZt4jkSxcUYLzAs2RNnPoiDh546HzSIvkw36qrNT2LHX7VrBQPLJOJDSZX0Wb2L7MnN8xnEan/ UkQWDDMnqWN8GnA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/pinctrl-amdisp.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-amdisp.c b/drivers/pinctrl/pinctrl-amd= isp.c index 9256ed67bb20e9eefef6c6574f1b60d71814cdc0..2e706bf8bcde0536b9e09614665= d46130e12c406 100644 --- a/drivers/pinctrl/pinctrl-amdisp.c +++ b/drivers/pinctrl/pinctrl-amdisp.c @@ -117,7 +117,7 @@ static int amdisp_gpio_get(struct gpio_chip *gc, unsign= ed int gpio) return !!(pin_reg & BIT(GPIO_CONTROL_PIN)); } =20 -static void amdisp_gpio_set(struct gpio_chip *gc, unsigned int gpio, int v= alue) +static int amdisp_gpio_set(struct gpio_chip *gc, unsigned int gpio, int va= lue) { unsigned long flags; u32 pin_reg; @@ -131,6 +131,8 @@ static void amdisp_gpio_set(struct gpio_chip *gc, unsig= ned int gpio, int value) pin_reg &=3D ~BIT(GPIO_CONTROL_PIN); writel(pin_reg, pctrl->gpiobase + gpio_offset[gpio]); raw_spin_unlock_irqrestore(&pctrl->lock, flags); + + return 0; } =20 static int amdisp_gpiochip_add(struct platform_device *pdev, @@ -149,7 +151,7 @@ static int amdisp_gpiochip_add(struct platform_device *= pdev, gc->direction_input =3D amdisp_gpio_direction_input; gc->direction_output =3D amdisp_gpio_direction_output; gc->get =3D amdisp_gpio_get; - gc->set =3D amdisp_gpio_set; + gc->set_rv =3D amdisp_gpio_set; gc->base =3D -1; gc->ngpio =3D ARRAY_SIZE(amdisp_range_pins); =20 --=20 2.48.1