From nobody Tue Feb 10 12:59:17 2026 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21F73298CB5; Thu, 12 Jun 2025 15:18:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749741532; cv=none; b=JhfmlG8u3G10T6VGTsIQnY6VDTgFG1Oe9KAO0xj9dyisrhRctTfSNwCfs93muw3szvA5MV343PvaEPEd6ypSpfh+5N8X1g/saMKRk+ih/c8HYK+LWiZaJ/XThP30r1KK+/x2W8KyWoy+m1lutCStDgfAxruR42kxhZW8+xXxDY8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749741532; c=relaxed/simple; bh=ZiS4ua4T6SpoiJKR8NBn3iuuQzEl+7w9fvlp8z/W/Vs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AQBOLzfQGvwP9QUQvoOR0wBHFlpT+T2G+s7Ikrxh0s6NF5JVt5SltPYds+maxuDmBz8DkgchtX7Dw565Q8PVl903X2lCzPq8QcVigCEtxysdkSlXCh6xy7Dj3BCnB6LJZL5Gac+Ja654xpNIhH6irSuq9Qv/o1ZzMiRf9J7oJQ0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=d7Q/eyN7; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="d7Q/eyN7" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 910B425F0B; Thu, 12 Jun 2025 17:18:49 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 2Vk_K1Nx03DA; Thu, 12 Jun 2025 17:18:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1749741528; bh=ZiS4ua4T6SpoiJKR8NBn3iuuQzEl+7w9fvlp8z/W/Vs=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=d7Q/eyN7ujwuudiipQHww523RDGq/M2seNny4ykdVRHTdtM14x5WqdqET9SmEeH/r s4W36v3HYv5E9dY/SMPrjd2TDv8yrul7pTU3vtggqopHayynjKmWFvu+sJxWGcB6jp Tt3GKB54VyhpMeXJnpHZtIt58tFasCLlH5Q1aj0lQlkjfck+zS6prfCMXDQNV5Opek ofar2bs5fX55LZh0xVB8E57JQWewJ9KnC9CTQhAOXOseWQ0xovdD43DT62e2MVu3GS cw7o2ebHZ5AuFoamxtKOYj44WXcIwGoJeqcIuIQ0FxC4PkhwNk2R5jGXkduuKxd/A2 1Ca8nKJoX7kfg== From: Kaustabh Chakraborty Date: Thu, 12 Jun 2025 20:48:06 +0530 Subject: [PATCH 02/12] drm/bridge: samsung-dsim: add SFRCTRL register Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250612-exynos7870-dsim-v1-2-1a330bca89df@disroot.org> References: <20250612-exynos7870-dsim-v1-0-1a330bca89df@disroot.org> In-Reply-To: <20250612-exynos7870-dsim-v1-0-1a330bca89df@disroot.org> To: Inki Dae , Jagan Teki , Marek Szyprowski , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Kaustabh Chakraborty X-Developer-Signature: v=1; a=ed25519-sha256; t=1749741499; l=2917; i=kauschluss@disroot.org; s=20250202; h=from:subject:message-id; bh=ZiS4ua4T6SpoiJKR8NBn3iuuQzEl+7w9fvlp8z/W/Vs=; b=v6cwmp1CzCmr1eEIEGTYK4kRVkG3M623+dY8XkOLuj+qmVxSq1/NwcrM6rgy4uxwk/tb5aRCa WZBsXfdFqK/Ds/y6do/YAu2Op73mV6/cUK9Z5wtFFE7EusFL2WeeaxG X-Developer-Key: i=kauschluss@disroot.org; a=ed25519; pk=h2xeR+V2I1+GrfDPAhZa3M+NWA0Cnbdkkq1bH3ct1hE= On Exynos7870 devices, enabling the display requires disabling standby by writing to the SFRCTRL register. Add the register and related bit values. Since this behavior isn't available on other SoCs, implement a flag in the driver data struct indicating the availability of this feature. Signed-off-by: Kaustabh Chakraborty --- drivers/gpu/drm/bridge/samsung-dsim.c | 16 ++++++++++++++++ include/drm/bridge/samsung-dsim.h | 1 + 2 files changed, 17 insertions(+) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge= /samsung-dsim.c index c418d9e30222ec47eec05bbdefef3df8b7fec3c4..e7287c289e0f8d01e2954075788= 17801bad9d8c8 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -155,6 +155,11 @@ #define DSIM_INT_RX_ECC_ERR BIT(15) #define DSIM_INT_RX_CRC_ERR BIT(14) =20 +/* DSIM_SFRCTRL */ +#define DSIM_SFR_CTRL_STAND_BY BIT(4) +#define DSIM_SFR_CTRL_SHADOW_UPDATE BIT(1) +#define DSIM_SFR_CTRL_SHADOW_EN BIT(0) + /* DSIM_FIFOCTRL */ #define DSIM_RX_DATA_FULL BIT(25) #define DSIM_RX_DATA_EMPTY BIT(24) @@ -254,6 +259,7 @@ enum reg_idx { DSIM_PKTHDR_REG, /* Packet Header FIFO register */ DSIM_PAYLOAD_REG, /* Payload FIFO register */ DSIM_RXFIFO_REG, /* Read FIFO register */ + DSIM_SFRCTRL_REG, /* SFR standby and shadow control register */ DSIM_FIFOCTRL_REG, /* FIFO status and control register */ DSIM_PLLCTRL_REG, /* PLL control register */ DSIM_PHYCTRL_REG, @@ -1029,6 +1035,7 @@ static void samsung_dsim_set_display_mode(struct sams= ung_dsim *dsi) =20 static void samsung_dsim_set_display_enable(struct samsung_dsim *dsi, bool= enable) { + const struct samsung_dsim_driver_data *driver_data =3D dsi->driver_data; u32 reg; =20 reg =3D samsung_dsim_read(dsi, DSIM_MDRESOL_REG); @@ -1037,6 +1044,15 @@ static void samsung_dsim_set_display_enable(struct s= amsung_dsim *dsi, bool enabl else reg &=3D ~DSIM_MAIN_STAND_BY; samsung_dsim_write(dsi, DSIM_MDRESOL_REG, reg); + + if (driver_data->has_sfrctrl) { + reg =3D samsung_dsim_read(dsi, DSIM_SFRCTRL_REG); + if (enable) + reg |=3D DSIM_SFR_CTRL_STAND_BY; + else + reg &=3D ~DSIM_SFR_CTRL_STAND_BY; + samsung_dsim_write(dsi, DSIM_SFRCTRL_REG, reg); + } } =20 static int samsung_dsim_wait_for_hdr_fifo(struct samsung_dsim *dsi) diff --git a/include/drm/bridge/samsung-dsim.h b/include/drm/bridge/samsung= -dsim.h index 9764d6eb5beb98b5b9427c5c4775c37b24dd6e17..a50e4f521b9d9561f6a3b9fe3e1= 74c0e140849a2 100644 --- a/include/drm/bridge/samsung-dsim.h +++ b/include/drm/bridge/samsung-dsim.h @@ -56,6 +56,7 @@ struct samsung_dsim_driver_data { unsigned int has_freqband:1; unsigned int has_clklane_stop:1; unsigned int has_broken_fifoctrl_emptyhdr:1; + unsigned int has_sfrctrl:1; unsigned int num_clks; unsigned int min_freq; unsigned int max_freq; --=20 2.49.0