From nobody Sat Oct 11 04:13:41 2025 Received: from relay.smtp-ext.broadcom.com (relay.smtp-ext.broadcom.com [192.19.166.231]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9C42225413; Wed, 11 Jun 2025 21:27:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.19.166.231 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749677260; cv=none; b=pI6UDaZ5eJFBZOhPOAqpH+PkUJDIohr9u19n4NUJcvSr02S07MeLXjA7sc/YNsJfVXVTBd4/mGjBUR7bzr+hGRBq2esmYjYu6kmkxH6jzhAk+mt4FkdjcDI1NZy8ZYTFMZn4Hu/LjGWfYqfnucOnNbNfMmd4V/kivi100TMI+/E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749677260; c=relaxed/simple; bh=r1BuQBYBAW6rqeGVd7IX2D2PqK1FkNIQJArsBxJUFIg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=QMdr6hjxTp6tEp+ykE1gUMx5efk8UJ34uPQhnUNtwcn7+6Y9binSvZFf3WxIR4mnin+TofLMewH3B3COKrrbXulr/WltX8Tcx2SgTyke43TEWRLaNNkB7po4Wze0+S/OFAxaBMpYNRLInQs7uKOhy6pid35j/JsHCf+K46w+QJA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=WNYowpiP; arc=none smtp.client-ip=192.19.166.231 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="WNYowpiP" Received: from mail-lvn-it-01.broadcom.com (mail-lvn-it-01.lvn.broadcom.net [10.36.132.253]) by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id 19CE1C0000D6; Wed, 11 Jun 2025 14:27:32 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 19CE1C0000D6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1749677252; bh=r1BuQBYBAW6rqeGVd7IX2D2PqK1FkNIQJArsBxJUFIg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WNYowpiPzGiZU2qDtJSgdkP6iIrwuNHjEzSf5zCPesXpv8WpY5YJhwQze/SiBFuqY OVRgnTVg7f1DH+DoDSXsCtv+flEmDHfYbceQIgAgejj853nAVipv4oxlZc8IV1GuO/ oEsz5EtxWhqhGfdlaIPaaZY0JdYxdbJthaK9qhus= Received: from stbirv-lnx-1.igp.broadcom.net (stbirv-lnx-1.igp.broadcom.net [10.67.48.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail-lvn-it-01.broadcom.com (Postfix) with ESMTPSA id ECDA618000847; Wed, 11 Jun 2025 14:27:31 -0700 (PDT) From: Florian Fainelli To: netdev@vger.kernel.org Cc: Florian Fainelli , Justin Chen , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , bcm-kernel-feedback-list@broadcom.com (open list:BROADCOM ASP 2.0 ETHERNET DRIVER), linux-kernel@vger.kernel.org (open list) Subject: [PATCH net-next v2 1/2] net: bcmasp: Utilize napi_complete_done() return value Date: Wed, 11 Jun 2025 14:27:29 -0700 Message-Id: <20250611212730.252342-2-florian.fainelli@broadcom.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250611212730.252342-1-florian.fainelli@broadcom.com> References: <20250611212730.252342-1-florian.fainelli@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make use of the return value from napi_complete_done(). This allows users to use the gro_flush_timeout and napi_defer_hard_irqs sysfs attributes for configuring software interrupt coalescing. Signed-off-by: Florian Fainelli Reviewed-by: Justin Chen Reviewed-by: Joe Damato --- drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c b/drivers/net= /ethernet/broadcom/asp2/bcmasp_intf.c index 0d61b8580d72..7dc28166d337 100644 --- a/drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c +++ b/drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c @@ -605,10 +605,8 @@ static int bcmasp_rx_poll(struct napi_struct *napi, in= t budget) =20 bcmasp_intf_rx_desc_write(intf, intf->rx_edpkt_dma_read); =20 - if (processed < budget) { - napi_complete_done(&intf->rx_napi, processed); + if (processed < budget && napi_complete_done(&intf->rx_napi, processed)) bcmasp_enable_rx_irq(intf, 1); - } =20 return processed; } --=20 2.34.1