From nobody Sat Oct 11 08:04:33 2025 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2046.outbound.protection.outlook.com [40.107.223.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FFE635962 for ; Wed, 11 Jun 2025 04:09:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.223.46 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749614963; cv=fail; b=Vl6s+kn2e2Ky4b8pnP4rymAd/6ohXMXaMSE+jR4AHXnjw4KJLaV7JsEs4sW8jgfoWjzC4jAPx00giPEPDBnOQakX55VL+zYkYdAu7fDKzpiCjIHwuk4UN83D6D0A792pYEvp/0Y4ThkUJxjWZ5TX5P2MYP8s3kIJKm528eyTcf0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749614963; c=relaxed/simple; bh=1EuR2v9IHE4rIKXEkaQQGrHkMzRyT1lqiH4hE/3wEUE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XdTIDyVG/lhYumcvE9yCKTnAffLnquEJCQCLC+GYFBpXNsNzHU05GB70kucWMjHPf+AU6mahvjlF7v7x4TYVYktUvs82A397Rw4PY205ZNXs90Mo4bcXf1OgvKBCXi3iH9pVNg3LKW5NUCoyeZxGleBKKyKmBlO2exbj79wwrOI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=B9zp0bLu; arc=fail smtp.client-ip=40.107.223.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="B9zp0bLu" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SxUz/38vsj6TCV6oB2s848FMlC+hW5QpysCUuWw069a0uAnLoNlZgDonDTiwt4qtos5aXPQ3sPplUYHPaqN7atHmjtCe8fRRgw39o3MzD388B5U+BbrTsJ02wQjx2N4swil3XsUlcXZmSdh9TwviIE1yS2azhxLDH1BKQrwS/QZXKnJMbS7gInskCo7tINFkGG48kyXa2S26F6CfxDH/3oY240ChSPMeoayuQOlh6eg2zqIJ0rkcpcWWrvzMqzsDzezCba/Gen0CaZwtAeUgWN3K0nKuSl16+KSWmFPckg7NYFqPT9JVRwJB9Pt7eznb3KAyVMLyGPjn7MOe6tMKUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EeWRXrH9ElZrG0T28y6CuOEt8+O7ZJvbQPVa0JiMfRA=; b=HALCNdlZ5/828NiBgV3GZXkz5+3VvyzLp2CZwIx5mo2pJ1dmYTQc279AZU76xUHTnvAGROt5r+OyO433vi4ZXFKL1lDbypsNVBq7yU94bz8eZiciao2+sg6FNjlnun5xsrwnTSV5RJowh077luo3kTOqYshkSp3y3/YpQOO3SNSYy5TRYJnLunADGoxrCDn9MzsAbFzcT5Mkpf2nTQOA24k2o7k2DK49S71J7Lkd4XS134tZFsBniXtHfqnY5BIfU1Pm8Jys2JlJz95x/isyqunr7PIVL+5yBaM4//KgmUqun7JHtu+p1J2Z6N/N4lPlP+QYB2bGew/Qa4QA2JjLTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EeWRXrH9ElZrG0T28y6CuOEt8+O7ZJvbQPVa0JiMfRA=; b=B9zp0bLu4TbQ6y/usWLpPqvDIUk4t+b/UidsE0iz4Q3DkKDXDki/MN4DILgAZFh+k/eiI5HYdXD8tbjEzDuOeqc+2obH8ogSw4wnW9AJNOOV4F5rTBFQ4CDiKltf6y2L+cguKXtK2ooMBfq9F9rcJsPOitJcabFdH/kq/iNR3zw= Received: from DM6PR11CA0069.namprd11.prod.outlook.com (2603:10b6:5:14c::46) by CYYPR12MB8962.namprd12.prod.outlook.com (2603:10b6:930:c4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.18; Wed, 11 Jun 2025 04:09:17 +0000 Received: from CH3PEPF00000015.namprd21.prod.outlook.com (2603:10b6:5:14c:cafe::92) by DM6PR11CA0069.outlook.office365.com (2603:10b6:5:14c::46) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8746.31 via Frontend Transport; Wed, 11 Jun 2025 04:09:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH3PEPF00000015.mail.protection.outlook.com (10.167.244.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8835.2 via Frontend Transport; Wed, 11 Jun 2025 04:09:17 +0000 Received: from aiemdee.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 10 Jun 2025 23:09:13 -0500 From: Alexey Kardashevskiy To: CC: , Thomas Gleixner , "Ingo Molnar" , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Tom Lendacky , Nikunj A Dadhania , Ard Biesheuvel , Ashish Kalra , Dionna Glaze , Michael Roth , "Kuppuswamy Sathyanarayanan" , "Alexey Kardashevskiy" Subject: [PATCH v2 1/4] virt: sev-guest: Contain snp_guest_request_ioctl in sev-guest Date: Wed, 11 Jun 2025 14:08:39 +1000 Message-ID: <20250611040842.2667262-2-aik@amd.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250611040842.2667262-1-aik@amd.com> References: <20250611040842.2667262-1-aik@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000015:EE_|CYYPR12MB8962:EE_ X-MS-Office365-Filtering-Correlation-Id: 5d20ddbd-d002-4e39-72f8-08dda89dbc23 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|7416014|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?2b7PaelpvN4ddwT5Hrv/EBekWeb6k8cr51CaTL4v9Ce4ADa7Ayb2r9AlRIts?= =?us-ascii?Q?cixeDwg2ZzDd/fgL+U1T+/8+uH1qgNeg2I0TUr6ZLGQAAM2ZZddwIl/7QLC5?= =?us-ascii?Q?AKfiqc9nN7H3QYkbJqXFv3uNt2z5Hx2Sp3PxFWP/XkL9iG2AGsbqbtAQ30u1?= =?us-ascii?Q?MybburCvBNRW67S908IEqJPqnktnmRyQKO5x8MT4aLivIWNYZ1B+0tqvIyAZ?= =?us-ascii?Q?KfiVIwpQkrwYRa94h1DKkMRbX7mD5AdSQElxekq8X5qhYyzDfjB1ch8k0eBy?= =?us-ascii?Q?gZRUoLHb2ba2MUrwNATYa3J7RY4tiM6rKssOmeWhoO9LhVvlRckb4ZFLGZ9O?= =?us-ascii?Q?v2dgp9wi7i4cWMnB6fclg1nT4BZD5AeBQfVDdHCGK7IZB78URO5yfsQOICxq?= =?us-ascii?Q?+7adAcbjGoc/fAbjlee1SvGDKVlgHfXa5ORJrKeqpKp+7/eIggo4DDeziBND?= =?us-ascii?Q?/s9El0yRtDDDo9RA5yVR2CVq8wfh+gv21qmWUda2gDl64uwELgLXpJ4489uL?= =?us-ascii?Q?e2G6s3Vw8fGdzOQGACqfX+Dkm55Sacs21Ieaq0G6WgQEbNFB+daLJ3LwRXtu?= =?us-ascii?Q?Ye4xqcoqCf+tYJMArq0vNqphDjRAkwTtyk/LgZCoaPyNmQ0tLZWEdFM1RIKN?= =?us-ascii?Q?bWURfkIhxg7wBb7yqxosc1JNmxerc1kGiNeRGCwyQPBTafZ71QWN+lqXiLAu?= =?us-ascii?Q?mUqaiFQw0Xa6/9vHymv3Oy4U51svzmyA3zTICufIzMtFrd/8NHQ+W/2UdoQj?= =?us-ascii?Q?D0hFXuE60WInJJ16dd6OlY1UdyPpQQ/D5ILvvIeKDTViutEMl/pqrgQJXz2W?= =?us-ascii?Q?ZI+YKOoOk37X0u66fi1GDiEtN9UgxYQD1cxEFP5o94DmxhnvI2vT6Ow/t/2L?= =?us-ascii?Q?Atki5yQj8IUpI3BBthVhZIkPA86S8nPikqsfsoR0e/269Gzf8wJxgFuEDEb6?= =?us-ascii?Q?5cay1VNwaBg0e+evy8ak8QmYT5sLzOprjRmDtefLIyQiBsnUUGeoTThB6WAz?= =?us-ascii?Q?7cVYkq0C7V9++STFYSZHJ20ivJH1cfl4nMDurT8LFKQA73RM/F41ZI9ihAke?= =?us-ascii?Q?KyIplp5A1eaftVCF7iH3H3UaWDgr5493hHKiB6QZE7oODdmqEEWQafxX8TTf?= =?us-ascii?Q?kCHT6e1EqaqJzbM6uG1XCvDM3VmqmTMon1FFM+63eNuKHUUyeBRzd94w2X9T?= =?us-ascii?Q?dI7TQggjZEz6mXivxZZDU5O3dRkMyKQGzLISfCVGxWbpgiQfntis8ueSSUSg?= =?us-ascii?Q?Vl7rCUPvEkGGkRhCU72ojeZ9BLKUhuRcToh7hJOM5F5dphm0+FfykjFzO9c1?= =?us-ascii?Q?KTE05G5rabp5tOTSi69Qv8MXThr4OzC8iRmCSvHzwq8qmZXNOSHn4H0gqfI1?= =?us-ascii?Q?3iuCChJOCsywxnQH3wOjm3KMnY9RkeudsQ9UQ7Hb6tuTxQx8HiXTa8fEmqnm?= =?us-ascii?Q?Owuipn+3IxHpKcnQJQGmYqGDWeCWktn2hWghINYvFQCxzK6iEqmAZ/YnWyMJ?= =?us-ascii?Q?u5ywcPwOE+b2CvpowI+mbx6Bu8rLXLmn3tkR?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(7416014)(376014)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2025 04:09:17.5701 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5d20ddbd-d002-4e39-72f8-08dda89dbc23 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000015.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8962 Content-Type: text/plain; charset="utf-8" SNP Guest Request only uses exitinfo2 which is a return value from GHCB, has meaning beyond ioctl and therefore belongs to snp_guest_req. Move exitinfo2 to snp_guest_req, remove snp_guest_request_ioctl from the SEV platform code. No functional change intended. Reviewed-by: Tom Lendacky Reviewed-by: Dionna Glaze Signed-off-by: Alexey Kardashevskiy --- Not passing exitinfo2 as a parameter as it's been mentioned on v2: =3D=3D=3D having a struct request which collects all fields you need to pass down or = return to callers is the RightThing(tm) to do. =3D=3D=3D --- arch/x86/include/asm/sev.h | 10 +++--- arch/x86/coco/sev/core.c | 36 +++++++------------- drivers/virt/coco/sev-guest/sev-guest.c | 9 +++-- 3 files changed, 23 insertions(+), 32 deletions(-) diff --git a/arch/x86/include/asm/sev.h b/arch/x86/include/asm/sev.h index 58e028d42e41..fbb616fcbfb8 100644 --- a/arch/x86/include/asm/sev.h +++ b/arch/x86/include/asm/sev.h @@ -231,6 +231,7 @@ struct snp_guest_req { size_t resp_sz; =20 u64 exit_code; + u64 exitinfo2; unsigned int vmpck_id; u8 msg_version; u8 msg_type; @@ -486,8 +487,6 @@ static inline int pvalidate(unsigned long vaddr, bool r= mp_psize, bool validate) return rc; } =20 -struct snp_guest_request_ioctl; - void setup_ghcb(void); void early_snp_set_memory_private(unsigned long vaddr, unsigned long paddr, unsigned long npages); @@ -513,8 +512,7 @@ void snp_kexec_begin(void); int snp_msg_init(struct snp_msg_desc *mdesc, int vmpck_id); struct snp_msg_desc *snp_msg_alloc(void); void snp_msg_free(struct snp_msg_desc *mdesc); -int snp_send_guest_request(struct snp_msg_desc *mdesc, struct snp_guest_re= q *req, - struct snp_guest_request_ioctl *rio); +int snp_send_guest_request(struct snp_msg_desc *mdesc, struct snp_guest_re= q *req); =20 int snp_svsm_vtpm_send_command(u8 *buffer); =20 @@ -587,8 +585,8 @@ static inline void snp_kexec_begin(void) { } static inline int snp_msg_init(struct snp_msg_desc *mdesc, int vmpck_id) {= return -1; } static inline struct snp_msg_desc *snp_msg_alloc(void) { return NULL; } static inline void snp_msg_free(struct snp_msg_desc *mdesc) { } -static inline int snp_send_guest_request(struct snp_msg_desc *mdesc, struc= t snp_guest_req *req, - struct snp_guest_request_ioctl *rio) { return -ENODEV; } +static inline int snp_send_guest_request(struct snp_msg_desc *mdesc, + struct snp_guest_req *req) { return -ENODEV; } static inline int snp_svsm_vtpm_send_command(u8 *buffer) { return -ENODEV;= } static inline void __init snp_secure_tsc_prepare(void) { } static inline void __init snp_secure_tsc_init(void) { } diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c index b6db4e0b936b..cf91cb4e2c47 100644 --- a/arch/x86/coco/sev/core.c +++ b/arch/x86/coco/sev/core.c @@ -1389,8 +1389,7 @@ int snp_issue_svsm_attest_req(u64 call_id, struct svs= m_call *call, } EXPORT_SYMBOL_GPL(snp_issue_svsm_attest_req); =20 -static int snp_issue_guest_request(struct snp_guest_req *req, struct snp_r= eq_data *input, - struct snp_guest_request_ioctl *rio) +static int snp_issue_guest_request(struct snp_guest_req *req, struct snp_r= eq_data *input) { struct ghcb_state state; struct es_em_ctxt ctxt; @@ -1398,7 +1397,7 @@ static int snp_issue_guest_request(struct snp_guest_r= eq *req, struct snp_req_dat struct ghcb *ghcb; int ret; =20 - rio->exitinfo2 =3D SEV_RET_NO_FW_CALL; + req->exitinfo2 =3D SEV_RET_NO_FW_CALL; =20 /* * __sev_get_ghcb() needs to run with IRQs disabled because it is using @@ -1423,8 +1422,8 @@ static int snp_issue_guest_request(struct snp_guest_r= eq *req, struct snp_req_dat if (ret) goto e_put; =20 - rio->exitinfo2 =3D ghcb->save.sw_exit_info_2; - switch (rio->exitinfo2) { + req->exitinfo2 =3D ghcb->save.sw_exit_info_2; + switch (req->exitinfo2) { case 0: break; =20 @@ -1919,8 +1918,7 @@ static int enc_payload(struct snp_msg_desc *mdesc, u6= 4 seqno, struct snp_guest_r return 0; } =20 -static int __handle_guest_request(struct snp_msg_desc *mdesc, struct snp_g= uest_req *req, - struct snp_guest_request_ioctl *rio) +static int __handle_guest_request(struct snp_msg_desc *mdesc, struct snp_g= uest_req *req) { unsigned long req_start =3D jiffies; unsigned int override_npages =3D 0; @@ -1934,7 +1932,7 @@ static int __handle_guest_request(struct snp_msg_desc= *mdesc, struct snp_guest_r * sequence number must be incremented or the VMPCK must be deleted to * prevent reuse of the IV. */ - rc =3D snp_issue_guest_request(req, &req->input, rio); + rc =3D snp_issue_guest_request(req, &req->input); switch (rc) { case -ENOSPC: /* @@ -1987,7 +1985,7 @@ static int __handle_guest_request(struct snp_msg_desc= *mdesc, struct snp_guest_r snp_inc_msg_seqno(mdesc); =20 if (override_err) { - rio->exitinfo2 =3D override_err; + req->exitinfo2 =3D override_err; =20 /* * If an extended guest request was issued and the supplied certificate @@ -2005,8 +2003,7 @@ static int __handle_guest_request(struct snp_msg_desc= *mdesc, struct snp_guest_r return rc; } =20 -int snp_send_guest_request(struct snp_msg_desc *mdesc, struct snp_guest_re= q *req, - struct snp_guest_request_ioctl *rio) +int snp_send_guest_request(struct snp_msg_desc *mdesc, struct snp_guest_re= q *req) { u64 seqno; int rc; @@ -2043,14 +2040,14 @@ int snp_send_guest_request(struct snp_msg_desc *mde= sc, struct snp_guest_req *req req->input.resp_gpa =3D __pa(mdesc->response); req->input.data_gpa =3D req->certs_data ? __pa(req->certs_data) : 0; =20 - rc =3D __handle_guest_request(mdesc, req, rio); + rc =3D __handle_guest_request(mdesc, req); if (rc) { if (rc =3D=3D -EIO && - rio->exitinfo2 =3D=3D SNP_GUEST_VMM_ERR(SNP_GUEST_VMM_ERR_INVALID_LE= N)) + req->exitinfo2 =3D=3D SNP_GUEST_VMM_ERR(SNP_GUEST_VMM_ERR_INVALID_LE= N)) return rc; =20 pr_alert("Detected error from ASP request. rc: %d, exitinfo2: 0x%llx\n", - rc, rio->exitinfo2); + rc, req->exitinfo2); =20 snp_disable_vmpck(mdesc); return rc; @@ -2069,7 +2066,6 @@ EXPORT_SYMBOL_GPL(snp_send_guest_request); =20 static int __init snp_get_tsc_info(void) { - struct snp_guest_request_ioctl *rio; struct snp_tsc_info_resp *tsc_resp; struct snp_tsc_info_req *tsc_req; struct snp_msg_desc *mdesc; @@ -2093,13 +2089,9 @@ static int __init snp_get_tsc_info(void) if (!req) goto e_free_tsc_resp; =20 - rio =3D kzalloc(sizeof(*rio), GFP_KERNEL); - if (!rio) - goto e_free_req; - mdesc =3D snp_msg_alloc(); if (IS_ERR_OR_NULL(mdesc)) - goto e_free_rio; + goto e_free_req; =20 rc =3D snp_msg_init(mdesc, snp_vmpl); if (rc) @@ -2114,7 +2106,7 @@ static int __init snp_get_tsc_info(void) req->resp_sz =3D sizeof(*tsc_resp) + AUTHTAG_LEN; req->exit_code =3D SVM_VMGEXIT_GUEST_REQUEST; =20 - rc =3D snp_send_guest_request(mdesc, req, rio); + rc =3D snp_send_guest_request(mdesc, req); if (rc) goto e_request; =20 @@ -2135,8 +2127,6 @@ static int __init snp_get_tsc_info(void) memzero_explicit(tsc_resp, sizeof(*tsc_resp) + AUTHTAG_LEN); e_free_mdesc: snp_msg_free(mdesc); -e_free_rio: - kfree(rio); e_free_req: kfree(req); e_free_tsc_resp: diff --git a/drivers/virt/coco/sev-guest/sev-guest.c b/drivers/virt/coco/se= v-guest/sev-guest.c index 7a4e2188f109..d2b3ae7113ab 100644 --- a/drivers/virt/coco/sev-guest/sev-guest.c +++ b/drivers/virt/coco/sev-guest/sev-guest.c @@ -101,7 +101,8 @@ static int get_report(struct snp_guest_dev *snp_dev, st= ruct snp_guest_request_io req.resp_sz =3D resp_len; req.exit_code =3D SVM_VMGEXIT_GUEST_REQUEST; =20 - rc =3D snp_send_guest_request(mdesc, &req, arg); + rc =3D snp_send_guest_request(mdesc, &req); + arg->exitinfo2 =3D req.exitinfo2; if (rc) goto e_free; =20 @@ -152,7 +153,8 @@ static int get_derived_key(struct snp_guest_dev *snp_de= v, struct snp_guest_reque req.resp_sz =3D resp_len; req.exit_code =3D SVM_VMGEXIT_GUEST_REQUEST; =20 - rc =3D snp_send_guest_request(mdesc, &req, arg); + rc =3D snp_send_guest_request(mdesc, &req); + arg->exitinfo2 =3D req.exitinfo2; if (rc) return rc; =20 @@ -249,7 +251,8 @@ static int get_ext_report(struct snp_guest_dev *snp_dev= , struct snp_guest_reques req.resp_sz =3D resp_len; req.exit_code =3D SVM_VMGEXIT_EXT_GUEST_REQUEST; =20 - ret =3D snp_send_guest_request(mdesc, &req, arg); + ret =3D snp_send_guest_request(mdesc, &req); + arg->exitinfo2 =3D req.exitinfo2; =20 /* If certs length is invalid then copy the returned length */ if (arg->vmm_error =3D=3D SNP_GUEST_VMM_ERR_INVALID_LEN) { --=20 2.49.0 From nobody Sat Oct 11 08:04:33 2025 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2088.outbound.protection.outlook.com [40.107.92.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9CB11D89FD for ; Wed, 11 Jun 2025 04:09:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.92.88 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749614980; cv=fail; b=ixBbc0Bpeh+cEzI1ddLb/VcB5PRpW2h+SzvNYZRrRHnfKdr3oquq1SHbhuN7ny6eCyaFRIFsAq6toDRub6OokNDz80JTCo+Yk42mQMpJAHMf+WCuAYNx1T4KZLplVHMga0ZQZKhHqs3MR1q/lYnRglb6JOqzxsIfgQzPAJ/jGwM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749614980; c=relaxed/simple; bh=/FdsD9XS/55iPX8cZsEcYNXFufyWxiNoZbteyjhBRas=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RhH1+x+srfyJFIOPFjgG62dcqErQWmoDtbjzcNXFoQG0KXw1byQ8xoOAH4xVWQ/H3o43Nm5gVC0fSJWg2Q8pUH23J4vl79gTDNRWq40Vd4TOTRCYOqaYcDoVdpqbiufYc9F9eoq8N7LeV6WW8anacKhtne8yk3uMdDBK7fmZuaw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=DHZJA9po; arc=fail smtp.client-ip=40.107.92.88 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="DHZJA9po" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AAzz9ZkkK8uFCL56lb86IZac19uquSOqUmI4VGzhr+QtfMEnaGxjBOpfoA+CWuRvK1Lc6gLBbk+EbD1RgMcW+DN5MQufttWvN5GhDfgk9Wei8Lc3e8qglVfNYw4AS6hk9umOveMVbO0jsgFeNAKg8DjZHLyADGqv6xYT7kT60jOJS0mhGUt1yr4bivtIi0PSp0dV0aHJJKphzVRRwWE48kp/TUWZPwZUvcmbfh3uiLgMcd5x2yquaXzn4PSOKuuOwsGt4JtOhp/7UiTZTy6Y6/26xjO7hBeKkcjbtP7h9ga4wa6pWlPJR9XwQ4RhjYGj3TlQ6Y7DUIItGTlcnWIcTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eY6nf3eFrMXZiRmq/3cht4aBo0KYtRDaf9JqcdKUluo=; b=wmaICjUiVbiCOxI0dyppqR03upatY9lctlYDJQ1/PXYZ1URazIIBi0MDmTiCufx422FZB/9paXqzZ4N33rQ07WDl9TKRtBZgsooNZhuoW9sS10aBeGnOPlf20yqDiO83QKSKeQczmaW5xMcKMC9Opj7qBSsNB2fXdEHdqEM4wCNlO0vkPleMt07ql04LTsHhat1pEakkesCv17oUMNuu+mFOxB0VnvySIeCclC/ifBkWLuTq4D69EraFcnC2g1kv+SzOX67DSmBibTSG+O8YhmuTpuK/9aLoo1IDufkaOAknMmMLnXW1D1B0gIEBUVPVt94pztMuo6cxyFzl8x5GUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eY6nf3eFrMXZiRmq/3cht4aBo0KYtRDaf9JqcdKUluo=; b=DHZJA9poKSrxqTOlpBgybXil0F/X+R8Vd3wnVDgQ1gOrclqI+Dpn/hJHIrXDlrsNj2tBjzmB8h5DABgwhMc26RbSEEt19/E+s6e1KmnjPVqGXDXVG/3wXuG303sS1u/jYjh3misC020hhGij68+zz5RYgcuxkVe6tXMBAgr9dEE= Received: from DS7PR03CA0081.namprd03.prod.outlook.com (2603:10b6:5:3bb::26) by DS4PR12MB9610.namprd12.prod.outlook.com (2603:10b6:8:277::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8792.38; Wed, 11 Jun 2025 04:09:35 +0000 Received: from CH3PEPF00000011.namprd21.prod.outlook.com (2603:10b6:5:3bb:cafe::13) by DS7PR03CA0081.outlook.office365.com (2603:10b6:5:3bb::26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8835.17 via Frontend Transport; Wed, 11 Jun 2025 04:09:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH3PEPF00000011.mail.protection.outlook.com (10.167.244.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8835.2 via Frontend Transport; Wed, 11 Jun 2025 04:09:33 +0000 Received: from aiemdee.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 10 Jun 2025 23:09:29 -0500 From: Alexey Kardashevskiy To: CC: , Thomas Gleixner , "Ingo Molnar" , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Tom Lendacky , Nikunj A Dadhania , Ard Biesheuvel , Ashish Kalra , Dionna Glaze , Michael Roth , "Kuppuswamy Sathyanarayanan" , "Alexey Kardashevskiy" Subject: [PATCH v2 2/4] x86/sev: Allocate request in TSC_INFO_REQ on stack Date: Wed, 11 Jun 2025 14:08:40 +1000 Message-ID: <20250611040842.2667262-3-aik@amd.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250611040842.2667262-1-aik@amd.com> References: <20250611040842.2667262-1-aik@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000011:EE_|DS4PR12MB9610:EE_ X-MS-Office365-Filtering-Correlation-Id: 7cb38ba1-2f81-49d5-d836-08dda89dc5e1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|36860700013|1800799024|82310400026|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?UbJ9MM+uug7rcDpM9ZDF7A6xXa7QzKBKSKI2DwBqndwwqMIbMusQ/OCfGJfm?= =?us-ascii?Q?3GYmtEkXN9M3A/VvESgtUwRB5+VPylNnWsqk0MbvQm7vkZyImTFL9O1ckfyz?= =?us-ascii?Q?x8Si7JIjwhJWEpSawIUo5S6KPQ5TRiKAz99alcwFTxsvAb1L2nleoaNhrhbR?= =?us-ascii?Q?e5IhkRJhen7Je8W8NnlhN3iizn16R3QCYWX310JHDIV2Gtogrw4RYwzVvBMD?= =?us-ascii?Q?k+vuNP4YfJ30ak2K7byeLcc+tLnc3tuZ6ayZf+jXNaiZeDhwlU8pc5h1nqZm?= =?us-ascii?Q?kyszhkU0ihdO6Gk1k8I9ynBgYKWGNkIXgJuEAv6+6OlhK+YP9mtmIvwkdejq?= =?us-ascii?Q?kUky5rq3y/L03WCUbwI8/SyaZtZ2mX82S6b9hVAa7Yl9TCK9JHVwVKETDHGk?= =?us-ascii?Q?FMNfUKOPCwwJ3S3kbjnnbPnu8VbwzDtzEJx+egN076LrgLcN8m5ZJJuSEzAP?= =?us-ascii?Q?YngihdNq2UUnbkhkzjjvhacQgJvdTHT6h1bYeZhJnpnsav5aQyWHtOb9/DSL?= =?us-ascii?Q?472iD9LENjTSTPoBO12c5c5qPDAoNFQeoWHSsfiq0Q8EnnN2fY23ZxExS6iY?= =?us-ascii?Q?1Ks7q32KfFCGRauD4+bTWoXKyYaA+R0PH92SVPcasKjafVYRhivpFdbYq05K?= =?us-ascii?Q?fQbWRdk0DeQQ+zfnqcfAL4dmsydmOGIMgrY1A6TqeH+TT84TqtDUNXfILzDl?= =?us-ascii?Q?kSO1Ves4A/9ytF4GWzJm3wS+7Yv+3zIbM7S0WLZFSXK5NuMw3fxlgnsOIRDd?= =?us-ascii?Q?IRUH3RQdnNGq3Ld2KggXViBWkBSTTrm+U7D4UENNAhkZWbGxtqOwEufkBxcV?= =?us-ascii?Q?OqvjgbYHcUNiqr4fG7ZsfZGNOhoWzgYJRo4X2KzSYQ6WhyAIL1EF2+fSbOPP?= =?us-ascii?Q?nZFtBgBHtOW8y6vu3Gl2t9n0lgGLQfPBIjYWVWf9VSOnyd3xWNr354WQ9W5w?= =?us-ascii?Q?dSXPwk2tU/xAQeBln7b/5PX5rQciH1Xlm9OROWh7c2J/eOuaEjjLTveR5S48?= =?us-ascii?Q?i90hbSIqrPQsiUlJVxGUId/fO7aw+EGj1/xJx4ybKJE8b/HgczcLV9nEdyCU?= =?us-ascii?Q?8JMvi+U7QzyFeUS3gj4nsOaXA/UstwKCyNSMyVmvXK3dg17D7Xip9ac2VJs7?= =?us-ascii?Q?ou9gQKJhordvqWby2S6tvI6sEDpQIq5e8rT50145QZkjPuw/1bqS8/WubljN?= =?us-ascii?Q?20luYOUgyF0OHGqZHDQNX9vp1BOoJLH6PpIxusF/uYj4HvOJY4uXkuVHE5Kp?= =?us-ascii?Q?Qbz9uTV4WUXekcT1GkWDTp1pCsF5bOKXQqdrjUzvOlSYSOapCvgcDxfS/kcH?= =?us-ascii?Q?75n1Q4KaHNMKKKLLjkZ/p44s/Ks52EVDEH/4GPNOQB37VwbJgasiTDXBDnHL?= =?us-ascii?Q?A3+qxKbt70NUAlHJHu3sR9TT+glJACE/wwbXeKWx4kc9MYHIzfRa3Menp3g8?= =?us-ascii?Q?Y63TSRijLLjSjuXQybpPFBxPBpI+JTIHaka0gM6LH5sqbs+DKH0trAeEK/nf?= =?us-ascii?Q?nHCTgkxttSW9XedzYUMMrG1atg5CGZSlevrv?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(7416014)(36860700013)(1800799024)(82310400026)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2025 04:09:33.9183 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7cb38ba1-2f81-49d5-d836-08dda89dc5e1 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000011.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS4PR12MB9610 Content-Type: text/plain; charset="utf-8" Allocate a 88 byte request structure on stack and skip needless kzalloc/kfree. While at this, correct indent. No functional change intended. Reviewed-by: Tom Lendacky Reviewed-by: Dionna Glaze Signed-off-by: Alexey Kardashevskiy --- arch/x86/coco/sev/core.c | 30 ++++++++------------ 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c index cf91cb4e2c47..068653865bfb 100644 --- a/arch/x86/coco/sev/core.c +++ b/arch/x86/coco/sev/core.c @@ -2069,7 +2069,7 @@ static int __init snp_get_tsc_info(void) struct snp_tsc_info_resp *tsc_resp; struct snp_tsc_info_req *tsc_req; struct snp_msg_desc *mdesc; - struct snp_guest_req *req; + struct snp_guest_req req =3D {}; int rc =3D -ENOMEM; =20 tsc_req =3D kzalloc(sizeof(*tsc_req), GFP_KERNEL); @@ -2085,28 +2085,24 @@ static int __init snp_get_tsc_info(void) if (!tsc_resp) goto e_free_tsc_req; =20 - req =3D kzalloc(sizeof(*req), GFP_KERNEL); - if (!req) - goto e_free_tsc_resp; - mdesc =3D snp_msg_alloc(); if (IS_ERR_OR_NULL(mdesc)) - goto e_free_req; + goto e_free_tsc_resp; =20 rc =3D snp_msg_init(mdesc, snp_vmpl); if (rc) goto e_free_mdesc; =20 - req->msg_version =3D MSG_HDR_VER; - req->msg_type =3D SNP_MSG_TSC_INFO_REQ; - req->vmpck_id =3D snp_vmpl; - req->req_buf =3D tsc_req; - req->req_sz =3D sizeof(*tsc_req); - req->resp_buf =3D (void *)tsc_resp; - req->resp_sz =3D sizeof(*tsc_resp) + AUTHTAG_LEN; - req->exit_code =3D SVM_VMGEXIT_GUEST_REQUEST; + req.msg_version =3D MSG_HDR_VER; + req.msg_type =3D SNP_MSG_TSC_INFO_REQ; + req.vmpck_id =3D snp_vmpl; + req.req_buf =3D tsc_req; + req.req_sz =3D sizeof(*tsc_req); + req.resp_buf =3D (void *)tsc_resp; + req.resp_sz =3D sizeof(*tsc_resp) + AUTHTAG_LEN; + req.exit_code =3D SVM_VMGEXIT_GUEST_REQUEST; =20 - rc =3D snp_send_guest_request(mdesc, req); + rc =3D snp_send_guest_request(mdesc, &req); if (rc) goto e_request; =20 @@ -2127,9 +2123,7 @@ static int __init snp_get_tsc_info(void) memzero_explicit(tsc_resp, sizeof(*tsc_resp) + AUTHTAG_LEN); e_free_mdesc: snp_msg_free(mdesc); -e_free_req: - kfree(req); - e_free_tsc_resp: +e_free_tsc_resp: kfree(tsc_resp); e_free_tsc_req: kfree(tsc_req); --=20 2.49.0 From nobody Sat Oct 11 08:04:33 2025 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2083.outbound.protection.outlook.com [40.107.237.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F50D1FDA8B for ; Wed, 11 Jun 2025 04:09:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.237.83 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749614998; cv=fail; b=bvL8Toc3Ut3AF4zKUgmsTbqP5Z2RI5IlPWjjbc8RpK5Ge71mxKwAc/Ugq2nZW+VWgmYmhFFI9gW2t3Y/b+oRlPOi37cpXlWMPhSXaRqIdH36OAuDFqTX7TYRDCdVm5ssvzA5TJ6zPxGwF6IjQ3hruo6OPwRI/SAvGOJfDsuS9kI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749614998; c=relaxed/simple; bh=H5CJrdAw+L+QZpvZ+MjAct3ErnBHfJvinagOgEJTJec=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=f1r3r4psHT3p/E7njk205+2WD++TZVFAuxxEFitc1002ijpnnwepmc8ysIX4WyepzRkwI4jj1kjKGbWfC0F/3q3del4rvi3jORnn1cRhMqQ7iDhdiUC0m8eO5kydQDbwWp8rhSNxleEJ9+AyfwICW+0qPW9tnzD8oYlxtdauLE0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=KGbtI9Hd; arc=fail smtp.client-ip=40.107.237.83 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="KGbtI9Hd" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hCosaB28GOZDQ8SWbR0j1plxE9miJOoGSGegCK5Pls9KTYGHdtvRTnwXv4OWD9reMTNVFk6F0aBjjYGd/mOGpmdQauE2Fxt47vSspKLzoZu3aMmMDSxJgNGBCBVHMem12e0k8yfizRW61GITwjxVGWAvfgbJUq1u0bQqhyaSr2EMVGsfb4bX6k2sxsUftzBU+seY/5pZdvg1dFWtSBTKMy91lBg+0pjVgNBQEvGBT6x8kR6fMmbxBTO+2ShQyPCYqzgw66Yxe312ymzsqzx0vthFZ+LP93pFMTn+mz6nabfvp+xhLYfow5RmtHoCzPr5+EONXpM93/d6A3KF3S++fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F8iXk+rqud4sAdaUa7E3FPzeEEijeMYbyJbMSj3FIno=; b=GmQ4/fqzdNuanooQ/zBLqqjmnGmShniI+tthjbS/7NwfS6Z5B5j44FVCvQ0x6KIeJo3YfJBrJ5vf8BV6+flnZk59HGuNrQPSwtjwpvesQTJatKuwYH7bWmBanxYXeBzrQwdfKHdL4OCVN+fT8V2X+E1L54GDaAnIMN4BcaaTZ1sd3aIO5kUeXhObvnqY78yaRexb1xA7/OA3lggHXKrgHvNlQ771fPcHB/uBoV4PZ4ux8p16b2vSt3ZtyaXvXHMCBTXYHyXM1VN7UvMz9IlGQ8E0lat20C6o1hPZmOlaUSWGFOHt0+8Qgu2TcYbuc3yvEvYudKL/h11hLhtB9rGVbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F8iXk+rqud4sAdaUa7E3FPzeEEijeMYbyJbMSj3FIno=; b=KGbtI9HdRJVp446iv4QUkuQjDfjOPUQuzm27v6NV5J6qutzbzNwdux7Ie7wZnOLzi594usRlfBGE7Czbb5/X5iPI1IgElZd0WWkRaUOCMueDB/dLEYDeq5nE1iiNwCgHJZE0/UOkvW6SFBNCJGMRDlR2+GgJlpzpKcxYkwuVxAc= Received: from DM6PR14CA0052.namprd14.prod.outlook.com (2603:10b6:5:18f::29) by SA0PR12MB4381.namprd12.prod.outlook.com (2603:10b6:806:70::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8792.38; Wed, 11 Jun 2025 04:09:51 +0000 Received: from CH3PEPF00000013.namprd21.prod.outlook.com (2603:10b6:5:18f:cafe::eb) by DM6PR14CA0052.outlook.office365.com (2603:10b6:5:18f::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8792.24 via Frontend Transport; Wed, 11 Jun 2025 04:09:50 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH3PEPF00000013.mail.protection.outlook.com (10.167.244.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8835.2 via Frontend Transport; Wed, 11 Jun 2025 04:09:50 +0000 Received: from aiemdee.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 10 Jun 2025 23:09:46 -0500 From: Alexey Kardashevskiy To: CC: , Thomas Gleixner , "Ingo Molnar" , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Tom Lendacky , Nikunj A Dadhania , Ard Biesheuvel , Ashish Kalra , Dionna Glaze , Michael Roth , "Kuppuswamy Sathyanarayanan" , "Alexey Kardashevskiy" Subject: [PATCH v2 3/4] x86/sev: Document requirement for linear mapping of Guest Request buffers Date: Wed, 11 Jun 2025 14:08:41 +1000 Message-ID: <20250611040842.2667262-4-aik@amd.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250611040842.2667262-1-aik@amd.com> References: <20250611040842.2667262-1-aik@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000013:EE_|SA0PR12MB4381:EE_ X-MS-Office365-Filtering-Correlation-Id: 194cdd54-d0c7-4841-b921-08dda89dcfdc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?xRetMoBJ1aqOqwRDEh0z7+hQY9bAlWbNa4pxwBEFNKsOlyefB86SzD/fntWt?= =?us-ascii?Q?ww/kPETJ8zOA45NmMP96d3winkXCiDipPb4Q9G8Z/CC6cIPLZA/SeebpYKCH?= =?us-ascii?Q?2Ps6CEJ3cnnbUOIAodpy2lAlJdCMIOmfowZKA3MYpi2u4iIxVx2pw/CC+yLz?= =?us-ascii?Q?lmdc/Q0qn3LgGz41pDnr5khzkL1tY4cIXIH849TTM5G+mPh5PmI9R+pZoqZo?= =?us-ascii?Q?AlbXa+R5Ha9WnjaNxIvkV2Cgsxmc6WToHr04WLLuA4T9+c66s45bCKt2RfAL?= =?us-ascii?Q?TfSkJgTwnNY79NZ29CrHe9z2/ZkXm+nIHbd08pP0cxrYGsRVelYlt6PkdPq9?= =?us-ascii?Q?jW5OPWsG/yUqelPxrsAMieryohgBU3YqNDozxYT4iz+1C/5Vn4CV+0zYcfEQ?= =?us-ascii?Q?7k6MgsLxf5lRVVSePdCWFO+gAyVGVDQhIYqxRMbKN6i9/OFuweRCGSUczjjA?= =?us-ascii?Q?HBfOaELb34YNhGyZK0ujyIcmNHMQ1p/Ydu1ZptF/eT3/8RUnJa/NtUFn+WYW?= =?us-ascii?Q?3cy0JdaKDCw0VA3+yUEODzX06VLvE0/PbAuyZmguHx8+4OcwK+rKWmK6Um4f?= =?us-ascii?Q?i152KdNRRdahZUR46k5xfBVbq62sV6hGvncTj9r2pp+fR68DDJgb9HikShzL?= =?us-ascii?Q?3uXa89dCkO/Ti5hQ4PmokGNU4d1F5ef1WMKdjdmwhCR9+kDW15dVnqpSw4ze?= =?us-ascii?Q?vaYox5/xUnY/Bic7kvwNAvMtGbFFS6E1PrzqFY1JW88dMWtrunL529ZjANL/?= =?us-ascii?Q?+42Ew4YxD2dZZ2IGELPLE2L2afbqvhZomINzW3hsDLqPoIzF+7sIXJxVmHNR?= =?us-ascii?Q?8e1Hn2qZxf9PHTO7KMOkV1FXAzTw99zn4FZVDb44QyjG1KQg9N9XIJETtXzD?= =?us-ascii?Q?JMi/MS6mVefztg2S+R2f8td8AIBS0cPkMPz70L+eWHpkcSUZvjtkB/cIh972?= =?us-ascii?Q?/urHqnKK4hgrkiu5gk9l4XkG2MC8SocJJoVg9c5pYc6pvwamX0EnKq3LVBlG?= =?us-ascii?Q?buF0cGCGYH0O8IJPQ6YsijtoSddDPVCqxGotFiEcVhRMhxUWd5tDFo76roTC?= =?us-ascii?Q?XEosSLxGS7hMyKWjshxItKIuTp584eatqJ/y85OcM0OuZvMzNezwvBTof34r?= =?us-ascii?Q?WKkhbg3L5TDQzH+rLb0cUAKDAwydh/OE6ltu1u62wf302wBGng+ywno/PYPa?= =?us-ascii?Q?FIFEe/D+zKYtkQERhN873R63XMzWBED/RtKtFfy9IvfjlL6H6XzRccs4XO2h?= =?us-ascii?Q?bkZE/d9IdJ5xU/RQ4mMzQD6LVmnc1diAj374emsBAC2zjxCw1ayjRDLvkIK/?= =?us-ascii?Q?PmtmUm1oPezD8RbcxTFaqACh8BkrgApGK+YDbx0W020JpkLl0cgjS6vTmSBE?= =?us-ascii?Q?NYwqnWFRoegPsznuuQoNnbZiDyU33k4I5U++0Ej3N8NS/4AnMoTNJW8k1VOw?= =?us-ascii?Q?pYwnK4zB6cWxYFf2QjqmG9qdaRpHubSWTIRuBAcGRM72SIB9T4lW1sgoNkoq?= =?us-ascii?Q?he8icTQ9LWiF1hte2wTzLMTPrcjKS/62oZ5S?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(36860700013)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2025 04:09:50.6576 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 194cdd54-d0c7-4841-b921-08dda89dcfdc X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000013.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4381 Content-Type: text/plain; charset="utf-8" The Guest Request supports 3 types of messages now, the largest is the extended variant of MSG_REPORT_REQ: sizeof(snp_ext_report_req)=3D=3D112. These used to be allocated on stack and then moved to the SNP guest platform device (snp_guest_dev) for the reason explained in commit db10cb9b5746 ("virt: sevguest: Fix passing a stack buffer as a scatterlist target"): aesgcm_encrypt() and aesgcm_decrypt() are used for guest messages and might potentially use a crypto accelerator which requires DMA buffers to be in the linear mapping. Add a comment, pr_warn() and return -EINVAL when the buffers are not in linear mapping. Reviewed-by: Tom Lendacky Reviewed-by: Dionna Glaze Signed-off-by: Alexey Kardashevskiy --- Changes: v2: * adjust grammar --- arch/x86/coco/sev/core.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c index 068653865bfb..b0d423a353ab 100644 --- a/arch/x86/coco/sev/core.c +++ b/arch/x86/coco/sev/core.c @@ -2008,6 +2008,15 @@ int snp_send_guest_request(struct snp_msg_desc *mdes= c, struct snp_guest_req *req u64 seqno; int rc; =20 + /* + * enc_payload() calls aesgcm_encrypt(), which can potentially offload to= HW. + * The offload's DMA SG list of data to encrypt has to be in linear mappi= ng. + */ + if (!virt_addr_valid(req->req_buf) || !virt_addr_valid(req->resp_buf)) { + pr_warn("AES-GSM buffers must be in linear mapping"); + return -EINVAL; + } + guard(mutex)(&snp_cmd_mutex); =20 /* Check if the VMPCK is not empty */ --=20 2.49.0 From nobody Sat Oct 11 08:04:33 2025 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2048.outbound.protection.outlook.com [40.107.220.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4C9C1D89FD for ; Wed, 11 Jun 2025 04:10:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.220.48 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749615021; cv=fail; b=IKSjj3m4u/JYNwpYl+AhMdtwQ/wXfbDRjGRsTdMFgl2HjKikNikLyfu0la3XcKIfQXbAWo9zOcxmPBaLt2jYcM9guVny+b/itJUkbad9VyZ7lDvBWc6jmoaiwoJ7FvVuqgYbqIjO524Eqy6f1jQNcBJ9kCX7fFDPydR3x9r56T0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749615021; c=relaxed/simple; bh=tclR56x6kY0b8PnnmNCmTH8gp19JU4k4mqJdI9LCjz0=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=OWISRA7KrUwIITnjLhZeruQwnafmipBZxlHn+/IVslWt5v4wDCnLfs2iY/VbUBG98wXs2Z4AaRgw1Ay5imN3MmSpHzoGeQGrLNxxfCgpop9IaapZ3VaKonXsn0thdaxihstjOngPVEzRankcPC/+ChhBm9ugnuCarCyEjD6jRe8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=aEeNY74c; arc=fail smtp.client-ip=40.107.220.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="aEeNY74c" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aBXU0wdqjXCs4LoK9VTE92EptuMNhEklActSzTLl4LsRnxOz6tBeHzyumB0pMl2M7OHuONnwy5D42BJazNFcGOxGyeJceisReMXNw+Qk8JrFqXK9X8mjB7JCJ630Hu87+dunMJGWZexhwVXq9mIN4JQku2R1piAIO4mFuveNH3VL+S78zPZF366ME2VGJUnAnpI7hOTCN8cI3vUT04J+bVwKAyyvkPc+FuBGVrIhqHA4twIJoBgIJ/iLj49nI6RfDDDCNWqDvrO1KnWCCVSfMIqZs36sRTJQ2az0j+uGxNytWrJcMxgrUNyPvZqRrmdk38E23N8LTQaUOCGCBo/InA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lvyl5VAHi3Jcqt0QxwvetKOI+F3mHG/1LUEoXtAS2aw=; b=JRT0x8pMtYrLuuGfY4g+MP0t6j7En43HxgUDvQuAxPPqo4LOaTNyEl3k7iqJyATHwXVvDIAhmZev8tYoFD6l6b0sEShiNvebMEGnAa4cGpnF8cuCGlfKlEvd2ZSTMZ8Sy6KwWNaJ4Kng7aIegXgfC0Q8jFt1nMicdhFvc6dNHaM4ODqi+8xV5R0cf+etnxUerJPttKCbW2SMeQS8l1M+FYa50RVrS0Ygwto40ofxZamXMVmToa05b+A5VpKOwmmv+0lm6oJij9P1NiCcnJgZNx6OI5+kUKJkaNAcOnPdl8TTZG1KpZTl6SosIvK9P0vDDfKGRWhdNnAz2W8ZAtidVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lvyl5VAHi3Jcqt0QxwvetKOI+F3mHG/1LUEoXtAS2aw=; b=aEeNY74c30Qcen+jlHVrw+UWPnZ/OcCwSYvohsB0XYOdOwJN0fU6TV/hhk5R+8794QD5Pgnomy5wx0xOkwLBIQaaWorW/2nDcGX8qwSYbay43aHon+BwrufkTgvulXm1dFPGtdJAFhNr2M4h4XEAT+ZXdIeyLJjaCDcMPtNmto8= Received: from DM6PR14CA0061.namprd14.prod.outlook.com (2603:10b6:5:18f::38) by CH3PR12MB9217.namprd12.prod.outlook.com (2603:10b6:610:195::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.24; Wed, 11 Jun 2025 04:10:11 +0000 Received: from CH3PEPF00000013.namprd21.prod.outlook.com (2603:10b6:5:18f:cafe::65) by DM6PR14CA0061.outlook.office365.com (2603:10b6:5:18f::38) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8792.35 via Frontend Transport; Wed, 11 Jun 2025 04:10:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH3PEPF00000013.mail.protection.outlook.com (10.167.244.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8835.2 via Frontend Transport; Wed, 11 Jun 2025 04:10:10 +0000 Received: from aiemdee.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 10 Jun 2025 23:10:02 -0500 From: Alexey Kardashevskiy To: CC: , Thomas Gleixner , "Ingo Molnar" , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Tom Lendacky , Nikunj A Dadhania , Ard Biesheuvel , Ashish Kalra , Dionna Glaze , Michael Roth , "Kuppuswamy Sathyanarayanan" , "Alexey Kardashevskiy" Subject: [PATCH v2 4/4] x86/sev: Drop unnecessary parameter in snp_issue_guest_request Date: Wed, 11 Jun 2025 14:08:42 +1000 Message-ID: <20250611040842.2667262-5-aik@amd.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250611040842.2667262-1-aik@amd.com> References: <20250611040842.2667262-1-aik@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000013:EE_|CH3PR12MB9217:EE_ X-MS-Office365-Filtering-Correlation-Id: 189e41c1-6071-43d6-1aeb-08dda89ddbe5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|1800799024|7416014|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?VESDv62WfnGvR5wmPzL8Au8IwknvbrFAuhIc2+3IpB5nGmrR51GxkOAGcEb4?= =?us-ascii?Q?FDOjrAnkiSumH2IOgI1Ub/L7OijeBScPyWJgUYT3OpePO9HvRvwzT3GQFVR8?= =?us-ascii?Q?ERLlyB6I69ybIBJJYLHYbdVSlaa3t1gaBnnYDMqd/mpYc2JHM5or7JBEa9S8?= =?us-ascii?Q?uqiswKMhLvXkZH4oe+Nef2pWF+x9JVZZvBGxovCjnCxng5E/D6KZzwlEdFYI?= =?us-ascii?Q?+TnyH8iGI1cgIK6k151uVOA5wRp81jAfaYkSCWmOnLzBHjlewpgdxWk54jN2?= =?us-ascii?Q?TQyZa+rD6ZLUrj1aY2AYn8wSd6zWAvti0GPc/Hop1y8rLapLlkz+kxPccktr?= =?us-ascii?Q?KhwTNUncvNzFdNDtoGqQN68SsQWeZtU2jRBjRvnmYwdvAiLjV+qAPxkxjD3L?= =?us-ascii?Q?JwwNTb/HZI+IzljgOAlaaTl6UmurfckjXRPhWmgagZ9u5t1XbW3KPeuMukoG?= =?us-ascii?Q?Mq9Rbn3R/3AaeFpacSmpl9BxSmVIua1TmtrEzYOMZ/TFPPrVNlrWVMYVkRzw?= =?us-ascii?Q?AtUi2qS6fx6KrZEghZadZ8kaZPrX2wU7/ldHXc342bdEbWu+xMxBDJTijjom?= =?us-ascii?Q?q6WPqRH1UXz3zbqnEpoOCami6AnwCDtjqLQ4f4pYRrOcxWMEQ5NQPb+gu5IQ?= =?us-ascii?Q?YvSz9wQvH+LfbBkRk7XrluzOcn/6hK8tRb8Zg/UTVMwTU8VvZ4m3wbnT7pEU?= =?us-ascii?Q?8fOP80I4p1E7vc3jRfxSw5TC/NtqK3XtSnlTsYxauNacZUW8pYAKfcPuVt9/?= =?us-ascii?Q?FtE06n1N7p4r3Qu2URFin3I2zNuSWQuRWI4IPE/TlgKv8XKoYUpHdSohq7d6?= =?us-ascii?Q?+ylGiKCozbGFdd9NQsRh8Y/k/cZ2Tgex/r0DCMeiWO2IcA1jynQXzwwvvpeH?= =?us-ascii?Q?mJFtH44KQaXaL4C1yHeLNcoDEPZNJwqA4X21/G4LS0S5DfLsnKE4a8OMh7gF?= =?us-ascii?Q?2YKgMG/uXQOc+zP/m5TRUp9uUsS26AtKU6v22l9zlCK1jgot/50G4v+y25Rh?= =?us-ascii?Q?dnIxQylgtLEXR4W0Bbe07U4YSHrwqy385uWuzEUqiGq+6lhtYuXvq51EfiqT?= =?us-ascii?Q?i1b26YaW7l+yUW/J4tFyqi0KoNw+tvNEOoiAzCAflqoyHJnFXj1ixEqyCzcD?= =?us-ascii?Q?Qdp+PIqY7xuWuEn1ZsBugooBEReTbUWRfQYL+0TbE49I294AqvJii77Pwv/P?= =?us-ascii?Q?sTS3fmvWjOfoVezZswaKcwSjwGraESFLtz236I9jFvWu+RDduA55sEvF5qE3?= =?us-ascii?Q?/yq4EARg+LkBUufALLaqF49RmztXn2PwHqM1ZraBpDxixeBNRdhim43nj1HB?= =?us-ascii?Q?I1U9Is6kbm3tpe3FS54TEyxhZiuPUcfC2wBVsj+zKglEarjC2GiQVjP248Eo?= =?us-ascii?Q?RUNzvCLec57JIOYVRzZM9ISCCkJA+LVYdzi1zLB8P92v7D7VZ8NSwqJofbOg?= =?us-ascii?Q?onXolSMw0thot7DfEEjubYG7R3ea1QG2LagE3ksCJmw24gOk5a5bOnwCAmEl?= =?us-ascii?Q?SiPFyuU/1DXx/WYUQmDqvNdQZk0MgMHf+AD7?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(1800799024)(7416014)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2025 04:10:10.8496 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 189e41c1-6071-43d6-1aeb-08dda89ddbe5 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000013.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9217 Content-Type: text/plain; charset="utf-8" Commit 3e385c0d6ce8 ("virt: sev-guest: Move SNP Guest Request data pages handling under snp_cmd_mutex") moved @input from snp_msg_desc to snp_guest_req which is passed to snp_issue_guest_request(). Drop the extra parameter. No functional change intended. Reviewed-by: Tom Lendacky Reviewed-by: Dionna Glaze Signed-off-by: Alexey Kardashevskiy --- arch/x86/coco/sev/core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c index b0d423a353ab..8375ca7fbd8a 100644 --- a/arch/x86/coco/sev/core.c +++ b/arch/x86/coco/sev/core.c @@ -1389,8 +1389,9 @@ int snp_issue_svsm_attest_req(u64 call_id, struct svs= m_call *call, } EXPORT_SYMBOL_GPL(snp_issue_svsm_attest_req); =20 -static int snp_issue_guest_request(struct snp_guest_req *req, struct snp_r= eq_data *input) +static int snp_issue_guest_request(struct snp_guest_req *req) { + struct snp_req_data *input =3D &req->input; struct ghcb_state state; struct es_em_ctxt ctxt; unsigned long flags; @@ -1932,7 +1933,7 @@ static int __handle_guest_request(struct snp_msg_desc= *mdesc, struct snp_guest_r * sequence number must be incremented or the VMPCK must be deleted to * prevent reuse of the IV. */ - rc =3D snp_issue_guest_request(req, &req->input); + rc =3D snp_issue_guest_request(req); switch (rc) { case -ENOSPC: /* --=20 2.49.0