From nobody Sat Oct 11 04:18:15 2025 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 852891865FA; Wed, 11 Jun 2025 14:37:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749652660; cv=none; b=KA6n0RB+jb5icUvjT1ff4PnePlgxCi6F13Z6KJnlxS4S02ZD5nvmog0G4ZMLxgJ4Bq2PnxSzcleSJ9iUl6oMNVW6H3fW3z1cuLzWXy0CF20I2KPbp2/FP1lHvP4ndU05BaqtWLOgpYfP8IpHFwBzN6Qatysgd1Bh/nuBxvgsf28= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749652660; c=relaxed/simple; bh=l+T5ZhzNUucEtcBwYebsvbIy6IaT4jf/3TtvPE2rO/4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hLvE0Bc2MhkWufTjT8lFvdn6kFOl2ULof796TZgiRh0MKz1fXducgorBYW9DEBllX6wdeKEaO96HTT9BS9kDWNetIH1vMeuhVeRClfbnRlovuuX7umlvWdmaoSOx6oIYsS8ESS6MxASPQnxys62XBVkklIl68iEN7QTD1ETax1U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QjXd2Ngk; arc=none smtp.client-ip=209.85.222.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QjXd2Ngk" Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-7d0a5ac00aaso12959585a.3; Wed, 11 Jun 2025 07:37:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749652657; x=1750257457; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XYnwybKCqEHQVsPm8x/SvQihwGROCOX4dUeuWu4RKaU=; b=QjXd2Ngk0G2i2DL7psCcC6b6nvT2LFIC72Ix+0wZp7UOGIysB09BF5q7gE3TIKY6q/ P7qIxPhIkxzlCp3gOZNPC8KQp9UWDh463oEzcGjze4/G13Zp0NJpvTw3iOQOWC+gXrVq f/M7TQ9UoABCSTCda5TNcp+NG4vL1b+nbYkRNA8wti9EAXAMQ4wihcwd8nz56p+WyYoi j7i6UQAuIaLQ8uWK8wINq3WU3yvVQ/X0HU8NXNwUsQ4jxk/C7GIOSug6UTmT1ULknbi4 WG9KyYFM2tdc7E52ZRMz+P7vf0j+ojB9yvzTmz9+MONgkyMFjYH8FuSEarkzW+ZfO6cc SFaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749652657; x=1750257457; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XYnwybKCqEHQVsPm8x/SvQihwGROCOX4dUeuWu4RKaU=; b=I6Y2EjNBNFvwcm7wOv/cdSQhA9x0hxxh1NmxNLDc01a/1JgpG6v7M4maVy9VPJckAi 6/JQ1HQArYkajpaoGXdi+/991U+l5SnJKoYKr7COpxCePOaS1yoE9BQWkwzypa3EhIFR /nK3AgTQCwfqrrd634CIwYOLfziDpFAOJLa+NNuzqKZMsXrYZQlF39nNu8cxRY/ezyr/ H3fnkRxEgNVMzasrkfAKKso0OnRu5yQDGSxMdUyahEbLJ/c0iCXuQoWrwlPAORc1WpjH cwS6wSekvGJ8oNbZbSc3JgOgKXDx8zb4f/uBq8oIUiw9PMEW6KY50gr1Yc8qmzOVPZHj k5nw== X-Forwarded-Encrypted: i=1; AJvYcCVzeRnmX/F2ssEurEwIw+S4Z2XpLP7p9WmOwatGe3kqnOOgA1AN6BSvWTsYMx255E0hi+Haz4UsKUHz17vW@vger.kernel.org, AJvYcCW3fWL8clZtJGRAIfQ9jxorwfAsnoL5CMD1mLTJnwqAfwBZXr0K/+y24wuOPqPwcl/9yplfxhBhr+s=@vger.kernel.org, AJvYcCXjF8jIRYbCWESXoROFG8fE1MyiCSTGV1ToWxIVRdKw9X+ZtiJ0NWy0i9gjlaG7frZIHed9gwavNkX2odYMmBvP@vger.kernel.org X-Gm-Message-State: AOJu0YzTRT12A+UdzYz91aupvrdDIhD9KtUrxDJ3UWaG/B7UMCSN1fho y6kHe0dFiVuc7ja/V4RhYSd+8xBH2/a32Pz6as+geF0JsPVwolPr2JIuXUU4m3QNhYc= X-Gm-Gg: ASbGncvpXNXylCk+GkQ2L0YrZgDjgA6P3hoWhu4s8NWNaIG+r+kbKn1BvKuFO3/GfXu 8XyGagHwe5Y08MN4/sqLx6MY8E5siNKQrKcSAgSK2oeJJh5WypvwpKjV1I1qYeZ4gIsbEfIpOYc fGLlzSkhvGbZLENHWhcB3qzKgx50D9tKpAk22kNKrmEh0zFD+K33yKyPTQfY9u6yNOxltasu4in ASNtpid3RGGJCqLD2DNQf7jqG15xthSGcGGUiYbTcWNd94GkXIAzsA5HLObU6OHpj+zi2r/adOA EaL5vXVqfe4VWAPHY9BeP0Ni9vyDOdQlYtr2pFv40ne5EKy22ncvitdP X-Google-Smtp-Source: AGHT+IGmxDOEBxXiNTnrWWFc27mEmo6BZIx4ubp2n281p1VAtAi7M13sbshETP3POiK4gC7uA3x/8Q== X-Received: by 2002:a05:620a:4514:b0:7c5:8f36:fbeb with SMTP id af79cd13be357-7d3a884260amr183598685a.12.1749652656727; Wed, 11 Jun 2025 07:37:36 -0700 (PDT) Received: from localhost ([2a03:2880:20ff:71::]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7d250e70898sm861571885a.20.2025.06.11.07.37.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jun 2025 07:37:36 -0700 (PDT) From: Gustavo Luiz Duarte Date: Wed, 11 Jun 2025 07:36:03 -0700 Subject: [PATCH net-next 1/5] netconsole: introduce 'msgid' as a new sysdata field Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250611-netconsole-msgid-v1-1-1784a51feb1e@gmail.com> References: <20250611-netconsole-msgid-v1-0-1784a51feb1e@gmail.com> In-Reply-To: <20250611-netconsole-msgid-v1-0-1784a51feb1e@gmail.com> To: Breno Leitao , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan , Simon Horman , Jonathan Corbet Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, Gustavo Luiz Duarte X-Mailer: b4 0.13.0 This adds a new sysdata field to enable assigning a per-target unique id to each message sent to that target. This id can later be appended as part of sysdata, allowing targets to detect dropped netconsole messages. Update count_extradata_entries() to take the new field into account. Signed-off-by: Gustavo Luiz Duarte Reviewed-by: Breno Leitao Suggested-by: Breno Leitao --- drivers/net/netconsole.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index 21077aff061c..787d170c3a0b 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -113,6 +113,8 @@ enum sysdata_feature { SYSDATA_TASKNAME =3D BIT(1), /* Kernel release/version as part of sysdata */ SYSDATA_RELEASE =3D BIT(2), + /* Include a per-target message ID as part of sysdata */ + SYSDATA_MSGID =3D BIT(3), }; =20 /** @@ -782,6 +784,8 @@ static size_t count_extradata_entries(struct netconsole= _target *nt) entries +=3D 1; if (nt->sysdata_fields & SYSDATA_RELEASE) entries +=3D 1; + if (nt->sysdata_fields & SYSDATA_MSGID) + entries +=3D 1; =20 return entries; } --=20 2.47.1 From nobody Sat Oct 11 04:18:15 2025 Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D61051865FA; Wed, 11 Jun 2025 14:37:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749652665; cv=none; b=tRXu/wvdgglUu+Rl43okFjMlTWLVyz0rFCsxPm4FGiiFErZFmT5S6/TkbwPiQkNUSeLBf9h8upuUXEx9HJ66bnRKN+OpAXm4PeEnC2u8YAfqqMeMEGbGeQcDZ1vHmTrnE7hOY6eZetyMHA9fnx4AZJyzbVMRg6TXPRp1zAFbdjw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749652665; c=relaxed/simple; bh=OiPRRK5piH3idkJPfTLqCzMAg5A0Ic9Hcu38DBnvdQg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tZrgms+IqArznqYlLO0fJ/wRg+cX0krU7Y8l4hJcDLH4HEdj7rgK+aPN20cFfYVsaW9yUsHj01sZtzFXhLgByFYIdZ6pfWSFeczCgPp0dWk0Idlb9fgKuOeUVn9beTQAfwoT94B4kQEAgpOrmHOrykl8A1Fx5JDZlGe6cJ8au+o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EFzL1/y7; arc=none smtp.client-ip=209.85.219.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EFzL1/y7" Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-6fae8838c1aso308276d6.2; Wed, 11 Jun 2025 07:37:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749652662; x=1750257462; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=jFZtFnNSCd6XICWhSL9CTpUln5QBYBY/QPDvCN5iXGw=; b=EFzL1/y71r07ZXN7zSXUx4Va/T8iBGZbCs8ReeNcUI/wYMBlCg009dhha50IwfLMQ/ firBRxjKKcDNsiOKQz8R9M4Si/cnqeG3yQ/nj9Nz9HXJUJ9W7YSZhsgnCTE9CD3smUj5 srIHkelf2FlVdcixfPNTIIVKsWy9EBqkRpRw/VeeFcy9vco17RJMyVH97uNBDns02fs0 qZnT1T1OAKuSccFzIvkhWn7HmKo6xdajVl09IViKO6wHrkERcKC7xLF+FbbhL4eOWBm3 Bir/w4OompcHSp4hJCFc0TAhAHG2h26fbz7ybDbl+xjwPH5guhRncv3EUJktVwJqobSw 0SVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749652662; x=1750257462; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jFZtFnNSCd6XICWhSL9CTpUln5QBYBY/QPDvCN5iXGw=; b=IdOXqP6p/DQbzs3qbYnYuLtxswLKTHSEM/UdNvXrHp9k1yY2Y2Wc2DryIlaEuxYYIA BV+j5v4Vsn5OVQVcRNV8Mc9OXfllDCP0q/3oaeYTkJZVsQ3QUB3bf66hZaTLMTZP509s APtfxe87TmWfwAZRfzvYyIKPSVW0Od9nbsSbCnzOrDajC/XUxgJxE4dDS8YrJNeZ8QrL cP4H61B/yuRbtfrAYRijm7Ekrbq4tyro3UO27zUbq7TZIdHfVx3gvSxge7nH6K3JTdo/ Tw4ntt5vDzxviaDplLxl7MEMd9yECfi5osqPvDgIJ7rR3A0ozt0cVnnJC9aI8KhCbtis xtXw== X-Forwarded-Encrypted: i=1; AJvYcCUD7GYrIZOhEtt1crsrN+6gewSn8zelOTJLSpa1tMHnRBjbMbtdgIHNXsQwXuvva3lZp+fdfA6k718=@vger.kernel.org, AJvYcCWeCn+phG/1ATNLrCkr77zu3txALLObnhQ1D3qT/EqYxyNKWGcHH42e9NFIL4zL18RD6izgtZAeX+5OnIRF@vger.kernel.org, AJvYcCWlCCFJfocNq38miJeOxLMWNRiooEFUyA5/HsHi9/nsxgSlOjmsoW/9QXzUS3KSYTwkvzszmBMMDKCrG4fYhG5a@vger.kernel.org X-Gm-Message-State: AOJu0YxG0CylGRwoRtuHmhy/Uxuunva8yrvldaJ1alwAE8WorNLyYsxw j6bJVlJBhrMrTNY30WpmaXOzJ403AwSPSzDltlKNa7oU8MUPwqZWdIZDiXmtbv0ZsNo= X-Gm-Gg: ASbGnctxkJMhjxOC/qKjpJkff2f+R5C5iZlR5+3KlMdJTOrkKLsRh55/9VTOgLX05WL x5EMcqTHRFd5noqUCX8981HiYltaUpB37eP/oLciRV5U62Qx4rUECj2j2YxIBlXKXhVIeUekfIb 0KgTU5z2U8OBamuoKfTZ7cWe6LH/c3BhxfG3jdQ8tyQF+45EURZdsHhPlVKCX1ITHRjBVc0uJIy B2uVSG3Fbwt1z2X1gvfiylnF/vq5rRIsu5GP9ZANyMHkyRB5knuBGX7RVRCg/NpgvCmdCLB3AZ8 k16FTo86+zg4jCg323uD3s0xHO7evdfo7ehe8nt4lRF9AMb17meu6Ks/ X-Google-Smtp-Source: AGHT+IFgJ1JvD9zobZmHURaq/FhcLmnzvPhcIvvLrVAE5C1rBTgIPotn5hK9gzflLmngjlfMTXjoHg== X-Received: by 2002:a05:6214:b6d:b0:6fa:ed19:2566 with SMTP id 6a1803df08f44-6fb2c31ea88mr22245346d6.2.1749652662005; Wed, 11 Jun 2025 07:37:42 -0700 (PDT) Received: from localhost ([2a03:2880:20ff:73::]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7d38c067179sm633968085a.73.2025.06.11.07.37.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jun 2025 07:37:41 -0700 (PDT) From: Gustavo Luiz Duarte Date: Wed, 11 Jun 2025 07:36:04 -0700 Subject: [PATCH net-next 2/5] netconsole: implement configfs for msgid_enabled Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250611-netconsole-msgid-v1-2-1784a51feb1e@gmail.com> References: <20250611-netconsole-msgid-v1-0-1784a51feb1e@gmail.com> In-Reply-To: <20250611-netconsole-msgid-v1-0-1784a51feb1e@gmail.com> To: Breno Leitao , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan , Simon Horman , Jonathan Corbet Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, Gustavo Luiz Duarte X-Mailer: b4 0.13.0 Implement the _show and _store functions for the msgid_enabled configfs attribute under userdata. Set the sysdata_fields bit accordingly. Signed-off-by: Gustavo Luiz Duarte Reviewed-by: Breno Leitao Suggested-by: Breno Leitao --- drivers/net/netconsole.c | 49 ++++++++++++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 49 insertions(+) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index 787d170c3a0b..813f50abaf9f 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -489,6 +489,19 @@ static void unregister_netcons_consoles(void) unregister_console(&netconsole); } =20 +static ssize_t sysdata_msgid_enabled_show(struct config_item *item, + char *buf) +{ + struct netconsole_target *nt =3D to_target(item->ci_parent); + bool msgid_enabled; + + mutex_lock(&dynamic_netconsole_mutex); + msgid_enabled =3D !!(nt->sysdata_fields & SYSDATA_MSGID); + mutex_unlock(&dynamic_netconsole_mutex); + + return sysfs_emit(buf, "%d\n", msgid_enabled); +} + /* * This one is special -- targets created through the configfs interface * are not enabled (and the corresponding netpoll activated) by default. @@ -922,6 +935,40 @@ static void disable_sysdata_feature(struct netconsole_= target *nt, nt->extradata_complete[nt->userdata_length] =3D 0; } =20 +static ssize_t sysdata_msgid_enabled_store(struct config_item *item, + const char *buf, size_t count) +{ + struct netconsole_target *nt =3D to_target(item->ci_parent); + bool msgid_enabled, curr; + ssize_t ret; + + ret =3D kstrtobool(buf, &msgid_enabled); + if (ret) + return ret; + + mutex_lock(&dynamic_netconsole_mutex); + curr =3D !!(nt->sysdata_fields & SYSDATA_MSGID); + if (msgid_enabled =3D=3D curr) + goto unlock_ok; + + if (msgid_enabled && + count_extradata_entries(nt) >=3D MAX_EXTRADATA_ITEMS) { + ret =3D -ENOSPC; + goto unlock; + } + + if (msgid_enabled) + nt->sysdata_fields |=3D SYSDATA_MSGID; + else + disable_sysdata_feature(nt, SYSDATA_MSGID); + +unlock_ok: + ret =3D strnlen(buf, count); +unlock: + mutex_unlock(&dynamic_netconsole_mutex); + return ret; +} + static ssize_t sysdata_release_enabled_store(struct config_item *item, const char *buf, size_t count) { @@ -1037,6 +1084,7 @@ CONFIGFS_ATTR(userdatum_, value); CONFIGFS_ATTR(sysdata_, cpu_nr_enabled); CONFIGFS_ATTR(sysdata_, taskname_enabled); CONFIGFS_ATTR(sysdata_, release_enabled); +CONFIGFS_ATTR(sysdata_, msgid_enabled); =20 static struct configfs_attribute *userdatum_attrs[] =3D { &userdatum_attr_value, @@ -1099,6 +1147,7 @@ static struct configfs_attribute *userdata_attrs[] = =3D { &sysdata_attr_cpu_nr_enabled, &sysdata_attr_taskname_enabled, &sysdata_attr_release_enabled, + &sysdata_attr_msgid_enabled, NULL, }; =20 --=20 2.47.1 From nobody Sat Oct 11 04:18:15 2025 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45FEE2E611B; Wed, 11 Jun 2025 14:37:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749652670; cv=none; b=AkM3cyYVxpDsx5Tplv2xbwfirvML8Yc16qfl1vkTEEM5hcuqi2U6LIXPEoc1MkPN3vVRzvfUlCrRy/xWyO7u4e29QPW1HUYi/m5pY4U9DbY+e6yeKl7db1aK1SnWvJUPNCuX3LtiWHaE9YYWy1ewLAcVeqzrr2vFqgtloAkISf0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749652670; c=relaxed/simple; bh=JYJreZkOHHz79z5ZTMlVk20LPBbeJoc475yWOc1bu+o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZxQC6u91UTe+HE2RdrgPgP6amdcXC72eeYwrkVFIDBLoW0+4yTwGP8J3Z33sttLnrBidtUvHC+VvJqqtyskDaqboleTdrVIxt37SyqmcpLAKqrcKqi6PnI8rBbFIoNPXmarN8DZ6TJ1j8Y0+9JClUJfErNmfLy8n5TEaoSSVIyo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=S8yGJ529; arc=none smtp.client-ip=209.85.160.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S8yGJ529" Received: by mail-qt1-f173.google.com with SMTP id d75a77b69052e-4a43e5c2b1aso382521cf.2; Wed, 11 Jun 2025 07:37:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749652667; x=1750257467; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3AXukWCQuh8tn2wAnl2VEUgBuzOqFWDlGEpyKe2E7R0=; b=S8yGJ529iwrQVPnKrGVoprooSmxtR/HdaSzaHG0b9Ou9Dfe1OmSwEE6kzreVh8w8/M BG+vL608c+/kh93oyOSiw51/MWJZSs3E1Y5LJCiqb3AEavNvZBhdNjJxrs7PSbxvjDRI fjHUos7JJhVw4G3YQ8AB7wDEh+9H95B4GdK6ByE28lYqqVQoYJL4KEEGGd5ErcY7jDMu RflCbVD04oZdkERiJ1RyY5sL1ieXccICjetPdaLaA5Le8r+GaDvBoHbr0OrNFdYhGV1O 600NkW3LVf9jnmsa8oddU+xhsx30ZX1T9QmJncOnzqow5xhugPoMor9YOs+yC8q61GaF WO1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749652667; x=1750257467; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3AXukWCQuh8tn2wAnl2VEUgBuzOqFWDlGEpyKe2E7R0=; b=fBmEY515RJR3XHRveqWWKSa7h/zFrbFgWSiYRRgjcuNGAV1CRQHIEfPfrgxOKaXtbA +JD9pO/9omFHSZmEOFjx45m9eBTfeJPBAkgSvgvqHfUmMb9aUJrAl6NszHYb53vdXtYJ U+PBIsDGYjs5t8kXlcZyYad7er49Jn9lon8x4ssBejfWdLu19jU6QubyxH2jAqmb6hg/ HSTLCVOD79xhlzxkBS2FIVpvFiNY7MRTMYoa5kDB1zjHnRVYKtshnOa4sNepMeQQjcJ1 SwQaZ2IR94BYx5lk53zKx14qWcym2f+a07zBY4Kjn/1/Il3LH5++SSkbmRDnzEb5k4/u shMQ== X-Forwarded-Encrypted: i=1; AJvYcCU3hpTVKpJJi9n5adsmRebLQD7nVuP6vc2hbcoUfB7vHasbMU2oRAdSr+dVQG5wwDRIDWM/4qzyK34=@vger.kernel.org, AJvYcCWoPtwVJ3XmbmCCWEfwBO9Bp7aohsSuXP8baZ30M8P4+2uaFwjD5WLIxwjTaEUAqi5ADbgxsbeO7sCQmb7GgXZI@vger.kernel.org, AJvYcCXPB6O71+kY//67cZNhk+PF/MNY9YRfiNpRlPLEfWVNvMS9J1gIiGCSxdwqFeSfskkWSCnn7pz0EWNgABa1@vger.kernel.org X-Gm-Message-State: AOJu0YyhB+7joZ6nS2FbMk4VJIsRLsaYIdlrm90VZU9+5HICTIEFYXkD bPVYaBWhQGQZPLTHhTTysiG/zJFlG/8T2DykngeKmdzyd6FCGGlKSM4QPLmoZTHKv2o= X-Gm-Gg: ASbGncs08xQL3orkp+qyMqM5TEFpZUg4sWOrvV5ENjyUv/hG4pz9hc8MI/wszoChFNj S40aBt8eT668hQkk9445CFq+A+haiF05ago3OkSNWitVy5k4KJcSVHVK2wO4w4bsFVk9SgXbLKd fYopLTdvQprjAYOj7WyZYuM4Ev36YM/Gp6/sQPKF6cZKn/Ufv3MXOnLdbkVMGEjk905FDIxlUFe O9m64xbWPvOJU0Oam7KbzAYEuRXwZCXGj6HOQTS74+4K30PC9fv63mloforCFDvOoVwLfYex1gU ys3a477XlSH3m6kdJS9Dasv4DZx5loGaU/9CCiSfPoPKFb3jPOcY5oQL X-Google-Smtp-Source: AGHT+IFzDewi+CU4QnYgkImp6inn5D5dtRpYExd+TsbaYLkrlP7RSuEX5tDLjdtYuzc7CnEGrP+qKQ== X-Received: by 2002:a05:622a:1a24:b0:4a5:a4ad:c55b with SMTP id d75a77b69052e-4a713c5ec60mr20160221cf.12.1749652667485; Wed, 11 Jun 2025 07:37:47 -0700 (PDT) Received: from localhost ([2a03:2880:20ff:71::]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a6f7a786a3sm56838381cf.81.2025.06.11.07.37.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jun 2025 07:37:46 -0700 (PDT) From: Gustavo Luiz Duarte Date: Wed, 11 Jun 2025 07:36:05 -0700 Subject: [PATCH net-next 3/5] netconsole: append msgid to sysdata Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250611-netconsole-msgid-v1-3-1784a51feb1e@gmail.com> References: <20250611-netconsole-msgid-v1-0-1784a51feb1e@gmail.com> In-Reply-To: <20250611-netconsole-msgid-v1-0-1784a51feb1e@gmail.com> To: Breno Leitao , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan , Simon Horman , Jonathan Corbet Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, Gustavo Luiz Duarte X-Mailer: b4 0.13.0 Add msgcounter to the netconsole_target struct to generate message IDs. If the msgid_enabled attribute is true, increment msgcounter and append msgid=3D to sysdata buffer before sending the message. Signed-off-by: Gustavo Luiz Duarte Suggested-by: Breno Leitao --- drivers/net/netconsole.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index 813f50abaf9f..34b61e299eeb 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -155,6 +155,8 @@ struct netconsole_target { size_t userdata_length; /* bit-wise with sysdata_feature bits */ u32 sysdata_fields; + /* protected by target_list_lock */ + u32 msgcounter; #endif struct netconsole_target_stats stats; bool enabled; @@ -1345,13 +1347,21 @@ static int sysdata_append_release(struct netconsole= _target *nt, int offset) init_utsname()->release); } =20 +static int sysdata_append_msgid(struct netconsole_target *nt, int offset) +{ + nt->msgcounter++; + return scnprintf(&nt->extradata_complete[offset], + MAX_EXTRADATA_ENTRY_LEN, " msgid=3D%u\n", + nt->msgcounter); +} + /* * prepare_extradata - append sysdata at extradata_complete in runtime * @nt: target to send message to */ static int prepare_extradata(struct netconsole_target *nt) { - u32 fields =3D SYSDATA_CPU_NR | SYSDATA_TASKNAME; + u32 fields =3D SYSDATA_CPU_NR | SYSDATA_TASKNAME | SYSDATA_MSGID; int extradata_len; =20 /* userdata was appended when configfs write helper was called @@ -1368,6 +1378,8 @@ static int prepare_extradata(struct netconsole_target= *nt) extradata_len +=3D sysdata_append_taskname(nt, extradata_len); if (nt->sysdata_fields & SYSDATA_RELEASE) extradata_len +=3D sysdata_append_release(nt, extradata_len); + if (nt->sysdata_fields & SYSDATA_MSGID) + extradata_len +=3D sysdata_append_msgid(nt, extradata_len); =20 WARN_ON_ONCE(extradata_len > MAX_EXTRADATA_ENTRY_LEN * MAX_EXTRADATA_ITEMS); --=20 2.47.1 From nobody Sat Oct 11 04:18:15 2025 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F4AB27815B; Wed, 11 Jun 2025 14:37:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749652677; cv=none; b=C5GS9xYAQsTaBXokh1RVmRiW2k/fCx+qwCpYKqPRUa3p7zP/EuvrcVaD5lHpZvHTuRIB4BqjRQ6GI+jlr6WjncpPolEC/j5JKY1XnrN5EEBXg/kntLvySrCDgA4bq38GvuqVQFCR6AO/1HG4vNkN3nuHIbrkgpRILADLxE7RBRU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749652677; c=relaxed/simple; bh=6QEznI5dDLWlKvkkHo/QuzqxbGMfjbjAro9UR7sEabw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=vC8dBNwEZ/KctaE5orIZKkOIlikTKXloadVffbo9yPhgLUeu3KA/kcrwBooDSBUf4fYdH4ENsRb9oK0tw+jIdeqCnsZ8O934YelHVGgRoE5C1Jrm/OBNMQiVZpU5dRdsy6EJLXktaVOKT4hkSCx4TE4E3c2lm8cX4lLbvWeHc60= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jaFE6AvY; arc=none smtp.client-ip=209.85.160.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jaFE6AvY" Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-4a5901854e3so592711cf.3; Wed, 11 Jun 2025 07:37:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749652674; x=1750257474; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=mWTHHniH+bU9oQ9NHxDCHqm92WzrmLWSDAFi+6Fga6c=; b=jaFE6AvYz2dJTlkvbuKo3C4VfF+Ooj27hEryW8eU2Ymx8YMyBhBy24EUZtAbgb/E9B BUvDTwy1M41LyReGZn48M8cDpWjb3SjXPePBl5TqX7dBxUgCJ/48Jq2aqGqKJ9TJcs3x gL47ZXOejE6dmkXvyZRR6bCU7yGesWQwkzJ7rEvc2WsOEn2QE1FrtsWoTQ1yGDWT+1pb UUimyyQKNDORSwWXT7XMV0eqbjvdUmHgNCCnoynF5Nqykwsuh2CyRhSp7z9DN4i2PZTh pLo4JnpXi9jzFvtk9O1KYh+LJBHOvaXLVR+RAfurrviLMsb1To0Ipw6TLBGqaArxMQEo lMdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749652674; x=1750257474; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mWTHHniH+bU9oQ9NHxDCHqm92WzrmLWSDAFi+6Fga6c=; b=Yv5eMoWL9apqaT20E3kqKAGi2pArnrUJ4OPEuhFnnwLnA9b6SbbPEp2WfAZFX5AWek sT6vMyunrvyxFfnU/nOrcIIDMlCxSqCwTLG1qr6HlnIvkFWsW1eUMQNCLDAdzju14sIb MoEpBBHLb0bDnCQVj89KrhSJVFJwSbE3oMGfEzj/jbKzqYjlxlNJVSfTOJoy/TyHu9U7 sxheQzfp8riG7wx3YYvjXik33rZcH0qXd3sJ9hfXIh+uQvngm1k6uzyjZjjp2zBAWPg8 IUPw3nFZ2kkqZ/qPx0N5nCFiUIG2Wajz6By7xM4noAxo/VhNzqtnta3uEhpAbrOoITLR ZvGQ== X-Forwarded-Encrypted: i=1; AJvYcCV2Vi1kt82T8n+9OrCiHlAH9P0B96RQaJOBksUFKjwbrVHMKV0UZiALRRHDuHcHbiS5nV/yrCeKS2RaaDcl@vger.kernel.org, AJvYcCVtPraL4mmjR7BRqPYIuomNeqMqS7SchpqrCRjiKnPgtX0sn16xN+bJFXPA2cb4RKjju1IpYOz13jykXLADC4fx@vger.kernel.org, AJvYcCWOeKON0GSw/5ey7kRQ4tuI7SpWy3rsSFVUZqoTJ50/QH0UrgygI1bdfbw03g/7Kx+8682GWunbAcY=@vger.kernel.org X-Gm-Message-State: AOJu0YxQ6PdenEzxDpVlHsdxOAoX+aTOs3Dte3whWtYXufFkpcL5tyne mkC/vMDPbUilgsxNG/ZoVV93HT0tnEEEv1ojz98tLdiAHHGx4MWQuItZDa3pxol5UfA= X-Gm-Gg: ASbGncs+H9itNFPlwua0oPIDDLPH7bqbpc2nz6snGi9F88K3kUust6O+5irJ7G3JNER gAh33t3IamjwrWJvgANeX+5H4qRzUPep+8Y7DSl2zWYJiZfmxh6bjeVbIxcFbnRb2AQPt3JP9wm 3rqb5uvT6aHl0wG3y14R+nH0OmRnAg+tlYPH3VIkQ9hmoc4cjc+8z/vGdtdM+D8pqsJ7Z+jht4G dZLrcnq29dV+Wj4CSJaJM31X/4Y1RZL+1qF+ctXmhMm0KQkeOFc3v6y1W0Ew7yv/fPvtEmNbr9k M1yxz5byo2AB3mdR7p/IN2QhCx/ebCh4ESYOEcvv05kNSMS57RFSUqgz X-Google-Smtp-Source: AGHT+IGpoQb1VZnYZFkyUPWRdqFbZp2QlhkzTSMnfG7PGjcKk2oqkZ6BSv2d7fW+qfiyp5LbxQ0IJg== X-Received: by 2002:ac8:7f52:0:b0:4a5:aaeb:dce2 with SMTP id d75a77b69052e-4a713c2128cmr21232271cf.10.1749652673543; Wed, 11 Jun 2025 07:37:53 -0700 (PDT) Received: from localhost ([2a03:2880:20ff:7d::]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a619894b05sm87327141cf.75.2025.06.11.07.37.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jun 2025 07:37:53 -0700 (PDT) From: Gustavo Luiz Duarte Date: Wed, 11 Jun 2025 07:36:06 -0700 Subject: [PATCH net-next 4/5] selftests: netconsole: Add tests for 'msgid' feature in sysdata Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250611-netconsole-msgid-v1-4-1784a51feb1e@gmail.com> References: <20250611-netconsole-msgid-v1-0-1784a51feb1e@gmail.com> In-Reply-To: <20250611-netconsole-msgid-v1-0-1784a51feb1e@gmail.com> To: Breno Leitao , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan , Simon Horman , Jonathan Corbet Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, Gustavo Luiz Duarte X-Mailer: b4 0.13.0 Extend the self-tests to cover the 'msgid' feature in sysdata. Verify that msgid is appended to the message when the feature is enabled and that it is not appended when the feature is disabled. Signed-off-by: Gustavo Luiz Duarte Suggested-by: Breno Leitao --- .../selftests/drivers/net/netcons_sysdata.sh | 30 ++++++++++++++++++= ++++ 1 file changed, 30 insertions(+) diff --git a/tools/testing/selftests/drivers/net/netcons_sysdata.sh b/tools= /testing/selftests/drivers/net/netcons_sysdata.sh index a737e377bf08..baf69031089e 100755 --- a/tools/testing/selftests/drivers/net/netcons_sysdata.sh +++ b/tools/testing/selftests/drivers/net/netcons_sysdata.sh @@ -53,6 +53,17 @@ function set_release() { echo 1 > "${NETCONS_PATH}/userdata/release_enabled" } =20 +# Enable the msgid to be appended to sysdata +function set_msgid() { + if [[ ! -f "${NETCONS_PATH}/userdata/msgid_enabled" ]] + then + echo "Not able to enable msgid sysdata append. Configfs not available in= ${NETCONS_PATH}/userdata/msgid_enabled" >&2 + exit "${ksft_skip}" + fi + + echo 1 > "${NETCONS_PATH}/userdata/msgid_enabled" +} + # Disable the sysdata cpu_nr feature function unset_cpu_nr() { echo 0 > "${NETCONS_PATH}/userdata/cpu_nr_enabled" @@ -67,6 +78,10 @@ function unset_release() { echo 0 > "${NETCONS_PATH}/userdata/release_enabled" } =20 +function unset_msgid() { + echo 0 > "${NETCONS_PATH}/userdata/msgid_enabled" +} + # Test if MSG contains sysdata function validate_sysdata() { # OUTPUT_FILE will contain something like: @@ -74,6 +89,7 @@ function validate_sysdata() { # userdatakey=3Duserdatavalue # cpu=3DX # taskname=3D + # msgid=3D =20 # Echo is what this test uses to create the message. See runtest() # function @@ -104,6 +120,12 @@ function validate_sysdata() { exit "${ksft_fail}" fi =20 + if ! grep -q "msgid=3D[0-9]\+$" "${OUTPUT_FILE}"; then + echo "FAIL: 'msgid=3D' not found in ${OUTPUT_FILE}" >&2 + cat "${OUTPUT_FILE}" >&2 + exit "${ksft_fail}" + fi + rm "${OUTPUT_FILE}" pkill_socat } @@ -155,6 +177,12 @@ function validate_no_sysdata() { exit "${ksft_fail}" fi =20 + if grep -q "msgid=3D" "${OUTPUT_FILE}"; then + echo "FAIL: 'msgid=3D found in ${OUTPUT_FILE}" >&2 + cat "${OUTPUT_FILE}" >&2 + exit "${ksft_fail}" + fi + rm "${OUTPUT_FILE}" } =20 @@ -206,6 +234,7 @@ set_cpu_nr # Enable taskname to be appended to sysdata set_taskname set_release +set_msgid runtest # Make sure the message was received in the dst part # and exit @@ -235,6 +264,7 @@ MSG=3D"Test #3 from CPU${CPU}" unset_cpu_nr unset_taskname unset_release +unset_msgid runtest # At this time, cpu=3D shouldn't be present in the msg validate_no_sysdata --=20 2.47.1 From nobody Sat Oct 11 04:18:15 2025 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 700DD2BD5B6; Wed, 11 Jun 2025 14:38:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749652682; cv=none; b=T+DeZNUV4ArF6yvfpwZsvTRWaE4PtkHrOhaF/NUbv+sgUYr7w7oYwdLnvO0aeY0hCG7omUP4UUv5r+tDmODlA7mbuq+IBC9oygB4exI1ejF0V5VDViB9COrfIaj44KU7R+JnvAGUO+2Z/CzqQljMeI5XcVABOmylqimlGGM+ooY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749652682; c=relaxed/simple; bh=tOzgL0KY9yFrjchFg5tvk0J/AejOvH97Tt3OuAqyGZA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KEV0sLsItpP/XmXMxAaidgJ4jZlicIs8t59Fot/nUVkNs0/b8JVDlKWmJRKFZmHGs3iG9Q/BmiisWWOHoIm5gRzdIbnZcf9HtGKqmr0zk3GVA6mjUfH1Fay97f+/g4cq6k1gmnu3OqISLpuziLrvev4cPTPGtfykeIWad0euNmI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BtBKBOaO; arc=none smtp.client-ip=209.85.219.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BtBKBOaO" Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-6fac4e2fcd1so144046d6.0; Wed, 11 Jun 2025 07:38:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749652679; x=1750257479; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=LEWFUemvl7siyfmS6XSp2BMVs4pqCozC91INbpbQZrY=; b=BtBKBOaOaRWiPauG8AGmK0BnMFHDRD1TBBwGUqHJ4KatXjnWyn5CffwDCgai9MkhUe 9vbFMvuauXgFesDJdqxcyhbJLz8K6lYzMDaKl0ilz+CoHlmZ95xshZmlcl2bT+82NVvC JLEbFiaQh00rIl6J5biOmSHGvUgoAYGOnFngwWBc2lFBy+DSeBI6VtEJKkgsEs//KV5l jIDTwXcRMPDyyJtH/eapUteX5l23Cgwtuh1TqexQFuU4M50jYmN00qYzzAFGUhyphqHi Mt3Z2W5N8kccQNTKE9cYJtbeBOYZkrwgdtSLgPnt4QMDDLd+qrFWtmOXK59hZF7Bg9Eb nPew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749652679; x=1750257479; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LEWFUemvl7siyfmS6XSp2BMVs4pqCozC91INbpbQZrY=; b=qYluR5EpSHnjpLj3XFFqJG8+8jBQkjO8yy4G5nRxhFRBKKkN40/PdM8qR8UrgFKOr6 /+OTOjMKVdqXJbvR6eiEZsa/GWLiqCOlNZ50jsfVztIzB7T9kvzfGzb6DsQ4UeGu7e9h Rdn4VoBbMHT8HUTl0emSHxC2PMWkbNjjt5mGkOUpyBqA8tlX2pjfC2UzoV1m71JPE7rr LtqRJ5cVnvE7yv+N26dVqe6puErkrOlMtNkYc7umJisf1t8++d1n7cOESYqKB+gtTHRS fwWwHLIDecAnfEL8/QgpUTgbRmleF5PxJshcYqY705JmJAxqVJOqSSYX0TVb4k5IVlyq nHlA== X-Forwarded-Encrypted: i=1; AJvYcCU0qmUQ+EvMl1+H+l8OthJ3HD9xy84dfQNVUwOfJKHzKK9sIs7lV+U+dt5+T4cJR4TvRWI3v8a02EdEf9K8@vger.kernel.org, AJvYcCVbOBKg0C58OMo5u0MWrAAa2Z3gz8OzGmQcSnQCo7PQz/wSteDdx8QlSDFekWdG7npIy18PpZAf1lY=@vger.kernel.org, AJvYcCXJypFgIsrzUxk3iUgQON7lgJRgeoQjoCRAuETlt5jXhGKmsvBpUyU3d5H1gDt4lV9ASaXzY13+FaScFidtZ8ol@vger.kernel.org X-Gm-Message-State: AOJu0Yy9TVH+czVCLpmFQDL6WQLY1b00VPj3VxH0D2a3uY+anTS/AP6Q IYmkKnuSSvjsjNiduDmhhAycGkWSbes1UZKj4e5scJ7Dq+H2RP1Z1F3uIF8aJEgfnEU= X-Gm-Gg: ASbGnctjQFYTVDgii2tb+Gj6YPOOoa2XZtkUSyVO98Xz70dszhM8xwvaH8Y4SR7tnBC EaCfBwogocssnMBXE7h1o5XSADIlT5UJVzUJosrdmX/4jJSO0HHVfDE9hQS/tEnKn4K5InoHt5E tMOmIEZaUldbcXN34jFwHKZWQdAJ9booS93yqrZIKQUUWHAlz0d4Gt3MiOlhtR6d1sHv3bUTdIt 79+JTc9C8QKihl5buRGb9Y9GysD6kuJlYWGEDB0GfX9Kfq58DEPcaYPMexF3pfImdFNP4xsjM9J Jn9AofbzcpUT7A+InsR9YiwRd2leUArf5UWRmuZZw6pDl5ULUp8QhbE= X-Google-Smtp-Source: AGHT+IHJUXXQFyBk9F2cncTLJpxIYvehgFqAwrqxUqIhkdJDPaNUQfAOqJdsZttNUJYQKPxTN6q6Ng== X-Received: by 2002:a05:6214:2509:b0:6fb:fe9:e90d with SMTP id 6a1803df08f44-6fb2c38cb32mr22229576d6.10.1749652678841; Wed, 11 Jun 2025 07:37:58 -0700 (PDT) Received: from localhost ([2a03:2880:20ff:8::]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fb09b1ce20sm82252766d6.67.2025.06.11.07.37.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jun 2025 07:37:58 -0700 (PDT) From: Gustavo Luiz Duarte Date: Wed, 11 Jun 2025 07:36:07 -0700 Subject: [PATCH net-next 5/5] docs: netconsole: document msgid feature Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250611-netconsole-msgid-v1-5-1784a51feb1e@gmail.com> References: <20250611-netconsole-msgid-v1-0-1784a51feb1e@gmail.com> In-Reply-To: <20250611-netconsole-msgid-v1-0-1784a51feb1e@gmail.com> To: Breno Leitao , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan , Simon Horman , Jonathan Corbet Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, Gustavo Luiz Duarte X-Mailer: b4 0.13.0 Add documentation explaining the msgid feature in netconsole. This feature appends unique id to the userdata dictionary. The message ID is populated from a per-target 32 bit counter which is incremented for each message sent to the target. This allows a target to detect if messages are dropped before reaching the target. Signed-off-by: Gustavo Luiz Duarte Suggested-by: Breno Leitao --- Documentation/networking/netconsole.rst | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/Documentation/networking/netconsole.rst b/Documentation/networ= king/netconsole.rst index a0076b542e9c..42a0acf2eb5e 100644 --- a/Documentation/networking/netconsole.rst +++ b/Documentation/networking/netconsole.rst @@ -340,6 +340,28 @@ In this example, the message was sent by CPU 42. cpu=3D42 # kernel-populated value =20 =20 +Message ID auto population in userdata +-------------------------------------- + +Within the netconsole configfs hierarchy, there is a file named `msgid_ena= bled` +located in the `userdata` directory. This file controls the message ID +auto-population feature, which assigns a unique id to each message sent to= a +given target and appends the ID to userdata dictionary in every message se= nt. + +The message ID is built from a per-target 32 bit counter that is increment= ed +for every message sent to the target. This ID can be used by the target to +detect if messages were dropped before reaching the target. + +Example:: + + echo "This is message #1" > /dev/kmsg + echo "This is message #2" > /dev/kmsg + 13,434,54928466,-;This is message #1 + msgid=3D1 + 13,435,54934019,-;This is message #2 + msgid=3D2 + + Extended console: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 --=20 2.47.1