From nobody Sat Oct 11 04:11:29 2025 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D406519ADBF for ; Wed, 11 Jun 2025 15:05:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749654323; cv=none; b=n+pIbEA2TDgNOSjONmwzLUDUlKCZiu61wfZ0yV/KTC8B9rkAN0SOVXtanX+tnNqvpeeOUmUoyJ/BBBfvsrPmEdfMRzRRZqQw2ahSRPF9JsreYn3eU72O6L5wgULRSvsxSTDgNfqBJY31ARdgGn96HzrmXJCHj85SYvEz9VcvOaA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749654323; c=relaxed/simple; bh=fZSNdaQw7LjO2JSM2umX2tfqykmAKg00XkcpPGh8Uac=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=jKhdhfX+YOJ7KI+IMOwuASBQEk4NqDEU+Evp67ziCFtgBJg7hYs3LcyNngr7fipkCny6IfNeib6ZlLGn8uJ4WGqb/nKu2AXwzISj91myf46k4+TJxEKRXRiMLGeTGRZFT4GdQiIFD+7HePMcvY57awvHAGZ04wSD17nh7cS8PEw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=V41SUBUs; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="V41SUBUs" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-7485bcb8b7cso2273318b3a.1 for ; Wed, 11 Jun 2025 08:05:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1749654321; x=1750259121; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=X2Btuiq67mOopxi+6Aea7VFzZVIX8u5AKrKDKKSNI+Q=; b=V41SUBUsUQG9+5SBCJnG11owZpfwWRwRBvYyckt//KGa0wTI51hRUJz+/dHjWW67S+ Dq9DJvBuEV1qwIyXLYAuuwoK3BRXp8fUUeC7o7oiBiA5i12Tub3uItA/BcfElElR7efq VBgYnXCNVlpvrpekBYR6cgZdXnJQiYyb5cTE/NdP65Q37G1Y1CAv8GJ4F96kFD9Mk+zq XxL0bTfGcL/H/2/SGmooyHrpoDW2GJGmNdAUsLErxJgZDyNMNBd5kedbhmDUw+dI9++m Epvnb02aIa3lAMbKWoytDVhCyQIn+rb5cZUwyta59yIHg+FI4mFl61nj5A4Om6siZ1TZ AqCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749654321; x=1750259121; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=X2Btuiq67mOopxi+6Aea7VFzZVIX8u5AKrKDKKSNI+Q=; b=OJ/ToMwPNVqSxHcJ8KnWG0IXY99svo4Y1ykfKOcZopWqeYR1Mbpywi6gh7NedxXnPt xebc4JvG6VGktvV7bfkEtI8VIu+zFLonFsiZOBjmBIfOQLp6DuRC9G1lkz7IqeCnc2vC zHRh1pXtsa2wazQ5airF3AnPEqPTLT+AVSBr5oXxBNAR3bcC9G5uMvRKNDY8jfLL+Frf 7M9bqb4ERmMu8k7xRSyGe7CGe3/19o8FyYdNIBar5s7cDkHZyeb34Gjr+WRG93qyjJiV elWiv73Ism7Aw33Wcpdn+ofa86LgbPgAUi5J/0IZuoe//GznWCrEHWb744kM/mBSouJ8 bQ2A== X-Forwarded-Encrypted: i=1; AJvYcCXmJKk2jhmDoDwXPlZW9yEJVkUuSihY7a0lTJDmrSz8KN+8HVQrE+mK6Use5BbDn+1JH2/B4NsBMv1WwsY=@vger.kernel.org X-Gm-Message-State: AOJu0YxIH1bU8ulU1pHYSIWTivsqMYZJTQHG0uD+CtbUqJZ7M+sMm0Mu Use7EEesnh0Bpd8pAZV84LGtoH76lYLUInrwb3XBOm0Jd+aDkK9hlzVMd/Ue2mSzWoA9+mT9JUS RAvnX X-Gm-Gg: ASbGnctHhaimcYalNIIDk7LbHl1n+5+MO1lSmsve7EXZj4Hoz7/0EbjiEfG61ekxgIC QBjYCMOUQ4MVhUW3QlsZGJnj4u4oSsR5G88B41VGZ0lkZrtqWGYu6VQIuIouJSGRK3icrPqN7Wx KKF2Q9AxpnIUBBTThiUrcnnA1Ikqw36aiDw1MmYtToUqx3Yr8MUvPY9kGvjjB6RBPDXEB1wtOeh 1aassggmH0nyxHp2m2Kgbv1liu1CbuD+YMbYqbRe/huIBj5jSyar4u9vi2B1JmWbd3trymyA6eQ ZD6nRuYi+YlzDVmqXe2UNCJiiSXHmClU7yKnAbljnKyLa5nBuGZAYcJSQps7hYzH3cc= X-Google-Smtp-Source: AGHT+IE2kNib/WhJGgeczqEw+psw/Mni4H9CXVBeRVZPfI7lAqfHf/tnDuEYm+hNO63ZG+gjAh/zBw== X-Received: by 2002:a05:6808:1886:b0:409:f8e:726f with SMTP id 5614622812f47-40a5d11fe8emr2452486b6e.25.1749654309717; Wed, 11 Jun 2025 08:05:09 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:eb6c:30d1:632b:494]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-73a06fe0b60sm333782a34.28.2025.06.11.08.05.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jun 2025 08:05:09 -0700 (PDT) From: David Lechner Date: Wed, 11 Jun 2025 10:04:58 -0500 Subject: [PATCH] iio: adc: ad7949: use spi_is_bpw_supported() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250611-iio-adc-ad7949-use-spi_is_bpw_supported-v1-1-c4e15bfd326e@baylibre.com> X-B4-Tracking: v=1; b=H4sIABmbSWgC/x2Nuw7CMAwAf6XyjKU6PNrwKwhFaeOAl8aKKSBV/ XcihhtuudvAuAobXLsNKr/FpCxN6NDB/IzLg1FSc3C9O/cXIhQpGNPcGPzJ42qMphLEwqSfYKt qqS9OSEMm549xyuMIraaVs3z/p9t933+5R0wKeQAAAA== X-Change-ID: 20250611-iio-adc-ad7949-use-spi_is_bpw_supported-17f1293abf88 To: Michael Hennerich , Jonathan Cameron , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: Da Xue , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1900; i=dlechner@baylibre.com; h=from:subject:message-id; bh=fZSNdaQw7LjO2JSM2umX2tfqykmAKg00XkcpPGh8Uac=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBoSZsb3/rwLgkmmdrmG2X6iDG5bupSZxzHKyMz5 3oQd+1Ia1OJATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaEmbGwAKCRDCzCAB/wGP wDstB/wNIV5zZQUDfhKoqTCwDnCkCXTZEcsR7JbEMDdQg28JswF5QVaE5e1Yq0JhwcyjC8aDwrU fAsPW165tqaxsQxKhws3W2cOua93FqpotHFP2N8u0UlkUw0wcC6+126TsYGc9tQ71wjVc4YnK3i RbZdSPDWmYcMOqQs5prQdR81D4G2lQo/3UHtbXIbAelqS/XcBVDOysrpA2a8g2TZQQQ9UzUKXbz TP80nyqp7x4I0RfDoXFadwdHKeg5/2DJ0AnSXiwLOUU9CzVciGoqrYUp8aZPkNHgnM8nS/kacRN rDXfySbiyXtmfxu9/Mavv4NHGutYLdpWgkcmkThw63yWNMZ7 X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Use spi_is_bpw_supported() instead of directly accessing spi->controller ->bits_per_word_mask. bits_per_word_mask may be 0, which implies that 8-bits-per-word is supported. spi_is_bpw_supported() takes this into account while spi_ctrl_mask =3D=3D SPI_BPW_MASK(8) does not. Closes: https://lore.kernel.org/linux-spi/c8b8a963-6cef-4c9b-bfef-dab2b7bd0= b0f@sirena.org.uk/ Signed-off-by: David Lechner Reported-by yourself. I'm wondering if the Closes adds a value in this case. Reviewed-by: Andy Shevchenko --- drivers/iio/adc/ad7949.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/iio/adc/ad7949.c b/drivers/iio/adc/ad7949.c index edd0c3a35ab73cca5ff87632e4d588eb5d712b47..202561cad4012b67e23ad6d3623= c913cfef35e68 100644 --- a/drivers/iio/adc/ad7949.c +++ b/drivers/iio/adc/ad7949.c @@ -308,7 +308,6 @@ static void ad7949_disable_reg(void *reg) =20 static int ad7949_spi_probe(struct spi_device *spi) { - u32 spi_ctrl_mask =3D spi->controller->bits_per_word_mask; struct device *dev =3D &spi->dev; const struct ad7949_adc_spec *spec; struct ad7949_adc_chip *ad7949_adc; @@ -337,11 +336,11 @@ static int ad7949_spi_probe(struct spi_device *spi) ad7949_adc->resolution =3D spec->resolution; =20 /* Set SPI bits per word */ - if (spi_ctrl_mask & SPI_BPW_MASK(ad7949_adc->resolution)) { + if (spi_is_bpw_supported(spi, ad7949_adc->resolution)) { spi->bits_per_word =3D ad7949_adc->resolution; - } else if (spi_ctrl_mask =3D=3D SPI_BPW_MASK(16)) { + } else if (spi_is_bpw_supported(spi, 16)) { spi->bits_per_word =3D 16; - } else if (spi_ctrl_mask =3D=3D SPI_BPW_MASK(8)) { + } else if (spi_is_bpw_supported(spi, 8)) { spi->bits_per_word =3D 8; } else { dev_err(dev, "unable to find common BPW with spi controller\n"); --- base-commit: 4c6073fec2fee4827fa0dd8a4ab4e6f7bbc05ee6 change-id: 20250611-iio-adc-ad7949-use-spi_is_bpw_supported-17f1293abf88 Best regards, --=20 David Lechner