From nobody Sat Oct 11 04:24:10 2025 Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48C9935970 for ; Wed, 11 Jun 2025 14:40:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749652831; cv=none; b=DUUBYYyRvMOqe6KXAahNZjwBhTNa4489FplSdbmCTS0Z0ptH06GpEc0tuw2/0P02oBEw92JVafe3w4hMQsv4U2HliIvHp6GnxOqAL1+VPDGTggoOKuyKmcSChatfLMRA71j5rItnx5xASeweTdrlsHno5eRimDOhGDaiU8k+/vs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749652831; c=relaxed/simple; bh=AoNBXfxmjiJwlJyNJTpuHiDBXjwzWldZGbKBWicfIv8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=FWTEPaAVggevP+i+VnBXO7mVSNjV9U/m5lWDSFGuaLQ8eDwGoUUPPSjOFFGU189do7Xpznf0cI+uqcdOUQE4LqqgRUi9uqcSHl4uYSZM20Jd7MBWctIiK8VuMGXULzp4ERUlZOd9+KrkS7Tm3NxnVCn46V8s441XHmkPVp6lUV8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=CM0NakH2; arc=none smtp.client-ip=209.85.210.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="CM0NakH2" Received: by mail-ot1-f48.google.com with SMTP id 46e09a7af769-72bc3987a05so617310a34.1 for ; Wed, 11 Jun 2025 07:40:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1749652828; x=1750257628; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=mLrrcjxPAjeFKi7iUJTxvFP27ls+0S72xIdrAaB/V34=; b=CM0NakH2YsQcYV0RupCN9KJcFRRJniJNLL9imCu3TvckMZDI5ZocGq7sKkWFiBUwfz ZPLV7mDKfW6FqMvWBeAKqhOam3AElSqB0p7S8PdZk//p6+Zz7h/PxlTH2oMI8PBqLt+i AI3R+RUSzlA87zdyBsZ4AakuDcljAiKaB+Lqaat9lQBgvx67qD5X1RALP6BOCdZDV5R/ ZyL50DQfDaVxCG1T9bXzdPVk1jStQFD1W4yeB6AUtBp7GGVutzxZkqSVHsLOluTLk2jv NabtAxJCPjjxV8oL92ZhIFv968nS0cNaHXnaiLBLQuv9GEwV2eC6lJuUv8x9QsIAJRcJ 2R1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749652828; x=1750257628; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mLrrcjxPAjeFKi7iUJTxvFP27ls+0S72xIdrAaB/V34=; b=Xfu8SQrb+JZdqnJz7jtcdNZXBsZhwdogt4hlhkR4jRPs8McjO3m2gc55LBw0S/ipkc 2StTNM68o5iOCqJdiIHdnvDqpkEV4F6KoVnIRtRx5Qs2Iy4/uRKPd4GmFBOGKb8xpO3S /znbf5mt8UVndHVqqyAU27VZHuUPl6WPwAfMDWfN3GMYgk7PG1TKyTJzfLR15s/WX4W9 bN8JJyju1gGAF1nUyPpauGS2F9O5LhAkMroYxnnYFhkayzux8nJrZTuvEAvWneBsxwpo +fFLucJxFO5plXIOb7vn2G3PKU94BQpg+n96JFnoUMckAAwsgkWaLLaScftqxZeEl5rc Qk8Q== X-Forwarded-Encrypted: i=1; AJvYcCWT6W9ucPV/lBP/06HqaufZqhuw3DnSBUmqCsx+G1RMb2+Ao8cUlAApoa/2scXHEs1o0dQApccmzth69V8=@vger.kernel.org X-Gm-Message-State: AOJu0YxhNadlzO9nRrQ/wNbldwgbof4+X8Evu6ROgDsZs14ZzBSTPPqL UVuaRpPAKOVYULI8oDmjbrNv6JfIltSx8sym0Egv79sRwu1SN44QVqgEfHNUeRmfgjc= X-Gm-Gg: ASbGnct5w7JJtkjNAvA42L6OgwQ6yCVKdhJ9ynEv3O7W2E0e01yCaJh4Eb13nTxSVx9 CX2mZ7exl5DpnIL9Dln4ylfLg+3IGzki1JdocpL60cqf8iKjHhT1fVZXK3n34ANGxURm0pRAZYw pc9ppkplWBc0LSyPnzczn/FhVLqFrmuwNTafr13pvoSNjC3TJ88MjEXCxsdLcGLfKI23CQA5QK4 RLx1q8Bc8+N0JCZ26jntV4csnG6jBR6x3l9zdb1WZ3L1OJN2Mq7QiMblqeqsZe7UDhvdWrSOyKj 3WQh+jQYmM78VKA9yX7fKb8+jG7pn0aFEPflZx1gdJ2xQhrTQhYokEKzX/yCWKBxG94= X-Google-Smtp-Source: AGHT+IFr6GLRVZwQuuEJUWf6+gPiIRd12h4YaeLZ8Ur4iNPV4hBUvhA1RQPoqix09J2XDOWzvZobxA== X-Received: by 2002:a9d:7d85:0:b0:72b:7dbb:e39d with SMTP id 46e09a7af769-73a0652151bmr1588147a34.1.1749652828260; Wed, 11 Jun 2025 07:40:28 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:eb6c:30d1:632b:494]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-73a06faa7a4sm330735a34.7.2025.06.11.07.40.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jun 2025 07:40:27 -0700 (PDT) From: David Lechner Date: Wed, 11 Jun 2025 09:40:16 -0500 Subject: [PATCH] iio: adc: ad7173: check return value of spi_setup() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250611-iio-adc-ad7173-check-spi_setup-return-v1-1-4d6f9ef0a2e4@baylibre.com> X-B4-Tracking: v=1; b=H4sIAE+VSWgC/x2NQQrCQAxFr1KyNjCZoQ54FREpaWqDMB0SFaH07 gYX78Pb/LeDi6k4XIYdTD7qurUQOg3A69QegjqHQ055TGciVN1wmjmoVAvyKvxE73p3eb07Wqw 1TDUnqrmMS2GIr26y6Pffud6O4wfDhGBkdwAAAA== X-Change-ID: 20250611-iio-adc-ad7173-check-spi_setup-return-072017235f3c To: Michael Hennerich , Jonathan Cameron , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1097; i=dlechner@baylibre.com; h=from:subject:message-id; bh=AoNBXfxmjiJwlJyNJTpuHiDBXjwzWldZGbKBWicfIv8=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBoSZVR9M0Y2yJvw8Y3W1UqUwM2S92STPmFTqFkv /YhRZ3r+W2JATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaEmVUQAKCRDCzCAB/wGP wF2KCACFPxTMDj4CL5i7akxNe1PjAzgkhUg2vFq9o2g5vSBsA4+H7uJ4QTe7QtnrkK29QKm/kk9 K59OyZcHOm3ggA7wQkgWtqtEZ2w084F5bFrMR3kMc6zitxnVxoIo4ESfiU+HsP/wHFekncHaEzt UVYgLReJyxkbxtjRSBc4BjBPwnngiDHocpSF2IbN3d+5mYI2t/py9MveadvUr+Bv4sh9EBz5qPQ b/jMmCC3krjSWRGuXn6vgKmNVAu3lpr3FGEPAAYig4AGEF4zK/i6L9MSpUZ4DUXSF8z/heeVDs6 oh6t/dZ8al2+1+O5dnRvDU4vUNckEeo9WpD8BYdKBdp3Mzp4 X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Check the return value of spi_setup() and propagate the error in the ad7173_probe() function. This is unlikely to happen since virtually every SPI controller supports SPI_MODE_3, but still always a good idea to check the return value. Signed-off-by: David Lechner --- drivers/iio/adc/ad7173.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c index 69de5886474ce2f700bf277ce707b15637113564..911001be368302fb9d7d6e8da37= 83751fe0f61c5 100644 --- a/drivers/iio/adc/ad7173.c +++ b/drivers/iio/adc/ad7173.c @@ -1775,7 +1775,9 @@ static int ad7173_probe(struct spi_device *spi) indio_dev->info =3D &ad7173_info; =20 spi->mode =3D SPI_MODE_3; - spi_setup(spi); + ret =3D spi_setup(spi); + if (ret) + return ret; =20 ret =3D ad_sd_init(&st->sd, indio_dev, spi, st->info->sd_info); if (ret) --- base-commit: aff301f37e220970c2f301b5c65a8bfedf52058e change-id: 20250611-iio-adc-ad7173-check-spi_setup-return-072017235f3c Best regards, --=20 David Lechner