From nobody Sat Oct 11 00:35:49 2025 Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74F6321ABB2 for ; Wed, 11 Jun 2025 20:18:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749673129; cv=none; b=UDL8Hv6bbb+VvazSmIkubp7GnV0juphZmD+5wYZ3tDuoxPo/gWFcWBAz5Asj/fso3f5lIordLl0ZhwoEK+1J86rfN31ZslNG3AvFgw9gxZ7imkZrFQaHsdRo9Y5EH5U1GTTEG4SZpAq8QaFrXamkT0wGgyX9oTcgRzYsLD1B5Js= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749673129; c=relaxed/simple; bh=SFpLyUrSkeov8lTDekLTl8UML1Z5oaveGJ3pRpViCz0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qip9nflVSowIm+RW7wlxHFVBLf8rQL/Hbpkdcfw2uuaKiKQVBp5RRJeM0iWH+qhR8v9Jm/QAbFCTHQeJZqSfljqy9sIYK4lVMx8DRX1eD5USYU/RD8FiQG1vnlfGRH71afF2Jk1Wu84k70WKT10UOaEk9w1frOjUyAsmi1b6/hw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=oFwMEtql; arc=none smtp.client-ip=209.85.167.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="oFwMEtql" Received: by mail-oi1-f181.google.com with SMTP id 5614622812f47-4067ac8f6cdso161478b6e.2 for ; Wed, 11 Jun 2025 13:18:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1749673125; x=1750277925; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dI+YClki4Q+OM8j5JXLpkAENpDyF7Cb60VCru1h+I9Y=; b=oFwMEtqlRpNqTTZ5sjbllSJABMS1/oibEGQnhutCATmy/qbRK59YDixZykQ6qvdWjH IXBF7ChHnfx7G/lIB7F0aD2jpPglQjywhLz11rkX9ndcoN+ErZhhJLOLtVm7obpEpftd 9I3Ud3l7gCqq39LL9kNbpSMfcRU+bXE2FyOn7uz0d75SRbp7yXtAGKrHsODqojlTF9Ib 0OEiim4MPGZIaMmV2CGdOCWfH7O45W/S/DCoCHjXLR0Xr+c/YaVG/vUati3omiVjOkSZ 0oPesABgRQlS5PTO9d9alpA8DSZTTz7pAafNUSXjT9DneDgcmiqh+4wFrW61gUM8ZLHj 2yiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749673125; x=1750277925; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dI+YClki4Q+OM8j5JXLpkAENpDyF7Cb60VCru1h+I9Y=; b=G1G6WY7Fzmd8Y/PECSlsddOjHLIQ94+3EQ/57Y3eB1sEvfBrTI5uEQdr1nfLhuf1hb Fh0Kh2OIhbE2uCFT9gF2ajnj8jyzse1EIaIZ9nKUfzgP3QhHoytejg7bm0cnbhCc6pCR R0Xdgv6WC8mXb181b/LNCE71ylE5SgxkOcpi0pgCSo9AqCtvs62OiTRTcMNd5TOTwZvf uqaMTmEERy7GSKJwb13yK2XcfZq5YMWlD79WtcGBi/wc/QyA4OoxK8ikb54gutHsobBV kyJRbUXlfro31ZAh2J74zpdlaWVKIJR/A+f2gMErBhp8ty0/LL03mKVC1RAs6483948o cPhg== X-Forwarded-Encrypted: i=1; AJvYcCUEYd6j4/GMaqc4Eud6l3468zBtUJ8X6suNmjE68ZSKzX43x+nuOE++kMIER7QFdQ8uF4d43B4Ni5sKjLM=@vger.kernel.org X-Gm-Message-State: AOJu0YywIRyuuR+jskaZc9boX2TJzqKMMnx/llcrSRaVe0iZGTaM72FV t5dYraOi4eLaJV+33YPNsujIfUguE2AFaALjA+o8p82UDPK2d5BNd3p6McDJVwgPFjo= X-Gm-Gg: ASbGnct6r3aAT5ewpPLEn7KHpgXevU8kP7acMq88iGOC20ROkv+LJVXOMnIj9vktDWK 7KXOYGhFs0jqk7MViHPZIWtAqIvmT4AxZEVc3DoTY+OxSW4T+Fcf2Y+PmbaIKS3nkWSXY6eqI5c EKthDqvqgKvUGqeRB4eQrNFNeipgAduI9/IyY1SCi+nnXOPc2NoctUJ+xGqYq//DlsDNO14oq/k JbGL8LDykgXiKAv/QhsYCjSefVcYmTsRNFvoTZqomm71B0MGMfCDEdN58YM8l910vfHzZeGvidl 63apKb32AezaFWi4wY4DPmhlmwLcpY+ogk+aXzqDmjEABYBySBVopKRAc9JrUUXHxPfa X-Google-Smtp-Source: AGHT+IG+yB4PjXqGam/mFmbhtOtlvWHnGRv/5k7WflE47rsgegPrEoGN/DZYNDmhGQv2uSn8xCKNlA== X-Received: by 2002:a05:6808:2021:b0:403:2a0d:428b with SMTP id 5614622812f47-40a66af403emr374548b6e.39.1749673125624; Wed, 11 Jun 2025 13:18:45 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:4753:719f:673f:547c]) by smtp.gmail.com with ESMTPSA id 5614622812f47-40a5d80d967sm467732b6e.4.2025.06.11.13.18.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jun 2025 13:18:44 -0700 (PDT) From: David Lechner Date: Wed, 11 Jun 2025 15:18:09 -0500 Subject: [PATCH v4 1/3] bus: ts-nbus: validate ts,data-gpios array size Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250611-gpio-set-array-helper-v4-1-fb86a9b499ab@baylibre.com> References: <20250611-gpio-set-array-helper-v4-0-fb86a9b499ab@baylibre.com> In-Reply-To: <20250611-gpio-set-array-helper-v4-0-fb86a9b499ab@baylibre.com> To: Sebastien Bourdelin , Arnd Bergmann , linux-arm-kernel@lists.infradead.org Cc: Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1149; i=dlechner@baylibre.com; h=from:subject:message-id; bh=SFpLyUrSkeov8lTDekLTl8UML1Z5oaveGJ3pRpViCz0=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBoSeSLaTcGiZbGvyVCGhUPWDMAFdGGlhKp9QYAq w/8u/EwnpqJATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaEnkiwAKCRDCzCAB/wGP wFJ8CACa6UjbtPBARyaIgkjAgp72QK4ZU1HZKfzr8KtlLr5R/CB6QnsNyw4TZMvcAWz1R8miGwK rnOoKrQzw+aGBFMT3k/vjRj/Ehsvsfu4W7bFWztvUhRK/1qwRLzvCYaCuNLRC5RYiyIC6MJzcM5 1GKb1EeWt2KZ3wrqA+7OC6UAhPVG7td3ZBG9Md3rkDtHX/buSAFTEANFbH6uZ9+x3Q/6aiS1Wh+ IVJDljCJ+oaaoVCOqFqVCre6Zn23FWfV5glFDG1hsak0No0f8a5Boidw1BqPCpQnkk/vGRFklwS Gr37dNhGA4ZAKQJhX5AnkMka5GObju10gyRpBCOMz+gcGOl/ X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Add validation of ts,data-gpios array size during probe. The driver later hard-codes 8 as the size of the array when using it, so we should be validating that the array is actually that big to prevent possible out of bounds accesses. Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- drivers/bus/ts-nbus.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/bus/ts-nbus.c b/drivers/bus/ts-nbus.c index 2328c48b9b1260e805c631f2aa7379d620084537..d3ee102a13893c83c50e41f7298= 821f4d7ae3487 100644 --- a/drivers/bus/ts-nbus.c +++ b/drivers/bus/ts-nbus.c @@ -48,6 +48,10 @@ static int ts_nbus_init_pdata(struct platform_device *pd= ev, return dev_err_probe(&pdev->dev, PTR_ERR(ts_nbus->data), "failed to retrieve ts,data-gpio from dts\n"); =20 + if (ts_nbus->data->ndescs !=3D 8) + return dev_err_probe(&pdev->dev, -EINVAL, + "invalid number of ts,data-gpios\n"); + ts_nbus->csn =3D devm_gpiod_get(&pdev->dev, "ts,csn", GPIOD_OUT_HIGH); if (IS_ERR(ts_nbus->csn)) return dev_err_probe(&pdev->dev, PTR_ERR(ts_nbus->csn), --=20 2.43.0 From nobody Sat Oct 11 00:35:49 2025 Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F37E2253E9 for ; Wed, 11 Jun 2025 20:18:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749673130; cv=none; b=E2ShX9wG3uNNRh6gaOqw3x8L8d1ihAL39henDwg/tV3fNqFjBYEFfPMuRQdZ3vPtig+WCCrNABhrjmNPYgY+jx5/93uykfTh3UQKSvfNt4rqGpzNBX8+GTMiINa/qa4eUhVXjRb3GKJ7jWhlszqRQ6qD2WzI1tr23otZMq6THAg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749673130; c=relaxed/simple; bh=K5V5TnWu+110nnHuULWw1Pwd0QiBFgzUapmy9BeC2p8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HrWUJMUMAlg+lVBbM9t4TIljbzo7cgI4XXUNGrhA5nxOk9liznM+mCSPX2FHILmmRsx+hsPqjSkY7c1TV2zyf0PKux8xcaQqpf2HtqsKg20OYagNl8h1lbyhpbI5JmxEDjPA574p4ITIlwPqP1TLfbAFiGnWdAoG/DgD+neFpeE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=pne2+DQN; arc=none smtp.client-ip=209.85.167.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="pne2+DQN" Received: by mail-oi1-f176.google.com with SMTP id 5614622812f47-40a4de1753fso133635b6e.1 for ; Wed, 11 Jun 2025 13:18:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1749673127; x=1750277927; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=oAgdP5/7nbSCpei3bdgHz+Kvp3J/VbeQ+Dc9cWuRxQY=; b=pne2+DQNEBE1DBmtW322NUW6m73qsrlwzaXJAZjtMN8V+DpH72ZChl338zc3C7N74g 0kft37MZvxuWMRQKlCYun781fo0yJz8qCnD/HWIkaIByLHVVPrZ2xc0OdL4RT4cmwDFW IJTsohFMvzZOWuDTZfL4kZg9+KxE5ekUCpsqVkoci1tP3mm/B+9B7OFmCkuwfdC+WF/r mwYP3eh3KJ4zINwwEFkU7J1qW5Yix2SEzGetA6ExRBgAdCPgCDirALkH7Va2rfSx2/sI 7ImVBdal5fm/6lMAZ0t9ExbU5qXcILqgCFmbJmIUhEQygL+UjzeLi22gRw6IWnIz9yoI uGIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749673127; x=1750277927; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oAgdP5/7nbSCpei3bdgHz+Kvp3J/VbeQ+Dc9cWuRxQY=; b=R3JCbj46EXZ5OdZ1wMkhVQnwgHFS58f94E3DF8mPP//J53AtWc/dR2OMlHLCscqPbL XsbumeWeBYY/yuAZFEgqWJYFxm0yIFoSbcjxldGdeO1hIvNyBlLbioBYmvJXsspjaL2w 2aVPLfONpVSsd3aogKHciD8umD5Bzbm/1f//RgzOTNXWQq8U3Ay0yX7cXk1OmZX+7d9X /BWcLH3SU/UyaPm2cKZCw0nKbNVjqkNJfCNGMdejxw6uIbUMrWtmQYRCPDNVL1LGxcux ybLns7fWxgH51BGw92pwRIo14LKFspivt8I0UEOGSB8L+0zINwC83CsfXF6sph65JmHT syOA== X-Forwarded-Encrypted: i=1; AJvYcCXayO9wfKz/fAa1UebECl9sOGmSpKhdsEw7Ru5vzLJQsiEdR+kLUkKQL/oAqVlYIZ9tmke7NR5H+5DfkX8=@vger.kernel.org X-Gm-Message-State: AOJu0YzhX8egIA1TkJpmZly6cv1NynnMPfsf+BTwfV6jlWDXbtuDpIeX JVldP4G05r8efxveT9biQnoMboIGLJSB47FlekJNj190oA4DNdWjcqu2tvK8FATyJeY= X-Gm-Gg: ASbGncvcH+M/DtECLKO6Tdlq9yTIEBufFPwPYzKPvPjXLmPGDQTmIbKFLuHkHTZbvuY 155wRZjCKnJkYezpsOxqVef5nyElKftODPuxY4HyLrpHFWY1INqVN6FDfOpmHCamG+g7h5Gt6T+ kgosCS4qrzAfkoQq6bVdKYs0p9X5xQIeJ2RZA8BLiOF8dNcNto4anX++rEwylmqFNQVnI+/QbGr 3tuxtH4WtNv5yd+35zTl9zlE8WmiXsbAQ4HziYnzLWbTFvf6kboVDbGqla/NfjldZXwuumdyYeh KKvAe5KkIOGY0uMYvHaRcovwALMgwG1Y6IoFem0j08R3pNA+I6e2EyoqasKgrtqWqoWw5ss5/lV K3VY= X-Google-Smtp-Source: AGHT+IEsgVOS0Cay3UgDCHS5flNsvIDVMlhbLgckyCmrDV07SD5UV63dS599YfSdekLGeOGNrlRAZA== X-Received: by 2002:a05:6808:1a13:b0:407:9d24:af03 with SMTP id 5614622812f47-40a66048f3bmr626458b6e.14.1749673127379; Wed, 11 Jun 2025 13:18:47 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:4753:719f:673f:547c]) by smtp.gmail.com with ESMTPSA id 5614622812f47-40a5d80d967sm467732b6e.4.2025.06.11.13.18.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jun 2025 13:18:47 -0700 (PDT) From: David Lechner Date: Wed, 11 Jun 2025 15:18:10 -0500 Subject: [PATCH v4 2/3] bus: ts-nbus: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250611-gpio-set-array-helper-v4-2-fb86a9b499ab@baylibre.com> References: <20250611-gpio-set-array-helper-v4-0-fb86a9b499ab@baylibre.com> In-Reply-To: <20250611-gpio-set-array-helper-v4-0-fb86a9b499ab@baylibre.com> To: Sebastien Bourdelin , Arnd Bergmann , linux-arm-kernel@lists.infradead.org Cc: Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1487; i=dlechner@baylibre.com; h=from:subject:message-id; bh=K5V5TnWu+110nnHuULWw1Pwd0QiBFgzUapmy9BeC2p8=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBoSeSR3WFNtYYJy+OvDmT0FfOVbE2ZWgN1LwSvI hhaBWo6iEeJATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaEnkkQAKCRDCzCAB/wGP wHGJB/91c9MDNHlXlq7EmskEj83sq+4fEyuAUc3SHN4AMqTJs8bzFLhHYUn3PqHXh4DPulwulNb f2NoBOAUwUg87Ss0koyZ3DBw1f4JBL8nHCrvwoK5XUNsCuFClysvag/sDr25+YFa89zZDg7BJuq h6uZlbirLJj518mNiTG1gVdiP3ezMybNzNLfuma28EkBum7DzArMY8sLulCIGGeiZ2yRrNGEgY6 JYYMW1zph/pP1NEfwJWZALncH6owE3WbPnYlL46IA3VO30CqHv7NOJnMWBCXykHmee6Eq9Zg+Zm tak73kkf4T1P657GshPZBolIVryP3HqVteJGR2V1K15G1dRO X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). ts_nbus->data->ndescs is validated to be 8 during probe, so will have the same value as the hard-coded 8 that is removed by this change. Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- drivers/bus/ts-nbus.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/bus/ts-nbus.c b/drivers/bus/ts-nbus.c index d3ee102a13893c83c50e41f7298821f4d7ae3487..b4c9308caf0647a3261071d9527= fffce77784af2 100644 --- a/drivers/bus/ts-nbus.c +++ b/drivers/bus/ts-nbus.c @@ -109,8 +109,7 @@ static void ts_nbus_reset_bus(struct ts_nbus *ts_nbus) =20 values[0] =3D 0; =20 - gpiod_set_array_value_cansleep(8, ts_nbus->data->desc, - ts_nbus->data->info, values); + gpiod_multi_set_value_cansleep(ts_nbus->data, values); gpiod_set_value_cansleep(ts_nbus->csn, 0); gpiod_set_value_cansleep(ts_nbus->strobe, 0); gpiod_set_value_cansleep(ts_nbus->ale, 0); @@ -150,12 +149,11 @@ static int ts_nbus_read_byte(struct ts_nbus *ts_nbus,= u8 *val) */ static void ts_nbus_write_byte(struct ts_nbus *ts_nbus, u8 byte) { - struct gpio_descs *gpios =3D ts_nbus->data; DECLARE_BITMAP(values, 8); =20 values[0] =3D byte; =20 - gpiod_set_array_value_cansleep(8, gpios->desc, gpios->info, values); + gpiod_multi_set_value_cansleep(ts_nbus->data, values); } =20 /* --=20 2.43.0 From nobody Sat Oct 11 00:35:49 2025 Received: from mail-oi1-f171.google.com (mail-oi1-f171.google.com [209.85.167.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 066D1263F5E for ; Wed, 11 Jun 2025 20:18:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749673131; cv=none; b=PYhEHSPeQmMI6XZgTA0vqgQR4qIFFWrAfy7wK42gXkl8YeQHA+4PY5hIMLK+cbVXjDM23biIqXKfT0qJ4xC9gEPmXCHoZEGgI86T8YJISiYrIa6U3AqKLgavjbnczD/zMxkKEOUvWhZPAhZBdbzpIccUXWCeNJ+cApWpI4OuPJ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749673131; c=relaxed/simple; bh=X+l1siqRVwIi6D1PzhyWFvmI4xdYsdCpoCSsUZIeM9Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WTw34F5gM2nYmYL5etFKjgW9qijn5LDMAUnOdVxG4g1R6gBmJCP94cNARx+fyNvww8jEB8p7XY0Om6tQe423/Ui5ankp1urdBZ4eda0H3UdUNTkxQmNTftpMpCfUR8PeYnqTcQQPP9GIptOKkn5HE2Ua/safr3oW7e1QljSACoY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=l8KOkARZ; arc=none smtp.client-ip=209.85.167.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="l8KOkARZ" Received: by mail-oi1-f171.google.com with SMTP id 5614622812f47-400fa6eafa9so154078b6e.1 for ; Wed, 11 Jun 2025 13:18:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1749673129; x=1750277929; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=+/+rrjhna+/Vax4rD8HC3TVO3EBLeff26p2DbcJCfS4=; b=l8KOkARZZIiADfYr/w3lTJabzOUjgNLnsovDoJRBzYrweRADMUz3Tmy3dqzoJYwbdD 4dzko7K/8l4bF1gJAJOB9jlFrlDu28Dqz+fsX50/iVaPLTJ44ApPP0eIMCi8o8rDkyUy FEqAECmJIFIWWFlCCotHSB5bXG296hrFNi4+4HeOEmxwDpHk3CCutUpBC43uA+T1wiha DgAEbR4N8FIjizNec6yCRkhvExmL66YflvHp13VNGyLc8f0OSv48GibXw8tWDOuudy/g N9QO4Rxj45wf0sVwejwLx8ZSTk/lKEf68+U+02VZXQcIROQaQ2YmeE5EV70Ymr6sXIbn sUxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749673129; x=1750277929; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+/+rrjhna+/Vax4rD8HC3TVO3EBLeff26p2DbcJCfS4=; b=kRJoUlLWwQlIhpStiSwzw5aSuO9RtXY1zy2NQKQC++D72LlAmB24deQP57yOZygOHY 8PeOi+FpNLY0S37GYVRJV5qmqFFaJxhYsn/geelNrYMnLzw4elXvFxOt9CNeIZ6R9TXH K8530KdO8sX0le8lnmd+pg52lQ02X8fnJV/138tdzdtpkO+DRjcOH9fIOLhhY6AHSlAJ dUURPJw/e+taweGrL/cdxGPyYF9Ca/w5lnNga63pcL9zc3JNesY/3/qA6nc3EB0cR+6n xyz0ocOJ1UvX8mgVfR6+GQFJO9ghOugYcmh/LkD9VwS80ZVhuF8SoAJwXkcamC7vcPOq wP0w== X-Forwarded-Encrypted: i=1; AJvYcCX4z3aTVcYH28cV4yuTvoPrCvMlbi3Njut4+gcg3Af9D83jjLoU0T9t7gOApwg5A9ANsTlE1mV2AsqTJJY=@vger.kernel.org X-Gm-Message-State: AOJu0YydGTZYr7M/wY5bu/1VFheqagzKa68aZwTtW2QI2uyaEOQgCiMq WBNSUYGs8PaZGHz2bvEKHTOS9wI/XjPzQErSPzW0F5fEWcWHOknWzDD6ZMSJxrgpefY= X-Gm-Gg: ASbGncsUY/9D5uOu0MI+RpL6LG0zR6dDwzSViWURCcBDGUHGFPuxo9TavGFiOxYm5f8 keBCk7Z9mcq8wY/QYw8g6y2qL2cUcOj3YxnTvG1M0ePT+zuARRyFiHjNfDoz9ViAuscaCoeUn5G fYM76EisQYWkGiExs3E+nZTPFOiJXVDCxa3SBS1aiTjECcZ+6//lLvPCBNBn2v8x6GRxKNnnSg5 7xkYGGPRtth0gvCw9D2p0NHezVgg5bVv4BYUz9DilCoTw7GKn655gMfVfEwBTd3+yefvMuNP+W+ rNe9XRNDzK2ran28/ndS3ULAzZxKDVK1WGmx9e3MqCkZlJTr21M/KR3c0ExuXJ5ES/yh X-Google-Smtp-Source: AGHT+IGD+DufvyN+5hzy7lg7VM5lfJsR43tAUQCYEJ3xhmONm3bDhzEoWmouYj722aMk3p5q+QWyrQ== X-Received: by 2002:a05:6808:80a6:b0:406:6d79:49d2 with SMTP id 5614622812f47-40a5d14fa9emr3327936b6e.26.1749673129216; Wed, 11 Jun 2025 13:18:49 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:4753:719f:673f:547c]) by smtp.gmail.com with ESMTPSA id 5614622812f47-40a5d80d967sm467732b6e.4.2025.06.11.13.18.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jun 2025 13:18:47 -0700 (PDT) From: David Lechner Date: Wed, 11 Jun 2025 15:18:11 -0500 Subject: [PATCH v4 3/3] bus: ts-nbus: use bitmap_set_value8() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250611-gpio-set-array-helper-v4-3-fb86a9b499ab@baylibre.com> References: <20250611-gpio-set-array-helper-v4-0-fb86a9b499ab@baylibre.com> In-Reply-To: <20250611-gpio-set-array-helper-v4-0-fb86a9b499ab@baylibre.com> To: Sebastien Bourdelin , Arnd Bergmann , linux-arm-kernel@lists.infradead.org Cc: Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , David Lechner X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1852; i=dlechner@baylibre.com; h=from:subject:message-id; bh=X+l1siqRVwIi6D1PzhyWFvmI4xdYsdCpoCSsUZIeM9Y=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBoSeSY/IJ6nkRrANAy2h70ciXzsWX6tvkao1sxD 4OB69BklISJATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaEnkmAAKCRDCzCAB/wGP wANcB/wM1esoiB5PaiuSRQBoxKnk8REf7zJM4aV0H6/M2/3mbM0ehJVngqtwdJ0thNdO+U0LWG6 XdHZpt4wJR1rc00U1rqILg0nxcEbrpOJ06KpGyloyzjGzRnx/JNr6ZIzsdNFGh7juRM1HaD7h5Z t47OOLSzgr1s9sPy03/lg3kuOK6BKfkZy8h00F0HnfgzzSFvFKxBn7Z8Ct4jyCVpDiq4GaUwpej wH2z0XaWliiQPfYo5AB/bGlE2jcnSmAn5hleY65LDObf1MpSHQaUT8/GGXYZHO1Jnl8iGZvFYx+ 7212QTKdyNcP98xvaCHkgAobE2zpI7HZeiHiP/8C6jzd4AnQ X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Use bitmap_set_value8() instead of accessing the bitmap directly. Accessing the bitmap directly is not considered good practice. We now have a helper function that can be used instead, so let's use it. The bitmap has to be zero-initialized now to avoid a compiler warning since bitmap_set_value8() does read/modify/write rather than just the write that this is replacing. Suggested-by: Andy Shevchenko Signed-off-by: David Lechner --- v4 changes: - Fix typo s/get/set/ in commit message - Zero-initialize the bitmap to avoid compiler warning --- drivers/bus/ts-nbus.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/bus/ts-nbus.c b/drivers/bus/ts-nbus.c index b4c9308caf0647a3261071d9527fffce77784af2..17540034e64a4e591ea61b0b4ee= f86a2081b02f5 100644 --- a/drivers/bus/ts-nbus.c +++ b/drivers/bus/ts-nbus.c @@ -10,6 +10,7 @@ * TS-4600 SoM. */ =20 +#include #include #include #include @@ -105,9 +106,9 @@ static void ts_nbus_set_direction(struct ts_nbus *ts_nb= us, int direction) */ static void ts_nbus_reset_bus(struct ts_nbus *ts_nbus) { - DECLARE_BITMAP(values, 8); + DECLARE_BITMAP(values, 8) =3D { }; =20 - values[0] =3D 0; + bitmap_set_value8(values, byte, 0); =20 gpiod_multi_set_value_cansleep(ts_nbus->data, values); gpiod_set_value_cansleep(ts_nbus->csn, 0); @@ -149,9 +150,9 @@ static int ts_nbus_read_byte(struct ts_nbus *ts_nbus, u= 8 *val) */ static void ts_nbus_write_byte(struct ts_nbus *ts_nbus, u8 byte) { - DECLARE_BITMAP(values, 8); + DECLARE_BITMAP(values, 8) =3D { }; =20 - values[0] =3D byte; + bitmap_set_value8(values, byte, 8); =20 gpiod_multi_set_value_cansleep(ts_nbus->data, values); } --=20 2.43.0