From nobody Sat Oct 11 08:07:05 2025 Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 628F223ED68; Wed, 11 Jun 2025 08:49:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.207.212.93 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749631790; cv=none; b=eIOxLXriPPhWAPZvZpkGdny43rjW7z4XJdC4F5dXEeTbNUeWmSke6vgPb/hiBYWQvXD0OVh90d+pc7GYRiqev7jIwj1C8LUzyGT7uRcqgEzVSrgdtLfSRBledy6BRDvr3J70CfvvBANIQgIdBynS2xFmtLtVmz61/BrpcdDYZ/Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749631790; c=relaxed/simple; bh=QcyXPFcPfN14Q5mVuC3lAt6POPZJpQWvb+wyX6TiII8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=VYGR72+KSybR1XrG3pFxzlOXH8uj7KZb3P760Z5h6T6u2o20bJMuRU33Pf9S+96WlYrmmYnQYi10jhB42aZpsmhoEzUZ95ozt4QmAonSCeIq3EL0cDxTnYR5pYxHkPwF/FhNeYs8TSXrpYsBMZqBN5Igp16n2LFA9skEGcSxvag= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=6SetRcbr; arc=none smtp.client-ip=91.207.212.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="6SetRcbr" Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55B6maDR020329; Wed, 11 Jun 2025 10:49:35 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=selector1; bh= mpLBdpH7Q64UGulCvUH0/TRi7b8UYxTI3kawUDO4Z6Y=; b=6SetRcbrz6+zMLw6 LUG1latKt0nN7VxwJi6/OxNrHWF1tkAK2A8RSxBJIW4YklGZDWx6GG+txlI6ay5t ONQgnaCZwGX05tStuTvRp8+wxAitb0os0S67OEYiMCmMsklvRjBFH6jeluFYmAVA h1xk7C4q/hbVnFunhkxv0d47aoscLh55jX9b8PTvENqt7GVcLevH8UtVsa8iqU64 O9K7iw8Ch4ioIof8GMz/dgVOgKck+T1IN5x6dPGVkWrqirDr/x6okRHXdy9HhlQ+ uTX021dF5LFk1JhGEZuIEW/pzASNzBOnIhk69VLzJG/jS9hTON+tcjSt2c2EeRZz r8n26g== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 474aja8n4f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 11 Jun 2025 10:49:35 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id C584F4005C; Wed, 11 Jun 2025 10:48:51 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 70C4EAFF5E5; Wed, 11 Jun 2025 10:48:38 +0200 (CEST) Received: from localhost (10.252.5.102) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 11 Jun 2025 10:48:38 +0200 From: Benjamin Mugnier Date: Wed, 11 Jun 2025 10:48:30 +0200 Subject: [PATCH v3 1/4] media: i2c: vd55g1: Fix RATE macros not being expressed in bps Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250611-fix_vd55g1-v3-1-ef4ecf15ddbc@foss.st.com> References: <20250611-fix_vd55g1-v3-0-ef4ecf15ddbc@foss.st.com> In-Reply-To: <20250611-fix_vd55g1-v3-0-ef4ecf15ddbc@foss.st.com> To: Sakari Ailus , Sylvain Petinot , Mauro Carvalho Chehab CC: , , Benjamin Mugnier X-Mailer: b4 0.14.2 X-ClientProxiedBy: EQNCAS1NODE3.st.com (10.75.129.80) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-11_03,2025-06-10_01,2025-03-28_01 As a bit rate is expressed in bps, use MEGA instead of HZ_PER_MHZ. Signed-off-by: Benjamin Mugnier --- drivers/media/i2c/vd55g1.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/vd55g1.c b/drivers/media/i2c/vd55g1.c index 25e2fc88a0367bf6a28bb22d209323ace99299f2..78dd22d9cab03edf4ff3e5a301f= 8d045e930c997 100644 --- a/drivers/media/i2c/vd55g1.c +++ b/drivers/media/i2c/vd55g1.c @@ -129,8 +129,8 @@ #define VD55G1_FWPATCH_REVISION_MINOR 9 #define VD55G1_XCLK_FREQ_MIN (6 * HZ_PER_MHZ) #define VD55G1_XCLK_FREQ_MAX (27 * HZ_PER_MHZ) -#define VD55G1_MIPI_RATE_MIN (250 * HZ_PER_MHZ) -#define VD55G1_MIPI_RATE_MAX (1200 * HZ_PER_MHZ) +#define VD55G1_MIPI_RATE_MIN (250 * MEGA) +#define VD55G1_MIPI_RATE_MAX (1200 * MEGA) =20 static const u8 patch_array[] =3D { 0x44, 0x03, 0x09, 0x02, 0xe6, 0x01, 0x42, 0x00, 0xea, 0x01, 0x42, 0x00, --=20 2.25.1 From nobody Sat Oct 11 08:07:05 2025 Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10FCC19924D; Wed, 11 Jun 2025 09:57:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.132.182.106 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749635865; cv=none; b=A4vejpLgx8uLHI0tmsoQWjW3KfdzSRtOmt/p3XgbQ0WT/voQslceUci440gWFoQmzWJ78qtvAdJ3G02H0YcsbHhuz/p2YwYkc8wIbTbsJjnL7UeDJ9rBGnM3wYrS91K6P7Z5RIzCq+7hFG/IaLasdTgo3xB/bOuWAs/UUKkvgIo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749635865; c=relaxed/simple; bh=69Lk3vhK7kxM+f3aRs9NZGKK7v3SZWRNe334x64JVkU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=W+dCShu6JfZqg2hzlOZh3GsZrMDuN8vgnh9j18TsG9CaYyKv4tiBfsmsdOZXOO0iRJp4QsQ0Ok9QjL14Gg4cbn2D9SGM0dGIrigwwy8zvEFBDlzIjYGkuXr8E1nrNIqsxc16uqZYUhP8S02dNHzF51GCaEE29vfNtNFko5XM0vk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=tNLjHeWO; arc=none smtp.client-ip=185.132.182.106 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="tNLjHeWO" Received: from pps.filterd (m0369458.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55B72cwx022334; Wed, 11 Jun 2025 10:49:35 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=selector1; bh= PX/y7gliH4I8f98WoXqhCdSxGh4NTXeRFWxdmsiFQgw=; b=tNLjHeWOsEcuJkP0 QGVIzqQo+s3p90AcqAb9pXu2l96lq+i9U5xs4WlDReWVXSOXPe/Na7nKluffLuZW IV0V2hPcU7Y5Vy5ppbdOvIx0L6O6QPui0xQMhkSf5OukQyisuGpmk4zpsPPGtjwt t+a4ukNaLcrugDNl/ggskYFAWyprDF6aQhfcunz3obIOfj9Qji0F39oVOHd58PKq 7ITxSlHAVHZMeQ7lS/zpmpRcMt3orlgz3IwNhPc5wHsUSYxsk/zUORdJCcJmjC1m CpsD6iIA4TCkSYirETJrfeKmzOZmApzK64fM5b1p1frmgekk5YGSQAjk33pk0wB0 DJBMwA== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 474y056w4h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 11 Jun 2025 10:49:35 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id C606240087; Wed, 11 Jun 2025 10:48:51 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 6B469AFF26E; Wed, 11 Jun 2025 10:48:39 +0200 (CEST) Received: from localhost (10.252.5.102) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 11 Jun 2025 10:48:39 +0200 From: Benjamin Mugnier Date: Wed, 11 Jun 2025 10:48:31 +0200 Subject: [PATCH v3 2/4] media: i2c: vd55g1: Fix return code in vd55g1_enable_streams error path Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250611-fix_vd55g1-v3-2-ef4ecf15ddbc@foss.st.com> References: <20250611-fix_vd55g1-v3-0-ef4ecf15ddbc@foss.st.com> In-Reply-To: <20250611-fix_vd55g1-v3-0-ef4ecf15ddbc@foss.st.com> To: Sakari Ailus , Sylvain Petinot , Mauro Carvalho Chehab CC: , , Benjamin Mugnier X-Mailer: b4 0.14.2 X-ClientProxiedBy: EQNCAS1NODE3.st.com (10.75.129.80) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-11_03,2025-06-10_01,2025-03-28_01 Enable stream was returning success even if an error occurred, fix it by modifying the err_rpm_put return value to -EINVAL. Signed-off-by: Benjamin Mugnier --- drivers/media/i2c/vd55g1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/vd55g1.c b/drivers/media/i2c/vd55g1.c index 78dd22d9cab03edf4ff3e5a301f8d045e930c997..336dc3c85ac9e695f22aa524e0d= f6138dc76e45c 100644 --- a/drivers/media/i2c/vd55g1.c +++ b/drivers/media/i2c/vd55g1.c @@ -1084,7 +1084,7 @@ static int vd55g1_enable_streams(struct v4l2_subdev *= sd, =20 err_rpm_put: pm_runtime_put(sensor->dev); - return 0; + return -EINVAL; } =20 static int vd55g1_disable_streams(struct v4l2_subdev *sd, --=20 2.25.1 From nobody Sat Oct 11 08:07:05 2025 Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35EB123AB9C; Wed, 11 Jun 2025 09:51:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.132.182.106 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749635477; cv=none; b=m+UBp71LlthcVE/cbmlNGXXHTAiXlOmGeFrfInA+sewkt84507+gYrn/FQ2jT2akNxpeYWGsCSv5GRu9Cr0TJb7IAsvk07QedymhlExGK2KLny0d4sGVCuDjD7bR6uUQRJ145OUvdlo9FHm4My6i4Kq+wKS51ik1fSg9DDP9U84= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749635477; c=relaxed/simple; bh=U4jGWHaIaMXuRCicMbs1PcoLZQJpE3+kZRirVXC12Bw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=RH69dA6ghpzhGKfbY6HOGMP3jVnUyjLQ4k7t3oQnYGdTaHaNq8yqY/i2nm452vivR2y8Y7HJEBZhYYrrFxQ9URqply9gceNHFK9ChdzbG3UIjCOG7xiG6CPhE75SU1Hqbo25tCUbG5JOUKg1PP9ywbCxjDFwe/KWU1IR0Mk0Yu4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=tqRRcgw5; arc=none smtp.client-ip=185.132.182.106 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="tqRRcgw5" Received: from pps.filterd (m0288072.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55B6Iv5f012912; Wed, 11 Jun 2025 10:49:38 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=selector1; bh= TV0Ykqz+yMv+EUoGBcc//ckZ5rwVDZ0YS3LKw7DDNAs=; b=tqRRcgw5gq6Na7K2 dWJ2gFSn7A40zkOd+PY4FM86BgEAUU0QGq3zvCf2mrn9d9ATFxh9YJZpPKQExB6f XETvYXAfy7+3uJ2MYT0on9gBuyBxtSeafwid/VpKIT88iotZJs9esbT1xbng1eTw xyqF5Owq2T0zutwa6RJW+3a5WqbGMIGs1Nclt18xUXmA6VxxCiZCejuSKaFDBODL /KDOYWWfAtLGwBVaA14ppfFT94RORbpEU/LZW54owDcl8oY0Bh2pQVLe1GWFxmeN PIjxG7yKmnqApa0mZFPp5VoWND45Us13Dl7UzhaoPiPYcVuDe8Djh172fOgpWTTw wNYs7A== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 474aumhngn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 11 Jun 2025 10:49:38 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id DB89840088; Wed, 11 Jun 2025 10:48:51 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 6ADD2AFE7D7; Wed, 11 Jun 2025 10:48:40 +0200 (CEST) Received: from localhost (10.252.5.102) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 11 Jun 2025 10:48:40 +0200 From: Benjamin Mugnier Date: Wed, 11 Jun 2025 10:48:32 +0200 Subject: [PATCH v3 3/4] media: i2c: vd55g1: Setup sensor external clock before patching Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250611-fix_vd55g1-v3-3-ef4ecf15ddbc@foss.st.com> References: <20250611-fix_vd55g1-v3-0-ef4ecf15ddbc@foss.st.com> In-Reply-To: <20250611-fix_vd55g1-v3-0-ef4ecf15ddbc@foss.st.com> To: Sakari Ailus , Sylvain Petinot , Mauro Carvalho Chehab CC: , , Benjamin Mugnier X-Mailer: b4 0.14.2 X-ClientProxiedBy: EQNCAS1NODE3.st.com (10.75.129.80) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-11_03,2025-06-10_01,2025-03-28_01 Proper clock configuration is required to advance through FSM states. Prior than this having a different clock value than default sensor's value was used (12 MHz) could prevent the sensor from booting. Signed-off-by: Benjamin Mugnier --- drivers/media/i2c/vd55g1.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/vd55g1.c b/drivers/media/i2c/vd55g1.c index 336dc3c85ac9e695f22aa524e0df6138dc76e45c..dec6e3e231d54a742bdd08ff2a5= 06c152bb89429 100644 --- a/drivers/media/i2c/vd55g1.c +++ b/drivers/media/i2c/vd55g1.c @@ -1038,8 +1038,6 @@ static int vd55g1_enable_streams(struct v4l2_subdev *= sd, if (ret < 0) return ret; =20 - vd55g1_write(sensor, VD55G1_REG_EXT_CLOCK, sensor->xclk_freq, &ret); - /* Configure output */ vd55g1_write(sensor, VD55G1_REG_MIPI_DATA_RATE, sensor->mipi_rate, &ret); @@ -1613,6 +1611,9 @@ static int vd55g1_power_on(struct device *dev) goto disable_clock; } =20 + /* Setup clock now to advance through system FSM states */ + vd55g1_write(sensor, VD55G1_REG_EXT_CLOCK, sensor->xclk_freq, &ret); + ret =3D vd55g1_patch(sensor); if (ret) { dev_err(dev, "Sensor patch failed %d\n", ret); --=20 2.25.1 From nobody Sat Oct 11 08:07:05 2025 Received: from mx08-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1546226188; Wed, 11 Jun 2025 08:49:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.207.212.93 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749631791; cv=none; b=o4l2LM4gj06MBP3zgW9M+tGa3GBjMz8rvjLZ6oLMO5sZXAXYByRLN3QRUG24UOpoCmgzSVgQ+Ma3WOPr20qPLXaI7z8Y+KfWKFX1fGAQUMJdeFr7tQiDOwTvXlcUuuLAgx+31kchtp2cldr5cfDwcbPb962QdwioSvqw30piMP8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749631791; c=relaxed/simple; bh=Yw0tSDhx4H5PFErf8hbWoAVIowk3O6olILFwOUlhlsg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=JEbVStL1PBV9aKK7vIvwuOw4kAwF4rJ5v4+0q4O78RLV8fuSP8lUPCshNaZk1uJg/mUl2t6h/HlyALhjmoO+QWeTt5IWP3/wY/6kGaCyaQ01QySrARKIAoJ6etiPD0QUesigmEHyQkIBL8tQF0PlWHhmjAP8QNXcOvRtzJREKY0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=ZUv3eQIo; arc=none smtp.client-ip=91.207.212.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="ZUv3eQIo" Received: from pps.filterd (m0369457.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55B8FXVc030672; Wed, 11 Jun 2025 10:49:35 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=selector1; bh= i3kIoHJXGkGuAMMHqDrHAUZaowwR9S+c63q8sx6H2l8=; b=ZUv3eQIoB4zoMOay nOsZpq7b4iVUzL0EusvBbR1d5EPJ6lbxMz6+NrbI1Nr8L64/4j1Iamnx9opo5H5W y4Ogd2JmKFjQm4Btwbi9QQfXgotnKrhClbXUpjyP8tGDnKwuyKQAk7X95GYR+Cf1 AqD+HbRHuDCZtmmaz0GB7fM1mWa0wtXtzrxQ9yAKFkKVIGt+51/zpdRgwaRD0UhZ LKPsZceoz85kecTeRTMtZol1TpSNrNQOJGWlTojTKxSmQt0RE7E7jW5m/7YfuJR+ wOJIEXmXQZiF2+01oCsqUt3f/E2Zo2OPT5Urj88vDd4jviDgUkXNHU7ZejBH0pIu pl8vLw== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 4750cnx3ph-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 11 Jun 2025 10:49:34 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 0A80C40089; Wed, 11 Jun 2025 10:48:52 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id BF3E3AFF5E4; Wed, 11 Jun 2025 10:48:41 +0200 (CEST) Received: from localhost (10.252.5.102) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 11 Jun 2025 10:48:41 +0200 From: Benjamin Mugnier Date: Wed, 11 Jun 2025 10:48:33 +0200 Subject: [PATCH v3 4/4] media: i2c: vd55g1: Use first index of mbus codes array as default Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20250611-fix_vd55g1-v3-4-ef4ecf15ddbc@foss.st.com> References: <20250611-fix_vd55g1-v3-0-ef4ecf15ddbc@foss.st.com> In-Reply-To: <20250611-fix_vd55g1-v3-0-ef4ecf15ddbc@foss.st.com> To: Sakari Ailus , Sylvain Petinot , Mauro Carvalho Chehab CC: , , Benjamin Mugnier X-Mailer: b4 0.14.2 X-ClientProxiedBy: EQNCAS1NODE3.st.com (10.75.129.80) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-11_03,2025-06-10_01,2025-03-28_01 Factorize code and prevent future errors in case of media bus codes change. Rename VD55G1_DEFAULT_MODE to VD55G1_MODE_DEF to mimic other macros and reduce vd55g1_update_img_pad_format() name to vd55g1_update_pad_fmt() to stay within the 80 characters limit. Signed-off-by: Benjamin Mugnier --- drivers/media/i2c/vd55g1.c | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/media/i2c/vd55g1.c b/drivers/media/i2c/vd55g1.c index dec6e3e231d54a742bdd08ff2a506c152bb89429..c0754fd03b1d5e947dc5e24e9f5= 4d98a67a23376 100644 --- a/drivers/media/i2c/vd55g1.c +++ b/drivers/media/i2c/vd55g1.c @@ -111,9 +111,9 @@ =20 #define VD55G1_WIDTH 804 #define VD55G1_HEIGHT 704 -#define VD55G1_DEFAULT_MODE 0 +#define VD55G1_MODE_DEF 0 #define VD55G1_NB_GPIOS 4 -#define VD55G1_MEDIA_BUS_FMT_DEF MEDIA_BUS_FMT_Y8_1X8 +#define VD55G1_MBUS_CODE_DEF 0 #define VD55G1_DGAIN_DEF 256 #define VD55G1_AGAIN_DEF 19 #define VD55G1_EXPO_MAX_TERM 64 @@ -883,10 +883,9 @@ static int vd55g1_apply_cold_start(struct vd55g1 *sens= or, return ret; } =20 -static void vd55g1_update_img_pad_format(struct vd55g1 *sensor, - const struct vd55g1_mode *mode, - u32 code, - struct v4l2_mbus_framefmt *fmt) +static void vd55g1_update_pad_fmt(struct vd55g1 *sensor, + const struct vd55g1_mode *mode, u32 code, + struct v4l2_mbus_framefmt *fmt) { fmt->code =3D code; fmt->width =3D mode->width; @@ -1229,8 +1228,8 @@ static int vd55g1_set_pad_fmt(struct v4l2_subdev *sd, width, height, sd_fmt->format.width, sd_fmt->format.height); =20 - vd55g1_update_img_pad_format(sensor, new_mode, sd_fmt->format.code, - &sd_fmt->format); + vd55g1_update_pad_fmt(sensor, new_mode, sd_fmt->format.code, + &sd_fmt->format); =20 /* * Use binning to maximize the crop rectangle size, and centre it in the @@ -1260,7 +1259,6 @@ static int vd55g1_set_pad_fmt(struct v4l2_subdev *sd, static int vd55g1_init_state(struct v4l2_subdev *sd, struct v4l2_subdev_state *sd_state) { - unsigned int def_mode =3D VD55G1_DEFAULT_MODE; struct vd55g1 *sensor =3D to_vd55g1(sd); struct v4l2_subdev_format fmt =3D { 0 }; struct v4l2_subdev_route routes[] =3D { @@ -1277,8 +1275,9 @@ static int vd55g1_init_state(struct v4l2_subdev *sd, if (ret) return ret; =20 - vd55g1_update_img_pad_format(sensor, &vd55g1_supported_modes[def_mode], - VD55G1_MEDIA_BUS_FMT_DEF, &fmt.format); + vd55g1_update_pad_fmt(sensor, &vd55g1_supported_modes[VD55G1_MODE_DEF], + vd55g1_mbus_codes[VD55G1_MBUS_CODE_DEF].code, + &fmt.format); =20 return vd55g1_set_pad_fmt(sd, sd_state, &fmt); } --=20 2.25.1