From nobody Sat Oct 11 08:30:44 2025 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54B4F2836A3 for ; Wed, 11 Jun 2025 12:54:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749646463; cv=none; b=o35NZ7dDChcGhLSiZYksOZVFpI+MB/v1oho+/4Ne72C2f0g/A8F3G0BLTddw/ZTMwdcvXFblhuqowGrCiX6rL2qIZmyelS2tKj28Ug7KCA0lL93dDyhBtLX2gC2Bcdxd+yj2vTANF/9eNpEyS9+AtM03UWHfeIveZgvCU8Lvhnw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749646463; c=relaxed/simple; bh=ojLJe2tP2Vz209foMJ0Lu2S+h70I7DXs1+HhM6dEcXA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DoaeW/gycKhE/JwW1eJUnvBbMm48yeB/haFpkH0rBzGhBrYmeUSwhsGCuqfi2J/UqlfRkYjKKI8dUinW5fBS20l021mWg8+xMCIlc/g8x34jHyEHXv8KHll9cRY+7YHle4s/DmcGGxLMhZcdhHBb+ULkbTfbtgzcHqBt8Wcx0nI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=yaSyfnk7; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="yaSyfnk7" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-451d54214adso54704985e9.3 for ; Wed, 11 Jun 2025 05:54:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1749646458; x=1750251258; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=HFpwfaBk9Zi/05ZHLg2kQwpAQr276eZe2gpjdnyEXsw=; b=yaSyfnk7IcLtQf6x/rBb729BUr+rJVcN0iujnb4SaNdwMdoTUnC7uuH8keqXn5b1wS affppTOMaHLH/yzIYDjkF3cz9oeBLAPy5bOKyW/siNR/wB8V1SU1pKuYHXMhYuK+EBGj 8SwP8lCE27gs40RmLPKucDbURwbqVzgQCNHB5toc56CS7NK+iq2tt9XWeqsAxuNyFY+v YIapGvWlO7cmcR7X5/BsIb9PWyeLNPqc/bOGLWLDZwM/tvMg7Pw+tEXENDPr0XFjRkUH 6m4hDFAtWY3dYYXbJoMbMxTOdEbVWwqj0imf+1M3hY5b5NgLRhVtIuDiJjDchNj62KVG JuEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749646458; x=1750251258; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HFpwfaBk9Zi/05ZHLg2kQwpAQr276eZe2gpjdnyEXsw=; b=Tn5mBFPbzplwm9S5Q53pyHjWGPskxmELEFeJZnH6ThNIXRouhRCrcdkiicvkK08klk FXMmU0MxbkMfGVxktw9r1fQfHbYHSR5ug7R8f5df1cHgLHzWBxOS2xaM6Ka+csthG1jW zWiPt3DPMqrCKQ37dPnY1DYFYiNusEouQsGaNFKNzAkaY0F6+z6C4/oL40ftywD1URNn oCLaw9y3m9ZKA3BaT7u/Zsp1rTHhVbfOlmKkAyx+LqDxCKn2mLtUJyK2heMK8HlJ0xae Yx/eNmGgVlE8qxdgR7VnNnr4DMn2a9Pt+f3gqVg+RoppWTbvkGzRZEoZ+eZIvPY4MFqJ xGkQ== X-Forwarded-Encrypted: i=1; AJvYcCUvDi+SXAmtvh+bhnrnbbt8P0p0bAiGXNn8kkBo8d7wcudJFXX8jeaWdNOEi2HA+ecdhhHFvb/CCVngjME=@vger.kernel.org X-Gm-Message-State: AOJu0YwgwUJW6figd3DXb9467QqsGtvxu305MZFA98vKcisQslitXCqO Kf8xifb9j85d3Im1fx+NXm0SZIDpoB51AYVz0GAnVQckd6mBDBwLqP+MhejKcPmEBhE= X-Gm-Gg: ASbGncuYtVml8AjHG8pxRponSQVQ3NBVjd3EW3hW6bMaSGPqkijyYlXAf0izb9XDoix 1jL+N6PyNHtQ3ncowjH9PQaFl8t30nMVZllkE/rvwrDprWTenToGfBei/aclGR5pcH+6GVhb2SZ VNS4L9GuqKgUVR0fJmOWzzmipx3rKtkR7PQrBLQLmmrUgkCvgUJ4bYLRm2gQWbPrRqPzOS8G1BT tz5ClG57w/+rUqckF1M9PRWEueuNXOMYTpWF0Yd6LLgt+1DfUoJRHKdn0R5s0BIVOfKL1WWhNxJ lFgQET2nAX9+OWeIkXggv8wCOdQqmNhfnW35DcYewYR/E2y1C3d9Ou1FWetWAS89DZd8ovDbqUe g8N/uZpDWr7s= X-Google-Smtp-Source: AGHT+IGIlwjD38JS//yUBEcvXlmN2huAOqXtp/YJa3YDrL38fHSYMCV1TEIKntX391ju7QlDra2xEA== X-Received: by 2002:a05:6000:2586:b0:3a4:d939:62f8 with SMTP id ffacd0b85a97d-3a5586cb2a6mr2093860f8f.32.1749646457670; Wed, 11 Jun 2025 05:54:17 -0700 (PDT) Received: from toaster.baylibre.com ([2a01:e0a:3c5:5fb1:8ef3:a82f:ccaa:91b5]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-3a53245275esm15225486f8f.76.2025.06.11.05.54.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jun 2025 05:54:17 -0700 (PDT) From: Jerome Brunet Date: Wed, 11 Jun 2025 14:53:58 +0200 Subject: [PATCH 3/4] clk: clk-imx8mp-audiomix: use the auxiliary device creation helper Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250611-clk-aux-v1-3-fb6575ed86a7@baylibre.com> References: <20250611-clk-aux-v1-0-fb6575ed86a7@baylibre.com> In-Reply-To: <20250611-clk-aux-v1-0-fb6575ed86a7@baylibre.com> To: Vladimir Kondratiev , Gregory CLEMENT , =?utf-8?q?Th=C3=A9o_Lebrun?= , Michael Turquette , Stephen Boyd , Philipp Zabel , Abel Vesa , Peng Fan , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Neil Armstrong , Kevin Hilman , Martin Blumenstingl Cc: linux-mips@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, Jerome Brunet X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2798; i=jbrunet@baylibre.com; h=from:subject:message-id; bh=ojLJe2tP2Vz209foMJ0Lu2S+h70I7DXs1+HhM6dEcXA=; b=owEBbQKS/ZANAwAKAeb8Dxw38tqFAcsmYgBoSXx0XZWnNZ1AgTV5+LghlbWYLZmdaCeetdFuI qp+F7j2WVaJAjMEAAEKAB0WIQT04VmuGPP1bV8btxvm/A8cN/LahQUCaEl8dAAKCRDm/A8cN/La hb16D/wP9KqqBEL7B0U8B0WK3yPhG6P25gSKeMgOS5rbf0shnJGcVbdMZrh5wm9fTchQpnEmZCz D2n4bKvAkLeTU4ydkqcJ269ydY7GRX313GINYYGI8Vg+zmRD8n52Kb7Stu2lxt/0RX81QLy/2vE UdgZmzXLrQ2p7vQFa+B/AAU02dJwd0jzeD6TTYstyr7Vt22QGmMBtRTl8MUiRbzFn0UTGfsNFxN wLGmBduWVn0u+WPHyEatcPAogHrnl78ggZsxkNmDNlLHJVlsjCYMKbOq4m2XV4NacsNVmG5G8dp GfaM8mfrSlogZpEL5Zbhz7PoJCcUjHf+NcnI35LMc53E30vHuphLQjdsUzJuDn3jsUO4FvCyUfA lom1Lz7f5BY4l3cojZXX+fHtCnp3Rjx736PDJxmvmXUNQM48ymIwr1jNh9XzYHP/6ZdnaTFXPT0 iLNQEC7PVi55LOyqA3Qh0Q4OTu0SXEL0Up0aCmi9hwUbtnsn8Hcnl2Ici1abYub+Us8WzOQVJT1 AeckT54HKRMGKNqpj/OQ4rMW8woe2BBCfkRgubAj13myhy1nI05lTUzV3LAtolCUdR3iSGT9htf iTexlX/QOC4yKNXuJoKwrB9N2TTIu2a9Jj0O/jNY3tem+RlQF7wWF88v6oSJ0sGAoHiCXLPtX8D rA4jtMmEVS0/N7w== X-Developer-Key: i=jbrunet@baylibre.com; a=openpgp; fpr=F29F26CF27BAE1A9719AE6BDC3C92AAF3E60AED9 The auxiliary device creation of this driver is simple enough to use the available auxiliary device creation helper. Use it and remove some boilerplate code. Signed-off-by: Jerome Brunet Reviewed-by: Frank Li --- drivers/clk/imx/clk-imx8mp-audiomix.c | 49 ++++++-------------------------= ---- 1 file changed, 8 insertions(+), 41 deletions(-) diff --git a/drivers/clk/imx/clk-imx8mp-audiomix.c b/drivers/clk/imx/clk-im= x8mp-audiomix.c index 775f62dddb11d8cfd17a4ebf7a677ef399c5e617..765fb1f5bd4fa2b039d7414abd8= 9471438ee41dd 100644 --- a/drivers/clk/imx/clk-imx8mp-audiomix.c +++ b/drivers/clk/imx/clk-imx8mp-audiomix.c @@ -230,61 +230,28 @@ struct clk_imx8mp_audiomix_priv { =20 #if IS_ENABLED(CONFIG_RESET_CONTROLLER) =20 -static void clk_imx8mp_audiomix_reset_unregister_adev(void *_adev) +static int clk_imx8mp_audiomix_reset_controller_register(struct device *de= v) { - struct auxiliary_device *adev =3D _adev; - - auxiliary_device_delete(adev); - auxiliary_device_uninit(adev); -} - -static void clk_imx8mp_audiomix_reset_adev_release(struct device *dev) -{ - struct auxiliary_device *adev =3D to_auxiliary_dev(dev); - - kfree(adev); -} - -static int clk_imx8mp_audiomix_reset_controller_register(struct device *de= v, - struct clk_imx8mp_audiomix_priv *priv) -{ - struct auxiliary_device *adev __free(kfree) =3D NULL; - int ret; + struct auxiliary_device *adev; =20 if (!of_property_present(dev->of_node, "#reset-cells")) return 0; =20 - adev =3D kzalloc(sizeof(*adev), GFP_KERNEL); + adev =3D devm_auxiliary_device_create(dev, "reset", NULL); if (!adev) - return -ENOMEM; - - adev->name =3D "reset"; - adev->dev.parent =3D dev; - adev->dev.release =3D clk_imx8mp_audiomix_reset_adev_release; - - ret =3D auxiliary_device_init(adev); - if (ret) - return ret; + return -ENODEV; =20 - ret =3D auxiliary_device_add(adev); - if (ret) { - auxiliary_device_uninit(adev); - return ret; - } - - return devm_add_action_or_reset(dev, clk_imx8mp_audiomix_reset_unregister= _adev, - no_free_ptr(adev)); + return 0; } =20 #else /* !CONFIG_RESET_CONTROLLER */ =20 -static int clk_imx8mp_audiomix_reset_controller_register(struct device *de= v, - struct clk_imx8mp_audiomix_priv *priv) +static int clk_imx8mp_audiomix_reset_controller_register(struct device *de= v) { return 0; } =20 -#endif /* !CONFIG_RESET_CONTROLLER */ +#endif =20 static void clk_imx8mp_audiomix_save_restore(struct device *dev, bool save) { @@ -408,7 +375,7 @@ static int clk_imx8mp_audiomix_probe(struct platform_de= vice *pdev) if (ret) goto err_clk_register; =20 - ret =3D clk_imx8mp_audiomix_reset_controller_register(dev, priv); + ret =3D clk_imx8mp_audiomix_reset_controller_register(dev); if (ret) goto err_clk_register; =20 --=20 2.47.2