From nobody Sat Oct 11 12:11:44 2025 Received: from out-180.mta0.migadu.com (out-180.mta0.migadu.com [91.218.175.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 856EC22B8A5; Tue, 10 Jun 2025 23:36:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749598611; cv=none; b=XxgW9j/rzU5JK0YrpOI+L53Sc16TUywBvUxlX+T5sqG6WYUYk65BwJTySgI6jpkhdpkJjyuIZz0QRPcJXZPY6L3/1jemymS/IlrjMMwNCestk5+6eBTy+A+rq2BslPVcnGJfUUFCPP5Nm2R4RGAZFREgDC4pAO4UpteEzNX8m6I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749598611; c=relaxed/simple; bh=kHWkJ5vN0DqrRwCNkI0qEg4WQoKQyw847+HTGAu+Rh4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=rv8I0tJm0eSADaDcYMv50l6sy0V2E91akq6yOT2fZjlv9PDKeL5kylnVSoJxmmFhikDGskIO6uq0ljscPp7t8Dv1ZybNHZCc3l/m5np0verC15ncVd9neE2EotB0zzFJlkCjzH6UAx2MC/AM6WOTwP5R1cOdbpFy24FWOD2F4AY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=aglHgGzC; arc=none smtp.client-ip=91.218.175.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="aglHgGzC" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1749598607; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0f+zwSuLYCy9Dl25vZBID+NIwmd7txRnqScklh0bo+U=; b=aglHgGzCED5YbwANTCrT3tsgpVZNJZLZk3IIxRjAQcrLXyQkewF4zTxZpf++vgJJmw+lj9 RkI3D/RpVro4SBVQcO1r9UQEWYZfM35g4kMfXYWUc2IaJJ/P6sNLx9UrJsteamocLxfu9C h6QOUNeBj77IGnKdJGLieJTsxtupPBI= From: Sean Anderson To: netdev@vger.kernel.org, Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King Cc: linux-kernel@vger.kernel.org, Daniel Golle , Simon Horman , Kory Maincent , Heiner Kallweit , Lei Wei , Christian Marangi , Vineeth Karumanchi , Sean Anderson , Claudiu Beznea , Nicolas Ferre Subject: [net-next PATCH v6 09/10] net: macb: Support external PCSs Date: Tue, 10 Jun 2025 19:36:42 -0400 Message-Id: <20250610233642.3588414-1-sean.anderson@linux.dev> In-Reply-To: <20250610233134.3588011-1-sean.anderson@linux.dev> References: <20250610233134.3588011-1-sean.anderson@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" This adds support for external PCSs. For example, the Xilinx UltraScale+ processor exposes its GMII interface to the FPGA fabric. This fabric may implement PCS to convert GMII to a serial interface such as SGMII or 1000BASE-X. When present, the external PCS takes precedence over the internal PCSs. Signed-off-by: Sean Anderson --- (no changes since v4) Changes in v4: - Convert to dev-less pcs_put Changes in v2: - Move update to macb_pcs_get_state to previous patch drivers/net/ethernet/cadence/macb.h | 1 + drivers/net/ethernet/cadence/macb_main.c | 26 ++++++++++++++++++++++-- 2 files changed, 25 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cad= ence/macb.h index c9a5c8beb2fa..9d310814f052 100644 --- a/drivers/net/ethernet/cadence/macb.h +++ b/drivers/net/ethernet/cadence/macb.h @@ -1291,6 +1291,7 @@ struct macb { struct phylink_config phylink_config; struct phylink_pcs phylink_usx_pcs; struct phylink_pcs phylink_sgmii_pcs; + struct phylink_pcs *phylink_ext_pcs; =20 u32 caps; unsigned int dma_burst_length; diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/etherne= t/cadence/macb_main.c index 78433d8f3746..cf7034c92672 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -21,6 +21,7 @@ #include #include #include +#include #include #include #include @@ -707,7 +708,10 @@ static struct phylink_pcs *macb_mac_select_pcs(struct = phylink_config *config, struct net_device *ndev =3D to_net_dev(config->dev); struct macb *bp =3D netdev_priv(ndev); =20 - if (interface =3D=3D PHY_INTERFACE_MODE_10GBASER) + if (bp->phylink_ext_pcs && + test_bit(interface, bp->phylink_ext_pcs->supported_interfaces)) + return bp->phylink_ext_pcs; + else if (interface =3D=3D PHY_INTERFACE_MODE_10GBASER) return &bp->phylink_usx_pcs; else if (interface =3D=3D PHY_INTERFACE_MODE_SGMII) return &bp->phylink_sgmii_pcs; @@ -733,7 +737,10 @@ static void macb_mac_config(struct phylink_config *con= fig, unsigned int mode, if (state->interface =3D=3D PHY_INTERFACE_MODE_RMII) ctrl |=3D MACB_BIT(RM9200_RMII); } else if (macb_is_gem(bp)) { - if (macb_mac_select_pcs(config, state->interface)) + struct phylink_pcs *pcs =3D macb_mac_select_pcs(config, + state->interface); + + if (pcs && pcs !=3D bp->phylink_ext_pcs) ctrl |=3D GEM_BIT(PCSSEL); else ctrl &=3D ~GEM_BIT(PCSSEL); @@ -907,6 +914,14 @@ static int macb_mii_probe(struct net_device *dev) bp->phylink_sgmii_pcs.ops =3D &macb_phylink_pcs_ops; bp->phylink_usx_pcs.ops =3D &macb_phylink_usx_pcs_ops; =20 + bp->phylink_ext_pcs =3D pcs_get_by_fwnode_optional(&bp->pdev->dev, + bp->pdev->dev.fwnode, + NULL); + if (IS_ERR(bp->phylink_ext_pcs)) + return dev_err_probe(&bp->pdev->dev, + PTR_ERR(bp->phylink_ext_pcs), + "Could not get external PCS\n"); + bp->phylink_config.dev =3D &dev->dev; bp->phylink_config.type =3D PHYLINK_NETDEV; bp->phylink_config.mac_managed_pm =3D true; @@ -924,6 +939,11 @@ static int macb_mii_probe(struct net_device *dev) __set_bit(PHY_INTERFACE_MODE_RMII, bp->phylink_config.supported_interfaces); =20 + if (bp->phylink_ext_pcs) + phy_interface_or(bp->phylink_config.supported_interfaces, + bp->phylink_config.supported_interfaces, + bp->phylink_ext_pcs->supported_interfaces); + /* Determine what modes are supported */ if (macb_is_gem(bp) && (bp->caps & MACB_CAPS_GIGABIT_MODE_AVAILABLE)) { bp->phylink_config.mac_capabilities |=3D MAC_1000FD; @@ -950,6 +970,7 @@ static int macb_mii_probe(struct net_device *dev) if (IS_ERR(bp->phylink)) { netdev_err(dev, "Could not create a phylink instance (%ld)\n", PTR_ERR(bp->phylink)); + pcs_put(bp->phylink_ext_pcs); return PTR_ERR(bp->phylink); } =20 @@ -5459,6 +5480,7 @@ static void macb_remove(struct platform_device *pdev) bp->rx_clk, bp->tsu_clk); pm_runtime_set_suspended(&pdev->dev); } + pcs_put(bp->phylink_ext_pcs); phylink_destroy(bp->phylink); free_netdev(dev); } --=20 2.35.1.1320.gc452695387.dirty