From nobody Sat Oct 11 08:07:05 2025 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 77B5823958C; Tue, 10 Jun 2025 21:35:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749591331; cv=none; b=C1C857LN7WDAcTfseqqBoIX90t2WxjcKofvEL+CjHQfi2cbhj+6fS5yjQug+kQgRqWDeDlS6+xvAiJ+3aelPdfifK55MpMkt2ybvAJY78O1Iqr4ZcGkOx3J7Y5jndYHDafJGqcqKxSrzvBiBILNHZWp81bw5rciZrRULs/6B3/c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749591331; c=relaxed/simple; bh=pCV5e9SgIfZkWF2C5ae5BFXAb7IvQC6jCuCk0AWF18M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=b5L3mNvwib5Y2VA+Y6OoXnG6Qq+02qc8UqtgkR6eLvlcwwq9m90X8fZuhoxEIjEHkx/ha1j9ijHN5IyOlpGJqLU/cLzec0T7g0cUohDvEHzzdwj/a89akblsMYu8gowAkDU1vLCGMrfOKs7bpIT6D6HPr76FALWzVyytQfLw52Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6A79B168F; Tue, 10 Jun 2025 14:35:09 -0700 (PDT) Received: from u103485.austin.arm.com (u103485.arm.com [10.118.30.35]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9432D3F66E; Tue, 10 Jun 2025 14:35:28 -0700 (PDT) From: Prachotan Bathi To: Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Stuart Yoder Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, Prachotan Bathi Subject: [PATCH v2 1/1] tpm_crb_ffa: handle tpm busy return code Date: Tue, 10 Jun 2025 16:35:05 -0500 Message-ID: <20250610213505.3881352-2-prachotan.bathi@arm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250610213505.3881352-1-prachotan.bathi@arm.com> References: <20250610213505.3881352-1-prachotan.bathi@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Platforms supporting direct message request v2 can support SPs that support multiple services. If the TPM service is sharing the SP with another service, it could get an error code of BUSY if the other service is in process. This adds a parameterized variable (default 2000ms) that indicates the maximum time to keep retrying for. When the TPM service returns a BUSY error code, we sleep 50-100us before retrying again, until we are over the busy timeout. Signed-off-by: Prachotan Bathi --- drivers/char/tpm/tpm_crb_ffa.c | 78 +++++++++++++++++++++++----------- 1 file changed, 54 insertions(+), 24 deletions(-) diff --git a/drivers/char/tpm/tpm_crb_ffa.c b/drivers/char/tpm/tpm_crb_ffa.c index 4ead61f01299..122984e15971 100644 --- a/drivers/char/tpm/tpm_crb_ffa.c +++ b/drivers/char/tpm/tpm_crb_ffa.c @@ -10,6 +10,8 @@ #define pr_fmt(fmt) "CRB_FFA: " fmt =20 #include +#include +#include #include "tpm_crb_ffa.h" =20 /* TPM service function status codes */ @@ -178,6 +180,17 @@ int tpm_crb_ffa_init(void) } EXPORT_SYMBOL_GPL(tpm_crb_ffa_init); =20 +static unsigned int busy_timeout =3D 2000; +/** + * busy_timeout - Maximum time to retry before giving up on busy + * + * This parameter defines the maximum time in milliseconds to retry + * sending a message to the TPM service before giving up. + */ +module_param(busy_timeout, uint, 0644); +MODULE_PARM_DESC(busy_timeout, + "Maximum time to retry before giving up on busy"); + static int __tpm_crb_ffa_send_recieve(unsigned long func_id, unsigned long a0, unsigned long a1, @@ -191,34 +204,51 @@ static int __tpm_crb_ffa_send_recieve(unsigned long f= unc_id, =20 msg_ops =3D tpm_crb_ffa->ffa_dev->ops->msg_ops; =20 - if (ffa_partition_supports_direct_req2_recv(tpm_crb_ffa->ffa_dev)) { - memset(&tpm_crb_ffa->direct_msg_data2, 0x00, - sizeof(struct ffa_send_direct_data2)); + ktime_t start; + ktime_t stop; + + start =3D ktime_get(); + stop =3D ktime_add(start, ms_to_ktime(busy_timeout)); + + do { + if (ffa_partition_supports_direct_req2_recv(tpm_crb_ffa->ffa_dev)) { + memset(&tpm_crb_ffa->direct_msg_data2, 0x00, + sizeof(struct ffa_send_direct_data2)); =20 - tpm_crb_ffa->direct_msg_data2.data[0] =3D func_id; - tpm_crb_ffa->direct_msg_data2.data[1] =3D a0; - tpm_crb_ffa->direct_msg_data2.data[2] =3D a1; - tpm_crb_ffa->direct_msg_data2.data[3] =3D a2; + tpm_crb_ffa->direct_msg_data2.data[0] =3D func_id; + tpm_crb_ffa->direct_msg_data2.data[1] =3D a0; + tpm_crb_ffa->direct_msg_data2.data[2] =3D a1; + tpm_crb_ffa->direct_msg_data2.data[3] =3D a2; =20 - ret =3D msg_ops->sync_send_receive2(tpm_crb_ffa->ffa_dev, + ret =3D msg_ops->sync_send_receive2(tpm_crb_ffa->ffa_dev, &tpm_crb_ffa->direct_msg_data2); - if (!ret) - ret =3D tpm_crb_ffa_to_linux_errno(tpm_crb_ffa->direct_msg_data2.data[0= ]); - } else { - memset(&tpm_crb_ffa->direct_msg_data, 0x00, - sizeof(struct ffa_send_direct_data)); - - tpm_crb_ffa->direct_msg_data.data1 =3D func_id; - tpm_crb_ffa->direct_msg_data.data2 =3D a0; - tpm_crb_ffa->direct_msg_data.data3 =3D a1; - tpm_crb_ffa->direct_msg_data.data4 =3D a2; - - ret =3D msg_ops->sync_send_receive(tpm_crb_ffa->ffa_dev, - &tpm_crb_ffa->direct_msg_data); - if (!ret) - ret =3D tpm_crb_ffa_to_linux_errno(tpm_crb_ffa->direct_msg_data.data1); - } + if (!ret) + ret =3D tpm_crb_ffa_to_linux_errno(tpm_crb_ffa->direct_msg_data2.data[= 0]); + } else { + memset(&tpm_crb_ffa->direct_msg_data, 0x00, + sizeof(struct ffa_send_direct_data)); =20 + tpm_crb_ffa->direct_msg_data.data1 =3D func_id; + tpm_crb_ffa->direct_msg_data.data2 =3D a0; + tpm_crb_ffa->direct_msg_data.data3 =3D a1; + tpm_crb_ffa->direct_msg_data.data4 =3D a2; + + ret =3D msg_ops->sync_send_receive(tpm_crb_ffa->ffa_dev, + &tpm_crb_ffa->direct_msg_data); + if (!ret) + ret =3D tpm_crb_ffa_to_linux_errno(tpm_crb_ffa->direct_msg_data.data1); + } + // Check if the TPM service returned busy + if (ret =3D=3D -EBUSY) + pr_err("TPM says busy, trying again, value, ret: %d\n", + ret); + else + // If TPM did not return busy, we are done, exit the loop + break; + // Sleep for a short time before retrying to avoid busy looping + usleep_range(50, 100); + } while (ktime_before(ktime_get(), stop)); + // If we are here, we either got a valid response or we are over the busy= timeout =20 return ret; } --=20 2.43.0