From nobody Sat Oct 11 12:08:52 2025 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14C711E9905 for ; Tue, 10 Jun 2025 11:16:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749554207; cv=none; b=nUIJEMDpxincDlYV2Z3FW9BkygINnK6sJ+5TVZkUJ4X35U6IVThCZU3MkJEzCAjp6kgeOAEEVU8w2Or9kccElXvYq6/RA4GuJU8n26HWJgN8l7KZ3VJBv8+Y3PCgy/ObyhMi8RUJ9XxxHeArv5R80yec0HT4ItXvLZ4918c2vcE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749554207; c=relaxed/simple; bh=zDeUcuv0yIbt+CHEosHsPE/6OpchOeANXKzL+3pPZ5k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CPoJ/O79FZbHwNtQGnrOyd62RZCdtY//v60Iz4k/VMUPeHZODxcCjpsOOqICjl0B/gjtOKqMdxhsMADCGQNtayim/TQIeZAekMH34mm50+a7K2fLXnT/SxF9CzgNh5QPOsSp9cfDuq0iMnF8O2wcRJQhsRqyqpGaNV4un3Iq5QY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=AHOfRn2K; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AHOfRn2K" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-553644b8f56so4910874e87.1 for ; Tue, 10 Jun 2025 04:16:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749554204; x=1750159004; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DaisSQk71updXPXwWenQ0eCHUVGGjGQ9tauWhBJXRks=; b=AHOfRn2K352HHbttT5Z+D+yaoRH+pl23mWkGaVrmPF9XQR4JzyFwi3b/fTOsTmxwF7 9W8LWPlVJx6ubYiMoIzvkijlsDVDKHCjpAn3mucnMiJFYhDGh7uLqGSSZGE3ccTRSVsG 6AoFRduNmUnnNODVMcKrkuq0B+D+TR70ypXCyNG6mxDxNPle8Dq/9/ZgSDTs20muYBey M+ohTt6ooiKFv3gnmrHa3E7G3p6WKiOaDAioKQ9hjZcFCK6fTyaYlx6GJiAuZYtUL66F 6ob/q5GRukWsibxHcoLGYoWDyyCJCLjBk0GF1uZos5KbmiVd05jTDpzl6J0o2XjtK16r RcMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749554204; x=1750159004; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DaisSQk71updXPXwWenQ0eCHUVGGjGQ9tauWhBJXRks=; b=htmWrZBnHWqMwlufetcrkF6wJbqU95MZcaTWVVuX0CH+p6O0VQvx75HOoEWC2tvIwP H2MA8fozjlwK5k3RpzsDkp/Sh/8HC9uUZGWHPbt7W0wKWga88JMIRKPlBxrQqj1U1Kgl GUCde3bgz8CdkheEo/ZXyOfrWOWw9hMDTlD+DKk7R1LeoTjqC8IxiA1AKKZHtJHVsQ9C lEvRd2wWpk5Kq88vodl3GdQB43DZcQOA4YFk8GgPDYaORax6NLd1FFo2SKPh0xByMHer kgKFcOz8k6eMeIW/oYJlRSLgsqK7k0SXdJAtaXW3nZI64e8bBEvJu0km2d9ZrNhPbGIP M2oQ== X-Forwarded-Encrypted: i=1; AJvYcCVwvj+/AsGipkKHjNX4kCrlPgVGGtpV91M/TMxSnFwPL1rX12uwuFqV/c8w8w+mVNI7yugOxXZ8fryk3YM=@vger.kernel.org X-Gm-Message-State: AOJu0YzxxziCD7qSCFACTs7GBhn1TZXYu6M1MxwrG7fEUBxZZNDlGU7/ umIVfmhdoLgTnYlzme1sb/5moNg4C+oXD6E6qUxjevMdFCDYCJ1UhG4X5m80rs/1pDf9kDdgXBt WErtwmyw= X-Gm-Gg: ASbGnctm3uY0yO4OFjHmgRFiizmq3B92J7jCH4q86YTgLDQleAbITUuTAb8+TZnmDPh jMsXTEyDOeYZH7FHOTy1NmQI8v+GKqcw1f6ypotZv2z2aeuqMy+vCAds09m2vbYqjjULRoEX0Ce uE2vd7wmn/LJsQP2FsMQwdWbr88c97ELrXU9eaBnNq+mT62NM6mN5T6SJ+PcfDo8Mm8I5tpSkVU 4eW2JliLWwMHqas8beHCrhby7fr+Ytrejx+45k2WdoYvRlJQuH5qPoMxnveIyHXRd2RiDs5GTOl mr/f3yRY7uKpK963LnPEXJ7z75Rbg2RdmAhpxlwPIpsKRZnYRcGbETkbmcqrOcJLerGK2pKl87x ixwlVnXClhcvvAfH5wJlLF5GOHnA/72M9Edlv X-Google-Smtp-Source: AGHT+IFY3VnRE9UcSrBVBH5iOgtbkmizeDx0kmpdz4+rinUwu3zbjO++INcIj2dBpGSkxIptNQK/Jw== X-Received: by 2002:a05:6512:1318:b0:553:515a:5ebd with SMTP id 2adb3069b0e04-55394745ef6mr667032e87.8.1749554204142; Tue, 10 Jun 2025 04:16:44 -0700 (PDT) Received: from uffe-tuxpro14.. (h-178-174-189-39.A498.priv.bahnhof.se. [178.174.189.39]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55367722481sm1500146e87.126.2025.06.10.04.16.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 04:16:42 -0700 (PDT) From: Ulf Hansson To: linux-mmc@vger.kernel.org, Ulf Hansson Cc: Ricky Wu , linux-kernel@vger.kernel.org Subject: [PATCH 1/4] mmc: rtsx_usb_sdmmc: Fix error-path in sd_set_power_mode() Date: Tue, 10 Jun 2025 13:16:23 +0200 Message-ID: <20250610111633.504366-2-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250610111633.504366-1-ulf.hansson@linaro.org> References: <20250610111633.504366-1-ulf.hansson@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In the error path of sd_set_power_mode() we don't update host->power_mode, which could lead to an imbalance of the runtime PM usage count. Fix this by always updating host->power_mode. Signed-off-by: Ulf Hansson Acked-by: Ricky Wu --- drivers/mmc/host/rtsx_usb_sdmmc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mmc/host/rtsx_usb_sdmmc.c b/drivers/mmc/host/rtsx_usb_= sdmmc.c index d229c2b83ea9..8c35cb85a9c0 100644 --- a/drivers/mmc/host/rtsx_usb_sdmmc.c +++ b/drivers/mmc/host/rtsx_usb_sdmmc.c @@ -1029,9 +1029,7 @@ static int sd_set_power_mode(struct rtsx_usb_sdmmc *h= ost, err =3D sd_power_on(host); } =20 - if (!err) - host->power_mode =3D power_mode; - + host->power_mode =3D power_mode; return err; } =20 --=20 2.43.0 From nobody Sat Oct 11 12:08:52 2025 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0839C225A35 for ; Tue, 10 Jun 2025 11:16:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749554208; cv=none; b=P7kMQPNVJ6OxPCPaNdeMTX+2xS3smWr5yDrmAVUmIFoW3gt0F/PVJHl1IbvnsfRy9rtsb94fFMqW8GWYZxt3KnsGYHCwj+tf4BmUQJOUZ7axGdhWErVeD5KaGjOUXDjax2VkmlPRfxgbtaU6G6YBLgbf2OFj7f0T0fLRGSRvDXs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749554208; c=relaxed/simple; bh=wLLJmOQJ18uLKIlN2M5/WYRzh0iJEMOdjCRJqqaJhYc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qDF60pn8TaQGLolaMk/Hr6lS0I7KN84Nv8v31TnCb2RWoPSXma9J2fE9qcrIWU74WeuRSUnJAiuyvcYj8QcMJNGGTEk049tDy74vCs9H05Gq8/dmDD+VbnbeB6UOQ21XaP3iVYzki3dVqrs0o6Kz4GNlUkpGfnTvr8w4+mAW0zA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=jg7tMin0; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jg7tMin0" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-5534edc6493so5732336e87.1 for ; Tue, 10 Jun 2025 04:16:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749554205; x=1750159005; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wnN9sQ1yphiBQx4a25u6KZxAXJc9uNDdDG1dBOTP22E=; b=jg7tMin0YEmDGDyZKwBYm9HuBxAe14hARHx4C9Djb+h2Dc6aSdvkTJL464MJKN8w7u 6hRqytAQg3HPKOq/j20LPkSJNG0DVMIpqH4SUPyzzlg9AglUOAyWyL9AbAKwOMii/guZ KxStum5BVMMShgnzo7h+LOI6sYhubUXyUg2I7ZQI4nwFHXuesX40SWT/3yggnqurIfQY ai3miKs26pzfYpqfVGvfAvp1OZ8Iwpf65UwkF2CXrSBVT6oFcjJgCX/+IbMDHJRbVdkz JRLwWtxIvzLmLrRW9FfgyUmRD1kDtytSn+744CUWsP0ALMjYluo8X+v5YgqOOIt/sU9k F2Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749554205; x=1750159005; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wnN9sQ1yphiBQx4a25u6KZxAXJc9uNDdDG1dBOTP22E=; b=Fhljyhm2D4T7ofqXf68EEuIjgYd01p/gtxal7h/2Muo4jPqh4ZuVikQBZ991M8biqr AN8mHK4SN18N7fPmLivxpzIwwG5vRstjYbx9X4bOsRRdoScmcK8wB4geFAeKJClpJce9 8YwinZUu7j/3NU13Bg6sFVlEeQecBwO4eDdXD0/ztGmW0Eqc0qH453MF5OlGuxlMyi01 bCVNkQzX37HBVhdO2gthJDg8YdNA0hVQM8c5caOnlWmCpzh4drGzLqBx5swTEyJ4YEkm 4Aj9uNVUZiCVQMOZjlX33e3BtFa15omLrMcl8KqeYuakmnZN3VF03OCL3WOh4hOCqtkw dZvQ== X-Forwarded-Encrypted: i=1; AJvYcCXpbSXJ+lavYedwYf66mcEvDtT1Te7kzLopmCp8kktaAWFNTMG85j8sGLSYkGCiXrpJvk5O+pmVsu9ijqA=@vger.kernel.org X-Gm-Message-State: AOJu0YyemSFFg4bDswk4MOOR+lM8Sam/a5M+ZSZ246/8bZ3vLgSOWRtY VJqYM4cVLn+HqCHals02AkG1ATqPngbxC7FatVNZFQfF6EUTtAA3emTD6qXVGVtlqeI= X-Gm-Gg: ASbGnculfIjVitihQeYv77cr9eJmtwHFFamoTzh7cc0f4elP+nBC/fgE9HC0DsR24iR PZUzHk59RO+o48lIbAqTwu9hGCz67IclSh72LlXakya6SlzRr1PDA0+sfXemaD2dLdl9iBDFpYv ZdM7AShDKh3/t9eqkmKfIjEYC4BLccTuFmtrXC8SCslzaMJlLz0QkQG5/I1T4K/NKUZ/ZF02cdQ 3KfRGnpXeJT2xJmFtFhoG3UOkCxiaK0KYWnqZe7WnwfMWIEGwflkkxPbJrThvSJy5EfWX1wwAfV 45K+2n40/rY4j2U7oyyiO3lSty0MElbTqMYxzbYh8XckrX5VjZj0DDI3p09xcDklMkoxN/L6eQx 2cD3LBMpGrBBb/CNbI5+0KE6z3Q46hlIq5uK2 X-Google-Smtp-Source: AGHT+IGmpHd8lIlZVdZTjU5PAjkevrDkv0bWhCAiyYC16cFI40T3Wsvz/AvzpYrW0BRCpDYvuwv1wQ== X-Received: by 2002:ac2:53ac:0:b0:553:20f2:2e77 with SMTP id 2adb3069b0e04-55366e33a1emr3605992e87.55.1749554205189; Tue, 10 Jun 2025 04:16:45 -0700 (PDT) Received: from uffe-tuxpro14.. (h-178-174-189-39.A498.priv.bahnhof.se. [178.174.189.39]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55367722481sm1500146e87.126.2025.06.10.04.16.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 04:16:44 -0700 (PDT) From: Ulf Hansson To: linux-mmc@vger.kernel.org, Ulf Hansson Cc: Ricky Wu , linux-kernel@vger.kernel.org Subject: [PATCH 2/4] mmc: rtsx_usb_sdmmc: Print debug-messages at power-on/off errors Date: Tue, 10 Jun 2025 13:16:24 +0200 Message-ID: <20250610111633.504366-3-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250610111633.504366-1-ulf.hansson@linaro.org> References: <20250610111633.504366-1-ulf.hansson@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" It should be useful to know when we fail to power-on/off a card. Let's therefore print debug-messages when this happens. Signed-off-by: Ulf Hansson Acked-by: Ricky Wu --- drivers/mmc/host/rtsx_usb_sdmmc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/mmc/host/rtsx_usb_sdmmc.c b/drivers/mmc/host/rtsx_usb_= sdmmc.c index 8c35cb85a9c0..c204cdeaee3e 100644 --- a/drivers/mmc/host/rtsx_usb_sdmmc.c +++ b/drivers/mmc/host/rtsx_usb_sdmmc.c @@ -1023,10 +1023,14 @@ static int sd_set_power_mode(struct rtsx_usb_sdmmc = *host, =20 if (power_mode =3D=3D MMC_POWER_OFF) { err =3D sd_power_off(host); + if (err) + dev_dbg(sdmmc_dev(host), "power-off (err =3D %d)\n", err); pm_runtime_put_noidle(sdmmc_dev(host)); } else { pm_runtime_get_noresume(sdmmc_dev(host)); err =3D sd_power_on(host); + if (err) + dev_dbg(sdmmc_dev(host), "power-on (err =3D %d)\n", err); } =20 host->power_mode =3D power_mode; --=20 2.43.0 From nobody Sat Oct 11 12:08:52 2025 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC82F2857FB for ; Tue, 10 Jun 2025 11:16:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749554210; cv=none; b=gDaP5clXEfCe+0vSOBoamSSXgHIZlR9wLVEZGoJVrytTpyzs4u3B0F9GCdTuQjnIDPe+UXpMhGT9/hV2BBoegsU35mgsbWSbKs7+y7RBdeemUKd5C3VUk4nTkP8bN5nj7lXRlmCGCEVvUMFvlCXzpL8/SMUpUDJv+MrceNOE1R8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749554210; c=relaxed/simple; bh=Q2G+6qC4eXTH3lTxHkq3eblVciHhR4sMPJfXSbMcZXs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kXenE/TLh3DCELY/HLpnGCBH8audemOXSIwOYdO6chllbRkcxhpFKhf1q2lfQ98PwBIu21A+Csxc1FqJPX4qwzfkOVHErDHn6Anig5058cLg8gALNGr+BO6GGZXXi1JBRvEjvOTvn68QS4KY3EzXtc298fIwJB/WdvOOxOn3CCE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=K3Sbiz9/; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="K3Sbiz9/" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-5534edc6493so5732369e87.1 for ; Tue, 10 Jun 2025 04:16:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749554207; x=1750159007; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wb7O/WfyRrI7BVa8uAeHS7SpLGTdVUHqO49VpFjc3ic=; b=K3Sbiz9/ydJUT61nEBgHGRWgUAxRmf2A5lbQhaTtJ3lH25p2Xg+ObsJrhs0To3KtXj LVH5bQKcs0XdZ5Uv/2yE+lM8DT7qE8ExHJzFFpJ4qc1DiadOb1JPwlTjKv7Hem7Bgl5S Gxl7C6u0GMjYnrbEg3vTSNkJPKyt4yMP+lNYXSqtK1nCLKHbXkqWEP7Szp4EBPGCd/sB y8CMhov3xxpLh56a2mnbsu2DJ58eI9ORnvICrjxiT1bhR7FuuGgrK9DqjDxhMkM6PjIf dMTZJGForgji1gWABYdiNET59PUnn+XkzLlP/F/SRmNZqHKzhCnOvQp+SOdMj0cN8+cq LV3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749554207; x=1750159007; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wb7O/WfyRrI7BVa8uAeHS7SpLGTdVUHqO49VpFjc3ic=; b=oOnd6qQaSj+Y8EUeLWvfS59oCh2JwfaNe/t9IEDB1CRTa8K1NbwWbvJtDbYb4LgEZy 9b/yVOxqS1wiI4gVLE/oN0MZ2H2oXRZryrMp6TjBToqn2j9pv1NzjD0mQviTOey3c5xb 7iyzh9jr6lo9xe1ZpV2/5ZsYmGQJxL5DYi/PWJCC2ERbIOSuAqYveJd07/gR+6g42SCV LRPzgPTHs6WffIWDjfgPc61KtuWl48dDkrSM3JDR2wOHbVNOWqBDtD4Rcl5Qs9pTGjGC gB4wlu96caeneO9jrpBqMnF4+eWLdEyrXNzpj1ssta43uORH4WWK/zfHJmwtfB8ITGc3 nIqQ== X-Forwarded-Encrypted: i=1; AJvYcCWp6tJg7li6ZrA6BfJxzimSEw50czl/EG9j/945PEkEAzLO++eb/2idO4ku9/8/VX/1BEw/iez0oCzStb4=@vger.kernel.org X-Gm-Message-State: AOJu0YzMH/1Ka//RuuyNPM4DG500WKB6PjPl3s2wBb86X0sUWsNhQpN4 5Klf9vNUSzYr1++A1M7hJTNEJcvH6Bu1l/y47ivty2xXkVpdpPs984KUe7ZUF2jJsAk= X-Gm-Gg: ASbGncudcoTt7PJ+X/NfxCgNOblhcXA1+Tqqiwg51Shqfz6gbVcQukpNVZjHXvZz6vI 26VaSHxU8xrIyOq98op4ZxUYY9f2iCK4zYB+U3XqAcxaCs1ArjMnRkexAbpbOwVCtj5lXayEY0o lrzDAOhGYTaTki7edrDbmqNQJZgZ+jY4Qb+TURnXvVT/KQcipFpKghbdUQ+C+sk1k64ZS9+7f0W /S6DoSYbXzZ0wlQ8ZgCVlAj1o2e2e2SMkmgHgc/CGX+TM79g7L10HDpdC6nSMMwbF8dsUQLAbDN ueT096WxlQefPh1E+FTZ7lnZHYDhWfAINjeOJt6vyF9AqvbaxXEQbFTvDw+6DCGXRHIjfrlWhd3 lIPXbzh5Fh0yumJxRG5bfoKP8WJkch6UPNVWd X-Google-Smtp-Source: AGHT+IGcJjeSLPZhPYZFF9acT9CaBa+tleHeWD/nvlbTe8RESEGmC/LAyYSFCjwYD71GvdSbOrVrtw== X-Received: by 2002:a05:6512:3b82:b0:553:5e35:b250 with SMTP id 2adb3069b0e04-55366c0262bmr4758736e87.32.1749554207032; Tue, 10 Jun 2025 04:16:47 -0700 (PDT) Received: from uffe-tuxpro14.. (h-178-174-189-39.A498.priv.bahnhof.se. [178.174.189.39]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55367722481sm1500146e87.126.2025.06.10.04.16.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 04:16:45 -0700 (PDT) From: Ulf Hansson To: linux-mmc@vger.kernel.org, Ulf Hansson Cc: Ricky Wu , linux-kernel@vger.kernel.org Subject: [PATCH 3/4] mmc: rtsx_usb_sdmmc: Convert sd_set_power_mode() into void Date: Tue, 10 Jun 2025 13:16:25 +0200 Message-ID: <20250610111633.504366-4-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250610111633.504366-1-ulf.hansson@linaro.org> References: <20250610111633.504366-1-ulf.hansson@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The sdmmc_set_ios() is the only caller of sd_set_power_mode() and it ignores the return code. Let's therefore convert sd_set_power_mode() into a void function instead. Signed-off-by: Ulf Hansson Acked-by: Ricky Wu --- drivers/mmc/host/rtsx_usb_sdmmc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/rtsx_usb_sdmmc.c b/drivers/mmc/host/rtsx_usb_= sdmmc.c index c204cdeaee3e..af45bac019d2 100644 --- a/drivers/mmc/host/rtsx_usb_sdmmc.c +++ b/drivers/mmc/host/rtsx_usb_sdmmc.c @@ -1010,7 +1010,7 @@ static int sd_power_off(struct rtsx_usb_sdmmc *host) return sd_pull_ctl_disable_qfn24(ucr); } =20 -static int sd_set_power_mode(struct rtsx_usb_sdmmc *host, +static void sd_set_power_mode(struct rtsx_usb_sdmmc *host, unsigned char power_mode) { int err; @@ -1019,7 +1019,7 @@ static int sd_set_power_mode(struct rtsx_usb_sdmmc *h= ost, power_mode =3D MMC_POWER_ON; =20 if (power_mode =3D=3D host->power_mode) - return 0; + return; =20 if (power_mode =3D=3D MMC_POWER_OFF) { err =3D sd_power_off(host); @@ -1034,7 +1034,6 @@ static int sd_set_power_mode(struct rtsx_usb_sdmmc *h= ost, } =20 host->power_mode =3D power_mode; - return err; } =20 static int sd_set_timing(struct rtsx_usb_sdmmc *host, --=20 2.43.0 From nobody Sat Oct 11 12:08:52 2025 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4303628DEFD for ; Tue, 10 Jun 2025 11:16:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749554211; cv=none; b=uaKRnAgbY+GNlDJ47HR4BlFOR5YgeAc26tv73XQfKt93l9UuCrPlz2WoGsZWr/VycvUHsd2udPTCzlBkpYmhaG5/rhwAp1WWRsuIh0rKaHsSfe4bNRL7ZileSVtu01TiZb02EwcZUZZy56ChdUPBSJUKSgmeMEvkuRMxIcQTo3A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749554211; c=relaxed/simple; bh=RUnyAMGtHh+/vEL4sflSpEFAoSQObmIYvyugmKssooo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YRIqxrGqYXdm/tHNlN22+0YBRQSz/OLZzYmJiTiPK59EWMV6ooEb/ZxO/t6hNay+KlDx768lsBoGRK78ojZoLrBFzI26U/MhxjaV4B24OaWquO7vPui7nWWm+r/tWFPt1mNqP0EepmxGwsrWo+1z8InxwO0zdWpRCmYBrnQlY9k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fEj2Gubg; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fEj2Gubg" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-5534edc646dso5504869e87.1 for ; Tue, 10 Jun 2025 04:16:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749554208; x=1750159008; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GWS6iCfw+rN1nm0C9pkCk8oe46JcwKDDliTDyR8kmr0=; b=fEj2Gubg1GXhS1CkD/hOnUPCBm08bI3qFh3o/zUwJROXgMYYo+8o3hi8wYssqdjGLH V3bPoW7jN1eymaKUH0rTb3Ev+EY77Sbfcdbx8Iz4S8GvTtMcGsIdj7FvfXRCtg5QYyIm PHSpcRtGyH65gnsymHmoZVsNd2nF2TS7YgL5G5/ySbTyrZyyOxSV+7wsDjJPZVuXbMTz 3HOR6Wm2hkDdvjbJcf4xy20+3Se1Ew1ZQhB9sUwGuuJEKP2gXpMlahYU6F93XVD8kzNS J+qrDHigdjuHNxYgO98lpbUqHJLMoYVifCpE9tENjchJwwVZdqFiFEFuEPZMLind3jmv ULmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749554208; x=1750159008; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GWS6iCfw+rN1nm0C9pkCk8oe46JcwKDDliTDyR8kmr0=; b=HX8CFKIen7pbBoF6nGDUerXamasSmrs1A8Qy21UUA2TXQGl0BIplAzjCo6wJ70RkcL LhMqBPbuRrjZJtsrLjWvldDf2hw3RliGCo9c6mJiWNkxgYVOvTSxOMuzPNRkCes7SZtm fkcf+SNlq53SFsV7Zn7TyPMfZ4+2GzA78Mw0Qh+WLA5tRVbPdq8N0zZZeocCu4wLsV6j 1qfMIQoblt8ie9J1FMQabEKnGyde7BvsajfMMDVSZQZUFVbiMcWXWRlqIm9V9C8/V8kv sMC3Uks5GE57xIwlnazIm/wgkxuq/rH4G4Ojtxwdge4gVFlUNsgVgZzLPqcoTjke7qJk ymgA== X-Forwarded-Encrypted: i=1; AJvYcCV31ekIJQ7w7I/jlLJABDd6a2dS4RS8bb5KtWMEy2YrKRNF233T8fuRYoQxVL/F1f8irYwYvdZI7QDMIVk=@vger.kernel.org X-Gm-Message-State: AOJu0YxUWIvBigwmPmsfVl9Lzzt0jdAsxaQZSUWXoz+/OuV66Mr7gOV5 t7fhz188l/ppXPQjN5AUJrkc3eM/BIvEDqNVxX1ttfj17KB6msG97dzN3e77BagniwM= X-Gm-Gg: ASbGncvD33rBXeVMB6tTfZnANqC+zn7dMdhwLbeaUaEZQkio7e8/0W+tJLVGH36Ej9Z 8ZK6+M2LsDhNZ+hkdskTdvQjdJZkrkhvzuNgh5njy0UwxP/TzZ2tUxw26DhSKfcetXPmuTsNF9Y rJ8fZfZOGBmmNW3/nZ5rRVtV+e8L+ZW4w8Kb50OoSZqicUH8pd7aZJcpULyCtRtIk17w+HvPIWL aD8QnLUX8CQXfUOu2lUWbnk36bUPca0BGI/zTVubdDnIyoEFbGLo2+VqWxvvOxkulbMBrR4X5T+ 4lLu+RyKow6QDdaXGkTPc4I+D1KHdeFZJJXY2VKj2BcFVu9oWFi2WPZ8qY9+0b8HjEeNq5rOnGu 3PKF8tiCyh1qiIASV1iaFs3tZC6Zy889fm348 X-Google-Smtp-Source: AGHT+IHE+pv8n7aP2OaZM/clNWkmC54/7jafLxvDCyYVgdGlQISWH7wYhIrRa9Iq6Ak/oNlfAese7A== X-Received: by 2002:a05:6512:3e06:b0:553:291f:92d with SMTP id 2adb3069b0e04-55366c38ec2mr4260599e87.57.1749554208364; Tue, 10 Jun 2025 04:16:48 -0700 (PDT) Received: from uffe-tuxpro14.. (h-178-174-189-39.A498.priv.bahnhof.se. [178.174.189.39]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55367722481sm1500146e87.126.2025.06.10.04.16.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 04:16:47 -0700 (PDT) From: Ulf Hansson To: linux-mmc@vger.kernel.org, Ulf Hansson Cc: Ricky Wu , linux-kernel@vger.kernel.org Subject: [PATCH 4/4] mmc: rtsx_usb_sdmmc: Re-work the code in sd_set_power_mode() Date: Tue, 10 Jun 2025 13:16:26 +0200 Message-ID: <20250610111633.504366-5-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250610111633.504366-1-ulf.hansson@linaro.org> References: <20250610111633.504366-1-ulf.hansson@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" It's only at MMC_POWER_OFF and at MMC_POWER_UP when some operations must be carried out in sd_set_power_mode(). The code is a bit obfuscated in this regards. Let's convert it into a switch-case-clause to make this clear. Signed-off-by: Ulf Hansson Acked-by: Ricky Wu --- drivers/mmc/host/rtsx_usb_sdmmc.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/host/rtsx_usb_sdmmc.c b/drivers/mmc/host/rtsx_usb_= sdmmc.c index af45bac019d2..c1fdcc334c8f 100644 --- a/drivers/mmc/host/rtsx_usb_sdmmc.c +++ b/drivers/mmc/host/rtsx_usb_sdmmc.c @@ -1015,22 +1015,30 @@ static void sd_set_power_mode(struct rtsx_usb_sdmmc= *host, { int err; =20 - if (power_mode !=3D MMC_POWER_OFF) - power_mode =3D MMC_POWER_ON; - if (power_mode =3D=3D host->power_mode) return; =20 - if (power_mode =3D=3D MMC_POWER_OFF) { + switch (power_mode) { + case MMC_POWER_OFF: err =3D sd_power_off(host); if (err) dev_dbg(sdmmc_dev(host), "power-off (err =3D %d)\n", err); pm_runtime_put_noidle(sdmmc_dev(host)); - } else { + break; + + case MMC_POWER_UP: pm_runtime_get_noresume(sdmmc_dev(host)); err =3D sd_power_on(host); if (err) dev_dbg(sdmmc_dev(host), "power-on (err =3D %d)\n", err); + break; + + case MMC_POWER_ON: + case MMC_POWER_UNDEFINED: + break; + + default: + break; } =20 host->power_mode =3D power_mode; --=20 2.43.0