From nobody Sat Oct 11 12:06:59 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04705286D6E; Tue, 10 Jun 2025 09:21:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749547282; cv=none; b=ndVDdtw+rX99GOOfLBEH9m2ELos5w6A3ULhmEPBF9nFZRnlLKY0xPEmaH9K71V1IZqhSeGorJPSWKc+HuFWz+vWxxUgj5OJYTd/gixi/0az3Ur0Fq1BtW9hGw6sQc/E9+hhqacjFGWyLiFFAonusp/UHrRgoGCBRjxhvdRpnd9E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749547282; c=relaxed/simple; bh=9qX58byGaVE5TC80pB4FkJH3w0rPGDf+jM6tTKUJldY=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=RAXFRf60w0nhSgFCD0+Fd9EtOoxCAxWXM0vS39YU9qsOxPFywhCZLOzMcBKMVhn+bBYK2ut5TYYnluXXHixfuG7c6lAvgWMZOt05wMoV3REH82xkge1swct7FOAVjABi/87jk/T02gSHp6RAzLLakw6GOA1j1fdFUN6MTvdG1Bg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=L/eAfWB0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="L/eAfWB0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40538C4CEED; Tue, 10 Jun 2025 09:21:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749547279; bh=9qX58byGaVE5TC80pB4FkJH3w0rPGDf+jM6tTKUJldY=; h=From:To:Cc:Subject:Date:From; b=L/eAfWB0eiRAmbS3wXT2vU2KmwcsIhM1MuF1N4cZVUXDf72c6lIicvkPS0Rdh9bWW S5VmGigbz8B9wEAte/xShaaTGzTGLtHD3y/ZAnbMoLjW25ysoduGgs6hSHIgJhV7G2 awJ9KcECj3l0tFASanyH1XFUoQ35IJsImFl7Zrf6YBq37E+FS85tkebGWdrRsE1WLZ IHHNhgeZFWk32vNIO94muUvNmkPl63jhvsctg3SqSooAJCZjht5VKB0dHwXuf8xfwZ qNx8+2GINV81n0BwFQRik3pZdiOuWqz0LgSGN9fHPeAd9t3VOFkiNiwh+wGVei/Swl 71OanMRRNiFXw== From: Arnd Bergmann To: Jian Shen , Salil Mehta , Jijie Shao , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Nathan Chancellor Cc: Arnd Bergmann , Nick Desaulniers , Bill Wendling , Justin Stitt , Hao Lan , Guangwei Zhang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: [PATCH] hns3: work around stack size warning Date: Tue, 10 Jun 2025 11:21:08 +0200 Message-Id: <20250610092113.2639248-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann The hns3 debugfs functions all use an extra on-stack buffer to store temporary text output before copying that to the debugfs file. In some configurations with clang, this can trigger the warning limit for the total stack size: drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c:788:12: error: stack fr= ame size (1456) exceeds limit (1280) in 'hns3_dbg_tx_queue_info' [-Werror,-= Wframe-larger-than] The problem here is that both hns3_dbg_tx_spare_info() and hns3_dbg_tx_queue_info() have a large on-stack buffer, and clang decides to inline them into a single function. Annotate hns3_dbg_tx_spare_info() as noinline_for_stack to force the behavior that gcc has, regardless of the compiler. Ideally all the functions in here would be changed to avoid on-stack output buffers. Signed-off-by: Arnd Bergmann Reported-by: Arnd Bergmann --- drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c b/drivers/n= et/ethernet/hisilicon/hns3/hns3_debugfs.c index 4e5d8bc39a1b..97dc47eeb44c 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c @@ -580,8 +580,9 @@ static const struct hns3_dbg_item tx_spare_info_items[]= =3D { { "DMA", 17 }, }; =20 -static void hns3_dbg_tx_spare_info(struct hns3_enet_ring *ring, char *buf, - int len, u32 ring_num, int *pos) +static noinline_for_stack void +hns3_dbg_tx_spare_info(struct hns3_enet_ring *ring, char *buf, + int len, u32 ring_num, int *pos) { char data_str[ARRAY_SIZE(tx_spare_info_items)][HNS3_DBG_DATA_STR_LEN]; struct hns3_tx_spare *tx_spare =3D ring->tx_spare; --=20 2.39.5